1 2017-11-28T00:01:16  *** hellxcode has joined #bitcoin-core-dev
  2 2017-11-28T00:01:16  *** bule has quit IRC
  3 2017-11-28T00:03:23  *** jb55 has quit IRC
  4 2017-11-28T00:03:56  *** ghost43 has quit IRC
  5 2017-11-28T00:04:51  *** ghost43 has joined #bitcoin-core-dev
  6 2017-11-28T00:06:50  *** jb55 has joined #bitcoin-core-dev
  7 2017-11-28T00:08:19  *** archaeal_ has quit IRC
  8 2017-11-28T00:10:10  *** ghost43 has quit IRC
  9 2017-11-28T00:10:44  *** ghost43 has joined #bitcoin-core-dev
 10 2017-11-28T00:34:51  *** dqx__ has joined #bitcoin-core-dev
 11 2017-11-28T00:37:53  *** dqx_ has quit IRC
 12 2017-11-28T00:38:21  *** JamesAU has joined #bitcoin-core-dev
 13 2017-11-28T00:41:55  *** JamesAU_ has joined #bitcoin-core-dev
 14 2017-11-28T00:42:57  *** owowo has quit IRC
 15 2017-11-28T00:43:02  *** JamesAU has quit IRC
 16 2017-11-28T00:43:51  *** owowo has joined #bitcoin-core-dev
 17 2017-11-28T00:46:12  *** JamesAU_ has quit IRC
 18 2017-11-28T00:51:15  *** tigana has joined #bitcoin-core-dev
 19 2017-11-28T00:51:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 20 2017-11-28T00:57:13  *** dabura667 has joined #bitcoin-core-dev
 21 2017-11-28T00:58:11  *** dqx_ has joined #bitcoin-core-dev
 22 2017-11-28T00:58:43  *** tigana has quit IRC
 23 2017-11-28T00:59:46  *** Squidicuz has quit IRC
 24 2017-11-28T01:00:08  *** PaulCapestany has quit IRC
 25 2017-11-28T01:00:39  *** PaulCapestany has joined #bitcoin-core-dev
 26 2017-11-28T01:01:05  *** Squidicuz has joined #bitcoin-core-dev
 27 2017-11-28T01:01:24  *** DigitalDank has quit IRC
 28 2017-11-28T01:01:32  *** dqx__ has quit IRC
 29 2017-11-28T01:01:35  *** DigitalDank has joined #bitcoin-core-dev
 30 2017-11-28T01:01:40  *** victorSN has quit IRC
 31 2017-11-28T01:02:07  *** Ge0rges has quit IRC
 32 2017-11-28T01:03:43  *** JamesAU has joined #bitcoin-core-dev
 33 2017-11-28T01:03:47  *** Ge0rges has joined #bitcoin-core-dev
 34 2017-11-28T01:05:45  *** dqx_ has quit IRC
 35 2017-11-28T01:06:12  *** isis has quit IRC
 36 2017-11-28T01:08:41  *** jb55 has quit IRC
 37 2017-11-28T01:11:25  *** isis has joined #bitcoin-core-dev
 38 2017-11-28T01:13:56  *** mumux has quit IRC
 39 2017-11-28T01:15:33  *** DigitalDank has quit IRC
 40 2017-11-28T01:16:13  *** btcdrak has quit IRC
 41 2017-11-28T01:16:59  *** DigitalDank has joined #bitcoin-core-dev
 42 2017-11-28T01:20:44  *** Randolf has quit IRC
 43 2017-11-28T01:23:23  *** DigitalDank has quit IRC
 44 2017-11-28T01:24:07  *** quantbot has joined #bitcoin-core-dev
 45 2017-11-28T01:25:01  *** DigitalDank has joined #bitcoin-core-dev
 46 2017-11-28T01:31:08  *** hellxcode has quit IRC
 47 2017-11-28T01:32:36  *** hellxcode has joined #bitcoin-core-dev
 48 2017-11-28T01:33:28  *** DigitalDank has quit IRC
 49 2017-11-28T01:35:01  *** DigitalDank has joined #bitcoin-core-dev
 50 2017-11-28T01:37:36  *** hoge_ has joined #bitcoin-core-dev
 51 2017-11-28T01:38:30  *** hellxcode has quit IRC
 52 2017-11-28T01:38:53  *** hellxcode has joined #bitcoin-core-dev
 53 2017-11-28T01:41:21  *** nickler has quit IRC
 54 2017-11-28T01:46:06  *** Randolf has joined #bitcoin-core-dev
 55 2017-11-28T01:47:14  *** DigitalDank has quit IRC
 56 2017-11-28T01:48:23  *** DigitalDank has joined #bitcoin-core-dev
 57 2017-11-28T01:49:11  *** nickler has joined #bitcoin-core-dev
 58 2017-11-28T01:50:24  *** ekrion has quit IRC
 59 2017-11-28T01:53:58  *** DigitalDank has quit IRC
 60 2017-11-28T01:55:27  *** DigitalDank has joined #bitcoin-core-dev
 61 2017-11-28T01:57:54  *** Ylbam has quit IRC
 62 2017-11-28T02:00:13  *** Victorsueca has quit IRC
 63 2017-11-28T02:01:16  *** JamesAU has quit IRC
 64 2017-11-28T02:01:22  *** Victorsueca has joined #bitcoin-core-dev
 65 2017-11-28T02:01:48  *** hellxcode has quit IRC
 66 2017-11-28T02:02:05  *** Emcy_ has joined #bitcoin-core-dev
 67 2017-11-28T02:02:11  *** hellxcode has joined #bitcoin-core-dev
 68 2017-11-28T02:04:49  *** Emcy has quit IRC
 69 2017-11-28T02:09:50  *** DigitalDank has quit IRC
 70 2017-11-28T02:11:33  *** DigitalDank has joined #bitcoin-core-dev
 71 2017-11-28T02:12:11  *** JamesAU has joined #bitcoin-core-dev
 72 2017-11-28T02:13:21  *** Chris_Stewart_5 has quit IRC
 73 2017-11-28T02:17:04  *** bule2 has quit IRC
 74 2017-11-28T02:17:22  *** bule2 has joined #bitcoin-core-dev
 75 2017-11-28T02:18:22  *** mr_burdell has quit IRC
 76 2017-11-28T02:20:34  *** mr_burdell has joined #bitcoin-core-dev
 77 2017-11-28T02:21:27  *** kallewoof has quit IRC
 78 2017-11-28T02:22:36  *** kallewoof has joined #bitcoin-core-dev
 79 2017-11-28T02:23:08  *** Emcy has joined #bitcoin-core-dev
 80 2017-11-28T02:24:17  *** justanotheruser has quit IRC
 81 2017-11-28T02:24:58  *** DigitalDank has quit IRC
 82 2017-11-28T02:25:46  *** Emcy_ has quit IRC
 83 2017-11-28T02:26:31  *** DigitalDank has joined #bitcoin-core-dev
 84 2017-11-28T02:26:52  *** justanotheruser has joined #bitcoin-core-dev
 85 2017-11-28T02:27:19  *** justanotheruser has joined #bitcoin-core-dev
 86 2017-11-28T02:29:04  *** wxss has quit IRC
 87 2017-11-28T02:32:02  *** DigitalDank has quit IRC
 88 2017-11-28T02:33:36  *** DigitalDank has joined #bitcoin-core-dev
 89 2017-11-28T02:33:43  *** brianhoffman_ has joined #bitcoin-core-dev
 90 2017-11-28T02:35:26  *** gmurf has joined #bitcoin-core-dev
 91 2017-11-28T02:35:57  *** brianhoffman has quit IRC
 92 2017-11-28T02:35:58  *** brianhoffman_ is now known as brianhoffman
 93 2017-11-28T02:37:32  *** Emcy_ has joined #bitcoin-core-dev
 94 2017-11-28T02:39:54  *** DigitalDank has quit IRC
 95 2017-11-28T02:39:59  *** Emcy has quit IRC
 96 2017-11-28T02:40:48  *** DigitalDank has joined #bitcoin-core-dev
 97 2017-11-28T02:41:54  <gmurf> any good places to learn how to use Bitcoin api
 98 2017-11-28T02:42:06  *** gmurf has quit IRC
 99 2017-11-28T02:51:06  *** DigitalDank has quit IRC
100 2017-11-28T02:52:31  *** DigitalDank has joined #bitcoin-core-dev
101 2017-11-28T02:58:47  *** DigitalDank has quit IRC
102 2017-11-28T03:00:03  *** DigitalDank has joined #bitcoin-core-dev
103 2017-11-28T03:03:03  *** hoge_ has quit IRC
104 2017-11-28T03:03:32  *** hoge_ has joined #bitcoin-core-dev
105 2017-11-28T03:06:33  *** DigitalDank has quit IRC
106 2017-11-28T03:06:51  *** hoge_ has quit IRC
107 2017-11-28T03:06:58  *** hoge_ has joined #bitcoin-core-dev
108 2017-11-28T03:07:12  *** goatpig has quit IRC
109 2017-11-28T03:08:07  *** DigitalDank has joined #bitcoin-core-dev
110 2017-11-28T03:10:09  *** jtimon has quit IRC
111 2017-11-28T03:10:43  *** Ehruv has joined #bitcoin-core-dev
112 2017-11-28T03:11:36  *** awright has joined #bitcoin-core-dev
113 2017-11-28T03:13:28  *** Ehruv has quit IRC
114 2017-11-28T03:16:52  *** DigitalDank has quit IRC
115 2017-11-28T03:17:34  *** DigitalDank has joined #bitcoin-core-dev
116 2017-11-28T03:23:02  *** awright has quit IRC
117 2017-11-28T03:24:15  *** DigitalDank has quit IRC
118 2017-11-28T03:25:14  *** DigitalDank has joined #bitcoin-core-dev
119 2017-11-28T03:27:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
120 2017-11-28T03:27:27  *** meshcollider has quit IRC
121 2017-11-28T03:32:01  *** DigitalDank has quit IRC
122 2017-11-28T03:32:26  *** DigitalDank has joined #bitcoin-core-dev
123 2017-11-28T03:38:38  *** DigitalDank has quit IRC
124 2017-11-28T03:40:14  *** DigitalDank has joined #bitcoin-core-dev
125 2017-11-28T03:45:14  *** wangyuan has joined #bitcoin-core-dev
126 2017-11-28T03:47:28  *** hoge_ has quit IRC
127 2017-11-28T03:47:29  *** DigitalDank has quit IRC
128 2017-11-28T03:47:59  *** hoge_ has joined #bitcoin-core-dev
129 2017-11-28T03:48:57  *** DigitalDank has joined #bitcoin-core-dev
130 2017-11-28T03:52:03  *** shesek has quit IRC
131 2017-11-28T03:52:12  *** hoge_ has quit IRC
132 2017-11-28T03:56:39  *** BRokq has joined #bitcoin-core-dev
133 2017-11-28T03:59:16  *** JamesAU has quit IRC
134 2017-11-28T03:59:59  *** Chris_Stewart_5 has quit IRC
135 2017-11-28T04:00:47  *** JamesAU has joined #bitcoin-core-dev
136 2017-11-28T04:03:20  *** BRokq has quit IRC
137 2017-11-28T04:13:08  *** rusty has joined #bitcoin-core-dev
138 2017-11-28T04:13:31  <rusty> Latest master branch, bitcoind in regtest mode: bitcoind: validation.cpp:4203: void CheckBlockIndex(const Consensus::Params&): Assertion `(pindexFirstNeverProcessed != nullptr) == (pindex->nChainTx == 0)' failed.
139 2017-11-28T04:16:05  *** Emcy_ has quit IRC
140 2017-11-28T04:16:11  <rusty> Pretty sure that was a .bitcoind dir from an older bitcoind.
141 2017-11-28T04:16:57  *** Emcy has joined #bitcoin-core-dev
142 2017-11-28T04:36:41  *** archaeal has quit IRC
143 2017-11-28T04:46:32  *** JamesAU has quit IRC
144 2017-11-28T04:48:02  *** JamesAU has joined #bitcoin-core-dev
145 2017-11-28T04:48:20  *** JamesAU has joined #bitcoin-core-dev
146 2017-11-28T04:52:38  *** StopAndDecrypt has quit IRC
147 2017-11-28T04:53:17  *** StopAndDecrypt has joined #bitcoin-core-dev
148 2017-11-28T04:53:18  *** StopAndDecrypt has quit IRC
149 2017-11-28T04:53:18  *** StopAndDecrypt has joined #bitcoin-core-dev
150 2017-11-28T05:03:41  *** dabura667 has quit IRC
151 2017-11-28T05:08:04  *** hoge_ has joined #bitcoin-core-dev
152 2017-11-28T05:12:05  *** hoge_ has quit IRC
153 2017-11-28T05:14:04  *** StopAndDecrypt_ has joined #bitcoin-core-dev
154 2017-11-28T05:14:07  *** StopAndDecrypt has quit IRC
155 2017-11-28T05:18:58  *** JackH has quit IRC
156 2017-11-28T05:32:31  *** Sinclair6 has quit IRC
157 2017-11-28T05:47:02  <aj> rusty: hey, i can duplicate that
158 2017-11-28T05:48:17  *** bule has joined #bitcoin-core-dev
159 2017-11-28T05:50:12  *** ghost43 has quit IRC
160 2017-11-28T05:50:37  *** bule2 has quit IRC
161 2017-11-28T05:50:38  *** ghost43 has joined #bitcoin-core-dev
162 2017-11-28T05:57:04  <aj> rusty: try https://pastebin.com/QfjsEHFK to reproduce -- bug seems to be in validation.cpp::RewindBlockIndex where pindexIter->nTx or nChainTx gets set to 0, but not real sure what the fix should be
163 2017-11-28T05:59:06  *** btcdrak has joined #bitcoin-core-dev
164 2017-11-28T06:11:35  *** meshcollider has joined #bitcoin-core-dev
165 2017-11-28T06:12:27  *** rusty has quit IRC
166 2017-11-28T06:19:09  *** Leminer has quit IRC
167 2017-11-28T06:20:25  *** d9b4bef9 has quit IRC
168 2017-11-28T06:21:20  *** d9b4bef9 has joined #bitcoin-core-dev
169 2017-11-28T06:22:21  *** JamesAU has quit IRC
170 2017-11-28T06:24:31  *** windsok has quit IRC
171 2017-11-28T06:25:01  <wangyuan> test
172 2017-11-28T06:25:29  *** wangyuan has quit IRC
173 2017-11-28T06:26:57  *** JamesAU has joined #bitcoin-core-dev
174 2017-11-28T06:27:24  *** windsok has joined #bitcoin-core-dev
175 2017-11-28T06:27:24  *** windsok has joined #bitcoin-core-dev
176 2017-11-28T06:29:10  *** Victorsueca has quit IRC
177 2017-11-28T06:30:21  *** Victorsueca has joined #bitcoin-core-dev
178 2017-11-28T06:31:16  *** pgupta has joined #bitcoin-core-dev
179 2017-11-28T06:32:14  *** LeMiner has joined #bitcoin-core-dev
180 2017-11-28T06:32:35  *** JamesAU has quit IRC
181 2017-11-28T06:32:55  *** pgupta has quit IRC
182 2017-11-28T06:36:15  *** ghost43 has quit IRC
183 2017-11-28T06:37:00  *** ghost43 has joined #bitcoin-core-dev
184 2017-11-28T06:52:36  *** esotericnonsense is now known as triggered
185 2017-11-28T06:52:49  *** triggered is now known as esotericnonsense
186 2017-11-28T06:59:33  *** hoge_ has joined #bitcoin-core-dev
187 2017-11-28T07:06:14  *** JamesAU has joined #bitcoin-core-dev
188 2017-11-28T07:10:27  *** JamesAU has quit IRC
189 2017-11-28T07:12:18  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
190 2017-11-28T07:12:18  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
191 2017-11-28T07:13:30  <Varunram> rusty: aj: had the bugs  few days back, turned out to be exactly what rusty specified, there'd be another .bitcoin directory somewhere. Once I changed home directories, it went well
192 2017-11-28T07:16:53  <Varunram> bug*
193 2017-11-28T07:23:29  <aj> Varunram: yeah, i think it'd be triggered by an old regtest blockchain from before #11389 got merged
194 2017-11-28T07:23:32  <gribble> https://github.com/bitcoin/bitcoin/issues/11389 | Support having SegWit always active in regtest (sipa, ajtowns, jnewbery) by sipa · Pull Request #11389 · bitcoin/bitcoin · GitHub
195 2017-11-28T07:23:41  *** JamesAU has joined #bitcoin-core-dev
196 2017-11-28T07:24:51  <Varunram> aj: Thanks! I was looking for that commit, couldn't find it
197 2017-11-28T07:26:34  *** hellxcode has quit IRC
198 2017-11-28T07:40:43  <bitcoin-git> [bitcoin] laanwj closed pull request #11722: Switched sync.{cpp,h} to std threading primitives. (master...tjps_sync_antiboost) https://github.com/bitcoin/bitcoin/pull/11722
199 2017-11-28T07:41:04  *** bule has quit IRC
200 2017-11-28T07:41:28  *** bule has joined #bitcoin-core-dev
201 2017-11-28T07:41:53  <wumpus> I'm completely lost with regard to PRs once again - anything ready for merge?
202 2017-11-28T07:45:33  <jonasschnelli> wumpus: I think a lot of "unfinished" PRs right now...
203 2017-11-28T07:45:39  <wumpus> yes...
204 2017-11-28T07:45:43  *** fanquake has joined #bitcoin-core-dev
205 2017-11-28T07:45:53  <fanquake> A few that could probably just be closed as well
206 2017-11-28T07:46:20  <jonasschnelli> fanquake: BTW. Thanks for your awesome work on closing / pinging on PRs!
207 2017-11-28T07:46:23  <fanquake> wumpus probably lost in that wormhole from earlier :p
208 2017-11-28T07:46:31  <wumpus> yes thanks fanquake :)
209 2017-11-28T07:46:54  <fanquake> jonasschnelli I try and keep on top of it. Have been wanting to ask you about your place for the coredev-tech site. Saw you put it up on GH?
210 2017-11-28T07:47:32  <jonasschnelli> fanquake: Yeah, The site is ugly (but simple). jnewbery will probably do some changes for the NY meeting.
211 2017-11-28T07:47:48  <jonasschnelli> (Which you are very welcome to join)
212 2017-11-28T07:48:24  *** BashCo has quit IRC
213 2017-11-28T07:48:50  *** AaronvanW has joined #bitcoin-core-dev
214 2017-11-28T07:48:55  *** dabura667 has joined #bitcoin-core-dev
215 2017-11-28T07:49:06  <fanquake> jonasschnelli when is that, might see if I can come along? I'm waiting for a meetup down here heh
216 2017-11-28T07:49:48  <jonasschnelli> fanquake: Australia is on the list,.. :) I'm not sure about the NY one... you need to ask jnewbery. Not sure if the exact date stays.. Guess it's in March 18
217 2017-11-28T07:49:51  <jonasschnelli> Not announce yet
218 2017-11-28T07:50:59  <fanquake> jonasschnelli cool. Good chance to discuss any potential iOS development work as well.
219 2017-11-28T07:51:21  <aj> "next one in NYC the week of March 5th 2018"
220 2017-11-28T07:53:06  <jonasschnelli> aj: Thanks!
221 2017-11-28T07:53:27  <jonasschnelli> fanquake: Yeah. Though, I won't attend. Schedule-colision.
222 2017-11-28T07:54:42  <wumpus> this is what we should avoid: https://github.com/bitcoin/bitcoin/pull/11747   the person posts a straightforward two-line fix for an actual issue, when well-meaning but overly zealous review comments get them to refactor things in a questionable way resulting in much more discussion and doubt of correctness
223 2017-11-28T07:55:04  <fanquake> jonasschnelli no worries
224 2017-11-28T07:55:17  <wumpus> if something fixes a problem, please just utACK it, if you want to refactor it to your personal taste later then go ahead but that's not part of review
225 2017-11-28T07:55:59  <wumpus> now we have yet another PR that is stuck...
226 2017-11-28T07:56:01  <jonasschnelli> wumpus: indeed.
227 2017-11-28T07:57:01  <bitcoin-git> [bitcoin] fanquake closed pull request #9859: Make TestBlockValidity optional in CreateNewBlock (master...tbv-optional) https://github.com/bitcoin/bitcoin/pull/9859
228 2017-11-28T07:58:22  <fanquake> I've always wondered how best we could keep tracked of post merge nits/minor fixups. Maybe another tag that we can add to PRs post merge which have any todos remaining in the comments? Then occasionally someone can sweep through and "clean up" stuff.
229 2017-11-28T07:58:55  <wumpus> fanquake: I think MarcoFalke added the "up for grabs" tag for that
230 2017-11-28T07:58:56  <fanquake> If GitHub search was a bit better it mightn't be such as issue.
231 2017-11-28T07:59:14  <aj> commits that sweep through and clean up stuff are generally pretty painful though, aren't they?
232 2017-11-28T07:59:21  <wumpus> yes, they are
233 2017-11-28T07:59:29  <fanquake> wumpus I mean PRs that have been merged, but with outstanding todos. Rather than just abandoned. I guess they are somewhat the same.
234 2017-11-28T07:59:34  *** raheel_ has joined #bitcoin-core-dev
235 2017-11-28T07:59:53  <wumpus> fanquake: if they have important TODOs that warrants an issue of its own, if not, better to forget about it sometimes
236 2017-11-28T08:00:00  <wumpus> if no one cares to remember it
237 2017-11-28T08:00:03  <fanquake> Is it more painful than not having obvious fixes easily merged
238 2017-11-28T08:00:35  <raheel_> ?HELP
239 2017-11-28T08:00:40  <fanquake> wumpus fair enough. I guess they get picked up again eventually anyways.
240 2017-11-28T08:01:07  <wumpus> for criticial concerns with something that is merged always open an issue, that's what they're for
241 2017-11-28T08:01:10  <raheel_> I want to create wallet address in pphp
242 2017-11-28T08:01:19  <wumpus> raheel_: #bitcoin
243 2017-11-28T08:01:22  <raheel_> php
244 2017-11-28T08:01:37  <raheel_> any api ?
245 2017-11-28T08:01:47  <wumpus> raheel_, take this to #bitcoin
246 2017-11-28T08:01:55  <jonasschnelli> raheel_: this is the core dev channel, pleae use #bitcoin or #bitcoin-dev for your Q
247 2017-11-28T08:01:58  <wumpus> read the topic for a change
248 2017-11-28T08:02:13  <fanquake> Thoughts on #9754 ? This is the second or third time this PR has been opened, hasn't ever gotten any real discussion
249 2017-11-28T08:02:15  <gribble> https://github.com/bitcoin/bitcoin/issues/9754 | Change NULLFAIL => SIG_NULLFAIL. by richardkiss · Pull Request #9754 · bitcoin/bitcoin · GitHub
250 2017-11-28T08:02:23  <raheel_> hii
251 2017-11-28T08:03:08  <wumpus> fanquake: it seems it doesn't really bother anyone but him
252 2017-11-28T08:03:51  <fanquake> I think I'm just going to close it again.
253 2017-11-28T08:03:53  *** raheel_ has quit IRC
254 2017-11-28T08:04:47  <bitcoin-git> [bitcoin] fanquake closed pull request #9754: Change NULLFAIL => SIG_NULLFAIL. (master...feature/unify_sig_nullfail) https://github.com/bitcoin/bitcoin/pull/9754
255 2017-11-28T08:04:59  <fanquake> re ready to merge. Maybe #11647 if you wanted to verify the backports.
256 2017-11-28T08:05:00  <gribble> https://github.com/bitcoin/bitcoin/issues/11647 | 0.15: Backports by MarcoFalke · Pull Request #11647 · bitcoin/bitcoin · GitHub
257 2017-11-28T08:05:46  <wumpus> agree with closing, I see no way forward for that PR
258 2017-11-28T08:08:00  *** JackH has joined #bitcoin-core-dev
259 2017-11-28T08:10:15  *** BashCo has joined #bitcoin-core-dev
260 2017-11-28T08:11:53  <aj> wumpus, fanquake: maybe having a 'highfive' bot would be an interesting idea to pursue? (auto welcome new contributors, assign reviewers, complain about lacking tests, modifying unsafe code, etc) http://sarah.thesharps.us/2016/11/17/impact-of-bots-on-github-communities/
261 2017-11-28T08:12:31  <wumpus> I think we should add cfields's #11457 to high priority for review, to make sure his net refactoring work can move forward
262 2017-11-28T08:12:34  <gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
263 2017-11-28T08:13:34  <wumpus> aj: don't know about others, but I'm not really a fan of bots personally, they generate a lot of extra notification. We had a "pull tester" bot once, you know.
264 2017-11-28T08:14:01  <wumpus> I like how travis integration doesn't generate a message, just shows the status inline
265 2017-11-28T08:14:35  *** JamesAU has quit IRC
266 2017-11-28T08:14:42  *** victorSN has joined #bitcoin-core-dev
267 2017-11-28T08:14:51  *** JamesAU has joined #bitcoin-core-dev
268 2017-11-28T08:15:04  *** victorSN has quit IRC
269 2017-11-28T08:15:26  *** victorSN has joined #bitcoin-core-dev
270 2017-11-28T08:16:12  <aj> wumpus: no, didn't know. how was the "pull tester" different to travis now?
271 2017-11-28T08:16:24  <wumpus> it posted a message if the tests failed/passed
272 2017-11-28T08:16:42  <aj> wumpus: ah, so same idea, just differnt github hook?
273 2017-11-28T08:17:14  <wumpus> I guess so, it was a project specific solution. travis is generic
274 2017-11-28T08:17:59  *** Cogito_Ergo_Sum has quit IRC
275 2017-11-28T08:18:25  *** dabura667 has quit IRC
276 2017-11-28T08:18:37  *** dabura667 has joined #bitcoin-core-dev
277 2017-11-28T08:20:15  *** kabaum has quit IRC
278 2017-11-28T08:31:19  *** meshcollider has quit IRC
279 2017-11-28T08:35:56  *** bule has quit IRC
280 2017-11-28T08:37:41  *** dqx has quit IRC
281 2017-11-28T08:39:46  *** SopaXorzTaker has quit IRC
282 2017-11-28T08:40:38  *** SopaXorzTaker has joined #bitcoin-core-dev
283 2017-11-28T08:47:32  *** dqx has joined #bitcoin-core-dev
284 2017-11-28T08:48:51  <Provoostenator> Coveralls can be configured to post the result like Travis does and not leave comments.
285 2017-11-28T08:49:05  <Provoostenator> Maybe the other bots can be too.
286 2017-11-28T08:54:13  <wumpus> if so I have no problem with them
287 2017-11-28T08:58:31  <wumpus> aj: anyhow that article seems interesting
288 2017-11-28T09:08:58  *** AaronvanW has quit IRC
289 2017-11-28T09:15:49  *** JamesAU has quit IRC
290 2017-11-28T09:19:01  *** BogatMohogat has joined #bitcoin-core-dev
291 2017-11-28T09:22:05  *** kabaum has joined #bitcoin-core-dev
292 2017-11-28T09:26:26  *** promag has joined #bitcoin-core-dev
293 2017-11-28T09:30:21  *** promag has quit IRC
294 2017-11-28T09:34:06  *** JamesAU has joined #bitcoin-core-dev
295 2017-11-28T09:36:46  <bitcoin-git> [bitcoin] laanwj opened pull request #11781: Add `-debuglogfile` option (master...2017_11_logfile) https://github.com/bitcoin/bitcoin/pull/11781
296 2017-11-28T09:38:41  *** JamesAU has quit IRC
297 2017-11-28T09:39:35  *** rusty has joined #bitcoin-core-dev
298 2017-11-28T09:40:10  *** JamesAU has joined #bitcoin-core-dev
299 2017-11-28T09:42:54  *** timothy has joined #bitcoin-core-dev
300 2017-11-28T09:44:39  *** str4d has joined #bitcoin-core-dev
301 2017-11-28T09:48:55  *** BogatMohogat has quit IRC
302 2017-11-28T10:06:59  *** promag has joined #bitcoin-core-dev
303 2017-11-28T10:08:19  *** promag has quit IRC
304 2017-11-28T10:12:15  *** d9b4bef9 has quit IRC
305 2017-11-28T10:13:21  *** d9b4bef9 has joined #bitcoin-core-dev
306 2017-11-28T10:14:37  *** hoge_ has quit IRC
307 2017-11-28T10:14:40  *** meshcollider has joined #bitcoin-core-dev
308 2017-11-28T10:15:04  *** hoge_ has joined #bitcoin-core-dev
309 2017-11-28T10:19:58  *** hoge_ has quit IRC
310 2017-11-28T10:30:59  *** dabura667 has quit IRC
311 2017-11-28T10:31:03  *** AaronvanW has joined #bitcoin-core-dev
312 2017-11-28T10:31:28  *** BogatMohogat has joined #bitcoin-core-dev
313 2017-11-28T10:41:57  *** kabaum has quit IRC
314 2017-11-28T10:47:00  *** hoge_ has joined #bitcoin-core-dev
315 2017-11-28T10:52:15  *** str4d has quit IRC
316 2017-11-28T10:53:49  *** Lauda has quit IRC
317 2017-11-28T10:54:21  *** Lauda has joined #bitcoin-core-dev
318 2017-11-28T11:03:06  *** Victorsueca has quit IRC
319 2017-11-28T11:04:22  *** Victorsueca has joined #bitcoin-core-dev
320 2017-11-28T11:07:57  *** rusty has quit IRC
321 2017-11-28T11:08:23  *** btcdrak has quit IRC
322 2017-11-28T11:11:11  *** belcher has joined #bitcoin-core-dev
323 2017-11-28T11:12:25  *** shesek has joined #bitcoin-core-dev
324 2017-11-28T11:12:25  *** shesek has joined #bitcoin-core-dev
325 2017-11-28T11:12:50  <bitcoin-git> [bitcoin] laanwj opened pull request #11783: Fix shutdown in case of errors during initialization (master...2017_11_notify_callbacks_shutdown_crash) https://github.com/bitcoin/bitcoin/pull/11783
326 2017-11-28T11:12:56  *** promag has joined #bitcoin-core-dev
327 2017-11-28T11:39:45  *** AaronvanW has quit IRC
328 2017-11-28T11:42:07  *** AaronvanW has joined #bitcoin-core-dev
329 2017-11-28T11:46:43  *** jtimon has joined #bitcoin-core-dev
330 2017-11-28T11:46:43  *** promag has quit IRC
331 2017-11-28T11:47:03  *** promag has joined #bitcoin-core-dev
332 2017-11-28T12:01:34  *** JamesAU has quit IRC
333 2017-11-28T12:06:54  *** promag has quit IRC
334 2017-11-28T12:09:28  *** Dev0P has joined #bitcoin-core-dev
335 2017-11-28T12:11:55  <bitcoin-git> [bitcoin] laanwj closed pull request #11287: DRY config header inclusion (master...refactor/dry-config) https://github.com/bitcoin/bitcoin/pull/11287
336 2017-11-28T12:12:45  *** promag has joined #bitcoin-core-dev
337 2017-11-28T12:13:01  *** hoge_ has quit IRC
338 2017-11-28T12:33:58  *** meshcollider has quit IRC
339 2017-11-28T12:34:11  *** ghost43 has quit IRC
340 2017-11-28T12:34:51  *** ghost43 has joined #bitcoin-core-dev
341 2017-11-28T12:38:38  *** promag has quit IRC
342 2017-11-28T12:41:11  *** ula has joined #bitcoin-core-dev
343 2017-11-28T12:43:21  *** dqx has quit IRC
344 2017-11-28T12:45:09  *** promag has joined #bitcoin-core-dev
345 2017-11-28T12:46:46  <promag> wumpus: I'm going to test #11783 rebased with #11781
346 2017-11-28T12:46:48  <gribble> https://github.com/bitcoin/bitcoin/issues/11783 | Fix shutdown in case of errors during initialization by laanwj · Pull Request #11783 · bitcoin/bitcoin · GitHub
347 2017-11-28T12:46:49  <gribble> https://github.com/bitcoin/bitcoin/issues/11781 | Add `-debuglogfile` option by laanwj · Pull Request #11781 · bitcoin/bitcoin · GitHub
348 2017-11-28T12:48:19  <wumpus> thanks!
349 2017-11-28T12:51:59  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
350 2017-11-28T12:51:59  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
351 2017-11-28T12:54:02  *** JamesAU has joined #bitcoin-core-dev
352 2017-11-28T12:54:35  *** roadcrap has quit IRC
353 2017-11-28T12:55:31  *** hoge_ has joined #bitcoin-core-dev
354 2017-11-28T12:55:57  *** Guyver2 has joined #bitcoin-core-dev
355 2017-11-28T12:56:56  <promag> wumpus: bitcoind -debuglogfile=/foo/bar/bar.log doesn't crash without 11783
356 2017-11-28T12:57:40  <promag> > (currently this segfaults afterwards, but that is due to an unrelated problem introduced in #10286, see #11783)
357 2017-11-28T12:57:44  <gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
358 2017-11-28T12:57:45  <gribble> https://github.com/bitcoin/bitcoin/issues/11783 | Fix shutdown in case of errors during initialization by laanwj · Pull Request #11783 · bitcoin/bitcoin · GitHub
359 2017-11-28T12:57:56  <promag> doesn't segfault here
360 2017-11-28T12:59:29  *** JamesAU has quit IRC
361 2017-11-28T13:00:55  <wumpus> well that's good
362 2017-11-28T13:02:56  *** promag has quit IRC
363 2017-11-28T13:03:50  <wumpus> still happens here
364 2017-11-28T13:04:19  <wumpus> "src/bitcoind  -debuglogfile=/dfdf" is enough to reproduce it immediately
365 2017-11-28T13:10:11  *** nelruk has joined #bitcoin-core-dev
366 2017-11-28T13:11:34  *** promag has joined #bitcoin-core-dev
367 2017-11-28T13:12:14  <promag> wumpus: what I mean is that 11781 alone doesn't segfault, how could it segfault there?
368 2017-11-28T13:12:42  <wumpus> I don't know, maybe a subtle configuration difference?
369 2017-11-28T13:13:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
370 2017-11-28T13:14:54  *** promag has quit IRC
371 2017-11-28T13:18:17  <wumpus> backtrace: https://0bin.net/paste/s2wRk1OomkBcFp3j#3-RdKCqzohpsAOe3dBIjacEmEuu6fh6tgCa9E4FIxBS
372 2017-11-28T13:18:20  <gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
373 2017-11-28T13:18:21  *** hoge_ has quit IRC
374 2017-11-28T13:18:48  *** hoge_ has joined #bitcoin-core-dev
375 2017-11-28T13:19:20  *** JamesAU has joined #bitcoin-core-dev
376 2017-11-28T13:19:28  <wumpus> so it calls UnregisterValidationInterface(0) . I don't see how that could not segfault.
377 2017-11-28T13:20:28  *** Dev0P has quit IRC
378 2017-11-28T13:23:01  *** hoge_ has quit IRC
379 2017-11-28T13:26:23  *** JamesAU has quit IRC
380 2017-11-28T13:35:27  *** kabaum has joined #bitcoin-core-dev
381 2017-11-28T13:37:39  *** belcher has quit IRC
382 2017-11-28T13:37:40  *** photonclock_ has quit IRC
383 2017-11-28T13:43:27  *** Chris_Stewart_5 has quit IRC
384 2017-11-28T13:48:50  *** promag has joined #bitcoin-core-dev
385 2017-11-28T13:49:20  *** JamesAU has joined #bitcoin-core-dev
386 2017-11-28T13:49:51  <promag> wumpus: sorry my bad, forget to git checkout . after git reset HEAD~1
387 2017-11-28T13:53:52  *** JamesAU has quit IRC
388 2017-11-28T13:56:11  *** promag has quit IRC
389 2017-11-28T13:56:50  *** hoge_ has joined #bitcoin-core-dev
390 2017-11-28T14:00:13  *** Victorsueca has quit IRC
391 2017-11-28T14:01:23  *** Victorsueca has joined #bitcoin-core-dev
392 2017-11-28T14:07:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
393 2017-11-28T14:07:26  <wumpus> hah!
394 2017-11-28T14:10:20  *** nelruk has quit IRC
395 2017-11-28T14:18:17  *** BogatMohogat has quit IRC
396 2017-11-28T14:22:31  <wumpus> what would be a good functional test to add the -debuglogfile= test in? can create a new one but it seems kind of overkill
397 2017-11-28T14:23:08  *** laurentmt has joined #bitcoin-core-dev
398 2017-11-28T14:24:57  <wumpus> none itseems, I'll just create a new one
399 2017-11-28T14:29:41  *** cyber55 has quit IRC
400 2017-11-28T14:30:10  *** ghost43 has quit IRC
401 2017-11-28T14:31:03  *** ghost43 has joined #bitcoin-core-dev
402 2017-11-28T14:43:01  <Provoostenator> In an RPC test, how would I go about debugging why sync_mempools times out, after a succesful sendrawtransaction?
403 2017-11-28T14:44:57  <Provoostenator> See bumpfee.py in https://github.com/Sjors/bitcoin/tree/bumpfee-test-refactor
404 2017-11-28T14:45:30  *** victorSN has left #bitcoin-core-dev
405 2017-11-28T14:45:45  <Provoostenator> I don't think it's related to the minimum relay fee, as even a 0.1 BTC fee doesn't help.
406 2017-11-28T14:46:53  <Provoostenator> I probably broke something about the nodes in the test setup, but it would be nice if I can reveal some sort of P2P error message to get a clue what I broke.
407 2017-11-28T14:47:19  <Provoostenator> E.g. can I access log files of the test nodes?
408 2017-11-28T14:47:29  <wumpus> timeout problems are notoriously annoying to debug
409 2017-11-28T14:47:56  <wumpus> yes, you can, it prints the test directory at start
410 2017-11-28T14:48:03  <wumpus> inside that are the data directories for the nodes
411 2017-11-28T14:48:31  <wumpus> also pass --nocleanup to not clean up
412 2017-11-28T14:49:38  <Provoostenator> Ah yes, that's very useful.
413 2017-11-28T14:51:16  <wumpus> there's also test/functional/combine_logs.py to merge the test log with logs of multiple nodes
414 2017-11-28T14:51:26  <wumpus> (to show one timeline)
415 2017-11-28T14:51:56  *** Giszmo has quit IRC
416 2017-11-28T14:52:44  <Provoostenator> I'm seeing an AddToWallet entry in the logs for the node that created the transaction, but no obvious error messages after that related to propagating it to the other peer.
417 2017-11-28T14:53:20  <Provoostenator> The other node has a "got inv: tx" entry for the same tx
418 2017-11-28T14:53:44  *** Sinclair6 has joined #bitcoin-core-dev
419 2017-11-28T14:54:01  <Provoostenator> And no obvious error either.
420 2017-11-28T14:54:20  *** Giszmo has joined #bitcoin-core-dev
421 2017-11-28T14:55:01  <Provoostenator> mempool.dat is empty for the other node though
422 2017-11-28T14:58:37  *** kexkey has joined #bitcoin-core-dev
423 2017-11-28T15:00:26  *** jb55 has joined #bitcoin-core-dev
424 2017-11-28T15:04:52  *** photonclock_ has joined #bitcoin-core-dev
425 2017-11-28T15:15:11  *** ghost43 has quit IRC
426 2017-11-28T15:16:08  *** ghost43 has joined #bitcoin-core-dev
427 2017-11-28T15:26:07  <Provoostenator> So I’m looking for debut messages that might explain why a node receives a transaction, but doesn’t add it to its mempool.
428 2017-11-28T15:40:01  *** savak has joined #bitcoin-core-dev
429 2017-11-28T15:51:07  *** StopAndDecrypt_ has quit IRC
430 2017-11-28T15:51:17  *** StopAndDecrypt has joined #bitcoin-core-dev
431 2017-11-28T16:00:18  *** hoge_ has quit IRC
432 2017-11-28T16:01:56  *** archaeal has joined #bitcoin-core-dev
433 2017-11-28T16:10:50  <instagibbs> Provoostenator, you may have to set debug=p2p, if you haven't yet
434 2017-11-28T16:16:59  *** msvr has joined #bitcoin-core-dev
435 2017-11-28T16:22:17  *** jb55 has quit IRC
436 2017-11-28T16:23:49  *** JackH has quit IRC
437 2017-11-28T16:36:47  *** JackH has joined #bitcoin-core-dev
438 2017-11-28T16:39:35  *** LumberCartel has joined #bitcoin-core-dev
439 2017-11-28T16:41:52  *** Randolf has quit IRC
440 2017-11-28T16:49:50  *** msvr has quit IRC
441 2017-11-28T16:54:19  *** LumberCartel has quit IRC
442 2017-11-28T16:54:52  *** wxss has joined #bitcoin-core-dev
443 2017-11-28T17:01:15  *** Victorsueca has quit IRC
444 2017-11-28T17:02:37  *** Victorsueca has joined #bitcoin-core-dev
445 2017-11-28T17:04:32  *** kabaum has quit IRC
446 2017-11-28T17:06:31  *** bule has joined #bitcoin-core-dev
447 2017-11-28T17:07:08  *** Chris_Stewart_5 has quit IRC
448 2017-11-28T17:13:30  *** quantbot_ has joined #bitcoin-core-dev
449 2017-11-28T17:14:33  *** laurentmt has quit IRC
450 2017-11-28T17:16:02  *** saint_ has joined #bitcoin-core-dev
451 2017-11-28T17:16:28  *** windsok has quit IRC
452 2017-11-28T17:16:28  *** savak has quit IRC
453 2017-11-28T17:16:52  *** quantbot has quit IRC
454 2017-11-28T17:19:37  *** windsok has joined #bitcoin-core-dev
455 2017-11-28T17:19:45  *** windsok has joined #bitcoin-core-dev
456 2017-11-28T17:22:48  *** XM has joined #bitcoin-core-dev
457 2017-11-28T17:39:50  *** timothy has quit IRC
458 2017-11-28T17:40:50  *** BashCo has quit IRC
459 2017-11-28T17:41:38  *** Randolf has joined #bitcoin-core-dev
460 2017-11-28T17:45:22  *** dqx has joined #bitcoin-core-dev
461 2017-11-28T17:46:15  *** jtimon has quit IRC
462 2017-11-28T17:49:13  *** btcdrak has joined #bitcoin-core-dev
463 2017-11-28T17:54:29  <Provoostenator> instagibbs: is that a flag to pass to the test node?
464 2017-11-28T17:58:35  <Provoostenator>   --tracerpc is quite useful too, although in this case it just shows that the second node's mempool is indeed empty every time sync_mempools looks at it
465 2017-11-28T18:00:02  *** Randolf has quit IRC
466 2017-11-28T18:02:18  <instagibbs> Provoostenator, yes, `debug=X` is the general purpose logging argument
467 2017-11-28T18:04:07  <Provoostenator> "<category> can be: net, tor, mempool, http, bench, zmq, db, rpc, estimatefee, addrman, selectcoins, reindex, cmpctblock, rand, prune, proxy, mempoolrej, libevent, coindb, qt, leveldb"
468 2017-11-28T18:04:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
469 2017-11-28T18:04:57  <instagibbs> oh sorry, so it's "net"
470 2017-11-28T18:06:50  *** timothy has joined #bitcoin-core-dev
471 2017-11-28T18:12:59  *** jb55 has joined #bitcoin-core-dev
472 2017-11-28T18:14:36  <Provoostenator> Ok, that seems to add a bit more detail. So the node which doesn't update its mempool log says: "received: inv (37 bytes) peer=1", "got inv: tx b4e9...f354  new peer=1"
473 2017-11-28T18:14:51  *** Randolf has joined #bitcoin-core-dev
474 2017-11-28T18:14:55  <Provoostenator> I'll turn on some more debug options...
475 2017-11-28T18:16:14  *** b71a48f9 has joined #bitcoin-core-dev
476 2017-11-28T18:16:59  *** b71a48f9 has quit IRC
477 2017-11-28T18:18:51  <sipa> there is also -debug=all
478 2017-11-28T18:22:31  *** BashCo has joined #bitcoin-core-dev
479 2017-11-28T18:30:51  *** Ylbam has joined #bitcoin-core-dev
480 2017-11-28T18:31:00  <Provoostenator> Even -debug-all doesn't tell me anything useful. Here's the combined log: https://gist.github.com/Sjors/f887722422f49144fe9b97cee9fef836
481 2017-11-28T18:32:00  <Provoostenator> Interestingly the same transaction (ca43...) is sent twice, even though only one test is run.
482 2017-11-28T18:38:22  <luke-jr> Provoostenator: -debug=all is not -debug-all
483 2017-11-28T18:40:15  <Provoostenator> luke-jr: that was a typo in IRC only.
484 2017-11-28T18:43:32  <Provoostenator> The test framework shows a warning if you use an unsupported debug category.
485 2017-11-28T19:12:46  *** laurentmt has joined #bitcoin-core-dev
486 2017-11-28T19:13:07  <MarcoFalke> nanotube: Where is the gribble code hosted that runs in this channel?
487 2017-11-28T19:13:20  <MarcoFalke> nanotube: https://github.com/nanotube/supybot-bitcoin-marketmonitor is only for the market, no?
488 2017-11-28T19:13:48  *** laurentmt has quit IRC
489 2017-11-28T19:17:35  *** tux3do has joined #bitcoin-core-dev
490 2017-11-28T19:17:53  *** tux3do has left #bitcoin-core-dev
491 2017-11-28T19:19:05  *** tux3do has joined #bitcoin-core-dev
492 2017-11-28T19:19:22  *** tux3do has left #bitcoin-core-dev
493 2017-11-28T19:31:05  <jonasschnelli> wumpus: Would it make sense to mention absolute paths are possibbe in #11781 (in the release notes or the init.cpp part)?
494 2017-11-28T19:31:07  <gribble> https://github.com/bitcoin/bitcoin/issues/11781 | Add `-debuglogfile` option by laanwj · Pull Request #11781 · bitcoin/bitcoin · GitHub
495 2017-11-28T19:31:35  <jonasschnelli> Only after reading the code I know it's possible (if (logfile.is_absolute()) {)
496 2017-11-28T19:31:43  <jonasschnelli> *knew
497 2017-11-28T19:32:02  <jonasschnelli> But maybe it's obvious
498 2017-11-28T19:37:24  *** wunpunch has joined #bitcoin-core-dev
499 2017-11-28T19:37:32  *** Emcy_ has joined #bitcoin-core-dev
500 2017-11-28T19:38:33  *** rusty has joined #bitcoin-core-dev
501 2017-11-28T19:39:57  *** blockchain has joined #bitcoin-core-dev
502 2017-11-28T19:40:15  *** Emcy has quit IRC
503 2017-11-28T19:41:13  <blockchain> hi I have installed bitcoin-core 15.01 and want to use the replace by fee. but the "increase transaction fee" option is grey, how can i activate it ?
504 2017-11-28T19:42:36  <jonasschnelli> blockchain: better use #bitcoin for this... off-topic here.
505 2017-11-28T19:42:51  <blockchain> ok didnt know where to ask
506 2017-11-28T19:46:47  *** marcoagner has joined #bitcoin-core-dev
507 2017-11-28T19:47:38  *** bule has quit IRC
508 2017-11-28T19:51:32  *** JamesAU has joined #bitcoin-core-dev
509 2017-11-28T19:51:35  *** jb55 has quit IRC
510 2017-11-28T19:52:18  *** ekrok_ has quit IRC
511 2017-11-28T19:54:41  *** JamesAU has quit IRC
512 2017-11-28T19:55:13  *** JamesAU has joined #bitcoin-core-dev
513 2017-11-28T19:59:14  *** PaulCapestany has quit IRC
514 2017-11-28T19:59:45  *** jtimon has joined #bitcoin-core-dev
515 2017-11-28T20:02:09  *** PaulCapestany has joined #bitcoin-core-dev
516 2017-11-28T20:04:19  *** bule has joined #bitcoin-core-dev
517 2017-11-28T20:06:21  *** laurentmt has joined #bitcoin-core-dev
518 2017-11-28T20:08:37  *** warxhead has joined #bitcoin-core-dev
519 2017-11-28T20:10:47  *** XM has quit IRC
520 2017-11-28T20:16:40  *** paveljanik has joined #bitcoin-core-dev
521 2017-11-28T20:16:41  *** paveljanik has joined #bitcoin-core-dev
522 2017-11-28T20:24:12  *** marcoagner has quit IRC
523 2017-11-28T20:27:46  *** Cheeseo has joined #bitcoin-core-dev
524 2017-11-28T20:32:33  *** cheese_ has joined #bitcoin-core-dev
525 2017-11-28T20:33:03  *** Giszmo has quit IRC
526 2017-11-28T20:35:52  *** Cheeseo has quit IRC
527 2017-11-28T20:37:31  *** marcoagner has joined #bitcoin-core-dev
528 2017-11-28T20:43:29  *** Masterboy has joined #bitcoin-core-dev
529 2017-11-28T20:46:04  <jonasschnelli> wumpus: every tried ODROID-XU4 with Core?
530 2017-11-28T20:46:43  <sipa> jonasschnelli: i'm syncing on an odroid-c2 currently
531 2017-11-28T20:47:26  <jonasschnelli> sipa: Oh. What storage?
532 2017-11-28T20:50:23  <sipa> 128 GB microsd card, pruned
533 2017-11-28T20:52:05  <jonasschnelli> sipa: okay. Happy to hear more... (sync speed, corruptions)
534 2017-11-28T20:52:16  *** DigitalDank has quit IRC
535 2017-11-28T20:53:00  <sipa> i just started maybe 10 hours ago
536 2017-11-28T20:53:12  <sipa> ask me again in a week :)
537 2017-11-28T20:53:46  <jonasschnelli> I'd say in 3 days. :)
538 2017-11-28T20:54:20  <Masterboy> jonasschnelli, sync speed is really bad on my core i3 pentium 300mbit connection
539 2017-11-28T20:54:37  <Masterboy> it took me days to sync from the start
540 2017-11-28T20:54:50  <jonasschnelli> Masterboy: dbcache how large?
541 2017-11-28T20:54:52  *** wunpunch has quit IRC
542 2017-11-28T20:55:13  <Masterboy> and the ping and speed to other clients was like 1/mbit
543 2017-11-28T20:55:20  <Masterboy> wait i will see
544 2017-11-28T20:55:30  <Masterboy> now it is crawling slow
545 2017-11-28T20:55:40  <Masterboy> client 0.15.1
546 2017-11-28T20:58:07  <jonasschnelli> Masterboy: network speed doesn't matter that much. What matters is CPU speed for signature verification, a.s.o. Disk speed is also important for the UTXO set read/writes.
547 2017-11-28T20:58:33  <jonasschnelli> Make sure you use a large dbcache which can make a significant improvement
548 2017-11-28T21:00:55  *** Dizzle has joined #bitcoin-core-dev
549 2017-11-28T21:02:04  <sipa> jonasschnelli: running with dbcache=450 maxmempool=10
550 2017-11-28T21:02:15  <sipa> default settings made it OOM
551 2017-11-28T21:04:49  <jonasschnelli> sipa: but you have 2GB, right?
552 2017-11-28T21:05:34  <jonasschnelli> maybe the maxmempool->dbcache-during-IBD-change is a OOM-problem for such systems
553 2017-11-28T21:05:54  <sipa> the total RSS was totally within expected ranges
554 2017-11-28T21:06:03  <sipa> it's more a question of what else was using memory i guess
555 2017-11-28T21:06:07  <sipa> but i haven't investigated
556 2017-11-28T21:06:14  <jonasschnelli> running with X?
557 2017-11-28T21:06:15  <Masterboy> jonasschnelli, sorry it take some time to load btc-qt like 10 min now. i am loading it from a hdd 700gb
558 2017-11-28T21:06:35  <sipa> jonasschnelli: yes, with a 4k screen - maybe that causes a lot of video memory
559 2017-11-28T21:06:46  <jonasschnelli> sipa: go headless!
560 2017-11-28T21:06:53  <sipa> yes, i should
561 2017-11-28T21:07:00  <Masterboy> jonasschnelli, how can i find out the dbcache value?
562 2017-11-28T21:07:05  <sipa> Masterboy: #bitcoin
563 2017-11-28T21:07:06  <jonasschnelli> 4k screen. ;-)
564 2017-11-28T21:07:45  <Masterboy> ok default is 450 i see in the manual
565 2017-11-28T21:07:50  <sipa> my tv was the only screen i had available with an HDMI port
566 2017-11-28T21:08:29  <Masterboy> jonasschnelli, so how can i make it faster? what should i set for a 300mbit connection?
567 2017-11-28T21:08:49  <Masterboy> jonasschnelli, cpu is 2.4ghz
568 2017-11-28T21:09:10  <jonasschnelli> Masterboy: please answer in the #bitcoin channel
569 2017-11-28T21:09:21  *** Krellan_ has joined #bitcoin-core-dev
570 2017-11-28T21:10:08  *** marcoagner has quit IRC
571 2017-11-28T21:26:51  *** rusty has quit IRC
572 2017-11-28T21:35:55  <BlueMatt> sipa: I highly recommend headless c2s, you can now build upstream kernels from released branches and upstream u-boot and things work :)
573 2017-11-28T21:36:01  <BlueMatt> no closed-source drivers needed
574 2017-11-28T21:36:28  *** btcdrak has quit IRC
575 2017-11-28T21:36:44  <BlueMatt> (closed source tool needed to convert u-boot build to binary image, sadly, and it does have a close-source first boot loader stage)
576 2017-11-28T21:37:31  *** paveljanik has quit IRC
577 2017-11-28T21:37:59  *** dqx has quit IRC
578 2017-11-28T21:40:08  *** Randolf has quit IRC
579 2017-11-28T21:41:20  *** dqx has joined #bitcoin-core-dev
580 2017-11-28T21:42:38  *** dqx has quit IRC
581 2017-11-28T21:43:15  <nanotube> MarcoFalke: that repo you linked contains a bunch of the plugins, but the core of the bot is https://github.com/nanotube/supybot_fixes
582 2017-11-28T21:43:56  <MarcoFalke> nanotube: I was specifically looking for the code that does this: #1337
583 2017-11-28T21:43:58  <gribble> https://github.com/bitcoin/bitcoin/issues/1337 | Quieter initial block download by rebroad · Pull Request #1337 · bitcoin/bitcoin · GitHub
584 2017-11-28T21:45:40  *** dqx has joined #bitcoin-core-dev
585 2017-11-28T21:46:24  *** dqx has quit IRC
586 2017-11-28T21:46:56  *** dqx has joined #bitcoin-core-dev
587 2017-11-28T21:48:45  <nanotube> MarcoFalke: ah, that's the MessageParser plugin :) the actual function to spit out issues is just config in the plugin
588 2017-11-28T21:48:57  *** Victorsueca has quit IRC
589 2017-11-28T21:50:07  *** Victorsueca has joined #bitcoin-core-dev
590 2017-11-28T21:51:49  <cluelessperson> I'm sorry to annoy you, is there an ETA on Core segwit support in the QT wallet?
591 2017-11-28T21:57:03  *** RoyceX has joined #bitcoin-core-dev
592 2017-11-28T21:58:37  *** kexkey has quit IRC
593 2017-11-28T22:00:02  <sipa> cluelessperson: when it's done
594 2017-11-28T22:00:12  *** cheese_ has quit IRC
595 2017-11-28T22:00:42  *** saint_ has quit IRC
596 2017-11-28T22:01:48  <sipa> cluelessperson: we never have the ability to set ETAs on features, as they depend on review, which is done by people volunteering their time
597 2017-11-28T22:05:08  <cluelessperson> sipa: how can I help?  (I don't know C++)
598 2017-11-28T22:05:48  <sipa> cluelessperson: you can help by testing it for sure
599 2017-11-28T22:06:08  <cluelessperson> sipa: can you lead me through what I need to do?
600 2017-11-28T22:06:15  <sipa> https://github.com/bitcoin/bitcoin/pull/11403
601 2017-11-28T22:06:18  <cluelessperson> maybe I can gain some experience and help more on my own in the future
602 2017-11-28T22:06:36  <sipa> can you compile from sourcr?
603 2017-11-28T22:06:42  <cluelessperson> yes
604 2017-11-28T22:07:30  <sipa> well the hardest part of being a good testing is figuring out what are good scenarios to test
605 2017-11-28T22:07:37  <sipa> identifying potential edge cases
606 2017-11-28T22:07:48  <cluelessperson> I figure I could try to test everythign on testnet
607 2017-11-28T22:07:57  <Chris_Stewart_5> *something something* #8469 *something something*
608 2017-11-28T22:07:59  <gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
609 2017-11-28T22:10:56  <cfields> Chris_Stewart_5: ugh, sorry. I promised you at Stanford that I'd take a look at that again, and never did.
610 2017-11-28T22:11:00  <cfields> adding it to my review queue.
611 2017-11-28T22:11:16  <BlueMatt> Chris_Stewart_5: I believe its still blocked on gcc 4.9, no?
612 2017-11-28T22:11:21  <BlueMatt> jnewbery: seemed to think so, at least
613 2017-11-28T22:11:24  <BlueMatt> (we currently only require 4.8)
614 2017-11-28T22:11:29  <Chris_Stewart_5> cfields: It's fine! I just like to make shameless plugs when I can.
615 2017-11-28T22:11:48  * BlueMatt still has it marked as "awaiting gcc bump"
616 2017-11-28T22:12:12  <Chris_Stewart_5> BlueMatt: I'm far from an expert on the build system, but can we make it only build if we have a >= 4.9 compiler?
617 2017-11-28T22:12:44  <Chris_Stewart_5> it was my understanding that 4.8 is going to be around for awhile
618 2017-11-28T22:12:57  <BlueMatt> 4.8 is some debian thing, right?
619 2017-11-28T22:13:01  <BlueMatt> like oldstable?
620 2017-11-28T22:13:14  <cfields> that's what we just did for DEBUG_LOCKORDER, so that sounds like fair game to me
621 2017-11-28T22:13:20  <BlueMatt> true
622 2017-11-28T22:13:40  <cfields> Trusty is 4.8 too
623 2017-11-28T22:13:48  <BlueMatt> ah, an ubuntu thing
624 2017-11-28T22:14:04  <BlueMatt> oldstable appears to be 4.9
625 2017-11-28T22:14:23  <sipa> what feature in 4.9 is needed?
626 2017-11-28T22:14:42  <BlueMatt> heh, trusty doesn't die until 2019
627 2017-11-28T22:14:53  <BlueMatt> man I'm so glad ubuntu shortened their supported cycle
628 2017-11-28T22:15:01  <Chris_Stewart_5> sipa: See the pull request. The library I'm using uses lambda's heavily
629 2017-11-28T22:15:28  <Chris_Stewart_5> apparently there is an issue with parameter packs
630 2017-11-28T22:16:07  <cfields> variadic lambdas? I thought that was a c++14 (or higher?) thing
631 2017-11-28T22:17:13  <cfields> oh, maybe that's a variadic in the callback definition as opposed to unpacking inside the lambda
632 2017-11-28T22:17:26  *** promag has joined #bitcoin-core-dev
633 2017-11-28T22:17:37  <MarcoFalke> nanotube: Ah, so the config is not in the repo... Have you enabled the Scheduler plugin? If so, mind adding a repeat every seconds=7*24*60*60 with a message of 'Meeting in ~30min' (first time at around 18:30UTC next Thursday)?
634 2017-11-28T22:19:09  <MarcoFalke> cfields: yeah travis is on trusty.
635 2017-11-28T22:19:21  <MarcoFalke> And I'd prefer to have it run on travis. Or at least compile
636 2017-11-28T22:19:29  <sipa> Chris_Stewart_5: it looks like it's a c++11 feature that's just buggy in gcc 4.5-4.8
637 2017-11-28T22:19:39  <sipa> cfields: ^
638 2017-11-28T22:19:50  <MarcoFalke> Jup, it is a bug in gcc4.8 that was never fixed (or backported)
639 2017-11-28T22:19:50  <cfields> MarcoFalke: well we could always work around that. The issue is what we consider to be the minimum for building.
640 2017-11-28T22:20:35  <BlueMatt> cfields: werent you gonna get us a depends-built gcc by 0.15 :p
641 2017-11-28T22:21:04  <MarcoFalke> Jup, could use that as work-around and keep min-gcc at 4.8
642 2017-11-28T22:21:15  <cfields> BlueMatt: yea, I just started messing with it again. Still unclear, though, whether we should go the gcc or clang route :(
643 2017-11-28T22:21:29  <BlueMatt> i thought we were going the "trusting trust" route :p
644 2017-11-28T22:21:47  <BlueMatt> (ie: both)
645 2017-11-28T22:22:30  <cfields> BlueMatt: both available for use? or use them to compile each-other, then use 1 of the resulting ones?
646 2017-11-28T22:22:40  <BlueMatt> the second
647 2017-11-28T22:23:02  <cfields> yea, even if we use clang for everything, we'll still want to build it with gcc at least once.
648 2017-11-28T22:25:35  <cfields> Chris_Stewart_5: https://github.com/emil-e/rapidcheck/commit/100fc66908b7c063160a3eebc5b778becaa335d1
649 2017-11-28T22:25:58  <cfields> Chris_Stewart_5: have you tried with a very recent rapidcheck, as opposed to what's shipped by distros?
650 2017-11-28T22:26:34  <MarcoFalke> lol, what disto ships that?
651 2017-11-28T22:27:06  <MarcoFalke> Aren't we fetching the code from the git directly?
652 2017-11-28T22:28:28  <Chris_Stewart_5> cfields: I did not see that and MarcoFalke yes. IIRC someone created a .mk file for it
653 2017-11-28T22:28:42  <cfields> oh, i assumed distros packaged it so we could use a local copy. nm.
654 2017-11-28T22:28:42  <MarcoFalke> I did ;)
655 2017-11-28T22:28:47  <Chris_Stewart_5> hah I thought it was you.
656 2017-11-28T22:29:22  <Chris_Stewart_5> cfields: I'll look at that later and see if I can just use that hack instead of having to do all this extra work
657 2017-11-28T22:29:30  <Chris_Stewart_5> thanks!
658 2017-11-28T22:29:59  <cfields> Chris_Stewart_5: well it's pretty old, so I assume it's not enough
659 2017-11-28T22:30:21  <cfields> (I was thinking you were testing with a stale distro package)
660 2017-11-28T22:31:58  *** blockchain has quit IRC
661 2017-11-28T22:34:26  <cfields> yea, your commit includes the hack
662 2017-11-28T22:34:36  *** quantbot has joined #bitcoin-core-dev
663 2017-11-28T22:34:46  *** quantbot_ has quit IRC
664 2017-11-28T22:38:55  *** promag has quit IRC
665 2017-11-28T22:39:12  *** Cogito_Ergo_Sum has quit IRC
666 2017-11-28T22:42:44  *** promag has joined #bitcoin-core-dev
667 2017-11-28T22:43:21  *** JamesAU has joined #bitcoin-core-dev
668 2017-11-28T22:43:39  *** hoge_ has joined #bitcoin-core-dev
669 2017-11-28T22:44:29  *** Chris_Stewart_5 has quit IRC
670 2017-11-28T22:44:56  *** promag has quit IRC
671 2017-11-28T22:46:36  *** promag has joined #bitcoin-core-dev
672 2017-11-28T22:49:13  *** JamesAU has quit IRC
673 2017-11-28T22:55:18  *** archaeal has quit IRC
674 2017-11-28T22:56:04  *** meshcollider has joined #bitcoin-core-dev
675 2017-11-28T23:07:14  *** Aaronvan_ has joined #bitcoin-core-dev
676 2017-11-28T23:07:52  *** RoyceX has quit IRC
677 2017-11-28T23:10:43  *** AaronvanW has quit IRC
678 2017-11-28T23:14:09  *** Cheeseo has joined #bitcoin-core-dev
679 2017-11-28T23:14:20  *** laurentmt has quit IRC
680 2017-11-28T23:14:54  *** Cheeseo has quit IRC
681 2017-11-28T23:15:36  *** Cheeseo has joined #bitcoin-core-dev
682 2017-11-28T23:19:50  *** Guyver2 has quit IRC
683 2017-11-28T23:20:51  *** goatpig has joined #bitcoin-core-dev
684 2017-11-28T23:21:46  *** Dizzle has quit IRC
685 2017-11-28T23:23:46  *** andyjdee has joined #bitcoin-core-dev
686 2017-11-28T23:24:05  *** dqx has quit IRC
687 2017-11-28T23:24:51  *** hoge_ has quit IRC
688 2017-11-28T23:27:01  *** dqx has joined #bitcoin-core-dev
689 2017-11-28T23:28:53  *** hoge_ has joined #bitcoin-core-dev
690 2017-11-28T23:30:33  *** vicenteH has quit IRC
691 2017-11-28T23:33:07  *** cheese_ has joined #bitcoin-core-dev
692 2017-11-28T23:36:01  *** JamesAU has joined #bitcoin-core-dev
693 2017-11-28T23:36:05  *** Cheeseo has quit IRC
694 2017-11-28T23:36:36  *** ctya has joined #bitcoin-core-dev
695 2017-11-28T23:40:51  *** dqx has quit IRC
696 2017-11-28T23:42:17  *** dqx has joined #bitcoin-core-dev
697 2017-11-28T23:42:36  *** qrestlove has quit IRC
698 2017-11-28T23:44:09  *** AaronvanW has joined #bitcoin-core-dev
699 2017-11-28T23:48:05  *** andyjdee has quit IRC
700 2017-11-28T23:50:45  *** wunpunch has joined #bitcoin-core-dev
701 2017-11-28T23:50:54  <meshcollider> promag: are you here?
702 2017-11-28T23:51:00  <promag> y
703 2017-11-28T23:51:15  <meshcollider> re: https://github.com/bitcoin/bitcoin/pull/11726/commits/75ae7453769517397df1020407bfa201121c5e31#r151863274 what do you mean by removing the default value?
704 2017-11-28T23:51:28  *** cheese_ has quit IRC
705 2017-11-28T23:51:34  <meshcollider> what would you suggest I put there instead?
706 2017-11-28T23:53:19  <promag> I thought this was true: std::string GetArg(const std::string& strArg, const std::string& strDefault="") const;
707 2017-11-28T23:53:49  <promag> Because your code is inside if (gArgs.IsArgSet("-walletdir") ...
708 2017-11-28T23:54:31  <promag> So this would look better gArgs.GetArg("-walletdir")
709 2017-11-28T23:54:47  <meshcollider> iirc GetArg didn't default to empty string?
710 2017-11-28T23:55:00  <meshcollider> https://github.com/bitcoin/bitcoin/blob/master/src/util.h#L229
711 2017-11-28T23:55:00  <promag> right, it doesn't
712 2017-11-28T23:55:01  *** Randolf has joined #bitcoin-core-dev
713 2017-11-28T23:56:14  <promag> it could be overloaded: std::string GetArg(const std::string& strArg) const; and there it would assert(IsSet(strArg))
714 2017-11-28T23:56:22  *** dqx has quit IRC
715 2017-11-28T23:56:55  <meshcollider> yeah true, probably out of scope for this PR though :)
716 2017-11-28T23:57:33  *** dqx has joined #bitcoin-core-dev
717 2017-11-28T23:57:34  <meshcollider> Also re: same PR, I'm unsure about the change you suggested to files.md, because even nodes running 0.16.0 will use the old file location if its an upgrade not a new install
718 2017-11-28T23:57:57  *** merehap has quit IRC
719 2017-11-28T23:58:05  <meshcollider> if I move it to a "Only used in pre-0.16.0" section, users may not realise that
720 2017-11-28T23:58:36  <promag> you mean this https://github.com/bitcoin/bitcoin/pull/11726/files#r153250209 ?
721 2017-11-28T23:58:51  <promag> just say:
722 2017-11-28T23:58:56  <meshcollider> yep
723 2017-11-28T23:59:19  <promag> * db.log: wallet database log file; replaced by wallets/ directory in 0.16.0 for fresh installs?
724 2017-11-28T23:59:22  <promag> or something?