12017-12-01T00:05:17  *** DigitalDank has quit IRC
  22017-12-01T00:06:37  *** DigitalDank has joined #bitcoin-core-dev
  32017-12-01T00:13:32  *** DigitalDank has quit IRC
  42017-12-01T00:14:58  *** DigitalDank has joined #bitcoin-core-dev
  52017-12-01T00:15:37  *** Randolf has quit IRC
  62017-12-01T00:21:23  *** DigitalDank has quit IRC
  72017-12-01T00:22:11  *** DigitalDank has joined #bitcoin-core-dev
  82017-12-01T00:22:11  *** DigitalDank has quit IRC
  92017-12-01T00:26:35  *** Aaronvan_ has joined #bitcoin-core-dev
 102017-12-01T00:29:37  *** AaronvanW has quit IRC
 112017-12-01T00:30:21  *** Deacyde has joined #bitcoin-core-dev
 122017-12-01T00:31:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 132017-12-01T00:32:21  *** wxss has quit IRC
 142017-12-01T00:38:52  *** dqx has joined #bitcoin-core-dev
 152017-12-01T01:05:32  *** DvdKhl has quit IRC
 162017-12-01T01:08:22  <promag> sipa: > involve downgrading/upgrading between versions
 172017-12-01T01:08:43  <sipa> yes?
 182017-12-01T01:09:01  <promag> could have those wallets as fixtures'
 192017-12-01T01:09:04  <promag> ?
 202017-12-01T01:09:30  <sipa> ?
 212017-12-01T01:11:07  *** Victorsueca has quit IRC
 222017-12-01T01:12:22  <promag> you mean that to test you have to use different versions of the wallet or the binary?
 232017-12-01T01:12:25  *** Victorsueca has joined #bitcoin-core-dev
 242017-12-01T01:12:31  *** bule has joined #bitcoin-core-dev
 252017-12-01T01:12:34  <sipa> yes
 262017-12-01T01:13:01  <sipa> any automated testing that downgrading/upgrading is supported under the intended scenarios would involve having tests with access to different versions of binaries
 272017-12-01T01:13:15  <sipa> which is just hard logistically
 282017-12-01T01:17:08  <promag> why? could make use of docker for instance
 292017-12-01T01:17:46  <sipa> i fail to understand what kind of universe you live in where that doesn't qualify as "logistically hard" :)
 302017-12-01T01:17:47  <promag> but yes, a pain
 312017-12-01T01:18:05  <sipa> i'm not saying it's impossible - but it requires very nontrivial changes to our setup
 322017-12-01T01:18:17  <sipa> so i'm looking for opinions
 332017-12-01T01:18:31  <sipa> is it enough to do manual testing for downgrade/upgrade scenarios, for example?
 342017-12-01T01:19:05  <promag> how about having some wallets created offline with different versions commited to the source code, to use in the the tests?
 352017-12-01T01:19:23  <sipa> that would be a good idea!
 362017-12-01T01:19:38  <sipa> it can't test downgrade scenarios, though - only upgrade
 372017-12-01T01:20:08  <promag> why? the downgrade should produce an expected wallet (also commited)
 382017-12-01T01:21:14  <sipa> we don't have old binaries available
 392017-12-01T01:21:20  <meshcollider> promag: what about testing a wallet generated by the new version, against old software
 402017-12-01T01:21:26  *** Murch has quit IRC
 412017-12-01T01:21:32  <sipa> oh, by downgrade i mean opening a new file in an old version of the software
 422017-12-01T01:21:32  <meshcollider> e.g. generate wallet with 0.16.0, test against 0.15.1
 432017-12-01T01:22:02  *** justanotheruser has joined #bitcoin-core-dev
 442017-12-01T01:22:14  <meshcollider> downgrading the software not the wallet :)
 452017-12-01T01:22:14  <promag> no need to test agains 0.15.1
 462017-12-01T01:22:27  <meshcollider> I mean any previous versin
 472017-12-01T01:22:30  *** Chris_Stewart_5 has quit IRC
 482017-12-01T01:23:00  <promag> you just happen to know downgrade result, so just check the downgrade result, offline you know it works in that version
 492017-12-01T01:23:25  <sipa> promag: practically the entire discussion about segwit wallet support is about downgrading and restoring backups across versions
 502017-12-01T01:23:47  <sipa> so no, we absolutely do care about how 0.15.1 deals with 0.16 files
 512017-12-01T01:23:48  *** dqx has quit IRC
 522017-12-01T01:24:27  <promag> I'm not saying otherwise
 532017-12-01T01:24:28  <meshcollider> old binaries are all stored on bitcoincore.org so just write another testing framework to use those ;)
 542017-12-01T01:24:29  *** bule has quit IRC
 552017-12-01T01:24:40  <sipa> promag: then i don't understand what you're saying
 562017-12-01T01:25:23  *** bule has joined #bitcoin-core-dev
 572017-12-01T01:25:43  <meshcollider> oh actually there is nothing pre-0.9.5 there
 582017-12-01T01:26:38  <promag> so offline with create and downgrade the wallet, test with older versions, if it's ok then commit a test that does the same and at the end verifies the downgraded wallet
 592017-12-01T01:27:05  <sipa> what does 'verifies the downgraded wallet' mean?
 602017-12-01T01:27:26  *** dqx has joined #bitcoin-core-dev
 612017-12-01T01:27:29  <sipa> there is no such thing as a downgraded wallet - it's just a wallet file that was modified by master, and we care about how old software deals with it
 622017-12-01T01:27:48  <promag> for instance, the sha(downgraded wallet file) must be ....
 632017-12-01T01:28:01  <sipa> bdb files aren't deterministic
 642017-12-01T01:28:12  <meshcollider> in reality it'd require a whole new testing framework to ensure things like signrawtransaction, listunspent, etc. all work on the old versions aye
 652017-12-01T01:28:22  <sipa> and testing exact equivalence would be painful to maintain, as it would need updating after pretty much any change
 662017-12-01T01:29:01  <promag> 2 downgrades of the same can be different?
 672017-12-01T01:29:11  *** Randolf has joined #bitcoin-core-dev
 682017-12-01T01:29:17  *** justanotheruser has quit IRC
 692017-12-01T01:29:37  *** justanotheruser has joined #bitcoin-core-dev
 702017-12-01T01:30:08  <sipa> promag: BDB files aren't deterministic, so you can't predict at all what the wallet file will look like after _any_ change
 712017-12-01T01:30:17  <sipa> you could dump the key/values in it, and compare those
 722017-12-01T01:30:23  <sipa> but my point is that you don't want to do that
 732017-12-01T01:30:41  <sipa> we don't care about the exact contents - we care about whether it works in old versions :)
 742017-12-01T01:31:03  <promag> my point is that those "exact contents" work in previous versions
 752017-12-01T01:31:23  <sipa> yes, but we can't predict what exact contents will be in master
 762017-12-01T01:31:39  <sipa> unless you want to modify that pre-committed exact contents after any change in master that affects the wallet file
 772017-12-01T01:31:53  <promag> that should not change often?
 782017-12-01T01:31:59  <sipa> maybe not
 792017-12-01T01:32:07  <sipa> it'd still be a pain
 802017-12-01T01:32:19  <promag> I mean, until a better testing framework exists it's better than nothing
 812017-12-01T01:32:26  <sipa> maybe
 822017-12-01T01:32:33  <meshcollider> just checking the hash of the wallet file is not sufficient though?
 832017-12-01T01:32:51  <sipa> meshcollider: no, the hash of the wallet file is completely unpredictable
 842017-12-01T01:33:04  <meshcollider> yeah, isn't that what promag is suggestion though
 852017-12-01T01:33:43  <promag> hash, key/values, whatever
 862017-12-01T01:34:27  <sipa> i generally dislike tests that test for exact equivalence
 872017-12-01T01:34:29  <meshcollider> key/values dumped by a newer version won't necessarily match those of an older version also, because changes to e.g. dumpscript would change the output
 882017-12-01T01:34:34  <promag> the test should just expect something. if master changes that then it might mean an old version can't use a downgraded wallet
 892017-12-01T01:34:36  *** bule has quit IRC
 902017-12-01T01:34:41  <sipa> especially if its unclear how those expected values should change
 912017-12-01T01:34:59  *** bule has joined #bitcoin-core-dev
 922017-12-01T01:35:15  <promag> but yes, if a wallet decides to add a new key/value for soemthing else then its' a pain
 932017-12-01T01:35:29  <sipa> or a timestamp
 942017-12-01T01:35:33  <sipa> or a version number
 952017-12-01T01:35:45  <sipa> or a txid that's hard to make constant during the test
 962017-12-01T01:36:07  <promag> and pick the relevant key/values?
 972017-12-01T01:36:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 982017-12-01T01:37:10  <promag> nothing better than actually use the old binaries
 992017-12-01T01:37:18  <meshcollider> yeah
1002017-12-01T01:37:39  <promag> what versions you think it should tests?
1012017-12-01T01:38:04  <meshcollider> well even 0.11 is now EOL isn't it, so I think it would be sufficient to just test on 12+ ?
1022017-12-01T01:38:14  *** Randolf has quit IRC
1032017-12-01T01:38:43  <meshcollider> (automatically, of course we shouldn't deliberately break compatibility with earlier versions too just not test against them all automatically)?
1042017-12-01T01:38:47  <promag> only final releases right?
1052017-12-01T01:39:43  <meshcollider> you mean like, not rc? or just 0.14.2 not 0.14.1?
1062017-12-01T01:40:28  <promag> not rc
1072017-12-01T01:40:55  <promag> anyone knows who owns this https://hub.docker.com/u/bitcoincore/ ?
1082017-12-01T01:41:50  <sipa> it's a good question what versions should be supportedd for downgrading
1092017-12-01T01:45:08  <sipa> the use case is generally that someone upgrades, notices that the new version does something else/unexpected that is incompatible with their business, and downgrades until the issue is resolved
1102017-12-01T01:46:17  <sipa> and obvious for the specific case of segwit wallet support - downgrading below 0.13 is impossible of course
1112017-12-01T01:47:45  *** Aaronvan_ has quit IRC
1122017-12-01T01:50:02  *** goatpig has quit IRC
1132017-12-01T01:56:39  *** ekrion has joined #bitcoin-core-dev
1142017-12-01T01:59:00  *** esotericnonsense has joined #bitcoin-core-dev
1152017-12-01T01:59:40  <promag> I guess you should add this testing as a follow up in #11403
1162017-12-01T01:59:44  <gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
1172017-12-01T02:01:45  <promag> a checklist for manual testing downgrade would be great also
1182017-12-01T02:02:14  <sipa> good point
1192017-12-01T02:04:51  <promag> bed time o/
1202017-12-01T02:04:59  *** promag has quit IRC
1212017-12-01T02:08:49  <meshcollider> IMO its safe enough to support downgrading to versions which havent reached EOL and not bother testing the others too
1222017-12-01T02:09:28  *** booyah_ has joined #bitcoin-core-dev
1232017-12-01T02:10:10  *** baldur_ has joined #bitcoin-core-dev
1242017-12-01T02:10:50  *** gaf__ has joined #bitcoin-core-dev
1252017-12-01T02:11:48  *** baldur has quit IRC
1262017-12-01T02:14:10  *** davec_ has joined #bitcoin-core-dev
1272017-12-01T02:14:31  *** dqx_ has joined #bitcoin-core-dev
1282017-12-01T02:15:14  *** whphhg_ has joined #bitcoin-core-dev
1292017-12-01T02:15:42  *** Vision-_- has joined #bitcoin-core-dev
1302017-12-01T02:16:18  *** da2ce7_ has joined #bitcoin-core-dev
1312017-12-01T02:17:34  *** bule has quit IRC
1322017-12-01T02:17:50  *** jnewbery_ has joined #bitcoin-core-dev
1332017-12-01T02:18:04  *** bule has joined #bitcoin-core-dev
1342017-12-01T02:19:13  *** cluelessperson_ has joined #bitcoin-core-dev
1352017-12-01T02:20:01  *** noglar_ has joined #bitcoin-core-dev
1362017-12-01T02:20:11  *** booyah has quit IRC
1372017-12-01T02:20:11  *** gaf_ has quit IRC
1382017-12-01T02:21:13  *** dqx has quit IRC
1392017-12-01T02:22:30  *** midnightmagic_ has joined #bitcoin-core-dev
1402017-12-01T02:22:40  *** [b__b] has quit IRC
1412017-12-01T02:22:41  *** davec has quit IRC
1422017-12-01T02:22:41  *** Ge0rges has quit IRC
1432017-12-01T02:22:41  *** whphhg has quit IRC
1442017-12-01T02:22:41  *** cluelessperson has quit IRC
1452017-12-01T02:22:41  *** cl0uding has quit IRC
1462017-12-01T02:22:41  *** Anduck has quit IRC
1472017-12-01T02:22:41  *** Vision has quit IRC
1482017-12-01T02:22:41  *** da2ce7 has quit IRC
1492017-12-01T02:22:41  *** midnightmagic has quit IRC
1502017-12-01T02:22:41  *** jnewbery has quit IRC
1512017-12-01T02:22:57  *** esotericnonsense has quit IRC
1522017-12-01T02:23:05  *** Anduck has joined #bitcoin-core-dev
1532017-12-01T02:26:35  *** [b__b] has joined #bitcoin-core-dev
1542017-12-01T02:27:44  *** Ge0rges has joined #bitcoin-core-dev
1552017-12-01T02:27:44  *** DigitalDank has joined #bitcoin-core-dev
1562017-12-01T02:33:05  *** ula has quit IRC
1572017-12-01T02:35:17  *** jackeroojohnson has joined #bitcoin-core-dev
1582017-12-01T02:35:29  *** ula has joined #bitcoin-core-dev
1592017-12-01T02:36:39  *** jackeroojohnson has quit IRC
1602017-12-01T02:48:39  *** owowo has joined #bitcoin-core-dev
1612017-12-01T02:50:17  *** Ylbam has quit IRC
1622017-12-01T02:51:35  *** Krellan has quit IRC
1632017-12-01T03:24:47  *** jtimon has quit IRC
1642017-12-01T03:31:43  *** Chris_Stewart_5 has quit IRC
1652017-12-01T04:05:57  *** dqx_ has quit IRC
1662017-12-01T04:23:30  <Varunram> Is it possible to change the difficulty on a regtest chain?
1672017-12-01T04:24:14  *** cluelessperson_ has quit IRC
1682017-12-01T04:24:58  *** cluelessperson has joined #bitcoin-core-dev
1692017-12-01T04:28:47  *** jouke has quit IRC
1702017-12-01T04:33:47  *** jouke has joined #bitcoin-core-dev
1712017-12-01T04:37:55  *** Vision-_- has left #bitcoin-core-dev
1722017-12-01T04:41:05  *** jouke has quit IRC
1732017-12-01T04:45:28  *** jack__ has joined #bitcoin-core-dev
1742017-12-01T04:50:58  *** ula has quit IRC
1752017-12-01T05:07:14  *** meshcollider has quit IRC
1762017-12-01T05:12:16  *** dabura667 has joined #bitcoin-core-dev
1772017-12-01T05:12:59  *** lari has quit IRC
1782017-12-01T05:14:12  *** lari has joined #bitcoin-core-dev
1792017-12-01T05:21:23  *** whphhg_ is now known as whphhg
1802017-12-01T05:27:51  *** jouke has joined #bitcoin-core-dev
1812017-12-01T05:59:12  *** midnightmagic_ is now known as midnightmagic
1822017-12-01T06:01:00  *** jack__ has quit IRC
1832017-12-01T06:07:40  *** Yop has joined #bitcoin-core-dev
1842017-12-01T06:08:00  *** Yop has quit IRC
1852017-12-01T06:12:20  *** Randolf has joined #bitcoin-core-dev
1862017-12-01T06:44:21  *** saint_ has quit IRC
1872017-12-01T06:59:11  *** Randolf has quit IRC
1882017-12-01T07:17:10  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1892017-12-01T07:17:10  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1902017-12-01T07:18:05  *** eurofap has joined #bitcoin-core-dev
1912017-12-01T07:20:03  *** BashCo has quit IRC
1922017-12-01T07:27:14  *** eurofap has quit IRC
1932017-12-01T07:37:48  *** bule has quit IRC
1942017-12-01T07:44:21  *** BashCo has joined #bitcoin-core-dev
1952017-12-01T07:46:39  <kallewoof> Trying to get gitian working, and am having issues with LXC. I am getting "sudo: unable to resolve host gitian / cannot set terminal process group (1): Inappropriate ioctl for device / no job control in this shell" for the line "sudo $LXC_EXECUTE -n gitian -f var/lxc.config -- sudo -u $TUSER $ENV -i -- $*" in libexec/on-target, called from make-clean-vm (the bootstrap-fixup part). Any ideas?
1962017-12-01T07:54:21  *** d9b4bef9 has quit IRC
1972017-12-01T07:55:30  *** d9b4bef9 has joined #bitcoin-core-dev
1982017-12-01T08:06:18  <midnightmagic> kallewoof: I solved that by modifying the gitian tqrget config to add the hostname to the internal /etc/hosts file; originally I solved it by manually modifying the base image.
1992017-12-01T08:08:35  *** shesek has joined #bitcoin-core-dev
2002017-12-01T08:11:03  *** warxhead has joined #bitcoin-core-dev
2012017-12-01T08:21:33  <kallewoof> midnightmagic: Nice, that got rid of the first line, but the other two lines remain (and I get thrown into a shell as root on the LXC side)..
2022017-12-01T08:22:10  <kallewoof> If I ^D, I get a bunch of "unknown user: ubuntu" errors when it tries to continue doing stuff.
2032017-12-01T08:28:19  <midnightmagic> does yout bootstrap-fixup not do an adduser for you?
2042017-12-01T08:30:06  <kallewoof> It's not being executed, because of the above errors, I suspect.
2052017-12-01T08:33:01  <kallewoof> I tried copying it into the base VM and then running it as a script from inside. That sorta worked, but "initctl: Unable to connect to Upstart: Failed to connect to socket /com/ubuntu/upstart: Connection refused" (not sure if that is bad news or can be ignored), then stuff, and then it fails again on the "Preparing build environment" part (basically, it fails whenever a "<" is used to feed a script
2062017-12-01T08:33:03  <kallewoof> into it).
2072017-12-01T08:33:37  <kallewoof> In this case, the "system! "on-target setarch #{@arches[arch]} bash < target-bin/init-build.sh"" part in gbuild
2082017-12-01T08:44:02  <kallewoof> I think an easy fix for me is to just copy target-bin into the image after copying it. Not sure why <'ing doesn't work tho. :/
2092017-12-01T08:46:09  *** Krellan has joined #bitcoin-core-dev
2102017-12-01T08:50:04  *** JackH has quit IRC
2112017-12-01T08:54:01  *** Emcy_ has quit IRC
2122017-12-01T08:54:30  *** Emcy_ has joined #bitcoin-core-dev
2132017-12-01T08:57:12  *** AaronvanW has joined #bitcoin-core-dev
2142017-12-01T08:58:41  *** Aaronvan_ has joined #bitcoin-core-dev
2152017-12-01T08:59:09  *** unholymachine has quit IRC
2162017-12-01T09:00:11  *** unholymachine has joined #bitcoin-core-dev
2172017-12-01T09:02:23  *** AaronvanW has quit IRC
2182017-12-01T09:04:38  *** kexkey has quit IRC
2192017-12-01T09:04:56  <kallewoof> I got to the copy-to-target part, which hangs indefinitely on "tar -C `dirname "$1"` -cf - `basename "$1"` | sudo $LXC_EXECUTE -n gitian -f var/lxc.config -- sudo -i -u $TUSER tar -C "$2" -xf -". I suspect the pipe is not functional just like the <, but I could be wrong.
2202017-12-01T09:17:25  *** luke-jr has quit IRC
2212017-12-01T09:17:42  *** luke-jr has joined #bitcoin-core-dev
2222017-12-01T09:22:57  *** laurentmt has joined #bitcoin-core-dev
2232017-12-01T09:23:09  *** Victorsueca has quit IRC
2242017-12-01T09:24:25  *** Victorsueca has joined #bitcoin-core-dev
2252017-12-01T09:26:10  *** vicenteH has joined #bitcoin-core-dev
2262017-12-01T09:30:41  *** promag has joined #bitcoin-core-dev
2272017-12-01T09:33:24  *** booyah_ is now known as booyah
2282017-12-01T09:33:43  *** promag has quit IRC
2292017-12-01T09:35:59  *** Sinclair6 has quit IRC
2302017-12-01T09:39:41  *** daedal has joined #bitcoin-core-dev
2312017-12-01T09:42:03  *** Ylbam has joined #bitcoin-core-dev
2322017-12-01T09:45:50  *** alreadylate has joined #bitcoin-core-dev
2332017-12-01T09:46:44  *** whphhg has quit IRC
2342017-12-01T09:48:05  *** booyah has quit IRC
2352017-12-01T09:48:20  *** booyah has joined #bitcoin-core-dev
2362017-12-01T09:51:07  *** timothy has joined #bitcoin-core-dev
2372017-12-01T09:58:28  *** jouke has quit IRC
2382017-12-01T10:02:27  *** booyah has quit IRC
2392017-12-01T10:03:28  *** booyah has joined #bitcoin-core-dev
2402017-12-01T10:07:41  *** jouke has joined #bitcoin-core-dev
2412017-12-01T10:20:44  *** jtimon has joined #bitcoin-core-dev
2422017-12-01T10:30:07  *** alreadylate has quit IRC
2432017-12-01T10:46:23  *** meshcollider has joined #bitcoin-core-dev
2442017-12-01T10:56:39  *** daedal has quit IRC
2452017-12-01T10:57:35  *** Krellan has quit IRC
2462017-12-01T10:58:29  *** Krellan has joined #bitcoin-core-dev
2472017-12-01T11:07:02  *** Aaronvan_ is now known as AaronvanW
2482017-12-01T11:07:41  *** qqq has joined #bitcoin-core-dev
2492017-12-01T11:08:00  *** laurentmt has quit IRC
2502017-12-01T11:08:41  *** laurentmt has joined #bitcoin-core-dev
2512017-12-01T11:10:54  *** qqq has quit IRC
2522017-12-01T11:27:18  *** laurentmt has quit IRC
2532017-12-01T11:31:31  *** whphhg has joined #bitcoin-core-dev
2542017-12-01T11:39:00  *** wxss has joined #bitcoin-core-dev
2552017-12-01T12:11:57  *** dabura667 has quit IRC
2562017-12-01T12:18:08  <wumpus> don't think Vision is still here but: https://github.com/bitcoin/bitcoin/pull/11809  should fix his issue
2572017-12-01T12:38:51  *** promag has joined #bitcoin-core-dev
2582017-12-01T12:47:00  *** SopaXorzTaker has joined #bitcoin-core-dev
2592017-12-01T12:52:42  *** wxss has quit IRC
2602017-12-01T12:53:02  *** wxss has joined #bitcoin-core-dev
2612017-12-01T12:54:14  *** wxss has quit IRC
2622017-12-01T12:55:35  *** wxss has joined #bitcoin-core-dev
2632017-12-01T12:56:10  *** meshcollider has quit IRC
2642017-12-01T13:03:44  *** promag has quit IRC
2652017-12-01T13:06:57  *** Krellan has quit IRC
2662017-12-01T13:07:57  *** Krellan has joined #bitcoin-core-dev
2672017-12-01T13:11:54  *** dcousens has quit IRC
2682017-12-01T13:29:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2692017-12-01T13:30:20  *** dqx has joined #bitcoin-core-dev
2702017-12-01T13:42:37  *** laurentmt has joined #bitcoin-core-dev
2712017-12-01T13:58:28  *** quantbot has joined #bitcoin-core-dev
2722017-12-01T14:01:32  *** riko has joined #bitcoin-core-dev
2732017-12-01T14:01:41  *** quantbot_ has quit IRC
2742017-12-01T14:02:57  *** quantbot has quit IRC
2752017-12-01T14:04:24  *** JackH has joined #bitcoin-core-dev
2762017-12-01T14:10:14  *** Victorsueca has quit IRC
2772017-12-01T14:11:25  *** Victorsueca has joined #bitcoin-core-dev
2782017-12-01T14:15:01  *** kexkey has joined #bitcoin-core-dev
2792017-12-01T14:19:31  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13e31dd6548d...0d7e0a3289ba
2802017-12-01T14:19:31  <bitcoin-git> bitcoin/master b4058ed Dan Raviv: Fix code constness in CBlockIndex::GetAncestor() overloads...
2812017-12-01T14:19:32  <bitcoin-git> bitcoin/master 0d7e0a3 Wladimir J. van der Laan: Merge #11337: Fix code constness in CBlockIndex::GetAncestor() overloads...
2822017-12-01T14:24:16  *** rafalcpp has quit IRC
2832017-12-01T14:29:22  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d7e0a3289ba...00d25e90db06
2842017-12-01T14:29:22  <bitcoin-git> bitcoin/master bf20a7d Tim Shimmin: [docs] Fixed outdated link with archive.is...
2852017-12-01T14:29:23  <bitcoin-git> bitcoin/master 00d25e9 Wladimir J. van der Laan: Merge #11804: [docs] Fixed outdated link with archive.is...
2862017-12-01T14:34:32  *** rafalcpp has joined #bitcoin-core-dev
2872017-12-01T14:58:09  *** timothy has quit IRC
2882017-12-01T14:59:57  *** Chris_Stewart_5 has quit IRC
2892017-12-01T15:00:27  *** timothy has joined #bitcoin-core-dev
2902017-12-01T15:00:44  *** ryan01010 has joined #bitcoin-core-dev
2912017-12-01T15:09:49  *** promag has joined #bitcoin-core-dev
2922017-12-01T15:14:23  *** ekrion has quit IRC
2932017-12-01T15:17:08  *** Krellan has quit IRC
2942017-12-01T15:18:26  *** Krellan has joined #bitcoin-core-dev
2952017-12-01T15:33:00  <Provoostenator> Tangentally related to testing the segwit branch. It looks like miners are no longer mining SegWit transactions on testnet. See my example in #bitcoin.
2962017-12-01T15:33:36  <Provoostenator> (well, much less, they do get mined eventually)
2972017-12-01T15:33:58  <wumpus> testnet mining seems a continuing issue
2982017-12-01T15:34:28  *** Victorsueca has quit IRC
2992017-12-01T15:34:34  <Provoostenator> I can't go in there with my laptop CPU and mine it myself I presume?
3002017-12-01T15:34:53  <instagibbs> people point ASICs at it, so no
3012017-12-01T15:35:08  <Provoostenator> Ethereum created a consortium testnet out of desperation, which seems like a pretty bad solution.
3022017-12-01T15:35:40  *** Victorsueca has joined #bitcoin-core-dev
3032017-12-01T15:35:42  <Provoostenator> Would it be hard to spin up smaller testnets amongst "friends"?
3042017-12-01T15:36:38  <instagibbs> you may be interested in #8994
3052017-12-01T15:36:41  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
3062017-12-01T15:37:17  <instagibbs> for segwit itself something like 4 new testnets were created(segnet)
3072017-12-01T15:37:20  <Provoostenator> instagibbs: thanks
3082017-12-01T15:37:41  *** ula has joined #bitcoin-core-dev
3092017-12-01T15:38:00  *** DvdKhl has joined #bitcoin-core-dev
3102017-12-01T15:38:35  *** promag has quit IRC
3112017-12-01T15:40:18  *** timothy has quit IRC
3122017-12-01T15:47:12  <Provoostenator> The Github issues and pull requests form an infinitely deep and complex rabbit hole; fascinating :-)
3132017-12-01T15:47:45  *** timothy has joined #bitcoin-core-dev
3142017-12-01T15:47:58  *** timothy has quit IRC
3152017-12-01T15:47:59  <Provoostenator> "There's a PR for that" might make a good meme.
3162017-12-01T15:49:35  <instagibbs> The best one is where there is a PR that's been revived by 2+ people.... thar be dragons
3172017-12-01T15:51:33  *** timothy has joined #bitcoin-core-dev
3182017-12-01T15:52:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3192017-12-01T15:54:56  *** BashCo has quit IRC
3202017-12-01T15:56:17  *** checksauce has joined #bitcoin-core-dev
3212017-12-01T16:00:23  <Provoostenator> Would it make sense to tweak the PoW algorithm on testnet so it can't (easily) be ASIC mined? Maybe that would keep the difficulty at somewhat manageable levels, where more people can step in and mine SegWit and (experimental) non-standard transactions.
3222017-12-01T16:02:46  <Provoostenator> Maybe now is a bad time with heated emotions and such, it could be taken the wrong way. DIY testnets like in the above PR is safer.
3232017-12-01T16:03:52  <wumpus> there was some talk of a testnet with signed blocks instead of mining at some point, as mining is always a problem with regard to incentives, but it's pretty annoying to implement and touches consensus code
3242017-12-01T16:03:57  <Provoostenator> And I suppose any code supporting such PoW change on testnet would cause maintenance headaches.
3252017-12-01T16:04:29  <wumpus> there's no need for PoW at all on testnet, unless for testing miners I guess
3262017-12-01T16:04:53  <wumpus> and in that case using a different one is useless
3272017-12-01T16:05:03  <Provoostenator> Hardcode the difficulty at 0 and add a consensus rule for now more than 1 block per minute?
3282017-12-01T16:05:54  <Provoostenator> I suppose that would be a DDOS vector.
3292017-12-01T16:06:54  <wumpus> but yes I think DIY/private testnets are the best solution usually, most testing scenarios don't really want all the noise around
3302017-12-01T16:07:09  <Provoostenator> The noise helps you catch unexpected stuff though.
3312017-12-01T16:08:26  <Provoostenator> And having frequent reorgs on testnet would be nice too for testing robustness.
3322017-12-01T16:08:56  <wumpus> that's what we have already, most requests are for a more reliable testnet
3332017-12-01T16:09:29  <Provoostenator> Right, maybe we need a seperate calmnet and wildnet.
3342017-12-01T16:12:04  <Provoostenator> I used to just test everything on mainnet when fees were a bit lower (still works if you use the minimum relay fee and spend unconfirmed txs).
3352017-12-01T16:21:19  *** bule has joined #bitcoin-core-dev
3362017-12-01T16:21:28  *** BashCo has joined #bitcoin-core-dev
3372017-12-01T16:22:06  *** bule has quit IRC
3382017-12-01T16:22:20  *** bule has joined #bitcoin-core-dev
3392017-12-01T16:22:39  <mlz> devs, current testnet blockheight:  1251999, could we reset testnet or redesign it all together that LN testers don't have to wait for a segwit miner to come along?
3402017-12-01T16:22:49  <wumpus> indeed, testing on mainnet is possible, though that's bad practice to recommend to anyone, much foot-shooting potential
3412017-12-01T16:28:25  <wumpus> mlz: yes, testnet seems broken at the moment, and no one seems to be able to spare miners to point at it :/
3422017-12-01T16:29:50  <mlz> wumpus, is it possible to make it CPU mining? i can help and so can many others
3432017-12-01T16:31:24  *** checksauce has quit IRC
3442017-12-01T16:33:49  *** str4d has joined #bitcoin-core-dev
3452017-12-01T16:34:57  *** Murch has joined #bitcoin-core-dev
3462017-12-01T16:35:01  <wumpus> one idea that has been proposed is to do a testnet with signed blocks, e.g. wumpus signs a block every 10 minutes. Mining, of whatever kind, will always introduce these kind of issues.
3472017-12-01T16:35:52  <wumpus> it's not that sha256 is not CPU minable, just that someone is mining and pushing up difficulty w/ inconvenient settings or version
3482017-12-01T16:37:53  <wumpus> just two year ago I CPU-mined quite a few blocks on testnet, while no one else was pointing miners at it
3492017-12-01T16:38:50  <wumpus> anyhow for a reliable testnet it's probably best to have a fixed set of rules, distributed mining competition doesn't really help
3502017-12-01T16:38:51  *** checksauce has joined #bitcoin-core-dev
3512017-12-01T16:46:19  *** cluelessperson has quit IRC
3522017-12-01T16:47:06  *** cluelessperson has joined #bitcoin-core-dev
3532017-12-01T16:49:31  *** checksauce has quit IRC
3542017-12-01T16:50:26  *** riko has quit IRC
3552017-12-01T16:51:17  <wumpus> as mentioned before it'd be good to try to move #8994 forward
3562017-12-01T16:51:19  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
3572017-12-01T16:55:13  *** bule has quit IRC
3582017-12-01T16:58:01  *** Chad54Kulas has joined #bitcoin-core-dev
3592017-12-01T17:01:40  <Varunram> Provoostenator: The difficulty of testnet has been down recently, could give it a shot
3602017-12-01T17:04:04  <Provoostenator> Varunram: I suppose I can try it for a day. Which begs the question how: https://bitcoin.stackexchange.com/questions/51169/how-can-i-solo-mine-using-bitcoin-core
3612017-12-01T17:04:28  <Provoostenator> (feel free to answer in #bitcoin instead)
3622017-12-01T17:05:14  <Varunram> (yeah)
3632017-12-01T17:21:51  *** kabaum has quit IRC
3642017-12-01T17:22:17  *** kabaum has joined #bitcoin-core-dev
3652017-12-01T17:23:09  *** DigitalDank has quit IRC
3662017-12-01T17:25:22  *** laurentmt has quit IRC
3672017-12-01T17:25:30  *** Victorsueca has quit IRC
3682017-12-01T17:26:42  *** Victorsueca has joined #bitcoin-core-dev
3692017-12-01T17:27:27  <Provoostenator> Is there a way to get `make cov` to produce an lcov file rather than HTML?
3702017-12-01T17:28:10  <Provoostenator> (happy to tweak Makefile.am, but no idea how)
3712017-12-01T17:34:23  *** Krellan has quit IRC
3722017-12-01T17:35:03  *** Krellan has joined #bitcoin-core-dev
3732017-12-01T17:40:32  *** Dizzle has joined #bitcoin-core-dev
3742017-12-01T17:42:48  *** esotericnonsense has joined #bitcoin-core-dev
3752017-12-01T17:43:58  *** jb55 has joined #bitcoin-core-dev
3762017-12-01T17:46:50  *** Randolf has joined #bitcoin-core-dev
3772017-12-01T17:50:28  *** whphhg has quit IRC
3782017-12-01T17:50:41  *** whphhg has joined #bitcoin-core-dev
3792017-12-01T17:52:15  *** promag has joined #bitcoin-core-dev
3802017-12-01T17:55:56  *** bule has joined #bitcoin-core-dev
3812017-12-01T17:58:56  <phantomcircuit> wumpus, ye but lots of miners use testnet to test
3822017-12-01T17:59:04  <phantomcircuit> about the only people who do really
3832017-12-01T18:00:24  <BlueMatt> nah, the ln folks are consistently pissed that testnet sucks
3842017-12-01T18:00:29  <BlueMatt> so they use it
3852017-12-01T18:00:51  *** timothy has quit IRC
3862017-12-01T18:02:41  <phantomcircuit> BlueMatt, heh
3872017-12-01T18:04:02  <Provoostenator> I'm getting a second hand Block Erupter USB on Sunday, we'll see if that helps.
3882017-12-01T18:04:11  <BlueMatt> lol
3892017-12-01T18:04:37  <Varunram> for mining segwit txs on testnet?
3902017-12-01T18:05:09  <Provoostenator> Yes, as the guy in Armageddon said: this is how we fix things in Russian space station :-)
3912017-12-01T18:06:11  <Varunram> lol
3922017-12-01T18:10:19  *** dqx has quit IRC
3932017-12-01T18:10:20  <adiabat> BlueMatt: I use testnet3 all the time, it's a little weird but oh well
3942017-12-01T18:10:53  <adiabat> maybe the biggest issue is that you'll have miners show up who don't run segwit and mine for days where no segwit txs can be confirmed
3952017-12-01T18:10:56  *** dqx has joined #bitcoin-core-dev
3962017-12-01T18:11:55  <gmaxwell> need some hashpower there that mines segwit invalid blocks.
3972017-12-01T18:12:56  <adiabat> the messiness of testnet3 is something of a feature though; found some reorg bug in my code the other day
3982017-12-01T18:12:57  *** dqx has quit IRC
3992017-12-01T18:13:07  *** dqx_ has joined #bitcoin-core-dev
4002017-12-01T18:13:20  <adiabat> though it's specific to the testnet difficulty reduction, so maybe actually not that great a feature :)
4012017-12-01T18:13:29  <Varunram> adaibat: further adding to BlueMatt's assertion that ln folks use testnet grudgingly
4022017-12-01T18:13:35  <Varunram> adiabat*
4032017-12-01T18:14:38  <adiabat> I mean, it's a mess, but at the same time it allows to test weird edge cases
4042017-12-01T18:15:04  <adiabat> for example, I have code to checkpoint SPV headers, which is only there because testnet has over 100MB of headers
4052017-12-01T18:15:44  <Varunram> nice e.g. lol
4062017-12-01T18:16:48  <BlueMatt> heh, there's been persistent discussion of resetting testnet to bump min diff to limit the insane header volume issue
4072017-12-01T18:17:11  <adiabat> if anything, making testnet3 more congested may help, as it would allow fee pressure and testing different fees, RBF, etc
4082017-12-01T18:17:31  <BlueMatt> heh, well someone can write a bot to do that.....
4092017-12-01T18:17:37  <BlueMatt> spam testnet!
4102017-12-01T18:17:47  <adiabat> yeah the min diff thing is weird, could definitely do without that
4112017-12-01T18:18:01  <adiabat> I don't know the etiquette on that
4122017-12-01T18:18:14  <adiabat> I spammed it a bit last year, and made those 3.7MB blocks
4132017-12-01T18:18:42  <adiabat> wouldn't be hard to spam more, but figured people might get annoyed at a 200GB testnet
4142017-12-01T18:19:06  <Varunram> people would quit it altogether
4152017-12-01T18:19:25  <phantomcircuit> BlueMatt, ye testnet probbaly needs a reset
4162017-12-01T18:19:38  <phantomcircuit> i mean
4172017-12-01T18:19:47  <phantomcircuit> pretty sure im still 90% of testnet by bytes
4182017-12-01T18:20:14  <adiabat> I may be a couple %
4192017-12-01T18:32:40  *** ryan01010 has quit IRC
4202017-12-01T18:36:32  *** shesek has quit IRC
4212017-12-01T18:38:57  *** vicenteH has quit IRC
4222017-12-01T18:44:00  *** PaulCapestany has quit IRC
4232017-12-01T18:46:49  *** PaulCapestany has joined #bitcoin-core-dev
4242017-12-01T18:49:43  *** shesek has joined #bitcoin-core-dev
4252017-12-01T18:49:45  *** shesek has joined #bitcoin-core-dev
4262017-12-01T18:52:59  *** jb55 has quit IRC
4272017-12-01T19:07:05  *** ula has quit IRC
4282017-12-01T19:10:49  *** ula has joined #bitcoin-core-dev
4292017-12-01T19:11:05  *** ekrion has joined #bitcoin-core-dev
4302017-12-01T19:14:39  *** jb55 has joined #bitcoin-core-dev
4312017-12-01T19:19:14  *** jonatan_ has joined #bitcoin-core-dev
4322017-12-01T19:20:48  *** jonatan_ has quit IRC
4332017-12-01T19:24:06  *** bule2 has joined #bitcoin-core-dev
4342017-12-01T19:25:22  *** bule2 has quit IRC
4352017-12-01T19:25:47  *** bule2 has joined #bitcoin-core-dev
4362017-12-01T19:27:08  *** bule has quit IRC
4372017-12-01T19:28:30  *** Victorsueca has quit IRC
4382017-12-01T19:29:43  *** Victorsueca has joined #bitcoin-core-dev
4392017-12-01T19:31:24  <Provoostenator> Rather than spamming, why not drastically decrease the block size? I kind of like that I do an IDB in less than an hour for a change.
4402017-12-01T19:33:22  *** bule has joined #bitcoin-core-dev
4412017-12-01T19:35:09  *** dqx_ has quit IRC
4422017-12-01T19:35:40  *** bule2 has quit IRC
4432017-12-01T19:36:00  *** dqx has joined #bitcoin-core-dev
4442017-12-01T19:45:00  *** promag has quit IRC
4452017-12-01T19:46:30  *** ekrion has quit IRC
4462017-12-01T19:47:56  *** Randolf has quit IRC
4472017-12-01T19:49:00  *** Krellan has quit IRC
4482017-12-01T19:49:44  *** Krellan has joined #bitcoin-core-dev
4492017-12-01T19:52:15  *** Sinclair6 has joined #bitcoin-core-dev
4502017-12-01T20:03:45  *** meshcollider has joined #bitcoin-core-dev
4512017-12-01T20:13:34  *** jb55 has quit IRC
4522017-12-01T20:20:18  *** SopaXorzTaker has quit IRC
4532017-12-01T20:28:40  *** quantbot has joined #bitcoin-core-dev
4542017-12-01T20:36:28  *** quantbot has quit IRC
4552017-12-01T20:36:54  *** quantbot has joined #bitcoin-core-dev
4562017-12-01T20:41:24  *** Randolf has joined #bitcoin-core-dev
4572017-12-01T20:44:35  *** quantbot has quit IRC
4582017-12-01T20:57:04  *** Sinclair_ has joined #bitcoin-core-dev
4592017-12-01T20:59:26  *** Sinclair6 has quit IRC
4602017-12-01T21:13:32  *** Randolf has quit IRC
4612017-12-01T21:19:23  *** Sinclair_ has quit IRC
4622017-12-01T21:20:50  *** Chris_Stewart_5 has quit IRC
4632017-12-01T21:21:41  *** Sinclair6 has joined #bitcoin-core-dev
4642017-12-01T21:29:24  *** roadcrap has joined #bitcoin-core-dev
4652017-12-01T21:31:03  *** Sinclair6 has quit IRC
4662017-12-01T21:33:10  *** Guyver2 has joined #bitcoin-core-dev
4672017-12-01T21:33:37  *** vicenteH has joined #bitcoin-core-dev
4682017-12-01T21:35:51  *** dqx has quit IRC
4692017-12-01T21:36:36  *** dqx has joined #bitcoin-core-dev
4702017-12-01T21:37:36  *** dqx has quit IRC
4712017-12-01T21:37:42  *** dqx_ has joined #bitcoin-core-dev
4722017-12-01T21:42:52  *** jb55 has joined #bitcoin-core-dev
4732017-12-01T21:47:35  *** Chad54Kulas has quit IRC
4742017-12-01T21:52:15  *** quantbot has joined #bitcoin-core-dev
4752017-12-01T21:57:36  *** Guyver2 has quit IRC
4762017-12-01T21:57:43  *** quantbot has quit IRC
4772017-12-01T21:58:09  *** quantbot has joined #bitcoin-core-dev
4782017-12-01T21:59:09  *** booyah is now known as SoCo_cpp___
4792017-12-01T21:59:34  *** SoCo_cpp___ is now known as booyah
4802017-12-01T22:01:48  *** Krellan has quit IRC
4812017-12-01T22:02:35  *** ula has quit IRC
4822017-12-01T22:02:36  *** quantbot has quit IRC
4832017-12-01T22:03:07  *** Krellan has joined #bitcoin-core-dev
4842017-12-01T22:06:16  *** Aaronvan_ has joined #bitcoin-core-dev
4852017-12-01T22:08:28  *** Aaronvan_ has quit IRC
4862017-12-01T22:09:05  *** AaronvanW has quit IRC
4872017-12-01T22:27:21  *** Cogito_Ergo_Sum has quit IRC
4882017-12-01T22:30:58  *** Dizzle has quit IRC
4892017-12-01T22:33:27  *** geezas has joined #bitcoin-core-dev
4902017-12-01T22:55:47  *** kurito has joined #bitcoin-core-dev
4912017-12-01T22:55:52  *** dabura667 has joined #bitcoin-core-dev
4922017-12-01T23:00:37  *** Victorsueca has quit IRC
4932017-12-01T23:01:57  *** Victorsueca has joined #bitcoin-core-dev
4942017-12-01T23:03:02  *** rabidus is now known as jonuzeioohomo
4952017-12-01T23:03:14  *** jonuzeioohomo is now known as rabidus
4962017-12-01T23:32:48  *** timothy has joined #bitcoin-core-dev
4972017-12-01T23:34:23  *** kexkey has quit IRC
4982017-12-01T23:36:49  *** dqx_ has quit IRC
4992017-12-01T23:37:40  *** dqx has joined #bitcoin-core-dev
5002017-12-01T23:41:17  *** dabura667 has quit IRC
5012017-12-01T23:44:01  *** dqx has quit IRC
5022017-12-01T23:49:21  *** timothy has quit IRC
5032017-12-01T23:55:48  <jimpo> In a local branch I'm getting linking errors along the lines of "multiple definition of `StartShutdown()'". Can someone explain why the definitions in test_bitcoin_main.cpp don't conflict with the ones in init.cpp?