1 2017-12-04T00:08:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  2 2017-12-04T00:13:26  *** zshlyk has quit IRC
  3 2017-12-04T00:15:24  *** go1111111 has quit IRC
  4 2017-12-04T00:16:36  *** promag has quit IRC
  5 2017-12-04T00:17:18  *** wunpunch has quit IRC
  6 2017-12-04T00:33:39  *** Emcy_ has quit IRC
  7 2017-12-04T00:34:08  *** Emcy_ has joined #bitcoin-core-dev
  8 2017-12-04T00:35:55  *** jb55 has quit IRC
  9 2017-12-04T00:37:53  *** go1111111 has joined #bitcoin-core-dev
 10 2017-12-04T00:40:31  *** jb55 has joined #bitcoin-core-dev
 11 2017-12-04T00:45:58  *** jb55 has quit IRC
 12 2017-12-04T00:46:33  *** bitmangw has left #bitcoin-core-dev
 13 2017-12-04T00:47:11  *** jb55 has joined #bitcoin-core-dev
 14 2017-12-04T00:50:44  *** Emcy has joined #bitcoin-core-dev
 15 2017-12-04T00:53:27  *** Emcy_ has quit IRC
 16 2017-12-04T00:54:34  *** wxss has quit IRC
 17 2017-12-04T00:55:12  *** DvdKhl has quit IRC
 18 2017-12-04T00:57:05  *** jb55 has quit IRC
 19 2017-12-04T01:00:00  *** dabura667 has joined #bitcoin-core-dev
 20 2017-12-04T01:03:45  *** dqx_ has joined #bitcoin-core-dev
 21 2017-12-04T01:04:35  *** dqx has quit IRC
 22 2017-12-04T01:08:18  *** dqx has joined #bitcoin-core-dev
 23 2017-12-04T01:11:18  *** dqx_ has quit IRC
 24 2017-12-04T01:12:30  *** nelruk has joined #bitcoin-core-dev
 25 2017-12-04T01:32:47  *** baltakatei has quit IRC
 26 2017-12-04T01:35:45  *** zshlyk has joined #bitcoin-core-dev
 27 2017-12-04T01:40:15  *** nelruk has quit IRC
 28 2017-12-04T01:43:26  *** Randolf has joined #bitcoin-core-dev
 29 2017-12-04T01:45:20  *** baltakatei has joined #bitcoin-core-dev
 30 2017-12-04T01:45:43  *** Ylbam has quit IRC
 31 2017-12-04T01:56:27  *** Krellan has quit IRC
 32 2017-12-04T01:57:07  *** Krellan has joined #bitcoin-core-dev
 33 2017-12-04T01:58:26  *** Chris_Stewart_5 has quit IRC
 34 2017-12-04T02:03:27  *** meshcollider has quit IRC
 35 2017-12-04T02:07:20  *** Emcy_ has joined #bitcoin-core-dev
 36 2017-12-04T02:08:35  *** dqx has quit IRC
 37 2017-12-04T02:09:56  *** Emcy has quit IRC
 38 2017-12-04T02:10:51  *** zshlyk has quit IRC
 39 2017-12-04T02:11:38  *** zshlyk has joined #bitcoin-core-dev
 40 2017-12-04T02:12:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 41 2017-12-04T02:21:51  *** Chris_Stewart_5 has quit IRC
 42 2017-12-04T02:22:48  *** Victorsueca has quit IRC
 43 2017-12-04T02:24:14  *** Victorsueca has joined #bitcoin-core-dev
 44 2017-12-04T02:30:48  *** jb55 has joined #bitcoin-core-dev
 45 2017-12-04T02:31:45  *** zshlyk has quit IRC
 46 2017-12-04T02:32:31  *** zshlyk has joined #bitcoin-core-dev
 47 2017-12-04T02:34:41  *** xRavenheart has joined #bitcoin-core-dev
 48 2017-12-04T02:35:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 49 2017-12-04T02:35:33  <xRavenheart> anyone able to assist me in my queries about a school project please?
 50 2017-12-04T02:40:48  *** dqx has joined #bitcoin-core-dev
 51 2017-12-04T02:41:55  *** Dizzle has joined #bitcoin-core-dev
 52 2017-12-04T02:42:47  *** xRavenheart has quit IRC
 53 2017-12-04T02:47:32  <Randolf> xRavenheart:  What's your school project about?  Bitcoin development?
 54 2017-12-04T02:50:20  *** xRavenheart has joined #bitcoin-core-dev
 55 2017-12-04T02:50:39  <xRavenheart> hi anyone able to assist me in a school project related question?
 56 2017-12-04T02:51:42  <sipa> 02:47:32 < Randolf> xRavenheart:  What's your school project about?  Bitcoin development?
 57 2017-12-04T02:51:44  <luke-jr> xRavenheart: not here
 58 2017-12-04T02:55:03  *** dqx has quit IRC
 59 2017-12-04T02:55:28  <Randolf> luke-jr:  You're right.  However, they just contacted me via PM in response to my response, so they probably have a secondary account watching this channel (I suspect).
 60 2017-12-04T02:58:48  <Dizzle> Randolf: he's here, rejoined. I think luke-jr was just suggesting he ask elsewhere, e.g. #bitcoin
 61 2017-12-04T02:58:58  <sipa> i'm talking in PM to him
 62 2017-12-04T03:00:58  *** baltakatei has quit IRC
 63 2017-12-04T03:03:02  *** jb55 has quit IRC
 64 2017-12-04T03:05:01  <xRavenheart> Ok guys, it seems like i should raise the question here instead of PM-ing
 65 2017-12-04T03:06:01  <xRavenheart> Basically, im a final year student doing FYP and my project scope is to modify on an existing lightweight client by bringing in optimizations from other clients (full/lightweight).
 66 2017-12-04T03:06:19  <Randolf> Dizzle:  Ah, yes.  I suggested that asking here may be appropriate since it might involve core development.  I also suggested that they ask in the #bitcoin and ##altcoins channel.
 67 2017-12-04T03:06:30  <xRavenheart> This optimization may be in any form such as block headers download, transacting speed, retrieving of wallet addresses, etc etc.
 68 2017-12-04T03:06:33  *** zshlyk has quit IRC
 69 2017-12-04T03:06:42  *** Chris_Stewart_5 has quit IRC
 70 2017-12-04T03:07:03  <sipa> xRavenheart: you're welcome here to ask questions about bitcoin's design and operation
 71 2017-12-04T03:07:07  <xRavenheart> E.g. For instance Bitcoin Core has optimizations 1,2 and Electrum has optimizations 3,4
 72 2017-12-04T03:07:21  *** zshlyk has joined #bitcoin-core-dev
 73 2017-12-04T03:07:21  <xRavenheart> I'm required to bring together these optimizations into one application
 74 2017-12-04T03:07:32  <sipa> though as i told, most of that will not be applicable to other types of clients
 75 2017-12-04T03:07:45  <xRavenheart> Is anyone able to first provide me with a clear architecture diagram of bitcoin?
 76 2017-12-04T03:07:58  *** jb55 has joined #bitcoin-core-dev
 77 2017-12-04T03:08:03  <xRavenheart> I've been trying to understand the system but it is way too broad and i have no clear idea of where to start
 78 2017-12-04T03:08:09  <sipa> ii don't think that exists
 79 2017-12-04T03:20:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 80 2017-12-04T03:25:29  *** zshlyk has quit IRC
 81 2017-12-04T03:26:45  *** zshlyk has joined #bitcoin-core-dev
 82 2017-12-04T03:30:05  *** Randolf has quit IRC
 83 2017-12-04T03:37:35  *** Chris_Stewart_5 has quit IRC
 84 2017-12-04T03:42:11  *** jb55 has quit IRC
 85 2017-12-04T03:46:28  *** Randolf has joined #bitcoin-core-dev
 86 2017-12-04T03:51:22  *** jb55 has joined #bitcoin-core-dev
 87 2017-12-04T03:53:05  *** Randolf has quit IRC
 88 2017-12-04T04:00:28  *** arubi has quit IRC
 89 2017-12-04T04:01:25  *** arubi has joined #bitcoin-core-dev
 90 2017-12-04T04:10:33  *** Krellan has quit IRC
 91 2017-12-04T04:11:37  *** Krellan has joined #bitcoin-core-dev
 92 2017-12-04T04:21:20  *** ghost43 has quit IRC
 93 2017-12-04T04:21:20  *** zshlyk has quit IRC
 94 2017-12-04T04:21:20  *** dermoth has quit IRC
 95 2017-12-04T04:21:20  *** arubi has quit IRC
 96 2017-12-04T04:21:35  *** ghost43 has joined #bitcoin-core-dev
 97 2017-12-04T04:21:43  *** arubi has joined #bitcoin-core-dev
 98 2017-12-04T04:23:08  *** zshlyk has joined #bitcoin-core-dev
 99 2017-12-04T04:29:50  *** zshlyk has quit IRC
100 2017-12-04T04:30:25  *** zshlyk has joined #bitcoin-core-dev
101 2017-12-04T04:30:40  *** Randolf has joined #bitcoin-core-dev
102 2017-12-04T04:31:38  *** Randolf has joined #bitcoin-core-dev
103 2017-12-04T04:32:35  *** zshlyk has quit IRC
104 2017-12-04T04:33:28  *** zshlyk has joined #bitcoin-core-dev
105 2017-12-04T04:33:36  *** Krellan has quit IRC
106 2017-12-04T05:08:33  *** roidster has joined #bitcoin-core-dev
107 2017-12-04T05:08:38  *** roidster is now known as Guest94795
108 2017-12-04T05:09:37  *** Guest94795 is now known as roidster
109 2017-12-04T05:10:36  *** zshlyk has quit IRC
110 2017-12-04T05:11:21  *** zshlyk has joined #bitcoin-core-dev
111 2017-12-04T05:12:14  *** Dizzle has quit IRC
112 2017-12-04T05:18:51  *** zshlyk has quit IRC
113 2017-12-04T05:19:35  *** zshlyk has joined #bitcoin-core-dev
114 2017-12-04T05:31:35  *** roidster_ has joined #bitcoin-core-dev
115 2017-12-04T05:32:12  *** roidster has quit IRC
116 2017-12-04T05:32:19  *** roidster_ is now known as roidster
117 2017-12-04T05:32:48  *** roidster is now known as Guest84550
118 2017-12-04T05:33:27  *** Guest84550 is now known as roidster
119 2017-12-04T05:36:03  *** kilicu has joined #bitcoin-core-dev
120 2017-12-04T05:36:41  <achow101> is there any particular reason that Core is using 26 GB of RAM during a reindex?
121 2017-12-04T05:36:52  <achow101> (out of 32 available on my machine)
122 2017-12-04T05:37:03  <gmaxwell> sipa: ^
123 2017-12-04T05:37:04  <achow101> my dbcache is only set to 6000
124 2017-12-04T05:37:10  <gmaxwell> achow101: master, right?
125 2017-12-04T05:37:14  <achow101> gmaxwell: yeah
126 2017-12-04T05:37:35  <gmaxwell> achow101: sipa saw this on his odroid too, thought it was a bug in master, but I think he had some reproduction problems.
127 2017-12-04T05:37:45  <gmaxwell> It may be a leak that depends on particular dependency versions.
128 2017-12-04T05:38:17  <achow101> I can consistently reproduce it by starting it, letting it go, and then waiting for my computer to freeze up.
129 2017-12-04T05:38:26  <achow101> then reboot and repeat :/
130 2017-12-04T05:41:49  <gmaxwell> any chance you could run in valgrind, let it obviously bloat up a bit then issue a clean stop?  if it's a true leak valgrind will report it.
131 2017-12-04T05:42:14  <achow101> Yeah, I'll do that once I reboot it again
132 2017-12-04T05:42:19  <gmaxwell> (I'd bet it's not actually a true leak... we have far too little manual memory management for that to be likely... but worth checking)
133 2017-12-04T05:44:01  <Randolf> I could try running bitcoind to confirm memory usage too -- I've got bitcoind v0.15.1 on Windows 10 (64-bit) handy.
134 2017-12-04T05:44:10  <Randolf> Which command-line parameters are you using?
135 2017-12-04T05:44:35  <gmaxwell> 0.15.1 doesn't exhibit this behavior in any testing we've seen so far.
136 2017-12-04T05:44:43  <Randolf> Oh.  Which version are you using?
137 2017-12-04T05:45:01  <gmaxwell> git master... the current in-development stuff.
138 2017-12-04T05:45:06  <Randolf> Oh.  I see.
139 2017-12-04T05:45:22  <achow101> Some build of master from sometime in the last few days
140 2017-12-04T05:46:00  <achow101> This is fairly recent, I think it's from yesterday or the day before
141 2017-12-04T05:46:05  *** brianhoffman has quit IRC
142 2017-12-04T05:46:16  <achow101> Although maybe I only noticed it now because I had to reindex
143 2017-12-04T05:46:33  <Randolf> Which OS are you running on?
144 2017-12-04T05:46:41  <achow101> Ubuntu 17.10
145 2017-12-04T05:47:08  <Randolf> Oh, I don't have that available.  I have a NetBSD server I could run it on if you need an extra test run.
146 2017-12-04T05:48:04  <Randolf> I'd have to get sync'd though because I don't have bitcoind running there now.  Maybe I should see if I can get it going and get the sync started for now.
147 2017-12-04T05:50:25  <achow101> also, i'm running bitcoin-qt right now, not bitcoind
148 2017-12-04T05:50:54  *** brianhoffman has joined #bitcoin-core-dev
149 2017-12-04T05:57:34  <Randolf> These servers don't have any GUI stuff installed.  So I won't be able to try bitcoin-qt on them.  But I could at least try bitcoin-qt on Windows 10 to confirm whether the same problem occurs cross-platform.
150 2017-12-04T05:58:25  *** ufukkilic has joined #bitcoin-core-dev
151 2017-12-04T05:58:32  *** kilicu has quit IRC
152 2017-12-04T06:01:27  *** nsh has quit IRC
153 2017-12-04T06:03:05  <achow101> btw I'm using commit 00d25e90db06149fa456b0a8f15b7b68005ff9c5 which is the current head of master
154 2017-12-04T06:03:31  *** zshlyk has quit IRC
155 2017-12-04T06:04:22  *** zshlyk has joined #bitcoin-core-dev
156 2017-12-04T06:09:49  <achow101> gmaxwell, sipa: when did you observe this issue on the odroid?
157 2017-12-04T06:13:17  *** nsh has joined #bitcoin-core-dev
158 2017-12-04T06:13:39  *** Taek has quit IRC
159 2017-12-04T06:13:50  *** Taek has joined #bitcoin-core-dev
160 2017-12-04T06:15:11  *** Emcy has joined #bitcoin-core-dev
161 2017-12-04T06:17:35  <Randolf> Hmm, I'm running into problems getting bitcoind compiled on NetBSD, but I've had problems getting other things to compile due to a learning curve on my part so I'll have to work on this.  In the meantime, I'll look into commit 00d25e90db06149fa456b0a8f15b7b68005ff9c5 (as I continue to learn more
162 2017-12-04T06:17:54  *** Emcy_ has quit IRC
163 2017-12-04T06:19:25  <achow101> it might be useful to walk back through the commit history testing each merge until we get to one that doesn't exhibit the leak. that would then tell us what commit introduced the problem, in theory.
164 2017-12-04T06:19:34  <achow101> although that will be very tedious to do
165 2017-12-04T06:19:46  <sipa> achow101: i have a difficult time reproducing it; i just saw it twice
166 2017-12-04T06:19:47  <Randolf> about GitHub) to see if there's something in there that I can test out on Windows.
167 2017-12-04T06:19:56  <sipa> it would be asome if you can bisect
168 2017-12-04T06:20:18  *** roidster has quit IRC
169 2017-12-04T06:20:40  <achow101> sipa: I'm going to try that once I finish this valgrind test
170 2017-12-04T06:20:45  <sipa> great
171 2017-12-04T06:20:52  <achow101> but because it's valgrind, it's going slowly
172 2017-12-04T06:20:55  <sipa> i do know 0.15.1 is unaffected
173 2017-12-04T06:21:31  <achow101> will bisect work with 0.15.1 even though it is not part of master's commit history
174 2017-12-04T06:22:23  <sipa> if not, you can always use the last common forking point between master and 0.15.1 is goof
175 2017-12-04T06:22:36  <achow101> indeed
176 2017-12-04T06:23:01  <sipa> *good, not goof
177 2017-12-04T06:28:24  *** arubi has quit IRC
178 2017-12-04T06:28:48  *** arubi has joined #bitcoin-core-dev
179 2017-12-04T06:30:32  *** zshlyk has quit IRC
180 2017-12-04T06:31:43  *** zshlyk has joined #bitcoin-core-dev
181 2017-12-04T06:35:37  *** xRavenheart has quit IRC
182 2017-12-04T06:38:23  <Varunram> achow101: If you set the dbcache in the GUI, you might be affected by this: #11788
183 2017-12-04T06:38:24  <gribble> https://github.com/bitcoin/bitcoin/issues/11788 | Bitcoin-Qt (Settings) reports incorrect "Size of database cache" · Issue #11788 · bitcoin/bitcoin · GitHub
184 2017-12-04T06:38:34  <achow101> Varunram: bitcoin.conf, not gui
185 2017-12-04T06:38:44  <achow101> I don't use the gui for any settings at all
186 2017-12-04T06:39:31  <Varunram> phew, along those messages, I read somewhere you were running qt, so..
187 2017-12-04T06:39:58  <achow101> I do run qt for testing things, and I noticed this issue while running qt
188 2017-12-04T06:40:05  <sipa> that's very unlikely to be related
189 2017-12-04T06:40:16  <achow101> but I'm just running bitcoind in valgrind right now
190 2017-12-04T06:40:22  <Varunram> yep, mostly not :) just wondered
191 2017-12-04T06:47:02  *** ghost43 has quit IRC
192 2017-12-04T06:47:17  *** ghost43 has joined #bitcoin-core-dev
193 2017-12-04T07:01:10  <achow101> damn valgrind is slow
194 2017-12-04T07:03:13  <eck> should be about 10x slower
195 2017-12-04T07:03:53  <sipa> much worse for cryptographic code
196 2017-12-04T07:04:07  <achow101> It's still in the rescanning part of init
197 2017-12-04T07:04:32  <eck> the actual numbers depend on how many memory accesses you are doing, all of the instructions that hit main memory are "emulated"
198 2017-12-04T07:04:53  <sipa> all instructions are emulated
199 2017-12-04T07:05:00  <sipa> it's not like it's running in a VM
200 2017-12-04T07:05:21  <sipa> but memory access get additional instrumentation
201 2017-12-04T07:06:12  <eck> i thought it worked by rewriting all of the instructions that access main memory, and then sort of fusing the non-memory instructions, i read julian seward's paper on it a long time ago
202 2017-12-04T07:06:28  <eck> but i certainly could be wrong
203 2017-12-04T07:06:40  <sipa> hmm, so could i
204 2017-12-04T07:06:45  *** jb55 has quit IRC
205 2017-12-04T07:08:46  <sipa> i didn't know it was that advanced, actually but it certainly could be
206 2017-12-04T07:13:48  <eck> in some cases it has to emulate cpu registers, in other cases the emulated cpu register may be the actual host cpu registers, section 3.4 http://www.valgrind.org/docs/valgrind2007.pdf
207 2017-12-04T07:14:19  <eck> clearly if the registers need to be emulated the overhead will be quite high
208 2017-12-04T07:23:48  *** zshlyk has quit IRC
209 2017-12-04T07:24:39  *** zshlyk has joined #bitcoin-core-dev
210 2017-12-04T07:26:17  *** jtimon has quit IRC
211 2017-12-04T07:32:36  *** zshlyk has quit IRC
212 2017-12-04T07:33:44  *** zshlyk has joined #bitcoin-core-dev
213 2017-12-04T07:33:47  *** indistylo has joined #bitcoin-core-dev
214 2017-12-04T07:34:20  *** roidster has joined #bitcoin-core-dev
215 2017-12-04T07:34:52  *** roidster is now known as Guest82416
216 2017-12-04T07:39:07  *** Ylbam has joined #bitcoin-core-dev
217 2017-12-04T07:44:34  *** arubi has quit IRC
218 2017-12-04T07:44:37  *** arubi_ has joined #bitcoin-core-dev
219 2017-12-04T07:47:47  *** Guest82416 has quit IRC
220 2017-12-04T07:48:09  <Randolf> Well, I was unsuccessful at getting bitcoind to compile on NetBSD because of problems with Berkeley DB API function naming, and Boost incompatibility problems.  I'll have to try again when get some more time (and I will try again).
221 2017-12-04T07:52:40  *** meshcollider has joined #bitcoin-core-dev
222 2017-12-04T08:07:34  *** gwillen has quit IRC
223 2017-12-04T08:07:53  <eck> fyi if you run configure with --disable-wallet you don't need berkeleydb, which would just leave you to figure out boost
224 2017-12-04T08:14:32  *** zshlyk has quit IRC
225 2017-12-04T08:16:27  *** zshlyk has joined #bitcoin-core-dev
226 2017-12-04T08:18:29  <achow101> I gave up on valgrind. It was doing the rescanning thing and moving at one percent per hour. I'm going to do the git bisect stuff tomorrow
227 2017-12-04T08:27:29  <eck> were you using massif or memcheck?
228 2017-12-04T08:27:35  <achow101> memcheck
229 2017-12-04T08:27:50  <eck> massif will just straight up tell you at any given point of time, where all the allocations came from
230 2017-12-04T08:28:26  <eck> which is useful if you can't wait for the program to run to completion
231 2017-12-04T08:28:56  <eck> iirc it's even slower than memcheck though
232 2017-12-04T08:28:58  <achow101> the problem was that it wasn't getting passed the init part. the leak is definitely coming from somwehere past the init part
233 2017-12-04T08:30:07  <eck> i have heard that ASAN is faster than valgrind but i haven't used it
234 2017-12-04T08:30:18  <eck> http://www.chromium.org/developers/testing/addresssanitizer http://www.chromium.org/developers/testing/leaksanitizer
235 2017-12-04T08:30:20  <eck> it's built into vlang
236 2017-12-04T08:30:22  <eck> *clang
237 2017-12-04T08:31:37  <eck> this is for a rescan?
238 2017-12-04T08:32:44  <achow101> reindex
239 2017-12-04T08:33:07  <achow101> the rescan I think is part of the reindex because the reindex was killed before it flushed
240 2017-12-04T08:35:00  <eck> i might take a look at that this week (if i can reproduce it), i was interested in generally profiling bitocind -reindex using systemtap
241 2017-12-04T08:37:24  <achow101> made an issue for this #11822
242 2017-12-04T08:37:26  <gribble> https://github.com/bitcoin/bitcoin/issues/11822 | Severe memory leak on current master · Issue #11822 · bitcoin/bitcoin · GitHub
243 2017-12-04T08:48:31  *** noglar_ has quit IRC
244 2017-12-04T08:59:25  <Randolf> eck:  Thanks.  There's an incompatibility because I have the wrong version of Boost.
245 2017-12-04T09:00:09  <eck> it is pretty straightforward to build, if you have the patience
246 2017-12-04T09:01:10  *** noglar_ has joined #bitcoin-core-dev
247 2017-12-04T09:01:32  <Randolf> eck:  I have plenty of patience, but my problem is meeting other deadlines at the moment so I've put this on hold for now.  I also need to learn more about compiling.
248 2017-12-04T09:07:02  *** timothy has joined #bitcoin-core-dev
249 2017-12-04T09:13:02  *** laurentmt has joined #bitcoin-core-dev
250 2017-12-04T09:13:48  *** timothy has joined #bitcoin-core-dev
251 2017-12-04T09:17:07  <achow101> I fairly quick and rather unscientific git bisect says that e545dedf72bff2bd41c93c93eb576929fce37112 is the commit that introduces the problem.
252 2017-12-04T09:17:39  <achow101> so if you want to investigate, that commit and commits in its vicinity should be looked at. But I need to sleep, so I'll look at it tomorrow.
253 2017-12-04T09:18:06  *** eck has quit IRC
254 2017-12-04T09:18:36  *** eck has joined #bitcoin-core-dev
255 2017-12-04T09:18:55  *** tiagotrs has joined #bitcoin-core-dev
256 2017-12-04T09:29:36  *** zshlyk has quit IRC
257 2017-12-04T09:34:07  *** rtm1046 has joined #bitcoin-core-dev
258 2017-12-04T09:35:31  *** zshlyk has joined #bitcoin-core-dev
259 2017-12-04T09:38:51  *** promag has joined #bitcoin-core-dev
260 2017-12-04T09:53:37  *** rtm1046 has quit IRC
261 2017-12-04T09:55:14  *** ghost43 has quit IRC
262 2017-12-04T09:55:17  *** ufukkilic has quit IRC
263 2017-12-04T09:55:50  *** ghost43 has joined #bitcoin-core-dev
264 2017-12-04T09:57:51  *** go1111111 has quit IRC
265 2017-12-04T10:01:38  *** go1111111 has joined #bitcoin-core-dev
266 2017-12-04T10:10:42  *** warxhead has quit IRC
267 2017-12-04T10:14:33  *** zshlyk has quit IRC
268 2017-12-04T10:15:37  *** zshlyk has joined #bitcoin-core-dev
269 2017-12-04T10:16:12  *** ghost43 has quit IRC
270 2017-12-04T10:26:50  *** ghost43 has joined #bitcoin-core-dev
271 2017-12-04T10:32:42  *** go1111111 has quit IRC
272 2017-12-04T10:48:10  *** dermoth has joined #bitcoin-core-dev
273 2017-12-04T10:48:27  *** mryandao has quit IRC
274 2017-12-04T10:48:56  *** jtimon has joined #bitcoin-core-dev
275 2017-12-04T10:50:12  *** arubi_ has quit IRC
276 2017-12-04T10:50:32  *** arubi has joined #bitcoin-core-dev
277 2017-12-04T10:54:39  *** zshlyk has quit IRC
278 2017-12-04T10:55:25  *** zshlyk has joined #bitcoin-core-dev
279 2017-12-04T11:04:03  *** mryandao has joined #bitcoin-core-dev
280 2017-12-04T11:05:03  *** zshlyk has quit IRC
281 2017-12-04T11:05:25  *** zshlyk has joined #bitcoin-core-dev
282 2017-12-04T11:06:37  *** zshlyk has quit IRC
283 2017-12-04T11:07:57  *** zshlyk has joined #bitcoin-core-dev
284 2017-12-04T11:08:38  *** go1111111 has joined #bitcoin-core-dev
285 2017-12-04T11:13:59  *** go1111111 has quit IRC
286 2017-12-04T11:14:10  *** dqx has joined #bitcoin-core-dev
287 2017-12-04T11:16:16  *** SopaXorzTaker has joined #bitcoin-core-dev
288 2017-12-04T11:17:53  *** tiagotrs has quit IRC
289 2017-12-04T11:18:29  *** dqx has quit IRC
290 2017-12-04T11:18:29  *** Victorsueca has quit IRC
291 2017-12-04T11:19:52  *** Victorsueca has joined #bitcoin-core-dev
292 2017-12-04T11:29:22  *** mmhhtt has joined #bitcoin-core-dev
293 2017-12-04T11:31:26  *** laurentmt has quit IRC
294 2017-12-04T11:31:51  *** tiagotrs has joined #bitcoin-core-dev
295 2017-12-04T11:32:21  *** dqx has joined #bitcoin-core-dev
296 2017-12-04T11:32:22  <mmhhtt> Hello, Is there anyone knows to how can build a exchange market for other country? Is there any request from bitcoin company to me for making exc market?
297 2017-12-04T11:33:13  <mmhhtt> also how can work payment for buy/sell btc for other country local money?
298 2017-12-04T11:39:42  *** promag has quit IRC
299 2017-12-04T11:43:21  *** dqx has quit IRC
300 2017-12-04T11:45:12  *** go1111111 has joined #bitcoin-core-dev
301 2017-12-04T12:04:52  *** dqx has joined #bitcoin-core-dev
302 2017-12-04T12:08:22  *** str4d has quit IRC
303 2017-12-04T12:13:43  <sipa> achow101: that's what i feared...
304 2017-12-04T12:14:49  *** wxss has joined #bitcoin-core-dev
305 2017-12-04T12:15:23  *** dqx has quit IRC
306 2017-12-04T12:16:20  *** dqx has joined #bitcoin-core-dev
307 2017-12-04T12:22:02  *** dqx has quit IRC
308 2017-12-04T12:26:04  *** zshlyk has quit IRC
309 2017-12-04T12:26:54  *** zshlyk has joined #bitcoin-core-dev
310 2017-12-04T12:27:22  *** dabura667 has quit IRC
311 2017-12-04T12:28:46  *** zshlyk has quit IRC
312 2017-12-04T12:29:49  *** zshlyk has joined #bitcoin-core-dev
313 2017-12-04T12:43:57  *** meshcollider has quit IRC
314 2017-12-04T13:10:13  *** RK_ has joined #bitcoin-core-dev
315 2017-12-04T13:11:01  <RK_> Hello
316 2017-12-04T13:11:48  <RK_> I want to know about bitcoin
317 2017-12-04T13:14:56  *** RK_ has quit IRC
318 2017-12-04T13:17:14  *** dreamrunner has joined #bitcoin-core-dev
319 2017-12-04T13:21:09  *** zshlyk has quit IRC
320 2017-12-04T13:21:55  *** dreamrunner has quit IRC
321 2017-12-04T13:21:55  *** zshlyk has joined #bitcoin-core-dev
322 2017-12-04T13:23:31  *** laurentmt has joined #bitcoin-core-dev
323 2017-12-04T13:25:34  *** laurentmt has quit IRC
324 2017-12-04T13:25:35  *** zshlyk has quit IRC
325 2017-12-04T13:26:45  *** zshlyk has joined #bitcoin-core-dev
326 2017-12-04T13:28:11  <mmhhtt> #bitcoin-core-dev
327 2017-12-04T13:28:16  <mmhhtt> hello
328 2017-12-04T13:28:39  <mmhhtt> Is there any one?
329 2017-12-04T13:30:12  *** mmhhtt has quit IRC
330 2017-12-04T13:47:13  *** jtimon has quit IRC
331 2017-12-04T13:49:33  *** dermoth has quit IRC
332 2017-12-04T13:50:42  *** dermoth has joined #bitcoin-core-dev
333 2017-12-04T13:51:27  *** tiagotrs has quit IRC
334 2017-12-04T13:52:42  *** laurentmt has joined #bitcoin-core-dev
335 2017-12-04T13:54:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
336 2017-12-04T13:57:10  *** promag has joined #bitcoin-core-dev
337 2017-12-04T14:03:35  *** zshlyk has quit IRC
338 2017-12-04T14:04:30  *** zshlyk has joined #bitcoin-core-dev
339 2017-12-04T14:11:40  *** zshlyk has quit IRC
340 2017-12-04T14:12:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
341 2017-12-04T14:12:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
342 2017-12-04T14:12:39  *** notabot_ has joined #bitcoin-core-dev
343 2017-12-04T14:12:55  *** zshlyk has joined #bitcoin-core-dev
344 2017-12-04T14:16:45  <notabot_> mmhhtt: try #bitcoin channel or reddit
345 2017-12-04T14:17:37  <notabot_> RK_: bitcoin.org is the best place to start.
346 2017-12-04T14:17:57  *** notabot_ has quit IRC
347 2017-12-04T14:24:17  *** Murphy40Hermann has joined #bitcoin-core-dev
348 2017-12-04T14:29:27  *** Chris_Stewart_5 has quit IRC
349 2017-12-04T14:32:24  *** rafalcpp has quit IRC
350 2017-12-04T14:32:45  *** rafalcpp has joined #bitcoin-core-dev
351 2017-12-04T14:33:20  *** laurentmt has quit IRC
352 2017-12-04T14:43:20  *** CubicEarth has joined #bitcoin-core-dev
353 2017-12-04T14:46:55  *** arubi has quit IRC
354 2017-12-04T14:48:07  *** arubi has joined #bitcoin-core-dev
355 2017-12-04T14:49:23  *** dqx has joined #bitcoin-core-dev
356 2017-12-04T14:53:27  *** dqx has quit IRC
357 2017-12-04T14:54:21  *** CubicEarth has quit IRC
358 2017-12-04T15:02:08  *** indistylo has quit IRC
359 2017-12-04T15:07:32  *** dqx has joined #bitcoin-core-dev
360 2017-12-04T15:08:10  *** izadev has joined #bitcoin-core-dev
361 2017-12-04T15:08:38  *** izadev has quit IRC
362 2017-12-04T15:09:31  *** dqx has quit IRC
363 2017-12-04T15:10:57  *** Victorsueca has quit IRC
364 2017-12-04T15:11:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
365 2017-12-04T15:11:59  *** Chris_Stewart_5 has quit IRC
366 2017-12-04T15:12:09  *** Victorsueca has joined #bitcoin-core-dev
367 2017-12-04T15:19:29  *** wxss has quit IRC
368 2017-12-04T15:24:46  *** roidster has joined #bitcoin-core-dev
369 2017-12-04T15:24:46  *** roidster is now known as Guest37184
370 2017-12-04T15:25:27  *** Guest37184 is now known as roidster
371 2017-12-04T15:26:25  *** zshlyk has quit IRC
372 2017-12-04T15:26:34  *** yoctopede has joined #bitcoin-core-dev
373 2017-12-04T15:28:25  *** jtimon has joined #bitcoin-core-dev
374 2017-12-04T15:32:54  *** saint_ has joined #bitcoin-core-dev
375 2017-12-04T15:34:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
376 2017-12-04T15:39:51  *** laurentmt has joined #bitcoin-core-dev
377 2017-12-04T15:41:39  *** yoctopede has quit IRC
378 2017-12-04T15:42:23  *** yoctopede has joined #bitcoin-core-dev
379 2017-12-04T15:54:24  *** Murch has joined #bitcoin-core-dev
380 2017-12-04T16:00:09  *** tiagotrs has joined #bitcoin-core-dev
381 2017-12-04T16:00:10  *** tiagotrs has joined #bitcoin-core-dev
382 2017-12-04T16:03:02  *** yoctopede has quit IRC
383 2017-12-04T16:03:54  *** yoctopede has joined #bitcoin-core-dev
384 2017-12-04T16:04:09  <BlueMatt> sipa: #11403 looks to have failed travis to to a bad iterator deref ( https://travis-ci.org/bitcoin/bitcoin/jobs/309801879#L2838 )
385 2017-12-04T16:04:14  <gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
386 2017-12-04T16:05:23  *** roidster has quit IRC
387 2017-12-04T16:06:53  *** wxss has joined #bitcoin-core-dev
388 2017-12-04T16:07:41  *** yoctopede has quit IRC
389 2017-12-04T16:08:29  *** yoctopede has joined #bitcoin-core-dev
390 2017-12-04T16:23:07  *** Guyver2 has joined #bitcoin-core-dev
391 2017-12-04T16:25:11  *** Emcy_ has joined #bitcoin-core-dev
392 2017-12-04T16:26:26  *** promag has quit IRC
393 2017-12-04T16:26:38  *** wxss has quit IRC
394 2017-12-04T16:27:45  *** wxss has joined #bitcoin-core-dev
395 2017-12-04T16:28:41  *** roidster has joined #bitcoin-core-dev
396 2017-12-04T16:28:51  *** Emcy has quit IRC
397 2017-12-04T16:29:04  *** roidster is now known as Guest290
398 2017-12-04T16:29:05  *** Guest290 is now known as roidster
399 2017-12-04T16:40:32  *** Dizzle has joined #bitcoin-core-dev
400 2017-12-04T16:49:12  *** roidster_ has joined #bitcoin-core-dev
401 2017-12-04T16:49:41  *** roidster has quit IRC
402 2017-12-04T16:49:44  *** roidster_ is now known as roidster
403 2017-12-04T16:49:47  *** Randolf has quit IRC
404 2017-12-04T16:59:22  *** AaronvanW has joined #bitcoin-core-dev
405 2017-12-04T17:00:26  *** Murphy40Hermann has quit IRC
406 2017-12-04T17:00:32  *** Aaronvan_ has joined #bitcoin-core-dev
407 2017-12-04T17:04:22  *** AaronvanW has quit IRC
408 2017-12-04T17:14:32  *** musalbas has quit IRC
409 2017-12-04T17:25:42  *** microapple has joined #bitcoin-core-dev
410 2017-12-04T17:26:36  *** yoctopede has quit IRC
411 2017-12-04T17:27:01  *** promag has joined #bitcoin-core-dev
412 2017-12-04T17:27:47  *** yoctopede has joined #bitcoin-core-dev
413 2017-12-04T17:30:55  *** Randolf has joined #bitcoin-core-dev
414 2017-12-04T17:37:40  *** timothy has quit IRC
415 2017-12-04T17:44:02  *** gevs has joined #bitcoin-core-dev
416 2017-12-04T17:49:26  *** microapple has quit IRC
417 2017-12-04T17:51:11  *** laurentmt has quit IRC
418 2017-12-04T17:56:27  *** jb55 has joined #bitcoin-core-dev
419 2017-12-04T17:58:19  *** indistylo has joined #bitcoin-core-dev
420 2017-12-04T18:01:55  *** microapple has joined #bitcoin-core-dev
421 2017-12-04T18:05:17  *** Randolf has quit IRC
422 2017-12-04T18:08:21  *** jb55 has quit IRC
423 2017-12-04T18:16:21  *** Emcy has joined #bitcoin-core-dev
424 2017-12-04T18:18:22  *** Emcy_ has quit IRC
425 2017-12-04T18:22:37  *** yoctopede has quit IRC
426 2017-12-04T18:23:37  *** yoctopede has joined #bitcoin-core-dev
427 2017-12-04T18:23:58  *** Randolf has joined #bitcoin-core-dev
428 2017-12-04T18:26:59  <BlueMatt> wumpus: I believe #10773 can be merge
429 2017-12-04T18:27:00  <BlueMatt> d
430 2017-12-04T18:27:01  <gribble> https://github.com/bitcoin/bitcoin/issues/10773 | Shell script cleanups by practicalswift · Pull Request #10773 · bitcoin/bitcoin · GitHub
431 2017-12-04T18:42:42  *** Randolf has quit IRC
432 2017-12-04T18:44:27  *** Emcy_ has joined #bitcoin-core-dev
433 2017-12-04T18:46:55  *** Emcy has quit IRC
434 2017-12-04T18:47:11  <BlueMatt> achow101: ping
435 2017-12-04T18:47:20  <BlueMatt> can you reliably reproduce #11822 ?
436 2017-12-04T18:47:21  <gribble> https://github.com/bitcoin/bitcoin/issues/11822 | Severe memory leak on current master · Issue #11822 · bitcoin/bitcoin · GitHub
437 2017-12-04T18:47:24  <achow101> BlueMatt: pong-ish
438 2017-12-04T18:47:26  <achow101> yes
439 2017-12-04T18:47:27  *** Emcy has joined #bitcoin-core-dev
440 2017-12-04T18:48:08  *** gwillen has joined #bitcoin-core-dev
441 2017-12-04T18:48:16  <achow101> I'm trying it in valgrind again, it's still going very slowly
442 2017-12-04T18:49:05  *** Emcy_ has quit IRC
443 2017-12-04T18:50:18  <BlueMatt> sec, I doubt its actually a leak, maybe just validation running ahead of wallet
444 2017-12-04T18:50:22  <BlueMatt> do you have a big(ish) wallet?
445 2017-12-04T18:51:06  <BlueMatt> achow101: can you try https://github.com/TheBlueMatt/bitcoin/tree/2017-12-11822-debug and see what debug log looks like?
446 2017-12-04T18:51:16  <BlueMatt> do you get a ton of events generated and then not executed?
447 2017-12-04T18:51:47  * BlueMatt didnt think this bug was realistically worse than previous master, but it may be, wasnt sure...
448 2017-12-04T18:54:36  *** DvdKhl has joined #bitcoin-core-dev
449 2017-12-04T18:55:49  *** yoctopede has quit IRC
450 2017-12-04T18:56:36  *** yoctopede has joined #bitcoin-core-dev
451 2017-12-04T19:00:43  *** yoctopede has quit IRC
452 2017-12-04T19:01:34  *** yoctopede has joined #bitcoin-core-dev
453 2017-12-04T19:02:40  <achow101> BlueMatt: the wallet is literally empty
454 2017-12-04T19:02:50  <achow101> I haven't used it; it's completely fresh
455 2017-12-04T19:02:56  <BlueMatt> but it has a wallet?
456 2017-12-04T19:03:00  <achow101> yes
457 2017-12-04T19:03:05  <BlueMatt> can you test with that patch? may be a lock issue or so
458 2017-12-04T19:03:35  <achow101> I'll try as soon as it responds to the stop command
459 2017-12-04T19:06:19  <GAit> am I correct if I say that the rpc doesn't support socket file?
460 2017-12-04T19:06:48  <sipa> GAit: what rpc?
461 2017-12-04T19:07:10  <GAit> bitcoin core rpc. Using a socket file rather than a port
462 2017-12-04T19:07:46  <achow101> GAit: as in unix sockets?
463 2017-12-04T19:07:49  <sipa> iirc there was a PR for that, but it needed a new version of libevent at the time
464 2017-12-04T19:07:55  <BlueMatt> it does not (currently), I believe wumpus had some stuff to get it to work, but ...yea, libevent
465 2017-12-04T19:08:03  <GAit> yes. Thinking because of Abcore. Other apps  could connect to it.
466 2017-12-04T19:08:17  <GAit> with a socket file i can prevent that. android app have a different user per app
467 2017-12-04T19:08:21  *** SopaXorzTaker has quit IRC
468 2017-12-04T19:08:23  <achow101> #9979
469 2017-12-04T19:08:25  <gribble> https://github.com/bitcoin/bitcoin/issues/9979 | p2p: Bare minimum to support UNIX sockets by laanwj · Pull Request #9979 · bitcoin/bitcoin · GitHub
470 2017-12-04T19:08:43  <achow101> and #9919
471 2017-12-04T19:08:46  <gribble> https://github.com/bitcoin/bitcoin/issues/9919 | UNIX sockets support for RPC by laanwj · Pull Request #9919 · bitcoin/bitcoin · GitHub
472 2017-12-04T19:08:46  <GAit> I managed to compile core for android with ndk by the way, which means i don't need the glibc hack + ld library path with archlinux/debian glibc
473 2017-12-04T19:09:48  <GAit> thanks sipa & achow101
474 2017-12-04T19:10:14  *** Emcy has quit IRC
475 2017-12-04T19:12:07  <sipa> GAit: cool!
476 2017-12-04T19:22:58  *** jb55 has joined #bitcoin-core-dev
477 2017-12-04T19:24:32  *** yoctopede has quit IRC
478 2017-12-04T19:24:55  *** intcat has joined #bitcoin-core-dev
479 2017-12-04T19:29:33  <achow101> BlueMatt: running your patch now. what exactly do you want?
480 2017-12-04T19:30:56  <BlueMatt> achow101: looking for a pattern of debug.log entries like a bunch of "X event queued!" but not (enough) corresponding "X event executing..."
481 2017-12-04T19:30:56  <BlueMatt> s
482 2017-12-04T19:31:02  <BlueMatt> (or just paste debug log
483 2017-12-04T19:31:47  <achow101> eyballing this debug.log tail looks like each one is properly paired
484 2017-12-04T19:31:57  <BlueMatt> hmmm, ok, so not the issue i assumed :(
485 2017-12-04T19:32:00  <BlueMatt> but the memory is growing?
486 2017-12-04T19:32:07  <achow101> yes
487 2017-12-04T19:32:14  <BlueMatt> hmmmm
488 2017-12-04T19:32:24  <achow101> not as quickly as yesterday since I dropped the dbcache, but growing much faster than it did with 0.15.1
489 2017-12-04T19:32:25  <BlueMatt> ok, then its news to me, have you checked a heap profile?
490 2017-12-04T19:32:39  <achow101> no
491 2017-12-04T19:33:30  <BlueMatt> well i guess thats next? (did valgrind give you any actual leaks?)
492 2017-12-04T19:33:36  <BlueMatt> i assuming circular shared_ptr refs
493 2017-12-04T19:36:07  *** wunpunch has joined #bitcoin-core-dev
494 2017-12-04T19:36:16  <achow101> valgrind... died
495 2017-12-04T19:36:21  <achow101> (I killed it)
496 2017-12-04T19:37:11  <BlueMatt> ah :/
497 2017-12-04T19:38:01  <achow101> but while it was running it did not output anything
498 2017-12-04T19:39:12  <achow101> I'll try it again and be more patient this time
499 2017-12-04T19:42:23  *** tiagotrs has quit IRC
500 2017-12-04T19:43:31  *** Emcy has joined #bitcoin-core-dev
501 2017-12-04T19:51:58  <ryanofsky> it's pretty use address sanitizer too. just: "./configure CXX=clang++ CXXFLAGS=-fsanitize=address LDFLAGS=-fsanitize=address" and run normally. it prints leaks at the end
502 2017-12-04T19:54:21  <BlueMatt> ugh, fuck you cfields, you sent me down a rabbit hole to replace cvBlockChanged with CValidationInterface, but I think I decided that has to wait on replacing the signals backend with our own thing
503 2017-12-04T19:55:14  <BlueMatt> cause you really end up wanting the validation interface stuff to have eg two threads where the ordering guarantees are only made per-client, and each new client that gets connected only receives events generated *after* when it was connected
504 2017-12-04T19:55:15  <cfields> BlueMatt: heh, sorry
505 2017-12-04T19:55:38  <BlueMatt> (pretty easy to do, I think, you just make events eg a struct and put shared_ptrs to it in each listener's queue)
506 2017-12-04T19:55:56  <BlueMatt> but its way more work than just fixing a fucking missing cs_main
507 2017-12-04T19:56:08  <BlueMatt> and is gonna have to wait for 20 other higher-priority things
508 2017-12-04T19:57:23  <achow101> ryanofsky: will try that at some point
509 2017-12-04T19:57:30  <BlueMatt> the cvBlockChanged/csBestBlock garbage is....garbage now that we have "real interfaces" to get notifications of validation events
510 2017-12-04T19:59:45  <cfields> BlueMatt: fwiw, i was picturing just adding a cached uint256 and a function to update it rather than notifying the cv directly
511 2017-12-04T20:00:19  <BlueMatt> i know you were, but lets *please* not add more in-thread callbacks out of validation :(
512 2017-12-04T20:00:28  <BlueMatt> I've been working too hard to get rid of those things
513 2017-12-04T20:00:28  <cfields> i understand your point about using our interfaces. but weighing quick fix against quick fix, that seems better to me
514 2017-12-04T20:00:46  <BlueMatt> meh, its a short cs_main, why not just take the cs_main
515 2017-12-04T20:02:47  <cfields> i'm worried that we'll end up locked there for milliseconds where we wouldn't have otherwise. Granted, the re-locking of cs_main at the bottom kinda nullifies that argument.
516 2017-12-04T20:03:03  <BlueMatt> yea, we re-lock anyway
517 2017-12-04T20:03:21  <BlueMatt> and, more importantly no one uses longpolling anyway
518 2017-12-04T20:03:22  <BlueMatt> afaiu
519 2017-12-04T20:04:10  *** promag has quit IRC
520 2017-12-04T20:04:25  *** promag has joined #bitcoin-core-dev
521 2017-12-04T20:06:07  <BlueMatt> achow101: you said you can repro by just -reindex'ing?
522 2017-12-04T20:06:13  <achow101> BlueMatt: yes
523 2017-12-04T20:12:01  *** indistylo has quit IRC
524 2017-12-04T20:12:51  *** intcat has quit IRC
525 2017-12-04T20:13:36  *** intcat has joined #bitcoin-core-dev
526 2017-12-04T20:14:07  *** gevs has quit IRC
527 2017-12-04T20:24:51  *** Cheeseo has joined #bitcoin-core-dev
528 2017-12-04T20:25:21  *** wunpunch has quit IRC
529 2017-12-04T20:25:31  <BlueMatt> concept review on #11799 would be appreciated - ignore the code thats there, its useless, but the question is do we want negative-lock-annotations (ie you may not hold cs_main when calling function x) when they are only enforced if the lock is taken directly in the calling function (unlike the requires-lock annotations, these ones dont require you pollute your entire codebase to fully document locking states)
530 2017-12-04T20:25:32  *** laurentmt has joined #bitcoin-core-dev
531 2017-12-04T20:25:33  <gribble> https://github.com/bitcoin/bitcoin/issues/11799 | wallet: Add compile-time checking of (non-)locking assumptions for BlockUntilSyncedToCurrentChain() [wip] by practicalswift · Pull Request #11799 · bitcoin/bitcoin · GitHub
532 2017-12-04T20:25:37  *** wunpunch has joined #bitcoin-core-dev
533 2017-12-04T20:26:37  <BlueMatt> someone want to close #11823 as NOTABUG
534 2017-12-04T20:26:38  <gribble> https://github.com/bitcoin/bitcoin/issues/11823 | Shouldnt this be nOut? · Issue #11823 · bitcoin/bitcoin · GitHub
535 2017-12-04T20:27:35  *** laurentmt has quit IRC
536 2017-12-04T20:29:30  <bitcoin-git> [bitcoin] practicalswift closed pull request #11799: wallet: Add compile-time checking of (non-)locking assumptions for BlockUntilSyncedToCurrentChain() [wip] (master...BlockUntilSyncedToCurrentChain-compile-time-warnings) https://github.com/bitcoin/bitcoin/pull/11799
537 2017-12-04T20:30:38  *** intcat has quit IRC
538 2017-12-04T20:31:52  *** intcat has joined #bitcoin-core-dev
539 2017-12-04T20:35:06  *** arubi has quit IRC
540 2017-12-04T20:35:30  *** arubi has joined #bitcoin-core-dev
541 2017-12-04T20:40:19  <achow101> hmm. valgrind didn't turn up with anything too frightetning, nor did the address sanitizer
542 2017-12-04T20:40:46  <achow101> only 160 bytes leaked (granted I only ran then for ~10 minutes each)
543 2017-12-04T20:42:36  <BlueMatt> achow101: nvm, i got it
544 2017-12-04T20:42:37  *** promag has quit IRC
545 2017-12-04T20:42:47  <achow101> .. ok?
546 2017-12-04T20:43:59  <achow101> BlueMatt: got it as in reproduced or found the leak?
547 2017-12-04T20:44:20  <BlueMatt> working on fix
548 2017-12-04T20:44:20  <BlueMatt> sec
549 2017-12-04T20:54:41  <BlueMatt> achow101: heh, well maybe I didnt have it, can repro and ran into a seemingly-related bug, however
550 2017-12-04T20:58:48  *** jnewbery_ is now known as jnewbery
551 2017-12-04T21:01:10  *** Aaronvan_ is now known as AaronvanW
552 2017-12-04T21:05:09  <BlueMatt> achow101: nope, nvm, my first guess was right
553 2017-12-04T21:05:48  <sipa> BlueMatt: care to elaborate?
554 2017-12-04T21:06:20  <BlueMatt> validation running ahead of validationinterface, you end up with a deep queue of shared_ptr<CBlock>s of all the shit you connected
555 2017-12-04T21:06:36  <BlueMatt> not normally an issue, but reindex is particularly easy to hit there
556 2017-12-04T21:07:09  <sipa> i would guess the solution is to block progress if the queue gets too long?
557 2017-12-04T21:07:31  <BlueMatt> indeed
558 2017-12-04T21:08:33  *** tiagotrs has joined #bitcoin-core-dev
559 2017-12-04T21:10:24  <achow101> BlueMatt: oh, I see now. so that's probably why valgrind and address sanitizer wasn't catching it
560 2017-12-04T21:11:02  <BlueMatt> its not a leak, thats why :p
561 2017-12-04T21:11:08  <BlueMatt> just an unbounded queue
562 2017-12-04T21:12:15  <achow101> was my git bisect correct?
563 2017-12-04T21:12:21  <BlueMatt> yes
564 2017-12-04T21:12:28  <achow101> :D
565 2017-12-04T21:14:54  *** intcat has quit IRC
566 2017-12-04T21:16:41  *** intcat has joined #bitcoin-core-dev
567 2017-12-04T21:17:49  *** tiagotrs has quit IRC
568 2017-12-04T21:17:50  *** tiagotrs has joined #bitcoin-core-dev
569 2017-12-04T21:18:10  *** Victorsueca has quit IRC
570 2017-12-04T21:19:24  *** Victorsueca has joined #bitcoin-core-dev
571 2017-12-04T21:19:30  *** roidster has quit IRC
572 2017-12-04T21:24:32  *** Randolf has joined #bitcoin-core-dev
573 2017-12-04T21:24:34  *** rhavar has joined #bitcoin-core-dev
574 2017-12-04T21:32:15  *** shesek has quit IRC
575 2017-12-04T21:41:42  <cfields> BlueMatt: Hmm. doesn't that imply that at the time something (say wallet) is running a callback, chainActive's tip could've progressed significantly past the payload block?
576 2017-12-04T21:42:07  <BlueMatt> cfields: yes, but that was always assumed to be allowed?
577 2017-12-04T21:43:08  *** Emcy_ has joined #bitcoin-core-dev
578 2017-12-04T21:43:28  <BlueMatt> cfields: heh, you're gonna murder me...the "quick fix" for this requires a net_processing-specific CNode boolean to be added :/
579 2017-12-04T21:43:37  <cfields> BlueMatt: how would that have manifested before moving to the scheduler thread?
580 2017-12-04T21:43:50  <BlueMatt> well, the "super quick fix" is to add a bunch of std::this_thread::yield()s, butttt....
581 2017-12-04T21:44:08  <BlueMatt> cfields: it wouldnt have, cause the calls are all on the thread that is generating the events
582 2017-12-04T21:44:46  <cfields> BlueMatt: right. I'm trying to reconsile that with "yes, but that was always assumed to be allowed?"
583 2017-12-04T21:45:17  <BlueMatt> oh, sorry, yes, just meant that that is the design of validationinterface now
584 2017-12-04T21:45:30  <BlueMatt> ie shouldnt be news if you reviewed the last 5 prs :p
585 2017-12-04T21:45:41  *** Emcy has quit IRC
586 2017-12-04T21:46:21  <cfields> well i didn't have this issue in mind, as I was still thinking too serially. Now I need to go re-review :(
587 2017-12-04T21:46:39  <BlueMatt> heh, sorry
588 2017-12-04T21:46:42  *** jamesob has joined #bitcoin-core-dev
589 2017-12-04T21:46:44  <cfields> *synchronously
590 2017-12-04T21:48:51  *** shesek has joined #bitcoin-core-dev
591 2017-12-04T21:48:52  *** shesek has joined #bitcoin-core-dev
592 2017-12-04T21:49:15  *** r0d3r5 has joined #bitcoin-core-dev
593 2017-12-04T21:52:40  *** r0d3r5 has quit IRC
594 2017-12-04T22:01:30  *** ds4tews has joined #bitcoin-core-dev
595 2017-12-04T22:06:07  *** ds4tews has quit IRC
596 2017-12-04T22:10:56  *** intcat has quit IRC
597 2017-12-04T22:11:43  *** intcat has joined #bitcoin-core-dev
598 2017-12-04T22:19:39  *** intcat has quit IRC
599 2017-12-04T22:20:53  *** intcat has joined #bitcoin-core-dev
600 2017-12-04T22:20:53  *** meshcollider has joined #bitcoin-core-dev
601 2017-12-04T22:43:57  *** Randolf has quit IRC
602 2017-12-04T22:44:17  *** Chris_Stewart_5 has quit IRC
603 2017-12-04T22:44:28  *** promag has joined #bitcoin-core-dev
604 2017-12-04T22:47:05  *** Cogito_Ergo_Sum has quit IRC
605 2017-12-04T22:51:15  <cfields> BlueMatt: see: SyncTransaction -> AddToWalletIfInvolvingMe -> MarkConflicted. That ends up testing against chainActive for conflicts rather than the view from the callback :(
606 2017-12-04T22:52:37  <BlueMatt> cfields: heh, I know :(
607 2017-12-04T22:53:04  <BlueMatt> oh, wait, sec
608 2017-12-04T22:53:09  <BlueMatt> missed your point, sorry
609 2017-12-04T22:54:25  *** jb55 has quit IRC
610 2017-12-04T22:54:39  *** Cheeseo has quit IRC
611 2017-12-04T22:54:59  <cfields> BlueMatt: assuming the callbacks are lagging and chainActive is significantly ahead, MarkConflicted could be looking for conflicts on some future (or reorg'd) chain
612 2017-12-04T22:56:15  <cfields> (i'm just looking around for things that could accidentally be using chainActive on the callback thread)
613 2017-12-04T23:01:53  *** JackH has quit IRC
614 2017-12-04T23:14:36  <jamesob> cfields: you're looking into the shared_ptr<CBlock> backup?
615 2017-12-04T23:15:32  *** bule has joined #bitcoin-core-dev
616 2017-12-04T23:15:58  <cfields> just having another look over the change that moves the validatioininterface callbacks to the scheduler thread. I guess that's what you mean?
617 2017-12-04T23:16:06  <jamesob> yeah
618 2017-12-04T23:16:43  *** Guyver2 has quit IRC
619 2017-12-04T23:17:40  <jamesob> didn't know if there was a particular fix in mind for that yet
620 2017-12-04T23:23:01  *** tiagotrs has quit IRC
621 2017-12-04T23:23:42  *** Victorsueca has quit IRC
622 2017-12-04T23:24:41  *** intcat has quit IRC
623 2017-12-04T23:24:54  *** Victorsueca has joined #bitcoin-core-dev
624 2017-12-04T23:25:34  *** intcat has joined #bitcoin-core-dev
625 2017-12-04T23:25:43  *** intcat has quit IRC
626 2017-12-04T23:26:26  *** intcat has joined #bitcoin-core-dev
627 2017-12-04T23:29:40  *** intcat has quit IRC
628 2017-12-04T23:30:15  *** Dizzle has quit IRC
629 2017-12-04T23:30:28  *** intcat has joined #bitcoin-core-dev
630 2017-12-04T23:30:36  <sipa> BlueMatt, cfields: if the wallet notifications can lag behind chainActive, the wallet needs its own "tip" to test against, no?
631 2017-12-04T23:34:50  <BlueMatt> cfields: sorry, was just finishing the queue-drain branch...I do not believe that to be an issue? Specifically, in the conflicted case you mention here, the only way to hit it is if the wallet lags behind and the block that made a transaction conflict is already reorg'd off the main chain, in which case you dont want to mark it conflicted, and if its still gonna be conflicted once you get to the best chain a later callback will mark
632 2017-12-04T23:34:50  <BlueMatt> it conflicted appropriately
633 2017-12-04T23:34:54  <BlueMatt> jamesob: yes, I have a branch
634 2017-12-04T23:35:31  <BlueMatt> sipa: I do not believe that to be the case (currently), please prove me wrong!
635 2017-12-04T23:36:10  <achow101> BlueMatt: cfields: are you working on the fix for the queue thing or something else?
636 2017-12-04T23:36:37  <BlueMatt> achow101: yes
637 2017-12-04T23:36:48  <BlueMatt> though cfields is trying to find other issues in the original pr
638 2017-12-04T23:36:52  <achow101> ok
639 2017-12-04T23:38:22  <sipa> BlueMatt: it certainly sounds safer...
640 2017-12-04T23:38:46  <cfields> sipa: agreed
641 2017-12-04T23:39:23  <BlueMatt> sipa: I agree, but to do that you'd rewrite about another 10 functions in the wallet and probably end up refactoring half of it
642 2017-12-04T23:39:27  <BlueMatt> (again, please prove me wrong :p)
643 2017-12-04T23:39:49  <cfields> even if the conflicts aren't an issue, i still really don't like that we're testing against some seemingly random chain
644 2017-12-04T23:40:12  <BlueMatt> well in that one specific case its fine (and kinda the way the function was written to begin with, strangely)
645 2017-12-04T23:40:12  <sipa> BlueMatt: hmm, really? I would just replace every call to chainActive in the wallet with a local variable, which gets updated through the callbac
646 2017-12-04T23:40:23  <cfields> BlueMatt: at least for the stuff affected by callbacks, can't we just pass a pindex around instead?
647 2017-12-04T23:41:26  <BlueMatt> cfields: isnt that like the one place that matters from the callbacks (its been like 8 months since I've looked though)
648 2017-12-04T23:41:58  <cfields> BlueMatt: unsure. I'll take a closer look before commenting further
649 2017-12-04T23:41:58  <BlueMatt> sipa: the number of places I'd have to go read to make sure GetDepthInMainChain being disconnected from main chain is fine to be convinced of that is....high
650 2017-12-04T23:42:07  <BlueMatt> sipa: though I'm sure ryanofsky would appreciate it greatly
651 2017-12-04T23:44:01  <BlueMatt> sipa: the obvious issue is that gui would have to be aware of the wallet chain state
652 2017-12-04T23:44:24  <sipa> right
653 2017-12-04T23:44:45  <sipa> and if there's anything that looks at pcoinsTip from the wallet (is there?) that would also be affected
654 2017-12-04T23:45:00  <BlueMatt> I dont think there is
655 2017-12-04T23:45:32  *** jb55 has joined #bitcoin-core-dev
656 2017-12-04T23:48:32  <BlueMatt> sipa: ReacceptWalletTransactions/RelayWalletTransactions would need a only-if-caught-up-to-main-chain condition, but thats the only obvious ones in wallet.cpp...it may be much easier than I thought, but I already have too many open prs to want to do it any time soon
657 2017-12-04T23:51:31  *** wunpunch has quit IRC
658 2017-12-04T23:52:27  *** D__ has joined #bitcoin-core-dev
659 2017-12-04T23:52:29  <D__> Dd
660 2017-12-04T23:52:38  *** bule2 has joined #bitcoin-core-dev
661 2017-12-04T23:52:46  *** bule has quit IRC
662 2017-12-04T23:52:50  *** D__ is now known as Guest72935
663 2017-12-04T23:57:10  *** Guest72935 has quit IRC