1 2018-01-08T00:00:30 *** promag has joined #bitcoin-core-dev
2 2018-01-08T00:05:46 *** ludens[m] has quit IRC
3 2018-01-08T00:05:47 *** herzmeister[m] has quit IRC
4 2018-01-08T00:05:55 *** ajtowns[m] has quit IRC
5 2018-01-08T00:05:55 *** kewde[m] has quit IRC
6 2018-01-08T00:06:00 *** Masaomi[m] has quit IRC
7 2018-01-08T00:07:57 *** hirish is now known as hirishaway
8 2018-01-08T00:08:27 *** da2ce7 has quit IRC
9 2018-01-08T00:09:57 *** promag has quit IRC
10 2018-01-08T00:10:31 *** Danilo_ has joined #bitcoin-core-dev
11 2018-01-08T00:10:52 *** da2ce7 has joined #bitcoin-core-dev
12 2018-01-08T00:13:07 *** kewde[m] has joined #bitcoin-core-dev
13 2018-01-08T00:14:15 *** Cogito_Ergo_Sum has quit IRC
14 2018-01-08T00:15:14 *** jl2012 has quit IRC
15 2018-01-08T00:16:07 *** jb55 has joined #bitcoin-core-dev
16 2018-01-08T00:16:09 *** anome has joined #bitcoin-core-dev
17 2018-01-08T00:19:10 *** logicue has quit IRC
18 2018-01-08T00:21:36 *** herzmeister[m] has joined #bitcoin-core-dev
19 2018-01-08T00:21:36 *** ajtowns[m] has joined #bitcoin-core-dev
20 2018-01-08T00:21:37 *** Masaomi[m] has joined #bitcoin-core-dev
21 2018-01-08T00:21:44 *** ludens[m] has joined #bitcoin-core-dev
22 2018-01-08T00:22:41 *** prometheus_falli has joined #bitcoin-core-dev
23 2018-01-08T00:28:14 *** jb55 has quit IRC
24 2018-01-08T00:31:12 *** meshcollider has joined #bitcoin-core-dev
25 2018-01-08T00:33:13 *** anome has quit IRC
26 2018-01-08T00:37:47 *** Tennis has quit IRC
27 2018-01-08T00:48:45 *** hirishaway is now known as hirish
28 2018-01-08T00:52:56 <go1111111> is it a known issue that the input selection UI is super unresponsive while Core 0.15.1 is syncing the blockchain? it's taking over 5 seconds to respond to mouse actions (I'm using Linux Mint 18.2). If not, could someone try to repro it to verify its not something weird in my machine?
29 2018-01-08T00:53:18 <go1111111> once Core is fully synced, the input selection UI responds quickly
30 2018-01-08T01:01:28 <eu-Robert> sounds like a low priority problem
31 2018-01-08T01:01:44 <eu-Robert> as in low priority to fix
32 2018-01-08T01:04:32 *** hirish is now known as hirishaway
33 2018-01-08T01:06:37 *** promag has joined #bitcoin-core-dev
34 2018-01-08T01:09:50 *** talesofterror has quit IRC
35 2018-01-08T01:11:10 *** promag has quit IRC
36 2018-01-08T01:11:11 *** talesofterror has joined #bitcoin-core-dev
37 2018-01-08T01:21:56 *** dqx has joined #bitcoin-core-dev
38 2018-01-08T01:22:34 *** dqx has joined #bitcoin-core-dev
39 2018-01-08T01:49:15 *** Randolf has joined #bitcoin-core-dev
40 2018-01-08T01:56:15 <luke-jr> yay, Gentoo finally addressed that 2015 miniupnpc buffer overflow https://security.gentoo.org/glsa/201801-08
41 2018-01-08T02:11:13 *** jl2012 has joined #bitcoin-core-dev
42 2018-01-08T02:12:50 *** belcher_ has quit IRC
43 2018-01-08T02:13:59 *** CubicEarths has quit IRC
44 2018-01-08T02:14:36 *** CubicEarths has joined #bitcoin-core-dev
45 2018-01-08T02:18:49 <bitcoin-git> [bitcoin] jackycjh opened pull request #12112: Docs: Remove the ending slashes from RPC URI format. (master...docs/multi-wallet_RPC_interface_correction) https://github.com/bitcoin/bitcoin/pull/12112
46 2018-01-08T02:24:43 *** CubicEar_ has joined #bitcoin-core-dev
47 2018-01-08T02:26:56 *** ossifrage has quit IRC
48 2018-01-08T02:28:29 *** CubicEarths has quit IRC
49 2018-01-08T02:34:48 *** CubicEarths has joined #bitcoin-core-dev
50 2018-01-08T02:38:05 *** CubicEar_ has quit IRC
51 2018-01-08T02:40:18 *** meshcollider has quit IRC
52 2018-01-08T02:44:45 *** meshcollider has joined #bitcoin-core-dev
53 2018-01-08T02:46:41 *** talesofterror has quit IRC
54 2018-01-08T02:49:16 *** dabura667 has joined #bitcoin-core-dev
55 2018-01-08T02:50:23 *** talesofterror has joined #bitcoin-core-dev
56 2018-01-08T02:53:58 *** d9b4bef9 has quit IRC
57 2018-01-08T02:55:13 *** d9b4bef9 has joined #bitcoin-core-dev
58 2018-01-08T02:56:10 *** dabura667 has quit IRC
59 2018-01-08T02:56:43 *** dabura667 has joined #bitcoin-core-dev
60 2018-01-08T03:00:10 *** dabura667 has quit IRC
61 2018-01-08T03:06:49 *** LeMiner2 has joined #bitcoin-core-dev
62 2018-01-08T03:07:11 *** jouke has quit IRC
63 2018-01-08T03:09:20 *** LeMiner has quit IRC
64 2018-01-08T03:09:20 *** LeMiner2 is now known as LeMiner
65 2018-01-08T03:09:53 *** tri333 has joined #bitcoin-core-dev
66 2018-01-08T03:09:54 <tri333> hi
67 2018-01-08T03:14:50 *** jouke has joined #bitcoin-core-dev
68 2018-01-08T03:14:54 *** atroxes has quit IRC
69 2018-01-08T03:15:37 *** atroxes has joined #bitcoin-core-dev
70 2018-01-08T03:23:54 *** Cheeseo has quit IRC
71 2018-01-08T03:23:59 *** cheese_ has joined #bitcoin-core-dev
72 2018-01-08T03:27:16 *** prometheus_falli has quit IRC
73 2018-01-08T03:27:51 *** talesofterror has quit IRC
74 2018-01-08T03:38:09 *** Giszmo has quit IRC
75 2018-01-08T04:08:57 *** Randolf has quit IRC
76 2018-01-08T04:27:35 *** prometheus_falli has joined #bitcoin-core-dev
77 2018-01-08T04:36:42 *** tknp has joined #bitcoin-core-dev
78 2018-01-08T04:51:19 *** ossifrage has joined #bitcoin-core-dev
79 2018-01-08T04:52:09 *** MrPaz has joined #bitcoin-core-dev
80 2018-01-08T05:06:24 *** Randolf has joined #bitcoin-core-dev
81 2018-01-08T05:39:36 *** Eetsi123 has joined #bitcoin-core-dev
82 2018-01-08T05:42:48 *** intcat has quit IRC
83 2018-01-08T05:44:10 *** MrPaz has quit IRC
84 2018-01-08T05:48:24 *** intcat has joined #bitcoin-core-dev
85 2018-01-08T05:53:32 *** intcat has quit IRC
86 2018-01-08T05:54:16 *** intcat has joined #bitcoin-core-dev
87 2018-01-08T05:54:54 *** AaronvanW has quit IRC
88 2018-01-08T05:55:25 *** magicoffee has joined #bitcoin-core-dev
89 2018-01-08T05:59:19 *** eu-Robert has quit IRC
90 2018-01-08T06:01:56 *** magicoffee has quit IRC
91 2018-01-08T06:02:41 *** mrfrasha has joined #bitcoin-core-dev
92 2018-01-08T06:05:43 *** jb55 has joined #bitcoin-core-dev
93 2018-01-08T06:33:05 *** Amuza has quit IRC
94 2018-01-08T06:33:21 *** jb55 has quit IRC
95 2018-01-08T06:37:15 *** mrfrasha has quit IRC
96 2018-01-08T06:38:42 *** mrfrasha has joined #bitcoin-core-dev
97 2018-01-08T06:41:16 <bitcoin-git> [bitcoin] AjkP opened pull request #12113: Qt: Fixed styling in modaloverlay.cpp (master...ajkp/modaloverlay_styling) https://github.com/bitcoin/bitcoin/pull/12113
98 2018-01-08T06:50:36 *** dqx has quit IRC
99 2018-01-08T06:55:57 *** d9b4bef9 has quit IRC
100 2018-01-08T06:57:04 *** d9b4bef9 has joined #bitcoin-core-dev
101 2018-01-08T07:02:07 *** AaronvanW has joined #bitcoin-core-dev
102 2018-01-08T07:07:02 *** prometheus_falli has quit IRC
103 2018-01-08T07:13:16 *** Masaomi[m] has quit IRC
104 2018-01-08T07:13:16 *** derbumi has quit IRC
105 2018-01-08T07:13:39 *** derbumi has joined #bitcoin-core-dev
106 2018-01-08T07:14:25 *** Masaomi[m] has joined #bitcoin-core-dev
107 2018-01-08T07:15:54 *** AaronvanW has quit IRC
108 2018-01-08T07:16:17 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
109 2018-01-08T07:16:17 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
110 2018-01-08T07:26:01 *** whphhg has quit IRC
111 2018-01-08T07:36:02 *** Cheeseo has joined #bitcoin-core-dev
112 2018-01-08T07:36:55 *** zeek has joined #bitcoin-core-dev
113 2018-01-08T07:38:58 *** AaronvanW has joined #bitcoin-core-dev
114 2018-01-08T07:39:11 *** cheese_ has quit IRC
115 2018-01-08T07:39:19 *** zeek has quit IRC
116 2018-01-08T07:53:21 *** promag has joined #bitcoin-core-dev
117 2018-01-08T07:53:58 *** mcochrane has joined #bitcoin-core-dev
118 2018-01-08T07:54:55 *** dqx has joined #bitcoin-core-dev
119 2018-01-08T07:56:17 *** mcochrane_ has quit IRC
120 2018-01-08T07:57:53 *** promag has quit IRC
121 2018-01-08T07:59:39 *** dqx has quit IRC
122 2018-01-08T08:08:28 *** intcat has quit IRC
123 2018-01-08T08:08:52 <bitcoin-git> [bitcoin] TexasSooner opened pull request #12114: update jan 8 (master...master) https://github.com/bitcoin/bitcoin/pull/12114
124 2018-01-08T08:09:47 <bitcoin-git> [bitcoin] TexasSooner closed pull request #12114: update jan 8 (master...master) https://github.com/bitcoin/bitcoin/pull/12114
125 2018-01-08T08:10:06 *** intcat has joined #bitcoin-core-dev
126 2018-01-08T08:15:36 *** Squidicc has quit IRC
127 2018-01-08T08:16:06 *** Squidicc has joined #bitcoin-core-dev
128 2018-01-08T08:16:37 *** Danilo__ has joined #bitcoin-core-dev
129 2018-01-08T08:17:20 *** timothy has joined #bitcoin-core-dev
130 2018-01-08T08:19:21 *** Danilo_ has quit IRC
131 2018-01-08T08:24:41 *** Amuza has joined #bitcoin-core-dev
132 2018-01-08T08:28:39 *** anome has joined #bitcoin-core-dev
133 2018-01-08T08:30:18 *** meshcollider has quit IRC
134 2018-01-08T08:31:05 *** tri333 has quit IRC
135 2018-01-08T08:33:40 *** anome has quit IRC
136 2018-01-08T08:33:41 *** anome has joined #bitcoin-core-dev
137 2018-01-08T08:40:53 *** anome has quit IRC
138 2018-01-08T08:41:15 *** anome has joined #bitcoin-core-dev
139 2018-01-08T08:58:06 *** anome has quit IRC
140 2018-01-08T09:16:07 *** JackH has joined #bitcoin-core-dev
141 2018-01-08T09:23:47 *** logicue has joined #bitcoin-core-dev
142 2018-01-08T09:28:54 *** anome has joined #bitcoin-core-dev
143 2018-01-08T09:42:25 *** cysm has quit IRC
144 2018-01-08T09:45:05 *** promag has joined #bitcoin-core-dev
145 2018-01-08T09:47:13 <sipa> BlueMatt: feel like having a look at #11403 again?
146 2018-01-08T09:47:19 <gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
147 2018-01-08T09:50:32 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12113: Qt: Fixed styling in modaloverlay.cpp (master...ajkp/modaloverlay_styling) https://github.com/bitcoin/bitcoin/pull/12113
148 2018-01-08T09:51:54 *** promag has quit IRC
149 2018-01-08T09:56:25 *** promag has joined #bitcoin-core-dev
150 2018-01-08T09:59:55 *** cysm has joined #bitcoin-core-dev
151 2018-01-08T10:14:36 *** AaronvanW has quit IRC
152 2018-01-08T10:18:57 *** AaronvanW has joined #bitcoin-core-dev
153 2018-01-08T10:23:11 *** AaronvanW has quit IRC
154 2018-01-08T10:23:29 *** whphhg has joined #bitcoin-core-dev
155 2018-01-08T10:24:19 *** logicue has quit IRC
156 2018-01-08T10:27:10 *** CubicEarths has quit IRC
157 2018-01-08T10:32:35 *** cysm has quit IRC
158 2018-01-08T10:44:55 *** shesek has quit IRC
159 2018-01-08T10:45:41 *** promag has quit IRC
160 2018-01-08T10:45:57 *** cysm has joined #bitcoin-core-dev
161 2018-01-08T10:49:50 *** JackH has quit IRC
162 2018-01-08T10:52:23 *** promag has joined #bitcoin-core-dev
163 2018-01-08T10:53:57 *** d9b4bef9 has quit IRC
164 2018-01-08T10:54:17 *** promag has quit IRC
165 2018-01-08T10:57:04 *** d9b4bef9 has joined #bitcoin-core-dev
166 2018-01-08T10:58:00 *** CubicEarths has joined #bitcoin-core-dev
167 2018-01-08T10:58:23 *** shesek has joined #bitcoin-core-dev
168 2018-01-08T10:58:23 *** shesek has joined #bitcoin-core-dev
169 2018-01-08T10:59:00 *** Boop has joined #bitcoin-core-dev
170 2018-01-08T10:59:11 *** hirishaway is now known as hirish
171 2018-01-08T10:59:38 *** Boop has quit IRC
172 2018-01-08T11:02:40 *** CubicEarths has quit IRC
173 2018-01-08T11:08:56 *** AaronvanW has joined #bitcoin-core-dev
174 2018-01-08T11:09:47 *** promag has joined #bitcoin-core-dev
175 2018-01-08T11:22:26 *** Midak has joined #bitcoin-core-dev
176 2018-01-08T11:29:06 *** mrfrasha has quit IRC
177 2018-01-08T11:30:29 *** Midak has quit IRC
178 2018-01-08T11:32:53 *** CubicEarths has joined #bitcoin-core-dev
179 2018-01-08T11:34:28 *** Guyver2 has joined #bitcoin-core-dev
180 2018-01-08T11:37:35 *** CubicEarths has quit IRC
181 2018-01-08T11:39:57 *** logicue has joined #bitcoin-core-dev
182 2018-01-08T11:41:35 *** anome has quit IRC
183 2018-01-08T11:42:20 *** larafale has joined #bitcoin-core-dev
184 2018-01-08T11:46:19 *** hirish is now known as hirishaway
185 2018-01-08T11:50:51 *** Amuza has quit IRC
186 2018-01-08T11:52:50 *** promag has quit IRC
187 2018-01-08T11:57:20 *** promag has joined #bitcoin-core-dev
188 2018-01-08T11:57:37 *** Amuza has joined #bitcoin-core-dev
189 2018-01-08T11:58:24 *** Lauda has quit IRC
190 2018-01-08T11:59:01 *** Lauda has joined #bitcoin-core-dev
191 2018-01-08T12:00:03 *** Manu_ has joined #bitcoin-core-dev
192 2018-01-08T12:06:03 *** CubicEarths has joined #bitcoin-core-dev
193 2018-01-08T12:08:02 *** anome has joined #bitcoin-core-dev
194 2018-01-08T12:10:05 *** CubicEarths has quit IRC
195 2018-01-08T12:10:56 *** anome has quit IRC
196 2018-01-08T12:14:23 *** Manu_ has quit IRC
197 2018-01-08T12:14:24 *** Giszmo has joined #bitcoin-core-dev
198 2018-01-08T12:15:04 *** JackH has joined #bitcoin-core-dev
199 2018-01-08T12:16:40 *** anome has joined #bitcoin-core-dev
200 2018-01-08T12:18:46 *** anome has quit IRC
201 2018-01-08T12:21:12 *** _flow_ has quit IRC
202 2018-01-08T12:25:25 *** anome has joined #bitcoin-core-dev
203 2018-01-08T12:27:41 *** anome has quit IRC
204 2018-01-08T12:32:24 *** DrFeelGood has quit IRC
205 2018-01-08T12:33:08 *** anome has joined #bitcoin-core-dev
206 2018-01-08T12:33:52 *** DrFeelGood has joined #bitcoin-core-dev
207 2018-01-08T12:35:15 *** anome has quit IRC
208 2018-01-08T12:43:41 *** anome has joined #bitcoin-core-dev
209 2018-01-08T12:50:55 *** anome has quit IRC
210 2018-01-08T12:57:02 *** Randolf has quit IRC
211 2018-01-08T12:58:05 *** logicue has quit IRC
212 2018-01-08T13:02:24 *** promag has quit IRC
213 2018-01-08T13:03:10 *** anome has joined #bitcoin-core-dev
214 2018-01-08T13:06:04 *** dqx has joined #bitcoin-core-dev
215 2018-01-08T13:08:18 *** _flow_ has joined #bitcoin-core-dev
216 2018-01-08T13:10:33 *** dqx has quit IRC
217 2018-01-08T13:16:07 *** CubicEarths has joined #bitcoin-core-dev
218 2018-01-08T13:20:55 *** CubicEarths has quit IRC
219 2018-01-08T13:23:12 *** ghost43 has quit IRC
220 2018-01-08T13:23:12 *** arubi has quit IRC
221 2018-01-08T13:23:13 *** intcat has quit IRC
222 2018-01-08T13:25:03 *** intcat has joined #bitcoin-core-dev
223 2018-01-08T13:26:08 *** Monte35Osinski has joined #bitcoin-core-dev
224 2018-01-08T13:28:44 *** ghost43 has joined #bitcoin-core-dev
225 2018-01-08T13:33:44 *** arubi has joined #bitcoin-core-dev
226 2018-01-08T13:37:34 *** anome has quit IRC
227 2018-01-08T13:41:55 *** logicue has joined #bitcoin-core-dev
228 2018-01-08T13:48:50 *** promag has joined #bitcoin-core-dev
229 2018-01-08T13:51:06 *** promag has quit IRC
230 2018-01-08T13:52:48 *** CubicEarths has joined #bitcoin-core-dev
231 2018-01-08T13:57:10 *** promag has joined #bitcoin-core-dev
232 2018-01-08T13:57:27 *** CubicEarths has quit IRC
233 2018-01-08T14:05:05 *** Randolf has joined #bitcoin-core-dev
234 2018-01-08T14:05:54 *** c01nkiller has joined #bitcoin-core-dev
235 2018-01-08T14:06:24 *** Chris_Stewart_5 has joined #bitcoin-core-dev
236 2018-01-08T14:07:53 *** Eetsi123 has quit IRC
237 2018-01-08T14:12:18 *** logicue has quit IRC
238 2018-01-08T14:14:51 *** belcher has joined #bitcoin-core-dev
239 2018-01-08T14:17:51 *** anome has joined #bitcoin-core-dev
240 2018-01-08T14:19:13 *** anome has quit IRC
241 2018-01-08T14:21:09 *** DrFeelGood has quit IRC
242 2018-01-08T14:21:58 *** DrFeelGood has joined #bitcoin-core-dev
243 2018-01-08T14:22:57 *** Chris_Stewart_5 has quit IRC
244 2018-01-08T14:24:35 *** AaronvanW has quit IRC
245 2018-01-08T14:25:38 *** CubicEarths has joined #bitcoin-core-dev
246 2018-01-08T14:30:37 *** CubicEarths has quit IRC
247 2018-01-08T14:32:54 *** c01nkiller has quit IRC
248 2018-01-08T14:33:43 *** CubicEarths has joined #bitcoin-core-dev
249 2018-01-08T14:35:23 *** anome has joined #bitcoin-core-dev
250 2018-01-08T14:37:56 *** anome has quit IRC
251 2018-01-08T14:39:05 *** CubicEarths has quit IRC
252 2018-01-08T14:57:28 *** zautomata has joined #bitcoin-core-dev
253 2018-01-08T14:57:47 *** CubicEarths has joined #bitcoin-core-dev
254 2018-01-08T14:58:38 <BlueMatt> sipa: yep, will do today
255 2018-01-08T15:01:57 *** CubicEarths has quit IRC
256 2018-01-08T15:05:07 *** promag has quit IRC
257 2018-01-08T15:14:32 *** Squidicc has quit IRC
258 2018-01-08T15:14:56 *** Squidicuz has joined #bitcoin-core-dev
259 2018-01-08T15:18:39 *** Emcy has quit IRC
260 2018-01-08T15:18:53 *** Emcy has joined #bitcoin-core-dev
261 2018-01-08T15:20:16 *** Amuza has quit IRC
262 2018-01-08T15:21:09 *** dqx has joined #bitcoin-core-dev
263 2018-01-08T15:25:11 *** dqx has quit IRC
264 2018-01-08T15:27:36 *** anome has joined #bitcoin-core-dev
265 2018-01-08T15:29:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
266 2018-01-08T15:32:14 *** logicue has joined #bitcoin-core-dev
267 2018-01-08T15:33:12 *** mandric has joined #bitcoin-core-dev
268 2018-01-08T15:36:59 *** CubicEarths has joined #bitcoin-core-dev
269 2018-01-08T15:41:21 *** CubicEarths has quit IRC
270 2018-01-08T15:42:56 *** ghost43 has quit IRC
271 2018-01-08T15:43:19 *** ghost43 has joined #bitcoin-core-dev
272 2018-01-08T15:47:12 *** dqx has joined #bitcoin-core-dev
273 2018-01-08T15:47:40 *** MrPaz has joined #bitcoin-core-dev
274 2018-01-08T15:47:45 *** Monte35Osinski has quit IRC
275 2018-01-08T15:48:31 *** logicue has quit IRC
276 2018-01-08T15:50:26 *** dqx_ has joined #bitcoin-core-dev
277 2018-01-08T15:51:19 *** dqx has quit IRC
278 2018-01-08T15:53:21 *** wxss has joined #bitcoin-core-dev
279 2018-01-08T15:55:47 *** dqx_ has quit IRC
280 2018-01-08T16:03:35 *** Schwineigel has joined #bitcoin-core-dev
281 2018-01-08T16:03:58 <Schwineigel> help
282 2018-01-08T16:04:32 <Schwineigel> first transaction did not go through.
283 2018-01-08T16:04:47 <Schwineigel> it was sent 6 jan 18
284 2018-01-08T16:05:08 <Schwineigel> what do i do
285 2018-01-08T16:05:38 <Lauda> Schwineigel: #bitcoin
286 2018-01-08T16:05:50 <Schwineigel> hi
287 2018-01-08T16:07:02 <Schwineigel> My first transaction sending satoshi out did not work what do i do?
288 2018-01-08T16:07:42 <Schwineigel> It was sent 6 Jan 18 it is still pending
289 2018-01-08T16:10:17 <Schwineigel> i guess i came to the wrong place for help
290 2018-01-08T16:10:40 *** dqx has joined #bitcoin-core-dev
291 2018-01-08T16:12:28 <Schwineigel> i came here to find help
292 2018-01-08T16:13:05 <Schwineigel> My trasnaction has not gone through, i made it on 6 jan
293 2018-01-08T16:13:33 <achow101> Schwineigel: this channel is for Bitcoin Core development, not for helping users
294 2018-01-08T16:13:44 <achow101> for general help, go to #bitcoin
295 2018-01-08T16:14:03 *** CubicEarths has joined #bitcoin-core-dev
296 2018-01-08T16:14:32 <Schwineigel> ok sorry to bother you. thanks for the info
297 2018-01-08T16:14:40 *** Schwineigel has quit IRC
298 2018-01-08T16:15:40 *** dqx has quit IRC
299 2018-01-08T16:16:38 *** zautomata1 has joined #bitcoin-core-dev
300 2018-01-08T16:17:09 *** interestedbystan has joined #bitcoin-core-dev
301 2018-01-08T16:18:09 *** Abdul has joined #bitcoin-core-dev
302 2018-01-08T16:18:18 *** zautomata has quit IRC
303 2018-01-08T16:18:39 *** CubicEarths has quit IRC
304 2018-01-08T16:18:56 *** Abdul has quit IRC
305 2018-01-08T16:19:01 *** interestedbystan has quit IRC
306 2018-01-08T16:19:15 *** dqx has joined #bitcoin-core-dev
307 2018-01-08T16:19:30 *** m8tion has joined #bitcoin-core-dev
308 2018-01-08T16:21:28 *** mcochrane has quit IRC
309 2018-01-08T16:22:32 *** mrfrasha has joined #bitcoin-core-dev
310 2018-01-08T16:27:55 *** mandric has quit IRC
311 2018-01-08T16:28:56 *** JackH has quit IRC
312 2018-01-08T16:33:08 *** Murch has joined #bitcoin-core-dev
313 2018-01-08T16:35:27 *** laurentmt has joined #bitcoin-core-dev
314 2018-01-08T16:45:29 *** CubicEarths has joined #bitcoin-core-dev
315 2018-01-08T16:48:08 <ossifrage> still no love building bitcoin-qt with -flto: ./libtool: line 1720: 18164 Segmentation fault (core dumped) /usr/bin/gcc-ranlib .libs/libsecp256k1.a
316 2018-01-08T16:50:07 *** CubicEarths has quit IRC
317 2018-01-08T16:51:49 *** laurentmt has quit IRC
318 2018-01-08T16:54:24 <BlueMatt> ossifrage: segfault in ranlib sounds like a gcc bug to be reported upstream, no?
319 2018-01-08T16:54:59 *** Randolf has quit IRC
320 2018-01-08T16:55:05 *** blackeye01 has joined #bitcoin-core-dev
321 2018-01-08T16:57:15 *** Murch has quit IRC
322 2018-01-08T17:04:09 *** blackeye01 has quit IRC
323 2018-01-08T17:05:16 *** Murch has joined #bitcoin-core-dev
324 2018-01-08T17:05:57 *** laurentmt has joined #bitcoin-core-dev
325 2018-01-08T17:06:29 *** dqx has quit IRC
326 2018-01-08T17:06:54 *** anome has quit IRC
327 2018-01-08T17:07:15 *** laurentmt has quit IRC
328 2018-01-08T17:07:16 *** anome has joined #bitcoin-core-dev
329 2018-01-08T17:15:23 *** Randolf has joined #bitcoin-core-dev
330 2018-01-08T17:16:21 *** flotwig has joined #bitcoin-core-dev
331 2018-01-08T17:19:45 *** CubicEarths has joined #bitcoin-core-dev
332 2018-01-08T17:22:12 *** jtimon has joined #bitcoin-core-dev
333 2018-01-08T17:24:27 *** CubicEarths has quit IRC
334 2018-01-08T17:24:51 *** PaulCapestany has quit IRC
335 2018-01-08T17:25:37 *** PaulCape_ has joined #bitcoin-core-dev
336 2018-01-08T17:29:15 *** dqx has joined #bitcoin-core-dev
337 2018-01-08T17:31:08 *** Szadek has joined #bitcoin-core-dev
338 2018-01-08T17:33:07 *** rlesias has joined #bitcoin-core-dev
339 2018-01-08T17:38:50 *** rlesias has quit IRC
340 2018-01-08T17:44:29 *** mandric has joined #bitcoin-core-dev
341 2018-01-08T17:45:12 <ossifrage> BlueMatt, yeah it should be reported upstream, but I haven't put the effort in to find a clean testcase
342 2018-01-08T17:50:19 *** CubicEarths has joined #bitcoin-core-dev
343 2018-01-08T17:54:42 *** Murch has quit IRC
344 2018-01-08T17:54:57 *** CubicEarths has quit IRC
345 2018-01-08T17:56:06 *** Murch has joined #bitcoin-core-dev
346 2018-01-08T18:03:07 *** litecoinDev has joined #bitcoin-core-dev
347 2018-01-08T18:04:17 *** litecoinDev has quit IRC
348 2018-01-08T18:05:36 *** MrPaz has quit IRC
349 2018-01-08T18:13:41 *** hirishaway is now known as hirish
350 2018-01-08T18:15:42 *** Murch has quit IRC
351 2018-01-08T18:16:38 *** George has joined #bitcoin-core-dev
352 2018-01-08T18:16:39 *** mandric has quit IRC
353 2018-01-08T18:17:10 *** Murch has joined #bitcoin-core-dev
354 2018-01-08T18:17:16 *** MrPaz has joined #bitcoin-core-dev
355 2018-01-08T18:18:36 *** anome has quit IRC
356 2018-01-08T18:20:15 *** m8tion has quit IRC
357 2018-01-08T18:23:51 *** timothy has quit IRC
358 2018-01-08T18:25:46 *** CubicEarths has joined #bitcoin-core-dev
359 2018-01-08T18:27:47 *** cncr04s has joined #bitcoin-core-dev
360 2018-01-08T18:30:23 *** CubicEarths has quit IRC
361 2018-01-08T18:32:26 *** kexkey has joined #bitcoin-core-dev
362 2018-01-08T18:35:37 *** promag has joined #bitcoin-core-dev
363 2018-01-08T18:40:23 *** promag has quit IRC
364 2018-01-08T18:45:11 *** logicue has joined #bitcoin-core-dev
365 2018-01-08T18:50:15 *** CubicEarths has joined #bitcoin-core-dev
366 2018-01-08T18:51:31 *** MrPaz has quit IRC
367 2018-01-08T18:56:31 *** dqx has quit IRC
368 2018-01-08T18:57:01 *** dqx has joined #bitcoin-core-dev
369 2018-01-08T18:59:07 <bitcoin-git> [bitcoin] sdaftuar opened pull request #12118: Sort mempool by min(feerate, ancestor_feerate) (master...2018-01-fix-mempool-score) https://github.com/bitcoin/bitcoin/pull/12118
370 2018-01-08T19:04:25 *** dqx has quit IRC
371 2018-01-08T19:04:41 *** jb55 has joined #bitcoin-core-dev
372 2018-01-08T19:08:43 *** dqx has joined #bitcoin-core-dev
373 2018-01-08T19:09:22 *** logicue has quit IRC
374 2018-01-08T19:11:37 *** MrPaz has joined #bitcoin-core-dev
375 2018-01-08T19:13:04 *** dqx has quit IRC
376 2018-01-08T19:20:32 *** jb55 has quit IRC
377 2018-01-08T19:20:39 *** Dizzle has joined #bitcoin-core-dev
378 2018-01-08T19:25:33 <bitcoin-git> [bitcoin] Sjors opened pull request #12119: [wallet] use bech32 change address if all destinations are bech32 (master...bech32-change) https://github.com/bitcoin/bitcoin/pull/12119
379 2018-01-08T19:26:30 *** zautomata2 has joined #bitcoin-core-dev
380 2018-01-08T19:27:27 *** zautomata1 has quit IRC
381 2018-01-08T19:34:15 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12120: Add dev guideline limiting auto usage. (master...2018-01-auto-devnotes) https://github.com/bitcoin/bitcoin/pull/12120
382 2018-01-08T19:34:36 * BlueMatt is gonna have to start a policy of auto-nacking anything with auto that doesnt save at least 30 chars of typing
383 2018-01-08T19:42:52 <sipa> BlueMatt: :(
384 2018-01-08T19:43:22 * achow101 replaces every word in the repo with auto
385 2018-01-08T19:45:41 <TD-Linux> #define let const auto
386 2018-01-08T19:46:16 *** Szadek has quit IRC
387 2018-01-08T19:47:37 *** HollowRiddler has joined #bitcoin-core-dev
388 2018-01-08T19:48:46 *** dqx has joined #bitcoin-core-dev
389 2018-01-08T19:49:12 <Chris_Stewart_5> Does the bitcoin core software dump txs back into the mempool when a chain is clearly orphaned?
390 2018-01-08T19:49:40 * BlueMatt is an auto-kermudgen
391 2018-01-08T19:49:51 <sipa> BlueMatt: i don't understand the rationale for that. in the case you reference, just see it as a replacement for inlining
392 2018-01-08T19:50:27 *** anome has joined #bitcoin-core-dev
393 2018-01-08T19:50:46 <sipa> (you could replace the two instances of 'key' with a call to GetKeyForDestination)
394 2018-01-08T19:51:35 <sipa> anyway, i don't feel strongly and if you insist i'll gladly change it... but i think making the type explicit there is less readable
395 2018-01-08T19:54:38 <Dizzle> Chris_Stewart_5: yep! It will not automatically rebroadcast them though. It will of course send along its revised mempool to any other peer that asks for it though.
396 2018-01-08T19:55:00 <luke-jr> I can see places where auto can help readability, and also places where it can hurt readability.
397 2018-01-08T19:55:32 <BlueMatt> sipa: I mean my objection in cases like that is if i want to go audit what IsNull does, I now have to go lookup two things, indeed there is a tradeoff because there may be a type conversion hiding in the = (evil, evil C++), but...
398 2018-01-08T19:55:55 <sipa> with auto you know no implciit type conversion can happen :)
399 2018-01-08T19:56:01 <BlueMatt> (and, yes, I do look up things like what IsNull() does quite often in review, but of course it depends on what the type is of if I know what it does already....)
400 2018-01-08T19:56:09 *** dqx has quit IRC
401 2018-01-08T19:56:19 <BlueMatt> indeed, thats the tradeoff...I wish there were a "this type, and no fucking conversion you piece of shit compiler" option in C++
402 2018-01-08T19:56:44 <sipa> or make all type conversions explicit :)
403 2018-01-08T19:56:49 <BlueMatt> well, yea
404 2018-01-08T19:57:06 * BlueMatt hates surprises
405 2018-01-08T19:57:09 *** anome has quit IRC
406 2018-01-08T19:57:47 <BlueMatt> with the auto in the case mentioned, I have to go do a speculative lookup of the type and use that to speculatively lookup what IsNull() does....waiiiitttttt
407 2018-01-08T19:58:23 <sipa> right... but if thete was only one instance of 'key' in the function, and the GetKeyForDestination clal was inlined into it.... would you complain about that too?
408 2018-01-08T19:58:34 <sipa> this is just a more efficient way of doing that
409 2018-01-08T20:00:32 * BlueMatt has been reading too many spectre posts this weekend, clearly
410 2018-01-08T20:00:39 <cncr04s> Is it possible to implement working mainnet LN on my service?
411 2018-01-08T20:01:45 <Chris_Stewart_5> Dizzle: Is there a specific amount of confirmations required to do this? I.e. one chain is ahead of the orphaned chain by 6 confirmations
412 2018-01-08T20:02:03 *** dqx has joined #bitcoin-core-dev
413 2018-01-08T20:02:17 <luke-jr> BlueMatt: happen to find a usable workaround? :x
414 2018-01-08T20:02:55 *** mandric has joined #bitcoin-core-dev
415 2018-01-08T20:03:31 *** dqx has quit IRC
416 2018-01-08T20:03:41 <BlueMatt> sipa: no, in that case I likely wouldnt have looked up the type, but I probably should have to check for implicit conversion, but mostly in that case I would have just go read the function taking it as argument and found the type in the signature, the issue is that its actually used for more than the pass-through
417 2018-01-08T20:03:55 <sipa> BlueMatt: you misunderstand
418 2018-01-08T20:04:04 <BlueMatt> luke-jr: depends on how many syscalls you do....also, the fucking intel microcode updates are all-but-undocumented
419 2018-01-08T20:04:06 *** dqx has joined #bitcoin-core-dev
420 2018-01-08T20:04:19 <CryptAxe> Chris_Stewart_5 : https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2199-L2243
421 2018-01-08T20:04:42 <CryptAxe> specifically: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2223-L2234
422 2018-01-08T20:04:59 <CryptAxe> Looks like they are added to the mempool right when the block is disconnected
423 2018-01-08T20:05:15 <sipa> BlueMatt: imagine that instead of key.IsNull() it was GetKeyForDestination(*pwallet, dest).IsNull()
424 2018-01-08T20:05:36 <sipa> CryptAxe, Chris_Stewart_5: yes, immediately... what else?
425 2018-01-08T20:05:40 *** Murch has quit IRC
426 2018-01-08T20:05:54 <BlueMatt> then I'd have to do the same lookup as the auto, but possibly wouldnt have complained, no, it still sucks just as much
427 2018-01-08T20:06:02 <sipa> okay :)
428 2018-01-08T20:06:16 *** dqx has quit IRC
429 2018-01-08T20:06:25 *** dqx has joined #bitcoin-core-dev
430 2018-01-08T20:06:34 <sipa> so you're basically saying that every intermediate expression should be annotated explicitly with its type (apart from that being unreasonable)
431 2018-01-08T20:07:06 *** Murch has joined #bitcoin-core-dev
432 2018-01-08T20:07:08 <BlueMatt> it would assist with review, and were it roughly as readable, I'd highly, highly prefer that
433 2018-01-08T20:07:10 <Chris_Stewart_5> CryptAxe: Thanks!
434 2018-01-08T20:07:30 * BlueMatt hates surprises :p
435 2018-01-08T20:08:02 <sipa> BlueMatt: fair; i guess i just disagree that that is more readable :)
436 2018-01-08T20:08:17 <BlueMatt> its all of 4 chars longer on a short line :(
437 2018-01-08T20:09:16 <BlueMatt> maybe I just need to hack my editor to pull shit out of the C++ ast and display the types :p
438 2018-01-08T20:12:21 *** Tennis has joined #bitcoin-core-dev
439 2018-01-08T20:15:56 *** isle2983 has joined #bitcoin-core-dev
440 2018-01-08T20:20:48 *** dqx has quit IRC
441 2018-01-08T20:21:18 *** dqx has joined #bitcoin-core-dev
442 2018-01-08T20:24:31 *** logicue has joined #bitcoin-core-dev
443 2018-01-08T20:25:27 *** dqx has quit IRC
444 2018-01-08T20:26:35 *** Murch has quit IRC
445 2018-01-08T20:29:35 *** Randolf has quit IRC
446 2018-01-08T20:30:14 *** eck has joined #bitcoin-core-dev
447 2018-01-08T20:30:29 *** jb55 has joined #bitcoin-core-dev
448 2018-01-08T20:36:32 *** dqx has joined #bitcoin-core-dev
449 2018-01-08T20:37:23 <BlueMatt> sipa: wait, for bech32 addresses, why do we need to add the p2sh-wrapped segwit thinggy to the wallet?
450 2018-01-08T20:38:56 *** promag has joined #bitcoin-core-dev
451 2018-01-08T20:39:14 <sipa> BlueMatt: because the IsMine logic added in 0.13.1 (for maximal conservativeness at the time) requires the presence of the redeemscript in the keystore even for native segwit output
452 2018-01-08T20:39:39 *** not-a-bot has joined #bitcoin-core-dev
453 2018-01-08T20:40:01 <BlueMatt> ah, ok, didnt realize that
454 2018-01-08T20:40:08 <BlueMatt> or...recall that
455 2018-01-08T20:40:14 <sipa> this was to make sure we don't accidentally treat outputs to uncompressed keys in witness versionas ours
456 2018-01-08T20:40:34 <BlueMatt> yea
457 2018-01-08T20:41:06 <sipa> i think that was overkill now, but it was not a bad strategy to need something explicit to mark a partocular output as ours
458 2018-01-08T20:41:16 <BlueMatt> yea
459 2018-01-08T20:42:23 <BlueMatt> oh, while you're here, have you tested adding a bech32 address to the addressbook and then trying to open the wallet with 0.15 qt?
460 2018-01-08T20:43:12 <sipa> no, i haven't tried qt
461 2018-01-08T20:44:01 <sipa> i've made necessary changes for it to compile, but there may be other changes necessary (especially if we want bech32 error detection in the gui)
462 2018-01-08T20:44:44 <BlueMatt> well, ok, have you tested adding a bech32 address to the addressbook and then calling 0.15 getaddressesbyaccount on the same wallet?
463 2018-01-08T20:46:18 <sipa> no, i haven't tested anything with the gui
464 2018-01-08T20:46:23 <BlueMatt> not gui
465 2018-01-08T20:46:26 <BlueMatt> rpc
466 2018-01-08T20:48:46 <sipa> ah
467 2018-01-08T20:49:15 <BlueMatt> does it blow up? I really have no idea, it just looks like it should blow up or UB or do something strange
468 2018-01-08T20:49:16 <sipa> p2sh certainly is tested, as most rpc tests use the default addresstype
469 2018-01-08T20:49:26 <sipa> how s?
470 2018-01-08T20:49:50 <BlueMatt> what happens when you blindly cast from a variant<CNoDestination> to a CBitcoinAddress?
471 2018-01-08T20:50:20 <sipa> cast?
472 2018-01-08T20:50:27 <sipa> those are not compatible types
473 2018-01-08T20:50:55 <BlueMatt> yes, thats what I thought, but we do a for (pair<CBitcoinAddress, CAddressBookData>& : mapAddressBook)
474 2018-01-08T20:51:02 <BlueMatt> which reads to me as "wat"
475 2018-01-08T20:51:24 <BlueMatt> and if you put bech32 in the address book, I think 0.15 will end up with a CNoDestination in your mapAddressBook
476 2018-01-08T20:52:33 *** mandric_ has joined #bitcoin-core-dev
477 2018-01-08T20:52:47 *** Emcy_ has joined #bitcoin-core-dev
478 2018-01-08T20:52:50 *** hirish has quit IRC
479 2018-01-08T20:53:35 *** mandric has quit IRC
480 2018-01-08T20:54:14 *** hirish has joined #bitcoin-core-dev
481 2018-01-08T20:54:17 *** Emcy has quit IRC
482 2018-01-08T20:54:23 <sipa> BlueMatt: oh, on downgrade!
483 2018-01-08T20:54:25 <sipa> ouch
484 2018-01-08T20:54:34 <BlueMatt> yes, I think we're like...kinda fucked
485 2018-01-08T20:54:45 <BlueMatt> I dunno how to fix that aside from a whole new map for segwit address labels :/
486 2018-01-08T20:55:05 <BlueMatt> (which isnt the worst idea, but its a big change)
487 2018-01-08T20:55:19 <BlueMatt> should check if my reading is actually correct, I'm still a bit foggy
488 2018-01-08T20:55:30 <sipa> well, as soon as you request a bech32 address - which is always an explicit action - you can't downgrade anymore i guess
489 2018-01-08T20:55:41 <sipa> maybe that means we neeed an uogradewallet to permit bech32
490 2018-01-08T20:56:02 <BlueMatt> yea, but we also cant do an upgradwallet without doing an hd upgrade.....
491 2018-01-08T20:56:10 <BlueMatt> or without introducing heaps of stupid hacks
492 2018-01-08T20:56:12 <sipa> well it could be like uogradewallet
493 2018-01-08T20:56:30 <BlueMatt> yea, i mean could, but it sucks
494 2018-01-08T20:56:36 <sipa> similar to how encryption a walletade it incompatible with 0.3
495 2018-01-08T20:56:42 <sipa> sorry, walking
496 2018-01-08T20:56:46 <sipa> my typing sucks
497 2018-01-08T21:02:54 <BlueMatt> also, it does seem weird to let someone have a different label for the bech32, the p2sh-wrapped and the p2ph versions of a pubkey -> address mapping :(
498 2018-01-08T21:04:59 <sipa> why?
499 2018-01-08T21:05:29 <sipa> that's certainly how it should be in the long term (when IsMine is also not related anymore)
500 2018-01-08T21:06:13 <sipa> it's kinda hacky that for some things we need labels on just one of them, and sometimes all
501 2018-01-08T21:06:27 <luke-jr> well, it shouldn't be possible to have more than one address style per key really
502 2018-01-08T21:07:24 <sipa> right; eventually that will be the case i think
503 2018-01-08T21:07:48 <sipa> though right now it's impossible to do that - our IsMine logoc will happily accept anything it can sign for
504 2018-01-08T21:08:54 *** Murch has joined #bitcoin-core-dev
505 2018-01-08T21:09:51 *** dqx has quit IRC
506 2018-01-08T21:11:33 *** mandric_ has quit IRC
507 2018-01-08T21:15:45 *** dqx has joined #bitcoin-core-dev
508 2018-01-08T21:16:49 *** dqx_ has joined #bitcoin-core-dev
509 2018-01-08T21:17:00 *** dqx has quit IRC
510 2018-01-08T21:17:23 <BlueMatt> sipa: what luke said, the fact that we have multiple pubkey->addr mappings right now is kinda a hack which will be for backwards compat eventually
511 2018-01-08T21:17:46 <BlueMatt> sipa: I mention it because if we did labels only for the P2PH version of an address then we'd sidestep the above issue
512 2018-01-08T21:18:29 *** not-a-bot has quit IRC
513 2018-01-08T21:18:35 *** zautomata2 has quit IRC
514 2018-01-08T21:18:38 <BlueMatt> ofc there's still the issue of people who already have entries for the p2sh wrapped version which mismatch the p2ph version :/
515 2018-01-08T21:20:21 *** Tennis has quit IRC
516 2018-01-08T21:21:32 *** zautomata2 has joined #bitcoin-core-dev
517 2018-01-08T21:22:03 *** opovo has joined #bitcoin-core-dev
518 2018-01-08T21:23:19 *** not-a-bot has joined #bitcoin-core-dev
519 2018-01-08T21:27:23 *** anome has joined #bitcoin-core-dev
520 2018-01-08T21:28:11 *** Tennis has joined #bitcoin-core-dev
521 2018-01-08T21:29:46 <Lauda> BlueMatt: What was that with adding bech32 to the address book? I can test that right now in the GUI
522 2018-01-08T21:31:16 <BlueMatt> Lauda: give a bech32 address a label, then downgrade
523 2018-01-08T21:31:28 <BlueMatt> what is in address book window?
524 2018-01-08T21:31:39 <sipa> and does it even start at all
525 2018-01-08T21:32:00 <Lauda> You mean create wallet with the PR, add a label to bech and try opening with 0.15.1?
526 2018-01-08T21:32:45 <sipa> indeed, use getnewaddress with addresstype=bech32
527 2018-01-08T21:32:52 <sipa> and then downgrade to 0.15.1
528 2018-01-08T21:33:25 <Lauda> Error loading wallet.dat: Wallet requires newer version of Bitcoin Core.
529 2018-01-08T21:33:46 <BlueMatt> ryanofsky: points out if anything it may be most likely to simply have a dummy entry from a default-constructed temporary
530 2018-01-08T21:33:47 <sipa> heh, why is that
531 2018-01-08T21:34:03 <BlueMatt> have to create with 15.1
532 2018-01-08T21:34:14 <BlueMatt> then upgrade, then get addr, then downgrade
533 2018-01-08T21:34:20 <Lauda> Oh
534 2018-01-08T21:34:21 <sipa> oh, the default key thing?
535 2018-01-08T21:34:26 <Lauda> sec, let me try that
536 2018-01-08T21:34:35 <sipa> Lauda: thanks!
537 2018-01-08T21:36:33 <Lauda> sipa: yw!
538 2018-01-08T21:36:58 <Lauda> It does open..
539 2018-01-08T21:37:05 <Lauda> label is not working and address is just '3QJmnh'
540 2018-01-08T21:37:23 <sipa> ugh.
541 2018-01-08T21:37:45 <Lauda> '3QJmnh' *is* the bech32 I generated.. weird cut-off
542 2018-01-08T21:37:46 <sipa> what if you have multiple bech32 addresses in the wallet?
543 2018-01-08T21:37:49 <BlueMatt> yea, so ryanofsky was right
544 2018-01-08T21:37:53 <Lauda> testing brb
545 2018-01-08T21:37:57 <sipa> lauda: that's not a bech32 address
546 2018-01-08T21:37:57 <BlueMatt> sipa: I'm pretty sure just 1 entry
547 2018-01-08T21:38:07 <BlueMatt> cause the map is indexed then by a CNoDestination
548 2018-01-08T21:38:08 <sipa> that's p2sh
549 2018-01-08T21:38:09 <Lauda> sipa it was bech32, after downgrade all I saw was "3QJmnh"
550 2018-01-08T21:38:27 <sipa> oh
551 2018-01-08T21:38:34 <Lauda> Let me generate a few of them
552 2018-01-08T21:38:40 <Lauda> and I'll screen
553 2018-01-08T21:38:51 <sipa> that's probabpy the empty array converted to base58
554 2018-01-08T21:39:01 <BlueMatt> sipa: sure its not just the checksum
555 2018-01-08T21:39:02 <BlueMatt> ?
556 2018-01-08T21:39:08 <BlueMatt> yea
557 2018-01-08T21:39:14 <sipa> right
558 2018-01-08T21:41:33 <BlueMatt> well, better than crash
559 2018-01-08T21:41:48 <BlueMatt> i mean i guess not so bad, but still worth fixing, problem is any fix is ugly
560 2018-01-08T21:42:00 <BlueMatt> unless we want to not support more than one address book entry per pubkey
561 2018-01-08T21:42:04 <BlueMatt> which I dont mind, but....
562 2018-01-08T21:42:18 <Lauda> uhm sipa
563 2018-01-08T21:42:22 <Lauda> I made multiple bech
564 2018-01-08T21:42:26 <Lauda> after downgrade
565 2018-01-08T21:42:28 <Lauda> all are gone
566 2018-01-08T21:42:31 <Lauda> o.o
567 2018-01-08T21:42:41 <sipa> that's kind of expected
568 2018-01-08T21:43:11 <sipa> though i think that if you had incoming payments to those bech32 addresses, you'd still have the balance
569 2018-01-08T21:43:20 <Lauda> Alright, so when making one and adding label it is weird. When I make multiple and add labels, they disappear. Anything else I should check?
570 2018-01-08T21:43:22 <BlueMatt> it should still have the one 3QJmnh
571 2018-01-08T21:43:27 <sipa> but the transaction list and address book woild be cut off
572 2018-01-08T21:43:30 <Lauda> BlueMatt: New wallet
573 2018-01-08T21:43:33 <sipa> *messed up
574 2018-01-08T21:45:52 <BlueMatt> Lauda: no, if you do the same thing again the address should not change
575 2018-01-08T21:46:03 <BlueMatt> and if you have multiple, it should still be the same, one, address in the address book in 0.15
576 2018-01-08T21:47:29 <Lauda> Sec, reproducing
577 2018-01-08T21:47:50 *** opovo has left #bitcoin-core-dev
578 2018-01-08T21:47:59 *** Randolf has joined #bitcoin-core-dev
579 2018-01-08T21:48:21 <Lauda> New wallet, generated bech again (so diff. address) and it still turned into '3QJmnh'.
580 2018-01-08T21:49:03 <BlueMatt> yes, ok
581 2018-01-08T21:49:14 <sipa> maybe we should just delete the defaultkey thing whenever a bech32 address is generator
582 2018-01-08T21:49:37 <BlueMatt> please no such hacks
583 2018-01-08T21:49:50 <sipa> why not?
584 2018-01-08T21:50:25 <sipa> it's not very different from the wallet version, except we can't really do that due to the HD thing
585 2018-01-08T21:50:36 <Lauda> Back with that wallet to 15.99, (2nd) bech address. Back to 15.1
586 2018-01-08T21:50:42 <Lauda> now both have 3QJmnh and no labels
587 2018-01-08T21:50:44 <Lauda> uh.
588 2018-01-08T21:50:51 <BlueMatt> such a hack, and I'd kinda rather have the 3QJmnh bug than completely blow up backwards compat
589 2018-01-08T21:51:23 <sipa> well i guess it depends on how we deal with transactions to bech32 addresses and then downgrade
590 2018-01-08T21:52:07 <BlueMatt> I dont (think) the 3QJmnh bug will break on-disk state, only in-memory/display
591 2018-01-08T21:52:13 <sipa> agree
592 2018-01-08T21:52:36 <BlueMatt> so its not the end of the world, but we should fix it, breaking backwards compat is a huge hammer to fix one small bug, and is really ugly for ux
593 2018-01-08T21:52:45 <BlueMatt> I mean we'd have to at least make it explicit
594 2018-01-08T21:53:06 <BlueMatt> -upgradewallettobech32segwit
595 2018-01-08T21:54:03 <sipa> for 0.16?
596 2018-01-08T21:54:07 <sipa> or later?
597 2018-01-08T21:55:23 <Lauda> If I import a privkey from a bech32 wallet (0.15.99) created, into the old one
598 2018-01-08T21:55:29 <Lauda> it gives me 3 addresses. Is this supposed to happen?
599 2018-01-08T21:55:55 <sipa> yes, unfortunately
600 2018-01-08T21:56:31 <Lauda> :<
601 2018-01-08T21:56:55 *** Randolf has quit IRC
602 2018-01-08T21:57:02 <sipa> when importing there is no way to know which of the addresses you want to use
603 2018-01-08T21:57:18 <sipa> importmulti doesn't have that problem as you must explicitly state the address or script as well
604 2018-01-08T21:57:31 <sipa> (but importmulti doesn't support segwit yet, that needs a follow-up pr)
605 2018-01-08T21:58:09 *** not-a-bot has quit IRC
606 2018-01-08T21:59:46 <Lauda> I added a bech address that has coins on it without rescan, downgraded and will rescan now
607 2018-01-08T22:00:25 <BlueMatt> sipa: for 0.16?
608 2018-01-08T22:00:46 *** mandric has joined #bitcoin-core-dev
609 2018-01-08T22:02:23 *** belcher has quit IRC
610 2018-01-08T22:03:00 <BlueMatt> cfields: so when libevent? #12123
611 2018-01-08T22:03:01 <gribble> https://github.com/bitcoin/bitcoin/issues/12123 | [Performance] LevelDB options.max_open_files = 64 parameter (Windows 10) · Issue #12123 · bitcoin/bitcoin · GitHub
612 2018-01-08T22:04:06 <sipa> BlueMatt: i'm not following
613 2018-01-08T22:04:35 <BlueMatt> sipa: nor am I
614 2018-01-08T22:04:41 <sipa> i thought you just said you prefer the 3QJmnh bug
615 2018-01-08T22:04:52 <sipa> and don't want to break backward compatibility
616 2018-01-08T22:05:20 <BlueMatt> I said I prefer the 3QJmnh to blindly deleting the default key...if we want to break backwards compat, which I dont like at all, then we'd have to require a manual upgrade
617 2018-01-08T22:05:33 <BlueMatt> I'd prefer we fix the bug
618 2018-01-08T22:05:37 <sipa> oh, i mean deleting the default whenever you decide you want bech32
619 2018-01-08T22:05:56 <sipa> whether that's explicit or implicit i don't care much
620 2018-01-08T22:06:10 <BlueMatt> it absolutely should not be implicit
621 2018-01-08T22:06:20 <BlueMatt> s/should/can/
622 2018-01-08T22:06:21 <sipa> ok, if you feel strongly
623 2018-01-08T22:06:44 <BlueMatt> since when do we blindly break downgrade implicitly on random actions?
624 2018-01-08T22:06:52 <sipa> encrpytion was one
625 2018-01-08T22:07:16 <BlueMatt> was that not documented? and thats a much less random action, imo, you can get a bech32 wallet in any one of 5 places...
626 2018-01-08T22:07:27 <BlueMatt> also importing a private key...
627 2018-01-08T22:07:29 <sipa> sure it needs to be documented
628 2018-01-08T22:08:04 <sipa> but i don't think it's unreasonable to say "if you generate a bech32 address, you can't open the wallet anymore in software that doesn't support bech32 addresses"
629 2018-01-08T22:08:14 <sipa> yeah, importprivkey is annoying
630 2018-01-08T22:08:20 *** belcher has joined #bitcoin-core-dev
631 2018-01-08T22:08:22 <BlueMatt> anyway, so options to fix the bug: a) store bech32 address book entries in a different db key space, b) dont allow multiple address book entries per public key
632 2018-01-08T22:08:35 <sipa> bah
633 2018-01-08T22:08:43 <BlueMatt> if there wer only one place you can "generate a bech32 address" I might agree, but there's many...
634 2018-01-08T22:08:54 <BlueMatt> I mean we will eventually implicitly have b
635 2018-01-08T22:08:58 <sipa> b is not possible without breaking importprivkey
636 2018-01-08T22:09:15 <BlueMatt> well by "allow" I mean look things up by their implied P2PH form
637 2018-01-08T22:09:22 <sipa> god no please
638 2018-01-08T22:09:28 <sipa> no more hacks
639 2018-01-08T22:10:16 <BlueMatt> how is that a hack?
640 2018-01-08T22:10:29 <BlueMatt> we jsut switch address book entries to be per-pubkey
641 2018-01-08T22:10:36 <BlueMatt> what the map is indexed by, who cares
642 2018-01-08T22:10:37 <sipa> bah
643 2018-01-08T22:10:50 <BlueMatt> we will get that implicitly eventually anyway...
644 2018-01-08T22:10:53 <sipa> no?
645 2018-01-08T22:11:03 <sipa> labels are for an address
646 2018-01-08T22:11:05 <sipa> not for a key
647 2018-01-08T22:11:17 <BlueMatt> yes, but if you only have one address per key, you also only have one label per key
648 2018-01-08T22:11:22 <sipa> you can have labels for p2sh multisig too
649 2018-01-08T22:11:27 <sipa> there is no good key there
650 2018-01-08T22:11:30 <BlueMatt> and, really, I think its super weird that you can do importprivkey on a key, get three address book entries, edit one address book entry and....
651 2018-01-08T22:11:32 <bitcoin-git> [bitcoin] laudaa opened pull request #12124: [wallet] Remove segwit status check (master...master) https://github.com/bitcoin/bitcoin/pull/12124
652 2018-01-08T22:12:20 <sipa> you can have lavels for addresses you don't have a key for even (watch only)
653 2018-01-08T22:12:24 <sipa> or only have a pubkey for
654 2018-01-08T22:12:27 <sipa> or p2sh
655 2018-01-08T22:12:28 <BlueMatt> yes, I'm aware
656 2018-01-08T22:12:42 <BlueMatt> ah, dont have a key for is annoying
657 2018-01-08T22:12:42 <sipa> having the label be associated with the key is just the wrong way to do it
658 2018-01-08T22:13:11 <BlueMatt> wrong way or not the result is much nicer in practice
659 2018-01-08T22:13:28 <BlueMatt> but, indeed, not having a key for it kinda blows that up
660 2018-01-08T22:13:36 <sipa> keys are things you spend with
661 2018-01-08T22:13:42 <sipa> addresses are things you receive with
662 2018-01-08T22:13:53 *** Chris_Stewart_5 has quit IRC
663 2018-01-08T22:13:53 <sipa> labels belong to the latter
664 2018-01-08T22:14:24 <BlueMatt> I agree, but practice != theory, in any case, it doesnt work in practice either :p
665 2018-01-08T22:14:32 <sipa> how do you mean?
666 2018-01-08T22:14:53 <sipa> the bug is that 0.15 doesn't support bech32 addresses
667 2018-01-08T22:14:54 <BlueMatt> in the case you want to add a label to a dont-have-pubkey bech32 address
668 2018-01-08T22:15:05 <sipa> and that we don't have a good way to mark a wallet to support bech32
669 2018-01-08T22:15:07 <BlueMatt> err, no it still workrs
670 2018-01-08T22:16:35 <sipa> i think we're spending an extraordinary amount of time here on compatibility with older software
671 2018-01-08T22:16:45 <sipa> and i wish we had better procedures for dealing with that
672 2018-01-08T22:16:54 *** anome has quit IRC
673 2018-01-08T22:17:05 <BlueMatt> we do have better procedures, but we blew then up with hd
674 2018-01-08T22:17:06 <ryanofsky> haven't followed everything above, but shouldn't it be possible to fix this with a simple change to serialization code in walletdb?
675 2018-01-08T22:17:18 <sipa> ryanofsky: how so?
676 2018-01-08T22:17:19 <BlueMatt> ryanofsky: that was my (a), above
677 2018-01-08T22:17:29 <BlueMatt> <BlueMatt> anyway, so options to fix the bug: a) store bech32 address book entries in a different db key space, b) dont allow multiple address book entries per public key
678 2018-01-08T22:17:36 <sipa> meh
679 2018-01-08T22:17:46 <ryanofsky> by serializing new addressbook entries with a different bdb key
680 2018-01-08T22:17:47 <sipa> you're much better off just making the wallet file incompatibe
681 2018-01-08T22:18:11 <ryanofsky> seems simple, and would require no change to regular wallet code
682 2018-01-08T22:18:14 <sipa> moving it to a different key space will not actually make things work - you'll still not see the labels in an old version
683 2018-01-08T22:18:21 <sipa> that's not desirable
684 2018-01-08T22:18:30 *** Arokh has quit IRC
685 2018-01-08T22:18:31 <sipa> if it's not going to actually work, it should actually not work
686 2018-01-08T22:18:59 <BlueMatt> man I miss the original plan of "fix hd upgrade, require walletupgrade for segwit wallet"
687 2018-01-08T22:19:02 <ryanofsky> oh, i didn't think that would be possible at all
688 2018-01-08T22:19:39 <sipa> having 3QJmnh show up is IMHO better than silently hiding things :)
689 2018-01-08T22:20:31 <ryanofsky> i see. really any of these options seem not that bad to me
690 2018-01-08T22:20:39 <sipa> agree
691 2018-01-08T22:20:55 <BlueMatt> which options?
692 2018-01-08T22:21:43 <ryanofsky> hiding keys, showing mangled keys, different keyspace workaround, collapsed keyspace workaround, or requiring explicit upgrade
693 2018-01-08T22:22:41 <sipa> my preference is either doing nothing and giving a nice big release notes warning that you may lose labels when downgrading after creating bech32 addresses
694 2018-01-08T22:23:02 <sipa> or making the wallet file backward incompatible whenever the first bech32 address is created
695 2018-01-08T22:23:11 <sipa> (explicitly with an action, or not)
696 2018-01-08T22:25:04 *** wxss has quit IRC
697 2018-01-08T22:25:46 <BlueMatt> labels arent copied anywhere else, right? so there's no other way for it to break your on-disk state?
698 2018-01-08T22:26:01 <sipa> i don't think so, no
699 2018-01-08T22:26:14 <sipa> after upgrading again everything should be fine
700 2018-01-08T22:26:36 <sipa> you can even create a bach32 address, give it out, downgrade, receive a transaction, upgrade... and all will work fine without rescan
701 2018-01-08T22:27:31 <BlueMatt> yes, thats my impression
702 2018-01-08T22:28:30 <sipa> also, when using importprivkey things will work as expected as long as you don't actually use the bech32 address
703 2018-01-08T22:28:51 <BlueMatt> yea, that really sucks, but there's nothing we can do to support any such workflows anyway, the transaction as displayed in 0.15.1 will always be missing the label anyway
704 2018-01-08T22:29:12 <sipa> there'll (from old software perspective) just be a weird unrelated addressbook entry added as well
705 2018-01-08T22:29:46 *** Cogito_Ergo_Sum has quit IRC
706 2018-01-08T22:33:55 *** larafale has quit IRC
707 2018-01-08T22:40:38 *** Arokh has joined #bitcoin-core-dev
708 2018-01-08T22:41:49 *** Randolf has joined #bitcoin-core-dev
709 2018-01-08T22:43:38 *** dqx_ has quit IRC
710 2018-01-08T22:44:12 *** dqx has joined #bitcoin-core-dev
711 2018-01-08T22:49:04 *** dqx has quit IRC
712 2018-01-08T22:49:05 *** Randolf has quit IRC
713 2018-01-08T22:49:18 *** Randolf has joined #bitcoin-core-dev
714 2018-01-08T22:51:25 *** MrPaz has quit IRC
715 2018-01-08T22:54:08 *** dqx has joined #bitcoin-core-dev
716 2018-01-08T22:55:30 *** jb55 has quit IRC
717 2018-01-08T22:57:33 *** Guyver2 has quit IRC
718 2018-01-08T22:58:41 *** dqx has quit IRC
719 2018-01-08T23:04:58 *** MrPaz has joined #bitcoin-core-dev
720 2018-01-08T23:05:11 *** DrFeelGood has quit IRC
721 2018-01-08T23:12:00 <BlueMatt> sipa: heh, AddAndGetDestinationForScript is only called in one place, but a AddAndGetDestinationForKey would be used in a bunch of places
722 2018-01-08T23:21:59 *** DrFeelGood has joined #bitcoin-core-dev
723 2018-01-08T23:26:23 <sipa> BlueMatt: yes
724 2018-01-08T23:27:11 <sipa> is that a problem?
725 2018-01-08T23:29:07 <sipa> it's different because AddAndGetScript is harder to split up without doing double work
726 2018-01-08T23:30:11 *** zautomata3 has joined #bitcoin-core-dev
727 2018-01-08T23:30:29 <BlueMatt> its not a problem, just found it funny
728 2018-01-08T23:30:37 <BlueMatt> i guess we dont care about wtf importwallet does?
729 2018-01-08T23:31:07 <sipa> todo for a follow up PR
730 2018-01-08T23:31:14 <sipa> just like signmessage and importmulti
731 2018-01-08T23:31:15 <BlueMatt> I mean I dont think it'll *break* anything, ....ah ok
732 2018-01-08T23:31:22 *** zautomata2 has quit IRC
733 2018-01-08T23:31:25 *** Emcy_ has quit IRC
734 2018-01-08T23:31:34 <sipa> (it's listed as such in the PR description, i think!)
735 2018-01-08T23:32:05 <sipa> but i also think it'll just work, apart from maybe birthdates and labels
736 2018-01-08T23:32:08 <BlueMatt> heh, text? ewwww why would i read that
737 2018-01-08T23:36:14 *** Emcy has joined #bitcoin-core-dev
738 2018-01-08T23:36:45 *** zautomata3 has quit IRC
739 2018-01-08T23:38:32 *** zautomata3 has joined #bitcoin-core-dev
740 2018-01-08T23:42:49 <sipa> i know
741 2018-01-08T23:44:50 *** dqx has joined #bitcoin-core-dev
742 2018-01-08T23:45:44 *** BashCo_ has quit IRC
743 2018-01-08T23:46:24 *** BashCo has joined #bitcoin-core-dev
744 2018-01-08T23:47:29 *** Emcy_ has joined #bitcoin-core-dev
745 2018-01-08T23:49:05 *** dqx has quit IRC
746 2018-01-08T23:49:56 *** Emcy has quit IRC
747 2018-01-08T23:54:51 *** mandric has quit IRC
748 2018-01-08T23:58:14 *** logicue has quit IRC