12018-01-08T00:00:30 *** promag has joined #bitcoin-core-dev
22018-01-08T00:05:46 *** ludens[m] has quit IRC
32018-01-08T00:05:47 *** herzmeister[m] has quit IRC
42018-01-08T00:05:55 *** ajtowns[m] has quit IRC
52018-01-08T00:05:55 *** kewde[m] has quit IRC
62018-01-08T00:06:00 *** Masaomi[m] has quit IRC
72018-01-08T00:07:57 *** hirish is now known as hirishaway
82018-01-08T00:08:27 *** da2ce7 has quit IRC
92018-01-08T00:09:57 *** promag has quit IRC
102018-01-08T00:10:31 *** Danilo_ has joined #bitcoin-core-dev
112018-01-08T00:10:52 *** da2ce7 has joined #bitcoin-core-dev
122018-01-08T00:13:07 *** kewde[m] has joined #bitcoin-core-dev
132018-01-08T00:14:15 *** Cogito_Ergo_Sum has quit IRC
142018-01-08T00:15:14 *** jl2012 has quit IRC
152018-01-08T00:16:07 *** jb55 has joined #bitcoin-core-dev
162018-01-08T00:16:09 *** anome has joined #bitcoin-core-dev
172018-01-08T00:19:10 *** logicue has quit IRC
182018-01-08T00:21:36 *** herzmeister[m] has joined #bitcoin-core-dev
192018-01-08T00:21:36 *** ajtowns[m] has joined #bitcoin-core-dev
202018-01-08T00:21:37 *** Masaomi[m] has joined #bitcoin-core-dev
212018-01-08T00:21:44 *** ludens[m] has joined #bitcoin-core-dev
222018-01-08T00:22:41 *** prometheus_falli has joined #bitcoin-core-dev
232018-01-08T00:28:14 *** jb55 has quit IRC
242018-01-08T00:31:12 *** meshcollider has joined #bitcoin-core-dev
252018-01-08T00:33:13 *** anome has quit IRC
262018-01-08T00:37:47 *** Tennis has quit IRC
272018-01-08T00:48:45 *** hirishaway is now known as hirish
282018-01-08T00:52:56 <go1111111> is it a known issue that the input selection UI is super unresponsive while Core 0.15.1 is syncing the blockchain? it's taking over 5 seconds to respond to mouse actions (I'm using Linux Mint 18.2). If not, could someone try to repro it to verify its not something weird in my machine?
292018-01-08T00:53:18 <go1111111> once Core is fully synced, the input selection UI responds quickly
302018-01-08T01:01:28 <eu-Robert> sounds like a low priority problem
312018-01-08T01:01:44 <eu-Robert> as in low priority to fix
322018-01-08T01:04:32 *** hirish is now known as hirishaway
332018-01-08T01:06:37 *** promag has joined #bitcoin-core-dev
342018-01-08T01:09:50 *** talesofterror has quit IRC
352018-01-08T01:11:10 *** promag has quit IRC
362018-01-08T01:11:11 *** talesofterror has joined #bitcoin-core-dev
372018-01-08T01:21:56 *** dqx has joined #bitcoin-core-dev
382018-01-08T01:22:34 *** dqx has joined #bitcoin-core-dev
392018-01-08T01:49:15 *** Randolf has joined #bitcoin-core-dev
402018-01-08T01:56:15 <luke-jr> yay, Gentoo finally addressed that 2015 miniupnpc buffer overflow https://security.gentoo.org/glsa/201801-08
412018-01-08T02:11:13 *** jl2012 has joined #bitcoin-core-dev
422018-01-08T02:12:50 *** belcher_ has quit IRC
432018-01-08T02:13:59 *** CubicEarths has quit IRC
442018-01-08T02:14:36 *** CubicEarths has joined #bitcoin-core-dev
452018-01-08T02:18:49 <bitcoin-git> [bitcoin] jackycjh opened pull request #12112: Docs: Remove the ending slashes from RPC URI format. (master...docs/multi-wallet_RPC_interface_correction) https://github.com/bitcoin/bitcoin/pull/12112
462018-01-08T02:24:43 *** CubicEar_ has joined #bitcoin-core-dev
472018-01-08T02:26:56 *** ossifrage has quit IRC
482018-01-08T02:28:29 *** CubicEarths has quit IRC
492018-01-08T02:34:48 *** CubicEarths has joined #bitcoin-core-dev
502018-01-08T02:38:05 *** CubicEar_ has quit IRC
512018-01-08T02:40:18 *** meshcollider has quit IRC
522018-01-08T02:44:45 *** meshcollider has joined #bitcoin-core-dev
532018-01-08T02:46:41 *** talesofterror has quit IRC
542018-01-08T02:49:16 *** dabura667 has joined #bitcoin-core-dev
552018-01-08T02:50:23 *** talesofterror has joined #bitcoin-core-dev
562018-01-08T02:53:58 *** d9b4bef9 has quit IRC
572018-01-08T02:55:13 *** d9b4bef9 has joined #bitcoin-core-dev
582018-01-08T02:56:10 *** dabura667 has quit IRC
592018-01-08T02:56:43 *** dabura667 has joined #bitcoin-core-dev
602018-01-08T03:00:10 *** dabura667 has quit IRC
612018-01-08T03:06:49 *** LeMiner2 has joined #bitcoin-core-dev
622018-01-08T03:07:11 *** jouke has quit IRC
632018-01-08T03:09:20 *** LeMiner has quit IRC
642018-01-08T03:09:20 *** LeMiner2 is now known as LeMiner
652018-01-08T03:09:53 *** tri333 has joined #bitcoin-core-dev
662018-01-08T03:09:54 <tri333> hi
672018-01-08T03:14:50 *** jouke has joined #bitcoin-core-dev
682018-01-08T03:14:54 *** atroxes has quit IRC
692018-01-08T03:15:37 *** atroxes has joined #bitcoin-core-dev
702018-01-08T03:23:54 *** Cheeseo has quit IRC
712018-01-08T03:23:59 *** cheese_ has joined #bitcoin-core-dev
722018-01-08T03:27:16 *** prometheus_falli has quit IRC
732018-01-08T03:27:51 *** talesofterror has quit IRC
742018-01-08T03:38:09 *** Giszmo has quit IRC
752018-01-08T04:08:57 *** Randolf has quit IRC
762018-01-08T04:27:35 *** prometheus_falli has joined #bitcoin-core-dev
772018-01-08T04:36:42 *** tknp has joined #bitcoin-core-dev
782018-01-08T04:51:19 *** ossifrage has joined #bitcoin-core-dev
792018-01-08T04:52:09 *** MrPaz has joined #bitcoin-core-dev
802018-01-08T05:06:24 *** Randolf has joined #bitcoin-core-dev
812018-01-08T05:39:36 *** Eetsi123 has joined #bitcoin-core-dev
822018-01-08T05:42:48 *** intcat has quit IRC
832018-01-08T05:44:10 *** MrPaz has quit IRC
842018-01-08T05:48:24 *** intcat has joined #bitcoin-core-dev
852018-01-08T05:53:32 *** intcat has quit IRC
862018-01-08T05:54:16 *** intcat has joined #bitcoin-core-dev
872018-01-08T05:54:54 *** AaronvanW has quit IRC
882018-01-08T05:55:25 *** magicoffee has joined #bitcoin-core-dev
892018-01-08T05:59:19 *** eu-Robert has quit IRC
902018-01-08T06:01:56 *** magicoffee has quit IRC
912018-01-08T06:02:41 *** mrfrasha has joined #bitcoin-core-dev
922018-01-08T06:05:43 *** jb55 has joined #bitcoin-core-dev
932018-01-08T06:33:05 *** Amuza has quit IRC
942018-01-08T06:33:21 *** jb55 has quit IRC
952018-01-08T06:37:15 *** mrfrasha has quit IRC
962018-01-08T06:38:42 *** mrfrasha has joined #bitcoin-core-dev
972018-01-08T06:41:16 <bitcoin-git> [bitcoin] AjkP opened pull request #12113: Qt: Fixed styling in modaloverlay.cpp (master...ajkp/modaloverlay_styling) https://github.com/bitcoin/bitcoin/pull/12113
982018-01-08T06:50:36 *** dqx has quit IRC
992018-01-08T06:55:57 *** d9b4bef9 has quit IRC
1002018-01-08T06:57:04 *** d9b4bef9 has joined #bitcoin-core-dev
1012018-01-08T07:02:07 *** AaronvanW has joined #bitcoin-core-dev
1022018-01-08T07:07:02 *** prometheus_falli has quit IRC
1032018-01-08T07:13:16 *** Masaomi[m] has quit IRC
1042018-01-08T07:13:16 *** derbumi has quit IRC
1052018-01-08T07:13:39 *** derbumi has joined #bitcoin-core-dev
1062018-01-08T07:14:25 *** Masaomi[m] has joined #bitcoin-core-dev
1072018-01-08T07:15:54 *** AaronvanW has quit IRC
1082018-01-08T07:16:17 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1092018-01-08T07:16:17 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1102018-01-08T07:26:01 *** whphhg has quit IRC
1112018-01-08T07:36:02 *** Cheeseo has joined #bitcoin-core-dev
1122018-01-08T07:36:55 *** zeek has joined #bitcoin-core-dev
1132018-01-08T07:38:58 *** AaronvanW has joined #bitcoin-core-dev
1142018-01-08T07:39:11 *** cheese_ has quit IRC
1152018-01-08T07:39:19 *** zeek has quit IRC
1162018-01-08T07:53:21 *** promag has joined #bitcoin-core-dev
1172018-01-08T07:53:58 *** mcochrane has joined #bitcoin-core-dev
1182018-01-08T07:54:55 *** dqx has joined #bitcoin-core-dev
1192018-01-08T07:56:17 *** mcochrane_ has quit IRC
1202018-01-08T07:57:53 *** promag has quit IRC
1212018-01-08T07:59:39 *** dqx has quit IRC
1222018-01-08T08:08:28 *** intcat has quit IRC
1232018-01-08T08:08:52 <bitcoin-git> [bitcoin] TexasSooner opened pull request #12114: update jan 8 (master...master) https://github.com/bitcoin/bitcoin/pull/12114
1242018-01-08T08:09:47 <bitcoin-git> [bitcoin] TexasSooner closed pull request #12114: update jan 8 (master...master) https://github.com/bitcoin/bitcoin/pull/12114
1252018-01-08T08:10:06 *** intcat has joined #bitcoin-core-dev
1262018-01-08T08:15:36 *** Squidicc has quit IRC
1272018-01-08T08:16:06 *** Squidicc has joined #bitcoin-core-dev
1282018-01-08T08:16:37 *** Danilo__ has joined #bitcoin-core-dev
1292018-01-08T08:17:20 *** timothy has joined #bitcoin-core-dev
1302018-01-08T08:19:21 *** Danilo_ has quit IRC
1312018-01-08T08:24:41 *** Amuza has joined #bitcoin-core-dev
1322018-01-08T08:28:39 *** anome has joined #bitcoin-core-dev
1332018-01-08T08:30:18 *** meshcollider has quit IRC
1342018-01-08T08:31:05 *** tri333 has quit IRC
1352018-01-08T08:33:40 *** anome has quit IRC
1362018-01-08T08:33:41 *** anome has joined #bitcoin-core-dev
1372018-01-08T08:40:53 *** anome has quit IRC
1382018-01-08T08:41:15 *** anome has joined #bitcoin-core-dev
1392018-01-08T08:58:06 *** anome has quit IRC
1402018-01-08T09:16:07 *** JackH has joined #bitcoin-core-dev
1412018-01-08T09:23:47 *** logicue has joined #bitcoin-core-dev
1422018-01-08T09:28:54 *** anome has joined #bitcoin-core-dev
1432018-01-08T09:42:25 *** cysm has quit IRC
1442018-01-08T09:45:05 *** promag has joined #bitcoin-core-dev
1452018-01-08T09:47:13 <sipa> BlueMatt: feel like having a look at #11403 again?
1462018-01-08T09:47:19 <gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
1472018-01-08T09:50:32 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12113: Qt: Fixed styling in modaloverlay.cpp (master...ajkp/modaloverlay_styling) https://github.com/bitcoin/bitcoin/pull/12113
1482018-01-08T09:51:54 *** promag has quit IRC
1492018-01-08T09:56:25 *** promag has joined #bitcoin-core-dev
1502018-01-08T09:59:55 *** cysm has joined #bitcoin-core-dev
1512018-01-08T10:14:36 *** AaronvanW has quit IRC
1522018-01-08T10:18:57 *** AaronvanW has joined #bitcoin-core-dev
1532018-01-08T10:23:11 *** AaronvanW has quit IRC
1542018-01-08T10:23:29 *** whphhg has joined #bitcoin-core-dev
1552018-01-08T10:24:19 *** logicue has quit IRC
1562018-01-08T10:27:10 *** CubicEarths has quit IRC
1572018-01-08T10:32:35 *** cysm has quit IRC
1582018-01-08T10:44:55 *** shesek has quit IRC
1592018-01-08T10:45:41 *** promag has quit IRC
1602018-01-08T10:45:57 *** cysm has joined #bitcoin-core-dev
1612018-01-08T10:49:50 *** JackH has quit IRC
1622018-01-08T10:52:23 *** promag has joined #bitcoin-core-dev
1632018-01-08T10:53:57 *** d9b4bef9 has quit IRC
1642018-01-08T10:54:17 *** promag has quit IRC
1652018-01-08T10:57:04 *** d9b4bef9 has joined #bitcoin-core-dev
1662018-01-08T10:58:00 *** CubicEarths has joined #bitcoin-core-dev
1672018-01-08T10:58:23 *** shesek has joined #bitcoin-core-dev
1682018-01-08T10:58:23 *** shesek has joined #bitcoin-core-dev
1692018-01-08T10:59:00 *** Boop has joined #bitcoin-core-dev
1702018-01-08T10:59:11 *** hirishaway is now known as hirish
1712018-01-08T10:59:38 *** Boop has quit IRC
1722018-01-08T11:02:40 *** CubicEarths has quit IRC
1732018-01-08T11:08:56 *** AaronvanW has joined #bitcoin-core-dev
1742018-01-08T11:09:47 *** promag has joined #bitcoin-core-dev
1752018-01-08T11:22:26 *** Midak has joined #bitcoin-core-dev
1762018-01-08T11:29:06 *** mrfrasha has quit IRC
1772018-01-08T11:30:29 *** Midak has quit IRC
1782018-01-08T11:32:53 *** CubicEarths has joined #bitcoin-core-dev
1792018-01-08T11:34:28 *** Guyver2 has joined #bitcoin-core-dev
1802018-01-08T11:37:35 *** CubicEarths has quit IRC
1812018-01-08T11:39:57 *** logicue has joined #bitcoin-core-dev
1822018-01-08T11:41:35 *** anome has quit IRC
1832018-01-08T11:42:20 *** larafale has joined #bitcoin-core-dev
1842018-01-08T11:46:19 *** hirish is now known as hirishaway
1852018-01-08T11:50:51 *** Amuza has quit IRC
1862018-01-08T11:52:50 *** promag has quit IRC
1872018-01-08T11:57:20 *** promag has joined #bitcoin-core-dev
1882018-01-08T11:57:37 *** Amuza has joined #bitcoin-core-dev
1892018-01-08T11:58:24 *** Lauda has quit IRC
1902018-01-08T11:59:01 *** Lauda has joined #bitcoin-core-dev
1912018-01-08T12:00:03 *** Manu_ has joined #bitcoin-core-dev
1922018-01-08T12:06:03 *** CubicEarths has joined #bitcoin-core-dev
1932018-01-08T12:08:02 *** anome has joined #bitcoin-core-dev
1942018-01-08T12:10:05 *** CubicEarths has quit IRC
1952018-01-08T12:10:56 *** anome has quit IRC
1962018-01-08T12:14:23 *** Manu_ has quit IRC
1972018-01-08T12:14:24 *** Giszmo has joined #bitcoin-core-dev
1982018-01-08T12:15:04 *** JackH has joined #bitcoin-core-dev
1992018-01-08T12:16:40 *** anome has joined #bitcoin-core-dev
2002018-01-08T12:18:46 *** anome has quit IRC
2012018-01-08T12:21:12 *** _flow_ has quit IRC
2022018-01-08T12:25:25 *** anome has joined #bitcoin-core-dev
2032018-01-08T12:27:41 *** anome has quit IRC
2042018-01-08T12:32:24 *** DrFeelGood has quit IRC
2052018-01-08T12:33:08 *** anome has joined #bitcoin-core-dev
2062018-01-08T12:33:52 *** DrFeelGood has joined #bitcoin-core-dev
2072018-01-08T12:35:15 *** anome has quit IRC
2082018-01-08T12:43:41 *** anome has joined #bitcoin-core-dev
2092018-01-08T12:50:55 *** anome has quit IRC
2102018-01-08T12:57:02 *** Randolf has quit IRC
2112018-01-08T12:58:05 *** logicue has quit IRC
2122018-01-08T13:02:24 *** promag has quit IRC
2132018-01-08T13:03:10 *** anome has joined #bitcoin-core-dev
2142018-01-08T13:06:04 *** dqx has joined #bitcoin-core-dev
2152018-01-08T13:08:18 *** _flow_ has joined #bitcoin-core-dev
2162018-01-08T13:10:33 *** dqx has quit IRC
2172018-01-08T13:16:07 *** CubicEarths has joined #bitcoin-core-dev
2182018-01-08T13:20:55 *** CubicEarths has quit IRC
2192018-01-08T13:23:12 *** ghost43 has quit IRC
2202018-01-08T13:23:12 *** arubi has quit IRC
2212018-01-08T13:23:13 *** intcat has quit IRC
2222018-01-08T13:25:03 *** intcat has joined #bitcoin-core-dev
2232018-01-08T13:26:08 *** Monte35Osinski has joined #bitcoin-core-dev
2242018-01-08T13:28:44 *** ghost43 has joined #bitcoin-core-dev
2252018-01-08T13:33:44 *** arubi has joined #bitcoin-core-dev
2262018-01-08T13:37:34 *** anome has quit IRC
2272018-01-08T13:41:55 *** logicue has joined #bitcoin-core-dev
2282018-01-08T13:48:50 *** promag has joined #bitcoin-core-dev
2292018-01-08T13:51:06 *** promag has quit IRC
2302018-01-08T13:52:48 *** CubicEarths has joined #bitcoin-core-dev
2312018-01-08T13:57:10 *** promag has joined #bitcoin-core-dev
2322018-01-08T13:57:27 *** CubicEarths has quit IRC
2332018-01-08T14:05:05 *** Randolf has joined #bitcoin-core-dev
2342018-01-08T14:05:54 *** c01nkiller has joined #bitcoin-core-dev
2352018-01-08T14:06:24 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2362018-01-08T14:07:53 *** Eetsi123 has quit IRC
2372018-01-08T14:12:18 *** logicue has quit IRC
2382018-01-08T14:14:51 *** belcher has joined #bitcoin-core-dev
2392018-01-08T14:17:51 *** anome has joined #bitcoin-core-dev
2402018-01-08T14:19:13 *** anome has quit IRC
2412018-01-08T14:21:09 *** DrFeelGood has quit IRC
2422018-01-08T14:21:58 *** DrFeelGood has joined #bitcoin-core-dev
2432018-01-08T14:22:57 *** Chris_Stewart_5 has quit IRC
2442018-01-08T14:24:35 *** AaronvanW has quit IRC
2452018-01-08T14:25:38 *** CubicEarths has joined #bitcoin-core-dev
2462018-01-08T14:30:37 *** CubicEarths has quit IRC
2472018-01-08T14:32:54 *** c01nkiller has quit IRC
2482018-01-08T14:33:43 *** CubicEarths has joined #bitcoin-core-dev
2492018-01-08T14:35:23 *** anome has joined #bitcoin-core-dev
2502018-01-08T14:37:56 *** anome has quit IRC
2512018-01-08T14:39:05 *** CubicEarths has quit IRC
2522018-01-08T14:57:28 *** zautomata has joined #bitcoin-core-dev
2532018-01-08T14:57:47 *** CubicEarths has joined #bitcoin-core-dev
2542018-01-08T14:58:38 <BlueMatt> sipa: yep, will do today
2552018-01-08T15:01:57 *** CubicEarths has quit IRC
2562018-01-08T15:05:07 *** promag has quit IRC
2572018-01-08T15:14:32 *** Squidicc has quit IRC
2582018-01-08T15:14:56 *** Squidicuz has joined #bitcoin-core-dev
2592018-01-08T15:18:39 *** Emcy has quit IRC
2602018-01-08T15:18:53 *** Emcy has joined #bitcoin-core-dev
2612018-01-08T15:20:16 *** Amuza has quit IRC
2622018-01-08T15:21:09 *** dqx has joined #bitcoin-core-dev
2632018-01-08T15:25:11 *** dqx has quit IRC
2642018-01-08T15:27:36 *** anome has joined #bitcoin-core-dev
2652018-01-08T15:29:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2662018-01-08T15:32:14 *** logicue has joined #bitcoin-core-dev
2672018-01-08T15:33:12 *** mandric has joined #bitcoin-core-dev
2682018-01-08T15:36:59 *** CubicEarths has joined #bitcoin-core-dev
2692018-01-08T15:41:21 *** CubicEarths has quit IRC
2702018-01-08T15:42:56 *** ghost43 has quit IRC
2712018-01-08T15:43:19 *** ghost43 has joined #bitcoin-core-dev
2722018-01-08T15:47:12 *** dqx has joined #bitcoin-core-dev
2732018-01-08T15:47:40 *** MrPaz has joined #bitcoin-core-dev
2742018-01-08T15:47:45 *** Monte35Osinski has quit IRC
2752018-01-08T15:48:31 *** logicue has quit IRC
2762018-01-08T15:50:26 *** dqx_ has joined #bitcoin-core-dev
2772018-01-08T15:51:19 *** dqx has quit IRC
2782018-01-08T15:53:21 *** wxss has joined #bitcoin-core-dev
2792018-01-08T15:55:47 *** dqx_ has quit IRC
2802018-01-08T16:03:35 *** Schwineigel has joined #bitcoin-core-dev
2812018-01-08T16:03:58 <Schwineigel> help
2822018-01-08T16:04:32 <Schwineigel> first transaction did not go through.
2832018-01-08T16:04:47 <Schwineigel> it was sent 6 jan 18
2842018-01-08T16:05:08 <Schwineigel> what do i do
2852018-01-08T16:05:38 <Lauda> Schwineigel: #bitcoin
2862018-01-08T16:05:50 <Schwineigel> hi
2872018-01-08T16:07:02 <Schwineigel> My first transaction sending satoshi out did not work what do i do?
2882018-01-08T16:07:42 <Schwineigel> It was sent 6 Jan 18 it is still pending
2892018-01-08T16:10:17 <Schwineigel> i guess i came to the wrong place for help
2902018-01-08T16:10:40 *** dqx has joined #bitcoin-core-dev
2912018-01-08T16:12:28 <Schwineigel> i came here to find help
2922018-01-08T16:13:05 <Schwineigel> My trasnaction has not gone through, i made it on 6 jan
2932018-01-08T16:13:33 <achow101> Schwineigel: this channel is for Bitcoin Core development, not for helping users
2942018-01-08T16:13:44 <achow101> for general help, go to #bitcoin
2952018-01-08T16:14:03 *** CubicEarths has joined #bitcoin-core-dev
2962018-01-08T16:14:32 <Schwineigel> ok sorry to bother you. thanks for the info
2972018-01-08T16:14:40 *** Schwineigel has quit IRC
2982018-01-08T16:15:40 *** dqx has quit IRC
2992018-01-08T16:16:38 *** zautomata1 has joined #bitcoin-core-dev
3002018-01-08T16:17:09 *** interestedbystan has joined #bitcoin-core-dev
3012018-01-08T16:18:09 *** Abdul has joined #bitcoin-core-dev
3022018-01-08T16:18:18 *** zautomata has quit IRC
3032018-01-08T16:18:39 *** CubicEarths has quit IRC
3042018-01-08T16:18:56 *** Abdul has quit IRC
3052018-01-08T16:19:01 *** interestedbystan has quit IRC
3062018-01-08T16:19:15 *** dqx has joined #bitcoin-core-dev
3072018-01-08T16:19:30 *** m8tion has joined #bitcoin-core-dev
3082018-01-08T16:21:28 *** mcochrane has quit IRC
3092018-01-08T16:22:32 *** mrfrasha has joined #bitcoin-core-dev
3102018-01-08T16:27:55 *** mandric has quit IRC
3112018-01-08T16:28:56 *** JackH has quit IRC
3122018-01-08T16:33:08 *** Murch has joined #bitcoin-core-dev
3132018-01-08T16:35:27 *** laurentmt has joined #bitcoin-core-dev
3142018-01-08T16:45:29 *** CubicEarths has joined #bitcoin-core-dev
3152018-01-08T16:48:08 <ossifrage> still no love building bitcoin-qt with -flto: ./libtool: line 1720: 18164 Segmentation fault (core dumped) /usr/bin/gcc-ranlib .libs/libsecp256k1.a
3162018-01-08T16:50:07 *** CubicEarths has quit IRC
3172018-01-08T16:51:49 *** laurentmt has quit IRC
3182018-01-08T16:54:24 <BlueMatt> ossifrage: segfault in ranlib sounds like a gcc bug to be reported upstream, no?
3192018-01-08T16:54:59 *** Randolf has quit IRC
3202018-01-08T16:55:05 *** blackeye01 has joined #bitcoin-core-dev
3212018-01-08T16:57:15 *** Murch has quit IRC
3222018-01-08T17:04:09 *** blackeye01 has quit IRC
3232018-01-08T17:05:16 *** Murch has joined #bitcoin-core-dev
3242018-01-08T17:05:57 *** laurentmt has joined #bitcoin-core-dev
3252018-01-08T17:06:29 *** dqx has quit IRC
3262018-01-08T17:06:54 *** anome has quit IRC
3272018-01-08T17:07:15 *** laurentmt has quit IRC
3282018-01-08T17:07:16 *** anome has joined #bitcoin-core-dev
3292018-01-08T17:15:23 *** Randolf has joined #bitcoin-core-dev
3302018-01-08T17:16:21 *** flotwig has joined #bitcoin-core-dev
3312018-01-08T17:19:45 *** CubicEarths has joined #bitcoin-core-dev
3322018-01-08T17:22:12 *** jtimon has joined #bitcoin-core-dev
3332018-01-08T17:24:27 *** CubicEarths has quit IRC
3342018-01-08T17:24:51 *** PaulCapestany has quit IRC
3352018-01-08T17:25:37 *** PaulCape_ has joined #bitcoin-core-dev
3362018-01-08T17:29:15 *** dqx has joined #bitcoin-core-dev
3372018-01-08T17:31:08 *** Szadek has joined #bitcoin-core-dev
3382018-01-08T17:33:07 *** rlesias has joined #bitcoin-core-dev
3392018-01-08T17:38:50 *** rlesias has quit IRC
3402018-01-08T17:44:29 *** mandric has joined #bitcoin-core-dev
3412018-01-08T17:45:12 <ossifrage> BlueMatt, yeah it should be reported upstream, but I haven't put the effort in to find a clean testcase
3422018-01-08T17:50:19 *** CubicEarths has joined #bitcoin-core-dev
3432018-01-08T17:54:42 *** Murch has quit IRC
3442018-01-08T17:54:57 *** CubicEarths has quit IRC
3452018-01-08T17:56:06 *** Murch has joined #bitcoin-core-dev
3462018-01-08T18:03:07 *** litecoinDev has joined #bitcoin-core-dev
3472018-01-08T18:04:17 *** litecoinDev has quit IRC
3482018-01-08T18:05:36 *** MrPaz has quit IRC
3492018-01-08T18:13:41 *** hirishaway is now known as hirish
3502018-01-08T18:15:42 *** Murch has quit IRC
3512018-01-08T18:16:38 *** George has joined #bitcoin-core-dev
3522018-01-08T18:16:39 *** mandric has quit IRC
3532018-01-08T18:17:10 *** Murch has joined #bitcoin-core-dev
3542018-01-08T18:17:16 *** MrPaz has joined #bitcoin-core-dev
3552018-01-08T18:18:36 *** anome has quit IRC
3562018-01-08T18:20:15 *** m8tion has quit IRC
3572018-01-08T18:23:51 *** timothy has quit IRC
3582018-01-08T18:25:46 *** CubicEarths has joined #bitcoin-core-dev
3592018-01-08T18:27:47 *** cncr04s has joined #bitcoin-core-dev
3602018-01-08T18:30:23 *** CubicEarths has quit IRC
3612018-01-08T18:32:26 *** kexkey has joined #bitcoin-core-dev
3622018-01-08T18:35:37 *** promag has joined #bitcoin-core-dev
3632018-01-08T18:40:23 *** promag has quit IRC
3642018-01-08T18:45:11 *** logicue has joined #bitcoin-core-dev
3652018-01-08T18:50:15 *** CubicEarths has joined #bitcoin-core-dev
3662018-01-08T18:51:31 *** MrPaz has quit IRC
3672018-01-08T18:56:31 *** dqx has quit IRC
3682018-01-08T18:57:01 *** dqx has joined #bitcoin-core-dev
3692018-01-08T18:59:07 <bitcoin-git> [bitcoin] sdaftuar opened pull request #12118: Sort mempool by min(feerate, ancestor_feerate) (master...2018-01-fix-mempool-score) https://github.com/bitcoin/bitcoin/pull/12118
3702018-01-08T19:04:25 *** dqx has quit IRC
3712018-01-08T19:04:41 *** jb55 has joined #bitcoin-core-dev
3722018-01-08T19:08:43 *** dqx has joined #bitcoin-core-dev
3732018-01-08T19:09:22 *** logicue has quit IRC
3742018-01-08T19:11:37 *** MrPaz has joined #bitcoin-core-dev
3752018-01-08T19:13:04 *** dqx has quit IRC
3762018-01-08T19:20:32 *** jb55 has quit IRC
3772018-01-08T19:20:39 *** Dizzle has joined #bitcoin-core-dev
3782018-01-08T19:25:33 <bitcoin-git> [bitcoin] Sjors opened pull request #12119: [wallet] use bech32 change address if all destinations are bech32 (master...bech32-change) https://github.com/bitcoin/bitcoin/pull/12119
3792018-01-08T19:26:30 *** zautomata2 has joined #bitcoin-core-dev
3802018-01-08T19:27:27 *** zautomata1 has quit IRC
3812018-01-08T19:34:15 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12120: Add dev guideline limiting auto usage. (master...2018-01-auto-devnotes) https://github.com/bitcoin/bitcoin/pull/12120
3822018-01-08T19:34:36 * BlueMatt is gonna have to start a policy of auto-nacking anything with auto that doesnt save at least 30 chars of typing
3832018-01-08T19:42:52 <sipa> BlueMatt: :(
3842018-01-08T19:43:22 * achow101 replaces every word in the repo with auto
3852018-01-08T19:45:41 <TD-Linux> #define let const auto
3862018-01-08T19:46:16 *** Szadek has quit IRC
3872018-01-08T19:47:37 *** HollowRiddler has joined #bitcoin-core-dev
3882018-01-08T19:48:46 *** dqx has joined #bitcoin-core-dev
3892018-01-08T19:49:12 <Chris_Stewart_5> Does the bitcoin core software dump txs back into the mempool when a chain is clearly orphaned?
3902018-01-08T19:49:40 * BlueMatt is an auto-kermudgen
3912018-01-08T19:49:51 <sipa> BlueMatt: i don't understand the rationale for that. in the case you reference, just see it as a replacement for inlining
3922018-01-08T19:50:27 *** anome has joined #bitcoin-core-dev
3932018-01-08T19:50:46 <sipa> (you could replace the two instances of 'key' with a call to GetKeyForDestination)
3942018-01-08T19:51:35 <sipa> anyway, i don't feel strongly and if you insist i'll gladly change it... but i think making the type explicit there is less readable
3952018-01-08T19:54:38 <Dizzle> Chris_Stewart_5: yep! It will not automatically rebroadcast them though. It will of course send along its revised mempool to any other peer that asks for it though.
3962018-01-08T19:55:00 <luke-jr> I can see places where auto can help readability, and also places where it can hurt readability.
3972018-01-08T19:55:32 <BlueMatt> sipa: I mean my objection in cases like that is if i want to go audit what IsNull does, I now have to go lookup two things, indeed there is a tradeoff because there may be a type conversion hiding in the = (evil, evil C++), but...
3982018-01-08T19:55:55 <sipa> with auto you know no implciit type conversion can happen :)
3992018-01-08T19:56:01 <BlueMatt> (and, yes, I do look up things like what IsNull() does quite often in review, but of course it depends on what the type is of if I know what it does already....)
4002018-01-08T19:56:09 *** dqx has quit IRC
4012018-01-08T19:56:19 <BlueMatt> indeed, thats the tradeoff...I wish there were a "this type, and no fucking conversion you piece of shit compiler" option in C++
4022018-01-08T19:56:44 <sipa> or make all type conversions explicit :)
4032018-01-08T19:56:49 <BlueMatt> well, yea
4042018-01-08T19:57:06 * BlueMatt hates surprises
4052018-01-08T19:57:09 *** anome has quit IRC
4062018-01-08T19:57:47 <BlueMatt> with the auto in the case mentioned, I have to go do a speculative lookup of the type and use that to speculatively lookup what IsNull() does....waiiiitttttt
4072018-01-08T19:58:23 <sipa> right... but if thete was only one instance of 'key' in the function, and the GetKeyForDestination clal was inlined into it.... would you complain about that too?
4082018-01-08T19:58:34 <sipa> this is just a more efficient way of doing that
4092018-01-08T20:00:32 * BlueMatt has been reading too many spectre posts this weekend, clearly
4102018-01-08T20:00:39 <cncr04s> Is it possible to implement working mainnet LN on my service?
4112018-01-08T20:01:45 <Chris_Stewart_5> Dizzle: Is there a specific amount of confirmations required to do this? I.e. one chain is ahead of the orphaned chain by 6 confirmations
4122018-01-08T20:02:03 *** dqx has joined #bitcoin-core-dev
4132018-01-08T20:02:17 <luke-jr> BlueMatt: happen to find a usable workaround? :x
4142018-01-08T20:02:55 *** mandric has joined #bitcoin-core-dev
4152018-01-08T20:03:31 *** dqx has quit IRC
4162018-01-08T20:03:41 <BlueMatt> sipa: no, in that case I likely wouldnt have looked up the type, but I probably should have to check for implicit conversion, but mostly in that case I would have just go read the function taking it as argument and found the type in the signature, the issue is that its actually used for more than the pass-through
4172018-01-08T20:03:55 <sipa> BlueMatt: you misunderstand
4182018-01-08T20:04:04 <BlueMatt> luke-jr: depends on how many syscalls you do....also, the fucking intel microcode updates are all-but-undocumented
4192018-01-08T20:04:06 *** dqx has joined #bitcoin-core-dev
4202018-01-08T20:04:19 <CryptAxe> Chris_Stewart_5 : https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2199-L2243
4212018-01-08T20:04:42 <CryptAxe> specifically: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2223-L2234
4222018-01-08T20:04:59 <CryptAxe> Looks like they are added to the mempool right when the block is disconnected
4232018-01-08T20:05:15 <sipa> BlueMatt: imagine that instead of key.IsNull() it was GetKeyForDestination(*pwallet, dest).IsNull()
4242018-01-08T20:05:36 <sipa> CryptAxe, Chris_Stewart_5: yes, immediately... what else?
4252018-01-08T20:05:40 *** Murch has quit IRC
4262018-01-08T20:05:54 <BlueMatt> then I'd have to do the same lookup as the auto, but possibly wouldnt have complained, no, it still sucks just as much
4272018-01-08T20:06:02 <sipa> okay :)
4282018-01-08T20:06:16 *** dqx has quit IRC
4292018-01-08T20:06:25 *** dqx has joined #bitcoin-core-dev
4302018-01-08T20:06:34 <sipa> so you're basically saying that every intermediate expression should be annotated explicitly with its type (apart from that being unreasonable)
4312018-01-08T20:07:06 *** Murch has joined #bitcoin-core-dev
4322018-01-08T20:07:08 <BlueMatt> it would assist with review, and were it roughly as readable, I'd highly, highly prefer that
4332018-01-08T20:07:10 <Chris_Stewart_5> CryptAxe: Thanks!
4342018-01-08T20:07:30 * BlueMatt hates surprises :p
4352018-01-08T20:08:02 <sipa> BlueMatt: fair; i guess i just disagree that that is more readable :)
4362018-01-08T20:08:17 <BlueMatt> its all of 4 chars longer on a short line :(
4372018-01-08T20:09:16 <BlueMatt> maybe I just need to hack my editor to pull shit out of the C++ ast and display the types :p
4382018-01-08T20:12:21 *** Tennis has joined #bitcoin-core-dev
4392018-01-08T20:15:56 *** isle2983 has joined #bitcoin-core-dev
4402018-01-08T20:20:48 *** dqx has quit IRC
4412018-01-08T20:21:18 *** dqx has joined #bitcoin-core-dev
4422018-01-08T20:24:31 *** logicue has joined #bitcoin-core-dev
4432018-01-08T20:25:27 *** dqx has quit IRC
4442018-01-08T20:26:35 *** Murch has quit IRC
4452018-01-08T20:29:35 *** Randolf has quit IRC
4462018-01-08T20:30:14 *** eck has joined #bitcoin-core-dev
4472018-01-08T20:30:29 *** jb55 has joined #bitcoin-core-dev
4482018-01-08T20:36:32 *** dqx has joined #bitcoin-core-dev
4492018-01-08T20:37:23 <BlueMatt> sipa: wait, for bech32 addresses, why do we need to add the p2sh-wrapped segwit thinggy to the wallet?
4502018-01-08T20:38:56 *** promag has joined #bitcoin-core-dev
4512018-01-08T20:39:14 <sipa> BlueMatt: because the IsMine logic added in 0.13.1 (for maximal conservativeness at the time) requires the presence of the redeemscript in the keystore even for native segwit output
4522018-01-08T20:39:39 *** not-a-bot has joined #bitcoin-core-dev
4532018-01-08T20:40:01 <BlueMatt> ah, ok, didnt realize that
4542018-01-08T20:40:08 <BlueMatt> or...recall that
4552018-01-08T20:40:14 <sipa> this was to make sure we don't accidentally treat outputs to uncompressed keys in witness versionas ours
4562018-01-08T20:40:34 <BlueMatt> yea
4572018-01-08T20:41:06 <sipa> i think that was overkill now, but it was not a bad strategy to need something explicit to mark a partocular output as ours
4582018-01-08T20:41:16 <BlueMatt> yea
4592018-01-08T20:42:23 <BlueMatt> oh, while you're here, have you tested adding a bech32 address to the addressbook and then trying to open the wallet with 0.15 qt?
4602018-01-08T20:43:12 <sipa> no, i haven't tried qt
4612018-01-08T20:44:01 <sipa> i've made necessary changes for it to compile, but there may be other changes necessary (especially if we want bech32 error detection in the gui)
4622018-01-08T20:44:44 <BlueMatt> well, ok, have you tested adding a bech32 address to the addressbook and then calling 0.15 getaddressesbyaccount on the same wallet?
4632018-01-08T20:46:18 <sipa> no, i haven't tested anything with the gui
4642018-01-08T20:46:23 <BlueMatt> not gui
4652018-01-08T20:46:26 <BlueMatt> rpc
4662018-01-08T20:48:46 <sipa> ah
4672018-01-08T20:49:15 <BlueMatt> does it blow up? I really have no idea, it just looks like it should blow up or UB or do something strange
4682018-01-08T20:49:16 <sipa> p2sh certainly is tested, as most rpc tests use the default addresstype
4692018-01-08T20:49:26 <sipa> how s?
4702018-01-08T20:49:50 <BlueMatt> what happens when you blindly cast from a variant<CNoDestination> to a CBitcoinAddress?
4712018-01-08T20:50:20 <sipa> cast?
4722018-01-08T20:50:27 <sipa> those are not compatible types
4732018-01-08T20:50:55 <BlueMatt> yes, thats what I thought, but we do a for (pair<CBitcoinAddress, CAddressBookData>& : mapAddressBook)
4742018-01-08T20:51:02 <BlueMatt> which reads to me as "wat"
4752018-01-08T20:51:24 <BlueMatt> and if you put bech32 in the address book, I think 0.15 will end up with a CNoDestination in your mapAddressBook
4762018-01-08T20:52:33 *** mandric_ has joined #bitcoin-core-dev
4772018-01-08T20:52:47 *** Emcy_ has joined #bitcoin-core-dev
4782018-01-08T20:52:50 *** hirish has quit IRC
4792018-01-08T20:53:35 *** mandric has quit IRC
4802018-01-08T20:54:14 *** hirish has joined #bitcoin-core-dev
4812018-01-08T20:54:17 *** Emcy has quit IRC
4822018-01-08T20:54:23 <sipa> BlueMatt: oh, on downgrade!
4832018-01-08T20:54:25 <sipa> ouch
4842018-01-08T20:54:34 <BlueMatt> yes, I think we're like...kinda fucked
4852018-01-08T20:54:45 <BlueMatt> I dunno how to fix that aside from a whole new map for segwit address labels :/
4862018-01-08T20:55:05 <BlueMatt> (which isnt the worst idea, but its a big change)
4872018-01-08T20:55:19 <BlueMatt> should check if my reading is actually correct, I'm still a bit foggy
4882018-01-08T20:55:30 <sipa> well, as soon as you request a bech32 address - which is always an explicit action - you can't downgrade anymore i guess
4892018-01-08T20:55:41 <sipa> maybe that means we neeed an uogradewallet to permit bech32
4902018-01-08T20:56:02 <BlueMatt> yea, but we also cant do an upgradwallet without doing an hd upgrade.....
4912018-01-08T20:56:10 <BlueMatt> or without introducing heaps of stupid hacks
4922018-01-08T20:56:12 <sipa> well it could be like uogradewallet
4932018-01-08T20:56:30 <BlueMatt> yea, i mean could, but it sucks
4942018-01-08T20:56:36 <sipa> similar to how encryption a walletade it incompatible with 0.3
4952018-01-08T20:56:42 <sipa> sorry, walking
4962018-01-08T20:56:46 <sipa> my typing sucks
4972018-01-08T21:02:54 <BlueMatt> also, it does seem weird to let someone have a different label for the bech32, the p2sh-wrapped and the p2ph versions of a pubkey -> address mapping :(
4982018-01-08T21:04:59 <sipa> why?
4992018-01-08T21:05:29 <sipa> that's certainly how it should be in the long term (when IsMine is also not related anymore)
5002018-01-08T21:06:13 <sipa> it's kinda hacky that for some things we need labels on just one of them, and sometimes all
5012018-01-08T21:06:27 <luke-jr> well, it shouldn't be possible to have more than one address style per key really
5022018-01-08T21:07:24 <sipa> right; eventually that will be the case i think
5032018-01-08T21:07:48 <sipa> though right now it's impossible to do that - our IsMine logoc will happily accept anything it can sign for
5042018-01-08T21:08:54 *** Murch has joined #bitcoin-core-dev
5052018-01-08T21:09:51 *** dqx has quit IRC
5062018-01-08T21:11:33 *** mandric_ has quit IRC
5072018-01-08T21:15:45 *** dqx has joined #bitcoin-core-dev
5082018-01-08T21:16:49 *** dqx_ has joined #bitcoin-core-dev
5092018-01-08T21:17:00 *** dqx has quit IRC
5102018-01-08T21:17:23 <BlueMatt> sipa: what luke said, the fact that we have multiple pubkey->addr mappings right now is kinda a hack which will be for backwards compat eventually
5112018-01-08T21:17:46 <BlueMatt> sipa: I mention it because if we did labels only for the P2PH version of an address then we'd sidestep the above issue
5122018-01-08T21:18:29 *** not-a-bot has quit IRC
5132018-01-08T21:18:35 *** zautomata2 has quit IRC
5142018-01-08T21:18:38 <BlueMatt> ofc there's still the issue of people who already have entries for the p2sh wrapped version which mismatch the p2ph version :/
5152018-01-08T21:20:21 *** Tennis has quit IRC
5162018-01-08T21:21:32 *** zautomata2 has joined #bitcoin-core-dev
5172018-01-08T21:22:03 *** opovo has joined #bitcoin-core-dev
5182018-01-08T21:23:19 *** not-a-bot has joined #bitcoin-core-dev
5192018-01-08T21:27:23 *** anome has joined #bitcoin-core-dev
5202018-01-08T21:28:11 *** Tennis has joined #bitcoin-core-dev
5212018-01-08T21:29:46 <Lauda> BlueMatt: What was that with adding bech32 to the address book? I can test that right now in the GUI
5222018-01-08T21:31:16 <BlueMatt> Lauda: give a bech32 address a label, then downgrade
5232018-01-08T21:31:28 <BlueMatt> what is in address book window?
5242018-01-08T21:31:39 <sipa> and does it even start at all
5252018-01-08T21:32:00 <Lauda> You mean create wallet with the PR, add a label to bech and try opening with 0.15.1?
5262018-01-08T21:32:45 <sipa> indeed, use getnewaddress with addresstype=bech32
5272018-01-08T21:32:52 <sipa> and then downgrade to 0.15.1
5282018-01-08T21:33:25 <Lauda> Error loading wallet.dat: Wallet requires newer version of Bitcoin Core.
5292018-01-08T21:33:46 <BlueMatt> ryanofsky: points out if anything it may be most likely to simply have a dummy entry from a default-constructed temporary
5302018-01-08T21:33:47 <sipa> heh, why is that
5312018-01-08T21:34:03 <BlueMatt> have to create with 15.1
5322018-01-08T21:34:14 <BlueMatt> then upgrade, then get addr, then downgrade
5332018-01-08T21:34:20 <Lauda> Oh
5342018-01-08T21:34:21 <sipa> oh, the default key thing?
5352018-01-08T21:34:26 <Lauda> sec, let me try that
5362018-01-08T21:34:35 <sipa> Lauda: thanks!
5372018-01-08T21:36:33 <Lauda> sipa: yw!
5382018-01-08T21:36:58 <Lauda> It does open..
5392018-01-08T21:37:05 <Lauda> label is not working and address is just '3QJmnh'
5402018-01-08T21:37:23 <sipa> ugh.
5412018-01-08T21:37:45 <Lauda> '3QJmnh' *is* the bech32 I generated.. weird cut-off
5422018-01-08T21:37:46 <sipa> what if you have multiple bech32 addresses in the wallet?
5432018-01-08T21:37:49 <BlueMatt> yea, so ryanofsky was right
5442018-01-08T21:37:53 <Lauda> testing brb
5452018-01-08T21:37:57 <sipa> lauda: that's not a bech32 address
5462018-01-08T21:37:57 <BlueMatt> sipa: I'm pretty sure just 1 entry
5472018-01-08T21:38:07 <BlueMatt> cause the map is indexed then by a CNoDestination
5482018-01-08T21:38:08 <sipa> that's p2sh
5492018-01-08T21:38:09 <Lauda> sipa it was bech32, after downgrade all I saw was "3QJmnh"
5502018-01-08T21:38:27 <sipa> oh
5512018-01-08T21:38:34 <Lauda> Let me generate a few of them
5522018-01-08T21:38:40 <Lauda> and I'll screen
5532018-01-08T21:38:51 <sipa> that's probabpy the empty array converted to base58
5542018-01-08T21:39:01 <BlueMatt> sipa: sure its not just the checksum
5552018-01-08T21:39:02 <BlueMatt> ?
5562018-01-08T21:39:08 <BlueMatt> yea
5572018-01-08T21:39:14 <sipa> right
5582018-01-08T21:41:33 <BlueMatt> well, better than crash
5592018-01-08T21:41:48 <BlueMatt> i mean i guess not so bad, but still worth fixing, problem is any fix is ugly
5602018-01-08T21:42:00 <BlueMatt> unless we want to not support more than one address book entry per pubkey
5612018-01-08T21:42:04 <BlueMatt> which I dont mind, but....
5622018-01-08T21:42:18 <Lauda> uhm sipa
5632018-01-08T21:42:22 <Lauda> I made multiple bech
5642018-01-08T21:42:26 <Lauda> after downgrade
5652018-01-08T21:42:28 <Lauda> all are gone
5662018-01-08T21:42:31 <Lauda> o.o
5672018-01-08T21:42:41 <sipa> that's kind of expected
5682018-01-08T21:43:11 <sipa> though i think that if you had incoming payments to those bech32 addresses, you'd still have the balance
5692018-01-08T21:43:20 <Lauda> Alright, so when making one and adding label it is weird. When I make multiple and add labels, they disappear. Anything else I should check?
5702018-01-08T21:43:22 <BlueMatt> it should still have the one 3QJmnh
5712018-01-08T21:43:27 <sipa> but the transaction list and address book woild be cut off
5722018-01-08T21:43:30 <Lauda> BlueMatt: New wallet
5732018-01-08T21:43:33 <sipa> *messed up
5742018-01-08T21:45:52 <BlueMatt> Lauda: no, if you do the same thing again the address should not change
5752018-01-08T21:46:03 <BlueMatt> and if you have multiple, it should still be the same, one, address in the address book in 0.15
5762018-01-08T21:47:29 <Lauda> Sec, reproducing
5772018-01-08T21:47:50 *** opovo has left #bitcoin-core-dev
5782018-01-08T21:47:59 *** Randolf has joined #bitcoin-core-dev
5792018-01-08T21:48:21 <Lauda> New wallet, generated bech again (so diff. address) and it still turned into '3QJmnh'.
5802018-01-08T21:49:03 <BlueMatt> yes, ok
5812018-01-08T21:49:14 <sipa> maybe we should just delete the defaultkey thing whenever a bech32 address is generator
5822018-01-08T21:49:37 <BlueMatt> please no such hacks
5832018-01-08T21:49:50 <sipa> why not?
5842018-01-08T21:50:25 <sipa> it's not very different from the wallet version, except we can't really do that due to the HD thing
5852018-01-08T21:50:36 <Lauda> Back with that wallet to 15.99, (2nd) bech address. Back to 15.1
5862018-01-08T21:50:42 <Lauda> now both have 3QJmnh and no labels
5872018-01-08T21:50:44 <Lauda> uh.
5882018-01-08T21:50:51 <BlueMatt> such a hack, and I'd kinda rather have the 3QJmnh bug than completely blow up backwards compat
5892018-01-08T21:51:23 <sipa> well i guess it depends on how we deal with transactions to bech32 addresses and then downgrade
5902018-01-08T21:52:07 <BlueMatt> I dont (think) the 3QJmnh bug will break on-disk state, only in-memory/display
5912018-01-08T21:52:13 <sipa> agree
5922018-01-08T21:52:36 <BlueMatt> so its not the end of the world, but we should fix it, breaking backwards compat is a huge hammer to fix one small bug, and is really ugly for ux
5932018-01-08T21:52:45 <BlueMatt> I mean we'd have to at least make it explicit
5942018-01-08T21:53:06 <BlueMatt> -upgradewallettobech32segwit
5952018-01-08T21:54:03 <sipa> for 0.16?
5962018-01-08T21:54:07 <sipa> or later?
5972018-01-08T21:55:23 <Lauda> If I import a privkey from a bech32 wallet (0.15.99) created, into the old one
5982018-01-08T21:55:29 <Lauda> it gives me 3 addresses. Is this supposed to happen?
5992018-01-08T21:55:55 <sipa> yes, unfortunately
6002018-01-08T21:56:31 <Lauda> :<
6012018-01-08T21:56:55 *** Randolf has quit IRC
6022018-01-08T21:57:02 <sipa> when importing there is no way to know which of the addresses you want to use
6032018-01-08T21:57:18 <sipa> importmulti doesn't have that problem as you must explicitly state the address or script as well
6042018-01-08T21:57:31 <sipa> (but importmulti doesn't support segwit yet, that needs a follow-up pr)
6052018-01-08T21:58:09 *** not-a-bot has quit IRC
6062018-01-08T21:59:46 <Lauda> I added a bech address that has coins on it without rescan, downgraded and will rescan now
6072018-01-08T22:00:25 <BlueMatt> sipa: for 0.16?
6082018-01-08T22:00:46 *** mandric has joined #bitcoin-core-dev
6092018-01-08T22:02:23 *** belcher has quit IRC
6102018-01-08T22:03:00 <BlueMatt> cfields: so when libevent? #12123
6112018-01-08T22:03:01 <gribble> https://github.com/bitcoin/bitcoin/issues/12123 | [Performance] LevelDB options.max_open_files = 64 parameter (Windows 10) · Issue #12123 · bitcoin/bitcoin · GitHub
6122018-01-08T22:04:06 <sipa> BlueMatt: i'm not following
6132018-01-08T22:04:35 <BlueMatt> sipa: nor am I
6142018-01-08T22:04:41 <sipa> i thought you just said you prefer the 3QJmnh bug
6152018-01-08T22:04:52 <sipa> and don't want to break backward compatibility
6162018-01-08T22:05:20 <BlueMatt> I said I prefer the 3QJmnh to blindly deleting the default key...if we want to break backwards compat, which I dont like at all, then we'd have to require a manual upgrade
6172018-01-08T22:05:33 <BlueMatt> I'd prefer we fix the bug
6182018-01-08T22:05:37 <sipa> oh, i mean deleting the default whenever you decide you want bech32
6192018-01-08T22:05:56 <sipa> whether that's explicit or implicit i don't care much
6202018-01-08T22:06:10 <BlueMatt> it absolutely should not be implicit
6212018-01-08T22:06:20 <BlueMatt> s/should/can/
6222018-01-08T22:06:21 <sipa> ok, if you feel strongly
6232018-01-08T22:06:44 <BlueMatt> since when do we blindly break downgrade implicitly on random actions?
6242018-01-08T22:06:52 <sipa> encrpytion was one
6252018-01-08T22:07:16 <BlueMatt> was that not documented? and thats a much less random action, imo, you can get a bech32 wallet in any one of 5 places...
6262018-01-08T22:07:27 <BlueMatt> also importing a private key...
6272018-01-08T22:07:29 <sipa> sure it needs to be documented
6282018-01-08T22:08:04 <sipa> but i don't think it's unreasonable to say "if you generate a bech32 address, you can't open the wallet anymore in software that doesn't support bech32 addresses"
6292018-01-08T22:08:14 <sipa> yeah, importprivkey is annoying
6302018-01-08T22:08:20 *** belcher has joined #bitcoin-core-dev
6312018-01-08T22:08:22 <BlueMatt> anyway, so options to fix the bug: a) store bech32 address book entries in a different db key space, b) dont allow multiple address book entries per public key
6322018-01-08T22:08:35 <sipa> bah
6332018-01-08T22:08:43 <BlueMatt> if there wer only one place you can "generate a bech32 address" I might agree, but there's many...
6342018-01-08T22:08:54 <BlueMatt> I mean we will eventually implicitly have b
6352018-01-08T22:08:58 <sipa> b is not possible without breaking importprivkey
6362018-01-08T22:09:15 <BlueMatt> well by "allow" I mean look things up by their implied P2PH form
6372018-01-08T22:09:22 <sipa> god no please
6382018-01-08T22:09:28 <sipa> no more hacks
6392018-01-08T22:10:16 <BlueMatt> how is that a hack?
6402018-01-08T22:10:29 <BlueMatt> we jsut switch address book entries to be per-pubkey
6412018-01-08T22:10:36 <BlueMatt> what the map is indexed by, who cares
6422018-01-08T22:10:37 <sipa> bah
6432018-01-08T22:10:50 <BlueMatt> we will get that implicitly eventually anyway...
6442018-01-08T22:10:53 <sipa> no?
6452018-01-08T22:11:03 <sipa> labels are for an address
6462018-01-08T22:11:05 <sipa> not for a key
6472018-01-08T22:11:17 <BlueMatt> yes, but if you only have one address per key, you also only have one label per key
6482018-01-08T22:11:22 <sipa> you can have labels for p2sh multisig too
6492018-01-08T22:11:27 <sipa> there is no good key there
6502018-01-08T22:11:30 <BlueMatt> and, really, I think its super weird that you can do importprivkey on a key, get three address book entries, edit one address book entry and....
6512018-01-08T22:11:32 <bitcoin-git> [bitcoin] laudaa opened pull request #12124: [wallet] Remove segwit status check (master...master) https://github.com/bitcoin/bitcoin/pull/12124
6522018-01-08T22:12:20 <sipa> you can have lavels for addresses you don't have a key for even (watch only)
6532018-01-08T22:12:24 <sipa> or only have a pubkey for
6542018-01-08T22:12:27 <sipa> or p2sh
6552018-01-08T22:12:28 <BlueMatt> yes, I'm aware
6562018-01-08T22:12:42 <BlueMatt> ah, dont have a key for is annoying
6572018-01-08T22:12:42 <sipa> having the label be associated with the key is just the wrong way to do it
6582018-01-08T22:13:11 <BlueMatt> wrong way or not the result is much nicer in practice
6592018-01-08T22:13:28 <BlueMatt> but, indeed, not having a key for it kinda blows that up
6602018-01-08T22:13:36 <sipa> keys are things you spend with
6612018-01-08T22:13:42 <sipa> addresses are things you receive with
6622018-01-08T22:13:53 *** Chris_Stewart_5 has quit IRC
6632018-01-08T22:13:53 <sipa> labels belong to the latter
6642018-01-08T22:14:24 <BlueMatt> I agree, but practice != theory, in any case, it doesnt work in practice either :p
6652018-01-08T22:14:32 <sipa> how do you mean?
6662018-01-08T22:14:53 <sipa> the bug is that 0.15 doesn't support bech32 addresses
6672018-01-08T22:14:54 <BlueMatt> in the case you want to add a label to a dont-have-pubkey bech32 address
6682018-01-08T22:15:05 <sipa> and that we don't have a good way to mark a wallet to support bech32
6692018-01-08T22:15:07 <BlueMatt> err, no it still workrs
6702018-01-08T22:16:35 <sipa> i think we're spending an extraordinary amount of time here on compatibility with older software
6712018-01-08T22:16:45 <sipa> and i wish we had better procedures for dealing with that
6722018-01-08T22:16:54 *** anome has quit IRC
6732018-01-08T22:17:05 <BlueMatt> we do have better procedures, but we blew then up with hd
6742018-01-08T22:17:06 <ryanofsky> haven't followed everything above, but shouldn't it be possible to fix this with a simple change to serialization code in walletdb?
6752018-01-08T22:17:18 <sipa> ryanofsky: how so?
6762018-01-08T22:17:19 <BlueMatt> ryanofsky: that was my (a), above
6772018-01-08T22:17:29 <BlueMatt> <BlueMatt> anyway, so options to fix the bug: a) store bech32 address book entries in a different db key space, b) dont allow multiple address book entries per public key
6782018-01-08T22:17:36 <sipa> meh
6792018-01-08T22:17:46 <ryanofsky> by serializing new addressbook entries with a different bdb key
6802018-01-08T22:17:47 <sipa> you're much better off just making the wallet file incompatibe
6812018-01-08T22:18:11 <ryanofsky> seems simple, and would require no change to regular wallet code
6822018-01-08T22:18:14 <sipa> moving it to a different key space will not actually make things work - you'll still not see the labels in an old version
6832018-01-08T22:18:21 <sipa> that's not desirable
6842018-01-08T22:18:30 *** Arokh has quit IRC
6852018-01-08T22:18:31 <sipa> if it's not going to actually work, it should actually not work
6862018-01-08T22:18:59 <BlueMatt> man I miss the original plan of "fix hd upgrade, require walletupgrade for segwit wallet"
6872018-01-08T22:19:02 <ryanofsky> oh, i didn't think that would be possible at all
6882018-01-08T22:19:39 <sipa> having 3QJmnh show up is IMHO better than silently hiding things :)
6892018-01-08T22:20:31 <ryanofsky> i see. really any of these options seem not that bad to me
6902018-01-08T22:20:39 <sipa> agree
6912018-01-08T22:20:55 <BlueMatt> which options?
6922018-01-08T22:21:43 <ryanofsky> hiding keys, showing mangled keys, different keyspace workaround, collapsed keyspace workaround, or requiring explicit upgrade
6932018-01-08T22:22:41 <sipa> my preference is either doing nothing and giving a nice big release notes warning that you may lose labels when downgrading after creating bech32 addresses
6942018-01-08T22:23:02 <sipa> or making the wallet file backward incompatible whenever the first bech32 address is created
6952018-01-08T22:23:11 <sipa> (explicitly with an action, or not)
6962018-01-08T22:25:04 *** wxss has quit IRC
6972018-01-08T22:25:46 <BlueMatt> labels arent copied anywhere else, right? so there's no other way for it to break your on-disk state?
6982018-01-08T22:26:01 <sipa> i don't think so, no
6992018-01-08T22:26:14 <sipa> after upgrading again everything should be fine
7002018-01-08T22:26:36 <sipa> you can even create a bach32 address, give it out, downgrade, receive a transaction, upgrade... and all will work fine without rescan
7012018-01-08T22:27:31 <BlueMatt> yes, thats my impression
7022018-01-08T22:28:30 <sipa> also, when using importprivkey things will work as expected as long as you don't actually use the bech32 address
7032018-01-08T22:28:51 <BlueMatt> yea, that really sucks, but there's nothing we can do to support any such workflows anyway, the transaction as displayed in 0.15.1 will always be missing the label anyway
7042018-01-08T22:29:12 <sipa> there'll (from old software perspective) just be a weird unrelated addressbook entry added as well
7052018-01-08T22:29:46 *** Cogito_Ergo_Sum has quit IRC
7062018-01-08T22:33:55 *** larafale has quit IRC
7072018-01-08T22:40:38 *** Arokh has joined #bitcoin-core-dev
7082018-01-08T22:41:49 *** Randolf has joined #bitcoin-core-dev
7092018-01-08T22:43:38 *** dqx_ has quit IRC
7102018-01-08T22:44:12 *** dqx has joined #bitcoin-core-dev
7112018-01-08T22:49:04 *** dqx has quit IRC
7122018-01-08T22:49:05 *** Randolf has quit IRC
7132018-01-08T22:49:18 *** Randolf has joined #bitcoin-core-dev
7142018-01-08T22:51:25 *** MrPaz has quit IRC
7152018-01-08T22:54:08 *** dqx has joined #bitcoin-core-dev
7162018-01-08T22:55:30 *** jb55 has quit IRC
7172018-01-08T22:57:33 *** Guyver2 has quit IRC
7182018-01-08T22:58:41 *** dqx has quit IRC
7192018-01-08T23:04:58 *** MrPaz has joined #bitcoin-core-dev
7202018-01-08T23:05:11 *** DrFeelGood has quit IRC
7212018-01-08T23:12:00 <BlueMatt> sipa: heh, AddAndGetDestinationForScript is only called in one place, but a AddAndGetDestinationForKey would be used in a bunch of places
7222018-01-08T23:21:59 *** DrFeelGood has joined #bitcoin-core-dev
7232018-01-08T23:26:23 <sipa> BlueMatt: yes
7242018-01-08T23:27:11 <sipa> is that a problem?
7252018-01-08T23:29:07 <sipa> it's different because AddAndGetScript is harder to split up without doing double work
7262018-01-08T23:30:11 *** zautomata3 has joined #bitcoin-core-dev
7272018-01-08T23:30:29 <BlueMatt> its not a problem, just found it funny
7282018-01-08T23:30:37 <BlueMatt> i guess we dont care about wtf importwallet does?
7292018-01-08T23:31:07 <sipa> todo for a follow up PR
7302018-01-08T23:31:14 <sipa> just like signmessage and importmulti
7312018-01-08T23:31:15 <BlueMatt> I mean I dont think it'll *break* anything, ....ah ok
7322018-01-08T23:31:22 *** zautomata2 has quit IRC
7332018-01-08T23:31:25 *** Emcy_ has quit IRC
7342018-01-08T23:31:34 <sipa> (it's listed as such in the PR description, i think!)
7352018-01-08T23:32:05 <sipa> but i also think it'll just work, apart from maybe birthdates and labels
7362018-01-08T23:32:08 <BlueMatt> heh, text? ewwww why would i read that
7372018-01-08T23:36:14 *** Emcy has joined #bitcoin-core-dev
7382018-01-08T23:36:45 *** zautomata3 has quit IRC
7392018-01-08T23:38:32 *** zautomata3 has joined #bitcoin-core-dev
7402018-01-08T23:42:49 <sipa> i know
7412018-01-08T23:44:50 *** dqx has joined #bitcoin-core-dev
7422018-01-08T23:45:44 *** BashCo_ has quit IRC
7432018-01-08T23:46:24 *** BashCo has joined #bitcoin-core-dev
7442018-01-08T23:47:29 *** Emcy_ has joined #bitcoin-core-dev
7452018-01-08T23:49:05 *** dqx has quit IRC
7462018-01-08T23:49:56 *** Emcy has quit IRC
7472018-01-08T23:54:51 *** mandric has quit IRC
7482018-01-08T23:58:14 *** logicue has quit IRC