1 2018-01-12T00:01:38  <gmaxwell> So you could just as well say that the pr12119 is "use BIP142" ... I wouldn't bother clarifying it, but the fact that there is not a 1:1 relationship between scripts and addresses is pretty important for cases like sipa points out.
  2 2018-01-12T00:02:01  <promag> sipa: do you think fundrawtransaction should have changetype option?
  3 2018-01-12T00:02:09  <gmaxwell> Also things like the payment protocol allow sending funds to a specific script which may not have any address encoding.
  4 2018-01-12T00:02:25  <sipa> promag: i guess it could have, yes
  5 2018-01-12T00:03:19  <gmaxwell> yea, probably should and should work like send to does unless overridden. ... though hopefully people will be moving onto the PSBT workflow sooner rather than later and all the old rawtxn interface can be depricated.
  6 2018-01-12T00:03:26  <promag> folks using just rpc, doing manual signing, can't expect seeing fewer (usable) utxo after upgrading
  7 2018-01-12T00:03:46  *** logicue has joined #bitcoin-core-dev
  8 2018-01-12T00:03:48  <gmaxwell> hm?
  9 2018-01-12T00:04:29  <gmaxwell> promag: I don't understand your last comment.
 10 2018-01-12T00:05:43  <promag> suppose someone creates raw transactions with utxos
 11 2018-01-12T00:06:45  <promag> and only uses utxos with "address", because those are the ones the system knows how to sign
 12 2018-01-12T00:07:00  <sipa> promag: that's not true
 13 2018-01-12T00:07:18  <sipa> bitcoin core was able to sign P2WPKH long before an address type for it existed
 14 2018-01-12T00:07:21  <promag> the system != bitcoind
 15 2018-01-12T00:07:30  <gmaxwell> indeed, and native mulsig too.
 16 2018-01-12T00:07:36  <sipa> and pay to pubkey
 17 2018-01-12T00:07:54  <promag> suppose signing is not done with bitcoind
 18 2018-01-12T00:08:02  <sipa> ok
 19 2018-01-12T00:08:08  <gmaxwell> There should be no need for an address encoding to exist to make a output usable... if there is such a requirement that cropped up, it's a bug.
 20 2018-01-12T00:08:40  <sipa> promag: imagine listunspent just gace the svriptPubKey instead of the address
 21 2018-01-12T00:08:53  <gmaxwell> promag: suppose signing is done by something that doesn't know anything about p2sh-p2wpkh?  it can't sign for that. But so?
 22 2018-01-12T00:08:59  *** Cogito_Ergo_Sum has quit IRC
 23 2018-01-12T00:09:12  <gmaxwell> Some things can't sign for some things, but this is unrelated to addresses.
 24 2018-01-12T00:09:33  <promag> so, if there is some fixed decision of change type, then the utxo set is useless for those folks
 25 2018-01-12T00:09:52  <sipa> promag: but the type of change is determined by that signer
 26 2018-01-12T00:10:02  <sipa> no signer would create a type of change it couldn't sign for itself
 27 2018-01-12T00:10:14  <sipa> just like no wallet would crrate an address it can't sig n for
 28 2018-01-12T00:10:53  <sipa> my typing makes me look like an idiot, it should go sleep
 29 2018-01-12T00:10:53  *** Krellan has quit IRC
 30 2018-01-12T00:11:21  <promag> ok, so if fundrawtansaction is called with a change address, no change will happen right?
 31 2018-01-12T00:11:30  *** Krellan has joined #bitcoin-core-dev
 32 2018-01-12T00:11:53  <promag> lol me too --- ... , no change to change will happen right?
 33 2018-01-12T00:12:33  <sipa> promag: i'm confused now!
 34 2018-01-12T00:12:57  <gmaxwell> if you've called it with a change address, thats what it would use for change.
 35 2018-01-12T00:13:17  <promag> gmaxwell: right, ok
 36 2018-01-12T00:13:21  <promag> another use case:
 37 2018-01-12T00:13:29  *** crazyprodigy has joined #bitcoin-core-dev
 38 2018-01-12T00:13:36  <promag> if a user upgrades to 0.16
 39 2018-01-12T00:14:12  <promag> and wants to run a while *but* knows that will go back to 0.15
 40 2018-01-12T00:14:18  <gmaxwell> Release notes will reflect that if you want to be able to downgrade you'll need to set the type to legacy.
 41 2018-01-12T00:14:27  *** Berry45Hilll has joined #bitcoin-core-dev
 42 2018-01-12T00:14:55  <gmaxwell> thats part of my rational on the auto-native PR to not override a selection of legacy even if all outputs are segwit.
 43 2018-01-12T00:14:56  <promag> meanwhile wants to send to a bech32, but doesn't want to add 0.16 stuff to his wallet, because he will go back to 0.15. makes sense?
 44 2018-01-12T00:15:44  <gmaxwell> right, I specifically arugued that the auto use of native should not apply if the wallet has been specifically set to use legacy outputs for change for mostly that reason.
 45 2018-01-12T00:16:09  <sipa> the upgrade will be kind of hard to avoid
 46 2018-01-12T00:16:11  *** CubicEarths has quit IRC
 47 2018-01-12T00:16:41  <sipa> if you even just send to a bech32, listtransacrions will return bogus addresses after downgrade
 48 2018-01-12T00:16:41  <promag> why?
 49 2018-01-12T00:16:49  *** CubicEarths has joined #bitcoin-core-dev
 50 2018-01-12T00:16:52  <gmaxwell> if you set legacy the only way you'll end up with segwit anything would be either due to manual action or some maniac manually constructing a segwit address for you based on your non-segwit addresses (a suicidal move).
 51 2018-01-12T00:16:55  <sipa> even without evrr creating such an address yourself
 52 2018-01-12T00:17:17  <promag> sipa: but balance will be correct right?
 53 2018-01-12T00:17:20  <sipa> yes
 54 2018-01-12T00:17:21  <gmaxwell> bogus? hm it just won't show the address. no?
 55 2018-01-12T00:17:35  <gmaxwell> We already have this case from the payment protocol which allows sending to arbritary scripts.
 56 2018-01-12T00:17:36  <sipa> gmaxwell: it will show a very weird invalid address, we've discovered
 57 2018-01-12T00:17:47  <promag> even if the change is bech32 address?
 58 2018-01-12T00:17:52  <sipa> 3Qpvllr or sethong like that
 59 2018-01-12T00:18:36  <sipa> actually, perhaps this os not the case in listtransactions
 60 2018-01-12T00:18:47  <gmaxwell> promag: you haven't given enough details, in a downgrade funds send to segwit outputs may not be there, depending on the exact operations.
 61 2018-01-12T00:19:03  <sipa> generally they will be
 62 2018-01-12T00:19:11  <gmaxwell> not if they downgrade and use a backup.
 63 2018-01-12T00:19:16  <gmaxwell> (for example)
 64 2018-01-12T00:19:25  <sipa> i think pretty much only that
 65 2018-01-12T00:19:37  <gmaxwell> sipa: or salvagewallet
 66 2018-01-12T00:19:40  <sipa> downgrading while restoring a backup
 67 2018-01-12T00:19:57  <gmaxwell> or downgrading in the presence of a reorg perhaps?
 68 2018-01-12T00:20:07  <sipa> no, that should woek
 69 2018-01-12T00:20:10  <sipa> *work
 70 2018-01-12T00:20:23  <gmaxwell> e.g. you downgrade and the txn is removed from the wallet in a reorg but not readded when it confirms?
 71 2018-01-12T00:20:35  <sipa> txn are never removed from the wallet
 72 2018-01-12T00:20:44  <sipa> they just become unconfirmed
 73 2018-01-12T00:20:46  <gmaxwell> ah, point it's just set to unconfir,ed
 74 2018-01-12T00:20:55  <sipa> i guess with abandontx they can be removed
 75 2018-01-12T00:21:00  <sipa> in ver specific cases
 76 2018-01-12T00:21:20  <gmaxwell> In any case, I don't think people should downgrade unless they've been running with legacy mode.
 77 2018-01-12T00:21:30  <gmaxwell> though indeed, it'll kinda work.
 78 2018-01-12T00:21:51  <sipa> yes, i think the downgrade after using segwit/bech32 is a best effort thing
 79 2018-01-12T00:21:58  <sipa> it's very unlikely to lose you money
 80 2018-01-12T00:22:05  <sipa> but RPC output may be weird
 81 2018-01-12T00:22:31  * sipa goes into standby
 82 2018-01-12T00:22:39  <promag> ok guys, thanks for your time
 83 2018-01-12T00:23:20  <gmaxwell> I'm generally not super comfortable with suggesting things that will have funds go missing if you do something reasonable but slightly uncommon like recover from a backup.
 84 2018-01-12T00:23:48  <gmaxwell> The "wallet forgot about my outputs" kind of funds loss is pretty creepy.
 85 2018-01-12T00:25:47  <promag> gmaxwell: btw, do you think seeing the checkbox could be considered an "expert" option?
 86 2018-01-12T00:26:26  <gmaxwell> Hm. I dunno. It's not really a thing that a user could usually hurt themself with.
 87 2018-01-12T00:26:36  <promag> do we want people to randomly check/uncheck like "what does this do?"
 88 2018-01-12T00:27:24  <gmaxwell> E.g. say they select it, get a bech32 addres... recieving site rejects it... then they can try again without it. I guess if they're really confused they might not figure out that they need to turn it off since the site will say "invalid address"...
 89 2018-01-12T00:28:16  <promag> didn't thought of that
 90 2018-01-12T00:29:29  <gmaxwell> best would probably be to have very descriptive help text that says "This will use an address that begins with BC1 instead of 1 and will result in lower transaction fees in the future. BC1 style addresses are not accepted everywhere yet. Turn off this option if the sending party says your address is invalid" or similar.
 91 2018-01-12T00:32:04  <gmaxwell> hopefully in a year or two we can bury the option to turn off these addresses behind some advanced thing... but I think early on it will need to be accessible because people will need both.
 92 2018-01-12T00:39:32  *** tknp has quit IRC
 93 2018-01-12T00:39:53  *** wxss has quit IRC
 94 2018-01-12T00:39:58  *** btcdrak has joined #bitcoin-core-dev
 95 2018-01-12T00:43:53  *** instagibbs has quit IRC
 96 2018-01-12T00:50:07  *** Giszmo has quit IRC
 97 2018-01-12T00:53:35  *** AaronvanW has quit IRC
 98 2018-01-12T00:55:57  *** Berry45Hilll has quit IRC
 99 2018-01-12T00:58:33  *** cysm has quit IRC
100 2018-01-12T01:00:10  *** dabura667 has joined #bitcoin-core-dev
101 2018-01-12T01:02:35  *** logicue has quit IRC
102 2018-01-12T01:04:55  *** jb55 has quit IRC
103 2018-01-12T01:08:14  *** Giszmo has joined #bitcoin-core-dev
104 2018-01-12T01:14:12  *** promag has quit IRC
105 2018-01-12T01:15:45  *** justan0theruser has joined #bitcoin-core-dev
106 2018-01-12T01:15:55  *** Allene18Dickinso has joined #bitcoin-core-dev
107 2018-01-12T01:17:09  *** justanotheruser has quit IRC
108 2018-01-12T01:18:02  <ossifrage> Has anyone noticed a large uptick in "non-continuous headers sequence" from peers?
109 2018-01-12T01:26:09  <gmaxwell> ossifrage: idiotic bitcoin gold peers.
110 2018-01-12T01:28:03  <ossifrage> gmaxwell, ah... it takes a while for them to get banned
111 2018-01-12T01:28:36  <gmaxwell> I thought btg changed the network magic?
112 2018-01-12T01:29:20  <gmaxwell> I guess its from people setting that option that lets them sync from bitcoin nodes or something, should probably submit a PR to them to remove that option.
113 2018-01-12T01:29:26  *** cysm has joined #bitcoin-core-dev
114 2018-01-12T01:29:58  <ossifrage> It seems to take about 10 'misbehaving's to get them banned
115 2018-01-12T01:30:20  <ossifrage> but my grep foo may be catching other stuff
116 2018-01-12T01:37:33  *** harrymm has quit IRC
117 2018-01-12T01:43:22  *** aj has quit IRC
118 2018-01-12T01:50:12  *** lightningbot has joined #bitcoin-core-dev
119 2018-01-12T01:50:29  *** harrymm has joined #bitcoin-core-dev
120 2018-01-12T01:53:27  *** logicue has joined #bitcoin-core-dev
121 2018-01-12T02:00:07  *** Victorsueca has quit IRC
122 2018-01-12T02:01:29  *** Victorsueca has joined #bitcoin-core-dev
123 2018-01-12T02:06:50  *** mgeuirx has quit IRC
124 2018-01-12T02:11:35  *** instagibbs has joined #bitcoin-core-dev
125 2018-01-12T02:16:18  *** Tennis has quit IRC
126 2018-01-12T02:27:55  *** Krellan has quit IRC
127 2018-01-12T02:29:00  *** Krellan has joined #bitcoin-core-dev
128 2018-01-12T02:33:49  *** Emcy_ has joined #bitcoin-core-dev
129 2018-01-12T02:35:14  *** Chris_St1 has joined #bitcoin-core-dev
130 2018-01-12T02:35:26  *** Chris_St1 has quit IRC
131 2018-01-12T02:36:17  *** Emcy has quit IRC
132 2018-01-12T02:37:12  *** logicue has quit IRC
133 2018-01-12T02:37:20  *** Chris_Stewart_5 has quit IRC
134 2018-01-12T02:39:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
135 2018-01-12T03:03:43  *** flokie_ has joined #bitcoin-core-dev
136 2018-01-12T03:04:12  *** Krellan has quit IRC
137 2018-01-12T03:05:04  *** flokie_ has quit IRC
138 2018-01-12T03:05:39  *** flokie_ has joined #bitcoin-core-dev
139 2018-01-12T03:06:29  *** flokie has quit IRC
140 2018-01-12T03:06:37  *** flokie_ is now known as flokie
141 2018-01-12T03:10:32  *** Krellan has joined #bitcoin-core-dev
142 2018-01-12T03:11:45  *** Allene18Dickinso has quit IRC
143 2018-01-12T03:15:23  *** Krellan has quit IRC
144 2018-01-12T03:16:33  *** belcher_ has quit IRC
145 2018-01-12T03:19:01  *** Demetrius4Bartol has joined #bitcoin-core-dev
146 2018-01-12T03:23:31  *** hirish is now known as hirishaway
147 2018-01-12T03:33:57  *** Demetrius4Bartol has quit IRC
148 2018-01-12T03:39:08  *** Randolf has joined #bitcoin-core-dev
149 2018-01-12T03:39:33  *** PaulCapestany has quit IRC
150 2018-01-12T03:41:54  *** PaulCapestany has joined #bitcoin-core-dev
151 2018-01-12T03:45:27  *** jtimon has quit IRC
152 2018-01-12T03:45:39  *** Krellan has joined #bitcoin-core-dev
153 2018-01-12T03:47:33  *** Giszmo has quit IRC
154 2018-01-12T03:51:21  *** Chris_Stewart_5 has quit IRC
155 2018-01-12T03:56:14  *** Krellan has quit IRC
156 2018-01-12T04:06:40  <achow101> how come when I enable libevent debugging I don't see any libevent stuff in the debug.log?
157 2018-01-12T04:11:02  *** kanzure has quit IRC
158 2018-01-12T04:16:51  *** CubicEarths has quit IRC
159 2018-01-12T04:20:50  *** Maximo64Kautzer has joined #bitcoin-core-dev
160 2018-01-12T04:46:09  *** [Author] has quit IRC
161 2018-01-12T04:46:57  *** meshcollider has quit IRC
162 2018-01-12T04:50:19  *** dx25 has joined #bitcoin-core-dev
163 2018-01-12T04:50:44  *** [Author] has joined #bitcoin-core-dev
164 2018-01-12T05:00:49  *** CubicEarths has joined #bitcoin-core-dev
165 2018-01-12T05:01:22  *** CubicEarths has quit IRC
166 2018-01-12T05:05:21  *** Victorsueca has quit IRC
167 2018-01-12T05:06:38  *** Victorsueca has joined #bitcoin-core-dev
168 2018-01-12T05:17:49  *** quitobro has joined #bitcoin-core-dev
169 2018-01-12T05:35:33  *** mrannanay has joined #bitcoin-core-dev
170 2018-01-12T05:42:13  *** quitobro has quit IRC
171 2018-01-12T05:43:00  *** CubicEarths has joined #bitcoin-core-dev
172 2018-01-12T05:49:14  *** d4ve has joined #bitcoin-core-dev
173 2018-01-12T05:49:29  <gmaxwell> The reason I bring up PR11739 is that getting the SW lockin along with wallet support would be pretty nice to have... since zomg 20000 block reorg fud continues.
174 2018-01-12T05:49:48  <d4ve> how can I convert this wallet address into something blockcypher api will understand? 04f50cd1051946c76f0dfe51bdda96b05c3007d81b56c6495c6adbf9db0c75a0f07bbde3e496447a80bb6f3813f5f01c513d4f1d55fec182ac518855065a299c31
175 2018-01-12T05:50:42  *** flokie has quit IRC
176 2018-01-12T05:52:19  <d4ve> into WIF format
177 2018-01-12T05:52:40  *** Krellan has joined #bitcoin-core-dev
178 2018-01-12T05:53:37  <Randolf> d4ve:  Does libbase58 do what you need?  https://github.com/bitcoin/libbase58
179 2018-01-12T05:54:05  <d4ve> i hope so
180 2018-01-12T05:54:19  <d4ve> I am using this to extract the pub key from the .pem file :   openssl ec -in priv.pem -pubout -outform DER|tail -c 65|xxd -p -c 65
181 2018-01-12T05:54:35  <d4ve> but I want it in WIF format
182 2018-01-12T05:55:31  <gmaxwell> WIF format is for private keys.
183 2018-01-12T05:59:27  <Randolf> d4ve:  This might be useful for a few one-off conversions, and the JavaScript code therein may be helpful for other implementations like what you need:  https://brainwalletx.github.io/#converter
184 2018-01-12T06:01:11  <Randolf> d4ve:  If you're not asking a question relating to core development, but rather an end-user type of question, then the #bitcoin channel is best-suited to that.
185 2018-01-12T06:01:34  <d4ve> thanks... so I need to convert to base58?
186 2018-01-12T06:02:11  <d4ve> that doesnt produce a valid address either
187 2018-01-12T06:02:12  <Randolf> Base58Check.
188 2018-01-12T06:02:29  <Randolf> a.k.a., B58Check on that conversion page.
189 2018-01-12T06:03:49  *** justanotheruser has joined #bitcoin-core-dev
190 2018-01-12T06:05:05  <d4ve> ok, thanks for the help
191 2018-01-12T06:06:28  *** justan0theruser has quit IRC
192 2018-01-12T06:09:58  <Randolf> d4ve:  You're welcome.
193 2018-01-12T06:10:55  *** propumpkin has joined #bitcoin-core-dev
194 2018-01-12T06:11:35  *** contrapumpkin has quit IRC
195 2018-01-12T06:13:44  *** btcdrak has quit IRC
196 2018-01-12T06:16:49  *** indistylo has joined #bitcoin-core-dev
197 2018-01-12T06:26:10  *** ludens[m] has quit IRC
198 2018-01-12T06:27:10  *** ludens[m] has joined #bitcoin-core-dev
199 2018-01-12T06:31:13  *** aruns has joined #bitcoin-core-dev
200 2018-01-12T06:33:58  <jonasschnelli> BlueMatt: can you shortly comment on https://github.com/bitcoin/bitcoin/pull/11937/files#r159596830?
201 2018-01-12T06:34:13  *** indistylo has quit IRC
202 2018-01-12T06:34:18  *** maaku has quit IRC
203 2018-01-12T06:36:44  *** maaku has joined #bitcoin-core-dev
204 2018-01-12T06:45:19  *** Maximo64Kautzer has quit IRC
205 2018-01-12T06:55:06  *** Krellan has quit IRC
206 2018-01-12T06:55:59  *** aruns has quit IRC
207 2018-01-12T07:01:36  *** Krellan has joined #bitcoin-core-dev
208 2018-01-12T07:03:17  *** jb55 has joined #bitcoin-core-dev
209 2018-01-12T07:04:20  *** indistylo has joined #bitcoin-core-dev
210 2018-01-12T07:11:02  *** wolfspra1l has quit IRC
211 2018-01-12T07:15:24  *** Krellan has quit IRC
212 2018-01-12T07:27:54  *** Lauryn88Kovacek has joined #bitcoin-core-dev
213 2018-01-12T07:28:33  *** intx has quit IRC
214 2018-01-12T07:33:08  *** crazyprodigy has quit IRC
215 2018-01-12T07:33:19  <maaku> <morcos> aren't those a bit premature for PR's?
216 2018-01-12T07:33:35  <maaku> ...no? they're explicitly ready for review and merge. we consider them done.
217 2018-01-12T07:35:17  <maaku> I don't know what Chris_Stewart_5 is talking about. The MAST PR's are not considered immature or work in progress. They are seriously proposed for inclusion in bitcoin core.
218 2018-01-12T07:36:24  <maaku> As to whether there is consensus for such features, I'm not sure how to answer that. There is a great deal of excitement in the community about MAST. There's not any critique for why we shouldn't have MAST, in general, that I'm aware of.
219 2018-01-12T07:36:39  <maaku> If there's some objection someone has they should speak up, and should have spoken up months ago.
220 2018-01-12T07:42:20  *** Krellan has joined #bitcoin-core-dev
221 2018-01-12T07:44:12  *** meshcollider has joined #bitcoin-core-dev
222 2018-01-12T07:44:17  *** Victorsueca has quit IRC
223 2018-01-12T07:45:38  *** Victorsueca has joined #bitcoin-core-dev
224 2018-01-12T07:46:21  <bitcoin-git> [bitcoin] maaku opened pull request #12167: Make segwit failure due to CLEANSTACK violation return a SCRIPT_ERR_CLEANSTACK error code (master...cleanstack-script-error) https://github.com/bitcoin/bitcoin/pull/12167
225 2018-01-12T07:47:17  *** Krellan has quit IRC
226 2018-01-12T07:54:52  *** Krellan has joined #bitcoin-core-dev
227 2018-01-12T07:56:28  <gmaxwell> maaku: should have spoken up months ago?
228 2018-01-12T07:56:45  *** indistylo has quit IRC
229 2018-01-12T07:56:50  <gmaxwell> maaku: That is a seriously inappropriate tone.
230 2018-01-12T07:58:01  <maaku> gmaxwell: It's also impolite to hold off on speaking up for why a feature shouldn't be adopted while development goes on for that feature for months.
231 2018-01-12T07:58:47  <maaku> Particularly when regular updates are provided in person and online during that time, and nobody speaks up for reasons against adoption of the feature.
232 2018-01-12T07:59:05  <maaku> 11th hour objections seriously waste people's time.
233 2018-01-12T08:00:00  <gmaxwell> maaku: 11th hour? regarding a BIP that hit the list less than two months ago?
234 2018-01-12T08:00:10  *** indistylo has joined #bitcoin-core-dev
235 2018-01-12T08:00:29  <maaku> gmaxwell: I think perhaps you are reading different into my statement
236 2018-01-12T08:01:04  *** TheRec has quit IRC
237 2018-01-12T08:01:10  <maaku> If someone had an objection to the concept of MAST or this general approach, September of 2017 would have been a good time to air it.
238 2018-01-12T08:01:35  <gmaxwell> Actually people did raise objections to you multiple times, you have agressively steamrolled their positions!
239 2018-01-12T08:02:04  <maaku> To the concept of MAST in general?
240 2018-01-12T08:02:17  <maaku> Again I think you are reading something I didn't say
241 2018-01-12T08:02:50  <gmaxwell> Okay.
242 2018-01-12T08:04:00  <gmaxwell> please avoid language that will shut down open discussion.
243 2018-01-12T08:04:03  *** timothy has joined #bitcoin-core-dev
244 2018-01-12T08:04:03  <sipa> I don't think I've heard concerns about the general concept of MAST.
245 2018-01-12T08:04:15  <gmaxwell> There is no point, even _post_ deployment when it's too late to raise concerns.
246 2018-01-12T08:04:39  <maaku> I agree. I didn't say otherwise.
247 2018-01-12T08:05:06  <gmaxwell> okay, my apologies then-- that was how the above comments came across to me, thus the comment about tone.
248 2018-01-12T08:05:23  <maaku> But if someone has an objection, they should not wait on it.
249 2018-01-12T08:06:13  <sipa> I do think there have been several concerns voiced about how it makes static analysis harder/impossible, and more specifocly later that sigop and ops limits are removed from the subscript.
250 2018-01-12T08:06:33  <maaku> Morcos asked if there is even consensus over whether this feature is wanted. I know of no one who has ever said we should not have MAST in some form. If there is such an objection, I would like to hear it.
251 2018-01-12T08:07:02  <gmaxwell> ah! the context you pasted was just about PRs.
252 2018-01-12T08:07:42  <sipa> i missed that too
253 2018-01-12T08:08:08  <gmaxwell> (and then you said ready for merge, should have raised objections... so hopefully you can see why I was not reading that about the general construction.)
254 2018-01-12T08:08:23  *** Chenpan has joined #bitcoin-core-dev
255 2018-01-12T08:08:27  *** jb55 has quit IRC
256 2018-01-12T08:08:32  *** Krellan has quit IRC
257 2018-01-12T08:08:39  *** Chenpan has quit IRC
258 2018-01-12T08:16:28  *** jrayhawk has quit IRC
259 2018-01-12T08:16:41  <maaku> gmaxwell: what you call "aggressive steamrolling" I call data-driven development
260 2018-01-12T08:19:07  *** Krellan has joined #bitcoin-core-dev
261 2018-01-12T08:19:11  *** Chenpan has joined #bitcoin-core-dev
262 2018-01-12T08:21:43  *** CubicEarths has quit IRC
263 2018-01-12T08:22:20  *** CubicEarths has joined #bitcoin-core-dev
264 2018-01-12T08:23:27  *** go1111111 has quit IRC
265 2018-01-12T08:24:41  <echeveria> maaku: I literally never knew there was anything more than the idea of MAST.
266 2018-01-12T08:25:18  <echeveria> that being a PR is pretty surprising to me, I had no idea it was anything beyond wishful thinking.
267 2018-01-12T08:25:57  *** go1111111 has joined #bitcoin-core-dev
268 2018-01-12T08:26:25  <gmaxwell> well, thats a utility of the PR then...
269 2018-01-12T08:29:21  *** indistylo has quit IRC
270 2018-01-12T08:30:11  <luke-jr> I do recall the sigop issue being mentioned when I tried to add MAST to witnessv1 stuff
271 2018-01-12T08:31:26  *** anome has joined #bitcoin-core-dev
272 2018-01-12T08:42:47  *** Chenpan has joined #bitcoin-core-dev
273 2018-01-12T08:43:33  *** ybit has quit IRC
274 2018-01-12T08:46:09  <maaku> luke-jr: the sigop / static analysis issue with respect to this proposal came up on the mailing list in September of last year
275 2018-01-12T08:46:10  <maaku> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-September/014992.html
276 2018-01-12T08:46:54  <maaku> quoting the email : "4MB of secp256k1 signatures takes 10s to validate on my 5 year old laptop (125,000 signatures, ignoring public keys and other things that would consume space). That's much less than bad blocks that can be constructed using other vulnerabilities."
277 2018-01-12T08:47:52  <maaku> There may be a small constant factor on that, but the point is that you can do more damage in terms of a bad block by other means than stuffing sigops.
278 2018-01-12T08:48:02  *** anome has quit IRC
279 2018-01-12T08:49:51  <gmaxwell> 10s to validate is not generally acceptable.
280 2018-01-12T08:50:10  <maaku> 10s to validate can be done with 1MB of quadratic hashing
281 2018-01-12T08:51:18  <gmaxwell> only with strange prep, 2 seconds otherwise; and there is a pretty big difference between attacks that require miner cooperation with non-standard transactions and stuff that can be done with ordinary transactions.
282 2018-01-12T08:53:09  *** jrayhawk has joined #bitcoin-core-dev
283 2018-01-12T08:58:26  <maaku> gmaxwell: we shouldn't talk specifics online, but I can make a block with no prep that takes 20s to validate using hashing tricks
284 2018-01-12T08:59:06  <maaku> using standard transactions
285 2018-01-12T08:59:23  <maaku> that's why I'm confused about the objection to something which, on the same system, maxes out at 10s validation times
286 2018-01-12T08:59:44  <gmaxwell> As I've told you before, if thats the case we should fix it.
287 2018-01-12T09:01:07  <maaku> How? By introducing additional limits? That's not an obvious win to me.
288 2018-01-12T09:01:33  <maaku> Particularly when the foregone transaction fees provide an economic protection against these attacks.
289 2018-01-12T09:13:17  *** AaronvanW has joined #bitcoin-core-dev
290 2018-01-12T09:14:52  *** Aaronvan_ has joined #bitcoin-core-dev
291 2018-01-12T09:18:21  *** AaronvanW has quit IRC
292 2018-01-12T09:19:52  *** CubicEar_ has joined #bitcoin-core-dev
293 2018-01-12T09:20:02  *** anome has joined #bitcoin-core-dev
294 2018-01-12T09:20:40  *** anome has quit IRC
295 2018-01-12T09:20:41  *** rabidus has quit IRC
296 2018-01-12T09:20:49  *** rabidus has joined #bitcoin-core-dev
297 2018-01-12T09:21:00  *** Lauryn88Kovacek has quit IRC
298 2018-01-12T09:21:57  *** anome has joined #bitcoin-core-dev
299 2018-01-12T09:22:07  *** zshlyk has quit IRC
300 2018-01-12T09:23:11  *** CubicEarths has quit IRC
301 2018-01-12T09:25:16  *** kabaum has quit IRC
302 2018-01-12T09:32:25  *** Maximilian35Terr has joined #bitcoin-core-dev
303 2018-01-12T09:34:08  *** logicue has joined #bitcoin-core-dev
304 2018-01-12T09:37:30  *** Maximilian35Terr has quit IRC
305 2018-01-12T09:39:27  *** tripleslash has quit IRC
306 2018-01-12T09:47:22  *** CubicEar_ has quit IRC
307 2018-01-12T09:47:59  *** CubicEarths has joined #bitcoin-core-dev
308 2018-01-12T09:49:18  *** anome has quit IRC
309 2018-01-12T09:57:57  *** promag has joined #bitcoin-core-dev
310 2018-01-12T09:58:43  *** Aaronvan_ has quit IRC
311 2018-01-12T10:01:24  *** AaronvanW has joined #bitcoin-core-dev
312 2018-01-12T10:09:16  *** Chen_Pan has joined #bitcoin-core-dev
313 2018-01-12T10:10:48  *** indistylo has joined #bitcoin-core-dev
314 2018-01-12T10:11:03  *** Chen_Pan has quit IRC
315 2018-01-12T10:11:38  *** Chen_Pan has joined #bitcoin-core-dev
316 2018-01-12T10:12:15  *** Chenpan has quit IRC
317 2018-01-12T10:16:10  *** arbitrary_guy has quit IRC
318 2018-01-12T10:18:55  *** anome has joined #bitcoin-core-dev
319 2018-01-12T10:20:47  *** zshlyk has joined #bitcoin-core-dev
320 2018-01-12T10:21:25  *** AaronvanW has quit IRC
321 2018-01-12T10:22:04  *** AaronvanW has joined #bitcoin-core-dev
322 2018-01-12T10:23:52  *** promag has quit IRC
323 2018-01-12T10:26:20  *** AaronvanW has quit IRC
324 2018-01-12T10:27:00  *** tripleslash has joined #bitcoin-core-dev
325 2018-01-12T10:31:23  *** kanzure has joined #bitcoin-core-dev
326 2018-01-12T10:32:12  *** CubicEarths has quit IRC
327 2018-01-12T10:33:37  *** meshcollider has quit IRC
328 2018-01-12T10:35:08  *** AaronvanW has joined #bitcoin-core-dev
329 2018-01-12T10:35:20  *** Giovanni31Medhur has joined #bitcoin-core-dev
330 2018-01-12T10:40:24  *** promag has joined #bitcoin-core-dev
331 2018-01-12T10:52:35  *** Giovanni31Medhur has quit IRC
332 2018-01-12T10:53:37  *** indistylo has quit IRC
333 2018-01-12T10:58:19  *** larafale has joined #bitcoin-core-dev
334 2018-01-12T10:59:11  *** mrannanay has quit IRC
335 2018-01-12T11:02:20  *** CubicEarths has joined #bitcoin-core-dev
336 2018-01-12T11:07:22  *** dabura667 has quit IRC
337 2018-01-12T11:09:51  *** indistylo has joined #bitcoin-core-dev
338 2018-01-12T11:11:48  *** jtimon has joined #bitcoin-core-dev
339 2018-01-12T11:18:14  *** hirishaway is now known as hirish
340 2018-01-12T11:19:15  *** AaronvanW has quit IRC
341 2018-01-12T11:22:50  <bitcoin-git> [bitcoin] jsarenik opened pull request #12168: Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (master...jasan/fcntl.h) https://github.com/bitcoin/bitcoin/pull/12168
342 2018-01-12T11:24:10  <bitcoin-git> [bitcoin] kekimusmaximus opened pull request #12169: Avoid temporary copies in C++11 ranged-based for loops. (master...remove_loop_implicit_casts) https://github.com/bitcoin/bitcoin/pull/12169
343 2018-01-12T11:24:31  *** CubicEar_ has joined #bitcoin-core-dev
344 2018-01-12T11:27:18  *** meshcollider has joined #bitcoin-core-dev
345 2018-01-12T11:27:37  *** CubicEarths has quit IRC
346 2018-01-12T11:31:01  *** indistylo has quit IRC
347 2018-01-12T11:32:56  *** belcher_ has joined #bitcoin-core-dev
348 2018-01-12T11:38:18  *** goatpig has joined #bitcoin-core-dev
349 2018-01-12T11:39:05  *** Aisha42Johnson has joined #bitcoin-core-dev
350 2018-01-12T11:42:32  <morcos> maaku: It is possible I have been out of the loop.  As you may know a lot has been happening in the last several months.
351 2018-01-12T11:42:44  <morcos> I though there were several MAST proposals in the works
352 2018-01-12T11:43:14  <morcos> I thought based on the amount of traffic that they weren't currently getting anywhere near the developer or community mindshare to be getting near adoption
353 2018-01-12T11:43:38  <morcos> I'd seen know discussion on whetther there was any consensus to the protocol changes or not
354 2018-01-12T11:44:15  <morcos> To be honest, I don't know if I have any concerns or objections becuase I haven't looked at it yet.  I'm in favor of the general concept, but I'm not convinced it should be a priority right now
355 2018-01-12T11:45:05  *** shesek has quit IRC
356 2018-01-12T11:45:16  <morcos> It would be one thing if it wasn't a consensus change, but it is, so I think before discussing PR's being ready for Core, it makes sense to discuss whether the community wants this.
357 2018-01-12T11:46:10  <morcos> That said, having Code is always helpful, and its good for me and others to get the feedback that this is further along than I thought if thats the case
358 2018-01-12T12:04:02  *** indistylo has joined #bitcoin-core-dev
359 2018-01-12T12:09:41  *** logicue has quit IRC
360 2018-01-12T12:12:19  *** AaronvanW has joined #bitcoin-core-dev
361 2018-01-12T12:14:39  *** Aisha42Johnson has quit IRC
362 2018-01-12T12:21:09  <provoostenator> sipa: I'm a bit confused as to how to interpret scenario 1 in your gist. At least in the test I wrote, if you restore from a backup then any addresses that were generated after that backup would only reappear if you remember the correct sequence of legacy/p2sh-segwit/bech32 choices: https://github.com/bitcoin/bitcoin/pull/12152
363 2018-01-12T12:21:33  <provoostenator> And funds don't show up for me unless I get that sequence right.
364 2018-01-12T12:21:53  *** arubi_ has joined #bitcoin-core-dev
365 2018-01-12T12:21:54  <sipa> provoostenator: that's a bug!
366 2018-01-12T12:21:57  <gmaxwell> ?!? what do you mean choices?!
367 2018-01-12T12:22:09  <provoostenator> sipa: ok, either that or my test is wrong.
368 2018-01-12T12:22:14  <gmaxwell> they should all appear with you doing nothing but starting the software and waiting for the rescan to complete.
369 2018-01-12T12:22:20  <sipa> yup
370 2018-01-12T12:22:28  <sipa> amd it is totally plausible that it is broken
371 2018-01-12T12:22:30  <sipa> *and
372 2018-01-12T12:22:45  <sipa> in which case i'd very much like to know
373 2018-01-12T12:22:48  <provoostenator> Right, but that's what the "look for related keys" logic is for, right?
374 2018-01-12T12:23:15  <gmaxwell> I did test this at one point.
375 2018-01-12T12:23:38  <gmaxwell> though only with native segwit outputs.
376 2018-01-12T12:23:49  <provoostenator> Maybe it's because my tests use accounts, I don't know how that changes things.
377 2018-01-12T12:24:31  *** arubi has quit IRC
378 2018-01-12T12:27:27  <sipa> provoostenator: the account obviously won't be credited - it can't predict which label you'll give future addresses
379 2018-01-12T12:27:39  <sipa> but the wallet balance should get uodated
380 2018-01-12T12:30:46  <provoostenator> I didn't check the total wallet balance, so that might be it then. So after restoring from a backup a user would see random new addresses have funds?
381 2018-01-12T12:31:32  <sipa> yes
382 2018-01-12T12:31:38  <provoostenator> I suppose the only way to prevent that is to disallow address creation before rescan / sync is done.
383 2018-01-12T12:31:49  <sipa> ?
384 2018-01-12T12:32:33  <provoostenator> The wallet would check to see if a key already has funds and then skip it in the new address UI.
385 2018-01-12T12:32:58  <sipa> i'm very confused :)
386 2018-01-12T12:33:31  *** laurentmt has joined #bitcoin-core-dev
387 2018-01-12T12:33:32  <provoostenator> Right now if you click on new address it will just pick the next key, even the corresponding address has coins on it.
388 2018-01-12T12:33:40  <sipa> no
389 2018-01-12T12:33:42  <sipa> oh... if an address is seen used on the network it is removed from the keypool
390 2018-01-12T12:33:43  <provoostenator> Which is weird for the user, because they thought they created a fresh address.
391 2018-01-12T12:33:56  <sipa> so it won't be given out agaon
392 2018-01-12T12:34:11  <provoostenator> "is seen used" is the operating word then, because in my test it doesn't see it in time.
393 2018-01-12T12:34:24  <sipa> okay
394 2018-01-12T12:34:29  <sipa> well there may be a bug!
395 2018-01-12T12:34:46  <sipa> or maybe you didn't wait for rescan etc
396 2018-01-12T12:34:57  <provoostenator> I did the rescan after generating the address, yes.
397 2018-01-12T12:34:58  <sipa> s/rescan/sync/
398 2018-01-12T12:35:09  <provoostenator> So you're saying if I do a rescan before generating an new address this won't happen?
399 2018-01-12T12:35:13  <sipa> there shouldn't be a need for rescan
400 2018-01-12T12:36:25  *** shesek has joined #bitcoin-core-dev
401 2018-01-12T12:36:25  *** shesek has joined #bitcoin-core-dev
402 2018-01-12T12:37:01  <provoostenator> What happens when you load an outdated wallet backup where new addresses have been added and funded by the user? Does it rescan it?
403 2018-01-12T12:37:47  <sipa> at startup, if your wallet is older than the chain, the missing part is automatically rescanned
404 2018-01-12T12:38:32  <provoostenator> In. my test (line 206) I had to do a rescan in order for the balances to show up on generated addresses.
405 2018-01-12T12:39:02  <provoostenator> Maybe that's because regtest behaves different in this regard and doens't do rescans automatically.
406 2018-01-12T12:40:05  <provoostenator> The test stops the node, replaces the wallet with an older version, starts the node, generates the same addresses and then calls rescan. That's when the balance shows up for these addresses.
407 2018-01-12T12:40:24  <provoostenator> Without rescan the address balances remain zero, though I didn't check the wallet balance.
408 2018-01-12T12:40:41  <provoostenator> I'll try some variations once I understand the intented behavior better.
409 2018-01-12T12:40:50  *** blueneon has joined #bitcoin-core-dev
410 2018-01-12T12:40:54  <sipa> don't look at address balance
411 2018-01-12T12:40:58  <sipa> look at wallet balance
412 2018-01-12T12:41:06  <sipa> listtransactions maybreport garbage
413 2018-01-12T12:41:13  <sipa> listunspent should probably work
414 2018-01-12T12:41:24  <provoostenator> I'm using getbalance("account name")
415 2018-01-12T12:41:33  <sipa> ... how could that possibly work?
416 2018-01-12T12:41:52  <sipa> the backup doesn't know what name you're going to give a future address
417 2018-01-12T12:41:53  <provoostenator> Which I'm assuming is what QT relies on to show the balance in the receive tab, so it could be pretty confusing (but haven't tested)
418 2018-01-12T12:41:59  <sipa> no
419 2018-01-12T12:42:07  <sipa> that's even a deprecated RPC
420 2018-01-12T12:42:21  <sipa> the GUI doesn't support accounts, and never has
421 2018-01-12T12:42:41  <blueneon> Hi there, I've made a fork/clone of the bitcoin coin in order for me to play around and get familiar. All went well after updating chainparams.cpp etc and I created new genesis and merkle etc -the code compiles and runs. However it crashes and debug.log says: ERROR: ReadBlockFromDisk: Errors in block header at CBlockDiskPos(nFile=0, nPos=8)
422 2018-01-12T12:42:49  <provoostenator> Ah, that points to my confusion between accouts and labels then..
423 2018-01-12T12:42:49  <blueneon> Any advise would be much appreciated.
424 2018-01-12T12:43:03  <sipa> blueneon: ##altcoin-dev
425 2018-01-12T12:43:16  <blueneon> Ok thanks
426 2018-01-12T12:43:34  <sipa> provoostenator: the only thing you should be looking at is getbalance (without argument), listtransactions, listunspent
427 2018-01-12T12:44:08  <provoostenator> How is the label that I use in QT when I create a payment reqest represented in the RPC?
428 2018-01-12T12:44:14  <blueneon> seems ##altcoin-dev is a dead chan :/
429 2018-01-12T12:44:59  <blueneon> Any chance someone here can shed light on my issue?
430 2018-01-12T12:45:08  <sipa> blueneon: not here, sorry
431 2018-01-12T12:45:49  <provoostenator> blueneon: that's not a good way to get familiar with the code in my experience. I somewhat selfishly suggest looking at random bitcoin core github issues and trying to help out in little bits.
432 2018-01-12T12:45:50  <sipa> provoostenator: labels amd accounts are the same up to that functionality... it's a name associated with an address
433 2018-01-12T12:46:01  <sipa> provoostenator: but labels don't have a balance
434 2018-01-12T12:46:16  <sipa> listreceivedbyaddress would also work
435 2018-01-12T12:46:36  <provoostenator> Ah, so a key has multiple addresses, each address can have a label. Not in the other direction?
436 2018-01-12T12:46:37  <sipa> but inherently, when recovering fromna backup, the labels won't be there - they can't be
437 2018-01-12T12:46:54  <gmaxwell> one of the many limitations of labels.
438 2018-01-12T12:47:05  <sipa> provoostenator: addresses have a label; multiple addresses can have the same label
439 2018-01-12T12:47:25  <provoostenator> I know the labels wouldn't come back. But when the user creates a payment request that address shouldn't already have money on it. But it seems I didn't actually test that, becaus eI was using accounts.
440 2018-01-12T12:48:14  <provoostenator> Multiple address (from different keys?) can have identical label strings or do you mean they point to the same label object?
441 2018-01-12T12:48:22  *** Toni67Stoltenber has joined #bitcoin-core-dev
442 2018-01-12T12:48:26  <sipa> provoostenator: what's the difference?
443 2018-01-12T12:48:49  <provoostenator> The difference is what happens to the label of addres A if I change the label of address B.
444 2018-01-12T12:48:58  <provoostenator> If they were identical before.
445 2018-01-12T12:48:59  <sipa> oh, i see
446 2018-01-12T12:49:02  <sipa> nothing changes to A
447 2018-01-12T12:49:12  <provoostenator> In other words, what's the SQL schema :-)
448 2018-01-12T12:49:23  <sipa> addresses have a string lab
449 2018-01-12T12:49:25  <sipa> el
450 2018-01-12T12:49:48  <gmaxwell> same label can be on many addresses (and often is)
451 2018-01-12T12:49:50  *** contrapumpkin has joined #bitcoin-core-dev
452 2018-01-12T12:49:53  <sipa> pro when the user requests a payment it should never give out an address associated with a key that has already been used
453 2018-01-12T12:50:02  <sipa> *provoostenator
454 2018-01-12T12:51:00  *** propumpkin has quit IRC
455 2018-01-12T12:51:33  <provoostenator> Alright, I'll take another look with that background.
456 2018-01-12T12:51:57  <provoostenator> How are we doing on actually deprecating accounts?
457 2018-01-12T12:52:13  <sipa> basically rename the string account label everywhere in the source code
458 2018-01-12T12:52:21  <sipa> and then removing getbalance(account)
459 2018-01-12T12:52:30  <sipa> and removing the ability to specify a "from" account
460 2018-01-12T12:52:35  <sipa> when creating a tx
461 2018-01-12T12:52:58  *** promag has quit IRC
462 2018-01-12T12:53:12  *** CubicEar_ has quit IRC
463 2018-01-12T13:00:32  *** mrannanay has joined #bitcoin-core-dev
464 2018-01-12T13:02:09  *** Toni67Stoltenber has quit IRC
465 2018-01-12T13:02:26  <sipa> provoostenator: actually, i am pretty interested in knowing what listtransactions shows after recovery
466 2018-01-12T13:03:49  <provoostenator> sipa: I can take a look later (you should be able to run the backwards compatibilty tests locally in the meantime).
467 2018-01-12T13:05:00  *** punch has joined #bitcoin-core-dev
468 2018-01-12T13:11:02  *** michagogo has quit IRC
469 2018-01-12T13:13:39  *** michagogo has joined #bitcoin-core-dev
470 2018-01-12T13:18:50  <provoostenator> sipa: wallet balance immedidately after backup restore: 3 (missing funds and transactions from the post-backup keys)
471 2018-01-12T13:21:55  <provoostenator> If I add a rescan to the test, 2 coins and their transactions reappear (not associated with an account).
472 2018-01-12T13:22:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
473 2018-01-12T13:24:04  *** CubicEarths has joined #bitcoin-core-dev
474 2018-01-12T13:24:32  <provoostenator> There's a third coin that won't appear until you've called getnewaddress 3 times.
475 2018-01-12T13:25:52  <sipa> provoostenator: after a confirmation?
476 2018-01-12T13:26:25  <provoostenator> Yes, these were all confirmed and synced before deleting the wallet and replacing it with a backup.
477 2018-01-12T13:26:39  <provoostenator> But I'm a bit confused myself now as to what's so special about htat 3rd ps2sh-segwit address.
478 2018-01-12T13:27:40  <provoostenator> It appears that a rescan revealed the wallet balance for 2 out of 3 keys (p2sh-segwit, bech32, p2sh-segwit), but it took 3 calls to getnewaddress to reveal the third one. Either a bug or more likely something really weird about my test.
479 2018-01-12T13:28:21  <provoostenator> Or maybe these transactions are chained in a way that matters.
480 2018-01-12T13:28:27  *** instagibbs has quit IRC
481 2018-01-12T13:28:38  *** CubicEarths has quit IRC
482 2018-01-12T13:28:39  <provoostenator> I have a node0 which mines the blocks and sprinkles coins to the test nodes.
483 2018-01-12T13:30:09  *** CubicEarths has joined #bitcoin-core-dev
484 2018-01-12T13:31:08  <provoostenator> https://gist.github.com/Sjors/b6ad5ee7a12973ad93edd81e2beff876
485 2018-01-12T13:31:32  <provoostenator> That's the output of listtransactions at the end. The bottom transaction didn't immedidatley show up.
486 2018-01-12T13:34:27  *** CubicEarths has quit IRC
487 2018-01-12T13:34:53  <provoostenator> Here's the 5 transactions (from a different test run) where I called rescan immedidatley after recovery: https://gist.github.com/Sjors/df8a35ae3481f83546d2ec7518e0ce28  (note that the last two account names aren't know, obviously)
488 2018-01-12T13:35:45  <provoostenator> I should probably run these with deterministic random seed for easier comparison.
489 2018-01-12T13:37:47  <sdaftuar> gmaxwell: re #11739 -- thoughts on next steps there?  i was thinking i need to document the change somehow, perhaps an update to the relevant bips and an email to the -dev list?
490 2018-01-12T13:37:48  <gribble> https://github.com/bitcoin/bitcoin/issues/11739 | RFC: Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis by sdaftuar · Pull Request #11739 · bitcoin/bitcoin · GitHub
491 2018-01-12T13:39:48  <gmaxwell> sdaftuar: sounds good to me.
492 2018-01-12T13:42:37  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
493 2018-01-12T13:43:24  <provoostenator> I should add that these 3 transactions, of which 1 only appears later, are in the same block.
494 2018-01-12T13:45:39  *** AaronvanW has quit IRC
495 2018-01-12T13:45:53  *** Lourdes55Wilkins has joined #bitcoin-core-dev
496 2018-01-12T13:50:34  *** AaronvanW has joined #bitcoin-core-dev
497 2018-01-12T13:53:20  *** blueneon has quit IRC
498 2018-01-12T13:57:33  <sipa> provoostenator: cool, i'll loook into it
499 2018-01-12T14:00:22  *** AaronvanW has quit IRC
500 2018-01-12T14:02:44  *** Chris_Stewart_5 has quit IRC
501 2018-01-12T14:11:06  *** AaronvanW has joined #bitcoin-core-dev
502 2018-01-12T14:12:55  *** instagibbs has joined #bitcoin-core-dev
503 2018-01-12T14:13:35  *** indistylo has quit IRC
504 2018-01-12T14:16:05  *** davec has quit IRC
505 2018-01-12T14:18:05  *** davec has joined #bitcoin-core-dev
506 2018-01-12T14:23:38  *** meshcollider has quit IRC
507 2018-01-12T14:25:58  *** Lourdes55Wilkins has quit IRC
508 2018-01-12T14:32:19  *** Guyver2 has joined #bitcoin-core-dev
509 2018-01-12T14:50:12  *** Jacquelyn14Koss has joined #bitcoin-core-dev
510 2018-01-12T14:50:42  *** AaronvanW has quit IRC
511 2018-01-12T14:51:59  *** alfa has joined #bitcoin-core-dev
512 2018-01-12T14:59:21  *** AaronvanW has joined #bitcoin-core-dev
513 2018-01-12T15:00:27  *** Jacquelyn14Koss has quit IRC
514 2018-01-12T15:02:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
515 2018-01-12T15:02:38  *** Emcy has joined #bitcoin-core-dev
516 2018-01-12T15:03:50  *** Victorsueca has quit IRC
517 2018-01-12T15:05:09  *** Victorsueca has joined #bitcoin-core-dev
518 2018-01-12T15:05:26  *** Emcy_ has quit IRC
519 2018-01-12T15:19:36  *** Sprh has joined #bitcoin-core-dev
520 2018-01-12T15:21:11  *** keks has joined #bitcoin-core-dev
521 2018-01-12T15:22:00  *** Sprh has quit IRC
522 2018-01-12T15:26:18  <larafale> hello guys, any brave soul to help me on this. I'm learning and testing address decoding. I've got a public key (from an electrum wallet) and I'm trying to ripemd160(sha256(pubkey)), but the result I get is not the result I'm expecting. I thought the result was going to be the pubkeyhash present in the scriptpubkey in one of the output where that address was used. Am I missing something ?
523 2018-01-12T15:27:54  <sipa> larafale: https://bitcoin.stackexchange.com
524 2018-01-12T15:32:35  *** maaku has left #bitcoin-core-dev
525 2018-01-12T15:38:01  *** shesek has quit IRC
526 2018-01-12T15:54:04  *** Gabrielle5Maggio has joined #bitcoin-core-dev
527 2018-01-12T15:54:09  *** Giszmo has joined #bitcoin-core-dev
528 2018-01-12T15:55:07  <Randolf> larafale:  This may also be helpful to you:  https://github.com/bitcoin/libbase58
529 2018-01-12T16:07:52  *** Eetsi123 has joined #bitcoin-core-dev
530 2018-01-12T16:12:31  *** Eetsi123 has quit IRC
531 2018-01-12T16:15:23  *** Eetsi123 has joined #bitcoin-core-dev
532 2018-01-12T16:16:33  *** crazyprodigy has joined #bitcoin-core-dev
533 2018-01-12T16:19:28  *** ghost43 has quit IRC
534 2018-01-12T16:20:58  *** ghost43 has joined #bitcoin-core-dev
535 2018-01-12T16:24:28  *** Eetsi123 has quit IRC
536 2018-01-12T16:24:49  *** Eetsi123 has joined #bitcoin-core-dev
537 2018-01-12T16:30:17  *** Eetsi123 has quit IRC
538 2018-01-12T16:32:23  *** Gabrielle5Maggio has quit IRC
539 2018-01-12T16:37:25  *** Arokh has quit IRC
540 2018-01-12T16:37:25  *** baldur has quit IRC
541 2018-01-12T16:37:25  *** wallet42 has quit IRC
542 2018-01-12T16:37:25  *** profall has quit IRC
543 2018-01-12T16:37:25  *** mturquette has quit IRC
544 2018-01-12T16:37:25  *** klow has quit IRC
545 2018-01-12T16:37:25  *** gmaxwell has quit IRC
546 2018-01-12T16:37:25  *** fronti has quit IRC
547 2018-01-12T16:37:25  *** thrasher` has quit IRC
548 2018-01-12T16:37:26  *** sipa has quit IRC
549 2018-01-12T16:37:26  *** chjj has quit IRC
550 2018-01-12T16:37:26  *** gijensen has quit IRC
551 2018-01-12T16:37:31  *** Eetsi123 has joined #bitcoin-core-dev
552 2018-01-12T16:37:33  *** gijensen has joined #bitcoin-core-dev
553 2018-01-12T16:37:33  *** fronti has joined #bitcoin-core-dev
554 2018-01-12T16:37:42  *** sipa has joined #bitcoin-core-dev
555 2018-01-12T16:38:00  *** mturquette has joined #bitcoin-core-dev
556 2018-01-12T16:38:01  *** chjj has joined #bitcoin-core-dev
557 2018-01-12T16:38:04  *** wallet42 has joined #bitcoin-core-dev
558 2018-01-12T16:38:05  *** profall has joined #bitcoin-core-dev
559 2018-01-12T16:38:07  *** klow has joined #bitcoin-core-dev
560 2018-01-12T16:38:12  *** gmaxwell has joined #bitcoin-core-dev
561 2018-01-12T16:38:17  *** thrasher` has joined #bitcoin-core-dev
562 2018-01-12T16:38:23  *** Eetsi123 has quit IRC
563 2018-01-12T16:38:33  *** gmaxwell has quit IRC
564 2018-01-12T16:38:33  *** gmaxwell has joined #bitcoin-core-dev
565 2018-01-12T16:39:10  *** Eetsi123 has joined #bitcoin-core-dev
566 2018-01-12T16:40:16  *** kakobrekla has quit IRC
567 2018-01-12T16:43:56  *** Eetsi123 has quit IRC
568 2018-01-12T16:46:21  *** kakobrekla has joined #bitcoin-core-dev
569 2018-01-12T16:47:27  *** SopaXorzTaker has joined #bitcoin-core-dev
570 2018-01-12T16:48:13  <SopaXorzTaker> Why does "satoshi" appear in the BIP39 wordlist?
571 2018-01-12T16:48:24  <SopaXorzTaker> I don't think that's a well-known, unique English word
572 2018-01-12T16:48:29  <SopaXorzTaker> a tribute to Nakamoto?
573 2018-01-12T16:50:40  *** Randolf has quit IRC
574 2018-01-12T16:52:14  <mlz> SopaXorzTaker, wrong channel
575 2018-01-12T16:55:12  <SopaXorzTaker> mlz, I know, I am sorry
576 2018-01-12T16:55:21  <SopaXorzTaker> but there's no #ask-bitcoin-devs
577 2018-01-12T16:58:39  *** Lyda60Hegmann has joined #bitcoin-core-dev
578 2018-01-12T17:09:22  *** timothy has quit IRC
579 2018-01-12T17:11:43  *** alfa has quit IRC
580 2018-01-12T17:13:26  *** Lyda60Hegmann has quit IRC
581 2018-01-12T17:14:54  *** Giszmo has quit IRC
582 2018-01-12T17:15:09  *** Randolf has joined #bitcoin-core-dev
583 2018-01-12T17:26:25  *** SevenTimes_ has quit IRC
584 2018-01-12T17:32:09  *** Chris_Stewart_5 has quit IRC
585 2018-01-12T17:32:11  <jtimon> I'm not sure I understand the point of fDumpMempoolLater ...
586 2018-01-12T17:33:23  <gmaxwell> jtimon: we don't want to dump the mempool if we haven't finished loading the last dump yet.
587 2018-01-12T17:34:34  <jtimon> well, that code doesn't seem to be working then, https://github.com/bitcoin/bitcoin/issues/12142
588 2018-01-12T17:35:29  *** arubi_ is now known as arubi
589 2018-01-12T17:35:32  <gmaxwell> I think thats just an issue with the rpc, it handles it fine on shutdown as far as I know.
590 2018-01-12T17:36:03  <jtimon> shouldn't https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L682 just set it to true? why to !fRequestShutdown ?
591 2018-01-12T17:37:08  <jtimon> no, never minf
592 2018-01-12T17:41:18  *** SevenTimes_ has joined #bitcoin-core-dev
593 2018-01-12T17:51:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
594 2018-01-12T17:55:04  *** zautomata has joined #bitcoin-core-dev
595 2018-01-12T17:57:21  *** Evel-Knievel has quit IRC
596 2018-01-12T17:59:25  *** laurentmt has quit IRC
597 2018-01-12T18:03:05  *** Betty82Schaden has joined #bitcoin-core-dev
598 2018-01-12T18:07:32  *** d4ve9 has joined #bitcoin-core-dev
599 2018-01-12T18:11:05  *** d4ve has quit IRC
600 2018-01-12T18:15:53  *** tripleslash has quit IRC
601 2018-01-12T18:19:11  *** zshlyk has quit IRC
602 2018-01-12T18:23:57  *** Betty82Schaden has quit IRC
603 2018-01-12T18:25:32  *** tripleslash has joined #bitcoin-core-dev
604 2018-01-12T18:26:07  *** zshlyk has joined #bitcoin-core-dev
605 2018-01-12T18:31:39  *** jb55 has joined #bitcoin-core-dev
606 2018-01-12T18:34:28  *** ludens[m] has quit IRC
607 2018-01-12T18:34:29  *** dlb76 has quit IRC
608 2018-01-12T18:34:29  *** jnewbery has quit IRC
609 2018-01-12T18:34:29  *** cfields has quit IRC
610 2018-01-12T18:34:36  *** cfields has joined #bitcoin-core-dev
611 2018-01-12T18:34:47  *** ludens[m] has joined #bitcoin-core-dev
612 2018-01-12T18:35:05  *** jnewbery has joined #bitcoin-core-dev
613 2018-01-12T18:38:42  <provoostenator> Call me superstitious, but Travis seems in a much better mood today.
614 2018-01-12T18:39:38  *** dlb76 has joined #bitcoin-core-dev
615 2018-01-12T18:45:13  <BlueMatt> aws disk io more available cause everyone's jobs got slowed down at the cpu level for meltdown fixes? :p
616 2018-01-12T18:46:19  *** Emcy_ has joined #bitcoin-core-dev
617 2018-01-12T18:47:35  *** Emcy has quit IRC
618 2018-01-12T18:48:30  *** Chenpan has joined #bitcoin-core-dev
619 2018-01-12T18:54:02  *** Arokh has joined #bitcoin-core-dev
620 2018-01-12T18:54:10  *** zautomata has quit IRC
621 2018-01-12T18:56:40  <cfields> gmaxwell: interesting side-effect from the toolchain work, you may be interested: https://gcc.gnu.org/ml/gcc/2018-01/msg00068.html
622 2018-01-12T18:56:47  *** zautomata has joined #bitcoin-core-dev
623 2018-01-12T19:02:08  *** Victorsueca has quit IRC
624 2018-01-12T19:03:19  *** Victorsueca has joined #bitcoin-core-dev
625 2018-01-12T19:07:20  *** Deborah19Pouros has joined #bitcoin-core-dev
626 2018-01-12T19:11:57  *** Deborah19Pouros has quit IRC
627 2018-01-12T19:12:21  *** larafale has quit IRC
628 2018-01-12T19:12:57  *** larafale has joined #bitcoin-core-dev
629 2018-01-12T19:16:57  *** larafale has quit IRC
630 2018-01-12T19:18:30  *** Dizzle has joined #bitcoin-core-dev
631 2018-01-12T19:25:10  *** goatpig has quit IRC
632 2018-01-12T19:27:47  *** laurentmt has joined #bitcoin-core-dev
633 2018-01-12T19:27:52  *** laurentmt has quit IRC
634 2018-01-12T19:29:22  *** CubicEarths has joined #bitcoin-core-dev
635 2018-01-12T19:34:04  *** meshcollider has joined #bitcoin-core-dev
636 2018-01-12T19:47:42  *** Eetsi123 has joined #bitcoin-core-dev
637 2018-01-12T19:54:24  *** AaronvanW has quit IRC
638 2018-01-12T19:54:57  *** Eetsi123 has quit IRC
639 2018-01-12T19:59:24  *** larafale has joined #bitcoin-core-dev
640 2018-01-12T20:05:14  *** Evel-Knievel has joined #bitcoin-core-dev
641 2018-01-12T20:05:22  *** SopaXorzTaker has quit IRC
642 2018-01-12T20:10:10  *** LeMiner has quit IRC
643 2018-01-12T20:11:24  *** Alberto25Runolfs has joined #bitcoin-core-dev
644 2018-01-12T20:16:38  *** larafale has quit IRC
645 2018-01-12T20:17:15  *** larafale has joined #bitcoin-core-dev
646 2018-01-12T20:19:11  *** mrannanay has quit IRC
647 2018-01-12T20:19:57  *** CubicEarths has quit IRC
648 2018-01-12T20:20:36  *** CubicEarths has joined #bitcoin-core-dev
649 2018-01-12T20:21:21  *** Alberto25Runolfs has quit IRC
650 2018-01-12T20:21:27  *** larafale has quit IRC
651 2018-01-12T20:26:27  *** JayBerg has joined #bitcoin-core-dev
652 2018-01-12T20:26:28  *** JackH has joined #bitcoin-core-dev
653 2018-01-12T20:26:30  *** CubicEar_ has joined #bitcoin-core-dev
654 2018-01-12T20:29:50  *** CubicEarths has quit IRC
655 2018-01-12T20:31:29  *** crazyprodigy has quit IRC
656 2018-01-12T20:37:22  *** JayBerg has quit IRC
657 2018-01-12T20:39:10  *** promag has joined #bitcoin-core-dev
658 2018-01-12T20:41:34  *** dx25 has quit IRC
659 2018-01-12T20:41:36  *** wtabata has quit IRC
660 2018-01-12T20:41:42  *** promag has quit IRC
661 2018-01-12T20:49:20  *** dx25 has joined #bitcoin-core-dev
662 2018-01-12T20:56:06  *** Jackielove4u has joined #bitcoin-core-dev
663 2018-01-12T20:58:13  *** anome has quit IRC
664 2018-01-12T20:58:19  *** laurentmt has joined #bitcoin-core-dev
665 2018-01-12T20:58:44  *** laurentmt has quit IRC
666 2018-01-12T21:01:04  *** promag has joined #bitcoin-core-dev
667 2018-01-12T21:01:05  <bitcoin-git> [bitcoin] jtimon opened pull request #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished (master...b16-bugfix-savemempool) https://github.com/bitcoin/bitcoin/pull/12172
668 2018-01-12T21:03:00  <jtimon> being a bugfix, could #12172 get in for 0.16 ?
669 2018-01-12T21:03:02  <gribble> https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub
670 2018-01-12T21:06:47  <jtimon> btw, gmaxwell previously I was wondering if I could reuse fDumpMempoolLater instead of creating g_is_mempool_loaded, thanks for the help
671 2018-01-12T21:07:55  *** promag has quit IRC
672 2018-01-12T21:10:06  *** Murch has joined #bitcoin-core-dev
673 2018-01-12T21:15:50  *** Taya60Johnston has joined #bitcoin-core-dev
674 2018-01-12T21:20:41  *** Taya60Johnston has quit IRC
675 2018-01-12T21:23:07  *** btcdrak has joined #bitcoin-core-dev
676 2018-01-12T21:30:45  *** zautomata has quit IRC
677 2018-01-12T21:31:36  <luke-jr> jtimon: IMO savemempool shouldn't succeed until it is actually saved, so if you make it delay the save, the RPC probably needs to block, which is complex
678 2018-01-12T21:31:42  *** JayBerg has joined #bitcoin-core-dev
679 2018-01-12T21:32:28  *** zautomata has joined #bitcoin-core-dev
680 2018-01-12T21:32:49  <jtimon> luke-jr: yeah, that's an interesting point but kind of orthogonal, no? (although definitely related)
681 2018-01-12T21:35:03  *** zautomata has quit IRC
682 2018-01-12T21:35:58  <jtimon> luke-jr: perhaps I can add something to the documentation while at it?
683 2018-01-12T21:36:40  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #12173: [Qt] Use flexible font size for QRCode image address (master...2018/01/fix_qr_font) https://github.com/bitcoin/bitcoin/pull/12173
684 2018-01-12T21:37:03  *** zautomata has joined #bitcoin-core-dev
685 2018-01-12T21:40:08  <jonasschnelli> sipa: mind doing a short review on #11281 (since you have raised some issues there)?
686 2018-01-12T21:40:12  <gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
687 2018-01-12T21:42:57  *** Chris_Stewart_5 has quit IRC
688 2018-01-12T21:43:40  *** zautomata has quit IRC
689 2018-01-12T21:44:50  *** zautomata has joined #bitcoin-core-dev
690 2018-01-12T21:49:02  *** hirish is now known as hirishaway
691 2018-01-12T22:21:13  *** Jared has joined #bitcoin-core-dev
692 2018-01-12T22:21:16  *** Leila75Marquardt has joined #bitcoin-core-dev
693 2018-01-12T22:23:33  *** meshcollider has quit IRC
694 2018-01-12T22:26:00  *** Jared has quit IRC
695 2018-01-12T22:26:58  *** Jared has joined #bitcoin-core-dev
696 2018-01-12T22:28:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/0910cbe4ef31...b7450cdbd89a
697 2018-01-12T22:28:31  <bitcoin-git> bitcoin/master fcfb952 Russell Yanofsky: Improve TestNodeCLI output parsing...
698 2018-01-12T22:28:32  <bitcoin-git> bitcoin/master ca9085a Russell Yanofsky: Prevent TestNodeCLI.args mixups...
699 2018-01-12T22:28:32  <bitcoin-git> bitcoin/master ff9a363 Russell Yanofsky: TestNodeCLI batch emulation...
700 2018-01-12T22:29:28  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11970: Add test coverage for bitcoin-cli multiwallet calls (master...pr/mcli) https://github.com/bitcoin/bitcoin/pull/11970
701 2018-01-12T22:33:40  *** LordHummus has joined #bitcoin-core-dev
702 2018-01-12T22:34:45  *** Jared has quit IRC
703 2018-01-12T22:35:01  *** d9b4bef9 has quit IRC
704 2018-01-12T22:36:07  *** d9b4bef9 has joined #bitcoin-core-dev
705 2018-01-12T22:36:23  *** AaronvanW has joined #bitcoin-core-dev
706 2018-01-12T22:50:29  *** Dmoney has joined #bitcoin-core-dev
707 2018-01-12T22:56:20  *** LordHummus has quit IRC
708 2018-01-12T23:04:38  *** clarkmoody_ has quit IRC
709 2018-01-12T23:05:59  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #12089: qa: Make TestNodeCLI command optional in send_cli (master...Mf1801-qaCliOptions) https://github.com/bitcoin/bitcoin/pull/12089
710 2018-01-12T23:10:02  *** zautomata1 has joined #bitcoin-core-dev
711 2018-01-12T23:10:29  *** cheese_ has joined #bitcoin-core-dev
712 2018-01-12T23:11:13  *** promag has joined #bitcoin-core-dev
713 2018-01-12T23:11:18  *** zautomata has quit IRC
714 2018-01-12T23:11:30  *** berndj has quit IRC
715 2018-01-12T23:13:14  *** berndj has joined #bitcoin-core-dev
716 2018-01-12T23:20:35  *** tknp has joined #bitcoin-core-dev
717 2018-01-12T23:22:45  *** Leila75Marquardt has quit IRC
718 2018-01-12T23:26:21  *** Victorsueca has quit IRC
719 2018-01-12T23:26:25  *** Llewellyn69Schme has joined #bitcoin-core-dev
720 2018-01-12T23:27:50  *** Victorsueca has joined #bitcoin-core-dev
721 2018-01-12T23:33:11  *** JayBerg has quit IRC
722 2018-01-12T23:35:08  *** JayBerg has joined #bitcoin-core-dev
723 2018-01-12T23:35:16  *** btcdrak has quit IRC
724 2018-01-12T23:38:09  *** Guyver2 has quit IRC
725 2018-01-12T23:38:47  *** Llewellyn69Schme has quit IRC
726 2018-01-12T23:46:07  *** hirishaway is now known as hirish
727 2018-01-12T23:54:41  *** Dizzle has quit IRC
728 2018-01-12T23:54:55  *** marsadm has quit IRC
729 2018-01-12T23:54:55  *** rfree_irc has quit IRC
730 2018-01-12T23:56:07  *** d4ve9 has quit IRC
731 2018-01-12T23:56:26  *** d4ve9 has joined #bitcoin-core-dev