12018-01-24T00:06:33  *** afilini has quit IRC
  22018-01-24T00:10:02  *** leec has joined #bitcoin-core-dev
  32018-01-24T00:10:22  *** dermoth has joined #bitcoin-core-dev
  42018-01-24T00:12:50  *** dermoth has quit IRC
  52018-01-24T00:13:22  *** PaulCapestany has quit IRC
  62018-01-24T00:13:28  *** leec has quit IRC
  72018-01-24T00:13:49  *** dermoth has joined #bitcoin-core-dev
  82018-01-24T00:14:21  *** Chris_Stewart_5 has quit IRC
  92018-01-24T00:19:57  *** afilini has joined #bitcoin-core-dev
 102018-01-24T00:21:28  *** Tennis has quit IRC
 112018-01-24T00:27:06  *** mandric has joined #bitcoin-core-dev
 122018-01-24T00:27:24  *** afilini has quit IRC
 132018-01-24T00:32:45  *** shesek has quit IRC
 142018-01-24T00:32:55  *** larafale_ has quit IRC
 152018-01-24T00:33:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 162018-01-24T00:40:44  *** PaulCapestany has joined #bitcoin-core-dev
 172018-01-24T00:43:36  *** Sinclair6 has joined #bitcoin-core-dev
 182018-01-24T00:46:18  *** shesek has joined #bitcoin-core-dev
 192018-01-24T00:46:18  *** shesek has joined #bitcoin-core-dev
 202018-01-24T00:52:31  *** dermoth has quit IRC
 212018-01-24T00:53:16  *** Murch has quit IRC
 222018-01-24T00:53:26  *** Chris_Stewart_5 has quit IRC
 232018-01-24T00:57:47  *** dabura667 has joined #bitcoin-core-dev
 242018-01-24T01:09:19  *** Cory has quit IRC
 252018-01-24T01:11:47  *** PaulCape_ has joined #bitcoin-core-dev
 262018-01-24T01:12:00  *** PaulCapestany has quit IRC
 272018-01-24T01:19:32  *** PaulCape_ has quit IRC
 282018-01-24T01:25:34  *** vigorousbearhunt has quit IRC
 292018-01-24T01:27:34  *** niska has quit IRC
 302018-01-24T01:37:35  *** niska has joined #bitcoin-core-dev
 312018-01-24T01:37:55  *** harrymm_ has quit IRC
 322018-01-24T01:39:36  *** PaulCapestany has joined #bitcoin-core-dev
 332018-01-24T01:42:19  <bitcoin-git> [bitcoin] jimpo opened pull request #12254: BIP 158: Compact Block Filters for Light Clients (master...bip-158) https://github.com/bitcoin/bitcoin/pull/12254
 342018-01-24T01:46:29  *** goatpig has quit IRC
 352018-01-24T01:50:39  *** mandric has quit IRC
 362018-01-24T01:51:09  *** harrymm_ has joined #bitcoin-core-dev
 372018-01-24T01:54:10  *** r00tc0in has quit IRC
 382018-01-24T01:56:20  *** PaulCapestany has quit IRC
 392018-01-24T01:58:36  <phantomcircuit> jimpo, can you make it so the individual commits in 12254 actually work independently?
 402018-01-24T01:58:57  <phantomcircuit> pr's like that where the individual commits result in broken code make things like bisect less useful
 412018-01-24T01:59:10  *** PaulCapestany has joined #bitcoin-core-dev
 422018-01-24T02:08:33  <jimpo> I thought they do. What one breaks the build?
 432018-01-24T02:15:10  *** promag has quit IRC
 442018-01-24T02:19:25  <phantomcircuit> jimpo, hmm yeah you're right that it doesn't actually, my mistake
 452018-01-24T02:19:43  <phantomcircuit> still kind of odd to define interfaces in one commit and then implement them in several others i think
 462018-01-24T02:19:48  <phantomcircuit> but maybe that's just me
 472018-01-24T02:22:55  *** dcousens has quit IRC
 482018-01-24T02:27:24  <jimpo> Yeah, that's just sort of what made the most sense to me as far as trying to communicate why code is happening. Basically, it's just a lot of new code and I wanted to break it up somehow.
 492018-01-24T02:38:52  *** Sinclair6 has quit IRC
 502018-01-24T02:42:17  *** Chicago has quit IRC
 512018-01-24T02:46:02  *** promag has joined #bitcoin-core-dev
 522018-01-24T02:49:38  *** DoC10450 has quit IRC
 532018-01-24T03:22:23  *** Sinclai__ has joined #bitcoin-core-dev
 542018-01-24T03:26:05  *** belcher has quit IRC
 552018-01-24T03:26:45  *** givanse has quit IRC
 562018-01-24T03:39:57  *** Giszmo has quit IRC
 572018-01-24T03:42:11  *** Giszmo has joined #bitcoin-core-dev
 582018-01-24T04:00:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 592018-01-24T04:10:22  *** Giszmo has quit IRC
 602018-01-24T04:10:25  *** Cory has joined #bitcoin-core-dev
 612018-01-24T04:14:14  *** ProfMac has quit IRC
 622018-01-24T04:31:11  *** dcousens has joined #bitcoin-core-dev
 632018-01-24T04:33:56  *** ProfMac has joined #bitcoin-core-dev
 642018-01-24T04:33:57  *** contrapumpkin has quit IRC
 652018-01-24T04:34:19  *** flokie has quit IRC
 662018-01-24T04:34:42  *** flokie has joined #bitcoin-core-dev
 672018-01-24T04:36:37  *** propumpkin has joined #bitcoin-core-dev
 682018-01-24T04:43:11  *** jtimon has quit IRC
 692018-01-24T05:10:43  *** Chris_Stewart_5 has quit IRC
 702018-01-24T05:23:36  *** flokie_ has joined #bitcoin-core-dev
 712018-01-24T05:26:55  *** flokie has quit IRC
 722018-01-24T05:28:54  *** flokie_ is now known as flokie
 732018-01-24T05:29:09  *** PaulCapestany has quit IRC
 742018-01-24T05:36:06  <bitcoin-git> [bitcoin] dongcarl opened pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255
 752018-01-24T05:46:38  *** arbitrary_guy has joined #bitcoin-core-dev
 762018-01-24T05:58:26  *** PaulCapestany has joined #bitcoin-core-dev
 772018-01-24T06:00:35  *** eck has joined #bitcoin-core-dev
 782018-01-24T06:04:01  *** [Author] has quit IRC
 792018-01-24T06:06:55  *** [Author] has joined #bitcoin-core-dev
 802018-01-24T06:11:23  <mryandao> whats the general advice to "clean up commit body"?
 812018-01-24T06:11:42  <mryandao> does it mean I just have to rebase and re-write the commit message to reflect the final changes?
 822018-01-24T06:12:01  <mryandao> sorry, i'm still very new to contributing.
 832018-01-24T06:15:47  *** jojeyh has quit IRC
 842018-01-24T06:16:53  <gmaxwell> context?
 852018-01-24T06:17:59  <mryandao> gmaxwell: https://github.com/bitcoin/bitcoin/pull/12240
 862018-01-24T06:18:11  *** eck has quit IRC
 872018-01-24T06:19:02  *** r251d has joined #bitcoin-core-dev
 882018-01-24T06:19:06  *** promag has quit IRC
 892018-01-24T06:20:07  <r251d> mryandao: I think "commit body" refers to the commit message at https://github.com/bitcoin/bitcoin/pull/12240/commits/acde12c2f651912fdd04e4e50638502d5de26e91
 902018-01-24T06:22:35  *** mrannanay has joined #bitcoin-core-dev
 912018-01-24T06:22:47  <mryandao> basically just summarising the actual stuff i'm contributing less the changes made in all the commits i've squashed?
 922018-01-24T06:25:38  <r251d> I'm not sure exactly what to change about it but I think it may just be a bit verbose. Contributing.md says this:
 932018-01-24T06:25:48  <r251d> > Commit messages should be verbose by default consisting of a short subject line (50 chars max), a blank line and detailed explanatory text as separate paragraph(s), unless the title alone is self-explanatory (like "Corrected typo in init.cpp") in which case a single title line is sufficient. Commit messages should be helpful to people reading your code in the future, so explain the reasoning for
 942018-01-24T06:25:48  <r251d>  your decisions. Further explanation here.
 952018-01-24T06:28:31  <gmaxwell> mryandao: Its not clear to me what you're being asked to do there. Feel free to ask.
 962018-01-24T06:28:43  *** Murch has joined #bitcoin-core-dev
 972018-01-24T06:30:42  *** indistylo has joined #bitcoin-core-dev
 982018-01-24T06:33:05  *** aruns has joined #bitcoin-core-dev
 992018-01-24T06:34:16  <Randolf> mryandao:  You're new too?  And you got Squashing working?  You're ahead of me then.  :)
1002018-01-24T06:35:04  <mryandao> the instructions were easy to follow.
1012018-01-24T06:35:21  <mryandao> way more inituitive than git rebase --help really.
1022018-01-24T06:36:00  *** indistylo has quit IRC
1032018-01-24T06:39:29  <Randolf> I think I got rebasing working today.  Nothing showed up on GitHub.com though, so I figured it got queued or something and I'll check again later.
1042018-01-24T06:43:31  <mryandao> you gotta do a git push -f
1052018-01-24T06:44:01  <mryandao> and it should show in github.com after the push is done.
1062018-01-24T06:44:02  *** maaku has joined #bitcoin-core-dev
1072018-01-24T06:46:26  *** aruns has quit IRC
1082018-01-24T06:46:31  <Randolf> I did that, it asked for my username and password, and then it finally reported that everything is up to date.
1092018-01-24T06:46:38  *** promag has joined #bitcoin-core-dev
1102018-01-24T06:46:48  *** indistylo has joined #bitcoin-core-dev
1112018-01-24T06:49:42  <r251d> promag: could you please clarify your nit about commit body cleanup for mryandao at https://github.com/bitcoin/bitcoin/pull/12240 ?
1122018-01-24T06:50:07  *** testtt has joined #bitcoin-core-dev
1132018-01-24T06:52:27  *** testtt has quit IRC
1142018-01-24T06:53:34  *** indistylo has quit IRC
1152018-01-24T06:54:39  *** r251d has quit IRC
1162018-01-24T06:55:57  *** indistylo has joined #bitcoin-core-dev
1172018-01-24T06:59:55  *** aruns has joined #bitcoin-core-dev
1182018-01-24T07:02:50  *** indistylo has quit IRC
1192018-01-24T07:09:32  *** flokie_ has joined #bitcoin-core-dev
1202018-01-24T07:13:03  *** flokie has quit IRC
1212018-01-24T07:16:32  <bitcoin-git> [bitcoin] kallewoof opened pull request #12257: [wallet] Use destination groups instead of coins in coin select (master...feature-addrgrouped-coinselect) https://github.com/bitcoin/bitcoin/pull/12257
1222018-01-24T07:28:56  <ProfMac> Is there a channel for people who want to study the code, but aren't strong developers?
1232018-01-24T07:31:29  <Randolf> ProfMac:  There is a #bitcoin-dev channel.
1242018-01-24T07:46:14  <gmaxwell> kallewoof: very cool
1252018-01-24T07:47:29  <gmaxwell> kallewoof: did you consider/try  having the non-avoidpartialspends mode first try to see it to see if there is a solution?  I assume everyone would prefer an avoidpartial solution if it was otherwise about as good.
1262018-01-24T07:49:14  <luke-jr> kallewoof: that doesn't avoid reuse, and has security issues in the event of QC (but we have enough issues there already, so not a big deal), but seems useful anyway
1272018-01-24T07:51:02  <gmaxwell> kallewoof: it doesn't avoid reuse, but it reduces one of its major harms.
1282018-01-24T07:51:12  <luke-jr> yes, hence useful anyway
1292018-01-24T07:51:19  <gmaxwell> right now even a small amount of reuse results in your entire wallet being common-input linked.
1302018-01-24T07:52:41  <luke-jr> my point was only that it isn't an "avoid address reuse" category PR as it seemed to be suggesting it was ;)
1312018-01-24T07:53:43  *** Amuza has joined #bitcoin-core-dev
1322018-01-24T07:57:58  *** SopaXorzTaker has joined #bitcoin-core-dev
1332018-01-24T07:58:26  <gmaxwell> luke-jr: we could probably do a lot wrt reuse with two small features: when you send to an address you've sent to before, put up a dialog that asks if you're making a mistake.  (we've certantly seen people mess up by double paying addresses); and put a 'reuse' icon on any transaction paying you that pays to an address which has already been paid.
1342018-01-24T08:02:54  *** aruns has quit IRC
1352018-01-24T08:09:25  *** promag has quit IRC
1362018-01-24T08:14:09  *** tryphe_ has joined #bitcoin-core-dev
1372018-01-24T08:17:36  *** tryphe has quit IRC
1382018-01-24T08:20:40  *** Murch has quit IRC
1392018-01-24T08:32:18  *** Krellan has joined #bitcoin-core-dev
1402018-01-24T08:36:15  *** promag has joined #bitcoin-core-dev
1412018-01-24T08:36:36  <kallewoof> gmaxwell: you mean it should try to avoid partial spending and if it finds a fairly optimal solution it picks it over the per-coin selector?
1422018-01-24T08:37:24  <kallewoof> gmaxwell: I'm not sure what would be a good factor for determining success in that case, but it does sound like a good strategy. (Maybe simply # of inputs with enabled vs disabled? If same, use the no-partial-spends variant.)
1432018-01-24T08:38:52  <kallewoof> also, as noted in the PR, it is a fix to an issue raised in a different PR which marks addresses dirty. The two PRs together would avoid reuse completely, I believe. (Correct me if I'm missing something, though!)
1442018-01-24T08:38:58  <kallewoof> luke-jr: ^
1452018-01-24T08:39:13  <kallewoof> s/issue raised/issue addressed/
1462018-01-24T08:41:35  <gmaxwell> kallewoof: the decision criteria is a complicated question that is cropping up in other areas too... generally if the current feerate is low compared to what you expect in the future you want to be spending more inputs, if it's high, fewer--  though solutions without change are preferable.
1472018-01-24T08:46:47  <bitcoin-git> [bitcoin] tviho opened pull request #12258: Change app name, datadir location/settings (master...master) https://github.com/bitcoin/bitcoin/pull/12258
1482018-01-24T08:46:50  <kallewoof> gmaxwell: ahh.. that's a good point. I really like the idea of testing both cases and using the avoidpartialspends variant if it's only marginally worse.
1492018-01-24T08:47:59  <kallewoof> gmaxwell: just not sure what to base the criteria on. Maybe that's a different PR. It's simply a matter of calling https://github.com/bitcoin/bitcoin/pull/12257/files#diff-b2bb174788c7409b671c46ccc86034bdR4228 with false once and true once and comparing.
1502018-01-24T08:47:59  <bitcoin-git> [bitcoin] fanquake closed pull request #12258: Change app name, datadir location/settings (master...master) https://github.com/bitcoin/bitcoin/pull/12258
1512018-01-24T08:55:05  <gmaxwell> well at a minimum you can prefer the avoidpartial solution if it pays equal or less total fees, I think.
1522018-01-24T08:55:47  <gmaxwell> Though I know that isn't ideal, but I think it's strictly better than not trying.
1532018-01-24T08:56:52  *** timothy has joined #bitcoin-core-dev
1542018-01-24T08:57:30  <kallewoof> If the fee rate is decided on coin selection (I don't think it is, but have to check), it could be used to consider more inputs as a better solution, maybe. I think I'll do the 'equal or less fee' fix right away though (but will it, ever? won't the same solution be found by the less restricted variant?)
1552018-01-24T08:58:18  <kallewoof> I mean, if the fee rate is really low, it could see it as an opportunity to group up inputs. I think that's flawed, though, so nevermind.
1562018-01-24T09:00:25  <gmaxwell> Fee rate is known then, so the software could decide to prefer more vs fewer, the challenge is how do you know if a specific feerate is a high vs a low one?
1572018-01-24T09:01:37  <gmaxwell> as far as "won't it find it" -- unlikely, the stochastic solver only evaluates a tiny fraction of the search space... imagine you have 10 addresses, and 10 payments each, its unlikely the ungrouped solver will ever consider spending just two groups.
1582018-01-24T09:02:29  <gmaxwell> I wouldn't be surprised if the grouped solution we seldom lower fees, though it might be equal not that infrequently.
1592018-01-24T09:03:47  *** whphhg_ has joined #bitcoin-core-dev
1602018-01-24T09:04:47  *** whphhg has quit IRC
1612018-01-24T09:04:53  <kallewoof> Okay... yeah, I haven't considered the more complex cases. I'm mostly thinking of this from the "one actual payment with a bunch of tiny dust payments to track you" scenario.
1622018-01-24T09:05:56  *** intcat has quit IRC
1632018-01-24T09:08:10  <gmaxwell> I was about to say that with feerates at least tracking dust is less of an issue ... but then I remembed the last couple days...
1642018-01-24T09:08:32  *** whphhg_ is now known as whphhg
1652018-01-24T09:08:38  <gmaxwell> fun fact: I noticed recently that some obvious tracking dust I got years ago is now worth $10 each. :)
1662018-01-24T09:08:48  <kallewoof> lol
1672018-01-24T09:09:11  *** intcat has joined #bitcoin-core-dev
1682018-01-24T09:12:14  *** echelon has quit IRC
1692018-01-24T09:12:22  <kallewoof> gmaxwell: the only straightforward way I could think of to check if the fee drops is the # of coins selected (I assume every input + signature will cost the same, which is untrue with segwit vs p2pkh, but I think that's not a big issue in the long run)
1702018-01-24T09:13:32  <gmaxwell> well one might have change and the other not...
1712018-01-24T09:13:42  <gmaxwell> you could compare their weight instead?
1722018-01-24T09:14:20  *** dermoth has joined #bitcoin-core-dev
1732018-01-24T09:16:36  <kallewoof> I'm checking for change by seeing if nValueFromPresetInputs + nValueRet2 == nTargetValue. That's not precise though, due to dust limits and such, I guess.
1742018-01-24T09:16:58  *** timothy has quit IRC
1752018-01-24T09:16:59  <kallewoof> I didn't know you could get the weight for coins. Will look.
1762018-01-24T09:18:35  *** promag has quit IRC
1772018-01-24T09:18:47  *** promag has joined #bitcoin-core-dev
1782018-01-24T09:19:52  <gmaxwell> oh I see.
1792018-01-24T09:20:00  *** timothy has joined #bitcoin-core-dev
1802018-01-24T09:20:01  <gmaxwell> right you're working with selections, not transactions.
1812018-01-24T09:20:02  <kallewoof> Okay, I think I understand what you mean -- make both transactions and compare their weights and pick the avoid-partial one if it's reasonable in comparison to the non-avoiding one.
1822018-01-24T09:20:18  <gmaxwell> yes, I was thinking that you were working with transactions for some reason.
1832018-01-24T09:20:26  <kallewoof> I was hoping to do all this in SelectCoins. (My patch currently looks like this: https://github.com/bitcoin/bitcoin/pull/12257/commits/4593c6164891e5d766b33952702195288a241b2d)
1842018-01-24T09:21:27  <promag> mryandao: do you need help addressing my comment??
1852018-01-24T09:21:47  *** Emcy_ has joined #bitcoin-core-dev
1862018-01-24T09:22:08  <gmaxwell> kallewoof: I think it's not unreasonable to do that.
1872018-01-24T09:22:13  *** echelon has joined #bitcoin-core-dev
1882018-01-24T09:24:35  *** Emcy has quit IRC
1892018-01-24T09:25:17  *** tryphe_ is now known as tryphe
1902018-01-24T09:31:11  *** timothy has quit IRC
1912018-01-24T09:35:31  *** emzy has quit IRC
1922018-01-24T09:35:32  *** emzy has joined #bitcoin-core-dev
1932018-01-24T09:39:49  *** vicenteH has joined #bitcoin-core-dev
1942018-01-24T09:41:57  *** timothy has joined #bitcoin-core-dev
1952018-01-24T09:44:10  *** timothy has quit IRC
1962018-01-24T09:44:42  *** Emcy has joined #bitcoin-core-dev
1972018-01-24T09:45:06  *** timothy has joined #bitcoin-core-dev
1982018-01-24T09:47:28  *** Emcy_ has quit IRC
1992018-01-24T09:54:54  *** arbitrary_guy has quit IRC
2002018-01-24T09:56:15  <kallewoof> gmaxwell: I think I've got it. Not sure what reviewers will say though (I wrapped CWallet::CreateTransaction and called the original twice for the case where avoid-partial is unset)... https://github.com/bitcoin/bitcoin/pull/12257/commits/3af1fac480fa08f92cd611ce93885d4501acc676
2012018-01-24T09:58:10  *** afilini has joined #bitcoin-core-dev
2022018-01-24T10:05:24  *** indistylo has joined #bitcoin-core-dev
2032018-01-24T10:09:03  *** dabura667 has quit IRC
2042018-01-24T10:13:09  *** dabura667 has joined #bitcoin-core-dev
2052018-01-24T10:17:09  *** indistylo has quit IRC
2062018-01-24T10:25:48  *** indistylo has joined #bitcoin-core-dev
2072018-01-24T10:26:24  <kallewoof> (It's failing in places; will fix & push update later.)
2082018-01-24T10:31:05  *** indistylo has quit IRC
2092018-01-24T10:31:34  *** indistylo has joined #bitcoin-core-dev
2102018-01-24T10:36:25  *** afilini has quit IRC
2112018-01-24T10:37:32  *** Orion3k has joined #bitcoin-core-dev
2122018-01-24T10:41:17  *** laurentmt has joined #bitcoin-core-dev
2132018-01-24T10:41:47  *** laurentmt has quit IRC
2142018-01-24T10:47:04  *** jtimon has joined #bitcoin-core-dev
2152018-01-24T10:50:07  *** shesek has quit IRC
2162018-01-24T10:55:59  *** wxss has joined #bitcoin-core-dev
2172018-01-24T11:03:05  *** afilini has joined #bitcoin-core-dev
2182018-01-24T11:06:48  *** shesek has joined #bitcoin-core-dev
2192018-01-24T11:06:48  *** shesek has joined #bitcoin-core-dev
2202018-01-24T11:07:20  *** Orion3k has quit IRC
2212018-01-24T11:09:20  *** larafale has joined #bitcoin-core-dev
2222018-01-24T11:16:39  *** dabura667 has quit IRC
2232018-01-24T11:20:40  *** larafale has quit IRC
2242018-01-24T11:21:16  *** larafale has joined #bitcoin-core-dev
2252018-01-24T11:21:16  *** Krellan has quit IRC
2262018-01-24T11:24:39  *** Krellan has joined #bitcoin-core-dev
2272018-01-24T11:25:27  *** larafale has quit IRC
2282018-01-24T11:29:27  *** timothy has quit IRC
2292018-01-24T11:31:27  *** larafale has joined #bitcoin-core-dev
2302018-01-24T11:32:51  *** indistylo has quit IRC
2312018-01-24T11:35:55  *** indistylo has joined #bitcoin-core-dev
2322018-01-24T11:39:10  *** indistylo has quit IRC
2332018-01-24T11:39:28  *** indistylo has joined #bitcoin-core-dev
2342018-01-24T11:46:32  *** timothy has joined #bitcoin-core-dev
2352018-01-24T11:55:02  *** timothy has quit IRC
2362018-01-24T11:57:09  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/b5e4b9b5100e...8470e64724cb
2372018-01-24T11:57:10  <bitcoin-git> bitcoin/master 8d0b610 Jonas Schnelli: Avoid pemanent cs_main/cs_wallet lock during wallet rescans
2382018-01-24T11:57:10  <bitcoin-git> bitcoin/master dbf8556 Jonas Schnelli: Add RAII wallet rescan reserver
2392018-01-24T11:57:11  <bitcoin-git> bitcoin/master bc356b4 Jonas Schnelli: Make sure WalletRescanReserver has successfully reserved the rescan
2402018-01-24T11:57:37  <bitcoin-git> [bitcoin] laanwj closed pull request #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime (master...2017/09/rescan_locks) https://github.com/bitcoin/bitcoin/pull/11281
2412018-01-24T11:59:42  <promag> \o/
2422018-01-24T12:07:27  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8470e64724cb...6e89de5ba7ce
2432018-01-24T12:07:28  <bitcoin-git> bitcoin/master fb6f6b1 Matt Corallo: bluematt's testnet-seed now supports x9 (and is just a static list)
2442018-01-24T12:07:28  <bitcoin-git> bitcoin/master 51ae766 Matt Corallo: Use GetDesireableServiceFlags in static seeds, document this....
2452018-01-24T12:07:29  <bitcoin-git> bitcoin/master 62e7642 Matt Corallo: Fall back to oneshot for DNS Seeds which don't support filtering....
2462018-01-24T12:08:01  <bitcoin-git> [bitcoin] laanwj closed pull request #11512: Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding (master...2017-10-seed-service-bits-cleanups) https://github.com/bitcoin/bitcoin/pull/11512
2472018-01-24T12:08:44  *** SopaXorzTaker has quit IRC
2482018-01-24T12:08:58  *** whphhg_ has joined #bitcoin-core-dev
2492018-01-24T12:10:07  *** SopaXorzTaker has joined #bitcoin-core-dev
2502018-01-24T12:10:07  *** whphhg has quit IRC
2512018-01-24T12:10:13  *** SopaXorzTaker has quit IRC
2522018-01-24T12:11:02  *** timothy has joined #bitcoin-core-dev
2532018-01-24T12:13:00  *** SopaXorzTaker has joined #bitcoin-core-dev
2542018-01-24T12:13:56  *** tryphe_ has joined #bitcoin-core-dev
2552018-01-24T12:14:03  *** SopaXorzTaker has joined #bitcoin-core-dev
2562018-01-24T12:14:15  *** SopaXorzTaker has quit IRC
2572018-01-24T12:14:44  *** SopaXorzTaker has joined #bitcoin-core-dev
2582018-01-24T12:16:29  *** SopaXorzTaker has joined #bitcoin-core-dev
2592018-01-24T12:16:33  *** tryphe has quit IRC
2602018-01-24T12:18:00  *** afilini has quit IRC
2612018-01-24T12:18:05  <promag> wumpus: #12213 do you agree with jnewbery?
2622018-01-24T12:18:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
2632018-01-24T12:19:30  *** eck has joined #bitcoin-core-dev
2642018-01-24T12:20:08  <wumpus> promag: I agree it makes sense to separate it out and discuss it separately, not making it hold up 0.16
2652018-01-24T12:20:22  <promag> ok, I'll adjust
2662018-01-24T12:21:34  <wumpus> I agree with his points, also that we really don't want to be introducing new #ifdef ENABLE_WALLET, but in any case let's get the other two commits in
2672018-01-24T12:21:41  *** maaku has left #bitcoin-core-dev
2682018-01-24T12:23:30  <wumpus> it's doubly interesting because this code within ENABLE_WALLET doesn't use any wallet, implying, if we want this, that there is some utility code that needs to be moved out of the wallet
2692018-01-24T12:25:10  *** aruns__ has joined #bitcoin-core-dev
2702018-01-24T12:25:13  *** alfa has joined #bitcoin-core-dev
2712018-01-24T12:27:43  *** indistylo has quit IRC
2722018-01-24T12:33:25  <wumpus> going to merge #11415 first, seems it's ready
2732018-01-24T12:33:29  <gribble> https://github.com/bitcoin/bitcoin/issues/11415 | [RPC] Disallow using addresses in createmultisig by achow101 · Pull Request #11415 · bitcoin/bitcoin · GitHub
2742018-01-24T12:33:36  *** eck has quit IRC
2752018-01-24T12:33:54  *** eck has joined #bitcoin-core-dev
2762018-01-24T12:40:28  *** drizztbsd has joined #bitcoin-core-dev
2772018-01-24T12:41:14  *** timothy has quit IRC
2782018-01-24T12:48:46  *** drizztbsd has quit IRC
2792018-01-24T12:50:45  *** drizztbsd has joined #bitcoin-core-dev
2802018-01-24T12:52:30  *** promag has quit IRC
2812018-01-24T13:04:04  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e89de5ba7ce...69ec021969a4
2822018-01-24T13:04:04  <bitcoin-git> bitcoin/master 1df206f Andrew Chow: Disallow using addresses in createmultisig...
2832018-01-24T13:04:05  <bitcoin-git> bitcoin/master 69ec021 Wladimir J. van der Laan: Merge #11415: [RPC] Disallow using addresses in createmultisig...
2842018-01-24T13:04:28  <bitcoin-git> [bitcoin] laanwj closed pull request #11415: [RPC] Disallow using addresses in createmultisig (master...createmultisig-no-addr) https://github.com/bitcoin/bitcoin/pull/11415
2852018-01-24T13:07:07  *** eck has quit IRC
2862018-01-24T13:09:36  *** indistylo has joined #bitcoin-core-dev
2872018-01-24T13:10:07  *** aruns__ has quit IRC
2882018-01-24T13:17:30  *** Eetsi123 has joined #bitcoin-core-dev
2892018-01-24T13:20:45  *** DarylSharp2 has quit IRC
2902018-01-24T13:22:10  *** Eetsi123 has quit IRC
2912018-01-24T13:22:10  *** drizztbsd has quit IRC
2922018-01-24T13:23:09  *** promag has joined #bitcoin-core-dev
2932018-01-24T13:23:10  *** drizztbsd has joined #bitcoin-core-dev
2942018-01-24T13:25:05  *** drizztbsd has quit IRC
2952018-01-24T13:25:30  *** drizztbsd has joined #bitcoin-core-dev
2962018-01-24T13:27:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2972018-01-24T13:27:29  *** drizztbsd has quit IRC
2982018-01-24T13:29:32  *** drizztbsd has joined #bitcoin-core-dev
2992018-01-24T13:30:28  *** rafalcpp_ is now known as rafalcpp
3002018-01-24T13:31:30  *** drizztbsd has quit IRC
3012018-01-24T13:31:33  *** Stevie88Glover has quit IRC
3022018-01-24T13:31:54  *** drizztbsd has joined #bitcoin-core-dev
3032018-01-24T13:32:30  *** Guyver2 has joined #bitcoin-core-dev
3042018-01-24T13:35:01  *** drizztbsd has quit IRC
3052018-01-24T13:35:40  *** drizztbsd has joined #bitcoin-core-dev
3062018-01-24T13:35:40  *** Krellan has quit IRC
3072018-01-24T13:36:04  *** Gay6Rowe has joined #bitcoin-core-dev
3082018-01-24T13:39:24  *** promag has quit IRC
3092018-01-24T13:39:37  *** promag has joined #bitcoin-core-dev
3102018-01-24T13:40:08  *** Krellan has joined #bitcoin-core-dev
3112018-01-24T13:44:45  *** Chris_Stewart_5 has quit IRC
3122018-01-24T13:47:31  *** Gay6Rowe has quit IRC
3132018-01-24T13:49:56  *** Krellan has quit IRC
3142018-01-24T13:50:30  *** Krellan has joined #bitcoin-core-dev
3152018-01-24T13:50:47  *** wolfspraul has joined #bitcoin-core-dev
3162018-01-24T13:52:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/69ec021969a4...126000ba9e7f
3172018-01-24T13:52:27  <bitcoin-git> bitcoin/master ffffb10 MarcoFalke: qa: Rename cli.args to cli.options...
3182018-01-24T13:52:27  <bitcoin-git> bitcoin/master fae7b14 MarcoFalke: qa: Make TestNodeCLI command optional in send_cli
3192018-01-24T13:52:28  <bitcoin-git> bitcoin/master 126000b MarcoFalke: Merge #12089: qa: Make TestNodeCLI command optional in send_cli...
3202018-01-24T13:53:10  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12089: qa: Make TestNodeCLI command optional in send_cli (master...Mf1801-qaCliOptions) https://github.com/bitcoin/bitcoin/pull/12089
3212018-01-24T13:54:48  *** Krellan has quit IRC
3222018-01-24T13:55:32  *** Krellan has joined #bitcoin-core-dev
3232018-01-24T13:58:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3242018-01-24T13:59:50  *** Krellan has quit IRC
3252018-01-24T14:00:32  *** Krellan has joined #bitcoin-core-dev
3262018-01-24T14:04:57  *** Krellan has quit IRC
3272018-01-24T14:05:33  *** Krellan has joined #bitcoin-core-dev
3282018-01-24T14:07:16  *** SopaXorzTaker has quit IRC
3292018-01-24T14:07:38  *** SopaXorzTaker has joined #bitcoin-core-dev
3302018-01-24T14:23:08  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/126000ba9e7f...95941396fff8
3312018-01-24T14:23:09  <bitcoin-git> bitcoin/master 596c446 Sjors Provoost: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH...
3322018-01-24T14:23:09  <bitcoin-git> bitcoin/master 9594139 Wladimir J. van der Laan: Merge #12119: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH...
3332018-01-24T14:23:51  *** tryphe_ has quit IRC
3342018-01-24T14:23:55  <bitcoin-git> [bitcoin] laanwj closed pull request #12119:  [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (master...bech32-change) https://github.com/bitcoin/bitcoin/pull/12119
3352018-01-24T14:25:57  *** Chris_Stewart_5 has quit IRC
3362018-01-24T14:26:11  *** drizztbsd has quit IRC
3372018-01-24T14:26:53  *** drizztbsd has joined #bitcoin-core-dev
3382018-01-24T14:30:17  *** belcher_ has joined #bitcoin-core-dev
3392018-01-24T14:35:53  *** Kayla10Mertz has joined #bitcoin-core-dev
3402018-01-24T14:40:52  *** eck has joined #bitcoin-core-dev
3412018-01-24T14:40:56  *** afilini has joined #bitcoin-core-dev
3422018-01-24T14:45:00  *** alfa has quit IRC
3432018-01-24T14:50:38  *** aruns__ has joined #bitcoin-core-dev
3442018-01-24T14:52:23  *** afilini has quit IRC
3452018-01-24T14:52:34  <promag> wumpus: #12213, rebased and removed createmultisig change
3462018-01-24T14:52:37  <gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
3472018-01-24T14:53:19  *** indistylo has quit IRC
3482018-01-24T14:56:53  *** SopaXorzTaker has quit IRC
3492018-01-24T14:59:38  *** propumpkin is now known as contrapumpkin
3502018-01-24T14:59:55  <wumpus> promag: thanks!
3512018-01-24T15:00:13  <promag> taking care of #12194 too
3522018-01-24T15:00:17  <gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
3532018-01-24T15:12:24  *** jojeyh has joined #bitcoin-core-dev
3542018-01-24T15:13:07  *** drizztbsd has quit IRC
3552018-01-24T15:14:09  *** neha has quit IRC
3562018-01-24T15:17:22  *** tryphe has joined #bitcoin-core-dev
3572018-01-24T15:22:03  *** lnostdal has joined #bitcoin-core-dev
3582018-01-24T15:22:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3592018-01-24T15:24:30  *** aruns__ has quit IRC
3602018-01-24T15:33:22  *** neha has joined #bitcoin-core-dev
3612018-01-24T15:34:06  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/95941396fff8...e37ca2be91bd
3622018-01-24T15:34:07  <bitcoin-git> bitcoin/master 04ededf Russell Yanofsky: Make CKey::Load references const...
3632018-01-24T15:34:07  <bitcoin-git> bitcoin/master e37ca2b Wladimir J. van der Laan: Merge #12250: Make CKey::Load references const...
3642018-01-24T15:34:57  <bitcoin-git> [bitcoin] laanwj closed pull request #12250: Make CKey::Load references const (master...pr/keyload) https://github.com/bitcoin/bitcoin/pull/12250
3652018-01-24T15:35:39  <promag> wumpus: pushed #12194
3662018-01-24T15:35:40  <gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
3672018-01-24T15:35:52  <promag> those are the last 2 in 0.16 millestone
3682018-01-24T15:37:42  *** neha has quit IRC
3692018-01-24T15:38:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e37ca2be91bd...6e3fe936090d
3702018-01-24T15:38:48  <bitcoin-git> bitcoin/master 1e0d6e9 Wladimir J. van der Laan: tx: Update transifex slug for 0.16...
3712018-01-24T15:38:49  <bitcoin-git> bitcoin/master 6e3fe93 Wladimir J. van der Laan: qt: Update translation source file...
3722018-01-24T15:40:58  *** wraithm has joined #bitcoin-core-dev
3732018-01-24T15:42:22  *** SopaXorzTaker has joined #bitcoin-core-dev
3742018-01-24T15:44:44  <achow101> Oh! 0.16 is almost ready. Only 2 PRs left
3752018-01-24T15:45:19  <wumpus> yep, I hope we can tag it after the meeting tomorrow
3762018-01-24T15:45:40  <wumpus> rc1, I mean
3772018-01-24T15:46:51  <wumpus> still need to some some release process things, such as updating hardcoded seeds
3782018-01-24T15:49:30  *** eck has quit IRC
3792018-01-24T15:49:45  *** afilini has joined #bitcoin-core-dev
3802018-01-24T15:50:42  <sipa> wumpus: do we want #12253 in 0.16?
3812018-01-24T15:50:43  <gribble> https://github.com/bitcoin/bitcoin/issues/12253 | SegWit support for importmulti · Issue #12253 · bitcoin/bitcoin · GitHub
3822018-01-24T15:51:48  <wumpus> sipa: if possible, but I think it's getting a bit late for that
3832018-01-24T15:52:02  *** vigorousbearhunt has joined #bitcoin-core-dev
3842018-01-24T15:52:32  <sipa> i certainly won't have time until next week
3852018-01-24T15:52:33  <wumpus> I assume the code still needs to be written, and ofc it will need to go through a review cycle
3862018-01-24T15:52:38  *** mrannanay has quit IRC
3872018-01-24T15:52:42  <wumpus> right, so I guess that means no
3882018-01-24T15:53:26  <wumpus> should probably mention lack of support in importmulti it in the 'known issues' in the release notes
3892018-01-24T15:53:30  <promag> is that a thing for a 0.16.1?
3902018-01-24T15:53:30  <sipa> you think it's not essential?
3912018-01-24T15:53:51  <wumpus> no, I don't think it's essential
3922018-01-24T15:54:04  <promag> sipa: you think it is?
3932018-01-24T15:54:23  <sipa> signmessage may be worse, as it may silently break for people who didn't know we were switching to a new address format
3942018-01-24T15:54:24  <wumpus> but I think segwit address support is worth a release in itself, even if not all supporting features have made it in yet
3952018-01-24T15:54:45  <wumpus> so that one needs to be mentioned in the release notes as well
3962018-01-24T15:55:28  <sipa> okay
3972018-01-24T15:56:03  <wumpus> I can't be the only one that really wants a release with segwit wallet out?
3982018-01-24T15:56:24  <sipa> no, i'm sure you're not :)
3992018-01-24T15:56:42  *** SopaXorzTaker has quit IRC
4002018-01-24T15:56:58  <wumpus> promag: yes, could be 0.16.1
4012018-01-24T16:00:24  *** Giszmo has joined #bitcoin-core-dev
4022018-01-24T16:00:30  *** timothy has joined #bitcoin-core-dev
4032018-01-24T16:00:33  *** afilini has quit IRC
4042018-01-24T16:00:54  <ryanofsky> promag, fyi #12213 nulldummy.py test currently fails
4052018-01-24T16:00:56  <gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
4062018-01-24T16:01:10  <instagibbs> there's going to be a lot of cleanup regardless, 0.16.1 is going to happen
4072018-01-24T16:01:16  <promag> ryanofsky: ty
4082018-01-24T16:01:31  <wumpus> instagibbs: that's true for any major release, though :)
4092018-01-24T16:03:31  <instagibbs> I would look through release history to try and disprove, instead i shall just double-down, and log off
4102018-01-24T16:03:35  <instagibbs> ;)
4112018-01-24T16:04:17  <promag> is there anything deprecated in 0.15 to remove?
4122018-01-24T16:07:57  *** mxg has joined #bitcoin-core-dev
4132018-01-24T16:10:07  <bitcoin-git> [bitcoin] fwolfst opened pull request #12260: [Trivial] link mentioned scripted-diff-commit (developer-doc) (master...LINK_COMMIT_IN_DOC_DEVNOTES) https://github.com/bitcoin/bitcoin/pull/12260
4142018-01-24T16:10:57  *** Amuza has quit IRC
4152018-01-24T16:12:37  <achow101> promag: I think all the currently deprecated things are for removal in 0.17 (except the accounts system)
4162018-01-24T16:13:10  <promag> so mark deprectated in X, remove in X+2?
4172018-01-24T16:13:40  <wumpus> depends on the feature and the reason for deprecation, so depends on what was discussed at the time of deprecating it
4182018-01-24T16:14:10  <achow101> no, the things currently deprecated were marked deprecated for 0.16
4192018-01-24T16:16:21  *** mrannanay has joined #bitcoin-core-dev
4202018-01-24T16:18:06  *** Murch has joined #bitcoin-core-dev
4212018-01-24T16:18:12  <promag> got it
4222018-01-24T16:19:13  *** Guest25674 has joined #bitcoin-core-dev
4232018-01-24T16:19:29  *** Krellan has quit IRC
4242018-01-24T16:19:51  <bitcoin-git> [bitcoin] laanwj opened pull request #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB (master...2018_01_block_chain_size) https://github.com/bitcoin/bitcoin/pull/12261
4252018-01-24T16:21:02  *** Krellan has joined #bitcoin-core-dev
4262018-01-24T16:24:14  <promag> ryanofsky: fixed segwit
4272018-01-24T16:24:24  <promag> ^ test =)
4282018-01-24T16:24:29  <sipa> that sounds ominous
4292018-01-24T16:24:38  <promag> heh
4302018-01-24T16:26:21  <promag> wumpus: "Bump BLOCK_CHAIN_SIZE to 200GB" typo there s/_CHAIN//
4312018-01-24T16:26:56  <wumpus> promag: noooooooo
4322018-01-24T16:27:07  <sipa> hahaha
4332018-01-24T16:27:08  <promag> 100GB?
4342018-01-24T16:27:27  *** neha has joined #bitcoin-core-dev
4352018-01-24T16:27:42  <wumpus> promag: I already had to juggle partitions to fit the current one on my dev machine
4362018-01-24T16:28:17  <Chris_Stewart_5> lol.
4372018-01-24T16:28:57  <Chris_Stewart_5> we can now fit our entire previous blockchain in two blocks. MUCH THROUGHPUT
4382018-01-24T16:30:33  *** Kayla10Mertz has quit IRC
4392018-01-24T16:30:46  *** harrymm_ has quit IRC
4402018-01-24T16:31:08  *** harrymm has joined #bitcoin-core-dev
4412018-01-24T16:31:29  <jcorgan> how about we embed the entire current blockchain in an OP_RETURN of a new genesis block?
4422018-01-24T16:33:15  <MarcoFalke> wumpus: What about #12251
4432018-01-24T16:33:15  <wumpus> of course, and after that the OP_RETURN policy limit goes from 80 bytes to 80 GB, so it's possible to embed entire DVD images
4442018-01-24T16:33:17  <gribble> https://github.com/bitcoin/bitcoin/issues/12251 | initwallet: Do not translate highly technical addresstype help by MarcoFalke · Pull Request #12251 · bitcoin/bitcoin · GitHub
4452018-01-24T16:33:30  <MarcoFalke> Asking since you pushed the translations recently
4462018-01-24T16:33:40  <promag> jcorgan:  another typo, s/OP_RETURN/javascript
4472018-01-24T16:34:42  <wumpus> MarcoFalke: I think we should not translate option help messages at all
4482018-01-24T16:34:45  *** Krellan has quit IRC
4492018-01-24T16:34:48  <promag> I guess project:bitcoin/bitcoin/8 will be updated in the next days?
4502018-01-24T16:34:53  <MarcoFalke> I know you proposed that #10962
4512018-01-24T16:34:54  <gribble> https://github.com/bitcoin/bitcoin/issues/10962 | Stop translating command-line option help? · Issue #10962 · bitcoin/bitcoin · GitHub
4522018-01-24T16:35:07  <wumpus> but yes it might be too late to do that for 0.16 so I'm ok with your change
4532018-01-24T16:35:21  *** Krellan has joined #bitcoin-core-dev
4542018-01-24T16:36:12  <MarcoFalke> Yeah, I want to save our translators from trying to translate "segwit" or "p2sh"
4552018-01-24T16:36:41  <wumpus> agree
4562018-01-24T16:37:54  *** Allan88Bergstrom has joined #bitcoin-core-dev
4572018-01-24T16:39:29  <bitcoin-git> [bitcoin] laanwj opened pull request #12262: net: Hardcoded seed update (master...2018_01_seed_update) https://github.com/bitcoin/bitcoin/pull/12262
4582018-01-24T16:39:53  *** Krellan has quit IRC
4592018-01-24T16:40:22  *** Krellan has joined #bitcoin-core-dev
4602018-01-24T16:41:41  *** tripleslash has joined #bitcoin-core-dev
4612018-01-24T16:42:27  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e3fe936090d...cc5870a4057f
4622018-01-24T16:42:27  <bitcoin-git> bitcoin/master fa7ecbf MarcoFalke: initwallet: Do not translate highly technical addresstype help
4632018-01-24T16:42:28  <bitcoin-git> bitcoin/master cc5870a Wladimir J. van der Laan: Merge #12251: initwallet: Do not translate highly technical addresstype help...
4642018-01-24T16:43:20  <bitcoin-git> [bitcoin] laanwj closed pull request #12251: initwallet: Do not translate highly technical addresstype help (master...Mf1801-walletNoTranslateInitHelp) https://github.com/bitcoin/bitcoin/pull/12251
4652018-01-24T16:43:27  *** Giszmo has quit IRC
4662018-01-24T16:50:57  *** Randolf has quit IRC
4672018-01-24T16:52:38  *** promag has quit IRC
4682018-01-24T16:59:01  *** Giszmo has joined #bitcoin-core-dev
4692018-01-24T17:02:36  *** Victorsueca has quit IRC
4702018-01-24T17:03:46  *** Victorsueca has joined #bitcoin-core-dev
4712018-01-24T17:04:11  *** harrymm_ has joined #bitcoin-core-dev
4722018-01-24T17:06:35  *** harrymm has quit IRC
4732018-01-24T17:08:56  *** dermoth has quit IRC
4742018-01-24T17:09:49  *** dermoth has joined #bitcoin-core-dev
4752018-01-24T17:10:54  *** meshcollider has quit IRC
4762018-01-24T17:13:55  *** mxg has quit IRC
4772018-01-24T17:19:05  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4782018-01-24T17:19:05  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4792018-01-24T17:20:00  *** Randolf has joined #bitcoin-core-dev
4802018-01-24T17:22:17  *** mxg has joined #bitcoin-core-dev
4812018-01-24T17:23:11  *** promag has joined #bitcoin-core-dev
4822018-01-24T17:24:43  *** afilini has joined #bitcoin-core-dev
4832018-01-24T17:26:49  *** afilini has quit IRC
4842018-01-24T17:29:36  *** Murch has quit IRC
4852018-01-24T17:31:20  *** Amuza has joined #bitcoin-core-dev
4862018-01-24T17:31:25  *** eck has joined #bitcoin-core-dev
4872018-01-24T17:32:14  *** larafale has quit IRC
4882018-01-24T17:43:36  *** Giszmo has quit IRC
4892018-01-24T17:44:14  *** DigitalDank has quit IRC
4902018-01-24T17:45:40  *** flokie_ is now known as flokie
4912018-01-24T17:56:30  *** ghost43 has quit IRC
4922018-01-24T17:58:35  *** ghost43 has joined #bitcoin-core-dev
4932018-01-24T18:03:03  *** goatpig has joined #bitcoin-core-dev
4942018-01-24T18:03:05  *** Murch has joined #bitcoin-core-dev
4952018-01-24T18:07:13  *** __jnsmk__ has joined #bitcoin-core-dev
4962018-01-24T18:07:49  *** mxg has quit IRC
4972018-01-24T18:09:06  *** mxg has joined #bitcoin-core-dev
4982018-01-24T18:17:11  *** eck has quit IRC
4992018-01-24T18:27:06  *** Giszmo has joined #bitcoin-core-dev
5002018-01-24T18:28:09  *** Murch has quit IRC
5012018-01-24T18:43:28  *** mxg has quit IRC
5022018-01-24T18:43:43  *** vicenteH has quit IRC
5032018-01-24T18:49:37  *** vigorousbearhunt has quit IRC
5042018-01-24T18:50:32  *** vigorousbearhunt has joined #bitcoin-core-dev
5052018-01-24T18:54:05  *** Krellan has quit IRC
5062018-01-24T18:58:37  *** Krellan has joined #bitcoin-core-dev
5072018-01-24T19:00:10  <bitcoin-git> [bitcoin] jnewbery opened pull request #12264: Fix versionbits warning test (master...fix_versionbits_warning_test) https://github.com/bitcoin/bitcoin/pull/12264
5082018-01-24T19:01:14  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cc5870a4057f...eadb2dacc3c6
5092018-01-24T19:01:15  <bitcoin-git> bitcoin/master 886a92f João Barbosa: [rpc] Add address type option to addmultisigaddress
5102018-01-24T19:01:16  <bitcoin-git> bitcoin/master f523c6b João Barbosa: [qa] Use address type in addmultisigaddress to avoid addwitnessaddress
5112018-01-24T19:01:16  <bitcoin-git> bitcoin/master eadb2da Jonas Schnelli: Merge #12213: Add address type option to addmultisigaddress...
5122018-01-24T19:01:36  *** Murch has joined #bitcoin-core-dev
5132018-01-24T19:02:04  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12213: Add address type option to addmultisigaddress (master...2018-01-addmultisigaddress-address-type) https://github.com/bitcoin/bitcoin/pull/12213
5142018-01-24T19:03:20  *** Krellan has quit IRC
5152018-01-24T19:03:59  *** Krellan has joined #bitcoin-core-dev
5162018-01-24T19:06:39  *** Allan88Bergstrom has quit IRC
5172018-01-24T19:08:05  *** owowo has quit IRC
5182018-01-24T19:08:24  *** Krellan has quit IRC
5192018-01-24T19:08:52  *** Victorsueca has quit IRC
5202018-01-24T19:09:00  *** Krellan has joined #bitcoin-core-dev
5212018-01-24T19:10:14  *** Victorsueca has joined #bitcoin-core-dev
5222018-01-24T19:10:19  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/eadb2dacc3c6...7abb0f0929bd
5232018-01-24T19:10:20  <bitcoin-git> bitcoin/master 31dbd5a João Barbosa: [wallet] Add change type to CCoinControl
5242018-01-24T19:10:20  <bitcoin-git> bitcoin/master 536ddeb João Barbosa: [rpc] Add change_type option to fundrawtransaction
5252018-01-24T19:10:21  <bitcoin-git> bitcoin/master 16f6f59 João Barbosa: [qa] Test fundrawtransaction with change_type option
5262018-01-24T19:11:05  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12194: Add change type option to fundrawtransaction (master...2018-01-fundrawtransaction-changetype) https://github.com/bitcoin/bitcoin/pull/12194
5272018-01-24T19:13:01  *** owowo has joined #bitcoin-core-dev
5282018-01-24T19:13:14  *** Krellan has quit IRC
5292018-01-24T19:14:00  *** Krellan has joined #bitcoin-core-dev
5302018-01-24T19:18:12  *** Krellan has quit IRC
5312018-01-24T19:18:23  *** dermoth has quit IRC
5322018-01-24T19:19:02  *** Krellan has joined #bitcoin-core-dev
5332018-01-24T19:19:59  *** BashCo has joined #bitcoin-core-dev
5342018-01-24T19:22:25  *** BashCo_ has quit IRC
5352018-01-24T19:29:40  *** BashCo has quit IRC
5362018-01-24T19:29:53  *** BashCo_ has joined #bitcoin-core-dev
5372018-01-24T19:30:53  *** dermoth has joined #bitcoin-core-dev
5382018-01-24T19:35:53  *** Melvin79Rodrigue has joined #bitcoin-core-dev
5392018-01-24T19:37:37  *** Murch has quit IRC
5402018-01-24T19:39:05  *** BashCo_ has quit IRC
5412018-01-24T19:39:52  *** BashCo has joined #bitcoin-core-dev
5422018-01-24T19:40:44  *** ghost43 has quit IRC
5432018-01-24T19:41:31  *** ghost43 has joined #bitcoin-core-dev
5442018-01-24T19:43:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7abb0f0929bd...f359afcc4104
5452018-01-24T19:43:12  <bitcoin-git> bitcoin/master ba490d2 Wladimir J. van der Laan: qt: Bump BLOCK_CHAIN_SIZE to 200GB...
5462018-01-24T19:43:13  <bitcoin-git> bitcoin/master f359afc MarcoFalke: Merge #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB...
5472018-01-24T19:44:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB (master...2018_01_block_chain_size) https://github.com/bitcoin/bitcoin/pull/12261
5482018-01-24T19:47:24  *** givanse has joined #bitcoin-core-dev
5492018-01-24T19:50:57  *** Randolf has quit IRC
5502018-01-24T19:55:44  *** vigorousbearhunt has quit IRC
5512018-01-24T19:56:31  *** vigorousbearhunt has joined #bitcoin-core-dev
5522018-01-24T19:58:30  *** Murch has joined #bitcoin-core-dev
5532018-01-24T19:59:04  *** Krellan has quit IRC
5542018-01-24T19:59:05  *** BashCo has quit IRC
5552018-01-24T19:59:44  *** Krellan has joined #bitcoin-core-dev
5562018-01-24T20:01:07  *** afilini has joined #bitcoin-core-dev
5572018-01-24T20:05:21  *** indistylo has joined #bitcoin-core-dev
5582018-01-24T20:09:13  *** BashCo has joined #bitcoin-core-dev
5592018-01-24T20:11:05  *** Randolf has joined #bitcoin-core-dev
5602018-01-24T20:12:05  *** indistylo has quit IRC
5612018-01-24T20:17:47  *** Giszmo has quit IRC
5622018-01-24T20:18:49  *** Giszmo has joined #bitcoin-core-dev
5632018-01-24T20:21:14  *** Scrat has quit IRC
5642018-01-24T20:23:01  *** Scrat has joined #bitcoin-core-dev
5652018-01-24T20:27:00  *** anome has joined #bitcoin-core-dev
5662018-01-24T20:41:54  *** Murch has quit IRC
5672018-01-24T20:42:01  *** anome has quit IRC
5682018-01-24T20:51:03  <jonasschnelli> Our sighash tests do not exercise sigversion SIGVERSION_WITNESS_V0?
5692018-01-24T20:51:27  <jonasschnelli> Or to ask different, where can I find the testvectors for SIGVERSION_WITNESS_V0 sighash?
5702018-01-24T20:51:32  *** jb55 has joined #bitcoin-core-dev
5712018-01-24T20:51:57  <Chris_Stewart_5> jonasschnelli: Isn't that tested by tx_{in}valid.json?
5722018-01-24T20:52:21  <jonasschnelli> Let me check...
5732018-01-24T20:53:04  <jonasschnelli> Chris_Stewart_5: I think your right,... was looking for bar sw sighash tests... thanks!
5742018-01-24T20:55:21  <Chris_Stewart_5> jonasschnelli: script_tests.json might have simpler tests for the serialization algorithm
5752018-01-24T20:55:34  <Chris_Stewart_5> there might be overhead to setting up the tx_valid.json test vectors
5762018-01-24T21:02:18  <jonasschnelli> Thanks!
5772018-01-24T21:07:21  *** echelon has quit IRC
5782018-01-24T21:08:11  *** echelon has joined #bitcoin-core-dev
5792018-01-24T21:10:12  *** jb55 has quit IRC
5802018-01-24T21:17:18  *** bajohns has quit IRC
5812018-01-24T21:17:49  *** droark has quit IRC
5822018-01-24T21:22:40  *** neha has quit IRC
5832018-01-24T21:23:36  *** ryan-c has quit IRC
5842018-01-24T21:24:50  *** ryan-c has joined #bitcoin-core-dev
5852018-01-24T21:25:35  *** dcousens has quit IRC
5862018-01-24T21:28:54  *** neha has joined #bitcoin-core-dev
5872018-01-24T21:29:08  *** vicenteH has joined #bitcoin-core-dev
5882018-01-24T21:31:16  *** promag has quit IRC
5892018-01-24T21:31:32  *** promag has joined #bitcoin-core-dev
5902018-01-24T21:33:25  *** givanse has quit IRC
5912018-01-24T21:37:10  *** Melvin79Rodrigue has quit IRC
5922018-01-24T21:45:33  *** timothy has quit IRC
5932018-01-24T21:50:29  *** __jnsmk__ has quit IRC
5942018-01-24T21:52:48  *** meshcollider has joined #bitcoin-core-dev
5952018-01-24T21:55:50  *** afilini has quit IRC
5962018-01-24T21:58:50  *** afilini has joined #bitcoin-core-dev
5972018-01-24T22:00:51  *** wraithm has quit IRC
5982018-01-24T22:01:03  *** Scrat has quit IRC
5992018-01-24T22:06:37  *** wraithm has joined #bitcoin-core-dev
6002018-01-24T22:06:59  *** wraithm has quit IRC
6012018-01-24T22:07:32  *** wraithm has joined #bitcoin-core-dev
6022018-01-24T22:09:25  *** wraithm has quit IRC
6032018-01-24T22:10:27  *** wraithm has joined #bitcoin-core-dev
6042018-01-24T22:12:08  *** cryptapus has quit IRC
6052018-01-24T22:17:13  *** cryptapus has joined #bitcoin-core-dev
6062018-01-24T22:17:14  *** cryptapus has joined #bitcoin-core-dev
6072018-01-24T22:18:24  *** Amuza has quit IRC
6082018-01-24T22:21:38  *** larafale has joined #bitcoin-core-dev
6092018-01-24T22:23:42  *** droark has joined #bitcoin-core-dev
6102018-01-24T22:24:40  *** Giszmo has quit IRC
6112018-01-24T22:25:19  *** Giszmo has joined #bitcoin-core-dev
6122018-01-24T22:25:40  *** mxg has joined #bitcoin-core-dev
6132018-01-24T22:27:17  *** Guyver2 has quit IRC
6142018-01-24T22:28:01  *** phantomcircuit has quit IRC
6152018-01-24T22:28:26  *** phantomcircuit has joined #bitcoin-core-dev
6162018-01-24T22:30:13  *** givanse has joined #bitcoin-core-dev
6172018-01-24T22:30:37  *** phantomcircuit has quit IRC
6182018-01-24T22:30:49  *** phantomcircuit has joined #bitcoin-core-dev
6192018-01-24T22:33:23  *** promag has quit IRC
6202018-01-24T22:35:53  *** Jamey74Swift has joined #bitcoin-core-dev
6212018-01-24T22:36:45  *** CubicEarths has joined #bitcoin-core-dev
6222018-01-24T22:37:12  *** phantomcircuit has left #bitcoin-core-dev
6232018-01-24T22:43:02  *** Murch has joined #bitcoin-core-dev
6242018-01-24T22:43:22  *** mxg has quit IRC
6252018-01-24T22:44:47  *** wxss has quit IRC
6262018-01-24T22:45:01  *** phantomcircuit has joined #bitcoin-core-dev
6272018-01-24T22:48:34  *** CubicEarths has quit IRC
6282018-01-24T22:50:18  *** Jamey74Swift has quit IRC
6292018-01-24T22:50:49  *** Cogito_Ergo_Sum has quit IRC
6302018-01-24T22:54:44  *** Murch has quit IRC
6312018-01-24T22:55:59  *** Chris_Stewart_5 has quit IRC
6322018-01-24T23:03:55  *** promag has joined #bitcoin-core-dev
6332018-01-24T23:04:43  *** phantomcircuit has quit IRC
6342018-01-24T23:04:55  *** phantomcircuit has joined #bitcoin-core-dev
6352018-01-24T23:07:53  *** vigorousbearhunt has quit IRC
6362018-01-24T23:07:54  *** owowo has quit IRC
6372018-01-24T23:09:50  *** vigorousbearhunt has joined #bitcoin-core-dev
6382018-01-24T23:22:38  *** mrannanay has quit IRC
6392018-01-24T23:29:49  *** wraithm has quit IRC
6402018-01-24T23:32:20  *** givanse has quit IRC
6412018-01-24T23:33:22  *** larafale has quit IRC
6422018-01-24T23:34:02  *** larafale has joined #bitcoin-core-dev
6432018-01-24T23:35:53  *** Melissa57Frami has joined #bitcoin-core-dev
6442018-01-24T23:38:27  *** larafale has quit IRC
6452018-01-24T23:41:12  *** sk8boy189 has joined #bitcoin-core-dev
6462018-01-24T23:43:18  *** Melissa57Frami has quit IRC
6472018-01-24T23:45:59  *** Murch has joined #bitcoin-core-dev
6482018-01-24T23:48:48  *** afilini has quit IRC
6492018-01-24T23:54:23  *** jb55 has joined #bitcoin-core-dev
6502018-01-24T23:59:22  *** petertod1 is now known as petertodd