1 2018-01-31T00:00:56  *** vicenteH has quit IRC
  2 2018-01-31T00:01:37  <jtimon> btw, iirc libbitcoin implemented bip90 as an option despite the complains
  3 2018-01-31T00:02:42  <jtimon> I don't think the option is very interesting (since the result will always be the same unless very bad things happen, just to further note is not bitcoin core specific)
  4 2018-01-31T00:03:12  *** moctost has quit IRC
  5 2018-01-31T00:03:40  <michagogo> Hm, does anyone have any idea why my gitian build is crashing?
  6 2018-01-31T00:06:56  <michagogo> http://paste.ubuntu.com/26492234/
  7 2018-01-31T00:07:13  <michagogo> (tail -n10000 build.log)
  8 2018-01-31T00:08:05  *** Allison19Schinne has quit IRC
  9 2018-01-31T00:08:10  *** Victorsueca has quit IRC
 10 2018-01-31T00:16:48  *** promag has quit IRC
 11 2018-01-31T00:18:30  <MarcoFalke> Just noting that the 0.16 gh branch is not "protecte" like the other branches...
 12 2018-01-31T00:20:54  *** d_t has joined #bitcoin-core-dev
 13 2018-01-31T00:21:19  *** finkan has joined #bitcoin-core-dev
 14 2018-01-31T00:28:06  *** jojeyh has joined #bitcoin-core-dev
 15 2018-01-31T00:28:11  *** PaulCape_ has quit IRC
 16 2018-01-31T00:36:31  *** PaulCapestany has joined #bitcoin-core-dev
 17 2018-01-31T00:39:54  *** d_t has quit IRC
 18 2018-01-31T00:41:26  <MarcoFalke> s/protecte/protected/
 19 2018-01-31T00:50:51  *** kallewoof has quit IRC
 20 2018-01-31T00:50:53  *** ProfMac has joined #bitcoin-core-dev
 21 2018-01-31T00:51:29  *** kallewoof has joined #bitcoin-core-dev
 22 2018-01-31T00:53:07  *** justan0theruser has quit IRC
 23 2018-01-31T00:58:47  *** justanotheruser has joined #bitcoin-core-dev
 24 2018-01-31T00:59:02  *** justanotheruser has joined #bitcoin-core-dev
 25 2018-01-31T01:01:10  *** Dizzle has quit IRC
 26 2018-01-31T01:01:24  *** Camryn27Rolfson has joined #bitcoin-core-dev
 27 2018-01-31T01:03:30  *** finkan has quit IRC
 28 2018-01-31T01:04:26  *** jb55 has joined #bitcoin-core-dev
 29 2018-01-31T01:05:48  *** jojeyh has quit IRC
 30 2018-01-31T01:07:10  *** jojeyh has joined #bitcoin-core-dev
 31 2018-01-31T01:08:50  *** Tennis has quit IRC
 32 2018-01-31T01:15:47  *** Victorsueca has joined #bitcoin-core-dev
 33 2018-01-31T01:18:44  <achow101> Uhh, so it seems like sendtoaddress can sometimes make an invalid/non-standard transaction.. Or maybe my coin selection code somehow messes with that
 34 2018-01-31T01:19:00  <achow101> I'm very confused now
 35 2018-01-31T01:19:31  *** bear_ has quit IRC
 36 2018-01-31T01:19:34  <gmaxwell> invalid in what way?!?!?!?!???!??!?!?!?
 37 2018-01-31T01:19:46  <achow101> 64: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation)
 38 2018-01-31T01:20:23  <achow101> that's the error I get when I try to sendrawtransaction with it
 39 2018-01-31T01:20:43  <achow101> basically what I was doing was sendtoaddress, then gettransaction, then sendrawtransaction the hex
 40 2018-01-31T01:20:58  <achow101> and then that error happened
 41 2018-01-31T01:32:34  *** jamesob has joined #bitcoin-core-dev
 42 2018-01-31T01:37:11  *** james has joined #bitcoin-core-dev
 43 2018-01-31T01:37:35  *** james is now known as Guest13391
 44 2018-01-31T01:37:57  *** Victorsueca has quit IRC
 45 2018-01-31T01:39:29  <achow101> so AFAICT that error means that the signature is being produced incorrectly
 46 2018-01-31T01:42:04  *** Victorsueca has joined #bitcoin-core-dev
 47 2018-01-31T01:42:13  <arubi> so there is a signature in the script \ witness at all?  are you signing something malformed?
 48 2018-01-31T01:45:09  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 49 2018-01-31T01:47:28  *** jojeyh has quit IRC
 50 2018-01-31T01:47:56  <achow101> There's a signature
 51 2018-01-31T01:48:12  <achow101> the transaction _looks_ right, besides the fact that I can't mentally verify signatures
 52 2018-01-31T01:48:41  <arubi> signrawtransaction along with the utxo in json should give a more verbose error about what's wrong
 53 2018-01-31T01:50:21  <arubi> unless it's really all it is and the signature is invalid for the tx..  that's pretty scary
 54 2018-01-31T01:52:18  *** Camryn27Rolfson has quit IRC
 55 2018-01-31T01:59:24  *** Rowena86Larkin has joined #bitcoin-core-dev
 56 2018-01-31T01:59:56  *** belcher has quit IRC
 57 2018-01-31T02:00:56  *** denis2342 has quit IRC
 58 2018-01-31T02:08:33  *** Victorsueca has quit IRC
 59 2018-01-31T02:08:48  *** droark has quit IRC
 60 2018-01-31T02:15:06  <achow101> hmm. It looks like there's a signature hash mis-calculation
 61 2018-01-31T02:15:36  <achow101> the signer signed one sighash but a different sighash was calculated when verifying before the send
 62 2018-01-31T02:15:56  <achow101> I've only observed this on segwit, so I think this may actually be a blocker for 0.16
 63 2018-01-31T02:20:09  *** Victorsueca has joined #bitcoin-core-dev
 64 2018-01-31T02:20:17  <arubi> can you tell which of the hashes is the correct one?
 65 2018-01-31T02:20:19  *** jamesob has quit IRC
 66 2018-01-31T02:20:36  *** jamesob has joined #bitcoin-core-dev
 67 2018-01-31T02:24:16  <achow101> https://github.com/bitcoin/bitcoin/issues/12307
 68 2018-01-31T02:27:09  <arubi> oh cool
 69 2018-01-31T02:29:14  <arubi> achow101, can you paste the payment to this tx please?
 70 2018-01-31T02:29:42  <achow101> what do you mean "payment to"?
 71 2018-01-31T02:29:45  <achow101> Like the input txs?
 72 2018-01-31T02:30:00  <kallewoof> I'd like to see the raw tx hex as well
 73 2018-01-31T02:30:02  <arubi> right, to know the amounts
 74 2018-01-31T02:30:22  <kallewoof> oops it's there nvm
 75 2018-01-31T02:30:23  <arubi> the raw hex for the spend is in the issue, but I wanna see what the sighash is supposed to be
 76 2018-01-31T02:31:00  *** Giszmo has joined #bitcoin-core-dev
 77 2018-01-31T02:32:07  <arubi> oh it does show the amount for the failed one nValue=4.68120500 , probably stopped because it's the first one
 78 2018-01-31T02:32:37  <arubi> ah no it's the output
 79 2018-01-31T02:33:05  <achow101> there's a lot of inputs...
 80 2018-01-31T02:33:25  <achow101> I can drop the wallet file instead and you can go find the transactions yourself
 81 2018-01-31T02:33:40  <arubi> sounds good
 82 2018-01-31T02:35:09  <achow101> updated the issue
 83 2018-01-31T02:35:20  <arubi> cheers
 84 2018-01-31T02:38:24  *** Tyth4n has joined #bitcoin-core-dev
 85 2018-01-31T02:39:40  *** To7 has quit IRC
 86 2018-01-31T02:47:45  *** Tyth4n has quit IRC
 87 2018-01-31T02:49:37  *** cdecker has quit IRC
 88 2018-01-31T02:49:56  *** Murch has quit IRC
 89 2018-01-31T02:50:46  *** cdecker has joined #bitcoin-core-dev
 90 2018-01-31T02:52:17  <kallewoof> newbie question but how would you dump the wallet info from that? :]
 91 2018-01-31T02:52:49  <arubi> I'm getting ba89d6d01bdfd4b611757e38802c5a09255659ae7d2d42ae3f0729e7f261de1f as sighash for the first input..
 92 2018-01-31T02:53:06  <arubi> (not 0.16)
 93 2018-01-31T02:53:18  *** droark has joined #bitcoin-core-dev
 94 2018-01-31T02:53:41  <arubi> kallewoof, you can 'gettransaction' for the txids in the inputs to the one posted
 95 2018-01-31T02:54:00  <arubi> pretty much only need the amounts from there
 96 2018-01-31T02:54:11  <kallewoof> Oh.. I tried listunspent but it was empty. Thanks
 97 2018-01-31T02:56:43  <kallewoof> I'm getting Invalid or non-wallet transaction id. I'm just starting a regtest instance with -datadir set to one containing that wallet.dat file, though.
 98 2018-01-31T02:57:46  <achow101> You have to use 0.16 or mater
 99 2018-01-31T02:57:48  <achow101> *master
100 2018-01-31T02:58:20  <achow101> arubi: that's what the verifier got. it's just byteswapped
101 2018-01-31T02:58:22  <kallewoof> This is master.. (well, as of jan 24)
102 2018-01-31T02:58:47  <arubi> ah!
103 2018-01-31T02:59:02  <achow101> usual byteswap stuff
104 2018-01-31T02:59:26  <achow101> kallewoof: really? It should be in the wallet
105 2018-01-31T02:59:52  <achow101> use decoderawtransaction on the tx hex and then fetch the input tx with gettransaction
106 2018-01-31T03:00:19  <arubi> I'm running this on pre-0.16 on regtest too
107 2018-01-31T03:00:30  <kallewoof> dumpwallet gave me a ton of stuff, but yeah. I did decoderaw and tried to gettx the first input (cf0996c1b356bf7df7ef81d65c6741d5db6058826be47842ab45e18afd36dd03)
108 2018-01-31T03:01:21  <arubi> should work.  sure you're using gettransaction and not getrawtransaction?
109 2018-01-31T03:01:24  <achow101> arubi: if you're using a version of master after september or som ething it should be fine
110 2018-01-31T03:01:57  <kallewoof> Yes, I'm using gettransaction.
111 2018-01-31T03:02:21  <achow101> strange
112 2018-01-31T03:02:23  <arubi> I'm using jl2012's latest bip114 client (vault branch)
113 2018-01-31T03:03:20  <arubi> ah, it's from september
114 2018-01-31T03:03:41  <cfields> achow101: regtest?
115 2018-01-31T03:03:56  <achow101> cfields: yes. from the test framework (which is what my simulator does)
116 2018-01-31T03:03:59  <achow101> s/does/uses
117 2018-01-31T03:04:23  <cfields> achow101: we'll need your chain data :)
118 2018-01-31T03:04:32  <achow101> oh, duh
119 2018-01-31T03:05:30  <achow101> cfields: updated in the issue
120 2018-01-31T03:06:09  <kallewoof> Doh. I put wallet.dat in datadir/ not datadir/regtest/wallets/. Works now.
121 2018-01-31T03:15:38  <achow101> oh shit. I fucked up my coin selection stuff
122 2018-01-31T03:15:42  <achow101> that's the problem, the amount is wrong
123 2018-01-31T03:18:01  <arubi> phew :)
124 2018-01-31T03:22:56  *** echeveria has quit IRC
125 2018-01-31T03:23:23  *** TD-Linux has quit IRC
126 2018-01-31T03:23:23  *** windsok has quit IRC
127 2018-01-31T03:23:48  *** ProfMac has quit IRC
128 2018-01-31T03:24:03  <achow101> I guess this is why I shouldn't suppress exceptions :/
129 2018-01-31T03:24:42  *** echeveria has joined #bitcoin-core-dev
130 2018-01-31T03:24:43  *** TD-Linux has joined #bitcoin-core-dev
131 2018-01-31T03:25:16  *** windsok has joined #bitcoin-core-dev
132 2018-01-31T03:25:25  *** ProfMac has joined #bitcoin-core-dev
133 2018-01-31T03:28:07  *** goatpig has quit IRC
134 2018-01-31T03:34:49  *** victor__ has joined #bitcoin-core-dev
135 2018-01-31T03:35:10  *** jb55 has quit IRC
136 2018-01-31T03:36:24  *** victor__ has quit IRC
137 2018-01-31T03:48:23  *** denis2342 has joined #bitcoin-core-dev
138 2018-01-31T03:54:12  *** jojeyh has joined #bitcoin-core-dev
139 2018-01-31T04:03:17  *** moctost has joined #bitcoin-core-dev
140 2018-01-31T04:04:04  *** jb55 has joined #bitcoin-core-dev
141 2018-01-31T04:04:08  *** dabura667 has joined #bitcoin-core-dev
142 2018-01-31T04:07:16  *** wxss has quit IRC
143 2018-01-31T04:20:18  *** jb55 has quit IRC
144 2018-01-31T04:24:18  *** jb55 has joined #bitcoin-core-dev
145 2018-01-31T04:24:57  *** Krellan has quit IRC
146 2018-01-31T04:27:40  *** jamesob has quit IRC
147 2018-01-31T04:28:04  *** Guest13391 has quit IRC
148 2018-01-31T04:30:47  *** cryptojanitor has joined #bitcoin-core-dev
149 2018-01-31T04:31:58  *** checksauce has joined #bitcoin-core-dev
150 2018-01-31T04:33:13  *** checksauce has joined #bitcoin-core-dev
151 2018-01-31T04:34:48  *** checksau_ has joined #bitcoin-core-dev
152 2018-01-31T04:37:18  *** checksauce has quit IRC
153 2018-01-31T04:38:27  *** jb55 has quit IRC
154 2018-01-31T04:42:40  *** Lynet_ has quit IRC
155 2018-01-31T04:43:32  *** unholymachine has quit IRC
156 2018-01-31T04:54:00  *** mrannanay has joined #bitcoin-core-dev
157 2018-01-31T05:01:51  *** Rowena86Larkin has quit IRC
158 2018-01-31T05:05:12  *** arubi has quit IRC
159 2018-01-31T05:06:15  *** arubi has joined #bitcoin-core-dev
160 2018-01-31T05:10:53  *** arubi has quit IRC
161 2018-01-31T05:10:56  *** arubi_ has joined #bitcoin-core-dev
162 2018-01-31T05:13:05  *** Giszmo has quit IRC
163 2018-01-31T05:14:49  *** arubi_ has quit IRC
164 2018-01-31T05:15:16  *** arubi has joined #bitcoin-core-dev
165 2018-01-31T05:21:13  *** justan0theruser has joined #bitcoin-core-dev
166 2018-01-31T05:22:09  *** justanotheruser has quit IRC
167 2018-01-31T05:30:12  *** flokie has quit IRC
168 2018-01-31T05:30:50  *** arbitrary_guy has quit IRC
169 2018-01-31T05:45:17  *** checksau_ has quit IRC
170 2018-01-31T05:55:47  *** aruns__ has joined #bitcoin-core-dev
171 2018-01-31T05:56:10  *** indistylo has joined #bitcoin-core-dev
172 2018-01-31T05:57:40  *** aruns has joined #bitcoin-core-dev
173 2018-01-31T05:59:31  *** Lauriane29Rolfso has joined #bitcoin-core-dev
174 2018-01-31T06:00:57  *** aruns__ has quit IRC
175 2018-01-31T06:01:23  *** aruns__ has joined #bitcoin-core-dev
176 2018-01-31T06:01:35  *** indistylo has quit IRC
177 2018-01-31T06:21:42  *** ghost43 has quit IRC
178 2018-01-31T06:21:48  *** shesek has joined #bitcoin-core-dev
179 2018-01-31T06:21:57  *** ghost43 has joined #bitcoin-core-dev
180 2018-01-31T06:40:57  *** Lauriane29Rolfso has quit IRC
181 2018-01-31T06:43:14  *** Krellan has joined #bitcoin-core-dev
182 2018-01-31T06:44:08  *** Emcy has joined #bitcoin-core-dev
183 2018-01-31T06:47:22  <michagogo> Dammit. The compiler just keeps segfaulting, somewhere else every time
184 2018-01-31T06:47:40  <gmaxwell> memtest86 time
185 2018-01-31T06:47:45  *** Krellan has quit IRC
186 2018-01-31T06:47:50  <michagogo> D:
187 2018-01-31T06:48:18  <michagogo> Hm, I wonder if shutting down the VM and starting it again might help
188 2018-01-31T06:56:29  <michagogo> gmaxwell: (on the physical machine, right? Or can running it in the VM also be relevant?)
189 2018-01-31T06:59:24  *** Charles26Aufderh has joined #bitcoin-core-dev
190 2018-01-31T07:03:15  <kallewoof> michagogo: i get that if I don't bump the RAM of the VM. esp if i use -j with make.
191 2018-01-31T07:03:41  <michagogo> I thought about that
192 2018-01-31T07:04:01  *** Charles26Aufderh has quit IRC
193 2018-01-31T07:04:04  <michagogo> Took it down from -j5 to -j3, and had htop open
194 2018-01-31T07:04:23  <michagogo> I don’t think it reached 3GB
195 2018-01-31T07:04:35  <michagogo> (The VM has almost 6)
196 2018-01-31T07:06:04  *** Krellan has joined #bitcoin-core-dev
197 2018-01-31T07:07:47  *** Krellan has joined #bitcoin-core-dev
198 2018-01-31T07:08:23  *** indistylo has joined #bitcoin-core-dev
199 2018-01-31T07:08:45  *** aruns has quit IRC
200 2018-01-31T07:08:48  *** aruns__ has quit IRC
201 2018-01-31T07:08:52  *** aruns has joined #bitcoin-core-dev
202 2018-01-31T07:15:04  *** aruns has quit IRC
203 2018-01-31T07:15:19  *** aruns has joined #bitcoin-core-dev
204 2018-01-31T07:15:22  *** aruns__ has joined #bitcoin-core-dev
205 2018-01-31T07:15:30  *** indistylo has quit IRC
206 2018-01-31T07:18:14  *** RubenSomsen has joined #bitcoin-core-dev
207 2018-01-31T07:20:36  *** aruns__ has quit IRC
208 2018-01-31T07:20:56  *** indistylo has joined #bitcoin-core-dev
209 2018-01-31T07:35:18  *** jtimon has quit IRC
210 2018-01-31T07:37:33  *** arowser has joined #bitcoin-core-dev
211 2018-01-31T07:44:19  *** meshcollider has quit IRC
212 2018-01-31T07:54:46  *** Victorsueca has quit IRC
213 2018-01-31T07:56:02  *** Victorsueca has joined #bitcoin-core-dev
214 2018-01-31T07:59:24  *** Ivory52Hartmann has joined #bitcoin-core-dev
215 2018-01-31T08:04:27  *** mrannanay has quit IRC
216 2018-01-31T08:09:06  *** aruns__ has joined #bitcoin-core-dev
217 2018-01-31T08:11:35  *** indistylo has quit IRC
218 2018-01-31T08:11:55  *** aruns has quit IRC
219 2018-01-31T08:12:14  *** indistylo has joined #bitcoin-core-dev
220 2018-01-31T08:27:42  *** ula has quit IRC
221 2018-01-31T08:34:07  *** Ivory52Hartmann has quit IRC
222 2018-01-31T08:34:41  *** nickler has quit IRC
223 2018-01-31T08:36:45  *** nickler has joined #bitcoin-core-dev
224 2018-01-31T08:41:50  *** xabbix has quit IRC
225 2018-01-31T08:44:41  *** dafuq has joined #bitcoin-core-dev
226 2018-01-31T08:59:24  *** Elisha60Jaskolsk has joined #bitcoin-core-dev
227 2018-01-31T09:02:13  *** gelango has joined #bitcoin-core-dev
228 2018-01-31T09:02:35  *** gelango has left #bitcoin-core-dev
229 2018-01-31T09:02:44  *** gelango has joined #bitcoin-core-dev
230 2018-01-31T09:03:10  *** capa66 has quit IRC
231 2018-01-31T09:04:10  *** gelango has quit IRC
232 2018-01-31T09:05:36  *** gelango has joined #bitcoin-core-dev
233 2018-01-31T09:06:03  *** Cogito_Ergo_Sum has quit IRC
234 2018-01-31T09:25:25  *** gelango has quit IRC
235 2018-01-31T09:26:01  *** Krellan has quit IRC
236 2018-01-31T09:27:18  *** Krellan has joined #bitcoin-core-dev
237 2018-01-31T09:30:50  *** gelango has joined #bitcoin-core-dev
238 2018-01-31T09:31:11  *** RubenSomsen has quit IRC
239 2018-01-31T09:36:11  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0295becbf3e...216f9a42e689
240 2018-01-31T09:36:12  <bitcoin-git> bitcoin/master 4c85517 Alex Vear: Add NetBSD build instruction links
241 2018-01-31T09:36:12  <bitcoin-git> bitcoin/master ee5e896 Alex Vear: Organise Linux build instructions to be categorised by distro
242 2018-01-31T09:36:13  <bitcoin-git> bitcoin/master 216f9a4 Wladimir J. van der Laan: Merge #12306: Docs: Improvements to UNIX documentation...
243 2018-01-31T09:37:14  <bitcoin-git> [bitcoin] laanwj closed pull request #12306: Docs: Improvements to UNIX documentation (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/12306
244 2018-01-31T09:38:02  *** d9b4bef9 has quit IRC
245 2018-01-31T09:39:07  *** d9b4bef9 has joined #bitcoin-core-dev
246 2018-01-31T09:40:45  *** promag has joined #bitcoin-core-dev
247 2018-01-31T09:49:13  *** vicenteH has joined #bitcoin-core-dev
248 2018-01-31T09:53:15  *** wxss has joined #bitcoin-core-dev
249 2018-01-31T09:54:16  *** wxss has quit IRC
250 2018-01-31T09:54:38  *** wxss has joined #bitcoin-core-dev
251 2018-01-31T09:56:16  *** aruns has joined #bitcoin-core-dev
252 2018-01-31T09:59:14  *** aruns__ has quit IRC
253 2018-01-31T09:59:18  *** indistylo has quit IRC
254 2018-01-31T09:59:33  *** indistylo has joined #bitcoin-core-dev
255 2018-01-31T09:59:52  *** meshcollider has joined #bitcoin-core-dev
256 2018-01-31T10:06:35  *** Elisha60Jaskolsk has quit IRC
257 2018-01-31T10:07:22  *** p3tr has joined #bitcoin-core-dev
258 2018-01-31T10:13:54  *** aruns has quit IRC
259 2018-01-31T10:14:08  *** aruns has joined #bitcoin-core-dev
260 2018-01-31T10:14:14  *** aruns__ has joined #bitcoin-core-dev
261 2018-01-31T10:14:18  *** indistylo has quit IRC
262 2018-01-31T10:17:35  *** larafale has joined #bitcoin-core-dev
263 2018-01-31T10:18:16  *** aruns has quit IRC
264 2018-01-31T10:18:42  *** aruns has joined #bitcoin-core-dev
265 2018-01-31T10:20:33  *** aruns__ has quit IRC
266 2018-01-31T10:21:07  *** denis2342 has joined #bitcoin-core-dev
267 2018-01-31T10:21:11  *** aruns__ has joined #bitcoin-core-dev
268 2018-01-31T10:22:59  *** aruns__ has joined #bitcoin-core-dev
269 2018-01-31T10:25:51  *** aruns has quit IRC
270 2018-01-31T10:26:08  *** aruns__ has quit IRC
271 2018-01-31T10:29:29  <bitcoin-git> [bitcoin] laanwj opened pull request #12308: contrib: Add support for out-of-tree builds in gen-manpages.sh (master...2018_01_genmanpages_outoftree) https://github.com/bitcoin/bitcoin/pull/12308
272 2018-01-31T10:30:05  *** gelango has quit IRC
273 2018-01-31T10:32:05  *** gelango has joined #bitcoin-core-dev
274 2018-01-31T10:33:40  *** larafale has quit IRC
275 2018-01-31T10:34:26  *** larafale has joined #bitcoin-core-dev
276 2018-01-31T10:36:07  *** gelango has quit IRC
277 2018-01-31T10:36:28  *** gelango has joined #bitcoin-core-dev
278 2018-01-31T10:37:22  *** gelango has quit IRC
279 2018-01-31T10:38:57  *** larafale has quit IRC
280 2018-01-31T10:44:47  *** checksauce has joined #bitcoin-core-dev
281 2018-01-31T10:46:59  *** gelango has joined #bitcoin-core-dev
282 2018-01-31T10:47:19  *** gelango has quit IRC
283 2018-01-31T10:49:29  *** denis2342 has quit IRC
284 2018-01-31T10:49:47  *** promag has quit IRC
285 2018-01-31T10:54:45  *** promag has joined #bitcoin-core-dev
286 2018-01-31T10:55:33  *** promag has quit IRC
287 2018-01-31T10:58:38  *** tryphe_ has joined #bitcoin-core-dev
288 2018-01-31T10:59:23  *** Lavonne24Walker has joined #bitcoin-core-dev
289 2018-01-31T11:01:40  *** tryphe has quit IRC
290 2018-01-31T11:08:28  *** denis2342 has joined #bitcoin-core-dev
291 2018-01-31T11:12:51  *** Guyver2 has joined #bitcoin-core-dev
292 2018-01-31T11:15:17  *** tryphe_ has quit IRC
293 2018-01-31T11:15:41  *** tryphe_ has joined #bitcoin-core-dev
294 2018-01-31T11:27:34  *** jtimon has joined #bitcoin-core-dev
295 2018-01-31T11:28:12  <michagogo> Oh, good, it worked.
296 2018-01-31T11:28:50  <michagogo> Don’t know if it was rebooting the VM, updating vbox, rebooting the host, or some combination
297 2018-01-31T11:30:57  <bitcoin-git> [bitcoin] laanwj opened pull request #12309: doc: Explain how to update chainTxData in release process (master...2018_01_release_process_chaintxstats) https://github.com/bitcoin/bitcoin/pull/12309
298 2018-01-31T11:42:27  *** arbitrary_guy has joined #bitcoin-core-dev
299 2018-01-31T11:50:29  <wumpus> ah yes VMs, aren't they delightful, combining the flakyness of hardware with the labyrinthine complexity of software
300 2018-01-31T11:51:04  <michagogo> Uh, WTF? Build-windows.md has instructions that I’m pretty sure will completely hose any Xenial system
301 2018-01-31T11:51:40  <michagogo> Namely, adding the apt repo for a newer release
302 2018-01-31T11:52:07  <wumpus> unfortunately there is no way to cross-build to windows from xenial otherwise
303 2018-01-31T11:52:43  <michagogo> Maybe there’s a way to just get the new versions of the relevant packages, I don’t know
304 2018-01-31T11:52:50  <wumpus> the mingw-gcc in that ubuntu release is hosed. THere used to be a warning to simply not do that, but to some people that wasn't good enough...
305 2018-01-31T11:53:02  <michagogo> But those instructions will trash the system
306 2018-01-31T11:53:02  *** Krellan has quit IRC
307 2018-01-31T11:53:21  <michagogo> They tell you to apt-get upgrade. With the wrong repos.
308 2018-01-31T11:54:09  <michagogo> wumpus: yeah, I know about that issue
309 2018-01-31T11:54:11  <wumpus> maybe they'd rather break their system than simply admit something is not possible and use a different release
310 2018-01-31T11:54:21  <michagogo> Maybe
311 2018-01-31T11:54:33  <michagogo> But the problem is that we’re telling people to do that
312 2018-01-31T11:54:34  <wumpus> I mean it's windows users, they're doing this in a sandbox that can be nuked and re-instated with one button push
313 2018-01-31T11:54:54  <michagogo> With a little footnote saying “this might cause issues”
314 2018-01-31T11:55:03  <wumpus> also they're probably not doing anything else in these VMs than building bitcoin
315 2018-01-31T11:55:09  <michagogo> Rather than “this is guaranteed to completely break the system”
316 2018-01-31T11:55:18  *** dabura667 has quit IRC
317 2018-01-31T11:55:26  <wumpus> anyhow, feel free to add proper warnings to the document, I've given up on that
318 2018-01-31T11:55:49  <wumpus> it's not that I didn't mention that in reviews but who listens to me, maybe they listen to you
319 2018-01-31T11:56:03  <michagogo> Is there a way to safely get just the newer compiler packages?
320 2018-01-31T11:56:18  <michagogo> Some ppa, backports, something like that?
321 2018-01-31T11:58:39  <wumpus> you could build your own toolchain, I'm partial to crosstool-ng myself as it comes with a nice menu configuration tool
322 2018-01-31T12:00:09  <wumpus> you need some patience but at least you can configure anything you'd ever wanted (and not wanted) to configure about the toolchain, and you're not bound to a certain version of binutils, gcc, libc, etc, that happens to come with your distro
323 2018-01-31T12:01:22  <wumpus> I use this for ARM boards all the time as ubuntu's default cross compilers only target a specific sw/hw combo, but i think it can do mingw-something as well.
324 2018-01-31T12:03:17  *** Krellan has joined #bitcoin-core-dev
325 2018-01-31T12:06:03  <wumpus> of course for a guide it's much easier to just say 'use ubunu 16.10 or higher', but I digress, that's what we already tried...
326 2018-01-31T12:07:03  <wumpus> at least we'll hopefully have 18.04 soon so there's a new LTS that can (hopefully) build working windows executables
327 2018-01-31T12:09:30  *** tryphe_ is now known as tryphe
328 2018-01-31T12:21:30  *** mrannanay has joined #bitcoin-core-dev
329 2018-01-31T12:26:36  *** denis2342 has quit IRC
330 2018-01-31T12:30:06  *** indistylo has joined #bitcoin-core-dev
331 2018-01-31T12:30:55  <michagogo> Yeah
332 2018-01-31T12:31:13  <michagogo> Btw, someone in #ubuntu pointed out that zesty is EOL...
333 2018-01-31T12:31:20  <michagogo> So even those instructions won’t work
334 2018-01-31T12:31:43  <michagogo> I wonder how much trouble it would be to get mingw backported
335 2018-01-31T12:31:51  *** anil_ has joined #bitcoin-core-dev
336 2018-01-31T12:32:01  <anil_> hello
337 2018-01-31T12:32:12  *** anil_ is now known as anil_1524
338 2018-01-31T12:32:16  <michagogo> Hi.
339 2018-01-31T12:33:26  *** AaronvanW has joined #bitcoin-core-dev
340 2018-01-31T12:33:31  <anil_1524> What is the easiest way to install the Berkeley DB dependencies on Debian Stretch?
341 2018-01-31T12:34:35  <wumpus> contrib/install_db4.sh
342 2018-01-31T12:35:41  <wumpus> michagogo: just use 17.10 then...
343 2018-01-31T12:35:44  *** aruns has joined #bitcoin-core-dev
344 2018-01-31T12:36:09  <wumpus> it will be EOL july 2018, but by that time you can upgrade to 18.04
345 2018-01-31T12:36:56  <anil_1524> wumpus: thanks
346 2018-01-31T12:37:03  *** anil_1524 has quit IRC
347 2018-01-31T12:37:45  *** denis2342 has joined #bitcoin-core-dev
348 2018-01-31T12:38:16  <wumpus> I've heard of people here using the 18.04 pre-release dailies but that's really living on the edge
349 2018-01-31T12:38:25  *** indistylo has quit IRC
350 2018-01-31T12:39:13  *** belcher has joined #bitcoin-core-dev
351 2018-01-31T12:44:04  *** AaronvanW has quit IRC
352 2018-01-31T12:44:45  *** AaronvanW has joined #bitcoin-core-dev
353 2018-01-31T12:44:57  <bitcoin-git> [bitcoin] practicalswift closed pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (master...return-early-in-CountWitnessSigOps) https://github.com/bitcoin/bitcoin/pull/10975
354 2018-01-31T12:45:18  *** AaronvanW has quit IRC
355 2018-01-31T12:46:19  *** AaronvanW has joined #bitcoin-core-dev
356 2018-01-31T12:51:16  *** AaronvanW has quit IRC
357 2018-01-31T12:57:17  *** checksauce has quit IRC
358 2018-01-31T12:58:16  *** aruns__ has joined #bitcoin-core-dev
359 2018-01-31T13:00:40  *** aruns has quit IRC
360 2018-01-31T13:07:26  *** Lavonne24Walker has quit IRC
361 2018-01-31T13:09:49  <provoostenator> I'm one of those people living on the edge with 18.04 pre-release. I sometimes fall off the edge :-)
362 2018-01-31T13:10:11  <provoostenator> (in a VM, that I don't really need)
363 2018-01-31T13:10:28  <wumpus> well someone needs to do the testing :)
364 2018-01-31T13:11:27  <provoostenator> Oh and with production c-lightning :-)
365 2018-01-31T13:11:33  <wumpus> the danger of succesfully discouraging people from using pre-release software is that the released software will be less well-tested and thus increases risk for the rest.
366 2018-01-31T13:11:59  <wumpus> this is, FWIW, why I'm not super enthusiastic about #12300
367 2018-01-31T13:12:01  <gribble> https://github.com/bitcoin/bitcoin/issues/12300 | [Build] Adding --enable-mainnet configuration option for running mainnet by jeffrade · Pull Request #12300 · bitcoin/bitcoin · GitHub
368 2018-01-31T13:13:22  <wumpus> yes let's not get started about production c-lighting :)
369 2018-01-31T13:13:59  <provoostenator> That PR does seem a bit pedantic. Anyone who compiles from source should know what they're doing. But adding a flag isn't a show-stopper either.
370 2018-01-31T13:14:32  *** zautomata1 has joined #bitcoin-core-dev
371 2018-01-31T13:15:30  <wumpus> no, it's not, though having experience from having to type --with-incompatible-bdb 20 times a day (okay, overstating a bit) do we want another flag we always need :-)
372 2018-01-31T13:15:38  <provoostenator> What would be more useful for me is being able to have testnet=1 in bitcoin.conf and then launch with -mainnet, because I do make that mistake quite often on my dev account.
373 2018-01-31T13:16:20  <wumpus> I think the long-term idea is to have a -network=<bla> or -chain=<bla> instead of separate options for testnet, mainnet, regtest
374 2018-01-31T13:16:33  *** zautomata has quit IRC
375 2018-01-31T13:16:34  <wumpus> this resolves the case of conflicting options while specifying multiple
376 2018-01-31T13:17:02  <provoostenator> I also want to be able to configure them differently, I believe there's a PR for that, e.g. I don't care about pruning testnet.
377 2018-01-31T13:17:10  <wumpus> I mean if you specify -regtest -testnet -mainnet who is the code to know what you really want?
378 2018-01-31T13:17:42  <provoostenator> That should be an error. Generally commandline flags override options in a config file, right?
379 2018-01-31T13:17:47  <wumpus> it *is* an error
380 2018-01-31T13:18:04  <wumpus> (at least specifying -regtest and -testnet at the same time)
381 2018-01-31T13:18:10  <provoostenator> At least that's how -changetype behave now
382 2018-01-31T13:18:25  <wumpus> but with -chain=... you could use simple override and it would simply work without having to special case them
383 2018-01-31T13:18:47  *** aruns has joined #bitcoin-core-dev
384 2018-01-31T13:18:53  <provoostenator> Yes, I agree -chain=testnet is more sensible than -testnet=1
385 2018-01-31T13:19:37  *** meshcollider has quit IRC
386 2018-01-31T13:19:38  <Sentineo> +1 on that :) I remember I was confused the first time I saw it
387 2018-01-31T13:20:48  *** aruns__ has quit IRC
388 2018-01-31T13:21:00  <bitcoin-git> [bitcoin] rutkov opened pull request #12311:  build: bump version to 0.15.0 (master...master) https://github.com/bitcoin/bitcoin/pull/12311
389 2018-01-31T13:22:06  <bitcoin-git> [bitcoin] fanquake closed pull request #12311:  build: bump version to 0.15.0 (master...master) https://github.com/bitcoin/bitcoin/pull/12311
390 2018-01-31T13:22:33  <wumpus> bump version to 0.15.0? have I traveled back in time?
391 2018-01-31T13:51:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/216f9a42e689...895fbd768f0c
392 2018-01-31T13:51:28  <bitcoin-git> bitcoin/master 7f968ae Wladimir J. van der Laan: doc: Explain how to update chainTxData in release process...
393 2018-01-31T13:51:29  <bitcoin-git> bitcoin/master 895fbd7 MarcoFalke: Merge #12309: doc: Explain how to update chainTxData in release process...
394 2018-01-31T13:52:28  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12309: doc: Explain how to update chainTxData in release process (master...2018_01_release_process_chaintxstats) https://github.com/bitcoin/bitcoin/pull/12309
395 2018-01-31T13:53:42  *** aruns__ has joined #bitcoin-core-dev
396 2018-01-31T13:56:23  *** larafale has joined #bitcoin-core-dev
397 2018-01-31T13:56:27  *** aruns has quit IRC
398 2018-01-31T13:56:42  *** AaronvanW has joined #bitcoin-core-dev
399 2018-01-31T13:59:31  *** Marilie13Nader has joined #bitcoin-core-dev
400 2018-01-31T14:10:59  *** jamesob has joined #bitcoin-core-dev
401 2018-01-31T14:12:48  *** anil_1524 has joined #bitcoin-core-dev
402 2018-01-31T14:13:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
403 2018-01-31T14:14:33  *** Krellan has quit IRC
404 2018-01-31T14:15:32  *** james has joined #bitcoin-core-dev
405 2018-01-31T14:15:56  *** james is now known as Guest3712
406 2018-01-31T14:16:10  *** Krellan has joined #bitcoin-core-dev
407 2018-01-31T14:16:16  *** anil_1524 has quit IRC
408 2018-01-31T14:16:28  *** anil_1524 has joined #bitcoin-core-dev
409 2018-01-31T14:21:26  *** anil_1524 has quit IRC
410 2018-01-31T14:22:41  *** meshcollider has joined #bitcoin-core-dev
411 2018-01-31T14:26:16  *** Giszmo has joined #bitcoin-core-dev
412 2018-01-31T14:27:50  *** promag has joined #bitcoin-core-dev
413 2018-01-31T14:28:04  <promag> jamesob: https://github.com/bitcoin/bitcoin/pull/12305/files#diff-321303fddcf725df060981d626a05df9R38 paths or path?
414 2018-01-31T14:30:13  <jamesob> promag: I'm fine with either
415 2018-01-31T14:30:32  <cfields> jonasschnelli: ping
416 2018-01-31T14:30:40  <promag> jamesob: remove https://github.com/bitcoin/bitcoin/pull/12305/files#diff-3b23ce4d86903a432863cfb3a1f1e547R10?
417 2018-01-31T14:31:10  <jamesob> promag: but the fs namespace is used in that file?
418 2018-01-31T14:33:38  <promag> jamesob: it is, but it's an unnecessary change in your PR. I mean, there are tons of other "missing" includes I guess
419 2018-01-31T14:34:09  <promag> jamesob: if by any chance you have to amend, consider removing it
420 2018-01-31T14:35:41  <jamesob> promag: will do, thanks. If others have similar feelings I'm happy to - just hard to tell when to make small improvements. I figured since this is a fairly low-risk, small change that an addition like that couldn't hurt, but maybe I'm wrong about that.
421 2018-01-31T14:36:11  <jamesob> s/change/changeset
422 2018-01-31T14:39:24  <promag> jamesob: I know that feeling. Usually I do secondary changes "near" the primary changes. I avoid unrelated changes (even simple changes). Maybe submit them in other pulls..
423 2018-01-31T14:40:20  <jamesob> promag: just don't want to become the guy who opens PRs for #include changes (more than I already am ;)
424 2018-01-31T14:41:19  <promag> jamesob: right, just don't do it then :) unless you have to
425 2018-01-31T14:41:34  <arubi> seems that dumpwallet puts base58 addresses in the dump when the wallet is set to bech32 (getnewaddress returns bech32)
426 2018-01-31T14:44:50  *** Giszmo has quit IRC
427 2018-01-31T14:49:23  *** Pavle has joined #bitcoin-core-dev
428 2018-01-31T14:54:32  *** aruns has joined #bitcoin-core-dev
429 2018-01-31T14:55:02  *** aruns__ has quit IRC
430 2018-01-31T14:58:18  *** DDDev has joined #bitcoin-core-dev
431 2018-01-31T14:58:48  <DDDev> Hi there, guys!
432 2018-01-31T14:59:08  <DDDev> Have you ever seen deleted transaction in the blockchain?
433 2018-01-31T15:00:54  <DDDev> For instance, you sent 10BTC and your transaction was unconfirmed for a long period of time. And after that the transaction became removed from the blockchain
434 2018-01-31T15:02:27  <AndyS2> It's not even on the blockchain if it is unconfirmed. It's just in the mempool to be potentially added. There's #bitcoin-dev for more general development questions, btw. This channel is more so for development of Bitcoin Core (an implementation of the protocol).
435 2018-01-31T15:05:28  <DDDev> Thank you, AndyS2
436 2018-01-31T15:06:18  *** DDDev has quit IRC
437 2018-01-31T15:07:00  *** Marilie13Nader has quit IRC
438 2018-01-31T15:09:18  *** aruns has quit IRC
439 2018-01-31T15:14:27  *** mrannanay has quit IRC
440 2018-01-31T15:14:39  *** Pavle has quit IRC
441 2018-01-31T15:16:59  *** unholymachine has joined #bitcoin-core-dev
442 2018-01-31T15:20:48  *** Krellan has quit IRC
443 2018-01-31T15:21:25  *** Krellan has joined #bitcoin-core-dev
444 2018-01-31T15:23:20  *** AaronvanW has quit IRC
445 2018-01-31T15:31:04  *** Krellan has quit IRC
446 2018-01-31T15:36:25  <provoostenator> I just noticed this by chance: #12312
447 2018-01-31T15:36:26  <gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
448 2018-01-31T15:36:57  *** Krellan has joined #bitcoin-core-dev
449 2018-01-31T15:40:54  *** To7 has joined #bitcoin-core-dev
450 2018-01-31T15:41:12  *** Krellan has quit IRC
451 2018-01-31T15:41:26  *** wraithm has joined #bitcoin-core-dev
452 2018-01-31T15:47:20  *** Krellan has joined #bitcoin-core-dev
453 2018-01-31T15:50:25  *** SopaXorzTaker has joined #bitcoin-core-dev
454 2018-01-31T15:59:23  *** Ewell74Mann has joined #bitcoin-core-dev
455 2018-01-31T15:59:40  *** sd_ has joined #bitcoin-core-dev
456 2018-01-31T16:04:17  *** Ewell74Mann has quit IRC
457 2018-01-31T16:04:21  *** Giszmo has joined #bitcoin-core-dev
458 2018-01-31T16:19:11  <arubi> does making dumpwallet use bech32 for the addresses if addresstype is bech32 or p2sh-segwit and base58 if it's legacy sound ok?
459 2018-01-31T16:22:57  *** Giszmo has quit IRC
460 2018-01-31T16:27:17  *** pedrobranco has joined #bitcoin-core-dev
461 2018-01-31T16:33:09  <bitcoin-git> [bitcoin] Schallabeer opened pull request #12313: 0.16 (master...0.16) https://github.com/bitcoin/bitcoin/pull/12313
462 2018-01-31T16:39:27  *** dcousens has quit IRC
463 2018-01-31T16:39:37  *** meshcollider has quit IRC
464 2018-01-31T16:40:04  *** Giszmo has joined #bitcoin-core-dev
465 2018-01-31T16:40:30  *** dcousens has joined #bitcoin-core-dev
466 2018-01-31T16:40:45  <promag> tag #12312 as bug?
467 2018-01-31T16:40:46  <gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
468 2018-01-31T16:59:23  *** Aron81Hahn has joined #bitcoin-core-dev
469 2018-01-31T17:07:11  *** RubenSomsen has joined #bitcoin-core-dev
470 2018-01-31T17:08:33  *** Giszmo has quit IRC
471 2018-01-31T17:09:02  *** Victorsueca has quit IRC
472 2018-01-31T17:09:53  *** Krellan has quit IRC
473 2018-01-31T17:10:14  *** Victorsueca has joined #bitcoin-core-dev
474 2018-01-31T17:11:05  <bitcoin-git> [bitcoin] fivepiece opened pull request #12315: Bech32 addresses in dumpwallet (master...dumpwallet-bech32) https://github.com/bitcoin/bitcoin/pull/12315
475 2018-01-31T17:11:08  *** AaronvanW has joined #bitcoin-core-dev
476 2018-01-31T17:11:20  *** indistylo has joined #bitcoin-core-dev
477 2018-01-31T17:12:10  *** timothy has joined #bitcoin-core-dev
478 2018-01-31T17:20:17  *** Krellan has joined #bitcoin-core-dev
479 2018-01-31T17:24:27  *** Derrekito has joined #bitcoin-core-dev
480 2018-01-31T17:24:35  *** Giszmo has joined #bitcoin-core-dev
481 2018-01-31T17:26:45  *** Chris_Stewart_5 has quit IRC
482 2018-01-31T17:31:13  *** Aron81Hahn has quit IRC
483 2018-01-31T17:42:10  *** RubenSomsen has quit IRC
484 2018-01-31T17:42:17  *** RubenSomsen has joined #bitcoin-core-dev
485 2018-01-31T17:45:41  *** timothy has quit IRC
486 2018-01-31T17:52:39  *** reardencode has joined #bitcoin-core-dev
487 2018-01-31T17:54:46  *** Krellan has quit IRC
488 2018-01-31T17:55:49  *** Krellan has joined #bitcoin-core-dev
489 2018-01-31T17:59:05  *** RubenSomsen has quit IRC
490 2018-01-31T17:59:23  *** Gardner37Bernier has joined #bitcoin-core-dev
491 2018-01-31T18:00:22  *** RubenSomsen has joined #bitcoin-core-dev
492 2018-01-31T18:00:46  *** pedrobranco has quit IRC
493 2018-01-31T18:01:19  *** pedrobranco has joined #bitcoin-core-dev
494 2018-01-31T18:01:59  *** pedrobranco has joined #bitcoin-core-dev
495 2018-01-31T18:04:10  *** Gardner37Bernier has quit IRC
496 2018-01-31T18:07:55  *** jb55 has joined #bitcoin-core-dev
497 2018-01-31T18:14:58  *** Krellan has quit IRC
498 2018-01-31T18:15:53  *** Krellan has joined #bitcoin-core-dev
499 2018-01-31T18:16:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
500 2018-01-31T18:16:47  *** keks_ has joined #bitcoin-core-dev
501 2018-01-31T18:17:45  *** indistylo has quit IRC
502 2018-01-31T18:17:45  <gmaxwell> ugh. I really dislike 12300.
503 2018-01-31T18:18:26  <gmaxwell> If we want to reduce screw up risk we should make the github default branch a release branch; not boobytrap the prerelease software.
504 2018-01-31T18:21:36  <gmaxwell> for the original ask, a developer that doesn't want to mess up their own wallets, could be just as well addressed with a --disable-mainnet configure option that they could setup to normally use.
505 2018-01-31T18:36:24  *** Dizzle has joined #bitcoin-core-dev
506 2018-01-31T18:39:12  <bitcoin-git> [bitcoin] thijstriemstra opened pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316
507 2018-01-31T18:40:55  *** Murch has joined #bitcoin-core-dev
508 2018-01-31T18:42:21  *** vicenteH has quit IRC
509 2018-01-31T18:44:07  <jonasschnelli> gmaxwell: agree
510 2018-01-31T18:46:08  <gmaxwell> achow101: so your belief is that for some input conditions the signer is producing an invalid signature?
511 2018-01-31T18:46:36  *** pedrobranco has quit IRC
512 2018-01-31T18:48:05  *** RubenSomsen has quit IRC
513 2018-01-31T18:50:22  <bitcoin-git> [bitcoin] jnewbery opened pull request #12317: Document method for reviewers to verify chainTxData (master...verify_chainTxData) https://github.com/bitcoin/bitcoin/pull/12317
514 2018-01-31T18:50:59  *** Victorsueca has quit IRC
515 2018-01-31T18:52:14  *** Victorsueca has joined #bitcoin-core-dev
516 2018-01-31T18:52:57  <cfields> gmaxwell / jonasschnelli: I agree as well. If anything, I think that's kinda dangerous as downstreams can just quietly remove the ifdef, and users think they're shielded from mainnet
517 2018-01-31T18:54:52  <cfields> i can see the need for some kind of switch like that, but I'd rather do it in the appropriate place. ie If exposing the wallet to mainnet is scary, then add something there.
518 2018-01-31T18:55:22  *** AaronvanW has quit IRC
519 2018-01-31T18:56:40  *** RubenSomsen has joined #bitcoin-core-dev
520 2018-01-31T18:56:49  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12313: 0.16 (master...0.16) https://github.com/bitcoin/bitcoin/pull/12313
521 2018-01-31T18:59:24  *** Felipe64Satterfi has joined #bitcoin-core-dev
522 2018-01-31T19:03:01  *** Tennis has joined #bitcoin-core-dev
523 2018-01-31T19:12:34  *** adiabat has quit IRC
524 2018-01-31T19:14:34  *** adiabat has joined #bitcoin-core-dev
525 2018-01-31T19:17:50  *** mandric has quit IRC
526 2018-01-31T19:26:07  *** SopaXorzTaker has quit IRC
527 2018-01-31T19:27:18  *** Felipe64Satterfi has quit IRC
528 2018-01-31T19:33:59  *** Giszmo has quit IRC
529 2018-01-31T19:37:07  *** laurentmt has joined #bitcoin-core-dev
530 2018-01-31T19:38:40  *** orenamsalem has joined #bitcoin-core-dev
531 2018-01-31T19:41:11  *** jb55 has quit IRC
532 2018-01-31T19:41:58  *** meshcollider has joined #bitcoin-core-dev
533 2018-01-31T19:46:15  *** shesek has quit IRC
534 2018-01-31T19:51:44  *** dcousens has quit IRC
535 2018-01-31T19:57:19  *** dcousens has joined #bitcoin-core-dev
536 2018-01-31T19:59:28  *** Leonel25Stamm has joined #bitcoin-core-dev
537 2018-01-31T20:02:07  *** shesek has joined #bitcoin-core-dev
538 2018-01-31T20:02:07  *** shesek has joined #bitcoin-core-dev
539 2018-01-31T20:05:20  *** goatpig has joined #bitcoin-core-dev
540 2018-01-31T20:13:31  *** AaronvanW has joined #bitcoin-core-dev
541 2018-01-31T20:18:59  *** laurentmt has quit IRC
542 2018-01-31T20:27:27  *** jamesob has quit IRC
543 2018-01-31T20:32:44  *** Krellan has quit IRC
544 2018-01-31T20:33:53  *** Krellan has joined #bitcoin-core-dev
545 2018-01-31T20:42:32  *** dermoth has quit IRC
546 2018-01-31T20:45:41  *** vicenteH has joined #bitcoin-core-dev
547 2018-01-31T20:47:04  *** merehap has joined #bitcoin-core-dev
548 2018-01-31T20:56:09  *** dermoth has joined #bitcoin-core-dev
549 2018-01-31T20:56:41  *** moctost has quit IRC
550 2018-01-31T20:56:53  *** moctost has joined #bitcoin-core-dev
551 2018-01-31T20:57:08  *** moctost has joined #bitcoin-core-dev
552 2018-01-31T20:58:24  *** Guest3712 has quit IRC
553 2018-01-31T20:58:45  *** Leonel25Stamm has quit IRC
554 2018-01-31T21:00:27  *** cloaks has quit IRC
555 2018-01-31T21:01:52  *** cloaks has joined #bitcoin-core-dev
556 2018-01-31T21:05:39  *** Victorsueca has quit IRC
557 2018-01-31T21:06:47  *** Victorsueca has joined #bitcoin-core-dev
558 2018-01-31T21:09:27  *** AaronvanW has quit IRC
559 2018-01-31T21:10:11  *** eklitzke has quit IRC
560 2018-01-31T21:11:15  *** dund has joined #bitcoin-core-dev
561 2018-01-31T21:15:17  <jtimon> what is this label supposed to mean? https://github.com/bitcoin/bitcoin/labels/good%20first%20issue
562 2018-01-31T21:16:20  <phantomcircuit> jtimon, i assume things someone can work on as their first pr
563 2018-01-31T21:16:47  <jtimon> oh, I see, thanks
564 2018-01-31T21:20:09  *** RubenSomsen has quit IRC
565 2018-01-31T21:21:35  *** Dizzle has quit IRC
566 2018-01-31T21:22:35  *** cloaks has quit IRC
567 2018-01-31T21:25:24  *** eklitzke has joined #bitcoin-core-dev
568 2018-01-31T21:45:51  <mryandao> are there any plans to implement compact filters for bitcoin-core?
569 2018-01-31T21:46:04  <mryandao> to deprecate bip37 bloom filter service?
570 2018-01-31T21:46:18  *** Chris_Stewart_5 has quit IRC
571 2018-01-31T21:49:20  *** dafuq[m] has joined #bitcoin-core-dev
572 2018-01-31T21:50:10  <achow101> gmaxwell: I just screwed up BnB, that's all
573 2018-01-31T21:51:40  *** meshcollider has quit IRC
574 2018-01-31T21:51:57  <jtimon> review begging for https://github.com/bitcoin/bitcoin/pull/12128/files I think it's a simple to review but nice simplification (sorry for the redundancy)
575 2018-01-31T21:53:04  *** dafuq[m] has quit IRC
576 2018-01-31T21:53:18  *** dafuq[m] has joined #bitcoin-core-dev
577 2018-01-31T21:53:18  *** dafuq[m] has joined #bitcoin-core-dev
578 2018-01-31T21:59:22  *** Lolita12Robel has joined #bitcoin-core-dev
579 2018-01-31T22:00:57  *** Murch has quit IRC
580 2018-01-31T22:01:18  *** dafuq[m] has quit IRC
581 2018-01-31T22:02:49  *** Murch has joined #bitcoin-core-dev
582 2018-01-31T22:03:54  *** dafuq[m] has joined #bitcoin-core-dev
583 2018-01-31T22:03:54  *** dafuq[m] has joined #bitcoin-core-dev
584 2018-01-31T22:04:18  *** Lolita12Robel has quit IRC
585 2018-01-31T22:06:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
586 2018-01-31T22:08:41  <gmaxwell> achow101: whew. what did you screw up?
587 2018-01-31T22:09:09  <achow101> gmaxwell: amounts. I was using the effective value of the utxo when signing instead of its actual value
588 2018-01-31T22:09:40  <gmaxwell> doh
589 2018-01-31T22:20:34  *** Murch has quit IRC
590 2018-01-31T22:21:59  *** Murch has joined #bitcoin-core-dev
591 2018-01-31T22:22:52  <jimpo> mryandao: https://github.com/bitcoin/bitcoin/pull/12254. Could use some review if you have time. :-)
592 2018-01-31T22:22:57  *** Chris_Stewart_5 has quit IRC
593 2018-01-31T22:24:17  <gmaxwell> achow101: I'm super glad you're working on BnB again.
594 2018-01-31T22:27:47  *** Tennis has quit IRC
595 2018-01-31T22:42:24  *** keks_ has quit IRC
596 2018-01-31T22:47:19  *** Giszmo has joined #bitcoin-core-dev
597 2018-01-31T22:52:52  <mryandao> how often should I follow up on a pending PR to get it closed?
598 2018-01-31T22:54:03  <mryandao> jimpo: cool! good to see that there'll be less spying going on eventually.
599 2018-01-31T22:54:39  *** Krellan has quit IRC
600 2018-01-31T22:55:18  *** Krellan has joined #bitcoin-core-dev
601 2018-01-31T22:57:17  *** orenamsalem has quit IRC
602 2018-01-31T22:57:30  *** Giszmo has quit IRC
603 2018-01-31T22:59:06  <midnightmagic> What's BnB? :-)
604 2018-01-31T22:59:23  *** Gaylord37Sanford has joined #bitcoin-core-dev
605 2018-01-31T23:01:39  *** Giszmo has joined #bitcoin-core-dev
606 2018-01-31T23:04:38  <gmaxwell> Branch and Bound.  Solvers that can construct changeless transactions.
607 2018-01-31T23:15:28  *** wxss has quit IRC
608 2018-01-31T23:17:58  <midnightmagic> nice.
609 2018-01-31T23:18:01  <midnightmagic> \o/
610 2018-01-31T23:31:48  *** meshcollider has joined #bitcoin-core-dev
611 2018-01-31T23:32:30  *** mlz has quit IRC
612 2018-01-31T23:34:03  *** larafale has quit IRC
613 2018-01-31T23:34:09  *** larafale has joined #bitcoin-core-dev
614 2018-01-31T23:34:55  <bitcoin-git> [bitcoin] Empact opened pull request #12319: Add size checking to CPubKey::IsValid, and prefer key/sig size const references (master...pubkeysize) https://github.com/bitcoin/bitcoin/pull/12319
615 2018-01-31T23:35:06  *** mlz has joined #bitcoin-core-dev
616 2018-01-31T23:37:47  *** wraithm has quit IRC
617 2018-01-31T23:38:27  *** Giszmo has quit IRC
618 2018-01-31T23:44:02  *** AaronvanW has joined #bitcoin-core-dev
619 2018-01-31T23:49:27  *** AaronvanW has quit IRC
620 2018-01-31T23:53:23  *** Guyver2 has quit IRC