12018-02-06T00:09:16  *** FTBCraig has quit IRC
  22018-02-06T00:10:28  *** mandric has quit IRC
  32018-02-06T00:10:30  *** meshcollider has quit IRC
  42018-02-06T00:10:37  *** Cchadwicka has quit IRC
  52018-02-06T00:11:20  *** lnostdal has quit IRC
  62018-02-06T00:11:34  *** Cchadwicka has joined #bitcoin-core-dev
  72018-02-06T00:15:59  *** lnostdal has joined #bitcoin-core-dev
  82018-02-06T00:20:00  *** checksau_ has joined #bitcoin-core-dev
  92018-02-06T00:20:01  *** checksauce has quit IRC
 102018-02-06T00:20:17  *** pgupta has joined #bitcoin-core-dev
 112018-02-06T00:24:50  *** pgupta has quit IRC
 122018-02-06T00:27:36  *** rex_4539 has quit IRC
 132018-02-06T00:29:04  *** promag has joined #bitcoin-core-dev
 142018-02-06T00:30:14  <conman> heh is there a testnet explorer that recognises bech32 addresses? I've mined a few and can't see anything on any explorers
 152018-02-06T00:32:57  *** mandric has joined #bitcoin-core-dev
 162018-02-06T00:33:09  <conman> I guess it doesnt matter if my bitcoind shows it as present
 172018-02-06T00:33:23  *** intcat has quit IRC
 182018-02-06T00:33:51  *** Chris_Stewart_5 has quit IRC
 192018-02-06T00:34:56  *** checksau_ has quit IRC
 202018-02-06T00:35:28  *** checksauce has joined #bitcoin-core-dev
 212018-02-06T00:37:25  *** intcat has joined #bitcoin-core-dev
 222018-02-06T00:38:21  *** pgupta has joined #bitcoin-core-dev
 232018-02-06T00:42:39  *** pgupta has quit IRC
 242018-02-06T00:42:48  <gmaxwell> conman: smartbits shows them like this https://testnet.smartbit.com.au/tx/794bd7016aa9f70eea3138d231c22c981f68badc33ec037c38c356a812dd3958
 252018-02-06T00:44:44  <conman> https://testnet.smartbit.com.au/tx/252b673ff3af4a3282881137d3f3212b30dc758d9b86f38754c36a9a4f67688f
 262018-02-06T00:44:54  <conman> there's one I mined to a tb1 address
 272018-02-06T00:45:02  <conman> seems okay, but it can't decipher the address
 282018-02-06T00:47:01  <conman> does anyone have a sample testnet bech32 script address I can try?
 292018-02-06T00:47:32  *** promag has quit IRC
 302018-02-06T00:48:44  *** Emcy_ has joined #bitcoin-core-dev
 312018-02-06T00:48:54  <conman> oh there are samples online, nm
 322018-02-06T00:50:10  <conman> https://testnet.smartbit.com.au/tx/2f94872811ca3855cb7a5069bf2f4ea75377c3310d47a3ce36c082de19c205c3
 332018-02-06T00:50:14  <conman> there, mined a script one too
 342018-02-06T00:50:21  <conman> great, thanks everyone for your help
 352018-02-06T00:50:39  <gmaxwell> Did you make sure you handle version 0 vs later versions correctly?
 362018-02-06T00:50:53  <conman> no, I only handled v0 for now
 372018-02-06T00:51:24  <gmaxwell> ugh.
 382018-02-06T00:51:27  <gmaxwell> wtf dude.
 392018-02-06T00:51:34  <conman> I'm still coding ?
 402018-02-06T00:51:38  <gmaxwell> oh okay.
 412018-02-06T00:51:39  <gmaxwell> :P
 422018-02-06T00:51:40  <conman> haha
 432018-02-06T00:52:02  <gmaxwell> Back to work!
 442018-02-06T00:52:09  <conman> sir yes sir o\
 452018-02-06T00:52:21  *** Emcy has quit IRC
 462018-02-06T00:56:26  *** pgupta has joined #bitcoin-core-dev
 472018-02-06T00:57:12  <conman> and v > 0 needs 0x50 I was told... just looking to figure out where exactly Mr. 0x50 goes
 482018-02-06T00:58:40  <sipa> conman: BIP173 (https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki) under "The following list gives valid segwit addresses and the scriptPubKey that they translate to in hex" gives you what you need
 492018-02-06T00:59:11  <conman> ty again
 502018-02-06T01:00:44  *** pgupta has quit IRC
 512018-02-06T01:01:49  <conman> are versions > 0 currently valid on the network?
 522018-02-06T01:02:30  <sipa> they're nonstandard, but valid by consensus rules (otherwise introducing a  new version would require a hard fork)
 532018-02-06T01:02:46  <conman> great
 542018-02-06T01:02:48  *** dabura667 has joined #bitcoin-core-dev
 552018-02-06T01:03:02  <sipa> ideally wallets don't need an upgrade to be able to send to future versions, though
 562018-02-06T01:03:22  <conman> sure but I'm not creating a wallet per se
 572018-02-06T01:03:51  *** Emcy has joined #bitcoin-core-dev
 582018-02-06T01:06:04  *** Emcy_ has quit IRC
 592018-02-06T01:07:30  <conman> where does the op_reserved go for v>0 ? After the witness program?
 602018-02-06T01:07:42  <sipa> what op_reserved?
 612018-02-06T01:08:00  <conman> ‎[15:56] ‎<‎luke-jr‎>‎ oh, right, you need to add 0x50 to any witver != 0
 622018-02-06T01:08:18  <sipa> witver 1 = OP_1 + witness program push
 632018-02-06T01:08:26  <sipa> witver 0 = OP_0 + witness program push
 642018-02-06T01:08:27  <sipa> etc
 652018-02-06T01:08:30  <sipa> OP_1 is just 0x51
 662018-02-06T01:08:32  <conman> oh doh
 672018-02-06T01:08:35  <conman> lol
 682018-02-06T01:08:42  <sipa> while OP_0 is 0x00
 692018-02-06T01:08:48  * conman facepalms
 702018-02-06T01:08:58  <conman> thanks, now I know what you mean by add
 712018-02-06T01:09:00  <conman> thanks
 722018-02-06T01:09:02  <sipa> yw
 732018-02-06T01:13:48  *** Giszmo has joined #bitcoin-core-dev
 742018-02-06T01:14:27  *** JackH has quit IRC
 752018-02-06T01:14:28  *** pgupta has joined #bitcoin-core-dev
 762018-02-06T01:16:28  *** satwo has quit IRC
 772018-02-06T01:18:48  *** pgupta has quit IRC
 782018-02-06T01:23:05  *** zautomata1 has joined #bitcoin-core-dev
 792018-02-06T01:25:02  *** zautomata has quit IRC
 802018-02-06T01:27:15  <conman> well I made up a random v1 and it got mined
 812018-02-06T01:27:23  <conman> so that's good I guess
 822018-02-06T01:27:32  <conman> https://testnet.smartbit.com.au/tx/8f3fb2cba3deeb57d9432ca13b03306aac40638a99cce3fc06c6240ca65ac25f
 832018-02-06T01:31:08  <conman> alright, it's a wrap, I've pushed mine-to-bech32 support into my master branch
 842018-02-06T01:32:33  *** pgupta has joined #bitcoin-core-dev
 852018-02-06T01:32:40  <gmaxwell> conman: link the commit.
 862018-02-06T01:32:52  <conman> https://bitbucket.org/ckolivas/ckpool/commits/61513a765b12947fae30535179194b1672dc82b5
 872018-02-06T01:33:38  <conman> the address is first checked against bitcoind
 882018-02-06T01:33:49  <conman> hence why there's no error checking in that code
 892018-02-06T01:36:57  *** pgupta has quit IRC
 902018-02-06T01:46:45  <windsok> conman: this explorer is pretty good too https://tchain.btc.com/2f94872811ca3855cb7a5069bf2f4ea75377c3310d47a3ce36c082de19c205c3
 912018-02-06T01:50:37  *** pgupta has joined #bitcoin-core-dev
 922018-02-06T01:54:56  *** pgupta has quit IRC
 932018-02-06T01:59:08  *** zautomata1 has quit IRC
 942018-02-06T01:59:37  *** zautomata has joined #bitcoin-core-dev
 952018-02-06T02:00:03  *** zautomata has joined #bitcoin-core-dev
 962018-02-06T02:00:04  *** Randolf has joined #bitcoin-core-dev
 972018-02-06T02:06:34  <luke-jr> conman: anything can get mined. the trick is when you go to spend it
 982018-02-06T02:08:41  *** pgupta has joined #bitcoin-core-dev
 992018-02-06T02:09:49  <conman> windsok: thanks :)
1002018-02-06T02:11:50  <conman> didn't know those scumbags had testnet explorer, I couldn't see the link initially
1012018-02-06T02:14:25  *** pgupta has quit IRC
1022018-02-06T02:22:07  <windsok> I'm no fan of bitmain, but I enjoy that explorer
1032018-02-06T02:25:55  <conman> yeah it is actually good
1042018-02-06T02:26:55  *** pgupta has joined #bitcoin-core-dev
1052018-02-06T02:28:30  *** CubicEar_ has quit IRC
1062018-02-06T02:28:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1072018-02-06T02:29:07  *** CubicEarths has joined #bitcoin-core-dev
1082018-02-06T02:31:53  *** pgupta has quit IRC
1092018-02-06T02:33:35  *** CubicEarths has quit IRC
1102018-02-06T02:33:57  *** Randolf has quit IRC
1112018-02-06T02:45:07  *** pgupta has joined #bitcoin-core-dev
1122018-02-06T02:48:12  *** Chris_Stewart_5 has quit IRC
1132018-02-06T02:49:18  *** pgupta has quit IRC
1142018-02-06T02:49:36  *** flokie has joined #bitcoin-core-dev
1152018-02-06T02:56:05  *** AriseChikun has quit IRC
1162018-02-06T02:56:32  *** AriseChikun has joined #bitcoin-core-dev
1172018-02-06T03:03:16  *** Giszmo has quit IRC
1182018-02-06T03:03:18  *** pgupta has joined #bitcoin-core-dev
1192018-02-06T03:03:58  *** Giszmo has joined #bitcoin-core-dev
1202018-02-06T03:08:09  *** pgupta has quit IRC
1212018-02-06T03:18:49  *** Randolf has joined #bitcoin-core-dev
1222018-02-06T03:21:28  *** pgupta has joined #bitcoin-core-dev
1232018-02-06T03:23:32  *** satwo has joined #bitcoin-core-dev
1242018-02-06T03:25:56  *** pgupta has quit IRC
1252018-02-06T03:27:28  *** Murch has quit IRC
1262018-02-06T03:39:38  *** pgupta has joined #bitcoin-core-dev
1272018-02-06T03:40:29  *** CubicEarths has joined #bitcoin-core-dev
1282018-02-06T03:44:20  *** pgupta has quit IRC
1292018-02-06T03:47:13  *** dgenr8 has quit IRC
1302018-02-06T03:48:04  *** dgenr8 has joined #bitcoin-core-dev
1312018-02-06T03:53:53  <jnewbery> I don't know how serious it is, but I've observed a new corrupted double-linked list error in master and v0.16rc2
1322018-02-06T03:53:58  <jnewbery> #12362
1332018-02-06T03:54:00  <gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
1342018-02-06T03:54:43  <jnewbery> I've bisected it to a commit in the last couple of weeks or so
1352018-02-06T03:55:06  <jnewbery> only observed when running multiple multiwallet.py tests in parallel
1362018-02-06T03:55:32  <jnewbery> (or rather, when running multiwallet.py in parallel with other tests)
1372018-02-06T03:56:49  *** meshcollider has joined #bitcoin-core-dev
1382018-02-06T03:57:49  *** pgupta has joined #bitcoin-core-dev
1392018-02-06T04:00:56  *** Krellan has quit IRC
1402018-02-06T04:02:01  *** luke-jr has quit IRC
1412018-02-06T04:02:09  *** pgupta has quit IRC
1422018-02-06T04:02:21  *** luke-jr has joined #bitcoin-core-dev
1432018-02-06T04:11:56  *** belcher has quit IRC
1442018-02-06T04:15:59  *** pgupta has joined #bitcoin-core-dev
1452018-02-06T04:20:05  *** pgupta has quit IRC
1462018-02-06T04:24:46  *** dermoth has quit IRC
1472018-02-06T04:25:18  *** dermoth has joined #bitcoin-core-dev
1482018-02-06T04:34:10  *** pgupta has joined #bitcoin-core-dev
1492018-02-06T04:38:18  *** pgupta has quit IRC
1502018-02-06T04:52:05  <esotericnonsense> hm. has anyone used libjson-rpc-cpp with bitcoind?
1512018-02-06T04:52:18  *** pgupta has joined #bitcoin-core-dev
1522018-02-06T04:52:39  <esotericnonsense> I get a "The response is invalid" exception but it looks like perfectly cromulent json to me
1532018-02-06T04:56:50  *** pgupta has quit IRC
1542018-02-06T04:59:35  <sipa> can you paste it somewhere?
1552018-02-06T04:59:58  <esotericnonsense> https://0bin.net/paste/XIEvc4xwV48k262L#AhFeXj9gcTlR-kcpU10eycgTuRaJ5HvS3TGT31wVyrn
1562018-02-06T05:00:23  <esotericnonsense> the rpc passwords and stuff don't need to be censored btw. :P
1572018-02-06T05:00:56  * esotericnonsense changes it to make that more explicit
1582018-02-06T05:02:11  <esotericnonsense> using basically their example code it just seems to explode.
1592018-02-06T05:06:01  *** Giszmo has quit IRC
1602018-02-06T05:07:12  <esotericnonsense> (same happens for anything, getmininginfo for example, it pulls out the response but raises an exception)
1612018-02-06T05:07:50  <sipa> looks fine to me
1622018-02-06T05:09:10  <esotericnonsense> yeah. i'm trying to figure out where the exception originates from like whether it's trying to parse the json and failing somehow.
1632018-02-06T05:10:30  *** pgupta has joined #bitcoin-core-dev
1642018-02-06T05:15:42  *** pgupta has quit IRC
1652018-02-06T05:16:08  *** mrannanay has joined #bitcoin-core-dev
1662018-02-06T05:17:03  *** Giszmo has joined #bitcoin-core-dev
1672018-02-06T05:19:08  *** cryptojanitor has quit IRC
1682018-02-06T05:21:06  *** Giszmo has quit IRC
1692018-02-06T05:24:05  <esotericnonsense> bah. it's json-rpc 1.0 not 2.0.
1702018-02-06T05:25:07  <esotericnonsense> https://github.com/cinemast/libjson-rpc-cpp/blob/e960bf5c00489dd2451be087ac4f05c9e5a47aa4/src/jsonrpccpp/client/rpcprotocolclient.cpp#L109 this is where it borked. changing to v1.0 client works fine. thanks anyway sipa :)
1712018-02-06T05:28:40  *** pgupta has joined #bitcoin-core-dev
1722018-02-06T05:33:21  *** pgupta has quit IRC
1732018-02-06T05:42:13  *** MrPaz has joined #bitcoin-core-dev
1742018-02-06T05:45:24  *** tryphe has quit IRC
1752018-02-06T05:45:47  *** tryphe has joined #bitcoin-core-dev
1762018-02-06T05:46:52  *** pgupta has joined #bitcoin-core-dev
1772018-02-06T05:51:21  *** pgupta has quit IRC
1782018-02-06T06:05:02  *** pgupta has joined #bitcoin-core-dev
1792018-02-06T06:08:43  *** sengehest has joined #bitcoin-core-dev
1802018-02-06T06:09:30  *** pgupta has quit IRC
1812018-02-06T06:11:18  *** meshcollider has quit IRC
1822018-02-06T06:15:02  *** Cchadwicka has quit IRC
1832018-02-06T06:23:13  *** pgupta has joined #bitcoin-core-dev
1842018-02-06T06:24:31  *** CubicEarths has quit IRC
1852018-02-06T06:27:57  *** pgupta has quit IRC
1862018-02-06T06:29:06  *** pgupta has joined #bitcoin-core-dev
1872018-02-06T06:36:05  *** sengehest has quit IRC
1882018-02-06T06:39:42  *** pgupta has quit IRC
1892018-02-06T06:47:11  *** pgupta has joined #bitcoin-core-dev
1902018-02-06T06:51:45  *** pgupta has quit IRC
1912018-02-06T07:07:46  *** jojeyh has joined #bitcoin-core-dev
1922018-02-06T07:11:36  *** MrPaz has quit IRC
1932018-02-06T07:14:17  *** pgupta has joined #bitcoin-core-dev
1942018-02-06T07:14:42  *** Emcy_ has joined #bitcoin-core-dev
1952018-02-06T07:17:56  *** Emcy has quit IRC
1962018-02-06T07:18:09  *** rex_4539 has joined #bitcoin-core-dev
1972018-02-06T07:18:56  *** pgupta has quit IRC
1982018-02-06T07:19:08  *** Krellan has joined #bitcoin-core-dev
1992018-02-06T07:21:13  *** Krellan has joined #bitcoin-core-dev
2002018-02-06T07:50:17  *** satwo has quit IRC
2012018-02-06T07:51:49  *** flokie has quit IRC
2022018-02-06T07:56:32  *** Amuza has joined #bitcoin-core-dev
2032018-02-06T08:01:51  *** meshcollider has joined #bitcoin-core-dev
2042018-02-06T08:09:14  *** lnostdal has quit IRC
2052018-02-06T08:24:14  *** BashCo_ has quit IRC
2062018-02-06T08:26:06  *** BashCo has joined #bitcoin-core-dev
2072018-02-06T08:30:51  *** pgupta has joined #bitcoin-core-dev
2082018-02-06T08:34:46  *** justan0theruser has quit IRC
2092018-02-06T08:35:46  *** Aliencorpse has quit IRC
2102018-02-06T08:36:20  *** justanotheruser has joined #bitcoin-core-dev
2112018-02-06T08:41:27  *** justanotheruser has quit IRC
2122018-02-06T08:44:24  *** Aliencorpse has joined #bitcoin-core-dev
2132018-02-06T08:45:04  *** pgupta has joined #bitcoin-core-dev
2142018-02-06T08:51:24  *** intcat has quit IRC
2152018-02-06T08:52:06  *** pgupta has quit IRC
2162018-02-06T08:52:22  *** laurentmt has joined #bitcoin-core-dev
2172018-02-06T08:52:34  *** intcat has joined #bitcoin-core-dev
2182018-02-06T08:53:38  *** justanotheruser has joined #bitcoin-core-dev
2192018-02-06T09:02:05  *** Krellan_ has joined #bitcoin-core-dev
2202018-02-06T09:02:26  *** Krellan has quit IRC
2212018-02-06T09:06:02  *** promag has joined #bitcoin-core-dev
2222018-02-06T09:07:43  *** zautomata has quit IRC
2232018-02-06T09:08:56  *** Pavle has joined #bitcoin-core-dev
2242018-02-06T09:12:31  *** laurentmt has quit IRC
2252018-02-06T09:12:46  *** arbitrary_guy has quit IRC
2262018-02-06T09:13:02  <promag> wumpus: is this updated https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Aopen+project%3Abitcoin%2Fbitcoin%2F8+ ?
2272018-02-06T09:13:45  <promag> which is/are more important?
2282018-02-06T09:14:05  <promag> #10740 is wip, not sure if it should be in that list
2292018-02-06T09:14:08  <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
2302018-02-06T09:21:25  *** Krellan_ has quit IRC
2312018-02-06T09:23:42  *** timothy has joined #bitcoin-core-dev
2322018-02-06T09:25:41  *** timothy has joined #bitcoin-core-dev
2332018-02-06T09:26:31  *** berndj has quit IRC
2342018-02-06T09:27:22  *** Krellan has joined #bitcoin-core-dev
2352018-02-06T09:30:39  *** dabura667 has quit IRC
2362018-02-06T09:37:58  <wumpus> promag: no, that hasn't been updated for weeks, as the 0.16 milestone was effectively 'high priority for review', so we'll want to go over it next meeting and determine what still belongs there and what not
2372018-02-06T09:38:35  <wumpus> I agree it's somewhat strange to have a WIP there
2382018-02-06T09:40:23  *** whphhg_ has joined #bitcoin-core-dev
2392018-02-06T09:40:45  *** whphhg has quit IRC
2402018-02-06T09:40:53  <promag> are we done regarding feature freeze?
2412018-02-06T09:41:00  *** whphhg_ is now known as whphhg
2422018-02-06T09:47:12  *** AaronvanW has joined #bitcoin-core-dev
2432018-02-06T09:47:13  <wumpus> yes, 0.16 is forked off
2442018-02-06T09:47:22  <wumpus> so we can merge new features into master, if they're ready
2452018-02-06T09:57:54  *** TheRec has quit IRC
2462018-02-06T10:00:50  *** intcat has quit IRC
2472018-02-06T10:04:27  *** intcat has joined #bitcoin-core-dev
2482018-02-06T10:06:24  <bitcoin-git> [bitcoin] laanwj closed pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
2492018-02-06T10:07:11  *** Victorsueca has quit IRC
2502018-02-06T10:08:21  *** Victorsueca has joined #bitcoin-core-dev
2512018-02-06T10:09:36  <gmaxwell> wumpus: assuming no other issues come up do you think we'll release RC2 as final (now that we know that qt assert is not new and really fringe) or do you think we'd do an RC3 for that alone?
2522018-02-06T10:11:24  *** berndj has joined #bitcoin-core-dev
2532018-02-06T10:11:54  <wumpus> gmaxwell: as it's only a crash on shutdown and happens only in certain circumstances, I'd say we shouldn't hold up the release just for that
2542018-02-06T10:12:32  <gmaxwell> thats my view. it's an assert and it looks like it requires lucky timing and a shutdown when started with reindex.
2552018-02-06T10:12:58  <wumpus> right, an assertion fail, not even a proper 'crash'
2562018-02-06T10:15:41  *** Pavle has quit IRC
2572018-02-06T10:19:27  <gmaxwell> anyone else see a bunch of connections from ?
2582018-02-06T10:19:35  *** laurentmt has joined #bitcoin-core-dev
2592018-02-06T10:19:57  <Sentineo> let me check
2602018-02-06T10:20:39  *** dabura667 has joined #bitcoin-core-dev
2612018-02-06T10:21:03  <Sentineo> gmaxwell: yes, 5
2622018-02-06T10:22:09  <Sentineo> but I see it from tor and all bitcoinj:0.14.5
2632018-02-06T10:22:35  *** dabura667 has quit IRC
2642018-02-06T10:22:50  *** dabura667 has joined #bitcoin-core-dev
2652018-02-06T10:23:16  <esotericnonsense> same
2662018-02-06T10:23:17  *** dabura667 has quit IRC
2672018-02-06T10:23:49  <esotericnonsense> i also have 5
2682018-02-06T10:24:17  *** LeMiner2 has joined #bitcoin-core-dev
2692018-02-06T10:24:24  <gmaxwell> Sentineo: what do you mean 'from tor'?
2702018-02-06T10:24:42  *** promag has quit IRC
2712018-02-06T10:25:58  <wumpus> connections from tor hs would come from
2722018-02-06T10:26:21  <esotericnonsense> i also seem to have a ton of spy nodes or something odd like that lately
2732018-02-06T10:26:36  * wumpus keeps typing listpeers instead of getpeerinfo now, argh
2742018-02-06T10:26:40  *** LeMiner has quit IRC
2752018-02-06T10:26:40  *** LeMiner2 is now known as LeMiner
2762018-02-06T10:27:18  <esotericnonsense> actually perhaps not, i think i'm actually getting inbound peers where before i'd only get like 10 :op
2772018-02-06T10:27:30  <wumpus> gmaxwell: yes, five here on two nodes  checked
2782018-02-06T10:30:16  <wumpus> a .2 .51 .62 .52  .59 b .2  .54 .57 .59. .61
2792018-02-06T10:32:28  <Sentineo> ah true for tor wumpus, but I do see the local address as for all of them.
2802018-02-06T10:32:52  <Sentineo> so that is why I thought tor, but yeh it would come through tor socks ...
2812018-02-06T10:34:17  <gmaxwell> wumpus: interesting, different hosts than I see too.
2822018-02-06T10:34:48  <esotericnonsense> i have 2, 51, 44, 42, 41
2832018-02-06T10:34:55  <Sentineo> not sure why some connections show for addrlocal my public IP, some show and some the ipv6 one.
2842018-02-06T10:34:57  <esotericnonsense> https://esotericnonsense.com/ peers tab
2852018-02-06T10:35:36  <gmaxwell> anyone see any outside of 23.92.36/24 but inside 23.92.32/20 ?
2862018-02-06T10:36:04  <Sentineo> nope
2872018-02-06T10:36:21  <Sentineo> http://node.ispol.sk/#!/overview - just the /24
2882018-02-06T10:36:43  <wumpus> nope, all .36
2892018-02-06T10:37:14  <gmaxwell> I think this is the first time I've added a subnet to my banlist.
2902018-02-06T10:37:19  <Sentineo> 34,32,2,30,29
2912018-02-06T10:41:56  <rabidus> .2, .56, .58, .59, .60
2922018-02-06T10:45:34  <gmaxwell> Updated my banlists:
2932018-02-06T10:45:36  <gmaxwell> https://people.xiph.org/~greg/banlist.cli.txt
2942018-02-06T10:45:39  <gmaxwell> https://people.xiph.org/~greg/banlist.gui.txt
2952018-02-06T10:48:33  <rabidus> entered those, 5 new ip address were banned
2962018-02-06T10:48:56  <gmaxwell> rabidus: you mean 5 got disconnected as a result of loading those?
2972018-02-06T10:49:01  <rabidus> yep
2982018-02-06T10:49:35  <rabidus> i used your list ~6 months ago
2992018-02-06T10:49:54  <gmaxwell> ::nods::
3002018-02-06T10:50:00  <wumpus> esotericnonsense: just curious, what features prevent json rpc 2.0 from working?
3012018-02-06T10:51:23  <Sentineo> is there a list for ipv6 gmaxwell ?
3022018-02-06T10:53:41  *** TheRec has joined #bitcoin-core-dev
3032018-02-06T10:53:57  *** nehan has quit IRC
3042018-02-06T10:54:37  <wumpus> ipv6 nodes could be included in this list, there just aren't any  in it at the moment
3052018-02-06T10:54:41  *** nehan has joined #bitcoin-core-dev
3062018-02-06T10:55:18  <gmaxwell> I don't run v6 nodes currently, so I can't gather data on them.
3072018-02-06T10:56:32  <wumpus> fwiw I have one node on ipv6
3082018-02-06T10:56:51  <esotericnonsense> wumpus: i believe it's the client being strict about the spec
3092018-02-06T10:56:54  <esotericnonsense> wumpus: see http://www.jsonrpc.org/specification#response_object
3102018-02-06T10:57:02  <esotericnonsense> jsonrpc: A String specifying the version of the JSON-RPC protocol. MUST be exactly "2.0".
3112018-02-06T10:57:13  <wumpus> esotericnonsense: sure, ok, but do you know what *specifically* it fails on
3122018-02-06T10:57:23  <wumpus> oh simply the version number
3132018-02-06T10:57:37  <esotericnonsense> there are other bits in the spec that are REQUIRED but at least in the core dev docs they're not REQUIRED (for the requests at least if not the responses)
3142018-02-06T10:57:47  <esotericnonsense> but I know that the developer docs are often outdated
3152018-02-06T10:57:54  <wumpus> can you try to lolpatch that to 2.0 and see if it works?
3162018-02-06T10:58:00  <esotericnonsense> it doesn't even respond with jsonrpc
3172018-02-06T10:58:13  *** zautomata has joined #bitcoin-core-dev
3182018-02-06T10:58:14  <esotericnonsense> i.e. it's not jsonrpc 1.0, it's just not there :P
3192018-02-06T10:58:28  *** zautomata has quit IRC
3202018-02-06T10:58:28  *** zautomata has joined #bitcoin-core-dev
3212018-02-06T10:58:39  <esotericnonsense> i can yeah but not immediately (a lolhack I suppose would be to reply with whatever was in the request :P)
3222018-02-06T10:58:45  <wumpus> we pretty much do 2.0, there might be some small things missing
3232018-02-06T10:59:17  *** Krellan has quit IRC
3242018-02-06T11:00:16  <wumpus> for example features such as batching are 2.0 afaik
3252018-02-06T11:02:28  *** shaowei has joined #bitcoin-core-dev
3262018-02-06T11:03:11  <esotericnonsense> indeed
3272018-02-06T11:03:28  * esotericnonsense now has coffee which was the important bit before trying to rpc2.0ise it
3282018-02-06T11:05:05  *** Emcy has joined #bitcoin-core-dev
3292018-02-06T11:07:11  *** Emcy_ has quit IRC
3302018-02-06T11:11:06  *** meshcollider has quit IRC
3312018-02-06T11:11:45  *** AaronvanW has quit IRC
3322018-02-06T11:15:15  *** Krellan has joined #bitcoin-core-dev
3332018-02-06T11:15:38  *** Pavle has joined #bitcoin-core-dev
3342018-02-06T11:20:25  *** booyah_ has joined #bitcoin-core-dev
3352018-02-06T11:20:55  *** booyah has quit IRC
3362018-02-06T11:21:18  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a30e67d20f7...eaeaa2d0b4e8
3372018-02-06T11:21:18  <bitcoin-git> bitcoin/master c887f87 Clem Taylor: Extend #11583 to include the most common message generated by non-contributing peers (port scanners?)...
3382018-02-06T11:21:19  <bitcoin-git> bitcoin/master eaeaa2d Wladimir J. van der Laan: Merge #12342: Extend #11583 to include "version handshake timeout" message...
3392018-02-06T11:21:25  <esotericnonsense> wumpus: nah that doesn't work. from looking at the code above (github link) it's clear why
3402018-02-06T11:21:45  <esotericnonsense> it interprets the spec very literally. we send error: null when it wants the error field to not exist if there's a result
3412018-02-06T11:22:10  <esotericnonsense> from memory i think we might also send result: null when the error is non-null
3422018-02-06T11:22:19  <bitcoin-git> [bitcoin] laanwj closed pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342
3432018-02-06T11:22:24  * esotericnonsense tries hacking error to not exist ...
3442018-02-06T11:22:41  <wumpus> in the long run we should move toward compliance with the spec, maybe first a command line option (for backwards compatiblity)
3452018-02-06T11:23:35  <esotericnonsense> yes that works
3462018-02-06T11:24:10  <esotericnonsense> lolpatch required to make it work in this specific instance: https://0bin.net/paste/d4-gThuaT2e1ZRk7#rsIjxU2jNyfmuWZHDaM76BRiVYOE723m7sP5vzVILEt
3472018-02-06T11:24:22  *** Krellan has quit IRC
3482018-02-06T11:24:25  <esotericnonsense> i agree, you'd need to track the client version though
3492018-02-06T11:24:56  *** Krellan has joined #bitcoin-core-dev
3502018-02-06T11:26:11  <esotericnonsense> it would have to be a commandline option because I think it would make sense to enforce the restrictions on the client at the same time
3512018-02-06T11:26:53  <wumpus> I mean to moving to strict json rpc 2.0 only, and keep the hack-1.0 compatibility as a command line option for the forseeable future for backwards compatiblity
3522018-02-06T11:27:03  <esotericnonsense> ah sure
3532018-02-06T11:27:44  <esotericnonsense> that might be something I could look at in the next few weeks :)
3542018-02-06T11:28:51  <wumpus> the way it is now is pretty much a historical mistake, but as a lot of software is written against our peculiar json-rpc dialect we can't and shouldn't completely drop it, but having a spec-compliant mode would be great
3552018-02-06T11:30:15  <wumpus> awesome
3562018-02-06T11:31:38  *** whphhg has quit IRC
3572018-02-06T11:31:55  <wumpus> btcd has this option: --rpcquirks             Mirror some JSON-RPC quirks of Bitcoin Core -- NOTE: Discouraged unless interoperability issues need to be worked around   -- O dpm
3582018-02-06T11:32:03  <wumpus> I don't know what it exactly changes
3592018-02-06T11:32:49  *** whphhg has joined #bitcoin-core-dev
3602018-02-06T11:33:56  <esotericnonsense> the JSONRPCReplyObj function seems to encapsulate all the problems if you could assume the client is jsonrpc 2.0
3612018-02-06T11:34:27  <wumpus> ok
3622018-02-06T11:34:28  <esotericnonsense> on the response side at least
3632018-02-06T11:35:07  <esotericnonsense> i guess it's less important to be strict about what clients send you, but then you don't want to later have a 'really really jsonrpc2.0' flag
3642018-02-06T11:35:07  <wumpus> right might be that bitcoin-cli needs changes as well
3652018-02-06T11:35:08  <esotericnonsense> :P
3662018-02-06T11:35:17  <esotericnonsense> yes\
3672018-02-06T11:35:18  <wumpus> haha no
3682018-02-06T11:36:12  * esotericnonsense wonders if bitcoind-ncurses would explode if the server were compliant
3692018-02-06T11:37:11  * esotericnonsense smashes himself in the face with a hammer after remembering how he handles rpc in general
3702018-02-06T11:40:31  *** wxss has joined #bitcoin-core-dev
3712018-02-06T11:45:29  *** AaronvanW has joined #bitcoin-core-dev
3722018-02-06T11:49:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eaeaa2d0b4e8...9a32114626fc
3732018-02-06T11:49:33  <bitcoin-git> bitcoin/master d3a185a Wladimir J. van der Laan: net: Move misbehaving logging to net logging category...
3742018-02-06T11:49:34  <bitcoin-git> bitcoin/master 9a32114 Wladimir J. van der Laan: Merge #12218: net: Move misbehaving logging to net logging category...
3752018-02-06T11:49:46  *** CubicEarths has joined #bitcoin-core-dev
3762018-02-06T11:50:23  <bitcoin-git> [bitcoin] laanwj closed pull request #12218: net: Move misbehaving logging to net logging category (master...2018_01_misbehaving_logging) https://github.com/bitcoin/bitcoin/pull/12218
3772018-02-06T11:53:46  *** AaronvanW has quit IRC
3782018-02-06T11:54:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a32114626fc...c3451483d283
3792018-02-06T11:54:25  <bitcoin-git> bitcoin/master eeeb416 murrayn: Remove suggestion to make cloned repository world-writable for Windows build.
3802018-02-06T11:54:26  <bitcoin-git> bitcoin/master c345148 Wladimir J. van der Laan: Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build....
3812018-02-06T11:54:51  *** AaronvanW has joined #bitcoin-core-dev
3822018-02-06T11:55:13  <bitcoin-git> [bitcoin] laanwj closed pull request #12322: Docs: Remove step making cloned repository world-writable for Windows build. (master...doc_change) https://github.com/bitcoin/bitcoin/pull/12322
3832018-02-06T11:57:07  *** CubicEarths has quit IRC
3842018-02-06T12:02:27  *** shaowei has quit IRC
3852018-02-06T12:08:47  *** booyah_ has quit IRC
3862018-02-06T12:08:57  *** booyah_ has joined #bitcoin-core-dev
3872018-02-06T12:10:51  *** Guyver2 has joined #bitcoin-core-dev
3882018-02-06T12:11:58  *** michagogo has quit IRC
3892018-02-06T12:12:35  *** michagogo has joined #bitcoin-core-dev
3902018-02-06T12:14:35  *** shesek has quit IRC
3912018-02-06T12:19:43  *** mrannanay has quit IRC
3922018-02-06T12:20:39  *** cryptojanitor has joined #bitcoin-core-dev
3932018-02-06T12:23:37  *** shaowei has joined #bitcoin-core-dev
3942018-02-06T12:25:20  *** Pavle has quit IRC
3952018-02-06T12:30:23  *** ken2812221 has quit IRC
3962018-02-06T12:39:26  *** AaronvanW has quit IRC
3972018-02-06T12:39:37  <bitcoin-git> [bitcoin] laanwj closed pull request #12325: Use dynamic_cast for downcasting instead of static_cast. (master...use_dynamic_cast_to_downcast) https://github.com/bitcoin/bitcoin/pull/12325
3982018-02-06T12:39:56  *** AaronvanW has joined #bitcoin-core-dev
3992018-02-06T12:43:33  *** SopaXorzTaker has joined #bitcoin-core-dev
4002018-02-06T12:45:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4012018-02-06T13:03:15  *** larafale has joined #bitcoin-core-dev
4022018-02-06T13:04:55  *** larafale has quit IRC
4032018-02-06T13:05:41  *** larafale has joined #bitcoin-core-dev
4042018-02-06T13:09:57  *** larafale has quit IRC
4052018-02-06T13:18:07  *** Chris_Stewart_5 has quit IRC
4062018-02-06T13:20:52  *** shesek has joined #bitcoin-core-dev
4072018-02-06T13:20:52  *** shesek has joined #bitcoin-core-dev
4082018-02-06T13:27:48  *** SopaXorzTaker has quit IRC
4092018-02-06T13:30:57  *** CubicEarths has joined #bitcoin-core-dev
4102018-02-06T13:30:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4112018-02-06T13:35:18  *** Chris_Stewart_5 has quit IRC
4122018-02-06T13:44:48  *** farmerwampum has quit IRC
4132018-02-06T13:46:52  *** Giszmo has joined #bitcoin-core-dev
4142018-02-06T13:48:03  *** Emcy_ has joined #bitcoin-core-dev
4152018-02-06T13:49:02  *** shesek has quit IRC
4162018-02-06T13:49:37  *** Emcy has quit IRC
4172018-02-06T13:50:00  *** belcher has joined #bitcoin-core-dev
4182018-02-06T13:55:07  *** shesek has joined #bitcoin-core-dev
4192018-02-06T14:00:16  *** promag has joined #bitcoin-core-dev
4202018-02-06T14:15:29  *** shesek has quit IRC
4212018-02-06T14:15:34  *** promag has joined #bitcoin-core-dev
4222018-02-06T14:17:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4232018-02-06T14:20:32  *** AaronvanW has quit IRC
4242018-02-06T14:29:47  *** Krellan has quit IRC
4252018-02-06T14:36:08  *** Krellan has joined #bitcoin-core-dev
4262018-02-06T14:45:02  *** Krellan has quit IRC
4272018-02-06T14:46:32  <bitcoin-git> [bitcoin] conscott opened pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
4282018-02-06T14:50:13  *** Krellan has joined #bitcoin-core-dev
4292018-02-06T14:50:37  *** shesek has joined #bitcoin-core-dev
4302018-02-06T14:50:37  *** shesek has joined #bitcoin-core-dev
4312018-02-06T14:54:50  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3451483d283...88971352f610
4322018-02-06T14:54:51  <bitcoin-git> bitcoin/master faeab66 MarcoFalke: contrib: Replace developer keys with list of pgp fingerprints
4332018-02-06T14:54:51  <bitcoin-git> bitcoin/master fabb72b MarcoFalke: contrib: Remove xpired 522739F6 key
4342018-02-06T14:54:52  <bitcoin-git> bitcoin/master 8897135 Wladimir J. van der Laan: Merge #11909: contrib: Replace developer keys with list of pgp fingerprints...
4352018-02-06T14:55:26  <bitcoin-git> [bitcoin] laanwj closed pull request #11909: contrib: Replace developer keys with list of pgp fingerprints (master...Mf1712-gitianKeysDel) https://github.com/bitcoin/bitcoin/pull/11909
4362018-02-06T15:14:37  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/88971352f610...f6cd41d93e12
4372018-02-06T15:14:38  <bitcoin-git> bitcoin/master a1e1305 James O'Beirne: Clarify help messages for path args to mention datadir prefix...
4382018-02-06T15:14:38  <bitcoin-git> bitcoin/master 5460460 James O'Beirne: Add AbsPathForConfigVal to consolidate datadir prefixing for path args...
4392018-02-06T15:14:39  <bitcoin-git> bitcoin/master f6cd41d Wladimir J. van der Laan: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling...
4402018-02-06T15:15:26  <bitcoin-git> [bitcoin] laanwj closed pull request #12305: [docs] [refactor] Add help messages for datadir path mangling (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305
4412018-02-06T15:17:42  *** SopaXorzTaker has joined #bitcoin-core-dev
4422018-02-06T15:20:30  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4432018-02-06T15:20:30  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4442018-02-06T15:22:53  *** larafale has joined #bitcoin-core-dev
4452018-02-06T15:34:09  *** sugarpuff has quit IRC
4462018-02-06T15:34:26  *** sugarpuff has joined #bitcoin-core-dev
4472018-02-06T15:35:55  *** ken2812221 has joined #bitcoin-core-dev
4482018-02-06T15:40:25  *** cryptojanitor has quit IRC
4492018-02-06T15:48:09  *** promag has quit IRC
4502018-02-06T15:48:50  *** justanotheruser has quit IRC
4512018-02-06T15:49:03  *** ossifrage has joined #bitcoin-core-dev
4522018-02-06T15:50:24  *** justanotheruser has joined #bitcoin-core-dev
4532018-02-06T15:52:16  *** Dizzle has joined #bitcoin-core-dev
4542018-02-06T15:53:21  *** Pavle has joined #bitcoin-core-dev
4552018-02-06T15:53:45  *** Dudley has joined #bitcoin-core-dev
4562018-02-06T15:54:12  <ossifrage>  Has anyone noticed a reduction in the number of connections with v0.16.x? Normally after ~3ish days of uptime I'd be upto 90 or so peers and with the new version I'm having a hard time keeping 60 connections?
4572018-02-06T15:54:30  *** Victorsueca has quit IRC
4582018-02-06T15:55:51  *** Victorsueca has joined #bitcoin-core-dev
4592018-02-06T15:57:36  <Dudley> Should  DEFAULT_WALLET_RBF be set to TRUE in wallet.h for version 0.16?
4602018-02-06T16:02:27  *** shesek has quit IRC
4612018-02-06T16:03:34  <Randolf> ossifrage:  I wonder if some folks have simply stopped running Bitcoin nodes given the recent downturn in price.  Or are you seeing the same number of initial connections as you did before?
4622018-02-06T16:05:07  <ossifrage> Randolf, previously I had no problem hitting ~100 connections in a few days and often >120
4632018-02-06T16:05:21  <ossifrage> Now I'm only hitting 50-60
4642018-02-06T16:06:17  <Randolf> I suppose you've been checking your logs?
4652018-02-06T16:06:39  <adiabat> ossifrage: I've also seen a big dropoff in nodes and also network traffic, down 50% or so in the last 2 weeks
4662018-02-06T16:07:17  <ossifrage> it could just be fall off in price results in a fall off in the number of nodes
4672018-02-06T16:08:34  <Randolf> Markets have been down a lot over the past few weeks (more than two weeks), and so I'm guessing that a number of folks might have chosen to stop running their nodes because of that.  I've certainly seen some chatter about that with other cryptocurrencies too from folks getting out while the markets
4682018-02-06T16:08:34  <Randolf> drop.
4692018-02-06T16:09:09  <Randolf> It could be interesting to find out which countries are seeing the most drops in node runners.
4702018-02-06T16:09:15  <Randolf> ...assuming that's what's happening.
4712018-02-06T16:09:35  <Randolf> It would also be nice to know whether some major ISPs have actively started blocking Bitcoin node traffic.
4722018-02-06T16:09:51  <rabidus> i haven't seen any drop in my node peer count (.fi)
4732018-02-06T16:10:19  <Randolf> rabidus:  Are you using v0.16?
4742018-02-06T16:10:35  <rabidus> ah, sry, no.
4752018-02-06T16:10:55  <Randolf> rabidus:  It's still good to know that you haven't seen a drop.  :)
4762018-02-06T16:11:25  <rabidus> hmmm, well now i'm very curious to test that
4772018-02-06T16:11:33  * Randolf smiles
4782018-02-06T16:12:47  <Randolf> Maybe I'll set up a node too, and let it run for a week.
4792018-02-06T16:12:55  <Randolf> ...at least.
4802018-02-06T16:13:30  <BlueMatt> I belive #12273 needs an 0.16 tag
4812018-02-06T16:13:31  <gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
4822018-02-06T16:15:09  <BlueMatt> wumpus: #12337 has two bugs, the first is a regression (so should likely be tagged 0.16, but should be an easy fix), the second is not a regression, though should also be an easy fix so dunno why we shouldnt just fix it
4832018-02-06T16:15:11  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
4842018-02-06T16:15:25  <Dudley> Command line options help displays   "walletrbf Send transactions with full-RBF opt-in enabled (RPC only, default: 0)" for version 0.16rc2
4852018-02-06T16:15:27  <BlueMatt> #12273 is a regression
4862018-02-06T16:15:29  <gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
4872018-02-06T16:16:42  <wumpus> BlueMatt: we removed the 0.16 tag from 12337, it doesn't warrant doing another r
4882018-02-06T16:16:44  <wumpus> rc
4892018-02-06T16:17:06  <wumpus> (which I also explained in my post there)
4902018-02-06T16:17:08  <BlueMatt> a regression causing a scarry assert on shutdown?
4912018-02-06T16:17:22  <wumpus> it's very rare
4922018-02-06T16:17:31  <wumpus> and it's only an assert, and only on shutdown
4932018-02-06T16:17:39  <BlueMatt> I mean I ran into it like 3 times during testing yesterday
4942018-02-06T16:17:48  <BlueMatt> its only rare if you never quit during startup, afaict
4952018-02-06T16:17:55  <wumpus> yeah...
4962018-02-06T16:18:13  <BlueMatt> (and other stuff probably does merit an rc3, so might as well, imo)
4972018-02-06T16:19:25  <wumpus> yes, if an rc3 turns out to be needed we can include the fix
4982018-02-06T16:20:23  <BlueMatt> #12273 could be rather annoying for a user who doesnt notice...it probably doesnt itself warrant an rc3 but that + the two bugs in 12337 might
4992018-02-06T16:20:25  <gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
5002018-02-06T16:20:29  <BlueMatt> and 12362 may by itself warrant one
5012018-02-06T16:20:54  <wumpus> 12273 affects more than just the tests?
5022018-02-06T16:21:29  <BlueMatt> its a race between eg sendrawtransaction and getrawmempool....someone who does a sendrawtransaction followed by an immediate getrawmempool to...test for something or check fee or something may suddenly start failing
5032018-02-06T16:21:47  <BlueMatt> its not exactly critical, especially since it doesnt effect wallet
5042018-02-06T16:21:56  <wumpus> right, it seems far-fetched
5052018-02-06T16:21:57  *** Amuza has quit IRC
5062018-02-06T16:21:58  <BlueMatt> but its kinda gross
5072018-02-06T16:22:04  <wumpus> needs to be fixed but does not warrant another rc
5082018-02-06T16:22:10  <BlueMatt> agreed (by itself)
5092018-02-06T16:22:47  *** promag has joined #bitcoin-core-dev
5102018-02-06T16:23:34  <wumpus> #12362 is scary though, it's exactly what I was afraid of merging #12266 last minute :/
5112018-02-06T16:23:35  <gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
5122018-02-06T16:23:36  <gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
5132018-02-06T16:24:28  <BlueMatt> yea, its rather surprising to me...something is really sketchy there :(
5142018-02-06T16:25:09  <BlueMatt> I mean this is why I wanted a full cycle of testing on all the parallell/background stuff, turns out even that seems like it wasnt enough :(
5152018-02-06T16:29:51  *** promag has quit IRC
5162018-02-06T16:30:08  <Dudley> Discard my question.     I guess default for walletrbf is different for RPC then the GUI
5172018-02-06T16:31:09  <wumpus> Dudley: yes
5182018-02-06T16:32:47  *** booyah_ is now known as booyah
5192018-02-06T16:40:33  *** Randolf has quit IRC
5202018-02-06T16:42:49  *** bizancio has joined #bitcoin-core-dev
5212018-02-06T16:43:36  *** Murch has joined #bitcoin-core-dev
5222018-02-06T16:53:26  *** Pavle has quit IRC
5232018-02-06T16:56:01  *** Krellan has quit IRC
5242018-02-06T16:59:08  <provoostenator> I'm making a fresh Debian 8 VM for Gitian to see which of the issues that I encountered last week are Debian 9 specific (probably still worth fixing at some point).
5252018-02-06T16:59:41  <provoostenator> (for rc3)
5262018-02-06T17:00:29  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6cd41d93e12...5ad320598f06
5272018-02-06T17:00:29  <bitcoin-git> bitcoin/master 8a6c62b Conor Scott: [tests] Update README after filename change
5282018-02-06T17:00:30  <bitcoin-git> bitcoin/master 5ad3205 Wladimir J. van der Laan: Merge #12363: Update README after filename change...
5292018-02-06T17:00:40  *** Krellan has joined #bitcoin-core-dev
5302018-02-06T17:01:24  <bitcoin-git> [bitcoin] laanwj closed pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
5312018-02-06T17:03:22  <wumpus> provoostenator: yeah it would help a lot if someone worked through that guide and fixed the things that are no longer correct, it's been too long
5322018-02-06T17:03:43  <wumpus> most people who have a working gitian environment dread to touch it again
5332018-02-06T17:03:49  <provoostenator> I already left about 10 issues on the docs repo, but I suspect some of it was Debian 9 related.
5342018-02-06T17:05:07  <wumpus> ok cool
5352018-02-06T17:05:56  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ad320598f06...1462bde767a1
5362018-02-06T17:05:56  <bitcoin-git> bitcoin/master bdb3231 251: Implements a virtual destructor on the BaseRequestHandler class....
5372018-02-06T17:05:57  <bitcoin-git> bitcoin/master 1462bde Wladimir J. van der Laan: Merge #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class....
5382018-02-06T17:06:12  <provoostenator> I'm also looking at clarifying how to build on the VM, but sign on the host machine.
5392018-02-06T17:06:33  <provoostenator> As well as push to github fro the host machine.
5402018-02-06T17:06:41  <bitcoin-git> [bitcoin] laanwj closed pull request #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class. (master...patch/BaseRequestHandler-virtual-dtor) https://github.com/bitcoin/bitcoin/pull/12050
5412018-02-06T17:07:21  <provoostenator> I already have a bash script for that, but need to combine that with the existing script (before or after someone converts that to Python).
5422018-02-06T17:08:32  *** owowo has quit IRC
5432018-02-06T17:08:38  *** AaronvanW has joined #bitcoin-core-dev
5442018-02-06T17:09:08  *** owowo has joined #bitcoin-core-dev
5452018-02-06T17:10:01  *** Krellan has quit IRC
5462018-02-06T17:14:06  <arubi> provoostenator, I'm successfully building w/ debian 9 as the host VM, here are my notes if it helps https://gist.github.com/fivepiece/4c5cd8733973b9821dba9c9c42958209
5472018-02-06T17:15:37  <arubi> it's also possible to set up the bridge stuff using the new `ip` commands, but I wasn't sure if the gitian builder scripts look for ifconfig and friends so I'm also pulling the net-tools package
5482018-02-06T17:16:13  <arubi> one plus is that it doesn't require installing an old vmbuilder as root
5492018-02-06T17:20:41  *** Krellan has joined #bitcoin-core-dev
5502018-02-06T17:27:39  *** Dizzle has quit IRC
5512018-02-06T17:28:55  *** paracyst has quit IRC
5522018-02-06T17:29:07  *** paracyst_ has joined #bitcoin-core-dev
5532018-02-06T17:31:17  *** Krellan has quit IRC
5542018-02-06T17:31:17  *** spinza has quit IRC
5552018-02-06T17:31:46  *** Krellan has joined #bitcoin-core-dev
5562018-02-06T17:34:12  *** paracyst_ has quit IRC
5572018-02-06T17:36:14  *** Krellan has quit IRC
5582018-02-06T17:36:25  *** cryptojanitor has joined #bitcoin-core-dev
5592018-02-06T17:41:18  *** bizancio has quit IRC
5602018-02-06T17:43:33  *** paracyst has joined #bitcoin-core-dev
5612018-02-06T17:46:50  *** Krellan has joined #bitcoin-core-dev
5622018-02-06T17:49:43  *** Amuza has joined #bitcoin-core-dev
5632018-02-06T17:55:58  <BlueMatt> ok, so found the issue in #12362...trying to find minimal patch
5642018-02-06T17:56:00  <gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
5652018-02-06T17:56:05  <BlueMatt> wumpus: you still around? you know this code much better than I
5662018-02-06T17:56:23  <wumpus> BlueMatt: yes
5672018-02-06T17:57:01  <wumpus> (as in still around, not sure about knowing the code better)
5682018-02-06T17:57:03  <BlueMatt> issue is simple: HTTPWorkQueueRun starting in a new thread may take longer to get to the queue->Run() call than it takes for us to go through InterruptHTTPServer(); StopHTTPServer()
5692018-02-06T17:57:14  <BlueMatt> so the thread will start after the underlying queue has been deleted
5702018-02-06T17:57:17  <BlueMatt> resulting in garbage
5712018-02-06T17:57:43  <wumpus> looks like we need a lock
5722018-02-06T17:57:57  <BlueMatt> prior to the commit to move the threadGroup to interrupt later, the only thing between VerifyWallets() was threadGroup.interrupt_all(), which was enough to keep from seeing this
5732018-02-06T17:58:30  <BlueMatt> but once that was removed if VerifyWallets() fails you essentially just immediately call InterruptHTTPServer() and then StopHTTPRPC(), StopREST(), StopRPC() and StopHTTPServer()
5742018-02-06T17:58:34  <BlueMatt> so you just get into a simple race there
5752018-02-06T17:59:10  <wumpus> yes, so when interrupthttpserver is run, we first need to wait that it is actually running
5762018-02-06T17:59:13  <BlueMatt> easy to test for - add a sleep at the top of HTTPWorkQueueRun and run in valgrind
5772018-02-06T17:59:15  <BlueMatt> you'll see it immediately
5782018-02-06T17:59:35  <BlueMatt> yea, just need to somehow pause until stuff is running
5792018-02-06T17:59:53  <BlueMatt> the stupid patch at https://github.com/bitcoin/bitcoin/issues/12362#issuecomment-363503855 apparently works
5802018-02-06T17:59:55  <wumpus> also, queue->run shouldn't run if it is already terminated
5812018-02-06T18:01:33  <BlueMatt> yea, i think that would be an equivalent fix
5822018-02-06T18:01:44  <wumpus> but does this fix the race?
5832018-02-06T18:02:20  *** Krellan has quit IRC
5842018-02-06T18:02:23  <wumpus> there's still a small window where threads_running is incrased but queue->run is not yet executed
5852018-02-06T18:02:38  <BlueMatt> oh yea I mean its not a sufficient fix
5862018-02-06T18:02:40  <BlueMatt> its just a hack for testing
5872018-02-06T18:02:51  <wumpus> right
5882018-02-06T18:03:51  <BlueMatt> wumpus: do you understand the qt init stuff well enough to fix #12337? (it just needs to have its shutdown match bitcoind - Shutdown() should always get called if AppInitMain() gets called, even if it fails)
5892018-02-06T18:03:52  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
5902018-02-06T18:04:12  <BlueMatt> I mean I can do a dirty hack for an rc3 that just does it directly but I dont understand the lifetimes well enough to not break things
5912018-02-06T18:04:14  <wumpus> I lost track of the qt init stuff to be honest, I used to understand it, but a lot changed
5922018-02-06T18:04:19  <BlueMatt> :(
5932018-02-06T18:04:40  <wumpus> oh that part, yes that should be easy
5942018-02-06T18:04:59  <wumpus> it's interesting because it used to be exactly the other way around
5952018-02-06T18:05:01  <BlueMatt> ok, well I'd propose we do that and just fix the 4 outstanding issues and do an rc3, then
5962018-02-06T18:05:18  <BlueMatt> yea, that stuff got confused and bitcoind and qt diverged introducing the bug in 12337 :(
5972018-02-06T18:05:35  <wumpus> I think that switched around a few times
5982018-02-06T18:05:55  <BlueMatt> well also AppInit got split.....
5992018-02-06T18:06:03  <wumpus> that shouldn't change this
6002018-02-06T18:06:32  *** Krellan has joined #bitcoin-core-dev
6012018-02-06T18:06:43  <wumpus> the earlier appinits shouldn't require a shutdown
6022018-02-06T18:06:45  <wumpus> only the last one
6032018-02-06T18:06:54  <BlueMatt> yea, well when there was only one appinit... :p
6042018-02-06T18:06:55  <wumpus> as that is what is executed in the daemon process
6052018-02-06T18:07:11  <wumpus> the other ones are preparation
6062018-02-06T18:07:13  *** Krellan has quit IRC
6072018-02-06T18:07:49  <BlueMatt> so one thing we should maybe consider is a test framework that changes shutdownrequested to just start shutdown after being called N times, and then run for all N 0...inf to make sure we handle all these cases well
6082018-02-06T18:08:05  <BlueMatt> cause we now have, what, 2 issues that would be caught by a test like that
6092018-02-06T18:08:07  <wumpus> yes it definitely needs tests
6102018-02-06T18:08:39  *** spinza has joined #bitcoin-core-dev
6112018-02-06T18:08:45  <wumpus> the initialization sequence and shutdown are really undertested
6122018-02-06T18:13:00  *** Randolf has joined #bitcoin-core-dev
6132018-02-06T18:14:07  *** AaronvanW has quit IRC
6142018-02-06T18:14:44  *** AaronvanW has joined #bitcoin-core-dev
6152018-02-06T18:14:58  <wumpus> so for the queue->Run() I don't understand why interrupting it before the Run is hit is a problem, interrupt should set the stopped flag on the queue, so it should just fall through and exit the thread immediately
6162018-02-06T18:15:50  <wumpus> or does deletion (which should happen in ShutdownHTTPServer, not Interrupt) somehow not wait for the threads to have stopped?
6172018-02-06T18:16:52  <BlueMatt> wumpus: I do not believe ShutdownHTTPServer does any meaningful waiting, no
6182018-02-06T18:17:03  <wumpus> then that is likely the issue, let me see
6192018-02-06T18:17:09  <BlueMatt> yea, I dont think Interrupt is the issue, I think its Shutdown
6202018-02-06T18:17:45  <wumpus> it does workqueue->WaitExit()
6212018-02-06T18:17:52  <wumpus> in Shutdown
6222018-02-06T18:18:32  <BlueMatt> yea, but if the thread hasnt joined (ie is still waiting to call numThreads++) then the wait is null
6232018-02-06T18:18:33  <ryanofsky> #11625 adds some testing for qt init code, fwiw
6242018-02-06T18:18:36  <gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
6252018-02-06T18:19:10  <wumpus> ah apparently it doesn't actually join the thread objects
6262018-02-06T18:19:18  <wumpus> ryanofsky: good!
6272018-02-06T18:20:04  <wumpus> the threads are detached and the handle is thrown away
6282018-02-06T18:20:49  *** neha has quit IRC
6292018-02-06T18:20:52  <BlueMatt> yea
6302018-02-06T18:21:10  <wumpus> ok this is easy to solve
6312018-02-06T18:22:22  <wumpus> will PR in a minute
6322018-02-06T18:24:47  <wumpus> thanks for finding this, I wonder if I introduced this bug or it somehow snuck in when going from boost::thread to std::thread (probably the former)
6332018-02-06T18:25:26  *** AaronvanW has quit IRC
6342018-02-06T18:26:01  *** AaronvanW has joined #bitcoin-core-dev
6352018-02-06T18:28:27  *** Chris_Stewart_5 has quit IRC
6362018-02-06T18:28:47  *** neha has joined #bitcoin-core-dev
6372018-02-06T18:29:09  <BlueMatt> alright, well I propose we fix all 4 bugs here and then rc3
6382018-02-06T18:29:52  <BlueMatt> wait, i may have another....
6392018-02-06T18:30:42  <BlueMatt> yup, ok, 5 bugs
6402018-02-06T18:30:44  *** AaronvanW has quit IRC
6412018-02-06T18:32:36  <bitcoin-git> [bitcoin] laanwj opened pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366
6422018-02-06T18:34:19  *** MrPaz has joined #bitcoin-core-dev
6432018-02-06T18:36:06  *** AaronvanW has joined #bitcoin-core-dev
6442018-02-06T18:37:57  <wumpus> as for qt, it seems it's already supposed to call Shutdown() even if AppInitMain() fails, don't know what goes wrong
6452018-02-06T18:38:30  <BlueMatt> wumpus: [13:15:15] <cfields> BlueMatt: i think i might see the issue
6462018-02-06T18:38:30  <BlueMatt> [13:16:58] <cfields> BlueMatt: BitcoinApplication connects requestedShutdown to shutdown(), but SplashScreen connects it to close()
6472018-02-06T18:38:43  <BlueMatt> [13:17:32] <cfields> so it looks like we should re-route that after AppInitMain has started
6482018-02-06T18:39:21  <wumpus> a signal can be connected to two handlers, I don't see the problem
6492018-02-06T18:40:00  <wumpus> that just makes sure that the splash screen is hidden when the shutdown window is shown
6502018-02-06T18:40:02  <BlueMatt> ahh, well I didnt look into it that deeply, but if Shutdown() is called, nThreadsServicingQueue should be pretty clearly 0
6512018-02-06T18:40:14  <BlueMatt> as it join()s
6522018-02-06T18:40:27  *** AaronvanW has quit IRC
6532018-02-06T18:40:49  <wumpus> I'm fairly sure that this has always worked, when closing during the splash screen the shutdown window is shown and it waits for proper shutdown
6542018-02-06T18:41:09  <wumpus> no idea wtf messed this up...
6552018-02-06T18:43:52  <wumpus> so the assertion is triggered after exiting main()?
6562018-02-06T18:44:04  <BlueMatt> yes
6572018-02-06T18:44:07  <BlueMatt> static-deinit
6582018-02-06T18:45:49  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367
6592018-02-06T18:46:01  <BlueMatt> ^ fixes two fast-shutdown bugs, hopefully with really-simple patches
6602018-02-06T18:46:27  <MarcoFalke> rc2 is basically rc1
6612018-02-06T18:46:41  <MarcoFalke> As we need to give users time to test, there is no downside in rc3
6622018-02-06T18:47:36  *** sengehest has joined #bitcoin-core-dev
6632018-02-06T18:52:18  *** dongcarl has joined #bitcoin-core-dev
6642018-02-06T18:53:36  <dongcarl> Hi all, I've been trying to get gitian on LXC working to no avail. I'm running into the same issues kallewoof ran into on Dec 1st, 2017. where the error is "sudo: unable to resolve host gitian / cannot set terminal process group (1): Inappropriate ioctl for device / no job control in this shell"
6652018-02-06T18:53:54  <dongcarl> I fixed the unable to resolve host error by modifying the /etc/hosts of the base image
6662018-02-06T18:53:54  <wumpus> unable to resolve host is harmless at least
6672018-02-06T18:54:04  <wumpus> that's just a warning
6682018-02-06T18:54:24  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368
6692018-02-06T18:54:25  <BlueMatt> MarcoFalke: ^
6702018-02-06T18:54:34  <wumpus> never saw the others though
6712018-02-06T18:55:16  <dongcarl> wumpus: thanks, it seems like there were case before where this happened as well, e.g. https://github.com/devrandom/gitian-builder/issues/63
6722018-02-06T18:55:24  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12273: rpc: Add back missing cs_main lock in getrawmempool (master...Mf1801-rpcMempoolGetLock) https://github.com/bitcoin/bitcoin/pull/12273
6732018-02-06T18:56:15  <dongcarl> What happens with the error is that I get dropped into a root shell, and when I ctrl-d, a loop of "sudo: unknown user: ubuntu" and "sudo: unable to initialize policy plugin" pops up
6742018-02-06T18:56:18  <BlueMatt> ok, so #12368 + #12367 + #12366 + the qt bug and then rc3? I think all of those except the last are at least super-trivial patches...and at this rate getting an extra week on testing cycles seems to make sense
6752018-02-06T18:56:19  <gribble> https://github.com/bitcoin/bitcoin/issues/12368 | Hold mempool.cs for the duration of ATMP. by TheBlueMatt · Pull Request #12368 · bitcoin/bitcoin · GitHub
6762018-02-06T18:56:21  <gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub
6772018-02-06T18:56:22  <gribble> https://github.com/bitcoin/bitcoin/issues/12366 | http: Join worker threads before deleting work queue by laanwj · Pull Request #12366 · bitcoin/bitcoin · GitHub
6782018-02-06T18:56:50  * dongcarl waits patiently for a savior
6792018-02-06T19:04:55  *** Amuza has quit IRC
6802018-02-06T19:05:00  *** neha has quit IRC
6812018-02-06T19:05:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6822018-02-06T19:06:16  *** neha has joined #bitcoin-core-dev
6832018-02-06T19:06:21  *** laurentmt has quit IRC
6842018-02-06T19:13:31  *** AaronvanW has joined #bitcoin-core-dev
6852018-02-06T19:15:17  <wumpus> dongcarl: is that perhaps with debian 9?
6862018-02-06T19:15:35  <dongcarl> wumpus: the base image is trusty
6872018-02-06T19:15:44  <wumpus> no, I mean the outer VM
6882018-02-06T19:15:56  <dongcarl> I'm on Arch right now
6892018-02-06T19:16:22  <dongcarl> am I understanding this wrong? I thought there were two layers, my laptop (Arch) and the lxc container (Trusty)
6902018-02-06T19:16:23  <wumpus> heh you might be the first that tries running gitian on arch
6912018-02-06T19:16:49  <dongcarl> wumpus: yeah I wanted to make a PR on how to workaround the kinks
6922018-02-06T19:16:55  <provoostenator> dongcarl: I've only used the Debian VM. Not sure if it's worth maintaining documentation for 2 distros.
6932018-02-06T19:17:22  <provoostenator> Although I suppose it would make the scripts more robust.
6942018-02-06T19:17:22  <MarcoFalke> provoostenator: We already have it for fedora as well
6952018-02-06T19:17:24  <dongcarl> provoostenator: I think it'll be nice if the scripts are distro-agnostic
6962018-02-06T19:17:24  <esotericnonsense> bah run debian or whatever in a vm and run the lxc within that. solved. :P
6972018-02-06T19:17:27  <dongcarl> yeah
6982018-02-06T19:17:30  <wumpus> well iI assumed you were following the gitian-building md, it starts out with debian VM in which the LXC based gitian is run
6992018-02-06T19:17:47  <wumpus> it would be nice, but not realistic I think
7002018-02-06T19:17:55  <wumpus> we have lots of trouble keeping it working in just debian
7012018-02-06T19:18:07  <dongcarl> :-/
7022018-02-06T19:18:29  <provoostenator> I'm getting better at it though, having nuked and rebuilt a Gitian VM half a dozen times now.
7032018-02-06T19:18:35  <dongcarl> So I know the zcash people use gitian+vagrant
7042018-02-06T19:18:49  <dongcarl> and vagrant is pretty portable across hosts and drivers
7052018-02-06T19:18:56  <dongcarl> but that's a whole other thing
7062018-02-06T19:19:02  <dongcarl> I think I know where the problem lies...
7072018-02-06T19:19:10  <MarcoFalke> Maybe we can get rid of gitian ...
7082018-02-06T19:19:18  <sipa> in theory there shouldn't be that much dependece on the outer host
7092018-02-06T19:19:25  <sipa> but that's theory...
7102018-02-06T19:19:27  <wumpus> hahaha
7112018-02-06T19:19:28  <wumpus> in theory
7122018-02-06T19:19:46  <MarcoFalke> sipa: The lxc bridge thing usually breaks
7132018-02-06T19:19:58  <sipa> the difference between theory and practice is of course that in theory there is nome, but in practice...
7142018-02-06T19:19:59  *** twoken has quit IRC
7152018-02-06T19:20:00  <wumpus> the lxc setup is quite fragile
7162018-02-06T19:20:06  <MarcoFalke> yeah
7172018-02-06T19:20:32  <wumpus> maybe it's easier with vagrant or another container hoster, I don't know
7182018-02-06T19:20:48  <wumpus> if someone has time to play around with that it'd be appreciated
7192018-02-06T19:21:04  <arubi> vagrant requires virtualbox right?
7202018-02-06T19:21:13  <dongcarl> arubi: no
7212018-02-06T19:21:19  <dongcarl> it can take a lot of drivers
7222018-02-06T19:21:20  <wumpus> I thought it was just another user of linux containers, just like lxc and docker
7232018-02-06T19:21:29  <arubi> oic
7242018-02-06T19:21:34  <arubi> I was using qemu for mine
7252018-02-06T19:21:42  <dongcarl> it's orchestration layer on top of multiple drivers, lxc, qemu, etc
7262018-02-06T19:21:49  <arubi> oh cool
7272018-02-06T19:21:50  <dongcarl> quite easy to write extensions
7282018-02-06T19:22:06  <wumpus> that sounds like another layer of complexity
7292018-02-06T19:22:32  <dongcarl> wumpus: right, that's why I don't know if people would want vagrant
7302018-02-06T19:22:37  <wumpus> the problem is that lxc is hard to set up, so switch to something that is another abstraction layer over multiple kinds of virtualization, just like gitian is already trying to be
7312018-02-06T19:22:43  <dongcarl> wumpus: but it's quite well-tested and easy to set up
7322018-02-06T19:23:19  <wumpus> gitian as-is can also be used with qemu, lxc or even virtualbox (though no one is doing the latter anymore since Gavin left, I think)
7332018-02-06T19:23:19  <arubi> maybe aboriginal linux -> mkroot -> build? :P
7342018-02-06T19:23:38  <dongcarl> wumpus: I think the end goal is for gitian to target vagrant, and for vagrant to handle interacting with the drivers
7352018-02-06T19:23:45  <dongcarl> which would make gitian work much easier
7362018-02-06T19:24:04  <dongcarl> anyways, I'll play around with it and see if it actually delivers
7372018-02-06T19:24:17  <dongcarl> (or just makes things more complicated)
7382018-02-06T19:24:54  *** twoken has joined #bitcoin-core-dev
7392018-02-06T19:25:00  <wumpus> right, that could work I guess
7402018-02-06T19:25:19  *** sengehest has quit IRC
7412018-02-06T19:26:18  <dongcarl> quick question: is anyone allowed to submit their gitian sigs or just a limited group of people?
7422018-02-06T19:27:00  <sipa> dongcarl: if you plan to regularly dongitian builds foe bitcoin core releases, you're very mufh encouraged to upload your key and do so:)
7432018-02-06T19:27:22  <sipa> that n between do and gitian is a typo, i swear!
7442018-02-06T19:27:37  <dongcarl> sipa: I'm definitely going to name my PR branch dongitian now ;-)
7452018-02-06T19:27:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
7462018-02-06T19:28:58  <wumpus> everyone is allowed to submit gitian sigs, the more the better
7472018-02-06T19:30:56  <dongcarl> <3
7482018-02-06T19:32:20  <wumpus> the only requirement is that you get the build working :)
7492018-02-06T19:33:34  <BlueMatt> wumpus: did you have any idea why the qt shit isnt calling Shutdown() reliably or should I try to decipher qt
7502018-02-06T19:33:55  <wumpus> no, I have no idea right now
7512018-02-06T19:33:58  <BlueMatt> k
7522018-02-06T19:34:07  <wumpus> from what I see it should simply work
7532018-02-06T19:36:25  *** jamesob has joined #bitcoin-core-dev
7542018-02-06T19:37:04  <cfields> BlueMatt: see my last comment on that ticket, I think I'm in the right ballpark
7552018-02-06T19:37:18  <BlueMatt> cfields: wumpus indicated that didnt seem likely
7562018-02-06T19:37:25  <cfields> though admittedly, I tried a million theories and probably crossed myself up in the process
7572018-02-06T19:37:26  <cfields> oh?
7582018-02-06T19:37:28  <BlueMatt> lol well I currently cant build qt due to the moc bug, so...ugh
7592018-02-06T19:37:41  <jnewbery> wumpus: change looks good. I can't reproduce 12362 with your PR
7602018-02-06T19:37:44  <cfields> eh? still?
7612018-02-06T19:37:45  <wumpus> cfields had a different theory there, I haven't checked that one
7622018-02-06T19:38:15  <wumpus> jnewbery: great!
7632018-02-06T19:38:30  *** finkan has joined #bitcoin-core-dev
7642018-02-06T19:38:38  <BlueMatt> cfields: well I never found any resolution to it? moc doesnt build bitcoin-qt right now....no idea why
7652018-02-06T19:39:24  <wumpus> cfields: just that the one about re-attaching the signal was not correct, because it's perfectly valid to attach multiple listeners to a signal (or did I misunderstand what you meant?)
7662018-02-06T19:39:29  <BlueMatt> cfields: is it just me or is the issue simply that BitcoinCore::initialize() calls initializeResult(false) if AppInitMain() fails, which calls quit() directly instead of calling shutdown() (which would call Interrupt(), Shutdown(), and then shutdownResult() which calls quit())?
7672018-02-06T19:39:43  <wumpus> quit() just exits the main loop
7682018-02-06T19:39:54  <BlueMatt> yes, but we thus wont call Shutdown(), I think
7692018-02-06T19:39:56  <wumpus> after that it starts the shutdown sequence in a new main loop
7702018-02-06T19:39:59  <BlueMatt> oh
7712018-02-06T19:40:04  <wumpus> after showing the shutdown window
7722018-02-06T19:40:21  <BlueMatt> funny because shutdown() will call Interrupt() and then Shutdown() and then quit()
7732018-02-06T19:40:32  <wumpus> that should just work, I tested it a zillion times
7742018-02-06T19:40:36  <wumpus> yes it calls quit again
7752018-02-06T19:40:51  <wumpus> to exit the new mainloop (which handles exiting)
7762018-02-06T19:40:51  <BlueMatt> hmm, ok, well I guess I'm just confused
7772018-02-06T19:45:04  <wumpus> FWIW it's structured like this because existing the main window will exit the main loop, so we need a new main loop instance to handle the shutdown window while it's shutting down (in the background). There's certainly different ways to do it, but this used to work at least.
7782018-02-06T19:46:11  *** cryptojanitor has quit IRC
7792018-02-06T19:46:28  <BlueMatt> well I'll debug moc a bit more and see if I can get that working again
7802018-02-06T19:47:05  *** dcousens has quit IRC
7812018-02-06T19:47:58  <cfields> BlueMatt: the problem as i saw it was that quit() is called _both_ by the failed AppInitMain(), as well as when it gets the shutdown signal.
7822018-02-06T19:48:17  *** dcousens has joined #bitcoin-core-dev
7832018-02-06T19:48:18  <cfields> I can only defer to wumpus as to whether that's an issue or not.
7842018-02-06T19:49:16  *** laurentmt has joined #bitcoin-core-dev
7852018-02-06T19:49:42  <cfields> but yes, in all of my tests, exit does wait on the shutdown procedure to finish. I can't force any other result :\
7862018-02-06T19:50:09  <wumpus> cfields: wait, we don't stop the shutdown poll timer while shutting down?
7872018-02-06T19:50:19  <cfields> hmm?
7882018-02-06T19:50:42  *** Krellan has joined #bitcoin-core-dev
7892018-02-06T19:50:58  <wumpus> BitcoinGUI::detectShutdown()
7902018-02-06T19:51:08  *** SopaXorzTaker has quit IRC
7912018-02-06T19:51:17  <wumpus> does that run while it's in the second main loop (while the shutdown window is visible)?
7922018-02-06T19:51:46  <wumpus> if so it will prematurely end that loop becuase, yes, it's shut down
7932018-02-06T19:52:20  <cfields> wumpus: ugh, no clue. I didn't even look at that.
7942018-02-06T19:52:58  <wumpus> cfields: I thought that's what you mean with 'when it gets the shutdown signal'
7952018-02-06T19:53:27  *** owowo has quit IRC
7962018-02-06T19:54:07  <wumpus> the other one (in shutdownResult) is for *after Shutdown() finished* so that's ok
7972018-02-06T19:54:34  <wumpus> and the one in initializeResult() is ok too, it means it goes into the shutdown sequence
7982018-02-06T19:54:48  <wumpus> but the timer might create such a weird race issue
7992018-02-06T19:55:45  <wumpus> ah, pollShutdownTimer is stopped
8002018-02-06T19:55:51  <wumpus> in requestShutdown
8012018-02-06T19:56:32  <wumpus> no, that should be ok
8022018-02-06T19:58:54  *** owowo has joined #bitcoin-core-dev
8032018-02-06T20:00:05  <cfields> wumpus: ah, so the timer sees StartShutdown() and fires requestedShutdown(). I see. I thought that was coming from the close button. So shutdown() isn't an overridden qt function?
8042018-02-06T20:00:37  <wumpus> cfields: no :)
8052018-02-06T20:01:07  <cfields> heh ok
8062018-02-06T20:01:08  <wumpus> shutdown() is just the background thread function that actually calls Interrupt() and Shutdown()
8072018-02-06T20:02:25  <wumpus> this is bound to the signal requestedShutdown(), coming from the GUI thread
8082018-02-06T20:02:29  <cfields> right. I know we call it, but I thought qt emitted it too as some life-cycle callback
8092018-02-06T20:02:49  *** Pavle has joined #bitcoin-core-dev
8102018-02-06T20:03:10  <cfields> yes, I have a much better idea now, thanks
8112018-02-06T20:04:27  *** timothy has quit IRC
8122018-02-06T20:05:18  *** mmgen has joined #bitcoin-core-dev
8132018-02-06T20:09:42  *** Krellan has quit IRC
8142018-02-06T20:14:13  *** promag has joined #bitcoin-core-dev
8152018-02-06T20:18:52  *** promag has quit IRC
8162018-02-06T20:22:29  <dongcarl> If anyone has a working LXC Trusty gitian container, could they show me `ls -la /dev/tty*'?
8172018-02-06T20:30:06  *** promag has joined #bitcoin-core-dev
8182018-02-06T20:30:40  *** Cogito_Ergo_Sum has quit IRC
8192018-02-06T20:31:38  <arubi> dongcarl, are you running a nested lxc then?  lxc host and gitian builder lxc inside it?  if so fwiw it's not so straight forward
8202018-02-06T20:35:05  *** promag has quit IRC
8212018-02-06T20:38:52  *** Krellan has joined #bitcoin-core-dev
8222018-02-06T20:40:04  *** promag has joined #bitcoin-core-dev
8232018-02-06T20:42:06  <arubi> if anybody's up for it, please kill the current running #25110 travis job.  it's obsolete a waste to keep folks waiting
8242018-02-06T20:42:07  <gribble> https://github.com/bitcoin/bitcoin/issues/25110 | HTTP Error 404: Not Found
8252018-02-06T20:43:42  <sipa> do you have URL?
8262018-02-06T20:43:55  <arubi> sipa, https://travis-ci.org/bitcoin/bitcoin/builds/338165077
8272018-02-06T20:44:32  *** cheese_ has quit IRC
8282018-02-06T20:44:33  *** cryptojanitor has joined #bitcoin-core-dev
8292018-02-06T20:45:34  *** gribble has quit IRC
8302018-02-06T20:47:46  *** meshcollider has joined #bitcoin-core-dev
8312018-02-06T20:53:11  *** gribble has joined #bitcoin-core-dev
8322018-02-06T20:56:16  <sipa> arubi: done
8332018-02-06T20:56:26  <arubi> cheers
8342018-02-06T21:01:56  *** timothy has joined #bitcoin-core-dev
8352018-02-06T21:07:20  *** timothy has quit IRC
8362018-02-06T21:13:30  *** mmgen has quit IRC
8372018-02-06T21:18:27  *** laurentmt has quit IRC
8382018-02-06T21:21:44  *** wunpunch has joined #bitcoin-core-dev
8392018-02-06T21:23:29  *** arubi has quit IRC
8402018-02-06T21:26:57  *** finkan has quit IRC
8412018-02-06T21:28:55  *** arubi has joined #bitcoin-core-dev
8422018-02-06T21:32:40  <BlueMatt> MarcoFalke: you can just close #12365 its a launchpad security issue that launchpad appears to give 0 fucks about fixing
8432018-02-06T21:32:42  <gribble> https://github.com/bitcoin/bitcoin/issues/12365 | Add ppa:bitcoin/bitcoin repository on linux problem · Issue #12365 · bitcoin/bitcoin · GitHub
8442018-02-06T21:32:47  <BlueMatt> yay ubuntu dgaf about security, apparently
8452018-02-06T21:32:59  <BlueMatt> well, i guess we knew that
8462018-02-06T21:33:35  <sipa> dgaf?
8472018-02-06T21:33:40  <BlueMatt> dont give a fuck
8482018-02-06T21:33:54  <dongcarl> (kids these days)
8492018-02-06T21:35:39  <dongcarl> arubi: no, it's just that I've isolated the problem down to the fact that 'sudo lxc-execute -n gitian -f var/lxc.config -- bash' doesn't work
8502018-02-06T21:35:52  <dongcarl> it says 'bash: cannot set terminal process group (1): Inappropriate ioctl for device'
8512018-02-06T21:36:11  <dongcarl> when i do s/bash/sh/
8522018-02-06T21:36:20  <dongcarl> it says 'sh: 0: can't access tty; job control turned off'
8532018-02-06T21:36:28  <dongcarl> so something's wrong with tty somewhere...
8542018-02-06T21:37:31  <arubi> I see, sorry, I didn't get this error here
8552018-02-06T21:37:55  <dongcarl> I think it's to do with me running a newer version of lxc
8562018-02-06T21:38:12  <dongcarl> it complains about the config file being an old format too and I had to look at what key names changed
8572018-02-06T21:39:00  <arubi> oh man that sounds like a lot of work once non bleeding edge os's are updated to newer lxc..
8582018-02-06T21:39:14  <dongcarl> arubi: yup, which is why I'm starting now...
8592018-02-06T21:39:23  <arubi> good luck
8602018-02-06T21:39:30  <dongcarl> <3
8612018-02-06T21:42:39  *** Dudley has quit IRC
8622018-02-06T21:47:57  *** Chris_Stewart_5 has quit IRC
8632018-02-06T22:01:01  *** promag has joined #bitcoin-core-dev
8642018-02-06T22:05:48  *** jamesob has quit IRC
8652018-02-06T22:08:51  *** Pavle has quit IRC
8662018-02-06T22:13:05  <BlueMatt> cfields: were you ever able to materially reproduce #12337?
8672018-02-06T22:13:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
8682018-02-06T22:13:51  <cfields> BlueMatt: no :(
8692018-02-06T22:14:17  <BlueMatt> you "killed" by just closing window?
8702018-02-06T22:14:18  <cfields> BlueMatt: i can confirm that Shutdown() wasn't called though
8712018-02-06T22:14:29  <cfields> yep
8722018-02-06T22:15:25  <cfields> BlueMatt: I tried all kinds of sleeps/early returns to try to hit it again, but no luck
8732018-02-06T22:15:29  *** rex_4539 has quit IRC
8742018-02-06T22:17:18  <cfields> tail of log:
8752018-02-06T22:17:21  <cfields> 2018-02-02 20:39:50 Upgrading utxo-set database...
8762018-02-06T22:17:22  <cfields> 2018-02-02 20:39:50 [0%]...[CANCELLED].
8772018-02-06T22:17:22  <cfields> 2018-02-02 20:39:50 Shutdown requested. Exiting
8782018-02-06T22:19:06  <bitcoin-git> [bitcoin] akx20000a opened pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371
8792018-02-06T22:19:25  <BlueMatt> hmm, k
8802018-02-06T22:20:32  <promag> BlueMatt: https://github.com/bitcoin/bitcoin/pull/12368#issuecomment-363584547
8812018-02-06T22:20:35  *** arubi has quit IRC
8822018-02-06T22:21:07  *** arubi has joined #bitcoin-core-dev
8832018-02-06T22:22:26  *** Lynet has joined #bitcoin-core-dev
8842018-02-06T22:24:12  <BlueMatt> promag: the validationinterface background-thread stuff breaks lock-order =D
8852018-02-06T22:25:19  *** Tennis has joined #bitcoin-core-dev
8862018-02-06T22:34:41  <promag> BlueMatt: got it, forgot about that X)
8872018-02-06T22:44:08  *** rex_4539 has joined #bitcoin-core-dev
8882018-02-06T22:50:05  *** Victorsueca has quit IRC
8892018-02-06T22:51:18  *** Victorsueca has joined #bitcoin-core-dev
8902018-02-06T22:59:01  *** meshcollider has quit IRC
8912018-02-06T23:03:20  *** dongcarl has quit IRC
8922018-02-06T23:07:04  *** promag has quit IRC
8932018-02-06T23:07:50  <BlueMatt> ugh, alright cfields I give up :/ at least I found #12372 in the process
8942018-02-06T23:07:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12372 | Qt Splash Screen is deleted (and accesses wallet) after Shutdown() (and wallets are deleted). · Issue #12372 · bitcoin/bitcoin · GitHub
8952018-02-06T23:07:58  <BlueMatt> hopefully it doesnt show up again in rc3
8962018-02-06T23:08:30  *** Krellan has quit IRC
8972018-02-06T23:08:49  <cfields> heh
8982018-02-06T23:08:54  <cfields> BlueMatt: i never saw that one :\
8992018-02-06T23:09:18  <BlueMatt> I have no idea how realistic it is
9002018-02-06T23:09:31  <BlueMatt> I was just putting sleeps in the middle of AppInitMain and closing splashscreen
9012018-02-06T23:13:53  <cfields> BlueMatt: how long are the sleeps? anywhere near reasonable?
9022018-02-06T23:16:48  *** Randolf has quit IRC
9032018-02-06T23:20:18  *** promag has joined #bitcoin-core-dev
9042018-02-06T23:26:22  *** promag has quit IRC
9052018-02-06T23:38:05  *** Guyver2 has quit IRC
9062018-02-06T23:45:10  *** arbitrary_guy has joined #bitcoin-core-dev
9072018-02-06T23:50:02  *** vicenteH has quit IRC
9082018-02-06T23:56:34  *** dongcarl has joined #bitcoin-core-dev