12018-02-08T00:00:14  <sipa> happy thursday
  22018-02-08T00:00:39  *** Victorsueca has joined #bitcoin-core-dev
  32018-02-08T00:01:57  <gmaxwell> so then at least we'd have some amount of base diversity, without any offers to support crazy stuff.
  42018-02-08T00:02:13  <gmaxwell> "Why won't it bootstrap on BeOS???????"
  52018-02-08T00:06:57  <cfields> gmaxwell: I'd just feel honored to be the preimage for BeOS :p
  62018-02-08T00:08:05  <gmaxwell> I used to have a BeOS machine in jenkins CI for opus, it was interesting to test on because it made some pretty different calls from linux on optional extensions beyond pure posix.
  72018-02-08T00:08:38  <cfields> erm, when was this?
  82018-02-08T00:09:13  <gmaxwell> ten years ago. (it was long dead by then too, of course)
  92018-02-08T00:09:44  *** dongcarl has quit IRC
 102018-02-08T00:09:48  <cfields> ah, ok. I was trying to figure out the overlap between Jenkins and BeOS.
 112018-02-08T00:10:45  <gmaxwell> since jenkins uses java you can run most anything java will run on as a remote build target.
 122018-02-08T00:10:51  *** Randolf has joined #bitcoin-core-dev
 132018-02-08T00:18:06  *** AaronvanW has joined #bitcoin-core-dev
 142018-02-08T00:19:57  *** wxss has quit IRC
 152018-02-08T00:21:14  *** jojeyh has quit IRC
 162018-02-08T00:25:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 172018-02-08T00:26:10  *** jojeyh has joined #bitcoin-core-dev
 182018-02-08T00:27:53  *** tn2or3 has joined #bitcoin-core-dev
 192018-02-08T00:33:42  *** tn2or3 has quit IRC
 202018-02-08T00:36:05  *** intcat has quit IRC
 212018-02-08T00:40:14  *** intcat has joined #bitcoin-core-dev
 222018-02-08T00:44:04  *** Dizzle has quit IRC
 232018-02-08T00:44:06  <contrapumpkin> have y'all looked at the Nix builds of bitcoin at all?
 242018-02-08T00:44:23  <contrapumpkin> roconnor wrote most of them, but it's a nice baseline to start with
 252018-02-08T00:44:33  <sipa> i don't think they're deterministic?
 262018-02-08T00:44:45  <contrapumpkin> I don't think so either
 272018-02-08T00:45:01  <contrapumpkin> but it's a less heavyweight starting point than a VM for the determinism
 282018-02-08T00:45:22  <contrapumpkin> when all your inputs are effectively deterministic modulo meaningless shit
 292018-02-08T00:45:30  *** neha has quit IRC
 302018-02-08T00:45:51  <sipa> contrapumpkin: i think we pretty much already have all that that does through the depends build system
 312018-02-08T00:46:22  *** AaronvanW has quit IRC
 322018-02-08T00:47:00  *** tn2or3 has joined #bitcoin-core-dev
 332018-02-08T00:49:32  *** zivl has quit IRC
 342018-02-08T00:50:17  *** tn2or3 has quit IRC
 352018-02-08T00:53:17  *** neha has joined #bitcoin-core-dev
 362018-02-08T00:58:47  <Randolf> contrapumpkin:  I recently made a minor contribution by adding instructions for NetBSD support, and there were many developers who took an interest in what I was doing and helped to make it even better.
 372018-02-08T00:59:26  <Randolf> contrapumpkin:  It seems to me that Unix/Linux support is very good, but I guess you've got some improvements in mind?  (If so, great!)
 382018-02-08T01:01:49  *** dabura667 has joined #bitcoin-core-dev
 392018-02-08T01:11:10  *** jojeyh has quit IRC
 402018-02-08T01:17:30  <bitcoin-git> [bitcoin] theuni opened pull request #12381: Remove more boost threads (master...boost-threads-again) https://github.com/bitcoin/bitcoin/pull/12381
 412018-02-08T01:25:35  *** arbitrary_guy has joined #bitcoin-core-dev
 422018-02-08T01:31:30  *** Randolf has quit IRC
 432018-02-08T01:34:38  *** ProfMac has quit IRC
 442018-02-08T01:37:52  *** ProfMac has joined #bitcoin-core-dev
 452018-02-08T01:41:10  *** Chris_Stewart_5 has quit IRC
 462018-02-08T01:43:39  *** ProfMac has quit IRC
 472018-02-08T01:45:09  *** meshcollider has quit IRC
 482018-02-08T01:47:46  *** whphhg_ has joined #bitcoin-core-dev
 492018-02-08T01:48:49  *** whphhg has quit IRC
 502018-02-08T01:51:39  *** ProfMac has joined #bitcoin-core-dev
 512018-02-08T01:56:40  *** ProfMac has quit IRC
 522018-02-08T01:58:01  *** jojeyh has joined #bitcoin-core-dev
 532018-02-08T02:05:04  *** VeraZ has joined #bitcoin-core-dev
 542018-02-08T02:12:21  *** zivl has joined #bitcoin-core-dev
 552018-02-08T02:17:24  <bitcoin-git> [bitcoin] pristantyo opened pull request #12382: Request Source Code Pull (master...master) https://github.com/bitcoin/bitcoin/pull/12382
 562018-02-08T02:18:34  <bitcoin-git> [bitcoin] fanquake closed pull request #12382: Request Source Code Pull (master...master) https://github.com/bitcoin/bitcoin/pull/12382
 572018-02-08T02:21:21  *** CubicEarths has joined #bitcoin-core-dev
 582018-02-08T02:27:47  *** RubenSomsen has joined #bitcoin-core-dev
 592018-02-08T02:28:25  *** Murch has quit IRC
 602018-02-08T02:29:29  *** RubenSomsen has quit IRC
 612018-02-08T02:29:42  *** RubenSomsen has joined #bitcoin-core-dev
 622018-02-08T02:31:36  *** VeraZ has quit IRC
 632018-02-08T02:33:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 642018-02-08T02:34:13  *** meshcollider has joined #bitcoin-core-dev
 652018-02-08T02:38:07  *** Chris_Stewart_5 has quit IRC
 662018-02-08T02:50:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 672018-02-08T02:57:06  *** CubicEarths has quit IRC
 682018-02-08T02:57:41  *** CubicEarths has joined #bitcoin-core-dev
 692018-02-08T03:01:57  *** CubicEarths has quit IRC
 702018-02-08T03:04:22  *** ProfMac has joined #bitcoin-core-dev
 712018-02-08T03:08:41  *** dongcarl has joined #bitcoin-core-dev
 722018-02-08T03:12:48  *** CubicEarths has joined #bitcoin-core-dev
 732018-02-08T03:14:35  *** tn2or3 has joined #bitcoin-core-dev
 742018-02-08T03:15:28  *** ProfMac has quit IRC
 752018-02-08T03:15:29  *** tn2or3 has quit IRC
 762018-02-08T03:15:52  *** ProfMac has joined #bitcoin-core-dev
 772018-02-08T03:18:03  *** zautomata1 has joined #bitcoin-core-dev
 782018-02-08T03:18:21  *** dongcarl has quit IRC
 792018-02-08T03:19:45  *** dongcarl has joined #bitcoin-core-dev
 802018-02-08T03:19:55  *** jamesob has joined #bitcoin-core-dev
 812018-02-08T03:20:05  *** zautomata has quit IRC
 822018-02-08T03:25:21  *** Chris_Stewart_5 has quit IRC
 832018-02-08T03:27:40  *** belcher has quit IRC
 842018-02-08T03:31:06  *** checksauce has joined #bitcoin-core-dev
 852018-02-08T03:33:33  *** CubicEarths has quit IRC
 862018-02-08T03:47:20  *** [Author] has quit IRC
 872018-02-08T03:48:23  *** jamesob has quit IRC
 882018-02-08T03:48:28  *** Randolf has joined #bitcoin-core-dev
 892018-02-08T03:53:09  *** [Author] has joined #bitcoin-core-dev
 902018-02-08T04:08:07  *** dongcarl has quit IRC
 912018-02-08T04:11:41  *** CubicEarths has joined #bitcoin-core-dev
 922018-02-08T04:13:27  *** TheRec has quit IRC
 932018-02-08T04:13:30  *** TheRec_ has joined #bitcoin-core-dev
 942018-02-08T04:24:27  *** cryptojanitor has quit IRC
 952018-02-08T04:28:33  *** Emcy has joined #bitcoin-core-dev
 962018-02-08T04:29:59  *** Emcy_ has quit IRC
 972018-02-08T04:54:26  *** checksauce has quit IRC
 982018-02-08T05:13:49  *** checksauce has joined #bitcoin-core-dev
 992018-02-08T05:18:21  *** flokie has joined #bitcoin-core-dev
1002018-02-08T05:37:08  *** dermoth has quit IRC
1012018-02-08T05:41:02  *** sengehest has joined #bitcoin-core-dev
1022018-02-08T05:41:35  *** a5m0 has quit IRC
1032018-02-08T05:43:38  *** dermoth has joined #bitcoin-core-dev
1042018-02-08T05:44:45  *** a5m0 has joined #bitcoin-core-dev
1052018-02-08T05:48:17  *** dermoth has quit IRC
1062018-02-08T05:48:47  *** dermoth has joined #bitcoin-core-dev
1072018-02-08T05:55:25  *** sengehest has quit IRC
1082018-02-08T05:55:35  *** sengehest has joined #bitcoin-core-dev
1092018-02-08T06:01:50  *** checksauce has quit IRC
1102018-02-08T06:02:22  *** checksauce has joined #bitcoin-core-dev
1112018-02-08T06:02:37  *** checksauce has quit IRC
1122018-02-08T06:07:04  *** dermoth has quit IRC
1132018-02-08T06:07:51  *** dermoth has joined #bitcoin-core-dev
1142018-02-08T06:13:20  *** sengehest has quit IRC
1152018-02-08T06:13:40  *** sengehest has joined #bitcoin-core-dev
1162018-02-08T06:15:09  *** meshcollider has quit IRC
1172018-02-08T06:17:10  *** RubenSomsen has quit IRC
1182018-02-08T06:17:59  *** rex_4539 has joined #bitcoin-core-dev
1192018-02-08T06:22:25  *** CubicEarths has quit IRC
1202018-02-08T06:42:15  *** RubenSomsen has joined #bitcoin-core-dev
1212018-02-08T07:16:20  *** checksauce has joined #bitcoin-core-dev
1222018-02-08T07:29:11  *** Deadhand has quit IRC
1232018-02-08T07:39:03  *** checksau_ has joined #bitcoin-core-dev
1242018-02-08T07:39:03  *** checksauce has quit IRC
1252018-02-08T07:41:26  *** Deadhand has joined #bitcoin-core-dev
1262018-02-08T07:41:58  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0277173b1def...7217ea2cc8dd
1272018-02-08T07:41:59  <bitcoin-git> bitcoin/master 1c9394a Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait...
1282018-02-08T07:41:59  <bitcoin-git> bitcoin/master dd2de47 Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded...
1292018-02-08T07:42:00  <bitcoin-git> bitcoin/master 7217ea2 Wladimir J. van der Laan: Merge #12367: Fix two fast-shutdown bugs...
1302018-02-08T07:42:43  <bitcoin-git> [bitcoin] laanwj closed pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367
1312018-02-08T07:46:44  *** dermoth has quit IRC
1322018-02-08T07:52:00  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7217ea2cc8dd...36a927c52585
1332018-02-08T07:52:00  <bitcoin-git> bitcoin/master 2222bf0 MarcoFalke: qt: Poll ShutdownTimer after init is done
1342018-02-08T07:52:01  <bitcoin-git> bitcoin/master 36a927c Wladimir J. van der Laan: Merge #12377: qt: Poll ShutdownTimer after init is done...
1352018-02-08T07:52:55  <bitcoin-git> [bitcoin] laanwj closed pull request #12377: qt: Poll ShutdownTimer after init is done (master...Mf1802-qtInitShutdown) https://github.com/bitcoin/bitcoin/pull/12377
1362018-02-08T07:52:58  <sipa> woohoo
1372018-02-08T07:53:39  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/36a927c52585...11f3eac79334
1382018-02-08T07:53:40  <bitcoin-git> bitcoin/master f5a4c3d Wladimir J. van der Laan: qt: Make sure splash screen is freed on AppInitMain fail...
1392018-02-08T07:53:40  <bitcoin-git> bitcoin/master 1e5d14b Wladimir J. van der Laan: qt: Clarify some comments...
1402018-02-08T07:53:41  <bitcoin-git> bitcoin/master 11f3eac Wladimir J. van der Laan: Merge #12374: qt: Make sure splash screen is freed on AppInitMain fail...
1412018-02-08T07:54:25  <bitcoin-git> [bitcoin] laanwj closed pull request #12374: qt: Make sure splash screen is freed on AppInitMain fail (master...2017_02_splash_abort) https://github.com/bitcoin/bitcoin/pull/12374
1422018-02-08T07:57:47  *** dermoth has joined #bitcoin-core-dev
1432018-02-08T07:58:55  *** sengehest has quit IRC
1442018-02-08T08:17:34  *** wallet42 has quit IRC
1452018-02-08T08:18:00  *** wallet42 has joined #bitcoin-core-dev
1462018-02-08T08:18:22  *** hsmiths has quit IRC
1472018-02-08T08:22:14  *** Ruben has joined #bitcoin-core-dev
1482018-02-08T08:22:20  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/11f3eac79334...6db4fa7ad329
1492018-02-08T08:22:21  <bitcoin-git> bitcoin/master b1c2370 Wladimir J. van der Laan: http: Join worker threads before deleting work queue...
1502018-02-08T08:22:21  <bitcoin-git> bitcoin/master f946654 Wladimir J. van der Laan: http: Remove WaitExit from WorkQueue...
1512018-02-08T08:22:22  <bitcoin-git> bitcoin/master 11e0151 Wladimir J. van der Laan: http: Remove numThreads and ThreadCounter...
1522018-02-08T08:22:27  *** RubenSomsen has quit IRC
1532018-02-08T08:23:07  <bitcoin-git> [bitcoin] laanwj closed pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366
1542018-02-08T08:25:53  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/f17942a3bc81...da84760701dc
1552018-02-08T08:25:53  <bitcoin-git> bitcoin/0.16 d56355a MarcoFalke: 0.16: Check in current release notes draft
1562018-02-08T08:25:54  <bitcoin-git> bitcoin/0.16 da84760 Wladimir J. van der Laan: Merge #12380: 0.16: Check in current release notes draft...
1572018-02-08T08:32:37  <bitcoin-git> [bitcoin] Willtech opened pull request #12384: Docs: Edited /doc/tor.md (master...tor.md) https://github.com/bitcoin/bitcoin/pull/12384
1582018-02-08T08:38:22  *** intcat has quit IRC
1592018-02-08T08:39:41  *** intcat has joined #bitcoin-core-dev
1602018-02-08T08:40:06  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6db4fa7ad329...d57d10ee96a6
1612018-02-08T08:40:07  <bitcoin-git> bitcoin/master 85aa839 Matt Corallo: Hold mempool.cs for the duration of ATMP....
1622018-02-08T08:40:07  <bitcoin-git> bitcoin/master 02fc886 Matt Corallo: Add braces to meet code style on line-after-the-one-changed.
1632018-02-08T08:40:08  <bitcoin-git> bitcoin/master d57d10e Wladimir J. van der Laan: Merge #12368: Hold mempool.cs for the duration of ATMP....
1642018-02-08T08:40:58  <bitcoin-git> [bitcoin] laanwj closed pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368
1652018-02-08T08:41:39  <gmaxwell> FWIW, I've had that stack of patches running for a few hours without issue, plus some restart cycles in valgrind.
1662018-02-08T08:47:27  *** neha has quit IRC
1672018-02-08T08:48:46  *** neha has joined #bitcoin-core-dev
1682018-02-08T08:56:42  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d57d10ee96a6...ab4ee6e69242
1692018-02-08T08:56:42  <bitcoin-git> bitcoin/master 45eea40 fivepiece: Bech32 addresses in dumpwallet...
1702018-02-08T08:56:43  <bitcoin-git> bitcoin/master ab4ee6e Wladimir J. van der Laan: Merge #12315: Bech32 addresses in dumpwallet...
1712018-02-08T08:57:28  <arubi> yay :)
1722018-02-08T08:57:36  <bitcoin-git> [bitcoin] laanwj closed pull request #12315: Bech32 addresses in dumpwallet (master...dumpwallet-bech32) https://github.com/bitcoin/bitcoin/pull/12315
1732018-02-08T08:57:37  <gmaxwell> okay, that one I didn't test.
1742018-02-08T09:02:09  *** intcat has quit IRC
1752018-02-08T09:02:53  *** intcat has joined #bitcoin-core-dev
1762018-02-08T09:04:28  *** arbitrary_guy has quit IRC
1772018-02-08T09:05:22  *** arbitrary_guy has joined #bitcoin-core-dev
1782018-02-08T09:11:02  <wumpus> yeah, the bech32 dumpwallet one is the one of the bunch that isn't completely straightforward and might require more testing - luckily this will be rc3, not final
1792018-02-08T09:12:52  <wumpus> the "address type is whatever there is a label for" part is interesting
1802018-02-08T09:13:32  <wumpus> though correct, I think
1812018-02-08T09:15:33  *** arbitrary_guy has quit IRC
1822018-02-08T09:17:00  *** timothy has joined #bitcoin-core-dev
1832018-02-08T09:18:47  <gmaxwell> the alternative construction would be to emit duplicate lines, one with each address we'd accept.
1842018-02-08T09:19:49  <sipa> it's just in a comment anyway
1852018-02-08T09:19:56  <wumpus> yes
1862018-02-08T09:20:46  *** timothy has quit IRC
1872018-02-08T09:23:41  *** timothy has joined #bitcoin-core-dev
1882018-02-08T09:25:33  <bitcoin-git> [bitcoin] laanwj pushed 11 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/da84760701dc...758a41e10045
1892018-02-08T09:25:34  <bitcoin-git> bitcoin/0.16 09fc859 Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait...
1902018-02-08T09:25:34  <bitcoin-git> bitcoin/0.16 0f207c4 Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded...
1912018-02-08T09:25:35  <bitcoin-git> bitcoin/0.16 604f289 MarcoFalke: qt: Poll ShutdownTimer after init is done...
1922018-02-08T09:27:23  *** go1111111 has quit IRC
1932018-02-08T09:28:11  *** drizztbsd has joined #bitcoin-core-dev
1942018-02-08T09:28:59  *** timothy has quit IRC
1952018-02-08T09:29:17  *** AaronvanW has joined #bitcoin-core-dev
1962018-02-08T09:29:50  *** rex_4539 has quit IRC
1972018-02-08T09:30:46  *** Aaronvan_ has joined #bitcoin-core-dev
1982018-02-08T09:34:09  *** Sinclair_ has joined #bitcoin-core-dev
1992018-02-08T09:34:50  *** AaronvanW has quit IRC
2002018-02-08T09:35:23  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/4f63a43f6b0425b4cdd9211283017af375e18c90
2012018-02-08T09:35:23  <bitcoin-git> bitcoin/0.16 4f63a43 Wladimir J. van der Laan: qt: Pre-rc3 translations update...
2022018-02-08T09:35:58  *** meshcollider has joined #bitcoin-core-dev
2032018-02-08T09:36:45  *** larafale has joined #bitcoin-core-dev
2042018-02-08T09:37:05  *** Sinclair6 has quit IRC
2052018-02-08T09:41:59  *** checksau_ has quit IRC
2062018-02-08T09:45:18  *** Sinclair_ has quit IRC
2072018-02-08T09:47:27  *** Sinclair6 has joined #bitcoin-core-dev
2082018-02-08T09:50:41  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/a5e3d44cc8f61f03a94d57302ff8c33c8f8a8689
2092018-02-08T09:50:41  <bitcoin-git> bitcoin/0.16 a5e3d44 Wladimir J. van der Laan: doc: Update release notes from wiki (for rc3 PRs)...
2102018-02-08T09:52:11  *** Sinclair6 has quit IRC
2112018-02-08T09:53:08  <wumpus> okay, anything I forgot before tagging rc3?
2122018-02-08T09:53:18  *** [Author] has quit IRC
2132018-02-08T09:58:22  <midnightmagic> YES WAIT..
2142018-02-08T09:58:26  <midnightmagic> j/k
2152018-02-08T09:59:25  *** Aaronvan_ has quit IRC
2162018-02-08T10:00:26  *** drizztbsd is now known as timothy
2172018-02-08T10:00:49  *** echonaut has quit IRC
2182018-02-08T10:01:12  *** echonaut has joined #bitcoin-core-dev
2192018-02-08T10:01:48  *** Sinclair6 has joined #bitcoin-core-dev
2202018-02-08T10:04:31  <wumpus> hehe
2212018-02-08T10:05:25  <wumpus>  * [new tag]         v0.16.0rc3 -> v0.16.0rc3
2222018-02-08T10:10:05  *** AaronvanW has joined #bitcoin-core-dev
2232018-02-08T10:11:58  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ab4ee6e69242...c9ca4f6024e0
2242018-02-08T10:11:58  <bitcoin-git> bitcoin/master b947d38 Akira Takizawa: Add gitian PGP key: akx20000
2252018-02-08T10:11:59  <bitcoin-git> bitcoin/master c9ca4f6 Wladimir J. van der Laan: Merge #12371: Add gitian PGP key: akx20000...
2262018-02-08T10:12:53  <bitcoin-git> [bitcoin] laanwj closed pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371
2272018-02-08T10:13:53  *** jtimon has quit IRC
2282018-02-08T10:14:32  *** AaronvanW has quit IRC
2292018-02-08T10:14:51  *** hsmiths has joined #bitcoin-core-dev
2302018-02-08T10:21:15  *** gribble has quit IRC
2312018-02-08T10:23:57  *** gribble has joined #bitcoin-core-dev
2322018-02-08T10:25:46  <promag> wumpus: no more theme release right?
2332018-02-08T10:26:02  <wumpus> hopefully not
2342018-02-08T10:29:10  <promag> wumpus: if you find the time #12333
2352018-02-08T10:29:34  <gribble> https://github.com/bitcoin/bitcoin/issues/12333 | Make CWallet::ListCoins atomic by promag · Pull Request #12333 · bitcoin/bitcoin · GitHub
2362018-02-08T10:29:42  <promag> add ?w=1
2372018-02-08T10:30:19  *** dabura667 has quit IRC
2382018-02-08T10:43:32  *** gribble has quit IRC
2392018-02-08T10:49:39  *** Victorsueca has quit IRC
2402018-02-08T10:50:49  *** Victorsueca has joined #bitcoin-core-dev
2412018-02-08T10:54:02  *** murrayn has quit IRC
2422018-02-08T10:54:20  *** murrayn has joined #bitcoin-core-dev
2432018-02-08T10:55:23  <promag> wumpus: this should be ready #12298
2442018-02-08T10:57:22  *** Sinclair6 has quit IRC
2452018-02-08T10:57:28  *** go1111111 has joined #bitcoin-core-dev
2462018-02-08T10:57:55  *** Sinclair6 has joined #bitcoin-core-dev
2472018-02-08T11:02:27  *** DrFeelGood has quit IRC
2482018-02-08T11:04:26  *** DrFeelGood has joined #bitcoin-core-dev
2492018-02-08T11:10:48  *** AaronvanW has joined #bitcoin-core-dev
2502018-02-08T11:14:57  *** AaronvanW has quit IRC
2512018-02-08T11:18:08  *** murrayn has quit IRC
2522018-02-08T11:19:29  *** checksauce has joined #bitcoin-core-dev
2532018-02-08T11:20:49  <provoostenator> Time to ssh into my computer, start the gitian VM, ssh into that and then have it build the vm that builds rc3. Must go deeper!
2542018-02-08T11:22:38  <promag> provoostenator: and play this https://www.youtube.com/watch?v=imamcajBEJs
2552018-02-08T11:22:58  <provoostenator> No, I'm tethering...
2562018-02-08T11:23:18  *** rex_4539 has joined #bitcoin-core-dev
2572018-02-08T11:23:29  *** murrayn has joined #bitcoin-core-dev
2582018-02-08T11:24:16  *** Giszmo has quit IRC
2592018-02-08T11:25:10  <promag> IMO we should add the version when something is deprecated, like DEPRECATED(0.16.0)
2602018-02-08T11:26:08  <promag> without that a reviewer must blame to see when it was deprecated
2612018-02-08T11:26:15  <promag> context 12336
2622018-02-08T11:27:34  *** Giszmo has joined #bitcoin-core-dev
2632018-02-08T11:29:44  *** checksauce has quit IRC
2642018-02-08T11:33:42  *** gribble has joined #bitcoin-core-dev
2652018-02-08T11:35:27  *** DrFeelGood has quit IRC
2662018-02-08T11:42:00  <promag> Close 12387..
2672018-02-08T11:45:30  *** meshcollider has quit IRC
2682018-02-08T11:50:23  <arubi> comments on #12321 ?
2692018-02-08T11:50:25  <gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh and p2sh-p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
2702018-02-08T11:50:43  *** cryptojanitor has joined #bitcoin-core-dev
2712018-02-08T11:58:56  *** jtimon has joined #bitcoin-core-dev
2722018-02-08T12:04:41  <arubi> oh actually I could use GetScriptForWitness() right?
2732018-02-08T12:05:35  *** Giszmo has quit IRC
2742018-02-08T12:07:10  *** Guyver2 has joined #bitcoin-core-dev
2752018-02-08T12:07:48  <arubi> well not blindly, it might return a p2wpkh instead
2762018-02-08T12:14:38  *** gauravgoyal has joined #bitcoin-core-dev
2772018-02-08T12:17:05  <wumpus> what's wrong with travis on rc3?
2782018-02-08T12:17:06  <wumpus> 0.04s$ if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/git-subtree-check.sh src/crypto/ctaes; fi ERROR: src/crypto/ctaes is not a subtree
2792018-02-08T12:17:12  <wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/338906244
2802018-02-08T12:17:49  <wumpus> I cannot reproduce that error locally
2812018-02-08T12:19:12  *** DrFeelGood has joined #bitcoin-core-dev
2822018-02-08T12:19:39  *** DrFeelGood has quit IRC
2832018-02-08T12:21:17  <promag> cache?
2842018-02-08T12:24:41  <wumpus> deleted the cache for the 0.16 branch, we'll see
2852018-02-08T12:27:15  <wumpus> same issue
2862018-02-08T12:31:27  *** gauravgoyal has quit IRC
2872018-02-08T12:31:46  <promag> wumpus: https://github.com/bitcoin/bitcoin/commits/0.16
2882018-02-08T12:31:49  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9ca4f6024e0...a1ffddb90d1b
2892018-02-08T12:31:49  <bitcoin-git> bitcoin/master 5bdbbdc João Barbosa: Refactor HaveKeys to early return on false result
2902018-02-08T12:31:50  <bitcoin-git> bitcoin/master a1ffddb Wladimir J. van der Laan: Merge #12298: Refactor HaveKeys to early return on false result...
2912018-02-08T12:32:44  <bitcoin-git> [bitcoin] laanwj closed pull request #12298: Refactor HaveKeys to early return on false result (master...2018-01-ismine-havekeys) https://github.com/bitcoin/bitcoin/pull/12298
2922018-02-08T12:32:46  <promag> this happened before https://travis-ci.org/bitcoin/bitcoin/jobs/338892886
2932018-02-08T12:36:32  <wumpus> "git log src/crypto/ctaes" shows the last change to ctaes was made a year and two months ago
2942018-02-08T12:37:13  *** laurentmt has joined #bitcoin-core-dev
2952018-02-08T12:37:28  <wumpus> maybe it has to do with "git clone --depth=50 --branch=0.16" , will try that
2962018-02-08T12:38:04  *** laurentmt has quit IRC
2972018-02-08T12:39:05  <wumpus> that's it: at depth 50, it cannot see that it is a subtree
2982018-02-08T12:39:57  <wumpus> e.g. the last change to ctaes was more than 50 commits ago, so for a shallow checkout, it's "lost"
2992018-02-08T12:40:55  <wumpus> the obvious solution would be to clone deeper, I guess, though it might be kicking the can down the road, I'd say to be robust the check needs to generate a warning in this case but continue
3002018-02-08T12:42:04  <wumpus> anyow I'll create a github issue, good to know at least this signals nothing important
3012018-02-08T12:47:28  <wumpus> https://github.com/bitcoin/bitcoin/issues/12388
3022018-02-08T12:51:39  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1ffddb90d1b...b2645286745b
3032018-02-08T12:51:39  <bitcoin-git> bitcoin/master 27736f2 fivepiece: add fivepiece key fingerprint
3042018-02-08T12:51:40  <bitcoin-git> bitcoin/master b264528 Wladimir J. van der Laan: Merge #12354: add gpg key for fivepiece...
3052018-02-08T12:52:10  <arubi> oh thanks, I was about to mention after pushing rc3 sigs
3062018-02-08T12:52:28  <bitcoin-git> [bitcoin] laanwj closed pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354
3072018-02-08T12:54:02  *** Talia34Lemke has joined #bitcoin-core-dev
3082018-02-08T12:57:55  *** DrFeelGood has joined #bitcoin-core-dev
3092018-02-08T13:08:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3102018-02-08T13:10:39  *** belcher has joined #bitcoin-core-dev
3112018-02-08T13:11:33  *** AaronvanW has joined #bitcoin-core-dev
3122018-02-08T13:13:10  *** mmgen has joined #bitcoin-core-dev
3132018-02-08T13:16:05  *** AaronvanW has quit IRC
3142018-02-08T13:27:46  *** Chris_Stewart_5 has quit IRC
3152018-02-08T13:28:49  *** laurentmt has joined #bitcoin-core-dev
3162018-02-08T13:29:35  *** SopaXorzTaker has joined #bitcoin-core-dev
3172018-02-08T13:33:24  *** jamesob has joined #bitcoin-core-dev
3182018-02-08T13:38:07  *** jtimon has quit IRC
3192018-02-08T13:41:36  *** lio17 has quit IRC
3202018-02-08T13:41:59  *** lio17 has joined #bitcoin-core-dev
3212018-02-08T13:52:52  *** Giszmo has joined #bitcoin-core-dev
3222018-02-08T13:57:14  *** Ruben has quit IRC
3232018-02-08T14:03:32  *** jamesob has quit IRC
3242018-02-08T14:12:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3252018-02-08T14:13:57  *** DrFeelGood has quit IRC
3262018-02-08T14:17:41  *** DrFeelGood has joined #bitcoin-core-dev
3272018-02-08T14:20:10  *** jamesob has joined #bitcoin-core-dev
3282018-02-08T14:27:06  *** conman has quit IRC
3292018-02-08T14:27:25  *** jamesob_ has joined #bitcoin-core-dev
3302018-02-08T14:29:00  *** capa66 has joined #bitcoin-core-dev
3312018-02-08T14:29:48  *** jamesob has quit IRC
3322018-02-08T14:38:52  <bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2645286745b...3843780fd8e0
3332018-02-08T14:38:53  <bitcoin-git> bitcoin/master d119f2e John Newbery: [tests] Fix style warnings in feature_fee_estimation.py
3342018-02-08T14:38:53  <bitcoin-git> bitcoin/master a5623b1 John Newbery: [tests] Remove tests for deprecated estimatefee RPC
3352018-02-08T14:38:54  <bitcoin-git> bitcoin/master a8e437a John Newbery: [tests] Remove estimatefee from rpc_deprecated.py test
3362018-02-08T14:39:44  <bitcoin-git> [bitcoin] laanwj closed pull request #12336: Remove deprecated rpc options (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12336
3372018-02-08T14:44:27  *** DrFeelGood has quit IRC
3382018-02-08T14:50:58  *** DrFeelGood has joined #bitcoin-core-dev
3392018-02-08T14:53:19  <BlueMatt> wumpus: where are we managing release notes for 16? (or do you want to just make sure that they mention the change in regtest consensus rules causing a CheckBlockIndex() failure on upgrade)
3402018-02-08T14:53:24  <BlueMatt> ie #11782
3412018-02-08T14:53:25  <gribble> https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub
3422018-02-08T14:53:27  *** SopaXorzTaker has quit IRC
3432018-02-08T14:54:32  <wumpus> BlueMatt: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
3442018-02-08T14:54:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3843780fd8e0...935eb8de039d
3452018-02-08T14:54:49  <bitcoin-git> bitcoin/master 0b9207e practicalswift: Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812)
3462018-02-08T14:54:49  <bitcoin-git> bitcoin/master 4cbab15 practicalswift: tests: Fix accidental redefinition of previously defined variable via list comprehension
3472018-02-08T14:54:50  <bitcoin-git> bitcoin/master a9d0ebc practicalswift: Enable flake8 warnings for all currently non-violated rules
3482018-02-08T14:55:06  <wumpus> it's currently the same as the one on the 0.16 branch, but you should do editing on the wiki
3492018-02-08T14:56:03  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12295: Enable flake8 warnings for all currently non-violated rules (master...accidental-redefinition-of-variable) https://github.com/bitcoin/bitcoin/pull/12295
3502018-02-08T14:57:51  *** AaronvanW has joined #bitcoin-core-dev
3512018-02-08T15:00:06  *** china008cn has joined #bitcoin-core-dev
3522018-02-08T15:02:48  *** neha has quit IRC
3532018-02-08T15:03:03  *** neha has joined #bitcoin-core-dev
3542018-02-08T15:03:24  *** AaronvanW has quit IRC
3552018-02-08T15:03:47  *** SopaXorzTaker has joined #bitcoin-core-dev
3562018-02-08T15:05:08  <BlueMatt> thanks!
3572018-02-08T15:05:34  *** afilini has joined #bitcoin-core-dev
3582018-02-08T15:06:06  <instagibbs> i was able to do a couple gitian runs, now compiling rc3 and getting: ./bin/gbuild:21:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
3592018-02-08T15:06:19  <instagibbs> ideas?
3602018-02-08T15:14:28  *** arbitrary_guy has joined #bitcoin-core-dev
3612018-02-08T15:18:55  *** arbitrary_guy has quit IRC
3622018-02-08T15:19:53  <bitcoin-git> [bitcoin] MajorFireball opened pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (master...0.16) https://github.com/bitcoin/bitcoin/pull/12390
3632018-02-08T15:20:41  <wumpus> instagibbs: anything in build.log?
3642018-02-08T15:22:19  <bitcoin-git> [bitcoin] laanwj closed pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (master...0.16) https://github.com/bitcoin/bitcoin/pull/12390
3652018-02-08T15:28:04  *** arbitrary_guy has joined #bitcoin-core-dev
3662018-02-08T15:32:43  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/935eb8de039d...663911ed581d
3672018-02-08T15:32:43  <bitcoin-git> bitcoin/master fa795cf MarcoFalke: wallet: Disallow abandon of conflicted txes
3682018-02-08T15:32:44  <bitcoin-git> bitcoin/master 663911e Wladimir J. van der Laan: Merge #12282: wallet: Disallow abandon of conflicted txes...
3692018-02-08T15:33:09  <instagibbs> re-running with just linux build to get saner log
3702018-02-08T15:33:29  <bitcoin-git> [bitcoin] laanwj closed pull request #12282: wallet: Disallow abandon of conflicted txes (master...Mf1801-walletBumpAbandonOnlyNonConflictedTxes) https://github.com/bitcoin/bitcoin/pull/12282
3712018-02-08T15:33:41  *** owowo has joined #bitcoin-core-dev
3722018-02-08T15:37:57  *** arbitrary_guy has quit IRC
3732018-02-08T15:38:08  *** unholymachine has quit IRC
3742018-02-08T15:38:26  *** mmgen has quit IRC
3752018-02-08T15:39:06  <instagibbs> wumpus, pages and pages of file timestamps being from the future, and "Check your system clock" message, followed by exit
3762018-02-08T15:39:26  *** unholymachine has joined #bitcoin-core-dev
3772018-02-08T15:43:16  <wumpus> instagibbs: strange, never seen that before
3782018-02-08T15:44:09  *** Chris_Stewart_5 has quit IRC
3792018-02-08T15:45:54  *** capa66 has quit IRC
3802018-02-08T15:53:33  <wumpus> gitian seems like a gambling machine sometimes
3812018-02-08T15:54:17  *** [Author] has joined #bitcoin-core-dev
3822018-02-08T15:54:19  <wumpus> (though, maybe as a surprising anecdote, here it's been 100% reliable for a long time)
3832018-02-08T15:57:08  *** [Author] has quit IRC
3842018-02-08T15:57:08  *** Victorsueca has quit IRC
3852018-02-08T15:58:19  *** Victorsueca has joined #bitcoin-core-dev
3862018-02-08T16:00:27  *** DrFeelGood has quit IRC
3872018-02-08T16:01:03  *** tryphe has quit IRC
3882018-02-08T16:01:25  <wumpus> oh crap, I've just apt-get-upgraded the VM running gitian, this might have been the last time that ^
3892018-02-08T16:01:31  *** tryphe has joined #bitcoin-core-dev
3902018-02-08T16:04:59  <achow101> wumpus: I highly suggest that you never do that because it will break gitian
3912018-02-08T16:05:35  <wumpus> so this went to debian 8.x now, not 9
3922018-02-08T16:05:59  *** jigawatt has quit IRC
3932018-02-08T16:06:17  *** tryphe has quit IRC
3942018-02-08T16:06:29  *** tryphe has joined #bitcoin-core-dev
3952018-02-08T16:09:57  <wumpus> oh, wrong, /etc/debian_version says 9.3
3962018-02-08T16:11:36  <wumpus> no it is 8.10 alright, checked the wrong VM, phew. It would have been really surprising to end up with 9 when just upgrading packages on 8.x. Now let's see if the build still works.
3972018-02-08T16:14:14  <instagibbs> running 8.10 here as well hm
3982018-02-08T16:15:24  *** DrFeelGood has joined #bitcoin-core-dev
3992018-02-08T16:17:04  *** Ruben has joined #bitcoin-core-dev
4002018-02-08T16:17:06  <MarcoFalke> debian 9 should work after the fix https://github.com/bitcoin-core/docs/pull/22
4012018-02-08T16:19:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4022018-02-08T16:23:21  *** owowo has quit IRC
4032018-02-08T16:24:26  *** Chris_St1 has joined #bitcoin-core-dev
4042018-02-08T16:24:59  *** Chris_Stewart_5 has quit IRC
4052018-02-08T16:28:17  *** owowo has joined #bitcoin-core-dev
4062018-02-08T16:30:23  *** mmgen has joined #bitcoin-core-dev
4072018-02-08T16:32:44  <provoostenator> instagibbs: I'm also getting " failed to run on-target setarch x86_64 "
4082018-02-08T16:33:14  <provoostenator> And that's a fresh Debian 8 that I used for rc2 two days ago.
4092018-02-08T16:36:33  <provoostenator> Though I used --setup that time, using -b this time.
4102018-02-08T16:38:31  *** dermoth has quit IRC
4112018-02-08T16:38:52  <wumpus> buliding on (upgraded) 8.10 seems to be going ok here
4122018-02-08T16:38:58  *** dermoth has joined #bitcoin-core-dev
4132018-02-08T16:39:52  <provoostenator> My VM clock is totally wrong though, why doesn't Debian sync it?
4142018-02-08T16:40:31  *** jtimon has joined #bitcoin-core-dev
4152018-02-08T16:40:49  <Sentineo> is it just an offset ? it does it for me on lxc ... always gmt
4162018-02-08T16:41:14  <wumpus> debian doesn't install as many packages by default as ubuntu does, maybe you need to install the ntp stuff
4172018-02-08T16:42:16  <wumpus> always compare date -u against UTC, the timezone shouldn't matter
4182018-02-08T16:42:17  <provoostenator> I just installed ntp. Trying gitian again.
4192018-02-08T16:43:42  <instagibbs> i thought mocktime somethingsomething was under the hood for these builds
4202018-02-08T16:43:59  <MarcoFalke> yeah, why would wall clock time matter
4212018-02-08T16:44:17  *** Randolf has quit IRC
4222018-02-08T16:45:00  *** mmgen has quit IRC
4232018-02-08T16:47:27  <instagibbs> provoostenator, please report back, ill hold out
4242018-02-08T16:49:26  <provoostenator> That seems to have done the trick.
4252018-02-08T16:49:44  <provoostenator> So let's just add installation instructions for ntp to the docs and not worry about why :-P
4262018-02-08T16:51:30  <achow101> instagibbs: MarcoFalke I'm guessing that the time of the vm and the time of the lxc container need to be the same so that the vm can send commands to the container
4272018-02-08T16:51:36  <achow101> the container has mocktime for the build itself
4282018-02-08T16:52:01  <wumpus> yes, having working instruction is more important than knowing why, I've found that usually with time-related problems it's something with SSL certificates or other network communications getting confused about large time differences
4292018-02-08T16:52:27  <provoostenator> I wonder what made suddenly made it picky though; I never paid much attention to the time on my gitian machines thus far, and I certainly didn't leave them on non-stop.
4302018-02-08T16:52:32  <wumpus> also if your time is too far in the past, any .tar.gz you unpack will have dates in the future, causing problems with make
4312018-02-08T16:52:59  <provoostenator> I may however have frozen the state, rather than shutting it down.
4322018-02-08T16:55:22  <Sentineo> some daemons refuse to start when time is not going forward, especially network daemons
4332018-02-08T16:56:55  *** mmgen has joined #bitcoin-core-dev
4342018-02-08T16:59:37  *** promag has quit IRC
4352018-02-08T16:59:54  *** AaronvanW has joined #bitcoin-core-dev
4362018-02-08T17:01:04  *** jigawatt has joined #bitcoin-core-dev
4372018-02-08T17:01:33  *** mmgen has quit IRC
4382018-02-08T17:04:30  *** AaronvanW has quit IRC
4392018-02-08T17:05:03  *** sanada has quit IRC
4402018-02-08T17:05:41  <instagibbs> yeah looks like it's fixed
4412018-02-08T17:07:27  *** finkan has joined #bitcoin-core-dev
4422018-02-08T17:08:53  *** Randolf has joined #bitcoin-core-dev
4432018-02-08T17:13:05  *** mmgen has joined #bitcoin-core-dev
4442018-02-08T17:20:22  *** promag has joined #bitcoin-core-dev
4452018-02-08T17:24:48  *** Victorsueca has quit IRC
4462018-02-08T17:26:19  *** Victorsueca has joined #bitcoin-core-dev
4472018-02-08T17:30:37  *** vexbuy has joined #bitcoin-core-dev
4482018-02-08T17:39:49  *** owowo has quit IRC
4492018-02-08T17:42:19  *** [Author] has joined #bitcoin-core-dev
4502018-02-08T17:43:57  *** owowo has joined #bitcoin-core-dev
4512018-02-08T17:44:15  *** ken2812221 has joined #bitcoin-core-dev
4522018-02-08T17:48:18  *** Murch has joined #bitcoin-core-dev
4532018-02-08T17:55:36  <promag> jnewbery: do you think bitcoind should auto-set LIBC_FATAL_STDERR_?
4542018-02-08T17:59:00  <wumpus> no, bitcoind should not set that, if desired it's intended to be set in the environment by calling process
4552018-02-08T18:00:43  *** mandric has quit IRC
4562018-02-08T18:01:02  <promag> ok, I didn't know that env var
4572018-02-08T18:01:44  *** mandric has joined #bitcoin-core-dev
4582018-02-08T18:01:45  <wumpus> me neither; it's specific to glibc so will likely not work on other OSes
4592018-02-08T18:02:34  <wumpus> or at least other C libraries
4602018-02-08T18:02:51  *** timothy has quit IRC
4612018-02-08T18:03:44  <promag> jnewbery: https://github.com/bitcoin/bitcoin/pull/12379/commits/f70e7997d26e3e456486ab0a351b8a352de07935 s/stdout/stderr in commit message?
4622018-02-08T18:13:39  *** Dizzle has joined #bitcoin-core-dev
4632018-02-08T18:14:48  <jnewbery> promag: yes indeed. Thanks - can you leave review comments on the PR please?
4642018-02-08T18:17:19  *** [Author] has quit IRC
4652018-02-08T18:17:57  *** LeMiner2 has joined #bitcoin-core-dev
4662018-02-08T18:19:43  *** LeMiner has quit IRC
4672018-02-08T18:19:44  *** LeMiner2 is now known as LeMiner
4682018-02-08T18:20:09  <promag> jnewbery: no problem
4692018-02-08T18:23:00  *** promag has quit IRC
4702018-02-08T18:23:26  *** promag has joined #bitcoin-core-dev
4712018-02-08T18:25:11  *** wtabata has joined #bitcoin-core-dev
4722018-02-08T18:28:04  *** SeABaT has joined #bitcoin-core-dev
4732018-02-08T18:28:22  *** promag has quit IRC
4742018-02-08T18:28:44  *** SeABaT has quit IRC
4752018-02-08T18:31:47  *** sanada has joined #bitcoin-core-dev
4762018-02-08T18:31:58  *** mmgen has quit IRC
4772018-02-08T18:32:27  *** [Author] has joined #bitcoin-core-dev
4782018-02-08T18:37:22  *** goatpig has joined #bitcoin-core-dev
4792018-02-08T18:37:27  *** DrFeelGood has quit IRC
4802018-02-08T18:37:56  *** mmgen has joined #bitcoin-core-dev
4812018-02-08T18:47:20  *** promag has joined #bitcoin-core-dev
4822018-02-08T18:48:45  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/663911ed581d...d405beea26c1
4832018-02-08T18:48:46  <bitcoin-git> bitcoin/master 1beea7a João Barbosa: [wallet] Make CWallet::ListCoins atomic
4842018-02-08T18:48:46  <bitcoin-git> bitcoin/master 2f960b5 João Barbosa: [wallet] Indent only change of CWallet::AvailableCoins
4852018-02-08T18:48:47  <bitcoin-git> bitcoin/master d405bee Wladimir J. van der Laan: Merge #12333: Make CWallet::ListCoins atomic...
4862018-02-08T18:49:29  <bitcoin-git> [bitcoin] laanwj closed pull request #12333: Make CWallet::ListCoins atomic (master...2018-02-atomic-listcoins) https://github.com/bitcoin/bitcoin/pull/12333
4872018-02-08T18:56:53  *** mmgen has quit IRC
4882018-02-08T19:00:11  <achow101> meeting?
4892018-02-08T19:00:14  <sipa> *PLING*
4902018-02-08T19:00:27  <wumpus> #startmeeting
4912018-02-08T19:00:27  <lightningbot> Meeting started Thu Feb  8 19:00:27 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4922018-02-08T19:00:27  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4932018-02-08T19:00:37  *** AaronvanW has joined #bitcoin-core-dev
4942018-02-08T19:00:46  <instagibbs> hi
4952018-02-08T19:00:50  <cfields> hi
4962018-02-08T19:00:50  *** finkan has quit IRC
4972018-02-08T19:00:51  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
4982018-02-08T19:01:04  <sdaftuar> hi
4992018-02-08T19:01:05  <jnewbery> hi
5002018-02-08T19:01:16  <achow101> hi
5012018-02-08T19:01:21  <wumpus> PSA: rc3 was tagged earlier today, if you haven't started your gitian build yet, please do so :)
5022018-02-08T19:01:28  <promag> topic suggestion, next high priority stuff
5032018-02-08T19:01:40  <wumpus> yes
5042018-02-08T19:01:44  <instagibbs> provoostenator, you filed an issue for timestamps right?
5052018-02-08T19:01:46  <wumpus> #topic high priority for review
5062018-02-08T19:02:39  <wumpus> we still have plenty of things in https://github.com/bitcoin/bitcoin/projects/8, but it hasn't been updated for a few weeks because we've effectively used the 0.16 milestone for that, so now that 0.16 has branched it's up for discussion to add/remove things
5072018-02-08T19:02:40  <kanzure> hi.
5082018-02-08T19:03:07  <promag> for instance #11383
5092018-02-08T19:03:10  <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
5102018-02-08T19:03:38  <jtimon> https://github.com/bitcoin/bitcoin/pull/12172 could use some tested acks, even if it's a small bug
5112018-02-08T19:04:19  <wumpus> jtimon: you have a comment by MarcoFalke to remove a commit IIRC
5122018-02-08T19:04:21  <jnewbery> #10740 needs rebase so it can be removed for now (and I think it makes sense to wait for after 11383 is in)
5132018-02-08T19:04:24  <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
5142018-02-08T19:04:40  <wumpus> but yes, #12172 should stay
5152018-02-08T19:04:43  <gribble> https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub
5162018-02-08T19:04:43  <jtimon> wumpus: yes, does anyone agree? I agree with removing it. just waiting for feedback
5172018-02-08T19:04:45  <Randolf> Hello.
5182018-02-08T19:05:12  <wumpus> jtimon: well he's the tests maintainer so I tend to agree with him regarding tests things, by default
5192018-02-08T19:05:23  *** AaronvanW has quit IRC
5202018-02-08T19:05:24  <achow101> It would be nice to get #10583 and #10579 in
5212018-02-08T19:05:27  <gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
5222018-02-08T19:05:31  <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
5232018-02-08T19:05:44  <wumpus> jtimon: I haven't looked closely though
5242018-02-08T19:05:47  <jnewbery> fyi MarcoFalke, ryanofsky and bluematt are away from keyboard
5252018-02-08T19:05:48  <jtimon> ok, I'll remove it, no problem, it will still need some tested acks then
5262018-02-08T19:05:48  <promag> jtimon: I'll check it too
5272018-02-08T19:06:20  <jtimon> promag: thanks!
5282018-02-08T19:06:29  <jnewbery> achow101: +1 a few more ACKs please - those PRs have been rebased too many times
5292018-02-08T19:06:41  <wumpus> 10740 removed
5302018-02-08T19:06:42  <instagibbs> will takea  look achow101
5312018-02-08T19:06:57  <wumpus> jtimon: but yes I'll take a look soon
5322018-02-08T19:07:06  <jtimon> awesome
5332018-02-08T19:07:12  <cfields> topic suggestion: PR purge before ramping up for 0.17
5342018-02-08T19:07:31  <instagibbs> purge as in closing?
5352018-02-08T19:07:43  <promag> #11882
5362018-02-08T19:07:45  <gribble> https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub
5372018-02-08T19:08:02  <cfields> well, I looked at my open PR list yesterday and noticed quite a few that I should probably just close. I suspect I'm not alone...
5382018-02-08T19:08:25  <wumpus> that could be a next topic, the current topic is high priority :)
5392018-02-08T19:08:26  <cfields> now seems like a good time to go through their own and close things that are stale
5402018-02-08T19:08:36  <wumpus> bjut yes I agree
5412018-02-08T19:09:05  <promag> Also #11913
5422018-02-08T19:09:09  <gribble> https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub
5432018-02-08T19:09:18  <cfields> ok, sorry
5442018-02-08T19:09:33  <jnewbery> cfields: perhaps the upcoming Core dev tech days is a good opportunity to go through and clear out old PRs?
5452018-02-08T19:09:37  *** meshcollider has joined #bitcoin-core-dev
5462018-02-08T19:09:37  <wumpus> achow101: I've added 10583, you already have the coin selection one I think two high prio per person is a good limit
5472018-02-08T19:09:40  <jtimon> yeah, there have been no interest in https://github.com/bitcoin/bitcoin/pull/9608 for a while so I'm more inclined to close it than to rebase it at this point unless  someone changes my mind
5482018-02-08T19:10:42  <meshcollider> hi
5492018-02-08T19:11:18  <sipa> could i have some comments on #10785 ?
5502018-02-08T19:11:20  <instagibbs> jnewbery, PR triage/close session sounds like a good idea
5512018-02-08T19:11:22  <gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
5522018-02-08T19:11:31  <achow101> wumpus: ok
5532018-02-08T19:11:32  <wumpus> #topic PR purge
5542018-02-08T19:12:26  <achow101> close old PRs?
5552018-02-08T19:12:28  <wumpus> if PRs should be closed you can always let me know, you don't really need to wait until a meeting
5562018-02-08T19:12:35  <cfields> jnewbery: agreed, as a rally. But I was really just hinting that everyone should clean up their stale pulls to get the count down.
5572018-02-08T19:12:57  <cfields> jnewbery: but yes, a kinda "i'm not sure if anyone cares about this or not" session in NYC would be great
5582018-02-08T19:13:24  <bitcoin-git> [bitcoin] sipa closed pull request #10434: [WIP] 3072-bit MuHash based hash_serialized (master...muhash) https://github.com/bitcoin/bitcoin/pull/10434
5592018-02-08T19:13:33  <wumpus> as I've said again and again, it's impossible for me to keep track of all PRs, so if there is something with a PR, just notify me
5602018-02-08T19:13:36  <bitcoin-git> [bitcoin] achow101 closed pull request #9504: [RPC] dumpmasterprivkey command (master...dumpmasterprivkey) https://github.com/bitcoin/bitcoin/pull/9504
5612018-02-08T19:13:44  <jnewbery> It feels like in-person is the most efficient way to do a bulk purge. Probably most efficient if a set of us make lists beforehand for what we think can be closed
5622018-02-08T19:14:43  <wumpus> yes
5632018-02-08T19:14:56  <bitcoin-git> [bitcoin] promag closed pull request #11563: Improve CheckBlockIndex performance (master...2017-10-improve-checkblockindex) https://github.com/bitcoin/bitcoin/pull/11563
5642018-02-08T19:15:00  <cfields> sgtm
5652018-02-08T19:15:33  <cfields> </topic>
5662018-02-08T19:15:39  <wumpus> any other topics?
5672018-02-08T19:15:41  <bitcoin-git> [bitcoin] jtimon closed pull request #9608: Net: Divide ProcessMessage in smaller functions (master...2017-01-split-processmessages) https://github.com/bitcoin/bitcoin/pull/9608
5682018-02-08T19:16:03  *** Victorsueca has quit IRC
5692018-02-08T19:16:13  <bitcoin-git> [bitcoin] instagibbs closed pull request #10360: [WIP] [Wallet] Target effective value during transaction creation (master...feedo) https://github.com/bitcoin/bitcoin/pull/10360
5702018-02-08T19:16:29  <cfields> maybe that should've been the last topic :p
5712018-02-08T19:16:30  <wumpus> so ocongratulations everyone on rc3! we were reallly fast with the fixes this time
5722018-02-08T19:17:08  <achow101> hopefully this will be the last rc
5732018-02-08T19:17:18  *** Victorsueca has joined #bitcoin-core-dev
5742018-02-08T19:17:23  <wumpus> hopefully, yes
5752018-02-08T19:18:00  <wumpus> cfields: at least the closes end up in the meeting log now
5762018-02-08T19:18:02  <Randolf> wumpus:  Is rc3 available for download?
5772018-02-08T19:18:20  <wumpus> Randolf: no, it's just tagged earlier today
5782018-02-08T19:18:35  <Randolf> Okay.  Thanks.
5792018-02-08T19:18:51  <wumpus> but if you have no problems with rc2, it should be ok, rc3 mostly fixed some edge cases
5802018-02-08T19:19:05  <wumpus> (to do with initialization and shutdown)
5812018-02-08T19:19:15  <cfields> wumpus: heh
5822018-02-08T19:19:22  <Randolf> I was planning to try rc2 this weekend.  If rc3 comes out first though, then rc3 is where I'll start.
5832018-02-08T19:20:28  <wumpus> I think it'll be possible to upload binaries for rc3 tomorrow
5842018-02-08T19:20:55  <achow101> have we gotten anywhere with the MPC RSA signing thing?
5852018-02-08T19:20:59  <Randolf> That will be great.
5862018-02-08T19:21:25  <wumpus> already lots of rc3 gitian sigs
5872018-02-08T19:21:37  <cfields> achow101: oh, right
5882018-02-08T19:21:48  <cfields> gmaxwell: ping ^^. Any update?
5892018-02-08T19:23:16  <achow101> I'm gonna guess that gmaxwell is not here right now
5902018-02-08T19:23:23  <wumpus> I guess so too
5912018-02-08T19:23:34  <instagibbs> busy with ___root
5922018-02-08T19:23:42  <wumpus> I'm also not hearing any other proposals for topics, so this will be a short meeting I suppose
5932018-02-08T19:23:57  <Randolf> instagibbs:  ...or fork (if he has kids).  ;)
5942018-02-08T19:24:04  * wumpus just merged the rc3 signatures on bitcoin-core/gitian.sigs
5952018-02-08T19:24:34  <Randolf> wumpus:  Moving away from Boost libraries?
5962018-02-08T19:24:38  *** wallet42 has quit IRC
5972018-02-08T19:24:40  <achow101> Randolf: he doesn't have kids. I'm pretty sure he hates children
5982018-02-08T19:24:41  <Randolf> wumpus:  ...as a topic?
5992018-02-08T19:24:55  <cfields> wumpus: mine just finished building. We can do binaries today if we get the osx sig :)
6002018-02-08T19:24:58  <wumpus> Randolf: is there anything specific to discuss about that? it's been going on, slowly, for a long time
6012018-02-08T19:25:08  <wumpus> Randolf: review cfields's PRs!
6022018-02-08T19:25:26  <Randolf> wumpus:  Well, it seems to me a good idea because Boost libraries have been a problem with getting numerous things compiled on NetBSD.  I guess I'm just wondering how things are going on that front.
6032018-02-08T19:25:32  <Randolf> More general.
6042018-02-08T19:25:35  <arubi> craig satoshi
6052018-02-08T19:25:36  <sipa> Randolf: it will be years
6062018-02-08T19:25:40  <arubi> holy shit roger is stupid
6072018-02-08T19:25:46  <sipa> arubi: not here
6082018-02-08T19:25:46  <cfields> Randolf: https://github.com/bitcoin/bitcoin/projects/3
6092018-02-08T19:25:48  <arubi> oh man sorry, wrong channel
6102018-02-08T19:25:50  <Randolf> sipa:  Oh, so there must be a lot of things tied to it then.
6112018-02-08T19:25:59  <arubi> yea, missed the ctrl :)
6122018-02-08T19:26:31  <Randolf> cfields:  Thanks.  Wow, there's quite a lot to do there, and I wonder if that's everything that needs to be done.
6132018-02-08T19:26:35  *** lnostdal has joined #bitcoin-core-dev
6142018-02-08T19:26:39  <wumpus> there's no hurry in any case
6152018-02-08T19:26:41  <cfields> Randolf: short version: I think we'll be able to get rid of a few parts of boost for 0.17, but things like the unit tests will keep it hanging around for a while
6162018-02-08T19:26:44  <Randolf> Sure, because it's working.
6172018-02-08T19:27:06  <Randolf> cfields:  That seems reasonable.
6182018-02-08T19:27:08  <wumpus> boost::filesystem can only be replaced in c++17 or so
6192018-02-08T19:27:10  <cfields> anyway, we can discuss after the meeting
6202018-02-08T19:27:14  *** wallet42 has joined #bitcoin-core-dev
6212018-02-08T19:27:21  <Randolf> Okay.
6222018-02-08T19:27:23  <wumpus> will be a while until we can start using that
6232018-02-08T19:27:24  <cfields> wumpus: right
6242018-02-08T19:28:03  <wumpus> or at least, mandating it, it could theoretically be an option, but meh. I'd recommend you just solve whatever build problems you have with boost and put it behind you for now
6252018-02-08T19:28:19  <wumpus> yes, let's close the meeting
6262018-02-08T19:28:21  <wumpus> #endmeeting
6272018-02-08T19:28:21  <lightningbot> Meeting ended Thu Feb  8 19:28:21 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6282018-02-08T19:28:21  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.html
6292018-02-08T19:28:21  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.txt
6302018-02-08T19:28:21  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.log.html
6312018-02-08T19:28:22  <Randolf> Already did that.
6322018-02-08T19:29:00  <cfields> Randolf: fwiw, I think threads are probably the biggest portability issue. And it looks like we'll be rid of boost::thread very soon.
6332018-02-08T19:30:00  <Randolf> cfields:  Indeed.  And I did notice this PR:  https://github.com/bitcoin/bitcoin/pull/12381
6342018-02-08T19:30:33  <cfields> <-- TheUni
6352018-02-08T19:30:37  <Randolf> Oh, that's you!
6362018-02-08T19:30:41  <cfields> :)
6372018-02-08T19:31:06  *** vexbuy has quit IRC
6382018-02-08T19:31:53  *** intcat has quit IRC
6392018-02-08T19:32:05  <Randolf> I had a terrible problem with Boost many years ago on NetBSD when I was trying to get two different software projects compiled.  They both needed different versions of Boost that had conflicting APIs.  Backward compabitility seems to be a problem because I ultimately had to either run one of the
6402018-02-08T19:32:19  <Randolf> So, I tend to favour the idea of getting rid of stuff like that.
6412018-02-08T19:32:19  <Randolf> applications under a chroot or in a VM, or on a different system.
6422018-02-08T19:32:42  *** Chris_St1 has quit IRC
6432018-02-08T19:32:57  <wumpus> that's terrible, bitcoind shouldn't have problems like that though, it works with a wide range of boost versions
6442018-02-08T19:33:10  <Randolf> Oh, Bitcoin wasn't one of the applications.
6452018-02-08T19:33:28  *** intcat has joined #bitcoin-core-dev
6462018-02-08T19:34:57  <cfields> Randolf: sounds familiar. Boost is basically the testing project for c++-next. So it's kinda like adding "#include <c++-unstable>" to your project :(
6472018-02-08T19:35:09  <Randolf> Oh.  Wow.
6482018-02-08T19:36:55  *** promag has quit IRC
6492018-02-08T19:45:31  <jonasschnelli> Sorry,.. missed the meeting... new timezone. :(
6502018-02-08T19:46:18  <Randolf> jonasschnelli:  Lots of PRs were closed.  It was quick.
6512018-02-08T19:46:41  *** mirese has joined #bitcoin-core-dev
6522018-02-08T19:46:46  <jonasschnelli> Randolf: Perfect!
6532018-02-08T19:47:10  <Randolf> http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.html
6542018-02-08T19:49:07  <jtimon> we're now on c++11 and the next is c++14, right? what stops us from moving to c++14 ?
6552018-02-08T19:50:16  *** mirese_ has quit IRC
6562018-02-08T19:50:27  <jonasschnelli> jtimon: too early I'd say
6572018-02-08T19:50:44  <jonasschnelli> jtimon: compiler support, stability
6582018-02-08T19:50:50  <jonasschnelli> (I would guess)
6592018-02-08T19:52:05  *** wunpunch has joined #bitcoin-core-dev
6602018-02-08T19:52:12  <jtimon> but for C++11 we needed to get rid of some things before worring about changing the build, no? or am I missremembering? my question is more, is there something like that?
6612018-02-08T19:52:35  <jtimon> some prerriquisite before even considering moving?
6622018-02-08T19:54:26  <wumpus> FWIW a few months ago I built bitcoind with c++17, and there were a few small changes necessary to get it to compile, I can try to find the patch, but nothing serious
6632018-02-08T19:54:26  *** dcousens has quit IRC
6642018-02-08T19:54:48  *** dcousens has joined #bitcoin-core-dev
6652018-02-08T19:55:03  <jtimon> wumpus: awesome, what kind of change ? can I have a look?
6662018-02-08T19:56:39  <wumpus> https://github.com/laanwj/bitcoin/commit/6df31f4c26805009734a620aa2d584e3936d4690 https://github.com/laanwj/bitcoin/commit/3f6bcfa283416182f2602dce357bdaedfc84efe7 https://github.com/laanwj/bitcoin/commit/efeec33d19752de7480f1e8d0fbcd79e49548910
6672018-02-08T19:56:48  <wumpus> especially the last one; the rest is build system
6682018-02-08T19:57:28  <wumpus> I am not sure all of those changes are still necessary, or that it was just working around a compiler bug
6692018-02-08T19:57:46  <jtimon> either way they seem pretty minimal
6702018-02-08T19:57:50  <wumpus> yep
6712018-02-08T19:58:03  <jtimon> cool
6722018-02-08T19:59:30  <wumpus> of course, changing to actually use any c++17 stuff will involve more changes
6732018-02-08T19:59:49  <wumpus> I'm not sure boost::filesystem to std::filesystem is just a drop in replacement, for exmple
6742018-02-08T20:00:21  <jtimon> well, yeah, but that could be considered later
6752018-02-08T20:01:10  <cfields> wumpus: I wrote an adapter at some point. IIRC you didn't like it, but I don't remember the exact reason
6762018-02-08T20:01:47  <wumpus> cfields: oh?!
6772018-02-08T20:02:19  <cfields> wumpus: yea, so that fs::foo would worth whether fs was std or boost
6782018-02-08T20:02:34  <cfields> let me see if I still have it
6792018-02-08T20:02:51  *** SopaXorzTaker has quit IRC
6802018-02-08T20:03:02  *** wtabata has quit IRC
6812018-02-08T20:03:05  <wumpus> cfields: I think that's a nice idea at least, it's one of the reasons I introduced fs in the first place
6822018-02-08T20:03:42  <cfields> wumpus: right. I'm kinda on the fence about it, I maily just wanted to see how compatible they were
6832018-02-08T20:04:07  <cfields> *mainly
6842018-02-08T20:04:38  <cfields> wumpus: also, I believe you can use std::fs pre-c++17 as a compiler extension
6852018-02-08T20:05:06  <wumpus> but I guess that will still require a c++17 compiler
6862018-02-08T20:05:14  <wumpus> it will just work in non-c++17 mode?
6872018-02-08T20:05:41  <cfields> wumpus: https://github.com/theuni/bitcoin/commits/filesystem
6882018-02-08T20:06:13  <wumpus> I don't remember seeing that before
6892018-02-08T20:07:16  <wumpus> I'm surprised if this are all the changes needed: https://github.com/theuni/bitcoin/commit/b208705020118d2be6962c0bf7b6fcfd702f576e
6902018-02-08T20:07:42  <wumpus> kind of nice
6912018-02-08T20:09:44  <cfields> yes, I was pleasantly surprised as well
6922018-02-08T20:10:45  *** flokie_ has joined #bitcoin-core-dev
6932018-02-08T20:11:14  <wumpus> I guess there isn't much reason to do it yet before we even got rid of boost::thread fully, but it's good to know
6942018-02-08T20:13:03  *** dermoth has quit IRC
6952018-02-08T20:13:16  <wumpus> at some point we could offer a choice with a configure option, either use boost, or c++17/experimental
6962018-02-08T20:13:22  *** flokie has quit IRC
6972018-02-08T20:13:48  *** dermoth has joined #bitcoin-core-dev
6982018-02-08T20:14:19  *** Ylbam_ has joined #bitcoin-core-dev
6992018-02-08T20:14:40  <cfields> right
7002018-02-08T20:16:20  *** RubenSomsen has joined #bitcoin-core-dev
7012018-02-08T20:16:42  <wumpus> I don't understand why I didn't like it, the only thing I can think of is that I thought it was too early to do it
7022018-02-08T20:18:35  *** Ruben has quit IRC
7032018-02-08T20:20:38  <cfields> wumpus: ah, you objected to the idea of our own impl. You were pretty pro std impl: https://github.com/bitcoin/bitcoin/pull/9902#issuecomment-283764371
7042018-02-08T20:21:43  <wumpus> cfields: yes, I remember now, one idea was to wrap the entire thing, which is a lot of code, thanks
7052018-02-08T20:22:31  <cfields> right
7062018-02-08T20:24:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
7072018-02-08T20:26:54  <GitHub158> [bitcoin-detached-sigs] jonasschnelli opened pull request #3: 0.16: osx signatures for 0.16.0rc3 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3
7082018-02-08T20:32:35  <instagibbs> achow101, ill review #10579 and #10583 if they get rebased(sorry for your rebasing)
7092018-02-08T20:32:39  <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
7102018-02-08T20:32:43  <gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
7112018-02-08T20:34:10  <achow101> instagibbs: do they need rebasing again? I rebased them last week!
7122018-02-08T20:34:26  <instagibbs> says merged conflict with tests <_<
7132018-02-08T20:35:15  <achow101> bleh
7142018-02-08T20:36:05  <GitHub126> [bitcoin-detached-sigs] theuni closed pull request #3: 0.16: osx signatures for 0.16.0rc3 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3
7152018-02-08T20:38:09  *** RubenSomsen has quit IRC
7162018-02-08T20:38:20  *** promag has joined #bitcoin-core-dev
7172018-02-08T20:40:38  <cfields> woohoo, no crashes during sanity checks this time :)
7182018-02-08T20:42:15  <wumpus> awesome :)
7192018-02-08T20:44:49  <cfields> gitian builders: v0.16.0rc3 detached sigs are up
7202018-02-08T20:49:41  *** promag has quit IRC
7212018-02-08T20:50:23  <achow101> instagibbs: rebased those again
7222018-02-08T20:51:47  <wumpus> cfields: thanks
7232018-02-08T20:52:10  <cfields> ofc
7242018-02-08T20:56:05  *** Randolf has quit IRC
7252018-02-08T21:07:11  *** mirese_ has joined #bitcoin-core-dev
7262018-02-08T21:11:18  *** mirese has quit IRC
7272018-02-08T21:14:17  *** Victorsueca has quit IRC
7282018-02-08T21:20:16  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d405beea26c1...67447ba06057
7292018-02-08T21:20:17  <bitcoin-git> bitcoin/master 0975406 Suhas Daftuar: Correct mempool mapTx comment
7302018-02-08T21:20:17  <bitcoin-git> bitcoin/master e868b22 Suhas Daftuar: fee estimator: avoid sorting mempool on shutdown
7312018-02-08T21:20:18  <bitcoin-git> bitcoin/master 669c943 Suhas Daftuar: Avoid leaking prioritization information when relaying transactions
7322018-02-08T21:21:03  <bitcoin-git> [bitcoin] laanwj closed pull request #12225: Mempool cleanups (master...2018-01-mempool-cleanups) https://github.com/bitcoin/bitcoin/pull/12225
7332018-02-08T21:33:33  *** DrFeelGood has joined #bitcoin-core-dev
7342018-02-08T21:33:43  *** Victorsueca has joined #bitcoin-core-dev
7352018-02-08T21:38:02  *** randy-waterhouse has joined #bitcoin-core-dev
7362018-02-08T21:38:40  *** randy-waterhouse has joined #bitcoin-core-dev
7372018-02-08T21:46:36  *** dermoth has quit IRC
7382018-02-08T21:47:24  *** dermoth has joined #bitcoin-core-dev
7392018-02-08T21:51:03  *** mirese has joined #bitcoin-core-dev
7402018-02-08T21:53:17  *** mirese__ has joined #bitcoin-core-dev
7412018-02-08T21:54:35  *** mirese_ has quit IRC
7422018-02-08T21:56:38  *** mirese has quit IRC
7432018-02-08T21:56:57  *** mirese has joined #bitcoin-core-dev
7442018-02-08T21:57:29  *** mirese_ has joined #bitcoin-core-dev
7452018-02-08T21:58:07  *** mirese___ has joined #bitcoin-core-dev
7462018-02-08T21:58:15  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12286: Wallet: Resolve compiler warnings in ec_privkey_import_der (master...master) https://github.com/bitcoin/bitcoin/pull/12286
7472018-02-08T21:58:32  *** mires____ has joined #bitcoin-core-dev
7482018-02-08T22:00:20  *** mir______ has joined #bitcoin-core-dev
7492018-02-08T22:00:36  *** mirese__ has quit IRC
7502018-02-08T22:01:01  *** mirese__ has joined #bitcoin-core-dev
7512018-02-08T22:01:44  *** mirese has quit IRC
7522018-02-08T22:02:18  *** mirese___ has quit IRC
7532018-02-08T22:02:18  *** mirese_ has quit IRC
7542018-02-08T22:02:52  *** mires____ has quit IRC
7552018-02-08T22:04:34  *** mir______ has quit IRC
7562018-02-08T22:11:12  *** intcat has quit IRC
7572018-02-08T22:11:20  *** Guyver2 has quit IRC
7582018-02-08T22:12:35  *** intcat has joined #bitcoin-core-dev
7592018-02-08T22:18:21  *** laurentmt has quit IRC
7602018-02-08T22:19:33  *** Chris_Stewart_5 has quit IRC
7612018-02-08T22:26:32  *** randy-waterhouse has quit IRC
7622018-02-08T22:32:07  *** AaronvanW has joined #bitcoin-core-dev
7632018-02-08T22:36:59  *** AaronvanW has quit IRC
7642018-02-08T22:42:36  *** promag has joined #bitcoin-core-dev
7652018-02-08T22:42:41  *** lnostdal has quit IRC
7662018-02-08T22:43:52  *** lnostdal has joined #bitcoin-core-dev
7672018-02-08T22:45:58  *** dermoth has quit IRC
7682018-02-08T22:46:25  *** dermoth has joined #bitcoin-core-dev
7692018-02-08T22:50:24  *** whphhg_ is now known as whphhg
7702018-02-08T22:53:36  *** whphhg has quit IRC
7712018-02-08T23:08:32  *** whphhg has joined #bitcoin-core-dev
7722018-02-08T23:09:47  *** grubles has joined #bitcoin-core-dev
7732018-02-08T23:10:10  *** musalbas has quit IRC
7742018-02-08T23:10:10  *** gaf_ has quit IRC
7752018-02-08T23:10:30  *** zautomata1 has quit IRC
7762018-02-08T23:10:35  *** dermoth has quit IRC
7772018-02-08T23:10:36  *** lnostdal has quit IRC
7782018-02-08T23:10:36  *** intcat has quit IRC
7792018-02-08T23:11:03  *** arubi has quit IRC
7802018-02-08T23:11:03  *** ghost43 has quit IRC
7812018-02-08T23:12:30  *** musalbas has joined #bitcoin-core-dev
7822018-02-08T23:13:27  *** DrFeelGood has quit IRC
7832018-02-08T23:13:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
7842018-02-08T23:16:01  *** gaf_ has joined #bitcoin-core-dev
7852018-02-08T23:19:21  *** promag has quit IRC
7862018-02-08T23:22:33  *** Chris_Stewart_5 has quit IRC
7872018-02-08T23:23:05  *** ghost43 has joined #bitcoin-core-dev
7882018-02-08T23:28:34  *** grubles has quit IRC
7892018-02-08T23:28:40  *** arubi has joined #bitcoin-core-dev
7902018-02-08T23:29:32  *** promag has joined #bitcoin-core-dev
7912018-02-08T23:30:45  *** rex_4539 has quit IRC
7922018-02-08T23:33:47  *** grubles has joined #bitcoin-core-dev
7932018-02-08T23:34:33  *** vicenteH has quit IRC
7942018-02-08T23:34:59  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (master...2018-02-fix-fpausesend-getdata-resp) https://github.com/bitcoin/bitcoin/pull/12392
7952018-02-08T23:39:37  *** intcat has joined #bitcoin-core-dev
7962018-02-08T23:41:57  *** meshcollider has quit IRC
7972018-02-08T23:43:27  *** lnostdal has joined #bitcoin-core-dev
7982018-02-08T23:44:41  *** larafale has quit IRC
7992018-02-08T23:44:48  *** jamesob_ has quit IRC
8002018-02-08T23:52:14  *** DrFeelGood has joined #bitcoin-core-dev
8012018-02-08T23:57:41  *** AaronvanW has joined #bitcoin-core-dev