1 2018-02-16T00:02:05  *** Jasmin42Hahn has quit IRC
  2 2018-02-16T00:09:57  *** grafcaps has quit IRC
  3 2018-02-16T00:21:40  *** AaronvanW has joined #bitcoin-core-dev
  4 2018-02-16T00:22:08  *** grafcaps has joined #bitcoin-core-dev
  5 2018-02-16T00:23:33  *** promag has quit IRC
  6 2018-02-16T00:27:02  *** AaronvanW has quit IRC
  7 2018-02-16T00:28:34  <achow101> at least they kept the copyright header this time
  8 2018-02-16T00:30:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fa556aee203...a233fb4f1d03
  9 2018-02-16T00:30:31  <bitcoin-git> bitcoin/master fafbf7f MarcoFalke: devtools: Exclude patches from lint-whitespace
 10 2018-02-16T00:30:32  <bitcoin-git> bitcoin/master a233fb4 MarcoFalke: Merge #12442: devtools: Exclude patches from lint-whitespace...
 11 2018-02-16T00:30:54  <gmaxwell> yea, they changed their strategy from removing the attribution to leaving it and falsely announcing that people were contributing to their project: https://twitter.com/jimmysong/status/952611979742601216
 12 2018-02-16T00:31:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12442: devtools: Exclude patches from lint-whitespace (master...Mf1802-devtoolsLintWhitespaceExcludePatches) https://github.com/bitcoin/bitcoin/pull/12442
 13 2018-02-16T00:32:05  <jimmysong> for what it's worth, deadalnix told me that one was specific to me because he wanted me to "choose sides"
 14 2018-02-16T00:32:22  * dongcarl *facepalm*
 15 2018-02-16T00:32:24  <jimmysong> no interest in aligning there
 16 2018-02-16T00:34:04  *** Cogito_Ergo_Sum has quit IRC
 17 2018-02-16T00:35:55  <Emcy_> lolol
 18 2018-02-16T00:36:06  <Emcy_> pick a side or we will pick one for you
 19 2018-02-16T00:36:46  <esotericnonsense> well, there is the flip side
 20 2018-02-16T00:37:12  <gmaxwell> :(
 21 2018-02-16T00:37:22  <esotericnonsense> as a bitcoin ABC contributor, I can go ahead and claim expert authority on the project being a nonsense
 22 2018-02-16T00:37:23  <Emcy_> youll have to bunk with rog if you choose the flip side
 23 2018-02-16T00:37:27  <gmaxwell> how did he expect that to work
 24 2018-02-16T00:37:38  <gmaxwell> meh, sorry I'm being offtopic
 25 2018-02-16T00:38:37  *** Murch has quit IRC
 26 2018-02-16T00:39:01  <Emcy_> jimmysong isnt deadlnix one of them libertarian voluntaryists ive heard so much about
 27 2018-02-16T00:39:06  <Emcy_> really interesting praxis
 28 2018-02-16T00:39:35  *** dfgsr has joined #bitcoin-core-dev
 29 2018-02-16T00:40:24  <jimmysong> i guess he wanted me to say "yes i'm a contributor to bch"
 30 2018-02-16T00:40:26  <jimmysong> or something like that
 31 2018-02-16T00:40:54  <esotericnonsense> heh
 32 2018-02-16T00:41:07  <Emcy_> bolster the 'multiple independent developers' rhetoric id guess
 33 2018-02-16T00:41:14  <jimmysong> something like that
 34 2018-02-16T00:41:21  <jimmysong> still don't understand why he did it that way
 35 2018-02-16T00:41:28  <jimmysong> just makes him look bad
 36 2018-02-16T00:41:39  <Emcy_> because hes a prick
 37 2018-02-16T00:41:42  <Emcy_> applying occams razor
 38 2018-02-16T00:42:00  <sipa> please, can we stick to technical topics relating to bitcoin core here
 39 2018-02-16T00:42:05  <jimmysong> sorry
 40 2018-02-16T00:49:38  *** hsmiths has quit IRC
 41 2018-02-16T00:49:39  *** dfgsr has quit IRC
 42 2018-02-16T00:50:42  *** hsmiths has joined #bitcoin-core-dev
 43 2018-02-16T00:51:02  *** anome has quit IRC
 44 2018-02-16T00:52:41  *** Francisco16Schow has joined #bitcoin-core-dev
 45 2018-02-16T00:53:55  *** sengehest has joined #bitcoin-core-dev
 46 2018-02-16T00:55:04  *** farmerwampum_ has joined #bitcoin-core-dev
 47 2018-02-16T00:59:24  *** dabura667 has joined #bitcoin-core-dev
 48 2018-02-16T01:01:04  *** sengehest has quit IRC
 49 2018-02-16T01:05:30  *** Emcy_ has quit IRC
 50 2018-02-16T01:15:07  *** Emcy has joined #bitcoin-core-dev
 51 2018-02-16T01:15:53  <Emcy> whoops i thought this was forks sorry
 52 2018-02-16T01:20:44  *** Emcy has quit IRC
 53 2018-02-16T01:23:18  *** Emcy has joined #bitcoin-core-dev
 54 2018-02-16T01:25:20  *** Murch has joined #bitcoin-core-dev
 55 2018-02-16T01:39:54  *** jamespeerless has joined #bitcoin-core-dev
 56 2018-02-16T01:54:49  *** sengehest has joined #bitcoin-core-dev
 57 2018-02-16T01:58:49  *** Francisco16Schow has quit IRC
 58 2018-02-16T01:59:29  *** sengehest has quit IRC
 59 2018-02-16T02:23:02  *** Murch has quit IRC
 60 2018-02-16T02:25:35  *** jb55 has joined #bitcoin-core-dev
 61 2018-02-16T02:45:46  *** ProfMac has quit IRC
 62 2018-02-16T02:47:37  *** sengehest has joined #bitcoin-core-dev
 63 2018-02-16T02:51:57  *** sengehest has quit IRC
 64 2018-02-16T02:52:43  *** Andreanne8Howe has joined #bitcoin-core-dev
 65 2018-02-16T02:57:27  *** Andreanne8Howe has quit IRC
 66 2018-02-16T03:02:38  *** sengehest has joined #bitcoin-core-dev
 67 2018-02-16T03:04:26  *** Giszmo has joined #bitcoin-core-dev
 68 2018-02-16T03:07:05  *** sengehest has quit IRC
 69 2018-02-16T03:09:55  *** meshcollider_ has joined #bitcoin-core-dev
 70 2018-02-16T03:10:11  *** meshcollider_ has quit IRC
 71 2018-02-16T03:18:45  *** ProfMac has joined #bitcoin-core-dev
 72 2018-02-16T03:18:51  *** jamespeerless has quit IRC
 73 2018-02-16T03:47:20  *** sengehest has joined #bitcoin-core-dev
 74 2018-02-16T03:48:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 75 2018-02-16T03:51:40  *** sengehest has quit IRC
 76 2018-02-16T03:52:35  *** Robin53Bartell has joined #bitcoin-core-dev
 77 2018-02-16T03:53:39  *** sengehest has joined #bitcoin-core-dev
 78 2018-02-16T03:57:57  *** sengehest has quit IRC
 79 2018-02-16T04:00:08  *** Chris_Stewart_5 has quit IRC
 80 2018-02-16T04:00:10  *** Madars has quit IRC
 81 2018-02-16T04:01:09  *** AriseChikun has quit IRC
 82 2018-02-16T04:05:27  *** Madars has joined #bitcoin-core-dev
 83 2018-02-16T04:15:28  <fanquake> meshcollider could you do that script testing on your own repo?
 84 2018-02-16T04:16:25  <meshcollider> fanquake: sorry, is it emailing you? Just finished testing it on my repo so its done anyway :)
 85 2018-02-16T04:18:55  <fanquake> meshcollider yes, ok
 86 2018-02-16T04:19:34  *** jojeyh has joined #bitcoin-core-dev
 87 2018-02-16T04:19:35  <meshcollider> fanquake: why is it emailing you if travis isn't even enabled on the repo? Or does it notify you of all PR changes?
 88 2018-02-16T04:21:17  <fanquake> meshcolllier you get notified of PR changes
 89 2018-02-16T04:24:13  *** AriseChikun has joined #bitcoin-core-dev
 90 2018-02-16T04:36:04  *** AriseChikun has quit IRC
 91 2018-02-16T04:36:32  *** AriseChikun has joined #bitcoin-core-dev
 92 2018-02-16T04:39:54  *** justan0theruser has joined #bitcoin-core-dev
 93 2018-02-16T04:40:19  *** justanotheruser has quit IRC
 94 2018-02-16T04:41:52  *** Giszmo has quit IRC
 95 2018-02-16T04:48:25  *** sengehest has joined #bitcoin-core-dev
 96 2018-02-16T04:52:57  *** sengehest has quit IRC
 97 2018-02-16T05:06:32  *** PINKY62 has joined #bitcoin-core-dev
 98 2018-02-16T05:24:17  *** niska has quit IRC
 99 2018-02-16T05:32:53  *** niska has joined #bitcoin-core-dev
100 2018-02-16T05:33:58  *** fb has joined #bitcoin-core-dev
101 2018-02-16T05:34:21  *** fb is now known as Guest2711
102 2018-02-16T05:36:33  *** Guest2711 has quit IRC
103 2018-02-16T05:36:53  *** cryptojanitor has quit IRC
104 2018-02-16T05:45:08  *** ProfMac has quit IRC
105 2018-02-16T05:47:38  *** sengehest has joined #bitcoin-core-dev
106 2018-02-16T05:47:43  *** jb55 has quit IRC
107 2018-02-16T05:49:14  *** grafcaps has quit IRC
108 2018-02-16T05:57:05  *** neha has quit IRC
109 2018-02-16T05:58:24  *** neha has joined #bitcoin-core-dev
110 2018-02-16T06:00:14  *** PINKY62 has quit IRC
111 2018-02-16T06:00:57  *** sengehest has quit IRC
112 2018-02-16T06:07:21  *** harrymm_ has quit IRC
113 2018-02-16T06:10:14  *** mmgen has joined #bitcoin-core-dev
114 2018-02-16T06:20:34  *** harrymm_ has joined #bitcoin-core-dev
115 2018-02-16T06:32:19  <GitHub1> [bitcoin-detached-sigs] jonasschnelli opened pull request #4: 0.16: osx signatures for 0.16.0rc4 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
116 2018-02-16T06:46:33  *** meshcollider has quit IRC
117 2018-02-16T07:00:23  *** windsok has quit IRC
118 2018-02-16T07:00:55  *** windsok has joined #bitcoin-core-dev
119 2018-02-16T07:07:35  *** mmgen has quit IRC
120 2018-02-16T07:09:36  *** mmgen has joined #bitcoin-core-dev
121 2018-02-16T07:34:16  *** denis2342 has joined #bitcoin-core-dev
122 2018-02-16T07:36:19  <denis2342> I have a small build regression on freebsd with 0.16.0rc4: https://pastebin.com/i9zPDKXd
123 2018-02-16T07:36:33  <denis2342> seems a header is missing
124 2018-02-16T07:48:11  <denis2342> adding #include <signal.h> to src/test/util_tests.cpp fixes the problem
125 2018-02-16T08:04:15  *** promag has joined #bitcoin-core-dev
126 2018-02-16T08:04:32  *** tryphe has quit IRC
127 2018-02-16T08:04:56  *** tryphe has joined #bitcoin-core-dev
128 2018-02-16T08:07:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a233fb4f1d03...1f055ef9d798
129 2018-02-16T08:07:25  <bitcoin-git> bitcoin/master d7f438a Cory Fields: gitian: bump descriptors for (0.)17
130 2018-02-16T08:07:26  <bitcoin-git> bitcoin/master 1f055ef Wladimir J. van der Laan: Merge #12444: gitian: bump descriptors for (0.)17...
131 2018-02-16T08:08:21  <bitcoin-git> [bitcoin] laanwj closed pull request #12444: gitian: bump descriptors for (0.)17 (master...gitian-bump) https://github.com/bitcoin/bitcoin/pull/12444
132 2018-02-16T08:10:15  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1f055ef9d798...26dc2daf82d2
133 2018-02-16T08:10:15  <bitcoin-git> bitcoin/master be45a67 Richard Kiss: Add some script tests related to BOOL ops and odd values like negative 0.
134 2018-02-16T08:10:16  <bitcoin-git> bitcoin/master 26dc2da Wladimir J. van der Laan: Merge #12425: Add some script tests...
135 2018-02-16T08:11:03  <bitcoin-git> [bitcoin] laanwj closed pull request #12425: Add some script tests (master...feature/bool_tests) https://github.com/bitcoin/bitcoin/pull/12425
136 2018-02-16T08:19:17  <wumpus> denis2342: hrm, I'll try rebuildilng my freebsd node and see if I run into the same
137 2018-02-16T08:19:32  *** dund has quit IRC
138 2018-02-16T08:21:31  *** promag has quit IRC
139 2018-02-16T08:33:41  *** anome has joined #bitcoin-core-dev
140 2018-02-16T08:40:20  *** meshcollider has joined #bitcoin-core-dev
141 2018-02-16T08:48:10  *** tma98 has joined #bitcoin-core-dev
142 2018-02-16T08:48:53  <tma98> hi
143 2018-02-16T08:54:08  *** tma98 has quit IRC
144 2018-02-16T09:05:54  *** anome has quit IRC
145 2018-02-16T09:24:30  *** promag has joined #bitcoin-core-dev
146 2018-02-16T09:26:17  *** d3vt4r has joined #bitcoin-core-dev
147 2018-02-16T09:27:29  *** timothy has joined #bitcoin-core-dev
148 2018-02-16T09:32:51  *** denis2342_ has joined #bitcoin-core-dev
149 2018-02-16T09:33:51  *** lnostdal has joined #bitcoin-core-dev
150 2018-02-16T09:34:11  *** denis2342 has quit IRC
151 2018-02-16T09:38:14  *** d_t has quit IRC
152 2018-02-16T09:45:02  *** lnostdal has quit IRC
153 2018-02-16T09:45:17  *** lnostdal has joined #bitcoin-core-dev
154 2018-02-16T09:46:19  *** larafale has joined #bitcoin-core-dev
155 2018-02-16T09:55:37  *** anome has joined #bitcoin-core-dev
156 2018-02-16T10:01:00  *** Guyver2 has joined #bitcoin-core-dev
157 2018-02-16T10:13:54  *** d3vt4r has quit IRC
158 2018-02-16T10:18:49  *** larafale has quit IRC
159 2018-02-16T10:26:33  <fanquake> wumpus I agree with closing https://github.com/bitcoin-core/gitian.sigs/pull/614
160 2018-02-16T10:27:57  <fanquake> #678 is more interesting as a quick check, making sure that submitters are only modifying a single dir. However that is still a trivial thing to check anyways.
161 2018-02-16T10:27:58  <gribble> https://github.com/bitcoin/bitcoin/issues/678 | changing the GUI language · Issue #678 · bitcoin/bitcoin · GitHub
162 2018-02-16T10:28:15  *** AaronvanW has joined #bitcoin-core-dev
163 2018-02-16T10:29:20  *** Aaronvan_ has joined #bitcoin-core-dev
164 2018-02-16T10:29:32  <wumpus> fanquake: I think it's difficult, I mwan from a user perspective it's useful to be alerted when signatures diverge, what "m less convinced about is that travis is always the right hammer for the job
165 2018-02-16T10:30:16  <wumpus> FWIW this is the same feeling that I have with hooking all kinds of things like whitespace linters into travis. If there was a better way to customize the message/icon that appears in the github issue it'd be better.
166 2018-02-16T10:30:17  <fanquake> I also agree that diverging/"incorrect" signatures should be merged regardless.
167 2018-02-16T10:30:30  <wumpus> yep, something could warn after merging
168 2018-02-16T10:32:40  *** AaronvanW has quit IRC
169 2018-02-16T10:39:19  <promag> wumpus: https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159
170 2018-02-16T10:39:46  <promag> circle does what you want https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159
171 2018-02-16T10:41:17  *** larafale has joined #bitcoin-core-dev
172 2018-02-16T11:02:40  <bitcoin-git> [bitcoin] laanwj opened pull request #12447: test: Add missing signal.h header (master...2018_02_freebsd_compile_fix) https://github.com/bitcoin/bitcoin/pull/12447
173 2018-02-16T11:03:35  *** promag has quit IRC
174 2018-02-16T11:08:38  <wumpus> promag: interesting!
175 2018-02-16T11:17:28  *** laurentmt has joined #bitcoin-core-dev
176 2018-02-16T11:17:31  *** denis2342_ has quit IRC
177 2018-02-16T11:20:25  *** larafale has quit IRC
178 2018-02-16T11:21:40  *** Robin53Bartell has quit IRC
179 2018-02-16T11:40:05  *** dabura667 has quit IRC
180 2018-02-16T11:52:35  *** Garrison16Lockma has joined #bitcoin-core-dev
181 2018-02-16T11:58:33  *** cryptojanitor has joined #bitcoin-core-dev
182 2018-02-16T12:14:18  *** anome has quit IRC
183 2018-02-16T12:19:28  *** jamesob has joined #bitcoin-core-dev
184 2018-02-16T12:21:01  *** promag has joined #bitcoin-core-dev
185 2018-02-16T12:25:19  *** shesek has quit IRC
186 2018-02-16T12:32:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
187 2018-02-16T12:36:40  *** laurentmt has quit IRC
188 2018-02-16T12:40:26  *** jojeyh has quit IRC
189 2018-02-16T12:43:16  *** Deinogalerix21 has joined #bitcoin-core-dev
190 2018-02-16T12:45:54  *** laurentmt has joined #bitcoin-core-dev
191 2018-02-16T13:03:32  <bitcoin-git> [bitcoin] promag opened pull request #12448: Interrupt block generation on shutdown request (master...2018-02-interrupt-generate-blocks) https://github.com/bitcoin/bitcoin/pull/12448
192 2018-02-16T13:06:56  *** dermoth has joined #bitcoin-core-dev
193 2018-02-16T13:09:29  <promag> wumpus: what kind of test?
194 2018-02-16T13:09:54  <promag> generate bigcount and in parallel quit?
195 2018-02-16T13:10:16  <wumpus> well in this case a test that does generateblock 10000 then sends an interrupt request and checks that bitcoin shuts down cleanly
196 2018-02-16T13:10:23  <wumpus> though I'd argue this is not an important one to test
197 2018-02-16T13:10:48  <wumpus> the early-outs in init, are
198 2018-02-16T13:11:24  <promag> right
199 2018-02-16T13:11:54  <promag> I was benchmarking stuff and did generate 100000
200 2018-02-16T13:11:55  *** SopaXorzTaker has joined #bitcoin-core-dev
201 2018-02-16T13:11:58  <wumpus> (that is where we had two fixes for, in the rc cycle... because early-outs leave the process in an inconsistent, or at least unpexpected state that may cause trouble later)
202 2018-02-16T13:12:08  <promag> and then I had to kill -9 otherwise it didn't stop
203 2018-02-16T13:12:53  <wumpus> which is fine, no one does software development perfectly, seeing all potential conseequences to a change (if only!), but illustrates tests are needed
204 2018-02-16T13:13:32  <promag> and generateBlocks is non main net right?
205 2018-02-16T13:15:47  *** Deinogalerix21 has quit IRC
206 2018-02-16T13:19:04  *** promag has quit IRC
207 2018-02-16T13:19:04  <wumpus> if you can use it for mainnet, interrupting *between* blocks isn't going to help you
208 2018-02-16T13:20:02  <wumpus> even generating one block at the current difficulty with the naive, single-threaded miner meant for regtest is going to take a million years
209 2018-02-16T13:40:00  *** jochemin has quit IRC
210 2018-02-16T13:40:27  *** jochemin has joined #bitcoin-core-dev
211 2018-02-16T13:40:40  *** laurentmt has quit IRC
212 2018-02-16T13:41:09  *** Chris_Stewart_5 has quit IRC
213 2018-02-16T13:47:39  *** fanquake has quit IRC
214 2018-02-16T13:48:32  *** dermoth has quit IRC
215 2018-02-16T13:49:09  *** jochemin has quit IRC
216 2018-02-16T13:49:40  *** dermoth has joined #bitcoin-core-dev
217 2018-02-16T13:55:16  *** jamespeerless has joined #bitcoin-core-dev
218 2018-02-16T13:58:23  *** jamesob has quit IRC
219 2018-02-16T14:00:51  *** esotericnonsense has quit IRC
220 2018-02-16T14:01:10  *** Garrison16Lockma has quit IRC
221 2018-02-16T14:03:03  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12451: Bump leveldb subtree (master...Mf1802-leveldbSubtreeBump) https://github.com/bitcoin/bitcoin/pull/12451
222 2018-02-16T14:04:43  *** esotericnonsense has joined #bitcoin-core-dev
223 2018-02-16T14:04:49  *** jamespeerless has quit IRC
224 2018-02-16T14:18:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26dc2daf82d2...4a62ddd01873
225 2018-02-16T14:18:13  <bitcoin-git> bitcoin/master dd7e42c Wladimir J. van der Laan: test: Add missing signal.h header...
226 2018-02-16T14:18:14  <bitcoin-git> bitcoin/master 4a62ddd MarcoFalke: Merge #12447: test: Add missing signal.h header...
227 2018-02-16T14:19:05  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12447: test: Add missing signal.h header (master...2018_02_freebsd_compile_fix) https://github.com/bitcoin/bitcoin/pull/12447
228 2018-02-16T14:21:46  *** farmerwampum_ has quit IRC
229 2018-02-16T14:26:44  *** jamesob has joined #bitcoin-core-dev
230 2018-02-16T14:32:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
231 2018-02-16T14:35:08  *** jamespeerless has joined #bitcoin-core-dev
232 2018-02-16T14:36:46  *** promag has joined #bitcoin-core-dev
233 2018-02-16T14:37:41  <provoostenator> I added an #ifdef ENABLE_WALLET in guiutil.h, but the compiler seems to think this is undefined for this particular file even though I configured with the wallet enabled.
234 2018-02-16T14:41:04  *** promag has quit IRC
235 2018-02-16T14:45:40  <kallewoof> provoostenator: you may need to do the HAVE_CONFIG_H deal first? (e.g. compat.h style)
236 2018-02-16T14:47:00  *** promag has joined #bitcoin-core-dev
237 2018-02-16T14:49:08  <provoostenator> kallewoof: thanks, that did the trick. What does it do?
238 2018-02-16T14:52:35  *** Georgiana72West has joined #bitcoin-core-dev
239 2018-02-16T14:55:05  *** promag has quit IRC
240 2018-02-16T15:00:14  *** Aaronvan_ is now known as AaronvanW
241 2018-02-16T15:04:10  *** ProfMac has joined #bitcoin-core-dev
242 2018-02-16T15:11:01  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
243 2018-02-16T15:11:01  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
244 2018-02-16T15:13:37  *** Georgiana72West has quit IRC
245 2018-02-16T15:14:07  *** laurentmt has joined #bitcoin-core-dev
246 2018-02-16T15:14:17  *** laurentmt has quit IRC
247 2018-02-16T15:23:11  <kallewoof> provoostenator: it pulls in defines from autoconf etc, I believe
248 2018-02-16T15:27:55  *** mirese_ has joined #bitcoin-core-dev
249 2018-02-16T15:31:04  *** mirese has quit IRC
250 2018-02-16T15:34:57  *** dcousens has quit IRC
251 2018-02-16T15:35:40  *** dcousens has joined #bitcoin-core-dev
252 2018-02-16T15:36:27  *** promag has joined #bitcoin-core-dev
253 2018-02-16T15:41:23  *** promag has quit IRC
254 2018-02-16T15:46:20  *** rosdi has joined #bitcoin-core-dev
255 2018-02-16T15:52:36  *** Maynard11Spinka has joined #bitcoin-core-dev
256 2018-02-16T15:53:24  *** rosdi has quit IRC
257 2018-02-16T15:58:31  *** AriseChikun has quit IRC
258 2018-02-16T16:00:40  *** RubenSomsen has joined #bitcoin-core-dev
259 2018-02-16T16:02:33  *** Maynard11Spinka has quit IRC
260 2018-02-16T16:05:05  *** belcher has joined #bitcoin-core-dev
261 2018-02-16T16:07:44  *** Victorsueca has quit IRC
262 2018-02-16T16:08:53  *** Victorsueca has joined #bitcoin-core-dev
263 2018-02-16T16:36:31  <cfields> yep
264 2018-02-16T16:36:45  <cfields> it's so that you can tell the difference between autoconf'd builds and non
265 2018-02-16T16:37:39  <cfields> for ex, you can (or could at one point) build bitcoind with MSVC, you just have to define all of the stuff that autoconf would've detected for you
266 2018-02-16T16:39:09  *** Deinogalerix21 has joined #bitcoin-core-dev
267 2018-02-16T16:40:39  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/4a62ddd01873...59e032b43cea
268 2018-02-16T16:40:40  <bitcoin-git> bitcoin/master 5a10859 fanquake: [depends] expat 2.2.5
269 2018-02-16T16:40:40  <bitcoin-git> bitcoin/master 61647a4 fanquake: [depends] ccache 3.4.1
270 2018-02-16T16:40:41  <bitcoin-git> bitcoin/master 41550d6 fanquake: [depends] miniupnpc 2.0.20180203
271 2018-02-16T16:41:27  <bitcoin-git> [bitcoin] laanwj closed pull request #12402: [depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203 (master...depends-02-2018) https://github.com/bitcoin/bitcoin/pull/12402
272 2018-02-16T16:42:13  <cfields> wumpus: that one wasn't ready yet :\
273 2018-02-16T16:51:23  *** grafcaps has joined #bitcoin-core-dev
274 2018-02-16T16:52:15  *** promag has joined #bitcoin-core-dev
275 2018-02-16T16:52:35  *** Ericka76Shields has joined #bitcoin-core-dev
276 2018-02-16T16:57:12  *** promag has quit IRC
277 2018-02-16T16:57:26  *** grafcaps has quit IRC
278 2018-02-16T17:02:38  *** Ericka76Shields has quit IRC
279 2018-02-16T17:04:34  <wumpus> cfields: what's the problem?
280 2018-02-16T17:11:46  *** Randolf has joined #bitcoin-core-dev
281 2018-02-16T17:11:59  *** instagibbs has quit IRC
282 2018-02-16T17:18:43  *** meshcollider has quit IRC
283 2018-02-16T17:19:57  *** instagibbs has joined #bitcoin-core-dev
284 2018-02-16T17:26:20  *** grafcaps has joined #bitcoin-core-dev
285 2018-02-16T17:39:56  *** owowo has quit IRC
286 2018-02-16T17:41:44  *** promag has joined #bitcoin-core-dev
287 2018-02-16T17:42:25  *** RubenSomsen has quit IRC
288 2018-02-16T17:43:55  *** jb55 has joined #bitcoin-core-dev
289 2018-02-16T17:44:47  *** owowo has joined #bitcoin-core-dev
290 2018-02-16T17:46:41  *** promag has quit IRC
291 2018-02-16T17:47:26  *** Murch has joined #bitcoin-core-dev
292 2018-02-16T17:52:35  *** Curtis27Boyle has joined #bitcoin-core-dev
293 2018-02-16T17:56:37  <gmaxwell> Someone noticed again that cross chain swaps can be broken due to different size limits on different systems https://bitcointalk.org/index.php?topic=2960023.0
294 2018-02-16T17:56:45  <gmaxwell> sipa: do you recall where this was previously pointed out?
295 2018-02-16T18:03:13  *** timothy has quit IRC
296 2018-02-16T18:19:10  *** Curtis27Boyle has quit IRC
297 2018-02-16T18:21:56  <GitHub194> [bitcoin-detached-sigs] theuni closed pull request #4: 0.16: osx signatures for 0.16.0rc4 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
298 2018-02-16T18:23:02  <cfields> gitian builders: v0.16.0rc4 detached sigs are pushed
299 2018-02-16T18:23:35  <cfields> wumpus: the darwin define for miniupnpc is done universally
300 2018-02-16T18:23:47  <cfields> I'll nag on the PR
301 2018-02-16T18:25:26  <wumpus> cfields: whoops so that define is for upnp itself, not a hint to darwin. I thought it was the latter so defining it universally wouldn't hurt.
302 2018-02-16T18:26:22  <cfields> right. it's unlikely to be an issue, but if it turned out to manifest somewhere, it'd be really nasty to track down
303 2018-02-16T18:30:05  *** Deinogalerix21 has quit IRC
304 2018-02-16T18:30:26  *** Victorsueca has quit IRC
305 2018-02-16T18:31:52  *** Victorsueca has joined #bitcoin-core-dev
306 2018-02-16T18:34:53  <jcorgan> is there a how-to-do-gitian-builds-for-fun-and-profit-and-mental-health.md somewhere?
307 2018-02-16T18:36:23  <achow101> jcorgan: https://github.com/bitcoin-core/docs/tree/master/gitian-building and https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md
308 2018-02-16T18:36:24  <achow101> good luck
309 2018-02-16T18:38:27  <jcorgan> if you don't hear from me in 72 hours send out the search teams
310 2018-02-16T18:39:10  <wumpus> achow101: he's gonna need it
311 2018-02-16T18:43:53  *** farmerwampum has joined #bitcoin-core-dev
312 2018-02-16T18:49:51  <jnewbery> review beg: #10583 . achow101 has rebased about a squillion times
313 2018-02-16T18:49:56  <gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
314 2018-02-16T18:50:37  <bitcoin-git> [bitcoin] DaveFromBinary opened pull request #12452: [Docs] Clarified systemd installation instructions in init.md for Ubuntu users. (master...doc-init-updates) https://github.com/bitcoin/bitcoin/pull/12452
315 2018-02-16T18:52:38  *** Hector67Nader has joined #bitcoin-core-dev
316 2018-02-16T18:53:19  *** belcher has quit IRC
317 2018-02-16T18:57:27  *** Hector67Nader has quit IRC
318 2018-02-16T18:57:47  *** jb55 has quit IRC
319 2018-02-16T19:06:31  <bitcoin-git> [bitcoin] Empact opened pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (master...fix-bip68-test) https://github.com/bitcoin/bitcoin/pull/12455
320 2018-02-16T19:12:17  *** promag has joined #bitcoin-core-dev
321 2018-02-16T19:16:38  *** promag has quit IRC
322 2018-02-16T19:20:06  *** promag has joined #bitcoin-core-dev
323 2018-02-16T19:24:10  *** promag has quit IRC
324 2018-02-16T19:29:54  <ProfMac> I did a gitian build back in 0.14.xx.  The process was not well documented, and I could not reproduce whatever I did from my notes.  Is the documentation process any better now?
325 2018-02-16T19:30:11  *** d_t has joined #bitcoin-core-dev
326 2018-02-16T19:39:11  <wumpus> https://github.com/bitcoin-core/docs/blob/master/gitian-building.md
327 2018-02-16T19:39:25  <wumpus> improvements are always welcome
328 2018-02-16T19:40:48  <achow101> I don't think the problem is documentation but rather that gitian doesn't always work
329 2018-02-16T19:43:51  *** promag has joined #bitcoin-core-dev
330 2018-02-16T19:46:13  <MarcoFalke> It is like Jenga. All the virtualizations or OSes that it depends on pull out sticks and you wait until it breaks
331 2018-02-16T19:48:42  *** promag has quit IRC
332 2018-02-16T19:52:36  *** Leopoldo4Heaney has joined #bitcoin-core-dev
333 2018-02-16T19:54:02  *** mmgen has quit IRC
334 2018-02-16T20:00:22  *** grafcaps has quit IRC
335 2018-02-16T20:02:39  *** Leopoldo4Heaney has quit IRC
336 2018-02-16T20:05:46  *** promag has joined #bitcoin-core-dev
337 2018-02-16T20:10:13  *** intcat has quit IRC
338 2018-02-16T20:10:41  *** promag has quit IRC
339 2018-02-16T20:11:08  *** d_t has quit IRC
340 2018-02-16T20:11:50  <bitcoin-git> [bitcoin] Empact opened pull request #12458: Enforce that amount is provided for signrawtransaction prevtxs (master...rawtransaction-amount-required) https://github.com/bitcoin/bitcoin/pull/12458
341 2018-02-16T20:12:12  *** intcat has joined #bitcoin-core-dev
342 2018-02-16T20:25:55  *** jb55 has joined #bitcoin-core-dev
343 2018-02-16T20:28:57  <esotericnonsense> is univalue compiled seperately without C++11 ? i'm struggling with my make-fu
344 2018-02-16T20:29:06  <esotericnonsense> it disagrees with my use of nullptr
345 2018-02-16T20:29:46  *** SopaXorzTaker has quit IRC
346 2018-02-16T20:33:50  <esotericnonsense> yeah, that's it.
347 2018-02-16T20:37:53  <bitcoin-git> [bitcoin] Empact opened pull request #12459: Assert compressed / compact keys and sigs are strictly shorter than regular (master...assert-compressed-smaller) https://github.com/bitcoin/bitcoin/pull/12459
348 2018-02-16T20:38:01  <bitcoin-git> [bitcoin] Empact opened pull request #12460: Assert CPubKey::ValidLength to the pubkey's header-relevent size (master...key-size-check-header) https://github.com/bitcoin/bitcoin/pull/12460
349 2018-02-16T20:39:41  <bitcoin-git> [bitcoin] Empact opened pull request #12461: Refactor key / signature size consts to be relative to their relevant class (master...key-size-consts) https://github.com/bitcoin/bitcoin/pull/12461
350 2018-02-16T20:39:47  *** promag has joined #bitcoin-core-dev
351 2018-02-16T20:40:57  <bitcoin-git> [bitcoin] Empact closed pull request #12319: Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references (master...pubkeysize) https://github.com/bitcoin/bitcoin/pull/12319
352 2018-02-16T20:42:01  <cfields> esotericnonsense: "yeah, that's it" ?
353 2018-02-16T20:43:48  <esotericnonsense> cfields: if I hack in g++ -std=c++11 into the makefile for univalue that works (I'm currently trying to figure out how to do this properly and fixing up some other compilation errors)
354 2018-02-16T20:44:03  <cfields> yikes!
355 2018-02-16T20:44:10  *** promag has quit IRC
356 2018-02-16T20:44:31  <esotericnonsense> what's yikes? that we weren't using c++11 for univalue? the concept of using it? :)
357 2018-02-16T20:44:49  *** grubles has quit IRC
358 2018-02-16T20:44:59  <cfields> yikes that we're possibly mixing ABIs in our binaries
359 2018-02-16T20:45:16  <cfields> I'm surprised we haven't seen issues from that yet
360 2018-02-16T20:45:54  <esotericnonsense> mmm. unfortunately my knowledge of this stuff has kind of faded after spending years in python-land. slowly getting there again.
361 2018-02-16T20:46:23  *** Chris_Stewart_5 has quit IRC
362 2018-02-16T20:46:31  <cfields> heh, no worries
363 2018-02-16T20:46:52  <cfields> I'll PR a fix, unless you want to drill down into it
364 2018-02-16T20:48:17  <esotericnonsense> up to you. i'm making a small change to univalue that requires it, but my knowledge of make is very limited (i'
365 2018-02-16T20:48:32  <esotericnonsense> (i'd just be hacking in -std=c+11 into flags until it works on my box)
366 2018-02-16T20:49:01  <esotericnonsense> well it doesn't require it because I don't _need_ to use nullptr it's just consistent that way
367 2018-02-16T20:49:11  <bitcoin-git> [bitcoin] Empact opened pull request #12463: Drop the return argument from CValidationState::DoS and Invalid (master...drop-dos-return) https://github.com/bitcoin/bitcoin/pull/12463
368 2018-02-16T20:49:46  <bitcoin-git> [bitcoin] Empact closed pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
369 2018-02-16T20:51:03  <cfields> well, we haven't discussed it afaik, but it makes sense to keep univalue c++03 simply because it already is
370 2018-02-16T20:52:40  *** Mona87Dooley has joined #bitcoin-core-dev
371 2018-02-16T20:53:15  <sipa> cfields: using c++11 may be more efficient
372 2018-02-16T20:53:56  <sipa> because it gives stl automagival rvalue support
373 2018-02-16T20:54:02  <sipa> *automagical
374 2018-02-16T20:54:09  <cfields> sipa: sure. I think it makes sense to discuss bumping. It'd just be senseless to bump for some trivial change
375 2018-02-16T20:54:29  <cfields> sipa: or did you mean just compiling as c++11?
376 2018-02-16T20:54:55  <jnewbery> second review beg: #10579 for the same reasons as 10583. (Obviously not as important as anything v0.16 related, but I think for achow's sanity we should merge soon)
377 2018-02-16T20:54:57  <cfields> 'cause, yea, we'd see the rvalue optims from that alone
378 2018-02-16T20:54:58  <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
379 2018-02-16T20:55:03  *** jb552 has joined #bitcoin-core-dev
380 2018-02-16T20:55:29  <sipa> jnewbery: yes, absolutely
381 2018-02-16T20:55:33  <cfields> beg threshold hit, will review :)
382 2018-02-16T20:56:12  <cfields> sipa: my immediate concern is catching exceptions across ABIs, though
383 2018-02-16T20:56:54  *** jb55 has quit IRC
384 2018-02-16T20:57:01  <jnewbery> thanks sipa, thanks cfields!
385 2018-02-16T20:57:27  *** Mona87Dooley has quit IRC
386 2018-02-16T20:58:37  <instagibbs> i know I've reviewed that PR before... no comments, hm. Will do again.
387 2018-02-16T20:59:28  *** grubles has joined #bitcoin-core-dev
388 2018-02-16T21:00:26  *** promag has joined #bitcoin-core-dev
389 2018-02-16T21:01:41  <bitcoin-git> [bitcoin] jnewbery opened pull request #12464: Revert "[tests] bind functional test nodes to" (master...revert_12200) https://github.com/bitcoin/bitcoin/pull/12464
390 2018-02-16T21:05:35  *** jb552 has quit IRC
391 2018-02-16T21:05:35  *** Randolf has quit IRC
392 2018-02-16T21:08:51  <achow101> jnewbery: sanity? What's that?
393 2018-02-16T21:09:20  *** jb552 has joined #bitcoin-core-dev
394 2018-02-16T21:09:26  *** grafcaps has joined #bitcoin-core-dev
395 2018-02-16T21:11:13  *** zautomata1 has joined #bitcoin-core-dev
396 2018-02-16T21:11:29  *** owowo has quit IRC
397 2018-02-16T21:12:05  *** Victorsueca has quit IRC
398 2018-02-16T21:12:08  *** zautomata has quit IRC
399 2018-02-16T21:12:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/59e032b43cea...27c59dc502f2
400 2018-02-16T21:12:28  <bitcoin-git> bitcoin/master df47afb John Newbery: Revert "[tests] bind functional test nodes to"...
401 2018-02-16T21:12:29  <bitcoin-git> bitcoin/master 27c59dc MarcoFalke: Merge #12464: Revert "[tests] bind functional test nodes to"...
402 2018-02-16T21:13:17  *** Victorsueca has joined #bitcoin-core-dev
403 2018-02-16T21:13:23  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12464: Revert "[tests] bind functional test nodes to" (master...revert_12200) https://github.com/bitcoin/bitcoin/pull/12464
404 2018-02-16T21:13:43  *** zautomata2 has joined #bitcoin-core-dev
405 2018-02-16T21:14:59  *** grubles has quit IRC
406 2018-02-16T21:15:34  *** promag has quit IRC
407 2018-02-16T21:15:35  *** zautomata1 has quit IRC
408 2018-02-16T21:16:45  *** owowo has joined #bitcoin-core-dev
409 2018-02-16T21:17:27  *** neha has quit IRC
410 2018-02-16T21:18:21  *** intcat has quit IRC
411 2018-02-16T21:18:28  <jnewbery> :)
412 2018-02-16T21:19:00  *** neha has joined #bitcoin-core-dev
413 2018-02-16T21:20:14  *** intcat has joined #bitcoin-core-dev
414 2018-02-16T21:23:31  *** Giszmo has joined #bitcoin-core-dev
415 2018-02-16T21:23:32  *** Giszmo has quit IRC
416 2018-02-16T21:23:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27c59dc502f2...23481fa50301
417 2018-02-16T21:23:59  <bitcoin-git> bitcoin/master e710387 Ben Woosley: test: Fix bip68 sequence test to reflect updated rpc error message...
418 2018-02-16T21:24:00  <bitcoin-git> bitcoin/master 23481fa MarcoFalke: Merge #12455: Fix bip68 sequence test to reflect updated rpc error message...
419 2018-02-16T21:24:05  *** Giszmo has joined #bitcoin-core-dev
420 2018-02-16T21:24:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (master...fix-bip68-test) https://github.com/bitcoin/bitcoin/pull/12455
421 2018-02-16T21:27:10  *** jb553 has joined #bitcoin-core-dev
422 2018-02-16T21:30:24  *** jb552 has quit IRC
423 2018-02-16T21:33:35  <esotericnonsense> cfields: changed the univalue stuff to just use NULL instead of nullptr
424 2018-02-16T21:38:11  *** jb554 has joined #bitcoin-core-dev
425 2018-02-16T21:40:51  *** jb553 has quit IRC
426 2018-02-16T21:52:23  *** Randolf has joined #bitcoin-core-dev
427 2018-02-16T21:52:36  *** Cortez83Doyle has joined #bitcoin-core-dev
428 2018-02-16T21:52:45  *** jb554 has quit IRC
429 2018-02-16T21:53:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
430 2018-02-16T21:55:36  *** mirese has joined #bitcoin-core-dev
431 2018-02-16T21:56:10  *** mirese__ has joined #bitcoin-core-dev
432 2018-02-16T21:57:32  *** Cortez83Doyle has quit IRC
433 2018-02-16T21:59:33  *** mirese_ has quit IRC
434 2018-02-16T21:59:48  *** mirese has quit IRC
435 2018-02-16T22:05:29  *** mirese has joined #bitcoin-core-dev
436 2018-02-16T22:06:36  *** justan0theruser has quit IRC
437 2018-02-16T22:08:52  *** mirese__ has quit IRC
438 2018-02-16T22:10:08  *** mirese_ has joined #bitcoin-core-dev
439 2018-02-16T22:11:34  *** mirese__ has joined #bitcoin-core-dev
440 2018-02-16T22:13:40  *** mirese has quit IRC
441 2018-02-16T22:15:10  *** mirese_ has quit IRC
442 2018-02-16T22:34:50  *** jb554 has joined #bitcoin-core-dev
443 2018-02-16T22:36:13  *** spinza has quit IRC
444 2018-02-16T22:40:35  *** Giszmo has quit IRC
445 2018-02-16T22:44:34  *** Chris_Stewart_5 has quit IRC
446 2018-02-16T22:51:48  *** spinza has joined #bitcoin-core-dev
447 2018-02-16T22:51:52  *** mirese has joined #bitcoin-core-dev
448 2018-02-16T22:52:23  *** mirese_ has joined #bitcoin-core-dev
449 2018-02-16T22:52:35  *** Thomas64Runte has joined #bitcoin-core-dev
450 2018-02-16T22:52:47  *** jamespeerless has quit IRC
451 2018-02-16T22:52:57  *** jamesob has quit IRC
452 2018-02-16T22:53:52  *** mirese___ has joined #bitcoin-core-dev
453 2018-02-16T22:54:40  *** mirese__ has quit IRC
454 2018-02-16T22:56:28  *** mirese has quit IRC
455 2018-02-16T22:57:02  *** mirese_ has quit IRC
456 2018-02-16T22:57:32  *** Thomas64Runte has quit IRC
457 2018-02-16T23:01:12  *** Murch has quit IRC
458 2018-02-16T23:04:58  *** Guyver2 has quit IRC
459 2018-02-16T23:14:09  *** StopAndDecrypt has quit IRC
460 2018-02-16T23:15:07  *** StopAndDecrypt has joined #bitcoin-core-dev
461 2018-02-16T23:15:17  *** StopAndDecrypt has quit IRC
462 2018-02-16T23:15:17  *** StopAndDecrypt has joined #bitcoin-core-dev
463 2018-02-16T23:15:57  *** promag has joined #bitcoin-core-dev
464 2018-02-16T23:21:27  *** StopAndDecrypt has quit IRC
465 2018-02-16T23:21:48  *** StopAndDecrypt has joined #bitcoin-core-dev
466 2018-02-16T23:21:58  *** StopAndDecrypt has quit IRC
467 2018-02-16T23:21:58  *** StopAndDecrypt has joined #bitcoin-core-dev
468 2018-02-16T23:26:22  *** Victorsueca has quit IRC
469 2018-02-16T23:27:47  *** Victorsueca has joined #bitcoin-core-dev
470 2018-02-16T23:30:54  *** meshcollider has joined #bitcoin-core-dev
471 2018-02-16T23:37:21  *** Murch has joined #bitcoin-core-dev
472 2018-02-16T23:41:02  *** jojeyh has joined #bitcoin-core-dev
473 2018-02-16T23:52:35  *** Kali58Bayer has joined #bitcoin-core-dev
474 2018-02-16T23:57:06  *** Randolf has quit IRC
475 2018-02-16T23:57:40  *** Kali58Bayer has quit IRC