1 2018-03-14T00:00:03  *** weez17 has quit IRC
  2 2018-03-14T00:00:50  *** weez17 has joined #bitcoin-core-dev
  3 2018-03-14T00:06:29  *** dafunkiz_ has joined #bitcoin-core-dev
  4 2018-03-14T00:15:33  *** mangoicedtea has quit IRC
  5 2018-03-14T00:17:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0630974647da...18462960c0f1
  6 2018-03-14T00:17:21  <bitcoin-git> bitcoin/master 33eb907 Russell Yanofsky: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER...
  7 2018-03-14T00:17:21  <bitcoin-git> bitcoin/master 1846296 MarcoFalke: Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER...
  8 2018-03-14T00:18:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER (master...pr/locksmart) https://github.com/bitcoin/bitcoin/pull/12681
  9 2018-03-14T00:19:06  <bitcoin-git> [bitcoin] sipa opened pull request #12683: Fix more constness violations in serialization code (master...201803_moreser) https://github.com/bitcoin/bitcoin/pull/12683
 10 2018-03-14T00:22:53  *** CubicEarths has quit IRC
 11 2018-03-14T00:28:21  *** jimbouki has joined #bitcoin-core-dev
 12 2018-03-14T00:28:45  *** CubicEarths has joined #bitcoin-core-dev
 13 2018-03-14T00:29:35  *** arbitrary_guy has quit IRC
 14 2018-03-14T00:31:31  *** Deacyde has joined #bitcoin-core-dev
 15 2018-03-14T00:33:19  *** mangoicedtea has joined #bitcoin-core-dev
 16 2018-03-14T00:35:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 17 2018-03-14T00:39:05  *** CubicEarths has quit IRC
 18 2018-03-14T00:41:57  *** jimbouki has quit IRC
 19 2018-03-14T00:52:47  *** justanotheruser has quit IRC
 20 2018-03-14T00:54:12  *** meshcollider has joined #bitcoin-core-dev
 21 2018-03-14T00:54:16  *** justanotheruser has joined #bitcoin-core-dev
 22 2018-03-14T00:54:38  *** justanotheruser has quit IRC
 23 2018-03-14T00:54:58  *** justanotheruser has joined #bitcoin-core-dev
 24 2018-03-14T00:54:58  *** jimbouki has joined #bitcoin-core-dev
 25 2018-03-14T00:59:22  *** mangoicedtea has quit IRC
 26 2018-03-14T00:59:59  *** justanotheruser has quit IRC
 27 2018-03-14T01:00:34  *** justanotheruser has joined #bitcoin-core-dev
 28 2018-03-14T01:01:09  *** CapitanRetardo has quit IRC
 29 2018-03-14T01:01:26  *** belcher_ has quit IRC
 30 2018-03-14T01:14:46  *** go1111111 has quit IRC
 31 2018-03-14T01:14:53  *** dafunkiz_ has quit IRC
 32 2018-03-14T01:14:54  *** EpicBaldGuy has quit IRC
 33 2018-03-14T01:20:49  *** schmidty has joined #bitcoin-core-dev
 34 2018-03-14T01:21:13  *** schmidty is now known as Guest75173
 35 2018-03-14T01:22:09  *** Chris_Stewart_5 has quit IRC
 36 2018-03-14T01:22:34  *** dafunkiz_ has joined #bitcoin-core-dev
 37 2018-03-14T01:23:00  *** Giszmo has quit IRC
 38 2018-03-14T01:25:33  *** Guest75173 has quit IRC
 39 2018-03-14T01:28:21  *** jimbouki has quit IRC
 40 2018-03-14T01:28:49  *** Samdney has quit IRC
 41 2018-03-14T01:28:51  *** jimbouki has joined #bitcoin-core-dev
 42 2018-03-14T01:29:33  *** tied2chainz has joined #bitcoin-core-dev
 43 2018-03-14T01:30:09  <tied2chainz> hi
 44 2018-03-14T01:30:41  <tied2chainz> just have a really quick question about version 16.
 45 2018-03-14T01:31:32  *** jimbouki_ has joined #bitcoin-core-dev
 46 2018-03-14T01:31:48  *** BashCo_ has joined #bitcoin-core-dev
 47 2018-03-14T01:32:11  *** jimbouki has quit IRC
 48 2018-03-14T01:32:35  *** BashCo has quit IRC
 49 2018-03-14T01:32:55  <sipa> tied2chainz: shoot
 50 2018-03-14T01:33:12  <sipa> (and generally just ask, don't ask to ask)
 51 2018-03-14T01:34:17  <Randolf> (Slow questions are okay too.)
 52 2018-03-14T01:34:53  *** dafunkiz_ has quit IRC
 53 2018-03-14T01:35:16  <tied2chainz> wanted to know can I also lookup transactions outside of send and receive transactions.
 54 2018-03-14T01:35:23  <sipa> no
 55 2018-03-14T01:35:56  <tied2chainz> only transactions that I've received or sent through my wallet
 56 2018-03-14T01:36:09  <sipa> unless you enable the transaction index (run with -txindex, or put txindex=1 in bitcoin.conf; that will enable the getrawtransaction txid RPC which works for all transactions, not just your own)
 57 2018-03-14T01:36:52  <sipa> it will require a full rebuild of the database though, and slows things down significantly
 58 2018-03-14T01:37:40  <tied2chainz> yeah thanks for the heads
 59 2018-03-14T01:37:45  <eklitzke> interesting, somehow i corrupted my chainstate directory
 60 2018-03-14T01:37:48  <tied2chainz> thanks for the heads up
 61 2018-03-14T01:38:15  <sipa> eklitzke: what did you do?
 62 2018-03-14T01:40:59  <kallewoof> tied2chainz: You can look them up if you know the block hash they're in.
 63 2018-03-14T01:41:10  *** Giszmo has joined #bitcoin-core-dev
 64 2018-03-14T01:41:20  <kallewoof> tied2chainz: Even without -txindex.
 65 2018-03-14T01:41:39  <eklitzke> https://paste.fedoraproject.org/paste/QsExxEOQwQOAGqT1rvPkAw
 66 2018-03-14T01:41:52  <eklitzke> it looks like it shut down normally
 67 2018-03-14T01:41:57  <eklitzke> and then the next time i tried to start it
 68 2018-03-14T01:42:01  <eklitzke> corrupted database
 69 2018-03-14T01:42:19  *** pyericz has joined #bitcoin-core-dev
 70 2018-03-14T01:43:20  <sipa> eklitzke: wow, with a clean shutdown? :S
 71 2018-03-14T01:43:37  <eklitzke> this is actually on v0.16.0, not from my branches
 72 2018-03-14T01:43:40  <eklitzke> hmm
 73 2018-03-14T01:44:06  <eklitzke> interesting, well i had been asking users if they could give me corrupted database files, looks like i got what i was asking for
 74 2018-03-14T01:44:48  *** justanotheruser has quit IRC
 75 2018-03-14T01:45:03  *** pyericz has quit IRC
 76 2018-03-14T01:45:18  *** justanotheruser has joined #bitcoin-core-dev
 77 2018-03-14T01:45:56  *** pyericz has joined #bitcoin-core-dev
 78 2018-03-14T01:48:55  <kallewoof> Am I right that signmessage <addr> leaks the public key of <addr> in the resulting signature?
 79 2018-03-14T01:49:18  <kallewoof> s/leaks/exposes/ I guess.
 80 2018-03-14T01:49:59  *** pyericz has quit IRC
 81 2018-03-14T01:50:24  *** pyericz has joined #bitcoin-core-dev
 82 2018-03-14T01:51:25  *** pyericz has quit IRC
 83 2018-03-14T01:51:35  <eklitzke> actually i remember now what i was doing, the last thing i had been doing with this was running my python utxo scanning script on the data directory
 84 2018-03-14T01:51:45  <eklitzke> s/data directory/chainstate directory/
 85 2018-03-14T01:51:58  <eklitzke> which uses the python leveldb bindings
 86 2018-03-14T01:52:14  <eklitzke> i thought i had the daemon stopped but i guess i could have had it running
 87 2018-03-14T01:52:19  <eklitzke> hopefully i can reproduce
 88 2018-03-14T01:55:31  *** tecneecs has joined #bitcoin-core-dev
 89 2018-03-14T01:55:55  <tecneecs> sup bitcoin?
 90 2018-03-14T01:56:06  *** justanotheruser has quit IRC
 91 2018-03-14T01:56:44  *** justanotheruser has joined #bitcoin-core-dev
 92 2018-03-14T01:59:47  *** pyericz has joined #bitcoin-core-dev
 93 2018-03-14T02:01:40  *** Victorsueca has quit IRC
 94 2018-03-14T02:02:36  *** justanotheruser has quit IRC
 95 2018-03-14T02:03:02  *** LeMiner has quit IRC
 96 2018-03-14T02:03:04  *** justanotheruser has joined #bitcoin-core-dev
 97 2018-03-14T02:03:07  *** Victorsueca has joined #bitcoin-core-dev
 98 2018-03-14T02:03:29  *** pyericz has quit IRC
 99 2018-03-14T02:03:50  *** jimbouki_ has quit IRC
100 2018-03-14T02:03:58  *** pyericz has joined #bitcoin-core-dev
101 2018-03-14T02:04:04  *** jimbouki has joined #bitcoin-core-dev
102 2018-03-14T02:04:57  *** jimbouki has quit IRC
103 2018-03-14T02:06:01  <sipa> kallewoof: every ECDSA signature leaks the pubkey (almost)
104 2018-03-14T02:09:23  *** pyericz has quit IRC
105 2018-03-14T02:10:18  *** pyericz has joined #bitcoin-core-dev
106 2018-03-14T02:14:20  *** dabura667 has joined #bitcoin-core-dev
107 2018-03-14T02:16:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
108 2018-03-14T02:17:11  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/18462960c0f1...6acd8700bc0e
109 2018-03-14T02:17:12  <bitcoin-git> bitcoin/master a128bdc Russell Yanofsky: [wallet] Construct CWalletTx objects in CommitTransaction...
110 2018-03-14T02:17:12  <bitcoin-git> bitcoin/master b4bc32a Russell Yanofsky: [wallet] Get rid of CWalletTx default constructor...
111 2018-03-14T02:17:13  <bitcoin-git> bitcoin/master 6acd870 Pieter Wuille: Merge #9680: Unify CWalletTx construction...
112 2018-03-14T02:17:43  <kallewoof> sipa: Well, it's sorta like spending an UTXO vs handing out the pubkey for its PKH. One seems worse than the other (though only a little).
113 2018-03-14T02:18:03  *** tied2chainz has quit IRC
114 2018-03-14T02:18:59  <sipa> kallewoof: but regardless, you can't create a signature without revealing the public key
115 2018-03-14T02:20:47  <kallewoof> Yeah, I was initially very confused about how verifymessage could pull it off with only an address, until I realized the signature had a recoverable pubkey in it.
116 2018-03-14T02:21:29  <kallewoof> It struck me that people may not realize they are revealing the pubkey when they signmessage a utxo. Clearly as you say, you need the pubkey to verify the sig.
117 2018-03-14T02:22:08  <kallewoof> Perhaps it doesn't really matter that you show the pubkey (long) before spending.
118 2018-03-14T02:27:06  <luke-jr> kallewoof: hopefully when someone gets around to replacing signmessage, it can be MAST-based with a separate key for messages
119 2018-03-14T02:32:18  <kallewoof> luke-jr: Interesting. I'll have to think about how that would work.
120 2018-03-14T02:32:57  <sipa> kallewoof: well a decent replacement for signmessage would be something that just uses script
121 2018-03-14T02:33:08  <sipa> (but signs something else than a tx)
122 2018-03-14T02:33:30  <sipa> that would automatically support any kind of output type
123 2018-03-14T02:41:17  *** jimbouki has joined #bitcoin-core-dev
124 2018-03-14T02:42:59  <kallewoof> sipa: That makes sense, yeah.
125 2018-03-14T02:45:47  *** Aaronvan_ has joined #bitcoin-core-dev
126 2018-03-14T02:46:07  <meshcollider> Wasn't someone already working on a BIP draft for an improved signmessage, or am I imagining things
127 2018-03-14T02:46:13  *** jimbouki has quit IRC
128 2018-03-14T02:46:30  <kallewoof> sipa: Presumably it would sign H(addr||message). Not sure if addr is strictly necessary though.
129 2018-03-14T02:48:29  *** Aaronvan_ has quit IRC
130 2018-03-14T02:48:34  *** kryptopraxis has quit IRC
131 2018-03-14T02:48:57  *** AaronvanW has quit IRC
132 2018-03-14T02:49:13  *** Chris_Stewart_5 has quit IRC
133 2018-03-14T02:59:12  <luke-jr> meshcollider: at one point, someone was talking about it at least
134 2018-03-14T03:00:54  *** kryptopraxis has joined #bitcoin-core-dev
135 2018-03-14T03:07:48  <sipa> kallewoof: yup, this is the way to fix it
136 2018-03-14T03:13:12  *** mrjenkins has joined #bitcoin-core-dev
137 2018-03-14T03:13:23  <mrjenkins> hello!
138 2018-03-14T03:14:06  <mrjenkins> why does github repo say that the build is failing?
139 2018-03-14T03:14:37  <mrjenkins> does the build is really failing?
140 2018-03-14T03:16:41  *** jimbouki has joined #bitcoin-core-dev
141 2018-03-14T03:18:50  *** Murch has quit IRC
142 2018-03-14T03:21:55  *** schmidty has joined #bitcoin-core-dev
143 2018-03-14T03:22:10  *** pyericz has quit IRC
144 2018-03-14T03:22:19  *** schmidty is now known as Guest3864
145 2018-03-14T03:22:50  *** larafale has joined #bitcoin-core-dev
146 2018-03-14T03:24:05  *** pyericz has joined #bitcoin-core-dev
147 2018-03-14T03:26:33  *** Guest3864 has quit IRC
148 2018-03-14T03:26:57  *** larafale has quit IRC
149 2018-03-14T03:31:26  *** arbitrary_guy has joined #bitcoin-core-dev
150 2018-03-14T03:32:16  *** jimbouki has quit IRC
151 2018-03-14T03:32:21  *** mrjenkins has quit IRC
152 2018-03-14T03:35:44  *** Giszmo has quit IRC
153 2018-03-14T03:44:01  *** mangoicedtea has joined #bitcoin-core-dev
154 2018-03-14T03:49:13  *** jimbouki has joined #bitcoin-core-dev
155 2018-03-14T04:12:36  *** User__ has joined #bitcoin-core-dev
156 2018-03-14T04:14:49  *** Victorsueca has quit IRC
157 2018-03-14T04:15:33  *** ken2812221 has quit IRC
158 2018-03-14T04:15:51  *** pyericz has quit IRC
159 2018-03-14T04:16:07  *** Victorsueca has joined #bitcoin-core-dev
160 2018-03-14T04:16:08  *** jimbouki_ has joined #bitcoin-core-dev
161 2018-03-14T04:16:17  *** jimbouki has quit IRC
162 2018-03-14T04:21:32  *** pyericz has joined #bitcoin-core-dev
163 2018-03-14T04:23:28  *** larafale has joined #bitcoin-core-dev
164 2018-03-14T04:23:47  *** jimbouki_ has quit IRC
165 2018-03-14T04:24:01  *** rex_4539 has joined #bitcoin-core-dev
166 2018-03-14T04:24:30  *** jimbouki has joined #bitcoin-core-dev
167 2018-03-14T04:26:09  *** pyericz has quit IRC
168 2018-03-14T04:27:57  *** larafale has quit IRC
169 2018-03-14T04:42:09  *** rex_4539 has quit IRC
170 2018-03-14T04:49:07  *** tecneecs has quit IRC
171 2018-03-14T04:55:39  *** jimbouki has quit IRC
172 2018-03-14T04:57:41  *** jimbouki has joined #bitcoin-core-dev
173 2018-03-14T05:01:57  *** jimbouki has quit IRC
174 2018-03-14T05:02:21  *** harryTrout has joined #bitcoin-core-dev
175 2018-03-14T05:04:59  *** mangoicedtea has quit IRC
176 2018-03-14T05:09:53  *** grafcaps has quit IRC
177 2018-03-14T05:10:43  <pierre_rochard> mrjenkins  https://github.com/bitcoin/bitcoin shows the build is passing
178 2018-03-14T05:10:53  *** dafunkiz_ has joined #bitcoin-core-dev
179 2018-03-14T05:23:04  *** schmidty has joined #bitcoin-core-dev
180 2018-03-14T05:23:26  *** schmidty is now known as Guest37915
181 2018-03-14T05:24:19  *** larafale has joined #bitcoin-core-dev
182 2018-03-14T05:27:58  *** Guest37915 has quit IRC
183 2018-03-14T05:28:57  *** larafale has quit IRC
184 2018-03-14T05:33:16  *** grafcaps has joined #bitcoin-core-dev
185 2018-03-14T05:37:50  *** pyericz has joined #bitcoin-core-dev
186 2018-03-14T05:38:09  *** grafcaps has quit IRC
187 2018-03-14T05:46:12  *** dafunkiz_ has quit IRC
188 2018-03-14T06:07:12  *** harryTrout has left #bitcoin-core-dev
189 2018-03-14T06:13:31  *** pyericz has quit IRC
190 2018-03-14T06:14:07  *** pyericz has joined #bitcoin-core-dev
191 2018-03-14T06:23:16  *** Victorsueca has quit IRC
192 2018-03-14T06:24:20  *** pyericz has quit IRC
193 2018-03-14T06:24:38  *** Victorsueca has joined #bitcoin-core-dev
194 2018-03-14T06:24:52  *** pyericz has joined #bitcoin-core-dev
195 2018-03-14T06:25:10  *** larafale has joined #bitcoin-core-dev
196 2018-03-14T06:29:27  *** larafale has quit IRC
197 2018-03-14T06:31:09  *** jimbouki has joined #bitcoin-core-dev
198 2018-03-14T06:35:54  *** jimbouki has quit IRC
199 2018-03-14T06:42:31  *** jimbouki has joined #bitcoin-core-dev
200 2018-03-14T06:43:49  *** sanada` has joined #bitcoin-core-dev
201 2018-03-14T06:45:00  *** pyericz_ has joined #bitcoin-core-dev
202 2018-03-14T06:45:22  *** sanada has quit IRC
203 2018-03-14T06:46:25  *** pyericz has quit IRC
204 2018-03-14T06:46:33  *** jimbouki has quit IRC
205 2018-03-14T06:56:58  *** fanquake has joined #bitcoin-core-dev
206 2018-03-14T07:05:04  <fanquake> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds?
207 2018-03-14T07:16:57  *** User__ has quit IRC
208 2018-03-14T07:17:42  *** User__ has joined #bitcoin-core-dev
209 2018-03-14T07:21:30  <sipa> fanquake: what PR are you referring to?
210 2018-03-14T07:22:23  <eklitzke> sipa: for #12683 did you do this manually or have a tool identify the temporary references?
211 2018-03-14T07:22:25  <gribble> https://github.com/bitcoin/bitcoin/issues/12683 | Fix more constness violations in serialization code by sipa · Pull Request #12683 · bitcoin/bitcoin · GitHub
212 2018-03-14T07:22:28  <eklitzke> this is an interesting change
213 2018-03-14T07:24:15  <sipa> eklitzke: there are only 2 dozen calls of REF, some are there as arguments to one of the wrappers (which aren't fixed yet), and some are around the wrappers (which are fixed now)
214 2018-03-14T07:24:20  <sipa> it's quite mechanical
215 2018-03-14T07:24:21  *** schmidty has joined #bitcoin-core-dev
216 2018-03-14T07:24:55  *** schmidty is now known as Guest10494
217 2018-03-14T07:25:03  <sipa> eklitzke: #10785 has many more things like this
218 2018-03-14T07:25:08  <gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
219 2018-03-14T07:25:49  *** larafale has joined #bitcoin-core-dev
220 2018-03-14T07:25:55  <eklitzke> neat, i'll take a look at that too
221 2018-03-14T07:27:55  *** CubicEarths has joined #bitcoin-core-dev
222 2018-03-14T07:28:32  *** fanquake has quit IRC
223 2018-03-14T07:28:56  *** Guest10494 has quit IRC
224 2018-03-14T07:28:59  *** grafcaps has joined #bitcoin-core-dev
225 2018-03-14T07:29:10  *** fanquake has joined #bitcoin-core-dev
226 2018-03-14T07:30:27  *** larafale has quit IRC
227 2018-03-14T07:34:02  *** grafcaps has quit IRC
228 2018-03-14T07:34:16  <kallewoof> fanquake: Don't know if you're referring to me, but I may be guilty of doing that. I'll try to think of whether it's worth it with the amount of ACKs for current state in the future.
229 2018-03-14T07:50:24  *** CapitanRetardo has joined #bitcoin-core-dev
230 2018-03-14T07:51:56  *** jimbouki has joined #bitcoin-core-dev
231 2018-03-14T07:56:45  *** jimbouki has quit IRC
232 2018-03-14T08:10:17  *** setpill has joined #bitcoin-core-dev
233 2018-03-14T08:15:57  *** pyericz_ has quit IRC
234 2018-03-14T08:17:13  *** pyericz has joined #bitcoin-core-dev
235 2018-03-14T08:18:21  *** timothy has joined #bitcoin-core-dev
236 2018-03-14T08:22:48  *** drizztbsd has joined #bitcoin-core-dev
237 2018-03-14T08:23:46  *** timothy has quit IRC
238 2018-03-14T08:25:01  *** arbitrary_guy has quit IRC
239 2018-03-14T08:26:33  *** larafale has joined #bitcoin-core-dev
240 2018-03-14T08:29:44  *** promag_ has quit IRC
241 2018-03-14T08:30:26  *** promag has joined #bitcoin-core-dev
242 2018-03-14T08:30:35  *** Bethany47Braun has quit IRC
243 2018-03-14T08:30:57  *** larafale has quit IRC
244 2018-03-14T08:34:41  *** promag has quit IRC
245 2018-03-14T08:39:23  *** Kayla75Wunsch has joined #bitcoin-core-dev
246 2018-03-14T08:57:36  *** laurentmt has joined #bitcoin-core-dev
247 2018-03-14T09:03:54  *** laurentmt has quit IRC
248 2018-03-14T09:04:07  *** jimbouki has joined #bitcoin-core-dev
249 2018-03-14T09:08:30  *** jimbouki has quit IRC
250 2018-03-14T09:14:15  <pierre_rochard> achow101: I’m taking a look at #12375 - do you have a fix in the works? I just implemented Akio’s solution and it works, though I’d like to do more research before letting a platform-specific issue add what feels like cruft.
251 2018-03-14T09:14:17  <gribble> https://github.com/bitcoin/bitcoin/issues/12375 | wallet_encryption.py fails on macos · Issue #12375 · bitcoin/bitcoin · GitHub
252 2018-03-14T09:15:18  *** adiabat has quit IRC
253 2018-03-14T09:24:15  <bitcoin-git> [bitcoin] bill-walker closed pull request #12599: [gui] Use base58 script hash address as example (master...master) https://github.com/bitcoin/bitcoin/pull/12599
254 2018-03-14T09:24:54  *** fanquake has quit IRC
255 2018-03-14T09:25:15  *** schmidty has joined #bitcoin-core-dev
256 2018-03-14T09:25:38  *** schmidty is now known as Guest44473
257 2018-03-14T09:30:05  *** Guest44473 has quit IRC
258 2018-03-14T09:30:11  *** adiabat has joined #bitcoin-core-dev
259 2018-03-14T09:31:49  *** grafcaps has joined #bitcoin-core-dev
260 2018-03-14T09:34:41  <bitcoin-git> [bitcoin] bill-walker opened pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685
261 2018-03-14T09:36:30  *** grafcaps has quit IRC
262 2018-03-14T09:37:55  *** fanquake has joined #bitcoin-core-dev
263 2018-03-14T09:38:27  *** CapitanRetardo has quit IRC
264 2018-03-14T09:47:52  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6acd8700bc0e...c6fc6656299b
265 2018-03-14T09:47:52  <bitcoin-git> bitcoin/master 2b3ea39 Vasil Dimov: Polish interfaces around PeerLogicValidation...
266 2018-03-14T09:47:53  <bitcoin-git> bitcoin/master c6fc665 Wladimir J. van der Laan: Merge #12680: Add missing virtual destructor in PeerLogicValidation...
267 2018-03-14T09:48:37  <bitcoin-git> [bitcoin] laanwj closed pull request #12680: Add missing virtual destructor in PeerLogicValidation (master...master-add-missing-vdtor-in-PeerLogicValidation) https://github.com/bitcoin/bitcoin/pull/12680
268 2018-03-14T09:49:11  *** promag has joined #bitcoin-core-dev
269 2018-03-14T10:01:06  *** zarez has joined #bitcoin-core-dev
270 2018-03-14T10:04:54  *** promag has quit IRC
271 2018-03-14T10:05:30  *** CapitanRetardo has joined #bitcoin-core-dev
272 2018-03-14T10:07:12  *** CapitanRetardo has quit IRC
273 2018-03-14T10:07:47  *** CapitanRetardo has joined #bitcoin-core-dev
274 2018-03-14T10:09:09  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c6fc6656299b...9f04c8e23118
275 2018-03-14T10:09:09  <bitcoin-git> bitcoin/master fa79016 MarcoFalke: travis: Clone depth 1 unless $CHECK_DOC
276 2018-03-14T10:09:10  <bitcoin-git> bitcoin/master 9f04c8e Wladimir J. van der Laan: Merge #12682: travis: Clone depth 1 unless $CHECK_DOC...
277 2018-03-14T10:09:20  *** CapitanRetardo has joined #bitcoin-core-dev
278 2018-03-14T10:09:59  <bitcoin-git> [bitcoin] laanwj closed pull request #12682: travis: Clone depth 1 unless $CHECK_DOC (master...Mf1803-travisDepth1) https://github.com/bitcoin/bitcoin/pull/12682
279 2018-03-14T10:10:25  *** CapitanRetardo has joined #bitcoin-core-dev
280 2018-03-14T10:12:25  *** jimbouki has joined #bitcoin-core-dev
281 2018-03-14T10:16:05  <wumpus> I'm confused re: 12685
282 2018-03-14T10:16:33  *** Megumiin has quit IRC
283 2018-03-14T10:16:41  <wumpus> I don't remember the dummy address change getting merged
284 2018-03-14T10:17:05  *** jimbouki has quit IRC
285 2018-03-14T10:17:20  *** CapitanRetardo has joined #bitcoin-core-dev
286 2018-03-14T10:17:50  *** Megumiin has joined #bitcoin-core-dev
287 2018-03-14T10:17:59  <wumpus> oh it wasn't (#12599)
288 2018-03-14T10:18:01  <gribble> https://github.com/bitcoin/bitcoin/issues/12599 | [gui] Use base58 script hash address as example by bill-walker · Pull Request #12599 · bitcoin/bitcoin · GitHub
289 2018-03-14T10:19:26  *** promag has joined #bitcoin-core-dev
290 2018-03-14T10:26:31  *** CapitanRetardo has quit IRC
291 2018-03-14T10:26:50  *** CapitanRetardo has joined #bitcoin-core-dev
292 2018-03-14T10:27:05  *** drizztbsd has quit IRC
293 2018-03-14T10:27:17  *** drizztbsd has joined #bitcoin-core-dev
294 2018-03-14T10:27:47  *** drizztbsd is now known as timothy
295 2018-03-14T10:32:58  *** fanquake has quit IRC
296 2018-03-14T10:35:47  *** drizztbsd has joined #bitcoin-core-dev
297 2018-03-14T10:36:25  *** timothy has quit IRC
298 2018-03-14T10:42:51  <bitcoin-git> [bitcoin] practicalswift opened pull request #12686: travis: Generate a trap for signed arithmetic overflows (enable -ftrapv) (master...trapv) https://github.com/bitcoin/bitcoin/pull/12686
299 2018-03-14T10:43:52  *** fanquake has joined #bitcoin-core-dev
300 2018-03-14T10:51:56  *** drizztbsd is now known as timothy
301 2018-03-14T10:56:35  *** fanquake has quit IRC
302 2018-03-14T11:04:03  *** User__ is now known as ken2812221
303 2018-03-14T11:04:37  *** ken2812221 has quit IRC
304 2018-03-14T11:04:59  *** ken2812221 has joined #bitcoin-core-dev
305 2018-03-14T11:08:15  *** fanquake has joined #bitcoin-core-dev
306 2018-03-14T11:23:26  *** opdenkamp has quit IRC
307 2018-03-14T11:26:42  *** schmidty has joined #bitcoin-core-dev
308 2018-03-14T11:27:06  *** schmidty is now known as Guest98035
309 2018-03-14T11:28:06  *** harrymm has joined #bitcoin-core-dev
310 2018-03-14T11:29:01  *** opdenkamp has joined #bitcoin-core-dev
311 2018-03-14T11:30:57  *** Guest98035 has quit IRC
312 2018-03-14T11:37:06  *** fanquake has quit IRC
313 2018-03-14T11:47:37  *** pyericz has quit IRC
314 2018-03-14T11:49:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
315 2018-03-14T11:53:42  *** Kayla75Wunsch has quit IRC
316 2018-03-14T11:56:16  *** jimbouki has joined #bitcoin-core-dev
317 2018-03-14T11:57:00  *** CubicEarths has quit IRC
318 2018-03-14T11:57:19  *** dabura667 has quit IRC
319 2018-03-14T11:57:36  *** CubicEarths has joined #bitcoin-core-dev
320 2018-03-14T12:00:24  *** Samdney has joined #bitcoin-core-dev
321 2018-03-14T12:01:03  *** jimbouki has quit IRC
322 2018-03-14T12:02:09  *** CubicEarths has quit IRC
323 2018-03-14T12:02:38  *** promag has quit IRC
324 2018-03-14T12:05:51  *** mrannanay has joined #bitcoin-core-dev
325 2018-03-14T12:06:22  *** CapitanRetardo has quit IRC
326 2018-03-14T12:07:11  *** AaronvanW has joined #bitcoin-core-dev
327 2018-03-14T12:07:57  *** fanquake has joined #bitcoin-core-dev
328 2018-03-14T12:08:13  *** Aaronvan_ has joined #bitcoin-core-dev
329 2018-03-14T12:11:45  *** AaronvanW has quit IRC
330 2018-03-14T12:14:19  *** promag has joined #bitcoin-core-dev
331 2018-03-14T12:14:23  *** grafcaps has joined #bitcoin-core-dev
332 2018-03-14T12:14:42  *** fanquake has quit IRC
333 2018-03-14T12:15:01  *** fanquake has joined #bitcoin-core-dev
334 2018-03-14T12:17:57  *** opdenkamp has quit IRC
335 2018-03-14T12:19:27  *** grafcaps has quit IRC
336 2018-03-14T12:19:52  *** promag has quit IRC
337 2018-03-14T12:21:24  *** promag has joined #bitcoin-core-dev
338 2018-03-14T12:21:36  *** CapitanRetardo has joined #bitcoin-core-dev
339 2018-03-14T12:21:37  *** fanquake has quit IRC
340 2018-03-14T12:24:23  *** promag has quit IRC
341 2018-03-14T12:27:01  *** promag has joined #bitcoin-core-dev
342 2018-03-14T12:30:46  *** promag has quit IRC
343 2018-03-14T12:31:15  *** promag has joined #bitcoin-core-dev
344 2018-03-14T12:35:16  *** setpill has quit IRC
345 2018-03-14T12:35:33  *** Chris_Stewart_5 has quit IRC
346 2018-03-14T12:39:11  <wumpus> <fanquake> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds? <- yeah...
347 2018-03-14T12:39:24  <wumpus> feel free to call me out when I do that
348 2018-03-14T12:39:58  <wumpus> usually I add "but this doesn't have to be done in this PR" in that case
349 2018-03-14T12:40:02  * luke-jr calls jonasschnelli out on doing it with multiwallet? XD
350 2018-03-14T12:40:49  <wumpus> at this point I'd be happy to have *any* multiwallet GUI in, just so that work can proceed on it in the repository
351 2018-03-14T12:41:06  *** setpill has joined #bitcoin-core-dev
352 2018-03-14T12:42:11  <luke-jr> well, #11383 is ready besides a new conflict in wallet_tests I could easily resolve :x
353 2018-03-14T12:42:14  <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
354 2018-03-14T12:46:47  *** dafunkiz_ has joined #bitcoin-core-dev
355 2018-03-14T12:52:43  *** opdenkamp has joined #bitcoin-core-dev
356 2018-03-14T12:55:39  *** promag has quit IRC
357 2018-03-14T12:56:30  *** CapitanRetardo has quit IRC
358 2018-03-14T13:03:34  *** belcher_ has joined #bitcoin-core-dev
359 2018-03-14T13:22:16  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f04c8e23118...ce6ffe196e9b
360 2018-03-14T13:22:16  <bitcoin-git> bitcoin/master fa23105 MarcoFalke: qa: Cache only chain and wallet for regtest datadir
361 2018-03-14T13:22:17  <bitcoin-git> bitcoin/master ce6ffe1 Wladimir J. van der Laan: Merge #12638: qa: Cache only chain and wallet for regtest datadir...
362 2018-03-14T13:23:07  <bitcoin-git> [bitcoin] laanwj closed pull request #12638:  qa: Cache only chain and wallet for regtest datadir  (master...Mf1803-qaMempoolCache) https://github.com/bitcoin/bitcoin/pull/12638
363 2018-03-14T13:25:40  *** schmidty has joined #bitcoin-core-dev
364 2018-03-14T13:26:03  *** schmidty is now known as Guest72256
365 2018-03-14T13:29:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
366 2018-03-14T13:29:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce6ffe196e9b...c4219ff3786e
367 2018-03-14T13:29:59  <bitcoin-git> bitcoin/master 4ef82f1 fanquake: depends: biplist 1.0.3
368 2018-03-14T13:30:00  <bitcoin-git> bitcoin/master c4219ff Wladimir J. van der Laan: Merge #12625: depends: biplist 1.0.3...
369 2018-03-14T13:30:45  <bitcoin-git> [bitcoin] laanwj closed pull request #12625: depends: biplist 1.0.3 (master...biplist-1-0-3) https://github.com/bitcoin/bitcoin/pull/12625
370 2018-03-14T13:31:44  *** dafunkiz_ has quit IRC
371 2018-03-14T13:32:51  *** CubicEarths has joined #bitcoin-core-dev
372 2018-03-14T13:37:44  *** CubicEarths has quit IRC
373 2018-03-14T13:38:30  *** CubicEarths has joined #bitcoin-core-dev
374 2018-03-14T13:39:03  *** fanquake has joined #bitcoin-core-dev
375 2018-03-14T13:40:00  <fanquake> wumpus I think we're meant to be excluding patches already: ":(exclude)depends/patches/" Maybe the script is broken?
376 2018-03-14T13:40:10  <wumpus> fanquake: was that ever backported
377 2018-03-14T13:40:36  <fanquake> wumpus Good point, probably not
378 2018-03-14T13:41:32  <wumpus> :D
379 2018-03-14T13:41:42  <wumpus> could include it in that PR I gues
380 2018-03-14T13:42:54  *** CubicEarths has quit IRC
381 2018-03-14T13:43:48  <wumpus> already had a bit of deja vu feeling about that patch exclusion
382 2018-03-14T13:44:41  <fanquake> heh, get enough hassel from whitespace already without it complaining about things we know are "correct"
383 2018-03-14T13:44:52  <fanquake> I'll add that commit in a minute
384 2018-03-14T13:44:57  <wumpus> yes, agree
385 2018-03-14T13:45:19  <fanquake> #12102 should be ready for merge
386 2018-03-14T13:45:22  <gribble> https://github.com/bitcoin/bitcoin/issues/12102 | Apply hardening measures in bitcoind systemd service file by Flowdalic · Pull Request #12102 · bitcoin/bitcoin · GitHub
387 2018-03-14T13:46:30  <wumpus> I'm still not convinced adding that whitespace check to travis was a good idea. On the other hand at least it avoids PRs to "fix" whitespace!
388 2018-03-14T13:48:31  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4219ff3786e...7fb8fb43a630
389 2018-03-14T13:48:31  <bitcoin-git> bitcoin/master 79ddfad Florian Schmaus: Apply hardening measurements in bitcoind systemd service file...
390 2018-03-14T13:48:32  <bitcoin-git> bitcoin/master 7fb8fb4 Wladimir J. van der Laan: Merge #12102: Apply hardening measures in bitcoind systemd service file...
391 2018-03-14T13:49:03  <bitcoin-git> [bitcoin] laanwj closed pull request #12102: Apply hardening measures in bitcoind systemd service file (master...systemd-hardening) https://github.com/bitcoin/bitcoin/pull/12102
392 2018-03-14T13:51:46  <bitcoin-git> [bitcoin] fanquake closed pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685
393 2018-03-14T13:53:52  *** CubicEarths has joined #bitcoin-core-dev
394 2018-03-14T13:54:02  *** ken2812221 has quit IRC
395 2018-03-14T13:56:07  *** ken2812221 has joined #bitcoin-core-dev
396 2018-03-14T13:57:13  <fanquake> wumpus #12460 has a bunch of utACKs, requested a review from sipa
397 2018-03-14T13:57:16  <gribble> https://github.com/bitcoin/bitcoin/issues/12460 | Assert CPubKey::ValidLength to the pubkeys header-relevant size by Empact · Pull Request #12460 · bitcoin/bitcoin · GitHub
398 2018-03-14T13:58:13  *** CubicEarths has quit IRC
399 2018-03-14T14:01:35  *** CubicEarths has joined #bitcoin-core-dev
400 2018-03-14T14:06:05  *** CubicEarths has quit IRC
401 2018-03-14T14:06:55  <fanquake> #12316 started a QT bump, but hasn't really been followed up.
402 2018-03-14T14:06:57  <gribble> https://github.com/bitcoin/bitcoin/issues/12316 | Upgrade depends/build system to use Qt 5.9.4 by thijstriemstra · Pull Request #12316 · bitcoin/bitcoin · GitHub
403 2018-03-14T14:07:25  <fanquake> After discussing with theuni 5.9.x is the way to go for the next QT bump, however the changes should be more involved than what's been done in that PR so far.
404 2018-03-14T14:07:45  <fanquake> I think I'll close it for now. I start work on an alternate pr last week.
405 2018-03-14T14:08:13  <wumpus> agree, better to close it if it doesn't make progress, probably the author underestimated the work involved
406 2018-03-14T14:08:13  *** Victorsueca has quit IRC
407 2018-03-14T14:08:54  <wumpus> it's kind of a long haul, for a first-time contributor to try to bump qt in the depends system
408 2018-03-14T14:09:16  <wumpus> might learn a thing if he was really involved, but it's going slow
409 2018-03-14T14:09:27  *** Victorsueca has joined #bitcoin-core-dev
410 2018-03-14T14:09:46  <bitcoin-git> [bitcoin] fanquake closed pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316
411 2018-03-14T14:11:52  <wumpus> let's try to credit him in the commit message when we do bump qt
412 2018-03-14T14:12:14  *** Guest72256 has quit IRC
413 2018-03-14T14:12:27  *** harrymm has quit IRC
414 2018-03-14T14:13:46  <bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510
415 2018-03-14T14:13:49  <fanquake> wumpus How would like to follow up with issues like #12657 ?
416 2018-03-14T14:13:50  <gribble> https://github.com/bitcoin/bitcoin/issues/12657 | Serbian Translation / Cyrillic and Latin - Needs better distinction on Transifex · Issue #12657 · bitcoin/bitcoin · GitHub
417 2018-03-14T14:14:08  <fanquake> I'm not quite on top of how we are doing things on Transifex.
418 2018-03-14T14:14:18  *** CubicEarths has joined #bitcoin-core-dev
419 2018-03-14T14:14:39  *** HFRadical has joined #bitcoin-core-dev
420 2018-03-14T14:14:44  <wumpus> I have no idea either
421 2018-03-14T14:17:12  <setpill> has anyone tried to test #12656 ? currently running into some problems but not sure if it's an issue in my virtualbox install or in the PR
422 2018-03-14T14:17:14  <gribble> https://github.com/bitcoin/bitcoin/issues/12656 | Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer by maaku · Pull Request #12656 · bitcoin/bitcoin · GitHub
423 2018-03-14T14:18:58  *** CubicEarths has quit IRC
424 2018-03-14T14:19:11  <fanquake> setpill I'm planning on testing shortly. Report any issues your having to the PR.
425 2018-03-14T14:19:17  <wumpus> I don't use virtualbox anymore (now use libvirt/virsh on my VM servers) so can't test
426 2018-03-14T14:20:06  <fanquake> wumpus I was wondering if the /docs repo might be a better place for that PR ?
427 2018-03-14T14:21:39  <wumpus> fanquake: at least the documentation for it should go into the docs repo, so that it's with the other menagerie of gitian building methods. If there are scripts that are more-or-less bound to the bitcoin core release schedule they can be in our repo. Not sure.
428 2018-03-14T14:22:33  *** Giszmo has joined #bitcoin-core-dev
429 2018-03-14T14:22:53  <wumpus> I think the other gitian building script is also in our repo
430 2018-03-14T14:22:53  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7fb8fb43a630...05042d38ba56
431 2018-03-14T14:22:54  <bitcoin-git> bitcoin/master 8172d3a Luke Dashjr: configure: UniValue 1.0.4 is required for pushKV(, bool)
432 2018-03-14T14:22:55  <bitcoin-git> bitcoin/master 05042d3 Wladimir J. van der Laan: Merge #12666: configure: UniValue 1.0.4 is required for pushKV(, bool)...
433 2018-03-14T14:23:43  <bitcoin-git> [bitcoin] laanwj closed pull request #12666: configure: UniValue 1.0.4 is required for pushKV(, bool) (master...univalue-1.0.4-required) https://github.com/bitcoin/bitcoin/pull/12666
434 2018-03-14T14:25:05  *** harrymm has joined #bitcoin-core-dev
435 2018-03-14T14:25:58  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/05042d38ba56...56cc022112af
436 2018-03-14T14:25:58  <bitcoin-git> bitcoin/master c316fdf João Barbosa: [qt] Add support to search the address book
437 2018-03-14T14:25:59  <bitcoin-git> bitcoin/master 56cc022 Wladimir J. van der Laan: Merge #12080: Add support to search the address book...
438 2018-03-14T14:26:33  <bitcoin-git> [bitcoin] laanwj closed pull request #12080: Add support to search the address book (master...2018-01-searchaddressbook) https://github.com/bitcoin/bitcoin/pull/12080
439 2018-03-14T14:29:29  *** CubicEarths has joined #bitcoin-core-dev
440 2018-03-14T14:31:14  *** grafcaps has joined #bitcoin-core-dev
441 2018-03-14T14:31:35  *** promag has joined #bitcoin-core-dev
442 2018-03-14T14:32:13  <fanquake> wumpus I think #12668 can just go in
443 2018-03-14T14:32:16  <gribble> https://github.com/bitcoin/bitcoin/issues/12668 | Doc: Ubuntu xenial first dependencies by nvercamm · Pull Request #12668 · bitcoin/bitcoin · GitHub
444 2018-03-14T14:32:46  <fanquake> If running apt update/upgrade is going to upset something, WSL is even more broken than we seem to think.
445 2018-03-14T14:33:37  <fanquake> You could adjust the commit message though, as nothing Xenial specific.
446 2018-03-14T14:34:11  *** CubicEarths has quit IRC
447 2018-03-14T14:35:17  <promag> hi, I would like some feedback on #12507, ty
448 2018-03-14T14:35:20  <gribble> https://github.com/bitcoin/bitcoin/issues/12507 | Interrupt rescan on shutdown request by promag · Pull Request #12507 · bitcoin/bitcoin · GitHub
449 2018-03-14T14:35:39  <promag> in particular, if the rescan should resume or not
450 2018-03-14T14:36:37  <instagibbs> wumpus, I must be the only one who gets triggered seeing extra whitespace on my git diff...
451 2018-03-14T14:37:23  *** Guyver2 has joined #bitcoin-core-dev
452 2018-03-14T14:37:29  *** SopaXorzTaker has joined #bitcoin-core-dev
453 2018-03-14T14:40:19  <wumpus> instagibbs: no, I don't think so, it's really easy to notice such things. I consciously have to push myself to ignore all kinds of small grievances while reviewing, to be able to focus at the real changes
454 2018-03-14T14:43:05  <wumpus> and yes, sometimes I still fail at that
455 2018-03-14T14:43:52  *** meshcollider has quit IRC
456 2018-03-14T14:44:23  *** CubicEarths has joined #bitcoin-core-dev
457 2018-03-14T14:46:35  *** SopaXorzTaker has joined #bitcoin-core-dev
458 2018-03-14T14:48:57  *** CubicEarths has quit IRC
459 2018-03-14T14:50:06  *** grafcaps has quit IRC
460 2018-03-14T14:53:45  <achow101> pierre_rochard: I haven't really looked at that issue yet. I can't reproduce it either; I don't have a mac
461 2018-03-14T14:59:22  *** fanquake has quit IRC
462 2018-03-14T15:03:51  *** Deinogalerix21 has joined #bitcoin-core-dev
463 2018-03-14T15:06:35  *** CubicEarths has joined #bitcoin-core-dev
464 2018-03-14T15:11:09  *** CubicEarths has quit IRC
465 2018-03-14T15:11:50  *** Deinogalerix21 has quit IRC
466 2018-03-14T15:16:00  *** grafcaps has joined #bitcoin-core-dev
467 2018-03-14T15:17:30  <bitcoin-git> [bitcoin] laanwj closed pull request #12636: backport: #11995 Fix Qt build with Xcode 9 (0.16...qt-fix-backport) https://github.com/bitcoin/bitcoin/pull/12636
468 2018-03-14T15:20:12  *** owowo has quit IRC
469 2018-03-14T15:20:45  *** Victorsueca has quit IRC
470 2018-03-14T15:21:54  *** Victorsueca has joined #bitcoin-core-dev
471 2018-03-14T15:24:46  *** promag has quit IRC
472 2018-03-14T15:25:28  *** owowo has joined #bitcoin-core-dev
473 2018-03-14T15:25:33  *** grafcaps has quit IRC
474 2018-03-14T15:28:44  *** CubicEarths has joined #bitcoin-core-dev
475 2018-03-14T15:30:56  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56cc022112af...de2fcaa89a61
476 2018-03-14T15:30:56  <bitcoin-git> bitcoin/master e29c6c8 Nick Vercammen: Ubuntu xenial first dependencies...
477 2018-03-14T15:30:57  <bitcoin-git> bitcoin/master de2fcaa Wladimir J. van der Laan: Merge #12668: Doc: do update before fetching packages in WSL build guide...
478 2018-03-14T15:31:51  <bitcoin-git> [bitcoin] laanwj closed pull request #12668: Doc: do update before fetching packages in WSL build guide (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12668
479 2018-03-14T15:34:14  *** CubicEarths has quit IRC
480 2018-03-14T15:35:10  *** zarez has quit IRC
481 2018-03-14T15:36:51  *** CubicEarths has joined #bitcoin-core-dev
482 2018-03-14T15:40:19  *** SopaXorzTaker has quit IRC
483 2018-03-14T15:41:45  *** CubicEarths has quit IRC
484 2018-03-14T15:41:45  *** SopaXorzTaker has joined #bitcoin-core-dev
485 2018-03-14T15:43:08  *** SopaXorzTaker has quit IRC
486 2018-03-14T15:43:44  *** SopaXorzTaker has joined #bitcoin-core-dev
487 2018-03-14T15:45:01  *** SopaXorzTaker has quit IRC
488 2018-03-14T15:45:39  *** SopaXorzTaker has joined #bitcoin-core-dev
489 2018-03-14T15:47:21  *** CubicEarths has joined #bitcoin-core-dev
490 2018-03-14T15:48:33  *** zarez has joined #bitcoin-core-dev
491 2018-03-14T15:50:09  *** Randolf has quit IRC
492 2018-03-14T15:52:03  *** CubicEarths has quit IRC
493 2018-03-14T15:55:52  *** CubicEarths has joined #bitcoin-core-dev
494 2018-03-14T15:59:57  *** kexkey has joined #bitcoin-core-dev
495 2018-03-14T16:00:57  *** CubicEarths has quit IRC
496 2018-03-14T16:03:29  *** CubicEarths has joined #bitcoin-core-dev
497 2018-03-14T16:04:06  *** dafunkiz_ has joined #bitcoin-core-dev
498 2018-03-14T16:07:57  *** CubicEarths has quit IRC
499 2018-03-14T16:07:58  *** grafcaps has joined #bitcoin-core-dev
500 2018-03-14T16:09:52  *** Aaronvan_ has quit IRC
501 2018-03-14T16:11:03  *** zarez has quit IRC
502 2018-03-14T16:11:16  *** zarez has joined #bitcoin-core-dev
503 2018-03-14T16:12:07  <provoostenator> Does -testsafemode do anything other than display a warning in QT?
504 2018-03-14T16:14:11  *** Randolf has joined #bitcoin-core-dev
505 2018-03-14T16:15:03  <wumpus> no
506 2018-03-14T16:15:40  <wumpus> safe mode never did anything in the GUI (well besides restrict use of RPC, through the debug console)
507 2018-03-14T16:16:35  <wumpus> it's interesting that testsafemode is not used in any of the tests, though maybe that was removed already when safe mode was deprecated
508 2018-03-14T16:17:34  *** AaronvanW has joined #bitcoin-core-dev
509 2018-03-14T16:17:51  *** CubicEarths has joined #bitcoin-core-dev
510 2018-03-14T16:22:09  *** CubicEarths has quit IRC
511 2018-03-14T16:22:25  *** Murch has joined #bitcoin-core-dev
512 2018-03-14T16:27:52  *** schmidty has joined #bitcoin-core-dev
513 2018-03-14T16:28:16  *** schmidty is now known as Guest38422
514 2018-03-14T16:28:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de2fcaa89a61...e7721e667260
515 2018-03-14T16:28:59  <bitcoin-git> bitcoin/master 59f4795 fanquake: docs: Update osx brew install instruction
516 2018-03-14T16:29:00  <bitcoin-git> bitcoin/master e7721e6 Wladimir J. van der Laan: Merge #12586: docs: Update osx brew install instruction...
517 2018-03-14T16:29:44  <bitcoin-git> [bitcoin] laanwj closed pull request #12586: docs: Update osx brew install instruction (master...homebrew-python3-python) https://github.com/bitcoin/bitcoin/pull/12586
518 2018-03-14T16:35:40  *** zarez has quit IRC
519 2018-03-14T16:39:15  <provoostenator> wumpus: should I make a PR to get rid of it then?
520 2018-03-14T16:45:47  *** larafale has joined #bitcoin-core-dev
521 2018-03-14T16:46:58  <wumpus> provoostenator: dunno, I don't think there's really a hurry
522 2018-03-14T16:52:16  <provoostenator> I didn't specificy when :-)
523 2018-03-14T16:53:03  <wumpus> I don't think anyone would be opposed to just removing safe mode and everything assosicated with it, but there's probably more important things, its existence isn't blocking any developments
524 2018-03-14T16:56:09  <wumpus> otoh it was deprecated in 0.16 so removing it in 0.17 would be sensible
525 2018-03-14T16:58:01  <provoostenator> Afaik the parameter literraly doesn't do anything except show that message. It's not setting any (global) variable.
526 2018-03-14T16:59:56  <wumpus> so if you run with -disablesafemode=0 -testsafemode , you should be prevented from executing various RPCs
527 2018-03-14T17:01:07  <wumpus> (to be precise, the ones that call ObserveSafeMode)
528 2018-03-14T17:01:33  *** SopaXorzTaker has quit IRC
529 2018-03-14T17:02:18  <bitcoin-git> [bitcoin] laanwj pushed 14 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7721e667260...e057589dc67f
530 2018-03-14T17:02:19  <bitcoin-git> bitcoin/master 12ec29d Andrew Chow: Calculate and store the number of bytes required to spend an input
531 2018-03-14T17:02:19  <bitcoin-git> bitcoin/master f84fed8 Andrew Chow: Store effective value, fee, and long term fee in CInputCoin...
532 2018-03-14T17:02:20  <bitcoin-git> bitcoin/master 0185939 Andrew Chow: Implement Branch and Bound coin selection in a new file...
533 2018-03-14T17:02:33  <bitcoin-git> [bitcoin] laanwj closed pull request #10637: Coin Selection with Murch's algorithm (master...bnb-coin-select) https://github.com/bitcoin/bitcoin/pull/10637
534 2018-03-14T17:03:44  <Murch> woohoooooo! :D
535 2018-03-14T17:05:42  <wumpus> :D
536 2018-03-14T17:06:25  <wumpus> congratulations, thanks for sticking with this
537 2018-03-14T17:07:09  <provoostenator> Very nice!
538 2018-03-14T17:12:14  *** setpill has quit IRC
539 2018-03-14T17:14:35  *** CubicEarths has joined #bitcoin-core-dev
540 2018-03-14T17:14:45  <Murch> Thank you achow101, instagibbs, morcos, ryanofsky, eklitzke and everyone else! :D
541 2018-03-14T17:14:53  <Murch> This makes me really happy!
542 2018-03-14T17:14:58  <achow101> \O/
543 2018-03-14T17:15:28  <achow101> Time to start working on replacing the fallback strategy
544 2018-03-14T17:16:12  <Murch> Yessir!
545 2018-03-14T17:16:26  <Murch> Thanks wumpus
546 2018-03-14T17:21:22  <bitcoin-git> [bitcoin] Sjors opened pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687
547 2018-03-14T17:21:30  <provoostenator> wumpus: I figured out what I was missing...
548 2018-03-14T17:21:40  *** arbitrary_guy has joined #bitcoin-core-dev
549 2018-03-14T17:22:03  *** rex_4539 has joined #bitcoin-core-dev
550 2018-03-14T17:22:19  *** Chris_Stewart_5 has quit IRC
551 2018-03-14T17:22:19  <bitcoin-git> [bitcoin] Sjors closed pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687
552 2018-03-14T17:23:55  <instagibbs> gave a whoop at taco place when i saw the email. Thanks for all the heavy lifting achow101 :)
553 2018-03-14T17:24:54  <Murch> instagibbs: Everybody was looking at my bewilderedly when I just whooped here at the office. Had to explain what happened. :D
554 2018-03-14T17:26:22  <instagibbs> next: rip up knapsack and crazy transaction looping...
555 2018-03-14T17:28:08  *** dafunkiz_ has quit IRC
556 2018-03-14T17:29:20  <sipa> congrats all, and achow101 and Murch in particular
557 2018-03-14T17:29:21  *** Guest38422 has quit IRC
558 2018-03-14T17:29:56  *** schmidty has joined #bitcoin-core-dev
559 2018-03-14T17:30:20  *** schmidty is now known as Guest74669
560 2018-03-14T17:32:29  *** dafunkiz_ has joined #bitcoin-core-dev
561 2018-03-14T17:34:36  *** setpill has joined #bitcoin-core-dev
562 2018-03-14T17:35:28  *** SopaXorzTaker has joined #bitcoin-core-dev
563 2018-03-14T17:35:29  *** Guest74669 has quit IRC
564 2018-03-14T17:44:46  *** kexkey_ has joined #bitcoin-core-dev
565 2018-03-14T17:47:17  *** timothy has quit IRC
566 2018-03-14T17:47:45  *** kexkey has quit IRC
567 2018-03-14T17:49:33  *** nullptr| has quit IRC
568 2018-03-14T17:50:32  *** nullptr| has joined #bitcoin-core-dev
569 2018-03-14T17:52:39  *** Randolf has quit IRC
570 2018-03-14T17:56:14  *** iyahjeff has joined #bitcoin-core-dev
571 2018-03-14T17:56:52  <iyahjeff> Hi there. Anyone running a full BTC node on Linux that would be kind enough to paste me the output of “du -shm .bitcoin/blocks/”
572 2018-03-14T17:57:24  <arubi> 191199  datadir/blocks/
573 2018-03-14T17:57:51  <arubi> oh this is #-core-dev
574 2018-03-14T17:57:51  <iyahjeff> @arubi Thanks a lot.
575 2018-03-14T17:59:49  *** dafunkiz_ has quit IRC
576 2018-03-14T18:01:10  *** iyahjeff has left #bitcoin-core-dev
577 2018-03-14T18:03:41  *** Strepsils has joined #bitcoin-core-dev
578 2018-03-14T18:20:55  *** LeMiner has joined #bitcoin-core-dev
579 2018-03-14T18:24:21  *** laurentmt has joined #bitcoin-core-dev
580 2018-03-14T18:27:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
581 2018-03-14T18:28:15  *** laurentmt has quit IRC
582 2018-03-14T18:28:32  *** jojeyh has quit IRC
583 2018-03-14T18:32:04  *** SopaXorzTaker has quit IRC
584 2018-03-14T18:38:08  <pierre_rochard> ryanofsky I’m looking at the 0.17 wallet PRs to see what to review next, is #11536 the priority? It seems to precede the two other label PRs
585 2018-03-14T18:38:11  <gribble> https://github.com/bitcoin/bitcoin/issues/11536 | Rename account to label where appropriate by ryanofsky · Pull Request #11536 · bitcoin/bitcoin · GitHub
586 2018-03-14T18:39:46  <ryanofsky> yes, it is meant to be followed up by #7729, then #11497
587 2018-03-14T18:39:49  <gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub
588 2018-03-14T18:39:51  <gribble> https://github.com/bitcoin/bitcoin/issues/11497 | Hide accounts system behind deprecation switch by achow101 · Pull Request #11497 · bitcoin/bitcoin · GitHub
589 2018-03-14T18:40:09  *** arbitrary_guy has quit IRC
590 2018-03-14T18:41:13  *** santiag0 has joined #bitcoin-core-dev
591 2018-03-14T18:48:01  *** qu4ku has joined #bitcoin-core-dev
592 2018-03-14T18:50:25  *** arbitrary_guy has joined #bitcoin-core-dev
593 2018-03-14T18:52:52  *** schmidty has joined #bitcoin-core-dev
594 2018-03-14T18:53:08  *** schmidty has quit IRC
595 2018-03-14T18:53:09  *** schmidty has joined #bitcoin-core-dev
596 2018-03-14T18:54:53  *** d_t has joined #bitcoin-core-dev
597 2018-03-14T18:58:23  *** booyah has quit IRC
598 2018-03-14T18:59:33  *** booyah has joined #bitcoin-core-dev
599 2018-03-14T19:01:12  *** dafunkiz_ has joined #bitcoin-core-dev
600 2018-03-14T19:01:35  *** Strepsils has quit IRC
601 2018-03-14T19:03:34  *** dafunkiz_ has joined #bitcoin-core-dev
602 2018-03-14T19:05:33  *** contrapumpkin has quit IRC
603 2018-03-14T19:07:04  *** contrapumpkin has joined #bitcoin-core-dev
604 2018-03-14T19:10:01  *** qu4ku has quit IRC
605 2018-03-14T19:11:01  *** meshcollider has joined #bitcoin-core-dev
606 2018-03-14T19:17:56  *** dafunkiz_ has quit IRC
607 2018-03-14T19:18:21  <meshcollider> Yay congrats on the coin selection merge finally achow101, Murch \o/
608 2018-03-14T19:27:32  *** Randolf has joined #bitcoin-core-dev
609 2018-03-14T19:28:07  *** AaronvanW has quit IRC
610 2018-03-14T19:29:00  *** dafunkiz_ has joined #bitcoin-core-dev
611 2018-03-14T19:34:25  *** CubicEarths has quit IRC
612 2018-03-14T19:36:45  *** owowo has quit IRC
613 2018-03-14T19:40:25  *** CubicEarths has joined #bitcoin-core-dev
614 2018-03-14T19:40:33  *** Chris_Stewart_5 has quit IRC
615 2018-03-14T19:41:53  *** owowo has joined #bitcoin-core-dev
616 2018-03-14T19:43:10  *** kexkey_ has quit IRC
617 2018-03-14T19:45:44  *** dafunkiz_ has quit IRC
618 2018-03-14T19:49:30  *** HFRadical has quit IRC
619 2018-03-14T19:50:09  *** HFRadical has joined #bitcoin-core-dev
620 2018-03-14T19:53:00  *** HFRadical has quit IRC
621 2018-03-14T19:53:55  *** HFRadical has joined #bitcoin-core-dev
622 2018-03-14T19:56:26  <bitcoin-git> [bitcoin] dooglus closed pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (master...set_hd_seed) https://github.com/bitcoin/bitcoin/pull/11085
623 2018-03-14T19:56:30  *** qu4ku has joined #bitcoin-core-dev
624 2018-03-14T19:59:57  *** santiag0_ has joined #bitcoin-core-dev
625 2018-03-14T20:00:42  *** santiag0_ has quit IRC
626 2018-03-14T20:03:29  *** ossifrage has quit IRC
627 2018-03-14T20:09:01  *** jojeyh has joined #bitcoin-core-dev
628 2018-03-14T20:10:43  *** santiag0_ has joined #bitcoin-core-dev
629 2018-03-14T20:20:16  *** dafunkiz_ has joined #bitcoin-core-dev
630 2018-03-14T20:21:59  *** santiag0_ is now known as jajinkaz
631 2018-03-14T20:22:32  *** jajinkaz is now known as santiago0
632 2018-03-14T20:24:58  *** ossifrage has joined #bitcoin-core-dev
633 2018-03-14T20:26:38  <santiago0> hello
634 2018-03-14T20:35:50  *** jojeyh has quit IRC
635 2018-03-14T20:36:17  <santiago0> I'm IT student. Never participated to bigger projects. How do you manage bitcoin source code? What IDE are you using?
636 2018-03-14T20:38:10  <sipa> text editor
637 2018-03-14T20:38:29  *** santiag0 has quit IRC
638 2018-03-14T20:39:15  <AndyS2> I guess most people just use vim and the command line. After trying a few IDEs, I settled for Eclipse CDT with a VIM plugin for better overview. I'm just fooling around, though.
639 2018-03-14T20:39:40  <AndyS2> Mostly because their debugger has a nice overview and seperate interfaces weren't as nice to use.
640 2018-03-14T20:40:09  <AndyS2> oops
641 2018-03-14T20:42:27  *** promag has joined #bitcoin-core-dev
642 2018-03-14T20:42:59  *** jojeyh has joined #bitcoin-core-dev
643 2018-03-14T20:43:12  <santiago0> ok thanks. Until now I also used VIM for everything.
644 2018-03-14T20:44:55  <AndyS2> It's easier to navigate unknown code with an IDE in my opinion. that said, there's probably some plugin that does just that for vim, too.
645 2018-03-14T20:45:30  <AndyS2> I just got a vim plugin for eclipse. serves my purpose well
646 2018-03-14T20:45:43  <jojeyh> AndyS2, grep -rnw . -e 'stuff to find'
647 2018-03-14T20:46:30  <promag> I believe #12621 is ready to be merged
648 2018-03-14T20:46:32  <gribble> https://github.com/bitcoin/bitcoin/issues/12621 | Avoid querying unnecessary model data when filtering transactions by promag · Pull Request #12621 · bitcoin/bitcoin · GitHub
649 2018-03-14T20:48:03  *** santiago0 has quit IRC
650 2018-03-14T20:51:43  *** goatpig has joined #bitcoin-core-dev
651 2018-03-14T21:05:48  *** Emcy has quit IRC
652 2018-03-14T21:08:09  *** Randolf has quit IRC
653 2018-03-14T21:08:33  *** rex_4539 has quit IRC
654 2018-03-14T21:12:28  *** setpill has quit IRC
655 2018-03-14T21:16:38  *** dafunkiz_ has quit IRC
656 2018-03-14T21:19:33  *** Emcy has joined #bitcoin-core-dev
657 2018-03-14T21:20:23  *** Emcy has quit IRC
658 2018-03-14T21:20:50  *** Emcy has joined #bitcoin-core-dev
659 2018-03-14T21:24:19  *** promag has quit IRC
660 2018-03-14T21:26:53  *** jimbouki has joined #bitcoin-core-dev
661 2018-03-14T21:26:58  *** Randolf has joined #bitcoin-core-dev
662 2018-03-14T21:26:58  *** dafunkiz_ has joined #bitcoin-core-dev
663 2018-03-14T21:28:08  *** Dizzle has joined #bitcoin-core-dev
664 2018-03-14T21:31:44  *** jimbouki has quit IRC
665 2018-03-14T21:38:20  <intcat> jojeyh: or without w
666 2018-03-14T21:43:29  *** jojeyh has quit IRC
667 2018-03-14T21:49:32  *** byteideas has joined #bitcoin-core-dev
668 2018-03-14T21:56:15  *** pgupta has joined #bitcoin-core-dev
669 2018-03-14T22:00:38  *** AaronvanW has joined #bitcoin-core-dev
670 2018-03-14T22:00:57  *** Randolf has quit IRC
671 2018-03-14T22:09:24  *** Guyver2 has quit IRC
672 2018-03-14T22:12:00  *** Randolf has joined #bitcoin-core-dev
673 2018-03-14T22:14:08  *** dafunkiz_ has quit IRC
674 2018-03-14T22:16:20  *** Randolf has quit IRC
675 2018-03-14T22:17:27  <bitcoin-git> [bitcoin] eklitzke opened pull request #12689: Smarter default behavior for -printtoconsole (master...console) https://github.com/bitcoin/bitcoin/pull/12689
676 2018-03-14T22:25:22  *** tknp has joined #bitcoin-core-dev
677 2018-03-14T22:49:33  *** larafale has quit IRC
678 2018-03-14T22:58:54  *** pgupta has quit IRC
679 2018-03-14T23:01:02  *** promag has joined #bitcoin-core-dev
680 2018-03-14T23:01:47  *** dafunkiz_ has joined #bitcoin-core-dev
681 2018-03-14T23:03:52  *** Randolf has joined #bitcoin-core-dev
682 2018-03-14T23:04:30  *** mikgrt has joined #bitcoin-core-dev
683 2018-03-14T23:09:14  *** mikgrt has quit IRC
684 2018-03-14T23:10:57  *** jimbouki has joined #bitcoin-core-dev
685 2018-03-14T23:11:25  *** jimbouki has quit IRC
686 2018-03-14T23:12:23  *** tknp has quit IRC
687 2018-03-14T23:14:14  *** Randolf has quit IRC
688 2018-03-14T23:14:17  <eklitzke> travis is so annoying, it looks like it doesn't properly handle bash arrays when setting up the build environment
689 2018-03-14T23:16:22  *** tecneecs has joined #bitcoin-core-dev
690 2018-03-14T23:22:42  *** mikgrt has joined #bitcoin-core-dev
691 2018-03-14T23:22:44  *** schmidty has quit IRC
692 2018-03-14T23:23:23  *** schmidty has joined #bitcoin-core-dev
693 2018-03-14T23:23:26  *** schmidty is now known as Guest48698
694 2018-03-14T23:27:26  *** mikgrt has quit IRC
695 2018-03-14T23:27:57  *** Guest48698 has quit IRC
696 2018-03-14T23:33:05  *** qu4ku has quit IRC
697 2018-03-14T23:34:31  *** dafunkiz_ has quit IRC
698 2018-03-14T23:38:52  *** Emcy has quit IRC
699 2018-03-14T23:39:28  *** Emcy has joined #bitcoin-core-dev
700 2018-03-14T23:40:47  *** mikgrt has joined #bitcoin-core-dev
701 2018-03-14T23:41:25  *** Randolf has joined #bitcoin-core-dev
702 2018-03-14T23:45:21  *** mikgrt has quit IRC
703 2018-03-14T23:47:41  <eklitzke> hmm, i got another corrupted chainstate database, this time on a different computer
704 2018-03-14T23:47:47  <eklitzke> what's interesting is the crc on the block is correct
705 2018-03-14T23:49:27  *** rafalcpp has quit IRC
706 2018-03-14T23:49:39  *** booyah has quit IRC
707 2018-03-14T23:50:11  <eklitzke> it also thinks that snappy compression is enabled, which is definitely not the case
708 2018-03-14T23:50:13  *** rafalcpp has joined #bitcoin-core-dev
709 2018-03-14T23:50:15  *** larafale has joined #bitcoin-core-dev
710 2018-03-14T23:50:49  *** booyah has joined #bitcoin-core-dev
711 2018-03-14T23:51:16  *** qu4ku has joined #bitcoin-core-dev
712 2018-03-14T23:52:14  *** promag_ has joined #bitcoin-core-dev
713 2018-03-14T23:53:45  *** promag has quit IRC
714 2018-03-14T23:54:57  *** larafale has quit IRC
715 2018-03-14T23:57:37  *** qu4ku has quit IRC
716 2018-03-14T23:58:50  *** mikgrt has joined #bitcoin-core-dev