1 2018-03-28T00:00:03  *** weez17 has quit IRC
  2 2018-03-28T00:00:48  *** weez17 has joined #bitcoin-core-dev
  3 2018-03-28T00:01:57  *** karimofthecrop has quit IRC
  4 2018-03-28T00:04:44  *** karimofthecrop has joined #bitcoin-core-dev
  5 2018-03-28T00:07:21  *** Chris_Stewart_5 has quit IRC
  6 2018-03-28T00:09:47  *** karimofthecrop has quit IRC
  7 2018-03-28T00:13:26  *** meshcollider has quit IRC
  8 2018-03-28T00:18:47  *** jojeyh has quit IRC
  9 2018-03-28T00:24:25  *** meshcollider has joined #bitcoin-core-dev
 10 2018-03-28T00:27:34  *** karimofthecrop has joined #bitcoin-core-dev
 11 2018-03-28T00:31:57  *** karimofthecrop has quit IRC
 12 2018-03-28T00:40:36  *** Murch has quit IRC
 13 2018-03-28T00:42:33  *** Strepsils has quit IRC
 14 2018-03-28T00:52:46  *** jamesob_ has joined #bitcoin-core-dev
 15 2018-03-28T00:56:20  *** promag has joined #bitcoin-core-dev
 16 2018-03-28T00:58:08  *** karimofthecrop has joined #bitcoin-core-dev
 17 2018-03-28T01:00:58  *** promag has quit IRC
 18 2018-03-28T01:06:16  *** AaronvanW has joined #bitcoin-core-dev
 19 2018-03-28T01:08:48  *** jamesob_ has quit IRC
 20 2018-03-28T01:09:10  *** jamesob_ has joined #bitcoin-core-dev
 21 2018-03-28T01:11:48  *** jamesob_ has quit IRC
 22 2018-03-28T01:12:14  *** jamesob_ has joined #bitcoin-core-dev
 23 2018-03-28T01:12:33  *** Randolf has joined #bitcoin-core-dev
 24 2018-03-28T01:14:13  *** jamesob_ has quit IRC
 25 2018-03-28T01:14:21  *** jamesob__ has joined #bitcoin-core-dev
 26 2018-03-28T01:22:53  *** jojeyh has joined #bitcoin-core-dev
 27 2018-03-28T01:29:01  *** d9b4bef9 has quit IRC
 28 2018-03-28T01:30:07  *** d9b4bef9 has joined #bitcoin-core-dev
 29 2018-03-28T01:30:43  *** jamesob___ has joined #bitcoin-core-dev
 30 2018-03-28T01:31:55  *** karimofthecrop has quit IRC
 31 2018-03-28T01:33:38  *** jamesob__ has quit IRC
 32 2018-03-28T01:34:19  *** karimofthecrop has joined #bitcoin-core-dev
 33 2018-03-28T01:43:27  *** dermoth has quit IRC
 34 2018-03-28T01:44:31  *** dermoth has joined #bitcoin-core-dev
 35 2018-03-28T01:49:14  *** harrymm has quit IRC
 36 2018-03-28T01:49:35  *** jojeyh has quit IRC
 37 2018-03-28T02:06:56  *** jojeyh has joined #bitcoin-core-dev
 38 2018-03-28T02:11:00  *** Samdney has quit IRC
 39 2018-03-28T02:21:07  *** contrapumpkin has joined #bitcoin-core-dev
 40 2018-03-28T02:21:22  *** jb55 has joined #bitcoin-core-dev
 41 2018-03-28T02:22:49  *** karimofthecrop has quit IRC
 42 2018-03-28T02:23:50  *** karimofthecrop has joined #bitcoin-core-dev
 43 2018-03-28T02:28:33  *** karimofthecrop has quit IRC
 44 2018-03-28T02:36:49  *** jamesob___ has quit IRC
 45 2018-03-28T02:43:04  *** belcher has quit IRC
 46 2018-03-28T02:47:13  *** promag has joined #bitcoin-core-dev
 47 2018-03-28T02:48:26  *** rex4539 has joined #bitcoin-core-dev
 48 2018-03-28T02:52:17  *** promag has quit IRC
 49 2018-03-28T02:57:21  *** Randolf has quit IRC
 50 2018-03-28T03:02:45  *** rex4539 has quit IRC
 51 2018-03-28T03:17:19  *** Krellan has quit IRC
 52 2018-03-28T03:35:09  *** jb55 has quit IRC
 53 2018-03-28T03:49:49  *** karimofthecrop has joined #bitcoin-core-dev
 54 2018-03-28T03:53:51  *** karimofthecrop has quit IRC
 55 2018-03-28T04:03:33  *** Randolf has joined #bitcoin-core-dev
 56 2018-03-28T04:17:56  *** promag has joined #bitcoin-core-dev
 57 2018-03-28T04:23:11  *** promag has quit IRC
 58 2018-03-28T04:24:36  *** karimofthecrop has joined #bitcoin-core-dev
 59 2018-03-28T04:30:11  *** aruns has joined #bitcoin-core-dev
 60 2018-03-28T04:31:25  *** karimofthecrop has quit IRC
 61 2018-03-28T04:38:56  *** r251d has quit IRC
 62 2018-03-28T04:39:21  *** r251d has joined #bitcoin-core-dev
 63 2018-03-28T04:46:54  *** lnostdal has quit IRC
 64 2018-03-28T04:53:46  *** Randolf has quit IRC
 65 2018-03-28T05:02:43  *** jtimon has quit IRC
 66 2018-03-28T05:03:01  *** lnostdal has joined #bitcoin-core-dev
 67 2018-03-28T05:06:52  *** promag has joined #bitcoin-core-dev
 68 2018-03-28T05:11:30  *** promag has quit IRC
 69 2018-03-28T05:15:52  *** karimofthecrop has joined #bitcoin-core-dev
 70 2018-03-28T05:20:09  *** karimofthecrop has quit IRC
 71 2018-03-28T05:33:16  *** Randolf has joined #bitcoin-core-dev
 72 2018-03-28T05:33:53  *** aruns has quit IRC
 73 2018-03-28T05:34:42  *** games_ is now known as bloatlet
 74 2018-03-28T05:35:16  *** grafcaps has quit IRC
 75 2018-03-28T05:37:06  *** grafcaps has joined #bitcoin-core-dev
 76 2018-03-28T06:01:41  *** Krellan has joined #bitcoin-core-dev
 77 2018-03-28T06:07:11  *** Krellan has quit IRC
 78 2018-03-28T06:16:27  *** promag has joined #bitcoin-core-dev
 79 2018-03-28T06:17:03  *** indistylo has joined #bitcoin-core-dev
 80 2018-03-28T06:17:30  *** flotwig_ has joined #bitcoin-core-dev
 81 2018-03-28T06:18:35  *** flotwig has quit IRC
 82 2018-03-28T06:20:24  *** flotwig_ is now known as flotwig
 83 2018-03-28T06:20:45  *** flotwig has joined #bitcoin-core-dev
 84 2018-03-28T06:21:24  *** promag has quit IRC
 85 2018-03-28T06:25:21  *** flotwig has quit IRC
 86 2018-03-28T06:28:07  *** qrestlove has quit IRC
 87 2018-03-28T06:29:16  *** commavir has quit IRC
 88 2018-03-28T06:30:29  *** flotwig has joined #bitcoin-core-dev
 89 2018-03-28T06:30:47  <bitcoin-git> [bitcoin] murrayn opened pull request #12809: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/12809
 90 2018-03-28T06:34:10  *** flotwig has quit IRC
 91 2018-03-28T06:34:32  *** flotwig has joined #bitcoin-core-dev
 92 2018-03-28T06:40:04  *** commavir has joined #bitcoin-core-dev
 93 2018-03-28T06:40:36  *** qrestlove has joined #bitcoin-core-dev
 94 2018-03-28T06:42:55  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 95 2018-03-28T06:42:55  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 96 2018-03-28T06:44:53  *** jdgs has joined #bitcoin-core-dev
 97 2018-03-28T06:51:29  *** promag has joined #bitcoin-core-dev
 98 2018-03-28T06:53:30  <bitcoin-git> [bitcoin] romanz opened pull request #12810: [Tests] Fix a typo at assert_start_raises_init_error() and update its invocation (master...fix-blocksdir-test) https://github.com/bitcoin/bitcoin/pull/12810
 99 2018-03-28T06:55:14  *** indistylo has quit IRC
100 2018-03-28T06:55:51  *** promag has quit IRC
101 2018-03-28T06:56:29  *** promag has joined #bitcoin-core-dev
102 2018-03-28T06:58:15  *** promag has quit IRC
103 2018-03-28T07:08:05  *** indistylo has joined #bitcoin-core-dev
104 2018-03-28T07:10:38  *** aruns has joined #bitcoin-core-dev
105 2018-03-28T07:13:36  *** indistylo has quit IRC
106 2018-03-28T07:16:13  *** karimofthecrop has joined #bitcoin-core-dev
107 2018-03-28T07:17:56  *** Krellan has joined #bitcoin-core-dev
108 2018-03-28T07:21:23  *** karimofthecrop has quit IRC
109 2018-03-28T07:24:32  *** Krellan has quit IRC
110 2018-03-28T07:29:26  *** jtimon has joined #bitcoin-core-dev
111 2018-03-28T07:29:37  *** zarez has joined #bitcoin-core-dev
112 2018-03-28T07:32:04  *** bloatlet is now known as games_
113 2018-03-28T07:32:54  *** Victorsueca has quit IRC
114 2018-03-28T07:33:20  *** karimofthecrop has joined #bitcoin-core-dev
115 2018-03-28T07:34:12  *** Victorsueca has joined #bitcoin-core-dev
116 2018-03-28T07:34:22  <wumpus> I've added jnewbery to the issue management team: there's now fanquake, meshcollider, cfields and jnewbery that can help with issues and PRs on github, and open/close them
117 2018-03-28T07:38:16  *** karimofthecrop has quit IRC
118 2018-03-28T07:41:57  *** asoltys has quit IRC
119 2018-03-28T07:43:10  *** asoltys has joined #bitcoin-core-dev
120 2018-03-28T07:51:52  *** aruns has quit IRC
121 2018-03-28T07:53:47  *** setpill has joined #bitcoin-core-dev
122 2018-03-28T07:55:36  *** laurentmt has joined #bitcoin-core-dev
123 2018-03-28T08:10:27  <aj> wumpus: if you haven't noticed already, #12806 is needed to fix travis failure on master
124 2018-03-28T08:10:29  <gribble> https://github.com/bitcoin/bitcoin/issues/12806 | qa: Fix function names in feature_blocksdir by MarcoFalke · Pull Request #12806 · bitcoin/bitcoin · GitHub
125 2018-03-28T08:16:51  *** timothy has joined #bitcoin-core-dev
126 2018-03-28T08:21:20  *** drizztbsd has joined #bitcoin-core-dev
127 2018-03-28T08:21:35  *** jtimon has quit IRC
128 2018-03-28T08:22:11  *** timothy has quit IRC
129 2018-03-28T08:24:20  *** setpill has quit IRC
130 2018-03-28T08:24:42  *** setpill has joined #bitcoin-core-dev
131 2018-03-28T08:51:40  *** indistylo has joined #bitcoin-core-dev
132 2018-03-28T08:57:42  <wumpus> aj: thanks
133 2018-03-28T08:57:46  *** BashCo_ has joined #bitcoin-core-dev
134 2018-03-28T08:58:08  <wumpus> aj: it's strange, I don't have errors while running the test suite locally
135 2018-03-28T08:58:09  *** BashCo has quit IRC
136 2018-03-28T08:58:58  <aj> wumpus: really? feature_blocksdir should be failing pretty trivially
137 2018-03-28T08:59:25  <wumpus> let me check again
138 2018-03-28T08:59:51  <wumpus> first want to be sure because I might have a stale file around or such
139 2018-03-28T09:01:08  *** jouke has quit IRC
140 2018-03-28T09:01:11  *** JackH has quit IRC
141 2018-03-28T09:01:22  *** jouke_ has joined #bitcoin-core-dev
142 2018-03-28T09:02:31  <provoostenator> I'll run it on macOS. Though in my experience the functional test suite rarely passes in a single attempt on my machine.
143 2018-03-28T09:04:16  <wumpus> ok yes it's failing
144 2018-03-28T09:06:10  <wumpus> let's make the FAILED on the last line red when things fail
145 2018-03-28T09:06:21  <aj> wumpus: there's #12810 as well, but i hadn't noticed it causing a bug
146 2018-03-28T09:06:22  <gribble> https://github.com/bitcoin/bitcoin/issues/12810 | [Tests] Fix a typo at assert_start_raises_init_error() by romanz · Pull Request #12810 · bitcoin/bitcoin · GitHub
147 2018-03-28T09:06:41  <wumpus> it must have just scrolled by yesterday as feature_blocksdir.py is one of the first in the long list, apparently didn't notice
148 2018-03-28T09:11:08  *** jouke has joined #bitcoin-core-dev
149 2018-03-28T09:11:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac898b689c66...18606eb475fb
150 2018-03-28T09:11:33  <bitcoin-git> bitcoin/master d71bedb MarcoFalke: qa: Fix function names in feature_blocksdir
151 2018-03-28T09:11:34  <bitcoin-git> bitcoin/master 18606eb Wladimir J. van der Laan: Merge #12806: qa: Fix function names in feature_blocksdir...
152 2018-03-28T09:12:27  <bitcoin-git> [bitcoin] laanwj closed pull request #12806: qa: Fix function names in feature_blocksdir (master...Mf1803-qaBlocksdirFixup) https://github.com/bitcoin/bitcoin/pull/12806
153 2018-03-28T09:22:53  <bitcoin-git> [bitcoin] laanwj opened pull request #12811: test: Make summary row bold-red if any test failed (master...2018_03_tests_summaryrow) https://github.com/bitcoin/bitcoin/pull/12811
154 2018-03-28T09:24:12  *** AaronvanW has joined #bitcoin-core-dev
155 2018-03-28T09:25:39  *** Aaronvan_ has joined #bitcoin-core-dev
156 2018-03-28T09:29:49  *** AaronvanW has quit IRC
157 2018-03-28T09:30:57  *** laurentmt has quit IRC
158 2018-03-28T09:34:04  *** karimofthecrop has joined #bitcoin-core-dev
159 2018-03-28T09:38:09  *** karimofthecrop has quit IRC
160 2018-03-28T09:38:16  *** aruns__ has joined #bitcoin-core-dev
161 2018-03-28T09:40:49  *** indistylo has quit IRC
162 2018-03-28T09:45:47  *** SopaXorzTaker has joined #bitcoin-core-dev
163 2018-03-28T09:46:35  *** jdgs has quit IRC
164 2018-03-28T09:59:56  <aj> wumpus: if you're making test_runner nicer, might work to just report all the failed tests at the end so they're easy to find. https://github.com/laanwj/bitcoin/pull/6 has sample code
165 2018-03-28T10:00:22  <wumpus> yes, there's probably a ton of different things that could be done
166 2018-03-28T10:00:38  <wumpus> I like making the row red though
167 2018-03-28T10:01:04  <wumpus> though could do what you propose in addition to that, as it saves scrolling to find what failed
168 2018-03-28T10:01:06  <aj> wumpus: i meant as well, not instead :)
169 2018-03-28T10:01:09  <wumpus> right :)
170 2018-03-28T10:03:03  <wumpus> I'll pull in your commit
171 2018-03-28T10:03:35  <aj> wumpus: feel free to squash it, i didn't write a good commit message :)
172 2018-03-28T10:04:09  *** indistylo has joined #bitcoin-core-dev
173 2018-03-28T10:04:26  <wumpus> instead of adding a sort_key we change the natural sorting order of the object
174 2018-03-28T10:04:53  *** suldev has joined #bitcoin-core-dev
175 2018-03-28T10:05:06  <wumpus> probably want to sort by 1) status, then within that 2) name
176 2018-03-28T10:05:17  <wumpus> oh it does
177 2018-03-28T10:05:37  *** aruns__ has quit IRC
178 2018-03-28T10:13:23  *** rafalcpp has quit IRC
179 2018-03-28T10:14:10  *** rafalcpp has joined #bitcoin-core-dev
180 2018-03-28T10:15:31  <bitcoin-git> [bitcoin] Empact opened pull request #12812: Test ReadConfigFile (master...test-read-config-file) https://github.com/bitcoin/bitcoin/pull/12812
181 2018-03-28T10:17:30  *** arubi has quit IRC
182 2018-03-28T10:17:59  *** arubi has joined #bitcoin-core-dev
183 2018-03-28T10:19:05  *** CubicEarths has quit IRC
184 2018-03-28T10:25:16  <bitcoin-git> [bitcoin] murrayn opened pull request #12813: Update man pages (master...man_pages) https://github.com/bitcoin/bitcoin/pull/12813
185 2018-03-28T10:34:05  *** CubicEarths has joined #bitcoin-core-dev
186 2018-03-28T10:38:48  *** fanquake has joined #bitcoin-core-dev
187 2018-03-28T10:43:15  <aj> wumpus: right, could define __lt__(self, other) by the looks; but i think dealing with status would be more painful that way
188 2018-03-28T10:43:40  <wumpus> yes, I looked at it and decided not to bother, it works fine like this, no use in overthinking it
189 2018-03-28T10:44:36  <wumpus> in a way having the sort key explicit is kind of nice instead of wondering what kind of magic makes it work
190 2018-03-28T10:48:08  *** fanquake has quit IRC
191 2018-03-28T10:48:57  *** suldev has quit IRC
192 2018-03-28T10:58:47  <bitcoin-git> [bitcoin] murrayn closed pull request #12813: Update man pages (master...man_pages) https://github.com/bitcoin/bitcoin/pull/12813
193 2018-03-28T10:59:52  <jnewbery> Is there a way to block user https://github.com/btcerichcom from opening issues/PRs?
194 2018-03-28T11:05:22  *** drizztbsd is now known as timothy
195 2018-03-28T11:05:29  <wumpus> yes, I'll do it
196 2018-03-28T11:05:56  <bitcoin-git> [bitcoin] jnewbery closed pull request #11614: ZMQ: Add decodedtx topic for JSON tx publishing (master...master) https://github.com/bitcoin/bitcoin/pull/11614
197 2018-03-28T11:07:35  *** indistylo has quit IRC
198 2018-03-28T11:09:33  *** indistylo has joined #bitcoin-core-dev
199 2018-03-28T11:18:39  *** Krellan has joined #bitcoin-core-dev
200 2018-03-28T11:23:09  *** Giszmo has quit IRC
201 2018-03-28T11:23:44  *** Krellan has quit IRC
202 2018-03-28T11:25:05  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/18606eb475fb...174d0160cb6b
203 2018-03-28T11:25:05  <bitcoin-git> bitcoin/master adc2586 MarcoFalke: doc: Refer to witness reserved value as spec. in the BIP
204 2018-03-28T11:25:06  <bitcoin-git> bitcoin/master 174d016 Wladimir J. van der Laan: Merge #12798: doc: Refer to witness reserved value as spec. in the BIP...
205 2018-03-28T11:25:48  <bitcoin-git> [bitcoin] laanwj closed pull request #12798: doc: Refer to witness reserved value as spec. in the BIP (master...Mf1803-docWitnessReservedValue) https://github.com/bitcoin/bitcoin/pull/12798
206 2018-03-28T11:27:46  *** Muis has quit IRC
207 2018-03-28T11:34:23  *** karimofthecrop has joined #bitcoin-core-dev
208 2018-03-28T11:36:43  *** Giszmo has joined #bitcoin-core-dev
209 2018-03-28T11:38:49  *** karimofthecrop has quit IRC
210 2018-03-28T11:44:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
211 2018-03-28T11:52:29  <provoostenator> What is bitdb in #11625 ryanofsky?
212 2018-03-28T11:52:31  <gribble> https://github.com/bitcoin/bitcoin/issues/11625 | WIP: Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
213 2018-03-28T12:11:33  *** promag has joined #bitcoin-core-dev
214 2018-03-28T12:22:06  *** zarez has quit IRC
215 2018-03-28T12:23:32  *** promag has quit IRC
216 2018-03-28T12:26:00  *** promag has joined #bitcoin-core-dev
217 2018-03-28T12:29:46  *** zarez has joined #bitcoin-core-dev
218 2018-03-28T12:30:26  *** Chris_Stewart_5 has quit IRC
219 2018-03-28T12:31:03  *** esotericnonsense has quit IRC
220 2018-03-28T12:45:17  *** jtimon has joined #bitcoin-core-dev
221 2018-03-28T12:52:11  *** aruns has joined #bitcoin-core-dev
222 2018-03-28T12:54:22  *** promag has quit IRC
223 2018-03-28T12:55:09  *** indistylo has quit IRC
224 2018-03-28T12:57:19  *** moneyball has joined #bitcoin-core-dev
225 2018-03-28T13:00:41  *** aruns__ has joined #bitcoin-core-dev
226 2018-03-28T13:03:05  *** aruns has quit IRC
227 2018-03-28T13:21:02  *** d9b4bef9 has quit IRC
228 2018-03-28T13:22:32  *** moneyball has quit IRC
229 2018-03-28T13:24:16  *** d9b4bef9 has joined #bitcoin-core-dev
230 2018-03-28T13:27:10  *** belcher has joined #bitcoin-core-dev
231 2018-03-28T13:30:14  *** esotericnonsense has joined #bitcoin-core-dev
232 2018-03-28T13:31:49  *** promag has joined #bitcoin-core-dev
233 2018-03-28T13:31:53  *** promag has quit IRC
234 2018-03-28T13:32:40  *** Guyver2 has joined #bitcoin-core-dev
235 2018-03-28T13:34:06  *** marcoagner has joined #bitcoin-core-dev
236 2018-03-28T13:42:00  *** setpill has quit IRC
237 2018-03-28T13:45:32  *** AaronvanW has joined #bitcoin-core-dev
238 2018-03-28T13:47:45  *** Aaronvan_ has quit IRC
239 2018-03-28T13:50:36  *** Aaronvan_ has joined #bitcoin-core-dev
240 2018-03-28T13:51:07  *** jamesob___ has joined #bitcoin-core-dev
241 2018-03-28T13:53:35  *** AaronvanW has quit IRC
242 2018-03-28T13:56:45  *** aruns__ has quit IRC
243 2018-03-28T13:57:17  *** Victorsueca has quit IRC
244 2018-03-28T13:58:27  *** Victorsueca has joined #bitcoin-core-dev
245 2018-03-28T14:01:04  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/174d0160cb6b...0d8fc8de076d
246 2018-03-28T14:01:05  <bitcoin-git> bitcoin/master f92541f Wladimir J. van der Laan: test: Make summary row bold-red if any test failed...
247 2018-03-28T14:01:06  <bitcoin-git> bitcoin/master ffb033a Anthony Towns: test: List any failed tests at the end of test_runner output...
248 2018-03-28T14:01:06  <bitcoin-git> bitcoin/master 0d8fc8d Wladimir J. van der Laan: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table...
249 2018-03-28T14:01:55  <bitcoin-git> [bitcoin] laanwj closed pull request #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table (master...2018_03_tests_summaryrow) https://github.com/bitcoin/bitcoin/pull/12811
250 2018-03-28T14:10:46  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d8fc8de076d...624bee96597c
251 2018-03-28T14:10:47  <bitcoin-git> bitcoin/master bc6fdf2 John Newbery: Change all python files to use Python3
252 2018-03-28T14:10:47  <bitcoin-git> bitcoin/master 1874058 Evan Klitzke: Make base58 python contrib code work with python3
253 2018-03-28T14:10:48  <bitcoin-git> bitcoin/master 624bee9 Wladimir J. van der Laan: Merge #11881: Remove Python2 support...
254 2018-03-28T14:11:07  <bitcoin-git> [bitcoin] laanwj closed pull request #11881: Remove Python2 support (master...remove_python2) https://github.com/bitcoin/bitcoin/pull/11881
255 2018-03-28T14:16:47  *** karimofthecrop has joined #bitcoin-core-dev
256 2018-03-28T14:21:20  *** karimofthecrop has quit IRC
257 2018-03-28T14:33:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
258 2018-03-28T14:33:26  *** meshcollider has quit IRC
259 2018-03-28T14:39:40  *** moneyball has joined #bitcoin-core-dev
260 2018-03-28T14:40:51  *** Murch has joined #bitcoin-core-dev
261 2018-03-28T14:43:17  <bitcoin-git> [bitcoin] Sjors opened pull request #12818: [qt] TransactionView: highlight replacement tx after fee bump (master...2018/03/bump-fee-focus) https://github.com/bitcoin/bitcoin/pull/12818
262 2018-03-28T14:52:16  *** jamesob___ is now known as jamesob_
263 2018-03-28T14:59:58  *** zarez has quit IRC
264 2018-03-28T15:09:56  *** commavir has quit IRC
265 2018-03-28T15:10:41  *** flotwig has quit IRC
266 2018-03-28T15:10:59  *** flotwig has joined #bitcoin-core-dev
267 2018-03-28T15:11:10  *** commavir has joined #bitcoin-core-dev
268 2018-03-28T15:14:08  *** Samdney has joined #bitcoin-core-dev
269 2018-03-28T15:18:55  *** Krellan has joined #bitcoin-core-dev
270 2018-03-28T15:19:30  *** marcoagner has quit IRC
271 2018-03-28T15:23:51  *** Krellan has quit IRC
272 2018-03-28T15:25:44  *** Dizzle has joined #bitcoin-core-dev
273 2018-03-28T15:47:17  <BlueMatt> #10762 looks very merge-able
274 2018-03-28T15:47:20  <BlueMatt> wumpus: ^
275 2018-03-28T15:47:20  <gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
276 2018-03-28T15:48:28  *** belcher has quit IRC
277 2018-03-28T15:50:23  *** marcoagner has joined #bitcoin-core-dev
278 2018-03-28T15:50:25  *** Randolf has quit IRC
279 2018-03-28T15:58:21  *** marcoagner has quit IRC
280 2018-03-28T16:02:59  *** flotwig_ has joined #bitcoin-core-dev
281 2018-03-28T16:03:57  *** flotwig has quit IRC
282 2018-03-28T16:03:58  *** flotwig_ is now known as flotwig
283 2018-03-28T16:05:15  <jnewbery> release-notes.md conflicts are really irritating. Any thoughts on how to make them stop? Perhaps have a separate release-notes file for each PR that requires them, eg release-notes-pr1234.md, and then concatenate/edit them before the release? Release notes need a lot of editing anyway, so might not add too much overhead
284 2018-03-28T16:06:48  *** jb55 has joined #bitcoin-core-dev
285 2018-03-28T16:09:54  *** linasv has quit IRC
286 2018-03-28T16:09:54  *** Alekszej has quit IRC
287 2018-03-28T16:11:07  <sipa> jnewbery: that doesn't seem like more overhead than the to-wiki-and-back dance we do already at the end
288 2018-03-28T16:12:21  *** jb55 has quit IRC
289 2018-03-28T16:13:38  *** marcoagner has joined #bitcoin-core-dev
290 2018-03-28T16:14:54  <BlueMatt> jimpo: I'd really rather the paralell-txindex stuff not have its own thread
291 2018-03-28T16:15:27  <BlueMatt> we have too much thread proliferation already, can it not fit cleanly into just running in the scheduler/validationinterface thread(s) (and we can add another thread there when things get too full)
292 2018-03-28T16:25:04  *** esotericnonsense has quit IRC
293 2018-03-28T16:25:37  *** grafcaps has quit IRC
294 2018-03-28T16:34:25  *** esotericnonsense has joined #bitcoin-core-dev
295 2018-03-28T16:34:51  *** AaronvanW has joined #bitcoin-core-dev
296 2018-03-28T16:36:04  <jimpo> BlueMatt the thread is just for when the index needs to catch up to the blockchain state from way behind (like behind BlockConnected callbacks).
297 2018-03-28T16:36:26  <jimpo> Once it gets in sync once, the thread exits and the index is kept in sync by the validation interface.
298 2018-03-28T16:36:42  <BlueMatt> ah, ok, right, will finish reviewing before I comment more :p
299 2018-03-28T16:37:00  <jimpo> \o/ Code review is happening!
300 2018-03-28T16:38:50  *** MarcoFalke_trave has joined #bitcoin-core-dev
301 2018-03-28T16:38:50  *** Aaronvan_ has quit IRC
302 2018-03-28T16:38:50  *** Victorsueca has quit IRC
303 2018-03-28T16:39:01  <MarcoFalke_trave> wumpus, Are you around for merges? I might send you a list of pulls
304 2018-03-28T16:40:03  *** Victorsueca has joined #bitcoin-core-dev
305 2018-03-28T16:40:05  *** moneyball has quit IRC
306 2018-03-28T16:43:39  *** grafcaps has joined #bitcoin-core-dev
307 2018-03-28T16:51:00  *** tryphe_ has joined #bitcoin-core-dev
308 2018-03-28T16:53:10  *** tryphe has quit IRC
309 2018-03-28T16:55:12  *** Aaronvan_ has joined #bitcoin-core-dev
310 2018-03-28T16:57:51  *** AaronvanW has quit IRC
311 2018-03-28T17:04:56  *** MarcoFalke_trave has quit IRC
312 2018-03-28T17:05:13  *** MarcoFalke_trave has joined #bitcoin-core-dev
313 2018-03-28T17:12:54  *** moneyball has joined #bitcoin-core-dev
314 2018-03-28T17:14:35  *** paulg222 has joined #bitcoin-core-dev
315 2018-03-28T17:14:46  *** timothy has quit IRC
316 2018-03-28T17:15:24  *** Strepsils has joined #bitcoin-core-dev
317 2018-03-28T17:16:58  <paulg222> with bitcoin 0.16 in regtest mode I'm seeing that coinbase transactions are not going to a segwit p2sh wrapped address, but to a regular p2pkh address. Is that expected?
318 2018-03-28T17:21:30  <arubi> paulg222, it's going to a p2pk, not p2pkh.  use generatetoaddress
319 2018-03-28T17:21:48  <arubi> (if you want a different address that is)
320 2018-03-28T17:22:46  *** aruns__ has joined #bitcoin-core-dev
321 2018-03-28T17:23:02  <instagibbs> jnewbery, ive had to rebase a couple PRs a couple times each due to that :/
322 2018-03-28T17:25:01  *** d9b4bef9 has quit IRC
323 2018-03-28T17:26:09  *** d9b4bef9 has joined #bitcoin-core-dev
324 2018-03-28T17:26:32  *** marcoagner has quit IRC
325 2018-03-28T17:27:33  <sipa> instagibbs: easy rebases, thankfully :)
326 2018-03-28T17:28:26  <instagibbs> muh acks!
327 2018-03-28T17:48:19  *** paulg222 has quit IRC
328 2018-03-28T17:55:41  *** Dizzle has quit IRC
329 2018-03-28T18:02:43  *** timothy has joined #bitcoin-core-dev
330 2018-03-28T18:03:02  *** goatpig has joined #bitcoin-core-dev
331 2018-03-28T18:04:50  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12820: contrib: Fix check-doc script regexes (master...Mf1803-qaCheckDocRegex) https://github.com/bitcoin/bitcoin/pull/12820
332 2018-03-28T18:05:17  *** timothy has quit IRC
333 2018-03-28T18:07:17  *** TD-Linux has quit IRC
334 2018-03-28T18:07:24  *** TD--Linux has joined #bitcoin-core-dev
335 2018-03-28T18:15:05  *** Ge0rges has quit IRC
336 2018-03-28T18:20:16  *** Ge0rges has joined #bitcoin-core-dev
337 2018-03-28T18:21:41  *** marcoagner has joined #bitcoin-core-dev
338 2018-03-28T18:22:50  *** cdecker has joined #bitcoin-core-dev
339 2018-03-28T18:26:12  *** JackH has joined #bitcoin-core-dev
340 2018-03-28T18:37:07  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12821: contrib: Remove unused import string (master...Mf1803-contribUnusedImportClangFormatDiff) https://github.com/bitcoin/bitcoin/pull/12821
341 2018-03-28T18:44:36  <BlueMatt> https://github.com/bitcoin/bitcoin/commit/7deba93bdc76616011a9f493cbc203d60084416f <-- wtf? we dont bump trusted-git-root when a pgp key expires...this is what allow-revsit-commits is for. let alone doing so without removing the key from trusted-keys :(
342 2018-03-28T18:46:01  *** aruns__ has quit IRC
343 2018-03-28T18:52:15  *** marcoagner has quit IRC
344 2018-03-28T18:56:42  *** Strepsils has quit IRC
345 2018-03-28T18:58:04  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12822: Revert 7deba93bdc76616011a9f493cbc203d60084416f and fix expired-key-sigs properly (master...master) https://github.com/bitcoin/bitcoin/pull/12822
346 2018-03-28T18:58:23  *** Randolf has joined #bitcoin-core-dev
347 2018-03-28T18:59:59  <MarcoFalke_trave> BlueMatt, they keys in trusted-keys are the root keys
348 2018-03-28T19:00:07  <MarcoFalke_trave> Can't remove them
349 2018-03-28T19:00:20  <MarcoFalke_trave> Imo we should change them to the specific subkeys instead
350 2018-03-28T19:00:39  <BlueMatt> the key in question expired
351 2018-03-28T19:00:44  <MarcoFalke_trave> sipa, around? Mind to merge #12821
352 2018-03-28T19:00:45  <gribble> https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
353 2018-03-28T19:00:46  <BlueMatt> we tried that, it didnt work very well
354 2018-03-28T19:00:54  <BlueMatt> we started with the subkeys listed
355 2018-03-28T19:00:56  <BlueMatt> and things blew up regularly
356 2018-03-28T19:01:30  <BlueMatt> oh, you're saying your root isnt expired, yea, ok
357 2018-03-28T19:01:38  <BlueMatt> either way, shouldnt have updated trusted-git-root
358 2018-03-28T19:01:44  <BlueMatt> let alone doing so without a fucking PR
359 2018-03-28T19:02:18  <MarcoFalke_trave> Having the root key in there means I can't ever put a subkey on a different machine
360 2018-03-28T19:02:49  <MarcoFalke_trave> :s/different/slightly compromised/
361 2018-03-28T19:02:52  <BlueMatt> if thats your concern you should have a git-signing separate primary key
362 2018-03-28T19:03:03  <BlueMatt> fully-separate them instead of partially combining them
363 2018-03-28T19:03:24  <eklitzke> maco when you're traveling your nick should be MarcoPolo
364 2018-03-28T19:05:42  *** tryphe has joined #bitcoin-core-dev
365 2018-03-28T19:06:02  <instagibbs> sdaftuar the `IsDust` use in both relay and wallet policy seems like it makes reasoning about p2sh outputs weird to me. I guess you just pretend the output is p2sh-p2wpkh, and use that for relay dust calculation?
366 2018-03-28T19:06:21  <instagibbs> (I'm leaving it for now, just thinking aloud)
367 2018-03-28T19:06:28  <sdaftuar> instagibbs: yeah i was wondering what effect this has on relay policy too -- but figure we might as well just make it right for our wallet at least
368 2018-03-28T19:07:17  *** MarcoFalke_trave is now known as MarcoPolo
369 2018-03-28T19:07:21  <instagibbs> the functional test already is pretty coarse-grained
370 2018-03-28T19:07:25  <sdaftuar> so we could just add a way to indicate we want the p2sh-p2wpkh assumption and use that only for our wallet, if we don't want to change relay policy
371 2018-03-28T19:07:30  <instagibbs> checks that you dump 100 satoshis
372 2018-03-28T19:07:36  *** MarcoPolo is now known as MarcoFalke_trave
373 2018-03-28T19:07:43  <instagibbs> right
374 2018-03-28T19:08:06  <instagibbs> or just split the concerns to allow us to move faster with wallet stuff
375 2018-03-28T19:08:41  <sdaftuar> oh hmm.  i guess the reason we have a discard rate in the first place is to be sure that we have a buffer above the prevailing network dust-fee
376 2018-03-28T19:08:47  <sdaftuar> so splitting might be counter to that a little
377 2018-03-28T19:08:48  *** marcoagner has joined #bitcoin-core-dev
378 2018-03-28T19:09:08  *** tryphe_ has quit IRC
379 2018-03-28T19:09:10  <sdaftuar> in that we might decouple our calculation from the network-wide policy
380 2018-03-28T19:10:56  <sdaftuar> oh.. so this is unfortunate i guess, in that current network nodes are applying a dust threshold that is "too high" for our p2sh-segwit wallet. good thing we have a discard rate in the first place i guess!  but given that it gets capped at the long term fee estimate, i'm not sure what value we're actually using now
381 2018-03-28T19:11:46  *** nitramiz has joined #bitcoin-core-dev
382 2018-03-28T19:14:52  <instagibbs> ill update the test at least to be a bit tighter
383 2018-03-28T19:26:46  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12823: doc: Add .gitattributes file for release-notes.md (master...Mf1803-docGitattributes) https://github.com/bitcoin/bitcoin/pull/12823
384 2018-03-28T19:33:22  <BlueMatt> #12754 does not look like an "upstream" issue - the reporter indicating some things we should probably do that make upstream behave the proper way
385 2018-03-28T19:33:23  <gribble> https://github.com/bitcoin/bitcoin/issues/12754 | [zmq] pub/sub is not reliable at all · Issue #12754 · bitcoin/bitcoin · GitHub
386 2018-03-28T19:33:26  <BlueMatt> should lose the upstream tag
387 2018-03-28T19:33:39  *** Aaronvan_ has quit IRC
388 2018-03-28T19:33:59  <MarcoFalke_trave> Removed
389 2018-03-28T19:34:22  *** nitramiz has quit IRC
390 2018-03-28T19:34:31  *** nitramiz has joined #bitcoin-core-dev
391 2018-03-28T19:44:42  *** SopaXorzTaker has quit IRC
392 2018-03-28T19:49:14  *** Murch has quit IRC
393 2018-03-28T19:50:07  *** nitramiz has quit IRC
394 2018-03-28T19:50:14  *** Murch has joined #bitcoin-core-dev
395 2018-03-28T19:53:46  *** Randolf has quit IRC
396 2018-03-28T19:54:05  *** Tennis has joined #bitcoin-core-dev
397 2018-03-28T19:57:41  *** belcher has joined #bitcoin-core-dev
398 2018-03-28T20:01:36  *** marcoagner has quit IRC
399 2018-03-28T20:04:20  <hkjn0> hey, maybe I'm just missing something basic here, but I had a tx which sendrawtransaction accepted and returned txid, but getrawtransaction (with txindex=1) still can't find.. how can this happen?
400 2018-03-28T20:05:34  <hkjn0> I'm assuming that if the fee was lower than minrelaytxfee we'd return an error instead of a txid..
401 2018-03-28T20:08:12  *** dafunkiz_ has joined #bitcoin-core-dev
402 2018-03-28T20:10:57  <jnewbery> hkjn0: #bitcoin please. This channel is for bitcoin core development
403 2018-03-28T20:16:04  *** nitramiz has joined #bitcoin-core-dev
404 2018-03-28T20:18:22  *** dafunkiz_ has quit IRC
405 2018-03-28T20:20:25  *** Cheeseo has joined #bitcoin-core-dev
406 2018-03-28T20:24:07  *** Victorsueca has quit IRC
407 2018-03-28T20:25:06  *** dafunkiz_ has joined #bitcoin-core-dev
408 2018-03-28T20:25:33  *** Victorsueca has joined #bitcoin-core-dev
409 2018-03-28T20:30:21  *** Chris_Stewart_5 has quit IRC
410 2018-03-28T20:30:33  *** MarcoFalke_trave has quit IRC
411 2018-03-28T20:32:49  *** drexl has joined #bitcoin-core-dev
412 2018-03-28T20:34:44  *** meshcollider has joined #bitcoin-core-dev
413 2018-03-28T20:34:45  *** Krellan has joined #bitcoin-core-dev
414 2018-03-28T20:35:16  *** StopAndDecrypt_ has joined #bitcoin-core-dev
415 2018-03-28T20:35:24  *** StopAndDecrypt has quit IRC
416 2018-03-28T20:41:02  *** d9b4bef9 has quit IRC
417 2018-03-28T20:41:22  <hkjn0> yup, sorry, realized after writing it was off-topic
418 2018-03-28T20:42:08  *** d9b4bef9 has joined #bitcoin-core-dev
419 2018-03-28T20:49:34  *** suldev has joined #bitcoin-core-dev
420 2018-03-28T20:52:25  *** Strepsils has joined #bitcoin-core-dev
421 2018-03-28T20:55:11  *** cheese_ has joined #bitcoin-core-dev
422 2018-03-28T20:57:33  *** Cheeseo has quit IRC
423 2018-03-28T21:03:43  *** dafunkiz_ has quit IRC
424 2018-03-28T21:06:49  *** dafunkiz_ has joined #bitcoin-core-dev
425 2018-03-28T21:10:22  *** Guyver2 has quit IRC
426 2018-03-28T21:15:41  *** moneyball has quit IRC
427 2018-03-28T21:16:31  *** Randolf has joined #bitcoin-core-dev
428 2018-03-28T21:21:01  *** dafunkiz_ has quit IRC
429 2018-03-28T21:22:43  *** Murch has quit IRC
430 2018-03-28T21:23:11  *** Murch has joined #bitcoin-core-dev
431 2018-03-28T21:27:49  *** dafunkiz_ has joined #bitcoin-core-dev
432 2018-03-28T21:36:08  *** jb55 has joined #bitcoin-core-dev
433 2018-03-28T21:38:47  *** suldev has quit IRC
434 2018-03-28T21:44:20  *** Randolf has quit IRC
435 2018-03-28T21:49:23  *** Strepsils has quit IRC
436 2018-03-28T21:49:28  *** ProfMac is now known as ProfMac_
437 2018-03-28T21:52:33  *** jb55 has quit IRC
438 2018-03-28T21:55:05  *** Victorsueca has quit IRC
439 2018-03-28T21:56:25  *** arbitrary_guy has joined #bitcoin-core-dev
440 2018-03-28T21:56:32  *** Victorsueca has joined #bitcoin-core-dev
441 2018-03-28T22:00:49  *** laurentmt has joined #bitcoin-core-dev
442 2018-03-28T22:01:23  *** Cogito_Ergo_Sum has quit IRC
443 2018-03-28T22:02:19  *** dafunkiz_ has quit IRC
444 2018-03-28T22:06:00  *** dafunkiz_ has joined #bitcoin-core-dev
445 2018-03-28T22:11:13  *** AaronvanW has joined #bitcoin-core-dev
446 2018-03-28T22:20:44  *** jcorgan has quit IRC
447 2018-03-28T22:22:32  *** TD--Linux is now known as TD-Linux
448 2018-03-28T22:22:33  *** TD-Linux has joined #bitcoin-core-dev
449 2018-03-28T22:26:51  *** dermoth has quit IRC
450 2018-03-28T22:28:55  *** dermoth has joined #bitcoin-core-dev
451 2018-03-28T22:31:27  *** laurentmt has quit IRC
452 2018-03-28T22:38:27  *** marcinja has joined #bitcoin-core-dev
453 2018-03-28T22:41:06  *** marcinja has quit IRC
454 2018-03-28T22:44:16  *** Randolf has joined #bitcoin-core-dev
455 2018-03-28T22:49:49  *** tyrick has quit IRC
456 2018-03-28T23:09:07  *** ProfMac_ is now known as ProfMac
457 2018-03-28T23:28:05  *** dafunkiz_ has quit IRC
458 2018-03-28T23:28:29  *** lnostdal has quit IRC
459 2018-03-28T23:30:03  *** drexl has quit IRC
460 2018-03-28T23:30:10  *** dafunkiz_ has joined #bitcoin-core-dev
461 2018-03-28T23:35:12  *** Tennis has quit IRC
462 2018-03-28T23:39:07  *** dafunkiz_ has quit IRC