1 2018-05-02T00:03:40 *** justanotheruser has joined #bitcoin-core-dev
2 2018-05-02T00:09:08 *** Ylbam has quit IRC
3 2018-05-02T00:11:03 *** AaronvanW has quit IRC
4 2018-05-02T00:29:08 *** Randolf has joined #bitcoin-core-dev
5 2018-05-02T00:31:02 *** d9b4bef9 has quit IRC
6 2018-05-02T00:32:08 *** d9b4bef9 has joined #bitcoin-core-dev
7 2018-05-02T00:35:57 *** zivl has quit IRC
8 2018-05-02T00:45:09 *** Krellan has quit IRC
9 2018-05-02T00:46:34 *** Randolf has quit IRC
10 2018-05-02T00:52:53 *** Randolf has joined #bitcoin-core-dev
11 2018-05-02T00:54:06 *** ctrlbreak has quit IRC
12 2018-05-02T00:54:29 *** ctrlbreak has joined #bitcoin-core-dev
13 2018-05-02T01:05:16 *** moneyball has joined #bitcoin-core-dev
14 2018-05-02T01:07:05 *** Randolf has quit IRC
15 2018-05-02T01:08:10 <wumpus> luke-jr: yes, agree we should fix that at the same time
16 2018-05-02T01:12:56 <wumpus> e.g. moving the assets attribution exclusively to debian seems to have been a bad idea
17 2018-05-02T01:16:30 *** Chris_Stewart_5 has joined #bitcoin-core-dev
18 2018-05-02T01:24:21 *** arowser has quit IRC
19 2018-05-02T01:24:47 *** arowser has joined #bitcoin-core-dev
20 2018-05-02T01:27:39 <bitcoin-git> [bitcoin] winder opened pull request #13145: Use common getPath method to create temp directory in tests. (master...master) https://github.com/bitcoin/bitcoin/pull/13145
21 2018-05-02T01:29:09 *** Chris_Stewart_5 has quit IRC
22 2018-05-02T01:30:49 *** arowser has quit IRC
23 2018-05-02T01:31:14 *** arowser has joined #bitcoin-core-dev
24 2018-05-02T01:35:08 *** arowser has quit IRC
25 2018-05-02T01:35:27 *** arowser has joined #bitcoin-core-dev
26 2018-05-02T01:35:39 *** fanquake has joined #bitcoin-core-dev
27 2018-05-02T01:39:03 <fanquake> Even though I know that splitting up the massive bitcoin/bitcoin repo is going to be better in the long term. Sometimes I feel like I'm losing a handle on everything that gets split out. Especially what's in the bitcoin-core/docs repo. Haven't reviewed any of the recent gitian build guide changes.
28 2018-05-02T01:39:23 <fanquake> wumpus #13141 is trivial and mergeable.
29 2018-05-02T01:39:25 <gribble> https://github.com/bitcoin/bitcoin/issues/13141 | [doc] qt: fixes broken link on readme by marcoagner · Pull Request #13141 · bitcoin/bitcoin · GitHub
30 2018-05-02T01:40:29 <wumpus> fanquake: it takes some getting used to, that's sure
31 2018-05-02T01:41:00 <wumpus> but it seems a good way to delegate, to avoid everything having to go through one small bottleneck
32 2018-05-02T01:41:31 <wumpus> fanquake: will take a look
33 2018-05-02T01:44:24 *** arowser has quit IRC
34 2018-05-02T01:44:49 *** arowser has joined #bitcoin-core-dev
35 2018-05-02T01:46:44 *** arowser has quit IRC
36 2018-05-02T01:47:08 *** arowser has joined #bitcoin-core-dev
37 2018-05-02T01:52:03 *** arowser has quit IRC
38 2018-05-02T01:52:38 *** arowser has joined #bitcoin-core-dev
39 2018-05-02T01:54:32 *** arowser has quit IRC
40 2018-05-02T01:54:53 *** arowser has joined #bitcoin-core-dev
41 2018-05-02T01:56:48 *** arowser has quit IRC
42 2018-05-02T01:56:50 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/baf6b4e3f956...57c57df86f14
43 2018-05-02T01:56:50 <bitcoin-git> bitcoin/master 12ad33a marcoagner: [doc] qt: fixes broken link on readme
44 2018-05-02T01:56:51 <bitcoin-git> bitcoin/master 57c57df Wladimir J. van der Laan: Merge #13141: [doc] qt: fixes broken link on readme...
45 2018-05-02T01:57:06 *** arowser has joined #bitcoin-core-dev
46 2018-05-02T01:57:49 <bitcoin-git> [bitcoin] laanwj closed pull request #13141: [doc] qt: fixes broken link on readme (master...fix_qt_readme_typo) https://github.com/bitcoin/bitcoin/pull/13141
47 2018-05-02T01:59:35 *** grafcaps has joined #bitcoin-core-dev
48 2018-05-02T02:01:22 *** moneyball has quit IRC
49 2018-05-02T02:01:39 <wumpus> fanquake: though not sure nightmerging is a good idea
50 2018-05-02T02:02:21 <fanquake> wumpus nightmerging?
51 2018-05-02T02:02:26 <wumpus> yes, it's night here
52 2018-05-02T02:02:40 <wumpus> I'm basically still sleeping :p
53 2018-05-02T02:04:26 <fanquake> wumpus hehe. I'm sure you merge enough you can do it in your sleep anyways..
54 2018-05-02T02:04:53 *** moneyball has joined #bitcoin-core-dev
55 2018-05-02T02:12:57 <wumpus> fanquake: that's true
56 2018-05-02T02:21:22 <wumpus> do we really have a problem with #'s in rpc passwords?
57 2018-05-02T02:24:20 *** meshcollider has quit IRC
58 2018-05-02T02:26:09 *** zivl has joined #bitcoin-core-dev
59 2018-05-02T02:38:24 *** isis_ is now known as isis
60 2018-05-02T02:40:52 <wumpus> bleh https://github.com/bitcoin/bitcoin/issues/13143#issuecomment-385848492
61 2018-05-02T02:44:54 <wumpus> I understand that it is convient to use # for defining comments, but did they really have to make it impossible to specify it in program_options? or am I missing something
62 2018-05-02T02:45:38 <fanquake> wumpus yes also reproduced that
63 2018-05-02T02:45:55 * sipa votes: removing program_options
64 2018-05-02T02:46:01 <wumpus> well we're going to replace boost program_options so I guess we can think of a way
65 2018-05-02T02:46:05 *** dcousens has quit IRC
66 2018-05-02T02:46:10 <luke-jr> we are?
67 2018-05-02T02:46:19 <wumpus> there's a PR for that...
68 2018-05-02T02:46:27 <sipa> https://github.com/bitcoin/bitcoin/pull/12744
69 2018-05-02T02:46:27 <fanquake> I'm guessing that the rpcauth.py will never generate any strings containing a "#"
70 2018-05-02T02:46:35 *** dcousens has joined #bitcoin-core-dev
71 2018-05-02T02:46:39 <luke-jr> as for comments, requiring a space prior to # (or start-of-line) would seem logical
72 2018-05-02T02:46:55 <wumpus> fanquake: correct - they'd have to adapt rpcauth.py to be able to provide a custom password
73 2018-05-02T02:46:55 <sipa> and even less intuitive
74 2018-05-02T02:47:37 <wumpus> fanquake: which is trivial, might do it...
75 2018-05-02T02:48:36 <luke-jr> using dependencies is strictly better than re-inventing them, but all things considered, I guess this case looks not totally unreasonble :x
76 2018-05-02T02:49:50 <wumpus> we have decided long time ago to slowly move away from boost - and there's no std:: equivalent for program_options
77 2018-05-02T02:51:25 <luke-jr> only in libconsensus..
78 2018-05-02T02:51:56 <sipa> in libconsensus we already did
79 2018-05-02T02:52:28 <wumpus> no, not only in libconsensus
80 2018-05-02T02:52:52 <wumpus> there's even a project open for it https://github.com/bitcoin/bitcoin/projects/3
81 2018-05-02T02:53:16 <luke-jr> I understood it to be using C++ where it has superceded boost
82 2018-05-02T02:53:18 <luke-jr> C++11*
83 2018-05-02T02:53:21 *** moneyball has quit IRC
84 2018-05-02T02:55:19 <luke-jr> not some kind of NIH "let's add to the workload by maintaining re-implementations of things others have already done"
85 2018-05-02T02:56:10 <luke-jr> anyway, not worth arguing over until someone proposes reimplementing Qt i guess
86 2018-05-02T02:56:16 <sipa> haha
87 2018-05-02T02:56:20 <wumpus> are you just arguing for arguing's sake now? I'm tired
88 2018-05-02T02:56:39 <wumpus> right
89 2018-05-02T02:59:20 <wumpus> qt is pretty ok as a GUI dependency, as these things go, at least it's not a cursed thing like electron
90 2018-05-02T02:59:53 <luke-jr> I was not seriously suggesting we discuss reimplementing Qt ;)
91 2018-05-02T03:00:26 <fanquake> I assumed we'd be moving to Electron shortly so that we could re-implement everything using WebAssembly ?
92 2018-05-02T03:01:05 <sipa> excellent idea.
93 2018-05-02T03:01:06 <wumpus> luke-jr: oh I thought we were going to move to SDL2, OpenGL and imgui, and do release on steam...
94 2018-05-02T03:01:15 <sipa> wahaha
95 2018-05-02T03:01:18 * luke-jr panics
96 2018-05-02T03:01:45 <sipa> i thought bitcoin core was going to become a minecraft plugin?
97 2018-05-02T03:02:39 <wumpus> even better, blocks in 3d
98 2018-05-02T03:03:02 <luke-jr> fun fact: I only began using the GUI when wumpus wrote Bitcoin-Qt ;)
99 2018-05-02T03:03:26 <fanquake> wumpus Probably want to benchmark point and click mining first
100 2018-05-02T03:04:19 <wumpus> luke-jr: same here, the old gui was terrible and needed some special pre-release of wxwidgets with unicode support to compile at all
101 2018-05-02T03:05:10 <wumpus> fanquake: but minecraft already has mining functionality, that's the genius, just have to put a chain between the blocks
102 2018-05-02T03:06:12 <fanquake> :o
103 2018-05-02T03:06:34 *** tryphe has quit IRC
104 2018-05-02T03:08:07 *** tryphe has joined #bitcoin-core-dev
105 2018-05-02T03:09:55 *** tralfaz has quit IRC
106 2018-05-02T03:11:17 <sipa> wumpus: i wonder if that wx unicode ever got actually released
107 2018-05-02T03:11:34 <bitcoin-git> [bitcoin] laanwj opened pull request #13146: rpcauth: Make it possible to provide a custom password (master...2018_05_rpcauth_custom_password) https://github.com/bitcoin/bitcoin/pull/13146
108 2018-05-02T03:12:28 *** liangliang has joined #bitcoin-core-dev
109 2018-05-02T03:14:18 <sipa> wumpus: november 2013
110 2018-05-02T03:14:32 <wumpus> sipa: I'm surprised
111 2018-05-02T03:14:59 *** justan0theruser has joined #bitcoin-core-dev
112 2018-05-02T03:15:15 <sipa> only 2 years after we switched to Qt :D
113 2018-05-02T03:15:54 *** justanotheruser has quit IRC
114 2018-05-02T03:16:27 *** meshcollider has joined #bitcoin-core-dev
115 2018-05-02T03:17:18 <wumpus> yep and that's the release, I'd imagine it'd take much longer to be taken up by linux distributions
116 2018-05-02T03:19:56 <sipa> trusty had it :)
117 2018-05-02T03:20:35 <wumpus> :-)
118 2018-05-02T03:26:11 *** liangliang has quit IRC
119 2018-05-02T03:28:51 *** grafcaps has quit IRC
120 2018-05-02T03:38:57 *** justan0theruser has quit IRC
121 2018-05-02T03:40:24 *** justanotheruser has joined #bitcoin-core-dev
122 2018-05-02T03:57:28 *** Randolf has joined #bitcoin-core-dev
123 2018-05-02T04:00:26 *** grafcaps has joined #bitcoin-core-dev
124 2018-05-02T04:04:28 *** GoldenBear has quit IRC
125 2018-05-02T04:04:54 *** ryanofsky has quit IRC
126 2018-05-02T04:07:19 <sipa> holy crap we have a lot of circular dependencies
127 2018-05-02T04:07:51 <sipa> https://zerobin.net/?26d4014573bf3d3b#Ckub5Tt1vtjJEVObubSjbs/LMPwCiy2KWiXHmdAAGYI=
128 2018-05-02T04:11:07 <gmaxwell> It's almost as if it were a program and not a utility toolkit. :P
129 2018-05-02T04:13:54 *** sipa has left #bitcoin-core-dev
130 2018-05-02T04:15:09 *** cysm has quit IRC
131 2018-05-02T04:37:54 <wumpus> do we at least have a handle on circular dependencies between .a files now?
132 2018-05-02T04:38:42 <wumpus> close, I guess #7965
133 2018-05-02T04:38:43 <gribble> https://github.com/bitcoin/bitcoin/issues/7965 | Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` · Issue #7965 · bitcoin/bitcoin · GitHub
134 2018-05-02T04:40:28 <wumpus> jnewbery: I suppose we can check off 'wallet initialization/verify/shutdown' as well there after #10762?
135 2018-05-02T04:40:32 <gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
136 2018-05-02T04:44:54 <wumpus> sipa: how does that script work, does it look at the includes only or at the symbols?
137 2018-05-02T04:46:50 *** cryptojanitor has quit IRC
138 2018-05-02T04:48:50 <wumpus> oh he left :/
139 2018-05-02T04:49:07 *** btc has joined #bitcoin-core-dev
140 2018-05-02T04:49:09 <btc> s
141 2018-05-02T04:49:17 <btc> aa
142 2018-05-02T04:49:37 <btc> hello?
143 2018-05-02T04:50:03 <btc> is anybody there
144 2018-05-02T04:50:24 *** btc has quit IRC
145 2018-05-02T04:53:41 *** sipa has joined #bitcoin-core-dev
146 2018-05-02T05:17:57 *** DrFeelGood has quit IRC
147 2018-05-02T05:24:37 *** Krellan has joined #bitcoin-core-dev
148 2018-05-02T05:24:47 *** meshcollider has quit IRC
149 2018-05-02T05:24:58 *** Krellan has quit IRC
150 2018-05-02T05:25:06 *** Krellan has joined #bitcoin-core-dev
151 2018-05-02T05:27:59 *** Krellan has quit IRC
152 2018-05-02T05:40:14 *** lnostdal has quit IRC
153 2018-05-02T05:46:33 *** lnostdal has joined #bitcoin-core-dev
154 2018-05-02T06:04:07 *** moneyball has joined #bitcoin-core-dev
155 2018-05-02T06:10:32 *** windsok has quit IRC
156 2018-05-02T06:12:47 *** windsok has joined #bitcoin-core-dev
157 2018-05-02T06:12:47 *** windsok has joined #bitcoin-core-dev
158 2018-05-02T06:14:45 *** jtimon has quit IRC
159 2018-05-02T06:18:52 *** tralfaz has joined #bitcoin-core-dev
160 2018-05-02T06:21:14 *** meshcollider has joined #bitcoin-core-dev
161 2018-05-02T06:22:03 *** Emcy has joined #bitcoin-core-dev
162 2018-05-02T06:43:41 *** laurentmt has joined #bitcoin-core-dev
163 2018-05-02T06:45:35 *** laurentmt has quit IRC
164 2018-05-02T07:06:14 *** moneyball has quit IRC
165 2018-05-02T07:18:58 *** jpe has joined #bitcoin-core-dev
166 2018-05-02T07:38:00 *** arowser has quit IRC
167 2018-05-02T07:38:19 *** arowser has joined #bitcoin-core-dev
168 2018-05-02T07:39:01 *** shesek has quit IRC
169 2018-05-02T07:42:34 *** SopaXorzTaker has joined #bitcoin-core-dev
170 2018-05-02T07:51:58 *** shesek has joined #bitcoin-core-dev
171 2018-05-02T08:04:28 *** mistergold has joined #bitcoin-core-dev
172 2018-05-02T08:08:44 *** setpill has joined #bitcoin-core-dev
173 2018-05-02T08:18:32 *** ajtowns[m] has quit IRC
174 2018-05-02T08:18:32 *** squarfed[m] has quit IRC
175 2018-05-02T08:19:22 *** joshb[m] has quit IRC
176 2018-05-02T08:23:06 *** squarfed[m] has joined #bitcoin-core-dev
177 2018-05-02T08:24:28 *** joshb[m] has joined #bitcoin-core-dev
178 2018-05-02T08:24:36 *** ajtowns[m] has joined #bitcoin-core-dev
179 2018-05-02T08:31:06 *** larafale has joined #bitcoin-core-dev
180 2018-05-02T08:32:44 *** promag has joined #bitcoin-core-dev
181 2018-05-02T08:45:57 <bitcoin-git> [bitcoin] practicalswift opened pull request #13148: logging: Fix potential use-after-free in LogPrintStr(...) (master...logprintstr-uaf) https://github.com/bitcoin/bitcoin/pull/13148
182 2018-05-02T08:49:39 *** timothy has joined #bitcoin-core-dev
183 2018-05-02T09:04:40 *** timothy has quit IRC
184 2018-05-02T09:38:06 *** rafalcpp has joined #bitcoin-core-dev
185 2018-05-02T09:59:31 *** vicenteH has joined #bitcoin-core-dev
186 2018-05-02T10:10:49 *** Victorsueca has quit IRC
187 2018-05-02T10:12:00 *** Victorsueca has joined #bitcoin-core-dev
188 2018-05-02T10:15:50 <bitcoin-git> [bitcoin] practicalswift opened pull request #13149: Handle unsuccessful fseek(...):s (master...fseek) https://github.com/bitcoin/bitcoin/pull/13149
189 2018-05-02T10:16:03 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57c57df86f14...0bc980b1f65f
190 2018-05-02T10:16:04 <bitcoin-git> bitcoin/master 2a89b0c Wladimir J. van der Laan: rpcauth: Make it possible to provide a custom password...
191 2018-05-02T10:16:04 <bitcoin-git> bitcoin/master 0bc980b Wladimir J. van der Laan: Merge #13146: rpcauth: Make it possible to provide a custom password...
192 2018-05-02T10:16:54 <bitcoin-git> [bitcoin] laanwj closed pull request #13146: rpcauth: Make it possible to provide a custom password (master...2018_05_rpcauth_custom_password) https://github.com/bitcoin/bitcoin/pull/13146
193 2018-05-02T10:17:09 *** mistergold has quit IRC
194 2018-05-02T10:17:53 *** mistergold has joined #bitcoin-core-dev
195 2018-05-02T10:18:31 *** belcher has joined #bitcoin-core-dev
196 2018-05-02T10:29:57 *** fanquake has quit IRC
197 2018-05-02T10:38:28 *** timothy has joined #bitcoin-core-dev
198 2018-05-02T10:39:04 *** cryptojanitor has joined #bitcoin-core-dev
199 2018-05-02T10:42:35 *** timothy has quit IRC
200 2018-05-02T10:43:33 *** timothy has joined #bitcoin-core-dev
201 2018-05-02T10:44:38 *** Guyver2 has joined #bitcoin-core-dev
202 2018-05-02T10:45:47 *** AaronvanW has joined #bitcoin-core-dev
203 2018-05-02T10:48:01 *** timothy has quit IRC
204 2018-05-02T10:48:01 *** drizztbsd has joined #bitcoin-core-dev
205 2018-05-02T10:55:41 *** fanquake has joined #bitcoin-core-dev
206 2018-05-02T10:59:57 *** fanquake has quit IRC
207 2018-05-02T11:00:31 <promag> I would like to know if #13034 is something we want, or if I should remove that from other PR's related to dynamic wallets
208 2018-05-02T11:00:34 <gribble> https://github.com/bitcoin/bitcoin/issues/13034 | Introduce WalletManager by promag · Pull Request #13034 · bitcoin/bitcoin · GitHub
209 2018-05-02T11:00:45 <promag> so please ACK/NACK there
210 2018-05-02T11:12:34 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0bc980b1f65f...598db389c33e
211 2018-05-02T11:12:35 <bitcoin-git> bitcoin/master 50b6533 Matt Corallo: scripted-diff: Rename SetBestChain callback ChainStateFlushed...
212 2018-05-02T11:12:35 <bitcoin-git> bitcoin/master 9cb6cdc Matt Corallo: Simplify semantics of ChainStateFlushed callback...
213 2018-05-02T11:12:36 <bitcoin-git> bitcoin/master 598db38 Wladimir J. van der Laan: Merge #13106: Simplify semantics of ChainStateFlushed callback...
214 2018-05-02T11:12:52 *** votefrac has joined #bitcoin-core-dev
215 2018-05-02T11:13:18 <bitcoin-git> [bitcoin] laanwj closed pull request #13106: Simplify semantics of ChainStateFlushed callback (master...2018-04-wallet-flush-better-criteria) https://github.com/bitcoin/bitcoin/pull/13106
216 2018-05-02T11:15:29 *** shesek has quit IRC
217 2018-05-02T11:17:50 *** fanquake has joined #bitcoin-core-dev
218 2018-05-02T11:17:53 *** lnostdal has quit IRC
219 2018-05-02T11:21:31 *** lnostdal has joined #bitcoin-core-dev
220 2018-05-02T11:24:47 *** meshcollider has quit IRC
221 2018-05-02T11:30:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
222 2018-05-02T11:38:23 *** votefrac has quit IRC
223 2018-05-02T11:42:02 *** d9b4bef9 has quit IRC
224 2018-05-02T11:43:07 *** d9b4bef9 has joined #bitcoin-core-dev
225 2018-05-02T11:58:21 *** fanquake has quit IRC
226 2018-05-02T12:03:21 *** Chris_Stewart_5 has quit IRC
227 2018-05-02T12:07:13 *** gwillen has quit IRC
228 2018-05-02T12:13:35 *** promag has quit IRC
229 2018-05-02T12:17:40 <bitcoin-git> [bitcoin] laanwj opened pull request #13151: WIP: net: Serve blocks directly from disk when possible (master...2018_05_direct_from_disk) https://github.com/bitcoin/bitcoin/pull/13151
230 2018-05-02T12:27:30 *** jtimon has joined #bitcoin-core-dev
231 2018-05-02T12:34:58 *** AaronvanW has quit IRC
232 2018-05-02T12:35:38 *** AaronvanW has joined #bitcoin-core-dev
233 2018-05-02T12:39:08 *** Guyver2_ has joined #bitcoin-core-dev
234 2018-05-02T12:39:26 *** Guyver2_ has joined #bitcoin-core-dev
235 2018-05-02T12:41:44 *** Guyver2 has quit IRC
236 2018-05-02T12:41:50 *** Guyver2_ is now known as Guyver2
237 2018-05-02T12:43:51 <bitcoin-git> [bitcoin] chris-belcher opened pull request #13152: [WIP] [rpc] Add getaddress RPC command (master...2018-04-rpc-getaddress) https://github.com/bitcoin/bitcoin/pull/13152
238 2018-05-02T12:44:40 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
239 2018-05-02T12:44:40 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
240 2018-05-02T12:46:40 *** fuss has joined #bitcoin-core-dev
241 2018-05-02T12:48:37 *** cryptojanitor has quit IRC
242 2018-05-02T12:50:37 *** adiabat has quit IRC
243 2018-05-02T12:51:15 *** adiabat has joined #bitcoin-core-dev
244 2018-05-02T12:52:31 <bitcoin-git> [bitcoin] laanwj opened pull request #13153: net: Add missing newlines to debug logging (master...2018_05_log_newlines) https://github.com/bitcoin/bitcoin/pull/13153
245 2018-05-02T12:53:43 *** fuss has quit IRC
246 2018-05-02T12:53:55 *** fanquake has joined #bitcoin-core-dev
247 2018-05-02T12:54:03 <fanquake> wumpus new linter inbound..
248 2018-05-02T12:54:40 <wumpus> fanquake: there is a linter for that, but somehow it didn't catch these!
249 2018-05-02T12:56:13 <fanquake> indeed, didn't realise we were checking that https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/lint-logs.sh
250 2018-05-02T12:56:49 <fanquake> Also, any suggestions for testing #13151 performance improvements?
251 2018-05-02T12:56:51 <gribble> https://github.com/bitcoin/bitcoin/issues/13151 | WIP: net: Serve blocks directly from disk when possible by laanwj · Pull Request #13151 · bitcoin/bitcoin · GitHub
252 2018-05-02T12:58:40 <wumpus> ideally we'd have some tool or script that simply pulls blocks through P2P
253 2018-05-02T12:58:56 <wumpus> just to measure raw download throughput
254 2018-05-02T12:59:17 <wumpus> I vaguely remember someone mentioning this but I'm not sure where or who
255 2018-05-02T13:00:34 *** intcat has quit IRC
256 2018-05-02T13:01:02 *** ghost43 has quit IRC
257 2018-05-02T13:01:32 <wumpus> I mean you could try to benchmark by making a node sync from another node locally, but verification at the client side would distort the results
258 2018-05-02T13:02:29 *** promag has joined #bitcoin-core-dev
259 2018-05-02T13:06:18 *** intcat has joined #bitcoin-core-dev
260 2018-05-02T13:06:28 *** ghost43 has joined #bitcoin-core-dev
261 2018-05-02T13:17:55 *** huh has joined #bitcoin-core-dev
262 2018-05-02T13:29:27 *** Giszmo has quit IRC
263 2018-05-02T13:29:55 <jonasschnelli> hmmm... LMDB seems to consume ~274 bytes for a txindex entry (32byte hash txid, 32byte blockhash). I wonder where to overhead comes from.
264 2018-05-02T13:32:14 *** arowser has quit IRC
265 2018-05-02T13:32:33 *** arowser has joined #bitcoin-core-dev
266 2018-05-02T13:34:44 *** huh has quit IRC
267 2018-05-02T13:41:48 *** ryanofsky has joined #bitcoin-core-dev
268 2018-05-02T13:44:27 <promag> CBlockIndex::nStatus is protected by cs_main?
269 2018-05-02T13:49:40 *** Giszmo has joined #bitcoin-core-dev
270 2018-05-02T13:53:05 <jonasschnelli> promag: Yeah. Seams like. Its definitively mutable.
271 2018-05-02T13:53:22 <promag> ty
272 2018-05-02T13:54:12 *** Giszmo has quit IRC
273 2018-05-02T13:57:32 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/598db389c33e...ef46c9904b80
274 2018-05-02T13:57:33 <bitcoin-git> bitcoin/master ff2ad2d Wladimir J. van der Laan: Add missing newlines to LogPrint debug logging...
275 2018-05-02T13:57:33 <bitcoin-git> bitcoin/master 4b75dcf MarcoFalke: devtools: Make linter check LogPrint calls
276 2018-05-02T13:57:34 <bitcoin-git> bitcoin/master ef46c99 Wladimir J. van der Laan: Merge #13153: Add missing newlines to debug logging...
277 2018-05-02T13:58:27 <bitcoin-git> [bitcoin] laanwj closed pull request #13153: Add missing newlines to debug logging (master...2018_05_log_newlines) https://github.com/bitcoin/bitcoin/pull/13153
278 2018-05-02T13:58:47 *** AaronvanW has quit IRC
279 2018-05-02T14:00:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
280 2018-05-02T14:05:12 *** rafalcpp has quit IRC
281 2018-05-02T14:07:53 *** rafalcpp has joined #bitcoin-core-dev
282 2018-05-02T14:08:10 *** grafcaps has quit IRC
283 2018-05-02T14:08:57 *** Giszmo has joined #bitcoin-core-dev
284 2018-05-02T14:09:22 <bitcoin-git> [bitcoin] ryanofsky opened pull request #13154: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 (master...pr/flushed) https://github.com/bitcoin/bitcoin/pull/13154
285 2018-05-02T14:16:20 <fanquake> Do you get spammed with emails/notifications if your @ mentioned in a commit body, same as what was happening in PRs?
286 2018-05-02T14:19:18 <ryanofsky> what's the difference between https://github.com/bitcoin and https://github.com/bitcoin-core?
287 2018-05-02T14:22:39 <fanquake> ryanofsky In what regard?
288 2018-05-02T14:22:54 *** grafcaps has joined #bitcoin-core-dev
289 2018-05-02T14:24:07 <fanquake> /bitcoin was where bitcoin was migrated to from SF. /bitcoin-core houses some core specific repos such as the website, docs etc
290 2018-05-02T14:25:05 <wumpus> right - bitcoin is the legacy organization, bitcoin-core is where most of the repositories have been moved
291 2018-05-02T14:26:12 <ryanofsky> oh ok, so it's just a legacy thing. i didn't know if they two orgs were supposed to have different purposes, or were run by different people or something
292 2018-05-02T14:26:17 <wumpus> it was originally the plan to move the bitcoin repository too, however since the 'bitcoin core' as currency name bullshit from BCHers, that's probably a bad idea and will only contribute towards user confusion
293 2018-05-02T14:26:44 *** Giszmo has quit IRC
294 2018-05-02T14:26:50 <BlueMatt> well except bips, which will probably always stay in bitcoin
295 2018-05-02T14:27:14 <wumpus> yes, or a 'bips' organization
296 2018-05-02T14:28:36 <fanquake> The crossover between the "teams" in the two orgs is pretty high. Probably just a few more inactive/older users in /bitcoin
297 2018-05-02T14:29:24 *** kexkey has joined #bitcoin-core-dev
298 2018-05-02T14:33:13 *** fanquake has quit IRC
299 2018-05-02T14:37:27 <wumpus> yes, if you're in bitcoin but not in bitcoin-core or vice versa, let me know, invites are supposed to go out for both at the same time
300 2018-05-02T14:44:45 *** owowo has quit IRC
301 2018-05-02T14:47:21 *** mistergold has quit IRC
302 2018-05-02T14:47:32 *** Giszmo has joined #bitcoin-core-dev
303 2018-05-02T14:50:51 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef46c9904b80...ef006d92845a
304 2018-05-02T14:50:52 <bitcoin-git> bitcoin/master 73bc1b7 practicalswift: Initialize editStatus and autoCompleter. Previously not initialized where defined or in constructor.
305 2018-05-02T14:50:52 <bitcoin-git> bitcoin/master f131872 practicalswift: Initialize non-static class members where they are defined
306 2018-05-02T14:50:53 <bitcoin-git> bitcoin/master 1e7813e practicalswift: Remove redundant initializations from the constructor
307 2018-05-02T14:51:33 *** owowo has joined #bitcoin-core-dev
308 2018-05-02T14:51:37 <bitcoin-git> [bitcoin] laanwj closed pull request #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor (master...qt-constructors) https://github.com/bitcoin/bitcoin/pull/12928
309 2018-05-02T14:56:28 <rafalcpp> hm is this expected that v0.16.0 crashes on start with built with --with-incompatible-bdb ? this issues are closed #6775 (and #12047). System always had libdb5.3 never had libdb4.x (Debian testing 10 from installation)
310 2018-05-02T14:56:29 <gribble> https://github.com/bitcoin/bitcoin/issues/6775 | Bitcoind v0.11.0 segfaults on startup trying to read wallet. · Issue #6775 · bitcoin/bitcoin · GitHub
311 2018-05-02T14:56:30 <gribble> https://github.com/bitcoin/bitcoin/issues/12047 | Segmentation fault if configured with incompatible BDB · Issue #12047 · bitcoin/bitcoin · GitHub
312 2018-05-02T15:04:59 <wumpus> rafalcpp: usually that means that you have multiple versions of berkeleydb installed, and it's compiling against a different one than it's dynamically linking at runtime
313 2018-05-02T15:05:52 <wumpus> but no, that's not normal, I've been compilng with --with-incompaible-bdb for years, and many others do
314 2018-05-02T15:09:31 *** promag has quit IRC
315 2018-05-02T15:11:39 <rafalcpp> wumpus: I seen that today on debian 10 and debian 9. so reopen?
316 2018-05-02T15:12:39 <wumpus> better to open a new issue, it's not clear this is the same problem
317 2018-05-02T15:13:46 <wumpus> if it's the same problem then reopening doesn't help - it was a local issue (ABI conflict)
318 2018-05-02T15:14:03 <wumpus> see e.g. https://github.com/bitcoin/bitcoin/issues/12047#issuecomment-357022687
319 2018-05-02T15:20:17 *** Giszmo has quit IRC
320 2018-05-02T15:35:56 *** Giszmo has joined #bitcoin-core-dev
321 2018-05-02T15:41:56 *** rafalcpp has quit IRC
322 2018-05-02T15:47:27 *** Randolf has quit IRC
323 2018-05-02T15:50:22 *** promag has joined #bitcoin-core-dev
324 2018-05-02T15:54:42 *** ExtraCrispy has joined #bitcoin-core-dev
325 2018-05-02T16:09:29 *** arowser has quit IRC
326 2018-05-02T16:09:45 *** arowser has joined #bitcoin-core-dev
327 2018-05-02T16:09:52 *** thelox95 has joined #bitcoin-core-dev
328 2018-05-02T16:10:59 *** thelox95 has quit IRC
329 2018-05-02T16:11:10 *** laurentmt has joined #bitcoin-core-dev
330 2018-05-02T16:11:28 *** thelox95 has joined #bitcoin-core-dev
331 2018-05-02T16:13:08 <thelox95> hi?
332 2018-05-02T16:14:21 *** laurentmt has quit IRC
333 2018-05-02T16:15:04 *** setpill has quit IRC
334 2018-05-02T16:16:41 *** arowser has quit IRC
335 2018-05-02T16:16:59 *** arowser has joined #bitcoin-core-dev
336 2018-05-02T16:22:22 *** kexkey has quit IRC
337 2018-05-02T16:26:06 *** thelox95 has quit IRC
338 2018-05-02T16:27:34 *** moneyball has joined #bitcoin-core-dev
339 2018-05-02T16:28:54 *** arowser has quit IRC
340 2018-05-02T16:29:11 *** arowser has joined #bitcoin-core-dev
341 2018-05-02T16:34:01 *** promag has quit IRC
342 2018-05-02T16:37:33 *** vicenteH has quit IRC
343 2018-05-02T16:37:41 *** vicenteH has joined #bitcoin-core-dev
344 2018-05-02T16:51:07 *** arowser has quit IRC
345 2018-05-02T16:51:24 *** arowser has joined #bitcoin-core-dev
346 2018-05-02T17:01:48 *** drizztbsd has quit IRC
347 2018-05-02T17:21:51 *** justanotheruser has quit IRC
348 2018-05-02T17:29:44 *** ExtraCrispy has quit IRC
349 2018-05-02T17:31:05 *** vicenteH has quit IRC
350 2018-05-02T17:34:01 *** brianhoffman has joined #bitcoin-core-dev
351 2018-05-02T17:35:19 *** arowser has quit IRC
352 2018-05-02T17:35:37 *** arowser has joined #bitcoin-core-dev
353 2018-05-02T17:37:33 *** arowser has quit IRC
354 2018-05-02T17:37:51 *** arowser has joined #bitcoin-core-dev
355 2018-05-02T17:39:45 *** arowser has quit IRC
356 2018-05-02T17:40:05 *** arowser has joined #bitcoin-core-dev
357 2018-05-02T17:57:03 *** Randolf has joined #bitcoin-core-dev
358 2018-05-02T18:01:53 *** gwillen has joined #bitcoin-core-dev
359 2018-05-02T18:02:43 *** timothy has joined #bitcoin-core-dev
360 2018-05-02T18:04:27 *** Randolf has quit IRC
361 2018-05-02T18:05:37 *** GoldenBear has joined #bitcoin-core-dev
362 2018-05-02T18:05:50 *** timothy has quit IRC
363 2018-05-02T18:11:00 *** Arokh has quit IRC
364 2018-05-02T18:11:21 *** Arokh has joined #bitcoin-core-dev
365 2018-05-02T18:23:01 *** d9b4bef9 has quit IRC
366 2018-05-02T18:23:25 <bitcoin-git> [bitcoin] practicalswift closed pull request #12665: Add compile time checking for run time locking assertions (master...compile-time-checking-of-runtime-assertions) https://github.com/bitcoin/bitcoin/pull/12665
367 2018-05-02T18:24:12 *** d9b4bef9 has joined #bitcoin-core-dev
368 2018-05-02T18:28:59 *** LeMiner has joined #bitcoin-core-dev
369 2018-05-02T18:46:10 <jamesob> are there any caveats we know of re: usage of std::mutex/std::lock_guard on windows? I'm seeing some weird unhandled page faults only on windows with pretty vanilla usage of these constructs
370 2018-05-02T18:57:49 <sipa> jamesob: care to create a minimal reproduction?
371 2018-05-02T18:58:19 <jamesob> sipa: yeah, I might have to go down that road
372 2018-05-02T19:03:10 *** SopaXorzTaker has quit IRC
373 2018-05-02T19:17:29 *** isis is now known as isis_
374 2018-05-02T19:28:59 *** LeMiner2 has joined #bitcoin-core-dev
375 2018-05-02T19:32:46 *** LeMiner has quit IRC
376 2018-05-02T19:32:46 *** LeMiner2 is now known as LeMiner
377 2018-05-02T19:42:23 *** moneyball has quit IRC
378 2018-05-02T19:52:30 *** promag has joined #bitcoin-core-dev
379 2018-05-02T19:55:35 *** cryptojanitor has joined #bitcoin-core-dev
380 2018-05-02T19:57:34 *** jimpo has quit IRC
381 2018-05-02T19:57:49 *** votefrac has joined #bitcoin-core-dev
382 2018-05-02T20:01:43 *** promag has quit IRC
383 2018-05-02T20:13:11 <jamesob> sipa: this is as concise as I've gotten it so far https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605
384 2018-05-02T20:13:20 *** votefrac has quit IRC
385 2018-05-02T20:15:32 <jamesob> updated with something simpler yet
386 2018-05-02T20:16:48 <jamesob> hm, seems to have to do with thread_local usage
387 2018-05-02T20:17:27 *** Victorsueca has quit IRC
388 2018-05-02T20:17:34 *** meshcollider has joined #bitcoin-core-dev
389 2018-05-02T20:18:40 *** Victorsueca has joined #bitcoin-core-dev
390 2018-05-02T20:24:23 <jamesob> either windows c++11 compiler is subtly busted or I don't understand c++; updated the gist with a patch that makes it work: https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605#file-works-cpp-L13
391 2018-05-02T20:27:35 *** drexl has joined #bitcoin-core-dev
392 2018-05-02T20:29:05 *** LeMiner2 has joined #bitcoin-core-dev
393 2018-05-02T20:32:46 *** LeMiner has quit IRC
394 2018-05-02T20:32:46 *** LeMiner2 is now known as LeMiner
395 2018-05-02T20:33:22 *** promag has joined #bitcoin-core-dev
396 2018-05-02T20:39:09 *** jimpo has joined #bitcoin-core-dev
397 2018-05-02T20:39:31 *** Chris_Stewart_5 has quit IRC
398 2018-05-02T20:44:16 *** go1111111 has joined #bitcoin-core-dev
399 2018-05-02T20:44:50 *** dbt001 has joined #bitcoin-core-dev
400 2018-05-02T20:53:55 *** dbt001 has quit IRC
401 2018-05-02T20:55:05 *** Giszmo has quit IRC
402 2018-05-02T21:13:28 *** Guyver2 has quit IRC
403 2018-05-02T21:14:16 *** DrFeelGood has joined #bitcoin-core-dev
404 2018-05-02T21:15:48 <booyah> jamesob: why this_id would need to be static? instead of simple std::string local variable?
405 2018-05-02T21:15:52 *** Giszmo has joined #bitcoin-core-dev
406 2018-05-02T21:20:43 *** AaronvanW has joined #bitcoin-core-dev
407 2018-05-02T21:22:48 <jamesob> booyah: in the real usecase, we're trying to establish a unique ID per thread on a one-time basis
408 2018-05-02T21:24:50 <sipa> jamesob: wouldn't surprise me if thread_local is broken in some mingw versions
409 2018-05-02T21:25:29 <jamesob> sipa: certainly appears so. I'm just gonna avoid using it altogether on WIN32
410 2018-05-02T21:26:24 <booyah> jamesob: would you report a bug to compiler devels?
411 2018-05-02T21:26:36 <jamesob> booyah: yeah probably
412 2018-05-02T21:27:31 <booyah> jamesob: ##c++ <Svitkona> both are working fine on msvc
413 2018-05-02T21:28:02 <jamesob> as sipa says, it may be a mingw32-specific thing
414 2018-05-02T21:29:18 *** LeMiner2 has joined #bitcoin-core-dev
415 2018-05-02T21:30:54 <booyah> jamesob: maybe this bug? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83562
416 2018-05-02T21:31:05 *** cryptapus has quit IRC
417 2018-05-02T21:32:25 *** cryptapus has joined #bitcoin-core-dev
418 2018-05-02T21:32:25 *** cryptapus has quit IRC
419 2018-05-02T21:32:25 *** cryptapus has joined #bitcoin-core-dev
420 2018-05-02T21:32:30 <jamesob> booyah: I can't repro that
421 2018-05-02T21:32:46 *** LeMiner has quit IRC
422 2018-05-02T21:32:46 *** LeMiner2 is now known as LeMiner
423 2018-05-02T21:44:35 <sipa> jamesob: wouldn't it be easier to just always use std::this_thread::get_id() ?
424 2018-05-02T21:44:41 *** AaronvanW has quit IRC
425 2018-05-02T21:45:09 <jamesob> sipa: I'd love to do that provided we can assume it's always compatible with boost threads
426 2018-05-02T21:45:12 *** AaronvanW has joined #bitcoin-core-dev
427 2018-05-02T21:45:45 <sipa> do we use boost threads anywhere?
428 2018-05-02T21:46:48 <sipa> seems we do.
429 2018-05-02T21:47:17 <jamesob> yeah, seems like it: https://github.com/bitcoin/bitcoin/blob/66fcbdcc4cbf5a99fad3ef6b4c953474c92af1be/src/init.cpp#L173
430 2018-05-02T21:48:30 <sipa> alternatively, i expect boost::this_thread::native_handle to always work
431 2018-05-02T21:49:53 <sipa> oh, that may not exist
432 2018-05-02T21:50:22 <jamesob> sipa: even if it did, wouldn't we have to have a bunch of platform-specific cases?
433 2018-05-02T21:50:50 *** Cogito_Ergo_Sum has quit IRC
434 2018-05-02T21:51:26 <sipa> if std::this_thread::get_id works everywhere, could we try that?
435 2018-05-02T21:52:28 *** dx25 has quit IRC
436 2018-05-02T21:53:01 <jamesob> sure thing
437 2018-05-02T21:53:20 <sipa> also, no need to convert to std::string; you can use std::thread::id as a map key
438 2018-05-02T21:53:49 <jamesob> willdo
439 2018-05-02T22:02:01 *** d9b4bef9 has quit IRC
440 2018-05-02T22:03:08 *** d9b4bef9 has joined #bitcoin-core-dev
441 2018-05-02T22:05:10 *** cryptojanitor has quit IRC
442 2018-05-02T22:11:42 *** Victorsueca has quit IRC
443 2018-05-02T22:12:55 *** Victorsueca has joined #bitcoin-core-dev
444 2018-05-02T22:21:58 *** LeMiner has quit IRC
445 2018-05-02T22:23:29 *** davec has quit IRC
446 2018-05-02T22:24:26 <promag> jnewbery: re #10740, should it be possible to specify an absolute path if it's in the walletdir?
447 2018-05-02T22:24:31 <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
448 2018-05-02T22:24:49 *** laurentmt has joined #bitcoin-core-dev
449 2018-05-02T22:25:11 *** laurentmt has quit IRC
450 2018-05-02T22:33:20 *** AaronvanW has quit IRC
451 2018-05-02T22:33:55 *** AaronvanW has joined #bitcoin-core-dev
452 2018-05-02T22:34:53 *** Emcy has quit IRC
453 2018-05-02T22:38:19 *** AaronvanW has quit IRC
454 2018-05-02T22:40:30 *** AaronvanW has joined #bitcoin-core-dev
455 2018-05-02T22:45:10 *** dx25 has joined #bitcoin-core-dev
456 2018-05-02T22:47:12 *** davec_ has joined #bitcoin-core-dev
457 2018-05-02T22:58:41 *** grafcaps has quit IRC
458 2018-05-02T23:09:47 *** moneyball has joined #bitcoin-core-dev
459 2018-05-02T23:12:35 *** drexl has quit IRC
460 2018-05-02T23:12:54 *** grafcaps has joined #bitcoin-core-dev
461 2018-05-02T23:13:31 <promag> BlueMatt: mind revisit #12151?
462 2018-05-02T23:13:34 <gribble> https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
463 2018-05-02T23:14:45 *** larafale has quit IRC
464 2018-05-02T23:15:23 *** Pat_Boy has joined #bitcoin-core-dev
465 2018-05-02T23:15:50 *** TheV01d_ has joined #bitcoin-core-dev
466 2018-05-02T23:16:45 *** TheV01d has quit IRC
467 2018-05-02T23:16:46 *** PatBoy has quit IRC
468 2018-05-02T23:16:46 *** infernix has quit IRC
469 2018-05-02T23:16:48 *** Pat_Boy is now known as PatBoy
470 2018-05-02T23:16:52 *** TheV01d_ is now known as TheV01d
471 2018-05-02T23:17:59 *** justanotheruser has joined #bitcoin-core-dev
472 2018-05-02T23:19:57 *** nullptr| has quit IRC
473 2018-05-02T23:22:11 *** nullptr| has joined #bitcoin-core-dev
474 2018-05-02T23:22:36 *** infernix has joined #bitcoin-core-dev
475 2018-05-02T23:44:12 *** moneyball has quit IRC