12018-05-16T00:00:01 *** glaksmono has quit IRC
22018-05-16T00:10:27 *** Randolf has quit IRC
32018-05-16T00:11:08 *** Randolf has joined #bitcoin-core-dev
42018-05-16T00:24:18 *** rex4539 has quit IRC
52018-05-16T00:34:44 <bitcoin-git> [bitcoin] Empact closed pull request #13223: refactor: Extract BnB-specific data from CInputCoin (master...duplicate-fee-calc) https://github.com/bitcoin/bitcoin/pull/13223
62018-05-16T00:36:54 *** isis_ is now known as isis
72018-05-16T00:45:16 *** ghost43 has quit IRC
82018-05-16T00:45:56 *** ghost43 has joined #bitcoin-core-dev
92018-05-16T00:49:17 *** tryphe has joined #bitcoin-core-dev
102018-05-16T00:53:49 <bitcoin-git> [bitcoin] kallewoof opened pull request #13242: uint256: Remove unnecessary crypto/common.h use (master...uint256-no-crypto) https://github.com/bitcoin/bitcoin/pull/13242
112018-05-16T01:02:02 *** jtimon has quit IRC
122018-05-16T01:02:35 *** dgenr8 has quit IRC
132018-05-16T01:09:37 *** honeybadgerdgaf has joined #bitcoin-core-dev
142018-05-16T01:11:02 *** d9b4bef9 has quit IRC
152018-05-16T01:11:35 *** honeybadgerdgaf has quit IRC
162018-05-16T01:12:08 *** d9b4bef9 has joined #bitcoin-core-dev
172018-05-16T01:14:19 *** honeybadgerdgaf has joined #bitcoin-core-dev
182018-05-16T01:16:28 *** Lynet has quit IRC
192018-05-16T01:16:30 *** Lynet_ has joined #bitcoin-core-dev
202018-05-16T01:18:35 <bitcoin-git> [bitcoin] jimpo opened pull request #13243: Make reusable base class for auxiliary indices (master...index-abstraction) https://github.com/bitcoin/bitcoin/pull/13243
212018-05-16T01:56:50 *** Lynet_ has quit IRC
222018-05-16T02:11:14 *** honeybadgerdgaf has quit IRC
232018-05-16T02:12:37 *** fanquake has joined #bitcoin-core-dev
242018-05-16T02:12:41 *** honeybadgerdgaf has joined #bitcoin-core-dev
252018-05-16T02:12:52 *** cryptojanitor has joined #bitcoin-core-dev
262018-05-16T02:14:16 <fanquake> If we want to tag 0.16.1, can I get some ACKS on #12967
272018-05-16T02:14:19 <gribble> https://github.com/bitcoin/bitcoin/issues/12967 | [0.16] Backports by fanquake · Pull Request #12967 · bitcoin/bitcoin · GitHub
282018-05-16T02:34:43 * kallewoof rubs head at addrman_new_collisions test.
292018-05-16T02:35:21 <kallewoof> It.. assumes that the first 17 IP addresses will not cause a collision. They don't. On little endian machines.
302018-05-16T02:35:41 <kallewoof> It then assumes taht the 18th IP address will collide. And then it assumes that the 19th won't (where Xth = 250.1.1.<X>).
312018-05-16T02:36:52 <kallewoof> No wonder big endian systems would fail the uint256 quick hash stuff. It depended on hashes being a certain way for the tests to succeed. That's not exactly how you test collisions normally. I would totally understand if these hashes were consensus critical somehow.
322018-05-16T02:37:38 <kallewoof> I honestly can't see the purpose of this test at all.
332018-05-16T02:41:48 <sipa> delete it :)
342018-05-16T02:43:38 <kallewoof> sipa: I might! If I can't convince myself they fulfill a purpose.
352018-05-16T02:45:20 <kallewoof> I literally tried changing the IP to 250.1.2.<X> and the tests now fail horribly..
362018-05-16T02:46:21 <kallewoof> These seem to be from an attempt to increase test coverage from a couple of yrs ago or so, according to git blame.
372018-05-16T02:47:13 <kallewoof> Maybe rewrite them to assume that X % of inserted addresses should not cause a collision. That should work on all architectures.
382018-05-16T02:51:15 *** ohnx has joined #bitcoin-core-dev
392018-05-16T02:57:22 *** Krellan has joined #bitcoin-core-dev
402018-05-16T03:02:14 *** Krellan has quit IRC
412018-05-16T03:07:09 <mryandao> hmm, i noticed that the -alertnotify flag is still in the manpages for `bitcoind` -- shouldn't that be removed already since 0.14?
422018-05-16T03:09:11 <mryandao> and what does 'a really long fork' even mean?
432018-05-16T03:11:41 <mryandao> oh nvm, just looked into the src and its basically doing an alert if there's a fork thats >= 6 blocks
442018-05-16T03:14:30 *** unholymachine has joined #bitcoin-core-dev
452018-05-16T03:32:49 *** justanotheruser has quit IRC
462018-05-16T03:43:44 *** honeybadgerdgaf has quit IRC
472018-05-16T03:54:48 *** unholymachine has quit IRC
482018-05-16T04:01:17 *** honeybadgerdgaf has joined #bitcoin-core-dev
492018-05-16T04:28:35 *** honeybadgerdgaf has quit IRC
502018-05-16T04:37:45 *** honeybadgerdgaf has joined #bitcoin-core-dev
512018-05-16T04:47:18 *** AaronvanW has joined #bitcoin-core-dev
522018-05-16T05:00:03 *** rex4539 has joined #bitcoin-core-dev
532018-05-16T05:02:35 *** cryptojanitor has quit IRC
542018-05-16T05:08:02 *** d9b4bef9 has quit IRC
552018-05-16T05:09:08 *** d9b4bef9 has joined #bitcoin-core-dev
562018-05-16T05:17:54 <kallewoof> sipa: I ended up keeping the tests for now. I just checked where big endian would see collisions and changed tests to work on both. These tests are pretty bad, though, but I guess for the sake of coverage, or something.
572018-05-16T05:23:55 *** honeybadgerdgaf has quit IRC
582018-05-16T05:36:18 *** Samdney has quit IRC
592018-05-16T05:36:48 *** AaronvanW has quit IRC
602018-05-16T05:37:48 *** AaronvanW has joined #bitcoin-core-dev
612018-05-16T05:40:57 *** lnostdal has joined #bitcoin-core-dev
622018-05-16T05:42:05 *** AaronvanW has quit IRC
632018-05-16T05:42:50 *** rex4539 has quit IRC
642018-05-16T05:54:05 *** lnostdal has quit IRC
652018-05-16T05:54:45 *** glaksmono has joined #bitcoin-core-dev
662018-05-16T06:32:02 *** AaronvanW has joined #bitcoin-core-dev
672018-05-16T06:38:24 *** AaronvanW has quit IRC
682018-05-16T06:50:19 <jonasschnelli> MarcoFalke: merge with a single ack? https://github.com/bitcoin/bitcoin/pull/13158
692018-05-16T06:54:21 *** Krellan has joined #bitcoin-core-dev
702018-05-16T07:04:49 *** rex4539 has joined #bitcoin-core-dev
712018-05-16T07:07:49 *** promag has quit IRC
722018-05-16T07:08:02 *** promag has joined #bitcoin-core-dev
732018-05-16T07:10:00 *** promag has quit IRC
742018-05-16T07:13:31 *** Ishtv4n has joined #bitcoin-core-dev
752018-05-16T07:14:51 *** timothy has joined #bitcoin-core-dev
762018-05-16T07:22:22 *** drizztbsd has joined #bitcoin-core-dev
772018-05-16T07:22:28 *** timothy has quit IRC
782018-05-16T07:29:13 *** drizztbsd is now known as timothy
792018-05-16T07:43:26 *** zarez has joined #bitcoin-core-dev
802018-05-16T07:51:02 *** zhrek has joined #bitcoin-core-dev
812018-05-16T08:09:14 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13da2899ae42...40c34a0a29f6
822018-05-16T08:09:14 <bitcoin-git> bitcoin/master 73cd5b2 Cristian Mircea Messel: [gui] Add proxy icon in statusbar
832018-05-16T08:09:15 <bitcoin-git> bitcoin/master 40c34a0 Jonas Schnelli: Merge #11491: [gui] Add proxy icon in statusbar...
842018-05-16T08:09:30 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11491: [gui] Add proxy icon in statusbar (master...add_proxy_icon) https://github.com/bitcoin/bitcoin/pull/11491
852018-05-16T08:14:02 *** Krellan has quit IRC
862018-05-16T08:14:43 *** laurentmt has joined #bitcoin-core-dev
872018-05-16T08:16:38 *** marcoagner has joined #bitcoin-core-dev
882018-05-16T08:20:22 *** AaronvanW has joined #bitcoin-core-dev
892018-05-16T08:21:59 *** Lynet has joined #bitcoin-core-dev
902018-05-16T08:25:06 *** AaronvanW has quit IRC
912018-05-16T08:38:24 *** rex4539 has quit IRC
922018-05-16T08:59:11 *** bhbbh has joined #bitcoin-core-dev
932018-05-16T08:59:28 <bhbbh> join
942018-05-16T09:01:40 *** bhbbh has quit IRC
952018-05-16T09:01:48 *** booyah has quit IRC
962018-05-16T09:14:28 *** AaronvanW has joined #bitcoin-core-dev
972018-05-16T09:19:03 *** AaronvanW has quit IRC
982018-05-16T09:20:04 *** goatpig has joined #bitcoin-core-dev
992018-05-16T09:26:03 *** lnostdal has joined #bitcoin-core-dev
1002018-05-16T09:50:43 *** setpill has joined #bitcoin-core-dev
1012018-05-16T09:53:07 *** AaronvanW has joined #bitcoin-core-dev
1022018-05-16T09:56:04 *** lnostdal has quit IRC
1032018-05-16T09:57:16 *** AaronvanW has quit IRC
1042018-05-16T10:02:38 *** AaronvanW has joined #bitcoin-core-dev
1052018-05-16T10:05:06 *** AaronvanW has quit IRC
1062018-05-16T10:06:27 *** booyah has joined #bitcoin-core-dev
1072018-05-16T10:08:24 *** lnostdal has joined #bitcoin-core-dev
1082018-05-16T10:12:39 *** AaronvanW has joined #bitcoin-core-dev
1092018-05-16T10:19:47 *** rex4539 has joined #bitcoin-core-dev
1102018-05-16T10:24:16 *** glaksmono has quit IRC
1112018-05-16T10:25:24 *** Lynet has quit IRC
1122018-05-16T10:31:26 *** AaronvanW has quit IRC
1132018-05-16T10:33:21 *** setpill has quit IRC
1142018-05-16T10:38:47 *** jtimon has joined #bitcoin-core-dev
1152018-05-16T10:40:32 *** rex4539 has quit IRC
1162018-05-16T10:42:54 *** justanotheruser has joined #bitcoin-core-dev
1172018-05-16T11:20:10 *** promag has joined #bitcoin-core-dev
1182018-05-16T11:22:43 *** promag has quit IRC
1192018-05-16T11:22:57 *** promag has joined #bitcoin-core-dev
1202018-05-16T11:23:42 *** glaksmono has joined #bitcoin-core-dev
1212018-05-16T11:35:29 *** Victorsueca has quit IRC
1222018-05-16T11:36:38 *** Victorsueca has joined #bitcoin-core-dev
1232018-05-16T11:38:13 *** glaksmono has quit IRC
1242018-05-16T11:38:47 *** glaksmono has joined #bitcoin-core-dev
1252018-05-16T11:41:32 <bitcoin-git> [bitcoin] laanwj pushed 10 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/9ea62a3dc4bd...feba12fe85e8
1262018-05-16T11:41:33 <bitcoin-git> bitcoin/0.16 f60e84d e0: Limit the number of IPs we use from each DNS seeder...
1272018-05-16T11:41:33 <bitcoin-git> bitcoin/0.16 f118a7a 251: Fix illegal default `addProxy` and `addrSeparateProxyTor` settings....
1282018-05-16T11:41:34 <bitcoin-git> bitcoin/0.16 e802c22 John Newbery: [config] Remove blockmaxsize option...
1292018-05-16T11:43:18 *** glaksmono has quit IRC
1302018-05-16T11:49:23 *** laurentmt has quit IRC
1312018-05-16T11:56:12 *** laurentmt has joined #bitcoin-core-dev
1322018-05-16T12:05:40 <promag> wumpus: which PR are you looking at?
1332018-05-16T12:10:31 *** Ishtv4n has quit IRC
1342018-05-16T12:13:07 *** Ishtv4n has joined #bitcoin-core-dev
1352018-05-16T12:14:09 *** tryphe has quit IRC
1362018-05-16T12:16:02 *** tryphe has joined #bitcoin-core-dev
1372018-05-16T12:31:50 *** glaksmono has joined #bitcoin-core-dev
1382018-05-16T12:36:15 *** glaksmono has quit IRC
1392018-05-16T12:44:17 *** AaronvanW has joined #bitcoin-core-dev
1402018-05-16T12:51:53 *** glaksmono has joined #bitcoin-core-dev
1412018-05-16T12:53:43 *** Ishtv4n has quit IRC
1422018-05-16T13:02:24 *** tryphe has quit IRC
1432018-05-16T13:04:35 *** justanotheruser has quit IRC
1442018-05-16T13:04:57 *** justan0theruser has joined #bitcoin-core-dev
1452018-05-16T13:06:19 *** marcoagner has quit IRC
1462018-05-16T13:06:25 *** AaronvanW has quit IRC
1472018-05-16T13:06:48 *** CubicEarths has joined #bitcoin-core-dev
1482018-05-16T13:11:03 *** glaksmono has quit IRC
1492018-05-16T13:14:11 *** Victorsueca has quit IRC
1502018-05-16T13:15:37 *** Victorsueca has joined #bitcoin-core-dev
1512018-05-16T13:17:25 *** glaksmono has joined #bitcoin-core-dev
1522018-05-16T13:18:31 *** pergaminho has joined #bitcoin-core-dev
1532018-05-16T13:22:09 *** glaksmono has quit IRC
1542018-05-16T13:23:50 *** AaronvanW has joined #bitcoin-core-dev
1552018-05-16T13:25:01 *** CubicEarths has quit IRC
1562018-05-16T13:25:55 *** pergaminho has quit IRC
1572018-05-16T13:28:07 *** glaksmono has joined #bitcoin-core-dev
1582018-05-16T13:29:32 *** pergaminho has joined #bitcoin-core-dev
1592018-05-16T13:30:31 *** arubi has quit IRC
1602018-05-16T13:32:29 *** glaksmono has quit IRC
1612018-05-16T13:33:04 *** glaksmono has joined #bitcoin-core-dev
1622018-05-16T13:40:34 *** glaksmono has quit IRC
1632018-05-16T13:40:48 *** glaksmono has joined #bitcoin-core-dev
1642018-05-16T13:44:10 *** arubi has joined #bitcoin-core-dev
1652018-05-16T13:49:11 *** Guyver2 has joined #bitcoin-core-dev
1662018-05-16T14:02:15 *** lnostdal_ has joined #bitcoin-core-dev
1672018-05-16T14:04:17 *** lnostdal has quit IRC
1682018-05-16T14:04:40 <jonasschnelli> Q for anyone with leveldb experience (maybe sipa, wumpus): Is there a performance downside of seeking the cursor to a specific key and read the current cursors value rather then just "read" a keys value "directly"?
1692018-05-16T14:11:08 <wumpus> I wouldn't expect there to be a significant difference, as long as you're looking for an existing key - both have to locate the key in the same way
1702018-05-16T14:12:09 *** ExtraCrispy has joined #bitcoin-core-dev
1712018-05-16T14:14:49 <jonasschnelli> wumpus: thanks
1722018-05-16T14:16:01 <jonasschnelli> I was thinking of storing 1-to-n relations (addressindex; address maps to many txns). Instead of constantly update a single object (read->(update)->write) I though of just reducing to a write operation
1732018-05-16T14:16:22 <jonasschnelli> Though it will lead to more disk-space being consumed due to the repetitive key-parts
1742018-05-16T14:18:19 <gmaxwell> I would expect pretty poor performance if you look up a non-existing entry, however. (also implied by wumpus' statement; but thought it was worth making a point of)-- otherwise leveldb is pretty fast for misses.
1752018-05-16T14:20:06 *** m8tion_ has quit IRC
1762018-05-16T14:23:46 *** ExtraCrispy has quit IRC
1772018-05-16T14:30:27 <bitcoin-git> [bitcoin] ken2812221 opened pull request #13246: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13246
1782018-05-16T14:35:47 *** AaronvanW has quit IRC
1792018-05-16T14:39:44 *** Deinogalerix21 has joined #bitcoin-core-dev
1802018-05-16T14:40:48 *** Samdney has joined #bitcoin-core-dev
1812018-05-16T14:44:35 *** justan0theruser has quit IRC
1822018-05-16T14:49:12 *** AaronvanW has joined #bitcoin-core-dev
1832018-05-16T14:52:04 <wumpus> right, the per-ldb bloom filter would be expected to make direct misses fast, but if it still has to look at the next record after the cursor, that will be a slower operation
1842018-05-16T15:00:54 <jonasschnelli> gmaxwell, wumpus: so for a 1-to-n relation, a exist-check is probably the biggest slowdown (especially for the first entry where the key does not exists). So a single write with hash160-blockkey-txpos is probably faster during indexing...
1852018-05-16T15:01:29 <jonasschnelli> for a lookup, just set the cursor to the key (hash160) and itterate as long as the key matches the hash160
1862018-05-16T15:01:46 *** ExtraCrispy has joined #bitcoin-core-dev
1872018-05-16T15:02:01 <jonasschnelli> lookup may be slower compared to storing the entire serialized object
1882018-05-16T15:02:36 <jonasschnelli> (though I expect cursor->next() must be pretty fast)
1892018-05-16T15:03:08 *** fanquake has quit IRC
1902018-05-16T15:04:29 *** kabaum has joined #bitcoin-core-dev
1912018-05-16T15:04:52 <jonasschnelli> hmm.. my IDE debugger refuses to debug wallet.cpp since we also have interface/wallet.cpp... meh!
1922018-05-16T15:05:19 <jonasschnelli> Is that common c++ practice to have same filenames in different subfolders?
1932018-05-16T15:06:48 *** AaronvanW has quit IRC
1942018-05-16T15:07:08 *** Victorsueca has quit IRC
1952018-05-16T15:08:37 *** Victorsueca has joined #bitcoin-core-dev
1962018-05-16T15:11:39 <ryanofsky> of course it is, i don't think you would use folders at all if filenames were supposed to be globally unique
1972018-05-16T15:11:59 *** elichai2 has joined #bitcoin-core-dev
1982018-05-16T15:11:59 <promag> jonasschnelli: should not be a problem
1992018-05-16T15:12:45 <jonasschnelli> Yes. Your both righ,.. Qt Create dbg/lldb integration is just buggy.
2002018-05-16T15:12:55 <jonasschnelli> *Qt Creator
2012018-05-16T15:13:01 *** elichai2 has left #bitcoin-core-dev
2022018-05-16T15:13:37 *** laurentmt has quit IRC
2032018-05-16T15:18:17 *** Deinogalerix21 has quit IRC
2042018-05-16T15:24:21 *** raarr has joined #bitcoin-core-dev
2052018-05-16T15:30:20 *** m8tion has joined #bitcoin-core-dev
2062018-05-16T15:31:27 *** glaksmono has quit IRC
2072018-05-16T15:31:59 *** glaksmono has joined #bitcoin-core-dev
2082018-05-16T15:36:21 *** glaksmono has quit IRC
2092018-05-16T15:37:03 *** Guyver2 has quit IRC
2102018-05-16T15:37:15 *** Guyver2 has joined #bitcoin-core-dev
2112018-05-16T15:38:55 <wumpus> right, C/C++ has no requirement for filenames to be unique in a project
2122018-05-16T15:40:35 <wumpus> this would be really difficult to enforce for large projects with a lot of people working on them. Even more, linkers have no concept of 'project-local' so it'd also collide between libraries then.
2132018-05-16T15:40:57 *** Randolf has quit IRC
2142018-05-16T15:42:35 *** Randolf has joined #bitcoin-core-dev
2152018-05-16T15:43:22 <wumpus> (at one employer we did have a requirement that every include file and compilation unit had a unique name; don't know why; but it resulted in everything being prefixed to the point of absurdity; every module had a two/four letter name, and every file had to be prefixed with the concatenated submodule identifiers)
2162018-05-16T15:47:13 *** Randolf has quit IRC
2172018-05-16T15:47:24 *** justan0theruser has joined #bitcoin-core-dev
2182018-05-16T15:47:32 <wumpus> inbefore someone proposes it for the bitcoin repository someone to have a reason to add another linter
2192018-05-16T15:56:34 *** lei_ has joined #bitcoin-core-dev
2202018-05-16T15:57:38 *** lei_ has quit IRC
2212018-05-16T16:00:29 *** Krellan has joined #bitcoin-core-dev
2222018-05-16T16:06:22 *** justan0theruser has quit IRC
2232018-05-16T16:09:08 <sipa> like src/a/b/c/a_b_c_file.h?
2242018-05-16T16:14:12 *** marcoagner has joined #bitcoin-core-dev
2252018-05-16T16:16:52 *** Randolf has joined #bitcoin-core-dev
2262018-05-16T16:16:53 <ryanofsky> i don't think that's repetitive enough, maybe src/a/a_b/a_b_c/src_a_b_c_file.h
2272018-05-16T16:17:30 <sipa> haha
2282018-05-16T16:22:04 *** lnostdal_ is now known as lnostdal
2292018-05-16T16:22:11 *** Sinclair6 has quit IRC
2302018-05-16T16:30:37 *** marcoagner has quit IRC
2312018-05-16T16:31:01 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/40c34a0a29f6...11e7bdfd903e
2322018-05-16T16:31:02 <bitcoin-git> bitcoin/master ecc3c4a Matt Corallo: Do not unlock cs_main in ABC unless we've actually made progress....
2332018-05-16T16:31:02 <bitcoin-git> bitcoin/master a3ae8e6 Jesse Cohen: Fix concurrency-related bugs in ActivateBestChain...
2342018-05-16T16:31:03 <bitcoin-git> bitcoin/master dd435ad Jesse Cohen: Add unit tests for signals generated by ProcessNewBlock()...
2352018-05-16T16:31:09 *** marcoagner has joined #bitcoin-core-dev
2362018-05-16T16:31:45 <bitcoin-git> [bitcoin] laanwj closed pull request #13023: Fix some concurrency issues in ActivateBestChain() (master...event-tests) https://github.com/bitcoin/bitcoin/pull/13023
2372018-05-16T16:35:57 *** davec has quit IRC
2382018-05-16T16:40:56 *** justanotheruser has joined #bitcoin-core-dev
2392018-05-16T16:44:49 <wumpus> yes, that idea, EADGxBLxAP_foowidget.[ch]
2402018-05-16T16:45:01 *** Sinclair6 has joined #bitcoin-core-dev
2412018-05-16T17:00:48 *** laurentmt has joined #bitcoin-core-dev
2422018-05-16T17:01:26 *** isis is now known as isis_
2432018-05-16T17:07:25 *** Samdney has quit IRC
2442018-05-16T17:07:25 *** Victorsueca has quit IRC
2452018-05-16T17:08:38 *** Victorsueca has joined #bitcoin-core-dev
2462018-05-16T17:09:21 *** timothy has quit IRC
2472018-05-16T17:10:54 *** Iconate has joined #bitcoin-core-dev
2482018-05-16T17:15:51 *** glaksmono has joined #bitcoin-core-dev
2492018-05-16T17:20:46 *** glaksmono has quit IRC
2502018-05-16T17:24:19 *** davec has joined #bitcoin-core-dev
2512018-05-16T17:26:34 *** pergaminho has quit IRC
2522018-05-16T17:32:21 *** glaksmono has joined #bitcoin-core-dev
2532018-05-16T17:32:29 *** drexl has joined #bitcoin-core-dev
2542018-05-16T17:36:27 *** glaksmono has quit IRC
2552018-05-16T17:41:05 *** mistergold has joined #bitcoin-core-dev
2562018-05-16T17:46:49 *** timothy has joined #bitcoin-core-dev
2572018-05-16T17:46:55 *** AaronvanW has joined #bitcoin-core-dev
2582018-05-16T17:52:35 *** timothy has quit IRC
2592018-05-16T17:59:44 *** Aaronvan_ has joined #bitcoin-core-dev
2602018-05-16T17:59:48 *** rex4539 has joined #bitcoin-core-dev
2612018-05-16T18:00:57 *** AaronvanW has quit IRC
2622018-05-16T18:02:22 *** Aaronvan_ has quit IRC
2632018-05-16T18:03:12 *** AaronvanW has joined #bitcoin-core-dev
2642018-05-16T18:08:21 *** Krellan has quit IRC
2652018-05-16T18:10:06 *** SopaXorzTaker has joined #bitcoin-core-dev
2662018-05-16T18:11:30 *** glaksmono has joined #bitcoin-core-dev
2672018-05-16T18:12:22 *** AaronvanW has quit IRC
2682018-05-16T18:12:40 *** AaronvanW has joined #bitcoin-core-dev
2692018-05-16T18:14:32 *** mistergold has quit IRC
2702018-05-16T18:15:25 *** AaronvanW has quit IRC
2712018-05-16T18:15:35 *** glaksmono has quit IRC
2722018-05-16T18:16:23 *** AaronvanW has joined #bitcoin-core-dev
2732018-05-16T18:19:18 *** AaronvanW has quit IRC
2742018-05-16T18:23:58 *** AaronvanW has joined #bitcoin-core-dev
2752018-05-16T18:25:04 *** justanotheruser has quit IRC
2762018-05-16T18:25:27 *** Aaronvan_ has joined #bitcoin-core-dev
2772018-05-16T18:26:47 *** justanotheruser has joined #bitcoin-core-dev
2782018-05-16T18:29:05 *** AaronvanW has quit IRC
2792018-05-16T18:34:50 *** justanotheruser has quit IRC
2802018-05-16T18:35:17 *** Aaronvan_ has quit IRC
2812018-05-16T18:39:25 *** marcoagner has quit IRC
2822018-05-16T18:44:05 *** laurentmt has quit IRC
2832018-05-16T18:44:30 *** marcoagner has joined #bitcoin-core-dev
2842018-05-16T18:47:18 *** SopaXorzTaker has quit IRC
2852018-05-16T18:49:00 *** glaksmono has joined #bitcoin-core-dev
2862018-05-16T18:49:45 *** justanotheruser has joined #bitcoin-core-dev
2872018-05-16T18:52:57 *** Randolf has quit IRC
2882018-05-16T18:53:07 *** m8tion has quit IRC
2892018-05-16T18:53:19 *** glaksmono has quit IRC
2902018-05-16T18:54:07 *** Randolf has joined #bitcoin-core-dev
2912018-05-16T18:54:45 *** AaronvanW has joined #bitcoin-core-dev
2922018-05-16T19:00:05 *** ken2812221 has quit IRC
2932018-05-16T19:00:08 *** AaronvanW has quit IRC
2942018-05-16T19:00:34 *** Krellan has joined #bitcoin-core-dev
2952018-05-16T19:12:48 *** Deadhand has quit IRC
2962018-05-16T19:24:35 <BlueMatt> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.16.1 <-- I think we should untag the remaining things and move forward with backports
2972018-05-16T19:24:36 <BlueMatt> wumpus: ?
2982018-05-16T19:26:57 *** dx25 has quit IRC
2992018-05-16T19:28:53 *** isis_ is now known as isis
3002018-05-16T19:34:05 *** AaronvanW has joined #bitcoin-core-dev
3012018-05-16T19:37:06 *** glaksmono has joined #bitcoin-core-dev
3022018-05-16T19:38:05 *** Iconate has quit IRC
3032018-05-16T19:39:43 <bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/11e7bdfd903e...4cfe17c3382b
3042018-05-16T19:39:44 <bitcoin-git> bitcoin/master 59b87a2 John Newbery: [wallet] Fix potential memory leak in CreateWalletFromFile...
3052018-05-16T19:39:44 <bitcoin-git> bitcoin/master 470316c John Newbery: [wallet] setup wallet background flushing in WalletInit directly...
3062018-05-16T19:39:45 <bitcoin-git> bitcoin/master e0e90db John Newbery: [wallet] Add CWallet::Verify function...
3072018-05-16T19:39:58 <bitcoin-git> [bitcoin] laanwj closed pull request #10740: [wallet] `loadwallet` RPC - load wallet at runtime (master...load_unload_wallet) https://github.com/bitcoin/bitcoin/pull/10740
3082018-05-16T19:40:08 <BlueMatt> nice!
3092018-05-16T19:41:14 <BlueMatt> another easy high-priority-merge-win: #13011 :p
3102018-05-16T19:41:16 <gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub
3112018-05-16T19:41:44 *** glaksmono has quit IRC
3122018-05-16T19:42:18 *** AaronvanW has quit IRC
3132018-05-16T19:45:51 <promag> yap ^
3142018-05-16T19:49:33 <bitcoin-git> [bitcoin] skeees opened pull request #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model (master...scheduler-tests) https://github.com/bitcoin/bitcoin/pull/13247
3152018-05-16T19:50:52 <promag> would be nice to have some reviews in #13097
3162018-05-16T19:50:55 <gribble> https://github.com/bitcoin/bitcoin/issues/13097 | ui: Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub
3172018-05-16T19:51:37 <promag> jonasschnelli luke-jr ^
3182018-05-16T19:54:01 *** marcoagner has quit IRC
3192018-05-16T19:55:03 *** AaronvanW has joined #bitcoin-core-dev
3202018-05-16T20:07:52 *** AaronvanW has quit IRC
3212018-05-16T20:08:05 *** mathwetrust has joined #bitcoin-core-dev
3222018-05-16T20:21:13 *** AaronvanW has joined #bitcoin-core-dev
3232018-05-16T20:26:59 *** AaronvanW has quit IRC
3242018-05-16T20:38:50 *** rex4539 has quit IRC
3252018-05-16T20:45:02 *** d9b4bef9 has quit IRC
3262018-05-16T20:46:07 *** d9b4bef9 has joined #bitcoin-core-dev
3272018-05-16T21:01:30 <phantomcircuit> sipa, flags ^= 1; is sort of confusing in the transaction deserialization function btw
3282018-05-16T21:04:43 *** glaksmono has joined #bitcoin-core-dev
3292018-05-16T21:07:10 *** tripleslash is now known as [\\\]
3302018-05-16T21:08:06 *** Victorsueca has quit IRC
3312018-05-16T21:09:05 *** glaksmono has quit IRC
3322018-05-16T21:09:27 *** Victorsueca has joined #bitcoin-core-dev
3332018-05-16T21:14:38 *** AaronvanW has joined #bitcoin-core-dev
3342018-05-16T21:18:37 *** AaronvanW has quit IRC
3352018-05-16T21:18:48 <phantomcircuit> AllocateFileRange seems to fallback to writting 1 byte at a time?
3362018-05-16T21:19:05 *** AaronvanW has joined #bitcoin-core-dev
3372018-05-16T21:21:21 *** AaronvanW has quit IRC
3382018-05-16T21:22:03 *** AaronvanW has joined #bitcoin-core-dev
3392018-05-16T21:22:44 *** honeybadgerdgaf has joined #bitcoin-core-dev
3402018-05-16T21:27:50 *** Guyver2 has quit IRC
3412018-05-16T21:34:06 *** [\\\] is now known as tripleslash
3422018-05-16T21:46:07 <bitcoin-git> [bitcoin] mess110 opened pull request #13248: [gui] Make proxy icon from statusbar clickable (master...make_proxy_icon_clickable) https://github.com/bitcoin/bitcoin/pull/13248
3432018-05-16T21:49:30 *** promag has quit IRC
3442018-05-16T21:53:34 *** honeybadgerdgaf has quit IRC
3452018-05-16T21:55:41 *** promag has joined #bitcoin-core-dev
3462018-05-16T21:56:35 *** honeybadgerdgaf has joined #bitcoin-core-dev
3472018-05-16T22:01:53 <bitcoin-git> [bitcoin] practicalswift opened pull request #13249: Make objects in range declarations immutable by default (master...for-const) https://github.com/bitcoin/bitcoin/pull/13249
3482018-05-16T22:03:35 *** Randolf has quit IRC
3492018-05-16T22:04:02 *** AaronvanW has quit IRC
3502018-05-16T22:10:20 *** goatpig has quit IRC
3512018-05-16T22:19:45 *** spinza has quit IRC
3522018-05-16T22:20:55 *** Randolf has joined #bitcoin-core-dev
3532018-05-16T22:21:21 *** mathwetrust has quit IRC
3542018-05-16T22:21:45 *** glaksmono has joined #bitcoin-core-dev
3552018-05-16T22:27:30 *** gaf_ has quit IRC
3562018-05-16T22:29:53 *** promag has quit IRC
3572018-05-16T22:30:21 *** gaf_ has joined #bitcoin-core-dev
3582018-05-16T22:31:22 *** glaksmono has quit IRC
3592018-05-16T22:31:54 *** glaksmono has joined #bitcoin-core-dev
3602018-05-16T22:34:12 *** honeybadgerdgaf has quit IRC
3612018-05-16T22:34:30 *** spinza has joined #bitcoin-core-dev
3622018-05-16T22:35:40 *** honeybadgerdgaf has joined #bitcoin-core-dev
3632018-05-16T22:36:05 *** glaksmono has quit IRC
3642018-05-16T22:36:40 *** Victorsueca has quit IRC
3652018-05-16T22:37:58 *** Victorsueca has joined #bitcoin-core-dev
3662018-05-16T22:48:54 *** promag has joined #bitcoin-core-dev
3672018-05-16T22:50:18 *** promag has quit IRC
3682018-05-16T22:50:42 <bitcoin-git> [bitcoin] pstratem opened pull request #13250: Simplify ProcessGetBlockData execution (master...2018-05-16-processgetblockdata) https://github.com/bitcoin/bitcoin/pull/13250
3692018-05-16T22:56:11 <phantomcircuit> ^ but why BlueMatt
3702018-05-16T22:56:45 <BlueMatt> cause old code got moved, dont blame me
3712018-05-16T22:57:00 *** honeybadgerdgaf has quit IRC
3722018-05-16T22:59:41 *** honeybadgerdgaf has joined #bitcoin-core-dev
3732018-05-16T23:00:31 *** AaronvanW has joined #bitcoin-core-dev
3742018-05-16T23:01:03 <phantomcircuit> sipa, it's making BlueMatt simpler
3752018-05-16T23:02:16 <sipa> well please elaborate in the PR description!
3762018-05-16T23:02:18 *** Victorsueca has quit IRC
3772018-05-16T23:02:30 *** Victorsueca has joined #bitcoin-core-dev
3782018-05-16T23:02:34 <sipa> does it decrease the size of his color pallette?
3792018-05-16T23:05:48 <phantomcircuit> im not sure how that is possible
3802018-05-16T23:05:52 <phantomcircuit> blue -> blue
3812018-05-16T23:09:30 <sipa> seriously, please give a better description on your PR
3822018-05-16T23:10:34 *** Randolf has quit IRC
3832018-05-16T23:14:33 *** Krellan has quit IRC
3842018-05-16T23:15:46 *** Krellan has joined #bitcoin-core-dev
3852018-05-16T23:15:48 *** honeybadgerdgaf has quit IRC
3862018-05-16T23:17:15 *** honeybadgerdgaf has joined #bitcoin-core-dev
3872018-05-16T23:21:52 *** Aaronvan_ has joined #bitcoin-core-dev
3882018-05-16T23:23:05 *** GreatSock has joined #bitcoin-core-dev
3892018-05-16T23:24:57 *** AaronvanW has quit IRC
3902018-05-16T23:25:24 *** GreatSock has quit IRC
3912018-05-16T23:36:48 *** eparham7861 has joined #bitcoin-core-dev
3922018-05-16T23:37:38 *** eparham7861 has quit IRC
3932018-05-16T23:42:03 *** dgenr8 has joined #bitcoin-core-dev
3942018-05-16T23:52:05 *** honeybadgerdgaf has quit IRC
3952018-05-16T23:56:10 *** StopAndDecrypt has quit IRC
3962018-05-16T23:56:28 *** drexl has quit IRC