12018-05-21T00:00:25  *** goatpig has quit IRC
  22018-05-21T00:07:02  *** honeybadgerdgaf has joined #bitcoin-core-dev
  32018-05-21T00:07:09  *** belcher has quit IRC
  42018-05-21T00:08:11  *** honeybadgerdgaf has quit IRC
  52018-05-21T00:11:04  *** honeybadgerdgaf has joined #bitcoin-core-dev
  62018-05-21T00:55:44  *** drexl has quit IRC
  72018-05-21T00:56:37  *** honeybadgerdgaf has joined #bitcoin-core-dev
  82018-05-21T01:08:46  *** honeybadgerdgaf has quit IRC
  92018-05-21T01:21:00  *** honeybadgerdgaf has joined #bitcoin-core-dev
 102018-05-21T01:23:39  *** ken2812221 has quit IRC
 112018-05-21T01:23:42  *** honeybadgerdgaf has quit IRC
 122018-05-21T01:24:09  *** ken2812221 has joined #bitcoin-core-dev
 132018-05-21T01:24:34  *** belcher has joined #bitcoin-core-dev
 142018-05-21T01:24:53  *** honeybadgerdgaf has joined #bitcoin-core-dev
 152018-05-21T01:29:31  *** eukaryote has joined #bitcoin-core-dev
 162018-05-21T01:33:21  *** Sinclair6 has quit IRC
 172018-05-21T01:51:14  *** glaksmono has joined #bitcoin-core-dev
 182018-05-21T02:05:02  *** d9b4bef9 has quit IRC
 192018-05-21T02:06:07  *** d9b4bef9 has joined #bitcoin-core-dev
 202018-05-21T02:07:26  *** yuyamchun has joined #bitcoin-core-dev
 212018-05-21T02:17:42  *** glaksmono has quit IRC
 222018-05-21T02:21:30  *** glaksmono has joined #bitcoin-core-dev
 232018-05-21T02:28:00  <bitcoin-git> [bitcoin] achow101 opened pull request #13289: [Qt] Re-setup args after translator setup to translate help text (master...qt-help-translations) https://github.com/bitcoin/bitcoin/pull/13289
 242018-05-21T02:32:58  *** glaksmono has quit IRC
 252018-05-21T02:34:05  *** yuyamchun has quit IRC
 262018-05-21T02:35:42  *** honeybadgerdgaf has quit IRC
 272018-05-21T02:41:15  *** honeybadgerdgaf has joined #bitcoin-core-dev
 282018-05-21T02:46:21  *** satwo has joined #bitcoin-core-dev
 292018-05-21T02:56:37  *** glaksmono has joined #bitcoin-core-dev
 302018-05-21T02:58:47  *** honeybadgerdgaf has quit IRC
 312018-05-21T03:00:59  *** glaksmono has quit IRC
 322018-05-21T03:03:37  *** honeybadgerdgaf has joined #bitcoin-core-dev
 332018-05-21T03:07:11  *** ossifrage_ is now known as ossifrage
 342018-05-21T03:13:23  *** Emcy has quit IRC
 352018-05-21T03:15:43  *** jrayhawk has quit IRC
 362018-05-21T03:15:51  *** jrayhawk has joined #bitcoin-core-dev
 372018-05-21T03:19:11  *** honeybadgerdgaf has quit IRC
 382018-05-21T03:19:19  *** glaksmono has joined #bitcoin-core-dev
 392018-05-21T03:32:27  *** honeybadgerdgaf has joined #bitcoin-core-dev
 402018-05-21T03:33:23  *** Samdney has quit IRC
 412018-05-21T04:03:13  *** honeybadgerdgaf has quit IRC
 422018-05-21T04:14:16  *** glaksmono has quit IRC
 432018-05-21T04:14:18  *** eukaryote has quit IRC
 442018-05-21T04:21:05  *** MrPaz has joined #bitcoin-core-dev
 452018-05-21T04:21:37  *** Emcy has joined #bitcoin-core-dev
 462018-05-21T04:23:45  *** honeybadgerdgaf has joined #bitcoin-core-dev
 472018-05-21T04:24:58  *** honeybadgerdgaf has joined #bitcoin-core-dev
 482018-05-21T04:56:39  *** glaksmono has joined #bitcoin-core-dev
 492018-05-21T05:11:35  *** honeybadgerdgaf has quit IRC
 502018-05-21T05:13:13  *** honeybadgerdgaf has joined #bitcoin-core-dev
 512018-05-21T05:15:16  *** Randolf has joined #bitcoin-core-dev
 522018-05-21T05:16:07  *** honeybadgerdgaf has quit IRC
 532018-05-21T05:36:37  *** ExtraCrispy has quit IRC
 542018-05-21T05:46:12  *** Emcy has quit IRC
 552018-05-21T05:57:33  *** satwo has quit IRC
 562018-05-21T06:00:18  *** satwo has joined #bitcoin-core-dev
 572018-05-21T06:02:57  *** SopaXorzTaker has joined #bitcoin-core-dev
 582018-05-21T06:11:16  <bitcoin-git> [bitcoin] Empact opened pull request #13291: [moveonly] Extract tor_reply.h from tor_control.cpp (master...tor-reply) https://github.com/bitcoin/bitcoin/pull/13291
 592018-05-21T06:12:50  *** glaksmono has quit IRC
 602018-05-21T06:13:16  *** glaksmono has joined #bitcoin-core-dev
 612018-05-21T06:19:21  *** glaksmono has quit IRC
 622018-05-21T06:19:55  *** satwo has quit IRC
 632018-05-21T06:21:50  *** qinfengling has quit IRC
 642018-05-21T06:22:15  *** qinfengling has joined #bitcoin-core-dev
 652018-05-21T06:25:09  *** satwo has joined #bitcoin-core-dev
 662018-05-21T06:38:02  *** d9b4bef9 has quit IRC
 672018-05-21T06:38:34  *** glaksmono has joined #bitcoin-core-dev
 682018-05-21T06:39:33  *** Ishtv4n_ has joined #bitcoin-core-dev
 692018-05-21T06:41:08  *** d9b4bef9 has joined #bitcoin-core-dev
 702018-05-21T06:44:29  *** ToURniQue has joined #bitcoin-core-dev
 712018-05-21T06:47:15  *** ToURniQue has quit IRC
 722018-05-21T06:52:59  *** satwo has quit IRC
 732018-05-21T06:53:50  *** satwo has joined #bitcoin-core-dev
 742018-05-21T06:59:30  *** Ishtv4n has joined #bitcoin-core-dev
 752018-05-21T07:00:03  *** Ishtv4n_ has quit IRC
 762018-05-21T07:01:42  *** Ishtv4n has quit IRC
 772018-05-21T07:04:32  *** Ishtv4n has joined #bitcoin-core-dev
 782018-05-21T07:11:21  *** rex4539 has quit IRC
 792018-05-21T07:12:09  *** Randolf has quit IRC
 802018-05-21T07:12:42  *** Randolf has joined #bitcoin-core-dev
 812018-05-21T07:26:25  *** promag has joined #bitcoin-core-dev
 822018-05-21T07:27:47  <provoostenator> IIRC someone recently suggested that too much of a dbcache is not a good thing. Why would that be? Is that only the case for n < dbcache < max_historical_utxo_size ?
 832018-05-21T07:28:34  *** promag has quit IRC
 842018-05-21T07:37:07  <provoostenator> Reason I ask is because in my benchmarking for #12404 my impression is that luke-jr's 10% pruning approach is faster than my aggresive prune approach. That effect appears more pronounced as I increase dbache. Pruning 10% should lead to more prune events, which in turn would keep dbcache smaller as a side effect.
 852018-05-21T07:37:09  <gribble> https://github.com/bitcoin/bitcoin/issues/12404 | Prune more aggressively during IBD by Sjors · Pull Request #12404 · bitcoin/bitcoin · GitHub
 862018-05-21T07:37:41  <provoostenator> If that doesn't make any sense at all, then maybe I'm just seeing random noise, so thoughts welcome.
 872018-05-21T07:38:24  <luke-jr> provoostenator: I imagine the 10% pruning is most of the advantage
 882018-05-21T07:39:14  <provoostenator> That could well be, which is why I'm testing it, but I'm surprised if it's actively harmful to prune more. That suggests something else is going on.
 892018-05-21T07:40:04  *** laurentmt has joined #bitcoin-core-dev
 902018-05-21T07:40:15  <luke-jr> yes, I wouldn't expect pruning more to be harmful
 912018-05-21T07:40:28  <luke-jr> except in terms of wallet syncing perhaps
 922018-05-21T07:40:33  <luke-jr> or similar
 932018-05-21T07:41:15  <provoostenator> This one is configured with --disable-wallet.
 942018-05-21T07:42:07  *** zarez has joined #bitcoin-core-dev
 952018-05-21T07:42:45  <bitcoin-git> [bitcoin] jonasschnelli pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/d792e47421fc...6738813bcbb7
 962018-05-21T07:42:46  <bitcoin-git> bitcoin/master 131d445 John Newbery: scripted-diff: Rename master key to seed...
 972018-05-21T07:42:46  <bitcoin-git> bitcoin/master c75c351 John Newbery: [refactor] manually change remaining instances of master key to seed.
 982018-05-21T07:42:47  <bitcoin-git> bitcoin/master 79053a5 John Newbery: [rpc] [wallet] Add 'hdmasterkeyid' alias return values....
 992018-05-21T07:43:23  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12924: Fix hdmaster-key / seed-key confusion (scripted diff) (master...master_key_to_seed) https://github.com/bitcoin/bitcoin/pull/12924
1002018-05-21T07:48:52  <provoostenator> (I think that "someone" was eklitzke)
1012018-05-21T07:59:38  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #13292: Re-add bench_bitcoin to gitian binaries (master...2018/05/bench_gitian) https://github.com/bitcoin/bitcoin/pull/13292
1022018-05-21T08:08:06  *** timothy has joined #bitcoin-core-dev
1032018-05-21T08:08:18  *** setpill has joined #bitcoin-core-dev
1042018-05-21T08:14:23  *** glaksmono has quit IRC
1052018-05-21T08:14:50  *** glaksmono has joined #bitcoin-core-dev
1062018-05-21T08:19:30  *** glaksmono has quit IRC
1072018-05-21T08:21:27  *** setpill has quit IRC
1082018-05-21T08:21:47  *** setpill has joined #bitcoin-core-dev
1092018-05-21T08:24:00  *** Victorsueca has quit IRC
1102018-05-21T08:25:16  *** Victorsueca has joined #bitcoin-core-dev
1112018-05-21T08:26:30  *** setpill has quit IRC
1122018-05-21T08:26:58  *** setpill has joined #bitcoin-core-dev
1132018-05-21T08:27:00  *** Guyver2 has joined #bitcoin-core-dev
1142018-05-21T08:27:09  *** Ishtv4n has quit IRC
1152018-05-21T08:30:02  *** Ishtv4n has joined #bitcoin-core-dev
1162018-05-21T08:31:42  *** Ishtv4n has quit IRC
1172018-05-21T08:33:50  *** LeMiner has joined #bitcoin-core-dev
1182018-05-21T08:34:33  *** Ishtv4n has joined #bitcoin-core-dev
1192018-05-21T08:37:00  *** glaksmono has joined #bitcoin-core-dev
1202018-05-21T08:38:19  *** Sinclair_ has joined #bitcoin-core-dev
1212018-05-21T08:43:36  <bitcoin-git> [bitcoin] KaneoHunter opened pull request #13293: Fixed grammar issue. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13293
1222018-05-21T08:46:15  <bitcoin-git> [bitcoin] fanquake closed pull request #13293: Fixed grammar issue. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13293
1232018-05-21T08:50:54  *** laurentmt has quit IRC
1242018-05-21T08:58:06  *** tetsuo has joined #bitcoin-core-dev
1252018-05-21T09:11:41  *** Mozell76Hickle has joined #bitcoin-core-dev
1262018-05-21T09:17:17  *** setpill has quit IRC
1272018-05-21T09:17:50  *** glaksmono has quit IRC
1282018-05-21T09:18:38  *** setpill has joined #bitcoin-core-dev
1292018-05-21T09:30:55  *** tetsuo has quit IRC
1302018-05-21T09:46:57  *** mmgen has joined #bitcoin-core-dev
1312018-05-21T09:49:45  <mmgen> question for the devs: to get a complete wallet backup with all historical transactions is it enough to back up wallet.dat, or must the database dir be backed up too?
1322018-05-21T09:50:02  *** glaksmono has joined #bitcoin-core-dev
1332018-05-21T09:53:39  <luke-jr> mmgen: the recommended way is to use the backupwallet RPC (or GUI equivalent)
1342018-05-21T09:53:46  <luke-jr> but if you must copy the data manually, you need both
1352018-05-21T09:54:07  <luke-jr> and from the same instant.. which may not be easy to get reliably
1362018-05-21T09:54:27  <mmgen> luke-jr: however, backupwallet just makes a copy of wallet.dat, nothing more
1372018-05-21T09:54:56  <mmgen> luke-jr: it doesn't copy the database directory, as far as I know
1382018-05-21T09:55:28  <luke-jr> mmgen: it closes the database first, and makes a copy with it closed
1392018-05-21T09:55:38  *** glaksmono has quit IRC
1402018-05-21T09:55:50  <mmgen> luke-jr: so the wallet.dat it produces is a complete backup that contains all the history?
1412018-05-21T09:56:07  <luke-jr> right
1422018-05-21T09:56:23  <mmgen> luke-jr: ok, that's what I neede to know.  Thanks!
1432018-05-21T09:58:00  *** vicenteH has joined #bitcoin-core-dev
1442018-05-21T09:58:52  *** promag has joined #bitcoin-core-dev
1452018-05-21T10:04:07  <mmgen> Just something I noticed: I'm running bitcoind with --connect=0, yet I'm getting error messages "Potential stale tip detected, will try using extra outbound peer".  Sort of silly, considering the daemon is running offline.
1462018-05-21T10:14:25  *** Ishtv4n has quit IRC
1472018-05-21T10:18:43  *** BashCo has joined #bitcoin-core-dev
1482018-05-21T10:28:41  *** promag has quit IRC
1492018-05-21T10:28:55  *** promag has joined #bitcoin-core-dev
1502018-05-21T10:36:34  *** ExtraCrispy has joined #bitcoin-core-dev
1512018-05-21T10:38:45  *** Ishtv4n has joined #bitcoin-core-dev
1522018-05-21T11:09:49  *** Emcy has joined #bitcoin-core-dev
1532018-05-21T11:09:56  *** Emcy has quit IRC
1542018-05-21T11:09:56  *** Emcy has joined #bitcoin-core-dev
1552018-05-21T11:11:32  *** ccdle12 has joined #bitcoin-core-dev
1562018-05-21T11:16:38  *** glaksmono has joined #bitcoin-core-dev
1572018-05-21T11:18:21  *** glaksmono has quit IRC
1582018-05-21T11:18:49  *** glaksmono has joined #bitcoin-core-dev
1592018-05-21T11:21:07  *** SopaXorzTaker has quit IRC
1602018-05-21T11:22:57  *** glaksmono has quit IRC
1612018-05-21T11:28:11  *** AaronvanW has joined #bitcoin-core-dev
1622018-05-21T11:29:18  *** muheet has joined #bitcoin-core-dev
1632018-05-21T11:30:29  *** rex4539 has joined #bitcoin-core-dev
1642018-05-21T11:51:29  *** BashCo has quit IRC
1652018-05-21T11:52:19  *** Emcy has quit IRC
1662018-05-21T12:00:57  *** DougieBot5000 has quit IRC
1672018-05-21T12:01:27  *** DougieBot5000 has joined #bitcoin-core-dev
1682018-05-21T12:02:57  *** promag has quit IRC
1692018-05-21T12:04:23  *** glaksmono has joined #bitcoin-core-dev
1702018-05-21T12:05:58  <bitcoin-git> [bitcoin] practicalswift opened pull request #13294: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 (master...openbsd-warnings) https://github.com/bitcoin/bitcoin/pull/13294
1712018-05-21T12:08:35  *** glaksmono has quit IRC
1722018-05-21T12:11:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1732018-05-21T12:18:26  *** muheet has quit IRC
1742018-05-21T12:32:08  *** glaksmono has joined #bitcoin-core-dev
1752018-05-21T12:36:16  *** glaksmono has quit IRC
1762018-05-21T12:37:06  *** Chris_Stewart_5 has quit IRC
1772018-05-21T12:39:02  *** d9b4bef9 has quit IRC
1782018-05-21T12:39:56  *** owowo has quit IRC
1792018-05-21T12:40:07  *** d9b4bef9 has joined #bitcoin-core-dev
1802018-05-21T12:41:21  *** paracyst_ has quit IRC
1812018-05-21T12:41:49  *** rex4539 has quit IRC
1822018-05-21T12:44:37  *** rex4539 has joined #bitcoin-core-dev
1832018-05-21T12:45:32  *** paracyst has joined #bitcoin-core-dev
1842018-05-21T12:45:49  *** owowo has joined #bitcoin-core-dev
1852018-05-21T12:52:30  *** paracyst has quit IRC
1862018-05-21T12:53:02  *** paracyst has joined #bitcoin-core-dev
1872018-05-21T12:57:06  *** paracyst has quit IRC
1882018-05-21T12:57:38  *** paracyst has joined #bitcoin-core-dev
1892018-05-21T12:58:52  *** goofie has quit IRC
1902018-05-21T13:03:48  *** TheRec has quit IRC
1912018-05-21T13:06:55  *** SopaXorzTaker has joined #bitcoin-core-dev
1922018-05-21T13:24:46  *** TheRec has joined #bitcoin-core-dev
1932018-05-21T13:24:57  *** TheRec has joined #bitcoin-core-dev
1942018-05-21T13:29:09  <Emzy> Moin
1952018-05-21T13:31:58  *** goosie has joined #bitcoin-core-dev
1962018-05-21T13:37:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1972018-05-21T13:40:58  *** AaronvanW has quit IRC
1982018-05-21T13:41:33  *** AaronvanW has joined #bitcoin-core-dev
1992018-05-21T13:46:10  *** AaronvanW has quit IRC
2002018-05-21T13:56:48  *** glaksmono has joined #bitcoin-core-dev
2012018-05-21T14:00:23  *** nman999_ has joined #bitcoin-core-dev
2022018-05-21T14:05:00  *** AaronvanW has joined #bitcoin-core-dev
2032018-05-21T14:06:33  *** goofie has joined #bitcoin-core-dev
2042018-05-21T14:11:33  *** glaksmono has quit IRC
2052018-05-21T14:12:09  *** glaksmono has joined #bitcoin-core-dev
2062018-05-21T14:36:09  *** Ishtv4n has quit IRC
2072018-05-21T14:38:19  <jamesob> cfields: is there a good place for me to undef HAVE_THREAD_LOCAL based on our findings that it's unsuitable for use on __APPLE__ and (apparently) __WIN32__? Can do it in threadutil.cpp as before, but it seems like there'd be a better place
2082018-05-21T14:40:55  *** contrapumpkin has joined #bitcoin-core-dev
2092018-05-21T14:44:59  <bitcoin-git> [bitcoin] practicalswift opened pull request #13295: docs: Update OpenBSD build instructions for OpenBSD 6.3 (master...openbsd-6.3) https://github.com/bitcoin/bitcoin/pull/13295
2102018-05-21T14:48:22  *** glaksmono has quit IRC
2112018-05-21T14:56:43  *** glaksmono has joined #bitcoin-core-dev
2122018-05-21T14:59:52  <Chris_Stewart_5> Does the protocol allow for different hash types for each signature in a multisig script?
2132018-05-21T15:02:40  *** promag has joined #bitcoin-core-dev
2142018-05-21T15:05:31  *** glaksmono has quit IRC
2152018-05-21T15:07:23  *** Samdney has joined #bitcoin-core-dev
2162018-05-21T15:09:31  *** JackH has joined #bitcoin-core-dev
2172018-05-21T15:10:27  *** Giszmo has quit IRC
2182018-05-21T15:12:32  *** nman999_ has quit IRC
2192018-05-21T15:12:56  *** zarez has quit IRC
2202018-05-21T15:13:34  *** Giszmo has joined #bitcoin-core-dev
2212018-05-21T15:15:22  *** Ishtv4n has joined #bitcoin-core-dev
2222018-05-21T15:18:09  *** glaksmono has joined #bitcoin-core-dev
2232018-05-21T15:31:13  *** glaksmono has quit IRC
2242018-05-21T15:35:13  *** glaksmono has joined #bitcoin-core-dev
2252018-05-21T15:37:16  <ryanofsky> jamesob, maybe just modify the autoconf test program to check for the behavior you need: https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L712-L729. or you could disable for known bad compiler versions
2262018-05-21T15:39:48  *** glaksmono has quit IRC
2272018-05-21T15:39:50  *** nman999_ has joined #bitcoin-core-dev
2282018-05-21T15:40:48  *** Victorsueca has quit IRC
2292018-05-21T15:41:16  <jamesob> ryanofsky: I think for the time being we want to undef HAVE_THREAD_LOCAL for certain platforms even after that autoconf check - any idea of the appropriate place to do that?
2302018-05-21T15:41:44  *** satwo has joined #bitcoin-core-dev
2312018-05-21T15:42:01  *** Victorsueca has joined #bitcoin-core-dev
2322018-05-21T15:42:44  *** Mozell76Hickle has quit IRC
2332018-05-21T15:42:47  <jimpo> kallewoof: You around by any chance?
2342018-05-21T15:51:43  *** Guyver2 has quit IRC
2352018-05-21T15:56:16  *** satwo has quit IRC
2362018-05-21T15:58:58  *** glaksmono has joined #bitcoin-core-dev
2372018-05-21T15:59:00  *** nman999_ has quit IRC
2382018-05-21T15:59:30  *** contrapumpkin has quit IRC
2392018-05-21T16:02:21  *** Giszmo has quit IRC
2402018-05-21T16:02:46  *** satwo has joined #bitcoin-core-dev
2412018-05-21T16:03:26  *** glaksmono has quit IRC
2422018-05-21T16:04:41  *** glaksmono has joined #bitcoin-core-dev
2432018-05-21T16:09:30  *** glaksmono has quit IRC
2442018-05-21T16:09:39  *** SopaXorzTaker has quit IRC
2452018-05-21T16:10:19  *** Giszmo has joined #bitcoin-core-dev
2462018-05-21T16:14:33  *** satwo has quit IRC
2472018-05-21T16:18:09  *** Giszmo has quit IRC
2482018-05-21T16:18:56  *** satwo has joined #bitcoin-core-dev
2492018-05-21T16:22:16  *** Giszmo has joined #bitcoin-core-dev
2502018-05-21T16:30:15  *** Randolf has quit IRC
2512018-05-21T16:30:54  *** Chris_Stewart_5 has quit IRC
2522018-05-21T16:31:39  *** Randolf has joined #bitcoin-core-dev
2532018-05-21T16:36:51  *** satwo has quit IRC
2542018-05-21T16:38:38  *** Deshawn17Jacobi has joined #bitcoin-core-dev
2552018-05-21T16:43:08  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6738813bcbb7...092b36688142
2562018-05-21T16:43:08  <bitcoin-git> bitcoin/master 4138f42 Ben Woosley: Revert "Merge #12870: make clean removes src/qt/moc_ files"...
2572018-05-21T16:43:09  <bitcoin-git> bitcoin/master 092b366 MarcoFalke: Merge #13254: Remove improper qt/moc_* cleaning glob from the general Makefile...
2582018-05-21T16:43:55  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13254: Remove improper qt/moc_* cleaning glob from the general Makefile (master...make-clean-qt-moc) https://github.com/bitcoin/bitcoin/pull/13254
2592018-05-21T16:46:25  *** Emcy has joined #bitcoin-core-dev
2602018-05-21T16:50:09  *** Giszmo has quit IRC
2612018-05-21T16:54:15  *** ccdle12 has quit IRC
2622018-05-21T16:57:40  *** Giszmo has joined #bitcoin-core-dev
2632018-05-21T16:59:28  <bitcoin-git> [bitcoin] jnewbery opened pull request #13297: [wallet] Fix incorrect comment for DeriveNewSeed. (master...derive_hd_seed_comment) https://github.com/bitcoin/bitcoin/pull/13297
2642018-05-21T17:00:59  *** promag has quit IRC
2652018-05-21T17:11:48  *** Samdney has quit IRC
2662018-05-21T17:14:10  *** LeMiner has quit IRC
2672018-05-21T17:17:45  <cfields> jamesob: maybe just exclude those OSs from the configure check?
2682018-05-21T17:18:02  <cfields> heh yes, what ryanofsky said :)
2692018-05-21T17:18:49  <cfields> jamesob: do you have a link to the busted mingw results? I'm curious to see the details
2702018-05-21T17:19:17  <jamesob> cfields: https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605
2712018-05-21T17:20:32  <cfields> thanks, looking
2722018-05-21T17:22:33  *** glaksmono has joined #bitcoin-core-dev
2732018-05-21T17:23:29  *** drexl has joined #bitcoin-core-dev
2742018-05-21T17:25:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2752018-05-21T17:25:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/092b36688142...d82c5d15c504
2762018-05-21T17:26:00  <bitcoin-git> bitcoin/master be87c6f John Newbery: [wallet] Fix incorrect comment for DeriveNewSeed.
2772018-05-21T17:26:00  <bitcoin-git> bitcoin/master d82c5d1 MarcoFalke: Merge #13297: [wallet] Fix incorrect comment for DeriveNewSeed....
2782018-05-21T17:26:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13297: [wallet] Fix incorrect comment for DeriveNewSeed. (master...derive_hd_seed_comment) https://github.com/bitcoin/bitcoin/pull/13297
2792018-05-21T17:26:52  *** glaksmono has quit IRC
2802018-05-21T17:42:44  <cfields> jamesob: confirmed, but i'm not sure if it's a mingw problem or a Wine one
2812018-05-21T17:42:52  *** timothy has quit IRC
2822018-05-21T17:43:14  <jamesob> cfields: yeah, good point. we'd need a native Windows platform to figure that one out, right?
2832018-05-21T17:43:16  <cfields> I guess realistically, those are the same thing for us, as a Wine bug would keep us from testing entirely
2842018-05-21T17:43:29  <cfields> jamesob: right
2852018-05-21T17:43:35  *** vicenteH has quit IRC
2862018-05-21T17:43:45  *** nman999_ has joined #bitcoin-core-dev
2872018-05-21T17:44:13  <cfields> bug was reported here, don't know if it was ever fixed: https://sourceforge.net/p/mingw-w64/bugs/445/
2882018-05-21T17:46:01  *** satwo has joined #bitcoin-core-dev
2892018-05-21T17:46:29  *** laurentmt has joined #bitcoin-core-dev
2902018-05-21T17:46:31  <cfields> jamesob: for platforms where we're enabling thread_local, we should add a runtime sanity check for sure
2912018-05-21T17:47:55  <jamesob> cfields: what specifically are you thinking there?
2922018-05-21T17:48:10  *** nman999_ has quit IRC
2932018-05-21T17:48:21  <jamesob> something more in the AC_LINK_IFELSE program?
2942018-05-21T17:48:28  <cfields> jamesob: see compat/glibc_sanity.cpp as an example. Imo we need compat/thread_local_sanity.cpp too
2952018-05-21T17:48:50  <cfields> jamesob: no, something that's actually executed by bitcoind as a quick runtime check
2962018-05-21T17:50:30  <jamesob> the testcase I wrote results in a stackoverflow though - is there a way to safely include something like that at runtime?
2972018-05-21T17:50:43  <cfields> basically, if it compiles and links ok, there's still a chance something's busted. We need to be able to catch the mingw failure and refuse to run, even if we didn't know that it was busted
2982018-05-21T17:51:03  <cfields> jamesob: see the link above. seems to give predictable-ish results
2992018-05-21T17:51:38  <ken2812221> jamesob: I test your code on Ubuntu 18.04, it seems not an issue anymore.
3002018-05-21T17:52:15  <ken2812221> I test it on native Windows and wine3.0
3012018-05-21T17:55:47  <pierre_rochard> I’ve written a blog post for the 1.0 release of BitcoinACKs.com and would really appreciate any and all feedback before I publish it: https://gist.github.com/PierreRochard/dad65528025cfac21bc5521ef7e629ac
3022018-05-21T17:56:03  <jamesob> ken2812221: interesting. thanks for testing.
3032018-05-21T17:56:20  *** promag has joined #bitcoin-core-dev
3042018-05-21T17:56:42  <pierre_rochard> Additionally, if you would like to provide a short blurb quote explaining why you find the site useful, that would be appreciated!
3052018-05-21T17:58:42  *** glaksmono has joined #bitcoin-core-dev
3062018-05-21T18:01:15  <Chris_Stewart_5> pierre_rochard: Very cool
3072018-05-21T18:02:37  <Chris_Stewart_5> pierre_rochard: Are you going to add that blurb to a help menu on the site?
3082018-05-21T18:02:57  *** glaksmono has quit IRC
3092018-05-21T18:04:27  <pierre_rochard> @chris_stewart_5 thanks! I was going to append blurbs to the blog post itself, and publish it as an "About" tab on the acks website, as well as on medium / my own website
3102018-05-21T18:04:50  <jamesob> cfields: you're pretty confident that the bug described in that issue is the same one affecting us in the gist?
3112018-05-21T18:06:20  *** AaronvanW has quit IRC
3122018-05-21T18:10:18  <cfields> jamesob: not sure, no. An issue either way, though
3132018-05-21T18:14:09  *** cryptojanitor has joined #bitcoin-core-dev
3142018-05-21T18:30:13  *** laurentmt has quit IRC
3152018-05-21T18:31:47  *** BullShark has quit IRC
3162018-05-21T18:33:10  *** Randolf has quit IRC
3172018-05-21T18:34:02  *** Randolf has joined #bitcoin-core-dev
3182018-05-21T18:35:13  *** opdenkamp has quit IRC
3192018-05-21T18:37:30  *** goosie has quit IRC
3202018-05-21T18:40:46  *** muheet has joined #bitcoin-core-dev
3212018-05-21T18:45:08  *** muheet has quit IRC
3222018-05-21T18:53:18  *** glaksmono has joined #bitcoin-core-dev
3232018-05-21T18:54:25  *** promag has quit IRC
3242018-05-21T18:57:06  *** str4d has joined #bitcoin-core-dev
3252018-05-21T18:57:42  *** glaksmono has quit IRC
3262018-05-21T19:04:15  <bitcoin-git> [bitcoin] naumenkogs opened pull request #13298: Net: Random delays *per network group* to obfuscate transaction time (master...delay_per_net_group) https://github.com/bitcoin/bitcoin/pull/13298
3272018-05-21T19:04:40  *** glaksmono has joined #bitcoin-core-dev
3282018-05-21T19:06:05  *** Ishtv4n has quit IRC
3292018-05-21T19:08:40  *** promag has joined #bitcoin-core-dev
3302018-05-21T19:08:57  *** glaksmono has quit IRC
3312018-05-21T19:15:46  *** glaksmono has joined #bitcoin-core-dev
3322018-05-21T19:20:15  *** glaksmono has quit IRC
3332018-05-21T19:21:46  *** opdenkamp has joined #bitcoin-core-dev
3342018-05-21T19:23:20  *** promag has quit IRC
3352018-05-21T19:31:02  *** Randolf has quit IRC
3362018-05-21T19:31:45  *** nman999_ has joined #bitcoin-core-dev
3372018-05-21T19:33:18  *** promag has joined #bitcoin-core-dev
3382018-05-21T19:35:31  *** nman999_ has quit IRC
3392018-05-21T19:45:58  *** MisterPaz has joined #bitcoin-core-dev
3402018-05-21T19:47:15  *** promag has quit IRC
3412018-05-21T19:49:18  *** glaksmono has joined #bitcoin-core-dev
3422018-05-21T19:49:47  *** MrPaz has quit IRC
3432018-05-21T19:49:58  *** promag has joined #bitcoin-core-dev
3442018-05-21T19:53:54  *** glaksmono has quit IRC
3452018-05-21T19:59:05  *** promag has quit IRC
3462018-05-21T20:02:11  *** LeMiner has joined #bitcoin-core-dev
3472018-05-21T20:02:51  *** Sinclair_ has quit IRC
3482018-05-21T20:04:52  *** Sinclair_ has joined #bitcoin-core-dev
3492018-05-21T20:05:44  *** Krellan has joined #bitcoin-core-dev
3502018-05-21T20:09:41  *** promag has joined #bitcoin-core-dev
3512018-05-21T20:13:44  *** promag has quit IRC
3522018-05-21T20:15:33  <skeees> anyone here looking at / spending time reviewing the latest dandelion proposal (either bip or code)?
3532018-05-21T20:17:13  *** glaksmono has joined #bitcoin-core-dev
3542018-05-21T20:21:27  *** glaksmono has quit IRC
3552018-05-21T20:31:47  <sipa> skeees: yup
3562018-05-21T20:32:40  <bitcoin-git> [bitcoin] jamesob closed pull request #13200: Process logs in a separate thread (master...2018-05-asynclog) https://github.com/bitcoin/bitcoin/pull/13200
3572018-05-21T20:33:45  <sipa> i was planning to go through it
3582018-05-21T20:57:09  *** honeybadgerdgaf has joined #bitcoin-core-dev
3592018-05-21T21:00:25  *** mmgen has quit IRC
3602018-05-21T21:02:24  *** Victorsueca has quit IRC
3612018-05-21T21:03:42  *** Victorsueca has joined #bitcoin-core-dev
3622018-05-21T21:03:55  *** cryptojanitor has quit IRC
3632018-05-21T21:06:22  *** jimpo has quit IRC
3642018-05-21T21:10:31  *** glaksmono has joined #bitcoin-core-dev
3652018-05-21T21:14:41  *** glaksmono has quit IRC
3662018-05-21T21:19:52  <Varunram> Is anyone else having this bug on macOS? bitcoind starts fine but I can't seem to query it using bitcoin-cli
3672018-05-21T21:19:58  *** promag has joined #bitcoin-core-dev
3682018-05-21T21:20:10  <Varunram> I'm on regtest and on commit d792e47421fcb9ce3b381c1e6d8902777ae3f9f3 for ref.
3692018-05-21T21:20:36  *** Giszmo has quit IRC
3702018-05-21T21:22:11  <sipa> define "can't seem to query it" ?
3712018-05-21T21:22:48  <sipa> what do you do, what do you see, what do you expect to see
3722018-05-21T21:22:51  <Varunram> sorry, should've been clearer: `Could not connect to the server 127.0.0.1:8332`
3732018-05-21T21:23:16  <sipa> are you sure bitcoind is running?
3742018-05-21T21:23:31  <Varunram> yep
3752018-05-21T21:23:43  <Varunram> btw, why is it trying to connect on that port?
3762018-05-21T21:23:50  <Varunram> it should be 18443 right?
3772018-05-21T21:24:01  <sipa> ah
3782018-05-21T21:24:10  <sipa> are you passing -regtest to bitcoin-cli?
3792018-05-21T21:24:33  <Varunram> oh my
3802018-05-21T21:24:49  <sipa> :)
3812018-05-21T21:24:57  <Varunram> was this added in 0.16? I can pretty much be sure I didn't do this in 0.15
3822018-05-21T21:25:50  *** str4d has quit IRC
3832018-05-21T21:25:50  <sipa> there is no way bitcoin-cli can know you're trying to connect to regtest without it
3842018-05-21T21:25:53  <sipa> ever
3852018-05-21T21:26:10  <Varunram> oh, ok. I guess i'd have had it in the conf then
3862018-05-21T21:26:21  <Varunram> thanks!
3872018-05-21T21:26:22  <sipa> that's possible
3882018-05-21T21:26:55  *** LeMiner has quit IRC
3892018-05-21T21:37:10  *** promag has quit IRC
3902018-05-21T21:40:20  *** glaksmono has joined #bitcoin-core-dev
3912018-05-21T21:40:23  *** rex4539 has quit IRC
3922018-05-21T21:41:06  *** Giszmo has joined #bitcoin-core-dev
3932018-05-21T21:44:46  *** glaksmono has quit IRC
3942018-05-21T21:48:28  *** honeybadgerdgaf has quit IRC
3952018-05-21T21:50:20  *** honeybadgerdgaf has joined #bitcoin-core-dev
3962018-05-21T21:50:20  *** Giszmo has quit IRC
3972018-05-21T21:53:35  *** Giszmo has joined #bitcoin-core-dev
3982018-05-21T21:54:59  *** Giszmo has quit IRC
3992018-05-21T22:01:48  *** Giszmo has joined #bitcoin-core-dev
4002018-05-21T22:03:14  *** Giszmo has quit IRC
4012018-05-21T22:05:37  *** Giszmo has joined #bitcoin-core-dev
4022018-05-21T22:08:32  *** Giszmo has quit IRC
4032018-05-21T22:09:32  *** cryptapus has quit IRC
4042018-05-21T22:14:34  *** cryptapus has joined #bitcoin-core-dev
4052018-05-21T22:14:34  *** cryptapus has quit IRC
4062018-05-21T22:14:34  *** cryptapus has joined #bitcoin-core-dev
4072018-05-21T22:21:54  *** glaksmono has joined #bitcoin-core-dev
4082018-05-21T22:22:09  *** Giszmo has joined #bitcoin-core-dev
4092018-05-21T22:23:33  *** Giszmo has quit IRC
4102018-05-21T22:24:40  *** Giszmo has joined #bitcoin-core-dev
4112018-05-21T22:26:04  *** Giszmo has quit IRC
4122018-05-21T22:26:30  *** glaksmono has quit IRC
4132018-05-21T22:27:01  *** Giszmo has joined #bitcoin-core-dev
4142018-05-21T22:28:25  *** Giszmo has quit IRC
4152018-05-21T22:29:50  *** Giszmo has joined #bitcoin-core-dev
4162018-05-21T22:31:02  *** honeybadgerdgaf has quit IRC
4172018-05-21T22:31:03  *** Giszmo has quit IRC
4182018-05-21T22:32:16  *** Giszmo has joined #bitcoin-core-dev
4192018-05-21T22:32:37  *** honeybadgerdgaf has joined #bitcoin-core-dev
4202018-05-21T22:33:46  *** honeybadgerdgaf has quit IRC
4212018-05-21T22:34:23  *** Giszmo has quit IRC
4222018-05-21T22:34:46  *** honeybadgerdgaf has joined #bitcoin-core-dev
4232018-05-21T22:42:52  *** promag has joined #bitcoin-core-dev
4242018-05-21T22:46:00  <satwo_> Hello all. Is the "witness_unknown" script type in Bitcoin Core essentially in place for backward compatibility in the event of a future soft fork adding a new witness script type (or increasing the version of an existing one)?
4252018-05-21T22:48:08  <sipa> yes
4262018-05-21T22:48:45  <sipa> because BIP173 defines an address type for future segwit versions, we need a way to parse and represent those
4272018-05-21T22:49:30  *** Randolf has joined #bitcoin-core-dev
4282018-05-21T22:53:34  <satwo> Ok, thanks sipa. Would it be possible for someone to manually construct such an address type right now that the parser represents as "witness_unknown"?
4292018-05-21T22:54:25  *** Randolf has quit IRC
4302018-05-21T22:55:05  *** Giszmo has joined #bitcoin-core-dev
4312018-05-21T22:57:33  *** jimpo has joined #bitcoin-core-dev
4322018-05-21T23:00:24  *** Randolf has joined #bitcoin-core-dev
4332018-05-21T23:01:07  <satwo> Not asking because I plan on doing so, but just want to make sure I understand things properly.
4342018-05-21T23:03:57  *** nman999_ has joined #bitcoin-core-dev
4352018-05-21T23:06:49  *** glaksmono has joined #bitcoin-core-dev
4362018-05-21T23:08:11  *** honeybadgerdgaf has quit IRC
4372018-05-21T23:08:29  *** glaksmono has quit IRC
4382018-05-21T23:08:43  *** glaksmono has joined #bitcoin-core-dev
4392018-05-21T23:09:57  *** honeybadgerdgaf has joined #bitcoin-core-dev
4402018-05-21T23:09:57  *** glaksmono has quit IRC
4412018-05-21T23:10:04  *** glaksmono has joined #bitcoin-core-dev
4422018-05-21T23:18:07  <luke-jr> satwo: yes, but it would be basically an anyone-can-spend and rejected by network policies
4432018-05-21T23:18:40  <sipa> satwo: creating such an address would be trivial, yes
4442018-05-21T23:19:19  <sipa> BIP173 even contains an example: bc1zw508d6qejxtdg4y5r3zarvaryvg6kdaj
4452018-05-21T23:24:01  <Chris_Stewart_5> Does anyone know how to compile bitcoin core when there is a name conflict for threading libraries on windows?
4462018-05-21T23:24:08  <satwo> Ah, that's what I was getting at, whether a tx with such an output could be relayed/mined at the present time. Thanks for the clarification gents.
4472018-05-21T23:24:12  <Chris_Stewart_5> what is the flag that needs to be set on ./configure ?
4482018-05-21T23:24:48  *** glaksmono has quit IRC
4492018-05-21T23:25:20  *** glaksmono has joined #bitcoin-core-dev
4502018-05-21T23:25:35  <luke-jr> Chris_Stewart_5: why would there be?
4512018-05-21T23:26:09  <Chris_Stewart_5> link to output: https://pastebin.com/ksnLcu3V
4522018-05-21T23:26:21  *** glaksmono has quit IRC
4532018-05-21T23:26:42  <Chris_Stewart_5> luke-jr: It's talked about in this foot note, but I'm not sure what flag needs to be set: https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md#footnotes
4542018-05-21T23:26:52  *** jimpo has quit IRC
4552018-05-21T23:30:03  *** Randolf has quit IRC
4562018-05-21T23:30:44  *** Nadav_Kohen has joined #bitcoin-core-dev
4572018-05-21T23:32:20  <luke-jr> odd
4582018-05-21T23:33:41  <sipa> Chris_Stewart_5: are you compiling _on_ windows or _for_ windows?
4592018-05-21T23:34:34  <Chris_Stewart_5> sipa: Using the "Windows subsystem for Linux" which I beleive is the former?
4602018-05-21T23:35:13  <sipa> the two footnotes there are specifically about issues when building on ubuntu for windows
4612018-05-21T23:35:18  <sipa> i doubt they apply to WSL
4622018-05-21T23:35:49  <sipa> ah, but WSL is derived from ubuntu?
4632018-05-21T23:36:02  *** jimpo has joined #bitcoin-core-dev
4642018-05-21T23:36:39  <Chris_Stewart_5> sipa: Possibly? I'm not 100% sure. Today is the first day of learning of this :-)
4652018-05-21T23:37:10  <Chris_Stewart_5> "The Windows Subsystem for Linux lets developers run Linux environments -- including most command-line tools, utilities, and applications -- directly on Windows, unmodified, without the overhead of a virtual machine. "
4662018-05-21T23:38:05  <sipa> i don't know either
4672018-05-21T23:40:44  <kallewoof> jimpo: Now I am :)
4682018-05-21T23:41:04  *** promag has quit IRC
4692018-05-21T23:43:27  *** honeybadgerdgaf has quit IRC
4702018-05-21T23:44:29  *** Randolf has joined #bitcoin-core-dev
4712018-05-21T23:50:12  *** Chris_Stewart_5 has quit IRC
4722018-05-21T23:52:17  *** Nadav_Kohen has quit IRC