12018-06-04T00:10:05  *** rfree_irc has quit IRC
  22018-06-04T00:10:05  *** marsadm has quit IRC
  32018-06-04T00:17:46  *** jcorgan has quit IRC
  42018-06-04T00:19:53  *** m8tion_ has joined #bitcoin-core-dev
  52018-06-04T00:23:05  *** m8tion has quit IRC
  62018-06-04T00:54:20  *** Aaronvan_ has joined #bitcoin-core-dev
  72018-06-04T00:57:05  *** AaronvanW has quit IRC
  82018-06-04T01:17:15  *** unholymachine has quit IRC
  92018-06-04T01:28:25  <bitcoin-git> [bitcoin] yuntai closed pull request #13365: RPC/REST/ZMQ, Wallet: Set label with importprivkey only requested (master...master) https://github.com/bitcoin/bitcoin/pull/13365
 102018-06-04T01:46:48  *** Randolf has joined #bitcoin-core-dev
 112018-06-04T01:52:56  *** meshcollider has quit IRC
 122018-06-04T01:54:35  *** Chris_Stewart_5 has quit IRC
 132018-06-04T02:08:47  *** Aaronvan_ has quit IRC
 142018-06-04T02:25:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 152018-06-04T02:34:43  *** ToURniQue has quit IRC
 162018-06-04T02:55:47  *** Emcy has quit IRC
 172018-06-04T02:58:28  <bitcoin-git> [bitcoin] qmma70 opened pull request #13388: util: Implement boolean conversion and !operator for uint_* (master...uint_bool) https://github.com/bitcoin/bitcoin/pull/13388
 182018-06-04T03:02:34  *** DrFeelGood has quit IRC
 192018-06-04T03:05:20  *** Chris_Stewart_5 has quit IRC
 202018-06-04T03:18:27  *** grubles has joined #bitcoin-core-dev
 212018-06-04T03:18:57  <mryandao> i actually asked about patch submission via mailing list in response to the takeover rumors.
 222018-06-04T03:34:36  *** abcjoe has joined #bitcoin-core-dev
 232018-06-04T04:24:40  *** qmma70 has quit IRC
 242018-06-04T04:39:06  *** jtimon has quit IRC
 252018-06-04T04:46:00  *** jtimon has joined #bitcoin-core-dev
 262018-06-04T05:25:30  <wumpus> mryandao: eek I understand now
 272018-06-04T05:30:05  <bitcoin-git> [bitcoin] n2yen opened pull request #13389: Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() (master...13371) https://github.com/bitcoin/bitcoin/pull/13389
 282018-06-04T05:36:29  <wumpus> mryandao: I don't think there's a hurry to get away from github, but I do think the microsoft takeover is the slow road to obsolence, just like sourceforge, until the service is finally put out of its misery (like happened with microsoft's other code hosting service, codeplex)
 292018-06-04T05:38:02  <wumpus> aanyhow maybe we should bring up the host-our-own-gitlab-instance topic again at next meeting
 302018-06-04T05:45:01  *** d9b4bef9 has quit IRC
 312018-06-04T05:46:11  *** d9b4bef9 has joined #bitcoin-core-dev
 322018-06-04T05:46:18  *** abcjoe has quit IRC
 332018-06-04T05:50:02  <wumpus> at the least I'm going to cancel my paid github membership as asoon as the announcement goes through, having to pay microsoft-tax with laptops is enough, not going to give them any more money...
 342018-06-04T05:53:43  <wumpus> (while I didn't mind supporting a smaller company that simply provides a, generally well-maintained, service)
 352018-06-04T05:58:23  *** justan0theruser has joined #bitcoin-core-dev
 362018-06-04T06:01:20  *** justanotheruser has quit IRC
 372018-06-04T06:03:27  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e24bf1ce184b...f0149330d2f8
 382018-06-04T06:03:27  <bitcoin-git> bitcoin/master 1e4eec4 steverusso: doc: split FreeBSD build instructions out of build-unix.md...
 392018-06-04T06:03:28  <bitcoin-git> bitcoin/master f014933 Wladimir J. van der Laan: Merge #13372: doc: split FreeBSD build instructions out of build-unix.md...
 402018-06-04T06:04:12  <bitcoin-git> [bitcoin] laanwj closed pull request #13372: doc: split FreeBSD build instructions out of build-unix.md (master...link-to-building-on-freebsd) https://github.com/bitcoin/bitcoin/pull/13372
 412018-06-04T06:41:06  *** lxer has joined #bitcoin-core-dev
 422018-06-04T06:47:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0149330d2f8...2722a1f8e935
 432018-06-04T06:47:41  <bitcoin-git> bitcoin/master f41d339 practicalswift: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)
 442018-06-04T06:47:42  <bitcoin-git> bitcoin/master 2722a1f Wladimir J. van der Laan: Merge #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)...
 452018-06-04T06:48:22  <bitcoin-git> [bitcoin] laanwj closed pull request #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...) (master...remove-dependency-on-lexical_cast-which-is-boost-and-also-throws) https://github.com/bitcoin/bitcoin/pull/13383
 462018-06-04T07:29:58  *** bitconner has joined #bitcoin-core-dev
 472018-06-04T07:30:46  *** Victorsueca has quit IRC
 482018-06-04T07:31:15  *** Victorsueca has joined #bitcoin-core-dev
 492018-06-04T07:32:12  *** setpill has joined #bitcoin-core-dev
 502018-06-04T07:41:08  *** Guest7379 has quit IRC
 512018-06-04T07:42:28  *** da2ce7 has joined #bitcoin-core-dev
 522018-06-04T07:51:05  *** Krellan has quit IRC
 532018-06-04T07:57:54  <jonasschnelli> roasbeef: what is the reason for using the version byte twice? Once in the enciphered payload and once prepended in plaintext: https://github.com/lightningnetwork/lnd/blob/master/aezeed/cipherseed.go#L39
 542018-06-04T08:19:20  *** Randolf has quit IRC
 552018-06-04T08:20:19  *** Randolf has joined #bitcoin-core-dev
 562018-06-04T08:24:51  *** esotericnonsense has joined #bitcoin-core-dev
 572018-06-04T08:26:45  *** ProfMac has joined #bitcoin-core-dev
 582018-06-04T08:30:11  *** timothy has joined #bitcoin-core-dev
 592018-06-04T08:35:39  *** drizztbsd has joined #bitcoin-core-dev
 602018-06-04T08:35:51  *** timothy has quit IRC
 612018-06-04T08:54:27  *** vicenteH has joined #bitcoin-core-dev
 622018-06-04T08:56:37  *** booyah has quit IRC
 632018-06-04T08:57:47  *** booyah has joined #bitcoin-core-dev
 642018-06-04T09:00:42  *** Guyver2 has joined #bitcoin-core-dev
 652018-06-04T09:02:02  *** promag has joined #bitcoin-core-dev
 662018-06-04T09:35:02  *** rex4539_ has joined #bitcoin-core-dev
 672018-06-04T09:35:12  *** rex4539 has quit IRC
 682018-06-04T09:53:10  *** rex4539_ has quit IRC
 692018-06-04T09:59:01  *** d9b4bef9 has quit IRC
 702018-06-04T10:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
 712018-06-04T10:12:17  <bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/2722a1f8e935...0de7cc848e07
 722018-06-04T10:12:18  <bitcoin-git> bitcoin/master 0df0178 Pieter Wuille: Benchmark Merkle root computation
 732018-06-04T10:12:18  <bitcoin-git> bitcoin/master 57f3463 Pieter Wuille: Refactor SHA256 code
 742018-06-04T10:12:19  <bitcoin-git> bitcoin/master d0c9632 Pieter Wuille: Specialized double sha256 for 64 byte inputs
 752018-06-04T10:12:23  *** zhrek` has joined #bitcoin-core-dev
 762018-06-04T10:12:56  <bitcoin-git> [bitcoin] laanwj closed pull request #13191: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 (master...201709_dsha256_64) https://github.com/bitcoin/bitcoin/pull/13191
 772018-06-04T10:15:35  *** drgrid has joined #bitcoin-core-dev
 782018-06-04T10:15:59  *** sturles_ has joined #bitcoin-core-dev
 792018-06-04T10:15:59  *** sturles_ has joined #bitcoin-core-dev
 802018-06-04T10:16:17  *** asoltys_ has joined #bitcoin-core-dev
 812018-06-04T10:16:21  *** earlz_ has joined #bitcoin-core-dev
 822018-06-04T10:17:08  *** sturles has quit IRC
 832018-06-04T10:17:09  *** sturles_ is now known as sturles
 842018-06-04T10:17:11  *** bitbee_ has joined #bitcoin-core-dev
 852018-06-04T10:18:26  *** jimpo_ has joined #bitcoin-core-dev
 862018-06-04T10:19:14  *** atroxes_ has joined #bitcoin-core-dev
 872018-06-04T10:19:19  *** rev_strangehope_ has joined #bitcoin-core-dev
 882018-06-04T10:19:21  *** TD--Linux has joined #bitcoin-core-dev
 892018-06-04T10:19:39  *** Deadhandd has joined #bitcoin-core-dev
 902018-06-04T10:20:33  *** Deadhand has quit IRC
 912018-06-04T10:20:33  *** jimpo has quit IRC
 922018-06-04T10:20:33  *** spinza has quit IRC
 932018-06-04T10:20:33  *** bitbee has quit IRC
 942018-06-04T10:20:33  *** TheCharlatan has quit IRC
 952018-06-04T10:20:34  *** earlz has quit IRC
 962018-06-04T10:20:34  *** zhrek has quit IRC
 972018-06-04T10:20:34  *** atroxes has quit IRC
 982018-06-04T10:20:34  *** TD-Linux has quit IRC
 992018-06-04T10:20:34  *** asoltys has quit IRC
1002018-06-04T10:20:34  *** rev_strangehope has quit IRC
1012018-06-04T10:20:36  *** atroxes_ is now known as atroxes
1022018-06-04T10:23:35  *** owowo has quit IRC
1032018-06-04T10:24:10  *** Randolf has quit IRC
1042018-06-04T10:25:38  *** owowo has joined #bitcoin-core-dev
1052018-06-04T10:25:50  *** Randolf has joined #bitcoin-core-dev
1062018-06-04T10:26:05  *** bitconner has quit IRC
1072018-06-04T10:29:08  *** spinza has joined #bitcoin-core-dev
1082018-06-04T10:31:23  *** bitconner has joined #bitcoin-core-dev
1092018-06-04T10:31:35  *** AaronvanW has joined #bitcoin-core-dev
1102018-06-04T10:36:12  *** Aaronvan_ has joined #bitcoin-core-dev
1112018-06-04T10:36:25  *** bitconner has quit IRC
1122018-06-04T10:39:38  <promag> is `./test/functional/wallet_multiwallet.py --usecli` working in master?
1132018-06-04T10:39:53  *** AaronvanW has quit IRC
1142018-06-04T10:47:22  *** rafalcpp has joined #bitcoin-core-dev
1152018-06-04T10:49:06  <marcoagner> promag: it's running and passing in master here
1162018-06-04T10:50:30  <marcoagner> if that's what you're asking
1172018-06-04T10:57:50  <promag> ty
1182018-06-04T10:58:11  <wumpus> yep, all the tests are passing on master
1192018-06-04T10:58:12  <promag> is there a test cache?
1202018-06-04T10:58:49  <wumpus> what do you mean with a test cache?
1212018-06-04T11:00:16  <wumpus> I think the only cache used by the tests is a pre-generated blockchain and wallet
1222018-06-04T11:00:29  <promag> never mind, I'm trying make clean && make
1232018-06-04T11:08:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1242018-06-04T11:22:41  *** justan0theruser has quit IRC
1252018-06-04T11:26:28  <promag> make clean && ccache -C && make and the test above continues to fail :S
1262018-06-04T11:27:41  *** promag_ has joined #bitcoin-core-dev
1272018-06-04T11:27:42  *** promag has quit IRC
1282018-06-04T11:32:51  *** bitconner has joined #bitcoin-core-dev
1292018-06-04T11:37:40  *** bitconner has quit IRC
1302018-06-04T11:39:01  *** domble has quit IRC
1312018-06-04T11:40:45  *** drizztbsd is now known as timothy
1322018-06-04T11:44:58  <wumpus> promag_: with what problem?
1332018-06-04T11:45:36  *** promag_ is now known as promag
1342018-06-04T11:46:56  <promag> wumpus: https://pastebin.com/Ghy69Ud0
1352018-06-04T11:47:17  *** bitconner has joined #bitcoin-core-dev
1362018-06-04T11:52:10  *** bitconner has quit IRC
1372018-06-04T11:52:22  <wumpus> so it expects "Requested wallet does not exist or is not loaded" but it gets a CalledProcessError
1382018-06-04T11:53:12  <wumpus> "subprocess.CalledProcessError: Command '/Users/joao/Projects/bitcoin/src/bitcoin-cli' returned non-zero exit status 18."
1392018-06-04T11:53:48  <wumpus> code 18 is RPC_WALLET_NOT_FOUND
1402018-06-04T11:54:03  <wumpus> so that looks correct, I'm confused
1412018-06-04T11:55:32  *** promag has quit IRC
1422018-06-04T12:00:10  *** SopaXorzTaker has joined #bitcoin-core-dev
1432018-06-04T12:02:24  *** bitconner has joined #bitcoin-core-dev
1442018-06-04T12:06:05  *** str4d has quit IRC
1452018-06-04T12:06:57  *** bitconner has quit IRC
1462018-06-04T12:09:07  *** Chris_Stewart_5 has quit IRC
1472018-06-04T12:09:56  *** bitconner has joined #bitcoin-core-dev
1482018-06-04T12:14:42  *** bitconner has quit IRC
1492018-06-04T12:15:19  *** promag has joined #bitcoin-core-dev
1502018-06-04T12:25:17  *** bitconner has joined #bitcoin-core-dev
1512018-06-04T12:29:57  *** bitconner has quit IRC
1522018-06-04T12:33:39  <wumpus> promag: just tried to run that test separately here on master (ubuntu 16.04), no issues
1532018-06-04T12:34:52  *** goatpig has joined #bitcoin-core-dev
1542018-06-04T12:36:13  <wumpus> promag: not sure what is special about your environment that could trigger this
1552018-06-04T12:36:37  <promag> wumpus: thanks
1562018-06-04T12:36:56  <promag> wumpus: I too can't understand why
1572018-06-04T12:38:38  *** bitconner has joined #bitcoin-core-dev
1582018-06-04T12:39:03  <wumpus> you could try doing a completely new checkout, then if that passes, compare the difference
1592018-06-04T12:42:56  <wumpus> if even a new build from a clean tree doesn't pass, it would be extremely confusing
1602018-06-04T12:43:53  *** bitconner has quit IRC
1612018-06-04T12:43:54  <promag> right, I hate on this happens
1622018-06-04T12:43:59  <promag> *when
1632018-06-04T12:46:47  <wumpus> it's bad, but one level of badness below issues that reproduce on travis but not locally
1642018-06-04T12:53:32  *** bitconner has joined #bitcoin-core-dev
1652018-06-04T12:58:09  *** bitconner has quit IRC
1662018-06-04T13:01:16  *** bitconner has joined #bitcoin-core-dev
1672018-06-04T13:03:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1682018-06-04T13:09:27  *** bitconner has quit IRC
1692018-06-04T13:14:38  *** bitconner has joined #bitcoin-core-dev
1702018-06-04T13:19:59  *** bitconner has quit IRC
1712018-06-04T13:22:09  *** bitconner has joined #bitcoin-core-dev
1722018-06-04T13:23:26  *** btcdrak has joined #bitcoin-core-dev
1732018-06-04T13:25:04  <promag> wumpus: git clone, autogen, configure, make, test same error :|
1742018-06-04T13:25:51  <promag> Python 3.6.5
1752018-06-04T13:25:58  * wumpus eats his hat
1762018-06-04T13:26:02  *** kabaum has quit IRC
1772018-06-04T13:27:08  *** bitconner has quit IRC
1782018-06-04T13:27:46  <wumpus> promag: what OS?
1792018-06-04T13:28:09  *** bitconner has joined #bitcoin-core-dev
1802018-06-04T13:28:11  <promag> wumpus: macos 10.13.3
1812018-06-04T13:28:43  <wumpus> can't try that, but I see ubuntu 1804 has the same version of python, will try that
1822018-06-04T13:29:25  <promag> ok, ty
1832018-06-04T13:29:40  <promag> I'll be back in a bit
1842018-06-04T13:29:45  *** promag has quit IRC
1852018-06-04T13:32:35  *** bitconner has quit IRC
1862018-06-04T13:36:33  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13390: Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node (master...stop_node) https://github.com/bitcoin/bitcoin/pull/13390
1872018-06-04T13:41:01  *** kabaum has joined #bitcoin-core-dev
1882018-06-04T13:43:02  *** Aaronvan_ has quit IRC
1892018-06-04T13:43:23  *** bitconner has joined #bitcoin-core-dev
1902018-06-04T13:43:38  *** AaronvanW has joined #bitcoin-core-dev
1912018-06-04T13:43:43  <bitcoin-git> [bitcoin] practicalswift opened pull request #13391: Make tinyformat noexcept: Use default error handling (assert(0 && reason)) on incorrect format strings (master...non-throwing-tinyformat) https://github.com/bitcoin/bitcoin/pull/13391
1922018-06-04T13:46:19  *** intcat has quit IRC
1932018-06-04T13:47:57  *** AaronvanW has quit IRC
1942018-06-04T13:48:41  *** bitconner has quit IRC
1952018-06-04T13:48:52  *** intcat has joined #bitcoin-core-dev
1962018-06-04T13:49:23  *** promag has joined #bitcoin-core-dev
1972018-06-04T13:51:32  *** bitconner has joined #bitcoin-core-dev
1982018-06-04T13:55:57  *** bitconner has quit IRC
1992018-06-04T14:03:09  *** ap has joined #bitcoin-core-dev
2002018-06-04T14:03:31  *** ap is now known as Guest67224
2012018-06-04T14:04:02  *** bitconner has joined #bitcoin-core-dev
2022018-06-04T14:09:07  *** bitconner has quit IRC
2032018-06-04T14:10:00  *** rafalcpp has quit IRC
2042018-06-04T14:11:07  *** Emcy has joined #bitcoin-core-dev
2052018-06-04T14:11:39  *** rafalcpp has joined #bitcoin-core-dev
2062018-06-04T14:12:09  *** AaronvanW has joined #bitcoin-core-dev
2072018-06-04T14:13:12  <wumpus> pierre_rochard: for some reason, bitcoinacks is not counting my concept ACK here: https://github.com/bitcoin/bitcoin/pull/12136
2082018-06-04T14:14:44  <pierre_rochard> wumpus: I'm taking a look, it should've picked that up automatically
2092018-06-04T14:18:52  *** bitconner has joined #bitcoin-core-dev
2102018-06-04T14:21:03  <bitcoin-git> [bitcoin] practicalswift closed pull request #13391: Make tinyformat noexcept: Use default error handling (assert(0 && reason)) on incorrect format strings (master...non-throwing-tinyformat) https://github.com/bitcoin/bitcoin/pull/13391
2112018-06-04T14:24:20  *** bitconner has quit IRC
2122018-06-04T14:25:12  *** bitconner has joined #bitcoin-core-dev
2132018-06-04T14:26:25  *** pergaminho has joined #bitcoin-core-dev
2142018-06-04T14:28:01  *** d9b4bef9 has quit IRC
2152018-06-04T14:29:08  *** d9b4bef9 has joined #bitcoin-core-dev
2162018-06-04T14:29:22  <pierre_rochard> wumpus: fix is deployed https://bitcoinacks.com/?search=12136
2172018-06-04T14:29:52  <wumpus> pierre_rochard: thanks!
2182018-06-04T14:30:11  *** bitconner has quit IRC
2192018-06-04T14:31:23  *** AaronvanW has quit IRC
2202018-06-04T14:31:58  *** AaronvanW has joined #bitcoin-core-dev
2212018-06-04T14:32:50  *** bitconner has joined #bitcoin-core-dev
2222018-06-04T14:34:41  *** justanotheruser has joined #bitcoin-core-dev
2232018-06-04T14:36:37  *** AaronvanW has quit IRC
2242018-06-04T14:37:35  *** bitconner has quit IRC
2252018-06-04T14:40:22  *** AaronvanW has joined #bitcoin-core-dev
2262018-06-04T14:45:58  *** bitconner has joined #bitcoin-core-dev
2272018-06-04T14:46:15  *** jcorgan has joined #bitcoin-core-dev
2282018-06-04T14:47:10  <jnewbery> promag: seems like the bitcoin-cli stderr is not matching the expected string. See test_node.py L370. I suggest you put a breakpoint in there and see what cli_stderr is set to
2292018-06-04T14:50:21  <promag> jnewbery: will do
2302018-06-04T14:50:22  *** callonme10 has quit IRC
2312018-06-04T14:50:45  *** bitconner has quit IRC
2322018-06-04T14:56:52  *** drgrid has quit IRC
2332018-06-04T14:57:46  *** TheCharlatan has joined #bitcoin-core-dev
2342018-06-04T14:57:58  *** bitconner has joined #bitcoin-core-dev
2352018-06-04T14:59:16  *** pergaminho has quit IRC
2362018-06-04T15:04:10  *** bitconner has quit IRC
2372018-06-04T15:05:56  *** pergaminho has joined #bitcoin-core-dev
2382018-06-04T15:08:18  *** pergaminho has quit IRC
2392018-06-04T15:09:41  *** Victorsueca has quit IRC
2402018-06-04T15:09:54  <wumpus> promag: passed on ubuntu 18.04 with 3.6.5
2412018-06-04T15:09:59  <wumpus> +python
2422018-06-04T15:10:06  <promag> right
2432018-06-04T15:10:23  *** justanotheruser has quit IRC
2442018-06-04T15:10:54  *** Victorsueca has joined #bitcoin-core-dev
2452018-06-04T15:11:34  *** bitconner has joined #bitcoin-core-dev
2462018-06-04T15:12:50  *** jhfrontz has joined #bitcoin-core-dev
2472018-06-04T15:12:52  <wumpus> so yes makes sense to try to debug this issue locally, it's unlikely we're going to be able to reproduce it
2482018-06-04T15:13:38  <bitcoin-git> [bitcoin] practicalswift opened pull request #13392: util: Make strprintf noexcept. Improve error message on format string error. (master...strprintf-noexcept) https://github.com/bitcoin/bitcoin/pull/13392
2492018-06-04T15:17:05  *** bitconner has quit IRC
2502018-06-04T15:18:22  *** justanotheruser has joined #bitcoin-core-dev
2512018-06-04T15:18:32  <marcoagner> promag: got curious at lunch and successfully passed the test you're having issue on my other laptop (macos 10.13.4 with python 3.6.5)... no help, it seems.
2522018-06-04T15:20:13  <wumpus> promag: you don't happen to have a different version of bitcoind running that it, for some reason or bug, runs against?
2532018-06-04T15:20:25  *** bitconner has joined #bitcoin-core-dev
2542018-06-04T15:22:26  *** JackH has quit IRC
2552018-06-04T15:22:48  <jonasschnelli> roasbeef: what is the reason for using the version byte twice? Once in the enciphered payload and once prepended in plaintext: https://github.com/lightningnetwork/lnd/blob/master/aezeed/cipherseed.go#L39
2562018-06-04T15:23:18  <jonasschnelli> (sry, wanted to post that on #lightning-dev)
2572018-06-04T15:25:19  *** bitconner has quit IRC
2582018-06-04T15:28:27  *** bitconner has joined #bitcoin-core-dev
2592018-06-04T15:33:32  *** bitconner has quit IRC
2602018-06-04T15:34:53  *** ExtraCrispy has joined #bitcoin-core-dev
2612018-06-04T15:37:04  <promag> wumpus: jnewbery: marcoagner: fixed :|
2622018-06-04T15:37:14  <promag> export EVENT_NOKQUEUE=1
2632018-06-04T15:38:01  <promag> jnewbery: thanks for the tip
2642018-06-04T15:38:05  *** bitconner has joined #bitcoin-core-dev
2652018-06-04T15:38:16  <promag> so my stderr has `[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0`
2662018-06-04T15:42:35  *** bitconner has quit IRC
2672018-06-04T15:43:39  *** SopaXorzTaker has quit IRC
2682018-06-04T15:44:08  <wumpus> promag: whoa. GOod find. I'm surprised you get that warning only for that test thoug!
2692018-06-04T15:45:04  *** promag has quit IRC
2702018-06-04T15:45:38  *** bitconner has joined #bitcoin-core-dev
2712018-06-04T15:46:42  *** JRob has joined #bitcoin-core-dev
2722018-06-04T15:47:31  *** promag has joined #bitcoin-core-dev
2732018-06-04T15:48:43  *** Randolf has quit IRC
2742018-06-04T15:49:59  *** promag has quit IRC
2752018-06-04T15:50:27  *** bitconner has quit IRC
2762018-06-04T15:56:34  *** bitconner has joined #bitcoin-core-dev
2772018-06-04T16:01:47  *** bitconner has quit IRC
2782018-06-04T16:02:52  *** btcdrak has quit IRC
2792018-06-04T16:08:22  *** setpill has quit IRC
2802018-06-04T16:08:53  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13390: Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node (master...stop_node) https://github.com/bitcoin/bitcoin/pull/13390
2812018-06-04T16:10:28  *** bitconner has joined #bitcoin-core-dev
2822018-06-04T16:15:15  *** bitconner has quit IRC
2832018-06-04T16:19:26  <bitcoin-git> [bitcoin] ken2812221 reopened pull request #13390: Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node (master...stop_node) https://github.com/bitcoin/bitcoin/pull/13390
2842018-06-04T16:22:43  <cfields> wumpus: that's just libevent falling back to poll(), as kqueue was known-buggy for 1 or 2 major macOS releases.
2852018-06-04T16:24:17  *** rafalcpp has quit IRC
2862018-06-04T16:25:05  *** bitconner has joined #bitcoin-core-dev
2872018-06-04T16:31:02  *** Krellan has joined #bitcoin-core-dev
2882018-06-04T16:32:59  *** bitconner has quit IRC
2892018-06-04T16:33:06  <wumpus> cfields: we should probably make sure that that warning is silenced, at least for the tests
2902018-06-04T16:34:04  <cfields> wumpus: I believe it should be fed to the logger. Maybe we don't have the libevent log callbacks hooked up for the tests?
2912018-06-04T16:35:07  *** gribble has quit IRC
2922018-06-04T16:39:29  *** bitconner has joined #bitcoin-core-dev
2932018-06-04T16:39:51  <wumpus> cfields: we don't set up a logger at all in bitcoin-cli
2942018-06-04T16:40:05  <wumpus> cfields: (and this is in a --with-cli test)
2952018-06-04T16:40:15  <cfields> wumpus: ahh, I missed that this was with -cli!
2962018-06-04T16:40:58  <cfields> yep, that's the problem then. Need to event_set_log_callback() there.
2972018-06-04T16:42:10  *** Chris_Stewart_5 has quit IRC
2982018-06-04T16:43:57  *** bitconner has quit IRC
2992018-06-04T16:45:52  *** Randolf has joined #bitcoin-core-dev
3002018-06-04T16:47:41  *** gribble has joined #bitcoin-core-dev
3012018-06-04T16:48:42  *** timothy has quit IRC
3022018-06-04T16:49:47  *** bitconner has joined #bitcoin-core-dev
3032018-06-04T16:52:53  <wumpus> cfields: where to send the output though? or just drop it
3042018-06-04T16:53:36  <cfields> wumpus: iirc it makes a distinction between errors and warnings. For -cli I suppose we could just drop warnings?
3052018-06-04T16:54:44  *** bitconner has quit IRC
3062018-06-04T16:55:15  *** roidster has joined #bitcoin-core-dev
3072018-06-04T16:57:02  <echeveria> kind of feels like the extra transaction pool default should be slightly higher
3082018-06-04T16:57:23  <echeveria> I'm getting a lot of compact block value out of doubling it, without an enormous memory usage hit.
3092018-06-04T16:57:27  <wumpus> cfields: seems it indeed passes in a severity, so it's possible to distinguish. I think it's fine to drop warnings for bitcoin-cli.
3102018-06-04T16:58:15  <wumpus> cfields: though I'm happy this goes to stderr, not stdout, at least it won't corrupt the output!
3112018-06-04T16:58:36  *** lnostdal has quit IRC
3122018-06-04T16:58:48  <cfields> heh yes, that's nice
3132018-06-04T16:58:49  <wumpus> would be kind of messed-up for RPCs that only return a string, and suddenly it has some silly libevent warning in it
3142018-06-04T16:59:26  <cfields> wumpus: I'll PR a quick change to ignore warnings and abort on errors (as I assume it would do now anyway)
3152018-06-04T16:59:53  *** Krellan has quit IRC
3162018-06-04T17:00:28  *** bitconner has joined #bitcoin-core-dev
3172018-06-04T17:03:59  <wumpus> cfields: sgtm
3182018-06-04T17:04:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3192018-06-04T17:05:13  *** bitconner has quit IRC
3202018-06-04T17:07:57  *** bitconner has joined #bitcoin-core-dev
3212018-06-04T17:11:53  *** lnostdal has joined #bitcoin-core-dev
3222018-06-04T17:13:02  *** bitconner has quit IRC
3232018-06-04T17:15:51  *** Dizzle has joined #bitcoin-core-dev
3242018-06-04T17:18:49  <luke-jr> echeveria: comparing two nodes running at the same time?
3252018-06-04T17:18:55  <luke-jr> or different times?
3262018-06-04T17:19:17  *** bitconner has joined #bitcoin-core-dev
3272018-06-04T17:20:39  *** promag has joined #bitcoin-core-dev
3282018-06-04T17:23:55  *** bitconner has quit IRC
3292018-06-04T17:26:33  <echeveria> luke-jr: comparing two nods, but only visually looking at the logs for now.
3302018-06-04T17:27:24  <luke-jr> right, I just mean time the transactions/blocks were received (ie, comparing the same circumstances)
3312018-06-04T17:27:46  *** laurentmt has joined #bitcoin-core-dev
3322018-06-04T17:28:16  <luke-jr> echeveria: want to make a PR and I can throw it in Knots 0.16.1 to give it some more real-world exposure? ;)
3332018-06-04T17:30:31  *** laurentmt has quit IRC
3342018-06-04T17:30:51  *** promag has quit IRC
3352018-06-04T17:31:51  *** bitconner has joined #bitcoin-core-dev
3362018-06-04T17:54:58  *** marcoagner has quit IRC
3372018-06-04T18:03:01  *** vicenteH has quit IRC
3382018-06-04T18:04:28  *** SopaXorzTaker has joined #bitcoin-core-dev
3392018-06-04T18:06:53  *** m8tion_ has quit IRC
3402018-06-04T18:07:26  *** lnostdal has quit IRC
3412018-06-04T18:08:01  *** mistergold has joined #bitcoin-core-dev
3422018-06-04T18:20:24  *** lnostdal has joined #bitcoin-core-dev
3432018-06-04T18:22:01  *** d9b4bef9 has quit IRC
3442018-06-04T18:23:09  *** d9b4bef9 has joined #bitcoin-core-dev
3452018-06-04T18:25:51  *** marcoagner has joined #bitcoin-core-dev
3462018-06-04T18:28:45  *** SopaXorzTaker has quit IRC
3472018-06-04T18:29:14  *** SopaXorzTaker has joined #bitcoin-core-dev
3482018-06-04T18:33:19  <bitcoin-git> [bitcoin] sipa opened pull request #13393: Enable double-SHA256-for-64-byte code on 32-bit x86 (master...201806_dsha256_i386) https://github.com/bitcoin/bitcoin/pull/13393
3492018-06-04T18:36:19  <gmaxwell> sipa: I thought there was intel core stuff that had SSE4 but not 64-bit?
3502018-06-04T18:37:01  <sipa> gmaxwell: perhaps, let me check!
3512018-06-04T18:37:40  <gmaxwell> echeveria: if you felt board you could do a bit of code copying, and keep an extra cache of each size...
3522018-06-04T18:37:58  <echeveria> hm, yeah
3532018-06-04T18:38:07  <echeveria> can simulate misses
3542018-06-04T18:38:10  <sipa> gmaxwell: they were introduced in Penryn, which supports x86_64
3552018-06-04T18:38:22  <sipa> perhaps SSE4 was later 'backported' to 32-bit CPU lines, though
3562018-06-04T18:38:55  <gmaxwell> Also technically our SSE4 code before was SSSE3, I dunno if thats the case for the new stuff.
3572018-06-04T18:39:20  <gmaxwell> (and I do have a cpu here which is SSSE3 and not SSE4 and I did try our old SSE4 code on it)
3582018-06-04T18:40:22  <sipa> hmm, can you try the new code?
3592018-06-04T18:40:35  *** lnostdal has quit IRC
3602018-06-04T18:42:12  *** lnostdal has joined #bitcoin-core-dev
3612018-06-04T18:43:12  <luke-jr> hmm, I wonder if I should make a 32-bit chroot to test this on then
3622018-06-04T18:43:30  <luke-jr> SSSE3 does NOT work correctly on Haswell CPUs running in 32-bit mode
3632018-06-04T18:43:36  <luke-jr> even though the CPU claims to support it
3642018-06-04T18:43:56  <luke-jr> (possibly an ABI/alignment issue)
3652018-06-04T18:45:00  <luke-jr> but that's assuming the new code is still SSSE3 at all.. :P
3662018-06-04T18:49:40  *** earlz_ is now known as earlz
3672018-06-04T18:51:13  *** MagicZ has joined #bitcoin-core-dev
3682018-06-04T18:52:12  *** promag has joined #bitcoin-core-dev
3692018-06-04T18:59:18  <jonasschnelli> Before:
3702018-06-04T18:59:18  <jonasschnelli> SHA256, 5, 340, 3.79253, 0.00222458, 0.00224373, 0.00222941
3712018-06-04T18:59:26  <jonasschnelli> Current master:
3722018-06-04T18:59:26  <jonasschnelli> SHA256, 5, 340, 3.85136, 0.00224624, 0.00227539, 0.00226702
3732018-06-04T19:00:35  <sipa> jonasschnelli: use the Merkle branchmark or SHA256D64 benchmark
3742018-06-04T19:00:47  <jonasschnelli> SHA256D64_1024, 5, 7400, 3.54442, 9.52022e-05, 9.65184e-05, 9.57865e-05
3752018-06-04T19:00:53  <bitcoin-git> [bitcoin] theuni opened pull request #13394: cli: Ignore libevent warnings (master...cli-event) https://github.com/bitcoin/bitcoin/pull/13394
3762018-06-04T19:01:02  <sipa> the normal SHA256 isn't affected by #13191
3772018-06-04T19:01:05  *** drexl has joined #bitcoin-core-dev
3782018-06-04T19:01:06  <gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub
3792018-06-04T19:01:14  <jonasschnelli> sipa: Yes. Right. SSE4 was enabled before..
3802018-06-04T19:02:45  *** str4d has joined #bitcoin-core-dev
3812018-06-04T19:05:32  *** SopaXorzTaker has quit IRC
3822018-06-04T19:09:01  *** promag has quit IRC
3832018-06-04T19:15:24  *** TD--Linux is now known as TD-Linux
3842018-06-04T19:15:24  *** TD-Linux has joined #bitcoin-core-dev
3852018-06-04T19:15:45  <roasbeef> jonasschnelli: external version for how to decipher the thing in the first place, internal version tells wallet what scheme was used to derive the set of addrs
3862018-06-04T19:16:21  <jonasschnelli> roasbeef: I see. Thanks!
3872018-06-04T19:17:08  <gmaxwell> sipa: I can but it'll be a bit since that computer is in a box right now.
3882018-06-04T19:19:30  <gmaxwell> echeveria: At least a few weeks ago I was watching it and almost never seeing hits out of my ordinary sized extrapool... but that might have just been because it was a bit too small.
3892018-06-04T19:22:42  <echeveria> 2018-06-04 18:15:44.495322 Successfully reconstructed block 00000000000000000037acbd8ccb51a8f09222800eab38f30c89bbe48ade3925 with 1 txn prefilled, 2075 txn from mempool (incl at least 13 from extra pool) and 16 txn requested
3902018-06-04T19:22:56  <echeveria> 2018-06-04 18:06:29.634709 Successfully reconstructed block 0000000000000000000e62f80def774b415e812da4473cdb49f3ba56ea0f1865 with 1 txn prefilled, 343 txn from mempool (incl at least 11 from extra pool) and 332 txn requested
3912018-06-04T19:22:57  <echeveria> woof.
3922018-06-04T19:23:07  <gmaxwell> oh man, yea thats pretty good
3932018-06-04T19:23:57  <echeveria> yeah I'll collect some proper stats.
3942018-06-04T19:24:34  <echeveria> a lot of the time I'm getting complete reconstructions which is nice. the node is running on a core i3 box that's mega underpowered, intentionally to see how it'll run.
3952018-06-04T19:29:09  *** twistedline has quit IRC
3962018-06-04T19:31:35  <gmaxwell> sipa: should call for someone to try out 13386 on shani supporting intel, ... they only have it on some atom cpus.
3972018-06-04T19:32:10  <sipa> i know; Goldmont only
3982018-06-04T19:32:28  <gmaxwell> not that its that important but it would be interesting to see numbers.
3992018-06-04T19:32:56  <echeveria> I looked around a while ago and couldn't find anything easy to get my hands on with a goldmont chip
4002018-06-04T19:33:04  *** promag has joined #bitcoin-core-dev
4012018-06-04T19:33:15  <echeveria> works on my rizen 7 server though.
4022018-06-04T19:33:20  *** twistedline has joined #bitcoin-core-dev
4032018-06-04T19:34:07  <gmaxwell> I assume DO or some other hosting provider is using goldmonts in vpses.
4042018-06-04T19:34:33  <echeveria> they're larger x86 cores for DO and ScaleWay.
4052018-06-04T19:34:42  <gmaxwell> (since basically thats the target application for that chip, AFAICT)
4062018-06-04T19:35:03  <echeveria> ScaleWay has armv7 servers which is vaguely interesting, I run an edge router node on one of their ARM boxes.
4072018-06-04T19:40:18  *** promag has quit IRC
4082018-06-04T19:49:28  <luke-jr> what is the cpuinfo entry for shani?
4092018-06-04T19:50:57  <luke-jr> a: sha_ni
4102018-06-04T19:53:05  *** kabaum has quit IRC
4112018-06-04T19:55:05  *** MagicZ has quit IRC
4122018-06-04T19:56:21  <sipa> luke-jr: sha ?
4132018-06-04T19:57:22  <sipa> sha_ni, indeed
4142018-06-04T19:57:25  <sipa> on my Ryzen
4152018-06-04T19:59:37  *** vicenteH has joined #bitcoin-core-dev
4162018-06-04T20:02:45  *** opdenkamp has joined #bitcoin-core-dev
4172018-06-04T20:07:58  *** kabaum has joined #bitcoin-core-dev
4182018-06-04T20:18:41  *** Randolf has quit IRC
4192018-06-04T20:21:45  *** Randolf has joined #bitcoin-core-dev
4202018-06-04T20:25:24  *** promag has joined #bitcoin-core-dev
4212018-06-04T20:34:23  *** jhfrontz has quit IRC
4222018-06-04T20:46:10  *** Guyver2 has quit IRC
4232018-06-04T20:46:58  *** jhfrontz has joined #bitcoin-core-dev
4242018-06-04T21:21:08  *** bitconner has joined #bitcoin-core-dev
4252018-06-04T21:28:10  *** bitconner has quit IRC
4262018-06-04T21:30:02  *** nullptr| has quit IRC
4272018-06-04T21:32:10  *** str4d has quit IRC
4282018-06-04T21:36:53  *** nullptr| has joined #bitcoin-core-dev
4292018-06-04T21:44:10  *** lukedashjr has joined #bitcoin-core-dev
4302018-06-04T21:44:10  *** luke-jr has quit IRC
4312018-06-04T21:47:34  *** lukedashjr is now known as luke-jr
4322018-06-04T21:49:28  *** zautomata has joined #bitcoin-core-dev
4332018-06-04T21:50:23  *** zautomata has quit IRC
4342018-06-04T21:50:23  *** zautomata has joined #bitcoin-core-dev
4352018-06-04T21:54:52  <cfields> sipa: taking an optim from the intel sha2 whitepaper gives me a ~6% speedup on the SHA256D64_1024 bench, using sse4 (no avx2 here :( )
4362018-06-04T21:55:01  <cfields> paper: https://www.intel.com/content/dam/www/public/us/en/documents/white-papers/sha-256-implementations-paper.pdf
4372018-06-04T21:55:28  <cfields> changes: https://github.com/theuni/bitcoin/commits/sha2-avx1 (top two, very simple)
4382018-06-04T21:56:09  <cfields> I assume it would benefit the avx2 impl the same way, but can't test
4392018-06-04T21:56:36  <sipa> cfields: oh, nice
4402018-06-04T22:00:15  *** Randolf has quit IRC
4412018-06-04T22:03:07  *** Chris_Stewart_5 has quit IRC
4422018-06-04T22:03:53  <sipa> cfields: testing
4432018-06-04T22:05:58  <sipa> cfields: makes it slower for me
4442018-06-04T22:06:19  <sipa> 3.5% slower
4452018-06-04T22:07:31  <cfields> sipa: huh. Is that sse4, or did you merge it into avx2?
4462018-06-04T22:07:52  <sipa> i merged it into avx2
4472018-06-04T22:08:55  <cfields> sipa: is it slower for the sse4 path on your cpu too?
4482018-06-04T22:24:50  <sipa> cfields: 5% speedup for SSE4
4492018-06-04T22:24:57  <sipa> (when disabling AVX2 in both)
4502018-06-04T22:25:00  <sipa> so go for it
4512018-06-04T22:25:05  <cfields> ok, so I'm not crazy
4522018-06-04T22:35:35  *** jarthur has joined #bitcoin-core-dev
4532018-06-04T22:36:09  <jarthur> gmaxwell sipa sorry I haven't had a chance to play with trying the dual SHA-NI on Ryzen yet. Anyone else had a chance to try it yet?
4542018-06-04T22:44:53  *** Aaronvan_ has joined #bitcoin-core-dev
4552018-06-04T22:46:40  *** Megumiin has joined #bitcoin-core-dev
4562018-06-04T22:48:05  *** AaronvanW has quit IRC
4572018-06-04T22:50:16  *** bitconner has joined #bitcoin-core-dev
4582018-06-04T23:00:47  *** mistergold has quit IRC
4592018-06-04T23:01:01  *** ttes23 has joined #bitcoin-core-dev
4602018-06-04T23:03:37  *** qmma70 has joined #bitcoin-core-dev
4612018-06-04T23:08:05  *** ttes23 has quit IRC
4622018-06-04T23:09:37  *** Victorsueca has quit IRC
4632018-06-04T23:10:54  *** Victorsueca has joined #bitcoin-core-dev
4642018-06-04T23:10:57  *** lxer has quit IRC
4652018-06-04T23:13:52  <promag> #13111
4662018-06-04T23:13:54  <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
4672018-06-04T23:14:11  <promag> ^ awesome PR to review!..
4682018-06-04T23:17:50  <sipa> "coredevelopers do not want you to see this awesome trick!"
4692018-06-04T23:18:43  <promag> :P
4702018-06-04T23:19:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4712018-06-04T23:21:09  *** lxer has joined #bitcoin-core-dev
4722018-06-04T23:34:34  *** bitconner has quit IRC
4732018-06-04T23:35:27  *** jarthur has quit IRC
4742018-06-04T23:35:28  *** Dizzle has quit IRC
4752018-06-04T23:36:33  *** zautomata has quit IRC
4762018-06-04T23:37:22  *** bitconner has joined #bitcoin-core-dev
4772018-06-04T23:41:00  *** lxer has quit IRC
4782018-06-04T23:46:27  *** drexl has quit IRC
4792018-06-04T23:47:46  *** zautomata has joined #bitcoin-core-dev
4802018-06-04T23:50:39  *** zautomata has quit IRC
4812018-06-04T23:50:39  *** zautomata has joined #bitcoin-core-dev
4822018-06-04T23:50:46  *** vicenteH has quit IRC
4832018-06-04T23:51:37  *** Randolf has joined #bitcoin-core-dev