1 2018-06-06T00:05:12 *** nuke_bloodaxe has joined #bitcoin-core-dev
2 2018-06-06T00:06:25 *** BashCo has quit IRC
3 2018-06-06T00:06:44 *** BashCo has joined #bitcoin-core-dev
4 2018-06-06T00:08:30 *** DougieBot5000 has quit IRC
5 2018-06-06T00:08:53 *** BashCo_ has joined #bitcoin-core-dev
6 2018-06-06T00:08:58 *** DougieBot5000 has joined #bitcoin-core-dev
7 2018-06-06T00:09:57 *** Randolf has quit IRC
8 2018-06-06T00:10:08 *** jhfrontz has quit IRC
9 2018-06-06T00:10:35 *** BashCo has quit IRC
10 2018-06-06T00:10:45 *** Randolf has joined #bitcoin-core-dev
11 2018-06-06T00:11:03 *** Randolf has quit IRC
12 2018-06-06T00:12:23 *** Randolf has joined #bitcoin-core-dev
13 2018-06-06T00:16:41 *** jhfrontz has joined #bitcoin-core-dev
14 2018-06-06T00:18:38 *** jhfrontz has quit IRC
15 2018-06-06T00:19:44 *** Randolf has quit IRC
16 2018-06-06T00:20:33 *** dgenr8 has quit IRC
17 2018-06-06T00:21:17 *** Randolf has joined #bitcoin-core-dev
18 2018-06-06T00:21:45 *** dgenr8 has joined #bitcoin-core-dev
19 2018-06-06T00:22:58 *** jhfrontz has joined #bitcoin-core-dev
20 2018-06-06T00:27:05 *** dgenr8 has quit IRC
21 2018-06-06T00:28:26 *** jhfrontz has quit IRC
22 2018-06-06T00:28:26 *** dgenr8 has joined #bitcoin-core-dev
23 2018-06-06T00:28:43 *** dgenr8 has quit IRC
24 2018-06-06T00:31:19 *** dgenr8 has joined #bitcoin-core-dev
25 2018-06-06T00:31:31 *** dgenr8 has quit IRC
26 2018-06-06T00:40:01 *** d9b4bef9 has quit IRC
27 2018-06-06T00:43:07 *** d9b4bef9 has joined #bitcoin-core-dev
28 2018-06-06T00:47:27 *** jhfrontz has joined #bitcoin-core-dev
29 2018-06-06T00:51:13 *** jhfrontz has quit IRC
30 2018-06-06T00:57:34 *** jhfrontz has joined #bitcoin-core-dev
31 2018-06-06T00:58:15 *** harrymm has quit IRC
32 2018-06-06T00:59:40 *** jhfrontz has quit IRC
33 2018-06-06T00:59:46 *** BashCo_ has quit IRC
34 2018-06-06T01:00:00 *** jhfrontz has joined #bitcoin-core-dev
35 2018-06-06T01:00:56 *** manecosta has joined #bitcoin-core-dev
36 2018-06-06T01:08:33 *** grafcaps has quit IRC
37 2018-06-06T01:10:02 *** manecosta has quit IRC
38 2018-06-06T01:12:21 *** jhfrontz has quit IRC
39 2018-06-06T01:12:40 *** jhfrontz has joined #bitcoin-core-dev
40 2018-06-06T01:21:53 *** grafcaps has joined #bitcoin-core-dev
41 2018-06-06T01:23:02 *** AaronvanW has quit IRC
42 2018-06-06T01:23:20 *** BashCo has joined #bitcoin-core-dev
43 2018-06-06T01:24:16 *** jhfrontz has quit IRC
44 2018-06-06T01:27:42 *** Chris_Stewart_5 has quit IRC
45 2018-06-06T01:33:44 *** AaronvanW has joined #bitcoin-core-dev
46 2018-06-06T01:37:51 *** AaronvanW has quit IRC
47 2018-06-06T01:46:27 *** ovovo has quit IRC
48 2018-06-06T01:53:03 *** unholymachine has joined #bitcoin-core-dev
49 2018-06-06T01:54:27 *** bitconner has quit IRC
50 2018-06-06T02:00:45 *** nuke_bloodaxe has quit IRC
51 2018-06-06T02:01:42 *** nuke_bloodaxe has joined #bitcoin-core-dev
52 2018-06-06T02:01:50 *** unholymachine has quit IRC
53 2018-06-06T02:02:28 *** unholymachine has joined #bitcoin-core-dev
54 2018-06-06T02:11:00 *** goatpig has quit IRC
55 2018-06-06T02:35:40 *** unholymachine has joined #bitcoin-core-dev
56 2018-06-06T02:50:39 <MarcoFalke> FYI, I have assigned all non-mergeable open pulls to a new label "Needs rebase"
57 2018-06-06T02:50:47 <MarcoFalke> Makes it easier to sort
58 2018-06-06T02:50:50 <MarcoFalke> e.g. https://github.com/bitcoin/bitcoin/pulls?q=is%3Apr+is%3Aopen+label%3A%22Needs+rebase%22
59 2018-06-06T02:56:09 *** intcat has quit IRC
60 2018-06-06T02:57:18 *** intcat has joined #bitcoin-core-dev
61 2018-06-06T03:30:44 *** jhfrontz has joined #bitcoin-core-dev
62 2018-06-06T03:33:04 *** vicenteH has quit IRC
63 2018-06-06T03:33:49 *** satwo has joined #bitcoin-core-dev
64 2018-06-06T03:35:50 *** jhfrontz has quit IRC
65 2018-06-06T03:36:49 *** vicenteH has joined #bitcoin-core-dev
66 2018-06-06T03:45:09 *** satwo has quit IRC
67 2018-06-06T03:45:39 *** jhfrontz has joined #bitcoin-core-dev
68 2018-06-06T03:48:09 *** jhfrontz has quit IRC
69 2018-06-06T03:52:30 *** jhfrontz has joined #bitcoin-core-dev
70 2018-06-06T03:54:31 *** jhfrontz has quit IRC
71 2018-06-06T03:59:38 *** jhfrontz has joined #bitcoin-core-dev
72 2018-06-06T04:01:47 *** jhfrontz has quit IRC
73 2018-06-06T04:26:29 *** Krellan has joined #bitcoin-core-dev
74 2018-06-06T04:26:55 *** bitconner has joined #bitcoin-core-dev
75 2018-06-06T04:32:02 *** d9b4bef9 has quit IRC
76 2018-06-06T04:33:08 *** d9b4bef9 has joined #bitcoin-core-dev
77 2018-06-06T04:34:53 *** AaronvanW has joined #bitcoin-core-dev
78 2018-06-06T04:38:10 *** Emcy has quit IRC
79 2018-06-06T04:40:15 *** AaronvanW has quit IRC
80 2018-06-06T04:43:55 *** Krellan has quit IRC
81 2018-06-06T05:05:21 *** Randolf has quit IRC
82 2018-06-06T05:07:28 *** Randolf has joined #bitcoin-core-dev
83 2018-06-06T05:09:07 *** bitconne1 has joined #bitcoin-core-dev
84 2018-06-06T05:11:57 *** bitconner has quit IRC
85 2018-06-06T05:16:07 *** unholymachine has quit IRC
86 2018-06-06T05:23:56 *** grubles has quit IRC
87 2018-06-06T05:25:52 *** ProfMac has quit IRC
88 2018-06-06T05:25:59 *** ghost43 has quit IRC
89 2018-06-06T05:30:50 *** ghost43 has joined #bitcoin-core-dev
90 2018-06-06T05:32:30 *** ProfMac has joined #bitcoin-core-dev
91 2018-06-06T05:37:11 <bitcoin-git> [bitcoin] lucash-dev opened pull request #13404: [tests] speed up of tx_validationcache_tests by reusing of CTransaction. (master...speedup-tx_validationcache_tests) https://github.com/bitcoin/bitcoin/pull/13404
92 2018-06-06T05:46:02 *** Cory has quit IRC
93 2018-06-06T05:52:30 *** usualrise has joined #bitcoin-core-dev
94 2018-06-06T05:56:55 *** vicenteH has quit IRC
95 2018-06-06T05:58:43 *** vicenteH has joined #bitcoin-core-dev
96 2018-06-06T06:02:10 *** Rebo has joined #bitcoin-core-dev
97 2018-06-06T06:18:36 *** Soligor has quit IRC
98 2018-06-06T06:19:53 *** Rebo has quit IRC
99 2018-06-06T06:20:08 *** Soligor has joined #bitcoin-core-dev
100 2018-06-06T06:37:22 *** AaronvanW has joined #bitcoin-core-dev
101 2018-06-06T06:41:53 *** AaronvanW has quit IRC
102 2018-06-06T07:03:00 *** setpill has joined #bitcoin-core-dev
103 2018-06-06T07:55:39 *** timothy has joined #bitcoin-core-dev
104 2018-06-06T08:00:10 *** drizztbsd has joined #bitcoin-core-dev
105 2018-06-06T08:00:59 *** timothy has quit IRC
106 2018-06-06T08:02:58 *** Cory has joined #bitcoin-core-dev
107 2018-06-06T08:07:10 *** usualrise has quit IRC
108 2018-06-06T08:21:07 *** promag has joined #bitcoin-core-dev
109 2018-06-06T08:23:22 *** drizztbsd is now known as timothy
110 2018-06-06T08:33:19 <wumpus> MarcoFalke: I hope that happens automatically? otherwise, it sounds like a nightmare to keep it up to date
111 2018-06-06T08:33:56 <wumpus> MarcoFalke: also, it's already possible to use bitcoinacks.com to keep track of that
112 2018-06-06T08:54:16 *** laurentmt has joined #bitcoin-core-dev
113 2018-06-06T08:59:07 *** Guyver2 has joined #bitcoin-core-dev
114 2018-06-06T09:05:05 *** AaronvanW has joined #bitcoin-core-dev
115 2018-06-06T09:07:46 *** laurentmt has quit IRC
116 2018-06-06T09:09:52 *** AaronvanW has quit IRC
117 2018-06-06T10:00:15 *** rafalcpp has joined #bitcoin-core-dev
118 2018-06-06T10:25:07 *** ghost43 has quit IRC
119 2018-06-06T10:25:18 *** ghost43 has joined #bitcoin-core-dev
120 2018-06-06T10:26:50 *** AaronvanW has joined #bitcoin-core-dev
121 2018-06-06T10:32:14 *** Aaronvan_ has joined #bitcoin-core-dev
122 2018-06-06T10:35:43 *** AaronvanW has quit IRC
123 2018-06-06T10:42:33 *** Guyver2 has quit IRC
124 2018-06-06T11:06:40 *** Madars has quit IRC
125 2018-06-06T11:07:46 *** Madars has joined #bitcoin-core-dev
126 2018-06-06T11:10:06 *** Guyver2 has joined #bitcoin-core-dev
127 2018-06-06T11:19:08 *** Victorsueca has quit IRC
128 2018-06-06T11:20:36 *** Victorsueca has joined #bitcoin-core-dev
129 2018-06-06T11:30:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
130 2018-06-06T11:34:20 <wumpus> how are things with 0.16.0rc1? do we have anything that needs to be backported for rc2? I haven't heard any reports of bugs at least.
131 2018-06-06T11:35:31 <wumpus> if not, we should do a very fast rc2 for the translations issue and then tag final
132 2018-06-06T11:35:34 <wumpus> eh, 0.16.1 obvs
133 2018-06-06T11:57:04 *** SopaXorzTaker has joined #bitcoin-core-dev
134 2018-06-06T11:57:53 *** bitconne1 has quit IRC
135 2018-06-06T12:00:02 *** d9b4bef9 has quit IRC
136 2018-06-06T12:00:25 <bitcoin-git> [bitcoin] ken2812221 opened pull request #13406: travis: Add make step so that travis can build all executables for Mac. (master...travis_make_mac) https://github.com/bitcoin/bitcoin/pull/13406
137 2018-06-06T12:00:47 *** promag has quit IRC
138 2018-06-06T12:01:49 *** Aaronvan_ has quit IRC
139 2018-06-06T12:03:15 *** d9b4bef9 has joined #bitcoin-core-dev
140 2018-06-06T12:03:52 *** bitconner has joined #bitcoin-core-dev
141 2018-06-06T12:08:35 *** bitconner has quit IRC
142 2018-06-06T12:10:35 *** m8tion has joined #bitcoin-core-dev
143 2018-06-06T12:16:24 *** AaronvanW has joined #bitcoin-core-dev
144 2018-06-06T12:17:07 *** Aaronvan_ has joined #bitcoin-core-dev
145 2018-06-06T12:18:36 *** bitconner has joined #bitcoin-core-dev
146 2018-06-06T12:18:46 *** promag has joined #bitcoin-core-dev
147 2018-06-06T12:21:00 *** AaronvanW has quit IRC
148 2018-06-06T12:27:38 *** bitconner has quit IRC
149 2018-06-06T12:27:46 *** bitconner has joined #bitcoin-core-dev
150 2018-06-06T12:32:27 *** bitconner has quit IRC
151 2018-06-06T12:35:02 *** Chris_Stewart_5 has quit IRC
152 2018-06-06T12:36:03 *** bitconner has joined #bitcoin-core-dev
153 2018-06-06T12:39:23 *** owowo has joined #bitcoin-core-dev
154 2018-06-06T12:39:23 *** owowo has joined #bitcoin-core-dev
155 2018-06-06T12:41:10 *** bitconner has quit IRC
156 2018-06-06T12:43:39 *** bitconner has joined #bitcoin-core-dev
157 2018-06-06T12:46:21 *** promag has quit IRC
158 2018-06-06T12:48:27 *** bitconner has quit IRC
159 2018-06-06T13:18:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a589f536b5e1...e4082d59f53d
160 2018-06-06T13:18:56 <bitcoin-git> bitcoin/master 9d6c9db Ben Woosley: lint: Add linter to error on #include <*.cpp>...
161 2018-06-06T13:18:57 <bitcoin-git> bitcoin/master e4082d5 MarcoFalke: Merge #13301: lint: Add linter to error on #include <*.cpp>...
162 2018-06-06T13:19:50 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13301: lint: Add linter to error on #include <*.cpp> (master...lint-include-cpp) https://github.com/bitcoin/bitcoin/pull/13301
163 2018-06-06T13:30:57 *** Emcy has joined #bitcoin-core-dev
164 2018-06-06T13:33:03 *** jhfrontz has joined #bitcoin-core-dev
165 2018-06-06T13:37:36 *** promag has joined #bitcoin-core-dev
166 2018-06-06T13:55:13 *** AaronvanW has joined #bitcoin-core-dev
167 2018-06-06T13:59:14 *** Aaronvan_ has quit IRC
168 2018-06-06T14:08:18 *** grubles has joined #bitcoin-core-dev
169 2018-06-06T14:08:40 *** grafcaps has quit IRC
170 2018-06-06T14:15:51 <jamesob_> anyone willing to trade reviews for #13168?
171 2018-06-06T14:15:53 <gribble> https://github.com/bitcoin/bitcoin/issues/13168 | Thread names in logs and deadlock debug tools (take 2) by jamesob · Pull Request #13168 · bitcoin/bitcoin · GitHub
172 2018-06-06T14:16:07 *** jamesob_ is now known as jamesob
173 2018-06-06T14:25:24 *** ryanzim has joined #bitcoin-core-dev
174 2018-06-06T14:26:42 <ryanzim> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#p2wpkh says:
175 2018-06-06T14:26:44 <ryanzim> > The HASH160 of the pubkey in witness must match the witness program.
176 2018-06-06T14:27:34 <ryanzim> This seems to imply that the witness program is HASH160(pubkey), when it's actually HASH160(SHA256(pubkey))
177 2018-06-06T14:27:40 <ryanzim> Shouldn't this be clarified?
178 2018-06-06T14:31:06 <ryanzim> Ah, sorry; doing a little more research; seems I was confusing HASH160 and ripemd160; nvm
179 2018-06-06T14:33:07 *** ryanzim has quit IRC
180 2018-06-06T14:33:45 *** luke-jr has quit IRC
181 2018-06-06T14:34:50 *** Chris_Stewart_5 has joined #bitcoin-core-dev
182 2018-06-06T14:35:36 *** luke-jr has joined #bitcoin-core-dev
183 2018-06-06T14:37:31 *** maxkaplan has joined #bitcoin-core-dev
184 2018-06-06T14:55:48 *** goatpig has joined #bitcoin-core-dev
185 2018-06-06T14:57:02 *** maxkaplan has quit IRC
186 2018-06-06T14:58:30 *** qu4ku has joined #bitcoin-core-dev
187 2018-06-06T15:09:53 *** Emcy has quit IRC
188 2018-06-06T15:12:15 *** Emcy has joined #bitcoin-core-dev
189 2018-06-06T15:13:17 *** Sinclair6 has quit IRC
190 2018-06-06T15:20:31 *** grafcaps has joined #bitcoin-core-dev
191 2018-06-06T15:25:29 *** mistergold has joined #bitcoin-core-dev
192 2018-06-06T15:31:03 *** Emcy has quit IRC
193 2018-06-06T15:31:34 *** Emcy has joined #bitcoin-core-dev
194 2018-06-06T15:42:25 *** grafcaps has quit IRC
195 2018-06-06T15:49:07 <promag> Currently there is a DbEnv can reference multiple Db instances right?
196 2018-06-06T15:49:21 <promag> s/there is//
197 2018-06-06T15:50:46 *** Randolf has quit IRC
198 2018-06-06T15:52:31 <promag> Also, BerkeleyDatabase::Flush calls BerkeleyEnvironment::Flush, is there a reason to keep it like that?
199 2018-06-06T15:58:02 <promag> so that when unloading a wallet all wallets wouldn't have to be flushed
200 2018-06-06T15:59:41 *** grafcaps has joined #bitcoin-core-dev
201 2018-06-06T16:00:05 *** owowo has quit IRC
202 2018-06-06T16:01:35 <bitcoin-git> [bitcoin] eudisd closed pull request #13373: Qt: Update Wallet Encryption Titles To Better Describe Process (master...feature/bitcoin-#13245) https://github.com/bitcoin/bitcoin/pull/13373
203 2018-06-06T16:07:13 <promag> jnewbery: yes there is a couple of things to fix
204 2018-06-06T16:07:23 <promag> jnewbery: one is as follow
205 2018-06-06T16:07:41 <promag> bitcoind -regtest -debug -wallet=w1 -wallet=w2
206 2018-06-06T16:07:59 <promag> bitcoin-cli -regtest unloadwallet w1
207 2018-06-06T16:08:17 <promag> bitcoin-cli -regtest -rpcwallet=w2 getwalletinfo
208 2018-06-06T16:08:27 <promag> see above questions
209 2018-06-06T16:09:19 *** Dizzle has joined #bitcoin-core-dev
210 2018-06-06T16:11:56 *** Victorsueca has quit IRC
211 2018-06-06T16:13:06 *** Victorsueca has joined #bitcoin-core-dev
212 2018-06-06T16:16:07 *** setpill has quit IRC
213 2018-06-06T16:17:10 *** nmnkgl has joined #bitcoin-core-dev
214 2018-06-06T16:41:15 *** owowo has joined #bitcoin-core-dev
215 2018-06-06T16:41:15 *** owowo has joined #bitcoin-core-dev
216 2018-06-06T16:47:34 *** Randolf has joined #bitcoin-core-dev
217 2018-06-06T16:48:52 *** qu4ku has quit IRC
218 2018-06-06T16:55:12 <MarcoFalke> wumpus: I know it is on bitcoinacks.com, but I don't like the idea to switch back and forth between websites when you could have it all in one place
219 2018-06-06T16:55:30 <MarcoFalke> And yes, will be automated in the future
220 2018-06-06T16:56:14 <MarcoFalke> ACK on the quick rc2
221 2018-06-06T16:59:29 *** GoldenBear has joined #bitcoin-core-dev
222 2018-06-06T17:06:03 *** Dizzle has quit IRC
223 2018-06-06T17:12:38 *** pergaminho has joined #bitcoin-core-dev
224 2018-06-06T17:23:49 <bitcoin-git> [bitcoin] skeees opened pull request #13407: [refactor, move-only-ish] Refactor mempool accept/reject logic (master...atmp-p2p-refactor) https://github.com/bitcoin/bitcoin/pull/13407
225 2018-06-06T17:26:16 *** timothy has quit IRC
226 2018-06-06T17:31:33 <cfields> sipa: did you happen to bench sha2 with sse41 + avx?
227 2018-06-06T17:36:01 *** vicenteH has quit IRC
228 2018-06-06T17:37:59 <sipa> cfields: ah, forgot about that, good idea
229 2018-06-06T17:38:18 <sipa> cfields: feel like fixing the proliferation of various crypto libs in the makefile?
230 2018-06-06T17:38:44 <cfields> sipa: sure thing, will PR
231 2018-06-06T17:40:06 *** Rebo has joined #bitcoin-core-dev
232 2018-06-06T17:41:12 *** JackH has joined #bitcoin-core-dev
233 2018-06-06T17:43:42 *** m8tion has quit IRC
234 2018-06-06T17:47:07 *** Dizzle has joined #bitcoin-core-dev
235 2018-06-06T17:48:57 <sipa> cfields: sse41 2.9ms, sse41 (compiled with -mavx) 2.0ms, avx2 1.1ms
236 2018-06-06T17:49:05 <sipa> that's a very significant improvement...
237 2018-06-06T17:49:40 <cfields> sipa: yep, same result on the aws instance I just fired up
238 2018-06-06T17:51:37 <cfields> sipa: the current avx2 path falls back to sse41 for single transforms, right? So presumably that benefits as well?
239 2018-06-06T17:51:52 <sipa> yup
240 2018-06-06T17:52:03 <sipa> cfields: ah, no
241 2018-06-06T17:52:12 <sipa> it falls back to sse41 for 4 elements
242 2018-06-06T17:52:35 *** Dizzle has quit IRC
243 2018-06-06T17:52:37 <sipa> there is also an asm sse4 single implementation... but that's not using intrinsics, so won't benefit from -mavx
244 2018-06-06T17:53:26 <cfields> ah yes, ok
245 2018-06-06T17:54:55 <sipa> we should try to convert that sse4 asm code to intrinsics, though
246 2018-06-06T17:55:00 <cfields> so, how do you want to move forward? Seems to me it makes sense to compile different bundles, where all contents are built with the flags
247 2018-06-06T17:56:27 <sipa> i guess we can compile the same source file twice, with a different -D specific to that build, which changes the namespace name?
248 2018-06-06T17:57:20 <cfields> so for ex, libbitcoin_crypto-avx.a is sha256.cpp, sha256_sse41.cpp, etc. Just built with the avx flags...
249 2018-06-06T17:57:26 <cfields> right
250 2018-06-06T17:57:58 *** Emcy has quit IRC
251 2018-06-06T17:59:03 <cfields> ok. how about: I'll do the simple build changes, we can get shani and power8 in, then we can redo the structure
252 2018-06-06T17:59:16 <sipa> sounds good
253 2018-06-06T17:59:30 <cfields> ok, thanks for testing
254 2018-06-06T18:01:11 *** Emcy has joined #bitcoin-core-dev
255 2018-06-06T18:02:40 <sipa> cfields: these numbers are on an 7th gen i7 CPU
256 2018-06-06T18:03:25 <sipa> i'll also try on ryzen
257 2018-06-06T18:03:39 *** drexl has joined #bitcoin-core-dev
258 2018-06-06T18:04:49 <cfields> ok. based on the other tests, I'd be perfectly happy with no-change there :)
259 2018-06-06T18:06:55 <gmaxwell> should figure out what AVX instruction's its substituting in...
260 2018-06-06T18:08:07 <sipa> gmaxwell: my assumption is that it's just using the higher 128 bits of the 256 registers as extra register space
261 2018-06-06T18:08:41 <cfields> gmaxwell: I did asm dumps of Round() split out, but don't speak enough asm to know what I'm looking at
262 2018-06-06T18:08:46 <cfields> I can paste those if you'd like
263 2018-06-06T18:10:02 <cfields> anything less focused than Round got too messy
264 2018-06-06T18:10:15 *** Dizzle has joined #bitcoin-core-dev
265 2018-06-06T18:13:16 <sipa> cfields: on Ryzen: sse41 2.8ms, sse41 w/ -mavx 2.2ms, avx2 2.1ms
266 2018-06-06T18:13:34 <cfields> woohoo!
267 2018-06-06T18:13:45 <sipa> (Ryzen actually only has 4-way parallel arithmetic, so avx2 doesn't have that much of a gain)
268 2018-06-06T18:13:52 <cfields> interesting that it's almost the same as avx2
269 2018-06-06T18:13:53 <cfields> ah
270 2018-06-06T18:13:58 *** jarthur has joined #bitcoin-core-dev
271 2018-06-06T18:15:09 <jarthur> Yep, it's practically just "API compatible" with AVX2.
272 2018-06-06T18:15:25 <sipa> well it also gives you 256-bit registers
273 2018-06-06T18:15:55 <sipa> but i guess those exist at AVX already
274 2018-06-06T18:17:40 <jarthur> sipa: gmaxwell mentioned that zen might be able to do parallel sha-ni runs if each step is loaded up side by side. Do you know if anyone has played with that yet? I volunteered at some point but didn't get around to it.
275 2018-06-06T18:18:42 <sipa> jarthur: yup, 2-way SHA-NI is faster than 1-way on my system
276 2018-06-06T18:18:53 <jarthur> nice! Is that code in your branch atm?
277 2018-06-06T18:18:57 <sipa> yup
278 2018-06-06T18:19:01 <jarthur> rockin
279 2018-06-06T18:19:15 <sipa> (not quite 2x - the implementation needs 10 registers-ish, so 2-way needs 20, while there are only 16 addressable ones, resulting in spills)
280 2018-06-06T18:19:42 <sipa> IIRC it took a benchmark from 0.83ms to 0.61ms by doing the 2-way
281 2018-06-06T18:20:05 <jarthur> that's significant in bitcoin land
282 2018-06-06T18:21:26 <sipa> jarthur: https://github.com/sipa/bitcoin/blob/bb80ab25963f56cad9bb560e59c77d40f351901b/src/crypto/sha256_shani.cpp#L151
283 2018-06-06T18:21:39 <sipa> it just calls every round function twice in a row
284 2018-06-06T18:22:43 <jarthur> Thanks. Looks nice and clean with those inlines.
285 2018-06-06T18:37:26 *** SopaXorzTaker has quit IRC
286 2018-06-06T18:54:28 <sipa> who is DrahtBot?
287 2018-06-06T18:57:29 *** Sinclair6 has joined #bitcoin-core-dev
288 2018-06-06T19:07:34 <wumpus> sipa: MarcoFalke's bot
289 2018-06-06T19:07:40 *** arubi has quit IRC
290 2018-06-06T19:07:57 <sipa> ah, nice
291 2018-06-06T19:08:00 <MarcoFalke> [ ] I'm not a robot
292 2018-06-06T19:08:30 *** arubi has joined #bitcoin-core-dev
293 2018-06-06T19:08:31 <sipa> oh, i meant "who is running Drahtbot"
294 2018-06-06T19:08:36 <sipa> i did realize it was a bot :)
295 2018-06-06T19:08:57 <sipa> how does it figure out conflicts?
296 2018-06-06T19:09:04 <sipa> does it try every combination of 2 PRs?
297 2018-06-06T19:17:57 <MarcoFalke> sipa: Yes, rn. I might implement a smart solution when I have time. Though, the compute overhead is trivial compared to the latency by the github api for now...
298 2018-06-06T19:23:07 *** Rebo has quit IRC
299 2018-06-06T19:26:33 <MarcoFalke> > i did realize it was a bot :)
300 2018-06-06T19:26:40 <MarcoFalke> Thanks for the compliment :)
301 2018-06-06T19:28:32 <bitcoin-git> [bitcoin] theuni opened pull request #13408: crypto: cleanup sha256 build (master...sha2-cleanup) https://github.com/bitcoin/bitcoin/pull/13408
302 2018-06-06T19:28:42 <cfields> sipa: ^^
303 2018-06-06T19:28:52 *** Rebo has joined #bitcoin-core-dev
304 2018-06-06T19:33:25 <sipa> cfields: i'd rather keep the explicit -D... in the makefile for the arch specific crypto libs
305 2018-06-06T19:33:48 <sipa> rather than rely on config.h
306 2018-06-06T19:34:19 <cfields> sipa: for what reason? We're already relying on config.h for endian/swap
307 2018-06-06T19:34:59 <sipa> cfields: because different libs may be compiled with different flags
308 2018-06-06T19:35:02 *** dongcarl has quit IRC
309 2018-06-06T19:35:08 <sipa> (expecting the avx/sse4 split)
310 2018-06-06T19:37:03 <cfields> sipa: hmm, I had a different approach in mind. But sure, I'll revert that and we can sha256 it out when we get there.
311 2018-06-06T19:37:30 *** Aaronvan_ has joined #bitcoin-core-dev
312 2018-06-06T19:39:18 <jamesob> wumpus: how much more review does a bench-only change like #13219 need?
313 2018-06-06T19:39:20 <gribble> https://github.com/bitcoin/bitcoin/issues/13219 | bench: Add block assemble benchmark by MarcoFalke · Pull Request #13219 · bitcoin/bitcoin · GitHub
314 2018-06-06T19:40:45 <MarcoFalke> jamesob: I guess it is fine, but just covered/hidden by a ton of other open pull requests.
315 2018-06-06T19:41:10 *** AaronvanW has quit IRC
316 2018-06-06T19:52:44 <sipa> cfields: if you have a different idea, sure
317 2018-06-06T19:58:25 *** pergaminho has quit IRC
318 2018-06-06T19:58:42 *** pergaminho has joined #bitcoin-core-dev
319 2018-06-06T19:59:14 *** pergaminho has joined #bitcoin-core-dev
320 2018-06-06T20:19:07 *** drexl has quit IRC
321 2018-06-06T20:25:08 *** jnewbery has quit IRC
322 2018-06-06T20:28:16 *** jnewbery has joined #bitcoin-core-dev
323 2018-06-06T20:53:34 *** pergaminho has quit IRC
324 2018-06-06T21:02:15 *** mistergold has quit IRC
325 2018-06-06T21:19:57 *** Guyver2 has quit IRC
326 2018-06-06T21:27:11 <cfields> sipa: https://github.com/theuni/bitcoin/commits/sha2-libs
327 2018-06-06T21:27:37 <cfields> that has the libs split out, rebuilt for each isn set, and adds avx
328 2018-06-06T21:28:23 *** nmnkgl has quit IRC
329 2018-06-06T21:28:41 <cfields> and yea, i see your point now, we need to pass in a flag for the namespace
330 2018-06-06T21:41:32 *** Chris_Stewart_5 has quit IRC
331 2018-06-06T21:42:37 *** jhfrontz has quit IRC
332 2018-06-06T21:43:35 *** jhfrontz has joined #bitcoin-core-dev
333 2018-06-06T21:46:19 <jarthur> sipa cfields, are we going down the direction that optimal instruction set would be picked at runtime, and default b86_64 build would have the lot of them compiled?
334 2018-06-06T21:46:52 <cfields> jarthur: yes. that's already the case, we're just diving deeper.
335 2018-06-06T21:50:27 *** nmnkgl has joined #bitcoin-core-dev
336 2018-06-06T21:50:58 <jarthur> thanks
337 2018-06-06T21:54:59 *** jhfrontz has quit IRC
338 2018-06-06T21:59:40 *** bitconner has joined #bitcoin-core-dev
339 2018-06-06T22:00:15 *** nmnkgl_ has joined #bitcoin-core-dev
340 2018-06-06T22:00:41 *** bitconner has quit IRC
341 2018-06-06T22:01:37 *** nmnkgl has quit IRC
342 2018-06-06T22:03:54 *** booyah has quit IRC
343 2018-06-06T22:05:04 *** booyah has joined #bitcoin-core-dev
344 2018-06-06T22:09:45 *** goatpig has quit IRC
345 2018-06-06T22:11:51 *** jhfrontz has joined #bitcoin-core-dev
346 2018-06-06T22:25:15 *** tryphe has quit IRC
347 2018-06-06T22:25:15 *** Victorsueca has quit IRC
348 2018-06-06T22:25:32 *** BGL has quit IRC
349 2018-06-06T22:25:42 *** tryphe has joined #bitcoin-core-dev
350 2018-06-06T22:26:23 *** Victorsueca has joined #bitcoin-core-dev
351 2018-06-06T22:29:05 *** bitbee_ has quit IRC
352 2018-06-06T22:30:31 *** bitbee has joined #bitcoin-core-dev
353 2018-06-06T22:39:33 *** snickerfritz has joined #bitcoin-core-dev
354 2018-06-06T22:41:18 *** jhfrontz has quit IRC
355 2018-06-06T22:45:47 *** jhfrontz has joined #bitcoin-core-dev
356 2018-06-06T22:53:51 *** Krellan has joined #bitcoin-core-dev
357 2018-06-06T23:06:50 *** contrapumpkin is now known as filthySJW
358 2018-06-06T23:06:56 *** filthySJW is now known as contrapumpkin
359 2018-06-06T23:09:24 *** jhfrontz has quit IRC
360 2018-06-06T23:10:53 *** jhfrontz has joined #bitcoin-core-dev
361 2018-06-06T23:13:10 *** nmnkgl_ has quit IRC
362 2018-06-06T23:13:55 *** Randolf has quit IRC
363 2018-06-06T23:19:03 *** timothy has joined #bitcoin-core-dev
364 2018-06-06T23:20:10 *** owowo has quit IRC
365 2018-06-06T23:20:22 *** ovovo has joined #bitcoin-core-dev
366 2018-06-06T23:26:37 *** jarthur has quit IRC
367 2018-06-06T23:26:38 *** Dizzle has quit IRC
368 2018-06-06T23:26:53 *** drexl has joined #bitcoin-core-dev
369 2018-06-06T23:27:01 *** jhfrontz has quit IRC
370 2018-06-06T23:32:34 *** bitconner has joined #bitcoin-core-dev
371 2018-06-06T23:36:49 *** jhfrontz has joined #bitcoin-core-dev
372 2018-06-06T23:39:21 *** jhfrontz has quit IRC
373 2018-06-06T23:41:31 *** Randolf has joined #bitcoin-core-dev
374 2018-06-06T23:45:12 *** intcat has quit IRC
375 2018-06-06T23:46:31 *** intcat has joined #bitcoin-core-dev
376 2018-06-06T23:47:58 *** Krellan has quit IRC
377 2018-06-06T23:48:45 *** Krellan has joined #bitcoin-core-dev