1 2018-06-12T00:00:27  *** nmnkgl has quit IRC
  2 2018-06-12T00:02:53  *** drexl has quit IRC
  3 2018-06-12T00:05:46  *** Chris_Stewart_5 has quit IRC
  4 2018-06-12T00:08:08  *** booyah_ has joined #bitcoin-core-dev
  5 2018-06-12T00:10:51  *** booyah has quit IRC
  6 2018-06-12T00:11:00  *** promag has joined #bitcoin-core-dev
  7 2018-06-12T00:15:59  *** gillian has joined #bitcoin-core-dev
  8 2018-06-12T00:16:22  *** gillian is now known as Guest97188
  9 2018-06-12T00:24:02  <sipa> cfields: clang does not like my code :(
 10 2018-06-12T00:24:20  <cfields> sipa: yea, needs a few little fixups...
 11 2018-06-12T00:24:43  <cfields> just template the param, and move the alignof() to the front of the definition
 12 2018-06-12T00:25:12  <cfields> (I assume you knew that, just verifying that it makes clang happy :)
 13 2018-06-12T00:27:06  <sipa> or just get rid of those helper functions
 14 2018-06-12T00:27:17  <sipa> they don't give much abstraction anyway :)
 15 2018-06-12T00:31:14  <cfields> heh
 16 2018-06-12T00:32:11  <cfields> sipa: this includes the optim from #13400. Was that intended?
 17 2018-06-12T00:32:13  <gribble> https://github.com/bitcoin/bitcoin/issues/13400 | sha256: small speedup for sse4 path. by theuni · Pull Request #13400 · bitcoin/bitcoin · GitHub
 18 2018-06-12T00:33:11  <sipa> oh?
 19 2018-06-12T00:33:14  <sipa> no
 20 2018-06-12T00:33:47  <sipa> i don't see that
 21 2018-06-12T00:34:55  <cfields> looking again, maybe order has me confused.
 22 2018-06-12T00:39:24  *** Guest97188 has left #bitcoin-core-dev
 23 2018-06-12T00:58:07  *** promag has quit IRC
 24 2018-06-12T01:06:08  <phantomcircuit> sipa, the only caller of CCoinsViewDB::BatchWrite seems to be CCoinsViewCache::Flush which calls clear() on cacheCoins after
 25 2018-06-12T01:06:42  <phantomcircuit> but BatchWrite is erasing each entry itself from cacheCoins passed by reference it seems
 26 2018-06-12T01:07:45  <cfields> sipa: https://pastebin.com/raw/H5rV4kM5
 27 2018-06-12T01:13:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 28 2018-06-12T01:18:57  *** AaronvanW has quit IRC
 29 2018-06-12T01:40:21  *** grafcaps has quit IRC
 30 2018-06-12T01:50:25  <sipa> phantomcircuit: correct
 31 2018-06-12T01:51:07  <sipa> it's also potentially creating new entries in the parent cache
 32 2018-06-12T01:51:25  <sipa> so to compensate for that memory usage, it also erases on the fly from the other one
 33 2018-06-12T01:52:34  *** Chris_Stewart_5 has quit IRC
 34 2018-06-12T01:52:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 35 2018-06-12T01:53:41  <gmaxwell> sipa: now that you've done intrensics you should be able to specialize the 64byte double sha2
 36 2018-06-12T01:53:48  <gmaxwell> pretty easily?
 37 2018-06-12T01:53:57  <phantomcircuit> sipa, right i see the pr, it's trying to avoid peak memory usage effectively being doubled by caching things twice
 38 2018-06-12T01:54:30  <gmaxwell> (at least the 32-byte specialized version should get heavy use... because of all the places we use double sha2...)
 39 2018-06-12T01:55:10  <sipa> gmaxwell: yup, one thing at a time
 40 2018-06-12T01:55:24  <phantomcircuit> does std::unordered_map::clear() even do anything on an empty map?
 41 2018-06-12T01:55:32  <sipa> no
 42 2018-06-12T01:56:02  <phantomcircuit> ok so that call in Flush() is effectively a noop but makes it clear that it's empty i guess
 43 2018-06-12T02:04:03  *** grafcaps has joined #bitcoin-core-dev
 44 2018-06-12T02:07:01  *** snickerfritz has quit IRC
 45 2018-06-12T02:10:34  *** Chris_Stewart_5 has quit IRC
 46 2018-06-12T02:31:12  *** StopAndDecrypt has quit IRC
 47 2018-06-12T02:39:34  <cfields> sipa: hmm, come to think about it, the slowdown occured on AMD when Round() was done on SIMD instructions. Maybe it doesn't pay the same price on integers?
 48 2018-06-12T02:40:24  *** StopAndDecrypt has joined #bitcoin-core-dev
 49 2018-06-12T02:41:09  <cfields> Sigma0/Sigma1, that is.
 50 2018-06-12T02:42:09  <sipa> what slowdown?
 51 2018-06-12T02:44:35  <cfields> sipa: nm, I'll comment on the PR
 52 2018-06-12T03:09:07  *** bitconner has quit IRC
 53 2018-06-12T03:14:07  <sipa> cfields: fixed, hopefully
 54 2018-06-12T03:15:53  <sipa> cfields: the new Round function in https://github.com/theuni/bitcoin/commit/d69a5164f914c6c2945d8f32134faa0da87795f5 makes the benchmark go from 3.68 ms to 4.16 ms
 55 2018-06-12T03:18:14  <cfields> sipa: Mind giving https://github.com/theuni/bitcoin/commit/4ee6fbb8b7525988783030eb0799bbc7293d50a0 a try? That's a little less dumb, doesn't force a dependency.
 56 2018-06-12T03:18:29  <sipa> (for me, on i7-7)
 57 2018-06-12T03:18:34  <sipa> sure
 58 2018-06-12T03:18:54  <cfields> sipa: I'm mostly curious to see if it's quicker on AMD.
 59 2018-06-12T03:19:53  <sipa> i'll try the different versions on a Ryzen system too if you want
 60 2018-06-12T03:20:04  <sipa> then again, on those systems we'll likely use SHA-NI instead :)
 61 2018-06-12T03:20:15  <cfields> heh, right
 62 2018-06-12T03:20:22  <cfields> you see what I'm getting at though, right?
 63 2018-06-12T03:26:00  *** bitconner has joined #bitcoin-core-dev
 64 2018-06-12T03:30:58  *** bitconner has quit IRC
 65 2018-06-12T03:56:02  *** d9b4bef9 has quit IRC
 66 2018-06-12T03:57:07  *** d9b4bef9 has joined #bitcoin-core-dev
 67 2018-06-12T03:59:24  *** bitconner has joined #bitcoin-core-dev
 68 2018-06-12T04:04:50  *** bitconner has quit IRC
 69 2018-06-12T04:14:37  *** bitconner has joined #bitcoin-core-dev
 70 2018-06-12T04:19:15  *** bitconner has quit IRC
 71 2018-06-12T04:37:10  *** goatpig has quit IRC
 72 2018-06-12T04:39:31  <sipa> cfields: yeah, i'll benchmark on other systems
 73 2018-06-12T04:40:01  *** jojeyh has joined #bitcoin-core-dev
 74 2018-06-12T04:49:01  <bitcoin-git> [bitcoin] lucash-dev opened pull request #13443: Removed unused == operator from CMutableTransaction. (master...remove-CMutableTransaction-equals) https://github.com/bitcoin/bitcoin/pull/13443
 75 2018-06-12T06:01:52  <bitcoin-git> [bitcoin] edsgerlin opened pull request #13444: depends: bump openssl to 1.0.2o (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13444
 76 2018-06-12T06:26:46  *** Victorsueca has quit IRC
 77 2018-06-12T06:28:03  *** Victorsueca has joined #bitcoin-core-dev
 78 2018-06-12T07:09:07  *** promag has joined #bitcoin-core-dev
 79 2018-06-12T07:17:28  *** promag has quit IRC
 80 2018-06-12T07:23:12  *** harrymm has quit IRC
 81 2018-06-12T07:35:58  *** harrymm has joined #bitcoin-core-dev
 82 2018-06-12T07:41:00  <kallewoof> Maybe I missed it.. do we ask someone to remove the needs rebase tags after we rebase stuff or...?
 83 2018-06-12T07:42:52  <sipa> kallewoof: DrahtBot will remove them when it gets around
 84 2018-06-12T07:46:22  <kallewoof> Oh, it is delayed? Gotcha
 85 2018-06-12T07:56:07  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13445: build: Reset default -g -O2 flags when enable debug (master...debug_cflags) https://github.com/bitcoin/bitcoin/pull/13445
 86 2018-06-12T07:59:19  <sipa> kallewoof: it's a bot, it goes through all PRs one by one, it takes a while
 87 2018-06-12T07:59:22  <sipa> MarcoFalke runs it
 88 2018-06-12T08:06:37  *** timothy has joined #bitcoin-core-dev
 89 2018-06-12T08:11:04  *** drizztbsd has joined #bitcoin-core-dev
 90 2018-06-12T08:11:32  *** timothy has quit IRC
 91 2018-06-12T08:14:59  *** rafalcpp has joined #bitcoin-core-dev
 92 2018-06-12T08:20:17  *** promag has joined #bitcoin-core-dev
 93 2018-06-12T08:26:53  <bitcoin-git> [bitcoin] ccdle12 closed pull request #13067: [WIP] Unit test sub-directories - Continued (master...PR-fixes-ccdle12) https://github.com/bitcoin/bitcoin/pull/13067
 94 2018-06-12T08:28:39  <jonasschnelli> wumpus: regarding https://github.com/bitcoin/bitcoin/pull/12196#issuecomment-394356035 ...
 95 2018-06-12T08:28:47  <jonasschnelli> Is that a pay to pubkey unspent?
 96 2018-06-12T08:34:52  *** bitconner has joined #bitcoin-core-dev
 97 2018-06-12T08:35:41  <bitcoin-git> [bitcoin] murrayn opened pull request #13446: Build: remove non-distribution files/directories during make distclean. (master...distclean) https://github.com/bitcoin/bitcoin/pull/13446
 98 2018-06-12T08:40:01  *** bitconner has quit IRC
 99 2018-06-12T09:09:25  *** cdecker has quit IRC
100 2018-06-12T09:10:53  *** cdecker has joined #bitcoin-core-dev
101 2018-06-12T09:13:32  *** Empact has quit IRC
102 2018-06-12T09:17:16  *** Empact has joined #bitcoin-core-dev
103 2018-06-12T09:26:22  *** f_ has joined #bitcoin-core-dev
104 2018-06-12T09:30:03  *** f_ has quit IRC
105 2018-06-12T09:41:28  *** ExtraCrispy has joined #bitcoin-core-dev
106 2018-06-12T09:50:25  *** drizztbsd has quit IRC
107 2018-06-12T09:51:06  *** drizztbsd has joined #bitcoin-core-dev
108 2018-06-12T09:53:09  *** AaronvanW has joined #bitcoin-core-dev
109 2018-06-12T09:56:16  *** fanquake has joined #bitcoin-core-dev
110 2018-06-12T09:58:38  *** bitconner has joined #bitcoin-core-dev
111 2018-06-12T10:03:57  *** bitconner has quit IRC
112 2018-06-12T10:11:01  *** d9b4bef9 has quit IRC
113 2018-06-12T10:12:07  *** d9b4bef9 has joined #bitcoin-core-dev
114 2018-06-12T10:14:10  *** bobques33 has joined #bitcoin-core-dev
115 2018-06-12T10:32:27  *** laurentmt has joined #bitcoin-core-dev
116 2018-06-12T11:12:40  <rafalcpp> wumpus: hm, why are symlinks prohibited from being in Tree-SHA512? they seem to normally work, they are shown as blobs, their git-sha1 is identical for symlinks with same symlink target, and so is sha512 that we get from them
117 2018-06-12T11:14:16  *** nman999_ has joined #bitcoin-core-dev
118 2018-06-12T11:15:13  *** nman999_ has quit IRC
119 2018-06-12T11:18:38  <rafalcpp> BlueMatt: why we disallow symlinks? (it's your commit be908a69 - Fail merge if there are any symlinks)
120 2018-06-12T11:23:09  <rafalcpp> it was decided in #9871 to disable them because bitcoin doesn't need them so no need to wonder if we handle them correctly
121 2018-06-12T11:23:11  <gribble> https://github.com/bitcoin/bitcoin/issues/9871 | Add a tree sha512 hash to merge commits by sipa · Pull Request #9871 · bitcoin/bitcoin · GitHub
122 2018-06-12T11:23:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
123 2018-06-12T11:29:00  *** bobques33 has quit IRC
124 2018-06-12T11:33:03  <wumpus> rafalcpp: basic security precaution, we could go into detail analysing the consequences of symlinks (relative, absolute, inside tree, outside tree, etc) or just blanket disallow them. As we don't require them, just disallowing is safer.
125 2018-06-12T11:33:43  <wumpus> jonasschnelli: could be!
126 2018-06-12T11:34:37  <wumpus> we don't really *want* symlinks ending up in the repository
127 2018-06-12T11:37:30  <wumpus> `(they're also not compatible with some OSes)
128 2018-06-12T11:40:40  <rafalcpp> wumpus: perhaps support for them could exist with --allow-symlinks defaulting to false? Other projects besides bitcoin could benefit from tree sha512
129 2018-06-12T11:40:55  *** AaronvanW has quit IRC
130 2018-06-12T11:41:29  <wumpus> yes- it could be a git setting that defaults to false. But I don't think it's urgent.
131 2018-06-12T11:57:37  *** AaronvanW has joined #bitcoin-core-dev
132 2018-06-12T12:03:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c32b414b632...b22115d9a3b0
133 2018-06-12T12:03:21  <bitcoin-git> bitcoin/master 419a198 practicalswift: docs: Add a note about the source code filename naming convention
134 2018-06-12T12:03:21  <bitcoin-git> bitcoin/master e567713 practicalswift: Do not use uppercase characters in source code filenames
135 2018-06-12T12:03:22  <bitcoin-git> bitcoin/master b22115d MarcoFalke: Merge #13312: docs: Add a note about the source code filename naming convention...
136 2018-06-12T12:04:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13312: docs: Add a note about the source code filename naming convention (master...lowercase-filenames) https://github.com/bitcoin/bitcoin/pull/13312
137 2018-06-12T12:06:06  *** laurentmt has quit IRC
138 2018-06-12T12:07:25  *** indistylo has joined #bitcoin-core-dev
139 2018-06-12T12:09:46  *** promag has quit IRC
140 2018-06-12T12:28:27  *** Chris_Stewart_5 has quit IRC
141 2018-06-12T12:45:11  <fanquake> I guess one slightly annoying limitation of the linters is that upstream changes can't be tested in /bitcoin
142 2018-06-12T12:45:17  *** AaronvanW has quit IRC
143 2018-06-12T12:45:57  *** AaronvanW has joined #bitcoin-core-dev
144 2018-06-12T12:53:46  <wumpus> yes
145 2018-06-12T12:54:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b22115d9a3b0...5315660baef0
146 2018-06-12T12:54:31  <bitcoin-git> bitcoin/master fa8071a MarcoFalke: qa: Log as utf-8
147 2018-06-12T12:54:31  <bitcoin-git> bitcoin/master 5315660 Wladimir J. van der Laan: Merge #13440: qa: Log as utf-8...
148 2018-06-12T12:55:19  <bitcoin-git> [bitcoin] laanwj closed pull request #13440: qa: Log as utf-8 (master...Mf1806-qaLogUtf8) https://github.com/bitcoin/bitcoin/pull/13440
149 2018-06-12T12:57:34  <fanquake> wumpus See #13444, I don't think that's something we want to do?
150 2018-06-12T12:57:36  <gribble> https://github.com/bitcoin/bitcoin/issues/13444 | depends: bump openssl to 1.0.2o by edsgerlin · Pull Request #13444 · bitcoin/bitcoin · GitHub
151 2018-06-12T13:00:05  <wumpus> fanquake: will have a look
152 2018-06-12T13:00:37  *** bitconner has joined #bitcoin-core-dev
153 2018-06-12T13:05:33  *** bitconner has quit IRC
154 2018-06-12T13:07:48  <wumpus> fanquake: so the only thing affected by the OpenSSL version in depends is pretty much qt nowadays, right?
155 2018-06-12T13:08:12  <wumpus> I tend to agree with you that it is unnecessary
156 2018-06-12T13:08:27  <wumpus> (assuming that there has been no security issue that necessitates it)
157 2018-06-12T13:09:55  <fanquake> wumpus Looking at the release notes, basically every major change in the 1.0.2 series is a CVE
158 2018-06-12T13:12:28  *** Guyver2 has joined #bitcoin-core-dev
159 2018-06-12T13:12:51  <wumpus> seems like a nightmare to keep track of
160 2018-06-12T13:12:52  *** jouke has quit IRC
161 2018-06-12T13:13:23  *** berndj has quit IRC
162 2018-06-12T13:13:31  <wumpus> maybe "update to most recent version" isn't that bad an idea, periodically, I don't know...
163 2018-06-12T13:13:55  <fanquake> tbh I prefer the "drop the requirement for OpenSSL entirely" idea :p
164 2018-06-12T13:14:20  <fanquake> There have been a few shots at that in the past, but never merged for various reasons.
165 2018-06-12T13:14:34  *** berndj has joined #bitcoin-core-dev
166 2018-06-12T13:16:08  <wumpus> for the core it's doable, but dropping the requirement from the GUI doesn't seem feasible to me, besides replacing it with some alternative SSL library (qt supports some) but I'm not sure that's better...
167 2018-06-12T13:17:24  <wumpus> e.g. on windows, qt can use the native SSL support, so wouldn't strictly need OpenSSL - but that doesn't sound too great to me either...
168 2018-06-12T13:17:50  <fanquake> Especially given the seeming lack of people we have testing anything on Windows
169 2018-06-12T13:19:03  <wumpus> that, too
170 2018-06-12T13:19:28  *** m8tion has joined #bitcoin-core-dev
171 2018-06-12T13:19:32  *** promag has joined #bitcoin-core-dev
172 2018-06-12T13:19:35  <wumpus> also the GUI code does some juggling with certificates that doesn't go through the Qt crypto API, so is OpenSSL specific
173 2018-06-12T13:19:48  <wumpus> it doesn't feel really worth working on
174 2018-06-12T13:21:23  <wumpus> in a bizarre twist of fate, I was working on a deprecation plan for payment requests, which would have solved this problem once and for all, but then bitpay announced they will *only* support it from then on.
175 2018-06-12T13:22:01  <fanquake> heh
176 2018-06-12T13:22:05  <fanquake> I remember that
177 2018-06-12T13:22:52  <fanquake> #11622
178 2018-06-12T13:22:56  <gribble> https://github.com/bitcoin/bitcoin/issues/11622 | build: Add --disable-bip70 configure option by laanwj · Pull Request #11622 · bitcoin/bitcoin · GitHub
179 2018-06-12T13:23:12  <wumpus> that took all of the wind out of my sails in that regard
180 2018-06-12T13:23:22  <wumpus> yes that one
181 2018-06-12T13:24:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
182 2018-06-12T13:25:39  <fanquake> I noticed that currently 1/3 of all PRs "need a rebase"
183 2018-06-12T13:30:05  *** juX0 has joined #bitcoin-core-dev
184 2018-06-12T13:30:52  <wumpus> is:pr is:open -label:"needs rebase"
185 2018-06-12T13:31:11  <fanquake> that indeed
186 2018-06-12T13:31:36  <wumpus> or let's go nag some people, at least if it's PRs likely to be merged otherwise
187 2018-06-12T13:33:31  <wumpus> it looks like most conflicts were caused by build system changes, as well as the txindex refactor
188 2018-06-12T13:36:45  *** juX0 has quit IRC
189 2018-06-12T13:37:31  <fanquake> wumpus: wouldn't dare nag anyone :p
190 2018-06-12T13:38:17  <wumpus> :p
191 2018-06-12T13:45:05  <wumpus> any opinions on when we should tag 0.16.1 final?
192 2018-06-12T13:46:06  <fanquake> Did anything happen for the assert on Windows?
193 2018-06-12T13:47:31  <wumpus> not that I know of - rc2 was just a translation fix
194 2018-06-12T13:49:53  <wumpus> you mean #13358? that doesn't seem to be a regression in 0.16.1
195 2018-06-12T13:49:54  <gribble> https://github.com/bitcoin/bitcoin/issues/13358 | Assertion failed Error file chain.cpp 102 · Issue #13358 · bitcoin/bitcoin · GitHub
196 2018-06-12T13:54:53  <fanquake> wumpus I thought there was another one on shutdown, but have just installed rc2 onto Windows 10 and no longer see it
197 2018-06-12T13:56:36  <fanquake> cfields You might be interested, some new output I'm seeing after upgrading to Command Line Tools 10.0 https://0bin.net/paste/2iaLr12c+Q-4rlmS#lexGszZqOKn07pwYKQvTKYGgCBTkDPKGnlCo5PjbGTV
198 2018-06-12T13:57:46  <fanquake> wumpus #12337
199 2018-06-12T13:57:47  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
200 2018-06-12T13:58:12  <fanquake> However seems like that doesn't need to hold up a 0.16.1
201 2018-06-12T14:03:42  *** drizztbsd is now known as timothy
202 2018-06-12T14:06:05  *** qrestlove has quit IRC
203 2018-06-12T14:15:54  *** laurentmt has joined #bitcoin-core-dev
204 2018-06-12T14:16:14  *** qrestlove has joined #bitcoin-core-dev
205 2018-06-12T14:17:03  *** laurentmt has quit IRC
206 2018-06-12T14:37:07  <jnewbery> Review beg for #13066. We haven't run successfully run the extended tests or verify-commits in Travis for over two months and that would fix it
207 2018-06-12T14:37:10  <gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub
208 2018-06-12T15:00:44  *** jcohen has joined #bitcoin-core-dev
209 2018-06-12T15:17:09  <wumpus> jnewbery: will take a look
210 2018-06-12T15:19:25  <wumpus> kind of forgot about that one
211 2018-06-12T15:19:49  <jnewbery> great. Thanks!
212 2018-06-12T15:21:02  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5315660baef0...ca2a23387be6
213 2018-06-12T15:21:02  <bitcoin-git> bitcoin/master fa7a6cf MarcoFalke: policy: Treat segwit as always active
214 2018-06-12T15:21:03  <bitcoin-git> bitcoin/master ca2a233 Wladimir J. van der Laan: Merge #13120: policy: Treat segwit as always active...
215 2018-06-12T15:21:47  <bitcoin-git> [bitcoin] laanwj closed pull request #13120: policy: Treat segwit as always active (master...Mf1805-segwitGenesisPolicy) https://github.com/bitcoin/bitcoin/pull/13120
216 2018-06-12T15:25:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca2a23387be6...fa4b9065a829
217 2018-06-12T15:25:48  <bitcoin-git> bitcoin/master e5b2cd8 Chun Kuan Lee: Use python instead of slow shell script on verify-commits
218 2018-06-12T15:25:49  <bitcoin-git> bitcoin/master fa4b906 Wladimir J. van der Laan: Merge #13066: Migrate verify-commits script to python, run in travis...
219 2018-06-12T15:26:07  *** satwo has joined #bitcoin-core-dev
220 2018-06-12T15:26:27  <bitcoin-git> [bitcoin] laanwj closed pull request #13066: Migrate verify-commits script to python, run in travis (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13066
221 2018-06-12T15:28:38  <BlueMatt> wumpus: errr, did anyone else even review that?
222 2018-06-12T15:28:46  <BlueMatt> else besides jnewbery, that is
223 2018-06-12T15:28:54  <wumpus> yes, I reviewed it a long time ago
224 2018-06-12T15:29:17  <BlueMatt> hmm, can you comment to that effect? I only see a concept ack from you on there
225 2018-06-12T15:29:21  <wumpus> checked that it still was more or less the same
226 2018-06-12T15:29:46  <wumpus> you didn't lookv ery well, there's an utACK from me in that topic too
227 2018-06-12T15:30:01  <wumpus> apr 27
228 2018-06-12T15:30:53  <BlueMatt> ah, ok, still wish we'd gotten more than 2 reviews with one pretty old on something thats designed to be usable to verify repo consistency
229 2018-06-12T15:31:11  *** satwo has quit IRC
230 2018-06-12T15:31:22  <wumpus> well at least it makes checking feasible again
231 2018-06-12T15:31:31  <jnewbery> post-merge reviews welcome :)
232 2018-06-12T15:31:46  <wumpus> no one was checking because the script was unusably slow
233 2018-06-12T15:31:48  <BlueMatt> jnewbery: I dont feel comfortable reviewing security python, sadly
234 2018-06-12T15:32:00  <BlueMatt> yes, indeed, better than it not getting run, which is apparently what was happening :(
235 2018-06-12T15:32:02  <wumpus> FWIW, I'm 100% more comfortable reviewing python than shell script
236 2018-06-12T15:32:20  <BlueMatt> heh, yes, I understand I'm like the only one left who prefers bash to python
237 2018-06-12T15:32:21  <wumpus> there's just too much icky edge cases in shell script for me to be comfortable about it
238 2018-06-12T15:32:39  <BlueMatt> lets just move everything to C :p
239 2018-06-12T15:32:54  <wumpus> (like oh no, you forget to use the right quoting, now everything with spaces will escape.. and similar things)
240 2018-06-12T15:33:07  <wumpus> feel free to rewrite it in C :p
241 2018-06-12T15:33:13  <wumpus> it'd likely be even faster
242 2018-06-12T15:33:23  <BlueMatt> lol, then it'd *actually* be usably fast
243 2018-06-12T15:33:27  <BlueMatt> maybe I'll rewrite it in rust :p
244 2018-06-12T15:33:36  <wumpus> hehe
245 2018-06-12T15:33:42  <wumpus> yes that'd be cool
246 2018-06-12T15:33:43  * BlueMatt has way too many rust projects now
247 2018-06-12T15:33:58  <BlueMatt> I mean I've got a whole multi-daemon pool server and proxies in rust
248 2018-06-12T15:34:47  <jnewbery> well, if anyone else knows python well enough to review #13066, I'm sure BlueMatt will appreciate your postmerge ACKs
249 2018-06-12T15:34:49  <gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub
250 2018-06-12T15:35:21  <wumpus> yes, it's always good to have more review, also of code already merged
251 2018-06-12T15:45:22  *** fanquake has quit IRC
252 2018-06-12T15:48:21  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13447: travis: Increase travis_wait time while verifying commits (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13447
253 2018-06-12T15:50:27  *** grafcaps has quit IRC
254 2018-06-12T15:51:20  <bitcoin-git> [bitcoin] practicalswift opened pull request #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python (master...lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13448
255 2018-06-12T15:53:38  <promag> #13111 is ready for review
256 2018-06-12T15:53:40  <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
257 2018-06-12T15:56:47  *** promag has quit IRC
258 2018-06-12T16:07:24  *** grafcaps has joined #bitcoin-core-dev
259 2018-06-12T16:08:38  *** joshb[m] has quit IRC
260 2018-06-12T16:08:39  *** ajtowns[m] has quit IRC
261 2018-06-12T16:08:47  *** squarfed[m] has quit IRC
262 2018-06-12T16:08:48  *** herzmeister[m] has quit IRC
263 2018-06-12T16:08:49  *** stepa[m] has quit IRC
264 2018-06-12T16:08:51  *** kewde[m] has quit IRC
265 2018-06-12T16:11:27  *** schnerchi has quit IRC
266 2018-06-12T16:13:30  *** schnerchi has joined #bitcoin-core-dev
267 2018-06-12T16:32:25  *** kewde[m] has joined #bitcoin-core-dev
268 2018-06-12T16:45:57  *** goatpig has joined #bitcoin-core-dev
269 2018-06-12T16:46:32  *** herzmeister[m] has joined #bitcoin-core-dev
270 2018-06-12T16:46:32  *** ajtowns[m] has joined #bitcoin-core-dev
271 2018-06-12T16:46:32  *** joshb[m] has joined #bitcoin-core-dev
272 2018-06-12T16:46:34  *** stepa[m] has joined #bitcoin-core-dev
273 2018-06-12T16:46:34  *** squarfed[m] has joined #bitcoin-core-dev
274 2018-06-12T16:49:20  *** jtimon has joined #bitcoin-core-dev
275 2018-06-12T16:51:45  *** rrrrr_ has joined #bitcoin-core-dev
276 2018-06-12T16:52:51  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa4b9065a829...a607d23ae82e
277 2018-06-12T16:52:51  <bitcoin-git> bitcoin/master 57ba401 Pieter Wuille: Enable double-SHA256-for-64-byte code on 32-bit x86
278 2018-06-12T16:52:52  <bitcoin-git> bitcoin/master a607d23 Wladimir J. van der Laan: Merge #13393: Enable double-SHA256-for-64-byte code on 32-bit x86...
279 2018-06-12T16:53:34  <bitcoin-git> [bitcoin] laanwj closed pull request #13393: Enable double-SHA256-for-64-byte code on 32-bit x86 (master...201806_dsha256_i386) https://github.com/bitcoin/bitcoin/pull/13393
280 2018-06-12T17:01:03  *** bitconner has joined #bitcoin-core-dev
281 2018-06-12T17:05:15  *** bitconner has quit IRC
282 2018-06-12T17:06:34  *** nmnkgl has joined #bitcoin-core-dev
283 2018-06-12T17:17:21  *** rrrrr_ has quit IRC
284 2018-06-12T17:18:01  *** d9b4bef9 has quit IRC
285 2018-06-12T17:19:08  *** d9b4bef9 has joined #bitcoin-core-dev
286 2018-06-12T17:19:16  *** promag has joined #bitcoin-core-dev
287 2018-06-12T17:25:38  *** Sinclair6 has quit IRC
288 2018-06-12T17:33:19  *** m8tion has quit IRC
289 2018-06-12T17:35:26  <promag> MarcoFalke: how about a "dormant" label, automatically added for something not updated for X days (either github or git)?
290 2018-06-12T17:45:50  *** nekotribal has quit IRC
291 2018-06-12T17:46:06  *** nekotribal has joined #bitcoin-core-dev
292 2018-06-12T17:48:22  *** ctrlbreak has quit IRC
293 2018-06-12T17:49:05  *** ctrlbreak has joined #bitcoin-core-dev
294 2018-06-12T17:53:04  *** drexl has joined #bitcoin-core-dev
295 2018-06-12T17:59:25  *** indistylo has quit IRC
296 2018-06-12T18:03:21  *** Cory has quit IRC
297 2018-06-12T18:07:49  *** promag has quit IRC
298 2018-06-12T18:08:20  *** Pasha has joined #bitcoin-core-dev
299 2018-06-12T18:11:32  *** Pasha is now known as Cory
300 2018-06-12T18:14:05  <bitcoin-git> [bitcoin] instagibbs opened pull request #13449: [WIP] support new multisig template in wallet for Solver, signing, and sign… (master...largemultisig) https://github.com/bitcoin/bitcoin/pull/13449
301 2018-06-12T18:24:08  *** Cory has quit IRC
302 2018-06-12T18:29:12  *** Pasha has joined #bitcoin-core-dev
303 2018-06-12T18:30:39  <luke-jr> #12859 seems to not be in 0.16.1 rc2?
304 2018-06-12T18:30:41  <gribble> https://github.com/bitcoin/bitcoin/issues/12859 | Bugfix: Include for std::unique_ptr by luke-jr · Pull Request #12859 · bitcoin/bitcoin · GitHub
305 2018-06-12T18:32:23  *** Pasha is now known as Cory
306 2018-06-12T18:42:25  *** AaronvanW has quit IRC
307 2018-06-12T18:42:39  <luke-jr> wumpus: ^
308 2018-06-12T18:46:58  *** nmnkgl has quit IRC
309 2018-06-12T18:47:35  *** nmnkgl has joined #bitcoin-core-dev
310 2018-06-12T18:51:58  *** nmnkgl has quit IRC
311 2018-06-12T18:53:16  *** Sinclair6 has joined #bitcoin-core-dev
312 2018-06-12T18:56:35  *** indistylo has joined #bitcoin-core-dev
313 2018-06-12T18:58:40  *** nmnkgl has joined #bitcoin-core-dev
314 2018-06-12T19:06:46  *** AaronvanW has joined #bitcoin-core-dev
315 2018-06-12T19:08:15  *** cubancorona has joined #bitcoin-core-dev
316 2018-06-12T19:11:06  *** jcohen has quit IRC
317 2018-06-12T19:15:18  *** AaronvanW has quit IRC
318 2018-06-12T19:15:52  *** AaronvanW has joined #bitcoin-core-dev
319 2018-06-12T19:19:27  *** cubancorona has quit IRC
320 2018-06-12T19:20:05  *** AaronvanW has quit IRC
321 2018-06-12T19:32:49  <wumpus> luke-jr: it was also not tagged as such
322 2018-06-12T19:33:54  * luke-jr doesn't do the tagging XD
323 2018-06-12T19:34:41  <wumpus> you could have mentioned it, at least
324 2018-06-12T19:34:51  <luke-jr> just did
325 2018-06-12T19:35:32  * luke-jr wonders how wide this affects
326 2018-06-12T19:35:51  *** Victorsueca has quit IRC
327 2018-06-12T19:37:04  *** Victorsueca has joined #bitcoin-core-dev
328 2018-06-12T19:37:55  <luke-jr> seems like Ubuntu doesn't have Qt 5.10 yet, but Debian testing does
329 2018-06-12T19:38:28  <luke-jr> dunno how to check Fedora
330 2018-06-12T19:39:12  <luke-jr> Arch has 5.11
331 2018-06-12T19:51:52  *** promag has joined #bitcoin-core-dev
332 2018-06-12T20:02:35  *** indistylo has quit IRC
333 2018-06-12T20:03:20  <bitcoin-git> [bitcoin] practicalswift opened pull request #13450: Add linter: Enforce the source code file naming convention described in the developer notes (master...lint-filenames) https://github.com/bitcoin/bitcoin/pull/13450
334 2018-06-12T20:09:01  *** promag has quit IRC
335 2018-06-12T20:19:00  *** AaronvanW has joined #bitcoin-core-dev
336 2018-06-12T20:32:43  *** promag has joined #bitcoin-core-dev
337 2018-06-12T20:34:02  *** nmnkgl has quit IRC
338 2018-06-12T20:34:36  *** nmnkgl has joined #bitcoin-core-dev
339 2018-06-12T20:35:10  *** bitconner has joined #bitcoin-core-dev
340 2018-06-12T20:35:51  *** promag has quit IRC
341 2018-06-12T20:38:57  *** nmnkgl has quit IRC
342 2018-06-12T20:39:25  *** bitconner has quit IRC
343 2018-06-12T20:47:50  <bitcoin-git> [bitcoin] instagibbs opened pull request #13451: expose CBlockIndex::nTx in getblockheader (master...expose_nTx) https://github.com/bitcoin/bitcoin/pull/13451
344 2018-06-12T20:49:23  *** joshb[m] has quit IRC
345 2018-06-12T20:49:32  *** herzmeister[m] has quit IRC
346 2018-06-12T20:49:35  *** kewde[m] has quit IRC
347 2018-06-12T20:49:38  *** ajtowns[m] has quit IRC
348 2018-06-12T20:49:44  *** squarfed[m] has quit IRC
349 2018-06-12T20:49:54  *** stepa[m] has quit IRC
350 2018-06-12T20:49:55  *** Krellan has joined #bitcoin-core-dev
351 2018-06-12T20:52:39  <luke-jr> #13120 should probably be backported too
352 2018-06-12T20:52:41  <gribble> https://github.com/bitcoin/bitcoin/issues/13120 | policy: Treat segwit as always active by MarcoFalke · Pull Request #13120 · bitcoin/bitcoin · GitHub
353 2018-06-12T20:53:17  <luke-jr> perhaps simplified
354 2018-06-12T21:03:28  *** drexl has quit IRC
355 2018-06-12T21:06:22  *** herzmeister[m] has joined #bitcoin-core-dev
356 2018-06-12T21:15:29  *** nmnkgl has joined #bitcoin-core-dev
357 2018-06-12T21:16:46  <bitcoin-git> [bitcoin] instagibbs opened pull request #13452: have verifytxoutproof check the number of txns in proof structure (master...actuallyverifytxoutproof) https://github.com/bitcoin/bitcoin/pull/13452
358 2018-06-12T21:18:43  *** drexl has joined #bitcoin-core-dev
359 2018-06-12T21:20:23  *** nmnkgl has quit IRC
360 2018-06-12T21:22:09  *** kewde[m] has joined #bitcoin-core-dev
361 2018-06-12T21:22:09  *** stepa[m] has joined #bitcoin-core-dev
362 2018-06-12T21:22:09  *** joshb[m] has joined #bitcoin-core-dev
363 2018-06-12T21:22:09  *** ajtowns[m] has joined #bitcoin-core-dev
364 2018-06-12T21:22:09  *** squarfed[m] has joined #bitcoin-core-dev
365 2018-06-12T21:23:59  *** Chris_Stewart_5 has quit IRC
366 2018-06-12T21:25:35  *** Kevinho669 has joined #bitcoin-core-dev
367 2018-06-12T21:32:45  *** Kevinho669 has quit IRC
368 2018-06-12T21:37:34  *** bitconner has joined #bitcoin-core-dev
369 2018-06-12T21:41:59  *** jcohen has joined #bitcoin-core-dev
370 2018-06-12T21:52:06  *** bitconner has quit IRC
371 2018-06-12T21:52:34  *** jcohen has quit IRC
372 2018-06-12T21:54:21  *** nmnkgl has joined #bitcoin-core-dev
373 2018-06-12T22:01:24  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
374 2018-06-12T22:01:24  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
375 2018-06-12T22:13:35  *** jojeyh has quit IRC
376 2018-06-12T22:16:51  *** Cogito_Ergo_Sum has quit IRC
377 2018-06-12T22:23:27  *** owowo has quit IRC
378 2018-06-12T22:35:57  *** owowo has joined #bitcoin-core-dev
379 2018-06-12T22:38:05  *** bitconner has joined #bitcoin-core-dev
380 2018-06-12T22:43:54  *** Anduck has joined #bitcoin-core-dev
381 2018-06-12T22:46:16  *** Guyver2 has quit IRC
382 2018-06-12T23:14:23  *** promag has joined #bitcoin-core-dev
383 2018-06-12T23:15:56  *** herzmeister[m] has quit IRC
384 2018-06-12T23:16:01  *** kewde[m] has quit IRC
385 2018-06-12T23:16:11  *** stepa[m] has quit IRC
386 2018-06-12T23:17:57  *** squarfed[m] has quit IRC
387 2018-06-12T23:17:57  *** joshb[m] has quit IRC
388 2018-06-12T23:17:57  *** ajtowns[m] has quit IRC
389 2018-06-12T23:28:12  *** evenzhou has joined #bitcoin-core-dev
390 2018-06-12T23:30:14  *** nekotribal has quit IRC
391 2018-06-12T23:32:38  *** herzmeister[m] has joined #bitcoin-core-dev
392 2018-06-12T23:35:13  *** promag has quit IRC
393 2018-06-12T23:36:08  *** drexl has quit IRC
394 2018-06-12T23:40:07  *** promag has joined #bitcoin-core-dev
395 2018-06-12T23:47:15  *** kewde[m] has joined #bitcoin-core-dev
396 2018-06-12T23:47:15  *** ajtowns[m] has joined #bitcoin-core-dev
397 2018-06-12T23:47:15  *** joshb[m] has joined #bitcoin-core-dev
398 2018-06-12T23:47:16  *** squarfed[m] has joined #bitcoin-core-dev
399 2018-06-12T23:47:16  *** stepa[m] has joined #bitcoin-core-dev
400 2018-06-12T23:52:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev