12018-06-18T00:01:31 *** nuke_bloodaxe has quit IRC
22018-06-18T00:02:58 *** Emcy has quit IRC
32018-06-18T00:35:17 <bitcoin-git> [bitcoin] qmma70 opened pull request #13490: Rewind when active block tip is higher than nStopAtHeight (master...rewind) https://github.com/bitcoin/bitcoin/pull/13490
42018-06-18T00:38:49 <gmaxwell> uh, that would make stop at height less useful for me. :(
52018-06-18T00:39:43 <gmaxwell> sjors request for a 'determinstic blockchain snapshot' as I understand what he's saying wouldn't be achieved by that
62018-06-18T00:44:24 <sipa> isn't there an easier solution to make sure ABC just doesn't pass the stopatheight value?
72018-06-18T00:45:53 <luke-jr> or just have a tx spend index, so we can calculate past UTXO states if that's the goal
82018-06-18T00:46:42 <gmaxwell> why tie it with stop at height, we could have a version of invalidateblock that rewinds to a particular block.
92018-06-18T00:47:38 <sipa> well the fact that -stopatheight doesn't actually stop at that height is a bug afaik, and it should be fixed
102018-06-18T00:47:59 <sipa> but going past it and then rolling back seems like an enormously roundabout way of accomplishing that
112018-06-18T00:48:39 <gmaxwell> ::nods::
122018-06-18T00:51:59 <sipa> actually i don't understand how this is possible at all, except in case there is a reorg just around that height
132018-06-18T00:53:10 *** jtimon has quit IRC
142018-06-18T00:54:53 *** belcher has joined #bitcoin-core-dev
152018-06-18T00:55:41 *** promag has quit IRC
162018-06-18T00:55:56 *** promag has joined #bitcoin-core-dev
172018-06-18T00:56:04 <gmaxwell> in any case if someone needs a utxo set at a particular place it should be triggered by blockhash
182018-06-18T01:01:12 <bitcoin-git> [bitcoin] sipa opened pull request #13491: Improve handling of INVALID in IsMine (master...201806_cleanmine) https://github.com/bitcoin/bitcoin/pull/13491
192018-06-18T01:46:05 *** fanquake has joined #bitcoin-core-dev
202018-06-18T01:49:45 *** meshcollider has quit IRC
212018-06-18T01:50:47 <bitcoin-git> [bitcoin] promag opened pull request #13492: Fix reply not sent when event loop terminates prematurely (master...2018-06-http-shutdown) https://github.com/bitcoin/bitcoin/pull/13492
222018-06-18T01:58:34 *** promag has quit IRC
232018-06-18T02:00:40 *** str4d has joined #bitcoin-core-dev
242018-06-18T02:01:35 *** promag has joined #bitcoin-core-dev
252018-06-18T02:10:06 *** promag has quit IRC
262018-06-18T02:20:46 *** promag has joined #bitcoin-core-dev
272018-06-18T02:22:21 *** str4d has quit IRC
282018-06-18T02:25:46 *** promag has quit IRC
292018-06-18T02:26:50 *** TESTA has quit IRC
302018-06-18T02:36:30 *** justanotheruser has quit IRC
312018-06-18T02:37:15 *** justan0theruser has joined #bitcoin-core-dev
322018-06-18T02:37:31 <bitcoin-git> [bitcoin] ken2812221 closed pull request #13485: Ensure that http event loop is empty before the loop exit (master...http_shutdown) https://github.com/bitcoin/bitcoin/pull/13485
332018-06-18T03:09:36 *** fanquake has quit IRC
342018-06-18T03:09:54 *** fanquake has joined #bitcoin-core-dev
352018-06-18T03:10:39 *** fanquake has joined #bitcoin-core-dev
362018-06-18T03:11:30 *** fanquake has joined #bitcoin-core-dev
372018-06-18T03:12:15 *** fanquake has joined #bitcoin-core-dev
382018-06-18T03:12:43 *** fanquake has quit IRC
392018-06-18T03:16:44 *** fanquake has joined #bitcoin-core-dev
402018-06-18T03:31:11 *** Victorsueca has quit IRC
412018-06-18T03:32:32 *** Victorsueca has joined #bitcoin-core-dev
422018-06-18T03:36:58 *** goatpig has joined #bitcoin-core-dev
432018-06-18T04:00:32 *** fanquake has quit IRC
442018-06-18T04:05:27 *** intcat has quit IRC
452018-06-18T04:06:21 *** intcat has joined #bitcoin-core-dev
462018-06-18T04:13:24 *** Krellan has quit IRC
472018-06-18T04:14:07 *** Krellan has joined #bitcoin-core-dev
482018-06-18T04:35:03 <bitcoin-git> [bitcoin] fanquake opened pull request #13493: gui: Add leading 0 to QT_VERSION check for QFontDatabase (master...remove-qtversion-qfontdatabase) https://github.com/bitcoin/bitcoin/pull/13493
492018-06-18T05:07:17 *** unholymachine has quit IRC
502018-06-18T05:16:43 *** Emcy has joined #bitcoin-core-dev
512018-06-18T06:02:24 *** justan0theruser has quit IRC
522018-06-18T06:02:47 *** justanotheruser has joined #bitcoin-core-dev
532018-06-18T07:41:28 *** setpill has joined #bitcoin-core-dev
542018-06-18T07:51:01 *** laurentmt has joined #bitcoin-core-dev
552018-06-18T07:56:14 *** laurentmt has quit IRC
562018-06-18T08:06:07 *** HearingVo has joined #bitcoin-core-dev
572018-06-18T08:06:17 <HearingVo> Can someone provide me with some BitCoin?
582018-06-18T08:08:34 *** Victorsueca has quit IRC
592018-06-18T08:10:01 *** Victorsueca has joined #bitcoin-core-dev
602018-06-18T08:11:05 *** timothy has joined #bitcoin-core-dev
612018-06-18T08:15:35 *** drizztbsd has joined #bitcoin-core-dev
622018-06-18T08:16:34 *** timothy has quit IRC
632018-06-18T08:19:01 *** d9b4bef9 has quit IRC
642018-06-18T08:20:08 *** d9b4bef9 has joined #bitcoin-core-dev
652018-06-18T08:22:42 *** setpill has quit IRC
662018-06-18T08:24:10 *** setpill has joined #bitcoin-core-dev
672018-06-18T08:29:56 *** promag has joined #bitcoin-core-dev
682018-06-18T08:35:42 *** rk3y has quit IRC
692018-06-18T08:35:43 *** rk3y has joined #bitcoin-core-dev
702018-06-18T08:39:28 *** HearingVo has left #bitcoin-core-dev
712018-06-18T08:48:46 <promag> jonasschnelli: friendly ping #13111
722018-06-18T08:48:49 <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
732018-06-18T08:54:59 *** setpill has quit IRC
742018-06-18T08:56:02 *** rafalcpp has joined #bitcoin-core-dev
752018-06-18T08:56:19 *** setpill has joined #bitcoin-core-dev
762018-06-18T09:03:57 *** setpill has quit IRC
772018-06-18T09:04:26 *** setpill has joined #bitcoin-core-dev
782018-06-18T09:11:35 *** AaronvanW has joined #bitcoin-core-dev
792018-06-18T09:16:37 *** Deinogalerix21 has joined #bitcoin-core-dev
802018-06-18T09:19:01 *** Aaronvan_ has joined #bitcoin-core-dev
812018-06-18T09:20:44 *** Aaronvan_ is now known as AaronvanW_
822018-06-18T09:22:09 *** AaronvanW has quit IRC
832018-06-18T09:24:34 *** jtimon has joined #bitcoin-core-dev
842018-06-18T09:30:56 *** fanquake has joined #bitcoin-core-dev
852018-06-18T09:33:18 *** Deinogalerix21 has quit IRC
862018-06-18T09:38:28 *** fanquake has quit IRC
872018-06-18T09:43:42 *** gnappuraz has joined #bitcoin-core-dev
882018-06-18T09:44:21 <gnappuraz> Hi, I have a question regarding some bitcoin source code i'm trying to understand. Is this the right place?
892018-06-18T09:49:14 *** Deinogalerix21 has joined #bitcoin-core-dev
902018-06-18T09:51:19 <jonasschnelli> promag: Yes. Will review this afternoon
912018-06-18T09:51:40 <promag> gnappuraz: just ask
922018-06-18T09:51:43 <promag> jonasschnelli: nice
932018-06-18T09:53:46 *** Deinogalerix21 has quit IRC
942018-06-18T09:54:40 <gnappuraz> I was looking at the wallet.h file, there is a mapWallet map<uint256, CWalletTx>... I was trying to figure out what this map exactly contains
952018-06-18T09:56:08 <gnappuraz> it seems the main memory storage to bookkeep the transactions seen so far. Not sure if invalid txs and txs from forks are there too though
962018-06-18T09:58:02 <jonasschnelli> gnappuraz: What do you mean with invalid txns?
972018-06-18T09:58:21 <jonasschnelli> Yes. It is the main storage for transactions filtered out of the blockchain and mempool that are relevant to the wallet keys
982018-06-18T09:58:48 <gnappuraz> also orphans?
992018-06-18T09:58:52 <jonasschnelli> But they are checked for confirmation or conflicts during presentation... so you can't assume that all transactions in mapWallet are confirmed, etc.
1002018-06-18T09:58:56 <jonasschnelli> Orphans possible, yes.
1012018-06-18T09:59:04 <gnappuraz> ok thank you very much!
1022018-06-18T09:59:28 <jonasschnelli> Its just a set of transactions that have relevance to your keys/scripts in your wallet...
1032018-06-18T09:59:57 <jonasschnelli> If you want to render a balance, etc. you need to check / calculate if the transactions counts, etc.
1042018-06-18T10:00:03 <gnappuraz> if instead I need to fetch txs that are not related to my wallet?
1052018-06-18T10:00:50 <jonasschnelli> gnappuraz: depends... if you know the blockhash/heigh and the txid, you can use getrawtransaction
1062018-06-18T10:01:04 <jonasschnelli> If you only know the txid, you may need the -txindex=1 (enabled tx index)
1072018-06-18T10:01:34 <gnappuraz> right, thanks
1082018-06-18T10:02:00 <jonasschnelli> The wallet is a partial indexing service for the blockchain,... it "indexes" transactions relevant to the keys/scripts in the wallet
1092018-06-18T10:02:17 <jonasschnelli> (it not only indexes, it "extracts" the transactions)
1102018-06-18T10:02:30 <gnappuraz> i understand
1112018-06-18T10:31:26 *** fanquake has joined #bitcoin-core-dev
1122018-06-18T10:31:45 <fanquake> wumpus: You commented on the wrong PR re squashing commits
1132018-06-18T10:41:01 <wumpus> fanquake: yep, resolved now
1142018-06-18T10:45:02 <fanquake> qt4 changes looking good
1152018-06-18T10:46:02 <fanquake> managed to engage the wrong @wumpus again
1162018-06-18T10:46:38 <promag> thanks jonas, will sort it out
1172018-06-18T10:57:52 *** setpill has quit IRC
1182018-06-18T10:58:13 <fanquake> provoostenator: As far as I can tell I've gotten ios cross builds working. Will PR some depends changes shortly.
1192018-06-18T10:58:19 *** setpill has joined #bitcoin-core-dev
1202018-06-18T11:14:37 <murrayn> was there not a time, not so long ago, where transaction age was a factor in prioritization? am i misremembering?
1212018-06-18T11:17:52 <wumpus> utxo age was
1222018-06-18T11:19:06 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6cf4bd7eb3b...45c00f841612
1232018-06-18T11:19:07 <bitcoin-git> bitcoin/master 3352da8 practicalswift: Add "export LC_ALL=C" to all shell scripts
1242018-06-18T11:19:07 <bitcoin-git> bitcoin/master 47776a9 practicalswift: Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
1252018-06-18T11:19:08 <bitcoin-git> bitcoin/master 45c00f8 Wladimir J. van der Laan: Merge #13454: Make sure LC_ALL=C is set in all shell scripts...
1262018-06-18T11:19:51 <bitcoin-git> [bitcoin] laanwj closed pull request #13454: Make sure LC_ALL=C is set in all shell scripts (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454
1272018-06-18T11:20:32 <wumpus> it used to be the sorting criterion for the free transaction area that some miners maintained in blocks
1282018-06-18T11:22:34 *** vicenteH has joined #bitcoin-core-dev
1292018-06-18T11:24:05 *** gnappuraz has quit IRC
1302018-06-18T11:56:41 *** Victorsueca has quit IRC
1312018-06-18T11:58:01 *** Victorsueca has joined #bitcoin-core-dev
1322018-06-18T12:00:49 <promag> jonasschnelli: pushed a fix
1332018-06-18T12:01:23 <jonasschnelli> promag: will test asap
1342018-06-18T12:02:11 <promag> jonasschnelli: ty
1352018-06-18T12:03:12 <promag> jonasschnelli: now in the main window the wallet selector hidden when there is only 1 wallet loaded
1362018-06-18T12:03:22 <promag> *is hidden*
1372018-06-18T12:03:39 <rabidus> oispa liivit
1382018-06-18T12:03:49 <rabidus> oops sorry, wrong channel :(
1392018-06-18T12:04:20 <promag> jonasschnelli: we should create a model for wallets no?
1402018-06-18T12:04:52 <promag> btw, any objection to change QObject::connect to qt5 syntax (after qt4 is dropped)?
1412018-06-18T12:08:27 *** promag has quit IRC
1422018-06-18T12:12:25 <fanquake> promag sounds good
1432018-06-18T12:15:01 *** d9b4bef9 has quit IRC
1442018-06-18T12:18:08 *** d9b4bef9 has joined #bitcoin-core-dev
1452018-06-18T12:21:27 <bitcoin-git> [bitcoin] practicalswift opened pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
1462018-06-18T12:26:28 *** ahp1992 has joined #bitcoin-core-dev
1472018-06-18T12:26:36 <ahp1992> hi
1482018-06-18T12:27:31 <ahp1992> hello all
1492018-06-18T12:28:33 *** promag has joined #bitcoin-core-dev
1502018-06-18T12:31:45 <promag> thank fanquake
1512018-06-18T12:34:07 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/45c00f841612...d67eff8002d7
1522018-06-18T12:34:07 <bitcoin-git> bitcoin/master 7b23e6e practicalswift: Follow-up to #13454: Fix broken build by exporting LC_ALL=C
1532018-06-18T12:34:08 <bitcoin-git> bitcoin/master d67eff8 MarcoFalke: Merge #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C...
1542018-06-18T12:34:59 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
1552018-06-18T12:38:04 *** promag has quit IRC
1562018-06-18T12:39:20 *** setpill has quit IRC
1572018-06-18T12:39:50 *** setpill has joined #bitcoin-core-dev
1582018-06-18T12:52:09 *** jhfrontz has joined #bitcoin-core-dev
1592018-06-18T12:54:51 <ahp1992> let me know, how can i study to do own currency using bitcoin core.
1602018-06-18T12:58:28 *** promag has joined #bitcoin-core-dev
1612018-06-18T13:00:51 *** ahp1992 has quit IRC
1622018-06-18T13:03:32 *** promag has quit IRC
1632018-06-18T13:05:01 <fanquake> ahp1992 off-topic here.
1642018-06-18T13:05:54 *** fanquake has quit IRC
1652018-06-18T13:08:56 *** Guyver2 has joined #bitcoin-core-dev
1662018-06-18T13:19:53 *** promag has joined #bitcoin-core-dev
1672018-06-18T13:20:01 *** ExtraCrispy has quit IRC
1682018-06-18T13:21:40 *** codyrutscher has joined #bitcoin-core-dev
1692018-06-18T13:24:55 *** berndj has quit IRC
1702018-06-18T13:28:57 *** berndj has joined #bitcoin-core-dev
1712018-06-18T13:31:47 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d67eff8002d7...2d071f5a7055
1722018-06-18T13:31:47 <bitcoin-git> bitcoin/master 55771b7 lucash.dev@gmail.com: Removed unused == operator from CMutableTransaction.
1732018-06-18T13:31:48 <bitcoin-git> bitcoin/master 2d071f5 Wladimir J. van der Laan: Merge #13443: Removed unused == operator from CMutableTransaction....
1742018-06-18T13:32:28 <bitcoin-git> [bitcoin] laanwj closed pull request #13443: Removed unused == operator from CMutableTransaction. (master...remove-CMutableTransaction-equals) https://github.com/bitcoin/bitcoin/pull/13443
1752018-06-18T13:32:50 *** ExtraCrispy has joined #bitcoin-core-dev
1762018-06-18T13:33:03 *** codyrutscher has quit IRC
1772018-06-18T13:35:00 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2d071f5a7055...450055bdbdcb
1782018-06-18T13:35:00 <bitcoin-git> bitcoin/master 1e1eb63 Pieter Wuille: Improve coverage of SHA256 SelfTest code
1792018-06-18T13:35:01 <bitcoin-git> bitcoin/master 450055b Wladimir J. van der Laan: Merge #13438: Improve coverage of SHA256 SelfTest code...
1802018-06-18T13:35:53 <bitcoin-git> [bitcoin] laanwj closed pull request #13438: Improve coverage of SHA256 SelfTest code (master...201806_selftestsha) https://github.com/bitcoin/bitcoin/pull/13438
1812018-06-18T14:01:13 *** Gnappuraz has joined #bitcoin-core-dev
1822018-06-18T14:06:07 *** qu4ku has joined #bitcoin-core-dev
1832018-06-18T14:12:47 *** SopaXorzTaker has joined #bitcoin-core-dev
1842018-06-18T14:17:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1852018-06-18T14:27:14 *** grafcaps has joined #bitcoin-core-dev
1862018-06-18T14:31:00 *** jhfrontz has quit IRC
1872018-06-18T14:32:46 *** grafcaps has quit IRC
1882018-06-18T14:39:04 *** qu4ku has quit IRC
1892018-06-18T14:48:25 *** jhfrontz has joined #bitcoin-core-dev
1902018-06-18T14:55:30 <jonasschnelli> sipa: would it be possible to have 3 different BCHs in Bech32X (three length of checksum)?
1912018-06-18T15:07:55 *** ken2812221 has quit IRC
1922018-06-18T15:08:05 *** ctrlbreak has quit IRC
1932018-06-18T15:08:24 *** ken2812221 has joined #bitcoin-core-dev
1942018-06-18T15:08:27 *** ctrlbreak has joined #bitcoin-core-dev
1952018-06-18T15:12:56 *** jwhoisthat has quit IRC
1962018-06-18T15:13:25 *** grafcaps has joined #bitcoin-core-dev
1972018-06-18T15:17:50 *** miya has joined #bitcoin-core-dev
1982018-06-18T15:19:23 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/450055bdbdcb...ac3224c8eea9
1992018-06-18T15:19:24 <bitcoin-git> bitcoin/master fafa270 MarcoFalke: Make ReceivedBlockTransactions return void
2002018-06-18T15:19:24 <bitcoin-git> bitcoin/master ac3224c Wladimir J. van der Laan: Merge #13412: Make ReceivedBlockTransactions return void...
2012018-06-18T15:20:15 <bitcoin-git> [bitcoin] laanwj closed pull request #13412: Make ReceivedBlockTransactions return void (master...Mf1806-refactorReturnCodeValidation) https://github.com/bitcoin/bitcoin/pull/13412
2022018-06-18T15:21:28 <bitcoin-git> [bitcoin] wodry opened pull request #13496: Test: Harden lint-filenames.sh (master...harden-test-lint-filenames.sh) https://github.com/bitcoin/bitcoin/pull/13496
2032018-06-18T15:22:40 *** miya has quit IRC
2042018-06-18T15:27:33 *** Ylbam has joined #bitcoin-core-dev
2052018-06-18T15:30:39 <sipa> jonasschnelli: sure, what lengths
2062018-06-18T15:31:24 <jonasschnelli> I think 7, 14, and 21 (correction)
2072018-06-18T15:32:26 <jonasschnelli> Or maybe 7, 14, 28
2082018-06-18T15:32:38 <jonasschnelli> 7 is ~5%, 14: ~10%, 28: ~20%
2092018-06-18T15:32:51 <jonasschnelli> (for 512bit)
2102018-06-18T15:34:43 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac3224c8eea9...088240685456
2112018-06-18T15:34:44 <bitcoin-git> bitcoin/master faa18ca MarcoFalke: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
2122018-06-18T15:34:44 <bitcoin-git> bitcoin/master 0882406 Wladimir J. van der Laan: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds...
2132018-06-18T15:35:40 <bitcoin-git> [bitcoin] laanwj closed pull request #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (master...Mf1806-walletPrunedFundsSegfault) https://github.com/bitcoin/bitcoin/pull/13437
2142018-06-18T15:39:40 *** jwhoisthat has joined #bitcoin-core-dev
2152018-06-18T15:48:32 *** promag has quit IRC
2162018-06-18T15:59:01 *** d9b4bef9 has quit IRC
2172018-06-18T16:00:08 *** d9b4bef9 has joined #bitcoin-core-dev
2182018-06-18T16:02:40 *** Ango_ has joined #bitcoin-core-dev
2192018-06-18T16:07:04 *** qu4ku has joined #bitcoin-core-dev
2202018-06-18T16:08:02 *** Krellan has quit IRC
2212018-06-18T16:13:08 *** Ango_ has quit IRC
2222018-06-18T16:25:13 *** Krellan has joined #bitcoin-core-dev
2232018-06-18T16:29:47 *** setpill has quit IRC
2242018-06-18T16:37:07 <bitcoin-git> [bitcoin] jnewbery opened pull request #13498: [wallet] Fixups from account API deprecation (master...account_deprecation_fixups) https://github.com/bitcoin/bitcoin/pull/13498
2252018-06-18T17:00:57 *** rafalcpp has quit IRC
2262018-06-18T17:07:15 *** dendisuhubdy has joined #bitcoin-core-dev
2272018-06-18T17:08:11 *** rafalcpp has joined #bitcoin-core-dev
2282018-06-18T17:17:53 *** harrymm has quit IRC
2292018-06-18T17:21:43 *** nmnkgl has joined #bitcoin-core-dev
2302018-06-18T17:29:10 *** Krellan has quit IRC
2312018-06-18T17:30:46 *** harrymm has joined #bitcoin-core-dev
2322018-06-18T17:33:31 *** Chris_Stewart_5 has quit IRC
2332018-06-18T17:39:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2342018-06-18T17:47:08 *** Ylbam has quit IRC
2352018-06-18T17:57:22 *** Gnappuraz has quit IRC
2362018-06-18T17:58:49 *** Tester_ has joined #bitcoin-core-dev
2372018-06-18T18:05:54 *** drizztbsd has quit IRC
2382018-06-18T18:08:24 *** drexl has joined #bitcoin-core-dev
2392018-06-18T18:08:50 *** qu4ku has quit IRC
2402018-06-18T18:19:23 *** SopaXorzTaker has quit IRC
2412018-06-18T19:01:53 *** dendisuhubdy has quit IRC
2422018-06-18T19:02:15 <sipa> jonasschnelli: around?
2432018-06-18T19:02:44 <jonasschnelli> sipa: yes (phonetyping)
2442018-06-18T19:04:25 <sipa> jonasschnelli: i have a few thoughts on a format for describing sets of scriptPubKey
2452018-06-18T19:04:54 <sipa> it's probably more complicated than what you're thinking about, but it's also pretty much what i'd want the entire wallet to migrate to
2462018-06-18T19:05:06 <sipa> i'll do a writeup/prototype over the next few days if you're interested
2472018-06-18T19:05:28 <jonasschnelli> sure. I think we could first use it for the scantxoutset
2482018-06-18T19:05:38 <sipa> yeah
2492018-06-18T19:06:07 <sipa> but it would also support things like multisig of multiple hd paths etc
2502018-06-18T19:06:37 <jonasschnelli> I think that's great... i guess it's related to your thoughts on PSBT
2512018-06-18T19:06:52 <sipa> yes
2522018-06-18T19:07:20 <sipa> and also for supporting hw wallets directly in core, and forward compatibility with schnorr etc
2532018-06-18T19:07:45 <jonasschnelli> Good.
2542018-06-18T19:08:02 <jonasschnelli> I wanted to comment about the encoding...
2552018-06-18T19:08:30 <jonasschnelli> Do you think pure binary serialization is unacceptable?
2562018-06-18T19:08:38 <sipa> for psbt?
2572018-06-18T19:08:43 <jonasschnelli> yes
2582018-06-18T19:08:53 <sipa> sure, that'd be the most common thing to do
2592018-06-18T19:08:59 <jonasschnelli> or where do you see advantages of base64 and z85, etc.
2602018-06-18T19:09:03 <sipa> but we can't put pure binary in an RPC response
2612018-06-18T19:09:12 <jonasschnelli> yes. sure.
2622018-06-18T19:09:28 <sipa> the common assumption i think is using hex
2632018-06-18T19:09:46 <jonasschnelli> yeah... I guess size won't matter to much on that layer
2642018-06-18T19:09:55 <sipa> but as i know how annoying raw transactions in hex can be to copy paste, i wanted to suggest something smaller
2652018-06-18T19:10:02 <sipa> and z85 looks pretty neat actually
2662018-06-18T19:10:08 <jonasschnelli> yes. I like it.
2672018-06-18T19:10:10 <sipa> it's 5 characters per 4 bytes
2682018-06-18T19:10:33 <jonasschnelli> but PSBT could also have it own file type... end user could email and dbl-click etc
2692018-06-18T19:10:42 <sipa> it probably should
2702018-06-18T19:11:18 <jonasschnelli> For RPC it will be a long chuck of text. both with hex or z85.
2712018-06-18T19:11:25 <sipa> yes
2722018-06-18T19:11:51 <sipa> but 1.6x shorter with z85
2732018-06-18T19:12:26 <jonasschnelli> Yes. But hassle on the client side... eventually opt-in?
2742018-06-18T19:12:48 <sipa> yeah, the burden of implementing z85 would be a deterrent i guess
2752018-06-18T19:12:58 <sipa> base64 is more common
2762018-06-18T19:13:12 <jonasschnelli> Yes.
2772018-06-18T19:13:15 <sipa> i don't care much; i just brought it up because it would be good to standardize on one
2782018-06-18T19:13:49 <jonasschnelli> I think z85 brings in some perfection and I generally think it's worth to explore
2792018-06-18T19:14:18 <sipa> cfields: what clang version will be used for 0.17 osx builds?
2802018-06-18T19:14:35 <jonasschnelli> and it not very complex so if one can deal with PSBT, z85 seem a trivial puzzlepiece
2812018-06-18T19:14:51 <jonasschnelli> *its
2822018-06-18T19:28:37 *** BashCo has quit IRC
2832018-06-18T19:30:14 *** BashCo has joined #bitcoin-core-dev
2842018-06-18T19:30:15 *** andytoshi has quit IRC
2852018-06-18T19:30:23 *** andytoshi has joined #bitcoin-core-dev
2862018-06-18T19:30:24 *** andytoshi has joined #bitcoin-core-dev
2872018-06-18T19:38:00 *** Randolf has joined #bitcoin-core-dev
2882018-06-18T19:39:54 *** laurentmt has joined #bitcoin-core-dev
2892018-06-18T19:59:57 *** promag has joined #bitcoin-core-dev
2902018-06-18T20:03:05 *** laurentmt has quit IRC
2912018-06-18T20:03:05 <bitcoin-git> [bitcoin] JeremyRubin reopened pull request #12763: Add RPC Whitelist Feature from #12248 (master...whitelistrpc) https://github.com/bitcoin/bitcoin/pull/12763
2922018-06-18T20:06:10 *** goatpig has quit IRC
2932018-06-18T20:08:27 <bitcoin-git> [bitcoin] jamesob closed pull request #12407: Ensure nStatus is set properly for all invalid blocks (master...jamesob/2018-02-mark-headers-invalid) https://github.com/bitcoin/bitcoin/pull/12407
2942018-06-18T20:15:05 *** nmnkgl has quit IRC
2952018-06-18T20:15:41 *** nmnkgl has joined #bitcoin-core-dev
2962018-06-18T20:19:57 *** nmnkgl has quit IRC
2972018-06-18T20:23:24 *** Guyver2 has quit IRC
2982018-06-18T20:35:41 *** qu4ku has joined #bitcoin-core-dev
2992018-06-18T20:40:37 *** qu4ku has quit IRC
3002018-06-18T20:45:27 *** Randolf has quit IRC
3012018-06-18T21:19:35 *** nmnkgl has joined #bitcoin-core-dev
3022018-06-18T21:30:18 *** drexl_ has joined #bitcoin-core-dev
3032018-06-18T21:32:59 *** drexl has quit IRC
3042018-06-18T21:33:06 *** drexl_ is now known as drexl
3052018-06-18T21:36:55 *** jojeyh has quit IRC
3062018-06-18T21:42:02 *** CubicEarths has quit IRC
3072018-06-18T21:42:41 *** CubicEarths has joined #bitcoin-core-dev
3082018-06-18T21:47:23 *** CubicEarths has quit IRC
3092018-06-18T21:53:26 *** nkohen has joined #bitcoin-core-dev
3102018-06-18T21:54:29 *** tryphe_ is now known as tryphe
3112018-06-18T21:55:14 <nkohen> Does anyone know what the intended functionality of combinerawtransaction is with bitcoind?
3122018-06-18T21:57:56 <sipa> nkohen: create a raw transaction for a 2-of-2 multisig, give it to both parties, each sign their part with a single signature; combinerawtransaction will turn it into a full transaction
3132018-06-18T22:01:02 <nkohen> Thanks!
3142018-06-18T22:05:55 *** dgenr8 has quit IRC
3152018-06-18T22:06:26 *** spinza has quit IRC
3162018-06-18T22:11:26 *** dgenr8 has joined #bitcoin-core-dev
3172018-06-18T22:17:14 *** grafcaps has quit IRC
3182018-06-18T22:19:49 *** spinza has joined #bitcoin-core-dev
3192018-06-18T22:31:48 <bitcoin-git> [bitcoin] achow101 opened pull request #13500: [wallet] Decouple wallet version from client version (master...decouple-wallet-version) https://github.com/bitcoin/bitcoin/pull/13500
3202018-06-18T22:31:55 *** nekotribal_ has quit IRC
3212018-06-18T22:33:15 *** rev_strangehope_ is now known as revstrangehope
3222018-06-18T22:35:00 <gmaxwell> sipa: is z85 as copy and paste friendly as base64?
3232018-06-18T22:38:45 *** AaronvanW_ has quit IRC
3242018-06-18T22:39:21 *** AaronvanW has joined #bitcoin-core-dev
3252018-06-18T22:41:55 <sipa> gmaxwell: probably not
3262018-06-18T22:42:43 <sipa> it's designed to not need escaping in typical programming languages when surrounded by quotation marks, though
3272018-06-18T22:43:27 *** AaronvanW has quit IRC
3282018-06-18T22:43:28 <sipa> wait, what do you mean by copy-paste friendly?
3292018-06-18T22:46:11 *** Chris_Stewart_5 has quit IRC
3302018-06-18T22:48:17 *** CubicEarths has joined #bitcoin-core-dev
3312018-06-18T22:48:49 <bitcoin-git> [bitcoin] promag opened pull request #13501: Remove race on shutdown between event loop exit and http reply (master...2018-06-loopexit) https://github.com/bitcoin/bitcoin/pull/13501
3322018-06-18T22:49:14 *** meshcollider has joined #bitcoin-core-dev
3332018-06-18T22:51:04 <gmaxwell> sipa: mostly not having weird escape characters that will cause misbehavior when pasted.
3342018-06-18T22:52:01 <gmaxwell> it has / which is unfortunate for pasting into IRC.
3352018-06-18T22:52:28 <sipa> gmaxwell: it excludes \ ' " ; ,
3362018-06-18T22:52:50 <sipa> and |
3372018-06-18T22:53:16 <sipa> if it would have excluded < / >, and included , ; | instead it would be clean html
3382018-06-18T22:53:21 *** AaronvanW has joined #bitcoin-core-dev
3392018-06-18T22:53:53 <gmaxwell> I'm surprised it doesn't include ,;| as those are generally safe AFAIK.
3402018-06-18T22:54:07 <sipa> yup
3412018-06-18T22:54:57 <sipa> hmm, there are are 94 non-space printable ascii characters
3422018-06-18T22:55:03 <sipa> so 9 must be excluded
3432018-06-18T22:58:08 *** nkohen has quit IRC
3442018-06-18T22:59:03 <sipa> \ ' " ; , | ` ~
3452018-06-18T22:59:07 <sipa> i must be missing one still
3462018-06-18T22:59:08 *** Empact_ has joined #bitcoin-core-dev
3472018-06-18T23:00:50 *** AaronvanW has quit IRC
3482018-06-18T23:01:01 <gmaxwell> https://tools.ietf.org/html/rfc1924 has < and > but leaves out the slashes.
3492018-06-18T23:01:20 <gmaxwell> it gives rationale for each of the omitted characters.
3502018-06-18T23:01:26 *** AaronvanW has joined #bitcoin-core-dev
3512018-06-18T23:02:10 *** Empact has quit IRC
3522018-06-18T23:02:30 <sipa> that's specific for ipv6 addresses, though
3532018-06-18T23:02:36 <sipa> for example the chose to exclude [ ]
3542018-06-18T23:03:12 <gmaxwell> Right. & is also an escape character that should be aboided.
3552018-06-18T23:03:17 <gmaxwell> (at that document argues,
3562018-06-18T23:04:07 <gmaxwell> <>"'`/\&. seem more obvious safe characters to exclude to me.
3572018-06-18T23:05:39 <sipa> or just base64... only 6.25% less efficient
3582018-06-18T23:05:46 *** AaronvanW has quit IRC
3592018-06-18T23:05:51 <sipa> and far more common
3602018-06-18T23:06:18 <gmaxwell> it is sad that base64 has / but at least it's a common and well understood thing.
3612018-06-18T23:06:26 <sipa> the base85 trick of encoding 32-bit integers is neat, though
3622018-06-18T23:10:07 *** CubicEarths has quit IRC
3632018-06-18T23:10:14 *** drexl has quit IRC
3642018-06-18T23:21:22 *** Randolf has joined #bitcoin-core-dev
3652018-06-18T23:33:20 *** vicenteH has quit IRC
3662018-06-18T23:39:12 *** AaronvanW has joined #bitcoin-core-dev
3672018-06-18T23:45:42 *** AaronvanW has quit IRC
3682018-06-18T23:46:19 *** AaronvanW has joined #bitcoin-core-dev
3692018-06-18T23:50:43 *** AaronvanW has quit IRC
3702018-06-18T23:55:13 *** fanquake has joined #bitcoin-core-dev
3712018-06-18T23:59:15 *** AaronvanW has joined #bitcoin-core-dev