1 2018-07-31T00:02:10  *** Krellan has quit IRC
  2 2018-07-31T00:06:55  *** masonicboom has joined #bitcoin-core-dev
  3 2018-07-31T00:12:01  *** masonicboom has quit IRC
  4 2018-07-31T00:14:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  5 2018-07-31T00:16:39  *** wraithm has quit IRC
  6 2018-07-31T00:17:26  *** wraithm has joined #bitcoin-core-dev
  7 2018-07-31T00:17:52  *** AaronvanW has quit IRC
  8 2018-07-31T00:20:15  *** Krellan has joined #bitcoin-core-dev
  9 2018-07-31T00:28:17  *** AaronvanW has joined #bitcoin-core-dev
 10 2018-07-31T00:30:39  *** IGHOR has quit IRC
 11 2018-07-31T00:31:27  *** IGHOR has joined #bitcoin-core-dev
 12 2018-07-31T00:33:22  *** AaronvanW has quit IRC
 13 2018-07-31T00:34:05  *** Chris_Stewart_5 has quit IRC
 14 2018-07-31T00:50:26  *** Orion3k has quit IRC
 15 2018-07-31T01:01:51  *** masonicboom has joined #bitcoin-core-dev
 16 2018-07-31T01:06:09  *** Krellan has quit IRC
 17 2018-07-31T01:06:35  *** masonicboom has quit IRC
 18 2018-07-31T01:25:08  *** Krellan has joined #bitcoin-core-dev
 19 2018-07-31T01:27:34  *** Orion3k has joined #bitcoin-core-dev
 20 2018-07-31T01:29:20  *** AaronvanW has joined #bitcoin-core-dev
 21 2018-07-31T01:33:53  *** AaronvanW has quit IRC
 22 2018-07-31T02:01:49  *** masonicboom has joined #bitcoin-core-dev
 23 2018-07-31T02:06:18  *** masonicboom has quit IRC
 24 2018-07-31T02:28:03  *** tryphe has quit IRC
 25 2018-07-31T02:28:28  *** tryphe has joined #bitcoin-core-dev
 26 2018-07-31T02:42:39  *** michaelsdunn1 has quit IRC
 27 2018-07-31T03:26:44  *** promag has joined #bitcoin-core-dev
 28 2018-07-31T03:30:01  *** AaronvanW has joined #bitcoin-core-dev
 29 2018-07-31T03:31:12  *** promag has quit IRC
 30 2018-07-31T03:34:36  *** AaronvanW has quit IRC
 31 2018-07-31T03:37:18  *** Krellan has quit IRC
 32 2018-07-31T03:51:05  *** masonicboom has joined #bitcoin-core-dev
 33 2018-07-31T03:55:45  *** masonicboom has quit IRC
 34 2018-07-31T04:04:44  *** Victorsueca has quit IRC
 35 2018-07-31T04:05:53  *** Victorsueca has joined #bitcoin-core-dev
 36 2018-07-31T04:08:01  *** MarcoFalke has quit IRC
 37 2018-07-31T04:08:33  *** Orion3k has quit IRC
 38 2018-07-31T04:08:33  *** luke-jr has quit IRC
 39 2018-07-31T04:12:17  *** BCBot has quit IRC
 40 2018-07-31T04:12:53  *** MarcoFalke has joined #bitcoin-core-dev
 41 2018-07-31T04:13:27  *** luke-jr has joined #bitcoin-core-dev
 42 2018-07-31T04:17:13  *** masonicboom has joined #bitcoin-core-dev
 43 2018-07-31T04:21:39  *** Orion3k has joined #bitcoin-core-dev
 44 2018-07-31T04:23:57  *** Squidicuz has quit IRC
 45 2018-07-31T04:25:29  *** dcousens has quit IRC
 46 2018-07-31T04:26:24  *** promag has joined #bitcoin-core-dev
 47 2018-07-31T04:31:24  *** promag has quit IRC
 48 2018-07-31T04:39:29  *** kerfle has quit IRC
 49 2018-07-31T04:52:04  *** ryanofsky_ has quit IRC
 50 2018-07-31T04:52:27  *** ryanofsky has joined #bitcoin-core-dev
 51 2018-07-31T05:04:40  *** dcousens has joined #bitcoin-core-dev
 52 2018-07-31T05:08:12  *** promag has joined #bitcoin-core-dev
 53 2018-07-31T05:12:08  *** ChanServ sets mode: +o sipa
 54 2018-07-31T05:12:16  *** sipa sets mode: -n 
 55 2018-07-31T05:12:21  *** sipa sets mode: -o sipa
 56 2018-07-31T05:12:34  *** promag has quit IRC
 57 2018-07-31T05:30:45  *** AaronvanW has joined #bitcoin-core-dev
 58 2018-07-31T05:35:57  *** AaronvanW has quit IRC
 59 2018-07-31T05:43:51  *** booyah has joined #bitcoin-core-dev
 60 2018-07-31T05:50:20  <bitcoin-git> [bitcoin] practicalswift opened pull request #13815: build: Add linter to make sure the return value of Parse[...](...) is checked (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
 61 2018-07-31T06:13:42  <kallewoof> So confused. Why would the `allowhighfees` argument refuse to become an integer despite client.cpp listing it as 'to be converted'? self.nodes[2].sendrawtransaction(hexstring=rawTxSigned['hex'], allowhighfees=Decimal("0.00007000"))
 62 2018-07-31T06:14:32  <kallewoof> Actually, wrong line, it was this one: assert_raises_rpc_error(-26, "absurdly-high-fee", self.nodes[2].sendrawtransaction, rawTxSigned['hex'], Decimal("0.00001000"))
 63 2018-07-31T06:18:10  *** Emcy has quit IRC
 64 2018-07-31T06:26:32  <luke-jr> kallewoof: client.cpp is entirely irrelevant for this
 65 2018-07-31T06:26:59  <kallewoof> luke-jr: It determines if argument should be converted or kept as a string, right?
 66 2018-07-31T06:27:30  <luke-jr> kallewoof: for bitcoin-cli, which isn't tested by assert_raises_rpc_error
 67 2018-07-31T06:27:49  * kallewoof blinks
 68 2018-07-31T06:28:55  <kallewoof> So how does it know whether to format arguments or  keep as strings?
 69 2018-07-31T06:29:03  <sipa> kallewoof: it doesn't
 70 2018-07-31T06:29:15  <sipa> JSON-RPC on the wire is JSON
 71 2018-07-31T06:29:17  <sipa> not strings
 72 2018-07-31T06:29:53  <sipa> if you use Decinal in python, it is sent as a JSON number
 73 2018-07-31T06:30:29  <sipa> bitcoin-cli needs to know what arguments to treat as string literals and which ones not
 74 2018-07-31T06:30:59  <kallewoof> I'm confused. THis works: self.nodes[2].sendrawtransaction(hexstring=rawTxSigned['hex'], allowhighfees=0.00007000)
 75 2018-07-31T06:30:59  <kallewoof> And this doesn't: self.nodes[2].sendrawtransaction(hexstring=rawTxSigned['hex'], allowhighfees=Decimal("0.00007000"))
 76 2018-07-31T06:31:10  *** promag has joined #bitcoin-core-dev
 77 2018-07-31T06:31:55  <sipa> oh, i must be wrong then
 78 2018-07-31T06:32:00  <kallewoof> Unless Decimal() gives something that univalue does not consider to be isNum().. but if I write() it, it gives me [ "0.00007000" ] (with quotes)
 79 2018-07-31T06:32:14  <sipa> this has nothing to do with univalue
 80 2018-07-31T06:32:32  <kallewoof> Wait, it does, because the error is when ! isBool() and ! isNum()
 81 2018-07-31T06:32:36  <sipa> JSON has 4 data types; numbers, strings, arrays, objects
 82 2018-07-31T06:33:09  <sipa> the *python* code is converting what you pass to the sendrawtransaction function into those 4 types
 83 2018-07-31T06:33:32  <sipa> isNum failing on the bitcoind side just means you're not sending a JSON number
 84 2018-07-31T06:33:33  <kallewoof> My code goes if isBool() {..} else if isNum() {..} else throw jsonrpcerror...
 85 2018-07-31T06:33:48  <sipa> so it's presumably sending a JSON string
 86 2018-07-31T06:33:58  <sipa> oh, bools too; sorry, 5
 87 2018-07-31T06:34:02  <kallewoof> Right -- I thought Decimal() gave a JSON number. Guess not.
 88 2018-07-31T06:34:09  <sipa> i guess not :)
 89 2018-07-31T06:35:45  *** promag has quit IRC
 90 2018-07-31T06:37:21  *** ken2812221 has quit IRC
 91 2018-07-31T06:38:29  <luke-jr> probably should be made to
 92 2018-07-31T06:46:43  <kallewoof> I'm honestly pretty sure it is, and I'm screwing something up, but rounding errors are no biggie in this case so I'm going with the native variant.
 93 2018-07-31T06:48:16  *** Emcy has joined #bitcoin-core-dev
 94 2018-07-31T07:01:06  *** ken2812221 has joined #bitcoin-core-dev
 95 2018-07-31T07:02:42  *** elkalamar has quit IRC
 96 2018-07-31T07:06:14  *** elkalamar has joined #bitcoin-core-dev
 97 2018-07-31T07:15:28  *** Guest43893 has joined #bitcoin-core-dev
 98 2018-07-31T07:18:22  *** elkalamar has quit IRC
 99 2018-07-31T07:25:33  *** SopaXorzTaker has joined #bitcoin-core-dev
100 2018-07-31T07:29:12  *** elkalamar has joined #bitcoin-core-dev
101 2018-07-31T07:30:31  *** Guest43893 has quit IRC
102 2018-07-31T07:38:04  *** timothy has joined #bitcoin-core-dev
103 2018-07-31T07:41:08  *** masonicboom has quit IRC
104 2018-07-31T07:45:37  *** go1111111 has quit IRC
105 2018-07-31T07:56:24  *** promag has joined #bitcoin-core-dev
106 2018-07-31T07:58:55  *** go1111111 has joined #bitcoin-core-dev
107 2018-07-31T08:00:55  *** elkalamar has quit IRC
108 2018-07-31T08:01:00  *** promag has quit IRC
109 2018-07-31T08:40:00  *** no_input_found has quit IRC
110 2018-07-31T08:40:46  *** no_input_found has joined #bitcoin-core-dev
111 2018-07-31T08:42:27  *** elkalamar has joined #bitcoin-core-dev
112 2018-07-31T08:44:40  *** elkalamar has quit IRC
113 2018-07-31T08:48:01  *** StopAndDecrypt has quit IRC
114 2018-07-31T08:50:52  *** StopAndDecrypt has joined #bitcoin-core-dev
115 2018-07-31T09:03:19  *** face has quit IRC
116 2018-07-31T09:08:04  *** elkalamar has joined #bitcoin-core-dev
117 2018-07-31T09:13:51  *** elkalamar has quit IRC
118 2018-07-31T09:26:21  *** AaronvanW has joined #bitcoin-core-dev
119 2018-07-31T09:38:08  *** Aaronvan_ has joined #bitcoin-core-dev
120 2018-07-31T09:41:35  *** AaronvanW has quit IRC
121 2018-07-31T09:46:28  *** fanquake has joined #bitcoin-core-dev
122 2018-07-31T09:46:48  <fanquake> wumpus: heh, I saw that "loss" as well. Got emailed twice for some reason
123 2018-07-31T09:48:58  <wumpus> fanquake: well I didn't see my comment so I posted another one, then suddenly they both appeared
124 2018-07-31T09:49:21  <fanquake> wumpus GH playing tricks on you
125 2018-07-31T09:51:24  <fanquake> Also please don't merge 13809 yet, few things to be fixed up first, to avoid lots of followups
126 2018-07-31T10:02:59  <wumpus> OK, please comment that there so anyone else won't merge it either
127 2018-07-31T10:54:57  <mryandao> typically most linux distribution follow XDG specification for looking up config files, would this be preferable in Core? I know there was a previous closed issue which mentioned this, but we could keep the datadir cache separate in ~/.bitcoin as is
128 2018-07-31T10:55:39  <mryandao> the upside of this is that daemon configuration can be easier to backup for users who just scoop the entire XDG_BASE_DIR
129 2018-07-31T11:05:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
130 2018-07-31T11:08:07  <harding> mryandao: do you think there's lots of people who backup just .config/ and not their whole home directories?  The stuff in my .config represents perhaps a few hours of tweaking over years, but the stuff in the rest of my home directory represents many hours of work each day over the same number of years.
131 2018-07-31T11:08:58  <mryandao> harding: personally, i only backup my .config directory since my homedir would have accumulated a bunch of unwanted stuff in new installations.
132 2018-07-31T11:10:49  <mryandao> especially when it comes to hidden directories in home :/
133 2018-07-31T11:15:47  <harding> mryandao: ok.  I guess I have a different backup philosophy than you do.  I use cheap external HDs, and so I just grab everything indiscriminately.  I think there probably is an advantage to fully separating stuff we really want users to backup (e..g bitcoin.conf and wallets) from stuff that's just nice to backup (e.g. old blocks), but I personally don't think that's enough of an advantage to make them have to go looking around
134 2018-07-31T11:15:47  <harding> various places in their home directory for different Bitcoin-related resources.
135 2018-07-31T11:23:06  *** arubi_ has joined #bitcoin-core-dev
136 2018-07-31T11:25:33  *** arubi has quit IRC
137 2018-07-31T11:31:59  <fanquake> wumpus I was looking at the wrong things before. Feel free to ignore my nit on 13809 and merge it.
138 2018-07-31T11:37:02  *** Victorsueca has quit IRC
139 2018-07-31T11:38:12  *** Victorsueca has joined #bitcoin-core-dev
140 2018-07-31T11:38:35  *** promag has joined #bitcoin-core-dev
141 2018-07-31T11:43:08  *** promag has quit IRC
142 2018-07-31T11:47:20  *** Soligor has quit IRC
143 2018-07-31T11:56:05  *** Chris_Stewart_5 has quit IRC
144 2018-07-31T11:59:01  *** d9b4bef9 has quit IRC
145 2018-07-31T12:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
146 2018-07-31T12:00:35  *** farmerwampum has joined #bitcoin-core-dev
147 2018-07-31T12:14:49  *** Soligor has joined #bitcoin-core-dev
148 2018-07-31T13:00:58  *** elkalamar has joined #bitcoin-core-dev
149 2018-07-31T13:05:17  *** fanquake has quit IRC
150 2018-07-31T13:14:57  <bitcoin-git> [bitcoin] scravy opened pull request #13816: travis: build and run tests on os: osx (master...run-functional-tests-on-macos) https://github.com/bitcoin/bitcoin/pull/13816
151 2018-07-31T13:22:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
152 2018-07-31T13:32:43  *** promag has joined #bitcoin-core-dev
153 2018-07-31T13:40:27  *** sturles has quit IRC
154 2018-07-31T13:46:46  *** JackH has joined #bitcoin-core-dev
155 2018-07-31T13:50:15  *** Amuza has joined #bitcoin-core-dev
156 2018-07-31T14:16:46  *** nodweber has joined #bitcoin-core-dev
157 2018-07-31T14:21:03  *** Victorsueca has quit IRC
158 2018-07-31T14:22:12  *** Victorsueca has joined #bitcoin-core-dev
159 2018-07-31T14:23:49  <bitcoin-git> [bitcoin] Sjors opened pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818
160 2018-07-31T14:35:12  *** Amuza has quit IRC
161 2018-07-31T14:36:17  *** michaelsdunn1 has joined #bitcoin-core-dev
162 2018-07-31T15:05:26  <bitcoin-git> [bitcoin] chipstar opened pull request #13820: Replace Bitcoin to XPChain (master...replace-botcoin-to-xpchain) https://github.com/bitcoin/bitcoin/pull/13820
163 2018-07-31T15:06:38  <gmaxwell> sipa: ^ plz close
164 2018-07-31T15:07:10  <gmaxwell> actually, he PRed from his master, so you could also helpfully remove his repository too... :-/
165 2018-07-31T15:08:01  <bitcoin-git> [bitcoin] chipstar closed pull request #13820: Replace Bitcoin to XPChain (master...replace-botcoin-to-xpchain) https://github.com/bitcoin/bitcoin/pull/13820
166 2018-07-31T15:14:09  *** Victorsueca has quit IRC
167 2018-07-31T15:15:32  *** Victorsueca has joined #bitcoin-core-dev
168 2018-07-31T15:39:40  *** esotericnonsense has joined #bitcoin-core-dev
169 2018-07-31T15:48:36  *** esotericnonsense has quit IRC
170 2018-07-31T15:50:15  *** satwo has quit IRC
171 2018-07-31T15:50:35  *** esotericnonsense has joined #bitcoin-core-dev
172 2018-07-31T15:52:14  *** esotericnonsens_ has joined #bitcoin-core-dev
173 2018-07-31T15:52:47  *** esotericnonsense has quit IRC
174 2018-07-31T15:52:58  *** esotericnonsens_ is now known as esotericnonsense
175 2018-07-31T15:57:06  *** Dizzle has joined #bitcoin-core-dev
176 2018-07-31T15:57:16  *** promag has quit IRC
177 2018-07-31T15:57:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ce55df70d31...77168f766f15
178 2018-07-31T15:57:48  <bitcoin-git> bitcoin/master fa0e1e2 MarcoFalke: contrib: Remove debian and rpm subfolders
179 2018-07-31T15:57:48  <bitcoin-git> bitcoin/master 77168f7 MarcoFalke: Merge #13809: contrib: Remove debian and rpm subfolder...
180 2018-07-31T15:59:01  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13809: contrib: Remove debian and rpm subfolder (master...Mf1808-debianContrib) https://github.com/bitcoin/bitcoin/pull/13809
181 2018-07-31T16:06:57  *** bsm117532 has joined #bitcoin-core-dev
182 2018-07-31T16:19:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/77168f766f15...230652cafc51
183 2018-07-31T16:19:31  <bitcoin-git> bitcoin/master 04ce0d8 Pieter Wuille: Report when unknown config file options are ignored
184 2018-07-31T16:19:31  <bitcoin-git> bitcoin/master 247d574 Pieter Wuille: Ignore unknown config file options for now
185 2018-07-31T16:19:32  <bitcoin-git> bitcoin/master 230652c MarcoFalke: Merge #13799: Ignore unknown config file options; warn instead of error...
186 2018-07-31T16:20:29  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13799: Ignore unknown config file options; warn instead of error (master...201807_warnunknown) https://github.com/bitcoin/bitcoin/pull/13799
187 2018-07-31T16:31:31  *** masonicboom has joined #bitcoin-core-dev
188 2018-07-31T16:37:54  *** csknk has joined #bitcoin-core-dev
189 2018-07-31T16:51:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13821: qa: Re-enable test for unknown arg in conf file (master...Mf1808-qaConfWarn) https://github.com/bitcoin/bitcoin/pull/13821
190 2018-07-31T16:55:29  *** no_input_found has quit IRC
191 2018-07-31T16:56:25  *** no_input_found has joined #bitcoin-core-dev
192 2018-07-31T16:56:39  *** arubi_ is now known as arubi
193 2018-07-31T16:58:30  *** csknk has quit IRC
194 2018-07-31T17:07:28  *** Aaronvan_ is now known as AaronvanW
195 2018-07-31T17:11:21  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13821: qa: Re-enable test for unknown arg in conf file (master...Mf1808-qaConfWarn) https://github.com/bitcoin/bitcoin/pull/13821
196 2018-07-31T17:20:27  *** rex4539 has quit IRC
197 2018-07-31T17:38:33  *** sturles has joined #bitcoin-core-dev
198 2018-07-31T17:56:18  *** SopaXorzTaker has quit IRC
199 2018-07-31T17:56:43  *** SopaXorzTaker has joined #bitcoin-core-dev
200 2018-07-31T18:04:28  *** keymone has quit IRC
201 2018-07-31T18:11:15  *** keymone has joined #bitcoin-core-dev
202 2018-07-31T18:32:59  <bitcoin-git> [bitcoin] achow101 opened pull request #13822: bench: Make CoinSelection output groups pass eligibility filter (master...fix-out-groups-bench) https://github.com/bitcoin/bitcoin/pull/13822
203 2018-07-31T18:48:19  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/230652cafc51...7d3623794a10
204 2018-07-31T18:48:20  <bitcoin-git> bitcoin/master 2fb0066 practicalswift: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)
205 2018-07-31T18:48:20  <bitcoin-git> bitcoin/master 7d36237 Wladimir J. van der Laan: Merge #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...)...
206 2018-07-31T18:49:14  <bitcoin-git> [bitcoin] laanwj closed pull request #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...) (master...call-IsIPv6-in-GetIn6Addr) https://github.com/bitcoin/bitcoin/pull/13776
207 2018-07-31T19:06:27  *** Orion3k has quit IRC
208 2018-07-31T19:19:34  <ossifrage> This is a curious error: " dropped: non-selectable socket"
209 2018-07-31T19:20:06  <ossifrage> They seem to happen in runs over several minutes
210 2018-07-31T19:22:16  *** Orion3k has joined #bitcoin-core-dev
211 2018-07-31T19:23:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13823: qa: quote path in authproxy for external multiwallets (master...Mf1808-qaAuthProxyQuotePath) https://github.com/bitcoin/bitcoin/pull/13823
212 2018-07-31T19:27:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7d3623794a10...0fb9c87815d1
213 2018-07-31T19:27:17  <bitcoin-git> bitcoin/master 494634a Andrew Chow: bench: Make CoinSelection output groups pass eligibility filter...
214 2018-07-31T19:27:17  <bitcoin-git> bitcoin/master 0fb9c87 MarcoFalke: Merge #13822: bench: Make CoinSelection output groups pass eligibility filter...
215 2018-07-31T19:27:41  <ossifrage> I didn't think bitcoin would be using select(), I thought it would be using epoll() and friends?
216 2018-07-31T19:28:21  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13822: bench: Make CoinSelection output groups pass eligibility filter (master...fix-out-groups-bench) https://github.com/bitcoin/bitcoin/pull/13822
217 2018-07-31T19:34:49  *** promag has joined #bitcoin-core-dev
218 2018-07-31T19:41:23  <ossifrage> it looks like bitcoin-qt is using up 800 FDs for open files (chainstate, txindex, etc...)
219 2018-07-31T19:43:15  <ossifrage> 509 for txindex and 288 for chainstate
220 2018-07-31T19:43:54  <sipa> ossifrage: longer term we'll probably switch to libevent
221 2018-07-31T19:44:07  <sipa> which uses the most efficient polling mechanism on every platfor.
222 2018-07-31T19:46:31  <ossifrage> sipa, any suggestions on reducing the number of FDs used by txindex?
223 2018-07-31T19:49:39  <sipa> ossifrage: don't use txindex
224 2018-07-31T19:49:41  <sipa> :)
225 2018-07-31T19:50:52  <ossifrage> I wonder how painful of a project it would be to make the move to libevent?
226 2018-07-31T19:51:22  <Dizzle> We're already using it for RPC and some other networking, right?
227 2018-07-31T19:54:43  <ossifrage> Hmm, I wonder what bounds the number of FDs used by the txindex ldb files
228 2018-07-31T19:57:41  <sipa> leveldb has a max open fileslimit
229 2018-07-31T19:58:47  <sipa> how many connwctions do you have?
230 2018-07-31T20:01:26  <ossifrage> sipa, 160
231 2018-07-31T20:01:56  <ossifrage> (right now, but it looks like has been having troubles with new connections for a while due to the number of ldb files open)
232 2018-07-31T20:02:28  <sipa> bitcoind tries to raise its max fd limit at startup
233 2018-07-31T20:03:42  <ossifrage> sipa, the problem is with the FD_SET size which is 1024 :-(
234 2018-07-31T20:03:56  <sipa> yes
235 2018-07-31T20:04:25  <ossifrage> it looks like ldb is using 1000 fds (as per comment)
236 2018-07-31T20:06:00  <ossifrage> I think I'll try rebuilding with the default set to 500 or so (I wonder if that is global or per database)
237 2018-07-31T20:06:37  <ossifrage> However, I suspect it will take another month of runtime to accumulate that many open ldb files to test...
238 2018-07-31T20:06:54  *** SopaXorzTaker has quit IRC
239 2018-07-31T20:07:09  <sipa> ossifrage: no, it's a runtime testing
240 2018-07-31T20:07:13  *** Krellan has joined #bitcoin-core-dev
241 2018-07-31T20:25:43  <jimpo> Is there an option for shared (read/write) locks w/o C++ 14?
242 2018-07-31T20:26:57  <jimpo> looks like sigcache uses boost::shared_lock. is that acceptable or discouraged?
243 2018-07-31T20:27:46  <sipa> i think as long as we don't have c++14, boost::shared_lock looks like a good solution
244 2018-07-31T20:28:22  <gmaxwell> Is there really no read/write lock before C++14?!  Posix has had them for like 20 years!
245 2018-07-31T20:28:56  *** JackH has quit IRC
246 2018-07-31T20:29:39  <gmaxwell> BlueMatt: See above FD_SET stuff. Is there any way I could bribe you to PR the patch that changes the net to use poll on Linux?
247 2018-07-31T20:29:59  <gmaxwell> We have 1001 windows specific things in the codebase,  having a linux+bsd specific thing wouldn't be the end of the world.
248 2018-07-31T20:30:21  <gmaxwell> And we've delayed doing the simple thing for eons, in favor of a grand change that has been slow in coming.
249 2018-07-31T20:30:47  <gmaxwell> IIRC the patchs that you and patrick had done were like a dozen lines of code, and except for the fact that they added platform IFdefs, were totally clean.
250 2018-07-31T20:30:58  <sipa> gmaxwell: before c++11, c++ didn't have any form of threading or synchronization primitives at all :)
251 2018-07-31T20:31:17  <gmaxwell> sipa: I know but why the heck didn't C++11 catch up with basic features from decades ago? :(
252 2018-07-31T20:31:36  <sipa> gmaxwell: my guess is that c++11 was already an enormous change
253 2018-07-31T20:32:09  <gmaxwell> aside, <3 RW locks
254 2018-07-31T20:32:18  <sipa> yes!
255 2018-07-31T20:36:18  <sipa> the c++14 shared mutex doesn't support upgradable locking
256 2018-07-31T20:37:06  <gmaxwell> I can see why upgradability would be useful for us, but I don't recall ever using it in my own code.
257 2018-07-31T20:37:21  <gmaxwell> (maybe posix rw locks aren't even upgradable?)
258 2018-07-31T20:37:52  <sipa> ah!
259 2018-07-31T20:37:55  <sipa> https://stackoverflow.com/questions/34993983/upgrading-read-lock-to-write-lock-without-releasing-the-first-in-c11
260 2018-07-31T20:38:09  <sipa> you can implement upgradable locks on top of shared and exclusive locks
261 2018-07-31T20:38:42  <gmaxwell> for us I think the big win for rw locks is that we can make all the things that just need readonly access to the blockchain not block each other...
262 2018-07-31T20:38:56  <gmaxwell> info-rpcs, wallet, P2P get* messages...
263 2018-07-31T20:39:17  <gmaxwell> and that doesn't need an upgradable lock.
264 2018-07-31T20:39:43  <sipa> upgradable locks would be nice in that they let us lock/unlock exclusive access during block validation
265 2018-07-31T20:39:50  <gmaxwell> block processing could in theory use one, e.g. take a read lock to decide if the incoming block is already known to us, then promote to write if it isn't... but thats rare, might as well take the write lock.
266 2018-07-31T20:40:00  <sipa> at times when the chainstate is consistent but not done
267 2018-07-31T20:40:10  <gmaxwell> okay thats a point.
268 2018-07-31T20:40:38  <sipa> basically you just need to upgrade when flushing the per-block utxo cache to the chainstate cache
269 2018-07-31T20:41:48  <gmaxwell> I'm always a little warry about peppering the code with a lot of fine locking, since they're slow (potentially very slow if contended)
270 2018-07-31T20:42:10  <gmaxwell> (and it's hard to tell that it's slow)
271 2018-07-31T20:43:13  <sipa> uncontended locks are really fast (at least on linux)
272 2018-07-31T20:44:08  <gmaxwell> It's all relative. I think they're always as slow as a cache line bounce, so equal to probably thousands of multiplies.
273 2018-07-31T20:44:50  <sipa> the number i had in my mind was 100 cpu cycles for an uncontended loc
274 2018-07-31T20:44:58  <sipa> but i can't remember actually ever validating that number
275 2018-07-31T20:45:04  <gmaxwell> hm. okay so an order of magnitude between our beliefs.
276 2018-07-31T20:45:33  <gmaxwell> I don't see how 100 is physically possible though.
277 2018-07-31T20:45:50  <gmaxwell> not without doing some kind of transactional crazyness that can rollback the cpu on conflicts.
278 2018-07-31T20:46:52  <sipa> http://ithare.com/infographics-operation-costs-in-cpu-clock-cycles/
279 2018-07-31T20:47:35  <sipa> i think an uncontended lock is a few compare-and-swaps
280 2018-07-31T20:48:29  <gmaxwell> so per that a few hundred cycles, seems fast to me, though thinking more about it, I guess it no longer strikes me as physically impossible to take a lock in 100 cycles IF you are the same core that last had the lock.
281 2018-07-31T20:51:44  <gmaxwell> If you aren't then I don't think it's physically possible, another core could take the lock at the same time, and at 100 cycles, it's potentially outside of your lightcone. (13 cm)
282 2018-07-31T20:53:09  <sipa> just wrote a small c++11 benchmark that creates a single thread which grabs a mutex, and increments a variable, and releases again
283 2018-07-31T20:53:21  <sipa> 14 ns per iteration
284 2018-07-31T20:53:38  <sipa> agreed, "always on the same thread" is a stronger condition than just "uncontended"
285 2018-07-31T20:55:54  <gmaxwell> makes sense. yea, 14ns is just not physically possible if it has to consult with a far away core. but I guess it doesn't in common cases.
286 2018-07-31T20:57:33  <sipa> now trying the same with 2 simultaneous threads
287 2018-07-31T20:58:22  <sipa> just 100 ns per iteration?
288 2018-07-31T20:58:23  <sipa> wtf
289 2018-07-31T20:58:36  <sipa> i was expected several orders of magnitudes more
290 2018-07-31T20:58:43  <gmaxwell> well, hyperthreading? :)
291 2018-07-31T20:59:00  <gmaxwell> use taskset to force it into different sockets. :P
292 2018-07-31T21:01:52  *** masonicboom has quit IRC
293 2018-07-31T21:05:29  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13824: doc: Remove outdated net comment (master...Mf1808-docNetCritSec) https://github.com/bitcoin/bitcoin/pull/13824
294 2018-07-31T21:09:44  *** booyah has quit IRC
295 2018-07-31T21:09:52  *** Chris_Stewart_5 has quit IRC
296 2018-07-31T21:13:34  *** masonicboom has joined #bitcoin-core-dev
297 2018-07-31T21:25:29  *** goatpig has joined #bitcoin-core-dev
298 2018-07-31T21:25:47  *** AaronvanW has quit IRC
299 2018-07-31T21:26:23  *** AaronvanW has joined #bitcoin-core-dev
300 2018-07-31T21:45:17  *** Amuza has joined #bitcoin-core-dev
301 2018-07-31T21:51:45  *** rex4539 has joined #bitcoin-core-dev
302 2018-07-31T21:54:09  <bitcoin-git> [bitcoin] jnewbery opened pull request #13825: [wallet] [Do not merge until v0.18] Kill accounts (master...kill_accounts) https://github.com/bitcoin/bitcoin/pull/13825
303 2018-07-31T21:54:41  *** Amuza has quit IRC
304 2018-07-31T21:59:58  *** arubi has quit IRC
305 2018-07-31T22:00:31  *** arubi has joined #bitcoin-core-dev
306 2018-07-31T22:09:30  *** no_input_found has quit IRC
307 2018-07-31T22:09:50  *** no_input_found has joined #bitcoin-core-dev
308 2018-07-31T22:20:51  *** michaelsdunn1 has quit IRC
309 2018-07-31T22:21:24  *** Orion3k has quit IRC
310 2018-07-31T22:33:59  *** Orion3k has joined #bitcoin-core-dev
311 2018-07-31T22:47:57  *** Krellan has quit IRC
312 2018-07-31T22:49:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
313 2018-07-31T23:07:07  *** JackH has joined #bitcoin-core-dev
314 2018-07-31T23:09:25  *** jtimon has joined #bitcoin-core-dev
315 2018-07-31T23:12:16  *** JackH has quit IRC
316 2018-07-31T23:21:37  *** Emcy has quit IRC
317 2018-07-31T23:22:28  *** Emcy has joined #bitcoin-core-dev
318 2018-07-31T23:29:10  *** Chris_Stewart_5 has quit IRC
319 2018-07-31T23:30:35  *** Dizzle has quit IRC
320 2018-07-31T23:35:21  *** timothy has quit IRC
321 2018-07-31T23:54:10  *** Victorsueca has quit IRC
322 2018-07-31T23:55:27  *** Victorsueca has joined #bitcoin-core-dev
323 2018-07-31T23:58:46  *** masonicboom has quit IRC