1 2018-08-17T00:01:46  *** Dizzle has quit IRC
  2 2018-08-17T00:05:59  *** masonicboom has quit IRC
  3 2018-08-17T00:11:45  *** justanotheruser has joined #bitcoin-core-dev
  4 2018-08-17T00:14:53  *** kevink has quit IRC
  5 2018-08-17T00:35:01  *** d9b4bef9 has quit IRC
  6 2018-08-17T00:35:50  *** masonicboom has joined #bitcoin-core-dev
  7 2018-08-17T00:36:16  *** d9b4bef9 has joined #bitcoin-core-dev
  8 2018-08-17T00:36:49  *** Emcy has joined #bitcoin-core-dev
  9 2018-08-17T00:39:27  <michagogo> Hrm
 10 2018-08-17T00:39:34  <michagogo> I got a new computer
 11 2018-08-17T00:40:06  <michagogo> But all my VMs, including the Ubuntu I use for gitian, are in virtualbox
 12 2018-08-17T00:40:57  <michagogo> And it seems that Windows 10 actually runs in a Hyper-V VM, which hogs the vtx…
 13 2018-08-17T00:41:52  <michagogo> Not to mention that if I want Docker that’s Hyper-V too
 14 2018-08-17T00:42:13  <michagogo> So I guess I need to figure out how to migrate, but I feel like that’ll be a pain
 15 2018-08-17T00:42:30  *** Emcy_ has joined #bitcoin-core-dev
 16 2018-08-17T00:42:31  <michagogo> Especially because the Hyper-V console sucks
 17 2018-08-17T00:43:05  <michagogo> To the point that for Windows VMs, they tell you you’re better off RDPing in
 18 2018-08-17T00:45:53  *** Emcy has quit IRC
 19 2018-08-17T00:46:31  *** Krellan has quit IRC
 20 2018-08-17T00:46:42  *** Krellan has joined #bitcoin-core-dev
 21 2018-08-17T00:48:17  *** Krellan has quit IRC
 22 2018-08-17T00:48:33  *** Krellan has joined #bitcoin-core-dev
 23 2018-08-17T00:48:35  *** Emcy_ has quit IRC
 24 2018-08-17T00:49:29  *** Emcy_ has joined #bitcoin-core-dev
 25 2018-08-17T00:53:21  *** jhfrontz has joined #bitcoin-core-dev
 26 2018-08-17T01:05:12  *** plankers has quit IRC
 27 2018-08-17T01:05:49  *** plankers has joined #bitcoin-core-dev
 28 2018-08-17T01:26:55  *** Aaronvan_ has quit IRC
 29 2018-08-17T01:29:16  *** justanotheruser has quit IRC
 30 2018-08-17T01:29:46  *** justanotheruser has joined #bitcoin-core-dev
 31 2018-08-17T01:35:23  <achow101> luke-jr: really? It worked for me
 32 2018-08-17T01:37:34  *** AaronvanW has joined #bitcoin-core-dev
 33 2018-08-17T01:39:00  <luke-jr> achow101: it's trying to install grub, and there's no package or something
 34 2018-08-17T01:39:04  <luke-jr> 2018-08-16 23:26:15,629 INFO    : E: Package 'grub' has no installation candidate
 35 2018-08-17T01:41:21  <achow101> luke-jr: are you sure you are using the correct vmbuilder?
 36 2018-08-17T01:41:57  *** AaronvanW has quit IRC
 37 2018-08-17T01:46:44  <luke-jr> achow101: no, but I tried both master and bionic branches..
 38 2018-08-17T01:55:46  *** ken2812221 has joined #bitcoin-core-dev
 39 2018-08-17T02:10:33  *** jb55 has joined #bitcoin-core-dev
 40 2018-08-17T02:13:16  *** rls has quit IRC
 41 2018-08-17T02:14:38  *** masonicboom has quit IRC
 42 2018-08-17T02:23:20  *** Krellan has quit IRC
 43 2018-08-17T02:28:08  *** thib has joined #bitcoin-core-dev
 44 2018-08-17T02:36:09  *** goatpig has quit IRC
 45 2018-08-17T02:38:17  *** AaronvanW has joined #bitcoin-core-dev
 46 2018-08-17T02:42:27  *** AaronvanW has quit IRC
 47 2018-08-17T02:47:06  *** reallll has joined #bitcoin-core-dev
 48 2018-08-17T02:47:49  *** masonicboom has joined #bitcoin-core-dev
 49 2018-08-17T02:50:41  *** belcher_ has quit IRC
 50 2018-08-17T02:56:00  *** Emcy_ has quit IRC
 51 2018-08-17T03:07:10  *** Emcy_ has joined #bitcoin-core-dev
 52 2018-08-17T03:16:27  *** Chris_Stewart_5 has quit IRC
 53 2018-08-17T03:38:05  *** masonicboom has quit IRC
 54 2018-08-17T04:34:02  *** d9b4bef9 has quit IRC
 55 2018-08-17T04:35:09  *** d9b4bef9 has joined #bitcoin-core-dev
 56 2018-08-17T04:37:28  *** unholymachine has quit IRC
 57 2018-08-17T04:39:02  *** AaronvanW has joined #bitcoin-core-dev
 58 2018-08-17T04:44:27  *** AaronvanW has quit IRC
 59 2018-08-17T05:28:17  *** fanquake has joined #bitcoin-core-dev
 60 2018-08-17T05:28:56  <fanquake> MarcoFalke Any idea why your sigs don't match the others that have been submitted?
 61 2018-08-17T05:35:27  <luke-jr> achow101: I don't see how the code in that branch can possibly work. It hard-codes "grub"
 62 2018-08-17T05:52:31  <achow101> luke-jr: I'm not sure
 63 2018-08-17T05:52:55  <achow101> fanquake: I'm getting the same sigs as MarcoFalke
 64 2018-08-17T05:53:21  <achow101> fanquake: I used docker to build, maybe that's causing the difference?
 65 2018-08-17T05:54:04  <fanquake> achow101 hmm ok. So wumpus, ken, jonass and myself match, yourself and marco match differently.
 66 2018-08-17T05:54:29  <fanquake> achow101: that could be it. I'll do a docker build and see if there's a difference.
 67 2018-08-17T06:02:48  *** rex4539 has quit IRC
 68 2018-08-17T06:12:05  *** rex4539 has joined #bitcoin-core-dev
 69 2018-08-17T06:27:04  *** Krellan has joined #bitcoin-core-dev
 70 2018-08-17T06:33:29  *** plankers has quit IRC
 71 2018-08-17T06:46:38  <ken2812221> The difference is linux only.
 72 2018-08-17T06:49:35  *** jtimon has quit IRC
 73 2018-08-17T07:29:56  <jonasschnelli> ken2812221, fanquake: you are using LXC, right? Docker uses LXC as well, right?
 74 2018-08-17T07:54:47  *** SopaXorzTaker has joined #bitcoin-core-dev
 75 2018-08-17T08:05:51  *** csknk has joined #bitcoin-core-dev
 76 2018-08-17T08:36:02  *** d9b4bef9 has quit IRC
 77 2018-08-17T08:37:09  *** d9b4bef9 has joined #bitcoin-core-dev
 78 2018-08-17T08:41:55  *** AaronvanW has joined #bitcoin-core-dev
 79 2018-08-17T08:46:27  *** AaronvanW has quit IRC
 80 2018-08-17T09:05:21  <ken2812221> jonasschnelli: yes, I'm using LXC
 81 2018-08-17T09:06:05  *** promag has joined #bitcoin-core-dev
 82 2018-08-17T09:08:08  <promag> should #13501 be tagged bugfix?
 83 2018-08-17T09:08:10  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
 84 2018-08-17T09:18:01  *** reallll has quit IRC
 85 2018-08-17T09:18:31  *** belcher_ has joined #bitcoin-core-dev
 86 2018-08-17T09:39:01  *** AaronvanW has joined #bitcoin-core-dev
 87 2018-08-17T09:43:08  <fanquake> yes, also LXC
 88 2018-08-17T10:44:05  *** Krellan has quit IRC
 89 2018-08-17T10:44:54  *** Krellan has joined #bitcoin-core-dev
 90 2018-08-17T10:59:32  *** arubi has quit IRC
 91 2018-08-17T10:59:56  *** arubi has joined #bitcoin-core-dev
 92 2018-08-17T11:01:27  *** Aaronvan_ has joined #bitcoin-core-dev
 93 2018-08-17T11:02:03  *** Aaronva__ has joined #bitcoin-core-dev
 94 2018-08-17T11:04:48  *** AaronvanW has quit IRC
 95 2018-08-17T11:05:58  *** Aaronvan_ has quit IRC
 96 2018-08-17T11:12:14  *** Krellan has quit IRC
 97 2018-08-17T11:14:18  *** HoMM has joined #bitcoin-core-dev
 98 2018-08-17T11:17:34  *** Krellan has joined #bitcoin-core-dev
 99 2018-08-17T11:21:58  *** Victorsueca has quit IRC
100 2018-08-17T11:23:18  *** Victorsueca has joined #bitcoin-core-dev
101 2018-08-17T11:38:40  *** prod_ has quit IRC
102 2018-08-17T11:50:39  *** itaseski has joined #bitcoin-core-dev
103 2018-08-17T12:00:48  *** promag has quit IRC
104 2018-08-17T12:02:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
105 2018-08-17T12:07:01  *** d9b4bef9 has quit IRC
106 2018-08-17T12:08:09  *** d9b4bef9 has joined #bitcoin-core-dev
107 2018-08-17T12:09:02  *** d9b4bef9 has quit IRC
108 2018-08-17T12:10:09  *** d9b4bef9 has joined #bitcoin-core-dev
109 2018-08-17T12:11:02  *** d9b4bef9 has quit IRC
110 2018-08-17T12:12:08  *** d9b4bef9 has joined #bitcoin-core-dev
111 2018-08-17T12:18:40  *** Victorsueca has quit IRC
112 2018-08-17T12:18:44  *** Victor_sueca has joined #bitcoin-core-dev
113 2018-08-17T12:58:55  *** brianhoffman has joined #bitcoin-core-dev
114 2018-08-17T13:01:42  *** brianhoffman_ has joined #bitcoin-core-dev
115 2018-08-17T13:03:26  *** brianhoffman has quit IRC
116 2018-08-17T13:03:27  *** brianhoffman_ is now known as brianhoffman
117 2018-08-17T13:18:05  *** rex4539 has quit IRC
118 2018-08-17T13:54:38  *** belcher_ has quit IRC
119 2018-08-17T13:56:36  *** belcher_ has joined #bitcoin-core-dev
120 2018-08-17T14:13:05  *** Chris_Stewart_5 has quit IRC
121 2018-08-17T14:26:24  <wumpus> I'm also using LXC
122 2018-08-17T14:30:20  *** promag has joined #bitcoin-core-dev
123 2018-08-17T14:30:26  *** michaelsdunn1 has joined #bitcoin-core-dev
124 2018-08-17T14:31:45  *** csknk has quit IRC
125 2018-08-17T14:38:49  <promag> wumpus: is there a way to compare case insensitive in the code?
126 2018-08-17T14:40:38  *** belcher_ has quit IRC
127 2018-08-17T14:45:03  *** belcher_ has joined #bitcoin-core-dev
128 2018-08-17T14:47:32  <promag> ken2812221: would you mind testing #13501 in windows?
129 2018-08-17T14:47:33  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHubAsset 1Asset 1
130 2018-08-17T14:48:31  <ken2812221> promag: Sure
131 2018-08-17T14:48:53  <promag> thanks! I don't have access to one atm
132 2018-08-17T14:50:47  <promag> wumpus: ^ no need to backport right?
133 2018-08-17T14:51:31  <sipa> promag: convert both sides to lowercase and then compare? :)
134 2018-08-17T14:52:06  <promag> sipa: yap, that's what I'm doing
135 2018-08-17T14:52:39  <promag> sipa: I'll add an utility function
136 2018-08-17T14:53:01  <promag> not sure if in util.h or utilstrencodings.h
137 2018-08-17T14:53:07  <promag> suggestion?
138 2018-08-17T14:53:41  <wumpus> promag: no, no need to backport, it's a very rare problem and not a regression -- would be great to solve it for 0.18
139 2018-08-17T14:53:56  <promag> wumpus: agree
140 2018-08-17T14:54:56  <ken2812221> promag: How about using regex?
141 2018-08-17T14:54:57  <wumpus> promag: we'll need a locale-independent case conversion function, I guess
142 2018-08-17T14:55:47  <wumpus> otherwise, this is going to do something different based on the user's language, which you don't want in http header handling
143 2018-08-17T14:56:12  <promag> wumpus: like evutil_ascii_strcasecmp?
144 2018-08-17T14:56:48  <wumpus> I guess you can use the libevent code, but only in code that already uses libevent directly
145 2018-08-17T14:57:02  <wumpus> not in, say, utilstrencodings or util
146 2018-08-17T14:58:00  <promag> maybe static bool HTTPRequest::CompareHeaders(a, b)?
147 2018-08-17T14:59:22  <wumpus> promag: or make the headers function return the headers already lowercased
148 2018-08-17T15:00:03  <promag> libevent doesn't expose that, and I'd like to dump what the client sends
149 2018-08-17T15:00:57  <wumpus> ok, yes in that case a static function on HTTPRequest makes sense I suppose... I think it's somewhat hacky, implementing our own case-insensitive comparision function sounds super easy
150 2018-08-17T15:02:00  <wumpus> now you convert from libevent string to std::string, then back to C string to pass it back for comparison...
151 2018-08-17T15:02:24  <promag> wumpus: right, prefer that than own implementation
152 2018-08-17T15:02:24  <wumpus> starting to think all of this isn't worth it just for some diagnostic logging
153 2018-08-17T15:02:57  <wumpus> how many times do you really need to know the headers?
154 2018-08-17T15:03:19  <wumpus> and you can't, say, start up wireshark or tcpdump
155 2018-08-17T15:03:29  <wumpus> that has always worked great for me FWIW
156 2018-08-17T15:05:01  <promag> sure, the idea is to have a out of the box way of seeing the requests
157 2018-08-17T15:05:17  <promag> *headers
158 2018-08-17T15:05:21  <wumpus> but why?
159 2018-08-17T15:05:25  *** owowo has joined #bitcoin-core-dev
160 2018-08-17T15:05:28  <wumpus> what was your motivation for this?
161 2018-08-17T15:05:52  <wumpus> from my own experience at least I'm usually interested inthe request contents, not the headers
162 2018-08-17T15:06:38  <promag> in 13501, I was puzzled to know why bitcoin-cli worked differently than AuthProxy
163 2018-08-17T15:07:13  *** nullptr| has quit IRC
164 2018-08-17T15:07:16  <promag> anyway, I'll finish the implementation and then close it
165 2018-08-17T15:07:38  <wumpus> well other people might reasonably disagree
166 2018-08-17T15:08:15  <promag> what if we dump it only if `-debug` is on?
167 2018-08-17T15:08:18  <wumpus> it's just that personally, I think this is a rabbit hole not venturing into
168 2018-08-17T15:08:23  <wumpus> worth*
169 2018-08-17T15:09:14  <wumpus> I add debug code like this all the time to diagnose specific issues, but never even consider upstreaming it, because it served its purpose
170 2018-08-17T15:10:39  <wumpus> and making it production-friendly implies "censoring" sensitive headers and all that
171 2018-08-17T15:10:56  <wumpus> which in turn brings in utiltiy functions we don't need right now for other things
172 2018-08-17T15:13:36  <wumpus> and then the new string sanitization issues that this brings
173 2018-08-17T15:13:47  <wumpus> I'm sorry
174 2018-08-17T15:14:03  *** nullptr| has joined #bitcoin-core-dev
175 2018-08-17T15:14:20  <promag> lol
176 2018-08-17T15:15:03  <promag> don't be, I'll just finish and close it because I agree with you
177 2018-08-17T15:17:58  <wumpus> thanks
178 2018-08-17T15:21:55  *** HoMM has quit IRC
179 2018-08-17T15:34:46  *** Krellan has quit IRC
180 2018-08-17T15:35:34  *** Krellan has joined #bitcoin-core-dev
181 2018-08-17T15:43:29  *** rex4539 has joined #bitcoin-core-dev
182 2018-08-17T15:56:47  <cfields_> catching up. I understand there is/was an issue with determinism with the gitian build. Resolved, or is that still the case?
183 2018-08-17T16:07:29  <cfields_> I see, it's the Linux build.  have
184 2018-08-17T16:07:32  <cfields_> er
185 2018-08-17T16:08:27  <cfields_> achow101 / jonasschnelli / ken2812221 / MarcoFalke / wumpus: can any of you share the gitian Linux output for comparison?
186 2018-08-17T16:16:29  <cfields_> http://changelogs.ubuntu.com/changelogs/pool/main/g/glibc/glibc_2.27-3ubuntu1/changelog
187 2018-08-17T16:18:32  <ken2812221> cfields: https://0bin.net/paste/Tae5ifPLYebHiKTi#uyXDywq91FOahuh+lc2E76cS9Qu-uINxkpxAHiL33BL
188 2018-08-17T16:19:01  <ken2812221> This is lxc
189 2018-08-17T16:19:06  <cfields_> ken2812221: thanks!
190 2018-08-17T16:20:21  <cfields_> comparing now
191 2018-08-17T16:21:43  <ken2812221> The difference is on bitcoin-qt, I've compared it before but I deleted the docker one.
192 2018-08-17T16:21:50  *** promag has quit IRC
193 2018-08-17T16:23:07  <cfields_> ah, ok
194 2018-08-17T16:27:09  *** csknk has joined #bitcoin-core-dev
195 2018-08-17T16:38:47  *** fanquake has quit IRC
196 2018-08-17T16:51:30  <MarcoFalke> Thanks for the lxc gitian results. Will also take a look here...
197 2018-08-17T17:05:41  *** jhfrontz has quit IRC
198 2018-08-17T17:18:37  *** jhfrontz has joined #bitcoin-core-dev
199 2018-08-17T17:41:39  *** Victor_sueca has quit IRC
200 2018-08-17T17:42:13  *** Victorsueca has joined #bitcoin-core-dev
201 2018-08-17T17:47:08  <achow101> jonasschnelli: docker doesn't use lxc as the backend anymore
202 2018-08-17T17:47:53  <wumpus> achow101: but it uses the same kind of kernel namespacing that lxc uses, doesn't it?
203 2018-08-17T17:48:10  <wumpus> (maybe in a slightly different way)
204 2018-08-17T17:49:12  <achow101> wumpus: I think so?
205 2018-08-17T17:51:34  <wumpus> it's somewhat surprising for that to cause a difference in build result!
206 2018-08-17T17:52:10  *** Krellan has quit IRC
207 2018-08-17T17:52:18  <wumpus> bitcoin-qt only suggests to me it's another non-determinism thing with the qt tooling, maybe file ordering or date/time in metadata in the qrc archives
208 2018-08-17T17:55:40  <MarcoFalke> I made it use --jobs 16, if that helps
209 2018-08-17T17:56:15  <achow101> I thought the non-determinism was with all of them
210 2018-08-17T17:56:23  <achow101> MarcoFalke: did you use docker?
211 2018-08-17T17:56:26  <MarcoFalke> jup
212 2018-08-17T17:56:30  <MarcoFalke> diffoscope spits out a trillion lines ...
213 2018-08-17T17:57:17  *** Krellan has joined #bitcoin-core-dev
214 2018-08-17T17:57:57  <achow101> oh, nvm, i see what you meant by bitcoin-qt being the non-deterministic one
215 2018-08-17T17:59:11  <achow101> cfields_: here are my binaries https://github.com/achow101/bitcoin/releases/tag/v0.17.0rc1
216 2018-08-17T18:00:09  *** jtimon has joined #bitcoin-core-dev
217 2018-08-17T18:01:04  <MarcoFalke> diffoscope: https://transfer.sh/8q9rT/diffoscope_51eb52972b_2_c7c606df_bitcoin-0.17.0-x86_64-linux-gnu.tar.gz.1
218 2018-08-17T18:02:23  <MarcoFalke> only difference in qt
219 2018-08-17T18:04:06  <gmaxwell> cmp the binaries and see if the difference is just a timestamp or something?
220 2018-08-17T18:05:12  *** jhfrontz has quit IRC
221 2018-08-17T18:06:56  <MarcoFalke> They have different sizes: 28286668 vs 28287142
222 2018-08-17T18:08:23  <gmaxwell> pretty big difference in fact.
223 2018-08-17T18:09:01  <wumpus> could still be a timestamp difference in compressed resource data
224 2018-08-17T18:11:04  *** vexbuy has joined #bitcoin-core-dev
225 2018-08-17T18:11:36  *** jeremyrubin has quit IRC
226 2018-08-17T18:14:25  *** jhfrontz has joined #bitcoin-core-dev
227 2018-08-17T18:16:21  <wumpus> gah for some reason I deleted the gitian output, need to rebuild before I can take a look
228 2018-08-17T18:16:56  <gmaxwell> or a difference in file order
229 2018-08-17T18:17:15  <jonasschnelli> gmaxwell: what do you think about the rekey not being a real rekey, I mean 'e' lives basically forever (until the connection dies). Would redoing the handshake (generate a new 'e') not make more sense?
230 2018-08-17T18:17:42  <gmaxwell> No, it would just waste cpu time.
231 2018-08-17T18:18:12  <gmaxwell> I'm not sure what 'e' refers to here, specifically.
232 2018-08-17T18:18:23  <jonasschnelli> ephemeral key
233 2018-08-17T18:19:16  <gmaxwell> The ephemeral key shouldn't even be remembered after the handshake is complete.
234 2018-08-17T18:19:46  <gmaxwell> The hand shake computes an ephemeral key and outputs a session id, and encrypt and auth keys in each direction and forgets the ephemeral key.
235 2018-08-17T18:20:10  <jonasschnelli> Yes. Right. Makes sense.
236 2018-08-17T18:20:12  <gmaxwell> Rekey replaces the encrypt and auth keys with new ones derrived one way, so a host compromise can't go back and get old ones.
237 2018-08-17T18:25:30  <gmaxwell> Rekey serves the purpose of limiting the amount of data that goes through the AEAD with a static key, since it's limited to 2^32 blocks by design, and as an additional benefit gets is some protection against being able to compromise a host in order to decrypt its past communications-- a kind of perfect forward secrecy which is relevant to us because we tend to have super long lived connections.
238 2018-08-17T18:26:08  <jonasschnelli> ack
239 2018-08-17T18:26:43  <jonasschnelli> Though 2^31 now with the rekey bit. :)
240 2018-08-17T18:27:02  *** d9b4bef9 has quit IRC
241 2018-08-17T18:27:04  <jonasschnelli> ah. you meant the ChaChaPoly1305, nm then
242 2018-08-17T18:27:08  <gmaxwell> right.
243 2018-08-17T18:27:56  <gmaxwell> running the DH again wouldn't actually accompish anything but be slow, so we'd have to worry about DOS attacks from rekeying too often-- which basically cannot happen when rekey is just a cheap one way function.
244 2018-08-17T18:28:03  <jonasschnelli> Sorry for brining other wild ideas in: what about using UDP (long term)?
245 2018-08-17T18:28:09  *** d9b4bef9 has joined #bitcoin-core-dev
246 2018-08-17T18:29:23  <sipa> that's a lot more complicated
247 2018-08-17T18:29:32  <sipa> as our protocol is inherently ordered
248 2018-08-17T18:30:05  *** Emcy_ has quit IRC
249 2018-08-17T18:30:07  <gmaxwell> It's very difficult to use UDP as a general thing because you have to have _working_ nat traversal. it's easy to traverse 50% of nats, but to get to 99.999% is very hard. webrtc in firefox has hundreds of thousands of lines of code related to nat traversal.
250 2018-08-17T18:30:08  <sipa> you'd need to invent your own message based protocol with retransmissions and ordering
251 2018-08-17T18:30:41  <gmaxwell> And as sipa notes, you also have to implement your own TCP analog, complete with flow control and ordering.
252 2018-08-17T18:30:48  <jonasschnelli> i see
253 2018-08-17T18:31:44  <gmaxwell> it think it would be really neat for someone to implement a UDP protocol for bitcoin that just runs as a proxy in another process.
254 2018-08-17T18:32:23  *** Krellan has quit IRC
255 2018-08-17T18:32:47  <gmaxwell> it's also possible to do UDP for a narrow subset of use pretty easily.  E.g. block relay between hosts that do not require nat traversal (either no nat, or manually portmapped udp)--  fibre does that and it's relatively straight forward.
256 2018-08-17T18:34:02  *** Krellan has joined #bitcoin-core-dev
257 2018-08-17T18:36:21  <gmaxwell> Basically the things we know we can gain from using UDP:   (1) better low priority congestion control for low priority traffic, e.g. support peers IBDing without impacting the local network,  (2) avoiding head of line blocking e.g. a peer requesting a 100k transaction from us stops us from sending them a 10kb compact block until the 100k transaction is done. (3) avoiding retransmission head of l
258 2018-08-17T18:36:21  <gmaxwell> ine blocking, where a single dropped packet delays communicating a block by at least one whole round trip. (4) better access to inbound peers due to nat hole punching.
259 2018-08-17T18:36:31  *** Krellan has quit IRC
260 2018-08-17T18:36:43  <gmaxwell> 2/3 are basically block transmission specific and don't apply to the rest of our protocol.
261 2018-08-17T18:37:26  <gmaxwell> Which means they can be solved with a thing that only does blocks.
262 2018-08-17T18:37:44  <gmaxwell> 4 is super hard because getting nat traversal working for the billion and one psycho devices out there is really complicated.
263 2018-08-17T18:39:51  <gmaxwell> 1. is hard because it requires effectively a userspace TCP stack optimized for low priority.. all of it having a big network attack surface.
264 2018-08-17T18:40:42  <gmaxwell> stuff like 1/4 don't need to be addressed from scratch, e.g. https://github.com/bittorrent/libutp
265 2018-08-17T18:43:38  <gmaxwell> in terms of effort&risk vs reward, it's kind of crazy that we haven't done a NAT-PMP/NAT-PCP implementation.
266 2018-08-17T18:44:29  *** grafcaps has joined #bitcoin-core-dev
267 2018-08-17T19:03:46  <jonasschnelli> The current signal-rekey-in-length bit has one problem, time based rekeys would need an artificial message,... or maybe it's okay to wait for the next ping
268 2018-08-17T19:04:11  <jonasschnelli> Because the signal is for : "next message will use the new key"
269 2018-08-17T19:05:00  <jonasschnelli> No message == no way to signal the bit
270 2018-08-17T19:07:06  <gmaxwell> I think it's fine to just wait for the next message for bitcoin core, since we ping with a perfectly fine interval.
271 2018-08-17T19:07:24  <gmaxwell> For some other kind of client that didn't ping as often, they could trigger a ping at the relevant time.
272 2018-08-17T19:14:26  <jonasschnelli> petertodd: did you post to the ML or did someone impersonates you?
273 2018-08-17T19:17:49  <MarcoFalke> jonasschnelli: The mail is missing the typical sig he puts on, so clearly fake unless proven otherwise
274 2018-08-17T19:18:10  <jonasschnelli> yes. He posts sometimes without GPG, but never without his text sig
275 2018-08-17T19:18:16  <gmaxwell> Who cares?
276 2018-08-17T19:18:40  <jonasschnelli> Indeed,.. maybe kanzure (the mod)
277 2018-08-17T19:18:50  <gmaxwell> yet another dumb offtopic post, out of many. :)
278 2018-08-17T19:19:36  <jonasschnelli> I thought it's a moderated list?!
279 2018-08-17T19:20:06  <gmaxwell> I believe regular posters are whitelisted to bypass the moderation.
280 2018-08-17T19:20:34  <jonasschnelli> by smtp from:? hell please no. :)
281 2018-08-17T19:22:13  <gmaxwell> seems like it!
282 2018-08-17T19:25:19  *** DougieBot5000 has quit IRC
283 2018-08-17T19:25:23  *** aLK-[i] has quit IRC
284 2018-08-17T19:25:47  *** DougieBot5000 has joined #bitcoin-core-dev
285 2018-08-17T19:30:55  *** Aaronva__ has quit IRC
286 2018-08-17T19:31:38  *** AaronvanW has joined #bitcoin-core-dev
287 2018-08-17T19:33:42  *** tripleslash has quit IRC
288 2018-08-17T19:33:51  *** CubicEarth has quit IRC
289 2018-08-17T19:34:01  *** StopAndDecrypt has quit IRC
290 2018-08-17T19:34:15  <MarcoFalke> The gitian issue is likely something with depends
291 2018-08-17T19:34:25  <MarcoFalke> Anyone happen to have a gitian-builder/cache/* for lxc?
292 2018-08-17T19:34:43  *** StopAndDecrypt has joined #bitcoin-core-dev
293 2018-08-17T19:34:51  * gmaxwell wonders if someday we're going to find a compromised dependency this way.
294 2018-08-17T19:34:59  *** tripleslash has joined #bitcoin-core-dev
295 2018-08-17T19:35:03  *** CubicEarth has joined #bitcoin-core-dev
296 2018-08-17T19:35:27  <MarcoFalke> gitian-builder/cache/bitcoin-linux-0.17/x86_64-linux-gnu/* I meant
297 2018-08-17T19:35:36  *** cfields has joined #bitcoin-core-dev
298 2018-08-17T19:37:55  *** tripleslash has quit IRC
299 2018-08-17T19:39:16  *** tripleslash has joined #bitcoin-core-dev
300 2018-08-17T19:40:11  *** SopaXorzTaker has quit IRC
301 2018-08-17T19:45:41  *** ken2812221_ has joined #bitcoin-core-dev
302 2018-08-17T19:47:33  *** Emcy has joined #bitcoin-core-dev
303 2018-08-17T19:53:26  *** ken2812221_ has quit IRC
304 2018-08-17T19:53:57  *** Emcy has quit IRC
305 2018-08-17T19:56:51  *** cfields has quit IRC
306 2018-08-17T19:57:12  *** cfields has joined #bitcoin-core-dev
307 2018-08-17T19:59:10  *** cfields has quit IRC
308 2018-08-17T19:59:33  *** csknk has quit IRC
309 2018-08-17T20:01:25  *** cfields has joined #bitcoin-core-dev
310 2018-08-17T20:02:27  <jonasschnelli> MarcoFalke: creating a tar.bz....
311 2018-08-17T20:02:45  *** cfields has joined #bitcoin-core-dev
312 2018-08-17T20:10:57  <MarcoFalke> jonasschnelli: thx
313 2018-08-17T20:12:11  <jonasschnelli> MarcoFalke: https://bitcoin.jonasschnelli.ch/x86_64-linux-gnu.tar.bz
314 2018-08-17T20:29:40  *** vexbuy has quit IRC
315 2018-08-17T20:32:17  <MarcoFalke> docker deps: https://transfer.sh/f6AG9/x86_64-linux-gnu.tar.xz
316 2018-08-17T20:32:23  <MarcoFalke> diffoscope says it is qt
317 2018-08-17T20:33:21  *** belcher_ has quit IRC
318 2018-08-17T20:33:24  <jonasschnelli> as always. :)
319 2018-08-17T20:36:12  <MarcoFalke> https://transfer.sh/JN68e/qt_diffoscope
320 2018-08-17T20:42:46  <MarcoFalke> .rodata.str1.1 has the size difference
321 2018-08-17T20:43:51  <MarcoFalke> caused by "/usr/share/X11/xkb", it seems
322 2018-08-17T20:44:02  *** jhfrontz has quit IRC
323 2018-08-17T20:48:31  <cfields> MarcoFalke: thanks! is that the only difference?
324 2018-08-17T20:48:37  <MarcoFalke> I think so
325 2018-08-17T20:49:17  <MarcoFalke> The other changes seem due to the two rodata offsets
326 2018-08-17T20:51:01  <cfields> hmm, I wonder if qt picked up a system xcb
327 2018-08-17T20:52:18  *** xHire has quit IRC
328 2018-08-17T20:54:10  <MarcoFalke> Are these are sting literals in translation units?
329 2018-08-17T20:54:42  *** BGL has joined #bitcoin-core-dev
330 2018-08-17T20:58:14  <cfields> MarcoFalke: I think I've got it, sec
331 2018-08-17T20:59:31  <MarcoFalke> Ah it is in src/gui/configure.pri
332 2018-08-17T21:01:27  <cfields> yea, it's a hard-coded thing that comes from configure
333 2018-08-17T21:02:46  <cfields> MarcoFalke: are all arches non-deterministic?
334 2018-08-17T21:02:52  <MarcoFalke> jup
335 2018-08-17T21:03:43  *** Victorsueca has quit IRC
336 2018-08-17T21:03:45  <cfields> ok
337 2018-08-17T21:04:27  *** xHire has joined #bitcoin-core-dev
338 2018-08-17T21:04:58  *** Victorsueca has joined #bitcoin-core-dev
339 2018-08-17T21:12:16  <cfields> MarcoFalke: you happen to have a build.log for one of your linux builds?
340 2018-08-17T21:13:09  *** treyzania has joined #bitcoin-core-dev
341 2018-08-17T21:13:16  <kanzure> hmmmm wtf smtp from: is whitelisted?
342 2018-08-17T21:13:22  <MarcoFalke> overwritten by my 0.16.2 build
343 2018-08-17T21:13:30  <MarcoFalke> Maybe drahtbot has one
344 2018-08-17T21:13:30  <kanzure> *what*?
345 2018-08-17T21:15:51  <achow101> cfields: I have one
346 2018-08-17T21:16:17  <MarcoFalke> cfields: Maybe https://drahtbot.space/gitian/bitcoin/bitcoin/885a45e323e900535ede2036b91a9118f12eb52b/bitcoin-linux-build.log
347 2018-08-17T21:16:33  <MarcoFalke> for commit https://github.com/bitcoin/bitcoin/commit/885a45e323e900535ede2036b91a9118f12eb52b
348 2018-08-17T21:16:38  <achow101> nvm, I don't
349 2018-08-17T21:17:17  <cfields> MarcoFalke: yep! there's the problem! thanks.
350 2018-08-17T21:17:48  <cfields> test config.gui.tests.xkbconfigroot gave result /usr/share/X11/xkb
351 2018-08-17T21:17:49  <cfields> vs
352 2018-08-17T21:17:58  <cfields> test config.gui.tests.xkbconfigroot gave result
353 2018-08-17T21:18:21  <cfields> qt's stupid check assumes a native build.
354 2018-08-17T21:18:21  *** xHire has quit IRC
355 2018-08-17T21:18:37  <MarcoFalke> Can we force the thing to an empty string?
356 2018-08-17T21:20:23  <MarcoFalke> My suggested fix would be to remove the for loop in src/gui/configure.pri:47
357 2018-08-17T21:20:51  <cfields> I think we want to hard-code it to the most likely strong. Otherwise I would assume it may affect keyboard layout/bindings
358 2018-08-17T21:22:29  <MarcoFalke> Thoug, both of the dirs are missing on the docker?
359 2018-08-17T21:22:35  <cfields> MarcoFalke: we should just be able to set "-xkb-config-root=/usr/share/X11/xkb"
360 2018-08-17T21:23:10  <cfields> MarcoFalke: I assume some people have that dir due to other installed packages
361 2018-08-17T21:23:55  <MarcoFalke> Ah, I didn't understand. Yeah, set it to the most likely one
362 2018-08-17T21:25:59  <cfields> sec, let's see what this path is actually used for
363 2018-08-17T21:30:15  <cfields> yea, keymap stuff. And it looks like the path is hit.
364 2018-08-17T21:30:33  <cfields> We should just use whatever value the previous binaries have used.
365 2018-08-17T21:31:38  <cfields> rebuilding 0.16 to see what it did.
366 2018-08-17T21:32:53  <MarcoFalke> cfields: 0.16.2 linux-build.log on docker trusty: https://transfer.sh/b8srP/build.log
367 2018-08-17T21:33:52  <cfields> MarcoFalke: thanks!
368 2018-08-17T21:33:55  <cfields> QMAKE_XKB_CONFIG_ROOT = /usr/share/X11/xkb
369 2018-08-17T21:36:47  *** jhfrontz has joined #bitcoin-core-dev
370 2018-08-17T21:37:23  <cfields> MarcoFalke: PR incoming. I'm just doing a quick local build with a phony value to make sure that it gets inserted even if the path doesn't exist.
371 2018-08-17T21:37:46  <MarcoFalke> ok
372 2018-08-17T21:37:58  <MarcoFalke> will be offline for about 40 mins
373 2018-08-17T21:47:42  *** luke-jr has quit IRC
374 2018-08-17T21:47:58  *** luke-jr has joined #bitcoin-core-dev
375 2018-08-17T21:58:05  *** Emcy has joined #bitcoin-core-dev
376 2018-08-17T22:00:15  *** itaseski has quit IRC
377 2018-08-17T22:01:40  *** spinza has quit IRC
378 2018-08-17T22:01:45  *** rls has joined #bitcoin-core-dev
379 2018-08-17T22:03:22  <achow101> cfields: do you know why this wasn't a problem for earlier releases?
380 2018-08-17T22:03:40  <achow101> I used the docker method for 0.16.2 and 0.16.1
381 2018-08-17T22:03:57  <cfields> achow101: qt reworked their entire build-system for 5.8 iirc.
382 2018-08-17T22:04:10  <cfields> I assume this is a regression
383 2018-08-17T22:05:46  <cfields> https://bugreports.qt.io/browse/QTBUG-60005
384 2018-08-17T22:06:16  *** jb55 has quit IRC
385 2018-08-17T22:06:34  *** spinza has joined #bitcoin-core-dev
386 2018-08-17T22:07:22  <cfields> yea, the -xkb-config-root switch is broken as well, we'll have to patch :(
387 2018-08-17T22:12:30  *** michaelsdunn1 has quit IRC
388 2018-08-17T22:41:42  *** masonicboom has joined #bitcoin-core-dev
389 2018-08-17T22:45:53  *** masonicboom has quit IRC
390 2018-08-17T22:45:54  *** Krellan has joined #bitcoin-core-dev
391 2018-08-17T22:52:17  *** grafcaps has quit IRC
392 2018-08-17T22:55:19  *** murrayn has quit IRC
393 2018-08-17T23:03:45  *** masonicboom has joined #bitcoin-core-dev
394 2018-08-17T23:04:27  <cfields> MarcoFalke: See #14000
395 2018-08-17T23:04:29  <gribble> https://github.com/bitcoin/bitcoin/issues/14000 | depends: fix qt determinism by theuni · Pull Request #14000 · bitcoin/bitcoin · GitHub
396 2018-08-17T23:26:10  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
397 2018-08-17T23:29:32  *** jb55 has joined #bitcoin-core-dev
398 2018-08-17T23:36:57  *** rls has quit IRC
399 2018-08-17T23:47:31  *** harding has quit IRC