1 2018-08-22T00:01:02  *** d9b4bef9 has quit IRC
  2 2018-08-22T00:02:09  *** d9b4bef9 has joined #bitcoin-core-dev
  3 2018-08-22T00:03:01  *** d9b4bef9 has quit IRC
  4 2018-08-22T00:04:08  *** d9b4bef9 has joined #bitcoin-core-dev
  5 2018-08-22T00:05:02  *** d9b4bef9 has quit IRC
  6 2018-08-22T00:06:09  *** d9b4bef9 has joined #bitcoin-core-dev
  7 2018-08-22T00:15:11  *** Krellan has joined #bitcoin-core-dev
  8 2018-08-22T00:31:05  *** profmac has joined #bitcoin-core-dev
  9 2018-08-22T00:52:46  <kallewoof> gmaxwell: We actually disabled the "attempt if fee is same" part for address reuse after review.
 10 2018-08-22T00:53:09  <kallewoof> Sorry, "attempt and do avoidreuse if fee is same" part I mean.
 11 2018-08-22T00:53:58  <kallewoof> s/avoidreuse/avoidpartialspend/
 12 2018-08-22T00:57:22  <kallewoof> gmaxwell: see https://github.com/bitcoin/bitcoin/pull/12257#pullrequestreview-139209710
 13 2018-08-22T01:04:44  *** peevsie has quit IRC
 14 2018-08-22T01:06:23  *** jtimon has quit IRC
 15 2018-08-22T01:27:55  *** Victorsueca has quit IRC
 16 2018-08-22T01:29:04  *** Victorsueca has joined #bitcoin-core-dev
 17 2018-08-22T01:30:20  *** jhfrontz has quit IRC
 18 2018-08-22T01:38:58  <phantomcircuit> gmaxwell, what's the newhope stuff for?
 19 2018-08-22T01:39:21  <sipa> phantomcircuit: post quantum link layer encryption
 20 2018-08-22T01:45:21  *** AaronvanW has quit IRC
 21 2018-08-22T01:49:01  <gmaxwell> Post-quantum might over/undersell it a bit. Its recently become a fashionable design for ephemerial key agreement to make use a hybrid ciphersuite where your key is H(ecc || some thing else), with the rational being that some attacker could be logging all your traffic in the hopes that 20 years from now your ECC group will pratically be broken and the decrypted data will be useful to them.  Majo
 22 2018-08-22T01:49:02  <gmaxwell> r fad is to pick the other thing out of a set of things conjectured to hold up to quantum computers, but it could be helpful against more conventional crypto breaks.
 23 2018-08-22T01:51:02  <gmaxwell> kallewoof: I've reread the whole PR there and I am not seeing the rationale for that.
 24 2018-08-22T01:54:22  <phantomcircuit> gmaxwell, ah
 25 2018-08-22T01:54:32  <phantomcircuit> sipa, ah
 26 2018-08-22T01:56:17  <gmaxwell> In any case, might well turn out that any particular candidate scheme isn't secure against classical computers, much less quantum ones... thus combining it with ECC, so at worst you just waste a bit of cpu and bandwidth.
 27 2018-08-22T02:06:27  *** promag has quit IRC
 28 2018-08-22T02:22:10  *** Giszmo has quit IRC
 29 2018-08-22T02:37:55  *** Giszmo has joined #bitcoin-core-dev
 30 2018-08-22T02:50:50  *** Jmabsd has joined #bitcoin-core-dev
 31 2018-08-22T02:52:02  *** phwalkr has joined #bitcoin-core-dev
 32 2018-08-22T02:52:15  <Jmabsd> Wait, in what situations are sighash bytes not added vs. added, to ecdsa signatures in Bitcoin?  With a sighhash byte the DER signature max size is 73B (if low-s, 72B) whereas without sighash byte the max size is 72B (if low-s, 71B).
 33 2018-08-22T02:56:30  <Jmabsd> ..so "contract endorsement" is DER signature + endorsement byte (= max 73B), and the DER signature is max 72B.
 34 2018-08-22T02:59:05  <sipa> what do you mean by 'situations' ?
 35 2018-08-22T02:59:15  <sipa> every signature in bitcoin script has a sighash byte
 36 2018-08-22T03:02:00  *** profmac has quit IRC
 37 2018-08-22T03:04:21  *** jhfrontz has joined #bitcoin-core-dev
 38 2018-08-22T03:05:13  <Jmabsd> sipa: ah right, so, the zoomed-out situation in Bitcoin is that DER situations are in sigscript, redeem script (part of sigscript right) and P2WSH witness script (input's last witness element), only.
 39 2018-08-22T03:05:27  <sipa> "only" ?
 40 2018-08-22T03:05:31  <sipa> what else is there?
 41 2018-08-22T03:05:48  <Jmabsd> sipa: so those three are the only 'situations', and in each of them there's a sighash byte, and, the OP_CHECKSIG operator processes the sighash byte too.
 42 2018-08-22T03:05:55  <sipa> yes
 43 2018-08-22T03:06:10  <sipa> OP_CHECKSIG and friends all require a sighash byte
 44 2018-08-22T03:06:14  <Jmabsd> and so Bitcoin is really only dealing with the "contract endorsement" structures, and hence in the real world those are 72B+1B sighhash=73B max.
 45 2018-08-22T03:06:21  <Jmabsd> great. thx for confirming.
 46 2018-08-22T03:11:57  *** promag has joined #bitcoin-core-dev
 47 2018-08-22T03:16:48  *** promag has quit IRC
 48 2018-08-22T03:34:34  *** Krellan has quit IRC
 49 2018-08-22T03:37:38  <Jmabsd> where is CHashWriter's sourcecode?  hash.h defines the interface but its logics are not in hash.cpp
 50 2018-08-22T03:39:00  <Jmabsd> the hash used in signing is a single-pass (small-endian? err) SHA256 hash of the signtext  (here, https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1298 ) right?
 51 2018-08-22T03:39:52  <sipa> Jmabsd: hash.h has all of it
 52 2018-08-22T03:41:00  <Jmabsd> oh there we go, CHashWriter wraps CHash256, which is a double-SHA256 hashing facility.
 53 2018-08-22T03:41:10  <Jmabsd> why is double-pass SHA256 used when signing?
 54 2018-08-22T03:42:12  <sipa> Jmabsd: ask satoshi :)
 55 2018-08-22T03:42:40  <Jmabsd> aha.
 56 2018-08-22T03:46:30  <sipa> bitcoin basically everywhere either uses ripemd160(sha256(x)) or sha256(sha256(x))
 57 2018-08-22T03:50:04  <Jmabsd> sipa, right - and normally when you pass around (communicate between parties) a hash, using double-hash is a nice convention as it protects from extension attacks right
 58 2018-08-22T03:50:25  <Jmabsd> however in the particular case of using the hash as input for signature, it doesn't make sense...
 59 2018-08-22T03:50:48  <Jmabsd> or can some actual utility of double-hashing the signtext when signing be guessed / thought of?
 60 2018-08-22T03:51:04  <sipa> nope. i believe it is pointless
 61 2018-08-22T03:51:29  <sipa> protecting against length extension attacks is generally a good reason, but it doesn't apply here
 62 2018-08-22T03:53:10  <Jmabsd> aha.
 63 2018-08-22T03:55:54  <Jmabsd> sipa, two quick off-topic but conceptually related questions, as general guidance for design of any new signing protocols, would you suggest using a single hash instead of double, or could it make sense to recycle Bitcoin's double-hash for symmetry with Bitcoin?     also for guidance for other protocols, if you're going to do a salted hash of some message e.g.   SHA256HMAC(protocolmessage,"SIPAPROTOCOL"),   then for extension
 64 2018-08-22T03:55:54  <Jmabsd> protection would you do the SHA256HMAC doubly i.e.  SHA256HMAC(SHA256HMAC(protocolmessage,"SIPAPROTOCOL"),"SIPAPROTOCOL") or would you do an inner SHA256 i.e. SHA256HMAC(SHA256(protocolmessage),"SIPAPROTOCOL") ?
 65 2018-08-22T03:58:23  <sipa> Jmabsd: a good guideline is to make sure that the data you're hashing is always deserializable
 66 2018-08-22T03:58:57  <sipa> whenever you're writing things into a hash with self-descriptive lengths, length extension attacks generally don't ezist
 67 2018-08-22T03:59:04  <sipa> and i would use single hashes
 68 2018-08-22T03:59:31  <Jmabsd> ahh so you mean, if your message protocol has the format      <length><message data>,  then noone could meaningfully attack a single-hash anyhow.
 69 2018-08-22T04:00:03  <Jmabsd> because they can't forge the <length> part in a hash anyhow - however, if the message format was just <message data> then they could (given a single hash). noted.
 70 2018-08-22T04:00:44  <Jmabsd> sipa, couldn't double hashing provide some other benefit.. or you mean, hashes may be data-destructive so risk that some rainy day there'd be hash collision attacks could be higher with double-hash or?
 71 2018-08-22T04:00:55  <Jmabsd> like what's motivating arguments in the choice for and against
 72 2018-08-22T04:02:07  <Jmabsd> ..ok so i take your suggestion that single-hash, and have the message format be well-defined and mark out length, should suffice. thanks for suggesting!
 73 2018-08-22T04:05:01  *** d9b4bef9 has quit IRC
 74 2018-08-22T04:06:08  *** d9b4bef9 has joined #bitcoin-core-dev
 75 2018-08-22T04:12:43  *** rls has joined #bitcoin-core-dev
 76 2018-08-22T04:13:19  *** profmac has joined #bitcoin-core-dev
 77 2018-08-22T04:16:13  *** lone3lf has joined #bitcoin-core-dev
 78 2018-08-22T04:20:25  <Jmabsd> it would be great if crypto/sha256.cpp's SHA256D64() would be clarified in a comment, what it does exactly (https://github.com/bitcoin/bitcoin/blob/master/src/crypto/sha256.cpp#L698)
 79 2018-08-22T04:21:05  <Jmabsd> it's used in merkle calculation (https://github.com/bitcoin/bitcoin/blob/master/src/consensus/merkle.cpp#L57) and the code in itself presently leaves a little bit of guesswork to the reader about what's going on
 80 2018-08-22T04:21:11  <luke-jr> Jmabsd: SHA256(SHA256(64 bytes))
 81 2018-08-22T04:21:58  <Jmabsd> luke-jr: ah, so an optimized double-SHA256 for a 64-bytes input. so a double-sha256 optimized for merkle node calculation. neat. thanks.
 82 2018-08-22T04:22:44  <Jmabsd> luke-jr: is any particular byte ordering or "endianness" to the SHA256 used here, i've seen some Bitcoin merkle node calculation use byte-reverse logics
 83 2018-08-22T04:23:43  <sipa> Jmabsd: as i've said before, all hash functions are treated as black box that convert from byte arrays to byte arrays
 84 2018-08-22T04:23:49  <sipa> no endianness is relevant
 85 2018-08-22T04:23:51  <gmaxwell> Jmabsd: Sipa already answered this question previously.  The bitcoin protocol uses sha256 exactly as it is.
 86 2018-08-22T04:23:58  <gmaxwell> Asking again won't make the answer change.
 87 2018-08-22T04:24:07  <gmaxwell> oops. didn't mean to pile on.
 88 2018-08-22T04:24:21  <luke-jr> XD
 89 2018-08-22T04:24:32  <sipa> :)
 90 2018-08-22T04:24:58  <gmaxwell> the stuff you're seeing is probably working from hex in UIs or something, and got reversed there.
 91 2018-08-22T04:26:06  <gmaxwell> Bitcoin "UI" hashes are backwards for path dependant but otherwise explicable reasons...
 92 2018-08-22T04:27:39  <luke-jr> it's probably because the block hash is interpreted as a 256-bit little endian number for target comparison, or something like that
 93 2018-08-22T04:28:06  <Jmabsd> gmaxwell, yes interesting, i see clearly in Bitcoin Core and other implementations that indeed there is no reversing whatsoever, no "endianness" or the like here.  you are right that the code in the wild must have been mitigating some kind of user-facing hex representation quirk.
 94 2018-08-22T04:28:32  <gmaxwell> luke-jr: right, and then you want to print it so that it starts with leading 0s so that the 'less than' comparison makes sense.
 95 2018-08-22T04:28:49  <Jmabsd> i think here it's only about transaction hashes
 96 2018-08-22T04:29:12  <gmaxwell> Jmabsd: the point is that bitcoin's UI uses the same stuff to print all these 256 bit hashes.
 97 2018-08-22T04:29:16  <luke-jr> ^
 98 2018-08-22T04:30:21  <gmaxwell> block hash is interpreted as a 256-bit little endian number for target comparison as luke says, so then bitcoin needed to print it that way too, otherwise the 0s would have been on the right which would have been confusing... and the same code was then used to print other hashes.
 99 2018-08-22T04:30:29  <gmaxwell> But thats just a UI thing.
100 2018-08-22T04:32:14  <Jmabsd> gmaxwell: ahaaa so for symmetry reasons there's reverse output order of transaction hashes too, i understand - "big endian".
101 2018-08-22T04:32:38  <Jmabsd> noo, little-endian.
102 2018-08-22T04:33:20  <Jmabsd> gmaxwell, this applies only to the string representation of block hashes and transaction hashes - any more?
103 2018-08-22T04:34:11  <luke-jr> Jmabsd: the hash is interpreted little-endian, and printed big-endian. don't try too hard to make endian sense of it or you'll hurt your brain :P
104 2018-08-22T04:35:54  <Jmabsd> luke-jr: this transformation when providing a string serialization, has it been applied (assumed as convention to be applied) to any more data than block hashes and transaction hashes?
105 2018-08-22T04:36:53  <luke-jr> off-hand, I don't think we print any other hashes in the UI, but I could be forgetting something
106 2018-08-22T04:38:26  <sipa> Jmabsd: it's used everywhere hashes are printed for human consumption
107 2018-08-22T04:38:32  <sipa> so txids and block hashes
108 2018-08-22T04:38:41  <sipa> also the chainstate hash in gettxoutsetinfo
109 2018-08-22T04:39:21  <Jmabsd> hash prints.. hm.. ok so it won't apply to other data like merkle tree root printouts? or signatures and such. ok. (y)
110 2018-08-22T04:39:28  <luke-jr> I'm glad getwork is gone :D
111 2018-08-22T04:40:07  <luke-jr> Jmabsd: probably there too
112 2018-08-22T04:40:13  <luke-jr> but that's not really exposed to the user
113 2018-08-22T04:40:26  <luke-jr> (other than RPC stuff)
114 2018-08-22T04:41:42  <Jmabsd> aha. ok so the quirk of this reverse ordering UI representation thing, is that transaction hashes have the funny representation order too, and this needs a bit of extra consideration when making a simple example script to calculate merkle nodes, as they need to reverse the byte order of the transaction hash. gotcha.
115 2018-08-22T04:42:48  *** ExtraCrispy has quit IRC
116 2018-08-22T04:43:00  <luke-jr> Jmabsd: no, not there
117 2018-08-22T04:43:11  <sipa> Jmabsd: no, it's only used when printing for human consumption
118 2018-08-22T04:43:21  <sipa> internally there is no reversing ever
119 2018-08-22T04:43:36  <luke-jr> I'm not 100% sure, but I suspect the merkle root is printed reversed in getblock RPC for example; but never internally
120 2018-08-22T04:43:47  <sipa> oh, yes it is
121 2018-08-22T04:43:58  <sipa> but again, just when converting to hex
122 2018-08-22T04:45:33  <Jmabsd> luke-jr, what's the code location for this hex serialization?
123 2018-08-22T04:46:05  <Jmabsd> (yes I totally see that Bitcoin Core or the Bitcoin protocol never represent data in reverse order internally - it's only a human representation thing)
124 2018-08-22T04:46:48  <Jmabsd> sipa, right, so it's when you're making a test script on the theme "user enters two+ transaction hashes for you to calculate merkle nodes / merkle root out of it", you take the human-output form as input there.
125 2018-08-22T04:47:09  <Jmabsd> also when making a block explorer and taking transaction hashes, you take the reverse form as input there too no?
126 2018-08-22T04:47:48  *** lone3lf has quit IRC
127 2018-08-22T04:51:00  *** airplanemod has joined #bitcoin-core-dev
128 2018-08-22T04:52:11  *** Rootsudo has joined #bitcoin-core-dev
129 2018-08-22T04:53:00  <sipa> Jmabsd: uint256's ToString() method
130 2018-08-22T04:58:32  <airplanemod> Hey guys, I would like to know if it is possible to set up a development environment for bitcoin-qt and/or bitcoind that will allow me to set breakpoints and step through live code as it is running? I cannot seem to find a tutorial or any good starting point for how to do this. I have been testing my own edits in a simple text editor and using gitian builder to compile and test using
131 2018-08-22T04:58:33  <airplanemod> the debug.log file but that is tedious and time-consuming work. Can anyone give any tips or pointers for how I might get a proper developement environment set up for testing?
132 2018-08-22T05:01:00  <sipa> airplanemod: sure, you can run bitcoind in gdb or so
133 2018-08-22T05:01:50  <sipa> setting up a development environment isn't very bitcoin core specific, so i wouldn't say is on topic here
134 2018-08-22T05:02:05  <sipa> but it's no different than other c/c++ projects
135 2018-08-22T05:03:27  *** helo has joined #bitcoin-core-dev
136 2018-08-22T05:04:48  *** phwalkr has quit IRC
137 2018-08-22T05:06:09  <airplanemod> ok thanks for replying sipa. Ive done tons of development but never touched c++ so I wasnt sure if there was a recommended IDE or anything specific that would cater to blockchain dev specifically or if its easier on linux vs windows for example
138 2018-08-22T05:08:24  <sipa> airplanemod: bitcoin core is primarily developed on unix systems (and the windows binaries are produced through cross compiling on linux)
139 2018-08-22T05:08:35  *** Jmabsd has quit IRC
140 2018-08-22T05:08:50  <sipa> you can use an IDE if you like, but i believe most developers use just text editors
141 2018-08-22T05:11:26  <luke-jr> I use a text editor with syntax highlighting
142 2018-08-22T05:11:42  <airplanemod> sipa: thats kind of what I was wondering about. so most developers are editing the source and then building binary executable files to test their changes? thats what Ive been doing up to now but I consider that to be working blind
143 2018-08-22T05:11:57  *** windsok has quit IRC
144 2018-08-22T05:12:21  <sipa> yes, i just use a text editor
145 2018-08-22T05:12:54  <airplanemod> im guessing because of the complexity of how the bicoin wallet works that it isnt possible to run it in a debugger. i couldnt find any info online to suggest this would be possible which is why i came here to ask
146 2018-08-22T05:12:59  <luke-jr> I'm not aware of any way to modify code at runtime
147 2018-08-22T05:13:09  <luke-jr> airplanemod: running it in a debugger just works
148 2018-08-22T05:13:26  <luke-jr> (in valgrind, is a bit more painful..)
149 2018-08-22T05:13:27  <airplanemod> luke-jr: not modify code at runtime but see the contents of variables
150 2018-08-22T05:15:45  <sipa> airplanemod: i occasionally run bitcoind in a debugger
151 2018-08-22T05:16:02  <sipa> which lets you put breakpoints and see the contents of variables etc
152 2018-08-22T05:16:30  <sipa> inside functional tests it's harder though, as they spin up multiple communicating bitcoinds
153 2018-08-22T05:17:06  <airplanemod> sipa: is that with gbd? (i havent used gdb before but i did come across it already tonight in my search)
154 2018-08-22T05:17:06  <luke-jr> while ! gdb -p $(ps ax | grep node0 | cut -b 1-5); do true; done
155 2018-08-22T05:17:08  <luke-jr> <.<
156 2018-08-22T05:17:17  <sipa> airplanemod: yes, gdb
157 2018-08-22T05:18:42  <airplanemod> great, thanks guys. I will look into gdb and keep using my text editor for qt debugging
158 2018-08-22T05:20:32  *** someone235 has joined #bitcoin-core-dev
159 2018-08-22T05:22:23  *** airplanemod has left #bitcoin-core-dev
160 2018-08-22T05:25:06  *** Krellan has joined #bitcoin-core-dev
161 2018-08-22T05:40:54  *** Rootsudo has quit IRC
162 2018-08-22T05:50:21  *** phwalkr has joined #bitcoin-core-dev
163 2018-08-22T06:11:35  *** intcat has quit IRC
164 2018-08-22T06:18:21  *** intcat has joined #bitcoin-core-dev
165 2018-08-22T07:02:27  *** someone235 has quit IRC
166 2018-08-22T07:10:08  <kallewoof> gmaxwell: since sdaftuar objected, I figured I could make a separate PR with that enabled. I'll do that soon.
167 2018-08-22T07:23:13  *** vexbuy has quit IRC
168 2018-08-22T07:23:47  *** Emcy has quit IRC
169 2018-08-22T07:23:48  *** vexbuy has joined #bitcoin-core-dev
170 2018-08-22T07:23:50  *** Emcy_ has joined #bitcoin-core-dev
171 2018-08-22T07:25:24  *** Amuza has joined #bitcoin-core-dev
172 2018-08-22T07:28:07  *** someone235 has joined #bitcoin-core-dev
173 2018-08-22T07:28:42  *** vexbuy has quit IRC
174 2018-08-22T07:37:01  *** emzy has joined #bitcoin-core-dev
175 2018-08-22T07:43:09  *** vexbuy has joined #bitcoin-core-dev
176 2018-08-22T07:53:39  *** JackH has quit IRC
177 2018-08-22T07:58:47  *** csknk has joined #bitcoin-core-dev
178 2018-08-22T08:18:01  *** setpill has joined #bitcoin-core-dev
179 2018-08-22T08:26:45  *** vexbuy has quit IRC
180 2018-08-22T08:27:18  *** vexbuy has joined #bitcoin-core-dev
181 2018-08-22T08:31:42  *** vexbuy has quit IRC
182 2018-08-22T08:34:02  *** vexbuy has joined #bitcoin-core-dev
183 2018-08-22T08:44:15  *** vexbuy has quit IRC
184 2018-08-22T08:53:54  *** AaronvanW has joined #bitcoin-core-dev
185 2018-08-22T09:03:32  *** atroxes has quit IRC
186 2018-08-22T09:04:25  *** intcat has quit IRC
187 2018-08-22T09:04:54  *** atroxes has joined #bitcoin-core-dev
188 2018-08-22T09:06:10  *** intcat has joined #bitcoin-core-dev
189 2018-08-22T09:11:52  *** promag has joined #bitcoin-core-dev
190 2018-08-22T09:17:01  *** promag has quit IRC
191 2018-08-22T09:28:22  *** Lauda has quit IRC
192 2018-08-22T09:28:57  *** Lauda has joined #bitcoin-core-dev
193 2018-08-22T09:35:25  *** elichai2 has joined #bitcoin-core-dev
194 2018-08-22T10:03:12  *** profmac has quit IRC
195 2018-08-22T10:16:31  *** Guyver2 has joined #bitcoin-core-dev
196 2018-08-22T10:19:23  *** rls has quit IRC
197 2018-08-22T10:30:44  *** vexbuy has joined #bitcoin-core-dev
198 2018-08-22T10:40:38  *** profmac has joined #bitcoin-core-dev
199 2018-08-22T10:47:14  *** promag has joined #bitcoin-core-dev
200 2018-08-22T10:51:59  *** promag has quit IRC
201 2018-08-22T11:01:09  <wumpus> arhhhhh noooo why does restarting your node cut up the debug.log again
202 2018-08-22T11:01:33  <wumpus> lost more than a day of perf data
203 2018-08-22T11:04:35  <wumpus> luke-jr: whooops, okay, will build windows then
204 2018-08-22T11:11:31  *** windsok has joined #bitcoin-core-dev
205 2018-08-22T11:45:33  *** qu4ku has joined #bitcoin-core-dev
206 2018-08-22T11:46:44  *** plankers has joined #bitcoin-core-dev
207 2018-08-22T12:15:16  *** wxss has joined #bitcoin-core-dev
208 2018-08-22T12:20:01  *** alicehatesbob has quit IRC
209 2018-08-22T12:20:25  *** meshcollider has joined #bitcoin-core-dev
210 2018-08-22T12:39:29  *** qu4ku has quit IRC
211 2018-08-22T12:50:23  *** promag has joined #bitcoin-core-dev
212 2018-08-22T12:55:02  *** promag has quit IRC
213 2018-08-22T13:00:32  *** rex4539 has joined #bitcoin-core-dev
214 2018-08-22T13:04:48  *** victorSN is now known as summitto
215 2018-08-22T13:05:19  *** summitto is now known as vicSN
216 2018-08-22T13:05:27  *** vicSN is now known as victorSN
217 2018-08-22T13:20:35  *** vexbuy has quit IRC
218 2018-08-22T13:22:38  *** vexbuy has joined #bitcoin-core-dev
219 2018-08-22T13:23:31  *** Amuza has quit IRC
220 2018-08-22T13:31:54  <wumpus> ok, everything pending for 0.17 has been merged again, time to tag rc2?
221 2018-08-22T13:32:03  <wumpus> it should at least be deterministic this time
222 2018-08-22T13:34:33  <MarcoFalke> go ahead
223 2018-08-22T13:37:18  <instagibbs> SGTM
224 2018-08-22T13:37:53  <instagibbs> appreciate the psbt fix merges last-minute
225 2018-08-22T13:43:58  *** vexbuy has quit IRC
226 2018-08-22T13:47:42  *** promag has joined #bitcoin-core-dev
227 2018-08-22T13:50:23  *** qu4ku has joined #bitcoin-core-dev
228 2018-08-22T13:52:42  *** promag has quit IRC
229 2018-08-22T13:53:21  *** fanquake has joined #bitcoin-core-dev
230 2018-08-22T13:53:42  <fanquake> wumpus 👍
231 2018-08-22T13:54:39  <fanquake> I’d like to be able to re-create the NSIS issue at some point. Just for interest
232 2018-08-22T13:55:08  *** fanquake has quit IRC
233 2018-08-22T13:57:35  *** qu4ku has quit IRC
234 2018-08-22T14:00:52  *** Krellan has quit IRC
235 2018-08-22T14:01:01  <wumpus>  * [new tag]                                                                           v0.17.0rc2 -> v0.17.0rc2
236 2018-08-22T14:01:41  *** Krellan has joined #bitcoin-core-dev
237 2018-08-22T14:04:34  <jonasschnelli> \o/
238 2018-08-22T14:05:02  <jonasschnelli> Is there a known issue with ./test/functional/wallet_backup.py? It failes often on my branch (though did some unrelated changes)?
239 2018-08-22T14:05:24  *** JackH has joined #bitcoin-core-dev
240 2018-08-22T14:08:33  <wumpus> not known to me, at least
241 2018-08-22T14:15:21  <wumpus> wallet_backup.py passed, Duration: 106 s
242 2018-08-22T14:16:05  <jonasschnelli> okay... probably a local issue
243 2018-08-22T14:17:38  *** vexbuy has joined #bitcoin-core-dev
244 2018-08-22T14:20:17  *** Guest11272 is now known as sturles
245 2018-08-22T14:21:21  *** fanquake has joined #bitcoin-core-dev
246 2018-08-22T14:21:32  <fanquake> \o/
247 2018-08-22T14:24:37  *** fanquake has quit IRC
248 2018-08-22T14:25:12  <wumpus>  /o\
249 2018-08-22T14:25:50  <achow101> \o\
250 2018-08-22T14:27:21  <wumpus> /o/
251 2018-08-22T14:27:55  <wumpus> the new version of lxc did make a long-standing issue go away for me where the first build try after starting the VM would always fail
252 2018-08-22T14:28:24  <achow101> apparently kvm is still broken even with the updated vmbuilder :(
253 2018-08-22T14:29:49  <wumpus> so if you can build a bionic image succesfully, what is the problem?
254 2018-08-22T14:30:10  <achow101> err, I mean that vmbuilder still doesn't work
255 2018-08-22T14:30:16  <achow101> so you can't build the bionic image
256 2018-08-22T14:35:18  <wumpus> maybe one of the ready-made ubuntu cloud images would be useful?
257 2018-08-22T14:37:06  *** michaelsdunn1 has joined #bitcoin-core-dev
258 2018-08-22T14:37:07  <wumpus> that's how I spin up new VMs locally, download the appropriate ubuntu cloud image, verify gpg signatures, convert to qcow2 format, resize, then launch it. I don't use this process for gitian, but I don't  see why it wouldn't be similar.
259 2018-08-22T14:41:08  *** SopaXorzTaker has joined #bitcoin-core-dev
260 2018-08-22T14:44:52  <jonasschnelli> wumpus: wallet_backup.py is also failing on master on my debian system
261 2018-08-22T14:44:53  <jonasschnelli> 'importwallet' RPC took longer than 60.000000 seconds
262 2018-08-22T14:45:07  <jonasschnelli> (4 instances of Core mainnet are runnning in the background though)
263 2018-08-22T14:45:31  <wumpus> jonasschnelli: maybe you can make it pass by increaing the timeout
264 2018-08-22T14:45:57  <wumpus> if it's really crashing, it would be interesting to attach a debugger and see where
265 2018-08-22T14:45:59  *** fanquake has joined #bitcoin-core-dev
266 2018-08-22T14:47:00  <fanquake> wumpus I think I’ve seen the same issue on my old Debian setup. Haven’t seen on the newer setup.
267 2018-08-22T14:47:11  <jonasschnelli> wumpus: I think importwallet is just slower then the timeout,... but I'll investigate
268 2018-08-22T14:50:10  *** fanquake has quit IRC
269 2018-08-22T14:50:47  <wumpus> right-importwallet is a call that can be slow so it doesn't surprise me
270 2018-08-22T14:59:02  <MarcoFalke> jonasschnelli: You could maybe fix that with "self.rpc_timewait = 90"
271 2018-08-22T14:59:08  <MarcoFalke> like in feature_dbcrash
272 2018-08-22T14:59:26  <jonasschnelli> MarcoFalke: Yes. I think that is necessary
273 2018-08-22T14:59:26  <MarcoFalke> or wallet_dump.py
274 2018-08-22T14:59:58  <jonasschnelli> MarcoFalke: IMO wallet_dumps.py:L84 self.rpc_timeout = 120 is invalid
275 2018-08-22T15:00:06  <jonasschnelli> It should be self.rpc_timewait = 120
276 2018-08-22T15:00:15  <MarcoFalke> oh
277 2018-08-22T15:00:44  <jonasschnelli> I saw both (wallet_dump and wallet_backup) failing on my system (and on travis)
278 2018-08-22T15:01:03  <jonasschnelli> Maybe they don't fall on bitcoin/bitcoin travis due to the exta CPU cycles we bought
279 2018-08-22T15:01:51  <MarcoFalke> right
280 2018-08-22T15:02:17  <MarcoFalke> Looks it is wrong in wallet_dump
281 2018-08-22T15:02:39  <MarcoFalke> Not sure about travis
282 2018-08-22T15:02:52  <MarcoFalke> We only bought additional machines, but the machines are itself identical
283 2018-08-22T15:03:08  <jonasschnelli> Okay. But when I enabled travis for my local branch, master failes
284 2018-08-22T15:03:23  <jonasschnelli> And master fails always on my debian machine
285 2018-08-22T15:08:07  <MarcoFalke> jonasschnelli: Huh, I can't find any recent travis builds on you repo https://github.com/jonasschnelli/bitcoin/commits/master
286 2018-08-22T15:08:24  <jonasschnelli> https://api.travis-ci.org/v3/job/419216711/log.txt
287 2018-08-22T15:08:42  <jonasschnelli> I was flipping forward and backward in my commit history...
288 2018-08-22T15:09:49  <jonasschnelli> Its all on my BIP151 branch
289 2018-08-22T15:11:10  <jonasschnelli> cef09c6e3d13bc082a5cdb878324b350a17c492fa77af805e0745ba52ee031aa  bitcoin-0.17.0-osx-unsigned.dmg
290 2018-08-22T15:11:23  <jonasschnelli> 3e953061e6baa7dc4d759d8447041071bff6222bc70188a66eddbcee8136c55e  bitcoin-0.17.0-win-unsigned.tar.gz
291 2018-08-22T15:15:45  <MarcoFalke> hmm, might be related to some bip151 changes?
292 2018-08-22T15:15:46  *** someone235 has quit IRC
293 2018-08-22T15:16:18  *** itaseski has joined #bitcoin-core-dev
294 2018-08-22T15:17:04  <MarcoFalke> you could first push the current master and then rebase the bip151 branch on that?
295 2018-08-22T15:19:42  *** rex4539 has quit IRC
296 2018-08-22T15:22:21  <MarcoFalke> But yeah, you can just bump the timeouts a little and submit a pull request. I think there is no harm in that
297 2018-08-22T15:32:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
298 2018-08-22T15:41:02  *** setpill has quit IRC
299 2018-08-22T16:04:43  <gmaxwell> damn, on the power9 host here at least the block loading step of a reindex takes an hour and five minutes.
300 2018-08-22T16:04:51  <gmaxwell> now.
301 2018-08-22T16:06:25  <sipa> gmaxwell: how much on x86?
302 2018-08-22T16:07:56  <gmaxwell> dunno, don't have a reasonably fast x86 machine running right now.
303 2018-08-22T16:10:46  <gmaxwell> It was about a half hour back in november... so it's totally plausable to me that its an hour now.
304 2018-08-22T16:12:32  *** Victorsueca has quit IRC
305 2018-08-22T16:13:44  *** Victorsueca has joined #bitcoin-core-dev
306 2018-08-22T16:18:34  *** MarcoFalke has quit IRC
307 2018-08-22T16:33:29  *** vexbuy has quit IRC
308 2018-08-22T16:33:41  *** Zenton has quit IRC
309 2018-08-22T16:34:26  *** vexbuy has joined #bitcoin-core-dev
310 2018-08-22T16:53:35  *** promag has joined #bitcoin-core-dev
311 2018-08-22T16:58:21  *** promag has quit IRC
312 2018-08-22T17:07:10  *** phwalkr has joined #bitcoin-core-dev
313 2018-08-22T17:13:29  *** phwalkr has quit IRC
314 2018-08-22T17:16:54  *** Guyver2 has quit IRC
315 2018-08-22T17:25:21  *** wxss has quit IRC
316 2018-08-22T17:25:21  *** d9b4bef9 has quit IRC
317 2018-08-22T17:25:21  *** IGHOR_ has quit IRC
318 2018-08-22T17:25:21  *** no_input_found has quit IRC
319 2018-08-22T17:25:21  *** StopAndDecrypt has quit IRC
320 2018-08-22T17:25:21  *** dcousens has quit IRC
321 2018-08-22T17:25:21  *** murrayn has quit IRC
322 2018-08-22T17:25:21  *** DougieBot5000_ has quit IRC
323 2018-08-22T17:25:21  *** tryphe has quit IRC
324 2018-08-22T17:25:21  *** Jbaczuk has quit IRC
325 2018-08-22T17:25:22  *** twistedline has quit IRC
326 2018-08-22T17:25:22  *** MDrollette has quit IRC
327 2018-08-22T17:25:22  *** wumpus has quit IRC
328 2018-08-22T17:25:22  *** jimpo has quit IRC
329 2018-08-22T17:25:22  *** [b__b] has quit IRC
330 2018-08-22T17:25:22  *** ossifrage has quit IRC
331 2018-08-22T17:25:22  *** wraithm has quit IRC
332 2018-08-22T17:25:22  *** thib has quit IRC
333 2018-08-22T17:25:22  *** newbie-- has quit IRC
334 2018-08-22T17:33:53  *** MarcoFalke has joined #bitcoin-core-dev
335 2018-08-22T17:34:37  *** vexbuy has quit IRC
336 2018-08-22T17:36:33  *** MarcoFalke has quit IRC
337 2018-08-22T17:37:23  *** MarcoFalke has joined #bitcoin-core-dev
338 2018-08-22T17:37:56  <jonasschnelli> MarcoFalke: travis on my repository fails even on the lint level: https://travis-ci.org/jonasschnelli/bitcoin/jobs/419285727
339 2018-08-22T17:37:58  <jonasschnelli> Any idea?
340 2018-08-22T17:39:24  <MarcoFalke> rerun all jobs and cancel the linter
341 2018-08-22T17:39:53  <MarcoFalke> They are known to be broken and only meant to run on bitcoin/bitcoin pull requests
342 2018-08-22T17:42:19  <jonasschnelli> Okay. Done.. but meh
343 2018-08-22T17:51:29  <MarcoFalke> Agree on meh, but I am not going to touch the linters again ;)
344 2018-08-22T17:59:38  *** MarcoFalke has quit IRC
345 2018-08-22T18:00:30  *** lone3lf has joined #bitcoin-core-dev
346 2018-08-22T18:09:08  *** dcousens has joined #bitcoin-core-dev
347 2018-08-22T18:09:57  *** twistedline has joined #bitcoin-core-dev
348 2018-08-22T18:14:08  *** lone3lf has quit IRC
349 2018-08-22T18:22:16  *** dgenr8 has quit IRC
350 2018-08-22T18:23:46  *** provoostenator has joined #bitcoin-core-dev
351 2018-08-22T18:25:26  *** michaelsdunn1 has quit IRC
352 2018-08-22T18:25:27  *** michaelsdunn1 has joined #bitcoin-core-dev
353 2018-08-22T18:26:42  *** wumpus has joined #bitcoin-core-dev
354 2018-08-22T18:27:12  <wumpus> fyi: gitian 0.17.0rc2 sigs up
355 2018-08-22T18:28:53  <provoostenator> Building... By the way, the web chat logs now say "BotBot disconnected, possible missing messages"
356 2018-08-22T18:29:35  *** CubicEarth has quit IRC
357 2018-08-22T18:29:42  <wumpus> I was kicked off too (and couldn't easily come back, SASL timeout issue)
358 2018-08-22T18:33:12  *** CubicEarth has joined #bitcoin-core-dev
359 2018-08-22T18:34:48  <wumpus> (so with sigs up, I mean my own, not codesigned sigs)
360 2018-08-22T18:41:59  *** vexbuy has joined #bitcoin-core-dev
361 2018-08-22T18:52:25  *** JackH has quit IRC
362 2018-08-22T18:59:56  *** [b__b] has joined #bitcoin-core-dev
363 2018-08-22T19:11:17  *** chainhead_ has quit IRC
364 2018-08-22T19:18:32  *** michaelsdunn1 has quit IRC
365 2018-08-22T19:23:12  *** MarcoFalke has joined #bitcoin-core-dev
366 2018-08-22T19:46:02  *** SopaXorzTaker has quit IRC
367 2018-08-22T19:46:26  *** nodweber has quit IRC
368 2018-08-22T19:47:22  *** elichai2 has quit IRC
369 2018-08-22T19:50:50  *** grubles has quit IRC
370 2018-08-22T20:06:32  *** tryphe has joined #bitcoin-core-dev
371 2018-08-22T20:07:27  *** larrybeck has joined #bitcoin-core-dev
372 2018-08-22T20:08:48  *** larrybeck has quit IRC
373 2018-08-22T20:11:26  *** larrybeck has joined #bitcoin-core-dev
374 2018-08-22T20:14:06  *** tryphe has joined #bitcoin-core-dev
375 2018-08-22T20:21:15  *** csknk has quit IRC
376 2018-08-22T20:22:48  *** promag has joined #bitcoin-core-dev
377 2018-08-22T20:25:35  *** Krellan has quit IRC
378 2018-08-22T20:26:47  *** Krellan has joined #bitcoin-core-dev
379 2018-08-22T20:27:08  *** promag has quit IRC
380 2018-08-22T20:30:29  *** Jbaczuk has joined #bitcoin-core-dev
381 2018-08-22T20:30:53  *** thib has joined #bitcoin-core-dev
382 2018-08-22T20:34:58  *** Giszmo has quit IRC
383 2018-08-22T20:36:08  *** d9b4bef9 has joined #bitcoin-core-dev
384 2018-08-22T20:37:01  *** d9b4bef9 has quit IRC
385 2018-08-22T20:38:08  *** d9b4bef9 has joined #bitcoin-core-dev
386 2018-08-22T20:40:05  *** larrybeck has quit IRC
387 2018-08-22T20:41:19  *** larrybeck has joined #bitcoin-core-dev
388 2018-08-22T20:46:04  *** rex4539 has joined #bitcoin-core-dev
389 2018-08-22T20:51:07  *** Giszmo has joined #bitcoin-core-dev
390 2018-08-22T20:51:14  <kanzure> can someone kill the spam plzkthx
391 2018-08-22T20:51:43  <kanzure> on github
392 2018-08-22T20:52:18  <sipa> blocked him
393 2018-08-22T20:52:42  *** thib has quit IRC
394 2018-08-22T20:55:53  *** BashCo has joined #bitcoin-core-dev
395 2018-08-22T20:56:10  *** farmerwampum has joined #bitcoin-core-dev
396 2018-08-22T20:56:28  <wumpus> thanks
397 2018-08-22T20:59:06  *** promag has joined #bitcoin-core-dev
398 2018-08-22T20:59:41  *** farmerwampum_ has quit IRC
399 2018-08-22T20:59:48  *** farmerwampum has quit IRC
400 2018-08-22T21:00:07  *** farmerwampum has joined #bitcoin-core-dev
401 2018-08-22T21:04:14  *** promag has quit IRC
402 2018-08-22T21:08:17  *** grafcaps has joined #bitcoin-core-dev
403 2018-08-22T21:09:35  *** Victorsueca has quit IRC
404 2018-08-22T21:10:43  *** Victorsueca has joined #bitcoin-core-dev
405 2018-08-22T21:13:58  *** vexbuy_ has joined #bitcoin-core-dev
406 2018-08-22T21:17:54  *** lesderid has quit IRC
407 2018-08-22T21:19:22  <gmaxwell> Is there a proper way to get information out of connOptions from some random place in the code? I want to make the tip may be stale stuff not run in all the cases where its pointless, (reindex/network inactive/-noconnect...)
408 2018-08-22T21:19:34  *** Chris_Stewart_5 has quit IRC
409 2018-08-22T21:19:42  *** lesderid has joined #bitcoin-core-dev
410 2018-08-22T21:33:37  <wumpus> the variables from connOptions end up in CConnman, so I guess only where the code has access to that
411 2018-08-22T21:35:14  *** larrybeck has quit IRC
412 2018-08-22T21:36:10  <gmaxwell> k, I'll add an accessor.
413 2018-08-22T21:38:21  *** michaelsdunn1 has joined #bitcoin-core-dev
414 2018-08-22T21:52:50  *** promag has joined #bitcoin-core-dev
415 2018-08-22T21:57:32  *** promag has quit IRC
416 2018-08-22T22:03:41  *** str4d has joined #bitcoin-core-dev
417 2018-08-22T22:05:31  *** ossifrage has joined #bitcoin-core-dev
418 2018-08-22T22:18:50  *** intcat has quit IRC
419 2018-08-22T22:22:46  *** intcat has joined #bitcoin-core-dev
420 2018-08-22T22:24:58  *** rls has joined #bitcoin-core-dev
421 2018-08-22T22:25:05  *** str4d has quit IRC
422 2018-08-22T22:56:18  *** itaseski has quit IRC
423 2018-08-22T23:05:30  *** grubles has joined #bitcoin-core-dev
424 2018-08-22T23:07:45  *** grubles has quit IRC
425 2018-08-22T23:09:48  *** grubles has joined #bitcoin-core-dev
426 2018-08-22T23:12:41  *** Victorsueca has quit IRC
427 2018-08-22T23:14:14  *** Victorsueca has joined #bitcoin-core-dev
428 2018-08-22T23:16:20  *** michaelsdunn1 has quit IRC
429 2018-08-22T23:20:41  *** arubi has quit IRC
430 2018-08-22T23:21:14  *** owowo has quit IRC
431 2018-08-22T23:25:43  *** arubi has joined #bitcoin-core-dev
432 2018-08-22T23:26:53  *** lnostdal has quit IRC
433 2018-08-22T23:27:05  *** owowo has joined #bitcoin-core-dev
434 2018-08-22T23:51:13  *** michaelsdunn1 has joined #bitcoin-core-dev
435 2018-08-22T23:56:05  *** michaelsdunn1 has quit IRC
436 2018-08-22T23:56:26  *** grafcaps has quit IRC