12018-08-29T00:02:17 *** alexneudatchin has joined #bitcoin-core-dev
22018-08-29T00:03:49 *** intcat has quit IRC
32018-08-29T00:06:34 *** intcat has joined #bitcoin-core-dev
42018-08-29T00:09:05 *** grafcaps has quit IRC
52018-08-29T00:24:49 <phantomcircuit> anybody know why we sleep in ThreadSocketHandler when select() fails ?
62018-08-29T00:25:13 <phantomcircuit> (it's all the way back to satoshi so cant exactly ask the author)
72018-08-29T00:28:23 <gmaxwell> presumably to avoid slamming it when it fails under the assumption that if it fails its not going to stop failing for a bit.
82018-08-29T00:30:37 <phantomcircuit> gmaxwell, it seems like basically every way it can fail except EINTR is a catastrophic failure and should just exit
92018-08-29T00:30:44 *** intcat has quit IRC
102018-08-29T00:31:10 <phantomcircuit> other things are like you gave it an invalid fd which should never happen
112018-08-29T00:32:21 <sipa> phantomcircuit: well, is it triggering for you?
122018-08-29T00:32:52 *** alexneudatchin has quit IRC
132018-08-29T00:33:11 <phantomcircuit> sipa, no and i cant remember ever seeing "socket select error" in logs
142018-08-29T00:33:25 <phantomcircuit> quick split up and search debug.log's far and wide
152018-08-29T00:36:18 *** itaseski has quit IRC
162018-08-29T00:37:33 *** intcat has joined #bitcoin-core-dev
172018-08-29T01:03:27 *** promag has quit IRC
182018-08-29T01:19:20 *** _flow_ has quit IRC
192018-08-29T01:19:20 *** harrigan has quit IRC
202018-08-29T01:19:20 *** michagogo has quit IRC
212018-08-29T01:19:20 *** earlz has quit IRC
222018-08-29T01:19:20 *** rockhouse has quit IRC
232018-08-29T01:19:40 *** earlz has joined #bitcoin-core-dev
242018-08-29T01:21:18 *** _flow_ has joined #bitcoin-core-dev
252018-08-29T01:21:47 *** harrigan has joined #bitcoin-core-dev
262018-08-29T01:22:23 *** rockhouse has joined #bitcoin-core-dev
272018-08-29T01:36:23 *** profmac has joined #bitcoin-core-dev
282018-08-29T01:44:21 *** AaronvanW has quit IRC
292018-08-29T01:54:37 *** lightningbot has joined #bitcoin-core-dev
302018-08-29T01:55:19 *** paracyst has joined #bitcoin-core-dev
312018-08-29T02:02:25 *** echeveria has joined #bitcoin-core-dev
322018-08-29T02:20:08 *** ken2812221 has joined #bitcoin-core-dev
332018-08-29T02:34:26 *** rafalcpp has quit IRC
342018-08-29T02:42:49 *** [b__b] has quit IRC
352018-08-29T02:42:50 *** achow101 has quit IRC
362018-08-29T02:42:50 *** jonasschnelli has quit IRC
372018-08-29T02:42:50 *** twistedline has quit IRC
382018-08-29T02:42:50 *** lifeofguenter has quit IRC
392018-08-29T02:42:50 *** barq has quit IRC
402018-08-29T02:42:50 *** Liliaceae has quit IRC
412018-08-29T02:42:51 *** gleb has quit IRC
422018-08-29T02:42:51 *** infernix has quit IRC
432018-08-29T02:42:51 *** TD-Linux has quit IRC
442018-08-29T02:42:51 *** CodeShark has quit IRC
452018-08-29T02:42:51 *** z323 has quit IRC
462018-08-29T02:42:51 *** kakobrekla has quit IRC
472018-08-29T02:42:52 *** hsmiths has quit IRC
482018-08-29T02:42:52 *** isis has quit IRC
492018-08-29T02:42:52 *** Fuzzbawls has quit IRC
502018-08-29T02:42:52 *** sugarpuff has quit IRC
512018-08-29T02:42:52 *** Dyaheon has quit IRC
522018-08-29T02:42:52 *** midnightmagic has quit IRC
532018-08-29T02:42:53 *** gmaxwell has quit IRC
542018-08-29T02:42:53 *** jouke has quit IRC
552018-08-29T02:42:53 *** kinlo has quit IRC
562018-08-29T02:42:53 *** dc1 has quit IRC
572018-08-29T02:42:53 *** aj has quit IRC
582018-08-29T02:42:53 *** Apocalyptic has quit IRC
592018-08-29T02:43:53 *** grubles has quit IRC
602018-08-29T02:52:27 *** ChanServ sets mode: +o sipa
612018-08-29T02:52:39 *** ChanServ sets mode: +o sipa
622018-08-29T02:53:42 *** Apocalyptic has joined #bitcoin-core-dev
632018-08-29T02:56:29 *** Fuzzbawls has joined #bitcoin-core-dev
642018-08-29T02:57:01 *** gmaxwell has joined #bitcoin-core-dev
652018-08-29T02:57:20 <gmaxwell> can we try removing +r again, I just couldn't join for a while because freenode bumped me and nickserv was down
662018-08-29T02:57:52 *** [b__b] has joined #bitcoin-core-dev
672018-08-29T02:58:02 *** grubles has joined #bitcoin-core-dev
682018-08-29T02:58:15 *** kinlo has joined #bitcoin-core-dev
692018-08-29T02:58:15 *** twistedline has joined #bitcoin-core-dev
702018-08-29T02:58:35 *** midnightmagic has joined #bitcoin-core-dev
712018-08-29T03:01:48 *** Krellan has quit IRC
722018-08-29T03:02:23 *** achow101 has joined #bitcoin-core-dev
732018-08-29T03:04:01 *** infernix has joined #bitcoin-core-dev
742018-08-29T03:05:28 *** dc1 has joined #bitcoin-core-dev
752018-08-29T03:06:18 *** ChanServ sets mode: +o sipa
762018-08-29T03:06:30 *** z323 has joined #bitcoin-core-dev
772018-08-29T03:06:32 *** sipa sets mode: -r
782018-08-29T03:06:37 <sipa> let's see
792018-08-29T03:06:43 *** sipa sets mode: -o sipa
802018-08-29T03:12:47 *** vexbuy has quit IRC
812018-08-29T03:48:58 *** Chris_Stewart_5 has quit IRC
822018-08-29T04:00:44 *** gleb has joined #bitcoin-core-dev
832018-08-29T04:35:13 *** phwalkr has joined #bitcoin-core-dev
842018-08-29T04:37:20 *** Kaizen_ has joined #bitcoin-core-dev
852018-08-29T04:38:42 *** Kaizen_ has quit IRC
862018-08-29T04:39:08 *** Kaizen_ has joined #bitcoin-core-dev
872018-08-29T04:39:34 *** phwalkr has quit IRC
882018-08-29T04:43:04 *** Kaizen_ has quit IRC
892018-08-29T04:51:40 *** vexbuy has joined #bitcoin-core-dev
902018-08-29T04:56:15 *** jonasschnelli_ has joined #bitcoin-core-dev
912018-08-29T05:13:58 *** Rootsudo has joined #bitcoin-core-dev
922018-08-29T05:14:46 *** leishman has joined #bitcoin-core-dev
932018-08-29T05:16:13 *** vexbuy has quit IRC
942018-08-29T05:18:53 <leishman> I had a node running 0.16.2 with a txindex. I updated the binary to 0.17rc2 and when starting up bitcoind it seems to hang on "Upgrading txindex database... [0%]"
952018-08-29T05:19:50 <leishman> I'm not sure how long this is expected to take, but I've seen no progress displayed after 5-10 minutes
962018-08-29T05:21:18 <leishman> I'm assuming this has to do with the changes to the txindex in 0.17
972018-08-29T05:24:28 <leishman> ok got 10% progress after 10 minutes
982018-08-29T05:26:06 <leishman> perhaps we should warn users that an upgrade for a node with a txindex could end up taking a while
992018-08-29T05:27:38 *** leishman_ has joined #bitcoin-core-dev
1002018-08-29T05:27:38 *** leishman has quit IRC
1012018-08-29T05:28:51 <sipa> leishman_: do the release notes not say anything about that? if so, indeed
1022018-08-29T05:29:21 *** sipa has quit IRC
1032018-08-29T05:29:21 *** arubi has quit IRC
1042018-08-29T05:29:21 *** grubles has quit IRC
1052018-08-29T05:29:22 *** intcat has quit IRC
1062018-08-29T05:30:21 <leishman_> sipa: I don't see any mention of it here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes#transaction-index-changes
1072018-08-29T05:30:47 *** arubi has joined #bitcoin-core-dev
1082018-08-29T05:31:19 *** Rootsudo has quit IRC
1092018-08-29T05:32:44 <leishman_> I see in jimpos PR here (https://github.com/bitcoin/bitcoin/pull/13033) that it was tested. What kind of migration times did others see?
1102018-08-29T05:32:52 *** Giszmo has quit IRC
1112018-08-29T05:36:57 *** qrestlove has quit IRC
1122018-08-29T05:49:22 *** vexbuy has joined #bitcoin-core-dev
1132018-08-29T05:49:27 <warren> leishman_: what kind of hardware?
1142018-08-29T05:50:11 *** qrestlove has joined #bitcoin-core-dev
1152018-08-29T05:50:56 <leishman_> warren: Intel J1900 Quad Core. 4GB ram, HDD
1162018-08-29T05:52:30 <leishman_> i'm at 22% through the migration after about 30 minutes.
1172018-08-29T06:05:25 *** Rootsudo has joined #bitcoin-core-dev
1182018-08-29T06:05:27 *** Krellan has joined #bitcoin-core-dev
1192018-08-29T06:09:47 *** Krellan has quit IRC
1202018-08-29T06:11:10 *** bitcoin-git has joined #bitcoin-core-dev
1212018-08-29T06:11:10 <bitcoin-git> [bitcoin] osbc opened pull request #14098: Dev (master...dev) https://github.com/bitcoin/bitcoin/pull/14098
1222018-08-29T06:11:10 *** bitcoin-git has left #bitcoin-core-dev
1232018-08-29T06:12:40 *** bitcoin-git has joined #bitcoin-core-dev
1242018-08-29T06:12:40 <bitcoin-git> [bitcoin] osbc closed pull request #14098: Dev (master...dev) https://github.com/bitcoin/bitcoin/pull/14098
1252018-08-29T06:12:40 *** bitcoin-git has left #bitcoin-core-dev
1262018-08-29T06:19:02 *** leishman_ has quit IRC
1272018-08-29T06:19:48 *** leishman has joined #bitcoin-core-dev
1282018-08-29T06:24:34 *** leishman has quit IRC
1292018-08-29T06:24:50 *** leishman has joined #bitcoin-core-dev
1302018-08-29T06:40:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1312018-08-29T06:49:46 *** Krellan has joined #bitcoin-core-dev
1322018-08-29T06:53:11 *** leishman has quit IRC
1332018-08-29T06:53:49 *** leishman has joined #bitcoin-core-dev
1342018-08-29T06:54:06 *** sipa has joined #bitcoin-core-dev
1352018-08-29T06:56:30 *** vexbuy has quit IRC
1362018-08-29T06:57:08 *** vexbuy has joined #bitcoin-core-dev
1372018-08-29T06:58:18 *** leishman has quit IRC
1382018-08-29T06:59:31 *** rhavar_ has quit IRC
1392018-08-29T07:01:33 *** vexbuy has quit IRC
1402018-08-29T07:05:25 *** setpill has joined #bitcoin-core-dev
1412018-08-29T07:11:22 *** vexbuy has joined #bitcoin-core-dev
1422018-08-29T07:12:08 *** Orion3k has quit IRC
1432018-08-29T07:16:11 *** Rootsudo has quit IRC
1442018-08-29T07:17:41 *** Rootsudo has joined #bitcoin-core-dev
1452018-08-29T07:19:11 *** SopaXorzTaker has joined #bitcoin-core-dev
1462018-08-29T07:27:41 *** profmac has quit IRC
1472018-08-29T07:37:04 *** Chris_Stewart_5 has quit IRC
1482018-08-29T07:38:44 *** StopAndDecrypt has quit IRC
1492018-08-29T07:40:26 *** StopAndDecrypt has joined #bitcoin-core-dev
1502018-08-29T07:40:36 *** StopAndDecrypt has quit IRC
1512018-08-29T07:40:37 *** StopAndDecrypt has joined #bitcoin-core-dev
1522018-08-29T07:41:00 <wumpus> yessss @ bitcoin-git
1532018-08-29T07:44:28 *** setpill has quit IRC
1542018-08-29T07:44:40 *** setpill has joined #bitcoin-core-dev
1552018-08-29T07:45:03 *** setpill has left #bitcoin-core-dev
1562018-08-29T07:47:15 *** profmac has joined #bitcoin-core-dev
1572018-08-29T07:51:35 *** bitcoin-git has joined #bitcoin-core-dev
1582018-08-29T07:51:35 <bitcoin-git> [bitcoin] osbc opened pull request #14099: Dev (master...dev) https://github.com/bitcoin/bitcoin/pull/14099
1592018-08-29T07:51:35 *** bitcoin-git has left #bitcoin-core-dev
1602018-08-29T07:51:36 *** aj__ has joined #bitcoin-core-dev
1612018-08-29T07:51:48 *** bitcoin-git has joined #bitcoin-core-dev
1622018-08-29T07:51:48 <bitcoin-git> [bitcoin] osbc closed pull request #14099: Dev (master...dev) https://github.com/bitcoin/bitcoin/pull/14099
1632018-08-29T07:51:48 *** bitcoin-git has left #bitcoin-core-dev
1642018-08-29T07:51:54 *** aj__ is now known as aj
1652018-08-29T08:04:45 *** Trackerming has joined #bitcoin-core-dev
1662018-08-29T08:05:40 *** Trackerming has quit IRC
1672018-08-29T08:31:43 *** promag has joined #bitcoin-core-dev
1682018-08-29T08:33:59 *** promag has quit IRC
1692018-08-29T08:36:05 *** promag_ has joined #bitcoin-core-dev
1702018-08-29T08:37:33 *** Victorsueca has quit IRC
1712018-08-29T08:38:43 *** Victorsueca has joined #bitcoin-core-dev
1722018-08-29T08:45:17 *** ConTa has joined #bitcoin-core-dev
1732018-08-29T08:50:34 *** setpill has joined #bitcoin-core-dev
1742018-08-29T08:51:56 *** intcat has joined #bitcoin-core-dev
1752018-08-29T08:53:46 *** promag_ has quit IRC
1762018-08-29T08:56:49 *** jonasschnelli_ has quit IRC
1772018-08-29T08:56:49 *** jonasschnelli_ has joined #bitcoin-core-dev
1782018-08-29T08:56:52 *** jonasschnelli_ is now known as jonasschnelli
1792018-08-29T09:01:09 *** Krellan has quit IRC
1802018-08-29T09:12:13 *** bitcoin-git has joined #bitcoin-core-dev
1812018-08-29T09:12:13 <bitcoin-git> [bitcoin] laanwj opened pull request #14100: doc: Change documentation for =0 for non-boolean options (master...2018_08_nodoc) https://github.com/bitcoin/bitcoin/pull/14100
1822018-08-29T09:12:13 *** bitcoin-git has left #bitcoin-core-dev
1832018-08-29T09:41:10 *** itaseski has joined #bitcoin-core-dev
1842018-08-29T09:41:42 *** murrayn has joined #bitcoin-core-dev
1852018-08-29T09:45:59 *** AaronvanW has joined #bitcoin-core-dev
1862018-08-29T09:53:56 <wumpus> phantomcircuit: please be really ,really careful about making things a catastrophic failure in network code
1872018-08-29T09:54:20 <wumpus> there's a huge chance of accidentally creating DoS vectors
1882018-08-29T09:59:45 <wumpus> (though, looking at the man page of select() I tend to agree; not sure it's the same on non-POSIX platforms though, select on windows is a different beast)
1892018-08-29T10:14:32 *** schmidty has joined #bitcoin-core-dev
1902018-08-29T10:14:42 *** schmidty has joined #bitcoin-core-dev
1912018-08-29T10:17:25 *** Guyver2 has joined #bitcoin-core-dev
1922018-08-29T10:21:12 *** Emcy has quit IRC
1932018-08-29T10:21:49 *** Emcy has joined #bitcoin-core-dev
1942018-08-29T11:04:44 *** itaseski has quit IRC
1952018-08-29T11:37:11 *** phwalkr has joined #bitcoin-core-dev
1962018-08-29T11:40:13 *** Kaizen_ has joined #bitcoin-core-dev
1972018-08-29T11:44:44 *** Kaizen_ has quit IRC
1982018-08-29T11:52:18 *** zura has joined #bitcoin-core-dev
1992018-08-29T11:57:59 *** Victorsueca has quit IRC
2002018-08-29T11:59:29 *** Victorsueca has joined #bitcoin-core-dev
2012018-08-29T11:59:51 *** elichai2 has joined #bitcoin-core-dev
2022018-08-29T12:05:04 *** zura_ has joined #bitcoin-core-dev
2032018-08-29T12:05:51 *** zura has quit IRC
2042018-08-29T12:06:17 <zura_> Start
2052018-08-29T12:06:31 <wumpus> !!!
2062018-08-29T12:06:31 <gribble> Error: "!!" is not a valid command.
2072018-08-29T12:06:31 <lightningbot> wumpus: Error: "!" is not a valid command.
2082018-08-29T12:07:03 <zura_> Mulai
2092018-08-29T12:07:19 <wumpus> STOP
2102018-08-29T12:10:41 *** ken2812221_ has joined #bitcoin-core-dev
2112018-08-29T12:13:24 *** gmaxwell has quit IRC
2122018-08-29T12:13:32 *** gmaxwell has joined #bitcoin-core-dev
2132018-08-29T12:13:55 *** gmaxwell is now known as Guest30235
2142018-08-29T12:13:57 *** ken2812221 has quit IRC
2152018-08-29T12:15:45 *** zura_ has quit IRC
2162018-08-29T12:16:08 *** Zura_ has joined #bitcoin-core-dev
2172018-08-29T12:16:44 *** bitcoin-git has joined #bitcoin-core-dev
2182018-08-29T12:16:45 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13887f41f229...2ddce35abcb8
2192018-08-29T12:16:45 <bitcoin-git> bitcoin/master 1661a47 Chun Kuan Lee: add unicode compatible file_lock for Windows...
2202018-08-29T12:16:46 <bitcoin-git> bitcoin/master 2ddce35 Wladimir J. van der Laan: Merge #13862: utils: drop boost::interprocess::file_lock...
2212018-08-29T12:16:46 *** bitcoin-git has left #bitcoin-core-dev
2222018-08-29T12:16:56 <Zura_> 113.210.102.130
2232018-08-29T12:17:39 *** bitcoin-git has joined #bitcoin-core-dev
2242018-08-29T12:17:40 <bitcoin-git> [bitcoin] laanwj closed pull request #13862: utils: drop boost::interprocess::file_lock (master...custom-filelock) https://github.com/bitcoin/bitcoin/pull/13862
2252018-08-29T12:17:40 *** bitcoin-git has left #bitcoin-core-dev
2262018-08-29T12:18:07 *** ChanServ sets mode: +o wumpus
2272018-08-29T12:18:40 *** wumpus sets mode: +b *!*@113.210.102.130
2282018-08-29T12:18:43 *** Zura_ was kicked by wumpus (Zura_)
2292018-08-29T12:49:36 *** profmac has quit IRC
2302018-08-29T12:50:15 *** ExtraCrispy has quit IRC
2312018-08-29T12:53:13 *** ExtraCrispy has joined #bitcoin-core-dev
2322018-08-29T13:00:23 *** bitcoin-git has joined #bitcoin-core-dev
2332018-08-29T13:00:24 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ddce35abcb8...5924dadc2f2d
2342018-08-29T13:00:24 <bitcoin-git> bitcoin/master e2ba043 251: Implements ParseNetwork unit test....
2352018-08-29T13:00:25 <bitcoin-git> bitcoin/master 7a208d9 251: Implements custom tolower and toupper functions....
2362018-08-29T13:00:25 <bitcoin-git> bitcoin/master b193d5a 251: Removes the Boost case_conv.hpp dependency....
2372018-08-29T13:00:26 *** bitcoin-git has left #bitcoin-core-dev
2382018-08-29T13:01:04 *** bitcoin-git has joined #bitcoin-core-dev
2392018-08-29T13:01:04 <bitcoin-git> [bitcoin] laanwj closed pull request #13671: Remove the boost/algorithm/string/case_conv.hpp dependency (master...patch/remove_boost_case_conv.hpp) https://github.com/bitcoin/bitcoin/pull/13671
2402018-08-29T13:01:04 *** bitcoin-git has left #bitcoin-core-dev
2412018-08-29T13:13:05 *** rhavar_ has joined #bitcoin-core-dev
2422018-08-29T13:14:09 *** bitcoin-git has joined #bitcoin-core-dev
2432018-08-29T13:14:10 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5924dadc2f2d...b0eb8f7ed43e
2442018-08-29T13:14:10 <bitcoin-git> bitcoin/master 1d9aa00 Ben Woosley: Explicitly initialize prevector _union
2452018-08-29T13:14:11 <bitcoin-git> bitcoin/master b0eb8f7 Wladimir J. van der Laan: Merge #14028: Explicitly initialize prevector _union...
2462018-08-29T13:14:12 *** bitcoin-git has left #bitcoin-core-dev
2472018-08-29T13:15:09 *** bitcoin-git has joined #bitcoin-core-dev
2482018-08-29T13:15:10 <bitcoin-git> [bitcoin] laanwj closed pull request #14028: Explicitly initialize prevector _union (master...prevector-explicit-initialization) https://github.com/bitcoin/bitcoin/pull/14028
2492018-08-29T13:15:10 *** bitcoin-git has left #bitcoin-core-dev
2502018-08-29T13:24:10 *** brianhoffman has joined #bitcoin-core-dev
2512018-08-29T13:25:09 <wumpus> can we please make a decision on what to to with tinyformat? either #13846 or #13845 or leave it as it is and close both
2522018-08-29T13:25:11 <gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHub
2532018-08-29T13:25:13 <gribble> https://github.com/bitcoin/bitcoin/issues/13845 | Include tinyformat as a subtree by Empact · Pull Request #13845 · bitcoin/bitcoin · GitHub
2542018-08-29T13:28:42 *** jhfrontz has quit IRC
2552018-08-29T13:30:49 *** Atourist has joined #bitcoin-core-dev
2562018-08-29T13:32:21 *** itaseski has joined #bitcoin-core-dev
2572018-08-29T13:33:01 *** Atourist has quit IRC
2582018-08-29T13:35:04 *** bitcoin-git has joined #bitcoin-core-dev
2592018-08-29T13:35:05 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b0eb8f7ed43e...1361f8babcc1
2602018-08-29T13:35:05 <bitcoin-git> bitcoin/master 6af6d9b João Barbosa: test: Add tests for RPC help
2612018-08-29T13:35:06 <bitcoin-git> bitcoin/master 1361f8b MarcoFalke: Merge #14020: Add tests for RPC help...
2622018-08-29T13:35:06 *** bitcoin-git has left #bitcoin-core-dev
2632018-08-29T13:35:59 *** bitcoin-git has joined #bitcoin-core-dev
2642018-08-29T13:35:59 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14020: Add tests for RPC help (master...2018-08-test-help) https://github.com/bitcoin/bitcoin/pull/14020
2652018-08-29T13:35:59 *** bitcoin-git has left #bitcoin-core-dev
2662018-08-29T13:36:54 *** jhfrontz has joined #bitcoin-core-dev
2672018-08-29T13:39:50 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2682018-08-29T13:50:18 *** murrayn has quit IRC
2692018-08-29T13:50:41 *** murrayn has joined #bitcoin-core-dev
2702018-08-29T13:50:42 *** murrayn has joined #bitcoin-core-dev
2712018-08-29T13:51:04 *** grubles has joined #bitcoin-core-dev
2722018-08-29T13:54:40 *** p3tr has joined #bitcoin-core-dev
2732018-08-29T14:06:45 *** JackH has joined #bitcoin-core-dev
2742018-08-29T14:09:02 *** profmac has joined #bitcoin-core-dev
2752018-08-29T14:10:31 *** promag has joined #bitcoin-core-dev
2762018-08-29T14:13:19 *** owowo has quit IRC
2772018-08-29T14:13:28 *** owowo has joined #bitcoin-core-dev
2782018-08-29T14:13:28 *** owowo has joined #bitcoin-core-dev
2792018-08-29T14:24:21 *** Taifta has joined #bitcoin-core-dev
2802018-08-29T14:26:56 *** Krellan has joined #bitcoin-core-dev
2812018-08-29T14:29:26 *** profmac has quit IRC
2822018-08-29T14:31:26 *** Taifta has quit IRC
2832018-08-29T14:31:37 *** bitcoin-git has joined #bitcoin-core-dev
2842018-08-29T14:31:37 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1361f8babcc1...888acefa5ee1
2852018-08-29T14:31:38 <bitcoin-git> bitcoin/master ddd395f MarcoFalke: Mark CTxMemPoolEntry members that should not be modified const
2862018-08-29T14:31:39 <bitcoin-git> bitcoin/master fe5c497 MarcoFalke: tx pool: Use the entry's hash instead of the one passed to addUnchecked
2872018-08-29T14:31:39 <bitcoin-git> bitcoin/master fa58777 MarcoFalke: scripted-diff: Remove unused first argument to addUnchecked...
2882018-08-29T14:31:39 *** bitcoin-git has left #bitcoin-core-dev
2892018-08-29T14:32:24 *** bitcoin-git has joined #bitcoin-core-dev
2902018-08-29T14:32:24 <bitcoin-git> [bitcoin] laanwj closed pull request #13792: tx pool: Avoid passing redundant hash into addUnchecked (scripted-diff) (master...Mf1808-constTxPoolEntries) https://github.com/bitcoin/bitcoin/pull/13792
2912018-08-29T14:32:24 *** bitcoin-git has left #bitcoin-core-dev
2922018-08-29T14:35:39 *** SopaXT has joined #bitcoin-core-dev
2932018-08-29T14:43:55 *** piraces has joined #bitcoin-core-dev
2942018-08-29T14:45:04 *** Guest30235 has quit IRC
2952018-08-29T14:45:04 *** Guest30235 has joined #bitcoin-core-dev
2962018-08-29T14:45:10 *** Guest30235 is now known as gmaxwell
2972018-08-29T14:51:21 *** Kaizen_ has joined #bitcoin-core-dev
2982018-08-29T14:54:06 *** Kaizen_ has quit IRC
2992018-08-29T14:59:45 *** michaelsdunn1 has joined #bitcoin-core-dev
3002018-08-29T14:59:45 *** michaelsdunn1 has quit IRC
3012018-08-29T14:59:45 *** michaelsdunn1 has joined #bitcoin-core-dev
3022018-08-29T15:04:14 *** profmac has joined #bitcoin-core-dev
3032018-08-29T15:15:21 *** bitcoin-git has joined #bitcoin-core-dev
3042018-08-29T15:15:22 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/888acefa5ee1...4e9a6f87b7d2
3052018-08-29T15:15:22 <bitcoin-git> bitcoin/master fa309dc MarcoFalke: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip
3062018-08-29T15:15:23 <bitcoin-git> bitcoin/master 4e9a6f8 Wladimir J. van der Laan: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip...
3072018-08-29T15:15:23 *** bitcoin-git has left #bitcoin-core-dev
3082018-08-29T15:16:36 *** bitcoin-git has joined #bitcoin-core-dev
3092018-08-29T15:16:36 <bitcoin-git> [bitcoin] laanwj closed pull request #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (master...Mf1808-validationLogError) https://github.com/bitcoin/bitcoin/pull/14097
3102018-08-29T15:16:36 *** bitcoin-git has left #bitcoin-core-dev
3112018-08-29T15:32:30 *** bitcoin-git has joined #bitcoin-core-dev
3122018-08-29T15:32:30 <bitcoin-git> [bitcoin] ryanofsky closed pull request #9381: Remove CWalletTx merging logic from AddToWallet (master...pr/atw-nomerge) https://github.com/bitcoin/bitcoin/pull/9381
3132018-08-29T15:32:30 *** bitcoin-git has left #bitcoin-core-dev
3142018-08-29T15:37:03 *** piraces has quit IRC
3152018-08-29T15:44:18 *** davex__ has quit IRC
3162018-08-29T15:44:26 *** Victorsueca has quit IRC
3172018-08-29T15:46:55 *** leishman has joined #bitcoin-core-dev
3182018-08-29T15:47:36 *** Rootsudo has joined #bitcoin-core-dev
3192018-08-29T15:55:36 <leishman> I added an update to the wiki with a note about the txindex db migration: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes#how-to-upgrade
3202018-08-29T15:56:52 <sipa> leishman: sgtm
3212018-08-29T15:57:12 <sipa> also, i notice the release notes don't mention scantxoutset yet
3222018-08-29T15:57:59 <sipa> (or i'm missing it)
3232018-08-29T16:02:53 *** leishman has quit IRC
3242018-08-29T16:03:30 *** leishman has joined #bitcoin-core-dev
3252018-08-29T16:06:26 *** bitconner has joined #bitcoin-core-dev
3262018-08-29T16:07:42 *** leishman has quit IRC
3272018-08-29T16:09:27 *** leishman has joined #bitcoin-core-dev
3282018-08-29T16:10:03 <leishman> yeah I don't see that either
3292018-08-29T16:12:04 *** promag has quit IRC
3302018-08-29T16:24:27 *** nullptr| has joined #bitcoin-core-dev
3312018-08-29T16:25:37 <marcinja> is getblockstats also new in 0.17?
3322018-08-29T16:26:16 <sipa> i think so!
3332018-08-29T16:32:09 <leishman> marcinja: is your feerate percentile stuff included in that as well?
3342018-08-29T16:34:17 <marcinja> leishman: yeah I think that change is considered a bug fix for getblockstats
3352018-08-29T16:34:29 <leishman> dope! Great work on that btw
3362018-08-29T16:35:24 *** rhavar_ has quit IRC
3372018-08-29T16:36:03 *** leishman has quit IRC
3382018-08-29T16:36:39 *** leishman has joined #bitcoin-core-dev
3392018-08-29T16:37:30 *** leishman has joined #bitcoin-core-dev
3402018-08-29T16:54:34 *** Kaizen_ has joined #bitcoin-core-dev
3412018-08-29T16:56:50 *** bitcoin-git has joined #bitcoin-core-dev
3422018-08-29T16:56:50 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14101: qa: Use named args in validation acceptance tests (master...Mf1808-qaNamedArgsAcceptance) https://github.com/bitcoin/bitcoin/pull/14101
3432018-08-29T16:56:50 *** bitcoin-git has left #bitcoin-core-dev
3442018-08-29T16:59:04 *** Kaizen_ has quit IRC
3452018-08-29T16:59:27 *** vexbuy has quit IRC
3462018-08-29T17:01:17 *** alexneudatchin has joined #bitcoin-core-dev
3472018-08-29T17:02:54 *** alexneudatchin has quit IRC
3482018-08-29T17:02:57 *** itaseski has quit IRC
3492018-08-29T17:06:04 *** bitconner has quit IRC
3502018-08-29T17:11:36 *** arubi has quit IRC
3512018-08-29T17:12:02 *** arubi has joined #bitcoin-core-dev
3522018-08-29T17:16:58 *** vexbuy has joined #bitcoin-core-dev
3532018-08-29T17:25:05 *** itaseski has joined #bitcoin-core-dev
3542018-08-29T17:52:31 *** leishman_ has joined #bitcoin-core-dev
3552018-08-29T17:55:04 *** leishman has quit IRC
3562018-08-29T17:57:27 *** vexbuy_ has joined #bitcoin-core-dev
3572018-08-29T18:00:26 *** vexbuy has quit IRC
3582018-08-29T18:09:05 *** rhavar has joined #bitcoin-core-dev
3592018-08-29T18:22:30 *** profmac has quit IRC
3602018-08-29T18:24:59 *** marcinja has quit IRC
3612018-08-29T18:26:15 *** marcinja has joined #bitcoin-core-dev
3622018-08-29T18:26:16 *** marcinja_ has joined #bitcoin-core-dev
3632018-08-29T18:26:24 *** marcinja_ has quit IRC
3642018-08-29T18:28:25 *** setpill has quit IRC
3652018-08-29T18:29:14 *** profmac has joined #bitcoin-core-dev
3662018-08-29T18:33:19 <jonasschnelli> luke-jr: I guess its good to know which peer supports what version of the p2p protocol _before_ you connect (in case of a non-compatible protocol).
3672018-08-29T18:33:30 *** osue has joined #bitcoin-core-dev
3682018-08-29T18:34:06 *** willyko has joined #bitcoin-core-dev
3692018-08-29T18:35:36 <jonasschnelli> luke-jr: but dropping NODE_ENCRYPTED is possible... you can just try to perform the v2 handshake and reconnect (&continue with v1 protocol) if failed.
3702018-08-29T18:36:24 <sipa> that still requires remembering whether or not encryption succeeded, though
3712018-08-29T18:39:25 *** leishman_ has quit IRC
3722018-08-29T18:40:01 *** leishman has joined #bitcoin-core-dev
3732018-08-29T18:41:05 <luke-jr> jonasschnelli: why can't the handshake occur over v1?
3742018-08-29T18:41:30 <jonasschnelli> luke-jr: we would have to drag the legacy v1 protocol always with us
3752018-08-29T18:41:43 <jonasschnelli> Assume new software doesn't want to adopt the v1 protocol
3762018-08-29T18:41:58 <luke-jr> yes, so? we need that anyway
3772018-08-29T18:42:03 <luke-jr> it could be some minimal subset
3782018-08-29T18:42:18 <jonasschnelli> Also, the v2 handshake doesn't reveal "bitcoin traffic" (not very DPI resistant though)
3792018-08-29T18:42:27 <luke-jr> hm
3802018-08-29T18:42:37 <luke-jr> also, you don't *know* service bits until you connect
3812018-08-29T18:42:42 <luke-jr> so this seems an issue either way
3822018-08-29T18:42:45 <jonasschnelli> luke-jr: IMO it doesn't make sense to handshake in v1 then upgrade to v2
3832018-08-29T18:42:56 <jonasschnelli> luke-jr: yes. Same with NODE_BLOOM, etc.
3842018-08-29T18:43:17 <jonasschnelli> But NODE_ENCRYPTED is something you lear if its working not from the VERSION message.:)
3852018-08-29T18:43:23 <jonasschnelli> *learn
3862018-08-29T18:43:36 <luke-jr> you get a guess at best
3872018-08-29T18:43:47 <jonasschnelli> Yes. Same witn NODE_NETWORK
3882018-08-29T18:43:49 <luke-jr> for bloom, that's still useful. not so much for encrpyted IMO
3892018-08-29T18:44:10 <sipa> luke-jr: you don't want to negotiate in v1 first
3902018-08-29T18:44:22 <sipa> that would defeat the purpose of not being recognizable as bitcoin traffic
3912018-08-29T18:44:27 *** leishman has quit IRC
3922018-08-29T18:44:43 <luke-jr> sipa: okay, but that problem is unrelated to the service bit
3932018-08-29T18:45:01 <jonasschnelli> What sipa said with the disclaimer, that censorship-resistant is not the goal of BIP151
3942018-08-29T18:46:12 <sipa> luke-jr: then what do you suggest instead? always first try v2 negotiation, and disconnect/reconnect if it fails?
3952018-08-29T18:46:27 <sipa> luke-jr: that seems a gratuitous waste of time
3962018-08-29T18:47:56 <luke-jr> I'm not sure.
3972018-08-29T18:48:14 <luke-jr> probably not a waste of time long-term, though, considering that 99% of nodes run Core now :/
3982018-08-29T18:48:45 <sipa> i think this is a pretty good match for a service bit
3992018-08-29T18:49:12 <sipa> it's a property of the node itself, can be rumoured over the network, and is not a disaster if it's wrong
4002018-08-29T18:50:07 <sipa>
4012018-08-29T18:55:03 *** willyko has quit IRC
4022018-08-29T18:59:56 <jonasschnelli> sipa: for the ChaCha20Poly1305, do you think its sane to remove the second length-encryption key (chacha round) and instead use 4 bytes of the poly1305 key chacha round?
4032018-08-29T19:01:11 <sipa> jonasschnelli: i'd rather keep the two encryption streams separate, but just treat them as streams
4042018-08-29T19:01:19 <sipa> rather than reset the iv for every packet
4052018-08-29T19:02:25 <sipa> oh, i see
4062018-08-29T19:03:22 <sipa> you're saying instead use the auth's stream for the length encrpyption; hmm
4072018-08-29T19:03:29 <jonasschnelli> yes
4082018-08-29T19:03:51 <jonasschnelli> I'm not going to mess with the sequence number as IV
4092018-08-29T19:04:19 <jonasschnelli> there is currently an extra round for the 4bytes length: https://github.com/bitcoin/bitcoin/pull/14050/files#diff-58a94ae53d4f04a57e9dc33014a679eaR70
4102018-08-29T19:04:22 <luke-jr> sipa: but there's no reason for nodes to care in general
4112018-08-29T19:06:30 <sipa> luke-jr: i don't understand why not
4122018-08-29T19:06:47 <sipa> you need to know whhich protocol to use - otherwise you always have to try both
4132018-08-29T19:07:23 <echeveria> or bind a different port.
4142018-08-29T19:07:28 <sipa> plus i guess at some point nodes may start preferring encrypted connections
4152018-08-29T19:07:38 <echeveria> normal peers donât use non 8333 ports ever.
4162018-08-29T19:07:48 <sipa> echeveria: in which case you still need a service flags to indicate that the other port is open
4172018-08-29T19:07:55 <echeveria> yep
4182018-08-29T19:08:02 <luke-jr> actually, protocol version might make sense for this?
4192018-08-29T19:08:19 <sipa> luke-jr: protocop version isn't known before connecting
4202018-08-29T19:08:22 <luke-jr> if we plan to deprecate the current one
4212018-08-29T19:08:25 <echeveria> luke-jr: key
4222018-08-29T19:08:29 <echeveria> kek
4232018-08-29T19:08:37 <luke-jr> I thought it was with the version messages, no?
4242018-08-29T19:08:47 <sipa> luke-jr: it's not in addr messages
4252018-08-29T19:08:55 <luke-jr> oh
4262018-08-29T19:09:01 <sipa> and the version message is only after setting up the encrypted connection
4272018-08-29T19:09:26 <luke-jr> well, whatever. I guess we can always "de allocate" it later if the old protocol is abandoned
4282018-08-29T19:09:37 <luke-jr> and we're not exactly short on service bits
4292018-08-29T19:09:42 <sipa> exactly
4302018-08-29T19:11:24 <gmaxwell> sipa: using the auth's stream for the length is apparently something the openssh things author considered but didn't so they could use unmodified library functions for the TLS thing. This seems to be a pretty weak argument for slowing down short messages by 33%.
4312018-08-29T19:13:20 <luke-jr> I guess I just see service bits more for the make-it-or-break-it type stuff, where you will drop the peer entirely if they don't have it
4322018-08-29T19:13:37 <gmaxwell> "For more information on output descriptors, see the documentation at TODO
4332018-08-29T19:13:38 <gmaxwell> "
4342018-08-29T19:16:40 <sipa> luke-jr: well, it is; if you get it wrong, you need to disconnect (at which point you can choose to start over)
4352018-08-29T19:16:56 <sipa> gmaxwell: seems i forgot about that, and people didn't review the rpc help text changes...
4362018-08-29T19:18:13 <gmaxwell> the help text there is actually sufficient to use the function.
4372018-08-29T19:19:27 <sipa> it doesn't explain all the features, though
4382018-08-29T19:20:29 *** Krellan has quit IRC
4392018-08-29T19:21:53 <gmaxwell> thats true, but my point was that we can probably just remove that line for now.
4402018-08-29T19:22:08 <jonasschnelli> gmaxwell: do you have a link to the openssh protocol discussion of that auth-stream thing?
4412018-08-29T19:22:31 <gmaxwell> I linked sipa to it the other day, uh.. have to go searching since my irc client has been restarted.
4422018-08-29T19:23:09 <sipa> gmaxwell: I have a PR that adds documentation and changes tge link
4432018-08-29T19:23:22 <sipa> i thought that's why you rought it up
4442018-08-29T19:23:30 <sipa> (sorry, phone in car typing)
4452018-08-29T19:23:54 <jonasschnelli> sipa: I'm not your mother, but that sounds dangerous. :)
4462018-08-29T19:24:12 <sipa> jonasschnelli: i'm ot driving :D
4472018-08-29T19:24:20 <sipa> *not
4482018-08-29T19:24:28 <gmaxwell> sipa: oh no, I brought it up because I was using the rpc. :P
4492018-08-29T19:24:28 <jonasschnelli> huh*.. glad you don't
4502018-08-29T19:25:39 <sipa> #14096
4512018-08-29T19:25:41 <gribble> https://github.com/bitcoin/bitcoin/issues/14096 | Add reference documentation for descriptors language by sipa · Pull Request #14096 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4522018-08-29T19:30:36 *** TD-Linux has joined #bitcoin-core-dev
4532018-08-29T19:35:20 *** profmac has quit IRC
4542018-08-29T19:41:08 *** SopaXorzTaker has quit IRC
4552018-08-29T19:44:05 *** bitconner has joined #bitcoin-core-dev
4562018-08-29T19:45:06 *** Rootsudo has quit IRC
4572018-08-29T19:50:02 *** leishman has joined #bitcoin-core-dev
4582018-08-29T19:54:49 *** profmac has joined #bitcoin-core-dev
4592018-08-29T19:54:49 *** Kaizen_ has joined #bitcoin-core-dev
4602018-08-29T19:57:32 *** valwal has joined #bitcoin-core-dev
4612018-08-29T19:59:10 *** Kaizen_ has quit IRC
4622018-08-29T19:59:54 *** ossifrage has quit IRC
4632018-08-29T20:00:36 *** ossifrage has joined #bitcoin-core-dev
4642018-08-29T20:01:21 *** ossifrage has joined #bitcoin-core-dev
4652018-08-29T20:02:58 *** ossifrage has joined #bitcoin-core-dev
4662018-08-29T20:07:22 *** ossifrage has joined #bitcoin-core-dev
4672018-08-29T20:07:53 *** zivl has quit IRC
4682018-08-29T20:07:56 *** Rootsudo has joined #bitcoin-core-dev
4692018-08-29T20:08:30 *** leishman has quit IRC
4702018-08-29T20:09:07 *** leishman has joined #bitcoin-core-dev
4712018-08-29T20:11:05 *** bitcoin-git has joined #bitcoin-core-dev
4722018-08-29T20:11:05 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14083: bench: Fix thread sanitizer issue in AssembleBlock benchmark (master...Mf1808-benchAssembleBlockThread) https://github.com/bitcoin/bitcoin/pull/14083
4732018-08-29T20:11:05 *** bitcoin-git has left #bitcoin-core-dev
4742018-08-29T20:13:33 *** leishman has quit IRC
4752018-08-29T20:13:52 *** zivl has joined #bitcoin-core-dev
4762018-08-29T20:14:39 *** leishman has joined #bitcoin-core-dev
4772018-08-29T20:43:15 *** Empact has left #bitcoin-core-dev
4782018-08-29T20:55:31 *** promag has joined #bitcoin-core-dev
4792018-08-29T21:22:11 *** odk has joined #bitcoin-core-dev
4802018-08-29T21:23:17 *** opdenkamp has quit IRC
4812018-08-29T21:39:22 *** Krellan has joined #bitcoin-core-dev
4822018-08-29T21:43:14 *** reza has joined #bitcoin-core-dev
4832018-08-29T21:49:39 <reza> https://www.irccloud.com/pastebin/yHN50SYq/
4842018-08-29T21:49:54 <reza> Hey everyone.
4852018-08-29T21:49:54 <reza> I had an idea for a Bitcoin wallet, iâd like to hear your thoughts about it.
4862018-08-29T21:49:54 <reza> To summarise, this wallet is a P2P-Multi-Sig wallet. Meaning that, Alice and Bob connect to each other and a multi-sig wallet is created between them. Whenever Alice or Bob wants to move the funds from that multi-sig they send each other an invoice which then they can approve or disapprove.
4872018-08-29T21:49:54 <reza> Thoughts?
4882018-08-29T21:53:43 <promag> reza: this channel is bitcoin-core specific
4892018-08-29T21:54:19 <promag> I mean, specific to development of bitcoin-core
4902018-08-29T21:54:40 <reza> ok cool, thanks anyway
4912018-08-29T21:56:01 *** d9b4bef9 has quit IRC
4922018-08-29T21:57:08 *** Chris_Stewart_5 has quit IRC
4932018-08-29T22:09:15 *** Guyver2 has quit IRC
4942018-08-29T22:29:33 *** michaelsdunn1 has quit IRC
4952018-08-29T22:33:05 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4962018-08-29T22:36:16 *** booyah has quit IRC
4972018-08-29T22:36:34 *** booyah has joined #bitcoin-core-dev
4982018-08-29T22:43:35 *** booyah has quit IRC
4992018-08-29T22:43:44 *** booyah has joined #bitcoin-core-dev
5002018-08-29T22:44:07 *** booyah has quit IRC
5012018-08-29T22:44:36 *** booyah has joined #bitcoin-core-dev
5022018-08-29T22:47:03 *** grubles has quit IRC
5032018-08-29T22:47:31 *** grubles has joined #bitcoin-core-dev
5042018-08-29T22:47:46 *** grubles has quit IRC
5052018-08-29T22:49:44 *** jarthur has joined #bitcoin-core-dev
5062018-08-29T22:56:03 *** jarthur has quit IRC
5072018-08-29T23:00:00 *** jarthur has joined #bitcoin-core-dev
5082018-08-29T23:03:13 *** grubles has joined #bitcoin-core-dev
5092018-08-29T23:08:51 *** promag has quit IRC
5102018-08-29T23:11:54 *** Rootsudo has quit IRC
5112018-08-29T23:19:36 *** elichai2 has quit IRC
5122018-08-29T23:36:07 *** itaseski has quit IRC
5132018-08-29T23:55:20 *** Kaizen_ has joined #bitcoin-core-dev
5142018-08-29T23:59:40 *** Kaizen_ has quit IRC