12018-08-30T00:01:19 *** vexbuy_ has quit IRC
22018-08-30T00:02:28 *** harrymm_ has quit IRC
32018-08-30T00:02:30 *** promag has joined #bitcoin-core-dev
42018-08-30T00:02:31 *** leishman has quit IRC
52018-08-30T00:03:05 *** leishman has joined #bitcoin-core-dev
62018-08-30T00:05:11 *** harrymm has joined #bitcoin-core-dev
72018-08-30T00:07:18 *** leishman has quit IRC
82018-08-30T00:09:34 *** harrymm has quit IRC
92018-08-30T00:21:49 *** harrymm has joined #bitcoin-core-dev
102018-08-30T00:22:36 *** leishman has joined #bitcoin-core-dev
112018-08-30T00:24:17 *** peevsie has joined #bitcoin-core-dev
122018-08-30T00:26:58 *** leishman has quit IRC
132018-08-30T00:48:49 *** promag has quit IRC
142018-08-30T01:10:39 *** schmidty has quit IRC
152018-08-30T01:16:06 *** AaronvanW has quit IRC
162018-08-30T01:25:28 *** zivl has quit IRC
172018-08-30T01:30:30 *** schmidty has joined #bitcoin-core-dev
182018-08-30T01:30:54 *** schmidty is now known as Guest76245
192018-08-30T01:32:19 *** leishman has joined #bitcoin-core-dev
202018-08-30T01:36:44 *** leishman has quit IRC
212018-08-30T01:41:04 *** peevsie has quit IRC
222018-08-30T01:41:07 *** d9b4bef9 has joined #bitcoin-core-dev
232018-08-30T01:41:54 *** Guest76245 has quit IRC
242018-08-30T01:53:27 *** Chris_Stewart_5 has quit IRC
252018-08-30T01:56:01 *** d9b4bef9 has quit IRC
262018-08-30T01:57:08 *** d9b4bef9 has joined #bitcoin-core-dev
272018-08-30T02:05:52 *** leishman has joined #bitcoin-core-dev
282018-08-30T02:10:36 *** leishman has quit IRC
292018-08-30T02:20:41 *** BillSmith4lyfe has joined #bitcoin-core-dev
302018-08-30T02:26:57 *** BillSmith4lyfe has quit IRC
312018-08-30T02:27:17 *** BillSmith4lyfe has joined #bitcoin-core-dev
322018-08-30T02:33:36 *** BillSmith4lyfe has quit IRC
332018-08-30T02:34:28 *** BillSmith4lyfe has joined #bitcoin-core-dev
342018-08-30T02:40:26 *** BillSmith4lyfe has quit IRC
352018-08-30T02:41:15 *** BillSmith4lyfe has joined #bitcoin-core-dev
362018-08-30T02:47:33 *** BillSmith4lyfe has quit IRC
372018-08-30T02:47:52 *** BillSmith4lyfe has joined #bitcoin-core-dev
382018-08-30T02:48:29 *** leishman has joined #bitcoin-core-dev
392018-08-30T02:54:26 *** BillSmith4lyfe has quit IRC
402018-08-30T02:54:49 *** BillSmith4lyfe has joined #bitcoin-core-dev
412018-08-30T03:01:15 *** leishman has quit IRC
422018-08-30T03:01:50 *** leishman has joined #bitcoin-core-dev
432018-08-30T03:04:49 *** phwalkr has joined #bitcoin-core-dev
442018-08-30T03:11:04 *** shesek has quit IRC
452018-08-30T03:11:04 *** phwalkr has quit IRC
462018-08-30T03:16:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
472018-08-30T03:21:30 *** leishman has quit IRC
482018-08-30T03:21:44 *** leishman has joined #bitcoin-core-dev
492018-08-30T03:23:00 *** leishman has quit IRC
502018-08-30T03:23:36 *** leishman has joined #bitcoin-core-dev
512018-08-30T03:23:49 *** leishman has joined #bitcoin-core-dev
522018-08-30T03:30:34 *** Chris_Stewart_5 has quit IRC
532018-08-30T03:31:07 *** valwal has quit IRC
542018-08-30T03:32:20 *** leishman has quit IRC
552018-08-30T03:32:33 *** leishman has joined #bitcoin-core-dev
562018-08-30T03:46:14 *** peevsie has joined #bitcoin-core-dev
572018-08-30T04:07:37 *** Victorsueca has joined #bitcoin-core-dev
582018-08-30T04:08:15 *** Victorsueca has quit IRC
592018-08-30T04:08:32 *** Victorsueca has joined #bitcoin-core-dev
602018-08-30T04:10:04 *** Victorsueca has quit IRC
612018-08-30T04:10:31 *** Victorsueca has joined #bitcoin-core-dev
622018-08-30T04:12:33 *** jarthur has quit IRC
632018-08-30T04:26:22 *** plankers has joined #bitcoin-core-dev
642018-08-30T04:53:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
652018-08-30T05:02:06 *** plankers has quit IRC
662018-08-30T05:05:36 *** peevsie has quit IRC
672018-08-30T05:17:09 *** plankers has joined #bitcoin-core-dev
682018-08-30T05:21:35 *** plankers has quit IRC
692018-08-30T05:21:48 *** Chris_Stewart_5 has quit IRC
702018-08-30T05:27:51 *** D00M has joined #bitcoin-core-dev
712018-08-30T05:32:35 *** leishman has quit IRC
722018-08-30T05:32:48 *** leishman has joined #bitcoin-core-dev
732018-08-30T05:45:34 *** bitconner has quit IRC
742018-08-30T05:48:30 *** Krellan has quit IRC
752018-08-30T05:50:24 *** Krellan has joined #bitcoin-core-dev
762018-08-30T06:07:35 *** Randolf has joined #bitcoin-core-dev
772018-08-30T06:09:56 *** leishman has quit IRC
782018-08-30T06:12:13 *** bitcoin-git has joined #bitcoin-core-dev
792018-08-30T06:12:13 <bitcoin-git> [bitcoin] fingera opened pull request #14102: export der always compressed (master...3-export-der) https://github.com/bitcoin/bitcoin/pull/14102
802018-08-30T06:12:13 *** bitcoin-git has left #bitcoin-core-dev
812018-08-30T06:20:16 *** vexbuy has joined #bitcoin-core-dev
822018-08-30T06:20:36 <wumpus> huh
832018-08-30T06:21:16 <wumpus> why... create a PR like that without any motivation whatsoever
842018-08-30T06:23:16 <Randolf> Looks like a bit of debug output added, plus changing use from a constant to a variable. Using the constant seems to be a better choice to me because with the constant it's more clear what the compression mode is.
852018-08-30T06:24:40 <Randolf> Oh, hang on, it's not debug output. It's getting rid of a warning. This PR seems pointless indeed.
862018-08-30T06:29:01 *** ossifrage has quit IRC
872018-08-30T06:36:22 *** leishman has joined #bitcoin-core-dev
882018-08-30T06:40:30 *** leishman has quit IRC
892018-08-30T06:44:08 *** Rootsudo has joined #bitcoin-core-dev
902018-08-30T06:45:01 *** vexbuy_ has joined #bitcoin-core-dev
912018-08-30T06:48:27 *** vexbuy has quit IRC
922018-08-30T06:55:46 *** ossifrage has joined #bitcoin-core-dev
932018-08-30T06:57:42 <ossifrage> Bloody fios had an outage and I lost my IP again, so much for having a well connected node :-(
942018-08-30T06:59:07 *** vexbuy_ has quit IRC
952018-08-30T07:10:34 *** owowo has quit IRC
962018-08-30T07:18:03 *** vicnicius has joined #bitcoin-core-dev
972018-08-30T07:18:11 <gmaxwell> he's saying the der format private key always wrote the embedded pubkey in compressed form.
982018-08-30T07:18:13 <gmaxwell> I think.
992018-08-30T07:18:46 <gmaxwell> Though considering thats just used inside the wallet and the compressed form is smaller, I think that the current behavior is desirable.
1002018-08-30T07:19:04 <gmaxwell> but perhaps he knows some reason why it isn't.
1012018-08-30T07:21:50 *** vicnicius has quit IRC
1022018-08-30T07:31:42 *** kallewoof has quit IRC
1032018-08-30T07:35:21 <wumpus> let's hope they manage to explain
1042018-08-30T07:35:40 *** ChanServ sets mode: -o wumpus
1052018-08-30T07:37:08 * wumpus feels like killing account system today, let's get some reviews on #13825
1062018-08-30T07:37:10 <gribble> https://github.com/bitcoin/bitcoin/issues/13825 | [wallet] Kill accounts by jnewbery · Pull Request #13825 · bitcoin/bitcoin · GitHub
1072018-08-30T07:40:40 <wumpus> that PR is pretty much dead code removal (the actual functionality was already removed in an earlier PR) so it should be a more or less easy review
1082018-08-30T07:45:24 *** rhavar has quit IRC
1092018-08-30T07:47:44 *** kallewoof has joined #bitcoin-core-dev
1102018-08-30T07:58:47 <jonasschnelli> wumpus: kill it!
1112018-08-30T07:59:51 *** Krellan has quit IRC
1122018-08-30T08:00:34 *** Krellan has joined #bitcoin-core-dev
1132018-08-30T08:10:19 *** bitconner has joined #bitcoin-core-dev
1142018-08-30T08:10:19 *** bitcoin-git has joined #bitcoin-core-dev
1152018-08-30T08:10:19 <bitcoin-git> [bitcoin] practicalswift opened pull request #14103: Fix broken Doxygen comments (master...doxygen-cleanups) https://github.com/bitcoin/bitcoin/pull/14103
1162018-08-30T08:10:19 *** bitcoin-git has left #bitcoin-core-dev
1172018-08-30T08:10:19 *** D00M has quit IRC
1182018-08-30T08:10:19 *** nickler_ has joined #bitcoin-core-dev
1192018-08-30T08:10:19 <wumpus> jonasschnelli: ack it please :)
1202018-08-30T08:10:20 <jonasschnelli> wumpus: I did my utACK (hope that is enought)
1212018-08-30T08:10:20 *** murchandamus1 has joined #bitcoin-core-dev
1222018-08-30T08:10:20 <wumpus> jonasschnelli: oh! hadn't seen yet
1232018-08-30T08:10:20 <jonasschnelli> Greg did also
1242018-08-30T08:10:33 *** nickler has quit IRC
1252018-08-30T08:10:33 *** murchandamus has quit IRC
1262018-08-30T08:12:53 *** laurentmt has joined #bitcoin-core-dev
1272018-08-30T08:26:50 *** promag has joined #bitcoin-core-dev
1282018-08-30T08:37:36 *** bitconner has quit IRC
1292018-08-30T08:42:57 *** Victorsueca has quit IRC
1302018-08-30T08:43:47 *** kallewoof has quit IRC
1312018-08-30T08:44:17 *** Victorsueca has joined #bitcoin-core-dev
1322018-08-30T08:47:12 *** kallewoof has joined #bitcoin-core-dev
1332018-08-30T09:00:35 *** laurentmt has quit IRC
1342018-08-30T09:01:50 *** Rootsudo has quit IRC
1352018-08-30T09:03:02 *** AaronvanW has joined #bitcoin-core-dev
1362018-08-30T09:03:05 *** Rootsudo has joined #bitcoin-core-dev
1372018-08-30T09:04:12 *** _flow_ has quit IRC
1382018-08-30T09:06:01 *** bitconner has joined #bitcoin-core-dev
1392018-08-30T09:49:52 *** Rootsudo has quit IRC
1402018-08-30T09:56:51 *** JackH has quit IRC
1412018-08-30T09:59:02 <wumpus> appveyor is doing its thing again (failing on every PR)
1422018-08-30T10:01:04 *** bitcoin-git has joined #bitcoin-core-dev
1432018-08-30T10:01:05 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e9a6f87b7d2...be301a577776
1442018-08-30T10:01:06 <bitcoin-git> bitcoin/master 0e534d4 practicalswift: Fix incorrect Doxygen comments
1452018-08-30T10:01:06 <bitcoin-git> bitcoin/master be301a5 Wladimir J. van der Laan: Merge #14103: docs: Fix broken Doxygen comments...
1462018-08-30T10:01:07 *** bitcoin-git has left #bitcoin-core-dev
1472018-08-30T10:02:15 *** bitcoin-git has joined #bitcoin-core-dev
1482018-08-30T10:02:15 <bitcoin-git> [bitcoin] laanwj closed pull request #14103: docs: Fix broken Doxygen comments (master...doxygen-cleanups) https://github.com/bitcoin/bitcoin/pull/14103
1492018-08-30T10:02:15 *** bitcoin-git has left #bitcoin-core-dev
1502018-08-30T10:05:18 <wumpus> okay, we should definitely discuss -noX versus -X=0 in the meeting, this is driving me crazy
1512018-08-30T10:05:25 <wumpus> #14100
1522018-08-30T10:05:26 <gribble> https://github.com/bitcoin/bitcoin/issues/14100 | doc: Change documentation for =0 for non-boolean options by laanwj · Pull Request #14100 · bitcoin/bitcoin · GitHub
1532018-08-30T10:06:59 <wumpus> I still hold to my original belief at the beginning of that PR that -X=0 for *non-boolean* options is ambigious, and we should encourage -noX, but it seems the code base is moving in the other direction
1542018-08-30T10:07:23 <wumpus> does
1552018-08-30T10:07:39 <wumpus> "nodebuglogfile" work at all in bitcoin.conf?
1562018-08-30T10:10:09 <wumpus> (no, doesn't seem to work)
1572018-08-30T10:12:21 <wumpus> oh it does if you specify nodebuglogfile=1
1582018-08-30T10:12:45 *** promag has quit IRC
1592018-08-30T10:16:43 *** belcher_ has joined #bitcoin-core-dev
1602018-08-30T10:24:07 *** Emcy has quit IRC
1612018-08-30T10:27:13 *** Emcy has joined #bitcoin-core-dev
1622018-08-30T10:30:55 <ken2812221_> I am trying to switch from msvc to autotool on appveyor, hope that it won't fail with weird reason again.
1632018-08-30T10:33:08 <ken2812221_> But this would drop CI for MSVC.
1642018-08-30T10:33:42 <ken2812221_> I'm not sure if it is a good idea.
1652018-08-30T10:34:03 *** SopaXorzTaker has joined #bitcoin-core-dev
1662018-08-30T10:34:06 *** kallewoof has quit IRC
1672018-08-30T10:34:43 <wumpus> it's just, from a maintenance perspective, that two CI testing systems that can fail for seemingly random reasons is even more frustrating then one
1682018-08-30T10:35:40 *** kallewoof has joined #bitcoin-core-dev
1692018-08-30T10:36:14 <wumpus> theoretically I agree testing with MSVC good, but in practice, I end up ignoring it because most of the time the failures make no sense
1702018-08-30T10:37:03 <wumpus> and it is another huge log file to scroll through :-(
1712018-08-30T10:37:26 <wumpus> ...slowly and sometimes crashing the browser
1722018-08-30T10:37:46 <wumpus> wish that CI tools were smart enough to simply report what the problem was
1732018-08-30T10:39:05 <ken2812221_> I believe we just have to clear the build cache. It will work again as well.
1742018-08-30T10:40:54 <ken2812221_> I clear the cache on my appveyor project, the build result turns out green.
1752018-08-30T10:42:28 <ken2812221_> Actually, we could add build matrix to both test mingw and msvc binaries. But it would be really slow.
1762018-08-30T10:42:41 <wumpus> we already test mingw in travis
1772018-08-30T10:42:57 <wumpus> I don't think it's necessary to do this in appveyor too
1782018-08-30T10:43:03 <ken2812221_> But no functional test.
1792018-08-30T10:43:16 <wumpus> that's simply because they don't pass at the moment
1802018-08-30T10:43:26 <wumpus> they were enabled at some point in the past
1812018-08-30T10:43:40 <wumpus> but they're flaky
1822018-08-30T10:44:44 <ken2812221_> I'm trying to solve this problem on #14007
1832018-08-30T10:44:46 <gribble> https://github.com/bitcoin/bitcoin/issues/14007 | tests: Run functional test on Windows by ken2812221 · Pull Request #14007 · bitcoin/bitcoin · GitHub
1842018-08-30T10:45:38 <wumpus> okay on travis they ran in wine, instead of windows
1852018-08-30T10:48:25 <ken2812221_> Yes, we should test it on real Windows.
1862018-08-30T10:48:56 <wumpus> but yes mingw on windows is really, really slow
1872018-08-30T10:49:11 <wumpus> (in compile time)
1882018-08-30T10:49:45 <wumpus> anyhow if clearing the cache works, let's do that
1892018-08-30T10:51:41 <ken2812221_> https://github.com/krlmlr/r-appveyor/issues/98#issuecomment-395123720 I believe that this is the easiest way to clear cache, appveyor does not have "clear cache" button.
1902018-08-30T10:52:06 <wumpus> ooh apparently I can log in as drahtbot into appveyor
1912018-08-30T10:52:27 <wumpus> maybe it means I can do things like clear the cache now
1922018-08-30T10:53:12 <wumpus> ok thank you
1932018-08-30T10:54:01 <wumpus> hehe the mozilla javascript console blocks pasting by default, with a warning about scams, makes sense
1942018-08-30T10:54:24 *** Victorsueca has quit IRC
1952018-08-30T10:54:54 <wumpus> so in my case this would be https://ci.appveyor.com/api/projects/DrahtBot/bitcoin/buildcache , hope it worked
1962018-08-30T10:55:32 *** Victorsueca has joined #bitcoin-core-dev
1972018-08-30T10:58:48 *** elichai2 has joined #bitcoin-core-dev
1982018-08-30T10:59:03 <ken2812221_> Seems it does not work, maybe it should be done by MarcoFalke
1992018-08-30T10:59:24 <wumpus> sigh--
2002018-08-30T11:03:21 *** zivl has joined #bitcoin-core-dev
2012018-08-30T11:06:27 *** promag has joined #bitcoin-core-dev
2022018-08-30T11:07:56 *** bitcoin-git has joined #bitcoin-core-dev
2032018-08-30T11:07:56 <bitcoin-git> [bitcoin] laanwj opened pull request #14105: util: Report parse errors in configuration file (master...2018_08_parse_error_reporting) https://github.com/bitcoin/bitcoin/pull/14105
2042018-08-30T11:07:56 *** bitcoin-git has left #bitcoin-core-dev
2052018-08-30T11:10:09 *** sipa has quit IRC
2062018-08-30T11:13:52 *** Randolf has quit IRC
2072018-08-30T11:15:30 *** sipa has joined #bitcoin-core-dev
2082018-08-30T11:23:29 *** promag has quit IRC
2092018-08-30T11:35:42 *** bitcoin-git has joined #bitcoin-core-dev
2102018-08-30T11:35:43 <bitcoin-git> [bitcoin] mkjekk opened pull request #14106: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14106
2112018-08-30T11:35:43 *** bitcoin-git has left #bitcoin-core-dev
2122018-08-30T11:37:26 *** bitcoin-git has joined #bitcoin-core-dev
2132018-08-30T11:37:26 <bitcoin-git> [bitcoin] laanwj closed pull request #14106: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14106
2142018-08-30T11:37:26 *** bitcoin-git has left #bitcoin-core-dev
2152018-08-30T11:41:23 *** roban has joined #bitcoin-core-dev
2162018-08-30T11:45:56 *** roban has left #bitcoin-core-dev
2172018-08-30T11:54:46 *** bitcoin-git has joined #bitcoin-core-dev
2182018-08-30T11:54:46 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/be301a577776...6c7cfc8da68a
2192018-08-30T11:54:47 <bitcoin-git> bitcoin/master db5e9d3 practicalswift: Add missing locks (cs_args)
2202018-08-30T11:54:47 <bitcoin-git> bitcoin/master d58dc9f practicalswift: Add lock annotations (cs_args)
2212018-08-30T11:54:48 <bitcoin-git> bitcoin/master 1e29379 practicalswift: Fix potential deadlock
2222018-08-30T11:54:48 *** bitcoin-git has left #bitcoin-core-dev
2232018-08-30T11:55:17 *** bitcoin-git has joined #bitcoin-core-dev
2242018-08-30T11:55:17 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13126: util: Add Clang thread safety annotations for variables guarded by cs_args (master...guarded-by-cs_args) https://github.com/bitcoin/bitcoin/pull/13126
2252018-08-30T11:55:17 *** bitcoin-git has left #bitcoin-core-dev
2262018-08-30T11:55:47 *** IGHOR has quit IRC
2272018-08-30T11:55:53 *** Rootsudo has joined #bitcoin-core-dev
2282018-08-30T11:58:55 *** IGHOR has joined #bitcoin-core-dev
2292018-08-30T11:58:56 *** _flow_ has joined #bitcoin-core-dev
2302018-08-30T12:05:52 *** kallewoof has quit IRC
2312018-08-30T12:18:09 *** kallewoof has joined #bitcoin-core-dev
2322018-08-30T12:24:32 *** promag has joined #bitcoin-core-dev
2332018-08-30T12:34:48 *** booyah has quit IRC
2342018-08-30T12:35:06 *** Rootsudo has quit IRC
2352018-08-30T12:36:36 *** Rootsudo has joined #bitcoin-core-dev
2362018-08-30T12:36:40 *** phwalkr has joined #bitcoin-core-dev
2372018-08-30T12:37:22 *** Rootsudo has joined #bitcoin-core-dev
2382018-08-30T12:38:10 *** Rootsudo has joined #bitcoin-core-dev
2392018-08-30T12:39:42 *** Rootsudo has joined #bitcoin-core-dev
2402018-08-30T12:41:05 *** thib has quit IRC
2412018-08-30T12:43:44 *** Victorsueca has quit IRC
2422018-08-30T12:45:01 *** Victorsueca has joined #bitcoin-core-dev
2432018-08-30T12:47:44 *** leishman has joined #bitcoin-core-dev
2442018-08-30T12:52:16 *** leishman has quit IRC
2452018-08-30T12:53:39 *** promag has quit IRC
2462018-08-30T13:01:48 <ken2812221_> OK, appveyor cache cleared.
2472018-08-30T13:04:51 *** bitcoin-git has joined #bitcoin-core-dev
2482018-08-30T13:04:51 <bitcoin-git> [bitcoin] ken2812221 closed pull request #13515: travis: avoid timeout without saving caches, also enable all qt (master...travis_qt) https://github.com/bitcoin/bitcoin/pull/13515
2492018-08-30T13:04:51 *** bitcoin-git has left #bitcoin-core-dev
2502018-08-30T13:07:46 *** promag has joined #bitcoin-core-dev
2512018-08-30T13:08:51 *** brianhoffman has left #bitcoin-core-dev
2522018-08-30T13:10:21 *** Guyver2 has joined #bitcoin-core-dev
2532018-08-30T13:12:27 *** belcher_ has quit IRC
2542018-08-30T13:12:47 *** belcher_ has joined #bitcoin-core-dev
2552018-08-30T13:13:40 *** bitcoin-git has joined #bitcoin-core-dev
2562018-08-30T13:13:41 <bitcoin-git> [bitcoin] practicalswift opened pull request #14107: wallet: Remove unused function GetLabelDestination (master...deadc0de) https://github.com/bitcoin/bitcoin/pull/14107
2572018-08-30T13:13:41 *** bitcoin-git has left #bitcoin-core-dev
2582018-08-30T13:18:45 *** promag has quit IRC
2592018-08-30T13:23:58 *** odk has quit IRC
2602018-08-30T13:26:49 *** belcher_ has joined #bitcoin-core-dev
2612018-08-30T13:53:02 *** d9b4bef9 has quit IRC
2622018-08-30T13:54:08 *** d9b4bef9 has joined #bitcoin-core-dev
2632018-08-30T13:54:40 *** vexbuy has joined #bitcoin-core-dev
2642018-08-30T14:06:15 *** shesek has joined #bitcoin-core-dev
2652018-08-30T14:06:15 *** shesek has quit IRC
2662018-08-30T14:06:15 *** shesek has joined #bitcoin-core-dev
2672018-08-30T14:11:10 *** Krellan has quit IRC
2682018-08-30T14:11:58 *** Krellan has joined #bitcoin-core-dev
2692018-08-30T14:11:59 *** abrarisme has joined #bitcoin-core-dev
2702018-08-30T14:19:14 *** bitcoin-git has joined #bitcoin-core-dev
2712018-08-30T14:19:15 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c7cfc8da68a...07033a8f9197
2722018-08-30T14:19:15 <bitcoin-git> bitcoin/master c9c32e6 John Newbery: [wallet] Kill accounts...
2732018-08-30T14:19:16 <bitcoin-git> bitcoin/master 07033a8 Wladimir J. van der Laan: Merge #13825: [wallet] Kill accounts...
2742018-08-30T14:19:16 *** bitcoin-git has left #bitcoin-core-dev
2752018-08-30T14:19:34 *** bitcoin-git has joined #bitcoin-core-dev
2762018-08-30T14:19:34 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14107: wallet: Remove unused function GetLabelDestination (master...deadc0de) https://github.com/bitcoin/bitcoin/pull/14107
2772018-08-30T14:19:34 *** bitcoin-git has left #bitcoin-core-dev
2782018-08-30T14:20:49 *** peevsie has joined #bitcoin-core-dev
2792018-08-30T14:21:34 *** bitcoin-git has joined #bitcoin-core-dev
2802018-08-30T14:21:34 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13825: [wallet] Kill accounts (master...kill_accounts) https://github.com/bitcoin/bitcoin/pull/13825
2812018-08-30T14:21:34 *** bitcoin-git has left #bitcoin-core-dev
2822018-08-30T14:23:53 <instagibbs> MarcoFalke, sorry for noob but why you close #14107 ? Doesn't say there's a merge conflict?
2832018-08-30T14:23:55 <gribble> https://github.com/bitcoin/bitcoin/issues/14107 | wallet: Remove unused function GetLabelDestination by practicalswift · Pull Request #14107 · bitcoin/bitcoin · GitHub
2842018-08-30T14:26:12 <wumpus> I think it's included in https://github.com/bitcoin/bitcoin/commit/c9c32e6b844fc79467b7e24c6c916142a0d08484
2852018-08-30T14:28:29 <instagibbs> ah ok
2862018-08-30T14:29:51 <wumpus> if a commit does exactly the same as a previous commit and is anchored at a point before the change was done, I don't think you get a merge conflict
2872018-08-30T14:30:03 <wumpus> it's still useless to do of course :)
2882018-08-30T14:32:31 *** abrarisme has quit IRC
2892018-08-30T14:34:39 *** bitcoin-git has joined #bitcoin-core-dev
2902018-08-30T14:34:39 <bitcoin-git> [bitcoin] practicalswift opened pull request #14108: tests: Add missing locking annotations and locks (master...mapOrphanTransactions-is-guarded-by-g_cs_orphans) https://github.com/bitcoin/bitcoin/pull/14108
2912018-08-30T14:34:39 *** bitcoin-git has left #bitcoin-core-dev
2922018-08-30T14:41:32 *** hebasto has joined #bitcoin-core-dev
2932018-08-30T14:43:45 *** michaelsdunn1 has joined #bitcoin-core-dev
2942018-08-30T14:44:45 *** phwalkr has quit IRC
2952018-08-30T14:47:28 <hebasto> luke-jr: regarding PR#14037: I've received your review by email but can't see it on GitHub.
2962018-08-30T14:47:30 <gribble> https://github.com/bitcoin/bitcoin/issues/14037 | Add README.md to linux release tarballs by hebasto · Pull Request #14037 · bitcoin/bitcoin · GitHub
2972018-08-30T14:53:19 *** vexbuy has quit IRC
2982018-08-30T14:53:57 *** vexbuy has joined #bitcoin-core-dev
2992018-08-30T14:58:04 *** Krellan has quit IRC
3002018-08-30T14:58:27 *** vexbuy has quit IRC
3012018-08-30T14:59:12 *** Krellan has joined #bitcoin-core-dev
3022018-08-30T15:08:13 *** Emcy has quit IRC
3032018-08-30T15:08:58 *** Emcy has joined #bitcoin-core-dev
3042018-08-30T15:42:07 *** diz23 has joined #bitcoin-core-dev
3052018-08-30T15:42:10 <diz23> A fascinating blog where freenode staff member Matthew mst Trout recounts his experiences of eye-raping young children https://MattSTrout.com/
3062018-08-30T15:42:14 <diz23> I thought you guys might be interested in this blog by freenode staff member Bryan kloeri Ostergaard https://bryanostergaard.com/
3072018-08-30T15:42:17 <diz23> With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
3082018-08-30T15:42:20 <diz23> Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate
3092018-08-30T15:44:28 *** ChanServ sets mode: +o sipa
3102018-08-30T15:44:39 *** sipa sets mode: +r
3112018-08-30T15:44:44 *** sipa sets mode: -o sipa
3122018-08-30T15:45:32 *** diz23 has quit IRC
3132018-08-30T15:46:49 *** Victorsueca has quit IRC
3142018-08-30T15:48:02 *** Victorsueca has joined #bitcoin-core-dev
3152018-08-30T16:11:49 <sipa> i won't attend the meeting today
3162018-08-30T16:12:48 <sipa> but as a topic, perhaps someone should go through the list of merged PRs in 0.17 to see if any are missing release notes
3172018-08-30T16:17:30 <gmaxwell> I was going to come up with a commandline people could run which would curl the list of merged PRs and run it through shuf and head and ask everyone to look at the top bunch to see if the need release notes, but the list of merged PRs isn't up yet.
3182018-08-30T16:19:12 *** Randolf has joined #bitcoin-core-dev
3192018-08-30T16:36:06 <gmaxwell> here is an approximation: git log --since=2018-02-01 --merges | grep 'Merge #' | shuf | head
3202018-08-30T16:36:35 <gmaxwell> maybe we could ask everyone in the meeting to run that and check the results against the current release notes draft and see if they get anything they think needs notes. :)
3212018-08-30T16:39:03 *** Randolf has quit IRC
3222018-08-30T16:41:58 <echeveria> /query *otr
3232018-08-30T16:42:01 <echeveria> ffs.
3242018-08-30T16:43:23 *** promag has joined #bitcoin-core-dev
3252018-08-30T16:46:25 *** promag has quit IRC
3262018-08-30T16:54:03 *** Victorsueca has quit IRC
3272018-08-30T16:55:17 *** Victorsueca has joined #bitcoin-core-dev
3282018-08-30T17:14:43 *** AaronvanW has quit IRC
3292018-08-30T17:16:54 *** harrymm has quit IRC
3302018-08-30T17:18:33 *** Emcy has quit IRC
3312018-08-30T17:25:01 *** AaronvanW has joined #bitcoin-core-dev
3322018-08-30T17:27:16 <wumpus> there's still a few things in #12391 too that need release notes
3332018-08-30T17:27:17 <gribble> https://github.com/bitcoin/bitcoin/issues/12391 | TODO for release notes 0.17.0 · Issue #12391 · bitcoin/bitcoin · GitHub
3342018-08-30T17:29:16 *** harrymm has joined #bitcoin-core-dev
3352018-08-30T17:29:37 *** AaronvanW has quit IRC
3362018-08-30T17:35:46 *** sneakerhax has joined #bitcoin-core-dev
3372018-08-30T17:42:34 *** daouzo23 has joined #bitcoin-core-dev
3382018-08-30T17:47:35 <midnightmagic> I know I've asked this before, but can anyone tell me if the meta-data in the github instance is being archived somewhere (still)?
3392018-08-30T17:53:01 *** d9b4bef9 has quit IRC
3402018-08-30T17:54:07 *** d9b4bef9 has joined #bitcoin-core-dev
3412018-08-30T18:05:15 <phantomcircuit> while implementing logic for poll() i've run into an interesting issue
3422018-08-30T18:05:16 <phantomcircuit> https://github.com/pstratem/bitcoin/commit/03fba51baf35824fb9e55caf2384bbd7626c5dc5#diff-9a82240fe7dfe86564178691cc57f2f1R319
3432018-08-30T18:05:31 *** Emcy has joined #bitcoin-core-dev
3442018-08-30T18:05:53 <phantomcircuit> compile fails https://0bin.net/paste/M-ESIY-7HRgIM6qK#rCpHK4Oxjyy9aiuMIZ7Av28dp8QSD3CBORpKoyw4-wp
3452018-08-30T18:06:00 <phantomcircuit> with net.cpp:2188:39: error: no matching function for call to âCConnman::RegisterListenSocket(SOCKET&)â
3462018-08-30T18:06:21 <phantomcircuit> but RegisterListenSocket(hListenSocket); hListenSocket is actually a struct ListenSocket
3472018-08-30T18:06:32 *** Krellan has quit IRC
3482018-08-30T18:06:54 <wumpus> midnightmagic: yes, it is, at git@github.com:zw/bitcoin-gh-meta.git
3492018-08-30T18:08:10 <echeveria> midnightmagic: wumpus: the whole of github is archived in real time.
3502018-08-30T18:08:28 <echeveria> https://www.gharchive.org/
3512018-08-30T18:09:58 <wumpus> echeveria: nice, that could be useful too I guess
3522018-08-30T18:10:37 <wumpus> the more mirrors the better
3532018-08-30T18:14:25 <midnightmagic> wumpus: thank you
3542018-08-30T18:14:29 <midnightmagic> echeveria: thank you
3552018-08-30T18:17:14 <midnightmagic> heh heh heh!
3562018-08-30T18:27:06 *** leishman has joined #bitcoin-core-dev
3572018-08-30T18:27:51 <wumpus> and yes, I'll add the PR list and author list into the preliminary release notes soon
3582018-08-30T18:32:10 *** promag has joined #bitcoin-core-dev
3592018-08-30T18:36:39 *** promag has quit IRC
3602018-08-30T18:43:59 *** promag has joined #bitcoin-core-dev
3612018-08-30T18:44:49 *** leishman has quit IRC
3622018-08-30T18:45:18 *** phwalkr has joined #bitcoin-core-dev
3632018-08-30T18:50:31 *** daouzo23 has quit IRC
3642018-08-30T18:57:07 *** grubles_ has joined #bitcoin-core-dev
3652018-08-30T18:57:16 *** grubles has quit IRC
3662018-08-30T19:01:16 <promag> meeting?
3672018-08-30T19:01:18 <wumpus> #startmeeting
3682018-08-30T19:01:18 <lightningbot> Meeting started Thu Aug 30 19:01:18 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3692018-08-30T19:01:18 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3702018-08-30T19:01:27 <jonasschnelli> \o
3712018-08-30T19:01:32 <jonasschnelli> \o
3722018-08-30T19:01:34 <promag> howdy
3732018-08-30T19:01:36 <jonasschnelli> o/
3742018-08-30T19:01:55 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
3752018-08-30T19:02:00 <kanzure> hi.
3762018-08-30T19:02:04 <achow101> hi
3772018-08-30T19:02:06 <meshcollider> hi
3782018-08-30T19:03:02 <wumpus> so re: 0.17.0 it seems we still have a few issues
3792018-08-30T19:03:12 <wumpus> https://github.com/bitcoin/bitcoin/milestone/33
3802018-08-30T19:03:17 <gmaxwell> Hi.
3812018-08-30T19:03:28 <kanzure> topic: i am collecting topics for coredevtech tokyo; please submit topic suggestions to me, things that you would like to speak about, or things that you would prefer others to speak about, could be anything from source code things to BIPs to mailing list stuff, or complaints about twitter.
3822018-08-30T19:03:29 <wumpus> looks like the most serious one is a possible incompatibility when going back to 0.16.2
3832018-08-30T19:03:45 <wumpus> #14048
3842018-08-30T19:03:46 <gribble> https://github.com/bitcoin/bitcoin/issues/14048 | 0.16.2 binary gives error after latest compiled client has run · Issue #14048 · bitcoin/bitcoin · GitHub
3852018-08-30T19:04:09 <instagibbs> hi
3862018-08-30T19:04:24 <achow101> wasn't there a change to how txindex is handled now?
3872018-08-30T19:04:28 <gmaxwell> I no longer think #14109 is blocking, it appears to be a measurement artifact. pages in the cache in read only mmaps show up in res.
3882018-08-30T19:04:29 <gribble> https://github.com/bitcoin/bitcoin/issues/14109 | ibd memory usage up in 0.17 · Issue #14109 · bitcoin/bitcoin · GitHub
3892018-08-30T19:04:29 <wumpus> there's also possible working memory use increase during IBD ( #14109)
3902018-08-30T19:04:30 <gribble> https://github.com/bitcoin/bitcoin/issues/14109 | ibd memory usage up in 0.17 · Issue #14109 · bitcoin/bitcoin · GitHub
3912018-08-30T19:04:32 <achow101> so that's probably what is causing the problem
3922018-08-30T19:04:36 <wumpus> gmaxwell: good to know!
3932018-08-30T19:04:37 <jonasschnelli> Also #14104 is eventually something we want to take a look (or at least mention in the RN)
3942018-08-30T19:04:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14104 | 0.17.2rc issue (standardness change for bare multisig) · Issue #14104 · bitcoin/bitcoin · GitHub
3952018-08-30T19:05:43 <wumpus> ok tagging that with 0.17.0
3962018-08-30T19:05:51 <jonasschnelli> sipas script template remove (#13194) caused a tiny isStandard different for bare multisig
3972018-08-30T19:05:53 <gribble> https://github.com/bitcoin/bitcoin/issues/13194 | Remove template matching and pseudo opcodes by sipa · Pull Request #13194 · bitcoin/bitcoin · GitHub
3982018-08-30T19:05:58 <wumpus> hadn't seen that one but it looks like it is expected?
3992018-08-30T19:06:14 <wumpus> ah
4002018-08-30T19:06:16 <jonasschnelli> Invalid pubkeys with the right size was standard until 0.17
4012018-08-30T19:06:41 <jonasschnelli> Now, it checks the first byte (compress, uncompressed, etc.). Before it just had to be 33 or 65 bytes.
4022018-08-30T19:06:49 <gmaxwell> jonasschnelli: what does invalid here mean? the initial byte isn't ne of the right flags?
4032018-08-30T19:06:50 <gmaxwell> okay.
4042018-08-30T19:07:08 <wumpus> I'd say the new way is better then?
4052018-08-30T19:07:10 <gmaxwell> (just making sure we weren't doing the on-the-curve check, since thats slow)
4062018-08-30T19:07:17 <jonasschnelli> It looks like people have stuffed 33 bytes into a bare multisig for some unknown reason
4072018-08-30T19:07:42 <jonasschnelli> (probably to make some data public available ala OP_RETURN)
4082018-08-30T19:07:47 <wumpus> well you can't avoid people stuffing other things in them, but making sure they look like valid keys makes some sense
4092018-08-30T19:08:10 <gmaxwell> The new way is a reasonable behavior. it will inhibit some kind of non-op-return store-data-in-the-utxo set behavior.
4102018-08-30T19:08:10 <jonasschnelli> heh. Yes. I think we should just mention that in the release notes
4112018-08-30T19:08:35 <wumpus> right
4122018-08-30T19:08:38 <gmaxwell> yes, should be release noted.
4132018-08-30T19:09:40 <wumpus> posted it in #12391
4142018-08-30T19:09:41 <gribble> https://github.com/bitcoin/bitcoin/issues/12391 | TODO for release notes 0.17.0 · Issue #12391 · bitcoin/bitcoin · GitHub
4152018-08-30T19:10:15 <jonasschnelli> For #14048, I think its acceptable to require to create the txindex again when downgrade from 17 to 16...
4162018-08-30T19:10:16 <gribble> https://github.com/bitcoin/bitcoin/issues/14048 | 0.16.2 binary gives error after latest compiled client has run · Issue #14048 · bitcoin/bitcoin · GitHub
4172018-08-30T19:10:33 <gmaxwell> jonasschnelli: I agree, but it needs to be release noted.
4182018-08-30T19:10:33 <wumpus> oh this is because of the txindex update? of course, gah
4192018-08-30T19:10:45 <wumpus> what is the PR that changed the txindex?
4202018-08-30T19:10:58 *** captjakk has joined #bitcoin-core-dev
4212018-08-30T19:11:05 <jonasschnelli> #13033
4222018-08-30T19:11:07 <gribble> https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub
4232018-08-30T19:11:08 <jonasschnelli> (i think)
4242018-08-30T19:11:47 <promag> also related #13243
4252018-08-30T19:11:49 <gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub
4262018-08-30T19:12:24 *** willyko_ has joined #bitcoin-core-dev
4272018-08-30T19:12:46 <willyko_> yaas finally got my gitian build to work
4282018-08-30T19:13:16 <wumpus> ok added
4292018-08-30T19:14:09 <wumpus> for the rest there is some documentation confusion which I *try* to clear up in #14100
4302018-08-30T19:14:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14100 | doc: Change documentation for =0 for non-boolean options by laanwj · Pull Request #14100 · bitcoin/bitcoin · GitHub
4312018-08-30T19:14:16 *** plankers has joined #bitcoin-core-dev
4322018-08-30T19:14:44 <wumpus> at least if I do understand it correctly
4332018-08-30T19:15:51 <jonasschnelli> Added a new minor issue for 0.17 #14114
4342018-08-30T19:15:52 <gribble> https://github.com/bitcoin/bitcoin/issues/14114 | scantxoutset help about descriptors refers to TODO document · Issue #14114 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4352018-08-30T19:17:11 <wumpus> oops
4362018-08-30T19:17:42 <gmaxwell> pieter opened a PR to fill in the docs.
4372018-08-30T19:17:57 <gmaxwell> #14096
4382018-08-30T19:17:59 <gribble> https://github.com/bitcoin/bitcoin/issues/14096 | Add reference documentation for descriptors language by sipa · Pull Request #14096 · bitcoin/bitcoin · GitHub
4392018-08-30T19:18:17 <wumpus> yes, that is already tagged 0.17.0
4402018-08-30T19:18:38 <gmaxwell> so it fixes 14114
4412018-08-30T19:18:44 <wumpus> right
4422018-08-30T19:19:22 <jonasschnelli> Oh. Wasn't aware
4432018-08-30T19:20:08 <wumpus> one topic I'd like to discuss is where to move tinyformat in the source tree, if we're going to do that at all, I hate it when there's two competing PRs open for something
4442018-08-30T19:20:11 * jonasschnelli is lost in PRs
4452018-08-30T19:20:24 <wumpus> #topic tinyformat move
4462018-08-30T19:20:34 <wumpus> e.g.: #13846, #13845, or keep as is
4472018-08-30T19:20:36 <gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHub
4482018-08-30T19:20:38 <gribble> https://github.com/bitcoin/bitcoin/issues/13845 | Include tinyformat as a subtree by Empact · Pull Request #13845 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4492018-08-30T19:21:07 <wumpus> I'm ok with all three options but not with leaving those PRs open forever
4502018-08-30T19:21:10 *** GoldenBear has quit IRC
4512018-08-30T19:21:32 *** GoldenBear has joined #bitcoin-core-dev
4522018-08-30T19:22:01 <jonasschnelli> The subtree looked to me after an overkill,... I would prefer #13846 (no strong opinion)
4532018-08-30T19:22:03 <gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4542018-08-30T19:22:57 <wumpus> I guess MarcoFalke is not here?
4552018-08-30T19:23:07 <wumpus> I think he has the strongest opinion about it
4562018-08-30T19:23:27 <gmaxwell> would we really do a subtree for a single file?
4572018-08-30T19:23:32 <wumpus> no.
4582018-08-30T19:24:00 <wumpus> I think this is pretty much unnecessary, and certainly the subtree one contains lots of changes
4592018-08-30T19:24:25 <gmaxwell> seems like change for the sake of change to me.
4602018-08-30T19:24:54 <wumpus> too much of that
4612018-08-30T19:25:05 <achow101> I'm in favor of keeping it as is
4622018-08-30T19:26:08 <wumpus> ok, other proposed topics?
4632018-08-30T19:26:18 <wumpus> I guess we haven't had high prio for review yet
4642018-08-30T19:26:23 <wumpus> #topic high priority for review
4652018-08-30T19:26:55 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
4662018-08-30T19:27:00 <jonasschnelli> I'd like to add #14046
4672018-08-30T19:27:02 <wumpus> we made quite a lot of progress there this week
4682018-08-30T19:27:03 <gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub
4692018-08-30T19:27:12 <wumpus> only three left
4702018-08-30T19:27:41 <wumpus> added
4712018-08-30T19:28:43 <achow101> can I get #14019 for hi prio?
4722018-08-30T19:28:45 <gribble> https://github.com/bitcoin/bitcoin/issues/14019 | Import pubkeys when importing p2sh with importmulti by achow101 · Pull Request #14019 · bitcoin/bitcoin · GitHub
4732018-08-30T19:29:01 <wumpus> achow101: you already have one
4742018-08-30T19:29:09 <achow101> replace it with that one
4752018-08-30T19:29:13 <wumpus> ok
4762018-08-30T19:29:48 <wumpus> done
4772018-08-30T19:30:04 <ken2812221_> wumpus: I want to replace #13866 with #13878
4782018-08-30T19:30:06 <gribble> https://github.com/bitcoin/bitcoin/issues/13866 | utils: Use _wfopen and _wfreopen on Windows by ken2812221 · Pull Request #13866 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4792018-08-30T19:30:08 <gribble> https://github.com/bitcoin/bitcoin/issues/13878 | utils: Add fstream wrapper to allow to pass unicode filename on Windows by ken2812221 · Pull Request #13878 · bitcoin/bitcoin · GitHubAsset 1Asset 1
4802018-08-30T19:30:26 <wumpus> ken2812221_: you really need to find someone that can review windows stuff :)
4812018-08-30T19:31:11 <wumpus> anyhow - replaced
4822018-08-30T19:31:18 <ken2812221_> I am not sure that who knows about Windows thing.
4832018-08-30T19:31:48 <wumpus> maybe sipsorcery (who contributed the MSVC build)
4842018-08-30T19:32:51 <wumpus> which reminds me of #14089
4852018-08-30T19:32:53 <gribble> https://github.com/bitcoin/bitcoin/issues/14089 | CryptGenRandom is deprecated by fingera · Pull Request #14089 · bitcoin/bitcoin · GitHub
4862018-08-30T19:32:58 <wumpus> I'd, personally, prefer to close that one
4872018-08-30T19:33:22 <wumpus> or what luke-jr says, add it as extra random source, that can't hurt
4882018-08-30T19:34:10 <jonasschnelli> deprecated PRNG may have less backdoors. :)
4892018-08-30T19:34:44 <wumpus> right, good to be very careful here
4902018-08-30T19:35:25 <ken2812221_> anyway, I don't have a strong opinion.
4912018-08-30T19:35:27 <gmaxwell> when we finally do move off of openssl as an input, we'll add additional randomness inputs, making that stuff slightly less critical.
4922018-08-30T19:35:38 <gmaxwell> ken2812221_: what caused you to be aware of the deprecation?
4932018-08-30T19:36:39 <wumpus> he only concept-ACKed it
4942018-08-30T19:36:41 <ken2812221_> Well, that is not my PR.
4952018-08-30T19:37:21 <wumpus> NicolasDorier NACKed it (with rationale)
4962018-08-30T19:37:38 *** Krellan has joined #bitcoin-core-dev
4972018-08-30T19:37:58 <wumpus> he's another person that knows things about windows btw, you could maybe ping him in your other PRs ken2812221_ :)
4982018-08-30T19:38:21 <ken2812221_> Thank you, wumpus
4992018-08-30T19:38:26 <gmaxwell> ken2812221_: oh sorry, its fingera's PR. my mistake.
5002018-08-30T19:40:05 <wumpus> ok, any other topics?
5012018-08-30T19:41:12 <wumpus> ken2812221_: would be nice to get your PRs in for 0.18 and fix the windows unicode issues once and for all
5022018-08-30T19:42:08 *** Krellan has quit IRC
5032018-08-30T19:42:08 <ken2812221_> I'm not sure if this fix all problems, it needs more and more tests.
5042018-08-30T19:42:25 <ken2812221_> But we have 6+ months to test it.
5052018-08-30T19:42:58 <wumpus> yes, better to merge it soon in that regard
5062018-08-30T19:43:31 *** Rootsudo has joined #bitcoin-core-dev
5072018-08-30T19:44:53 <wumpus> so if no other topics I'm going to close the meeting
5082018-08-30T19:45:34 <wumpus> #endmeeting
5092018-08-30T19:45:34 <lightningbot> Meeting ended Thu Aug 30 19:45:34 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5102018-08-30T19:45:34 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-08-30-19.01.html
5112018-08-30T19:45:34 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-08-30-19.01.txt
5122018-08-30T19:45:34 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-08-30-19.01.log.html
5132018-08-30T19:45:46 <phantomcircuit> while people are here
5142018-08-30T19:46:19 <gmaxwell> phantomcircuit has almost finished a patch to switch to poll but is stuck on some C++ confusion.
5152018-08-30T19:46:28 *** phwalkr has quit IRC
5162018-08-30T19:46:36 <phantomcircuit> https://github.com/pstratem/bitcoin/commit/03fba51baf35824fb9e55caf2384bbd7626c5dc5#diff-9a82240fe7dfe86564178691cc57f2f1R319
5172018-08-30T19:46:37 <phantomcircuit> https://0bin.net/paste/M-ESIY-7HRgIM6qK#rCpHK4Oxjyy9aiuMIZ7Av28dp8QSD3CBORpKoyw4-wp
5182018-08-30T19:46:39 <promag> wumpus: regarding min qt, shouldn't we just use the current qt lts?
5192018-08-30T19:46:47 <phantomcircuit> net.cpp:2188:39: error: no matching function for call to âCConnman::RegisterListenSocket(SOCKET&)â
5202018-08-30T19:46:59 <gmaxwell> I looked at it, but must be a blonde day for me...
5212018-08-30T19:47:07 *** phwalkr has joined #bitcoin-core-dev
5222018-08-30T19:47:15 <promag> too bad if distributions use less than that?
5232018-08-30T19:47:16 <phantomcircuit> but im pretty clear that im calling RegisterListenSocket(hSocketListen) and hSocketListen is a const ListenSocket&
5242018-08-30T19:47:25 <phantomcircuit> any ideas?
5252018-08-30T19:49:01 <wumpus> promag: so that is 5.5?
5262018-08-30T19:49:16 <promag> 5.9
5272018-08-30T19:49:19 <wumpus> phantomcircuit: will have a look
5282018-08-30T19:50:20 <wumpus> phantomcircuit: the branch is 2018-08-29-poll?
5292018-08-30T19:50:30 <wumpus> I rather check locally instead of on gh
5302018-08-30T19:51:21 *** phwalkr has quit IRC
5312018-08-30T19:54:54 *** willyko_ has quit IRC
5322018-08-30T19:56:23 <wumpus> ok this is really strange
5332018-08-30T19:56:36 * wumpus wishes c++ had helpful warnings like rust
5342018-08-30T19:57:35 <promag> it's not strange
5352018-08-30T19:57:46 <midnightmagic> I thought clang having helpful warnings was one of the whole reasons for its existence
5362018-08-30T19:58:11 <promag> the correct line is https://github.com/bitcoin/bitcoin/blob/03fba51baf35824fb9e55caf2384bbd7626c5dc5/src/net.cpp#L2188
5372018-08-30T19:58:38 <promag> there type of hListenSocket is SOCKET
5382018-08-30T19:58:46 <wumpus> promag: yes!
5392018-08-30T19:58:57 <wumpus> was looking at the wrong caller function
5402018-08-30T19:59:36 <wumpus> the argument to RegisterListenSocket is a ListenSocket structure, which has a SOCKET and a whiltelisting flag
5412018-08-30T19:59:49 <promag> me too, but then I say the line..
5422018-08-30T19:59:58 <promag> *saw
5432018-08-30T20:01:15 <wumpus> I only noticed it when I replaced the argument with a copy of the structure, then noticed the variable name in the compiler error didn't change
5442018-08-30T20:02:15 *** Krellan has joined #bitcoin-core-dev
5452018-08-30T20:03:01 *** Victorsueca has quit IRC
5462018-08-30T20:03:18 *** Krellan has quit IRC
5472018-08-30T20:03:47 *** Krellan has joined #bitcoin-core-dev
5482018-08-30T20:04:18 *** Victorsueca has joined #bitcoin-core-dev
5492018-08-30T20:05:31 *** Krellan has quit IRC
5502018-08-30T20:05:37 *** Krellan_ has joined #bitcoin-core-dev
5512018-08-30T20:08:33 *** elichai2 has quit IRC
5522018-08-30T20:09:19 *** promag has quit IRC
5532018-08-30T20:10:07 <wumpus> phantomcircuit: so on the line below it, 2189, a ListenSocket is actually constructed with ListenSocket(hListenSocket, fWhitelisted)
5542018-08-30T20:10:54 <wumpus> though I'm not sure you need to call it there at all, as RegisterListenSocket will already be called with everything in that vector it is added to
5552018-08-30T20:18:11 *** promag has joined #bitcoin-core-dev
5562018-08-30T20:19:44 *** Rootsudo has quit IRC
5572018-08-30T20:19:45 *** SopaXorzTaker has quit IRC
5582018-08-30T20:20:32 <luke-jr> sorry I missed the meeting
5592018-08-30T20:21:00 <luke-jr> would be nice if people look at and decide between the two ARM/RISC-V symbol check things - either one is a fine starting point IMO
5602018-08-30T20:21:21 <luke-jr> hebasto: I deleted it because I noticed it was the binary tarball, not sources
5612018-08-30T20:21:41 *** Zenton has quit IRC
5622018-08-30T20:21:58 *** Zenton has joined #bitcoin-core-dev
5632018-08-30T20:21:58 <wumpus> luke-jr: my vote would be little-endian only
5642018-08-30T20:22:08 <wumpus> luke-jr: oh, that's not what you mean
5652018-08-30T20:23:19 <hebasto> luke-jr: Thank you for clarification.
5662018-08-30T20:23:27 <wumpus> yes the symbol check thing is another thing with competing PRs
5672018-08-30T20:23:52 <wumpus> tbh for such scripts I care very little as long as they do what they should do
5682018-08-30T20:24:45 <promag> what is going on in #14090? :S
5692018-08-30T20:24:48 <gribble> https://github.com/bitcoin/bitcoin/issues/14090 | [windows] progress bar in task bar by alexeyneu · Pull Request #14090 · bitcoin/bitcoin · GitHub
5702018-08-30T20:25:18 <luke-jr> wumpus: I'm inclined to just close mine and rebase on the other one
5712018-08-30T20:25:31 <luke-jr> maybe clean it up slightly (grouping the arch configurations together)
5722018-08-30T20:26:30 *** AaronvanW has joined #bitcoin-core-dev
5732018-08-30T20:26:37 <wumpus> yes, rebasing one on top of the other would be great and make it much easier to go ahead
5742018-08-30T20:26:53 <wumpus> promag: good question...
5752018-08-30T20:27:30 <wumpus> promag: I've unsubscribed from it, was kind of annoyed by the author
5762018-08-30T20:28:29 <phantomcircuit> wumpus, oh snap yeah i see what it is
5772018-08-30T20:28:43 <wumpus> didn't want to close it in case anyone else wanted to guide them toward getting the PR to a mergable state, as the functionality looks useful, but if it's a lost cause we probably should
5782018-08-30T20:29:06 <phantomcircuit> promag, ty
5792018-08-30T20:29:21 <luke-jr> I suspect a language barrier in that one
5802018-08-30T20:29:24 <phantomcircuit> gmaxwell, derp
5812018-08-30T20:29:30 <phantomcircuit> was the answer of course
5822018-08-30T20:29:39 <luke-jr> he thought I was trying to make a joke when I said to not touch unrelated whitespace O.o
5832018-08-30T20:30:13 <wumpus> yes he seems like an impossible person
5842018-08-30T20:30:50 <wumpus> goes to argue against all review comments
5852018-08-30T20:30:59 <promag> I guess I'll open a new one with the winextra
5862018-08-30T20:31:21 <luke-jr> :x
5872018-08-30T20:31:44 <promag> don't care? :D
5882018-08-30T20:31:50 <wumpus> looks like either a language barrier or at the least a strong misunderstanding how contributing to open source works, that was clear from the first post
5892018-08-30T20:32:08 <luke-jr> I would prefer fixing the communications and teaching him to do it right, so he doesn't think we're just a clique
5902018-08-30T20:32:22 <luke-jr> (and hopefully contributes more in the future)
5912018-08-30T20:32:27 *** AaronvanW has quit IRC
5922018-08-30T20:32:42 <wumpus> yes, if you think there's any hope of that, that'd be preferable
5932018-08-30T20:33:11 <promag> ok then, my suggestion is there
5942018-08-30T20:34:12 *** Rootsudo has joined #bitcoin-core-dev
5952018-08-30T20:50:43 <phantomcircuit> if select() fails we're currently setting every fd in fdsetRecv so that the loop immediately after will call recv for every node
5962018-08-30T20:50:57 <phantomcircuit> that doesn't seem to make much sense
5972018-08-30T20:52:40 <phantomcircuit> this logic goes back to satoshi also so ?
5982018-08-30T20:53:29 <wumpus> yes, that doesn't sound very sensible to me either...
5992018-08-30T20:59:20 <phantomcircuit> seems like if select() fails we should sleep for a bit and continue the loop?
6002018-08-30T21:00:12 <phantomcircuit> actually it seems like every way this can fail except EINTR is basically catastrophic
6012018-08-30T21:03:34 *** bitconner has quit IRC
6022018-08-30T21:29:38 *** Rootsudo has quit IRC
6032018-08-30T21:39:27 *** promag has quit IRC
6042018-08-30T21:43:52 *** AaronvanW has joined #bitcoin-core-dev
6052018-08-30T21:47:51 <gmaxwell> Bustapay ftw.
6062018-08-30T21:48:23 *** AaronvanW has quit IRC
6072018-08-30T21:48:28 <gmaxwell> achow101: See https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-August/016340.html ?
6082018-08-30T21:49:43 <achow101> cool!
6092018-08-30T21:54:00 <instagibbs> Dr Maxwell makes his return
6102018-08-30T21:54:31 <instagibbs> I gave some technical feeback over hte last week; pretty cool to see it live :)
6112018-08-30T22:09:16 *** michaelsdunn1 has quit IRC
6122018-08-30T22:18:47 <grubles_> cool stuff
6132018-08-30T22:18:50 *** promag has joined #bitcoin-core-dev
6142018-08-30T22:23:26 *** peevsie has quit IRC
6152018-08-30T22:33:34 *** Zenton has quit IRC
6162018-08-30T22:33:55 *** profmac has quit IRC
6172018-08-30T22:34:17 *** profmac has joined #bitcoin-core-dev
6182018-08-30T22:35:04 *** Guyver2 has quit IRC
6192018-08-30T22:42:38 *** plankers has quit IRC
6202018-08-30T22:46:44 *** justanotheruser has quit IRC
6212018-08-30T22:47:15 *** justanotheruser has joined #bitcoin-core-dev
6222018-08-30T23:07:53 <echeveria> gmaxwell: I can see people doing this really badly.
6232018-08-30T23:08:21 *** sneakerhax has quit IRC
6242018-08-30T23:08:27 <echeveria> gmaxwell: it also requires that the sender can process the transaction before the HTTP request times out.
6252018-08-30T23:09:28 <echeveria> gmaxwell: you can also hammer the remote to enumerate their outputs, but never submit a result.
6262018-08-30T23:10:27 <gmaxwell> echeveria: hm? No. you can only learn one output from the remote per output you spend.
6272018-08-30T23:11:23 <gmaxwell> You connect to the merchant and give him a valid txn ready for broadcast. He responds with an updated version that includes his output. If you don't reply, he sends the original to the network.
6282018-08-30T23:12:38 <echeveria> "Doing so will invalidate the "template transaction"'s original input signatures, so the sender needs to return this "partial transaction" back to the receiver to sign. This is returned as a hex-encoded raw transaction a response to the original HTTP POST request."
6292018-08-30T23:12:59 <echeveria> "The receiver is responsible in making sure the "partial transaction" returned by the sender was changed correctly (it should assume the connection has been MITM'd and act accordingly), resign its original inputs and propagates this transaction over the bitcoin network. The client must be aware that the server can reorder inputs and outputs."
6302018-08-30T23:13:13 <echeveria> oh.
6312018-08-30T23:13:31 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6322018-08-30T23:13:32 <echeveria> uh. I guess so.
6332018-08-30T23:18:41 *** grubles_ has quit IRC
6342018-08-30T23:18:42 *** lnostdal has quit IRC
6352018-08-30T23:19:12 <phantomcircuit> wumpus, seems like select can fail if a socket is closed or in some way broken
6362018-08-30T23:19:27 <phantomcircuit> so im guessing calling recv() on every socket was some attempt to handle that?
6372018-08-30T23:19:39 *** Rootsudo has joined #bitcoin-core-dev
6382018-08-30T23:23:14 *** belcher_ has quit IRC
6392018-08-30T23:31:26 *** lnostdal has joined #bitcoin-core-dev
6402018-08-30T23:35:47 *** lnostdal has quit IRC
6412018-08-30T23:40:02 *** AaronvanW has joined #bitcoin-core-dev
6422018-08-30T23:51:28 *** lnostdal has joined #bitcoin-core-dev
6432018-08-30T23:54:54 *** captjakk has quit IRC
6442018-08-30T23:55:06 *** grubles_ has joined #bitcoin-core-dev