1 2018-09-06T00:12:45  *** Victorsueca has quit IRC
  2 2018-09-06T00:13:44  *** Victorsueca has joined #bitcoin-core-dev
  3 2018-09-06T00:38:12  *** justan0theruser is now known as justanotheruser
  4 2018-09-06T00:39:23  *** justanotheruser is now known as cata-foxes
  5 2018-09-06T00:39:25  *** Murch has quit IRC
  6 2018-09-06T00:39:35  *** cata-foxes is now known as justanotheruser
  7 2018-09-06T00:42:00  *** masonicboom has quit IRC
  8 2018-09-06T00:49:01  *** Victorsueca has quit IRC
  9 2018-09-06T00:50:21  *** Victorsueca has joined #bitcoin-core-dev
 10 2018-09-06T01:07:36  *** spinza has quit IRC
 11 2018-09-06T01:08:50  *** fanquake has joined #bitcoin-core-dev
 12 2018-09-06T01:10:02  <fanquake> Probably easiest of the release-notes.md in master links to the wiki (as that is quicker and easier to make changes too).
 13 2018-09-06T01:10:18  <fanquake> Then the release notes can just be merged back into branches pre a tag/release. Or something like that.
 14 2018-09-06T01:11:51  <sipa> i'd actually prefer merging them now
 15 2018-09-06T01:12:01  <sipa> there isn't all that much activity on the wiki
 16 2018-09-06T01:13:05  *** AaronvanW has quit IRC
 17 2018-09-06T01:13:08  <fanquake> Fair enough. I can PR that later today if you'd like.
 18 2018-09-06T01:16:16  *** justanotheruser has quit IRC
 19 2018-09-06T01:28:06  *** plankers has quit IRC
 20 2018-09-06T01:28:09  *** spinza has joined #bitcoin-core-dev
 21 2018-09-06T01:39:05  <fanquake> sipa #14157
 22 2018-09-06T01:39:06  <gribble> https://github.com/bitcoin/bitcoin/issues/14157 | [0.17] doc: merge upstream release-notes from bitcoin-core/bitcoin-devwiki by fanquake · Pull Request #14157 · bitcoin/bitcoin · GitHub
 23 2018-09-06T01:40:02  <sipa> thanks!
 24 2018-09-06T01:46:11  *** justanotheruser has joined #bitcoin-core-dev
 25 2018-09-06T02:04:27  <fanquake> Is download.qt.io down for anyone else?
 26 2018-09-06T02:17:36  *** ken2812221_ has joined #bitcoin-core-dev
 27 2018-09-06T02:24:24  <fanquake> nvm, must have been an intermittent issue.
 28 2018-09-06T02:26:18  *** justanotheruser has quit IRC
 29 2018-09-06T02:30:21  *** miknotauro has quit IRC
 30 2018-09-06T02:43:25  *** justanotheruser has joined #bitcoin-core-dev
 31 2018-09-06T03:34:54  *** takinbo has joined #bitcoin-core-dev
 32 2018-09-06T03:48:27  *** sipa has quit IRC
 33 2018-09-06T03:50:27  *** miknotauro has joined #bitcoin-core-dev
 34 2018-09-06T03:55:19  *** ken2812221_ has quit IRC
 35 2018-09-06T03:57:14  *** sipa has joined #bitcoin-core-dev
 36 2018-09-06T03:58:34  *** fanquake has quit IRC
 37 2018-09-06T03:58:53  *** fanquake has joined #bitcoin-core-dev
 38 2018-09-06T03:59:37  *** fanquake has joined #bitcoin-core-dev
 39 2018-09-06T04:00:07  *** fanquake has quit IRC
 40 2018-09-06T04:00:26  *** fanquake has joined #bitcoin-core-dev
 41 2018-09-06T04:01:06  *** profmac has quit IRC
 42 2018-09-06T04:05:47  *** sipa_ has joined #bitcoin-core-dev
 43 2018-09-06T04:08:04  *** sipa has quit IRC
 44 2018-09-06T04:16:29  *** instagibbs has quit IRC
 45 2018-09-06T04:17:18  *** profmac has joined #bitcoin-core-dev
 46 2018-09-06T04:17:40  *** contrapumpkin has quit IRC
 47 2018-09-06T04:18:23  *** a5m0 has quit IRC
 48 2018-09-06T04:19:38  *** instagibbs has joined #bitcoin-core-dev
 49 2018-09-06T04:25:13  *** a5m0 has joined #bitcoin-core-dev
 50 2018-09-06T04:34:24  *** fanquake has joined #bitcoin-core-dev
 51 2018-09-06T04:37:46  *** fanquake has quit IRC
 52 2018-09-06T04:38:01  *** fanquake has joined #bitcoin-core-dev
 53 2018-09-06T06:15:28  *** a5m0 has quit IRC
 54 2018-09-06T06:17:54  *** fanquake has quit IRC
 55 2018-09-06T06:27:07  *** AaronvanW has joined #bitcoin-core-dev
 56 2018-09-06T06:31:43  *** AaronvanW has quit IRC
 57 2018-09-06T07:07:51  *** a5m0 has joined #bitcoin-core-dev
 58 2018-09-06T07:17:30  *** ryanofsky has joined #bitcoin-core-dev
 59 2018-09-06T07:25:35  <ken2812221> Both #10102 and #13937 are down
 60 2018-09-06T07:25:37  <gribble> https://github.com/bitcoin/bitcoin/issues/10102 | HTTP Error 500: Internal Server Error
 61 2018-09-06T07:25:38  <gribble> https://github.com/bitcoin/bitcoin/issues/13937 | HTTP Error 500: Internal Server Error
 62 2018-09-06T07:55:01  *** profmac has quit IRC
 63 2018-09-06T08:11:48  *** profmac has joined #bitcoin-core-dev
 64 2018-09-06T08:28:01  *** AaronvanW has joined #bitcoin-core-dev
 65 2018-09-06T08:32:36  *** AaronvanW has quit IRC
 66 2018-09-06T08:44:53  *** trotski2000 has joined #bitcoin-core-dev
 67 2018-09-06T08:46:39  *** Zenton has joined #bitcoin-core-dev
 68 2018-09-06T09:15:23  <wumpus> sipa_: before final
 69 2018-09-06T09:15:50  <wumpus> sipa: editing release notes should *not* happen in the branch right now, who is doing this?
 70 2018-09-06T09:16:32  <wumpus> editing the release notes should happen on the wiki
 71 2018-09-06T09:16:37  <wumpus> if anyone is doing something else, point them there
 72 2018-09-06T09:16:56  <wumpus> FWIW the wiki is also the 'preliminary release notes' link sent in the rc announcements
 73 2018-09-06T09:39:27  *** AaronvanW has joined #bitcoin-core-dev
 74 2018-09-06T10:03:38  <sipa_> wumpus: ok
 75 2018-09-06T10:12:03  *** Guyver2 has joined #bitcoin-core-dev
 76 2018-09-06T11:10:15  *** drexl has joined #bitcoin-core-dev
 77 2018-09-06T11:23:40  *** giaki3003 has joined #bitcoin-core-dev
 78 2018-09-06T11:23:49  *** giaki3003 has left #bitcoin-core-dev
 79 2018-09-06T11:24:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 80 2018-09-06T11:53:49  *** promag has joined #bitcoin-core-dev
 81 2018-09-06T11:57:58  *** promag has quit IRC
 82 2018-09-06T12:21:04  *** Chris_Stewart_5 has quit IRC
 83 2018-09-06T12:30:57  *** miknotauro has quit IRC
 84 2018-09-06T12:55:22  <wumpus> ok, https://github.com/bitcoin/bitcoin/milestone/33 has only release notes TODOs left, let's tag 0.17.0rc3 ?
 85 2018-09-06T13:00:51  *** belcher_ has joined #bitcoin-core-dev
 86 2018-09-06T13:08:16  *** copumpkin has joined #bitcoin-core-dev
 87 2018-09-06T13:12:56  *** RubenSomsen has joined #bitcoin-core-dev
 88 2018-09-06T13:13:15  <ken2812221> ACK
 89 2018-09-06T13:25:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 90 2018-09-06T13:27:10  *** rafalcpp has joined #bitcoin-core-dev
 91 2018-09-06T13:43:02  *** SopaXorzTaker has joined #bitcoin-core-dev
 92 2018-09-06T13:50:44  *** elichai2 has joined #bitcoin-core-dev
 93 2018-09-06T13:52:03  <wumpus>  * [new tag]                                                                           v0.17.0rc3 -> v0.17.0rc3
 94 2018-09-06T13:56:09  *** itaseski has joined #bitcoin-core-dev
 95 2018-09-06T14:01:14  <achow101> yay
 96 2018-09-06T14:18:42  *** owowo has quit IRC
 97 2018-09-06T14:23:12  *** owowo has joined #bitcoin-core-dev
 98 2018-09-06T14:29:23  *** AaronvanW has quit IRC
 99 2018-09-06T14:30:27  *** profmac has quit IRC
100 2018-09-06T14:40:01  *** AaronvanW has joined #bitcoin-core-dev
101 2018-09-06T14:44:25  *** AaronvanW has quit IRC
102 2018-09-06T15:05:21  <provoostenator> ken2812221 they're down for me too. I sent an email to Github yesterday about another one; they're looking into it.
103 2018-09-06T15:11:04  *** polydin has quit IRC
104 2018-09-06T15:23:27  *** Emcy has quit IRC
105 2018-09-06T15:24:39  *** Emcy has joined #bitcoin-core-dev
106 2018-09-06T15:28:20  *** harrymm_ has joined #bitcoin-core-dev
107 2018-09-06T15:28:42  *** harrymm has quit IRC
108 2018-09-06T15:32:48  *** harrymm_ has quit IRC
109 2018-09-06T15:38:24  *** harrymm has joined #bitcoin-core-dev
110 2018-09-06T15:40:45  *** AaronvanW has joined #bitcoin-core-dev
111 2018-09-06T15:43:15  *** harrymm has quit IRC
112 2018-09-06T15:46:36  *** AaronvanW has quit IRC
113 2018-09-06T15:55:33  *** harrymm has joined #bitcoin-core-dev
114 2018-09-06T16:11:24  *** Rootsudo has joined #bitcoin-core-dev
115 2018-09-06T16:19:21  *** Victorsueca has quit IRC
116 2018-09-06T16:20:42  *** Victorsueca has joined #bitcoin-core-dev
117 2018-09-06T16:32:45  *** rafalcpp has quit IRC
118 2018-09-06T16:32:45  *** queip has quit IRC
119 2018-09-06T16:49:29  *** Randolf has joined #bitcoin-core-dev
120 2018-09-06T17:10:15  *** Randolf has quit IRC
121 2018-09-06T17:13:55  *** polydin has joined #bitcoin-core-dev
122 2018-09-06T17:14:10  <wumpus> same problem here
123 2018-09-06T17:18:11  *** Guyver2 has quit IRC
124 2018-09-06T17:37:24  *** Krellan has quit IRC
125 2018-09-06T17:39:39  <jamesob> anyone know if we have an easy way of testing zeromq PUBs?
126 2018-09-06T17:40:11  <jamesob> i.e. triggering publications for the purpose of testing a client
127 2018-09-06T17:41:30  <wumpus> regtest + zmq block notifications?
128 2018-09-06T17:41:32  *** Zenton has quit IRC
129 2018-09-06T17:41:48  <wumpus> (e.g. the same way as the functional test does it)
130 2018-09-06T17:42:48  *** AaronvanW has joined #bitcoin-core-dev
131 2018-09-06T17:44:02  <jamesob> yeah, that's probably easiest. thanks wumpus
132 2018-09-06T17:46:43  <Chris_Stewart_5> Was there a bug in master recently related to -datadir?
133 2018-09-06T17:47:33  *** AaronvanW has quit IRC
134 2018-09-06T17:47:51  <wumpus> Chris_Stewart_5: not that I know o, what kind of bug?
135 2018-09-06T17:49:52  <Chris_Stewart_5> Ooh, nvm. Seems it might have been related to a systemd config
136 2018-09-06T17:56:02  *** profmac has joined #bitcoin-core-dev
137 2018-09-06T18:02:32  *** SopaXorzTaker has quit IRC
138 2018-09-06T18:02:40  *** hebasto has joined #bitcoin-core-dev
139 2018-09-06T18:03:20  *** Rootsudo has quit IRC
140 2018-09-06T18:13:06  *** itaseski has quit IRC
141 2018-09-06T18:26:24  <wumpus> right
142 2018-09-06T18:29:41  *** jtimon has joined #bitcoin-core-dev
143 2018-09-06T18:34:25  <jonasschnelli> sipa_: a) is the master key fingerprint optional?
144 2018-09-06T18:34:55  <sipa_> jonasschnelli: where?
145 2018-09-06T18:34:59  *** sipa_ is now known as sipa
146 2018-09-06T18:35:17  <jonasschnelli> sipa: in the descriptor. :)
147 2018-09-06T18:35:26  <jonasschnelli> would ... pkh(d34db33f/44'/0'/0':xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL/1/*)
148 2018-09-06T18:35:39  <sipa> that's valid
149 2018-09-06T18:35:43  <jonasschnelli> also work as pkh(xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL/1/*)
150 2018-09-06T18:35:48  <sipa> yes of course
151 2018-09-06T18:35:53  <jonasschnelli> Oh... NM, that is already implemented..
152 2018-09-06T18:36:04  <sipa> it just doesn't have key origin info if you don't specify it
153 2018-09-06T18:36:37  <jonasschnelli> Is a key origin always fingerprint & path or can it just be the fingerprint?
154 2018-09-06T18:36:50  <sipa> it can just be fingerprint
155 2018-09-06T18:36:53  <sipa> in case the path is empty
156 2018-09-06T18:37:35  <jonasschnelli> okay... but that wouldn't not imply that the fingerprint must be the related xpubs fingerprint?
157 2018-09-06T18:37:54  <sipa> uh, i guess it would be
158 2018-09-06T18:38:13  <sipa> yeah, there isn't much sense in that case,  i guess
159 2018-09-06T18:38:16  <jonasschnelli> I'm asking because the fingerprint could also be a hint to the signing device without revealing the path
160 2018-09-06T18:38:19  <sipa> or at least it should be enforced
161 2018-09-06T18:39:00  *** promag has joined #bitcoin-core-dev
162 2018-09-06T18:39:01  *** promag has quit IRC
163 2018-09-06T18:39:17  *** promag has joined #bitcoin-core-dev
164 2018-09-06T18:39:32  *** promag has quit IRC
165 2018-09-06T18:53:40  <jonasschnelli> sipa: would it make sense to always support 'h' as hardened key indicator...
166 2018-09-06T18:53:47  <jonasschnelli> The parsing does not https://github.com/bitcoin/bitcoin/pull/13723/files#diff-0480c57f121cd5daa1bc3a495a51ebaeR562
167 2018-09-06T18:54:04  <achow101> jonasschnelli: IMO yes. that's part of one my import things PRs
168 2018-09-06T18:54:08  <jonasschnelli> And I just looked up, ... there is no "clear" standard for derivation path (BIP32 doesn't mention it specific)
169 2018-09-06T18:54:12  <achow101> the BIP uses h/H too
170 2018-09-06T18:54:41  <jonasschnelli> achow101: is there a spec how to specify a derivation path? I think this is something that is vaguely defined.
171 2018-09-06T18:55:02  <sipa> jonasschnelli: the parser should always support h wherever ' is supported
172 2018-09-06T18:55:09  <jonasschnelli> agree
173 2018-09-06T18:55:11  <sipa> there are even tests for that
174 2018-09-06T18:55:24  <achow101> jonasschnelli: doesn't bip 32 say>?
175 2018-09-06T18:55:48  *** clarkmoody has joined #bitcoin-core-dev
176 2018-09-06T18:56:29  <sipa> jonasschnelli: https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp#L439
177 2018-09-06T18:57:22  *** Krellan has joined #bitcoin-core-dev
178 2018-09-06T18:59:54  <jonasschnelli> sipa: but https://github.com/bitcoin/bitcoin/pull/13723/files#diff-0480c57f121cd5daa1bc3a495a51ebaeR562 ?
179 2018-09-06T19:00:26  <sipa> jonasschnelli: that's not used by the descriptor code
180 2018-09-06T19:00:29  *** elichai2 has quit IRC
181 2018-09-06T19:00:30  <wumpus> #startmeeting
182 2018-09-06T19:00:30  <lightningbot> Meeting started Thu Sep  6 19:00:30 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
183 2018-09-06T19:00:30  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
184 2018-09-06T19:00:39  <gmaxwell> Hi
185 2018-09-06T19:00:57  <achow101> hi
186 2018-09-06T19:01:00  <jonasschnelli> hi
187 2018-09-06T19:01:08  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircu
188 2018-09-06T19:01:11  <wumpus> it codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
189 2018-09-06T19:01:42  <wumpus> PSA: v0.17.0rc3 has been tagged
190 2018-09-06T19:01:56  <wumpus> topics?
191 2018-09-06T19:02:00  <sipa> \o/
192 2018-09-06T19:02:28  *** meshcollider_ has joined #bitcoin-core-dev
193 2018-09-06T19:02:44  <meshcollider> hi
194 2018-09-06T19:03:03  <gmaxwell> Seems things have been kind of quiet.
195 2018-09-06T19:03:21  <wumpus> yes, quiet week
196 2018-09-06T19:03:55  <provoostenator> hi
197 2018-09-06T19:04:00  <jnewbery> hi
198 2018-09-06T19:04:08  <gmaxwell> phantomcircuit (your ping got cut, perhaps you'd like to talk about your poll() work, if you're around)
199 2018-09-06T19:04:08  <Chris_Stewart_5> Thoughts on merging #12775 ? Do we want it enabled in .travis.yml by default?
200 2018-09-06T19:04:11  <gribble> https://github.com/bitcoin/bitcoin/issues/12775 | Integration of property based testing into Bitcoin Core by Christewart · Pull Request #12775 · bitcoin/bitcoin · GitHub
201 2018-09-06T19:04:15  *** promag has joined #bitcoin-core-dev
202 2018-09-06T19:04:29  <wumpus> Chris_Stewart_5: yeah that one should be merged...
203 2018-09-06T19:04:40  <phantomcircuit> Hello
204 2018-09-06T19:04:44  <Chris_Stewart_5> sorry, RAPIDCHECK=1 in DEP_OPTS
205 2018-09-06T19:05:19  <wumpus> Chris_Stewart_5: and it makes sense to have it enabled for at least one travis build if it's merged, after all, otherwise it'll probably get under-tested
206 2018-09-06T19:05:19  *** promag has quit IRC
207 2018-09-06T19:05:31  <phantomcircuit> i'm working on implementing poll on *nix systems, the first step is to cleanup ThreadSocketHandler to separate the select() logic from the rest of the logic
208 2018-09-06T19:05:41  <wumpus> oh topic
209 2018-09-06T19:05:50  <wumpus> #topic poll() (phantoncircuit)
210 2018-09-06T19:06:02  <Chris_Stewart_5> wumpus: I'll try to take care of that in the next 2 days
211 2018-09-06T19:06:18  <phantomcircuit> i've started that in #14147 (which is as far as im going to go in that particular pr)
212 2018-09-06T19:06:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14147 | net: Refactor ThreadSocketHandler by pstratem · Pull Request #14147 · bitcoin/bitcoin · GitHub
213 2018-09-06T19:06:19  <wumpus> Chris_Stewart_5: I mean it'd be perfectly valid to say you don't want to hold up this PR for that, and do it later
214 2018-09-06T19:06:25  <wumpus> Chris_Stewart_5: just be clear :)
215 2018-09-06T19:07:00  <phantomcircuit> next step after that is going to be to separate the socket handling logic from the select() logic
216 2018-09-06T19:07:03  <wumpus> phantomcircuit: good
217 2018-09-06T19:07:11  <gmaxwell> phantomcircuit: my understanding is that your refactors are driven by a more complete set of commits that go all the way to actually enabling poll, you just haven't PRed the ret, right?
218 2018-09-06T19:07:28  <phantomcircuit> gmaxwell, right
219 2018-09-06T19:08:21  <wumpus> so enabling poll turns out to be more work than was expected, I was told at some point it'd basically be a five-line patch, or is this because you want to do it properly? :)
220 2018-09-06T19:09:08  <sipa> it seems we're pretty close on track for the 0.17 release schedule
221 2018-09-06T19:09:11  <gmaxwell> he's doing it more properly.
222 2018-09-06T19:10:17  <gmaxwell> ISTM at least the current PR is a perfectly fine change even considered independantly of poll().
223 2018-09-06T19:10:29  <phantomcircuit> doing it more property, there's a smaller patchset possible but that does things like iterate over every fd for every cnode looking for it's own fd
224 2018-09-06T19:10:46  <phantomcircuit> which is O(n^2) worst case for n = vNodes.size()
225 2018-09-06T19:10:53  <phantomcircuit> so probably dont want to do that
226 2018-09-06T19:10:58  <wumpus> ok, yes, that would be good to avoid, we don't want to worsen performance
227 2018-09-06T19:11:21  <wumpus> right, thanks for the explanation, it's common for people to underestimate how much work something is anyhow :)
228 2018-09-06T19:11:52  <gmaxwell> I think I made the 5 line comment before, but it was based on an actual ~5 line patch that matt was previously using. :P
229 2018-09-06T19:12:07  <phantomcircuit> and indeed the current patchset is specifically selected to make sense even without poll() (but that's certainly why im doing it)
230 2018-09-06T19:13:37  <wumpus> should we add 14147 to high priority for review? I suppose it's blocking further work for you
231 2018-09-06T19:13:42  <phantomcircuit> poll() works more like epoll than select, specifically there's no equivalent for FD_ISSET, so either you need to keep some sort of mapping or iterate over them
232 2018-09-06T19:14:11  <phantomcircuit> i believe matts patchset just iterated which is trivial but certainly not what we want to do
233 2018-09-06T19:14:25  <wumpus> indeed
234 2018-09-06T19:14:35  <wumpus> it was just aproof of concept then
235 2018-09-06T19:14:36  <sipa> makes sense
236 2018-09-06T19:14:44  <phantomcircuit> wumpus, im building off that pr for the rest of the poll() logic assuming it'll eventually be fine
237 2018-09-06T19:15:14  <phantomcircuit> there's 7 commits to that pr and 100 loc changed but mostly that's just moving things
238 2018-09-06T19:15:18  <BlueMatt> I mean iterating is essentially fine, really
239 2018-09-06T19:15:18  <gmaxwell> It's a nearly trivial review in any case. It's just moving things around.
240 2018-09-06T19:15:27  <BlueMatt> its not like we're handling 10k connections
241 2018-09-06T19:15:36  <gmaxwell> ?w=1 eliminates 90% of the diff. :)
242 2018-09-06T19:15:40  <BlueMatt> (and less error-prone than tracking things with CNodes)
243 2018-09-06T19:15:48  <BlueMatt> cause we've had errors in the past with CNode deletion ordering....
244 2018-09-06T19:15:57  <BlueMatt> or, if not errors, shitloads of complication that made review hard
245 2018-09-06T19:16:32  <gmaxwell> I agree that iterating is fine for a few hundred connections, but I think we'd prefer to avoid it unless we really do get mired in review.
246 2018-09-06T19:16:38  <wumpus> anyhow, let's review phantomcircuit 's work
247 2018-09-06T19:16:44  <BlueMatt> wumpus: yea, fair
248 2018-09-06T19:16:47  <wumpus> I don't see the point of discussing this now
249 2018-09-06T19:16:52  <BlueMatt> yep
250 2018-09-06T19:17:39  <wumpus> if it's really so hard to review (there's nothing what people have said that would suggest that) then of course we can look for another solution
251 2018-09-06T19:17:46  <wumpus> any other topics?
252 2018-09-06T19:17:48  <gmaxwell> +1
253 2018-09-06T19:18:23  <gmaxwell> sipa: wumpus: Where did we ever land in replacing the openssl RNG?
254 2018-09-06T19:18:35  <wumpus> #topic replacing the openssl RNG
255 2018-09-06T19:18:44  <wumpus> good question, I think that kind of stranded at some point
256 2018-09-06T19:18:47  <sipa> gmaxwell: i don't feel like spending much work on it
257 2018-09-06T19:18:54  <gmaxwell> It would be nice if we could finally be rid of the dependency in 0.18.
258 2018-09-06T19:19:08  <sipa> but we should probably write some requirements for what it needs to be replaced with
259 2018-09-06T19:19:10  <wumpus> ok so someone would need to pick up sipa 's old work probably
260 2018-09-06T19:19:43  <gmaxwell> I think in part because we reasonably wanted to break some of it off into a library, and then that sounded like too much work. :)
261 2018-09-06T19:19:56  <sipa> yes
262 2018-09-06T19:20:00  <meshcollider> Is there an old PR or something
263 2018-09-06T19:20:03  <wumpus> I don't care about that part anymore
264 2018-09-06T19:20:21  <meshcollider> Or a gist
265 2018-09-06T19:20:27  <moneyball> suggested topic: Tokyo CoreDev topic ideas
266 2018-09-06T19:20:32  <gmaxwell> I'd be happy to do something, but I also really don't feel like making a library right now. (or rather, I'd prefer to spend that time working on something else)
267 2018-09-06T19:20:36  <wumpus> just put it in its own subdirectory under src, someone that wants it as library can do the work for that
268 2018-09-06T19:21:07  <wumpus> if not, there's no need to do build system work etc
269 2018-09-06T19:21:09  <provoostenator> meshcollider: #10299
270 2018-09-06T19:21:11  <gribble> https://github.com/bitcoin/bitcoin/issues/10299 | Remove OpenSSL by sipa · Pull Request #10299 · bitcoin/bitcoin · GitHub
271 2018-09-06T19:21:18  *** owowo has quit IRC
272 2018-09-06T19:21:21  <meshcollider> provoostenator: thanks
273 2018-09-06T19:21:30  <gmaxwell> (in particular, librarizing it is hard because a library ought to be reentrant and probably C callable ... which are things that don't matter much for our own use)
274 2018-09-06T19:21:38  <wumpus> I know all too well how frustrating making libraries for c++ is
275 2018-09-06T19:21:57  <luke-jr> why would it be C++?
276 2018-09-06T19:22:02  <wumpus> lol...
277 2018-09-06T19:22:06  <provoostenator>  CoreDev topic ideas: hardware wallet support, faster wallet bootstrap (i.e. sync in background)
278 2018-09-06T19:22:17  <wumpus> yesl et's start piling up other requirements as well
279 2018-09-06T19:22:20  <wumpus> ok, another topic?
280 2018-09-06T19:22:28  <gmaxwell> luke-jr: So one of the things we could do for it would be rewrite in C, but thats something that people don't feel like doing.
281 2018-09-06T19:22:29  <provoostenator> Probably continue the coin selection fun?
282 2018-09-06T19:22:42  <wumpus> let's rewrite it in rust !
283 2018-09-06T19:23:01  <moneyball> wumpus suggested topic: Tokyo CoreDev topic ideas
284 2018-09-06T19:23:14  <kanzure> hi.
285 2018-09-06T19:23:20  <wumpus> #topic Tokyo CoreDev topic ideas (provoostenator)
286 2018-09-06T19:23:23  <sipa> CoreDev topics: descriptors and extensions to them
287 2018-09-06T19:23:36  <kanzure> already on there
288 2018-09-06T19:23:39  <jtimon> rust all your problems
289 2018-09-06T19:23:47  <kanzure> what would you guys like to hjear from other people, and/or from yourselves
290 2018-09-06T19:23:53  <moneyball> kanzure has reached out to some folks, and i plan to as well to solicit topic ideas. also feel free to share them here as you are already doing :)
291 2018-09-06T19:23:55  <wumpus> jtimon: I have C/C++ burnout
292 2018-09-06T19:24:22  <kanzure> oh no that's terminal
293 2018-09-06T19:24:38  <jtimon> wumpus: well, you write python too :p
294 2018-09-06T19:24:47  <wumpus> jtimon: python is still somewhat cute
295 2018-09-06T19:25:01  * jonasschnelli can't be in Tokyo :/
296 2018-09-06T19:25:11  <achow101> kanzure: moneyball: what are the current topics, if any?
297 2018-09-06T19:25:21  <gmaxwell> I'd like to see kallewoof's progress on input grouping get done.
298 2018-09-06T19:25:23  <sipa> wumpus: thankfully carbon doesn't rust
299 2018-09-06T19:25:32  *** promag has joined #bitcoin-core-dev
300 2018-09-06T19:25:37  <wumpus> sipa: heh!
301 2018-09-06T19:26:25  <kanzure> achow101: PSBT, hardware wallet stuff, output descriptors, input grouping, schnorr signatures BIP stuff, forward blocks, client-side filtering, lattice-based digital signatures, coin selection, #13869
302 2018-09-06T19:26:26  <gribble> https://github.com/bitcoin/bitcoin/issues/13869 | Filename and command line encoding issue on Windows · Issue #13869 · bitcoin/bitcoin · GitHub
303 2018-09-06T19:26:36  <gmaxwell> Maybe people could think about rhavar's bustapay... I think it might be reasonable to support it in the bitcoin core wallet.
304 2018-09-06T19:26:52  <gmaxwell> lattice-based digital signatures?!?!
305 2018-09-06T19:26:53  <kanzure> who would be a good candidate to fly the flag of bustapay
306 2018-09-06T19:27:04  <kanzure> gmaxwell: it's a meshcollider thing
307 2018-09-06T19:27:17  <moneyball> here is what kanzure has collected so far, from about 10 people:
308 2018-09-06T19:27:17  <moneyball> * partially signed bitcoin transactions
309 2018-09-06T19:27:17  <moneyball> * hardware wallet support
310 2018-09-06T19:27:17  <moneyball> * script validation
311 2018-09-06T19:27:17  <moneyball> * input grouping
312 2018-09-06T19:27:17  <moneyball> * output descriptors
313 2018-09-06T19:27:17  <moneyball> * Schnorr signatures BIP
314 2018-09-06T19:27:18  <moneyball> * k-of-n threshold signatures using Schnorr
315 2018-09-06T19:27:18  <moneyball> * forward blocks
316 2018-09-06T19:27:19  <moneyball> * hardware wallet support in Bitcoin Core
317 2018-09-06T19:27:19  <moneyball> * status of client-side filtering and neutrino
318 2018-09-06T19:27:20  <moneyball> * client side filtering
319 2018-09-06T19:27:40  <sipa> please don't paste long lists in IRC
320 2018-09-06T19:27:50  <meshcollider> Heh I don't think it's worth discussing lattice sigs at CoreDev
321 2018-09-06T19:27:50  <moneyball> oh, sorry
322 2018-09-06T19:27:57  <meshcollider> That's just what I'm working on
323 2018-09-06T19:28:00  <achow101> kanzure: re bustapay, me? I was part of the meeting that came up with the basis for that
324 2018-09-06T19:28:04  <kanzure> okay it is you
325 2018-09-06T19:28:21  <kanzure> done
326 2018-09-06T19:28:43  *** owowo has joined #bitcoin-core-dev
327 2018-09-06T19:29:00  <jnewbery> maybe offtopic for now, but how is bustapay different from p2ep?
328 2018-09-06T19:29:02  <wumpus> nah pasting 12 lines which are relevant topics isn't that bad, but yes, never do that with error messages / logs pelase :)
329 2018-09-06T19:29:13  <BlueMatt> "forward blocks"
330 2018-09-06T19:29:15  <BlueMatt> ?
331 2018-09-06T19:29:20  <instagibbs> BlueMatt, maaku's thing
332 2018-09-06T19:29:22  <instagibbs> IIRC
333 2018-09-06T19:29:30  <kanzure> BlueMatt: time travel exploit
334 2018-09-06T19:29:46  <achow101> jnewbery: it's basically the same thing, but actually implemented
335 2018-09-06T19:30:02  <gmaxwell> jnewbery: actually implementable and not woo.
336 2018-09-06T19:30:26  <kanzure> moneyball and i will be heckling each of you for more topic suggestions soon, thanks for the input
337 2018-09-06T19:30:28  <achow101> it cuts out some of the complexity as a tradeoff for a possible and very small (IMO) privacy risk
338 2018-09-06T19:30:48  <BlueMatt> ah, right, the exploit-timeward-to-change-blocktime-and-fork-to-lock-it-in thing....I feel like thats something that needs more broad bitcoin-dev or whatever discussion, its not something to be discussed a technical planning meeting
339 2018-09-06T19:30:50  <wumpus> do you need even more topics? seems a decent list
340 2018-09-06T19:31:07  <kanzure> this list is tiny compared to last few times; it'll grow.
341 2018-09-06T19:31:07  <BlueMatt> dandelion, depending on who's there, should be discussed
342 2018-09-06T19:31:08  <wumpus> none trivial
343 2018-09-06T19:31:13  <jtimon> kallewoof: has been working on a "signet" branch I'm currently reviewing and testing that allows the creation of signed blocks testchains ala elements, not sure if that could be a topic, but I would be very happy to see something like that get into master at some point
344 2018-09-06T19:31:14  <instagibbs> BlueMatt, ACK
345 2018-09-06T19:31:29  <sipa> agree with BlueMatt as well
346 2018-09-06T19:31:50  <kanzure> jtimon: added
347 2018-09-06T19:31:52  <kanzure> BlueMatt: added
348 2018-09-06T19:31:55  <gmaxwell> agree with BlueMatt as well
349 2018-09-06T19:32:03  <BlueMatt> agree with BlueMatt as well
350 2018-09-06T19:32:06  <BlueMatt> wait, hmmm
351 2018-09-06T19:32:15  <kanzure> don't do that you'll break the universe
352 2018-09-06T19:32:42  <sipa> try typing 'google' into google
353 2018-09-06T19:33:18  <michagogo> Or ‘recursion’
354 2018-09-06T19:33:20  <BlueMatt> Did you mean recursion?
355 2018-09-06T19:33:32  <sipa> BlueMatt: it was an it crowd joke
356 2018-09-06T19:33:56  <provoostenator> Something that might be worth putting in the meeting minutes: multiple PR's are suffering from 500 server error for multiple days. Apparantly Github is aware of the problem.
357 2018-09-06T19:34:07  *** farmerwampum has joined #bitcoin-core-dev
358 2018-09-06T19:34:15  * BlueMatt emailed support and got back a "we're looking into it, its visible on a few projects"
359 2018-09-06T19:34:31  <achow101> do we have so many PRs and issues that we broke github?
360 2018-09-06T19:34:39  <wumpus> github is falling apart, so soon after ms took it over
361 2018-09-06T19:34:54  <sipa> nah, it was falling apart before
362 2018-09-06T19:34:57  <wumpus> I think they switched the server hosting to windows 95
363 2018-09-06T19:35:05  <sipa> haha
364 2018-09-06T19:35:38  <wumpus> if it helps I'll send a mail too
365 2018-09-06T19:35:38  <luke-jr> at least not ME
366 2018-09-06T19:35:50  <wumpus> haah then it would alrady be gone
367 2018-09-06T19:35:57  <kanzure> other topics?
368 2018-09-06T19:36:10  <gmaxwell> WinCE.
369 2018-09-06T19:36:20  <michagogo> How did everyone get a bionic gitian environment working?
370 2018-09-06T19:36:28  <meshcollider> MS haven't actually taken over yet have they
371 2018-09-06T19:36:32  <luke-jr> michagogo: I ended up installing from the iso by hand
372 2018-09-06T19:36:36  <sipa> https://i.imgur.com/zh4F55R.png
373 2018-09-06T19:36:40  <wumpus> deep magic voodoo rituals
374 2018-09-06T19:36:44  <luke-jr> michagogo: and patching gitian to work with it
375 2018-09-06T19:36:52  <wumpus> #topic gitian build on bionic
376 2018-09-06T19:36:58  <meshcollider> sipa: lol
377 2018-09-06T19:37:07  <provoostenator> Works
378 2018-09-06T19:37:10  <wumpus> with LXC it's easy, just the standard steps
379 2018-09-06T19:37:32  <achow101> both lxc and docker work
380 2018-09-06T19:37:50  <achow101> but according to luke-jr kvm is broken again as apparently the new vmbuilder doesn't work?
381 2018-09-06T19:37:58  <achow101> (I haven't tried yet)
382 2018-09-06T19:38:02  <michagogo> wumpus: make-base-vm —lxc —suite bionic seemed to work for me (finished without error), but the result seems broken
383 2018-09-06T19:38:17  <jonasschnelli> define "broken"?
384 2018-09-06T19:38:30  <luke-jr> michagogo: latest gitian?
385 2018-09-06T19:38:36  <michagogo> Yep
386 2018-09-06T19:38:42  <michagogo> (On a xenial host)
387 2018-09-06T19:39:21  <wumpus> these additional steps are what I had to do for gitian building on debian 9.5 with LXC: https://gist.github.com/laanwj/c62e101bfd68718f0686926dfd10666b
388 2018-09-06T19:40:22  <wumpus> (e.g. I needed a new lxc version, as well as a new version of debootstrap as it was lacking the bionic script)
389 2018-09-06T19:41:07  <wumpus> if it built the image then I think that part went right, but you might have an too-old version of LXC that cannot handle bionic
390 2018-09-06T19:41:31  <wumpus> I don't remember what the minimum version is that works, jonasschnelli might
391 2018-09-06T19:41:40  * jonasschnelli looking
392 2018-09-06T19:42:04  <jonasschnelli> stable-2.1
393 2018-09-06T19:42:19  <wumpus> yea 2.1.5 or something?
394 2018-09-06T19:42:32  * luke-jr wonders why bionic needs special LXC support
395 2018-09-06T19:43:02  <jonasschnelli> I think its 2.1.1
396 2018-09-06T19:43:15  <jonasschnelli> jup. 2.1.1. is min
397 2018-09-06T19:43:24  <wumpus> thanks!
398 2018-09-06T19:43:38  *** AaronvanW has joined #bitcoin-core-dev
399 2018-09-06T19:44:21  <achow101> you need at least 2.1.x
400 2018-09-06T19:44:43  *** Rootsudo has joined #bitcoin-core-dev
401 2018-09-06T19:44:47  <wumpus> michagogo: which lxc version did you try with?
402 2018-09-06T19:46:22  <michagogo> wumpus: whatever’s in xenial-updates
403 2018-09-06T19:46:42  <achow101> michagogo: do `lxc-start --version`
404 2018-09-06T19:47:47  *** AaronvanW has quit IRC
405 2018-09-06T19:49:29  <promag> hi :|
406 2018-09-06T19:50:44  <wumpus> Package: lxc1 (2.0.8-0ubuntu1~16.04.2)
407 2018-09-06T19:50:48  <wumpus> so, too old.
408 2018-09-06T19:50:56  <wumpus> promag: hi
409 2018-09-06T19:51:28  <wumpus> other topics?
410 2018-09-06T19:52:31  <wumpus> #endmeeting
411 2018-09-06T19:52:31  <lightningbot> Meeting ended Thu Sep  6 19:52:31 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
412 2018-09-06T19:52:31  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.html
413 2018-09-06T19:52:31  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.txt
414 2018-09-06T19:52:31  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.log.html
415 2018-09-06T19:52:33  <sipa> seems not
416 2018-09-06T19:53:03  <meshcollider> 7:25 am <gmaxwell> I'd like to see kallewoof's progress on input grouping get done.
417 2018-09-06T19:53:04  <meshcollider> What's this referring to?
418 2018-09-06T19:53:52  <luke-jr> #12257 probably?
419 2018-09-06T19:53:59  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHubAsset 1Asset 1
420 2018-09-06T19:54:10  *** jtimon has quit IRC
421 2018-09-06T19:54:26  <gmaxwell> especially the "group for everyone, if it doesn't make your fees higher" part that got dropped at the last minute.
422 2018-09-06T19:54:26  <luke-jr> but it's already merged, so.. dunno
423 2018-09-06T19:54:33  <luke-jr> ah
424 2018-09-06T19:54:36  <gmaxwell> it got gimped before being merged. :P
425 2018-09-06T19:58:31  <meshcollider> oh
426 2018-09-06T20:02:52  *** clarkmoody has quit IRC
427 2018-09-06T20:03:09  <michagogo> Yep, 2.0.8
428 2018-09-06T20:03:27  <michagogo> “lxc-init: missing container name, use —name option”
429 2018-09-06T20:04:08  <michagogo> Maybe I’ll upgrade my VM to 18.04
430 2018-09-06T20:04:12  <MarcoFalke> We should put the minimum version into https://github.com/bitcoin-core/docs
431 2018-09-06T20:04:43  *** AaronvanW has joined #bitcoin-core-dev
432 2018-09-06T20:08:54  <michagogo> sudo do-release-upgrade
433 2018-09-06T20:08:56  <michagogo> er
434 2018-09-06T20:12:10  <wumpus> MarcoFalke: yes, would make sense
435 2018-09-06T20:20:27  *** Urgo has quit IRC
436 2018-09-06T20:27:54  <sipa> jonasschnelli: to be clear, if you have an xpub without key origin in a descriptor, it'll still report a fpr/path in its expansion; just one with fpr = xpub's short id, and empty path
437 2018-09-06T20:28:33  <jonasschnelli> ok
438 2018-09-06T20:29:48  <sipa> i think i'll add a test that if you supply a key origin with empty path, its hash matches the xpub's short id
439 2018-09-06T20:37:22  *** Zenton has joined #bitcoin-core-dev
440 2018-09-06T21:07:33  <michagogo> Okay, I'm now running bionic
441 2018-09-06T21:11:11  <michagogo> And yep, looks like now the build's working
442 2018-09-06T21:17:58  *** Chris_Stewart_5 has quit IRC
443 2018-09-06T21:32:45  *** RubenSomsen has quit IRC
444 2018-09-06T21:44:39  *** belcher_ has quit IRC
445 2018-09-06T22:00:37  *** jtimon has joined #bitcoin-core-dev
446 2018-09-06T22:06:07  *** jtimon has quit IRC
447 2018-09-06T22:06:18  <michagogo> So, hey, looks like my new i7-8750H is quite a bit faster than my i7-3610QM :D
448 2018-09-06T22:22:17  *** hebasto has quit IRC
449 2018-09-06T22:31:25  *** meshcollider_ has quit IRC
450 2018-09-06T22:50:40  *** promag has quit IRC
451 2018-09-06T22:51:14  *** promag has joined #bitcoin-core-dev
452 2018-09-06T22:51:54  *** esotericnonsense has quit IRC
453 2018-09-06T22:55:28  *** promag has quit IRC
454 2018-09-06T22:57:26  *** esotericnonsense has joined #bitcoin-core-dev
455 2018-09-06T23:03:04  *** Victorsueca has quit IRC
456 2018-09-06T23:04:22  *** Victorsueca has joined #bitcoin-core-dev
457 2018-09-06T23:06:18  *** spinza has quit IRC
458 2018-09-06T23:09:30  *** esotericnonsense has quit IRC
459 2018-09-06T23:13:56  *** profmac has quit IRC
460 2018-09-06T23:15:29  *** leishman has joined #bitcoin-core-dev
461 2018-09-06T23:16:26  *** spinza has joined #bitcoin-core-dev
462 2018-09-06T23:22:17  *** leishman has quit IRC
463 2018-09-06T23:34:13  *** esotericnonsense has joined #bitcoin-core-dev
464 2018-09-06T23:34:39  *** esotericnonsense has quit IRC
465 2018-09-06T23:36:16  *** esotericnonsense has joined #bitcoin-core-dev
466 2018-09-06T23:38:59  *** esotericnonsense has quit IRC
467 2018-09-06T23:39:28  *** esotericnonsense has joined #bitcoin-core-dev
468 2018-09-06T23:49:06  *** jcorgan has quit IRC
469 2018-09-06T23:57:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev