12018-09-18T00:00:32  <promag> Maybe replace "Overall workflow" and "RPCs" sections with "Refer to the [PSBT documentation](doc/psbt.md) for more details."
  22018-09-18T00:02:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  32018-09-18T00:06:35  *** plankers has joined #bitcoin-core-dev
  42018-09-18T00:25:33  <wumpus> * [new tag]                                                                           v0.16.3 -> v0.16.3
  52018-09-18T00:26:50  *** adiabat has joined #bitcoin-core-dev
  62018-09-18T00:27:30  <midnightmagic> lol "And to those[...]" "+- beardnboobies"
  72018-09-18T00:29:33  *** Murch has quit IRC
  82018-09-18T00:32:52  *** Victorsueca has quit IRC
  92018-09-18T00:34:06  *** Victorsueca has joined #bitcoin-core-dev
 102018-09-18T00:38:01  *** Murch has joined #bitcoin-core-dev
 112018-09-18T00:41:04  *** promag has quit IRC
 122018-09-18T00:44:42  *** tryphe has quit IRC
 132018-09-18T00:44:56  *** Chris_Stewart_5 has quit IRC
 142018-09-18T00:45:09  *** tryphe has joined #bitcoin-core-dev
 152018-09-18T00:54:31  *** Murch has quit IRC
 162018-09-18T01:05:51  *** grubles has quit IRC
 172018-09-18T01:06:18  *** grubles has joined #bitcoin-core-dev
 182018-09-18T01:06:24  *** escrivner has joined #bitcoin-core-dev
 192018-09-18T01:07:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 202018-09-18T01:07:57  *** rhavar has joined #bitcoin-core-dev
 212018-09-18T01:08:21  *** escrivner has left #bitcoin-core-dev
 222018-09-18T01:08:50  *** escrivner has joined #bitcoin-core-dev
 232018-09-18T01:09:29  *** escrivner has quit IRC
 242018-09-18T01:26:04  *** plankers has quit IRC
 252018-09-18T01:28:53  *** Krellan has quit IRC
 262018-09-18T01:43:51  <luke-jr> wumpus: did someone get a CVE number yet?
 272018-09-18T01:44:28  *** Zenton is now known as vicenteH
 282018-09-18T01:44:42  *** tryphe has quit IRC
 292018-09-18T01:45:07  *** tryphe has joined #bitcoin-core-dev
 302018-09-18T01:45:26  *** plankers has joined #bitcoin-core-dev
 312018-09-18T01:47:34  *** Chris_Stewart_5 has quit IRC
 322018-09-18T01:53:39  <achow101> wouldn't been nice to have had 14196 in rc4 ...
 332018-09-18T01:53:45  <achow101> *would've
 342018-09-18T01:55:04  <sipa> #14196
 352018-09-18T01:55:05  <gribble> https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHub
 362018-09-18T01:55:11  <sipa> oh yes
 372018-09-18T02:07:35  *** fanquake has joined #bitcoin-core-dev
 382018-09-18T02:14:23  <bralyclow> is v0.16.3 official release yet?
 392018-09-18T02:15:37  <bralyclow> I see listed as unofficial release, but it is not tagged Latest Release yet
 402018-09-18T02:20:35  <fanquake> bralyclow It was only tagged a few hours ago, gitian builds still need to be done
 412018-09-18T02:20:41  <gmaxwell> bralyclow: it's been tagged but the binaries are not up yet, since it takes time for the determinstic build process do to its thing.
 422018-09-18T02:21:05  <fanquake> (which are under way at the moment)
 432018-09-18T02:21:47  <bralyclow> very good, thank you for update/clarify, will wait on binaries for mac
 442018-09-18T02:22:19  <bralyclow> btw, when might 0.17 be released as I see at rc4 now?
 452018-09-18T02:25:26  <achow101> bralyclow: 0.17 will be released when we stop finding bugs in it for a week or 2
 462018-09-18T02:25:28  <fanquake> bralyclow There are still some outstanding issues/PRs that need to be resolved for 0.17 https://github.com/bitcoin/bitcoin/milestone/33
 472018-09-18T02:25:31  *** sneakerhax has joined #bitcoin-core-dev
 482018-09-18T02:28:38  <bralyclow> thank you for that info
 492018-09-18T02:37:57  *** plankers has quit IRC
 502018-09-18T02:44:42  *** tryphe has quit IRC
 512018-09-18T02:45:09  *** tryphe has joined #bitcoin-core-dev
 522018-09-18T03:14:20  *** sneakerhax has quit IRC
 532018-09-18T03:41:35  <fanquake> I've PR'd some 0.17.0rc4 unsignedsigs, as I already had depends built, will PR 0.16.3 this arvo.
 542018-09-18T03:44:42  *** tryphe has quit IRC
 552018-09-18T03:45:10  *** tryphe has joined #bitcoin-core-dev
 562018-09-18T04:35:48  *** treebeardd has joined #bitcoin-core-dev
 572018-09-18T04:44:43  *** tryphe has quit IRC
 582018-09-18T04:45:07  *** tryphe has joined #bitcoin-core-dev
 592018-09-18T05:08:22  *** grubles has quit IRC
 602018-09-18T05:08:50  *** grubles has joined #bitcoin-core-dev
 612018-09-18T05:12:45  *** treebeardd has quit IRC
 622018-09-18T05:44:43  *** tryphe has quit IRC
 632018-09-18T05:45:11  *** tryphe has joined #bitcoin-core-dev
 642018-09-18T05:48:34  *** Murch has joined #bitcoin-core-dev
 652018-09-18T06:30:51  *** RubenSomsen has quit IRC
 662018-09-18T06:42:59  *** Victorsueca has quit IRC
 672018-09-18T06:44:12  *** Victorsueca has joined #bitcoin-core-dev
 682018-09-18T06:44:43  *** tryphe has quit IRC
 692018-09-18T06:45:11  *** tryphe has joined #bitcoin-core-dev
 702018-09-18T06:45:20  *** ghost43 has quit IRC
 712018-09-18T06:45:37  *** ghost43 has joined #bitcoin-core-dev
 722018-09-18T06:50:47  *** Murch has quit IRC
 732018-09-18T06:55:59  *** promag has joined #bitcoin-core-dev
 742018-09-18T07:00:49  *** promag has quit IRC
 752018-09-18T07:03:07  *** setpill has joined #bitcoin-core-dev
 762018-09-18T07:08:21  *** ken2812221_ has quit IRC
 772018-09-18T07:17:12  *** setpill has quit IRC
 782018-09-18T07:19:40  *** setpill has joined #bitcoin-core-dev
 792018-09-18T07:24:19  *** zndtoshi has joined #bitcoin-core-dev
 802018-09-18T07:25:21  *** Krellan has joined #bitcoin-core-dev
 812018-09-18T07:25:26  *** pipp8 has quit IRC
 822018-09-18T07:27:22  *** quer has joined #bitcoin-core-dev
 832018-09-18T07:32:25  <wumpus> fanquake: great!
 842018-09-18T07:35:50  <wumpus> i've pushed 0.16.3 unsigned sigs to gitian.sigs
 852018-09-18T07:35:58  *** rhavar has quit IRC
 862018-09-18T07:37:05  <zndtoshi> Pierre Rochard explained in a presentation about Bitcoin Governance that consensus is reached similary to people meeting at the Schelling point: they know the city but not the location and hour to meet. They will think what the other would  do and vice versa and in NY meet in Grand Central Station at noon without communicating. So conseus in Bitcoin is the same: everyone gravitates to the right software to use or the rig
 872018-09-18T07:37:15  <zndtoshi> miners. They have a veto option by signaling acceptance or not of a future softfork. But they should/will meet with everyone else at the Schelling point as well. Is there a REAL need for mining nodes to signal inside the Bitcoin Network? If not, are there any risks to remove mining node signaling?
 882018-09-18T07:37:16  *** hebasto has joined #bitcoin-core-dev
 892018-09-18T07:38:11  *** hebasto has joined #bitcoin-core-dev
 902018-09-18T07:39:00  <echeveria> zndtoshi: this is more appropriate for #bitcoin, please ask it there.
 912018-09-18T07:40:29  <zndtoshi> Thought I would ask developers if there is contention about this. Sorry, will post there.
 922018-09-18T07:42:47  <fanquake> wumpus cool. Looks like yours match my in-progress 0.16.3. Just finishing the macOS build
 932018-09-18T07:44:43  *** tryphe has quit IRC
 942018-09-18T07:45:17  *** tryphe has joined #bitcoin-core-dev
 952018-09-18T07:53:58  *** Krellan has quit IRC
 962018-09-18T07:56:25  *** ossifrage_ has joined #bitcoin-core-dev
 972018-09-18T07:58:56  *** ossifrage has quit IRC
 982018-09-18T08:08:33  <wumpus> now building 0.17.0rc4
 992018-09-18T08:23:18  *** vicenteH is now known as Zenton
1002018-09-18T08:27:48  *** zndtoshi has quit IRC
1012018-09-18T08:36:18  *** fanquake has quit IRC
1022018-09-18T08:36:42  *** timothy has joined #bitcoin-core-dev
1032018-09-18T08:44:43  *** tryphe has quit IRC
1042018-09-18T08:45:11  *** tryphe has joined #bitcoin-core-dev
1052018-09-18T08:45:27  *** AaronvanW has joined #bitcoin-core-dev
1062018-09-18T08:55:06  *** Victorsueca has quit IRC
1072018-09-18T08:56:34  *** Victorsueca has joined #bitcoin-core-dev
1082018-09-18T09:07:40  *** pipp8 has joined #bitcoin-core-dev
1092018-09-18T09:13:02  *** intcat has quit IRC
1102018-09-18T09:14:02  *** intcat has joined #bitcoin-core-dev
1112018-09-18T09:14:33  *** belcher has joined #bitcoin-core-dev
1122018-09-18T09:15:28  *** rafalcpp has quit IRC
1132018-09-18T09:15:47  *** fanquake has joined #bitcoin-core-dev
1142018-09-18T09:18:27  *** rafalcpp has joined #bitcoin-core-dev
1152018-09-18T09:20:18  *** fanquake has quit IRC
1162018-09-18T09:25:13  *** RubenSomsen has joined #bitcoin-core-dev
1172018-09-18T09:27:24  *** fanquake has joined #bitcoin-core-dev
1182018-09-18T09:31:43  *** fanquake has quit IRC
1192018-09-18T09:34:00  *** ken2812221 has quit IRC
1202018-09-18T09:35:41  *** ken2812221 has joined #bitcoin-core-dev
1212018-09-18T09:37:01  *** TheCharlatan has joined #bitcoin-core-dev
1222018-09-18T09:44:43  *** tryphe has quit IRC
1232018-09-18T09:45:11  *** tryphe has joined #bitcoin-core-dev
1242018-09-18T10:01:09  *** fanquake has joined #bitcoin-core-dev
1252018-09-18T10:05:19  *** fanquake has quit IRC
1262018-09-18T10:32:16  *** hebasto has quit IRC
1272018-09-18T10:33:46  *** ghost43 has quit IRC
1282018-09-18T10:34:01  *** ghost43 has joined #bitcoin-core-dev
1292018-09-18T10:44:22  <harding> wumpus: 0.16.3 release PR for BitcoinCore.org for when the binaries are uploaded: https://github.com/bitcoin-core/bitcoincore.org/pull/596
1302018-09-18T10:44:43  *** tryphe has quit IRC
1312018-09-18T10:45:11  *** tryphe has joined #bitcoin-core-dev
1322018-09-18T10:48:54  *** hebasto has joined #bitcoin-core-dev
1332018-09-18T10:55:23  *** fanquake has joined #bitcoin-core-dev
1342018-09-18T11:01:18  *** setpill has quit IRC
1352018-09-18T11:02:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1362018-09-18T11:05:04  <wumpus> harding: thank you, that's quick !
1372018-09-18T11:17:27  *** Guyver2 has joined #bitcoin-core-dev
1382018-09-18T11:18:21  *** SopaXorzTaker has joined #bitcoin-core-dev
1392018-09-18T11:24:01  <fanquake> wumpus 0.15 will need a build as well I guess, given it's maintenance period doesn't end until after 0.17 release?
1402018-09-18T11:25:48  *** Victorsueca has quit IRC
1412018-09-18T11:40:40  *** treebeardd has joined #bitcoin-core-dev
1422018-09-18T11:40:59  *** promag has joined #bitcoin-core-dev
1432018-09-18T11:44:43  *** tryphe has quit IRC
1442018-09-18T11:44:47  *** rex4539 has quit IRC
1452018-09-18T11:45:09  *** tryphe has joined #bitcoin-core-dev
1462018-09-18T11:47:54  *** promag has quit IRC
1472018-09-18T11:49:37  *** booyah is now known as [_D
1482018-09-18T11:59:54  *** stevenroose has quit IRC
1492018-09-18T12:00:46  *** rex4539 has joined #bitcoin-core-dev
1502018-09-18T12:04:37  *** stevenroose has joined #bitcoin-core-dev
1512018-09-18T12:15:27  *** Chris_Stewart_5 has quit IRC
1522018-09-18T12:44:44  *** tryphe has quit IRC
1532018-09-18T12:44:44  *** [_D is now known as booyah
1542018-09-18T12:45:09  *** tryphe has joined #bitcoin-core-dev
1552018-09-18T12:50:02  *** drexl has joined #bitcoin-core-dev
1562018-09-18T12:52:04  <wumpus> fanquake: yes, probably would make sense to tag a 0.15.x release as well
1572018-09-18T12:52:54  <wumpus> though that is less urgent, today I'd ideally like ot upload binaries for 0.17.0rc4 and 0.16.3 at least
1582018-09-18T12:55:32  <achow101> 0.14 isn't EOL yet too
1592018-09-18T12:57:36  <wumpus> the patch has been backported to both 0.14 and 0.15
1602018-09-18T13:00:06  <wumpus> making a release on those branches is pretty much only a matter of writing (short) release notes, if anyone wants to speed it up and have a go at those, be my guest
1612018-09-18T13:04:51  <fanquake> wumpus np. I've just merged achow's sigs. So we've got 3 builders for 0.16.3 and 4 for 0.17.0rc4 so far.
1622018-09-18T13:17:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1632018-09-18T13:34:45  <luke-jr> FWIW, I got CVE-2018-17144 assigned for this
1642018-09-18T13:40:46  <wumpus> (and bumping the version, and bumping the mangpages maybe)
1652018-09-18T13:41:21  <wumpus> luke-jr: thanks
1662018-09-18T13:44:44  *** tryphe has quit IRC
1672018-09-18T13:45:12  *** tryphe has joined #bitcoin-core-dev
1682018-09-18T13:52:05  *** Victorsueca has joined #bitcoin-core-dev
1692018-09-18T14:02:44  *** rafalcpp has quit IRC
1702018-09-18T14:04:55  *** esotericnonsense has quit IRC
1712018-09-18T14:08:27  *** rafalcpp has joined #bitcoin-core-dev
1722018-09-18T14:19:35  *** ovovo has joined #bitcoin-core-dev
1732018-09-18T14:20:47  *** owowo has quit IRC
1742018-09-18T14:30:00  <provoostenator> (building in progress for 0.17rc4, I'll do 0.16.3 too)
1752018-09-18T14:31:11  *** fanquake has quit IRC
1762018-09-18T14:37:29  *** promag has joined #bitcoin-core-dev
1772018-09-18T14:43:39  *** jhfrontz has joined #bitcoin-core-dev
1782018-09-18T14:44:44  *** tryphe has quit IRC
1792018-09-18T14:45:10  *** tryphe has joined #bitcoin-core-dev
1802018-09-18T14:46:25  *** michaelsdunn1 has joined #bitcoin-core-dev
1812018-09-18T14:50:59  <luke-jr> trivial bug in release notes: wumpus didn't update translations :p
1822018-09-18T14:51:02  *** jarthur has joined #bitcoin-core-dev
1832018-09-18T15:28:03  *** morcos has quit IRC
1842018-09-18T15:28:22  *** morcos has joined #bitcoin-core-dev
1852018-09-18T15:31:23  *** Murch has joined #bitcoin-core-dev
1862018-09-18T15:39:26  *** rex4539 has quit IRC
1872018-09-18T15:43:57  *** esotericnonsense has joined #bitcoin-core-dev
1882018-09-18T15:44:03  *** esotericnonsense has quit IRC
1892018-09-18T15:44:44  *** tryphe has quit IRC
1902018-09-18T15:44:57  *** Victorsueca has quit IRC
1912018-09-18T15:45:08  *** tryphe has joined #bitcoin-core-dev
1922018-09-18T15:46:07  *** Victorsueca has joined #bitcoin-core-dev
1932018-09-18T15:48:13  *** treebeardd has quit IRC
1942018-09-18T15:57:30  *** esotericnonsense has joined #bitcoin-core-dev
1952018-09-18T16:00:40  *** Krellan has joined #bitcoin-core-dev
1962018-09-18T16:02:57  *** promag has quit IRC
1972018-09-18T16:13:36  *** nullptr| has quit IRC
1982018-09-18T16:15:16  *** sfhi has joined #bitcoin-core-dev
1992018-09-18T16:18:11  <provoostenator> I'll tackle the 0.15.2 release notes if nobody else is already doing it.
2002018-09-18T16:18:35  *** treebeardd has joined #bitcoin-core-dev
2012018-09-18T16:20:28  *** sfhi has quit IRC
2022018-09-18T16:29:42  <provoostenator> Not that many commits so I can probably do it manually, but the release docs say "ping @wumpus on IRC, he has specific tooling to generate the list of merged pulls and sort them into categories based on labels"
2032018-09-18T16:30:14  <provoostenator> For backports, so I refer to the backport PR or to the original one?
2042018-09-18T16:31:32  *** nullptr| has joined #bitcoin-core-dev
2052018-09-18T16:33:24  <luke-jr> might be good to mention the CVE number in release notes yet-to-be-final
2062018-09-18T16:44:45  *** tryphe has quit IRC
2072018-09-18T16:45:12  *** tryphe has joined #bitcoin-core-dev
2082018-09-18T16:47:31  <provoostenator> luke-jr: I'll add that to #14262 now
2092018-09-18T16:47:33  <gribble> https://github.com/bitcoin/bitcoin/issues/14262 | 0.15.2 release notes by Sjors · Pull Request #14262 · bitcoin/bitcoin · GitHub
2102018-09-18T16:49:44  *** promag has joined #bitcoin-core-dev
2112018-09-18T16:56:56  <luke-jr>  * [new tag]               v0.16.3.knots20180918 -> v0.16.3.knots20180918
2122018-09-18T17:09:46  *** leishman has joined #bitcoin-core-dev
2132018-09-18T17:09:49  *** esotericnonsense has quit IRC
2142018-09-18T17:10:07  <leishman> https://lincolnloop.com/blog/saying-goodbye-botbotme/
2152018-09-18T17:10:11  <leishman> "If you are a channel operator and would like to download a copy of the logs for your channel, please send a PM to ipmb on Freenode for more details."
2162018-09-18T17:10:47  <leishman> I find the bitcoin-core-dev irc logs on botbot super useful for following development progress and learning. Are there channel logs anywhere else?
2172018-09-18T17:11:13  <sipa> see topic :)
2182018-09-18T17:12:13  *** promag has quit IRC
2192018-09-18T17:12:14  *** ovovo is now known as owowo
2202018-09-18T17:12:29  <leishman> oh haha. I may try to run a version of the botbot logger since it's open source and has a much better UI than the others
2212018-09-18T17:13:36  <echeveria> it however, does seem to have a crazy amount of deps.
2222018-09-18T17:14:56  *** esotericnonsense has joined #bitcoin-core-dev
2232018-09-18T17:15:05  <echeveria> I guess not too many, I thought foreman was ruby (along with go, python).
2242018-09-18T17:17:47  <leishman> yeah. shouldn't be too difficult to write a simple logger and put a UI on top of it either.
2252018-09-18T17:19:59  *** timothy has quit IRC
2262018-09-18T17:30:54  *** leishman has quit IRC
2272018-09-18T17:41:40  <provoostenator> FWIW gen-manpages.sh doesn't work on macOS because of sed issues.
2282018-09-18T17:44:45  *** tryphe has quit IRC
2292018-09-18T17:45:14  *** tryphe has joined #bitcoin-core-dev
2302018-09-18T17:58:03  *** rex4539 has joined #bitcoin-core-dev
2312018-09-18T17:58:43  *** jarthur has quit IRC
2322018-09-18T18:02:58  *** csknk has joined #bitcoin-core-dev
2332018-09-18T18:11:12  *** shinohai has joined #bitcoin-core-dev
2342018-09-18T18:11:12  *** Krellan has quit IRC
2352018-09-18T18:11:50  *** Krellan has joined #bitcoin-core-dev
2362018-09-18T18:19:44  *** treebeardd has quit IRC
2372018-09-18T18:24:06  *** d_t has quit IRC
2382018-09-18T18:28:50  *** Krellan has quit IRC
2392018-09-18T18:31:36  *** masonicboom has joined #bitcoin-core-dev
2402018-09-18T18:34:16  *** masonicboom has quit IRC
2412018-09-18T18:40:13  *** Krellan has joined #bitcoin-core-dev
2422018-09-18T18:44:45  *** tryphe has quit IRC
2432018-09-18T18:44:54  *** Krellan has quit IRC
2442018-09-18T18:45:09  *** tryphe has joined #bitcoin-core-dev
2452018-09-18T18:46:42  *** rafalcpp has quit IRC
2462018-09-18T18:48:24  *** rafalcpp has joined #bitcoin-core-dev
2472018-09-18T18:48:45  <wumpus> luke-jr: I explicitly didn't update translations, because translations can contain 'bugs' and we're not following an rc process
2482018-09-18T18:49:20  <wumpus> but yes, not mentioning it in release notes makes sense
2492018-09-18T18:54:39  <wumpus> removed mention of translations from #14251
2502018-09-18T18:54:40  <gribble> https://github.com/bitcoin/bitcoin/issues/14251 | doc: Add historical release notes for 0.16.3 by laanwj · Pull Request #14251 · bitcoin/bitcoin · GitHub
2512018-09-18T18:56:06  <wumpus> provoostenator: yeah, it's more trouble than it's worth using the tooling in this case
2522018-09-18T19:07:10  <provoostenator> I'll remove the translation mention as well.
2532018-09-18T19:07:11  *** jarthur has joined #bitcoin-core-dev
2542018-09-18T19:18:53  <wumpus> I'll add in the CVE, good idea
2552018-09-18T19:31:57  *** michaelsdunn1 has quit IRC
2562018-09-18T19:33:40  *** BashCo has joined #bitcoin-core-dev
2572018-09-18T19:33:45  *** jarthur_ has joined #bitcoin-core-dev
2582018-09-18T19:36:12  *** promag has joined #bitcoin-core-dev
2592018-09-18T19:37:28  *** jarthur has quit IRC
2602018-09-18T19:43:28  *** SopaXorzTaker has quit IRC
2612018-09-18T19:44:45  *** tryphe has quit IRC
2622018-09-18T19:45:11  *** tryphe has joined #bitcoin-core-dev
2632018-09-18T19:46:51  <luke-jr> wumpus:       sudo lxc-execute -n gitian -f var/lxc.config -- sudo -u root -i -- bash
2642018-09-18T19:46:57  <luke-jr> why is this line in your .assert? O.o
2652018-09-18T19:49:41  <provoostenator> I'm trying to build the man pages on a Gitian box, which doesn't have a display. Any idea how to get around "QXcbConnection: Could not connect to display" for "bitcoin-qt --help"?
2662018-09-18T19:52:12  <provoostenator> xvfb-run to the rescue
2672018-09-18T19:58:04  *** csknk has quit IRC
2682018-09-18T19:58:40  *** promag has quit IRC
2692018-09-18T20:04:19  *** promag has joined #bitcoin-core-dev
2702018-09-18T20:05:55  <cfields> gitian builders: v0.16.3 detached sigs are pushed
2712018-09-18T20:06:42  <gmaxwell> perhaps people that regularly build should get pinged directly?
2722018-09-18T20:07:30  <cfields> fanquake/achow101/jonasschnelli/provoostenator/luke-jr/wumpus/MarcoFalke/fivepiece: ^^
2732018-09-18T20:07:44  <achow101> ok
2742018-09-18T20:07:45  <cfields> reused from last time
2752018-09-18T20:09:48  *** quer has quit IRC
2762018-09-18T20:09:56  *** quer_ has joined #bitcoin-core-dev
2772018-09-18T20:09:57  *** theymos has joined #bitcoin-core-dev
2782018-09-18T20:20:49  <wumpus> luke-jr: no idea!
2792018-09-18T20:21:38  <wumpus> luke-jr: oh, apparently I added an 'echo' line once
2802018-09-18T20:26:07  <wumpus> must have been while debugging some issue with lxc, didn't expect it to end up anywhere else but on my own screen; hope it doesn't cause problems with validation
2812018-09-18T20:27:27  *** quer_ has quit IRC
2822018-09-18T20:27:52  *** quer has joined #bitcoin-core-dev
2832018-09-18T20:31:45  *** charlieyou has joined #bitcoin-core-dev
2842018-09-18T20:37:03  *** charlieyou has quit IRC
2852018-09-18T20:39:39  *** charlieyou has joined #bitcoin-core-dev
2862018-09-18T20:41:25  <luke-jr> XD
2872018-09-18T20:44:45  *** tryphe has quit IRC
2882018-09-18T20:45:09  *** tryphe has joined #bitcoin-core-dev
2892018-09-18T20:46:57  *** charlieyou has quit IRC
2902018-09-18T20:47:41  *** Victorsueca has quit IRC
2912018-09-18T20:48:52  *** Victorsueca has joined #bitcoin-core-dev
2922018-09-18T20:49:28  <luke-jr> pushed my signed gitian sigs (3rd one)
2932018-09-18T20:50:27  <luke-jr> wumpus: I doubt the line should cause problems; I only noticed it because I was comparing
2942018-09-18T20:50:39  *** charlieyou has joined #bitcoin-core-dev
2952018-09-18T20:57:14  <ossifrage_> gmaxwell, I was just building a fresh bitcoin and noticed I still had a madvise(MADV_RANDOM) when mmapping read only data in leveldb, Is this worth a PR? It seem to reduces the number of pages fetched, but I don't have a good way to show if it actually helps
2962018-09-18T20:57:22  *** ossifrage_ is now known as ossifrage
2972018-09-18T20:58:04  *** Chris_Stewart_5 has quit IRC
2982018-09-18T20:58:15  <provoostenator> Updated man pages in #14263, anything else needed for a v0.15.2 tag?
2992018-09-18T20:58:17  <gribble> https://github.com/bitcoin/bitcoin/issues/14263 | Update manpages for 0.15.2 by Sjors · Pull Request #14263 · bitcoin/bitcoin · GitHub
3002018-09-18T20:58:22  <luke-jr> ossifrage: LevelDB changes should go upstream
3012018-09-18T20:58:31  <wumpus> ossifrage: I think doing optimization PRs only make sense if you can show it is a win
3022018-09-18T20:59:29  <wumpus> 0.16.3 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.16.3/
3032018-09-18T21:00:31  *** charlieyou has quit IRC
3042018-09-18T21:00:44  <ossifrage> wumpus, it does reduce the working set of pages pulled (at least initially) if people actually care about that (I don't)
3052018-09-18T21:01:06  <wumpus> ossifrage: I care about it if it helps performance!
3062018-09-18T21:01:47  <luke-jr> might be more of a system performance thing than bitcoind performance
3072018-09-18T21:01:59  <luke-jr> (which IMO is still worth getting it merged upstream)
3082018-09-18T21:02:48  <ossifrage> luke-jr, yeah it is a system level issue, which makes it much harder to test
3092018-09-18T21:03:23  <luke-jr> run Chromium on the test system :P
3102018-09-18T21:03:26  <luke-jr> on btrfs
3112018-09-18T21:03:28  <luke-jr> lol
3122018-09-18T21:03:49  <ossifrage> It depends heavily on how much system level memory pressure you have and how fast your IO is
3132018-09-18T21:06:43  <ossifrage> luke-jr, g++ seems triggers way more violent page eviction then chrome does. chrome is a slow burn, g++ is a punch in the face
3142018-09-18T21:06:55  *** jarthur_ has quit IRC
3152018-09-18T21:07:21  *** jarthur has joined #bitcoin-core-dev
3162018-09-18T21:07:46  <luke-jr> ossifrage: well, Chromium seems to rewrite its state text files every second or two, and does fsync on that
3172018-09-18T21:11:27  *** jarthur has quit IRC
3182018-09-18T21:13:05  <provoostenator> Is there a way to curse blocks, i.e. the opposite of "preciousblock"?
3192018-09-18T21:13:57  <sipa> invalidateblock
3202018-09-18T21:14:02  <provoostenator> Thanks
3212018-09-18T21:14:21  <sipa> (which is more than cursing, it marks the block as unconditionally invalid)
3222018-09-18T21:14:28  <sipa> the oppposite of invalidateblock is reconsiderblock
3232018-09-18T21:14:52  <midnightmagic> and of course there's the ancillary haveteawithblock
3242018-09-18T21:15:23  <jamesob> any idea when bitcoincore.org is going to be updated with 0.16.3's release notes?
3252018-09-18T21:17:05  <theymos> How upgraded are miners right now?
3262018-09-18T21:17:05  <wumpus> you people really don't have a second of patience do you
3272018-09-18T21:17:19  <midnightmagic> I do!
3282018-09-18T21:17:21  <midnightmagic> \o/
3292018-09-18T21:17:25  <luke-jr> lol
3302018-09-18T21:17:25  <jamesob> wumpus: sorry
3312018-09-18T21:18:24  <wumpus> jamesob: anyow you can find them here https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.16.3.md
3322018-09-18T21:20:25  <wumpus> theymos: some miners have already upgraded, don't know the % though
3332018-09-18T21:21:12  <theymos> Do you think that I mention in my bitcointalk.org announcement that a chain split is possible?
3342018-09-18T21:21:49  *** jarthur has joined #bitcoin-core-dev
3352018-09-18T21:22:58  <provoostenator> theymos: I don't think that's possible
3362018-09-18T21:23:41  <achow101> theymos: a chain split is not possible
3372018-09-18T21:23:42  <provoostenator> An invalid block could crash a node, but no node, patched or unpatched would accept such a block
3382018-09-18T21:23:57  <theymos> ok, thanks
3392018-09-18T21:24:36  <achow101> however, if you remove the assert that causes the crash, then you would accept an invalid block. but no release has that
3402018-09-18T21:28:58  <wumpus> bitcoincore.org and bitcoin.org PRs have both been merged, should be a matter of times before the sites update...
3412018-09-18T21:30:08  <gmaxwell> ossifrage: I should benchmark a reindex I guess.
3422018-09-18T21:37:17  *** jarthur has quit IRC
3432018-09-18T21:42:12  *** jarthur has joined #bitcoin-core-dev
3442018-09-18T21:44:00  *** jarthur has quit IRC
3452018-09-18T21:44:47  *** tryphe has quit IRC
3462018-09-18T21:45:13  *** tryphe has joined #bitcoin-core-dev
3472018-09-18T21:57:37  <wumpus> harding: for some reason, bitcoincore.org is not updating, travis shows build passing etc, any idea what coudl be wrong?
3482018-09-18T22:05:44  <wumpus> did anyone urge people to upgrade in #bitcoin yet?
3492018-09-18T22:08:39  <luke-jr> I announced Knots there, at least. echeveria changed the topic. don't see an actual Core ann tho
3502018-09-18T22:09:51  <wumpus> ok
3512018-09-18T22:15:22  <TD-Linux> gmaxwell, are there "standard" reindex benchmark settings?
3522018-09-18T22:16:28  <gmaxwell> TD-Linux: defaults, and dbcache=10000 (e.g. big enough that it never flushes) are the two cases that are most interesting.  It's useful to -connect=0  to stay offline while benchmarking.
3532018-09-18T22:18:03  *** opdenkamp has quit IRC
3542018-09-18T22:19:05  <molz> wumpus, i got my nodes updated hours ago, now i'm announcing this on several forums, thanks for all your work and don't let it stress you out
3552018-09-18T22:28:45  *** hebasto has quit IRC
3562018-09-18T22:33:07  *** fanquake has joined #bitcoin-core-dev
3572018-09-18T22:40:21  <TD-Linux> how does bitcoin decide how many threads to use? it seems to only be using 16 on my 32 core machine
3582018-09-18T22:42:42  *** niftynei has joined #bitcoin-core-dev
3592018-09-18T22:44:08  <fanquake> To set the number of script verification threads, we ultimately call std::thread::hardware_concurrency()
3602018-09-18T22:44:30  <luke-jr> TD-Linux: boost::thread::physical_concurrency()
3612018-09-18T22:44:46  <luke-jr> fanquake: only when compiling with an obsolete boost
3622018-09-18T22:44:48  *** tryphe has quit IRC
3632018-09-18T22:45:01  <luke-jr> TD-Linux: are you sure it has 32 cores? not 16 + HT?
3642018-09-18T22:45:14  <TD-Linux> 64 counting HT
3652018-09-18T22:45:16  *** tryphe has joined #bitcoin-core-dev
3662018-09-18T22:45:37  * luke-jr wonders what it uses on POWER9
3672018-09-18T22:45:53  <fanquake> luke-jr not since #10271 ?
3682018-09-18T22:45:55  <gribble> https://github.com/bitcoin/bitcoin/issues/10271 | Use std::thread::hardware_concurrency, instead of Boost, to determine available cores by fanquake · Pull Request #10271 · bitcoin/bitcoin · GitHub
3692018-09-18T22:46:18  <luke-jr> oh, didn't realise it changed recently; in any case, nobody should be running that yet
3702018-09-18T22:48:38  <luke-jr> TD-Linux: might be good to check if that PR fixes it for you
3712018-09-18T22:49:09  *** Guyver2 has quit IRC
3722018-09-18T22:50:00  <TD-Linux> indeed boost's cpuinfo parsing won't work on my /proc/cpuinfo
3732018-09-18T22:50:40  <TD-Linux> it looks for the number of unique (physical id, core id) pairs but that is not a unique identifier on my machine
3742018-09-18T22:51:47  <luke-jr> I don't even have physical/core ids in mine XD
3752018-09-18T22:53:32  <TD-Linux> yeah so I'm running master for my benchmark
3762018-09-18T22:53:41  <TD-Linux> boost would actually say I only have 8 cores with its logic
3772018-09-18T22:54:06  <TD-Linux> I'll file a boost bug but I guess I also need a libstdc++ bug
3782018-09-18T22:54:06  <luke-jr> >_<
3792018-09-18T22:55:14  <luke-jr> does get_nprocs() work?
3802018-09-18T22:55:56  <luke-jr> I guess that doesn't try to de-HT
3812018-09-18T22:56:58  <TD-Linux> yes it does (returns 64)
3822018-09-18T22:57:12  <luke-jr> looks like boost's cpuinfo parsing would fallback to get_nprocs on POWER9
3832018-09-18T22:57:45  * TD-Linux kind of doubts that trying to not count HT cores is worth the pain
3842018-09-18T23:00:10  <luke-jr> std::thread::hardware_concurrency seems to just wrap get_nprocs on GCC 7.3
3852018-09-18T23:04:06  *** Zenton has quit IRC
3862018-09-18T23:07:05  <gmaxwell> TD-Linux: bitcoin caps at 16 because we measured previously and found that performance stops improving there and gets worse.
3872018-09-18T23:30:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3882018-09-18T23:39:09  *** Murch has quit IRC
3892018-09-18T23:41:50  *** promag has quit IRC
3902018-09-18T23:44:51  *** tryphe has quit IRC
3912018-09-18T23:45:17  *** tryphe has joined #bitcoin-core-dev
3922018-09-18T23:58:17  *** AaronvanW has quit IRC
3932018-09-18T23:58:47  *** Chris_Stewart_5 has quit IRC