1 2018-10-16T00:14:13  *** Zenton has quit IRC
  2 2018-10-16T00:16:52  *** Zenton has joined #bitcoin-core-dev
  3 2018-10-16T00:17:37  *** dongcarl_ has joined #bitcoin-core-dev
  4 2018-10-16T00:18:54  *** promag has quit IRC
  5 2018-10-16T00:20:55  *** dongcarl_ has quit IRC
  6 2018-10-16T00:25:53  *** owowo has quit IRC
  7 2018-10-16T00:31:13  *** morcos has quit IRC
  8 2018-10-16T00:33:48  *** morcos has joined #bitcoin-core-dev
  9 2018-10-16T00:36:27  *** proletesseract has quit IRC
 10 2018-10-16T00:40:52  *** dongcarl_ has joined #bitcoin-core-dev
 11 2018-10-16T00:49:56  *** Victorsueca has quit IRC
 12 2018-10-16T00:51:04  *** Victorsueca has joined #bitcoin-core-dev
 13 2018-10-16T00:56:03  *** proletesseract has joined #bitcoin-core-dev
 14 2018-10-16T01:00:40  *** MrPaz has joined #bitcoin-core-dev
 15 2018-10-16T01:01:18  *** dongcarl_ has quit IRC
 16 2018-10-16T01:05:36  *** fanquake has joined #bitcoin-core-dev
 17 2018-10-16T01:12:12  *** fanquake has quit IRC
 18 2018-10-16T01:13:13  *** AaronvanW has quit IRC
 19 2018-10-16T01:13:34  *** AaronvanW has joined #bitcoin-core-dev
 20 2018-10-16T01:17:53  *** AaronvanW has quit IRC
 21 2018-10-16T01:22:40  *** drexl has quit IRC
 22 2018-10-16T01:23:44  *** str4d has quit IRC
 23 2018-10-16T01:31:47  *** Murch has quit IRC
 24 2018-10-16T01:39:01  *** rh0nj has quit IRC
 25 2018-10-16T01:40:07  *** rh0nj has joined #bitcoin-core-dev
 26 2018-10-16T01:47:59  *** dongcarl_ has joined #bitcoin-core-dev
 27 2018-10-16T01:49:32  *** dongcarl_ has quit IRC
 28 2018-10-16T02:24:01  *** Murch has joined #bitcoin-core-dev
 29 2018-10-16T02:31:42  *** tryphe has quit IRC
 30 2018-10-16T02:31:48  *** Murch has quit IRC
 31 2018-10-16T02:32:33  *** Krellan has quit IRC
 32 2018-10-16T02:34:11  *** intcat has quit IRC
 33 2018-10-16T02:35:21  *** intcat has joined #bitcoin-core-dev
 34 2018-10-16T02:39:16  *** bitconner has quit IRC
 35 2018-10-16T02:42:10  *** tryphe has joined #bitcoin-core-dev
 36 2018-10-16T02:46:25  *** leishman has joined #bitcoin-core-dev
 37 2018-10-16T02:47:55  *** hebasto has joined #bitcoin-core-dev
 38 2018-10-16T02:50:38  *** leishman has quit IRC
 39 2018-10-16T02:55:22  *** Murch has joined #bitcoin-core-dev
 40 2018-10-16T02:57:08  <kallewoof> How does bitcoin core track bip9 activation states? I have odd cases where a copied chain state will result in all bip9 soft forks turning up as "failed" rather than "activated". If I disable the timeout, they show up as 'started', but with 'possible: false'.
 41 2018-10-16T02:59:39  *** bitconner has joined #bitcoin-core-dev
 42 2018-10-16T03:00:15  *** arubi has quit IRC
 43 2018-10-16T03:01:41  <sipa> kallewoof: versionbits.cpp
 44 2018-10-16T03:02:07  *** schnerchi has joined #bitcoin-core-dev
 45 2018-10-16T03:02:14  *** luke-jr has quit IRC
 46 2018-10-16T03:02:26  *** luke-jr has joined #bitcoin-core-dev
 47 2018-10-16T03:02:57  <kallewoof> sipa: Yeah, I've been staring at that file for awhile now. Will stare some more.
 48 2018-10-16T03:03:35  <sipa> kallewoof: it should be implementing bip9 exactly
 49 2018-10-16T03:04:39  *** bitconner has quit IRC
 50 2018-10-16T03:04:54  *** arubi has joined #bitcoin-core-dev
 51 2018-10-16T03:05:01  <kallewoof> Yeah, I think I'm confused over what I'm confused over tbh. Will do some debugging.
 52 2018-10-16T03:05:14  *** schnerch_ has quit IRC
 53 2018-10-16T03:07:01  <achow101> kallewoof: those errors you mention sound like mtp isn't being computed correctly
 54 2018-10-16T03:07:45  <kallewoof> achow101: Huh.. I haven't really touched that part of the code.
 55 2018-10-16T03:09:38  <sipa> but everything should be recomputed at runtime
 56 2018-10-16T03:10:13  <achow101> kallewoof: sipa: is it possible that pruned chainstates cannot compute bip9 status?
 57 2018-10-16T03:10:30  <kallewoof> They only rely on block headers so I think they should be able to
 58 2018-10-16T03:11:45  <sipa> indeed
 59 2018-10-16T03:16:32  *** bitcoin-git has joined #bitcoin-core-dev
 60 2018-10-16T03:16:33  <bitcoin-git> [bitcoin] MeshCollider opened pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
 61 2018-10-16T03:16:33  *** bitcoin-git has left #bitcoin-core-dev
 62 2018-10-16T03:19:41  *** jack has joined #bitcoin-core-dev
 63 2018-10-16T03:20:57  *** jack has quit IRC
 64 2018-10-16T03:21:16  *** Murch has quit IRC
 65 2018-10-16T03:52:00  *** bitcoin-git has joined #bitcoin-core-dev
 66 2018-10-16T03:52:00  <bitcoin-git> [bitcoin] kallewoof opened pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
 67 2018-10-16T03:52:00  *** bitcoin-git has left #bitcoin-core-dev
 68 2018-10-16T04:00:40  *** schnerch_ has joined #bitcoin-core-dev
 69 2018-10-16T04:02:14  *** MrPaz has quit IRC
 70 2018-10-16T04:03:30  *** schnerchi has quit IRC
 71 2018-10-16T04:24:31  *** rex4539 has quit IRC
 72 2018-10-16T04:42:20  *** geezas has joined #bitcoin-core-dev
 73 2018-10-16T04:55:08  *** bitcoin-git has joined #bitcoin-core-dev
 74 2018-10-16T04:55:09  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a2cac787360...9bd3ff430b4e
 75 2018-10-16T04:55:09  <bitcoin-git> bitcoin/master 36323e2 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode...
 76 2018-10-16T04:55:10  <bitcoin-git> bitcoin/master 9bd3ff4 Wladimir J. van der Laan: Merge #14383: qt: Clean system tray icon menu for '-disablewallet' mode...
 77 2018-10-16T04:55:10  *** bitcoin-git has left #bitcoin-core-dev
 78 2018-10-16T04:56:14  *** bitcoin-git has joined #bitcoin-core-dev
 79 2018-10-16T04:56:14  <bitcoin-git> [bitcoin] laanwj closed pull request #14383: qt: Clean system tray icon menu for '-disablewallet' mode (master...20181003-disablewallet-systray) https://github.com/bitcoin/bitcoin/pull/14383
 80 2018-10-16T04:56:14  *** bitcoin-git has left #bitcoin-core-dev
 81 2018-10-16T04:59:58  *** bitconner has joined #bitcoin-core-dev
 82 2018-10-16T05:04:49  *** bitcoin-git has joined #bitcoin-core-dev
 83 2018-10-16T05:04:50  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bd3ff430b4e...2468471e1398
 84 2018-10-16T05:04:50  <bitcoin-git> bitcoin/master 7d173c4 Tim Ruffing: qt: Revert "Force TLS1.0+ for SSL connections"...
 85 2018-10-16T05:04:51  <bitcoin-git> bitcoin/master 2468471 Wladimir J. van der Laan: Merge #14403: qt: Revert "Force TLS1.0+ for SSL connections"...
 86 2018-10-16T05:04:51  *** bitcoin-git has left #bitcoin-core-dev
 87 2018-10-16T05:04:57  *** bitconner has quit IRC
 88 2018-10-16T05:05:50  *** bitcoin-git has joined #bitcoin-core-dev
 89 2018-10-16T05:05:50  <bitcoin-git> [bitcoin] laanwj closed pull request #14403: qt: Revert "Force TLS1.0+ for SSL connections" (master...sslv3) https://github.com/bitcoin/bitcoin/pull/14403
 90 2018-10-16T05:05:50  *** bitcoin-git has left #bitcoin-core-dev
 91 2018-10-16T05:10:56  <hebasto> wumpus: regarding #14370, should I add a modified unit test to the same PR or it should be another PR?
 92 2018-10-16T05:10:57  <gribble> https://github.com/bitcoin/bitcoin/issues/14370 | utils and libraries: Allow values quoting in config files by hebasto · Pull Request #14370 · bitcoin/bitcoin · GitHub
 93 2018-10-16T05:13:33  *** unholymachine has quit IRC
 94 2018-10-16T05:18:31  *** murrayn has joined #bitcoin-core-dev
 95 2018-10-16T05:18:32  *** murrayn has joined #bitcoin-core-dev
 96 2018-10-16T05:27:09  <meshcollider> wumpus: #14291 is also RTM I think
 97 2018-10-16T05:27:14  <gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
 98 2018-10-16T05:27:32  <meshcollider> and can we please add #14454 to high priority
 99 2018-10-16T05:27:34  <gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
100 2018-10-16T05:27:38  *** kallewoof has quit IRC
101 2018-10-16T05:28:16  <sipa> meshcollider: that's growing into a painful amount of code :)
102 2018-10-16T05:28:42  <wumpus> meshcollider: thanks, will have a look
103 2018-10-16T05:28:55  <sipa> will review in detail soon
104 2018-10-16T05:28:58  *** kallewoof has joined #bitcoin-core-dev
105 2018-10-16T05:29:07  <meshcollider> sipa: the segwit one?
106 2018-10-16T05:29:11  <sipa> and thanks for quickly addressing my comments so far
107 2018-10-16T05:29:13  <meshcollider> sipa: it still removes more than it adds ;)
108 2018-10-16T05:29:53  <meshcollider> thanks for giving comments so quickly
109 2018-10-16T05:31:48  <meshcollider> and 14303 removes all the duplicated pwallet->MarkDirty() calls which will tidy it up a bit more too
110 2018-10-16T05:33:46  <wumpus> habasto: would rather close 14370, don't think it is a necessary change
111 2018-10-16T05:34:37  <hebasto> wumpus: thanks for your quick review; I'll think about it.
112 2018-10-16T05:35:03  <wumpus> if something can be solved by better documentation, please work on documentation!
113 2018-10-16T05:35:12  <wumpus> don't change the code instead
114 2018-10-16T05:36:48  *** bitcoin-git has joined #bitcoin-core-dev
115 2018-10-16T05:36:48  <bitcoin-git> [bitcoin] MeshCollider opened pull request #14494: Error if # is used in rpcpassword in conf (master...201810_hash_in_rpcpassword_error) https://github.com/bitcoin/bitcoin/pull/14494
116 2018-10-16T05:36:48  *** bitcoin-git has left #bitcoin-core-dev
117 2018-10-16T05:39:01  *** rh0nj has quit IRC
118 2018-10-16T05:41:43  <wumpus> habasto: huh so does #13143 provide an actual use-case for quoting functionality?
119 2018-10-16T05:41:44  <gribble> https://github.com/bitcoin/bitcoin/issues/13143 | `#` cannot be used rpcpassword (or bitcoin.conf in general) · Issue #13143 · bitcoin/bitcoin · GitHub
120 2018-10-16T05:42:08  *** rh0nj has joined #bitcoin-core-dev
121 2018-10-16T05:42:39  <meshcollider> wumpus: I would say it makes it even more confusing lol
122 2018-10-16T05:43:00  <wumpus> hehe
123 2018-10-16T05:43:25  <wumpus> well I remember because windows .ini format has no way to insert #'s, that's also why I know they have no quoting...
124 2018-10-16T05:44:07  <wumpus> all this is kind of terrible edge-case stuff
125 2018-10-16T05:45:18  <meshcollider> I agree
126 2018-10-16T05:46:17  <meshcollider> we should just disallow same-line comments and only exclude lines from the conf if they *start* with a #
127 2018-10-16T05:47:27  <wumpus> yes, I think that's a fair option, I remember seeing that in other software (but don't remember which one, right now); though,also a breaking change
128 2018-10-16T05:47:54  <wumpus> people might already be using # to comment their .ini files lines... so would create the *opposite* issue :(
129 2018-10-16T05:48:28  <meshcollider> yeah I think its too hard to change now
130 2018-10-16T05:48:29  <wumpus> anyhow I think 14494 is good, just don't have "illegal hash character" in the error message that's terrible :-)
131 2018-10-16T05:48:45  <meshcollider> haha ok what should I change it to
132 2018-10-16T05:49:22  <wumpus> well what I said in the PR, it's at most ambigious, it's rejected because it's probably a mistake
133 2018-10-16T05:49:35  <meshcollider> " do not use hash characters in rpcpassword" ?
134 2018-10-16T05:50:14  <wumpus> if it's an actual comment it is actually okay, in principle
135 2018-10-16T05:50:35  <wumpus> well a friendlier message, not something about 'do not use' but just explain to the user why this is a problem
136 2018-10-16T05:50:38  <meshcollider> ok
137 2018-10-16T05:50:54  <wumpus> illegal hash characer sounds like the cops will show up any time :)
138 2018-10-16T05:51:16  <kallewoof> wumpus: I think iptables will happily try to parse # chars unless they are the first on the line
139 2018-10-16T05:51:17  *** proletesseract has quit IRC
140 2018-10-16T05:51:24  <meshcollider> "using hash in rpcpassword can be ambiguous and should be avoided"
141 2018-10-16T05:52:01  <wumpus> yes, that would be better
142 2018-10-16T05:52:16  <wumpus> or maybe don't call it hash but simply mention '#'
143 2018-10-16T05:53:10  <wumpus> that's more direct for non-english speaking people
144 2018-10-16T05:53:52  *** proletesseract has joined #bitcoin-core-dev
145 2018-10-16T05:54:21  <hebasto> ^
146 2018-10-16T05:54:30  <meshcollider> true, and even english speakers sometimes call it pound or octothorpe
147 2018-10-16T05:54:47  *** proletesseract has quit IRC
148 2018-10-16T05:58:02  <sipa> meshcollider: probably only antipodians
149 2018-10-16T05:59:06  <meshcollider> sipa: lol
150 2018-10-16T05:59:24  <meshcollider> sipa: achow used "pound", so it must be you all who are upside down
151 2018-10-16T06:01:26  *** proletesseract has joined #bitcoin-core-dev
152 2018-10-16T06:06:00  *** proletesseract has quit IRC
153 2018-10-16T06:18:22  <luke-jr> meshcollider: but if we can't hash over RPC, how will people mine? /s
154 2018-10-16T06:19:16  <sipa> clearly we need to rename it 'pounders'
155 2018-10-16T06:21:10  <luke-jr> sipa: also, what are these 'podes' that people are protesting? :p
156 2018-10-16T06:29:32  <karelb> I am trying to run my fork of bitcoind on travis.... and travis stops with this
157 2018-10-16T06:29:42  <karelb> src/threadinterrupt.cpp:25: mut  ==> must, mutt, moot
158 2018-10-16T06:29:43  <karelb> Warning: codespell identified likely spelling errors
159 2018-10-16T06:29:50  <karelb> failure generated from test/lint/lint-spelling.sh
160 2018-10-16T06:29:55  *** ExtraCrispy_ has quit IRC
161 2018-10-16T06:29:56  <karelb> .....ummmmm, ok?
162 2018-10-16T06:30:32  <karelb> I did no change in threadinterrupt, and that "mut" is just some mutex
163 2018-10-16T06:32:17  *** ExtraCrispy_ has joined #bitcoin-core-dev
164 2018-10-16T06:39:15  <karelb> well whatever, one commit that renamed "mut" to "mutex" fixed that, I just wonder why I needed to do that...
165 2018-10-16T06:40:18  <gwillen> karelb: your travis instance is stupid
166 2018-10-16T06:40:24  <gwillen> if you make it less stupid you will have fewer problems
167 2018-10-16T06:40:38  <gwillen> it is trying to spell-correct your code, and doing it moronically
168 2018-10-16T06:40:43  <karelb> :D
169 2018-10-16T06:40:43  <gwillen> and seems to be set to warnings-as-errors.
170 2018-10-16T06:40:56  <karelb> I use travis-ci.org
171 2018-10-16T06:41:02  <gwillen> well, apparently they are stupid
172 2018-10-16T06:41:11  <gwillen> but I imagine there is an option not to make codespell warnings errors
173 2018-10-16T06:41:14  <karelb> the same config as bitcoin core
174 2018-10-16T06:41:15  <gwillen> which they absolutely should not be
175 2018-10-16T06:41:18  <gwillen> oh, hm
176 2018-10-16T06:41:21  <gwillen> I mean, seemingly not
177 2018-10-16T06:42:36  <karelb> well let's see what happens when I make a PR, if that `mut` stuff is still there
178 2018-10-16T06:52:06  *** geezas has quit IRC
179 2018-10-16T06:54:29  *** proletesseract has joined #bitcoin-core-dev
180 2018-10-16T07:00:50  <meshcollider> sipa: re private keys, if youve imported the private key then the danger isnt as prominent is it
181 2018-10-16T07:06:42  *** Krellan has joined #bitcoin-core-dev
182 2018-10-16T07:07:35  *** Krellan has quit IRC
183 2018-10-16T07:07:52  *** setpill has joined #bitcoin-core-dev
184 2018-10-16T07:08:31  <meshcollider> because even if they send to the key directly, you have the privkey
185 2018-10-16T07:11:04  *** Krellan has joined #bitcoin-core-dev
186 2018-10-16T07:23:33  *** JackH has quit IRC
187 2018-10-16T07:24:13  *** DougieBot5000_ is now known as DougieBot5000
188 2018-10-16T07:25:04  *** romanz has quit IRC
189 2018-10-16T07:25:39  *** romanz has joined #bitcoin-core-dev
190 2018-10-16T07:31:30  *** e4xit has joined #bitcoin-core-dev
191 2018-10-16T07:32:19  *** hebasto has quit IRC
192 2018-10-16T07:33:40  *** hebasto has joined #bitcoin-core-dev
193 2018-10-16T07:36:57  *** jungly has joined #bitcoin-core-dev
194 2018-10-16T07:44:59  *** bitconner has joined #bitcoin-core-dev
195 2018-10-16T07:49:33  *** bitconner has quit IRC
196 2018-10-16T08:18:15  *** promag has joined #bitcoin-core-dev
197 2018-10-16T08:26:36  *** Empact_ has quit IRC
198 2018-10-16T08:30:00  *** murrayn_ has joined #bitcoin-core-dev
199 2018-10-16T08:33:18  *** murrayn has quit IRC
200 2018-10-16T08:35:15  *** luke-jr has quit IRC
201 2018-10-16T08:35:24  *** luke-jr has joined #bitcoin-core-dev
202 2018-10-16T08:35:45  *** murrayn_ has quit IRC
203 2018-10-16T08:36:06  *** proletesseract has quit IRC
204 2018-10-16T08:41:04  *** luke-jr has quit IRC
205 2018-10-16T08:41:12  *** luke-jr has joined #bitcoin-core-dev
206 2018-10-16T08:49:11  <wumpus> karelb: lol that's stupid
207 2018-10-16T08:50:44  <wumpus> please don't tell me that stupid spelling check is mandatory in travis now
208 2018-10-16T08:50:56  <karelb> wumpus: maybe it's some misconfiguration... I don't really want to deal with it so I made a commit that I will remove before doing PR
209 2018-10-16T08:51:11  <karelb> that commit just renamed mut to mutex
210 2018-10-16T08:51:12  <wumpus> AHH apparently it was changed to fail in e413c2ddd1240d7bacd1837fa49d25781fe6e5fa
211 2018-10-16T08:51:38  *** Zenton has quit IRC
212 2018-10-16T08:52:13  <wumpus> yes I can imagine...
213 2018-10-16T08:53:06  <wumpus> i've tried, in vain, to prevent all kinds of silly lints from being merged
214 2018-10-16T08:54:22  <karelb> :D
215 2018-10-16T08:54:39  <karelb> I wonder why is my fork failing but not bitcoin master
216 2018-10-16T08:54:52  <karelb> but I don't wonder *that much*
217 2018-10-16T08:55:18  *** Zenton has joined #bitcoin-core-dev
218 2018-10-16T08:58:12  *** rex4539 has joined #bitcoin-core-dev
219 2018-10-16T08:59:38  <wumpus> maybe... it only runs on PRs?
220 2018-10-16T09:01:48  *** bralyclo_ has joined #bitcoin-core-dev
221 2018-10-16T09:02:13  <wumpus> well you could always rename it 'mutt' or 'moot', i'm sure that's an improvement...
222 2018-10-16T09:02:42  <karelb> 'mutex' seems to work, although 'mutt' has a ring to it
223 2018-10-16T09:03:15  *** nickler has joined #bitcoin-core-dev
224 2018-10-16T09:03:50  <wumpus> i'm not sure whether this constitutes a 'variable names need to be valid english words' policy
225 2018-10-16T09:05:14  *** bralyclow has quit IRC
226 2018-10-16T09:07:20  *** murrayn has joined #bitcoin-core-dev
227 2018-10-16T09:07:20  *** murrayn has joined #bitcoin-core-dev
228 2018-10-16T09:08:43  <promag> wumpus: from the PR discussion looks like that change slipped?
229 2018-10-16T09:09:23  *** timothy has joined #bitcoin-core-dev
230 2018-10-16T09:10:33  <promag> maybe the reason is because nobody checks the warnings
231 2018-10-16T09:11:56  *** ken2812221_ has joined #bitcoin-core-dev
232 2018-10-16T09:13:59  <luke-jr> 'variable names need to be valid english words' sounds like a stupid policy..
233 2018-10-16T09:22:45  <wumpus> luke-jr: no disagreement from me, i'm sure i've protested in the PR that added this linter, but meh i don't have the energy to fight this
234 2018-10-16T09:23:48  *** Victorsueca has quit IRC
235 2018-10-16T09:23:54  * wumpus wants to add a linter that deletes all linters
236 2018-10-16T09:24:06  <luke-jr> :P
237 2018-10-16T09:26:03  <wumpus> soo enough about that shit, are there any serious PRs I should pay attention to?
238 2018-10-16T09:26:57  <luke-jr> dunno, barely have time to rebase my own stuff :/
239 2018-10-16T09:26:57  *** Krellan has quit IRC
240 2018-10-16T09:27:02  *** Victorsueca has joined #bitcoin-core-dev
241 2018-10-16T09:28:36  *** Krellan has joined #bitcoin-core-dev
242 2018-10-16T09:28:44  <luke-jr> the downgrading warning in 0.17 relnotes is confusing; why is it talking about 0.15?
243 2018-10-16T09:29:15  <meshcollider> luke-jr: because that's the version at which it changed isn't it
244 2018-10-16T09:29:57  <meshcollider> but yeah its not worded well
245 2018-10-16T09:30:04  <luke-jr> dunno, 0.16 didn't mention it
246 2018-10-16T09:30:13  <luke-jr> I thought we had a change in 0.17 too?
247 2018-10-16T09:30:14  <wumpus> I *guess* it's when you want to downgrade from 0.17 to 0.15?
248 2018-10-16T09:30:30  <meshcollider> "Wallets created in 0.16 and later are not compatible with versions prior to 0.16 and will not work if you try to use newly created wallets in older versions. Existing wallets that were created with older versions are not affected by this."
249 2018-10-16T09:30:53  <wumpus> it's a bit late to discuss 0.17 release notes, now
250 2018-10-16T09:31:10  <meshcollider> it looks like its just been copy+pasted from 0.15, oh well
251 2018-10-16T09:31:45  <luke-jr> wumpus: that's not what it says though :/
252 2018-10-16T09:31:46  <luke-jr> yes, just noticed
253 2018-10-16T09:31:51  <wumpus> it probably has
254 2018-10-16T09:32:13  <wumpus> the upgrading/downgrading part tends to be copy-pasted between releases because it tends to stay relevant
255 2018-10-16T09:32:46  <wumpus> at some point it can be removed because no one is going to downgrade to 3 major versions back, but still
256 2018-10-16T09:33:18  <wumpus> would be good to have close scrutiny of the release notes before a release
257 2018-10-16T09:33:33  <promag> wumpus: I'm depending on #14291 for the multiwallet support in the UI
258 2018-10-16T09:33:37  <gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
259 2018-10-16T09:33:55  <wumpus> promag: yeah have that one merged locally for testing
260 2018-10-16T09:34:02  <promag> wumpus: nice
261 2018-10-16T09:41:22  <meshcollider> sipa: for the descriptors PR, what if we don't even import the public keys? Why not just import the private keys, otherwise just import the scriptPubKey only as watch only
262 2018-10-16T09:41:59  *** ken2812221 has quit IRC
263 2018-10-16T09:45:31  *** ken2812221 has joined #bitcoin-core-dev
264 2018-10-16T10:06:41  *** AaronvanW has joined #bitcoin-core-dev
265 2018-10-16T10:21:16  *** Deacyde has quit IRC
266 2018-10-16T10:34:54  *** rex4539 has quit IRC
267 2018-10-16T10:35:40  <promag> sipa: meshcollider: please also see #14303
268 2018-10-16T10:35:42  <gribble> https://github.com/bitcoin/bitcoin/issues/14303 | rpc: Early call once CWallet::MarkDirty in import calls by promag · Pull Request #14303 · bitcoin/bitcoin · GitHub
269 2018-10-16T10:36:35  <meshcollider> promag: Already concept ACK'ed it ;) mentioned it above, its a nice cleanup
270 2018-10-16T10:36:56  *** kau has joined #bitcoin-core-dev
271 2018-10-16T10:37:40  *** esotericnonsense has quit IRC
272 2018-10-16T10:37:58  <promag> ken2812221: how do you build and run tests on windows? do you use wsl and depends?
273 2018-10-16T10:41:11  *** esotericnonsense has joined #bitcoin-core-dev
274 2018-10-16T10:45:04  *** ken2812221__ has joined #bitcoin-core-dev
275 2018-10-16T10:45:20  *** ken2812221_ has quit IRC
276 2018-10-16T10:46:59  <ken2812221__> promag: I use both MSVC and virtual machine to build it. The IO on WSL is extremely slow.
277 2018-10-16T10:47:27  <promag> ken2812221__: right, it is
278 2018-10-16T10:48:09  <promag> ken2812221__: is there a guide or something so I can easily setup the same here?
279 2018-10-16T10:51:37  <ken2812221__> Copy bitcoin-cli.exe and bitcoind.exe into src folder. Modify and copy test\config.ini.in to test\config.ini. Then you can run python test\functional\test_runner.py --force.
280 2018-10-16T10:57:01  *** hebasto has quit IRC
281 2018-10-16T10:57:23  *** hebasto has joined #bitcoin-core-dev
282 2018-10-16T10:57:40  <promag> I suspect #14299 will create more noise
283 2018-10-16T10:57:41  <gribble> https://github.com/bitcoin/bitcoin/issues/14299 | Deprecate wallet `generate` RPC method · Issue #14299 · bitcoin/bitcoin · GitHub
284 2018-10-16T11:06:25  *** belcher_ has joined #bitcoin-core-dev
285 2018-10-16T11:09:41  *** belcher has quit IRC
286 2018-10-16T11:10:18  <wumpus> I don't know, I think telling people to use generatetoaddress is fine
287 2018-10-16T11:10:39  <wumpus> the mining functionality in bitcoin core is not exactly used a lot
288 2018-10-16T11:12:24  <wumpus> seperating the mining from the wallet always made sense, not sure why it hasn't been done before
289 2018-10-16T11:14:56  *** ken2812221__ has quit IRC
290 2018-10-16T11:16:38  <promag> yeap, I also think the ones using it can easily change
291 2018-10-16T11:22:23  *** kau has quit IRC
292 2018-10-16T11:24:26  <promag> wumpus: does my response clarifies your concern https://github.com/bitcoin/bitcoin/pull/14291/files#r225491304 ?
293 2018-10-16T11:26:00  <wumpus> promag: i'm personally scared of that behavior, but if others think it's ok, i'll just go along...
294 2018-10-16T11:26:44  <wumpus> promag: you're right it only scans the files at recursion depth=0 for the btree signature, though it still *nests* into all the directories nevertheless
295 2018-10-16T11:26:51  <promag> wumpus: do you think it should do that only if walletdir != datadir?
296 2018-10-16T11:28:00  <wumpus> that would, to me, seem like the most straightforward way to prevent this; then give the user a clear explanation *why* it won't work and what they can do to make it work
297 2018-10-16T11:29:15  <wumpus> one specific concern: opening and closing the .lock file will nix the datadir lock, at least on some OSes
298 2018-10-16T11:30:17  <promag> hmm, skip that filename then?
299 2018-10-16T11:30:21  <promag> ryanofsky: ^
300 2018-10-16T11:30:31  <wumpus> that seems *extremely* fragile
301 2018-10-16T11:31:54  <wumpus> maybe this brings a valid problem to light: there's just too many ways to organize the data directory with regard to wallets, all need to be handled, and tested
302 2018-10-16T11:32:06  <wumpus> in any case, I'd prefer if the RPC simply failed in that case
303 2018-10-16T11:33:07  <promag> but do you agree on the concept?
304 2018-10-16T11:37:59  <wumpus> in the case where there is a separate wallet directory, certainly!
305 2018-10-16T11:38:48  *** bitcoin-git has joined #bitcoin-core-dev
306 2018-10-16T11:38:48  <bitcoin-git> [bitcoin] practicalswift opened pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
307 2018-10-16T11:38:48  *** bitcoin-git has left #bitcoin-core-dev
308 2018-10-16T11:42:45  <promag> wumpus: I'll push a commit with that change to see what others say
309 2018-10-16T11:51:55  *** bitcoin-git has joined #bitcoin-core-dev
310 2018-10-16T11:51:56  <bitcoin-git> [bitcoin] practicalswift opened pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
311 2018-10-16T11:51:56  *** bitcoin-git has left #bitcoin-core-dev
312 2018-10-16T12:05:07  <promag> ken2812221: just say build_msvc/README.md
313 2018-10-16T12:05:19  <promag> s/say/saw :P
314 2018-10-16T12:07:38  <promag> assign #14495 to MarcoFalke?
315 2018-10-16T12:07:39  <gribble> https://github.com/bitcoin/bitcoin/issues/14495 | build: Warn (dont fail!) on spelling errors by practicalswift · Pull Request #14495 · bitcoin/bitcoin · GitHub
316 2018-10-16T12:11:13  *** promag has quit IRC
317 2018-10-16T12:30:35  *** bitconner has joined #bitcoin-core-dev
318 2018-10-16T12:34:59  *** bitconner has quit IRC
319 2018-10-16T12:37:00  *** shesek has joined #bitcoin-core-dev
320 2018-10-16T12:37:00  *** shesek has quit IRC
321 2018-10-16T12:37:00  *** shesek has joined #bitcoin-core-dev
322 2018-10-16T12:40:20  *** drexl has joined #bitcoin-core-dev
323 2018-10-16T12:42:01  *** rh0nj has quit IRC
324 2018-10-16T12:43:07  *** rh0nj has joined #bitcoin-core-dev
325 2018-10-16T13:01:11  *** dcousens has joined #bitcoin-core-dev
326 2018-10-16T13:02:03  *** dcousens has quit IRC
327 2018-10-16T13:03:04  *** AaronvanW has quit IRC
328 2018-10-16T13:04:31  *** timothy has quit IRC
329 2018-10-16T13:05:50  *** Jmabsd has joined #bitcoin-core-dev
330 2018-10-16T13:05:57  *** timothy has joined #bitcoin-core-dev
331 2018-10-16T13:06:27  <Jmabsd> sorry for disturbing - can you give me some reference where the hash in a P2WSH pubkey script is validated or/and generated?  i like to understand if it's single or dual iteration SHA256 and how the code looks.
332 2018-10-16T13:09:54  *** echonaut has joined #bitcoin-core-dev
333 2018-10-16T13:10:30  *** echonaut13 has quit IRC
334 2018-10-16T13:15:44  *** promag has joined #bitcoin-core-dev
335 2018-10-16T13:16:41  *** Guyver2 has joined #bitcoin-core-dev
336 2018-10-16T13:23:52  *** AaronvanW has joined #bitcoin-core-dev
337 2018-10-16T13:42:20  *** Deinogalerix21 has joined #bitcoin-core-dev
338 2018-10-16T13:51:54  *** Deinogalerix21 has quit IRC
339 2018-10-16T13:59:15  <karelb> ad the codespell issue - it seems I have branched master *before* the codespell version was fixed, so that's why it got updated now and shouted at me
340 2018-10-16T13:59:36  <karelb> which explains that
341 2018-10-16T14:04:07  *** zivl has quit IRC
342 2018-10-16T14:07:13  *** Krellan has quit IRC
343 2018-10-16T14:07:54  <promag> wumpus: pushed https://github.com/bitcoin/bitcoin/pull/14291/commits/4702191778eaa23152fccd4d219a649ce712e79c
344 2018-10-16T14:08:24  *** Krellan has joined #bitcoin-core-dev
345 2018-10-16T14:11:26  *** promag has quit IRC
346 2018-10-16T14:35:03  *** leishman has joined #bitcoin-core-dev
347 2018-10-16T14:35:46  *** leishman has quit IRC
348 2018-10-16T14:36:34  *** bitconner has joined #bitcoin-core-dev
349 2018-10-16T14:36:40  *** leishman has joined #bitcoin-core-dev
350 2018-10-16T14:38:10  *** promag has joined #bitcoin-core-dev
351 2018-10-16T14:39:53  *** grubles has quit IRC
352 2018-10-16T14:41:16  *** bitconner has quit IRC
353 2018-10-16T14:41:39  <phantomcircuit> wumpus, can you look at #14335
354 2018-10-16T14:41:40  <gribble> https://github.com/bitcoin/bitcoin/issues/14335 | net: refactor: cleanup ThreadSocketHandler by pstratem · Pull Request #14335 · bitcoin/bitcoin · GitHub
355 2018-10-16T14:52:18  *** michaelsdunn1 has joined #bitcoin-core-dev
356 2018-10-16T14:55:54  *** nullptr| has quit IRC
357 2018-10-16T14:56:56  *** nullptr| has joined #bitcoin-core-dev
358 2018-10-16T15:09:41  *** esotericnonsense has quit IRC
359 2018-10-16T15:11:14  *** esotericnonsense has joined #bitcoin-core-dev
360 2018-10-16T15:13:24  <wumpus> phantomcircuit: sure
361 2018-10-16T15:13:38  *** bergz has joined #bitcoin-core-dev
362 2018-10-16T15:14:46  *** bitcoin-git has joined #bitcoin-core-dev
363 2018-10-16T15:14:46  <bitcoin-git> [bitcoin] DesWurstes closed pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
364 2018-10-16T15:14:46  *** bitcoin-git has left #bitcoin-core-dev
365 2018-10-16T15:21:10  *** bitcoin-git has joined #bitcoin-core-dev
366 2018-10-16T15:21:10  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2468471e1398...23419e4c4939
367 2018-10-16T15:21:11  <bitcoin-git> bitcoin/master edb5350 Patrick Strateman: Move NotifyNumConnectionsChanged logic to private method.
368 2018-10-16T15:21:11  <bitcoin-git> bitcoin/master 7479b63 Patrick Strateman: Move DisconnectNodes logic to private method.
369 2018-10-16T15:21:12  <bitcoin-git> bitcoin/master 2af9cff Patrick Strateman: Move InactivityCheck logic to private method.
370 2018-10-16T15:21:12  *** bitcoin-git has left #bitcoin-core-dev
371 2018-10-16T15:21:43  *** shesek has quit IRC
372 2018-10-16T15:22:28  *** bitcoin-git has joined #bitcoin-core-dev
373 2018-10-16T15:22:28  <bitcoin-git> [bitcoin] laanwj closed pull request #14335: net: refactor: cleanup ThreadSocketHandler (master...2018-09-24-thread-handler-cleanup) https://github.com/bitcoin/bitcoin/pull/14335
374 2018-10-16T15:22:28  *** bitcoin-git has left #bitcoin-core-dev
375 2018-10-16T15:24:28  <phantomcircuit> wumpus, ty
376 2018-10-16T15:40:43  *** arubi has quit IRC
377 2018-10-16T15:44:30  *** JackH has joined #bitcoin-core-dev
378 2018-10-16T15:44:51  *** esotericnonsense has quit IRC
379 2018-10-16T15:45:23  *** arubi has joined #bitcoin-core-dev
380 2018-10-16T15:46:45  *** promag has quit IRC
381 2018-10-16T15:46:57  *** intcat has quit IRC
382 2018-10-16T15:47:06  *** esotericnonsense has joined #bitcoin-core-dev
383 2018-10-16T15:48:32  *** iphelix_ has quit IRC
384 2018-10-16T15:49:29  *** grubles has joined #bitcoin-core-dev
385 2018-10-16T15:50:39  *** intcat has joined #bitcoin-core-dev
386 2018-10-16T15:53:38  *** iphelix has joined #bitcoin-core-dev
387 2018-10-16T15:54:01  *** iphelix is now known as Guest3720
388 2018-10-16T15:55:36  *** Guest3720 has quit IRC
389 2018-10-16T15:59:10  *** justanotheruser has quit IRC
390 2018-10-16T16:00:35  *** Murch has joined #bitcoin-core-dev
391 2018-10-16T16:01:30  *** esotericnonsense has quit IRC
392 2018-10-16T16:03:15  *** iphelix_ has joined #bitcoin-core-dev
393 2018-10-16T16:04:42  *** esotericnonsense has joined #bitcoin-core-dev
394 2018-10-16T16:04:51  *** Krellan has quit IRC
395 2018-10-16T16:04:56  *** leishman has quit IRC
396 2018-10-16T16:05:29  *** leishman has joined #bitcoin-core-dev
397 2018-10-16T16:06:04  *** setpill has quit IRC
398 2018-10-16T16:06:43  *** esotericnonsense has quit IRC
399 2018-10-16T16:10:01  *** leishman has quit IRC
400 2018-10-16T16:10:16  *** leishman has joined #bitcoin-core-dev
401 2018-10-16T16:19:45  *** singleSole_ has joined #bitcoin-core-dev
402 2018-10-16T16:20:06  <singleSole_> hi
403 2018-10-16T16:29:14  *** esotericnonsense has joined #bitcoin-core-dev
404 2018-10-16T16:31:13  *** singleSole_ has quit IRC
405 2018-10-16T16:33:59  *** promag has joined #bitcoin-core-dev
406 2018-10-16T16:35:18  *** owowo has joined #bitcoin-core-dev
407 2018-10-16T16:35:28  *** esotericnonsens_ has joined #bitcoin-core-dev
408 2018-10-16T16:35:33  *** esotericnonsense has quit IRC
409 2018-10-16T16:35:42  *** esotericnonsens_ is now known as esotericnonsense
410 2018-10-16T16:38:32  *** Krellan has joined #bitcoin-core-dev
411 2018-10-16T16:40:16  *** jungly has quit IRC
412 2018-10-16T16:41:04  *** sfhi has joined #bitcoin-core-dev
413 2018-10-16T16:49:30  *** jarthur has joined #bitcoin-core-dev
414 2018-10-16T16:52:19  *** bergz has quit IRC
415 2018-10-16T17:05:16  *** sfhi has quit IRC
416 2018-10-16T17:16:30  *** promag has quit IRC
417 2018-10-16T17:18:52  *** timothy has quit IRC
418 2018-10-16T17:48:44  *** bralyclow has joined #bitcoin-core-dev
419 2018-10-16T17:49:50  *** bralyclow has joined #bitcoin-core-dev
420 2018-10-16T17:51:57  *** bralyclo_ has quit IRC
421 2018-10-16T18:00:35  *** promag has joined #bitcoin-core-dev
422 2018-10-16T18:01:47  *** Zenton has quit IRC
423 2018-10-16T18:04:20  *** Zenton has joined #bitcoin-core-dev
424 2018-10-16T18:07:06  *** bralyclo_ has joined #bitcoin-core-dev
425 2018-10-16T18:07:32  *** bralyclo_ has joined #bitcoin-core-dev
426 2018-10-16T18:08:37  *** bralyclo_ has quit IRC
427 2018-10-16T18:09:01  *** bralyclo_ has joined #bitcoin-core-dev
428 2018-10-16T18:09:32  *** luke-jr has quit IRC
429 2018-10-16T18:09:50  *** luke-jr has joined #bitcoin-core-dev
430 2018-10-16T18:10:03  *** bralyclow has quit IRC
431 2018-10-16T18:30:49  *** bergz has joined #bitcoin-core-dev
432 2018-10-16T18:31:26  *** wumpus has quit IRC
433 2018-10-16T18:31:39  *** MrPaz has joined #bitcoin-core-dev
434 2018-10-16T18:38:29  *** Krellan has quit IRC
435 2018-10-16T19:01:54  *** bitconner has joined #bitcoin-core-dev
436 2018-10-16T19:18:04  *** bralyclo_ has quit IRC
437 2018-10-16T19:18:26  *** bralyclow has joined #bitcoin-core-dev
438 2018-10-16T19:21:18  *** promag has quit IRC
439 2018-10-16T19:40:00  *** bralyclow2 has joined #bitcoin-core-dev
440 2018-10-16T19:47:00  *** michaelsdunn1 has quit IRC
441 2018-10-16T19:48:23  *** bralyclow2 has quit IRC
442 2018-10-16T19:48:45  *** bralyclow2 has joined #bitcoin-core-dev
443 2018-10-16T19:49:03  *** bralyclow2 has quit IRC
444 2018-10-16T19:49:38  *** bralyclow2 has joined #bitcoin-core-dev
445 2018-10-16T19:50:08  *** promag has joined #bitcoin-core-dev
446 2018-10-16T19:51:16  *** bralyclow2 has quit IRC
447 2018-10-16T19:51:30  *** michaelsdunn1 has joined #bitcoin-core-dev
448 2018-10-16T19:51:30  *** michaelsdunn1 has quit IRC
449 2018-10-16T19:51:30  *** michaelsdunn1 has joined #bitcoin-core-dev
450 2018-10-16T19:53:50  *** Krellan has joined #bitcoin-core-dev
451 2018-10-16T19:59:48  *** jarthur has quit IRC
452 2018-10-16T20:08:17  *** michaelsdunn1 has quit IRC
453 2018-10-16T20:11:20  *** michaelsdunn1 has joined #bitcoin-core-dev
454 2018-10-16T20:23:07  *** Aaronvan_ has joined #bitcoin-core-dev
455 2018-10-16T20:26:11  *** AaronvanW has quit IRC
456 2018-10-16T20:27:41  *** Squidicuz has joined #bitcoin-core-dev
457 2018-10-16T20:31:54  *** proletesseract has joined #bitcoin-core-dev
458 2018-10-16T20:36:16  *** Murch has quit IRC
459 2018-10-16T20:41:08  *** lukedashjr has joined #bitcoin-core-dev
460 2018-10-16T20:45:26  *** luke-jr has quit IRC
461 2018-10-16T20:45:51  *** lukedashjr is now known as luke-jr
462 2018-10-16T20:48:09  <hebasto> promag: regarding "breaking change" in #14494. why?
463 2018-10-16T20:48:10  <gribble> https://github.com/bitcoin/bitcoin/issues/14494 | Error if # is used in rpcpassword in conf by MeshCollider · Pull Request #14494 · bitcoin/bitcoin · GitHub
464 2018-10-16T20:49:45  *** dviola has joined #bitcoin-core-dev
465 2018-10-16T20:58:23  *** promag has quit IRC
466 2018-10-16T21:03:00  *** dviola has quit IRC
467 2018-10-16T21:10:20  *** cryptapus has joined #bitcoin-core-dev
468 2018-10-16T21:10:20  *** cryptapus has quit IRC
469 2018-10-16T21:10:20  *** cryptapus has joined #bitcoin-core-dev
470 2018-10-16T21:11:18  *** jamesob has joined #bitcoin-core-dev
471 2018-10-16T21:15:52  *** Aaronvan_ has quit IRC
472 2018-10-16T21:16:59  *** jarthur has joined #bitcoin-core-dev
473 2018-10-16T21:18:03  *** bitconner has quit IRC
474 2018-10-16T21:18:19  *** bitcoin-git has joined #bitcoin-core-dev
475 2018-10-16T21:18:19  <bitcoin-git> [bitcoin] hebasto opened pull request #14497: docs: Add `doc/bitcoin-conf.md` (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497
476 2018-10-16T21:18:19  *** bitcoin-git has left #bitcoin-core-dev
477 2018-10-16T21:32:56  *** proletesseract has quit IRC
478 2018-10-16T21:37:15  <meshcollider> hebasto: I mentioned that idea above briefly, we can't just stop ignoring comments in-line, because many people's conf files may already use inline comments
479 2018-10-16T21:37:25  <meshcollider> So suddenly they would all stop being ignored
480 2018-10-16T21:37:37  *** Murch has joined #bitcoin-core-dev
481 2018-10-16T21:41:07  *** intcat has quit IRC
482 2018-10-16T21:41:11  <meshcollider> Jmabsd: https://github.com/bitcoin/bitcoin/tree/master/src/script/standard.cpp#L24
483 2018-10-16T21:45:58  *** intcat has joined #bitcoin-core-dev
484 2018-10-16T21:47:59  *** promag has joined #bitcoin-core-dev
485 2018-10-16T21:49:44  <achow101> what if we instead just removed rpcuser and rpcpassword? they'be been deprecated for ages
486 2018-10-16T21:52:39  <sipa> ha.
487 2018-10-16T21:52:39  <hebasto> meshcollider: to change config file is not the same as to change code :)
488 2018-10-16T21:53:47  <sipa> hebasto: well we can't just break compatibility with existing config files (within reason)
489 2018-10-16T21:54:06  <esotericnonsense> surely # in rpcpassword is broken regardless. wtf.
490 2018-10-16T21:54:37  * esotericnonsense has now made himself aware that you can have a hash in file names. great
491 2018-10-16T21:54:44  <sipa> ha
492 2018-10-16T21:55:29  <esotericnonsense> stat #: missing operand (of course)
493 2018-10-16T21:55:32  <esotericnonsense> stat "#": it works
494 2018-10-16T21:55:46  <sipa> stat \#
495 2018-10-16T21:56:03  <promag> hebasto: what sipa said
496 2018-10-16T21:56:14  <hebasto> agree
497 2018-10-16T22:05:02  *** bergz has quit IRC
498 2018-10-16T22:09:24  *** profmac has quit IRC
499 2018-10-16T22:10:06  *** hebasto has quit IRC
500 2018-10-16T22:12:52  *** Krellan has quit IRC
501 2018-10-16T22:13:24  *** Krellan_ has joined #bitcoin-core-dev
502 2018-10-16T22:14:21  *** shesek has joined #bitcoin-core-dev
503 2018-10-16T22:14:21  *** shesek has joined #bitcoin-core-dev
504 2018-10-16T22:16:27  *** spinza has quit IRC
505 2018-10-16T22:17:29  *** bitcoin-git has joined #bitcoin-core-dev
506 2018-10-16T22:17:29  <bitcoin-git> [bitcoin] mrwhythat opened pull request #14498: rpcwallet: listsentbyaddress RPC (master...listsentbyaddress-rpc) https://github.com/bitcoin/bitcoin/pull/14498
507 2018-10-16T22:17:29  *** bitcoin-git has left #bitcoin-core-dev
508 2018-10-16T22:19:04  *** jarthur has quit IRC
509 2018-10-16T22:21:45  *** profmac has joined #bitcoin-core-dev
510 2018-10-16T22:23:02  *** bitconner has joined #bitcoin-core-dev
511 2018-10-16T22:26:25  *** spinza has joined #bitcoin-core-dev
512 2018-10-16T22:26:33  *** justanotheruser has joined #bitcoin-core-dev
513 2018-10-16T22:27:33  *** Guyver2 has quit IRC
514 2018-10-16T22:32:26  *** ExtraCrispy_ has quit IRC
515 2018-10-16T22:37:21  *** michaelsdunn1 has quit IRC
516 2018-10-16T22:40:17  *** bergz has joined #bitcoin-core-dev
517 2018-10-16T22:45:03  *** promag has quit IRC
518 2018-10-16T22:47:50  *** OzPac has joined #bitcoin-core-dev
519 2018-10-16T23:13:54  <gmaxwell> oh come on, getblockstats  run with no special aguments either works or doesn't work without txindex enabled, based on what block you call it on.
520 2018-10-16T23:14:02  *** leishman has quit IRC
521 2018-10-16T23:14:34  *** leishman has joined #bitcoin-core-dev
522 2018-10-16T23:20:31  *** jarthur has joined #bitcoin-core-dev
523 2018-10-16T23:21:47  *** bralyclow2 has joined #bitcoin-core-dev
524 2018-10-16T23:23:17  *** bralyclow2 has quit IRC
525 2018-10-16T23:23:32  <echeveria> achow101: they kind of need to go away
526 2018-10-16T23:23:45  <echeveria> achow101: there's fucking like, 3000+ open RPC ports on IPv4.
527 2018-10-16T23:23:49  *** bralyclow2 has joined #bitcoin-core-dev
528 2018-10-16T23:24:08  <echeveria> achow101: assclowns like Samurai Wallet are telling people to bind RPC to
529 2018-10-16T23:24:36  *** bralyclow3 has joined #bitcoin-core-dev
530 2018-10-16T23:26:46  <gmaxwell> echeveria: what?!
531 2018-10-16T23:27:08  <gmaxwell> why?
532 2018-10-16T23:27:38  <echeveria> gmaxwell: connect your wallet to your own node, using RPC! or something. I don't know much about it other than reading some people trying to do it in #bitcoin.
533 2018-10-16T23:28:13  * luke-jr facepalms
534 2018-10-16T23:28:39  *** bralyclow2 has quit IRC
535 2018-10-16T23:29:08  <echeveria> https://support.samourai.io/article/39-enable-trusted-node-in-your-wallet
536 2018-10-16T23:29:40  <echeveria> clowns.
537 2018-10-16T23:29:59  <gmaxwell> actually they tell you to VPN, no rpc bind it seems?
538 2018-10-16T23:30:28  <gmaxwell> what does this feature do?
539 2018-10-16T23:30:41  *** bralyclow3 has quit IRC
540 2018-10-16T23:30:48  <luke-jr> they also tell you to rpcallowip your LAN (or VPN) only
541 2018-10-16T23:30:58  <luke-jr> but I guess that may bind :/
542 2018-10-16T23:31:14  <gmaxwell> why are they not just using p2p?
543 2018-10-16T23:31:24  *** OzPac has quit IRC
544 2018-10-16T23:31:56  <gmaxwell> "Use your personal node to broadcast transactions to the bitcoin network"
545 2018-10-16T23:32:07  <gmaxwell> thats what it claims it does
546 2018-10-16T23:32:35  <luke-jr> wtf, that's not even particularly useful
547 2018-10-16T23:32:36  <echeveria> from the description I doubt it uses it as a data source.
548 2018-10-16T23:33:03  <echeveria> this is the company that lied in their original software release and claimed to be decentralized, while using blockchain.info in their closed source release.
549 2018-10-16T23:33:12  <gmaxwell> I know previously it used bc.i as its data source. I don't see how it would use your local node as a data source.
550 2018-10-16T23:33:25  *** bergz has quit IRC
551 2018-10-16T23:33:59  <gmaxwell> "We build the software that Bitcoin deserves"  ... just so.
552 2018-10-16T23:38:45  <echeveria> all of their "privacy" tools are snake oil, to boot. it's unfortunate that they're impacting bitcoin node users as well as people fooled into using their incompetent software.
553 2018-10-16T23:39:04  <achow101> echeveria: removing rpcuser and rpcpassword wouldn't change that though
554 2018-10-16T23:39:12  <achow101> you can still set rpcauth
555 2018-10-16T23:39:27  <achow101> (albeit harder to do)
556 2018-10-16T23:39:50  <echeveria> achow101: it ends up being an automatically generated token, doesn't it?
557 2018-10-16T23:40:09  <gmaxwell> echeveria: no thats cookie auth.
558 2018-10-16T23:40:11  <achow101> echeveria: no, that's only the cookie auth stuff. that token goes into the .cookie file
559 2018-10-16T23:40:26  <achow101> rpcauth is like rpcuser and rpcpassword except as one config option and the password is hashed
560 2018-10-16T23:40:38  <echeveria> oh, I thought they were the same thing.
561 2018-10-16T23:41:04  <echeveria> guess that doesn't implicitly solve any issue like I thought.
562 2018-10-16T23:41:36  <achow101> i mean it's harder for people to figure out how to hash their password to use rpcauth
563 2018-10-16T23:41:50  <gmaxwell> cookie auth is a replacement for things that read passwords out of the conf file, rpcauth is the replacement for things that have a persistant key left in another app.
564 2018-10-16T23:42:46  <echeveria> yep, understood, I just bundled them together in my head. it sort of surprised my awfully to realise that so many RPC ports were open in public IPv4 scans. I'm not sure there's a resolution to that, it's already something that's non-trivial to do.
565 2018-10-16T23:43:15  <gmaxwell> I hope that many of them are honeypots, etc.
566 2018-10-16T23:43:15  <echeveria> unless the RPC bind option is changed to IM_AN_IDIOT=0.0.0. or something, which I can understand why nobody would want to do that.
567 2018-10-16T23:43:43  <echeveria> hopefully.
568 2018-10-16T23:44:14  <meshcollider> sipa: how about checking the flatsigningprovider only added a single pubkey for each descriptor, and import it if it did
569 2018-10-16T23:44:14  <gmaxwell> just change the string to a new random 256 bit hex value in each release. :P
570 2018-10-16T23:44:18  <meshcollider> Would that work?
571 2018-10-16T23:45:21  <echeveria> gmaxwell: see I'd say remove the ability to bind anything but localhost, but I know that would mean people would refuse to upgrade for compatibility reasons.
572 2018-10-16T23:45:36  <sipa> meshcollider: i have a bit of another strategy in mind
573 2018-10-16T23:45:36  <achow101> or remove rpcbind and make people figure out iptables/firewall crap to get it accessible from the outside world
574 2018-10-16T23:45:56  <sipa> meshcollider: let's focus on making importmulti work first for all supported things, and ignore descriptors
575 2018-10-16T23:46:09  <sipa> meshcollider: i think the code can be massively simplified (but let's do that after merging your PR)
576 2018-10-16T23:46:13  <gmaxwell> echeveria: it's not unreasonable to bind to a private lan, for example. just security wise fragile.
577 2018-10-16T23:46:16  <meshcollider> sipa: Alright, sounds good
578 2018-10-16T23:46:25  <sipa> and after simplification, it can share a lot of logic with the descriptor approach
579 2018-10-16T23:46:45  <gmaxwell> echeveria: maybe {stop} should work without authentication. :P
580 2018-10-16T23:47:02  <meshcollider> sipa: does this include change to the wallet or just the RPC code
581 2018-10-16T23:47:14  <sipa> meshcollider: just the scope of your current PRs
582 2018-10-16T23:47:16  <gmaxwell> echeveria: oh there you go, auto stop after 1000 invalid auth attempts. :P
583 2018-10-16T23:47:29  <echeveria> yuck.
584 2018-10-16T23:47:39  <sipa> echeveria: wumpus had some unix socket binding RPC stuff earlier, not sure what the state is
585 2018-10-16T23:48:03  <sipa> perhaps that can be made default the only open thing, and you need a separate tool to proxy it to TCP/IP
586 2018-10-16T23:48:08  <sipa> ... at some point
587 2018-10-16T23:48:12  <gmaxwell> sipa: it was held up because the client side support needed upstream improvements in libevent. :(
588 2018-10-16T23:48:17  <sipa> gmaxwell: right
589 2018-10-16T23:48:29  <echeveria> sipa: I think that results in people using obsolete versions sadly.
590 2018-10-16T23:48:43  <sipa> echeveria: quite possibly
591 2018-10-16T23:48:58  <echeveria> that's what happened with BitPay's Insight. they stopped maintaining it so everybody who built around it is still running 0.12, as far as I can tell not behind guard nodes.
592 2018-10-16T23:48:59  <gmaxwell> I do think that making it harder to make rpc remotely accessible might be a reasonable move, esp post domain socket support. (not that they're really related)
593 2018-10-16T23:49:03  <jarthur> sipa gmaxwell do you remember why we needed to re-use a socket object in libevent? Is it because we wanted the unix socket file managed by Core instead of libevent?
594 2018-10-16T23:49:12  *** bitcoin-git has joined #bitcoin-core-dev
595 2018-10-16T23:49:13  <bitcoin-git> [bitcoin] MeshCollider closed pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
596 2018-10-16T23:49:13  *** bitcoin-git has left #bitcoin-core-dev
597 2018-10-16T23:49:16  <sipa> jarthur: no clue about the details
598 2018-10-16T23:49:35  <gmaxwell> echeveria: disabling it would do that, but requiring an insecure_nonlocal_binding=1
599 2018-10-16T23:49:46  <echeveria> yep.
600 2018-10-16T23:50:08  <gmaxwell> jarthur: should be in wumpus' issue in the libevent repo.
601 2018-10-16T23:50:27  <jarthur> sipa: alright. I think that's what wumpus' upstream PR was all about. I think we can do it in libevent today if we have libevent opening the socket in the first place.
602 2018-10-16T23:51:37  <jarthur> Why is this remote RPC stuff coming up? IMO, it's already hard to expose an RPC port on anything but the loopback.
603 2018-10-16T23:51:59  <echeveria> jarthur: I noticed that there's a large number of RPC sockets open.
604 2018-10-16T23:52:38  *** Murch has quit IRC
605 2018-10-16T23:52:48  <jarthur> echeveria: ah, when using Samurai? Or just listening sockets on a clean Core run?
606 2018-10-16T23:52:52  <gmaxwell> jarthur: wumpus' major motiviation behind working on domain sockets was getting bitcoind to run in a very restrictive sandbox.
607 2018-10-16T23:53:30  <gmaxwell> samurai is just one of many potential causes for the large number of rpc exposes hosts.
608 2018-10-16T23:54:02  <echeveria> jarthur: just in general, many IPv4 that have 8333 open also have 8332 open. there's various tools like shodan that present this information in an easy to consume way. samourai was just one theory of mine as to why people might be doing it, as they do suggest exposing your RPC port in some way, for a very stupid reason.
609 2018-10-16T23:54:04  <gmaxwell> (and a kind of absurd one, since it looks like they have the user open up the RPC to remote hosts just to sendrawtransaction)
610 2018-10-16T23:54:55  <achow101> even with rpcbind=, you still need to be whitelisted in rpcallowip to connect though
611 2018-10-16T23:55:12  <achow101> unless people also did rpcallowip=
612 2018-10-16T23:56:08  <jarthur> echeveria: alright. There's also electrumx, electrum-server, electrum-personal-server, electrs, getwork proxy, stratum mining proxies, stratum mining pools. A whole lot of RPC uses out there.
613 2018-10-16T23:56:29  <gmaxwell> none of those things should be exposing the bitcoind rpc to the wide internet.
614 2018-10-16T23:56:31  <echeveria> jarthur: none of what you've described need a world listening RPC port.
615 2018-10-16T23:56:54  <jarthur> Yea, not justifying the open port, just why people end up opening those ports in the first place.
616 2018-10-16T23:57:39  <gmaxwell> achow101: perhaps we should require  "massively_increased_security_vulnerablity_exposure=1" for any rpcallowip statement wider than /8. :P
617 2018-10-16T23:57:41  *** Murch has joined #bitcoin-core-dev
618 2018-10-16T23:57:56  <jarthur> I sometimes load up an EC2 Core server, open up RPC to the net and use Amazon Security group to only let myself have access. I got no shame in it :)
619 2018-10-16T23:58:02  <echeveria> jarthur: huh? it needs extra effort to make it bind to, which you don't need for nay of the services you talk about.
620 2018-10-16T23:58:23  <echeveria> jarthur: you're a bad sysadmin. you have SSH, forward the port locally.
621 2018-10-16T23:59:19  <gmaxwell> jarthur: the fact that its possible to 0/0 safely (although fragile) is why its possible at all.
622 2018-10-16T23:59:41  <jarthur> echeveria: yea, that's certainly better. Have done that too when less lazy.