1 2018-10-17T00:00:06  <gmaxwell> But in practice it appears that a lot of people are exposing themselves, and ultimately thats an issue for us... not just because we care about people getting owned but because it increases the critical attack surface a lot.
  2 2018-10-17T00:00:58  <echeveria> ie, even if not authenticated, I don't believe the RPC server is designed to handle a lot of arbitrary connections hogging sockets.
  3 2018-10-17T00:01:28  <achow101> the rpcpassword is sent plaintext so a mitm can access everything too
  4 2018-10-17T00:04:50  <echeveria> it's not a huge issue, just something to consider.
  5 2018-10-17T00:07:01  *** Bullit has quit IRC
  6 2018-10-17T00:09:05  *** bralyclow2 has joined #bitcoin-core-dev
  7 2018-10-17T00:10:01  *** bralyclow2 has quit IRC
  8 2018-10-17T00:10:23  *** bralyclow2 has joined #bitcoin-core-dev
  9 2018-10-17T00:10:49  *** bralyclow2 has quit IRC
 10 2018-10-17T00:14:19  <gmaxwell> indeed, we've had people in #bitcoin that were having issues because some third party was trying to password bruteforce their rpc port or something like that..
 11 2018-10-17T00:19:24  <sipa> meshcollider: you don't seem to have code for P2SH-P2WPKH
 12 2018-10-17T00:22:21  *** Victorsueca has quit IRC
 13 2018-10-17T00:23:29  *** Victorsueca has joined #bitcoin-core-dev
 14 2018-10-17T00:25:10  *** leishman has quit IRC
 15 2018-10-17T00:27:07  <sipa> meshcollider: also i think the tests are very insufficient; it doesn't test anything but that importmulti succeeds, not whether it actually imported anything
 16 2018-10-17T00:27:23  <sipa> meshcollider: also, no tests with solvable-but-not-spendable cases
 17 2018-10-17T00:31:40  *** proletesseract has joined #bitcoin-core-dev
 18 2018-10-17T00:44:01  *** Jmabsd2 has joined #bitcoin-core-dev
 19 2018-10-17T00:47:00  *** leishman has joined #bitcoin-core-dev
 20 2018-10-17T00:47:58  *** Jmabsd has quit IRC
 21 2018-10-17T00:50:36  *** Jmabsd2 has quit IRC
 22 2018-10-17T00:50:55  *** prole has joined #bitcoin-core-dev
 23 2018-10-17T00:51:18  *** leishman has quit IRC
 24 2018-10-17T00:52:45  *** jb55 has joined #bitcoin-core-dev
 25 2018-10-17T00:52:58  *** proletesseract has quit IRC
 26 2018-10-17T01:03:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 27 2018-10-17T01:05:46  *** Jmabsd has joined #bitcoin-core-dev
 28 2018-10-17T01:12:00  <meshcollider> sipa: yeah I know the tests aren't the best, I'll make some better ones soon
 29 2018-10-17T01:13:31  <meshcollider> sipa: good point re P2SH-P2WPKH, it was there earlier when it always imported the public keys, but now I changed that I need to add the pubkey import into the P2SH if statement too
 30 2018-10-17T01:14:43  <sipa> meshcollider: i also realized that the importmulti does a whole bunch of things not that it should be doing (unrelated to your PR), which I'd like to fix, like checking that the private keys are actually used, or assigning a timestamp for imported pubkey, or checking that no unnecessary information is given
 31 2018-10-17T01:15:18  <sipa> so maybe my earlier claim that it can simplied a lot is an overstatement, but at least it should be possible to avoid all the duplication that exists now
 32 2018-10-17T01:15:46  <meshcollider> yeah that's what I had hoped at the start, but it keeps devolving into lots of if statements :(
 33 2018-10-17T01:16:02  <sipa> yeah
 34 2018-10-17T01:16:08  <sipa> let's first fix the functionality and tests
 35 2018-10-17T01:16:14  <sipa> further improvements can come later
 36 2018-10-17T01:16:21  <meshcollider> agreed
 37 2018-10-17T01:16:36  <sipa> meshcollider: btw, i realized that getaddressinfo doesn't expose issolvable
 38 2018-10-17T01:17:03  <sipa> which seems a pretty obvious improvement, and would make tests for whether importing succeeded much easier
 39 2018-10-17T01:19:57  <meshcollider> mmm I noticed that, I originally thought it did
 40 2018-10-17T01:20:01  <meshcollider> did validateaddress expose it?
 41 2018-10-17T01:20:07  <meshcollider> or was that never possible
 42 2018-10-17T01:20:16  <sipa> i don't think it did
 43 2018-10-17T01:22:50  *** luke-jr has quit IRC
 44 2018-10-17T01:23:00  *** luke-jr has joined #bitcoin-core-dev
 45 2018-10-17T01:26:26  *** prole has quit IRC
 46 2018-10-17T01:32:18  *** luke-jr has quit IRC
 47 2018-10-17T01:32:48  *** luke-jr has joined #bitcoin-core-dev
 48 2018-10-17T01:33:36  *** esotericnonsense has quit IRC
 49 2018-10-17T01:38:00  *** esotericnonsense has joined #bitcoin-core-dev
 50 2018-10-17T01:43:11  *** Murch has quit IRC
 51 2018-10-17T01:45:08  *** luke-jr has quit IRC
 52 2018-10-17T01:45:34  *** luke-jr has joined #bitcoin-core-dev
 53 2018-10-17T01:48:23  *** luke-jr has quit IRC
 54 2018-10-17T01:48:52  *** luke-jr has joined #bitcoin-core-dev
 55 2018-10-17T01:51:34  *** proletesseract has joined #bitcoin-core-dev
 56 2018-10-17T01:55:49  *** proletesseract has quit IRC
 57 2018-10-17T01:59:59  *** Empact has joined #bitcoin-core-dev
 58 2018-10-17T02:00:50  *** Giszmo has quit IRC
 59 2018-10-17T02:01:15  *** Empact has quit IRC
 60 2018-10-17T02:07:06  *** proletesseract has joined #bitcoin-core-dev
 61 2018-10-17T02:24:22  *** booyah has quit IRC
 62 2018-10-17T02:35:51  *** Chris_Stewart_5 has quit IRC
 63 2018-10-17T02:37:08  *** ken2812221 has quit IRC
 64 2018-10-17T02:42:33  *** Bullit has joined #bitcoin-core-dev
 65 2018-10-17T02:46:36  <meshcollider> sipa: managed to get rid of a bit more duplication in the process, should be better now
 66 2018-10-17T02:51:08  *** ken2812221 has joined #bitcoin-core-dev
 67 2018-10-17T02:57:03  *** ken2812221 has quit IRC
 68 2018-10-17T02:57:26  *** ken2812221 has joined #bitcoin-core-dev
 69 2018-10-17T03:04:38  *** keymone has quit IRC
 70 2018-10-17T03:05:49  *** keymone has joined #bitcoin-core-dev
 71 2018-10-17T03:12:24  *** CubicEarth has quit IRC
 72 2018-10-17T03:14:04  *** CubicEarth has joined #bitcoin-core-dev
 73 2018-10-17T03:17:27  *** ken2812221 has quit IRC
 74 2018-10-17T03:18:17  *** bralyclow2 has joined #bitcoin-core-dev
 75 2018-10-17T03:19:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 76 2018-10-17T03:19:08  *** bralyclow2 has quit IRC
 77 2018-10-17T03:28:54  *** ken2812221 has joined #bitcoin-core-dev
 78 2018-10-17T03:32:36  *** Chris_Stewart_5 has quit IRC
 79 2018-10-17T03:47:21  *** Murch has joined #bitcoin-core-dev
 80 2018-10-17T03:54:53  *** bralyclow2 has joined #bitcoin-core-dev
 81 2018-10-17T03:56:05  *** bralyclow2 has quit IRC
 82 2018-10-17T03:58:40  *** Jmabsd has quit IRC
 83 2018-10-17T03:59:02  *** schnerchi has joined #bitcoin-core-dev
 84 2018-10-17T04:02:16  *** schnerch_ has quit IRC
 85 2018-10-17T04:38:48  *** Murch has quit IRC
 86 2018-10-17T04:39:15  *** leishman has joined #bitcoin-core-dev
 87 2018-10-17T04:40:16  *** leishman has joined #bitcoin-core-dev
 88 2018-10-17T04:42:40  *** Krellan_ has quit IRC
 89 2018-10-17T04:53:05  *** hebasto has joined #bitcoin-core-dev
 90 2018-10-17T04:53:08  *** bitconner has quit IRC
 91 2018-10-17T05:03:05  *** leishman has quit IRC
 92 2018-10-17T05:09:22  *** grubles_ has joined #bitcoin-core-dev
 93 2018-10-17T05:09:34  *** grubles has quit IRC
 94 2018-10-17T05:31:59  *** jarthur has quit IRC
 95 2018-10-17T05:32:43  *** jarthur has joined #bitcoin-core-dev
 96 2018-10-17T05:33:39  *** bralyclow2 has joined #bitcoin-core-dev
 97 2018-10-17T05:35:06  *** bitconner has joined #bitcoin-core-dev
 98 2018-10-17T05:35:20  *** bralyclow2 has quit IRC
 99 2018-10-17T05:39:32  *** bitconner has quit IRC
100 2018-10-17T05:40:36  *** GAit has quit IRC
101 2018-10-17T05:49:01  *** rh0nj has quit IRC
102 2018-10-17T05:49:47  *** arubi has quit IRC
103 2018-10-17T05:50:11  *** rh0nj has joined #bitcoin-core-dev
104 2018-10-17T05:53:47  *** bitconner has joined #bitcoin-core-dev
105 2018-10-17T05:58:01  *** arubi has joined #bitcoin-core-dev
106 2018-10-17T05:58:26  *** bitconner has quit IRC
107 2018-10-17T06:01:11  <provoostenator> Github has a new review feature: "New! Suggest specific code changes that the pull request author can immediately commit. You will be attributed in the commit."
108 2018-10-17T06:07:31  *** GAit has joined #bitcoin-core-dev
109 2018-10-17T06:08:58  <provoostenator> I'll try it on the importmulti segwit RPC PR, though I suspect it creates entire new (unsigned) commits, which would mess up our usual flow.
110 2018-10-17T06:19:00  <meshcollider> well, the commits don't need to be signed except the merge commits
111 2018-10-17T06:19:15  <meshcollider> so who knows :)
112 2018-10-17T06:19:46  <meshcollider> but most suggested changes in PRs will be nitfixes I imagine, which should be squashed anyway
113 2018-10-17T06:28:36  <provoostenator> Related thought: it would be very cool if it was possible to co-sign another persons commit, like a superACK.
114 2018-10-17T06:30:39  <sipa> there is a convention to add "Signed-off-by: <name>" to a commit message
115 2018-10-17T06:31:37  <sipa> there's even a git option for it, git commit --signoff
116 2018-10-17T06:39:33  *** ken2812221 has quit IRC
117 2018-10-17T06:39:57  *** ken2812221 has joined #bitcoin-core-dev
118 2018-10-17T06:50:36  <sipa> meshcollider: moar comments, starting to look good :)
119 2018-10-17T07:01:00  <meshcollider> sipa: thanks, appreciate the amount of time youre putting into reviewing this, I'll work on them as soon as I can
120 2018-10-17T07:02:05  *** echonaut has quit IRC
121 2018-10-17T07:02:13  *** echonaut14 has joined #bitcoin-core-dev
122 2018-10-17T07:08:25  *** instagibbs has quit IRC
123 2018-10-17T07:12:36  *** promag has joined #bitcoin-core-dev
124 2018-10-17T07:14:20  *** promag has quit IRC
125 2018-10-17T07:16:09  *** ossifrage has quit IRC
126 2018-10-17T07:18:37  <sipa> meshcollider: happy to see someone working on this; we should have done this 2 releases ago, so the alternative is probably that i'd need to do it myself :)
127 2018-10-17T07:18:53  <sipa> also, it's great to get some more people familiar with this code
128 2018-10-17T07:23:13  *** Guyver2 has joined #bitcoin-core-dev
129 2018-10-17T07:23:33  *** AM5800 has joined #bitcoin-core-dev
130 2018-10-17T07:24:45  *** bitcoin-git has joined #bitcoin-core-dev
131 2018-10-17T07:24:46  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/23419e4c4939...27bf14f6f3e0
132 2018-10-17T07:24:46  <bitcoin-git> bitcoin/master 4ae50da practicalswift: Revert "qa: Fix codespell error and have lint-spelling error instead of warn"...
133 2018-10-17T07:24:47  <bitcoin-git> bitcoin/master c32cf6a practicalswift: Add ignored word: mut
134 2018-10-17T07:24:47  <bitcoin-git> bitcoin/master 27bf14f Pieter Wuille: Merge #14495: build: Warn (don't fail!) on spelling errors...
135 2018-10-17T07:24:48  *** bitcoin-git has left #bitcoin-core-dev
136 2018-10-17T07:25:59  *** bitcoin-git has joined #bitcoin-core-dev
137 2018-10-17T07:25:59  <bitcoin-git> [bitcoin] sipa closed pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
138 2018-10-17T07:25:59  *** bitcoin-git has left #bitcoin-core-dev
139 2018-10-17T07:25:59  <AM5800> Hi, can someone tell me what is the current status of dandelion (BIP 156)?
140 2018-10-17T07:27:13  <sipa> AM5800: people are working on an implementation, but there is a lot of unclarity on how to combine it with the DoS protections the current mempool model has
141 2018-10-17T07:28:42  *** ken2812221 has quit IRC
142 2018-10-17T07:29:03  *** ken2812221 has joined #bitcoin-core-dev
143 2018-10-17T07:29:52  <AM5800> sipa, thanks. I would like to offer an assistance on this feature, who should I contact?
144 2018-10-17T07:30:39  *** ExtraCrispy_ has joined #bitcoin-core-dev
145 2018-10-17T07:30:47  <sipa> AM5800: sdaftuar and MarcoFalke are probably people to talk to
146 2018-10-17T07:31:44  <AM5800> sipa, one final question: what would be the best way to reach them?
147 2018-10-17T07:31:57  <sipa> irc is pretty good :)
148 2018-10-17T07:32:06  <sipa> you may need to wait a few hours or days, though
149 2018-10-17T07:32:14  <meshcollider> sipa: yes, I find the wallet and descriptor stuff all very interesting, much more interesting than say network code hehe
150 2018-10-17T07:33:08  <AM5800> sipa: thank you!
151 2018-10-17T07:34:46  *** Krellan has joined #bitcoin-core-dev
152 2018-10-17T07:44:23  *** ken2812221 has quit IRC
153 2018-10-17T07:54:00  *** bitconner has joined #bitcoin-core-dev
154 2018-10-17T07:58:23  *** bitconner has quit IRC
155 2018-10-17T08:00:58  *** proletesseract has quit IRC
156 2018-10-17T08:15:56  *** phwalkr has joined #bitcoin-core-dev
157 2018-10-17T08:16:09  *** booyah has joined #bitcoin-core-dev
158 2018-10-17T08:18:03  *** jungly has joined #bitcoin-core-dev
159 2018-10-17T08:18:17  *** Guyver2 has quit IRC
160 2018-10-17T08:23:02  *** timothy has joined #bitcoin-core-dev
161 2018-10-17T08:28:27  *** instagibbs has joined #bitcoin-core-dev
162 2018-10-17T08:38:38  *** OzPac has joined #bitcoin-core-dev
163 2018-10-17T08:42:39  *** ken2812221 has joined #bitcoin-core-dev
164 2018-10-17T08:43:54  *** ossifrage has joined #bitcoin-core-dev
165 2018-10-17T08:44:37  *** luke-jr has quit IRC
166 2018-10-17T08:44:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
167 2018-10-17T08:45:01  *** luke-jr has joined #bitcoin-core-dev
168 2018-10-17T08:47:21  *** promag has joined #bitcoin-core-dev
169 2018-10-17T08:58:01  *** luke-jr has quit IRC
170 2018-10-17T08:58:10  *** luke-jr has joined #bitcoin-core-dev
171 2018-10-17T08:58:24  *** Chris_Stewart_5 has quit IRC
172 2018-10-17T09:00:21  *** bitconner has joined #bitcoin-core-dev
173 2018-10-17T09:04:45  *** bitconner has quit IRC
174 2018-10-17T09:06:39  *** ken2812221 has quit IRC
175 2018-10-17T09:08:18  *** bitcoin-git has joined #bitcoin-core-dev
176 2018-10-17T09:08:19  <bitcoin-git> [bitcoin] luke-jr opened pull request #14501: Fix possible data race when committing block files (master...fsync_dir) https://github.com/bitcoin/bitcoin/pull/14501
177 2018-10-17T09:08:19  *** bitcoin-git has left #bitcoin-core-dev
178 2018-10-17T09:14:50  *** ken2812221 has joined #bitcoin-core-dev
179 2018-10-17T09:14:58  *** ExtraCrispy_ has quit IRC
180 2018-10-17T09:15:23  *** Krellan has quit IRC
181 2018-10-17T09:21:48  *** promag has quit IRC
182 2018-10-17T09:24:09  *** laurentmt has joined #bitcoin-core-dev
183 2018-10-17T09:24:40  *** OzPac has quit IRC
184 2018-10-17T09:25:45  *** promag has joined #bitcoin-core-dev
185 2018-10-17T09:25:57  *** wumpus has joined #bitcoin-core-dev
186 2018-10-17T09:30:22  *** AaronvanW has joined #bitcoin-core-dev
187 2018-10-17T09:30:30  *** OzPac has joined #bitcoin-core-dev
188 2018-10-17T09:32:51  *** belcher_ has quit IRC
189 2018-10-17T09:35:27  *** laurentmt has quit IRC
190 2018-10-17T09:39:31  *** ken2812221 has quit IRC
191 2018-10-17T09:40:05  *** luke-jr has quit IRC
192 2018-10-17T09:40:15  *** luke-jr has joined #bitcoin-core-dev
193 2018-10-17T09:41:56  *** promag has quit IRC
194 2018-10-17T09:42:20  *** promag has joined #bitcoin-core-dev
195 2018-10-17T09:51:40  *** OzPac has quit IRC
196 2018-10-17T09:59:46  *** OzPac has joined #bitcoin-core-dev
197 2018-10-17T10:00:19  *** OzPac has quit IRC
198 2018-10-17T10:03:19  *** setpill has joined #bitcoin-core-dev
199 2018-10-17T10:06:46  *** OzPac has joined #bitcoin-core-dev
200 2018-10-17T10:33:54  *** david___ has joined #bitcoin-core-dev
201 2018-10-17T10:35:52  <david___> LS
202 2018-10-17T10:37:31  *** AM5800 has quit IRC
203 2018-10-17T10:40:45  *** Zenton has quit IRC
204 2018-10-17T10:40:53  *** Zenton has joined #bitcoin-core-dev
205 2018-10-17T10:50:26  *** phwalkr has quit IRC
206 2018-10-17T10:52:27  *** Zenton has quit IRC
207 2018-10-17T10:52:34  *** Zenton has joined #bitcoin-core-dev
208 2018-10-17T11:00:32  *** bitconner has joined #bitcoin-core-dev
209 2018-10-17T11:04:43  *** bitconner has quit IRC
210 2018-10-17T11:06:43  *** Guest87013 has quit IRC
211 2018-10-17T11:10:17  *** schmidty has joined #bitcoin-core-dev
212 2018-10-17T11:10:41  *** schmidty is now known as Guest3968
213 2018-10-17T11:44:54  *** bitcoin-git has joined #bitcoin-core-dev
214 2018-10-17T11:44:54  <bitcoin-git> [bitcoin] karel-3d opened pull request #14502: Rpc helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
215 2018-10-17T11:44:54  *** bitcoin-git has left #bitcoin-core-dev
216 2018-10-17T11:52:32  *** bergz has joined #bitcoin-core-dev
217 2018-10-17T11:53:00  *** AaronvanW has quit IRC
218 2018-10-17T11:55:24  *** AM5800 has joined #bitcoin-core-dev
219 2018-10-17T12:00:03  *** harrymm has quit IRC
220 2018-10-17T12:00:37  *** harrymm has joined #bitcoin-core-dev
221 2018-10-17T12:01:08  *** phwalkr has joined #bitcoin-core-dev
222 2018-10-17T12:03:37  *** AaronvanW has joined #bitcoin-core-dev
223 2018-10-17T12:08:50  *** AaronvanW has quit IRC
224 2018-10-17T12:13:10  *** AaronvanW has joined #bitcoin-core-dev
225 2018-10-17T12:24:04  *** josephnicholas has joined #bitcoin-core-dev
226 2018-10-17T12:32:21  *** Guest3968 has quit IRC
227 2018-10-17T12:36:32  *** Drakon has joined #bitcoin-core-dev
228 2018-10-17T12:36:38  <Drakon> The option to minimize to system tray instead of the taskbar ist available, but doesn't have an effect if it is started with the -min option. If I start it via that option, I have to click on the program symbil on the taskbar and then minimize it again in order to get it minimized to system tray.
229 2018-10-17T12:37:28  <Drakon> That's annoying.
230 2018-10-17T12:40:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
231 2018-10-17T12:48:04  *** Victorsueca has quit IRC
232 2018-10-17T12:49:18  *** Victorsueca has joined #bitcoin-core-dev
233 2018-10-17T12:51:04  *** josephnicholas has quit IRC
234 2018-10-17T12:51:37  *** josephnicholas has joined #bitcoin-core-dev
235 2018-10-17T12:51:58  *** josephnicholas has joined #bitcoin-core-dev
236 2018-10-17T12:56:24  *** josephnicholas has quit IRC
237 2018-10-17T13:00:49  *** bitconner has joined #bitcoin-core-dev
238 2018-10-17T13:05:26  *** bitconner has quit IRC
239 2018-10-17T13:07:35  *** AM5800 has quit IRC
240 2018-10-17T13:07:42  *** setpill has quit IRC
241 2018-10-17T13:08:04  *** Drakon has quit IRC
242 2018-10-17T13:13:20  *** Zenton has quit IRC
243 2018-10-17T13:13:27  *** Zenton has joined #bitcoin-core-dev
244 2018-10-17T13:15:09  *** phwalkr has quit IRC
245 2018-10-17T13:28:15  *** Zenton has quit IRC
246 2018-10-17T13:28:22  *** Zenton has joined #bitcoin-core-dev
247 2018-10-17T13:29:48  *** schmidty has joined #bitcoin-core-dev
248 2018-10-17T13:30:12  *** schmidty is now known as Guest63155
249 2018-10-17T13:32:19  *** Zenton has quit IRC
250 2018-10-17T13:32:26  *** Zenton has joined #bitcoin-core-dev
251 2018-10-17T13:33:11  *** david___ has quit IRC
252 2018-10-17T13:33:16  *** Zenton has quit IRC
253 2018-10-17T13:34:14  *** ken2812221 has joined #bitcoin-core-dev
254 2018-10-17T13:40:33  *** jungly has quit IRC
255 2018-10-17T13:49:09  *** jungly has joined #bitcoin-core-dev
256 2018-10-17T13:51:19  <wumpus> can you open an issue for that please? https://github.com/bitcoin/bitcoin/issues/new
257 2018-10-17T13:53:24  <wumpus> (if there isn't one yet-)
258 2018-10-17T13:58:28  *** bergz has quit IRC
259 2018-10-17T14:01:47  *** bitcoin-git has joined #bitcoin-core-dev
260 2018-10-17T14:01:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27bf14f6f3e0...3036faf51a18
261 2018-10-17T14:01:49  <bitcoin-git> bitcoin/master ee0b7c4 practicalswift: build: Pin to specific versions of Python packages we install from PyPI in Travis
262 2018-10-17T14:01:49  <bitcoin-git> bitcoin/master 3036faf Wladimir J. van der Laan: Merge #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis...
263 2018-10-17T14:01:50  *** bitcoin-git has left #bitcoin-core-dev
264 2018-10-17T14:03:17  *** bitcoin-git has joined #bitcoin-core-dev
265 2018-10-17T14:03:18  <bitcoin-git> [bitcoin] laanwj closed pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
266 2018-10-17T14:03:18  *** bitcoin-git has left #bitcoin-core-dev
267 2018-10-17T14:04:12  *** Murch has joined #bitcoin-core-dev
268 2018-10-17T14:09:17  *** bergz has joined #bitcoin-core-dev
269 2018-10-17T14:24:03  *** bralyclow2 has joined #bitcoin-core-dev
270 2018-10-17T14:25:06  *** jarthur has quit IRC
271 2018-10-17T14:25:12  *** bralyclow2 has quit IRC
272 2018-10-17T14:31:36  *** ossifrage_ has joined #bitcoin-core-dev
273 2018-10-17T14:33:46  *** Chris_Stewart_5 has quit IRC
274 2018-10-17T14:34:25  *** leishman has joined #bitcoin-core-dev
275 2018-10-17T14:34:54  *** arubi has quit IRC
276 2018-10-17T14:34:54  *** intcat has quit IRC
277 2018-10-17T14:34:54  *** morcos has quit IRC
278 2018-10-17T14:34:54  *** ghost43 has quit IRC
279 2018-10-17T14:36:01  *** sipa has quit IRC
280 2018-10-17T14:38:02  *** harding_ has joined #bitcoin-core-dev
281 2018-10-17T14:47:42  *** ossifrage has quit IRC
282 2018-10-17T14:49:42  *** profmac has quit IRC
283 2018-10-17T14:49:45  *** Taek has quit IRC
284 2018-10-17T14:49:45  *** TheRec has quit IRC
285 2018-10-17T14:49:45  *** gribble has quit IRC
286 2018-10-17T14:49:45  *** cryptocat has quit IRC
287 2018-10-17T14:49:45  *** harding has quit IRC
288 2018-10-17T14:49:45  *** qinfengling has quit IRC
289 2018-10-17T14:50:26  *** jarthur has joined #bitcoin-core-dev
290 2018-10-17T14:52:49  *** profmac has joined #bitcoin-core-dev
291 2018-10-17T14:53:14  *** michaelsdunn1 has joined #bitcoin-core-dev
292 2018-10-17T14:55:02  *** qinfengling has joined #bitcoin-core-dev
293 2018-10-17T14:55:35  *** TheRec has joined #bitcoin-core-dev
294 2018-10-17T14:55:36  *** TheRec has joined #bitcoin-core-dev
295 2018-10-17T15:01:02  *** bitconner has joined #bitcoin-core-dev
296 2018-10-17T15:02:59  *** grubles_ is now known as grubles
297 2018-10-17T15:05:32  *** bitconner has quit IRC
298 2018-10-17T15:06:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
299 2018-10-17T15:14:52  *** Zenton has joined #bitcoin-core-dev
300 2018-10-17T15:15:54  <promag> ken2812221: do you build bitcoin-qt with msvc?
301 2018-10-17T15:23:00  *** bralyclow2 has joined #bitcoin-core-dev
302 2018-10-17T15:24:05  *** bralyclow2 has quit IRC
303 2018-10-17T15:24:20  *** leishman has quit IRC
304 2018-10-17T15:24:26  *** bitcoin-git has joined #bitcoin-core-dev
305 2018-10-17T15:24:26  <bitcoin-git> [bitcoin] isghe opened pull request #14504: show the progress of functional test (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
306 2018-10-17T15:24:26  *** bitcoin-git has left #bitcoin-core-dev
307 2018-10-17T15:24:53  *** leishman has joined #bitcoin-core-dev
308 2018-10-17T15:29:03  *** leishman has quit IRC
309 2018-10-17T15:30:30  *** jarthur has quit IRC
310 2018-10-17T15:35:21  *** leishman has joined #bitcoin-core-dev
311 2018-10-17T15:35:35  <promag> hebasto: regarding #14450 I've replaced the mingw setup with msvc
312 2018-10-17T15:36:04  <promag> but I don't know how to build bitcoin-qt to test it
313 2018-10-17T15:37:59  <promag> I'm waiting for `vcpkg install qt5` ..
314 2018-10-17T15:39:40  <ken2812221> promag: No, I don't know how to do that.
315 2018-10-17T15:40:00  <ken2812221> vcpkg is still using Qt 5.2
316 2018-10-17T15:40:30  <promag> here says 5.9.2
317 2018-10-17T15:42:05  <ken2812221> oh, I missed that 9 for a while ago.
318 2018-10-17T15:44:17  <ken2812221> But it's complicate to use qt tools on msvc. This could be done by cmake, but that's a difficult task.
319 2018-10-17T15:45:01  *** bralyclow3 has joined #bitcoin-core-dev
320 2018-10-17T15:46:48  *** bralyclow3 has quit IRC
321 2018-10-17T15:50:12  *** AM5800 has joined #bitcoin-core-dev
322 2018-10-17T15:55:16  *** lightningbot has joined #bitcoin-core-dev
323 2018-10-17T16:03:55  *** AM5800 has quit IRC
324 2018-10-17T16:11:39  *** Krellan has joined #bitcoin-core-dev
325 2018-10-17T16:24:39  *** Taek has joined #bitcoin-core-dev
326 2018-10-17T16:24:40  *** gribble has joined #bitcoin-core-dev
327 2018-10-17T16:24:40  *** cryptocat has joined #bitcoin-core-dev
328 2018-10-17T16:28:39  *** nullptr| has quit IRC
329 2018-10-17T16:29:53  *** nullptr| has joined #bitcoin-core-dev
330 2018-10-17T16:50:37  *** bitconner has joined #bitcoin-core-dev
331 2018-10-17T16:55:04  *** bitconner has quit IRC
332 2018-10-17T16:56:08  *** timothy has quit IRC
333 2018-10-17T16:56:09  *** arubi has joined #bitcoin-core-dev
334 2018-10-17T16:56:41  *** ghost43 has joined #bitcoin-core-dev
335 2018-10-17T16:56:43  *** morcos has joined #bitcoin-core-dev
336 2018-10-17T16:57:04  *** intcat has joined #bitcoin-core-dev
337 2018-10-17T16:58:09  *** sipa has joined #bitcoin-core-dev
338 2018-10-17T17:03:01  *** jarthur has joined #bitcoin-core-dev
339 2018-10-17T17:03:49  *** Guyver2 has joined #bitcoin-core-dev
340 2018-10-17T17:08:57  *** bitcoin-git has joined #bitcoin-core-dev
341 2018-10-17T17:08:57  <bitcoin-git> [bitcoin] sdaftuar closed pull request #14220: Transaction relay privacy bugfix (master...2018-09-txrelay) https://github.com/bitcoin/bitcoin/pull/14220
342 2018-10-17T17:08:57  *** bitcoin-git has left #bitcoin-core-dev
343 2018-10-17T17:14:50  *** OzPac has quit IRC
344 2018-10-17T17:18:09  *** esotericnonsense has quit IRC
345 2018-10-17T17:22:18  *** esotericnonsense has joined #bitcoin-core-dev
346 2018-10-17T17:25:06  *** bitcoin-git has joined #bitcoin-core-dev
347 2018-10-17T17:25:06  <bitcoin-git> [bitcoin] practicalswift opened pull request #14505: Make all single parameter constructors explicit (C++11) (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
348 2018-10-17T17:25:06  *** bitcoin-git has left #bitcoin-core-dev
349 2018-10-17T17:30:25  *** jungly has quit IRC
350 2018-10-17T17:38:09  *** leishman has quit IRC
351 2018-10-17T17:38:44  *** leishman has joined #bitcoin-core-dev
352 2018-10-17T17:42:58  *** leishman has quit IRC
353 2018-10-17T17:45:19  *** bitconner has joined #bitcoin-core-dev
354 2018-10-17T17:45:58  *** leishman has joined #bitcoin-core-dev
355 2018-10-17T17:49:38  *** bitconner has quit IRC
356 2018-10-17T17:55:15  *** leishman has quit IRC
357 2018-10-17T17:55:29  *** leishman has joined #bitcoin-core-dev
358 2018-10-17T18:08:23  *** owowo has quit IRC
359 2018-10-17T18:10:17  *** bitcoin-git has joined #bitcoin-core-dev
360 2018-10-17T18:10:18  <bitcoin-git> [bitcoin] practicalswift opened pull request #14506: Remove redundancies: redundant forward declaration, redundant namespace, redundancy copying, redundant conditionals (master...remove) https://github.com/bitcoin/bitcoin/pull/14506
361 2018-10-17T18:10:18  *** bitcoin-git has left #bitcoin-core-dev
362 2018-10-17T18:12:28  *** owowo has joined #bitcoin-core-dev
363 2018-10-17T18:19:36  *** leishman has quit IRC
364 2018-10-17T18:20:12  *** leishman has joined #bitcoin-core-dev
365 2018-10-17T18:20:58  *** AaronvanW has quit IRC
366 2018-10-17T18:21:33  *** AaronvanW has joined #bitcoin-core-dev
367 2018-10-17T18:24:12  *** leishman has quit IRC
368 2018-10-17T18:25:43  *** AaronvanW has quit IRC
369 2018-10-17T18:25:57  *** bitcoin-git has joined #bitcoin-core-dev
370 2018-10-17T18:25:58  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3036faf51a18...816fab9ccae5
371 2018-10-17T18:25:58  <bitcoin-git> bitcoin/master 081cc02 Hennadii Stepanov: Fix QCompleter popup regression...
372 2018-10-17T18:25:59  <bitcoin-git> bitcoin/master 816fab9 Jonas Schnelli: Merge #14450: qt: Fix QCompleter popup regression...
373 2018-10-17T18:25:59  *** bitcoin-git has left #bitcoin-core-dev
374 2018-10-17T18:27:12  *** bitcoin-git has joined #bitcoin-core-dev
375 2018-10-17T18:27:13  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14450: qt: Fix QCompleter popup regression (master...20181009-console-autocomplete) https://github.com/bitcoin/bitcoin/pull/14450
376 2018-10-17T18:27:13  *** bitcoin-git has left #bitcoin-core-dev
377 2018-10-17T18:27:34  *** Krellan has quit IRC
378 2018-10-17T18:28:33  *** Krellan has joined #bitcoin-core-dev
379 2018-10-17T18:29:59  *** leishman has joined #bitcoin-core-dev
380 2018-10-17T18:31:34  *** AaronvanW has joined #bitcoin-core-dev
381 2018-10-17T18:34:31  *** leishman has quit IRC
382 2018-10-17T18:35:56  *** leishman has joined #bitcoin-core-dev
383 2018-10-17T18:36:08  *** leishman has quit IRC
384 2018-10-17T18:36:15  *** AaronvanW has quit IRC
385 2018-10-17T18:36:18  *** sipa has quit IRC
386 2018-10-17T18:36:21  *** leishman has joined #bitcoin-core-dev
387 2018-10-17T18:36:31  *** sipa has joined #bitcoin-core-dev
388 2018-10-17T18:42:43  *** bergz has quit IRC
389 2018-10-17T18:43:31  *** bergz has joined #bitcoin-core-dev
390 2018-10-17T18:43:37  *** andytoshi has joined #bitcoin-core-dev
391 2018-10-17T18:48:27  *** bergz has quit IRC
392 2018-10-17T19:03:24  *** bitconner has joined #bitcoin-core-dev
393 2018-10-17T19:04:47  *** bergz has joined #bitcoin-core-dev
394 2018-10-17T19:05:30  *** laurentmt has joined #bitcoin-core-dev
395 2018-10-17T19:21:27  *** leishman has quit IRC
396 2018-10-17T19:22:00  *** leishman has joined #bitcoin-core-dev
397 2018-10-17T19:26:12  *** leishman has quit IRC
398 2018-10-17T19:27:21  *** bralyclo_ has joined #bitcoin-core-dev
399 2018-10-17T19:29:59  *** bralycl__ has joined #bitcoin-core-dev
400 2018-10-17T19:31:35  *** bralyclow has quit IRC
401 2018-10-17T19:32:20  *** AaronvanW has joined #bitcoin-core-dev
402 2018-10-17T19:34:11  *** bralyclo_ has quit IRC
403 2018-10-17T19:35:56  *** bergz has left #bitcoin-core-dev
404 2018-10-17T19:38:41  *** AaronvanW has quit IRC
405 2018-10-17T19:39:12  *** Zenton has quit IRC
406 2018-10-17T19:39:23  *** Zenton has joined #bitcoin-core-dev
407 2018-10-17T19:42:39  *** jpe has joined #bitcoin-core-dev
408 2018-10-17T19:46:21  *** jarthur has quit IRC
409 2018-10-17T19:47:03  *** jarthur has joined #bitcoin-core-dev
410 2018-10-17T19:51:15  *** AaronvanW has joined #bitcoin-core-dev
411 2018-10-17T19:57:04  *** ra_ has joined #bitcoin-core-dev
412 2018-10-17T19:57:49  <ra_> Hello Everyone
413 2018-10-17T19:58:49  *** leishman has joined #bitcoin-core-dev
414 2018-10-17T20:00:06  <ra_> Hello Lei
415 2018-10-17T20:02:30  *** ra_ has quit IRC
416 2018-10-17T20:07:07  *** michaelsdunn1 has quit IRC
417 2018-10-17T20:09:22  *** michaelsdunn1 has joined #bitcoin-core-dev
418 2018-10-17T20:09:22  *** michaelsdunn1 has quit IRC
419 2018-10-17T20:09:22  *** michaelsdunn1 has joined #bitcoin-core-dev
420 2018-10-17T20:12:27  *** michaelsdunn1 has quit IRC
421 2018-10-17T20:13:48  *** laurentmt has quit IRC
422 2018-10-17T20:17:10  *** iphelix_ has left #bitcoin-core-dev
423 2018-10-17T20:26:34  *** michaelsdunn1 has joined #bitcoin-core-dev
424 2018-10-17T20:26:34  *** michaelsdunn1 has quit IRC
425 2018-10-17T20:26:34  *** michaelsdunn1 has joined #bitcoin-core-dev
426 2018-10-17T20:27:10  *** iceberg has joined #bitcoin-core-dev
427 2018-10-17T20:30:19  *** leishman has quit IRC
428 2018-10-17T20:33:14  *** leishman has joined #bitcoin-core-dev
429 2018-10-17T20:34:20  *** belcher has joined #bitcoin-core-dev
430 2018-10-17T20:38:54  <iceberg> Hello, I would like to ask question related to the hot wallet implementation of Gemini. Gemini is using the CloudHSM (the cloud-based HSM of AWS) for their hot wallet. As far as I know CloudHSM does not support the secp256k1. How is it possible to implement such a solution? Can such a solution be as safe as if the CloudHSM was supporting the secp256k1? I also asked the question on stack exchange https://tinyurl.com/yaq8al5
431 2018-10-17T20:39:44  <sipa> you'll need to ask gemini :)
432 2018-10-17T20:39:46  <iceberg> I am sorry if the question is not relevant for this channel, but I am very curious...
433 2018-10-17T20:40:22  <sipa> to me personally, "cloud HSM" sounds like marketing nonsense, but I haven't really looked into it
434 2018-10-17T20:40:50  <sipa> but yes, off topic here
435 2018-10-17T20:42:03  <iceberg> I asked Gemini and they replied with a link from their website, which didn't help. Thanks for the reply.
436 2018-10-17T20:45:27  *** leishman has quit IRC
437 2018-10-17T20:46:01  *** leishman has joined #bitcoin-core-dev
438 2018-10-17T20:46:50  <gmaxwell> I don't know anything about gemini, but it is routine for bitcoin companies to more or less outright lie about their security.
439 2018-10-17T20:46:50  *** Krellan has quit IRC
440 2018-10-17T20:47:00  <gmaxwell> MTGox also claimed to be using HSMs, for example.
441 2018-10-17T20:47:42  *** Krellan has joined #bitcoin-core-dev
442 2018-10-17T20:47:53  <gmaxwell> Using 'cloud hsm' might just mean they're securing passwords using it. Or they keep the private keys in it normally but routinely export them for signing.
443 2018-10-17T20:48:33  <sipa> i assume that if gemini claims to be using amazon cloudhsm, then they're indeed actually using those in some kind or form. whether that product actually gives them a security advantage is a very different question though :)
444 2018-10-17T20:48:59  <gmaxwell> Yes, indeed.
445 2018-10-17T20:50:27  *** leishman has quit IRC
446 2018-10-17T20:59:43  <phantomcircuit> iceberg, there's keystorage which is what i assume they're using
447 2018-10-17T20:59:54  <phantomcircuit> i cant see how that would provide any meaningful security
448 2018-10-17T21:01:49  <phantomcircuit> gmaxwell, well he had them at least
449 2018-10-17T21:01:50  <phantomcircuit> lol
450 2018-10-17T21:06:36  *** ossifrage_ is now known as ossifrage
451 2018-10-17T21:12:09  *** leishman has joined #bitcoin-core-dev
452 2018-10-17T21:17:58  *** leishman has quit IRC
453 2018-10-17T21:21:07  *** qu4ku has joined #bitcoin-core-dev
454 2018-10-17T21:24:24  *** otoburb has joined #bitcoin-core-dev
455 2018-10-17T21:24:55  *** iceberg has quit IRC
456 2018-10-17T21:27:10  *** justanotheruser has quit IRC
457 2018-10-17T21:32:51  *** ap4lmtree has joined #bitcoin-core-dev
458 2018-10-17T21:32:52  <ap4lmtree> hi
459 2018-10-17T21:36:27  *** michaelsdunn1 has quit IRC
460 2018-10-17T21:36:44  *** leishman has joined #bitcoin-core-dev
461 2018-10-17T21:37:54  *** justanotheruser has joined #bitcoin-core-dev
462 2018-10-17T21:39:39  *** qu4ku has quit IRC
463 2018-10-17T21:41:13  *** leishman has quit IRC
464 2018-10-17T21:46:31  <sipa> what's up with appveyor failing random builds?
465 2018-10-17T21:47:19  <sipa> or am i actually doing something wrong that travis doesn't catch?
466 2018-10-17T21:47:54  *** leishman has joined #bitcoin-core-dev
467 2018-10-17T21:48:14  <phantomcircuit> sipa, which tests fail?
468 2018-10-17T21:48:43  <sipa> i've seen ua_comment fail a few times
469 2018-10-17T21:49:07  <sipa> now also example_test: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19592226
470 2018-10-17T21:51:31  <sipa> wth is example_test anyway
471 2018-10-17T21:52:05  <meshcollider> sipa: see #14446
472 2018-10-17T21:52:05  <gribble> https://github.com/bitcoin/bitcoin/issues/14446 | tests: Some issue about running functional tests on Windows · Issue #14446 · bitcoin/bitcoin · GitHub
473 2018-10-17T21:52:55  <andytoshi> seeing failures in rust-land too https://github.com/solson/miri/pull/485
474 2018-10-17T21:53:06  <jamesob> I've seen a lot of spurious appveyor failures recently too - and they queue up pretty deep so green lights take forever to come on
475 2018-10-17T21:53:29  <jamesob> we use that for windows testing, right?
476 2018-10-17T21:53:33  <sipa> yes
477 2018-10-17T21:54:02  <sipa> specifically, msvc-built windows - which isn't used for production anywhere
478 2018-10-17T21:55:57  <meshcollider> Ugh if someone suggests changes in that new commit thing then you can't reply to their comments
479 2018-10-17T22:01:47  *** g687 has quit IRC
480 2018-10-17T22:17:35  <ken2812221> sipa: Instead of disabling the CI, why don't do review #13501 and #14465 ASAP?
481 2018-10-17T22:17:37  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
482 2018-10-17T22:17:38  <gribble> https://github.com/bitcoin/bitcoin/issues/14465 | tests: Stop node before removing the notification file by ken2812221 · Pull Request #14465 · bitcoin/bitcoin · GitHub
483 2018-10-17T22:19:52  *** tknp has joined #bitcoin-core-dev
484 2018-10-17T22:20:23  <ken2812221> The act the same behaviour with mingw builds
485 2018-10-17T22:21:37  <sipa> ken2812221: i had no idea there was a fix
486 2018-10-17T22:21:58  <sipa> ken2812221: perhaps you should comment there is one on 14446?
487 2018-10-17T22:22:42  <ken2812221> I did mention them in issue description.
488 2018-10-17T22:23:32  <sipa> ken2812221: my apologies
489 2018-10-17T22:24:49  <sipa> i didn't notice there were fixes mentioned
490 2018-10-17T22:26:18  *** harding_ is now known as harding
491 2018-10-17T22:27:00  *** profmac has quit IRC
492 2018-10-17T22:29:55  <ken2812221> Now I use bold font to mention to fixes in the description. Hope that people won't ignore them again.
493 2018-10-17T22:34:54  <sipa> ken2812221: thanks!
494 2018-10-17T22:36:22  <sipa> ken2812221: i'm sorry if i came about as dismissive about appveyor, but i was a bit annoyed how it is interfering with development for little purpose (being compatible with building on windows is a nice to have, but it's not like we'll create production binaries that way)... though i have to take my words back if there are actual issues that are at the basis here
495 2018-10-17T22:41:08  *** Guyver2 has quit IRC
496 2018-10-17T22:41:34  *** jarthur has quit IRC
497 2018-10-17T22:42:50  *** leishman has quit IRC
498 2018-10-17T22:46:40  <jnewbery> sipa: example_test is an example test, for people who don't know how to use our test framework. It didn't used to run in CI. It shouldn't ever fail
499 2018-10-17T22:49:51  <ken2812221> As laanwj say, the appveyor ci status is not merge blocker. It's a bit racy on Windows, so the error shows more often, we could find the same issue on travis sometimes.
500 2018-10-17T22:57:37  *** profmac has joined #bitcoin-core-dev
501 2018-10-17T23:04:03  *** leishman has joined #bitcoin-core-dev
502 2018-10-17T23:07:31  *** Chris_Stewart_5 has quit IRC
503 2018-10-17T23:08:06  *** tknp has quit IRC
504 2018-10-17T23:08:36  *** tknp has joined #bitcoin-core-dev
505 2018-10-17T23:08:48  *** tknp has quit IRC
506 2018-10-17T23:10:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
507 2018-10-17T23:13:04  *** jarthur has joined #bitcoin-core-dev
508 2018-10-17T23:16:00  *** romanz_ has joined #bitcoin-core-dev
509 2018-10-17T23:16:37  *** Aaronvan_ has joined #bitcoin-core-dev
510 2018-10-17T23:17:48  *** jarthur has quit IRC
511 2018-10-17T23:17:56  *** romanz has quit IRC
512 2018-10-17T23:20:11  *** AaronvanW has quit IRC
513 2018-10-17T23:29:19  *** josephnicholas has joined #bitcoin-core-dev
514 2018-10-17T23:36:39  *** Zenton has quit IRC
515 2018-10-17T23:38:10  *** leishman has quit IRC
516 2018-10-17T23:38:44  *** leishman has joined #bitcoin-core-dev
517 2018-10-17T23:41:40  *** Zenton has joined #bitcoin-core-dev
518 2018-10-17T23:42:58  *** leishman has quit IRC
519 2018-10-17T23:43:36  *** leishman has joined #bitcoin-core-dev
520 2018-10-17T23:49:11  *** leishman has quit IRC
521 2018-10-17T23:49:43  *** leishman has joined #bitcoin-core-dev
522 2018-10-17T23:53:41  <promag> jnewbery: I think #13339 can be added to https://github.com/bitcoin/bitcoin/projects/2?
523 2018-10-17T23:53:43  <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
524 2018-10-17T23:53:50  *** leishman has quit IRC