12018-10-23T00:17:45 *** hebasto_ has quit IRC
22018-10-23T00:18:08 *** hebasto_ has joined #bitcoin-core-dev
32018-10-23T00:37:13 *** bitcoin-git has joined #bitcoin-core-dev
42018-10-23T00:37:13 <bitcoin-git> [bitcoin] charlesrocket closed pull request #14539: add Apple SDK download to gitian-build.py (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539
52018-10-23T00:37:13 *** bitcoin-git has left #bitcoin-core-dev
62018-10-23T00:40:18 *** AaronvanW has joined #bitcoin-core-dev
72018-10-23T00:51:13 *** ken2812221 has joined #bitcoin-core-dev
82018-10-23T01:01:01 *** rh0nj has quit IRC
92018-10-23T01:02:08 *** rh0nj has joined #bitcoin-core-dev
102018-10-23T01:13:35 *** AaronvanW has quit IRC
112018-10-23T01:17:41 *** spinza has quit IRC
122018-10-23T01:21:02 *** Krellan has joined #bitcoin-core-dev
132018-10-23T01:27:36 *** spinza has joined #bitcoin-core-dev
142018-10-23T01:30:08 *** cubancorona has joined #bitcoin-core-dev
152018-10-23T01:30:54 *** cubancorona has quit IRC
162018-10-23T01:32:54 *** Krellan has quit IRC
172018-10-23T01:32:59 *** Randolf has joined #bitcoin-core-dev
182018-10-23T01:34:04 *** rafalcpp_ has quit IRC
192018-10-23T01:34:30 *** rafalcpp_ has joined #bitcoin-core-dev
202018-10-23T01:43:33 *** bitcoin-git has joined #bitcoin-core-dev
212018-10-23T01:43:34 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8f519a0626...b3f377daaa86
222018-10-23T01:43:34 <bitcoin-git> bitcoin/master 5918204 Martin Erlandsson: Removed explicit mention of storage requirement (squashed)...
232018-10-23T01:43:35 <bitcoin-git> bitcoin/master b3f377d Pieter Wuille: Merge #14511: doc: Remove explicit storage requirement from README.md...
242018-10-23T01:43:35 *** bitcoin-git has left #bitcoin-core-dev
252018-10-23T01:44:38 *** bitcoin-git has joined #bitcoin-core-dev
262018-10-23T01:44:38 <bitcoin-git> [bitcoin] sipa closed pull request #14511: doc: Remove explicit storage requirement from README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
272018-10-23T01:44:38 *** bitcoin-git has left #bitcoin-core-dev
282018-10-23T02:05:24 *** mr_paz has joined #bitcoin-core-dev
292018-10-23T02:25:44 *** Murch has quit IRC
302018-10-23T02:33:05 *** ken2812221 has quit IRC
312018-10-23T02:33:14 *** sanket1729_ has joined #bitcoin-core-dev
322018-10-23T02:37:40 *** sanket1729_ has quit IRC
332018-10-23T03:00:12 <sipa> status.github.com reports everything operating normally again, since 4 hours ago
342018-10-23T03:00:29 <sipa> the whole incident lasted 23h54m ...
352018-10-23T03:12:12 *** spinza has quit IRC
362018-10-23T03:17:37 *** Guest74867 is now known as iphelix
372018-10-23T03:17:38 *** iphelix has joined #bitcoin-core-dev
382018-10-23T03:26:58 <meshcollider> Ouch
392018-10-23T03:40:27 *** Randolf has quit IRC
402018-10-23T03:41:14 *** Randolf has joined #bitcoin-core-dev
412018-10-23T03:53:07 *** schnerchi has joined #bitcoin-core-dev
422018-10-23T03:56:40 *** schnerch_ has quit IRC
432018-10-23T04:16:18 *** sanket1729 has joined #bitcoin-core-dev
442018-10-23T04:19:29 *** spinza has joined #bitcoin-core-dev
452018-10-23T04:26:05 *** AaronvanW has joined #bitcoin-core-dev
462018-10-23T04:31:33 *** AaronvanW has quit IRC
472018-10-23T04:55:25 *** Tralfaz has quit IRC
482018-10-23T04:58:53 *** bitcoin-git has joined #bitcoin-core-dev
492018-10-23T04:58:54 <bitcoin-git> [bitcoin] preserveddarnell opened pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
502018-10-23T04:58:54 *** bitcoin-git has left #bitcoin-core-dev
512018-10-23T05:01:42 *** bitcoin-git has joined #bitcoin-core-dev
522018-10-23T05:01:42 <bitcoin-git> [bitcoin] fanquake closed pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
532018-10-23T05:01:42 *** bitcoin-git has left #bitcoin-core-dev
542018-10-23T05:05:47 *** bitcoin-git has joined #bitcoin-core-dev
552018-10-23T05:05:47 <bitcoin-git> [bitcoin] preserveddarnell opened pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
562018-10-23T05:05:47 *** bitcoin-git has left #bitcoin-core-dev
572018-10-23T05:22:52 *** bitconner has quit IRC
582018-10-23T05:49:18 *** Tralfaz has joined #bitcoin-core-dev
592018-10-23T05:57:24 *** AaronvanW has joined #bitcoin-core-dev
602018-10-23T05:57:40 *** Tralfaz has quit IRC
612018-10-23T06:00:13 *** Tralfaz has joined #bitcoin-core-dev
622018-10-23T06:08:02 *** rh0nj has quit IRC
632018-10-23T06:09:07 *** rh0nj has joined #bitcoin-core-dev
642018-10-23T06:32:58 *** panako has joined #bitcoin-core-dev
652018-10-23T06:40:33 *** martinus__ has joined #bitcoin-core-dev
662018-10-23T06:44:35 *** martinus_ has quit IRC
672018-10-23T06:46:26 *** AaronvanW has quit IRC
682018-10-23T06:56:46 *** AaronvanW has joined #bitcoin-core-dev
692018-10-23T06:58:47 *** josephnicholas has joined #bitcoin-core-dev
702018-10-23T07:01:41 *** AaronvanW has quit IRC
712018-10-23T07:04:20 *** setpill has joined #bitcoin-core-dev
722018-10-23T07:10:23 *** Hassaan121 has joined #bitcoin-core-dev
732018-10-23T07:10:47 *** Hassaan121 has left #bitcoin-core-dev
742018-10-23T07:12:41 *** bitcoin-git has joined #bitcoin-core-dev
752018-10-23T07:12:41 <bitcoin-git> [bitcoin] laanwj closed pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
762018-10-23T07:12:41 *** bitcoin-git has left #bitcoin-core-dev
772018-10-23T07:18:43 *** jungly has joined #bitcoin-core-dev
782018-10-23T07:18:44 *** gribble has quit IRC
792018-10-23T07:20:51 *** josephni_ has joined #bitcoin-core-dev
802018-10-23T07:22:16 *** josephnicholas has quit IRC
812018-10-23T07:23:16 *** sanket1729 has quit IRC
822018-10-23T07:28:37 *** gribble has joined #bitcoin-core-dev
832018-10-23T07:40:50 *** Krellan has joined #bitcoin-core-dev
842018-10-23T07:41:40 *** Krellan_ has joined #bitcoin-core-dev
852018-10-23T07:43:42 *** michaelfolkson has joined #bitcoin-core-dev
862018-10-23T07:45:40 *** Krellan has quit IRC
872018-10-23T07:58:05 *** AaronvanW has joined #bitcoin-core-dev
882018-10-23T08:00:07 *** bitcoin-git has joined #bitcoin-core-dev
892018-10-23T08:00:07 <bitcoin-git> [bitcoin] ken2812221 opened pull request #14552: wallet: throw an error if user load the wallet file by different ways (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
902018-10-23T08:00:07 *** bitcoin-git has left #bitcoin-core-dev
912018-10-23T08:03:07 *** AaronvanW has quit IRC
922018-10-23T08:16:47 *** josephni_ has quit IRC
932018-10-23T08:18:17 *** laurentmt has joined #bitcoin-core-dev
942018-10-23T08:21:57 *** laurentmt has quit IRC
952018-10-23T08:24:00 *** timothy has joined #bitcoin-core-dev
962018-10-23T08:37:47 *** Randolf has quit IRC
972018-10-23T08:38:53 *** Randolf has joined #bitcoin-core-dev
982018-10-23T08:44:55 *** AaronvanW has joined #bitcoin-core-dev
992018-10-23T08:48:11 *** OzPac has joined #bitcoin-core-dev
1002018-10-23T08:50:56 *** panako has quit IRC
1012018-10-23T09:07:58 *** josephnicholas has joined #bitcoin-core-dev
1022018-10-23T09:12:07 *** josephnicholas has quit IRC
1032018-10-23T09:21:16 *** josephnicholas has joined #bitcoin-core-dev
1042018-10-23T09:23:11 *** michaelfolkson has quit IRC
1052018-10-23T09:45:19 *** josephnicholas has quit IRC
1062018-10-23T09:45:53 *** josephnicholas has joined #bitcoin-core-dev
1072018-10-23T09:46:23 *** michaelfolkson has joined #bitcoin-core-dev
1082018-10-23T09:49:37 *** laurentmt has joined #bitcoin-core-dev
1092018-10-23T09:50:07 *** josephnicholas has quit IRC
1102018-10-23T09:53:53 *** ap4lmtree has joined #bitcoin-core-dev
1112018-10-23T10:11:19 *** spinza has quit IRC
1122018-10-23T10:18:23 *** b77 has joined #bitcoin-core-dev
1132018-10-23T10:18:51 *** b77 has quit IRC
1142018-10-23T10:22:52 *** klot has joined #bitcoin-core-dev
1152018-10-23T10:23:37 *** bitconner has joined #bitcoin-core-dev
1162018-10-23T10:23:43 *** spinza has joined #bitcoin-core-dev
1172018-10-23T10:23:43 *** klot has quit IRC
1182018-10-23T10:24:08 *** klot has joined #bitcoin-core-dev
1192018-10-23T10:24:41 *** laurentmt has quit IRC
1202018-10-23T10:25:13 *** klot has quit IRC
1212018-10-23T10:25:38 *** klot has joined #bitcoin-core-dev
1222018-10-23T10:26:43 *** klot has quit IRC
1232018-10-23T10:27:12 *** klot has joined #bitcoin-core-dev
1242018-10-23T10:28:21 *** bitconner has quit IRC
1252018-10-23T10:38:07 *** shesek has quit IRC
1262018-10-23T10:43:03 *** sakalli_ has joined #bitcoin-core-dev
1272018-10-23T10:45:27 *** sakalli_ has quit IRC
1282018-10-23T10:52:45 *** josephnicholas has joined #bitcoin-core-dev
1292018-10-23T10:57:09 *** josephnicholas has quit IRC
1302018-10-23T11:18:26 *** Guyver2 has joined #bitcoin-core-dev
1312018-10-23T11:31:57 *** josephnicholas has joined #bitcoin-core-dev
1322018-10-23T11:36:37 *** michaelfolkson has quit IRC
1332018-10-23T11:47:32 *** josephnicholas_ has joined #bitcoin-core-dev
1342018-10-23T11:48:07 *** josephnicholas has quit IRC
1352018-10-23T11:48:25 <josephnicholas_> Hello all
1362018-10-23T11:55:23 *** michaelfolkson has joined #bitcoin-core-dev
1372018-10-23T11:57:24 *** Krellan_ has quit IRC
1382018-10-23T11:57:50 *** ken2812221 has joined #bitcoin-core-dev
1392018-10-23T11:58:28 *** Krellan has joined #bitcoin-core-dev
1402018-10-23T12:00:09 *** intcat has quit IRC
1412018-10-23T12:02:28 *** intcat has joined #bitcoin-core-dev
1422018-10-23T12:05:14 *** michaelfolkson has quit IRC
1432018-10-23T12:06:10 *** michaelfolkson has joined #bitcoin-core-dev
1442018-10-23T12:17:15 *** josephnicholas_ has quit IRC
1452018-10-23T12:18:33 *** michaelfolkson has quit IRC
1462018-10-23T12:22:50 *** michaelfolkson has joined #bitcoin-core-dev
1472018-10-23T12:23:52 *** bitconner has joined #bitcoin-core-dev
1482018-10-23T12:28:16 *** bitconner has quit IRC
1492018-10-23T12:32:23 *** IGHOR has quit IRC
1502018-10-23T12:49:43 *** ken2812221 has quit IRC
1512018-10-23T12:50:59 *** map has joined #bitcoin-core-dev
1522018-10-23T12:51:24 *** map is now known as Guest8103
1532018-10-23T12:52:08 *** Guest8103 has quit IRC
1542018-10-23T12:53:22 *** panako has joined #bitcoin-core-dev
1552018-10-23T12:58:35 *** ghost43 has quit IRC
1562018-10-23T12:58:52 *** ghost43 has joined #bitcoin-core-dev
1572018-10-23T13:03:31 *** setpill has quit IRC
1582018-10-23T13:06:28 *** klot has quit IRC
1592018-10-23T13:07:13 *** klot has joined #bitcoin-core-dev
1602018-10-23T13:08:15 *** unifiedh has joined #bitcoin-core-dev
1612018-10-23T13:08:24 *** klot has quit IRC
1622018-10-23T13:08:55 *** klot has joined #bitcoin-core-dev
1632018-10-23T13:09:52 *** bitcoin-git has joined #bitcoin-core-dev
1642018-10-23T13:09:53 <bitcoin-git> [bitcoin] merland opened pull request #14553: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
1652018-10-23T13:09:53 *** bitcoin-git has left #bitcoin-core-dev
1662018-10-23T13:09:55 *** spinza has quit IRC
1672018-10-23T13:10:44 *** zautomata has joined #bitcoin-core-dev
1682018-10-23T13:10:55 *** zautomata has joined #bitcoin-core-dev
1692018-10-23T13:12:04 *** Randolf has quit IRC
1702018-10-23T13:12:16 *** zautomata has left #bitcoin-core-dev
1712018-10-23T13:15:23 *** Randolf has joined #bitcoin-core-dev
1722018-10-23T13:31:33 *** spinza has joined #bitcoin-core-dev
1732018-10-23T13:33:48 *** michaelfolkson has quit IRC
1742018-10-23T13:41:51 *** michaelfolkson has joined #bitcoin-core-dev
1752018-10-23T14:08:11 *** Krellan has quit IRC
1762018-10-23T14:09:09 *** michaelfolkson has quit IRC
1772018-10-23T14:09:40 *** Krellan has joined #bitcoin-core-dev
1782018-10-23T14:24:07 *** bitconner has joined #bitcoin-core-dev
1792018-10-23T14:26:25 *** kihjhgzh has joined #bitcoin-core-dev
1802018-10-23T14:27:56 *** kihjhgzh has quit IRC
1812018-10-23T14:28:52 *** bitconner has quit IRC
1822018-10-23T14:36:31 *** michaelsdunn1 has joined #bitcoin-core-dev
1832018-10-23T14:45:36 *** bitcoin-git has joined #bitcoin-core-dev
1842018-10-23T14:45:36 <bitcoin-git> [bitcoin] hebasto opened pull request #14554: qt: Remove unused `adjustedTime` parameter (master...20181023-unused-adjustedtime) https://github.com/bitcoin/bitcoin/pull/14554
1852018-10-23T14:45:36 *** bitcoin-git has left #bitcoin-core-dev
1862018-10-23T14:48:23 *** IGHOR has joined #bitcoin-core-dev
1872018-10-23T14:49:47 *** hebasto_ has quit IRC
1882018-10-23T14:50:22 *** hebasto has joined #bitcoin-core-dev
1892018-10-23T14:55:39 *** michaelfolkson has joined #bitcoin-core-dev
1902018-10-23T14:59:26 *** unifiedh has quit IRC
1912018-10-23T15:03:31 *** michaelfolkson has quit IRC
1922018-10-23T15:16:18 *** Sinclair6 has joined #bitcoin-core-dev
1932018-10-23T15:18:56 *** atroxes_ has joined #bitcoin-core-dev
1942018-10-23T15:19:45 *** jarthur has joined #bitcoin-core-dev
1952018-10-23T15:20:25 *** atroxes has quit IRC
1962018-10-23T15:20:26 *** atroxes_ is now known as atroxes
1972018-10-23T15:32:46 *** klot has quit IRC
1982018-10-23T15:33:30 *** promag has quit IRC
1992018-10-23T15:34:59 *** klot has joined #bitcoin-core-dev
2002018-10-23T15:36:07 *** klot has quit IRC
2012018-10-23T15:36:35 *** klot has joined #bitcoin-core-dev
2022018-10-23T15:37:37 *** klot has quit IRC
2032018-10-23T15:38:02 *** klot has joined #bitcoin-core-dev
2042018-10-23T15:39:07 *** klot has quit IRC
2052018-10-23T15:39:33 *** klot has joined #bitcoin-core-dev
2062018-10-23T15:40:37 *** klot has quit IRC
2072018-10-23T15:40:52 *** timothy has quit IRC
2082018-10-23T15:41:02 *** klot has joined #bitcoin-core-dev
2092018-10-23T15:42:04 *** Randolf has quit IRC
2102018-10-23T15:42:07 *** klot has quit IRC
2112018-10-23T15:42:34 *** klot has joined #bitcoin-core-dev
2122018-10-23T15:43:00 *** panako has quit IRC
2132018-10-23T15:43:37 *** klot has quit IRC
2142018-10-23T15:44:02 *** klot has joined #bitcoin-core-dev
2152018-10-23T15:44:15 *** justan0theruser has quit IRC
2162018-10-23T15:45:07 *** klot has quit IRC
2172018-10-23T15:45:43 *** klot has joined #bitcoin-core-dev
2182018-10-23T15:58:30 *** Mutter has joined #bitcoin-core-dev
2192018-10-23T15:59:19 <Mutter> Hi
2202018-10-23T16:03:40 *** Mutter has quit IRC
2212018-10-23T16:05:42 *** Krellan has quit IRC
2222018-10-23T16:08:44 *** wumpus has quit IRC
2232018-10-23T16:09:10 *** promag has joined #bitcoin-core-dev
2242018-10-23T16:10:39 *** laurentmt has joined #bitcoin-core-dev
2252018-10-23T16:13:01 *** laurentmt has quit IRC
2262018-10-23T16:14:01 *** sipa has quit IRC
2272018-10-23T16:14:17 *** justan0theruser has joined #bitcoin-core-dev
2282018-10-23T16:14:22 *** ircclient has joined #bitcoin-core-dev
2292018-10-23T16:20:18 *** Krellan has joined #bitcoin-core-dev
2302018-10-23T16:24:21 *** bitconner has joined #bitcoin-core-dev
2312018-10-23T16:24:27 *** sipa has joined #bitcoin-core-dev
2322018-10-23T16:28:36 *** bitconner has quit IRC
2332018-10-23T16:33:11 *** promag has quit IRC
2342018-10-23T16:33:54 *** mr_paz has quit IRC
2352018-10-23T16:34:12 *** HASAN_K has joined #bitcoin-core-dev
2362018-10-23T16:38:18 *** promag has joined #bitcoin-core-dev
2372018-10-23T16:38:27 *** HASAN_K has quit IRC
2382018-10-23T16:43:01 *** Murch has joined #bitcoin-core-dev
2392018-10-23T16:44:23 *** Murch has quit IRC
2402018-10-23T16:47:28 *** ircclient has quit IRC
2412018-10-23T16:51:38 *** Murch has joined #bitcoin-core-dev
2422018-10-23T16:57:08 *** ircclient has joined #bitcoin-core-dev
2432018-10-23T16:57:22 <promag> wumpus not around?
2442018-10-23T16:57:38 <ircclient> just messing with my IRC client
2452018-10-23T16:57:47 *** ircclient is now known as wumpus
2462018-10-23T16:57:47 <promag> kallewoof: I'd love some feedback on #14531
2472018-10-23T16:57:49 <gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
2482018-10-23T16:57:52 <promag> :D
2492018-10-23T16:58:04 <promag> please replace my PR on HP with 14531
2502018-10-23T16:58:17 <promag> I think is more important to fix something first
2512018-10-23T16:59:21 <wumpus> added
2522018-10-23T17:00:58 *** jungly has quit IRC
2532018-10-23T17:05:17 <promag> thanks
2542018-10-23T17:06:02 <promag> also see #12842 (2 lines change) and #14518 (small change)
2552018-10-23T17:06:05 <gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
2562018-10-23T17:06:06 <gribble> https://github.com/bitcoin/bitcoin/issues/14518 | rpc: Always throw in getblockstats if -txindex is required by promag · Pull Request #14518 · bitcoin/bitcoin · GitHub
2572018-10-23T17:08:43 *** klot has quit IRC
2582018-10-23T17:09:42 *** klot has joined #bitcoin-core-dev
2592018-10-23T17:10:45 *** klot has quit IRC
2602018-10-23T17:11:09 *** klot has joined #bitcoin-core-dev
2612018-10-23T17:12:09 *** promag has quit IRC
2622018-10-23T17:12:15 *** klot has quit IRC
2632018-10-23T17:12:40 *** klot has joined #bitcoin-core-dev
2642018-10-23T17:13:26 *** bitcoin-git has joined #bitcoin-core-dev
2652018-10-23T17:13:26 <bitcoin-git> [bitcoin] jimpo opened pull request #14555: Move util files to directory (master...util-cleanup) https://github.com/bitcoin/bitcoin/pull/14555
2662018-10-23T17:13:26 *** bitcoin-git has left #bitcoin-core-dev
2672018-10-23T17:13:45 *** klot has quit IRC
2682018-10-23T17:14:14 *** klot has joined #bitcoin-core-dev
2692018-10-23T17:15:15 *** klot has quit IRC
2702018-10-23T17:15:44 *** klot has joined #bitcoin-core-dev
2712018-10-23T17:16:45 *** klot has quit IRC
2722018-10-23T17:17:13 *** klot has joined #bitcoin-core-dev
2732018-10-23T17:18:15 *** klot has quit IRC
2742018-10-23T17:18:43 *** klot has joined #bitcoin-core-dev
2752018-10-23T17:19:42 *** bitconner has joined #bitcoin-core-dev
2762018-10-23T17:19:45 *** klot has quit IRC
2772018-10-23T17:20:09 *** klot has joined #bitcoin-core-dev
2782018-10-23T17:21:15 *** klot has quit IRC
2792018-10-23T17:21:39 *** klot has joined #bitcoin-core-dev
2802018-10-23T17:22:45 *** klot has quit IRC
2812018-10-23T17:23:13 *** klot has joined #bitcoin-core-dev
2822018-10-23T17:24:09 *** bitconner has quit IRC
2832018-10-23T17:24:15 *** klot has quit IRC
2842018-10-23T17:24:44 *** klot has joined #bitcoin-core-dev
2852018-10-23T17:25:45 *** klot has quit IRC
2862018-10-23T17:26:12 *** klot has joined #bitcoin-core-dev
2872018-10-23T17:27:15 *** klot has quit IRC
2882018-10-23T17:27:42 *** klot has joined #bitcoin-core-dev
2892018-10-23T17:28:43 *** Sinclai__ has joined #bitcoin-core-dev
2902018-10-23T17:28:45 *** klot has quit IRC
2912018-10-23T17:29:09 *** klot has joined #bitcoin-core-dev
2922018-10-23T17:30:15 *** klot has quit IRC
2932018-10-23T17:30:43 *** klot has joined #bitcoin-core-dev
2942018-10-23T17:31:21 *** Sinclair6 has quit IRC
2952018-10-23T17:31:45 *** klot has quit IRC
2962018-10-23T17:32:12 *** klot has joined #bitcoin-core-dev
2972018-10-23T17:33:15 *** klot has quit IRC
2982018-10-23T17:33:21 *** Murch has quit IRC
2992018-10-23T17:33:42 *** klot has joined #bitcoin-core-dev
3002018-10-23T17:37:08 *** Krellan has quit IRC
3012018-10-23T17:42:10 *** Murch has joined #bitcoin-core-dev
3022018-10-23T17:49:12 *** rafalcpp_ is now known as rafalcpp
3032018-10-23T18:15:32 *** bitconner has joined #bitcoin-core-dev
3042018-10-23T18:20:28 *** bitconner has quit IRC
3052018-10-23T18:27:21 <stevenroose> Anyone here any experience with the Travis tests? We copied them for Elements and the one with NOWALLET=1 times out consistently. Could anyone tell what the NOWALLET=1 exactly involves?
3062018-10-23T18:28:33 *** owowo has quit IRC
3072018-10-23T18:34:18 *** owowo has joined #bitcoin-core-dev
3082018-10-23T18:58:04 *** zxzzt has joined #bitcoin-core-dev
3092018-10-23T19:06:20 *** Aaronvan_ has joined #bitcoin-core-dev
3102018-10-23T19:09:07 *** AaronvanW has quit IRC
3112018-10-23T19:11:33 *** klot has quit IRC
3122018-10-23T19:11:36 <jamesob> when's the last time someone proposed a "trace"-level logger that wouldn't ever be enabled for production, but might be useful during testing/debugging
3132018-10-23T19:11:47 *** klot has joined #bitcoin-core-dev
3142018-10-23T19:15:46 *** reallll has joined #bitcoin-core-dev
3152018-10-23T19:16:19 *** klot has quit IRC
3162018-10-23T19:19:16 *** belcher_ has quit IRC
3172018-10-23T19:28:43 *** hebasto has quit IRC
3182018-10-23T19:28:58 *** reallll is now known as belcher_
3192018-10-23T19:29:04 *** hebasto has joined #bitcoin-core-dev
3202018-10-23T19:29:55 *** bitcoin-git has joined #bitcoin-core-dev
3212018-10-23T19:29:55 <bitcoin-git> [bitcoin] hebasto opened pull request #14556: qt: Fix bug #13299 (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
3222018-10-23T19:29:55 *** bitcoin-git has left #bitcoin-core-dev
3232018-10-23T19:30:19 <BlueMatt> jamesob: isnt that kinda what -debug=1 means?
3242018-10-23T19:30:27 <BlueMatt> I mean it prints all your inbound/outbound messages...
3252018-10-23T19:40:11 <jamesob> yeah, suppose so - but we're missing a lot of logging around tx validation and peer treatment
3262018-10-23T19:41:31 <BlueMatt> fair enough, probably worth adding? Could add another debug category if its too voluminous
3272018-10-23T19:58:54 *** dqx_ has joined #bitcoin-core-dev
3282018-10-23T20:02:54 *** OzPac has quit IRC
3292018-10-23T20:03:22 *** bitconner has joined #bitcoin-core-dev
3302018-10-23T20:08:28 *** bitconner has quit IRC
3312018-10-23T20:14:36 <jamesob> yup, sounds good
3322018-10-23T20:14:48 <phantomcircuit> jamesob, there could certainly be many more log lines
3332018-10-23T20:15:03 <phantomcircuit> but not that even when you're not logging things the LogPrint function takes some time
3342018-10-23T20:18:59 <sipa> phantomcircuit: note that LogPrintf doesn't serialize its arguments when the debug category it's on is not enabled
3352018-10-23T20:19:03 <sipa> but the argument are evaluated
3362018-10-23T20:23:52 <wumpus> there's intentionally little/no debug logging around transaction validation, it would just be too spammy and confusing for users as it'd log for every transaction received from the network
3372018-10-23T20:23:56 *** shesek has joined #bitcoin-core-dev
3382018-10-23T20:24:10 <wumpus> but yes I guess it'd work as a separate categoryâ¦
3392018-10-23T20:26:03 <phantomcircuit> sipa, yeah it's very fast, but putting it in a tight loop would be a mistake
3402018-10-23T20:26:52 <gmaxwell> Anyone attempting that should be prepared to prove the change doesn't substantially lower performance when not in use.
3412018-10-23T20:29:42 <phantomcircuit> i wonder if checking for the category TRACE and then exiting unless compile time option was set would allow optimization out completely
3422018-10-23T20:34:23 *** mr_paz has joined #bitcoin-core-dev
3432018-10-23T20:37:18 <sipa> phantomcircuit: yeah certainly
3442018-10-23T20:46:18 <jamesob> phantomcircuit: that's what I had in mind
3452018-10-23T20:46:33 *** Victorsueca has quit IRC
3462018-10-23T20:47:24 <jamesob> TraceLogPrintf as a macro that gets expanded or not based on configure options
3472018-10-23T20:47:49 *** Victorsueca has joined #bitcoin-core-dev
3482018-10-23T20:49:14 <sipa> jamesob: we kindof have that, due to the templated approach that forwards the arguments
3492018-10-23T20:49:35 <sipa> though it would require inlining the function to guarantee the arguments aren't evaluated when needed
3502018-10-23T20:50:14 <luke-jr> #define LogTrace(â¦) if (unlikely(g_trace)) { LogPrintf(__VA_ARGS__); }
3512018-10-23T20:50:16 <luke-jr> maybe
3522018-10-23T20:54:41 <sipa> that has the risk of removing statements with side effects, though
3532018-10-23T20:55:14 <sipa> marking LogPrintf as __attribute__((always_inline)) where permitted is probably safer
3542018-10-23T20:55:23 <sipa> (or whatever the syntax is)
3552018-10-23T20:58:36 *** promag has joined #bitcoin-core-dev
3562018-10-23T21:03:27 *** hebasto has quit IRC
3572018-10-23T21:04:09 *** hebasto has joined #bitcoin-core-dev
3582018-10-23T21:12:05 *** intcat has quit IRC
3592018-10-23T21:15:53 *** intcat has joined #bitcoin-core-dev
3602018-10-23T21:52:26 <luke-jr> sipa: hopefully nobody would use these new things with side-effect stuff.. especially if it's disabled by default
3612018-10-23T21:52:51 <luke-jr> would always_inline actually avoid evaluating the arguments?
3622018-10-23T21:53:27 <sipa> sometimes, sure
3632018-10-23T21:53:50 <sipa> it'd enable the compiler to optimize it out when it provably has no side effectd
3642018-10-23T21:55:38 <luke-jr> proving no side effects can be hard for C++
3652018-10-23T21:55:55 <luke-jr> eg, a copy constructor might have side effects
3662018-10-23T21:56:16 <luke-jr> but maybe the variadic argument situation is better, dunno
3672018-10-23T21:58:21 <sipa> luke-jr: a c++ compiler is allowed to elide copy constructors even if they have side effects :)
3682018-10-23T21:58:27 <luke-jr> interesting
3692018-10-23T21:58:45 <sipa> https://en.cppreference.com/w/cpp/language/copy_elision
3702018-10-23T21:58:46 * luke-jr ponders if there's any way to abuse that for something useful
3712018-10-23T21:59:03 <sipa> since c++17 it's mandatory that where possible, that elision must happen
3722018-10-23T21:59:21 *** hebasto has quit IRC
3732018-10-23T21:59:34 <sipa> before, it was optional, and thus could result in different behaviour depending on the compiler's choice
3742018-10-23T22:00:03 <sipa> i believe it's the only exception to the rule that optimizations are only allowed when they don't change observable behavior
3752018-10-23T22:01:04 <gmaxwell> this sort of stuff where side effects vanish presents the same kind of risk as the assert macro with -UDEBUG.
3762018-10-23T22:01:21 <gmaxwell> (refering to the trace discussion, not copy constructors)
3772018-10-23T22:01:33 *** hebasto has joined #bitcoin-core-dev
3782018-10-23T22:02:24 *** spinza has quit IRC
3792018-10-23T22:02:50 <sipa> actually i expect that log statements have a relatively low chance of accidentally having side effects
3802018-10-23T22:03:19 <sipa> things like assert(OperationIsSuccessful(bla)); isn't too crazy however
3812018-10-23T22:03:21 *** rodarmor has joined #bitcoin-core-dev
3822018-10-23T22:09:16 *** Guyver2 has quit IRC
3832018-10-23T22:17:35 *** bitcoin-git has joined #bitcoin-core-dev
3842018-10-23T22:17:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3f377daaa86...3668bb335c6a
3852018-10-23T22:17:36 <bitcoin-git> bitcoin/master c269209 John Newbery: [tests] Small fixups before deprecating generate...
3862018-10-23T22:17:36 <bitcoin-git> bitcoin/master aab8172 John Newbery: [tests] Add generate method to TestNode...
3872018-10-23T22:17:37 <bitcoin-git> bitcoin/master c9f0295 John Newbery: [wallet] Deprecate the generate RPC method
3882018-10-23T22:17:37 *** bitcoin-git has left #bitcoin-core-dev
3892018-10-23T22:18:57 *** bitcoin-git has joined #bitcoin-core-dev
3902018-10-23T22:18:57 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14468: [wallet] Deprecate generate RPC method (master...deprecate_generate) https://github.com/bitcoin/bitcoin/pull/14468
3912018-10-23T22:18:57 *** bitcoin-git has left #bitcoin-core-dev
3922018-10-23T22:18:57 *** justan0theruser has quit IRC
3932018-10-23T22:24:18 *** spinza has joined #bitcoin-core-dev
3942018-10-23T22:27:01 *** justanotheruser has joined #bitcoin-core-dev
3952018-10-23T22:28:22 <gmaxwell> sipa: do you think that log statements and asserts are really a lot different there?
3962018-10-23T22:28:57 <gmaxwell> LogPrint("tx: %s Valid: %d\n", tx.hash(), ProcessTx(tx));
3972018-10-23T22:32:18 *** Sinclair6 has joined #bitcoin-core-dev
3982018-10-23T22:32:26 *** michaelsdunn1 has quit IRC
3992018-10-23T22:32:58 <sipa> gmaxwell: hmm, i guess i've just encountered those less
4002018-10-23T22:33:06 <sipa> it depends a lot on developer culture i guess
4012018-10-23T22:33:19 <gmaxwell> well that's /the/ assert mistake.
4022018-10-23T22:35:59 *** Sinclai__ has quit IRC
4032018-10-23T22:38:45 *** Aaronvan_ has quit IRC
4042018-10-23T22:39:10 *** spinza has quit IRC
4052018-10-23T22:45:40 *** hebasto has quit IRC
4062018-10-23T22:48:10 *** Murch has quit IRC
4072018-10-23T22:55:55 *** AaronvanW has joined #bitcoin-core-dev
4082018-10-23T23:05:47 *** bitcoin-git has joined #bitcoin-core-dev
4092018-10-23T23:05:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3668bb335c6a...94cf1ec94821
4102018-10-23T23:05:48 <bitcoin-git> bitcoin/master d4d70ed Eric Scrivner: Fix listreceivedbyaddress not taking address as a string...
4112018-10-23T23:05:49 <bitcoin-git> bitcoin/master 94cf1ec MarcoFalke: Merge #14417: Fix listreceivedbyaddress not taking address as a string...
4122018-10-23T23:05:49 *** bitcoin-git has left #bitcoin-core-dev
4132018-10-23T23:06:48 *** bitcoin-git has joined #bitcoin-core-dev
4142018-10-23T23:06:48 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14417: Fix listreceivedbyaddress not taking address as a string (master...fix-rpc-calls-not-taking-valid-strings) https://github.com/bitcoin/bitcoin/pull/14417
4152018-10-23T23:06:48 *** bitcoin-git has left #bitcoin-core-dev
4162018-10-23T23:08:03 *** spinza has joined #bitcoin-core-dev
4172018-10-23T23:19:01 *** intcat has quit IRC
4182018-10-23T23:21:25 *** intcat has joined #bitcoin-core-dev
4192018-10-23T23:31:12 *** bitconner has joined #bitcoin-core-dev
4202018-10-23T23:33:27 *** jarthur_ has joined #bitcoin-core-dev
4212018-10-23T23:37:01 *** Squidicuz has quit IRC
4222018-10-23T23:37:03 *** jarthur has quit IRC
4232018-10-23T23:37:14 *** Squidicuz has joined #bitcoin-core-dev
4242018-10-23T23:38:09 *** jarthur_ has quit IRC
4252018-10-23T23:38:51 *** intcat has quit IRC
4262018-10-23T23:42:50 *** intcat has joined #bitcoin-core-dev
4272018-10-23T23:43:20 *** Emcy_ has joined #bitcoin-core-dev
4282018-10-23T23:44:31 *** Emcy has quit IRC
4292018-10-23T23:48:42 *** jarthur has joined #bitcoin-core-dev
4302018-10-23T23:49:42 *** bitconner has quit IRC