1 2019-01-15T00:24:57  *** ddustin has joined #bitcoin-core-dev
  2 2019-01-15T00:26:33  *** Murch has quit IRC
  3 2019-01-15T00:30:12  *** ddustin has quit IRC
  4 2019-01-15T00:32:09  *** bzb_ has quit IRC
  5 2019-01-15T00:35:05  *** Murch has joined #bitcoin-core-dev
  6 2019-01-15T00:39:37  *** mistergold has quit IRC
  7 2019-01-15T00:56:42  *** ddustin has joined #bitcoin-core-dev
  8 2019-01-15T00:58:57  *** Dean_Guss has quit IRC
  9 2019-01-15T01:01:00  *** promag has quit IRC
 10 2019-01-15T01:01:22  *** ddustin has quit IRC
 11 2019-01-15T01:05:20  *** jb55 has quit IRC
 12 2019-01-15T01:13:17  *** pinheadmz has quit IRC
 13 2019-01-15T01:17:02  *** rh0nj has quit IRC
 14 2019-01-15T01:18:13  *** rh0nj has joined #bitcoin-core-dev
 15 2019-01-15T01:32:21  *** Tralfaz has quit IRC
 16 2019-01-15T01:35:10  *** benthecarman has joined #bitcoin-core-dev
 17 2019-01-15T01:36:08  <benthecarman> Is the mailing list down? It won't let me add myself
 18 2019-01-15T01:37:06  *** wajz has joined #bitcoin-core-dev
 19 2019-01-15T01:38:35  <wajz> Hi there!, just a simple question. I'm reading a blockchain paper which I would like to discuss. Is this an appropiate channel or there's any 'research channel'?
 20 2019-01-15T01:39:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 21 2019-01-15T01:40:37  <kanzure> /join #bitcoin-wizards
 22 2019-01-15T01:41:25  <wajz> Thanks kanzure
 23 2019-01-15T01:51:19  *** ossifrage has quit IRC
 24 2019-01-15T01:51:47  *** ossifrage has joined #bitcoin-core-dev
 25 2019-01-15T02:12:31  *** dviola has quit IRC
 26 2019-01-15T02:12:34  *** Chris_Stewart_5 has quit IRC
 27 2019-01-15T02:16:04  *** Murch has quit IRC
 28 2019-01-15T02:17:06  *** Murch has joined #bitcoin-core-dev
 29 2019-01-15T02:23:27  *** wajz has quit IRC
 30 2019-01-15T02:44:15  *** jb55 has joined #bitcoin-core-dev
 31 2019-01-15T02:44:30  *** ddustin has joined #bitcoin-core-dev
 32 2019-01-15T02:57:52  *** Dean_Guss has joined #bitcoin-core-dev
 33 2019-01-15T03:01:21  *** AaronvanW has quit IRC
 34 2019-01-15T03:01:51  *** bitcoin-git has joined #bitcoin-core-dev
 35 2019-01-15T03:01:51  <bitcoin-git> [bitcoin] sdaftuar opened pull request #15169: WIP: Parallelize CheckInputs() in AcceptToMemoryPool() (master...2018-12-parallel-mempool-scriptchecks) https://github.com/bitcoin/bitcoin/pull/15169
 36 2019-01-15T03:01:51  *** bitcoin-git has left #bitcoin-core-dev
 37 2019-01-15T03:07:40  *** Krellan has quit IRC
 38 2019-01-15T03:12:06  *** karlos has joined #bitcoin-core-dev
 39 2019-01-15T03:12:16  *** bitcoin-git has joined #bitcoin-core-dev
 40 2019-01-15T03:12:16  <bitcoin-git> [bitcoin] koalaman opened pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170
 41 2019-01-15T03:12:16  *** bitcoin-git has left #bitcoin-core-dev
 42 2019-01-15T03:18:33  *** Dean_Guss has quit IRC
 43 2019-01-15T03:25:24  *** Dean_Guss has joined #bitcoin-core-dev
 44 2019-01-15T03:39:29  *** dviola has joined #bitcoin-core-dev
 45 2019-01-15T03:40:01  *** karlos has quit IRC
 46 2019-01-15T04:00:17  *** Dean_Guss has quit IRC
 47 2019-01-15T04:06:06  *** schnerch_ has joined #bitcoin-core-dev
 48 2019-01-15T04:08:49  *** schnerchi has quit IRC
 49 2019-01-15T04:10:25  *** rasrenato has joined #bitcoin-core-dev
 50 2019-01-15T04:23:54  *** benthecarman has quit IRC
 51 2019-01-15T04:27:10  *** dviola has quit IRC
 52 2019-01-15T04:32:55  *** karlos has joined #bitcoin-core-dev
 53 2019-01-15T04:55:52  *** DeanGuss has joined #bitcoin-core-dev
 54 2019-01-15T05:06:35  *** sipa has quit IRC
 55 2019-01-15T05:08:22  *** sipa has joined #bitcoin-core-dev
 56 2019-01-15T05:19:01  *** rh0nj has quit IRC
 57 2019-01-15T05:20:07  *** rh0nj has joined #bitcoin-core-dev
 58 2019-01-15T05:36:36  *** qrestlove has quit IRC
 59 2019-01-15T05:39:21  <meshcollider> gwillen: maybe only one or two more, hopefully promag or someone who commented early on is willing to do a full review
 60 2019-01-15T05:54:40  *** spaced0ut has quit IRC
 61 2019-01-15T06:01:13  *** qrestlove has joined #bitcoin-core-dev
 62 2019-01-15T06:10:23  *** karlos has quit IRC
 63 2019-01-15T06:11:17  *** Klox has joined #bitcoin-core-dev
 64 2019-01-15T06:14:02  <gwillen> meshcollider: cool, thanks
 65 2019-01-15T06:14:13  <gwillen> I would ping promag here but he doesn't seem to be on at the moment
 66 2019-01-15T06:14:44  <meshcollider> He'll get pinged by my message anyway :)
 67 2019-01-15T06:15:01  <gwillen> well he would if he were here, anyway :-)
 68 2019-01-15T06:20:50  *** rhavar has quit IRC
 69 2019-01-15T06:30:27  *** zenogais has quit IRC
 70 2019-01-15T07:10:51  *** Krellan has joined #bitcoin-core-dev
 71 2019-01-15T07:22:18  *** hebasto has joined #bitcoin-core-dev
 72 2019-01-15T07:26:30  *** pinheadmz has joined #bitcoin-core-dev
 73 2019-01-15T07:35:06  *** bitcoin-git has joined #bitcoin-core-dev
 74 2019-01-15T07:35:06  <bitcoin-git> [bitcoin] Empact opened pull request #15171: test: Wait before cleanup on exit (master...test-wait-cleanup) https://github.com/bitcoin/bitcoin/pull/15171
 75 2019-01-15T07:35:06  *** bitcoin-git has left #bitcoin-core-dev
 76 2019-01-15T07:35:30  *** ddustin has quit IRC
 77 2019-01-15T07:43:52  *** ddustin has joined #bitcoin-core-dev
 78 2019-01-15T07:58:53  *** wangkaixuan has joined #bitcoin-core-dev
 79 2019-01-15T08:00:19  *** wangkaixuan has quit IRC
 80 2019-01-15T08:21:47  <gmaxwell> Security warning: if you scp files from a malicious ssh server, it can overwrite arbritary files in/under your target directory.
 81 2019-01-15T08:27:14  <DeanGuss> so you're saying don't work with malicious ssh servers?
 82 2019-01-15T08:38:33  *** karlos has joined #bitcoin-core-dev
 83 2019-01-15T08:44:24  <booyah> gmaxwell: that seems like a serious bug. you are not controling the file name?  scp foo@bar.org:/tmp/a.txt ./  can result in something else then ./a.txt ?
 84 2019-01-15T08:59:39  <cjd> that's what it sounds like
 85 2019-01-15T08:59:53  <cjd> or worse, a.txt as you expected plus also click_here_please.exe as well
 86 2019-01-15T09:00:57  <cjd> or .bashrc or any of a plethora of other nasties
 87 2019-01-15T09:03:58  *** setpill has joined #bitcoin-core-dev
 88 2019-01-15T09:10:52  *** pinheadmz has quit IRC
 89 2019-01-15T09:12:35  *** luc_ has joined #bitcoin-core-dev
 90 2019-01-15T09:14:43  *** mistergold has joined #bitcoin-core-dev
 91 2019-01-15T09:16:51  *** luc_ has quit IRC
 92 2019-01-15T09:21:01  *** rh0nj has quit IRC
 93 2019-01-15T09:23:07  <wumpus> wonder if rsync has the same problem? that's what I usually yse
 94 2019-01-15T09:27:59  *** ExtraCrispy has joined #bitcoin-core-dev
 95 2019-01-15T09:32:46  *** murrayn has quit IRC
 96 2019-01-15T09:33:17  *** hebasto has quit IRC
 97 2019-01-15T09:37:20  *** Guyver2 has joined #bitcoin-core-dev
 98 2019-01-15T09:44:14  *** promag has joined #bitcoin-core-dev
 99 2019-01-15T09:48:23  *** promag has quit IRC
100 2019-01-15T09:50:01  <cjd> hmm, my intuition is that ssh to malicious machines is a minefield
101 2019-01-15T09:51:40  *** promag has joined #bitcoin-core-dev
102 2019-01-15T09:54:10  <promag> #14941 should be ready for last ack and merge
103 2019-01-15T09:54:12  <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
104 2019-01-15T10:00:31  *** murrayn has joined #bitcoin-core-dev
105 2019-01-15T10:04:56  *** kexkey has quit IRC
106 2019-01-15T10:14:52  *** spinza has quit IRC
107 2019-01-15T10:16:28  *** miknotauro has quit IRC
108 2019-01-15T10:20:55  *** philgee has joined #bitcoin-core-dev
109 2019-01-15T10:21:36  *** TheV01d_ has quit IRC
110 2019-01-15T10:21:45  *** TheV01d_ has joined #bitcoin-core-dev
111 2019-01-15T10:35:44  *** timothy has joined #bitcoin-core-dev
112 2019-01-15T10:40:40  *** spinza has joined #bitcoin-core-dev
113 2019-01-15T10:43:15  *** karlos has quit IRC
114 2019-01-15T10:55:44  *** fanquake has joined #bitcoin-core-dev
115 2019-01-15T11:03:18  *** rex4539 has quit IRC
116 2019-01-15T11:19:14  *** timothy has quit IRC
117 2019-01-15T11:21:12  *** AaronvanW has joined #bitcoin-core-dev
118 2019-01-15T11:22:14  *** timothy has joined #bitcoin-core-dev
119 2019-01-15T11:42:55  *** spinza has quit IRC
120 2019-01-15T11:48:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
121 2019-01-15T11:50:39  *** spinza has joined #bitcoin-core-dev
122 2019-01-15T11:55:02  *** rex4539 has joined #bitcoin-core-dev
123 2019-01-15T12:07:32  *** rex4539 has quit IRC
124 2019-01-15T12:21:14  *** guga has joined #bitcoin-core-dev
125 2019-01-15T12:24:53  *** sakalli_ has joined #bitcoin-core-dev
126 2019-01-15T12:25:10  *** sakalli_ has joined #bitcoin-core-dev
127 2019-01-15T12:29:08  *** rh0nj has joined #bitcoin-core-dev
128 2019-01-15T12:29:42  *** sakalli_ has quit IRC
129 2019-01-15T12:30:45  *** Guyver2 has quit IRC
130 2019-01-15T12:38:49  *** rex4539 has joined #bitcoin-core-dev
131 2019-01-15T12:48:46  *** promag has quit IRC
132 2019-01-15T12:53:56  *** fanquake has quit IRC
133 2019-01-15T12:58:51  *** hebasto has joined #bitcoin-core-dev
134 2019-01-15T13:07:07  *** Chris_Stewart_5 has quit IRC
135 2019-01-15T13:11:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
136 2019-01-15T13:16:28  <wumpus> but do you ever know for sure that the machine you're sshing to is not 'malicious'? if exploits can easily travel from ssh servers to clients, this makes e.g. VMs mostly useless as an isolation mechanism
137 2019-01-15T13:21:48  <wumpus> but yes, if you know you're sshing to a compromised machine it's good to be careful I guess
138 2019-01-15T13:37:36  *** jungly has joined #bitcoin-core-dev
139 2019-01-15T13:38:53  *** bitcoin-git has joined #bitcoin-core-dev
140 2019-01-15T13:38:53  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf0c67b62c20...1b6fc3053045
141 2019-01-15T13:38:54  <bitcoin-git> bitcoin/master c37851d João Barbosa: rpc: Make unloadwallet wait for complete wallet unload
142 2019-01-15T13:38:54  <bitcoin-git> bitcoin/master 645e905 João Barbosa: doc: Add release notes for unloadwallet change to synchronous call
143 2019-01-15T13:38:55  <bitcoin-git> bitcoin/master 1b6fc30 Wladimir J. van der Laan: Merge #14941: rpc: Make unloadwallet wait for complete wallet unload...
144 2019-01-15T13:38:55  *** bitcoin-git has left #bitcoin-core-dev
145 2019-01-15T13:39:34  *** bitcoin-git has joined #bitcoin-core-dev
146 2019-01-15T13:39:34  <bitcoin-git> [bitcoin] laanwj closed pull request #14941: rpc: Make unloadwallet wait for complete wallet unload (master...2018-12-sync-unloadwallet) https://github.com/bitcoin/bitcoin/pull/14941
147 2019-01-15T13:39:34  *** bitcoin-git has left #bitcoin-core-dev
148 2019-01-15T13:43:49  <wumpus> whoa, bitcoin-git is *working* again
149 2019-01-15T13:44:15  *** mistergo1d has joined #bitcoin-core-dev
150 2019-01-15T13:46:06  *** mistergold has quit IRC
151 2019-01-15T13:46:45  *** Chris_Stewart_5 has quit IRC
152 2019-01-15T13:47:36  <wumpus> gkrizek: is that your bot now?
153 2019-01-15T14:02:18  *** Emcy has quit IRC
154 2019-01-15T14:12:06  *** Emcy has joined #bitcoin-core-dev
155 2019-01-15T14:13:06  *** promag has joined #bitcoin-core-dev
156 2019-01-15T14:21:20  *** bitcoin-git has joined #bitcoin-core-dev
157 2019-01-15T14:21:20  <bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
158 2019-01-15T14:21:20  *** bitcoin-git has left #bitcoin-core-dev
159 2019-01-15T14:21:37  *** bitcoin-git has joined #bitcoin-core-dev
160 2019-01-15T14:21:37  <bitcoin-git> [bitcoin] Mr-Leshiy reopened pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
161 2019-01-15T14:21:37  *** bitcoin-git has left #bitcoin-core-dev
162 2019-01-15T14:27:37  *** bitcoin-git has joined #bitcoin-core-dev
163 2019-01-15T14:27:38  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b6fc3053045...a5daf70ffb80
164 2019-01-15T14:27:38  <bitcoin-git> bitcoin/master a88640e Hennadii Stepanov: Fix minimized window bug on Linux...
165 2019-01-15T14:27:39  <bitcoin-git> bitcoin/master a5daf70 Wladimir J. van der Laan: Merge #14594: qt: Fix minimized window bug on Linux...
166 2019-01-15T14:27:39  *** bitcoin-git has left #bitcoin-core-dev
167 2019-01-15T14:28:03  *** bitcoin-git has joined #bitcoin-core-dev
168 2019-01-15T14:28:03  <bitcoin-git> [bitcoin] laanwj closed pull request #14594: qt: Fix minimized window bug on Linux (master...20181028-restore-minimized) https://github.com/bitcoin/bitcoin/pull/14594
169 2019-01-15T14:28:03  *** bitcoin-git has left #bitcoin-core-dev
170 2019-01-15T14:29:27  *** bitcoin-git has joined #bitcoin-core-dev
171 2019-01-15T14:29:28  <bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
172 2019-01-15T14:29:28  *** bitcoin-git has left #bitcoin-core-dev
173 2019-01-15T14:30:30  *** miknotauro has joined #bitcoin-core-dev
174 2019-01-15T14:30:46  *** spaced0ut has joined #bitcoin-core-dev
175 2019-01-15T14:33:24  *** owowo has joined #bitcoin-core-dev
176 2019-01-15T14:34:26  <luke-jr> yikes re scp
177 2019-01-15T14:34:31  <luke-jr> is there a CVE?
178 2019-01-15T14:37:33  *** Guest51719 has joined #bitcoin-core-dev
179 2019-01-15T14:41:55  *** bitcoin-git has joined #bitcoin-core-dev
180 2019-01-15T14:41:56  <bitcoin-git> [bitcoin] laanwj closed pull request #14965: minor: fix extra "non" in source code comment (master...minor-comment-double-negation) https://github.com/bitcoin/bitcoin/pull/14965
181 2019-01-15T14:41:56  *** bitcoin-git has left #bitcoin-core-dev
182 2019-01-15T14:41:58  <timothy> luke-jr: yes, much CVE-s
183 2019-01-15T14:42:18  <timothy> luke-jr: https://sintonen.fi/advisories/scp-client-multiple-vulnerabilities.txt
184 2019-01-15T14:43:14  *** Murch has joined #bitcoin-core-dev
185 2019-01-15T14:43:55  <wumpus> thanks timothy
186 2019-01-15T14:44:00  <luke-jr> ^
187 2019-01-15T14:44:30  <luke-jr> wumpus: rsync supports wildcards, so I suspect it has the same problem :/
188 2019-01-15T14:44:45  <luke-jr> eg, rsync foo@bar:/path/to/\* ./
189 2019-01-15T14:45:50  <wumpus> hmm true, but if you use a wildcard you're kind of asking for the remote to be able to overwrite any file locally (unless you provide the flag not to)
190 2019-01-15T14:46:07  <wumpus> well any file within the destination path obviously not outside it
191 2019-01-15T14:46:12  <luke-jr> wumpus: yes, but that feature implies the local client needs to do its own globbing check
192 2019-01-15T14:47:20  *** qrestlove has quit IRC
193 2019-01-15T14:48:00  <wumpus> luke-jr: but the remote can always lie about which files are available, I'd think
194 2019-01-15T14:48:32  <wumpus> oh you mean to match against the globs, of course
195 2019-01-15T14:49:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
196 2019-01-15T14:50:37  <wumpus> promag: please rebase #14458
197 2019-01-15T14:50:40  <gribble> https://github.com/bitcoin/bitcoin/issues/14458 | WIP: Add JSON-RPC interface documentation by promag · Pull Request #14458 · bitcoin/bitcoin · GitHub
198 2019-01-15T14:51:18  *** qrestlove has joined #bitcoin-core-dev
199 2019-01-15T14:54:18  *** owowo has quit IRC
200 2019-01-15T14:55:08  *** elichai2 has joined #bitcoin-core-dev
201 2019-01-15T14:56:27  <gkrizek> wumpus: no, I commented about it when it started up yesterday. "GitHub IRC Service is out of its brown out until the 31st when it’s fully depreciated. I’m still working on a replacement and it’s close to done. Will def be done before the 31st."
202 2019-01-15T14:56:33  *** Guyver2 has joined #bitcoin-core-dev
203 2019-01-15T14:56:39  <gkrizek> So it's still GitHub back for a couple weeks before it's really really dead
204 2019-01-15T14:57:49  <wumpus> gkrizek: okay ! thanks again for working on it
205 2019-01-15T14:58:10  <wumpus> apparently missed that comment :)
206 2019-01-15T14:58:16  <gkrizek> No problem, happy to do it!
207 2019-01-15T14:59:10  *** owowo has joined #bitcoin-core-dev
208 2019-01-15T15:00:13  <promag> wumpus: on it
209 2019-01-15T15:01:44  <promag> wumpus: #14958 could also go
210 2019-01-15T15:01:46  <gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
211 2019-01-15T15:01:51  <wumpus> ook
212 2019-01-15T15:02:41  <wumpus> would be nice if MarcoFalke could take a look at that one
213 2019-01-15T15:09:48  *** setpill has quit IRC
214 2019-01-15T15:10:38  *** Guest51719 has quit IRC
215 2019-01-15T15:11:57  <promag> no problem
216 2019-01-15T15:15:58  *** muzaffer has joined #bitcoin-core-dev
217 2019-01-15T15:18:25  <promag> there's like 1 month until feature freeze?
218 2019-01-15T15:20:16  *** muzaffer has quit IRC
219 2019-01-15T15:31:48  <wumpus> 'for (uint64_t j = static_cast<uint64_t>(1) << (i - 1); (j >> i) == 0; ++j) {'
220 2019-01-15T15:32:14  <wumpus> isn't there a shorter way to do this? static_casting 1 to uint64_t seems... outrageous
221 2019-01-15T15:32:58  *** michaelsdunn1 has joined #bitcoin-core-dev
222 2019-01-15T15:38:36  <wumpus> (concerning #14151)
223 2019-01-15T15:38:40  <gribble> https://github.com/bitcoin/bitcoin/issues/14151 | windows: Fix remaining compiler warnings (MSVC) by practicalswift · Pull Request #14151 · bitcoin/bitcoin · GitHub
224 2019-01-15T15:39:29  <wumpus> promag: yes exactly a month you're right ! (#14438)
225 2019-01-15T15:39:30  <gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
226 2019-01-15T15:40:02  <luke-jr> at the very least it could be uint64_t(1)
227 2019-01-15T15:40:22  <luke-jr> FWIW, I confirmed rsync IS vulnerable to the same
228 2019-01-15T15:40:37  *** zenogais has joined #bitcoin-core-dev
229 2019-01-15T15:40:49  <wumpus> luke-jr: thanks for the suggestion, will try
230 2019-01-15T15:40:55  <luke-jr> (to reproduce, make a dummy shell script that just does exec ${SSH_ORIGINAL_COMMAND/dummyA\/a/dummyA\/*}, and use SSH forced commands to call it)
231 2019-01-15T15:44:27  <sipa> wumpus: so it's counting from 2**(i-1) to (2**i)-1 ?
232 2019-01-15T15:48:51  <phantomcircuit> wumpus, remote can also send sym and hard links with rsync so like... yeah
233 2019-01-15T15:49:21  <luke-jr> phantomcircuit: depends on client configuration in theory
234 2019-01-15T15:49:30  <luke-jr> and that's expected behaviour at least
235 2019-01-15T15:49:38  <phantomcircuit> luke-jr, iirc the flags just control what the client requests
236 2019-01-15T15:50:00  <wumpus> sipa: it kind of confuses me, according to the test it's supposed to generate bit patterns in j with i bits set
237 2019-01-15T15:50:05  <luke-jr> phantomcircuit: ugh
238 2019-01-15T15:50:38  *** rex4539 has quit IRC
239 2019-01-15T15:51:15  <phantomcircuit> luke-jr, tons of stuff works that way
240 2019-01-15T15:51:36  <luke-jr> wumpus: actually, looking at that further looks .. dumb
241 2019-01-15T15:52:45  * luke-jr wonders wtf that's *trying* to do
242 2019-01-15T15:56:58  *** promag has quit IRC
243 2019-01-15T15:58:09  *** promag has joined #bitcoin-core-dev
244 2019-01-15T15:58:24  <luke-jr> for (unsigned j = 1U << (i - 1); (j >> i) == 0; ++j) {
245 2019-01-15T15:59:37  <wumpus> that creates an 'unsigned int' which is probably 32 bit, won't the shift potentially shift out of the register or even create undefined behavior
246 2019-01-15T16:03:02  <luke-jr> wumpus: unsigned int is guaranteed to be at least 16-bit, and this is only done when i is <10
247 2019-01-15T16:04:17  <wumpus> hhmm okay
248 2019-01-15T16:04:45  <wumpus> I... don't think adding that reliance is very nice
249 2019-01-15T16:05:21  <luke-jr> it's gotta rely on some bit width regardless. no reason to do 64-bit when we know it won't be 64-bit :p
250 2019-01-15T16:05:51  <wumpus> the input to that bitcounting function is 64-bit, and it's a test for that, so limiting it at that makes some sense
251 2019-01-15T16:06:08  <luke-jr> and if the standards-required assumption of 16-bit ever fails, the test will just fail
252 2019-01-15T16:06:37  <luke-jr> which we probably want anyway, considering other code currently assumes it's 32-bit :p
253 2019-01-15T16:11:46  *** philgee has quit IRC
254 2019-01-15T16:12:38  <wumpus> true; I wish C++ had 1u64 like rust
255 2019-01-15T16:13:01  *** guga has quit IRC
256 2019-01-15T16:14:07  <sipa> e could define a user-defined literal for it
257 2019-01-15T16:14:12  <sipa> c++11 feature :)
258 2019-01-15T16:15:29  <wumpus> interesting
259 2019-01-15T16:16:45  <luke-jr> sipa: ?
260 2019-01-15T16:16:46  <wumpus> nice feature, I don't think that's used anywhere in the code yet
261 2019-01-15T16:17:32  <wumpus> https://en.cppreference.com/w/cpp/language/user_literal
262 2019-01-15T16:17:43  <sipa> luke-jr: in c++11 you can define compile-time code to evaluate expressions of the form 1234_u64 for example
263 2019-01-15T16:18:26  <wumpus> kind of overkill for this, but still, nice :)
264 2019-01-15T16:18:30  <sipa> kinda surprising they didn't include a few default instances of it in the std library for things like this
265 2019-01-15T16:19:05  <luke-jr> wow
266 2019-01-15T16:19:06  <wumpus> looks like they defined a few default instances for std::complex and std::chrono::*
267 2019-01-15T16:19:13  <wumpus> but not this unfortunately yeh
268 2019-01-15T16:19:37  <wumpus> oh wait that's *C++14* nm\
269 2019-01-15T16:19:47  <sipa> and only in c++14, and a few more in c++20
270 2019-01-15T16:22:19  <wumpus> right
271 2019-01-15T16:25:21  *** miknotauro has quit IRC
272 2019-01-15T16:26:50  *** miknotauro has joined #bitcoin-core-dev
273 2019-01-15T16:30:01  *** rh0nj has quit IRC
274 2019-01-15T16:31:07  *** rh0nj has joined #bitcoin-core-dev
275 2019-01-15T16:32:07  *** miknotauro has quit IRC
276 2019-01-15T16:37:17  *** drexl has joined #bitcoin-core-dev
277 2019-01-15T16:39:43  *** bitcoin-git has joined #bitcoin-core-dev
278 2019-01-15T16:39:44  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5daf70ffb80...e8ad580f5153
279 2019-01-15T16:39:44  <bitcoin-git> bitcoin/master fb3ce75 Hennadii Stepanov: Don't label transactions "Open" while catching up...
280 2019-01-15T16:39:45  <bitcoin-git> bitcoin/master e8ad580 Wladimir J. van der Laan: Merge #14556: qt: fix confirmed transaction labeled "open" (#13299)...
281 2019-01-15T16:39:45  *** bitcoin-git has left #bitcoin-core-dev
282 2019-01-15T16:40:21  *** bitcoin-git has joined #bitcoin-core-dev
283 2019-01-15T16:40:22  <bitcoin-git> [bitcoin] laanwj closed pull request #14556: qt: fix confirmed transaction labeled "open" (#13299) (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
284 2019-01-15T16:40:22  *** bitcoin-git has left #bitcoin-core-dev
285 2019-01-15T16:42:41  *** bitcoin-git has joined #bitcoin-core-dev
286 2019-01-15T16:42:42  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8ad580f5153...eb2aecfb8066
287 2019-01-15T16:42:43  <bitcoin-git> bitcoin/master 03b8596 TheCharlatan: Add checksum in gitian build scripts for ossl...
288 2019-01-15T16:42:43  <bitcoin-git> bitcoin/master eb2aecf Wladimir J. van der Laan: Merge #14433: Add checksum in gitian build scripts for ossl...
289 2019-01-15T16:42:44  *** bitcoin-git has left #bitcoin-core-dev
290 2019-01-15T16:43:06  *** bitcoin-git has joined #bitcoin-core-dev
291 2019-01-15T16:43:06  <bitcoin-git> [bitcoin] laanwj closed pull request #14433: Add checksum in gitian build scripts for ossl (master...osslChecksum) https://github.com/bitcoin/bitcoin/pull/14433
292 2019-01-15T16:43:06  *** bitcoin-git has left #bitcoin-core-dev
293 2019-01-15T16:48:15  *** promag has quit IRC
294 2019-01-15T16:51:37  *** pinheadmz has joined #bitcoin-core-dev
295 2019-01-15T16:57:48  *** rex4539 has joined #bitcoin-core-dev
296 2019-01-15T17:16:00  *** jarthur has joined #bitcoin-core-dev
297 2019-01-15T17:21:51  *** promag has joined #bitcoin-core-dev
298 2019-01-15T17:26:23  *** promag has quit IRC
299 2019-01-15T17:32:24  *** pinheadmz has quit IRC
300 2019-01-15T17:32:55  *** pinheadmz has joined #bitcoin-core-dev
301 2019-01-15T17:39:44  *** lnostdal has quit IRC
302 2019-01-15T17:41:56  *** jungly has quit IRC
303 2019-01-15T17:42:31  *** lnostdal has joined #bitcoin-core-dev
304 2019-01-15T17:51:15  *** promag has joined #bitcoin-core-dev
305 2019-01-15T17:58:10  *** promag has quit IRC
306 2019-01-15T18:02:27  *** Guest9_ has joined #bitcoin-core-dev
307 2019-01-15T18:02:42  *** Guest9_ is now known as ThomasLuong
308 2019-01-15T18:03:06  *** jimmysong has joined #bitcoin-core-dev
309 2019-01-15T18:03:31  *** ThomasLuong is now known as luongthomas_
310 2019-01-15T18:04:04  *** luongthomas_ is now known as luongthomas
311 2019-01-15T18:04:42  *** luongthomas is now known as ThomasLuong
312 2019-01-15T18:14:01  *** promag has joined #bitcoin-core-dev
313 2019-01-15T18:15:25  *** ddustin_ has joined #bitcoin-core-dev
314 2019-01-15T18:15:28  *** Chris_Stewart_5 has quit IRC
315 2019-01-15T18:16:22  *** ddustin has quit IRC
316 2019-01-15T18:30:31  *** soundsalad has joined #bitcoin-core-dev
317 2019-01-15T18:35:43  *** promag has quit IRC
318 2019-01-15T18:37:18  *** timothy has quit IRC
319 2019-01-15T18:37:42  *** promag has joined #bitcoin-core-dev
320 2019-01-15T18:39:05  <dongcarl> Anything else that needs doing for: https://github.com/bitcoin/bitcoin/pull/12255
321 2019-01-15T18:42:40  <luke-jr> dongcarl: the release notes seem wrong
322 2019-01-15T18:43:08  <dongcarl> luke-jr: Comment on the PR, happy to fix.
323 2019-01-15T18:43:17  <luke-jr> yeah, will do
324 2019-01-15T18:44:03  <luke-jr> (it's actually init.md)
325 2019-01-15T18:44:17  *** bitcoin-git has joined #bitcoin-core-dev
326 2019-01-15T18:44:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/eb2aecfb8066...82ffd4d91832
327 2019-01-15T18:44:18  <bitcoin-git> bitcoin/master fac4558 MarcoFalke: sync: Add RecursiveMutex type alias
328 2019-01-15T18:44:18  <bitcoin-git> bitcoin/master fafe941 MarcoFalke: test: Add missing validation locks
329 2019-01-15T18:44:19  <bitcoin-git> bitcoin/master fa5c346 MarcoFalke: doc: Add comment to cs_main and mempool::cs
330 2019-01-15T18:44:19  *** bitcoin-git has left #bitcoin-core-dev
331 2019-01-15T18:44:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
332 2019-01-15T18:44:56  *** bitcoin-git has joined #bitcoin-core-dev
333 2019-01-15T18:44:56  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14963: mempool, validation: Explain cs_main locking semantics (master...Mf1812-docValLocks) https://github.com/bitcoin/bitcoin/pull/14963
334 2019-01-15T18:44:56  *** bitcoin-git has left #bitcoin-core-dev
335 2019-01-15T18:46:05  <dongcarl> luke-jr: Thanks!
336 2019-01-15T18:50:50  *** ddustin_ has quit IRC
337 2019-01-15T18:51:27  *** ddustin has joined #bitcoin-core-dev
338 2019-01-15T18:56:20  *** ddustin has quit IRC
339 2019-01-15T18:58:46  *** bitcoin-git has joined #bitcoin-core-dev
340 2019-01-15T18:58:46  <bitcoin-git> [bitcoin] Sjors opened pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173
341 2019-01-15T18:58:46  *** bitcoin-git has left #bitcoin-core-dev
342 2019-01-15T19:01:35  *** hebasto has quit IRC
343 2019-01-15T19:02:22  *** bitcoin-git has joined #bitcoin-core-dev
344 2019-01-15T19:02:22  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/82ffd4d91832...c7c84209bb0a
345 2019-01-15T19:02:23  <bitcoin-git> bitcoin/master f411c8b João Barbosa: gui: Remove unused return type in some BitcoinGUI methods
346 2019-01-15T19:02:23  <bitcoin-git> bitcoin/master 8a79261 João Barbosa: gui: Keep network style in BitcoinGUI
347 2019-01-15T19:02:24  <bitcoin-git> bitcoin/master fe7048b João Barbosa: gui: Show current wallet name in window title
348 2019-01-15T19:02:24  *** bitcoin-git has left #bitcoin-core-dev
349 2019-01-15T19:02:58  *** bitcoin-git has joined #bitcoin-core-dev
350 2019-01-15T19:02:58  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #15149: gui: Show current wallet name in window title (master...2019-01-updatewindowtitle) https://github.com/bitcoin/bitcoin/pull/15149
351 2019-01-15T19:02:58  *** bitcoin-git has left #bitcoin-core-dev
352 2019-01-15T19:16:19  *** soundsalad has quit IRC
353 2019-01-15T19:26:39  *** Krellan has quit IRC
354 2019-01-15T19:28:51  *** pinheadmz has quit IRC
355 2019-01-15T19:30:06  *** pinheadmz has joined #bitcoin-core-dev
356 2019-01-15T19:34:19  *** DougieBot5000_ has joined #bitcoin-core-dev
357 2019-01-15T19:34:23  <jamesob> is there any good reason that ofstream objects can't be used as a stream with the serialize functions?
358 2019-01-15T19:35:56  <sipa> jamesob: i think it just diverged; they used to implement a similar interface, but nothing used stdlib stream objects, so changes over time broke the compatibility?
359 2019-01-15T19:36:08  <sipa> what causes it? the GetVersion etc?
360 2019-01-15T19:37:57  <jamesob> trying to figure that out atm but I don't think it's GetVersion; top line of the compiler barf is
361 2019-01-15T19:37:58  <jamesob> ./compressor.h:55:15: error: invalid operands to binary expression ('std::basic_ofstream<char>' and 'Span<typename std::remove_pointer<decltype(std::declval<vector<unsigned char, allocator<unsigned char> > >().data())>::type>' (aka 'Span<unsigned char>'))
362 2019-01-15T19:38:08  *** DougieBot5000 has quit IRC
363 2019-01-15T19:38:57  <jamesob> in the meantime I can do a CDataStream intermediary I guess
364 2019-01-15T19:40:32  <gwillen> heh, I just tried to do this the other day
365 2019-01-15T19:40:36  <gwillen> and assumed it was just not meant to work
366 2019-01-15T19:40:52  <gwillen> and wrote a little std::string returning wrapper around CDataStream nonsense instead
367 2019-01-15T19:44:55  <jamesob> ah funny. I'm dealing with binary and so want to avoid string
368 2019-01-15T19:44:55  *** riemann has joined #bitcoin-core-dev
369 2019-01-15T19:54:40  *** Aaronvan_ has joined #bitcoin-core-dev
370 2019-01-15T19:57:12  *** Aaronva__ has joined #bitcoin-core-dev
371 2019-01-15T19:57:34  *** AaronvanW has quit IRC
372 2019-01-15T19:58:57  *** Aaronvan_ has quit IRC
373 2019-01-15T20:00:02  *** pinheadmz has quit IRC
374 2019-01-15T20:01:10  *** Aaronva__ is now known as AaronvanW
375 2019-01-15T20:22:53  *** Murch has quit IRC
376 2019-01-15T20:27:40  *** StopAndDecrypt has joined #bitcoin-core-dev
377 2019-01-15T20:32:01  *** rh0nj has quit IRC
378 2019-01-15T20:37:38  *** pinheadmz has joined #bitcoin-core-dev
379 2019-01-15T20:38:12  *** Murch has joined #bitcoin-core-dev
380 2019-01-15T20:42:07  <luke-jr> followup on the random_tests failure the other day, apparently some are seeing it with raii_tests instead: https://bugs.gentoo.org/675546 :/
381 2019-01-15T20:46:48  *** DougieBot5000_ is now known as DougieBot5000
382 2019-01-15T20:46:52  *** Krellan has joined #bitcoin-core-dev
383 2019-01-15T20:48:55  *** morcos has quit IRC
384 2019-01-15T20:49:19  *** morcos has joined #bitcoin-core-dev
385 2019-01-15T20:51:18  *** Krellan has quit IRC
386 2019-01-15T20:53:59  *** mistergold has joined #bitcoin-core-dev
387 2019-01-15T20:57:08  *** mistergo1d has quit IRC
388 2019-01-15T20:58:14  *** ThomasLuong has quit IRC
389 2019-01-15T21:00:12  *** Murch has quit IRC
390 2019-01-15T21:05:37  *** DougieBot5000 has quit IRC
391 2019-01-15T21:07:48  *** DougieBot5000 has joined #bitcoin-core-dev
392 2019-01-15T21:08:08  *** achow101 has quit IRC
393 2019-01-15T21:08:09  *** bitcoin-git has joined #bitcoin-core-dev
394 2019-01-15T21:08:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7c84209bb0a...391a27376b30
395 2019-01-15T21:08:11  <bitcoin-git> bitcoin/master 04215eb Sjors Provoost: [doc] explain what .python-version does
396 2019-01-15T21:08:11  <bitcoin-git> bitcoin/master 391a273 MarcoFalke: Merge #15173: [doc] explain what .python-version does...
397 2019-01-15T21:08:12  *** bitcoin-git has left #bitcoin-core-dev
398 2019-01-15T21:08:49  *** bitcoin-git has joined #bitcoin-core-dev
399 2019-01-15T21:08:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173
400 2019-01-15T21:08:50  *** bitcoin-git has left #bitcoin-core-dev
401 2019-01-15T21:17:34  *** jarthur has quit IRC
402 2019-01-15T21:17:39  *** achow101 has joined #bitcoin-core-dev
403 2019-01-15T21:28:27  *** mistergold has quit IRC
404 2019-01-15T21:28:48  *** mistergold has joined #bitcoin-core-dev
405 2019-01-15T21:37:49  *** booyah is now known as booyah_
406 2019-01-15T21:39:23  *** booyah_ is now known as booyah
407 2019-01-15T21:41:43  *** Murch has joined #bitcoin-core-dev
408 2019-01-15T22:00:39  <ryanofsky> jamesob, std::string is fine for binary data
409 2019-01-15T22:05:51  <gwillen> I can confirm what ryanofsky
410 2019-01-15T22:05:55  <gwillen> says*
411 2019-01-15T22:06:06  <gwillen> I checked this very carefully before going that route, it was slightly surprising to me too
412 2019-01-15T22:06:28  <gwillen> std::string will happily hold binary data as long as you do not like, call c_str and try to use the result as a zero-terminated string
413 2019-01-15T22:06:33  <gwillen> but std::string itself is 100% binary safe
414 2019-01-15T22:09:12  *** spinza has quit IRC
415 2019-01-15T22:11:59  *** Chris_Stewart_5 has quit IRC
416 2019-01-15T22:13:30  *** spinza has joined #bitcoin-core-dev
417 2019-01-15T22:28:42  *** jarthur has joined #bitcoin-core-dev
418 2019-01-15T22:29:30  *** sfhi has joined #bitcoin-core-dev
419 2019-01-15T22:31:56  *** miknotauro has joined #bitcoin-core-dev
420 2019-01-15T22:32:30  *** jarthur has quit IRC
421 2019-01-15T22:44:05  *** ThomasLuong has joined #bitcoin-core-dev
422 2019-01-15T22:44:26  *** tryphe has quit IRC
423 2019-01-15T22:44:50  *** tryphe has joined #bitcoin-core-dev
424 2019-01-15T22:48:58  *** spaced0ut has quit IRC
425 2019-01-15T22:57:12  <luke-jr> gwillen: in standard or practice only?
426 2019-01-15T22:58:51  <gwillen> in standard
427 2019-01-15T23:00:47  <sipa> std::string is just a weirdly specialized vector of chars
428 2019-01-15T23:02:42  <gwillen> and much to my chagrin, in Clang its iterator is interchangeable with one to a vector<char> but in g++ it is not.
429 2019-01-15T23:04:52  *** elichai2 has quit IRC
430 2019-01-15T23:06:19  <gmaxwell> but why not use a vector<char> ? :)
431 2019-01-15T23:08:54  <gwillen> in my case it was because there are other interfaces that use std::string
432 2019-01-15T23:08:59  <gwillen> and converting back and forth is extra lines of code
433 2019-01-15T23:26:13  *** sfhi has quit IRC
434 2019-01-15T23:37:34  *** michaelsdunn1 has quit IRC
435 2019-01-15T23:55:50  *** mistergold has quit IRC
436 2019-01-15T23:58:08  *** rh0nj has joined #bitcoin-core-dev