1 2019-01-30T00:06:08  *** Zenton has quit IRC
  2 2019-01-30T00:11:03  <MarcoFalke> Where did the irc merge bot go?
  3 2019-01-30T00:12:48  <meshcollider> i was wondering the same thing
  4 2019-01-30T00:13:31  <meshcollider> gkrizek: do you know?
  5 2019-01-30T00:19:16  *** mistergold has joined #bitcoin-core-dev
  6 2019-01-30T00:23:52  *** AaronvanW has joined #bitcoin-core-dev
  7 2019-01-30T00:24:58  *** AaronvanW has quit IRC
  8 2019-01-30T00:26:56  *** Aaronvan_ has quit IRC
  9 2019-01-30T00:31:53  *** kexkey has joined #bitcoin-core-dev
 10 2019-01-30T00:33:05  *** rhavar_ has joined #bitcoin-core-dev
 11 2019-01-30T00:33:50  *** rhavar_ has left #bitcoin-core-dev
 12 2019-01-30T00:34:08  *** StopAndDecrypt has quit IRC
 13 2019-01-30T00:34:16  *** rhavar_ has joined #bitcoin-core-dev
 14 2019-01-30T00:35:21  *** kexkey has quit IRC
 15 2019-01-30T00:35:25  *** kexkey_ has joined #bitcoin-core-dev
 16 2019-01-30T00:35:47  *** rhavar_ has quit IRC
 17 2019-01-30T00:36:06  *** rhavar_ has joined #bitcoin-core-dev
 18 2019-01-30T00:42:33  *** Chris_Stewart_5 has quit IRC
 19 2019-01-30T00:45:16  *** miknotauro has quit IRC
 20 2019-01-30T00:48:47  *** kexkey_ has quit IRC
 21 2019-01-30T00:54:42  <gkrizek> Hmm might have died. It’s hosted on wumpus server. Let me see if I still have access
 22 2019-01-30T00:55:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 23 2019-01-30T01:00:18  <gkrizek> We'll have to ask wumpus. I still have access to the server, but not enough privileges to see anything. The process appears to be running still, but not sure where logs are being sent.
 24 2019-01-30T01:03:25  *** mistergo1d has joined #bitcoin-core-dev
 25 2019-01-30T01:04:09  *** ThomasLuong has quit IRC
 26 2019-01-30T01:06:43  *** mistergold has quit IRC
 27 2019-01-30T01:12:46  *** miknotauro has joined #bitcoin-core-dev
 28 2019-01-30T01:20:36  *** Skirmant has quit IRC
 29 2019-01-30T01:20:54  *** pinheadmz has quit IRC
 30 2019-01-30T01:22:08  *** Chris_Stewart_5 has quit IRC
 31 2019-01-30T01:40:41  *** Skirmant has joined #bitcoin-core-dev
 32 2019-01-30T01:54:02  *** ThomasLuong has joined #bitcoin-core-dev
 33 2019-01-30T01:55:15  *** Dean_Guss has quit IRC
 34 2019-01-30T01:58:17  *** jtimon has joined #bitcoin-core-dev
 35 2019-01-30T02:17:39  *** kexkey has joined #bitcoin-core-dev
 36 2019-01-30T02:26:58  *** dviola has quit IRC
 37 2019-01-30T02:28:48  *** pinheadmz has joined #bitcoin-core-dev
 38 2019-01-30T02:29:06  *** mistergold has joined #bitcoin-core-dev
 39 2019-01-30T02:32:27  *** mistergo1d has quit IRC
 40 2019-01-30T02:32:44  *** miknotauro has quit IRC
 41 2019-01-30T02:34:35  *** StopAndDecrypt has joined #bitcoin-core-dev
 42 2019-01-30T02:36:04  *** ThomasLuong has quit IRC
 43 2019-01-30T02:42:14  *** Skirmant has quit IRC
 44 2019-01-30T02:42:21  *** rhavar_ has quit IRC
 45 2019-01-30T02:47:51  *** rhavar_ has joined #bitcoin-core-dev
 46 2019-01-30T02:49:36  *** jarthur has quit IRC
 47 2019-01-30T02:50:21  *** rhavar_ has quit IRC
 48 2019-01-30T02:50:45  *** rhavar has joined #bitcoin-core-dev
 49 2019-01-30T03:01:07  *** pinheadmz has quit IRC
 50 2019-01-30T03:37:55  *** IZooo has joined #bitcoin-core-dev
 51 2019-01-30T03:38:41  <IZooo> Hello !
 52 2019-01-30T03:38:49  *** sipa has quit IRC
 53 2019-01-30T03:39:07  *** sipa has joined #bitcoin-core-dev
 54 2019-01-30T03:41:09  *** Murch has quit IRC
 55 2019-01-30T03:43:17  *** Dean_Guss has joined #bitcoin-core-dev
 56 2019-01-30T03:43:42  *** Murch has joined #bitcoin-core-dev
 57 2019-01-30T03:43:45  *** IZooo has quit IRC
 58 2019-01-30T03:57:53  *** pinheadmz has joined #bitcoin-core-dev
 59 2019-01-30T04:03:29  *** Murch has quit IRC
 60 2019-01-30T04:07:44  *** Krellan has quit IRC
 61 2019-01-30T04:14:08  *** spinza has joined #bitcoin-core-dev
 62 2019-01-30T04:23:58  *** pinheadmz has quit IRC
 63 2019-01-30T04:34:44  *** mistergold has quit IRC
 64 2019-01-30T04:46:34  *** hebasto has joined #bitcoin-core-dev
 65 2019-01-30T05:41:12  *** dviola has joined #bitcoin-core-dev
 66 2019-01-30T05:56:03  *** miknotauro has joined #bitcoin-core-dev
 67 2019-01-30T06:03:55  *** dviola has quit IRC
 68 2019-01-30T06:30:46  *** pinheadmz has joined #bitcoin-core-dev
 69 2019-01-30T07:24:04  *** ThomasLuong has joined #bitcoin-core-dev
 70 2019-01-30T07:36:04  *** jtimon has quit IRC
 71 2019-01-30T07:39:05  *** Murch has joined #bitcoin-core-dev
 72 2019-01-30T07:49:59  *** Dean_Guss has quit IRC
 73 2019-01-30T07:58:16  *** pinheadmz has quit IRC
 74 2019-01-30T08:00:52  *** DeanGuss has joined #bitcoin-core-dev
 75 2019-01-30T08:10:03  *** hashist has quit IRC
 76 2019-01-30T08:20:02  *** promag has quit IRC
 77 2019-01-30T08:48:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 78 2019-01-30T08:52:29  *** schmidty_ has joined #bitcoin-core-dev
 79 2019-01-30T08:52:58  *** schmidty has quit IRC
 80 2019-01-30T08:54:04  *** schmidty has joined #bitcoin-core-dev
 81 2019-01-30T08:54:04  *** schmidty_ has quit IRC
 82 2019-01-30T09:01:52  *** Chris_Stewart_5 has quit IRC
 83 2019-01-30T09:04:14  *** setpill has joined #bitcoin-core-dev
 84 2019-01-30T09:06:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 85 2019-01-30T09:10:17  *** Krellan has joined #bitcoin-core-dev
 86 2019-01-30T09:12:07  *** ThomasLuong has quit IRC
 87 2019-01-30T09:12:21  *** rhavar has quit IRC
 88 2019-01-30T09:31:49  *** Zenton has joined #bitcoin-core-dev
 89 2019-01-30T09:47:46  *** fanquake has joined #bitcoin-core-dev
 90 2019-01-30T09:48:30  *** promag has joined #bitcoin-core-dev
 91 2019-01-30T09:52:56  *** promag has quit IRC
 92 2019-01-30T10:03:03  *** kexkey has quit IRC
 93 2019-01-30T10:07:16  *** promag has joined #bitcoin-core-dev
 94 2019-01-30T10:09:20  *** promag has quit IRC
 95 2019-01-30T10:09:58  *** timothy has joined #bitcoin-core-dev
 96 2019-01-30T10:11:18  *** wpaulino has quit IRC
 97 2019-01-30T10:20:06  *** jungly has joined #bitcoin-core-dev
 98 2019-01-30T10:21:30  *** spinza has quit IRC
 99 2019-01-30T10:25:29  *** spinza has joined #bitcoin-core-dev
100 2019-01-30T10:26:58  *** root has joined #bitcoin-core-dev
101 2019-01-30T10:27:21  *** root is now known as Guest94198
102 2019-01-30T10:28:21  *** promag has joined #bitcoin-core-dev
103 2019-01-30T10:28:34  *** Guest94198 has quit IRC
104 2019-01-30T10:29:06  *** root__ has joined #bitcoin-core-dev
105 2019-01-30T10:29:14  *** Chris_Stewart_5 has quit IRC
106 2019-01-30T10:29:38  *** root__ has quit IRC
107 2019-01-30T10:31:56  *** promag has quit IRC
108 2019-01-30T10:33:38  *** rex4539 has quit IRC
109 2019-01-30T10:37:14  *** wpaulino has joined #bitcoin-core-dev
110 2019-01-30T10:51:20  *** Murch has quit IRC
111 2019-01-30T11:02:01  *** rh0nj has quit IRC
112 2019-01-30T11:03:07  *** rh0nj has joined #bitcoin-core-dev
113 2019-01-30T11:13:00  *** ddustin has quit IRC
114 2019-01-30T11:13:49  *** ddustin has joined #bitcoin-core-dev
115 2019-01-30T11:17:58  *** ddustin has quit IRC
116 2019-01-30T11:22:13  *** promag has joined #bitcoin-core-dev
117 2019-01-30T11:26:45  *** Guyver2 has joined #bitcoin-core-dev
118 2019-01-30T11:27:57  *** ghost43 has quit IRC
119 2019-01-30T11:28:13  *** ghost43 has joined #bitcoin-core-dev
120 2019-01-30T11:29:57  *** rex4539 has joined #bitcoin-core-dev
121 2019-01-30T11:39:18  *** bitcoin-git has joined #bitcoin-core-dev
122 2019-01-30T11:39:18  <bitcoin-git> [bitcoin] hebasto opened pull request #15292: Remove 'boost::optional'-related gcc warnings (master...0190130-gcc-maybeuninitialized) https://github.com/bitcoin/bitcoin/pull/15292
123 2019-01-30T11:39:18  *** bitcoin-git has left #bitcoin-core-dev
124 2019-01-30T11:42:16  *** rex4539 has quit IRC
125 2019-01-30T11:46:36  *** AaronvanW has joined #bitcoin-core-dev
126 2019-01-30T11:49:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
127 2019-01-30T11:50:34  *** spinza has quit IRC
128 2019-01-30T11:53:28  *** drexl has quit IRC
129 2019-01-30T11:54:19  *** drexl has joined #bitcoin-core-dev
130 2019-01-30T11:59:24  *** spinza has joined #bitcoin-core-dev
131 2019-01-30T12:22:27  *** Chris_Stewart_5 has quit IRC
132 2019-01-30T12:27:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
133 2019-01-30T12:38:32  *** Chris_Stewart_5 has quit IRC
134 2019-01-30T12:43:55  *** laurentmt has joined #bitcoin-core-dev
135 2019-01-30T12:47:36  *** Skirmant has joined #bitcoin-core-dev
136 2019-01-30T12:53:24  *** promag has quit IRC
137 2019-01-30T12:53:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
138 2019-01-30T12:58:43  *** promag has joined #bitcoin-core-dev
139 2019-01-30T13:09:14  <provoostenator> IsMine is thoroughly confusing :-) Can anyone confirm or debunk my reasoning in #15263?
140 2019-01-30T13:09:16  <gribble> https://github.com/bitcoin/bitcoin/issues/15263 | Descriptor expansions only need pubkey entries for PKH/WPKH by sipa · Pull Request #15263 · bitcoin/bitcoin · GitHub
141 2019-01-30T13:14:18  *** ddustin has joined #bitcoin-core-dev
142 2019-01-30T13:17:46  *** promag has quit IRC
143 2019-01-30T13:18:46  *** ddustin has quit IRC
144 2019-01-30T13:22:15  <provoostenator> And so in a descriptor based wallet, we would want a Descriptor method which for a given transaction checks if it spends to/from it?
145 2019-01-30T13:23:00  <provoostenator> And then AddToWalletIfInvolvingMe just calls that on all its descriptors in order to decide what to add.
146 2019-01-30T13:27:52  *** owowo has quit IRC
147 2019-01-30T13:34:00  *** owowo has joined #bitcoin-core-dev
148 2019-01-30T13:48:27  *** promag has joined #bitcoin-core-dev
149 2019-01-30T13:52:52  *** promag has quit IRC
150 2019-01-30T14:07:57  *** fanquake has quit IRC
151 2019-01-30T14:22:57  *** promag has joined #bitcoin-core-dev
152 2019-01-30T14:25:44  *** Chris_Stewart_5 has quit IRC
153 2019-01-30T14:32:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
154 2019-01-30T14:49:17  <promag> jimpo: do you consider implementing support for concurrent calls to TxIndex::FindTx?
155 2019-01-30T14:52:43  *** bitcoin-git has joined #bitcoin-core-dev
156 2019-01-30T14:52:44  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/72ca72e6370e...29396bd66999
157 2019-01-30T14:52:45  <bitcoin-git> bitcoin/master 4f2e6c8 MarcoFalke: Squashed 'src/leveldb/' changes from 524b7e36a8..f545dfabff
158 2019-01-30T14:52:46  <bitcoin-git> bitcoin/master fa61801 MarcoFalke: Pull leveldb subtree
159 2019-01-30T14:52:47  <bitcoin-git> bitcoin/master 29396bd Wladimir J. van der Laan: Merge #15270: Pull leveldb subtree
160 2019-01-30T14:52:48  *** bitcoin-git has left #bitcoin-core-dev
161 2019-01-30T14:53:27  *** bitcoin-git has joined #bitcoin-core-dev
162 2019-01-30T14:53:27  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15270: Pull leveldb subtree (master...Mf1901-subtreeLeveldb) https://github.com/bitcoin/bitcoin/pull/15270
163 2019-01-30T14:53:27  *** bitcoin-git has left #bitcoin-core-dev
164 2019-01-30T14:55:06  <wumpus> gkrizek: oh thanks for restarting the bot!
165 2019-01-30T14:55:57  <wumpus> gkrizek: "but not sure where logs are being sent"  ~/ghi.log :)
166 2019-01-30T14:58:16  <gkrizek> wumpus no problem.  I saw that log but it looked like it didn’t have any logs for days. I’ll keep an eye on it though.
167 2019-01-30T14:58:23  <wumpus> jonasschnelli: it was an intermittent error, happened exaxtly once, I haven't been able to reproduce it
168 2019-01-30T14:59:48  *** spaced0ut has joined #bitcoin-core-dev
169 2019-01-30T15:00:57  <wumpus> MarcoFalke: adding dongcarl sounds good to me, will do
170 2019-01-30T15:02:17  *** lmk22 has quit IRC
171 2019-01-30T15:17:21  <wumpus> gkrizek: once we're sure the bot is stable I'll add it to crontab etc to automatically (re)start
172 2019-01-30T15:32:01  <wumpus> does it run for merges to 0.17? just merged 15252 but nothing
173 2019-01-30T15:43:23  <gkrizek> wumpus sounds good It should message about any PR merges. It only comments about pushes to specific branches, but 0.17 should be one of them. Looking at the logs
174 2019-01-30T15:46:53  <gkrizek> I'm going to restart it with debug enabled to try to catch some of this.
175 2019-01-30T15:49:28  *** jtimon has joined #bitcoin-core-dev
176 2019-01-30T15:51:46  <gkrizek> wumpus you can resend those payloads if you want to test it out
177 2019-01-30T15:52:51  *** pinheadmz has joined #bitcoin-core-dev
178 2019-01-30T15:54:15  <wumpus> gkrizek: yeh i'll rewind the 0.17 one
179 2019-01-30T15:54:38  *** rex4539 has joined #bitcoin-core-dev
180 2019-01-30T15:56:44  <sipa> provoostenator: with my latest PR pubkey entries in the expansion are only created for "pkh", "wpkh" and "combo" descriptors
181 2019-01-30T15:57:08  *** bitcoin-git has joined #bitcoin-core-dev
182 2019-01-30T15:57:08  <bitcoin-git> [bitcoin] fanquake merged pull request #15252: [0.17] Backport: Update zmq to 4.3.1 (.17...17-backport-15188) https://github.com/bitcoin/bitcoin/pull/15252
183 2019-01-30T15:57:08  *** bitcoin-git has left #bitcoin-core-dev
184 2019-01-30T15:59:28  *** Deinogalerix21 has joined #bitcoin-core-dev
185 2019-01-30T16:00:08  <gkrizek> wumpus so that worked sending the PR message, but I see the commit push messages failed. I'll go fix that now
186 2019-01-30T16:00:41  *** Deinogalerix21 has quit IRC
187 2019-01-30T16:02:38  *** MrPaz has joined #bitcoin-core-dev
188 2019-01-30T16:02:47  *** phwalkr has joined #bitcoin-core-dev
189 2019-01-30T16:03:02  <wumpus> gkrizek: any idea why it was missed the first time around?
190 2019-01-30T16:04:18  <gkrizek> No, I could see that it connected to IRC successfully but just stalled after that. So something happened with the IRC server. I'll leave debug on for a while so I can catch little errors like this.
191 2019-01-30T16:07:17  <wumpus> gkrizek: ohh okay thank you
192 2019-01-30T16:09:51  <wumpus> no big deal github's own service was also not 100% reliable in delivery
193 2019-01-30T16:12:25  *** setpill has quit IRC
194 2019-01-30T16:12:43  <gkrizek> Good to know! haha. I'll make some updates to hopefully fix these issues. Then I'll monitor the logs throughout the day and try to catch any new problems and fix them.
195 2019-01-30T16:14:47  <gkrizek> Thanks everyone for being patient with this! It's very hard for me to adequately mimic the bitcoin repo payloads and IRC stuff, so naturally the bugs happen in "production".
196 2019-01-30T16:21:18  *** bitcoin-git has joined #bitcoin-core-dev
197 2019-01-30T16:21:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd8bda161e35...a47319dada2f
198 2019-01-30T16:21:19  <bitcoin-git> bitcoin/master 04da9f4 Amiti Uttarwar: [RPC] Update getrawtransaction interface
199 2019-01-30T16:21:19  <bitcoin-git> bitcoin/master a47319d MarcoFalke: Merge #15159: [RPC] Remove lookup to UTXO set from GetTransaction
200 2019-01-30T16:21:21  *** bitcoin-git has left #bitcoin-core-dev
201 2019-01-30T16:21:55  *** bitcoin-git has joined #bitcoin-core-dev
202 2019-01-30T16:21:55  <bitcoin-git> [bitcoin] amitiuttarwar merged pull request #15159: [RPC] Remove lookup to UTXO set from GetTransaction (master...3931_rebase) https://github.com/bitcoin/bitcoin/pull/15159
203 2019-01-30T16:21:55  *** bitcoin-git has left #bitcoin-core-dev
204 2019-01-30T16:31:10  <promag> gkrizek: is the code available?
205 2019-01-30T16:32:35  <gkrizek> promag https://github.com/gkrizek/ghi
206 2019-01-30T16:33:11  <gkrizek> Finding a couple bugs already that I'm working on fixes for
207 2019-01-30T16:34:00  <promag> is there a 0.17.2 date? still some work in https://github.com/bitcoin/bitcoin/milestone/40
208 2019-01-30T16:34:09  <promag> thaumavorio: athanks gkrizek
209 2019-01-30T16:34:20  <promag> ops :s thanks gkrizek
210 2019-01-30T16:45:23  *** rhavar has joined #bitcoin-core-dev
211 2019-01-30T17:04:15  *** nullptr| has quit IRC
212 2019-01-30T17:06:14  *** laurentmt has quit IRC
213 2019-01-30T17:07:19  *** nullptr| has joined #bitcoin-core-dev
214 2019-01-30T17:18:07  *** brianhoffman has quit IRC
215 2019-01-30T17:19:42  <hebasto> could someone restart Travis on #15163?
216 2019-01-30T17:19:44  <gribble> https://github.com/bitcoin/bitcoin/issues/15163 | Correct units for "-dbcache" and "-prune" by hebasto · Pull Request #15163 · bitcoin/bitcoin · GitHub
217 2019-01-30T17:20:33  <provoostenator> sipa: I know. I want to check that I understand _why_ correctly (see my comment on your PR).
218 2019-01-30T17:22:29  <provoostenator> tl&dr iiuc it's to prevent e.g. with multisig A+B, when A redeems to an address wpkh(a) that suddenly B sees that as part of his wallet.
219 2019-01-30T17:23:27  *** brianhoffman has joined #bitcoin-core-dev
220 2019-01-30T17:26:39  *** ddustin has joined #bitcoin-core-dev
221 2019-01-30T17:27:55  <sipa> provoostenator: it's more that you only happen to need pubkey entries in the signprovider when pubkeys need to be looked up by hash
222 2019-01-30T17:28:18  *** michaelsdunn1 has joined #bitcoin-core-dev
223 2019-01-30T17:29:13  <sipa> provoostenator: it's a bit of a coincidence that that is exactly compatible with what's needed for importmulti
224 2019-01-30T17:31:26  *** ddustin has quit IRC
225 2019-01-30T17:32:31  *** DeanGuss has quit IRC
226 2019-01-30T17:33:29  *** ddustin has joined #bitcoin-core-dev
227 2019-01-30T17:34:11  *** ddustin has quit IRC
228 2019-01-30T17:34:20  *** ddustin has joined #bitcoin-core-dev
229 2019-01-30T17:40:39  *** pinheadmz has quit IRC
230 2019-01-30T17:54:54  *** nev_ has joined #bitcoin-core-dev
231 2019-01-30T17:56:02  *** jungly has quit IRC
232 2019-01-30T18:03:18  *** ddustin has quit IRC
233 2019-01-30T18:03:19  *** miknotauro has quit IRC
234 2019-01-30T18:04:14  *** ddustin has joined #bitcoin-core-dev
235 2019-01-30T18:09:00  *** Skirmant has quit IRC
236 2019-01-30T18:13:04  *** Murch has joined #bitcoin-core-dev
237 2019-01-30T18:13:46  *** Skirmant has joined #bitcoin-core-dev
238 2019-01-30T18:16:58  *** pinheadmz has joined #bitcoin-core-dev
239 2019-01-30T18:18:42  *** Chris_Stewart_5 has quit IRC
240 2019-01-30T18:19:03  *** laurentmt has joined #bitcoin-core-dev
241 2019-01-30T18:20:27  <MarcoFalke> Anyone interested in trading reviews on #15043?
242 2019-01-30T18:20:35  <gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
243 2019-01-30T18:20:49  *** Murch has quit IRC
244 2019-01-30T18:22:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
245 2019-01-30T18:28:20  *** pinheadmz has joined #bitcoin-core-dev
246 2019-01-30T18:33:48  *** nullptr| has quit IRC
247 2019-01-30T18:40:16  *** nullptr| has joined #bitcoin-core-dev
248 2019-01-30T18:51:31  *** laurentmt has quit IRC
249 2019-01-30T18:54:15  *** MrPaz has quit IRC
250 2019-01-30T18:56:10  *** Zenton has quit IRC
251 2019-01-30T19:04:01  *** rh0nj has quit IRC
252 2019-01-30T19:05:08  *** rh0nj has joined #bitcoin-core-dev
253 2019-01-30T19:06:46  *** jarthur has joined #bitcoin-core-dev
254 2019-01-30T19:06:56  *** Murch has joined #bitcoin-core-dev
255 2019-01-30T19:08:44  *** emilr has quit IRC
256 2019-01-30T19:12:00  *** Madars has quit IRC
257 2019-01-30T19:14:10  *** mildly_risky has quit IRC
258 2019-01-30T19:16:17  *** hashist has joined #bitcoin-core-dev
259 2019-01-30T19:19:54  *** Madars has joined #bitcoin-core-dev
260 2019-01-30T19:21:25  <wumpus> src/wallet/rpcwallet.cpp:1638:41: warning: ‘*((void*)& height +4)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
261 2019-01-30T19:21:27  <wumpus> src/wallet/wallet.cpp:1704:72: warning: ‘*((void*)& block_height +4)’ may be used uninitialized in this function [-Wmaybe-uninitialize]d
262 2019-01-30T19:21:33  <wumpus> that's some scary warnings
263 2019-01-30T19:21:46  *** bitcoin-git has joined #bitcoin-core-dev
264 2019-01-30T19:21:46  <bitcoin-git> [bitcoin] Empact opened pull request #15294: [moveonly] Extract RipeMd160 (master...ripe-md) https://github.com/bitcoin/bitcoin/pull/15294
265 2019-01-30T19:21:47  *** bitcoin-git has left #bitcoin-core-dev
266 2019-01-30T19:22:17  <hebasto> wumpus: could you look into #15292?
267 2019-01-30T19:22:18  <gribble> https://github.com/bitcoin/bitcoin/issues/15292 | Remove boost::optional-related false positive -Wmaybe-uninitialized warnings on GCC compiler by hebasto · Pull Request #15292 · bitcoin/bitcoin · GitHub
268 2019-01-30T19:23:28  *** bitcoin-git has joined #bitcoin-core-dev
269 2019-01-30T19:23:29  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04226f8706b5...77339e5c244b
270 2019-01-30T19:23:29  <bitcoin-git> bitcoin/master 6f6514a Hennadii Stepanov: Correct units for "-dbcache" and "-prune"
271 2019-01-30T19:23:30  <bitcoin-git> bitcoin/master 77339e5 Wladimir J. van der Laan: Merge #15163: Correct units for "-dbcache" and "-prune"
272 2019-01-30T19:23:39  *** bitcoin-git has left #bitcoin-core-dev
273 2019-01-30T19:24:05  *** bitcoin-git has joined #bitcoin-core-dev
274 2019-01-30T19:24:05  <bitcoin-git> [bitcoin] hebasto merged pull request #15163: Correct units for "-dbcache" and "-prune" (master...0190114-correct-info-units) https://github.com/bitcoin/bitcoin/pull/15163
275 2019-01-30T19:24:10  *** bitcoin-git has left #bitcoin-core-dev
276 2019-01-30T19:25:10  <wumpus> hebasto: good point, will take a look
277 2019-01-30T19:25:37  <wumpus> gkrizek: i think the merger name is wrong^^
278 2019-01-30T19:26:11  <gkrizek> Looking at the comments before it, I'm guessing you merged it?
279 2019-01-30T19:26:16  <wumpus> the bot makes it look like everyone (even those without commit access) merge their own PRs :$
280 2019-01-30T19:26:19  <wumpus> yep!
281 2019-01-30T19:26:24  *** emilr has joined #bitcoin-core-dev
282 2019-01-30T19:26:35  <gkrizek> Ok, yep. Fixing that now.
283 2019-01-30T19:27:15  <gkrizek> I believe I have fix the other issues though! Found some bugs that were causing it to basically be inoperable. So should be working much better now, but I'll watch it today
284 2019-01-30T19:33:42  <gwillen> win goto #cslounge-finance
285 2019-01-30T19:33:47  <gwillen> whoops
286 2019-01-30T19:34:41  *** nev_ has quit IRC
287 2019-01-30T19:36:32  <gkrizek> wumpus username issue fixed so all known issues are fixed, but I'll keep an eye on it
288 2019-01-30T19:36:45  <meshcollider> gkrizek: thanks!
289 2019-01-30T19:37:15  <gkrizek> No problem! :D
290 2019-01-30T19:37:19  <wumpus> gkrizek: yay !
291 2019-01-30T19:37:59  <wumpus> I'll set it up for secp256k1 too
292 2019-01-30T19:39:08  <gkrizek> Awesome
293 2019-01-30T19:45:00  <wumpus> gkrizek: ok I've added the webhook in the secp256k1 project and updated the ghi config to add a new 'pool' for it
294 2019-01-30T19:45:55  <wumpus> i think this should do it
295 2019-01-30T19:46:27  *** nullptr| has quit IRC
296 2019-01-30T19:52:13  *** nullptr| has joined #bitcoin-core-dev
297 2019-01-30T19:55:48  <gkrizek> Ok, great. I see in the logs: "Received repository 'bitcoin-core/secp256k1', but no pool is configured for it.", but I'm guessing you added the webhook before the update to the config?
298 2019-01-30T19:57:38  <MarcoFalke> wumpus: Mind to create a https://github.com/new for bitcoin-core/qa-assets ?
299 2019-01-30T19:58:26  <MarcoFalke> To hold Bitcoin Core related blobs used for quality assurance
300 2019-01-30T19:59:24  <wumpus> gkrizek: yes; i also guess it needs to be restarted before the change to the config takes effect?
301 2019-01-30T19:59:33  <wumpus> MarcoFalke: sure!
302 2019-01-30T19:59:39  <MarcoFalke> kewl
303 2019-01-30T19:59:56  <gkrizek> No it shouldn't actually. So I'm guessing it was just a timing mismatch
304 2019-01-30T20:00:41  <wumpus> gkrizek: i'll resend the event just in case
305 2019-01-30T20:01:23  <gkrizek> "Received the 'ping' event Sent 'pong'"
306 2019-01-30T20:01:26  <gkrizek> It works!
307 2019-01-30T20:01:29  <wumpus> woohoo!
308 2019-01-30T20:02:00  <MarcoFalke> I think #15043 is ready for merge, since there is no substantial review and it is holding back my work on the fuzz test runner
309 2019-01-30T20:02:03  <gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
310 2019-01-30T20:05:14  <wumpus> MarcoFalke: https://github.com/bitcoin-core/qa-assets is live
311 2019-01-30T20:06:02  <wumpus> MarcoFalke: yes, was kind of waiting to merge that
312 2019-01-30T20:08:11  *** spaced0ut has quit IRC
313 2019-01-30T20:10:47  *** bitcoin-git has joined #bitcoin-core-dev
314 2019-01-30T20:10:48  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/77339e5c244b...9553102c38c0
315 2019-01-30T20:10:48  <bitcoin-git> bitcoin/master fab4bed MarcoFalke: [test] fuzz: make test_one_input return void
316 2019-01-30T20:10:50  <bitcoin-git> bitcoin/master 2ca632e MarcoFalke: test: Build fuzz targets into seperate executables
317 2019-01-30T20:10:50  <bitcoin-git> bitcoin/master 9553102 Wladimir J. van der Laan: Merge #15043: test: Build fuzz targets into seperate executables
318 2019-01-30T20:11:00  *** bitcoin-git has left #bitcoin-core-dev
319 2019-01-30T20:11:24  *** bitcoin-git has joined #bitcoin-core-dev
320 2019-01-30T20:11:25  <bitcoin-git> [bitcoin] laanwj merged pull request #15043: test: Build fuzz targets into seperate executables (master...Mf1812-buildFuzzTargets) https://github.com/bitcoin/bitcoin/pull/15043
321 2019-01-30T20:11:28  *** bitcoin-git has left #bitcoin-core-dev
322 2019-01-30T20:12:41  <MarcoFalke> \o/
323 2019-01-30T20:13:27  <wumpus> MarcoFalke: any additional people that should have commit access?
324 2019-01-30T20:14:22  *** bitcoin-git has joined #bitcoin-core-dev
325 2019-01-30T20:14:22  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9553102c38c0...bb36f5e24b63
326 2019-01-30T20:14:23  <bitcoin-git> bitcoin/master fa83999 MarcoFalke: travis: Compile once on trusty
327 2019-01-30T20:14:23  <bitcoin-git> bitcoin/master fa5ce3f MarcoFalke: travis: Compile trusty with depends for now
328 2019-01-30T20:14:24  <bitcoin-git> bitcoin/master bb36f5e MarcoFalke: Merge #15276: travis: Compile once on trusty
329 2019-01-30T20:14:28  <MarcoFalke> Pretty much anyone who wants to and is a common contributor to Core
330 2019-01-30T20:14:32  *** bitcoin-git has left #bitcoin-core-dev
331 2019-01-30T20:15:06  *** bitcoin-git has joined #bitcoin-core-dev
332 2019-01-30T20:15:06  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15276: travis: Compile once on trusty (master...Mf1901-travisTrusty) https://github.com/bitcoin/bitcoin/pull/15276
333 2019-01-30T20:15:07  *** bitcoin-git has left #bitcoin-core-dev
334 2019-01-30T20:15:13  <wumpus> ok
335 2019-01-30T20:15:44  <wumpus> I created a qa developers team just in case we want to add people (who are not the usual) at some point
336 2019-01-30T20:16:32  *** dviola has joined #bitcoin-core-dev
337 2019-01-30T20:16:37  <gkrizek> Can I get a few more eyes on #15255?
338 2019-01-30T20:16:39  <gribble> https://github.com/bitcoin/bitcoin/issues/15255 | [tests] Remove travis_wait from lint script by gkrizek · Pull Request #15255 · bitcoin/bitcoin · GitHub
339 2019-01-30T20:17:03  <gkrizek> Simple, but it's the thing that caused our master CI failures that we couldn't find the cause
340 2019-01-30T20:21:50  <wumpus> I mean one great advantage of having split repositories is that we could spread the load of maintenance a bit
341 2019-01-30T20:22:51  <MarcoFalke> Merging of fuzz seeds could even be automatic. I am going to write a script for that
342 2019-01-30T20:23:06  <wumpus> cool!
343 2019-01-30T20:23:15  <MarcoFalke> Only seeds that increase node-coverage are going to be merged
344 2019-01-30T20:33:31  *** pinheadmz has quit IRC
345 2019-01-30T20:52:36  *** pinheadmz has joined #bitcoin-core-dev
346 2019-01-30T20:57:36  *** DeanGuss has joined #bitcoin-core-dev
347 2019-01-30T21:03:05  <wumpus> promag: "is there a 0.17.2 date?" → no, we never plan release dates for minor releases, usually they're motivated by some more serious bug
348 2019-01-30T21:12:20  *** bitcoin-git has joined #bitcoin-core-dev
349 2019-01-30T21:12:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295
350 2019-01-30T21:12:24  *** bitcoin-git has left #bitcoin-core-dev
351 2019-01-30T21:18:24  *** rex4539 has quit IRC
352 2019-01-30T21:19:58  *** millerti has joined #bitcoin-core-dev
353 2019-01-30T21:22:09  *** spaced0ut has joined #bitcoin-core-dev
354 2019-01-30T21:24:45  *** timothy has quit IRC
355 2019-01-30T21:25:07  *** niska has quit IRC
356 2019-01-30T21:28:46  *** niska has joined #bitcoin-core-dev
357 2019-01-30T21:29:41  *** bitcoin-git has joined #bitcoin-core-dev
358 2019-01-30T21:29:41  <bitcoin-git> [bitcoin] practicalswift opened pull request #15296: tests: Add script checking for deterministic line coverage in unit tests (master...test_deterministic_coverage) https://github.com/bitcoin/bitcoin/pull/15296
359 2019-01-30T21:29:47  *** bitcoin-git has left #bitcoin-core-dev
360 2019-01-30T21:30:25  *** rex4539 has joined #bitcoin-core-dev
361 2019-01-30T21:30:50  *** Guyver2 has quit IRC
362 2019-01-30T21:34:59  *** AaronvanW has quit IRC
363 2019-01-30T21:38:56  *** Chris_Stewart_5 has quit IRC
364 2019-01-30T21:40:55  <hebasto> Could someone restart Travis on #15292? My build is ok: https://travis-ci.org/hebasto/bitcoin/builds/486611945
365 2019-01-30T21:40:56  <gribble> https://github.com/bitcoin/bitcoin/issues/15292 | Remove boost::optional-related false positive -Wmaybe-uninitialized warnings on GCC compiler by hebasto · Pull Request #15292 · bitcoin/bitcoin · GitHub
366 2019-01-30T21:42:32  <wumpus> hebasto: sure
367 2019-01-30T21:42:47  <hebasto> wumpus: ty
368 2019-01-30T21:48:14  *** ddustin has quit IRC
369 2019-01-30T21:49:01  *** ddustin has joined #bitcoin-core-dev
370 2019-01-30T21:49:18  *** hebasto has quit IRC
371 2019-01-30T21:53:28  *** ddustin has quit IRC
372 2019-01-30T21:56:51  *** Murch has quit IRC
373 2019-01-30T22:05:57  *** pinheadmz has quit IRC
374 2019-01-30T22:13:10  *** spinza has quit IRC
375 2019-01-30T22:13:41  *** pinheadmz has joined #bitcoin-core-dev
376 2019-01-30T22:37:12  *** AaronvanW has joined #bitcoin-core-dev
377 2019-01-30T22:38:54  *** spinza has joined #bitcoin-core-dev
378 2019-01-30T22:39:29  *** bitcoin-git has joined #bitcoin-core-dev
379 2019-01-30T22:39:30  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb36f5e24b63...cb77dc820f1b
380 2019-01-30T22:39:30  <bitcoin-git> bitcoin/master 2d48314 Hennadii Stepanov: Remove 'boost::optional'-related gcc warnings
381 2019-01-30T22:39:30  <bitcoin-git> bitcoin/master cb77dc8 Wladimir J. van der Laan: Merge #15292: Remove 'boost::optional'-related false positive -Wmaybe-unin...
382 2019-01-30T22:39:33  *** bitcoin-git has left #bitcoin-core-dev
383 2019-01-30T22:40:14  *** bitcoin-git has joined #bitcoin-core-dev
384 2019-01-30T22:40:14  <bitcoin-git> [bitcoin] laanwj merged pull request #15292: Remove 'boost::optional'-related false positive -Wmaybe-uninitialized warnings on GCC compiler (master...0190130-gcc-maybeuninitialized) https://github.com/bitcoin/bitcoin/pull/15292
385 2019-01-30T22:40:16  *** bitcoin-git has left #bitcoin-core-dev
386 2019-01-30T22:41:56  *** pinheadmz has quit IRC
387 2019-01-30T22:43:09  *** pinheadmz has joined #bitcoin-core-dev
388 2019-01-30T22:49:38  *** hebasto has joined #bitcoin-core-dev
389 2019-01-30T23:03:04  *** pinheadmz has quit IRC
390 2019-01-30T23:05:22  *** pinheadmz has joined #bitcoin-core-dev
391 2019-01-30T23:07:30  *** hebasto has quit IRC
392 2019-01-30T23:13:43  *** mn949588 has joined #bitcoin-core-dev
393 2019-01-30T23:19:49  *** hashistnd has joined #bitcoin-core-dev
394 2019-01-30T23:21:00  *** bitcoin-git has joined #bitcoin-core-dev
395 2019-01-30T23:21:01  <bitcoin-git> [bitcoin] Empact closed pull request #15171: test: Wait before cleanup on exit (master...test-wait-cleanup) https://github.com/bitcoin/bitcoin/pull/15171
396 2019-01-30T23:21:02  *** bitcoin-git has left #bitcoin-core-dev
397 2019-01-30T23:21:26  *** hashist has quit IRC
398 2019-01-30T23:36:57  *** michaelsdunn1 has quit IRC
399 2019-01-30T23:37:53  *** Zenton has joined #bitcoin-core-dev
400 2019-01-30T23:39:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
401 2019-01-30T23:57:24  *** pinheadmz has quit IRC
402 2019-01-30T23:58:35  *** pinheadmz has joined #bitcoin-core-dev