12019-02-04T00:01:40  *** miknotauro has quit IRC
  22019-02-04T00:06:34  *** Victor_sueca has joined #bitcoin-core-dev
  32019-02-04T00:07:56  *** Victorsueca has quit IRC
  42019-02-04T00:19:09  *** justanotheruser has quit IRC
  52019-02-04T00:30:53  *** spinza has quit IRC
  62019-02-04T00:34:56  *** justanotheruser has joined #bitcoin-core-dev
  72019-02-04T01:01:17  *** Jbaczuk has quit IRC
  82019-02-04T01:11:01  *** rh0nj has quit IRC
  92019-02-04T01:12:07  *** rh0nj has joined #bitcoin-core-dev
 102019-02-04T01:25:11  *** justanotheruser has quit IRC
 112019-02-04T01:44:54  *** justanotheruser has joined #bitcoin-core-dev
 122019-02-04T02:04:49  *** spinza has joined #bitcoin-core-dev
 132019-02-04T02:12:34  *** pinheadmz has quit IRC
 142019-02-04T02:25:00  *** profmac has quit IRC
 152019-02-04T02:34:51  *** AaronvanW has quit IRC
 162019-02-04T02:37:58  *** pinheadmz has joined #bitcoin-core-dev
 172019-02-04T02:42:24  *** pinheadmz has quit IRC
 182019-02-04T02:58:52  *** pinheadmz has joined #bitcoin-core-dev
 192019-02-04T03:17:27  *** pinheadmz has quit IRC
 202019-02-04T03:21:58  *** mistergold has joined #bitcoin-core-dev
 212019-02-04T03:23:11  *** phwalkr has joined #bitcoin-core-dev
 222019-02-04T03:28:28  *** mistergold has quit IRC
 232019-02-04T03:30:27  *** owowo has quit IRC
 242019-02-04T03:34:47  *** owowo has joined #bitcoin-core-dev
 252019-02-04T03:50:43  *** murrayn has joined #bitcoin-core-dev
 262019-02-04T03:52:59  *** rex4539 has quit IRC
 272019-02-04T03:58:04  *** jarthur has quit IRC
 282019-02-04T03:58:39  *** jarthur has joined #bitcoin-core-dev
 292019-02-04T04:08:25  *** Skirmant has quit IRC
 302019-02-04T04:10:08  *** DeanGuss has joined #bitcoin-core-dev
 312019-02-04T04:32:16  *** murrayn has quit IRC
 322019-02-04T04:32:43  *** murrayn has joined #bitcoin-core-dev
 332019-02-04T04:33:56  *** jarthur has quit IRC
 342019-02-04T04:35:38  *** ap4lmtree- has joined #bitcoin-core-dev
 352019-02-04T04:36:46  *** murrayn has quit IRC
 362019-02-04T04:37:10  *** murrayn has joined #bitcoin-core-dev
 372019-02-04T04:39:31  *** ap4lmtree has quit IRC
 382019-02-04T04:40:04  *** jarthur has joined #bitcoin-core-dev
 392019-02-04T04:59:28  *** ap4lmtree- is now known as ap4lmtree
 402019-02-04T05:09:44  *** jtimon has quit IRC
 412019-02-04T05:23:50  *** jarthur has quit IRC
 422019-02-04T05:35:27  *** hebasto has joined #bitcoin-core-dev
 432019-02-04T06:11:58  *** bitcoin-git has joined #bitcoin-core-dev
 442019-02-04T06:11:59  <bitcoin-git> [bitcoin] AkioNak opened pull request #15335: Fix lack of warning of unrecognized section names (master...conf_include_multi) https://github.com/bitcoin/bitcoin/pull/15335
 452019-02-04T06:12:05  *** bitcoin-git has left #bitcoin-core-dev
 462019-02-04T06:20:24  *** profmac has joined #bitcoin-core-dev
 472019-02-04T06:35:54  *** mistergold has joined #bitcoin-core-dev
 482019-02-04T06:54:56  *** mistergold has quit IRC
 492019-02-04T07:06:58  *** pinheadmz has joined #bitcoin-core-dev
 502019-02-04T07:11:37  *** mistergold has joined #bitcoin-core-dev
 512019-02-04T07:13:47  *** DeanGuss has quit IRC
 522019-02-04T07:37:56  *** mistergold has quit IRC
 532019-02-04T07:51:33  *** pinheadmz has quit IRC
 542019-02-04T08:14:32  *** mistergold has joined #bitcoin-core-dev
 552019-02-04T08:23:07  *** DeanGuss has joined #bitcoin-core-dev
 562019-02-04T08:24:03  *** bitcoin-git has joined #bitcoin-core-dev
 572019-02-04T08:24:03  <bitcoin-git> [bitcoin] bvbfan opened pull request #15336: Enable moving of hashes, uints, outpoints (master...master) https://github.com/bitcoin/bitcoin/pull/15336
 582019-02-04T08:24:16  *** bitcoin-git has left #bitcoin-core-dev
 592019-02-04T08:49:46  *** tryphe_ has joined #bitcoin-core-dev
 602019-02-04T08:51:18  *** tryphe has quit IRC
 612019-02-04T08:58:25  *** darosior has joined #bitcoin-core-dev
 622019-02-04T09:07:23  *** setpill has joined #bitcoin-core-dev
 632019-02-04T09:25:20  *** rafalcpp has quit IRC
 642019-02-04T09:25:25  *** queip has quit IRC
 652019-02-04T09:31:03  *** rafalcpp has joined #bitcoin-core-dev
 662019-02-04T09:34:58  *** Zenton has joined #bitcoin-core-dev
 672019-02-04T09:36:31  *** queip has joined #bitcoin-core-dev
 682019-02-04T09:42:04  *** timothy has joined #bitcoin-core-dev
 692019-02-04T09:51:59  *** fanquake has joined #bitcoin-core-dev
 702019-02-04T10:07:56  *** lnostdal has quit IRC
 712019-02-04T10:10:27  *** bitcoin-git has joined #bitcoin-core-dev
 722019-02-04T10:10:29  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2fbf6a57d282...64127b3098a1
 732019-02-04T10:10:30  <bitcoin-git> bitcoin/master 60e190c João Barbosa: gui: Fix WalletController deletion
 742019-02-04T10:10:30  <bitcoin-git> bitcoin/master 07b9aad João Barbosa: gui: Expose BitcoinGUI::unsubscribeFromCoreSignals
 752019-02-04T10:10:31  <bitcoin-git> bitcoin/master fd6d499 João Barbosa: gui: Fix m_node.startShutdown() order
 762019-02-04T10:10:33  *** bitcoin-git has left #bitcoin-core-dev
 772019-02-04T10:10:54  *** lnostdal has joined #bitcoin-core-dev
 782019-02-04T10:11:13  *** bitcoin-git has joined #bitcoin-core-dev
 792019-02-04T10:11:13  <bitcoin-git> [bitcoin] laanwj merged pull request #15280: gui: Fix shutdown order (master...019-01-gui-shutdown) https://github.com/bitcoin/bitcoin/pull/15280
 802019-02-04T10:11:15  *** bitcoin-git has left #bitcoin-core-dev
 812019-02-04T10:13:16  *** spinza has quit IRC
 822019-02-04T10:25:13  *** Soligor has quit IRC
 832019-02-04T10:25:42  *** spinza has joined #bitcoin-core-dev
 842019-02-04T10:28:26  *** ExtraCrispy has quit IRC
 852019-02-04T10:40:51  *** Soligor has joined #bitcoin-core-dev
 862019-02-04T10:47:06  *** Skirmant has joined #bitcoin-core-dev
 872019-02-04T11:15:59  *** promag has joined #bitcoin-core-dev
 882019-02-04T11:23:02  *** Guyver2 has joined #bitcoin-core-dev
 892019-02-04T11:27:33  *** bitcoin-git has joined #bitcoin-core-dev
 902019-02-04T11:27:33  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64127b3098a1...424327e1a8f5
 912019-02-04T11:27:33  <bitcoin-git> bitcoin/master fae169c MarcoFalke: test: Make bloom tests deterministic
 922019-02-04T11:27:34  <bitcoin-git> bitcoin/master 424327e Wladimir J. van der Laan: Merge #15324: test: Make bloom tests deterministic
 932019-02-04T11:27:35  *** bitcoin-git has left #bitcoin-core-dev
 942019-02-04T11:28:08  *** bitcoin-git has joined #bitcoin-core-dev
 952019-02-04T11:28:08  <bitcoin-git> [bitcoin] laanwj merged pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
 962019-02-04T11:28:09  *** bitcoin-git has left #bitcoin-core-dev
 972019-02-04T11:33:00  *** znd has joined #bitcoin-core-dev
 982019-02-04T11:33:59  <wumpus> #15140 confuses me a bit
 992019-02-04T11:34:01  <gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
1002019-02-04T11:34:09  <wumpus> does it fix an actual problem?
1012019-02-04T11:36:47  *** darosior has quit IRC
1022019-02-04T11:42:56  <luke-jr> wumpus: I guess the test wasn't testing what it was supposed to? not sure
1032019-02-04T11:43:37  *** AaronvanW has joined #bitcoin-core-dev
1042019-02-04T11:43:46  <wumpus> yea that's what it purports to do, the change itself is kind of strange though
1052019-02-04T11:47:17  <wumpus> it seems that a more minimal fix could solve it
1062019-02-04T11:47:25  <wumpus> but I might be wrong
1072019-02-04T11:47:40  *** Skirmant has quit IRC
1082019-02-04T11:49:27  *** jungly has joined #bitcoin-core-dev
1092019-02-04T11:55:33  *** marcoagner has joined #bitcoin-core-dev
1102019-02-04T11:57:48  <promag> coffee break merge #15322
1112019-02-04T11:57:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
1122019-02-04T12:03:06  *** bitcoin-git has joined #bitcoin-core-dev
1132019-02-04T12:03:07  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/424327e1a8f5...ebc6542d982c
1142019-02-04T12:03:07  <bitcoin-git> bitcoin/master 712d35b João Barbosa: wallet: Add missing cs_db lock
1152019-02-04T12:03:08  <bitcoin-git> bitcoin/master ebc6542 Wladimir J. van der Laan: Merge #15322: wallet: Add missing cs_db lock
1162019-02-04T12:03:12  *** bitcoin-git has left #bitcoin-core-dev
1172019-02-04T12:03:50  *** bitcoin-git has joined #bitcoin-core-dev
1182019-02-04T12:03:50  <bitcoin-git> [bitcoin] laanwj merged pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
1192019-02-04T12:03:54  <promag> that was fast
1202019-02-04T12:03:56  *** bitcoin-git has left #bitcoin-core-dev
1212019-02-04T12:04:10  <wumpus> promag: yep already intended to merge that one
1222019-02-04T12:04:20  <promag> ok ty
1232019-02-04T12:04:31  <wumpus> but you reminded me
1242019-02-04T12:05:06  <promag> I'm now with #15153
1252019-02-04T12:05:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
1262019-02-04T12:09:57  <fanquake> promag restarted all the tests in 15153
1272019-02-04T12:10:03  <fanquake> planning on testing that again
1282019-02-04T12:10:30  <promag> fanquake: I'll push shortly
1292019-02-04T12:10:57  <promag> I think it's good enough for 1st GUI support
1302019-02-04T12:12:04  <promag> in order to support "cancel open because it's rescanning" we have to do some refactors
1312019-02-04T12:12:04  <fanquake> promag, yes I think so. There are still edge cases/improvements that can be fixed/made later
1322019-02-04T12:12:27  <fanquake> i.e closing a modal after opening a wallet, then opening the same wallet again
1332019-02-04T12:13:18  <fanquake> You end up with the first completing, then the second opening failing because the same wallet is loaded already.
1342019-02-04T12:13:30  *** mistergo1d has joined #bitcoin-core-dev
1352019-02-04T12:13:39  <promag> fanquake: I think I can fix that, by disabling the close
1362019-02-04T12:13:47  *** mistergold has quit IRC
1372019-02-04T12:13:55  <promag> fanquake: right
1382019-02-04T12:15:06  <fanquake> Disabling the close button could work, although that's probably not ideal if you are stuck with a long time to rescan wallet, and want to bail out.
1392019-02-04T12:15:27  <promag> fanquake: ryanofsky: I think Node::loadWallet should return the Wallet immediately, and the the GUI could add handlers and interact with the wallet asynchronously
1402019-02-04T12:16:23  <promag> fanquake: ah I see, then I it should not be modal, and if the same wallet is opened then it fails
1412019-02-04T12:28:33  <wumpus> hhmm translation process for adding new translations needs to be updated for the MSVC build system
1422019-02-04T12:28:55  <wumpus> translations are listed in three places now :(
1432019-02-04T12:32:03  <wumpus> (working on this)
1442019-02-04T12:34:42  *** EagleTM has joined #bitcoin-core-dev
1452019-02-04T12:44:13  *** rabidus has quit IRC
1462019-02-04T12:44:13  *** jtimon has joined #bitcoin-core-dev
1472019-02-04T12:45:53  *** rabidus has joined #bitcoin-core-dev
1482019-02-04T12:48:04  *** EagleTM has quit IRC
1492019-02-04T13:00:54  *** shesek has quit IRC
1502019-02-04T13:01:59  *** mistergo1d has quit IRC
1512019-02-04T13:04:26  *** mistergold has joined #bitcoin-core-dev
1522019-02-04T13:06:00  *** Skirmant has joined #bitcoin-core-dev
1532019-02-04T13:09:34  *** Skirmant has quit IRC
1542019-02-04T13:15:26  *** phwalkr has quit IRC
1552019-02-04T13:16:04  *** phwalkr has joined #bitcoin-core-dev
1562019-02-04T13:17:05  *** phwalkr has joined #bitcoin-core-dev
1572019-02-04T13:17:48  *** darosior has joined #bitcoin-core-dev
1582019-02-04T13:19:23  *** bitcoin-git has joined #bitcoin-core-dev
1592019-02-04T13:19:23  <bitcoin-git> [bitcoin] benthecarman opened pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337
1602019-02-04T13:19:24  *** bitcoin-git has left #bitcoin-core-dev
1612019-02-04T13:25:27  *** phwalkr has quit IRC
1622019-02-04T13:41:15  *** promag has quit IRC
1632019-02-04T13:42:36  *** thedevworks has joined #bitcoin-core-dev
1642019-02-04T13:48:55  *** bitcoin-git has joined #bitcoin-core-dev
1652019-02-04T13:48:55  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15338: ci: Build and run tests once on freebsd (master...Mf1902-cirrusci) https://github.com/bitcoin/bitcoin/pull/15338
1662019-02-04T13:48:56  *** bitcoin-git has left #bitcoin-core-dev
1672019-02-04T14:10:00  *** promag has joined #bitcoin-core-dev
1682019-02-04T14:12:36  *** bitcoin-git has joined #bitcoin-core-dev
1692019-02-04T14:12:36  <bitcoin-git> [bitcoin] laanwj opened pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339
1702019-02-04T14:12:37  *** bitcoin-git has left #bitcoin-core-dev
1712019-02-04T14:14:19  *** promag has quit IRC
1722019-02-04T14:24:56  *** promag has joined #bitcoin-core-dev
1732019-02-04T14:37:24  *** phwalkr has joined #bitcoin-core-dev
1742019-02-04T14:41:34  *** fanquake has quit IRC
1752019-02-04T14:59:46  *** bitcoin-git has joined #bitcoin-core-dev
1762019-02-04T14:59:46  <bitcoin-git> [bitcoin] hebasto opened pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
1772019-02-04T14:59:52  *** bitcoin-git has left #bitcoin-core-dev
1782019-02-04T15:01:59  *** setpill has quit IRC
1792019-02-04T15:04:11  *** darosior has quit IRC
1802019-02-04T15:10:42  <dongcarl> Re #13865, wondering if people think this is a good idea. Pro: git bisectability, Con: travis will be even slower
1812019-02-04T15:10:44  <gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub
1822019-02-04T15:17:38  <luke-jr> dongcarl: it shouldn't affect build times *too* much, so long as it uses the same build dir between commits
1832019-02-04T15:18:15  <dongcarl> Okay, I will PR to do `git --exec` then
1842019-02-04T15:18:23  <dongcarl> or rather `git rebase --exec`
1852019-02-04T15:18:43  <instagibbs> I don't have a lot of experience in this but how often has this been a problem
1862019-02-04T15:19:40  <dongcarl> instagibbs: You mean git bisectability?
1872019-02-04T15:19:55  <luke-jr> that's a good point too
1882019-02-04T15:20:05  <wumpus> I don't see a strong reason to do this either
1892019-02-04T15:20:10  <instagibbs> dongcarl, correct, how often has this been an issue
1902019-02-04T15:20:18  <luke-jr> AFAIK git bisect doesn't go inside merges unless the issue is part of that set of commits
1912019-02-04T15:20:50  <wumpus> testing the top commit of a PR should be enough, anything else is for certain going to confuse people, how many projects run the CI on every single commit even in merges?
1922019-02-04T15:21:39  <dongcarl> I guess I was thinking that if we had a long-standing bug we could use bisect to find where it started
1932019-02-04T15:21:50  <luke-jr> too bad there's no way to set priorities so Travis just runs everything on intermediate commits if it gets idle cycles
1942019-02-04T15:22:00  <luke-jr> dongcarl: you can do that regardless
1952019-02-04T15:22:05  <wumpus> bisect is already quite usable
1962019-02-04T15:22:11  <wumpus> never had problems really
1972019-02-04T15:22:11  <instagibbs> dongcarl, I believe luke is right in that it can still do it, regardless
1982019-02-04T15:22:11  <dongcarl> Okay cool
1992019-02-04T15:22:23  <instagibbs> as long as merge commits are properly passing
2002019-02-04T15:22:30  <wumpus> right
2012019-02-04T15:22:53  <dongcarl> luke-jr: wanna close #13865?
2022019-02-04T15:22:54  <gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub
2032019-02-04T15:23:11  <instagibbs> You can also mark known-bad commits
2042019-02-04T15:23:13  <instagibbs> and skip them
2052019-02-04T15:24:01  * dongcarl of little faith in the Linus, repenting
2062019-02-04T15:24:07  <luke-jr> dongcarl: I don't have access to close it
2072019-02-04T15:24:33  <luke-jr> instagibbs: hm, I wonder if there's a way to make a permanent list of skip commits
2082019-02-04T15:25:08  <instagibbs> someone can grind through commits and build it :P
2092019-02-04T15:25:29  <instagibbs> then we can make a bisect wrapper script that allows bisection to skip
2102019-02-04T15:26:31  <luke-jr> no, I just mean, next time I'm bisecting, it'd be nice to be able to do `git bisect skip --remember` or something
2112019-02-04T15:27:03  <instagibbs> ah, not sure about that one
2122019-02-04T15:30:52  *** pinheadmz has joined #bitcoin-core-dev
2132019-02-04T15:33:52  *** jarthur has joined #bitcoin-core-dev
2142019-02-04T15:34:28  *** pinheadmz has quit IRC
2152019-02-04T15:36:14  <promag> dongcarl: I like the idea and most branches have few commit. however travis already takes a lot of time..
2162019-02-04T15:37:44  *** michaelsdunn1 has joined #bitcoin-core-dev
2172019-02-04T15:37:45  *** michaelsdunn1 has quit IRC
2182019-02-04T15:37:45  *** michaelsdunn1 has joined #bitcoin-core-dev
2192019-02-04T15:38:54  <promag> wumpus: if there was enough horsepower then you wouldn't mind it
2202019-02-04T15:39:45  *** bitcoin-git has joined #bitcoin-core-dev
2212019-02-04T15:39:45  <bitcoin-git> [bitcoin] promag opened pull request #15341: rpc: Support specifying change address in bumpfee (master...019-01-bumpfee-changeaddress) https://github.com/bitcoin/bitcoin/pull/15341
2222019-02-04T15:39:50  *** bitcoin-git has left #bitcoin-core-dev
2232019-02-04T15:40:21  <luke-jr> kinda crazy to think how far CPUs have come, and still there is a question of horsepower for some things
2242019-02-04T15:41:53  <wumpus> c++ is crazy expensive to compile
2252019-02-04T15:42:54  <wumpus> both in memory as cpu
2262019-02-04T15:43:53  *** phwalkr has quit IRC
2272019-02-04T15:44:28  *** phwalkr has joined #bitcoin-core-dev
2282019-02-04T15:45:06  *** znd has quit IRC
2292019-02-04T15:45:12  <wumpus> I don't know why that's the case, but pretty much every language does better in that regard
2302019-02-04T15:45:50  <promag> what is the motivation of #15340? is this something found elsewhere?
2312019-02-04T15:45:51  <gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub
2322019-02-04T15:46:19  *** phwalkr has quit IRC
2332019-02-04T15:46:24  <wumpus> it was discussed on IRC at some point as a way to make googling errors easier
2342019-02-04T15:46:37  <hebasto> promag: ^
2352019-02-04T15:46:43  <wumpus> but this is quite an ugly change :/ and it doesn't even really work like this
2362019-02-04T15:47:05  <hebasto> wumpus: yep (
2372019-02-04T15:47:26  <sipa> wumpus: templates.. they essentially require recompiling for every instantiation
2382019-02-04T15:47:50  <wumpus> sipa: it's true but many other languages have parametrized types too
2392019-02-04T15:48:24  <luke-jr> wumpus: we had C++ in 2005
2402019-02-04T15:48:44  <luke-jr> maybe not C++11, but surely the feature additions aren't *that* big a difference
2412019-02-04T15:49:01  <sipa> wumpus: perhaps the pervasive use of templates in the standard library
2422019-02-04T15:49:27  <sipa> how many languages have a sort function instantiated for every call
2432019-02-04T15:49:33  <promag> another coffee break merge #15297
2442019-02-04T15:49:34  <gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
2452019-02-04T15:50:19  <wumpus> luke-jr: maybe the source code compiled was smaller, on average, at the time :)
2462019-02-04T15:50:33  <promag> wumpus: do you want me to review any specific pr?
2472019-02-04T15:50:35  <wumpus> compilers certainly have improved since then
2482019-02-04T15:50:50  <promag> 0.18 or hp?
2492019-02-04T15:51:01  <wumpus> promag: that's really up to you
2502019-02-04T15:51:23  <wumpus> but it's a good point that so close to a release, having two lists to prioritize review isn't great
2512019-02-04T15:51:55  <wumpus> normally I'd say "high priority for review" takes precedence as it's blocking people
2522019-02-04T15:53:22  <wumpus> most things tagged 0.18 will be untagged anyway when it's time for the release and they haven't made it
2532019-02-04T15:53:43  <wumpus> promag: thanks!
2542019-02-04T15:54:27  <promag> no problem
2552019-02-04T15:55:11  <wumpus> luke-jr: of course our functional test suite takes significant time too, blaming the compiler only isn't fair :)
2562019-02-04T15:55:47  <wumpus> promag: that one has no (ut)ACKs at all
2572019-02-04T15:55:59  <promag> wumpus: I know :(
2582019-02-04T15:56:28  <promag> maybe next week coffee
2592019-02-04T15:57:24  <luke-jr> XD
2602019-02-04T15:57:30  <wumpus> hehe
2612019-02-04T15:57:53  <luke-jr> wumpus: I suppose in 2005, we didn't have CI
2622019-02-04T15:58:23  <luke-jr> but anyway, that wasn't really my point. :x
2632019-02-04T16:08:46  *** bitcoin-git has joined #bitcoin-core-dev
2642019-02-04T16:08:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ebc6542d982c...6a5feb7d821f
2652019-02-04T16:08:47  <bitcoin-git> bitcoin/master bef8fdd ken2812221: msvc: Fix silent merge conflict between #13926 and #14372
2662019-02-04T16:08:47  <bitcoin-git> bitcoin/master 6a5feb7 MarcoFalke: Merge #15325: msvc: Fix silent merge conflict between #13926 and #14372
2672019-02-04T16:08:55  *** bitcoin-git has left #bitcoin-core-dev
2682019-02-04T16:09:26  *** bitcoin-git has joined #bitcoin-core-dev
2692019-02-04T16:09:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15325: msvc: Fix silent merge conflict between #13926 and #14372 (master...msvc-merge-conflict) https://github.com/bitcoin/bitcoin/pull/15325
2702019-02-04T16:09:31  *** bitcoin-git has left #bitcoin-core-dev
2712019-02-04T16:15:34  *** EagleTM has joined #bitcoin-core-dev
2722019-02-04T16:16:56  *** bitcoin-git has joined #bitcoin-core-dev
2732019-02-04T16:16:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a5feb7d821f...70d06eb857ce
2742019-02-04T16:16:57  <bitcoin-git> bitcoin/master fa6b7b9 MarcoFalke: travis: Revert "Run extended tests once daily"
2752019-02-04T16:16:58  <bitcoin-git> bitcoin/master 70d06eb MarcoFalke: Merge #15328: travis: Revert "Run extended tests once daily"
2762019-02-04T16:17:00  *** bitcoin-git has left #bitcoin-core-dev
2772019-02-04T16:17:38  *** bitcoin-git has joined #bitcoin-core-dev
2782019-02-04T16:17:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15328: travis: Revert "Run extended tests once daily" (master...Mf1902-travisExt) https://github.com/bitcoin/bitcoin/pull/15328
2792019-02-04T16:17:41  *** bitcoin-git has left #bitcoin-core-dev
2802019-02-04T16:18:43  *** jarthur_ has joined #bitcoin-core-dev
2812019-02-04T16:20:01  *** jarthur_ has quit IRC
2822019-02-04T16:21:58  *** jarthur has quit IRC
2832019-02-04T16:23:44  *** bitcoin-git has joined #bitcoin-core-dev
2842019-02-04T16:23:44  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70d06eb857ce...cf8aa5c76ad8
2852019-02-04T16:23:46  <bitcoin-git> bitcoin/master df8a7d3 Wladimir J. van der Laan: qt: Pre-0.18 split-off translations update
2862019-02-04T16:23:46  <bitcoin-git> bitcoin/master cf8aa5c Wladimir J. van der Laan: Merge #15339: qt: Pre-0.18 split-off translations update
2872019-02-04T16:23:57  *** bitcoin-git has left #bitcoin-core-dev
2882019-02-04T16:24:30  *** bitcoin-git has joined #bitcoin-core-dev
2892019-02-04T16:24:31  <bitcoin-git> [bitcoin] laanwj merged pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339
2902019-02-04T16:24:35  *** bitcoin-git has left #bitcoin-core-dev
2912019-02-04T16:25:56  *** EagleTM has quit IRC
2922019-02-04T16:28:23  *** promag has quit IRC
2932019-02-04T16:33:21  *** pinheadmz has joined #bitcoin-core-dev
2942019-02-04T16:35:43  *** spinza has quit IRC
2952019-02-04T16:41:27  *** spinza has joined #bitcoin-core-dev
2962019-02-04T16:49:16  *** bitcoin-git has joined #bitcoin-core-dev
2972019-02-04T16:49:16  <bitcoin-git> [bitcoin] dongcarl opened pull request #15343: netaddress: Make IPv4 loopback comment more descriptive (master...019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343
2982019-02-04T16:49:24  *** bitcoin-git has left #bitcoin-core-dev
2992019-02-04T16:59:38  *** bitcoin-git has joined #bitcoin-core-dev
3002019-02-04T16:59:39  <bitcoin-git> [bitcoin] hebasto closed pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
3012019-02-04T16:59:47  *** bitcoin-git has left #bitcoin-core-dev
3022019-02-04T17:03:02  *** rh0nj has quit IRC
3032019-02-04T17:03:06  *** jungly has quit IRC
3042019-02-04T17:03:33  *** bitcoin-git has joined #bitcoin-core-dev
3052019-02-04T17:03:34  <bitcoin-git> [bitcoin] Empact opened pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344
3062019-02-04T17:03:41  *** bitcoin-git has left #bitcoin-core-dev
3072019-02-04T17:04:08  *** rh0nj has joined #bitcoin-core-dev
3082019-02-04T17:14:49  *** mistergold has quit IRC
3092019-02-04T17:16:27  *** Murch has joined #bitcoin-core-dev
3102019-02-04T17:26:09  *** pinheadmz has quit IRC
3112019-02-04T17:28:34  *** pinheadmz has joined #bitcoin-core-dev
3122019-02-04T17:41:43  <dongcarl> Hey all, anyone got a good understanding of `mapLocalHost`?
3132019-02-04T17:42:05  <dongcarl> What does "local address for a particular peer" mean?
3142019-02-04T17:42:20  * dongcarl looking at `GetLocal`
3152019-02-04T17:43:22  <sipa> dongcarl: for a IPv4 peer your own address will likely be an IPv4 one
3162019-02-04T17:43:29  <sipa> i think
3172019-02-04T17:44:34  <sipa> this code has evolved a bit since i last worked on it
3182019-02-04T17:44:58  <dongcarl> sipa: So... `GetLocal` tries to find the best "local" address to give to a peer?
3192019-02-04T17:45:23  <dongcarl> Why would it matter to peers? I feel like I'm misunderstanding...
3202019-02-04T17:49:27  *** ThomasLuong has joined #bitcoin-core-dev
3212019-02-04T17:55:14  *** EagleTM has joined #bitcoin-core-dev
3222019-02-04T18:00:02  <wumpus> it's used to determine what address to gossip IIRC
3232019-02-04T18:05:03  *** Orion3k has joined #bitcoin-core-dev
3242019-02-04T18:10:25  <dongcarl> Got the answer in `CNetAddr::GetReachabilityFrom`
3252019-02-04T18:11:17  <wumpus> okay!
3262019-02-04T18:15:16  *** bitcoin-git has joined #bitcoin-core-dev
3272019-02-04T18:15:16  <bitcoin-git> [bitcoin] dongcarl opened pull request #15345: net: Correct comparison of addr count (master...019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345
3282019-02-04T18:15:23  *** bitcoin-git has left #bitcoin-core-dev
3292019-02-04T18:17:48  *** ExtraCrispy has joined #bitcoin-core-dev
3302019-02-04T18:27:52  <dongcarl> wumpus: In situations like #15343, would it be okay for me to just fix the indentation for the function?
3312019-02-04T18:27:53  <gribble> https://github.com/bitcoin/bitcoin/issues/15343 | netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub
3322019-02-04T18:28:26  *** EagleTM has quit IRC
3332019-02-04T18:31:45  *** nullptr| has quit IRC
3342019-02-04T18:34:34  *** pinheadmz has quit IRC
3352019-02-04T18:35:53  <gkrizek> wumpus: I just pushed a fix for the leading digit problem on branch names. I updated the ghi instance on your server as well
3362019-02-04T18:37:41  *** nullptr| has joined #bitcoin-core-dev
3372019-02-04T18:41:11  <wumpus> dongcarl: how much of the indentation is broken? is it the case for other functions as well?
3382019-02-04T18:41:42  <wumpus> but sure, you certainly don't need to fix all the indentation, just don't introduce any new wrong one
3392019-02-04T18:42:03  <wumpus> gkrizek: oh great! thank you
3402019-02-04T18:42:11  *** pinheadmz has joined #bitcoin-core-dev
3412019-02-04T18:42:11  *** promag has joined #bitcoin-core-dev
3422019-02-04T18:44:28  *** bitcoin-git has joined #bitcoin-core-dev
3432019-02-04T18:44:28  <bitcoin-git> [bitcoin] laanwj closed pull request #15274: remove redundant 'solved' from ProduceSignature (master...sign_redundant_solved) https://github.com/bitcoin/bitcoin/pull/15274
3442019-02-04T18:44:39  *** bitcoin-git has left #bitcoin-core-dev
3452019-02-04T18:50:10  *** Zenton has quit IRC
3462019-02-04T18:51:56  *** bitcoin-git has joined #bitcoin-core-dev
3472019-02-04T18:51:57  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cf8aa5c76ad8...76deb30550b2
3482019-02-04T18:51:57  <bitcoin-git> bitcoin/master b0c7b54 Carl Dong: init: Use systemd automatic directory creation
3492019-02-04T18:51:59  <bitcoin-git> bitcoin/master bad1716 Carl Dong: init: Modify docs and add release note for 12255
3502019-02-04T18:51:59  <bitcoin-git> bitcoin/master 76deb30 Wladimir J. van der Laan: Merge #12255: Update bitcoin.service to conform to init.md
3512019-02-04T18:52:08  *** bitcoin-git has left #bitcoin-core-dev
3522019-02-04T18:52:24  *** bitcoin-git has joined #bitcoin-core-dev
3532019-02-04T18:52:25  <bitcoin-git> [bitcoin] laanwj merged pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255
3542019-02-04T18:52:31  *** bitcoin-git has left #bitcoin-core-dev
3552019-02-04T18:53:30  *** jarthur has joined #bitcoin-core-dev
3562019-02-04T19:02:19  *** Murch has quit IRC
3572019-02-04T19:02:47  *** Murch has joined #bitcoin-core-dev
3582019-02-04T19:04:13  *** timothy has quit IRC
3592019-02-04T19:06:08  *** bitcoin-git has joined #bitcoin-core-dev
3602019-02-04T19:06:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76deb30550b2...bfbe42585e9b
3612019-02-04T19:06:10  <bitcoin-git> bitcoin/master 107623c Carl Dong: net: Correct comparison of addr count
3622019-02-04T19:06:10  <bitcoin-git> bitcoin/master bfbe425 Wladimir J. van der Laan: Merge #15345: net: Correct comparison of addr count
3632019-02-04T19:06:16  *** bitcoin-git has left #bitcoin-core-dev
3642019-02-04T19:06:45  *** bitcoin-git has joined #bitcoin-core-dev
3652019-02-04T19:06:45  <bitcoin-git> [bitcoin] laanwj merged pull request #15345: net: Correct comparison of addr count (master...2019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345
3662019-02-04T19:06:47  *** bitcoin-git has left #bitcoin-core-dev
3672019-02-04T19:12:17  <dongcarl> Can anyone tell me what the deprecated variable naming convention is? I see that `v*` is vector... `f*` seems to be booleans? There's also a `vf` in net.cpp, which is an array of booleans?
3682019-02-04T19:13:39  <sipa> dongcarl: v=vector, map=map, str=string, sz=c-style-string, f=flag
3692019-02-04T19:13:54  <sipa> vf=vector of flags
3702019-02-04T19:14:02  <dongcarl> sipa: Thank you!
3712019-02-04T19:15:44  *** thedevworks has quit IRC
3722019-02-04T19:17:00  *** thedevworks has joined #bitcoin-core-dev
3732019-02-04T19:17:49  <wumpus> don't use it in new code though
3742019-02-04T19:18:31  <dongcarl> wumpus: Haha yeah ofc
3752019-02-04T19:18:45  <dongcarl> I'm just reading thru net.cpp adding comments
3762019-02-04T19:19:18  <sipa> there are many variables whose type changed without the name changing accordingly
3772019-02-04T19:19:35  <sipa> there's probably some fun archaeology to do with that
3782019-02-04T19:19:53  <dongcarl> "fun"
3792019-02-04T19:19:58  *** Krellan has quit IRC
3802019-02-04T19:22:46  <wumpus> dongcarl: btw if you intend to submit more comment changes to net code, that'd be very helpful, but it's probably better to group them into one PR instead of opening separate ones like #15343
3812019-02-04T19:22:47  <gribble> https://github.com/bitcoin/bitcoin/issues/15343 | [doc] netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub
3822019-02-04T19:23:01  *** phwalkr has joined #bitcoin-core-dev
3832019-02-04T19:23:38  <dongcarl> wumpus: Okay will do, I guess I'll just separate them into different commits so that we can drop/modify them easily during review
3842019-02-04T19:24:40  <wumpus> yea multiple commits is fine!
3852019-02-04T19:27:20  *** rex4539 has joined #bitcoin-core-dev
3862019-02-04T19:27:26  *** phwalkr has quit IRC
3872019-02-04T19:29:00  *** jarthur_ has joined #bitcoin-core-dev
3882019-02-04T19:29:04  *** bitcoin-git has joined #bitcoin-core-dev
3892019-02-04T19:29:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bfbe42585e9b...452acee4da20
3902019-02-04T19:29:05  <bitcoin-git> bitcoin/master 77777c5 MarcoFalke: log: Construct global logger on first use
3912019-02-04T19:29:06  <bitcoin-git> bitcoin/master 452acee MarcoFalke: Merge #15266: memory: Construct globals on first use
3922019-02-04T19:29:13  *** bitcoin-git has left #bitcoin-core-dev
3932019-02-04T19:29:43  *** bitcoin-git has joined #bitcoin-core-dev
3942019-02-04T19:29:43  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15266: memory: Construct globals on first use (master...Mf1901-cofu) https://github.com/bitcoin/bitcoin/pull/15266
3952019-02-04T19:29:48  *** bitcoin-git has left #bitcoin-core-dev
3962019-02-04T19:32:40  *** Murch has quit IRC
3972019-02-04T19:32:57  <dongcarl> Does anyone know what the "p" in "paddrPeer" in net.cpp might be referring to?
3982019-02-04T19:33:16  *** jarthur has quit IRC
3992019-02-04T19:33:35  <sipa> pointer
4002019-02-04T19:33:50  *** Murch has joined #bitcoin-core-dev
4012019-02-04T19:35:14  <promag> classic XD
4022019-02-04T19:35:33  <sipa> promag: that's hungarian style :)
4032019-02-04T19:35:36  * dongcarl facepalms
4042019-02-04T19:36:22  <dongcarl> Oh wow that's an actual thing
4052019-02-04T19:36:23  <dongcarl> TIL
4062019-02-04T19:37:25  <hebasto> jonasschnelli: thank you for your opinion about #15340 but this pr breaks translation process, unfortunately.
4072019-02-04T19:37:27  <gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub
4082019-02-04T19:37:39  <promag> dongcarl: apologies for that, you were much happier before
4092019-02-04T19:38:20  <sipa> dongcarl: so psz is pointer-to-zero-terminated-string
4102019-02-04T19:38:30  <sipa> which used to occur frequently
4112019-02-04T19:40:12  <dongcarl> sipa: My mom warned me about nasty C-style zero-terminated strings! They hang out in all the bad stacks!
4122019-02-04T19:42:44  *** mn949588 has quit IRC
4132019-02-04T19:43:04  *** mn949588 has joined #bitcoin-core-dev
4142019-02-04T19:44:14  *** ap4lmtree has quit IRC
4152019-02-04T19:53:15  *** lnostdal has quit IRC
4162019-02-04T19:57:05  *** jarthur_ has quit IRC
4172019-02-04T19:59:08  *** ap4lmtree has joined #bitcoin-core-dev
4182019-02-04T19:59:34  *** promag has quit IRC
4192019-02-04T19:59:47  <wumpus> hebasto: *conceptually* it's a good idea, it's just virtually impossible to implement correctly with gettext
4202019-02-04T20:01:41  *** mn9495881 has joined #bitcoin-core-dev
4212019-02-04T20:01:58  <hebasto> wumpus: thanks
4222019-02-04T20:04:42  *** mn949588 has quit IRC
4232019-02-04T20:08:48  <wumpus> we've run into a similar issue in the past for the status bar, where we wanted to return the untranslated error on the RPC and the translated one on the GUI
4242019-02-04T20:08:58  <wumpus> ended up duplicating the text ...
4252019-02-04T20:09:21  <wumpus> would certainly *not* be nice to do for all errors
4262019-02-04T20:10:15  <wumpus> dongcarl: your mother is very wise
4272019-02-04T20:29:26  *** thedevworks has quit IRC
4282019-02-04T20:31:13  *** thedevworks has joined #bitcoin-core-dev
4292019-02-04T20:34:56  *** ap4lmtree has quit IRC
4302019-02-04T20:44:07  *** DeanGuss has quit IRC
4312019-02-04T20:45:30  *** lnostdal has joined #bitcoin-core-dev
4322019-02-04T20:55:54  *** phwalkr has joined #bitcoin-core-dev
4332019-02-04T20:57:13  *** shesek has joined #bitcoin-core-dev
4342019-02-04T21:00:09  *** phwalkr has quit IRC
4352019-02-04T21:07:05  *** darosior has joined #bitcoin-core-dev
4362019-02-04T21:16:11  *** ap4lmtree has joined #bitcoin-core-dev
4372019-02-04T21:24:20  *** jarthur has joined #bitcoin-core-dev
4382019-02-04T21:32:14  *** thedevworks has quit IRC
4392019-02-04T21:36:45  *** pinheadmz has quit IRC
4402019-02-04T21:42:21  *** phwalkr has joined #bitcoin-core-dev
4412019-02-04T21:44:44  *** macbroadcast has joined #bitcoin-core-dev
4422019-02-04T21:47:05  *** macbroadcast has quit IRC
4432019-02-04T21:47:20  *** macbroadcast_ has joined #bitcoin-core-dev
4442019-02-04T21:48:48  *** macbroadcast_ has quit IRC
4452019-02-04T21:54:35  *** bitcoin-git has joined #bitcoin-core-dev
4462019-02-04T21:54:35  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14169: add -debuglogsize=<n> option (master...master) https://github.com/bitcoin/bitcoin/pull/14169
4472019-02-04T21:54:38  *** bitcoin-git has left #bitcoin-core-dev
4482019-02-04T22:00:56  *** pinheadmz has joined #bitcoin-core-dev
4492019-02-04T22:06:33  *** Zenton has joined #bitcoin-core-dev
4502019-02-04T22:10:03  *** bitcoin-git has joined #bitcoin-core-dev
4512019-02-04T22:10:03  <bitcoin-git> [bitcoin] darosior opened pull request #15346: cli: encryptwallet password entered from stdin. fixes #15318 (master...cli_encryptwallet_stdin) https://github.com/bitcoin/bitcoin/pull/15346
4522019-02-04T22:10:07  *** bitcoin-git has left #bitcoin-core-dev
4532019-02-04T22:10:35  *** phwalkr has quit IRC
4542019-02-04T22:10:43  *** Guyver2 has quit IRC
4552019-02-04T22:13:41  *** spinza has quit IRC
4562019-02-04T22:14:36  *** DeanGuss has joined #bitcoin-core-dev
4572019-02-04T22:19:32  *** spinza has joined #bitcoin-core-dev
4582019-02-04T22:19:47  *** rex4539 has quit IRC
4592019-02-04T22:26:11  *** darosior has quit IRC
4602019-02-04T22:37:02  *** Orion3k has quit IRC
4612019-02-04T22:45:09  *** Krellan has joined #bitcoin-core-dev
4622019-02-04T22:52:36  *** bitcoin-git has joined #bitcoin-core-dev
4632019-02-04T22:52:37  <bitcoin-git> [bitcoin] hebasto reopened pull request #15340: gui: Introduce bilingual GUI error messages (master...20190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
4642019-02-04T22:52:43  *** bitcoin-git has left #bitcoin-core-dev
4652019-02-04T22:52:57  *** tryphe_ is now known as tryphe
4662019-02-04T22:55:35  *** arubi has quit IRC
4672019-02-04T22:59:23  *** Murch has quit IRC
4682019-02-04T23:03:11  *** tyttor has joined #bitcoin-core-dev
4692019-02-04T23:04:28  *** tyttor has left #bitcoin-core-dev
4702019-02-04T23:11:15  *** thedevworks has joined #bitcoin-core-dev
4712019-02-04T23:12:55  *** thedevworks has quit IRC
4722019-02-04T23:17:03  *** promag has joined #bitcoin-core-dev
4732019-02-04T23:22:13  *** DeanGuss has quit IRC
4742019-02-04T23:38:27  *** bitcoin-git has joined #bitcoin-core-dev
4752019-02-04T23:38:28  <bitcoin-git> [bitcoin] hebasto opened pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347
4762019-02-04T23:38:33  *** bitcoin-git has left #bitcoin-core-dev
4772019-02-04T23:38:46  *** michaelsdunn1 has quit IRC
4782019-02-04T23:54:40  *** pinheadmz has quit IRC
4792019-02-04T23:54:54  *** ThomasLuong has quit IRC