1 2019-02-04T00:01:40  *** miknotauro has quit IRC
  2 2019-02-04T00:06:34  *** Victor_sueca has joined #bitcoin-core-dev
  3 2019-02-04T00:07:56  *** Victorsueca has quit IRC
  4 2019-02-04T00:19:09  *** justanotheruser has quit IRC
  5 2019-02-04T00:30:53  *** spinza has quit IRC
  6 2019-02-04T00:34:56  *** justanotheruser has joined #bitcoin-core-dev
  7 2019-02-04T01:01:17  *** Jbaczuk has quit IRC
  8 2019-02-04T01:11:01  *** rh0nj has quit IRC
  9 2019-02-04T01:12:07  *** rh0nj has joined #bitcoin-core-dev
 10 2019-02-04T01:25:11  *** justanotheruser has quit IRC
 11 2019-02-04T01:44:54  *** justanotheruser has joined #bitcoin-core-dev
 12 2019-02-04T02:04:49  *** spinza has joined #bitcoin-core-dev
 13 2019-02-04T02:12:34  *** pinheadmz has quit IRC
 14 2019-02-04T02:25:00  *** profmac has quit IRC
 15 2019-02-04T02:34:51  *** AaronvanW has quit IRC
 16 2019-02-04T02:37:58  *** pinheadmz has joined #bitcoin-core-dev
 17 2019-02-04T02:42:24  *** pinheadmz has quit IRC
 18 2019-02-04T02:58:52  *** pinheadmz has joined #bitcoin-core-dev
 19 2019-02-04T03:17:27  *** pinheadmz has quit IRC
 20 2019-02-04T03:21:58  *** mistergold has joined #bitcoin-core-dev
 21 2019-02-04T03:23:11  *** phwalkr has joined #bitcoin-core-dev
 22 2019-02-04T03:28:28  *** mistergold has quit IRC
 23 2019-02-04T03:30:27  *** owowo has quit IRC
 24 2019-02-04T03:34:47  *** owowo has joined #bitcoin-core-dev
 25 2019-02-04T03:50:43  *** murrayn has joined #bitcoin-core-dev
 26 2019-02-04T03:52:59  *** rex4539 has quit IRC
 27 2019-02-04T03:58:04  *** jarthur has quit IRC
 28 2019-02-04T03:58:39  *** jarthur has joined #bitcoin-core-dev
 29 2019-02-04T04:08:25  *** Skirmant has quit IRC
 30 2019-02-04T04:10:08  *** DeanGuss has joined #bitcoin-core-dev
 31 2019-02-04T04:32:16  *** murrayn has quit IRC
 32 2019-02-04T04:32:43  *** murrayn has joined #bitcoin-core-dev
 33 2019-02-04T04:33:56  *** jarthur has quit IRC
 34 2019-02-04T04:35:38  *** ap4lmtree- has joined #bitcoin-core-dev
 35 2019-02-04T04:36:46  *** murrayn has quit IRC
 36 2019-02-04T04:37:10  *** murrayn has joined #bitcoin-core-dev
 37 2019-02-04T04:39:31  *** ap4lmtree has quit IRC
 38 2019-02-04T04:40:04  *** jarthur has joined #bitcoin-core-dev
 39 2019-02-04T04:59:28  *** ap4lmtree- is now known as ap4lmtree
 40 2019-02-04T05:09:44  *** jtimon has quit IRC
 41 2019-02-04T05:23:50  *** jarthur has quit IRC
 42 2019-02-04T05:35:27  *** hebasto has joined #bitcoin-core-dev
 43 2019-02-04T06:11:58  *** bitcoin-git has joined #bitcoin-core-dev
 44 2019-02-04T06:11:59  <bitcoin-git> [bitcoin] AkioNak opened pull request #15335: Fix lack of warning of unrecognized section names (master...conf_include_multi) https://github.com/bitcoin/bitcoin/pull/15335
 45 2019-02-04T06:12:05  *** bitcoin-git has left #bitcoin-core-dev
 46 2019-02-04T06:20:24  *** profmac has joined #bitcoin-core-dev
 47 2019-02-04T06:35:54  *** mistergold has joined #bitcoin-core-dev
 48 2019-02-04T06:54:56  *** mistergold has quit IRC
 49 2019-02-04T07:06:58  *** pinheadmz has joined #bitcoin-core-dev
 50 2019-02-04T07:11:37  *** mistergold has joined #bitcoin-core-dev
 51 2019-02-04T07:13:47  *** DeanGuss has quit IRC
 52 2019-02-04T07:37:56  *** mistergold has quit IRC
 53 2019-02-04T07:51:33  *** pinheadmz has quit IRC
 54 2019-02-04T08:14:32  *** mistergold has joined #bitcoin-core-dev
 55 2019-02-04T08:23:07  *** DeanGuss has joined #bitcoin-core-dev
 56 2019-02-04T08:24:03  *** bitcoin-git has joined #bitcoin-core-dev
 57 2019-02-04T08:24:03  <bitcoin-git> [bitcoin] bvbfan opened pull request #15336: Enable moving of hashes, uints, outpoints (master...master) https://github.com/bitcoin/bitcoin/pull/15336
 58 2019-02-04T08:24:16  *** bitcoin-git has left #bitcoin-core-dev
 59 2019-02-04T08:49:46  *** tryphe_ has joined #bitcoin-core-dev
 60 2019-02-04T08:51:18  *** tryphe has quit IRC
 61 2019-02-04T08:58:25  *** darosior has joined #bitcoin-core-dev
 62 2019-02-04T09:07:23  *** setpill has joined #bitcoin-core-dev
 63 2019-02-04T09:25:20  *** rafalcpp has quit IRC
 64 2019-02-04T09:25:25  *** queip has quit IRC
 65 2019-02-04T09:31:03  *** rafalcpp has joined #bitcoin-core-dev
 66 2019-02-04T09:34:58  *** Zenton has joined #bitcoin-core-dev
 67 2019-02-04T09:36:31  *** queip has joined #bitcoin-core-dev
 68 2019-02-04T09:42:04  *** timothy has joined #bitcoin-core-dev
 69 2019-02-04T09:51:59  *** fanquake has joined #bitcoin-core-dev
 70 2019-02-04T10:07:56  *** lnostdal has quit IRC
 71 2019-02-04T10:10:27  *** bitcoin-git has joined #bitcoin-core-dev
 72 2019-02-04T10:10:29  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2fbf6a57d282...64127b3098a1
 73 2019-02-04T10:10:30  <bitcoin-git> bitcoin/master 60e190c João Barbosa: gui: Fix WalletController deletion
 74 2019-02-04T10:10:30  <bitcoin-git> bitcoin/master 07b9aad João Barbosa: gui: Expose BitcoinGUI::unsubscribeFromCoreSignals
 75 2019-02-04T10:10:31  <bitcoin-git> bitcoin/master fd6d499 João Barbosa: gui: Fix m_node.startShutdown() order
 76 2019-02-04T10:10:33  *** bitcoin-git has left #bitcoin-core-dev
 77 2019-02-04T10:10:54  *** lnostdal has joined #bitcoin-core-dev
 78 2019-02-04T10:11:13  *** bitcoin-git has joined #bitcoin-core-dev
 79 2019-02-04T10:11:13  <bitcoin-git> [bitcoin] laanwj merged pull request #15280: gui: Fix shutdown order (master...019-01-gui-shutdown) https://github.com/bitcoin/bitcoin/pull/15280
 80 2019-02-04T10:11:15  *** bitcoin-git has left #bitcoin-core-dev
 81 2019-02-04T10:13:16  *** spinza has quit IRC
 82 2019-02-04T10:25:13  *** Soligor has quit IRC
 83 2019-02-04T10:25:42  *** spinza has joined #bitcoin-core-dev
 84 2019-02-04T10:28:26  *** ExtraCrispy has quit IRC
 85 2019-02-04T10:40:51  *** Soligor has joined #bitcoin-core-dev
 86 2019-02-04T10:47:06  *** Skirmant has joined #bitcoin-core-dev
 87 2019-02-04T11:15:59  *** promag has joined #bitcoin-core-dev
 88 2019-02-04T11:23:02  *** Guyver2 has joined #bitcoin-core-dev
 89 2019-02-04T11:27:33  *** bitcoin-git has joined #bitcoin-core-dev
 90 2019-02-04T11:27:33  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64127b3098a1...424327e1a8f5
 91 2019-02-04T11:27:33  <bitcoin-git> bitcoin/master fae169c MarcoFalke: test: Make bloom tests deterministic
 92 2019-02-04T11:27:34  <bitcoin-git> bitcoin/master 424327e Wladimir J. van der Laan: Merge #15324: test: Make bloom tests deterministic
 93 2019-02-04T11:27:35  *** bitcoin-git has left #bitcoin-core-dev
 94 2019-02-04T11:28:08  *** bitcoin-git has joined #bitcoin-core-dev
 95 2019-02-04T11:28:08  <bitcoin-git> [bitcoin] laanwj merged pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
 96 2019-02-04T11:28:09  *** bitcoin-git has left #bitcoin-core-dev
 97 2019-02-04T11:33:00  *** znd has joined #bitcoin-core-dev
 98 2019-02-04T11:33:59  <wumpus> #15140 confuses me a bit
 99 2019-02-04T11:34:01  <gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub
100 2019-02-04T11:34:09  <wumpus> does it fix an actual problem?
101 2019-02-04T11:36:47  *** darosior has quit IRC
102 2019-02-04T11:42:56  <luke-jr> wumpus: I guess the test wasn't testing what it was supposed to? not sure
103 2019-02-04T11:43:37  *** AaronvanW has joined #bitcoin-core-dev
104 2019-02-04T11:43:46  <wumpus> yea that's what it purports to do, the change itself is kind of strange though
105 2019-02-04T11:47:17  <wumpus> it seems that a more minimal fix could solve it
106 2019-02-04T11:47:25  <wumpus> but I might be wrong
107 2019-02-04T11:47:40  *** Skirmant has quit IRC
108 2019-02-04T11:49:27  *** jungly has joined #bitcoin-core-dev
109 2019-02-04T11:55:33  *** marcoagner has joined #bitcoin-core-dev
110 2019-02-04T11:57:48  <promag> coffee break merge #15322
111 2019-02-04T11:57:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
112 2019-02-04T12:03:06  *** bitcoin-git has joined #bitcoin-core-dev
113 2019-02-04T12:03:07  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/424327e1a8f5...ebc6542d982c
114 2019-02-04T12:03:07  <bitcoin-git> bitcoin/master 712d35b João Barbosa: wallet: Add missing cs_db lock
115 2019-02-04T12:03:08  <bitcoin-git> bitcoin/master ebc6542 Wladimir J. van der Laan: Merge #15322: wallet: Add missing cs_db lock
116 2019-02-04T12:03:12  *** bitcoin-git has left #bitcoin-core-dev
117 2019-02-04T12:03:50  *** bitcoin-git has joined #bitcoin-core-dev
118 2019-02-04T12:03:50  <bitcoin-git> [bitcoin] laanwj merged pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
119 2019-02-04T12:03:54  <promag> that was fast
120 2019-02-04T12:03:56  *** bitcoin-git has left #bitcoin-core-dev
121 2019-02-04T12:04:10  <wumpus> promag: yep already intended to merge that one
122 2019-02-04T12:04:20  <promag> ok ty
123 2019-02-04T12:04:31  <wumpus> but you reminded me
124 2019-02-04T12:05:06  <promag> I'm now with #15153
125 2019-02-04T12:05:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
126 2019-02-04T12:09:57  <fanquake> promag restarted all the tests in 15153
127 2019-02-04T12:10:03  <fanquake> planning on testing that again
128 2019-02-04T12:10:30  <promag> fanquake: I'll push shortly
129 2019-02-04T12:10:57  <promag> I think it's good enough for 1st GUI support
130 2019-02-04T12:12:04  <promag> in order to support "cancel open because it's rescanning" we have to do some refactors
131 2019-02-04T12:12:04  <fanquake> promag, yes I think so. There are still edge cases/improvements that can be fixed/made later
132 2019-02-04T12:12:27  <fanquake> i.e closing a modal after opening a wallet, then opening the same wallet again
133 2019-02-04T12:13:18  <fanquake> You end up with the first completing, then the second opening failing because the same wallet is loaded already.
134 2019-02-04T12:13:30  *** mistergo1d has joined #bitcoin-core-dev
135 2019-02-04T12:13:39  <promag> fanquake: I think I can fix that, by disabling the close
136 2019-02-04T12:13:47  *** mistergold has quit IRC
137 2019-02-04T12:13:55  <promag> fanquake: right
138 2019-02-04T12:15:06  <fanquake> Disabling the close button could work, although that's probably not ideal if you are stuck with a long time to rescan wallet, and want to bail out.
139 2019-02-04T12:15:27  <promag> fanquake: ryanofsky: I think Node::loadWallet should return the Wallet immediately, and the the GUI could add handlers and interact with the wallet asynchronously
140 2019-02-04T12:16:23  <promag> fanquake: ah I see, then I it should not be modal, and if the same wallet is opened then it fails
141 2019-02-04T12:28:33  <wumpus> hhmm translation process for adding new translations needs to be updated for the MSVC build system
142 2019-02-04T12:28:55  <wumpus> translations are listed in three places now :(
143 2019-02-04T12:32:03  <wumpus> (working on this)
144 2019-02-04T12:34:42  *** EagleTM has joined #bitcoin-core-dev
145 2019-02-04T12:44:13  *** rabidus has quit IRC
146 2019-02-04T12:44:13  *** jtimon has joined #bitcoin-core-dev
147 2019-02-04T12:45:53  *** rabidus has joined #bitcoin-core-dev
148 2019-02-04T12:48:04  *** EagleTM has quit IRC
149 2019-02-04T13:00:54  *** shesek has quit IRC
150 2019-02-04T13:01:59  *** mistergo1d has quit IRC
151 2019-02-04T13:04:26  *** mistergold has joined #bitcoin-core-dev
152 2019-02-04T13:06:00  *** Skirmant has joined #bitcoin-core-dev
153 2019-02-04T13:09:34  *** Skirmant has quit IRC
154 2019-02-04T13:15:26  *** phwalkr has quit IRC
155 2019-02-04T13:16:04  *** phwalkr has joined #bitcoin-core-dev
156 2019-02-04T13:17:05  *** phwalkr has joined #bitcoin-core-dev
157 2019-02-04T13:17:48  *** darosior has joined #bitcoin-core-dev
158 2019-02-04T13:19:23  *** bitcoin-git has joined #bitcoin-core-dev
159 2019-02-04T13:19:23  <bitcoin-git> [bitcoin] benthecarman opened pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337
160 2019-02-04T13:19:24  *** bitcoin-git has left #bitcoin-core-dev
161 2019-02-04T13:25:27  *** phwalkr has quit IRC
162 2019-02-04T13:41:15  *** promag has quit IRC
163 2019-02-04T13:42:36  *** thedevworks has joined #bitcoin-core-dev
164 2019-02-04T13:48:55  *** bitcoin-git has joined #bitcoin-core-dev
165 2019-02-04T13:48:55  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15338: ci: Build and run tests once on freebsd (master...Mf1902-cirrusci) https://github.com/bitcoin/bitcoin/pull/15338
166 2019-02-04T13:48:56  *** bitcoin-git has left #bitcoin-core-dev
167 2019-02-04T14:10:00  *** promag has joined #bitcoin-core-dev
168 2019-02-04T14:12:36  *** bitcoin-git has joined #bitcoin-core-dev
169 2019-02-04T14:12:36  <bitcoin-git> [bitcoin] laanwj opened pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339
170 2019-02-04T14:12:37  *** bitcoin-git has left #bitcoin-core-dev
171 2019-02-04T14:14:19  *** promag has quit IRC
172 2019-02-04T14:24:56  *** promag has joined #bitcoin-core-dev
173 2019-02-04T14:37:24  *** phwalkr has joined #bitcoin-core-dev
174 2019-02-04T14:41:34  *** fanquake has quit IRC
175 2019-02-04T14:59:46  *** bitcoin-git has joined #bitcoin-core-dev
176 2019-02-04T14:59:46  <bitcoin-git> [bitcoin] hebasto opened pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
177 2019-02-04T14:59:52  *** bitcoin-git has left #bitcoin-core-dev
178 2019-02-04T15:01:59  *** setpill has quit IRC
179 2019-02-04T15:04:11  *** darosior has quit IRC
180 2019-02-04T15:10:42  <dongcarl> Re #13865, wondering if people think this is a good idea. Pro: git bisectability, Con: travis will be even slower
181 2019-02-04T15:10:44  <gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub
182 2019-02-04T15:17:38  <luke-jr> dongcarl: it shouldn't affect build times *too* much, so long as it uses the same build dir between commits
183 2019-02-04T15:18:15  <dongcarl> Okay, I will PR to do `git --exec` then
184 2019-02-04T15:18:23  <dongcarl> or rather `git rebase --exec`
185 2019-02-04T15:18:43  <instagibbs> I don't have a lot of experience in this but how often has this been a problem
186 2019-02-04T15:19:40  <dongcarl> instagibbs: You mean git bisectability?
187 2019-02-04T15:19:55  <luke-jr> that's a good point too
188 2019-02-04T15:20:05  <wumpus> I don't see a strong reason to do this either
189 2019-02-04T15:20:10  <instagibbs> dongcarl, correct, how often has this been an issue
190 2019-02-04T15:20:18  <luke-jr> AFAIK git bisect doesn't go inside merges unless the issue is part of that set of commits
191 2019-02-04T15:20:50  <wumpus> testing the top commit of a PR should be enough, anything else is for certain going to confuse people, how many projects run the CI on every single commit even in merges?
192 2019-02-04T15:21:39  <dongcarl> I guess I was thinking that if we had a long-standing bug we could use bisect to find where it started
193 2019-02-04T15:21:50  <luke-jr> too bad there's no way to set priorities so Travis just runs everything on intermediate commits if it gets idle cycles
194 2019-02-04T15:22:00  <luke-jr> dongcarl: you can do that regardless
195 2019-02-04T15:22:05  <wumpus> bisect is already quite usable
196 2019-02-04T15:22:11  <wumpus> never had problems really
197 2019-02-04T15:22:11  <instagibbs> dongcarl, I believe luke is right in that it can still do it, regardless
198 2019-02-04T15:22:11  <dongcarl> Okay cool
199 2019-02-04T15:22:23  <instagibbs> as long as merge commits are properly passing
200 2019-02-04T15:22:30  <wumpus> right
201 2019-02-04T15:22:53  <dongcarl> luke-jr: wanna close #13865?
202 2019-02-04T15:22:54  <gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub
203 2019-02-04T15:23:11  <instagibbs> You can also mark known-bad commits
204 2019-02-04T15:23:13  <instagibbs> and skip them
205 2019-02-04T15:24:01  * dongcarl of little faith in the Linus, repenting
206 2019-02-04T15:24:07  <luke-jr> dongcarl: I don't have access to close it
207 2019-02-04T15:24:33  <luke-jr> instagibbs: hm, I wonder if there's a way to make a permanent list of skip commits
208 2019-02-04T15:25:08  <instagibbs> someone can grind through commits and build it :P
209 2019-02-04T15:25:29  <instagibbs> then we can make a bisect wrapper script that allows bisection to skip
210 2019-02-04T15:26:31  <luke-jr> no, I just mean, next time I'm bisecting, it'd be nice to be able to do `git bisect skip --remember` or something
211 2019-02-04T15:27:03  <instagibbs> ah, not sure about that one
212 2019-02-04T15:30:52  *** pinheadmz has joined #bitcoin-core-dev
213 2019-02-04T15:33:52  *** jarthur has joined #bitcoin-core-dev
214 2019-02-04T15:34:28  *** pinheadmz has quit IRC
215 2019-02-04T15:36:14  <promag> dongcarl: I like the idea and most branches have few commit. however travis already takes a lot of time..
216 2019-02-04T15:37:44  *** michaelsdunn1 has joined #bitcoin-core-dev
217 2019-02-04T15:37:45  *** michaelsdunn1 has quit IRC
218 2019-02-04T15:37:45  *** michaelsdunn1 has joined #bitcoin-core-dev
219 2019-02-04T15:38:54  <promag> wumpus: if there was enough horsepower then you wouldn't mind it
220 2019-02-04T15:39:45  *** bitcoin-git has joined #bitcoin-core-dev
221 2019-02-04T15:39:45  <bitcoin-git> [bitcoin] promag opened pull request #15341: rpc: Support specifying change address in bumpfee (master...019-01-bumpfee-changeaddress) https://github.com/bitcoin/bitcoin/pull/15341
222 2019-02-04T15:39:50  *** bitcoin-git has left #bitcoin-core-dev
223 2019-02-04T15:40:21  <luke-jr> kinda crazy to think how far CPUs have come, and still there is a question of horsepower for some things
224 2019-02-04T15:41:53  <wumpus> c++ is crazy expensive to compile
225 2019-02-04T15:42:54  <wumpus> both in memory as cpu
226 2019-02-04T15:43:53  *** phwalkr has quit IRC
227 2019-02-04T15:44:28  *** phwalkr has joined #bitcoin-core-dev
228 2019-02-04T15:45:06  *** znd has quit IRC
229 2019-02-04T15:45:12  <wumpus> I don't know why that's the case, but pretty much every language does better in that regard
230 2019-02-04T15:45:50  <promag> what is the motivation of #15340? is this something found elsewhere?
231 2019-02-04T15:45:51  <gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub
232 2019-02-04T15:46:19  *** phwalkr has quit IRC
233 2019-02-04T15:46:24  <wumpus> it was discussed on IRC at some point as a way to make googling errors easier
234 2019-02-04T15:46:37  <hebasto> promag: ^
235 2019-02-04T15:46:43  <wumpus> but this is quite an ugly change :/ and it doesn't even really work like this
236 2019-02-04T15:47:05  <hebasto> wumpus: yep (
237 2019-02-04T15:47:26  <sipa> wumpus: templates.. they essentially require recompiling for every instantiation
238 2019-02-04T15:47:50  <wumpus> sipa: it's true but many other languages have parametrized types too
239 2019-02-04T15:48:24  <luke-jr> wumpus: we had C++ in 2005
240 2019-02-04T15:48:44  <luke-jr> maybe not C++11, but surely the feature additions aren't *that* big a difference
241 2019-02-04T15:49:01  <sipa> wumpus: perhaps the pervasive use of templates in the standard library
242 2019-02-04T15:49:27  <sipa> how many languages have a sort function instantiated for every call
243 2019-02-04T15:49:33  <promag> another coffee break merge #15297
244 2019-02-04T15:49:34  <gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
245 2019-02-04T15:50:19  <wumpus> luke-jr: maybe the source code compiled was smaller, on average, at the time :)
246 2019-02-04T15:50:33  <promag> wumpus: do you want me to review any specific pr?
247 2019-02-04T15:50:35  <wumpus> compilers certainly have improved since then
248 2019-02-04T15:50:50  <promag> 0.18 or hp?
249 2019-02-04T15:51:01  <wumpus> promag: that's really up to you
250 2019-02-04T15:51:23  <wumpus> but it's a good point that so close to a release, having two lists to prioritize review isn't great
251 2019-02-04T15:51:55  <wumpus> normally I'd say "high priority for review" takes precedence as it's blocking people
252 2019-02-04T15:53:22  <wumpus> most things tagged 0.18 will be untagged anyway when it's time for the release and they haven't made it
253 2019-02-04T15:53:43  <wumpus> promag: thanks!
254 2019-02-04T15:54:27  <promag> no problem
255 2019-02-04T15:55:11  <wumpus> luke-jr: of course our functional test suite takes significant time too, blaming the compiler only isn't fair :)
256 2019-02-04T15:55:47  <wumpus> promag: that one has no (ut)ACKs at all
257 2019-02-04T15:55:59  <promag> wumpus: I know :(
258 2019-02-04T15:56:28  <promag> maybe next week coffee
259 2019-02-04T15:57:24  <luke-jr> XD
260 2019-02-04T15:57:30  <wumpus> hehe
261 2019-02-04T15:57:53  <luke-jr> wumpus: I suppose in 2005, we didn't have CI
262 2019-02-04T15:58:23  <luke-jr> but anyway, that wasn't really my point. :x
263 2019-02-04T16:08:46  *** bitcoin-git has joined #bitcoin-core-dev
264 2019-02-04T16:08:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ebc6542d982c...6a5feb7d821f
265 2019-02-04T16:08:47  <bitcoin-git> bitcoin/master bef8fdd ken2812221: msvc: Fix silent merge conflict between #13926 and #14372
266 2019-02-04T16:08:47  <bitcoin-git> bitcoin/master 6a5feb7 MarcoFalke: Merge #15325: msvc: Fix silent merge conflict between #13926 and #14372
267 2019-02-04T16:08:55  *** bitcoin-git has left #bitcoin-core-dev
268 2019-02-04T16:09:26  *** bitcoin-git has joined #bitcoin-core-dev
269 2019-02-04T16:09:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15325: msvc: Fix silent merge conflict between #13926 and #14372 (master...msvc-merge-conflict) https://github.com/bitcoin/bitcoin/pull/15325
270 2019-02-04T16:09:31  *** bitcoin-git has left #bitcoin-core-dev
271 2019-02-04T16:15:34  *** EagleTM has joined #bitcoin-core-dev
272 2019-02-04T16:16:56  *** bitcoin-git has joined #bitcoin-core-dev
273 2019-02-04T16:16:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a5feb7d821f...70d06eb857ce
274 2019-02-04T16:16:57  <bitcoin-git> bitcoin/master fa6b7b9 MarcoFalke: travis: Revert "Run extended tests once daily"
275 2019-02-04T16:16:58  <bitcoin-git> bitcoin/master 70d06eb MarcoFalke: Merge #15328: travis: Revert "Run extended tests once daily"
276 2019-02-04T16:17:00  *** bitcoin-git has left #bitcoin-core-dev
277 2019-02-04T16:17:38  *** bitcoin-git has joined #bitcoin-core-dev
278 2019-02-04T16:17:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15328: travis: Revert "Run extended tests once daily" (master...Mf1902-travisExt) https://github.com/bitcoin/bitcoin/pull/15328
279 2019-02-04T16:17:41  *** bitcoin-git has left #bitcoin-core-dev
280 2019-02-04T16:18:43  *** jarthur_ has joined #bitcoin-core-dev
281 2019-02-04T16:20:01  *** jarthur_ has quit IRC
282 2019-02-04T16:21:58  *** jarthur has quit IRC
283 2019-02-04T16:23:44  *** bitcoin-git has joined #bitcoin-core-dev
284 2019-02-04T16:23:44  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70d06eb857ce...cf8aa5c76ad8
285 2019-02-04T16:23:46  <bitcoin-git> bitcoin/master df8a7d3 Wladimir J. van der Laan: qt: Pre-0.18 split-off translations update
286 2019-02-04T16:23:46  <bitcoin-git> bitcoin/master cf8aa5c Wladimir J. van der Laan: Merge #15339: qt: Pre-0.18 split-off translations update
287 2019-02-04T16:23:57  *** bitcoin-git has left #bitcoin-core-dev
288 2019-02-04T16:24:30  *** bitcoin-git has joined #bitcoin-core-dev
289 2019-02-04T16:24:31  <bitcoin-git> [bitcoin] laanwj merged pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339
290 2019-02-04T16:24:35  *** bitcoin-git has left #bitcoin-core-dev
291 2019-02-04T16:25:56  *** EagleTM has quit IRC
292 2019-02-04T16:28:23  *** promag has quit IRC
293 2019-02-04T16:33:21  *** pinheadmz has joined #bitcoin-core-dev
294 2019-02-04T16:35:43  *** spinza has quit IRC
295 2019-02-04T16:41:27  *** spinza has joined #bitcoin-core-dev
296 2019-02-04T16:49:16  *** bitcoin-git has joined #bitcoin-core-dev
297 2019-02-04T16:49:16  <bitcoin-git> [bitcoin] dongcarl opened pull request #15343: netaddress: Make IPv4 loopback comment more descriptive (master...019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343
298 2019-02-04T16:49:24  *** bitcoin-git has left #bitcoin-core-dev
299 2019-02-04T16:59:38  *** bitcoin-git has joined #bitcoin-core-dev
300 2019-02-04T16:59:39  <bitcoin-git> [bitcoin] hebasto closed pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
301 2019-02-04T16:59:47  *** bitcoin-git has left #bitcoin-core-dev
302 2019-02-04T17:03:02  *** rh0nj has quit IRC
303 2019-02-04T17:03:06  *** jungly has quit IRC
304 2019-02-04T17:03:33  *** bitcoin-git has joined #bitcoin-core-dev
305 2019-02-04T17:03:34  <bitcoin-git> [bitcoin] Empact opened pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344
306 2019-02-04T17:03:41  *** bitcoin-git has left #bitcoin-core-dev
307 2019-02-04T17:04:08  *** rh0nj has joined #bitcoin-core-dev
308 2019-02-04T17:14:49  *** mistergold has quit IRC
309 2019-02-04T17:16:27  *** Murch has joined #bitcoin-core-dev
310 2019-02-04T17:26:09  *** pinheadmz has quit IRC
311 2019-02-04T17:28:34  *** pinheadmz has joined #bitcoin-core-dev
312 2019-02-04T17:41:43  <dongcarl> Hey all, anyone got a good understanding of `mapLocalHost`?
313 2019-02-04T17:42:05  <dongcarl> What does "local address for a particular peer" mean?
314 2019-02-04T17:42:20  * dongcarl looking at `GetLocal`
315 2019-02-04T17:43:22  <sipa> dongcarl: for a IPv4 peer your own address will likely be an IPv4 one
316 2019-02-04T17:43:29  <sipa> i think
317 2019-02-04T17:44:34  <sipa> this code has evolved a bit since i last worked on it
318 2019-02-04T17:44:58  <dongcarl> sipa: So... `GetLocal` tries to find the best "local" address to give to a peer?
319 2019-02-04T17:45:23  <dongcarl> Why would it matter to peers? I feel like I'm misunderstanding...
320 2019-02-04T17:49:27  *** ThomasLuong has joined #bitcoin-core-dev
321 2019-02-04T17:55:14  *** EagleTM has joined #bitcoin-core-dev
322 2019-02-04T18:00:02  <wumpus> it's used to determine what address to gossip IIRC
323 2019-02-04T18:05:03  *** Orion3k has joined #bitcoin-core-dev
324 2019-02-04T18:10:25  <dongcarl> Got the answer in `CNetAddr::GetReachabilityFrom`
325 2019-02-04T18:11:17  <wumpus> okay!
326 2019-02-04T18:15:16  *** bitcoin-git has joined #bitcoin-core-dev
327 2019-02-04T18:15:16  <bitcoin-git> [bitcoin] dongcarl opened pull request #15345: net: Correct comparison of addr count (master...019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345
328 2019-02-04T18:15:23  *** bitcoin-git has left #bitcoin-core-dev
329 2019-02-04T18:17:48  *** ExtraCrispy has joined #bitcoin-core-dev
330 2019-02-04T18:27:52  <dongcarl> wumpus: In situations like #15343, would it be okay for me to just fix the indentation for the function?
331 2019-02-04T18:27:53  <gribble> https://github.com/bitcoin/bitcoin/issues/15343 | netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub
332 2019-02-04T18:28:26  *** EagleTM has quit IRC
333 2019-02-04T18:31:45  *** nullptr| has quit IRC
334 2019-02-04T18:34:34  *** pinheadmz has quit IRC
335 2019-02-04T18:35:53  <gkrizek> wumpus: I just pushed a fix for the leading digit problem on branch names. I updated the ghi instance on your server as well
336 2019-02-04T18:37:41  *** nullptr| has joined #bitcoin-core-dev
337 2019-02-04T18:41:11  <wumpus> dongcarl: how much of the indentation is broken? is it the case for other functions as well?
338 2019-02-04T18:41:42  <wumpus> but sure, you certainly don't need to fix all the indentation, just don't introduce any new wrong one
339 2019-02-04T18:42:03  <wumpus> gkrizek: oh great! thank you
340 2019-02-04T18:42:11  *** pinheadmz has joined #bitcoin-core-dev
341 2019-02-04T18:42:11  *** promag has joined #bitcoin-core-dev
342 2019-02-04T18:44:28  *** bitcoin-git has joined #bitcoin-core-dev
343 2019-02-04T18:44:28  <bitcoin-git> [bitcoin] laanwj closed pull request #15274: remove redundant 'solved' from ProduceSignature (master...sign_redundant_solved) https://github.com/bitcoin/bitcoin/pull/15274
344 2019-02-04T18:44:39  *** bitcoin-git has left #bitcoin-core-dev
345 2019-02-04T18:50:10  *** Zenton has quit IRC
346 2019-02-04T18:51:56  *** bitcoin-git has joined #bitcoin-core-dev
347 2019-02-04T18:51:57  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cf8aa5c76ad8...76deb30550b2
348 2019-02-04T18:51:57  <bitcoin-git> bitcoin/master b0c7b54 Carl Dong: init: Use systemd automatic directory creation
349 2019-02-04T18:51:59  <bitcoin-git> bitcoin/master bad1716 Carl Dong: init: Modify docs and add release note for 12255
350 2019-02-04T18:51:59  <bitcoin-git> bitcoin/master 76deb30 Wladimir J. van der Laan: Merge #12255: Update bitcoin.service to conform to init.md
351 2019-02-04T18:52:08  *** bitcoin-git has left #bitcoin-core-dev
352 2019-02-04T18:52:24  *** bitcoin-git has joined #bitcoin-core-dev
353 2019-02-04T18:52:25  <bitcoin-git> [bitcoin] laanwj merged pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255
354 2019-02-04T18:52:31  *** bitcoin-git has left #bitcoin-core-dev
355 2019-02-04T18:53:30  *** jarthur has joined #bitcoin-core-dev
356 2019-02-04T19:02:19  *** Murch has quit IRC
357 2019-02-04T19:02:47  *** Murch has joined #bitcoin-core-dev
358 2019-02-04T19:04:13  *** timothy has quit IRC
359 2019-02-04T19:06:08  *** bitcoin-git has joined #bitcoin-core-dev
360 2019-02-04T19:06:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76deb30550b2...bfbe42585e9b
361 2019-02-04T19:06:10  <bitcoin-git> bitcoin/master 107623c Carl Dong: net: Correct comparison of addr count
362 2019-02-04T19:06:10  <bitcoin-git> bitcoin/master bfbe425 Wladimir J. van der Laan: Merge #15345: net: Correct comparison of addr count
363 2019-02-04T19:06:16  *** bitcoin-git has left #bitcoin-core-dev
364 2019-02-04T19:06:45  *** bitcoin-git has joined #bitcoin-core-dev
365 2019-02-04T19:06:45  <bitcoin-git> [bitcoin] laanwj merged pull request #15345: net: Correct comparison of addr count (master...2019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345
366 2019-02-04T19:06:47  *** bitcoin-git has left #bitcoin-core-dev
367 2019-02-04T19:12:17  <dongcarl> Can anyone tell me what the deprecated variable naming convention is? I see that `v*` is vector... `f*` seems to be booleans? There's also a `vf` in net.cpp, which is an array of booleans?
368 2019-02-04T19:13:39  <sipa> dongcarl: v=vector, map=map, str=string, sz=c-style-string, f=flag
369 2019-02-04T19:13:54  <sipa> vf=vector of flags
370 2019-02-04T19:14:02  <dongcarl> sipa: Thank you!
371 2019-02-04T19:15:44  *** thedevworks has quit IRC
372 2019-02-04T19:17:00  *** thedevworks has joined #bitcoin-core-dev
373 2019-02-04T19:17:49  <wumpus> don't use it in new code though
374 2019-02-04T19:18:31  <dongcarl> wumpus: Haha yeah ofc
375 2019-02-04T19:18:45  <dongcarl> I'm just reading thru net.cpp adding comments
376 2019-02-04T19:19:18  <sipa> there are many variables whose type changed without the name changing accordingly
377 2019-02-04T19:19:35  <sipa> there's probably some fun archaeology to do with that
378 2019-02-04T19:19:53  <dongcarl> "fun"
379 2019-02-04T19:19:58  *** Krellan has quit IRC
380 2019-02-04T19:22:46  <wumpus> dongcarl: btw if you intend to submit more comment changes to net code, that'd be very helpful, but it's probably better to group them into one PR instead of opening separate ones like #15343
381 2019-02-04T19:22:47  <gribble> https://github.com/bitcoin/bitcoin/issues/15343 | [doc] netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub
382 2019-02-04T19:23:01  *** phwalkr has joined #bitcoin-core-dev
383 2019-02-04T19:23:38  <dongcarl> wumpus: Okay will do, I guess I'll just separate them into different commits so that we can drop/modify them easily during review
384 2019-02-04T19:24:40  <wumpus> yea multiple commits is fine!
385 2019-02-04T19:27:20  *** rex4539 has joined #bitcoin-core-dev
386 2019-02-04T19:27:26  *** phwalkr has quit IRC
387 2019-02-04T19:29:00  *** jarthur_ has joined #bitcoin-core-dev
388 2019-02-04T19:29:04  *** bitcoin-git has joined #bitcoin-core-dev
389 2019-02-04T19:29:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bfbe42585e9b...452acee4da20
390 2019-02-04T19:29:05  <bitcoin-git> bitcoin/master 77777c5 MarcoFalke: log: Construct global logger on first use
391 2019-02-04T19:29:06  <bitcoin-git> bitcoin/master 452acee MarcoFalke: Merge #15266: memory: Construct globals on first use
392 2019-02-04T19:29:13  *** bitcoin-git has left #bitcoin-core-dev
393 2019-02-04T19:29:43  *** bitcoin-git has joined #bitcoin-core-dev
394 2019-02-04T19:29:43  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15266: memory: Construct globals on first use (master...Mf1901-cofu) https://github.com/bitcoin/bitcoin/pull/15266
395 2019-02-04T19:29:48  *** bitcoin-git has left #bitcoin-core-dev
396 2019-02-04T19:32:40  *** Murch has quit IRC
397 2019-02-04T19:32:57  <dongcarl> Does anyone know what the "p" in "paddrPeer" in net.cpp might be referring to?
398 2019-02-04T19:33:16  *** jarthur has quit IRC
399 2019-02-04T19:33:35  <sipa> pointer
400 2019-02-04T19:33:50  *** Murch has joined #bitcoin-core-dev
401 2019-02-04T19:35:14  <promag> classic XD
402 2019-02-04T19:35:33  <sipa> promag: that's hungarian style :)
403 2019-02-04T19:35:36  * dongcarl facepalms
404 2019-02-04T19:36:22  <dongcarl> Oh wow that's an actual thing
405 2019-02-04T19:36:23  <dongcarl> TIL
406 2019-02-04T19:37:25  <hebasto> jonasschnelli: thank you for your opinion about #15340 but this pr breaks translation process, unfortunately.
407 2019-02-04T19:37:27  <gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub
408 2019-02-04T19:37:39  <promag> dongcarl: apologies for that, you were much happier before
409 2019-02-04T19:38:20  <sipa> dongcarl: so psz is pointer-to-zero-terminated-string
410 2019-02-04T19:38:30  <sipa> which used to occur frequently
411 2019-02-04T19:40:12  <dongcarl> sipa: My mom warned me about nasty C-style zero-terminated strings! They hang out in all the bad stacks!
412 2019-02-04T19:42:44  *** mn949588 has quit IRC
413 2019-02-04T19:43:04  *** mn949588 has joined #bitcoin-core-dev
414 2019-02-04T19:44:14  *** ap4lmtree has quit IRC
415 2019-02-04T19:53:15  *** lnostdal has quit IRC
416 2019-02-04T19:57:05  *** jarthur_ has quit IRC
417 2019-02-04T19:59:08  *** ap4lmtree has joined #bitcoin-core-dev
418 2019-02-04T19:59:34  *** promag has quit IRC
419 2019-02-04T19:59:47  <wumpus> hebasto: *conceptually* it's a good idea, it's just virtually impossible to implement correctly with gettext
420 2019-02-04T20:01:41  *** mn9495881 has joined #bitcoin-core-dev
421 2019-02-04T20:01:58  <hebasto> wumpus: thanks
422 2019-02-04T20:04:42  *** mn949588 has quit IRC
423 2019-02-04T20:08:48  <wumpus> we've run into a similar issue in the past for the status bar, where we wanted to return the untranslated error on the RPC and the translated one on the GUI
424 2019-02-04T20:08:58  <wumpus> ended up duplicating the text ...
425 2019-02-04T20:09:21  <wumpus> would certainly *not* be nice to do for all errors
426 2019-02-04T20:10:15  <wumpus> dongcarl: your mother is very wise
427 2019-02-04T20:29:26  *** thedevworks has quit IRC
428 2019-02-04T20:31:13  *** thedevworks has joined #bitcoin-core-dev
429 2019-02-04T20:34:56  *** ap4lmtree has quit IRC
430 2019-02-04T20:44:07  *** DeanGuss has quit IRC
431 2019-02-04T20:45:30  *** lnostdal has joined #bitcoin-core-dev
432 2019-02-04T20:55:54  *** phwalkr has joined #bitcoin-core-dev
433 2019-02-04T20:57:13  *** shesek has joined #bitcoin-core-dev
434 2019-02-04T21:00:09  *** phwalkr has quit IRC
435 2019-02-04T21:07:05  *** darosior has joined #bitcoin-core-dev
436 2019-02-04T21:16:11  *** ap4lmtree has joined #bitcoin-core-dev
437 2019-02-04T21:24:20  *** jarthur has joined #bitcoin-core-dev
438 2019-02-04T21:32:14  *** thedevworks has quit IRC
439 2019-02-04T21:36:45  *** pinheadmz has quit IRC
440 2019-02-04T21:42:21  *** phwalkr has joined #bitcoin-core-dev
441 2019-02-04T21:44:44  *** macbroadcast has joined #bitcoin-core-dev
442 2019-02-04T21:47:05  *** macbroadcast has quit IRC
443 2019-02-04T21:47:20  *** macbroadcast_ has joined #bitcoin-core-dev
444 2019-02-04T21:48:48  *** macbroadcast_ has quit IRC
445 2019-02-04T21:54:35  *** bitcoin-git has joined #bitcoin-core-dev
446 2019-02-04T21:54:35  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14169: add -debuglogsize=<n> option (master...master) https://github.com/bitcoin/bitcoin/pull/14169
447 2019-02-04T21:54:38  *** bitcoin-git has left #bitcoin-core-dev
448 2019-02-04T22:00:56  *** pinheadmz has joined #bitcoin-core-dev
449 2019-02-04T22:06:33  *** Zenton has joined #bitcoin-core-dev
450 2019-02-04T22:10:03  *** bitcoin-git has joined #bitcoin-core-dev
451 2019-02-04T22:10:03  <bitcoin-git> [bitcoin] darosior opened pull request #15346: cli: encryptwallet password entered from stdin. fixes #15318 (master...cli_encryptwallet_stdin) https://github.com/bitcoin/bitcoin/pull/15346
452 2019-02-04T22:10:07  *** bitcoin-git has left #bitcoin-core-dev
453 2019-02-04T22:10:35  *** phwalkr has quit IRC
454 2019-02-04T22:10:43  *** Guyver2 has quit IRC
455 2019-02-04T22:13:41  *** spinza has quit IRC
456 2019-02-04T22:14:36  *** DeanGuss has joined #bitcoin-core-dev
457 2019-02-04T22:19:32  *** spinza has joined #bitcoin-core-dev
458 2019-02-04T22:19:47  *** rex4539 has quit IRC
459 2019-02-04T22:26:11  *** darosior has quit IRC
460 2019-02-04T22:37:02  *** Orion3k has quit IRC
461 2019-02-04T22:45:09  *** Krellan has joined #bitcoin-core-dev
462 2019-02-04T22:52:36  *** bitcoin-git has joined #bitcoin-core-dev
463 2019-02-04T22:52:37  <bitcoin-git> [bitcoin] hebasto reopened pull request #15340: gui: Introduce bilingual GUI error messages (master...20190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
464 2019-02-04T22:52:43  *** bitcoin-git has left #bitcoin-core-dev
465 2019-02-04T22:52:57  *** tryphe_ is now known as tryphe
466 2019-02-04T22:55:35  *** arubi has quit IRC
467 2019-02-04T22:59:23  *** Murch has quit IRC
468 2019-02-04T23:03:11  *** tyttor has joined #bitcoin-core-dev
469 2019-02-04T23:04:28  *** tyttor has left #bitcoin-core-dev
470 2019-02-04T23:11:15  *** thedevworks has joined #bitcoin-core-dev
471 2019-02-04T23:12:55  *** thedevworks has quit IRC
472 2019-02-04T23:17:03  *** promag has joined #bitcoin-core-dev
473 2019-02-04T23:22:13  *** DeanGuss has quit IRC
474 2019-02-04T23:38:27  *** bitcoin-git has joined #bitcoin-core-dev
475 2019-02-04T23:38:28  <bitcoin-git> [bitcoin] hebasto opened pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347
476 2019-02-04T23:38:33  *** bitcoin-git has left #bitcoin-core-dev
477 2019-02-04T23:38:46  *** michaelsdunn1 has quit IRC
478 2019-02-04T23:54:40  *** pinheadmz has quit IRC
479 2019-02-04T23:54:54  *** ThomasLuong has quit IRC