1 2019-02-05T00:01:47 *** pinheadmz has joined #bitcoin-core-dev
2 2019-02-05T00:11:01 *** rh0nj has quit IRC
3 2019-02-05T00:12:07 *** Murch has joined #bitcoin-core-dev
4 2019-02-05T00:12:08 *** rh0nj has joined #bitcoin-core-dev
5 2019-02-05T00:12:47 *** jtimon has quit IRC
6 2019-02-05T00:14:37 *** Krellan_ has joined #bitcoin-core-dev
7 2019-02-05T00:15:12 *** hebasto has quit IRC
8 2019-02-05T00:17:12 *** Krellan has quit IRC
9 2019-02-05T00:23:17 *** jtimon has joined #bitcoin-core-dev
10 2019-02-05T00:49:50 *** miknotauro has joined #bitcoin-core-dev
11 2019-02-05T01:00:14 *** Murch has quit IRC
12 2019-02-05T01:05:55 *** sipa has quit IRC
13 2019-02-05T01:06:37 *** sipa has joined #bitcoin-core-dev
14 2019-02-05T01:14:46 *** spinza has quit IRC
15 2019-02-05T01:21:28 *** pinheadmz has quit IRC
16 2019-02-05T01:26:42 *** spinza has joined #bitcoin-core-dev
17 2019-02-05T01:31:22 *** IGHOR has quit IRC
18 2019-02-05T01:33:36 *** IGHOR has joined #bitcoin-core-dev
19 2019-02-05T01:42:18 *** Murch has joined #bitcoin-core-dev
20 2019-02-05T01:45:57 *** Murch has quit IRC
21 2019-02-05T02:13:17 *** miknotauro has quit IRC
22 2019-02-05T02:15:58 *** miknotauro has joined #bitcoin-core-dev
23 2019-02-05T02:16:08 *** AaronvanW has quit IRC
24 2019-02-05T02:33:08 *** DeanGuss has joined #bitcoin-core-dev
25 2019-02-05T02:34:01 *** miknotauro has quit IRC
26 2019-02-05T02:37:23 *** bitcoin-git has joined #bitcoin-core-dev
27 2019-02-05T02:37:24 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/452acee4da20...e50853501b79
28 2019-02-05T02:37:24 <bitcoin-git> bitcoin/master e1b6436 Hennadii Stepanov: Fix build after pr 15266 merged
29 2019-02-05T02:37:25 <bitcoin-git> bitcoin/master e508535 Wladimir J. van der Laan: Merge #15347: Fix build after pr 15266 merged
30 2019-02-05T02:37:28 *** bitcoin-git has left #bitcoin-core-dev
31 2019-02-05T02:38:09 *** bitcoin-git has joined #bitcoin-core-dev
32 2019-02-05T02:38:09 <bitcoin-git> [bitcoin] laanwj merged pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347
33 2019-02-05T02:38:12 *** bitcoin-git has left #bitcoin-core-dev
34 2019-02-05T02:45:29 *** bitcoin-git has joined #bitcoin-core-dev
35 2019-02-05T02:45:29 <bitcoin-git> [bitcoin] Empact closed pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344
36 2019-02-05T02:45:31 *** bitcoin-git has left #bitcoin-core-dev
37 2019-02-05T02:48:04 *** pinheadmz has joined #bitcoin-core-dev
38 2019-02-05T02:53:25 *** jarthur has quit IRC
39 2019-02-05T02:55:48 *** Empact has joined #bitcoin-core-dev
40 2019-02-05T02:55:49 *** StopAndDecrypt has joined #bitcoin-core-dev
41 2019-02-05T03:04:55 *** Empact has quit IRC
42 2019-02-05T03:06:21 *** Empact has joined #bitcoin-core-dev
43 2019-02-05T03:19:27 *** pinheadmz has quit IRC
44 2019-02-05T03:20:05 *** Krellan_ has quit IRC
45 2019-02-05T03:23:41 *** Empact has quit IRC
46 2019-02-05T03:26:51 *** Empact has joined #bitcoin-core-dev
47 2019-02-05T03:27:08 *** Empact has quit IRC
48 2019-02-05T03:28:27 *** pinheadmz has joined #bitcoin-core-dev
49 2019-02-05T03:31:31 *** Empact has joined #bitcoin-core-dev
50 2019-02-05T03:43:06 *** ThomasLuong has joined #bitcoin-core-dev
51 2019-02-05T03:48:18 *** pinheadmz has quit IRC
52 2019-02-05T03:50:32 *** Empact has quit IRC
53 2019-02-05T04:03:34 *** achow101 has quit IRC
54 2019-02-05T04:11:17 *** achow101 has joined #bitcoin-core-dev
55 2019-02-05T04:29:27 *** skyikot has joined #bitcoin-core-dev
56 2019-02-05T04:42:57 *** skyikot has quit IRC
57 2019-02-05T04:46:09 *** skyikot has joined #bitcoin-core-dev
58 2019-02-05T04:48:23 *** skyikot has quit IRC
59 2019-02-05T04:54:41 *** skyikot has joined #bitcoin-core-dev
60 2019-02-05T05:06:26 *** pinheadmz has joined #bitcoin-core-dev
61 2019-02-05T05:23:18 *** pinheadmz has quit IRC
62 2019-02-05T05:26:25 *** rex4539 has joined #bitcoin-core-dev
63 2019-02-05T05:42:44 *** nelsonhb has joined #bitcoin-core-dev
64 2019-02-05T05:45:46 *** skyikot has quit IRC
65 2019-02-05T06:00:51 *** tryphe_ has joined #bitcoin-core-dev
66 2019-02-05T06:03:56 *** tryphe has quit IRC
67 2019-02-05T06:06:43 *** jtimon has quit IRC
68 2019-02-05T06:07:48 *** ThomasLuong has quit IRC
69 2019-02-05T06:12:45 *** pinheadmz has joined #bitcoin-core-dev
70 2019-02-05T06:24:44 *** skyikot has joined #bitcoin-core-dev
71 2019-02-05T06:26:42 *** nelsonhb has quit IRC
72 2019-02-05T06:46:21 <meshcollider> provoostenator: I've just cleaned up #14491 now, feel free to rebase your stuff on top of it again :)
73 2019-02-05T06:46:24 <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
74 2019-02-05T07:16:10 *** hebasto has joined #bitcoin-core-dev
75 2019-02-05T07:23:31 <meshcollider> whats up with the "Reading package lists...
76 2019-02-05T07:23:31 <meshcollider> No output has been received in the last 10m0s" failures on travis atm
77 2019-02-05T07:24:55 <meshcollider> https://travis-ci.org/bitcoin/bitcoin/builds/488891564
78 2019-02-05T07:29:33 *** skyikot has quit IRC
79 2019-02-05T07:43:32 *** darosior has joined #bitcoin-core-dev
80 2019-02-05T07:45:41 *** pinheadmz has quit IRC
81 2019-02-05T07:48:40 *** jimmysong has quit IRC
82 2019-02-05T07:49:03 *** jimmysong has joined #bitcoin-core-dev
83 2019-02-05T08:13:01 *** rh0nj has quit IRC
84 2019-02-05T08:14:07 *** rh0nj has joined #bitcoin-core-dev
85 2019-02-05T08:14:52 *** fanquake has joined #bitcoin-core-dev
86 2019-02-05T08:20:07 *** romain has quit IRC
87 2019-02-05T08:27:14 *** Sentineo has quit IRC
88 2019-02-05T08:27:55 *** Empact has joined #bitcoin-core-dev
89 2019-02-05T08:29:58 *** phwalkr has joined #bitcoin-core-dev
90 2019-02-05T08:31:56 *** Empact_ has joined #bitcoin-core-dev
91 2019-02-05T08:32:34 *** rex4539 has quit IRC
92 2019-02-05T08:32:44 *** Empact_ has quit IRC
93 2019-02-05T08:38:36 <meshcollider> nvm its working now
94 2019-02-05T08:39:13 *** promag has quit IRC
95 2019-02-05T08:46:58 *** Sentineo has joined #bitcoin-core-dev
96 2019-02-05T09:00:17 *** darosior has quit IRC
97 2019-02-05T09:00:32 *** nelsonhb has joined #bitcoin-core-dev
98 2019-02-05T09:00:49 *** volkov has joined #bitcoin-core-dev
99 2019-02-05T09:06:02 *** hebasto has quit IRC
100 2019-02-05T09:11:26 *** setpill has joined #bitcoin-core-dev
101 2019-02-05T09:26:28 *** nelsonhb has quit IRC
102 2019-02-05T09:26:54 *** timothy has joined #bitcoin-core-dev
103 2019-02-05T09:44:44 *** volkov has quit IRC
104 2019-02-05T09:57:39 *** jungly has joined #bitcoin-core-dev
105 2019-02-05T09:58:31 *** dqx has quit IRC
106 2019-02-05T10:14:33 *** dqx has joined #bitcoin-core-dev
107 2019-02-05T10:25:28 *** promag has joined #bitcoin-core-dev
108 2019-02-05T10:29:20 <meshcollider> anyone willing to give #14667 a quick review?
109 2019-02-05T10:29:23 <gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddresses RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
110 2019-02-05T10:33:21 *** spinza has quit IRC
111 2019-02-05T10:40:28 *** rex4539 has joined #bitcoin-core-dev
112 2019-02-05T10:40:42 *** pergaminho has joined #bitcoin-core-dev
113 2019-02-05T10:46:09 *** spinza has joined #bitcoin-core-dev
114 2019-02-05T11:05:54 *** davec has quit IRC
115 2019-02-05T11:05:54 *** qubenix has quit IRC
116 2019-02-05T11:05:54 *** wxss has quit IRC
117 2019-02-05T11:06:11 *** davec has joined #bitcoin-core-dev
118 2019-02-05T11:06:27 *** lnostdal has quit IRC
119 2019-02-05T11:06:52 *** wxss has joined #bitcoin-core-dev
120 2019-02-05T11:11:49 *** lnostdal has joined #bitcoin-core-dev
121 2019-02-05T11:15:55 *** tryphe_ has quit IRC
122 2019-02-05T11:16:17 *** tryphe_ has joined #bitcoin-core-dev
123 2019-02-05T11:16:27 *** promag has quit IRC
124 2019-02-05T11:19:29 *** qubenix has joined #bitcoin-core-dev
125 2019-02-05T11:20:36 *** spinza has quit IRC
126 2019-02-05T11:20:58 *** cluelessperson has quit IRC
127 2019-02-05T11:21:19 *** cluelessperson has joined #bitcoin-core-dev
128 2019-02-05T11:29:42 *** spinza has joined #bitcoin-core-dev
129 2019-02-05T11:31:47 *** promag has joined #bitcoin-core-dev
130 2019-02-05T11:34:37 *** lnostdal has quit IRC
131 2019-02-05T11:35:48 *** lnostdal has joined #bitcoin-core-dev
132 2019-02-05T11:51:11 *** AaronvanW has joined #bitcoin-core-dev
133 2019-02-05T12:03:33 *** pergaminho has quit IRC
134 2019-02-05T12:04:21 *** pergaminho has joined #bitcoin-core-dev
135 2019-02-05T12:10:03 *** pergaminho has quit IRC
136 2019-02-05T12:21:57 *** pergaminho has joined #bitcoin-core-dev
137 2019-02-05T12:25:36 *** arubi has joined #bitcoin-core-dev
138 2019-02-05T12:26:32 *** marcoagner has quit IRC
139 2019-02-05T12:27:36 *** promag has quit IRC
140 2019-02-05T12:42:24 *** nelsonhb has joined #bitcoin-core-dev
141 2019-02-05T13:01:19 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
142 2019-02-05T13:01:19 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
143 2019-02-05T13:28:14 *** rex4539 has quit IRC
144 2019-02-05T13:31:51 *** Guyver2 has joined #bitcoin-core-dev
145 2019-02-05T13:39:03 *** promag has joined #bitcoin-core-dev
146 2019-02-05T13:40:01 *** Cogito_Ergo_Sum has quit IRC
147 2019-02-05T13:43:26 *** promag has quit IRC
148 2019-02-05T13:47:20 *** pergaminho has quit IRC
149 2019-02-05T13:47:33 *** pergaminho has joined #bitcoin-core-dev
150 2019-02-05T13:50:59 *** nelsonhb has quit IRC
151 2019-02-05T13:57:55 *** otoburb has joined #bitcoin-core-dev
152 2019-02-05T14:02:37 *** queip has quit IRC
153 2019-02-05T14:03:16 *** rafalcpp has quit IRC
154 2019-02-05T14:09:22 *** oneark has joined #bitcoin-core-dev
155 2019-02-05T14:10:57 <instagibbs> pure utility rpcs? Not that I wouldn't appreciate the functionality but I don't think the motivation for adding it versus other utility rpcs has been given
156 2019-02-05T14:29:04 *** queip has joined #bitcoin-core-dev
157 2019-02-05T14:34:59 *** promag has joined #bitcoin-core-dev
158 2019-02-05T14:45:22 <promag> 0.18 list is quite big
159 2019-02-05T14:46:37 *** rex4539 has joined #bitcoin-core-dev
160 2019-02-05T14:57:55 *** promag has quit IRC
161 2019-02-05T15:08:17 *** mn949588 has joined #bitcoin-core-dev
162 2019-02-05T15:08:24 *** mn9495881 has quit IRC
163 2019-02-05T15:24:36 <fanquake> promag Some stuff on there that'll get dropped, as well as issues that dont actually require any more action
164 2019-02-05T15:26:09 *** hebasto has joined #bitcoin-core-dev
165 2019-02-05T15:30:20 <fanquake> sipa I know it's arbitrary, but how long would you expect test-exhaust (from minisketch) to run for?
166 2019-02-05T15:31:36 *** setpill has quit IRC
167 2019-02-05T15:32:01 *** kexkey has joined #bitcoin-core-dev
168 2019-02-05T15:40:05 *** michaelsdunn1 has joined #bitcoin-core-dev
169 2019-02-05T15:40:05 *** michaelsdunn1 has quit IRC
170 2019-02-05T15:40:05 *** michaelsdunn1 has joined #bitcoin-core-dev
171 2019-02-05T15:41:06 *** bitcoin-git has joined #bitcoin-core-dev
172 2019-02-05T15:41:08 <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e50853501b79...bbdcc0b0ff0e
173 2019-02-05T15:41:08 <bitcoin-git> bitcoin/master 95a812b Russell Yanofsky: Rename ScanResult stop_block field
174 2019-02-05T15:41:09 <bitcoin-git> bitcoin/master a8d645c Russell Yanofsky: Update ScanForWalletTransactions result comment
175 2019-02-05T15:41:10 <bitcoin-git> bitcoin/master db2d093 Russell Yanofsky: Add suggested rescanblockchain comments
176 2019-02-05T15:41:12 *** bitcoin-git has left #bitcoin-core-dev
177 2019-02-05T15:41:56 *** bitcoin-git has joined #bitcoin-core-dev
178 2019-02-05T15:41:56 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15342: Suggested wallet code cleanups from #14711 (master...pr/wclean) https://github.com/bitcoin/bitcoin/pull/15342
179 2019-02-05T15:41:57 *** bitcoin-git has left #bitcoin-core-dev
180 2019-02-05T15:48:16 *** bitcoin-git has joined #bitcoin-core-dev
181 2019-02-05T15:48:17 <bitcoin-git> [bitcoin] dongcarl opened pull request #15348: doc: Add separate productivity notes document (master...2019-02-productivity-md) https://github.com/bitcoin/bitcoin/pull/15348
182 2019-02-05T15:48:20 *** bitcoin-git has left #bitcoin-core-dev
183 2019-02-05T15:51:24 *** bitcoin-git has joined #bitcoin-core-dev
184 2019-02-05T15:51:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbdcc0b0ff0e...fc21bb4e3590
185 2019-02-05T15:51:25 <bitcoin-git> bitcoin/master 851380c Gregory Sanders: remove deprecated mentions of signrawtransaction from fundraw help
186 2019-02-05T15:51:25 <bitcoin-git> bitcoin/master fc21bb4 MarcoFalke: Merge #15245: remove deprecated mentions of signrawtransaction from fundra...
187 2019-02-05T15:51:26 *** bitcoin-git has left #bitcoin-core-dev
188 2019-02-05T15:52:11 *** bitcoin-git has joined #bitcoin-core-dev
189 2019-02-05T15:52:12 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15245: remove deprecated mentions of signrawtransaction from fundraw help (master...fundraw_signraw) https://github.com/bitcoin/bitcoin/pull/15245
190 2019-02-05T15:52:15 *** bitcoin-git has left #bitcoin-core-dev
191 2019-02-05T16:11:44 *** jarthur has joined #bitcoin-core-dev
192 2019-02-05T16:17:10 *** rafalcpp has joined #bitcoin-core-dev
193 2019-02-05T16:19:05 *** darosior has joined #bitcoin-core-dev
194 2019-02-05T16:21:21 *** rockhouse has quit IRC
195 2019-02-05T16:21:21 *** victorSN has quit IRC
196 2019-02-05T16:24:46 *** rockhouse has joined #bitcoin-core-dev
197 2019-02-05T16:25:32 *** victorSN has joined #bitcoin-core-dev
198 2019-02-05T16:26:08 *** fanquake has quit IRC
199 2019-02-05T16:32:20 *** jtimon has joined #bitcoin-core-dev
200 2019-02-05T16:54:10 *** jungly has quit IRC
201 2019-02-05T16:57:04 *** jarthur_ has joined #bitcoin-core-dev
202 2019-02-05T16:57:22 *** hebasto has quit IRC
203 2019-02-05T16:59:02 *** pinheadmz has joined #bitcoin-core-dev
204 2019-02-05T16:59:12 <dongcarl> I'm talking to distro maintainers about #12255, when checking if a directory is a valid bitcoin directory, would checking `[ -f foo/bar/peers.dat ]` be sufficient? Would it be better to check `[ -f foo/bar/.lock ]`?
205 2019-02-05T16:59:14 <gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
206 2019-02-05T17:00:07 *** jarthur has quit IRC
207 2019-02-05T17:08:15 *** ddustin has joined #bitcoin-core-dev
208 2019-02-05T17:09:20 *** ddustin has joined #bitcoin-core-dev
209 2019-02-05T17:09:58 *** ddustin has quit IRC
210 2019-02-05T17:10:33 *** ddustin has joined #bitcoin-core-dev
211 2019-02-05T17:11:01 *** darosior has quit IRC
212 2019-02-05T17:11:01 *** ddustin has quit IRC
213 2019-02-05T17:11:38 *** ddustin has joined #bitcoin-core-dev
214 2019-02-05T17:13:50 *** jarthur_ has quit IRC
215 2019-02-05T17:14:31 *** ThomasLuong has joined #bitcoin-core-dev
216 2019-02-05T17:15:50 *** bitcoin-git has joined #bitcoin-core-dev
217 2019-02-05T17:15:51 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fc21bb4e3590...3a573fd46c75
218 2019-02-05T17:15:52 <bitcoin-git> bitcoin/master 1bd9ffd Chun Kuan Lee: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
219 2019-02-05T17:15:53 <bitcoin-git> bitcoin/master d8a2992 Chun Kuan Lee: windows: Call SetProcessDEPPolicy directly
220 2019-02-05T17:15:54 <bitcoin-git> bitcoin/master d0522ec Ben Woosley: Drop defunct Windows compat fixes
221 2019-02-05T17:15:55 *** bitcoin-git has left #bitcoin-core-dev
222 2019-02-05T17:16:21 *** bitcoin-git has joined #bitcoin-core-dev
223 2019-02-05T17:16:21 <bitcoin-git> [bitcoin] laanwj merged pull request #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
224 2019-02-05T17:16:22 *** bitcoin-git has left #bitcoin-core-dev
225 2019-02-05T17:18:28 *** hebasto has joined #bitcoin-core-dev
226 2019-02-05T17:19:50 *** jarthur has joined #bitcoin-core-dev
227 2019-02-05T17:21:48 *** jarthur has joined #bitcoin-core-dev
228 2019-02-05T17:22:28 *** ThomasLuong has quit IRC
229 2019-02-05T17:31:18 *** promag has joined #bitcoin-core-dev
230 2019-02-05T17:44:15 *** EagleTM has joined #bitcoin-core-dev
231 2019-02-05T17:48:55 *** oneark has quit IRC
232 2019-02-05T17:52:30 *** dqx has quit IRC
233 2019-02-05T17:52:35 *** EagleTM has quit IRC
234 2019-02-05T18:05:44 <promag> is #15153 for 0.18? if so it needs the label
235 2019-02-05T18:05:47 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
236 2019-02-05T18:11:55 <wumpus> sure, the 0.18 label isn't more than 'would be nice if it made 0.18'
237 2019-02-05T18:13:59 *** dqx has joined #bitcoin-core-dev
238 2019-02-05T18:16:58 *** Murch has joined #bitcoin-core-dev
239 2019-02-05T18:18:42 *** dqx has quit IRC
240 2019-02-05T18:19:06 <promag> just saw #15309 :/
241 2019-02-05T18:19:07 <gribble> https://github.com/bitcoin/bitcoin/issues/15309 | tests: Running with --usecli ~5x slower than without · Issue #15309 · bitcoin/bitcoin · GitHub
242 2019-02-05T18:20:02 <promag> I'll dig into that cc sdaftuar
243 2019-02-05T18:20:11 *** promag has quit IRC
244 2019-02-05T18:28:53 <gleb> It seems like we restricted getdata on sending to 100 entries, and on receiving to 50,000 entries :)
245 2019-02-05T18:29:45 *** dqx has joined #bitcoin-core-dev
246 2019-02-05T18:30:44 *** ap4lmtree has quit IRC
247 2019-02-05T18:32:26 <gleb> If we restrict getdata to 100 on receive, it seems we would punish btcd nodes for misbehaving :)
248 2019-02-05T18:33:36 <gleb> If this is done on purpose, perhaps we should leave a comment at least...
249 2019-02-05T18:34:14 <sdaftuar> you mean leave a comment as to why we picked 100?
250 2019-02-05T18:34:39 <gleb> Why there are 2 different numbers where it is expected to have the same number (because we don't want to punish btcd?)
251 2019-02-05T18:34:55 <sdaftuar> or punish old nodes
252 2019-02-05T18:35:00 <sipa> well, it's always been 50000
253 2019-02-05T18:35:07 <sipa> we can't just change what we accept
254 2019-02-05T18:35:11 <sipa> we can change what we send
255 2019-02-05T18:35:12 <sdaftuar> ^ right
256 2019-02-05T18:35:29 *** ap4lmtree has joined #bitcoin-core-dev
257 2019-02-05T18:35:40 <sipa> so indeed, the needed comment is why are we only sending 100 :)
258 2019-02-05T18:37:19 <gmaxwell> we should probably limit rx too, that just takes coordination time.
259 2019-02-05T18:38:36 <sdaftuar> limiting rx implies creating some rate limit (to be useful). not sure what we gain otherwise except coordination headache
260 2019-02-05T18:41:19 <sdaftuar> gleb: i picked 100 by looking at the already_asked_for size relative to the number of peers i thought you might reasonably have, and picking a round number that would give us some buffer
261 2019-02-05T18:42:34 <gmaxwell> sdaftuar: not a rate limit, but the number of invs in a single message.
262 2019-02-05T18:42:38 *** EagleTM has joined #bitcoin-core-dev
263 2019-02-05T18:42:45 <sdaftuar> gmaxwell: what purpose would that serve?
264 2019-02-05T18:42:54 <gmaxwell> We should not have 1.8MB packets in the protocol, they insert huge latency/processing spikes.
265 2019-02-05T18:43:09 <sdaftuar> ah, i guess that's fair
266 2019-02-05T18:43:33 <sdaftuar> we could also make our code smarter and allow interruption of processing such messages
267 2019-02-05T18:43:55 <gmaxwell> not the most critical of issues, but I can't see any reason why we'd ever want getdatas that large.
268 2019-02-05T18:44:04 <sipa> sdaftuar: i think we do, for getdata
269 2019-02-05T18:44:08 <sdaftuar> sipa: yep
270 2019-02-05T18:44:12 <sdaftuar> but for tx announcements
271 2019-02-05T18:44:17 <gmaxwell> sdaftuar: still have to buffer them.
272 2019-02-05T18:45:02 <gmaxwell> an obvious thing to do would be to limit them with the introduction of the encrypted transport.
273 2019-02-05T18:47:38 <sdaftuar> sure
274 2019-02-05T18:47:53 <gleb> But huge getdatas are as bad as huge invs, right?
275 2019-02-05T18:48:08 <sdaftuar> i think so
276 2019-02-05T18:48:13 <sdaftuar> we queue them up for processing
277 2019-02-05T18:48:38 <sdaftuar> in theory getdatas should be limited by what we announce, which is rate limited
278 2019-02-05T18:48:43 <sdaftuar> a misbehaving peer could send us garbage
279 2019-02-05T18:48:51 *** hebasto has quit IRC
280 2019-02-05T18:48:52 <sdaftuar> and we wouldn't punish (instead, we helpfully send notfound's)
281 2019-02-05T18:49:06 <gmaxwell> I thought we stopped sending notfounds?
282 2019-02-05T18:49:13 <sdaftuar> no, we stopped sending rejects i think
283 2019-02-05T18:49:18 *** hebasto has joined #bitcoin-core-dev
284 2019-02-05T18:49:25 <sdaftuar> i have a PR coming that will use the NOTFOUNDs! so i hope we don't get rid of those
285 2019-02-05T18:50:23 <gmaxwell> what would you use them for?
286 2019-02-05T18:50:38 <sdaftuar> to request a transaction from someone else. my thought was that we can make it so that not providing a transaciton is no longer a DoS on our peer
287 2019-02-05T18:50:52 <sdaftuar> and this would be a way to eventually drop mapRelay
288 2019-02-05T18:56:20 <gmaxwell> that requires the peer to cooperate, a DOS attacker wouldn't...
289 2019-02-05T18:56:39 <sdaftuar> gmaxwell: agree, but a DoS attacker has no bearing on whether we keep mapRelay around
290 2019-02-05T18:56:53 <gmaxwell> So all that would do is speed things up in the cooperative case? which sounds okay to me, but I don't see how we could drop maprelay?
291 2019-02-05T18:57:07 <sdaftuar> well i think then we can just serve things from the mempool
292 2019-02-05T18:57:12 <sdaftuar> and give a notfound otherwise
293 2019-02-05T18:57:46 <gmaxwell> oh maprealy sorry, being dumb and thinking you were talking about the map we use to schedule rerequests.
294 2019-02-05T18:57:47 <gmaxwell> sounds good.
295 2019-02-05T18:58:26 <sdaftuar> this should be easy to implement after gleb's PR, so i was hoping we might slip it into 0.18
296 2019-02-05T18:59:27 <sdaftuar> (the smarter behavior after receiving a NOTFOUND, i mean)
297 2019-02-05T19:00:41 <gmaxwell> I like this idea.
298 2019-02-05T19:02:24 *** wolfspraul has quit IRC
299 2019-02-05T19:02:32 *** wolfspraul has joined #bitcoin-core-dev
300 2019-02-05T19:05:42 <phantomcircuit> gmaxwell, im not sure how much of a processing spike a 1.8MB inv would cause, since it gets pushed into it's own queue and each inv is processed individually
301 2019-02-05T19:05:58 <phantomcircuit> (s/inv/getdata/)
302 2019-02-05T19:06:26 *** wolfspraul has quit IRC
303 2019-02-05T19:06:50 *** wolfspraul has joined #bitcoin-core-dev
304 2019-02-05T19:07:44 <gmaxwell> not processing spike, as much as it head of line blocks the socket, uses up a big buffer just checksumming it, etc. It's not much of a problem but it serves no use.
305 2019-02-05T19:08:38 <phantomcircuit> think the only issue there is the memory it uses
306 2019-02-05T19:09:10 <phantomcircuit> blocking the socket for the peer that's being stupid seems fine to me
307 2019-02-05T19:12:31 <gmaxwell> right, I said about it isn't so much a problem as its just dumb.
308 2019-02-05T19:13:04 <gmaxwell> though it does mean that we need to be willing to buffer 1.8mb of memory, but we have to for other messages in any case.
309 2019-02-05T19:13:09 <gmaxwell> (in particular, block messages)
310 2019-02-05T19:18:52 *** pergaminho has quit IRC
311 2019-02-05T19:19:52 *** ghost43 has quit IRC
312 2019-02-05T19:22:05 *** ghost43 has joined #bitcoin-core-dev
313 2019-02-05T19:57:03 *** michaelsdunn1 has quit IRC
314 2019-02-05T19:58:46 *** michaelsdunn1 has joined #bitcoin-core-dev
315 2019-02-05T20:08:31 *** mn9495882 has joined #bitcoin-core-dev
316 2019-02-05T20:09:47 *** mn949588 has quit IRC
317 2019-02-05T20:14:23 *** EagleTM has quit IRC
318 2019-02-05T20:15:34 *** Krellan has joined #bitcoin-core-dev
319 2019-02-05T20:25:04 *** Murch has quit IRC
320 2019-02-05T20:26:31 *** Murch has joined #bitcoin-core-dev
321 2019-02-05T20:28:53 *** promag has joined #bitcoin-core-dev
322 2019-02-05T20:29:49 *** promag_ has joined #bitcoin-core-dev
323 2019-02-05T20:31:10 *** jarthur_ has joined #bitcoin-core-dev
324 2019-02-05T20:31:46 *** Krellan_ has joined #bitcoin-core-dev
325 2019-02-05T20:32:27 *** Murch has quit IRC
326 2019-02-05T20:33:06 *** promag has quit IRC
327 2019-02-05T20:33:39 *** michaelsdunn1 has quit IRC
328 2019-02-05T20:34:08 *** jarthur has quit IRC
329 2019-02-05T20:34:16 *** Krellan has quit IRC
330 2019-02-05T20:34:30 *** tryphe_ is now known as tryphe
331 2019-02-05T20:37:29 *** michaelsdunn1 has joined #bitcoin-core-dev
332 2019-02-05T20:38:01 *** hebasto has quit IRC
333 2019-02-05T20:38:05 *** Murch has joined #bitcoin-core-dev
334 2019-02-05T20:39:49 *** EagleTM has joined #bitcoin-core-dev
335 2019-02-05T20:41:21 *** michaelsdunn1 has quit IRC
336 2019-02-05T20:44:39 *** michaelsdunn1 has joined #bitcoin-core-dev
337 2019-02-05T20:46:15 *** Murch has quit IRC
338 2019-02-05T20:51:37 *** skyikot has joined #bitcoin-core-dev
339 2019-02-05T20:54:56 *** dqx has quit IRC
340 2019-02-05T20:56:06 *** dqx has joined #bitcoin-core-dev
341 2019-02-05T20:56:09 *** lnostdal has quit IRC
342 2019-02-05T20:57:24 *** skyikot has quit IRC
343 2019-02-05T20:59:01 *** Guyver2 has quit IRC
344 2019-02-05T21:01:10 *** StopAndDecrypt has quit IRC
345 2019-02-05T21:05:57 *** phwalkr has quit IRC
346 2019-02-05T21:06:10 *** StopAndDecrypt has joined #bitcoin-core-dev
347 2019-02-05T21:06:19 *** StopAndDecrypt has quit IRC
348 2019-02-05T21:06:19 *** StopAndDecrypt has joined #bitcoin-core-dev
349 2019-02-05T21:07:03 *** dqx has quit IRC
350 2019-02-05T21:08:15 *** dqx has joined #bitcoin-core-dev
351 2019-02-05T21:11:50 *** bitcoin-git has joined #bitcoin-core-dev
352 2019-02-05T21:11:51 <bitcoin-git> [bitcoin] MeshCollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3a573fd46c75...30e799a5f705
353 2019-02-05T21:11:52 <bitcoin-git> bitcoin/master 8602a1e João Barbosa: wallet: Close dbenv error file db.log
354 2019-02-05T21:11:53 <bitcoin-git> bitcoin/master 2f8b8f4 João Barbosa: wallet: Close wallet env lock file
355 2019-02-05T21:11:54 <bitcoin-git> bitcoin/master d3bf3b9 João Barbosa: qa: Test .walletlock file is closed
356 2019-02-05T21:11:55 *** bitcoin-git has left #bitcoin-core-dev
357 2019-02-05T21:12:38 *** bitcoin-git has joined #bitcoin-core-dev
358 2019-02-05T21:12:38 <bitcoin-git> [bitcoin] MeshCollider merged pull request #15297: wallet: Releases dangling files on BerkeleyEnvironment::Close (master...2019-01-close-dbenv-files) https://github.com/bitcoin/bitcoin/pull/15297
359 2019-02-05T21:12:48 *** bitcoin-git has left #bitcoin-core-dev
360 2019-02-05T21:13:15 *** EagleTM has quit IRC
361 2019-02-05T21:14:22 *** dviola has joined #bitcoin-core-dev
362 2019-02-05T21:15:40 *** Aaronvan_ has joined #bitcoin-core-dev
363 2019-02-05T21:19:03 *** dviola has quit IRC
364 2019-02-05T21:19:14 *** AaronvanW has quit IRC
365 2019-02-05T21:19:46 *** dviola has joined #bitcoin-core-dev
366 2019-02-05T21:24:10 *** Murch has joined #bitcoin-core-dev
367 2019-02-05T21:32:26 *** EagleTM has joined #bitcoin-core-dev
368 2019-02-05T21:36:04 <promag_> sdaftuar: found the problem
369 2019-02-05T21:36:11 *** promag_ is now known as promag
370 2019-02-05T21:36:15 *** lnostdal has joined #bitcoin-core-dev
371 2019-02-05T21:36:23 <sdaftuar> promag: great! what is the issue?
372 2019-02-05T21:36:40 <promag> as usual (?) code is right
373 2019-02-05T21:37:07 <promag> so the issue is in wait_for_rpc_connection
374 2019-02-05T21:37:48 <promag> when using --usecli the TestNode still establishes a RPC connection
375 2019-02-05T21:37:57 <promag> to see if the RPC interface is ready
376 2019-02-05T21:38:06 <promag> however that connection is persistent by default
377 2019-02-05T21:38:56 <sdaftuar> so the issue is that the python tests aren't properly closing the connection, when using --usecli?
378 2019-02-05T21:39:40 <promag> in other words, if the daemon has 2 persistent connections, and 1 sends stop, the server (at the moment) won't force disconnect the other, it will timeout
379 2019-02-05T21:39:45 <promag> yes
380 2019-02-05T21:39:49 <sdaftuar> what's the mechanism for that to work when we're not using --usecli?
381 2019-02-05T21:40:26 <sdaftuar> oh the daemon will initiate the close?
382 2019-02-05T21:41:56 *** jarthur_ has quit IRC
383 2019-02-05T21:42:02 <promag> when not using --usecli the rpc connection will receive the header Connection: close, because the server is shutting down
384 2019-02-05T21:42:12 *** bitcoin-git has joined #bitcoin-core-dev
385 2019-02-05T21:42:12 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30e799a5f705...9b63c436a699
386 2019-02-05T21:42:12 <bitcoin-git> bitcoin/master 364cff1 Chris Moore: Fix issue #9683 "gui, wallet: random abort (segmentation fault) running ma...
387 2019-02-05T21:42:12 <sdaftuar> ok i think i sort of understand
388 2019-02-05T21:42:13 <bitcoin-git> bitcoin/master 9b63c43 MarcoFalke: Merge #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fau...
389 2019-02-05T21:42:13 <promag> but if the connection is idle then no header is sent
390 2019-02-05T21:42:14 *** bitcoin-git has left #bitcoin-core-dev
391 2019-02-05T21:42:41 <sdaftuar> i did notice that my test in #15305 seems very slow -- the issue there is that i'm constructing a scenario where bitcoind AbortNode()'s
392 2019-02-05T21:42:42 <gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
393 2019-02-05T21:42:46 *** bitcoin-git has joined #bitcoin-core-dev
394 2019-02-05T21:42:46 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) (master...fix-startup-crash) https://github.com/bitcoin/bitcoin/pull/15203
395 2019-02-05T21:42:46 <sdaftuar> and the http server is slow to shut down
396 2019-02-05T21:42:47 *** bitcoin-git has left #bitcoin-core-dev
397 2019-02-05T21:42:48 <promag> one way to fix this is to send the close header if --usecli
398 2019-02-05T21:43:05 *** jarthur has joined #bitcoin-core-dev
399 2019-02-05T21:43:29 <promag> however I'm still curious of what should be the correct behavior of stop
400 2019-02-05T21:43:43 *** jarthur has joined #bitcoin-core-dev
401 2019-02-05T21:43:43 <promag> stop command should force close everything?
402 2019-02-05T21:43:54 <sdaftuar> yeah i don't know, i haven't given this much though
403 2019-02-05T21:43:56 <sdaftuar> thought*
404 2019-02-05T21:44:27 <promag> anyway I'll see if I can fix this with the above idea
405 2019-02-05T21:44:58 <sdaftuar> ok thanks for working on this, hopefully others more knowledgeable about the design here can chime in with suggestions
406 2019-02-05T21:45:37 <promag> well maybe wait_for_rpc_connection should also --usecli
407 2019-02-05T21:45:46 <promag> jnewbery: ^
408 2019-02-05T21:46:50 <promag> bbl with a pr, sorry for the inconvenient
409 2019-02-05T21:48:37 *** ExtraCrispy has quit IRC
410 2019-02-05T21:49:40 *** promag has quit IRC
411 2019-02-05T22:00:06 *** esotericnonsense has quit IRC
412 2019-02-05T22:03:15 *** esotericnonsense has joined #bitcoin-core-dev
413 2019-02-05T22:06:28 *** jarthur has quit IRC
414 2019-02-05T22:07:02 *** spinza has quit IRC
415 2019-02-05T22:17:30 *** bitcoin-git has joined #bitcoin-core-dev
416 2019-02-05T22:17:31 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b63c436a699...9e7f8f6c8271
417 2019-02-05T22:17:31 <bitcoin-git> bitcoin/master ef0b012 practicalswift: tests: Make updatecoins_simulation_test deterministic
418 2019-02-05T22:17:32 <bitcoin-git> bitcoin/master 9e7f8f6 MarcoFalke: Merge #15327: tests: Make test updatecoins_simulation_test deterministic
419 2019-02-05T22:17:35 *** bitcoin-git has left #bitcoin-core-dev
420 2019-02-05T22:18:10 *** bitcoin-git has joined #bitcoin-core-dev
421 2019-02-05T22:18:11 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15327: tests: Make test updatecoins_simulation_test deterministic (master...SeedInsecureRand(true);) https://github.com/bitcoin/bitcoin/pull/15327
422 2019-02-05T22:18:12 *** bitcoin-git has left #bitcoin-core-dev
423 2019-02-05T22:21:34 *** bitcoin-git has joined #bitcoin-core-dev
424 2019-02-05T22:21:34 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e7f8f6c8271...baf125b31d0b
425 2019-02-05T22:21:35 <bitcoin-git> bitcoin/master 4701239 Amiti Uttarwar: [Docs] Small updates to getrawtransaction description
426 2019-02-05T22:21:35 <bitcoin-git> bitcoin/master baf125b MarcoFalke: Merge #15332: [Docs] Small updates to getrawtransaction description
427 2019-02-05T22:21:37 *** bitcoin-git has left #bitcoin-core-dev
428 2019-02-05T22:22:19 *** bitcoin-git has joined #bitcoin-core-dev
429 2019-02-05T22:22:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15332: [Docs] Small updates to getrawtransaction description (master...get_transaction_docs) https://github.com/bitcoin/bitcoin/pull/15332
430 2019-02-05T22:22:23 *** bitcoin-git has left #bitcoin-core-dev
431 2019-02-05T22:22:42 *** pinheadmz has quit IRC
432 2019-02-05T22:24:09 *** kexkey has quit IRC
433 2019-02-05T22:26:37 *** spinza has joined #bitcoin-core-dev
434 2019-02-05T22:29:25 *** promag has joined #bitcoin-core-dev
435 2019-02-05T22:30:25 *** michaelsdunn1 has quit IRC
436 2019-02-05T22:38:37 *** Murch has quit IRC
437 2019-02-05T22:39:59 *** Murch has joined #bitcoin-core-dev
438 2019-02-05T22:43:18 *** bitcoin-git has joined #bitcoin-core-dev
439 2019-02-05T22:43:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/baf125b31d0b...5029e94f855c
440 2019-02-05T22:43:19 <bitcoin-git> bitcoin/master 58180b5 James O'Beirne: tests: add utility to easily profile node performance with perf
441 2019-02-05T22:43:20 <bitcoin-git> bitcoin/master 13782b8 James O'Beirne: docs: add perf section to developer docs
442 2019-02-05T22:43:21 <bitcoin-git> bitcoin/master 5029e94 MarcoFalke: Merge #14519: tests: add utility to easily profile node performance with p...
443 2019-02-05T22:43:22 *** bitcoin-git has left #bitcoin-core-dev
444 2019-02-05T22:43:46 *** bitcoin-git has joined #bitcoin-core-dev
445 2019-02-05T22:43:47 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14519: tests: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519
446 2019-02-05T22:43:52 *** bitcoin-git has left #bitcoin-core-dev
447 2019-02-05T22:45:28 *** Skirmant has joined #bitcoin-core-dev
448 2019-02-05T22:47:13 *** EagleTM has quit IRC
449 2019-02-05T22:51:18 *** dqx has quit IRC
450 2019-02-05T23:00:48 *** Murch has quit IRC
451 2019-02-05T23:04:59 *** pinheadmz has joined #bitcoin-core-dev
452 2019-02-05T23:05:24 *** IGHOR has quit IRC
453 2019-02-05T23:07:16 *** IGHOR has joined #bitcoin-core-dev
454 2019-02-05T23:07:41 *** dqx has joined #bitcoin-core-dev
455 2019-02-05T23:08:20 *** Murch has joined #bitcoin-core-dev
456 2019-02-05T23:08:34 *** twistedline has quit IRC
457 2019-02-05T23:17:10 <gleb> It's confusing that we do not log "AcceptToMemoryPool" upon accepting orphan transactions (when receive a valid parent)
458 2019-02-05T23:17:28 <jnewbery> promag: I'm not sure without digging into it. Feel free to @ me on the PR
459 2019-02-05T23:17:46 <gleb> We do it for a parent, but not for an not-orphan-anymore child...
460 2019-02-05T23:23:20 *** bitcoin-git has joined #bitcoin-core-dev
461 2019-02-05T23:23:20 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349
462 2019-02-05T23:23:23 *** bitcoin-git has left #bitcoin-core-dev
463 2019-02-05T23:23:32 <gmaxwell> gleb: weird. patch accepted?
464 2019-02-05T23:23:49 *** DeanGuss has quit IRC
465 2019-02-05T23:25:48 <gleb> gmaxwell: Sorry not sure what you're asking, are you suggesting me to fix it?
466 2019-02-05T23:54:02 <gmaxwell> gleb: yes, I agree it's weird that we don't log. it also should be a trivial change to add a log entry for it.
467 2019-02-05T23:54:12 <gmaxwell> So I'm suggesting you go add it. :)