12019-02-14T00:05:22  *** Murch has joined #bitcoin-core-dev
  22019-02-14T00:05:39  *** michaels_ has joined #bitcoin-core-dev
  32019-02-14T00:07:26  *** Aaronva__ is now known as AaronvanW
  42019-02-14T00:10:32  *** michaels_ has quit IRC
  52019-02-14T00:25:28  *** Karyon has quit IRC
  62019-02-14T00:34:08  *** promag has quit IRC
  72019-02-14T00:34:46  *** promag has joined #bitcoin-core-dev
  82019-02-14T00:39:45  *** Murch has quit IRC
  92019-02-14T00:45:10  *** michaels_ has joined #bitcoin-core-dev
 102019-02-14T00:46:50  *** skyikot has joined #bitcoin-core-dev
 112019-02-14T00:50:24  *** michaels_ has quit IRC
 122019-02-14T00:52:42  *** jarthur has quit IRC
 132019-02-14T01:11:06  *** elichai2 has quit IRC
 142019-02-14T01:11:24  *** profmac has quit IRC
 152019-02-14T01:11:26  *** pinheadmz has quit IRC
 162019-02-14T01:14:05  <gwillen> do I need to get more people to look at #14978
 172019-02-14T01:14:09  <gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
 182019-02-14T01:14:15  <gwillen> it feels like it is almost there :-)
 192019-02-14T01:18:40  *** michaels_ has joined #bitcoin-core-dev
 202019-02-14T01:19:37  *** spinza has quit IRC
 212019-02-14T01:24:02  *** michaels_ has quit IRC
 222019-02-14T01:27:20  *** bitcoin-git has joined #bitcoin-core-dev
 232019-02-14T01:27:20  <bitcoin-git> [bitcoin] sipa opened pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
 242019-02-14T01:27:21  *** bitcoin-git has left #bitcoin-core-dev
 252019-02-14T01:29:04  *** spinza has joined #bitcoin-core-dev
 262019-02-14T01:30:57  *** StopAndDecrypt has joined #bitcoin-core-dev
 272019-02-14T01:32:20  <sipa> gmaxwell, wumpus: ^
 282019-02-14T01:32:31  <sipa> infinite depth invalidateblock
 292019-02-14T01:38:23  *** michaels_ has joined #bitcoin-core-dev
 302019-02-14T01:39:37  <gmaxwell> rewinding irrelevancy is also because the rewind is slow...
 312019-02-14T01:39:47  <gmaxwell> might even be faster to reindex now
 322019-02-14T01:40:09  *** ExtraCrispy has quit IRC
 332019-02-14T01:41:02  <sipa> it very likely is
 342019-02-14T01:41:14  *** promag has quit IRC
 352019-02-14T01:42:56  *** michaels_ has quit IRC
 362019-02-14T01:43:28  *** ExtraCrispy has joined #bitcoin-core-dev
 372019-02-14T01:50:44  *** profmac has joined #bitcoin-core-dev
 382019-02-14T02:04:56  *** AaronvanW has quit IRC
 392019-02-14T02:12:18  *** pinheadmz has joined #bitcoin-core-dev
 402019-02-14T02:14:09  *** skyikot has quit IRC
 412019-02-14T02:21:18  <meshcollider> gwillen: I agree, it'd be good to get a post-rebase re-ACK from someone though
 422019-02-14T02:21:34  <meshcollider> Or a review from ryanofsky who had commented on it a few times
 432019-02-14T02:34:24  *** drexl has quit IRC
 442019-02-14T02:45:53  *** ExtraCrispy has quit IRC
 452019-02-14T03:02:50  *** TX1683 has quit IRC
 462019-02-14T03:09:15  *** TX1683 has joined #bitcoin-core-dev
 472019-02-14T03:50:01  *** rh0nj has quit IRC
 482019-02-14T03:51:08  *** rh0nj has joined #bitcoin-core-dev
 492019-02-14T03:54:27  *** DeanGuss has quit IRC
 502019-02-14T03:55:25  <gwillen> thanks achow101 :-)
 512019-02-14T04:07:46  *** DeanGuss has joined #bitcoin-core-dev
 522019-02-14T04:37:45  *** pinheadmz has quit IRC
 532019-02-14T04:40:16  *** pinheadmz has joined #bitcoin-core-dev
 542019-02-14T04:41:32  *** pinheadmz has quit IRC
 552019-02-14T04:42:40  *** jtimon has quit IRC
 562019-02-14T04:52:50  *** DeanGuss has quit IRC
 572019-02-14T04:53:07  *** DeanGuss has joined #bitcoin-core-dev
 582019-02-14T05:08:07  *** DeanGuss has quit IRC
 592019-02-14T05:15:50  *** skyikot has joined #bitcoin-core-dev
 602019-02-14T05:18:56  *** bitcoin-git has joined #bitcoin-core-dev
 612019-02-14T05:18:57  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15404: [test] Remove -txindex to start nodes (master...remove_txindex) https://github.com/bitcoin/bitcoin/pull/15404
 622019-02-14T05:19:05  *** bitcoin-git has left #bitcoin-core-dev
 632019-02-14T05:41:00  *** pinheadmz has joined #bitcoin-core-dev
 642019-02-14T05:44:34  *** yoyo_ has joined #bitcoin-core-dev
 652019-02-14T05:50:06  *** bralyclow has joined #bitcoin-core-dev
 662019-02-14T05:53:23  *** bralyclo_ has quit IRC
 672019-02-14T05:56:46  *** pinheadmz has quit IRC
 682019-02-14T06:29:05  *** zhangzf has joined #bitcoin-core-dev
 692019-02-14T06:44:41  *** DeanGuss has joined #bitcoin-core-dev
 702019-02-14T06:51:53  * kallewoof wonders why appveyor is failing on master
 712019-02-14T06:54:40  *** rhavar has joined #bitcoin-core-dev
 722019-02-14T06:54:46  * sipa also
 732019-02-14T06:55:00  <sipa> something something leveldb linket error
 742019-02-14T07:02:41  *** anonymous8587 has joined #bitcoin-core-dev
 752019-02-14T07:04:12  *** anonymous8587_ has joined #bitcoin-core-dev
 762019-02-14T07:04:13  *** anonymous8587 has quit IRC
 772019-02-14T07:06:21  *** anonymous8587_ has quit IRC
 782019-02-14T07:06:40  *** anonymous8587 has joined #bitcoin-core-dev
 792019-02-14T07:08:18  *** pinheadmz has joined #bitcoin-core-dev
 802019-02-14T07:09:07  *** anonymous8587 has quit IRC
 812019-02-14T07:09:29  *** ap4lmtree has quit IRC
 822019-02-14T07:09:56  *** ap4lmtree has joined #bitcoin-core-dev
 832019-02-14T07:29:41  <kallewoof> yeah. i can't see the reason why that would start happening though. the latest merged commits seem to have passed.
 842019-02-14T07:38:24  *** ap4lmtree- has joined #bitcoin-core-dev
 852019-02-14T07:38:48  *** ap4lmtree has quit IRC
 862019-02-14T07:51:22  <wumpus> sipa: neat!
 872019-02-14T07:55:51  *** skyikot has quit IRC
 882019-02-14T07:57:51  *** anonymous8587 has joined #bitcoin-core-dev
 892019-02-14T08:00:10  *** anonymous8587 has quit IRC
 902019-02-14T08:42:08  *** Guyver2 has joined #bitcoin-core-dev
 912019-02-14T08:43:13  <provoostenator> That may have my fault :-)
 922019-02-14T08:43:43  <provoostenator> I think AppVeyor works sequentally and I've had to restart it a few times and tried to bust the cache for my PR.
 932019-02-14T08:44:12  <provoostenator> I think busting the cache may worked, because this error is also why I get on AppVeyor on my own repo against master.
 942019-02-14T08:44:38  <provoostenator> "bitcoin-wallet.exe : fatal error LNK1120: 14 unresolved externals"
 952019-02-14T08:48:59  <provoostenator> In #15382 I added "C:\tools\vcpkg\installed -> appveyor.yml" to .appveyor.yml to bust the package cache whenever that file is modified.
 962019-02-14T08:49:01  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
 972019-02-14T08:49:27  *** bitcoin-git has joined #bitcoin-core-dev
 982019-02-14T08:49:28  <bitcoin-git> [bitcoin] MeshCollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9c93f5d9fc93...2452c6cc0a23
 992019-02-14T08:49:29  <bitcoin-git> bitcoin/master 162ffef Glenn Willen: Add pf_invalid arg to std::string DecodeBase{32,64}
1002019-02-14T08:49:29  <bitcoin-git> bitcoin/master c734aaa Glenn Willen: Split DecodePSBT into Base64 and Raw versions
1012019-02-14T08:49:31  <bitcoin-git> bitcoin/master 81cd958 Glenn Willen: Factor BroadcastTransaction out of sendrawtransaction
1022019-02-14T08:49:33  *** bitcoin-git has left #bitcoin-core-dev
1032019-02-14T08:50:00  *** bitcoin-git has joined #bitcoin-core-dev
1042019-02-14T08:50:00  <bitcoin-git> [bitcoin] MeshCollider merged pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
1052019-02-14T08:50:01  *** bitcoin-git has left #bitcoin-core-dev
1062019-02-14T08:50:40  <provoostenator> ^ watching my rebase hell slowly come to an end, thanks MeshCollider :-)
1072019-02-14T08:51:07  <meshcollider> \o/
1082019-02-14T08:51:11  <meshcollider> we are nearly there yep
1092019-02-14T08:52:41  <meshcollider> just #14021 and #14075 to go
1102019-02-14T08:52:44  <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
1112019-02-14T08:52:47  <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
1122019-02-14T08:54:38  *** pinheadmz has quit IRC
1132019-02-14T08:58:02  <provoostenator> I'll try rebasing #15388 and see if that magically fixes AppVeyor. If not, someone who actually understands it should take a look...
1142019-02-14T08:58:04  <gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
1152019-02-14T09:05:25  *** setpill has joined #bitcoin-core-dev
1162019-02-14T09:07:18  *** jungly has joined #bitcoin-core-dev
1172019-02-14T09:39:57  *** timothy has joined #bitcoin-core-dev
1182019-02-14T09:44:00  *** a5m0 has quit IRC
1192019-02-14T09:46:20  *** a5m0 has joined #bitcoin-core-dev
1202019-02-14T09:48:30  *** rex4539 has quit IRC
1212019-02-14T10:16:31  *** bitcoin-git has joined #bitcoin-core-dev
1222019-02-14T10:16:31  <bitcoin-git> [bitcoin] Sjors opened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
1232019-02-14T10:16:35  *** bitcoin-git has left #bitcoin-core-dev
1242019-02-14T10:24:15  *** rhavar has quit IRC
1252019-02-14T10:28:18  *** drexl has joined #bitcoin-core-dev
1262019-02-14T10:29:32  *** thedevworks has joined #bitcoin-core-dev
1272019-02-14T10:30:58  *** thedevworks has quit IRC
1282019-02-14T10:31:20  *** thedevworks has joined #bitcoin-core-dev
1292019-02-14T10:32:20  <meshcollider> sipa: would you happen to have a little time to review #14021
1302019-02-14T10:32:22  <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
1312019-02-14T10:39:42  *** rex4539 has joined #bitcoin-core-dev
1322019-02-14T10:40:51  <provoostenator> Update: I have no idea how to make the AppVeyor errors on master go away. There's probably some extra configuration needed for bitcoin-wallet, but #15388 doesn't do the trick.
1332019-02-14T10:40:53  <gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
1342019-02-14T10:45:36  *** siom_ has joined #bitcoin-core-dev
1352019-02-14T10:47:04  *** elichai2 has joined #bitcoin-core-dev
1362019-02-14T10:56:04  *** spinza has quit IRC
1372019-02-14T10:58:16  *** Guyver2 has quit IRC
1382019-02-14T10:59:00  *** bitcoin-git has joined #bitcoin-core-dev
1392019-02-14T10:59:00  <bitcoin-git> [bitcoin] marcuswin opened pull request #15406: Update links (master...master) https://github.com/bitcoin/bitcoin/pull/15406
1402019-02-14T10:59:12  *** bitcoin-git has left #bitcoin-core-dev
1412019-02-14T11:09:41  *** spinza has joined #bitcoin-core-dev
1422019-02-14T11:11:24  *** Karyon has joined #bitcoin-core-dev
1432019-02-14T11:16:10  *** AaronvanW has joined #bitcoin-core-dev
1442019-02-14T11:17:06  *** zhangzf has quit IRC
1452019-02-14T11:31:47  *** ovovo has quit IRC
1462019-02-14T11:31:56  *** owowo has joined #bitcoin-core-dev
1472019-02-14T11:31:57  *** owowo has joined #bitcoin-core-dev
1482019-02-14T11:37:59  *** CubicEarth has joined #bitcoin-core-dev
1492019-02-14T11:42:48  *** thedevworks has quit IRC
1502019-02-14T11:52:01  *** rh0nj has quit IRC
1512019-02-14T11:53:09  *** rh0nj has joined #bitcoin-core-dev
1522019-02-14T12:12:30  *** bitcoin-git has joined #bitcoin-core-dev
1532019-02-14T12:12:30  <bitcoin-git> [bitcoin] ken2812221 opened pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
1542019-02-14T12:12:32  *** bitcoin-git has left #bitcoin-core-dev
1552019-02-14T12:19:27  *** Karyon has quit IRC
1562019-02-14T12:25:11  <provoostenator> I cancelled some ongoing AppVeyor builds to make room for ^
1572019-02-14T12:25:19  *** rex4539 has quit IRC
1582019-02-14T12:31:52  *** Karyon has joined #bitcoin-core-dev
1592019-02-14T12:47:00  *** zhangzf has joined #bitcoin-core-dev
1602019-02-14T12:54:04  *** thedevworks has joined #bitcoin-core-dev
1612019-02-14T13:05:41  *** elichai2 has quit IRC
1622019-02-14T13:35:39  *** indistylo has joined #bitcoin-core-dev
1632019-02-14T13:40:42  *** jimmysong_ has joined #bitcoin-core-dev
1642019-02-14T13:44:24  *** jimmysong has quit IRC
1652019-02-14T13:45:17  *** bitcoin-git has joined #bitcoin-core-dev
1662019-02-14T13:45:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2452c6cc0a23...38989ab03fb7
1672019-02-14T13:45:18  <bitcoin-git> bitcoin/master 8c3fdd3 marcoagner: fixes m_assumed_blockchain_size variables values:
1682019-02-14T13:45:19  <bitcoin-git> bitcoin/master 38989ab MarcoFalke: Merge #15183: [Qt]: fixes m_assumed_blockchain_size variable value
1692019-02-14T13:45:22  *** bitcoin-git has left #bitcoin-core-dev
1702019-02-14T13:45:29  <luke-jr> hm, someone had a good idea: if nodes store their own UTXO hashes, they can safely recover from other nodes if something gets corrupt rather than a re-IBD
1712019-02-14T13:45:56  *** bralyclo_ has joined #bitcoin-core-dev
1722019-02-14T13:45:59  *** bitcoin-git has joined #bitcoin-core-dev
1732019-02-14T13:46:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183
1742019-02-14T13:46:00  *** bitcoin-git has left #bitcoin-core-dev
1752019-02-14T13:46:02  <luke-jr> although it's a lot of data to download before you know if the other peer is being malicious or not
1762019-02-14T13:49:32  *** bralyclow has quit IRC
1772019-02-14T13:50:14  * luke-jr adds it to https://github.com/bitcoin/bitcoin/issues/8037#issuecomment-463633344
1782019-02-14T13:52:22  *** zhangzf has quit IRC
1792019-02-14T13:53:28  *** zhangzf has joined #bitcoin-core-dev
1802019-02-14T13:55:13  *** promag has joined #bitcoin-core-dev
1812019-02-14T13:59:31  *** bitcoin-git has joined #bitcoin-core-dev
1822019-02-14T13:59:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38989ab03fb7...e3b1c7a9d6ae
1832019-02-14T13:59:31  <bitcoin-git> bitcoin/master 3c6ef03 Chun Kuan Lee: msvc: Fix silent merge conflict between #13926 and #14372 part II
1842019-02-14T13:59:32  <bitcoin-git> bitcoin/master e3b1c7a MarcoFalke: Merge #15407: msvc: Fix silent merge conflict between #13926 and #14372 pa...
1852019-02-14T13:59:33  *** bitcoin-git has left #bitcoin-core-dev
1862019-02-14T14:00:14  *** promag has quit IRC
1872019-02-14T14:00:16  *** bitcoin-git has joined #bitcoin-core-dev
1882019-02-14T14:00:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
1892019-02-14T14:00:19  *** bitcoin-git has left #bitcoin-core-dev
1902019-02-14T14:05:51  *** bitcoin-git has joined #bitcoin-core-dev
1912019-02-14T14:05:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
1922019-02-14T14:06:03  *** bitcoin-git has left #bitcoin-core-dev
1932019-02-14T14:06:22  *** bitcoin-git has joined #bitcoin-core-dev
1942019-02-14T14:06:22  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
1952019-02-14T14:06:23  *** bitcoin-git has left #bitcoin-core-dev
1962019-02-14T14:30:33  *** Karyon has quit IRC
1972019-02-14T14:34:13  *** Karyon has joined #bitcoin-core-dev
1982019-02-14T14:34:48  *** zhangzf has quit IRC
1992019-02-14T14:39:59  *** promag has joined #bitcoin-core-dev
2002019-02-14T14:41:43  *** rhavar has joined #bitcoin-core-dev
2012019-02-14T14:47:01  *** jtimon has joined #bitcoin-core-dev
2022019-02-14T14:51:34  *** dviola has joined #bitcoin-core-dev
2032019-02-14T14:55:26  *** bitcoin-git has joined #bitcoin-core-dev
2042019-02-14T14:55:26  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15408: Remove unused TransactionError constants (master...Mf1902-TransactionErrorConst) https://github.com/bitcoin/bitcoin/pull/15408
2052019-02-14T14:55:27  *** bitcoin-git has left #bitcoin-core-dev
2062019-02-14T14:59:44  *** ap4lmtree has joined #bitcoin-core-dev
2072019-02-14T15:08:07  *** promag has quit IRC
2082019-02-14T15:16:38  *** thedevworks_ has joined #bitcoin-core-dev
2092019-02-14T15:18:57  *** thedevworks has quit IRC
2102019-02-14T15:19:53  *** ArdeshirV has joined #bitcoin-core-dev
2112019-02-14T15:20:48  *** luke-jr has quit IRC
2122019-02-14T15:21:20  *** luke-jr has joined #bitcoin-core-dev
2132019-02-14T15:27:16  *** pinheadmz has joined #bitcoin-core-dev
2142019-02-14T15:29:18  *** ArdeshirV has quit IRC
2152019-02-14T15:32:05  *** Karyon has quit IRC
2162019-02-14T15:33:11  *** indistylo has quit IRC
2172019-02-14T15:34:44  *** bitcoin-git has joined #bitcoin-core-dev
2182019-02-14T15:34:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b1c7a9d6ae...9b1df4ba0bec
2192019-02-14T15:34:44  <bitcoin-git> bitcoin/master 4a43eb8 Sjors Provoost: [build] Makefile.am: add rule for src/bitcoin-wallet
2202019-02-14T15:34:45  <bitcoin-git> bitcoin/master 9b1df4b MarcoFalke: Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet
2212019-02-14T15:34:46  *** bitcoin-git has left #bitcoin-core-dev
2222019-02-14T15:35:31  *** bitcoin-git has joined #bitcoin-core-dev
2232019-02-14T15:35:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
2242019-02-14T15:35:37  *** bitcoin-git has left #bitcoin-core-dev
2252019-02-14T15:37:39  *** setpill has quit IRC
2262019-02-14T15:42:38  *** Karyon has joined #bitcoin-core-dev
2272019-02-14T15:44:07  *** thedevworks_ has quit IRC
2282019-02-14T15:52:26  *** bralyclo_ has quit IRC
2292019-02-14T16:10:37  *** pinheadmz has quit IRC
2302019-02-14T16:30:00  *** ZaiRoX has joined #bitcoin-core-dev
2312019-02-14T16:37:31  *** Karyon has quit IRC
2322019-02-14T16:51:57  *** pinheadmz has joined #bitcoin-core-dev
2332019-02-14T16:52:00  *** mmgen has joined #bitcoin-core-dev
2342019-02-14T16:59:39  *** ap4lmtree- is now known as ap4lmtree
2352019-02-14T17:02:48  *** spinza has quit IRC
2362019-02-14T17:03:10  *** Murch has joined #bitcoin-core-dev
2372019-02-14T17:07:15  *** jarthur has joined #bitcoin-core-dev
2382019-02-14T17:17:19  *** Guyver2 has joined #bitcoin-core-dev
2392019-02-14T17:32:12  *** rex4539 has joined #bitcoin-core-dev
2402019-02-14T17:33:40  *** Karyon has joined #bitcoin-core-dev
2412019-02-14T17:37:08  *** spinza has joined #bitcoin-core-dev
2422019-02-14T17:40:30  *** justanotheruser has quit IRC
2432019-02-14T17:42:40  *** siom_ has quit IRC
2442019-02-14T17:46:21  *** JackH has quit IRC
2452019-02-14T17:47:30  <sipa> meshcollider: wil do
2462019-02-14T17:47:47  *** jungly has quit IRC
2472019-02-14T18:04:59  *** phwalkr has joined #bitcoin-core-dev
2482019-02-14T18:09:57  *** promag has joined #bitcoin-core-dev
2492019-02-14T18:19:40  *** jonasschnelli_ has quit IRC
2502019-02-14T18:19:40  *** jonasschnelli_ has joined #bitcoin-core-dev
2512019-02-14T18:19:53  *** jonasschnelli_ is now known as jonasschnelli
2522019-02-14T18:20:28  *** Karyon has quit IRC
2532019-02-14T18:26:03  *** Karyon has joined #bitcoin-core-dev
2542019-02-14T18:27:06  *** mistergold has joined #bitcoin-core-dev
2552019-02-14T18:30:16  *** ap4lmtree has quit IRC
2562019-02-14T18:40:59  *** ap4lmtree has joined #bitcoin-core-dev
2572019-02-14T18:42:23  *** fabianfabian has joined #bitcoin-core-dev
2582019-02-14T18:49:25  *** schmidty_ has quit IRC
2592019-02-14T18:55:31  *** schmidty has joined #bitcoin-core-dev
2602019-02-14T18:56:16  *** schmidty has joined #bitcoin-core-dev
2612019-02-14T18:58:59  <jonasschnelli> luke-jr: a hardlink copy seems more efficient since you don't depend on other nodes
2622019-02-14T19:00:22  <wumpus> #startmeeting
2632019-02-14T19:00:22  <lightningbot> Meeting started Thu Feb 14 19:00:22 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2642019-02-14T19:00:22  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2652019-02-14T19:00:27  <provoostenator> hi
2662019-02-14T19:00:29  <jamesob> hi
2672019-02-14T19:00:33  <instagibbs> hi
2682019-02-14T19:00:38  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
2692019-02-14T19:00:39  <moneyball> topic proposed by provoostenator: minimum QT version for v0.18, see #13478
2702019-02-14T19:00:41  <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
2712019-02-14T19:00:43  <promag> hi
2722019-02-14T19:00:45  <jonasschnelli> hi
2732019-02-14T19:00:50  <achow101> hi
2742019-02-14T19:01:14  <moneyball> happy valentine's day :)
2752019-02-14T19:01:20  <luke-jr> St. Valentine's day*
2762019-02-14T19:01:22  <jamesob> <3
2772019-02-14T19:01:33  <provoostenator> Thanks! I spent it with AppVeyor mostly :-)
2782019-02-14T19:01:37  <luke-jr> lol
2792019-02-14T19:01:48  <jonasschnelli> heh
2802019-02-14T19:02:48  <wumpus> 💜
2812019-02-14T19:03:16  <luke-jr> Sjors pointed me to the issue when I asked what benefits there are, but I didn't see any there..
2822019-02-14T19:03:49  <luke-jr> I also don't see where/if anyone done a check for what versions come with current stable distros.
2832019-02-14T19:03:51  <wumpus> #topic 0.18 feature freeze
2842019-02-14T19:03:54  <phantomcircuit> hi
2852019-02-14T19:03:55  <phantomcircuit> luke-jr, happy halmark day
2862019-02-14T19:04:02  <provoostenator> luke-jr: the issue described the reasons for switching, but those reasons aren't benefits :-)
2872019-02-14T19:04:30  <sipa> will be there in 5-10 mi
2882019-02-14T19:04:32  <sipa> min
2892019-02-14T19:05:05  <wumpus> tomorrow (15th) is the 0.18 feature freeze
2902019-02-14T19:05:22  <wumpus> there's still quite a few PRs open on the 0.18 milestone https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0 though not all are features of course
2912019-02-14T19:06:54  <wumpus> but it'd definitely help to get some more review there
2922019-02-14T19:06:56  <gleb> hi
2932019-02-14T19:07:19  <phantomcircuit> luke-jr, generally 4/5 are available in parallel
2942019-02-14T19:08:00  <gmaxwell> hi
2952019-02-14T19:08:05  <luke-jr> phantomcircuit: ?
2962019-02-14T19:08:14  <phantomcircuit> luke-jr, qt
2972019-02-14T19:08:23  <phantomcircuit> debian at least i have both installed
2982019-02-14T19:08:27  <wumpus> still open features are #15195 for the GUI and a few RPC ones
2992019-02-14T19:08:29  <gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
3002019-02-14T19:08:30  <luke-jr> phantomcircuit: we already don't support Qt4
3012019-02-14T19:08:33  <wumpus> please, stick to the topic
3022019-02-14T19:08:39  <phantomcircuit> oh right
3032019-02-14T19:09:51  <wumpus> for RPC there's #14481 #14075 #14021 #13932 left that are really features
3042019-02-14T19:09:53  <gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
3052019-02-14T19:09:56  <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
3062019-02-14T19:09:58  <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
3072019-02-14T19:10:02  <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
3082019-02-14T19:10:04  <kanzure> hi.
3092019-02-14T19:10:29  <instagibbs> key origin import seems camera-ready if others want to look
3102019-02-14T19:10:49  *** VitorB has joined #bitcoin-core-dev
3112019-02-14T19:11:02  <achow101> 14021 is pretty close
3122019-02-14T19:11:18  <wumpus> good!
3132019-02-14T19:12:11  <promag> I'm waiting for some feedback on 15195
3142019-02-14T19:12:12  <wumpus> ah there's also #15368
3152019-02-14T19:12:14  <gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
3162019-02-14T19:12:48  <gmaxwell> luke-jr: do you have a 32-bit host with rdrand (modern intel/amd cpu running in 32bit mode)? would be nice to test #15250 on that. (doesn't block merge, I guess since it could be fixed before release if there were an issue)
3172019-02-14T19:12:49  <gribble> https://github.com/bitcoin/bitcoin/issues/15250 | Use RdSeed when available, and reduce RdRand load by sipa · Pull Request #15250 · bitcoin/bitcoin · GitHub
3182019-02-14T19:13:09  <wumpus> which already has some ACKs
3192019-02-14T19:13:26  <luke-jr> gmaxwell: my most recent x86 is Haswell, and it doesn't have a 32-bit chroot at the moment
3202019-02-14T19:13:46  <wumpus> gmaxwell: I consider the rdrand one a bugfix not a feature so it doesn't strictly need to be merged tomorrow
3212019-02-14T19:13:49  <gmaxwell> haswell is ducky and has both rdrand and rdseed IIRC.
3222019-02-14T19:14:09  <gmaxwell> (it certantly has rdrand)
3232019-02-14T19:14:24  <gmaxwell> wumpus: thanks, I agree.
3242019-02-14T19:14:45  <luke-jr> if our static binaries were actually portable, I could have probably tested with those, but.. :/
3252019-02-14T19:14:58  *** hebasto has joined #bitcoin-core-dev
3262019-02-14T19:15:03  <sipa> wumpus: would #15402 count as a bugfix?
3272019-02-14T19:15:05  <gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
3282019-02-14T19:15:16  <wumpus> sipa: I guess so
3292019-02-14T19:15:30  <wumpus> sipa: it fixes that out of memory issue on reorg right?
3302019-02-14T19:15:36  <gmaxwell> It should, it's a pretty serious bug.
3312019-02-14T19:15:39  <provoostenator> It fixes an OOM
3322019-02-14T19:15:45  <sipa> hmm, not reorg
3332019-02-14T19:16:00  <gmaxwell> wumpus: on rewind/replay
3342019-02-14T19:16:16  <wumpus> so I mean it fixes  #14289
3352019-02-14T19:16:18  <gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
3362019-02-14T19:16:21  <wumpus> so it's a fix
3372019-02-14T19:16:54  <wumpus> added 0.18 milestone
3382019-02-14T19:17:41  <jamesob> it doesn't fix the general issue of #14289, just one specific instance right?
3392019-02-14T19:17:42  <gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
3402019-02-14T19:17:50  <sipa> jamesob: indeed
3412019-02-14T19:18:25  <jamesob> intend on building in a SERIAL_SCHEDULER_EXECUTION flag (or something) for use in CI in the next couple days
3422019-02-14T19:18:29  <jamesob> (offtopic, sorry)
3432019-02-14T19:19:01  <wumpus> #topic minimum QT version for v0.18 (provoostenator)
3442019-02-14T19:19:02  <phantomcircuit> gmaxwell, that cant be checked in a vm?
3452019-02-14T19:19:20  <gmaxwell> phantomcircuit: absolutely can be
3462019-02-14T19:19:40  <luke-jr> [19:03:49] <luke-jr> I also don't see where/if anyone done a check for what versions come with current stable distros.
3472019-02-14T19:19:49  <luke-jr> I tried doing ^ myself, but I couldn't figure out what version RHEL 7 has
3482019-02-14T19:19:50  <provoostenator> I think we should either make Travis test older versions of QT or bump the min version.
3492019-02-14T19:19:54  <MarcoFalke> luke-jr: The benefit is that it is easier to just bump the minimum than to make it compile with 5.2
3502019-02-14T19:20:02  <provoostenator> Currently it doesn't even compile in 5.2
3512019-02-14T19:20:06  <MarcoFalke> ^
3522019-02-14T19:20:18  <wumpus> 5.2 is ancient anyway
3532019-02-14T19:20:22  <luke-jr> but who does this cut off?
3542019-02-14T19:20:31  <luke-jr> what version does RHEL 7 have?
3552019-02-14T19:20:34  <MarcoFalke> If someone wants to build on an acient system with an EOL qt, they are better off with depends
3562019-02-14T19:20:45  <provoostenator> As for stable distros: we can narrow that down to stable distros where the depends system doesn't work?
3572019-02-14T19:20:47  <luke-jr> RHEL 7 is current
3582019-02-14T19:20:48  <wumpus> didn't we have a discussion about this in a github issue?
3592019-02-14T19:20:57  <jonasschnelli> Yes
3602019-02-14T19:20:59  <luke-jr> provoostenator: depends should not be the norm
3612019-02-14T19:21:04  <MarcoFalke> luke-jr:  rhel7 can use depends
3622019-02-14T19:21:05  <wumpus> is there anything new to add to that or is this just another repeat of that?
3632019-02-14T19:21:13  <jonasschnelli> I think just updating Qt for the sake of updating seems pointless
3642019-02-14T19:21:15  <wumpus> this comes up too often
3652019-02-14T19:21:28  <jonasschnelli> What we need is advantages/disadvantage comparison
3662019-02-14T19:21:39  <luke-jr> updating is fine. cutting off people who reasonably have an old version isn't.
3672019-02-14T19:21:43  <meshcollider> Hi, sorry im late
3682019-02-14T19:21:43  <wumpus> jonasschnelli: he isn't updating qt, only changing the minimum requirement in the build system to the actual minimum requirement IIRC
3692019-02-14T19:22:08  <provoostenator> jonasschnelli: it's not for the sake of updating, it's because we're constantly breaking old versions.
3702019-02-14T19:22:08  <wumpus> it doesn't work with qt 5.2, no one is testing it with that, so it's kind of a moot point
3712019-02-14T19:22:15  <gmaxwell> Just pushing to new versions for the sake of updating is a bad pattern.  If there is a problem or a new feature, then great.  Matching minimums to the actual minimums is also good (excepting in cases where we should fix the minimum because we're cutting something out people are currently using)
3722019-02-14T19:22:24  <wumpus> no one is updating qt !
3732019-02-14T19:22:28  <jonasschnelli> I see. Sorry for the confusion.
3742019-02-14T19:22:29  <wumpus> this isn't the point of tha pr
3752019-02-14T19:23:08  <wumpus> #15393 bumps the minimum version checked by the bulid system
3762019-02-14T19:23:11  <gribble> https://github.com/bitcoin/bitcoin/issues/15393 | build: Bump minimum Qt version to 5.5.1 by Sjors · Pull Request #15393 · bitcoin/bitcoin · GitHub
3772019-02-14T19:23:16  <wumpus> to the version that we actually require already
3782019-02-14T19:23:23  <wumpus> the only difference is that configure will show an error now
3792019-02-14T19:23:25  <jonasschnelli> Qt 5.6 LTS ends in 2 months... :/
3802019-02-14T19:23:27  <wumpus> instead of failing later in the build
3812019-02-14T19:23:50  <jonasschnelli> Whatever minimal Qt support we set, we should make sure its ran in our CI
3822019-02-14T19:23:54  <luke-jr> can someone with a reasonable internet connection download CentOS 7 and find out what version it has? :x
3832019-02-14T19:24:00  <wumpus> jonasschnelli: yes
3842019-02-14T19:24:18  <jonasschnelli> I'm not sure if we should look to deep into all distros...
3852019-02-14T19:24:32  <MarcoFalke> luke-jr: It is 5.9?
3862019-02-14T19:24:34  <MarcoFalke> http://mirror.centos.org/centos/7/os/x86_64/Packages/qt5-qtbase-5.9.2-3.el7.x86_64.rpm
3872019-02-14T19:24:37  <jonasschnelli> If CentOS uses Qt5.3 which its support has probably been stopped 2 years ago, it's not a pattern to follow
3882019-02-14T19:24:42  <jonasschnelli> (assuming)
3892019-02-14T19:24:51  <luke-jr> MarcoFalke: not sure why I couldn't find that.. thanks
3902019-02-14T19:24:55  <sipa> luke-jr: is 5.9.2 possible? http://mirror.centos.org/centos/7/os/x86_64/Packages/
3912019-02-14T19:25:18  <jonasschnelli> make sense... 5.9 is the one where LTS is at least 1 year
3922019-02-14T19:25:28  <MarcoFalke> Is rhel7 using the same as centos7?
3932019-02-14T19:25:39  <luke-jr> MarcoFalke: CentOS is just a free-of-charge RHEL
3942019-02-14T19:25:47  <provoostenator> luke-jr: CentOS 7 seems to have QT5.9.2: http://mirror.centos.org/centos/7/os/x86_64/Packages/
3952019-02-14T19:25:53  <luke-jr> sounds like this is a non-issue then
3962019-02-14T19:25:56  <provoostenator> (oh, sipa found it)
3972019-02-14T19:25:57  <MarcoFalke> Ok, so it seems we are not cutting off anyone with the bump?
3982019-02-14T19:26:41  <wumpus> ok
3992019-02-14T19:26:48  <jonasschnelli> We cut off debian 8 which is LTS till 2020
4002019-02-14T19:26:51  <provoostenator> Cool, let's merge it right now :-P
4012019-02-14T19:26:53  <jonasschnelli> but I guess thats okay
4022019-02-14T19:27:07  <wumpus> let's merge it or close it and not talk about this for two years or so
4032019-02-14T19:27:12  <jonasschnelli> hehe
4042019-02-14T19:27:13  <jonasschnelli> indeed
4052019-02-14T19:27:26  <luke-jr> Debian 8 is oldstable?
4062019-02-14T19:28:11  <luke-jr> yeah
4072019-02-14T19:28:23  <wumpus> Debian 8 ("jessie") — obsolete stable release
4082019-02-14T19:28:26  <wumpus> obsolete
4092019-02-14T19:29:17  <MarcoFalke> Then, please someone add a debian_8 travis job. Otherwise this will be broken again
4102019-02-14T19:29:20  <jonasschnelli> yes... but we need to expect users run it close to the LTS end... but I'm fine with setting Qt 5.5.1 as min
4112019-02-14T19:29:28  <wumpus> I guess it's possible to build through depends still, but we can't support old versions of distributions that are already known to carry old packages forever
4122019-02-14T19:29:32  <luke-jr> MarcoFalke: we don't need to support oldstable IMO
4132019-02-14T19:29:41  <wumpus> no, we don't need a debian 8 travis job
4142019-02-14T19:29:44  <jonasschnelli> Yes. We have the depends build for those
4152019-02-14T19:29:53  <MarcoFalke> ok, action merge
4162019-02-14T19:30:40  <jonasschnelli> ack
4172019-02-14T19:30:43  <wumpus> ack
4182019-02-14T19:30:47  <wumpus> any other topics?
4192019-02-14T19:31:51  *** bitcoin-git has joined #bitcoin-core-dev
4202019-02-14T19:31:51  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b1df4ba0bec...758c6d784da0
4212019-02-14T19:31:52  <bitcoin-git> bitcoin/master 9975282 Luke Dashjr: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing
4222019-02-14T19:31:52  <bitcoin-git> bitcoin/master 113f000 Luke Dashjr: GUI: If BIP70 is disabled, give a proper error when trying to open a payme...
4232019-02-14T19:31:52  <bitcoin-git> bitcoin/master 84f5315 Luke Dashjr: Travis: Add test without BIP70 (but still full wallet + tests)
4242019-02-14T19:32:04  *** bitcoin-git has left #bitcoin-core-dev
4252019-02-14T19:32:20  *** bitcoin-git has joined #bitcoin-core-dev
4262019-02-14T19:32:21  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15063: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (master...bip70_fallback_to_bip21) https://github.com/bitcoin/bitcoin/pull/15063
4272019-02-14T19:32:29  *** bitcoin-git has left #bitcoin-core-dev
4282019-02-14T19:33:57  <wumpus> I guess not
4292019-02-14T19:34:14  <wumpus> #endmeeting
4302019-02-14T19:34:14  <lightningbot> Meeting ended Thu Feb 14 19:34:14 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4312019-02-14T19:34:14  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-14-19.00.html
4322019-02-14T19:34:14  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-14-19.00.txt
4332019-02-14T19:34:14  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-14-19.00.log.html
4342019-02-14T19:34:14  <jonasschnelli> looks like
4352019-02-14T19:34:15  <instagibbs> When is 0.18 branch date again
4362019-02-14T19:34:27  <jonasschnelli> https://github.com/bitcoin/bitcoin/issues/14438
4372019-02-14T19:34:32  <wumpus> 2019-03-01
4382019-02-14T19:34:33  <instagibbs> thx
4392019-02-14T19:34:46  <instagibbs> feature freeze 15 kk
4402019-02-14T19:35:07  <wumpus> yes, I mentioned this earlier in the meeting, please pay attention :-)
4412019-02-14T19:35:08  <jonasschnelli> a lot to review and merge until tomorrow. :)
4422019-02-14T19:35:16  <instagibbs> wumpus, yes sensei
4432019-02-14T19:35:39  <wumpus> lol
4442019-02-14T19:42:41  <wumpus> please use the leftover meeting time to review feature PRs <3
4452019-02-14T19:43:37  <sipa> what is the deal with appveyor failures? (sorry if i missed that)
4462019-02-14T19:43:50  *** bitcoin-git has joined #bitcoin-core-dev
4472019-02-14T19:43:51  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15410: test: txindex: interrupt threadGroup before calling destructor (master...Mf1902-testIndexInterr) https://github.com/bitcoin/bitcoin/pull/15410
4482019-02-14T19:43:52  *** bitcoin-git has left #bitcoin-core-dev
4492019-02-14T19:44:02  *** mistergo1d has joined #bitcoin-core-dev
4502019-02-14T19:44:09  <meshcollider> Ooh github has a new "draft PR" feature
4512019-02-14T19:44:38  <meshcollider> Handy for WIP PRs
4522019-02-14T19:44:38  <achow101> meshcollider: what's it do?
4532019-02-14T19:44:49  *** VitorB has quit IRC
4542019-02-14T19:44:51  <meshcollider> Can't be merged until its marked as ready
4552019-02-14T19:44:58  <MarcoFalke> sipa: Appveyor should be fixed
4562019-02-14T19:45:10  <sipa> ah thanks
4572019-02-14T19:45:32  *** dviola has quit IRC
4582019-02-14T19:45:44  <meshcollider> https://github.blog/2019-02-14-introducing-draft-pull-requests/
4592019-02-14T19:47:08  *** mistergold has quit IRC
4602019-02-14T19:48:32  *** mistergo1d has quit IRC
4612019-02-14T19:48:34  *** Karyon has quit IRC
4622019-02-14T19:48:49  <instagibbs> ah, gitlab has similar(WIP is actually enforced)
4632019-02-14T19:48:57  *** mistergold has joined #bitcoin-core-dev
4642019-02-14T19:48:59  <aj> meshcollider: nifty
4652019-02-14T19:49:07  <instagibbs> if you have any fixup! commits it also marks it as WIP
4662019-02-14T19:53:25  *** spinza has quit IRC
4672019-02-14T19:55:44  *** sschall has joined #bitcoin-core-dev
4682019-02-14T20:00:53  *** promag has quit IRC
4692019-02-14T20:02:57  *** bitcoin-git has joined #bitcoin-core-dev
4702019-02-14T20:02:57  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15411: travis: Combine --disable-bip70 into existing job (master...Mf1902-travisBIP70) https://github.com/bitcoin/bitcoin/pull/15411
4712019-02-14T20:03:03  *** bitcoin-git has left #bitcoin-core-dev
4722019-02-14T20:03:23  *** spinza has joined #bitcoin-core-dev
4732019-02-14T20:15:59  *** sschall has quit IRC
4742019-02-14T20:18:21  *** bitcoin-git has joined #bitcoin-core-dev
4752019-02-14T20:18:21  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/758c6d784da0...3b33cbc2b60d
4762019-02-14T20:18:22  <bitcoin-git> bitcoin/master fd46c4c Sjors Provoost: Bump minimum Qt version to 5.5.1
4772019-02-14T20:18:22  <bitcoin-git> bitcoin/master 3b33cbc Jonas Schnelli: Merge #15393: build: Bump minimum Qt version to 5.5.1
4782019-02-14T20:18:28  *** bitcoin-git has left #bitcoin-core-dev
4792019-02-14T20:19:01  *** bitcoin-git has joined #bitcoin-core-dev
4802019-02-14T20:19:01  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15393: build: Bump minimum Qt version to 5.5.1 (master...2019/02/qt-5_5) https://github.com/bitcoin/bitcoin/pull/15393
4812019-02-14T20:19:05  *** bitcoin-git has left #bitcoin-core-dev
4822019-02-14T20:30:39  *** DeanGuss has quit IRC
4832019-02-14T20:41:18  <wumpus> meshcollider "Can't be merged until its marked as ready" -> heh, [wip] in the PR title works just as well in practice
4842019-02-14T20:47:18  *** bitcoin-git has joined #bitcoin-core-dev
4852019-02-14T20:47:19  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3b33cbc2b60d...b7456e6bf9d1
4862019-02-14T20:47:19  <bitcoin-git> bitcoin/master f6122ab João Barbosa: interfaces: Add remove to Wallet
4872019-02-14T20:47:20  <bitcoin-git> bitcoin/master f77ba34 João Barbosa: gui: Add closeWallet to WalletController
4882019-02-14T20:47:20  <bitcoin-git> bitcoin/master 94086fb João Barbosa: gui: Add close wallet action
4892019-02-14T20:47:21  *** bitcoin-git has left #bitcoin-core-dev
4902019-02-14T20:47:52  *** bitcoin-git has joined #bitcoin-core-dev
4912019-02-14T20:47:52  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15195: gui: Add Close Wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195
4922019-02-14T20:47:57  *** bitcoin-git has left #bitcoin-core-dev
4932019-02-14T21:05:22  *** mmgen has quit IRC
4942019-02-14T21:10:57  *** phwalkr has quit IRC
4952019-02-14T21:12:29  *** bitcoin-git has joined #bitcoin-core-dev
4962019-02-14T21:12:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7456e6bf9d1...cd8ca8be31ab
4972019-02-14T21:12:30  <bitcoin-git> bitcoin/master 7257353 Pieter Wuille: Select orphan transaction uniformly for eviction
4982019-02-14T21:12:31  <bitcoin-git> bitcoin/master cd8ca8b MarcoFalke: Merge #14626: Select orphan transaction uniformly for eviction
4992019-02-14T21:12:33  *** bitcoin-git has left #bitcoin-core-dev
5002019-02-14T21:12:58  *** bitcoin-git has joined #bitcoin-core-dev
5012019-02-14T21:12:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14626: Select orphan transaction uniformly for eviction (master...201810_uniform_orphan_eviction) https://github.com/bitcoin/bitcoin/pull/14626
5022019-02-14T21:13:00  *** bitcoin-git has left #bitcoin-core-dev
5032019-02-14T21:18:21  *** bitcoin-git has joined #bitcoin-core-dev
5042019-02-14T21:18:21  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cd8ca8be31ab...3facd9fdc4dd
5052019-02-14T21:18:22  <bitcoin-git> bitcoin/master 314784a MeshCollider: Make listunspent and signrawtransaction RPCs support witnessScript
5062019-02-14T21:18:22  <bitcoin-git> bitcoin/master 928beae MeshCollider: Add test for P2SH-P2WSH in signrawtransactionwithkey and listunspent
5072019-02-14T21:18:23  <bitcoin-git> bitcoin/master 6ca836a MeshCollider: Add release note for listunspent P2WSH change
5082019-02-14T21:18:24  *** bitcoin-git has left #bitcoin-core-dev
5092019-02-14T21:18:37  *** timothy has quit IRC
5102019-02-14T21:18:45  *** bitcoin-git has joined #bitcoin-core-dev
5112019-02-14T21:18:45  <bitcoin-git> [bitcoin] laanwj merged pull request #14481: Add P2SH-P2WSH support to listunspent RPC (master...201810_listunspent_wsh) https://github.com/bitcoin/bitcoin/pull/14481
5122019-02-14T21:18:47  *** bitcoin-git has left #bitcoin-core-dev
5132019-02-14T21:22:57  *** mistergo1d has joined #bitcoin-core-dev
5142019-02-14T21:23:32  *** lnostdal has quit IRC
5152019-02-14T21:26:07  *** mistergold has quit IRC
5162019-02-14T21:27:37  *** lnostdal has joined #bitcoin-core-dev
5172019-02-14T21:28:21  *** bitcoin-git has joined #bitcoin-core-dev
5182019-02-14T21:28:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3facd9fdc4dd...642bd7bbe747
5192019-02-14T21:28:22  <bitcoin-git> bitcoin/master eeeee58 MarcoFalke: travis: Combine --disable-bip70 into existing job
5202019-02-14T21:28:22  <bitcoin-git> bitcoin/master 642bd7b MarcoFalke: Merge #15411: travis: Combine --disable-bip70 into existing job
5212019-02-14T21:28:27  *** bitcoin-git has left #bitcoin-core-dev
5222019-02-14T21:29:03  *** bitcoin-git has joined #bitcoin-core-dev
5232019-02-14T21:29:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15411: travis: Combine --disable-bip70 into existing job (master...Mf1902-travisBIP70) https://github.com/bitcoin/bitcoin/pull/15411
5242019-02-14T21:29:09  *** bitcoin-git has left #bitcoin-core-dev
5252019-02-14T21:31:09  <phantomcircuit> gmaxwell, aight how to test that rdseed and rdrand are being used?
5262019-02-14T21:33:22  *** bitcoin-git has joined #bitcoin-core-dev
5272019-02-14T21:33:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/642bd7bbe747...31f7c6dd2152
5282019-02-14T21:33:24  <bitcoin-git> bitcoin/master fa7ca8e MarcoFalke: qa: Add test/fuzz/test_runner.py
5292019-02-14T21:33:24  <bitcoin-git> bitcoin/master fa535af MarcoFalke: fuzz: test_runner: Better error message when built with afl
5302019-02-14T21:33:25  <bitcoin-git> bitcoin/master 31f7c6d MarcoFalke: Merge #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis
5312019-02-14T21:33:26  *** bitcoin-git has left #bitcoin-core-dev
5322019-02-14T21:33:56  *** bitcoin-git has joined #bitcoin-core-dev
5332019-02-14T21:33:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295
5342019-02-14T21:33:58  *** bitcoin-git has left #bitcoin-core-dev
5352019-02-14T21:35:35  <phantomcircuit> oh i see
5362019-02-14T21:35:46  *** hebasto has quit IRC
5372019-02-14T21:39:52  *** fabianfabian has quit IRC
5382019-02-14T21:43:20  *** bitcoin-git has joined #bitcoin-core-dev
5392019-02-14T21:43:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31f7c6dd2152...33480c636658
5402019-02-14T21:43:21  <bitcoin-git> bitcoin/master 0890339 Sjors Provoost: build: prefer python3.4 even if newer versions are present on the system
5412019-02-14T21:43:22  <bitcoin-git> bitcoin/master 33480c6 MarcoFalke: Merge #15285: build: Prefer Python 3.4 even if newer versions are present ...
5422019-02-14T21:43:23  *** bitcoin-git has left #bitcoin-core-dev
5432019-02-14T21:43:55  *** bitcoin-git has joined #bitcoin-core-dev
5442019-02-14T21:43:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15285: build: Prefer Python 3.4 even if newer versions are present on the system (master...2019/01/bitcoin-util-test-python) https://github.com/bitcoin/bitcoin/pull/15285
5452019-02-14T21:43:56  *** bitcoin-git has left #bitcoin-core-dev
5462019-02-14T21:49:42  <achow101> meshcollider: do you think #14021 is RTM?
5472019-02-14T21:49:45  <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
5482019-02-14T21:51:26  *** ap4lmtree- has joined #bitcoin-core-dev
5492019-02-14T21:57:40  <meshcollider> achow101: sipa said he would review it, but I think its RTM if he is busy
5502019-02-14T21:57:41  *** ap4lmtree- has quit IRC
5512019-02-14T21:57:48  <meshcollider> I was just going to wait for him
5522019-02-14T21:57:52  *** ap4lmtree has quit IRC
5532019-02-14T21:58:04  *** ap4lmtree has joined #bitcoin-core-dev
5542019-02-14T22:03:30  <meshcollider> achow101: how trivial is the merge conflict between the two?
5552019-02-14T22:03:46  <achow101> meshcollider: pretty trivial
5562019-02-14T22:03:51  <meshcollider> sweet
5572019-02-14T22:03:57  <achow101> IIRC it's just a move in the tests
5582019-02-14T22:06:33  <sipa> achow101: on it right now
5592019-02-14T22:06:46  <achow101> cool, thanks
5602019-02-14T22:10:13  *** schmidty has quit IRC
5612019-02-14T22:10:46  *** schmidty has joined #bitcoin-core-dev
5622019-02-14T22:12:41  *** spinza has quit IRC
5632019-02-14T22:33:40  <meshcollider> achow101: I'll merge 14075 first, then you can address sipa's nits in the rebase if you want to
5642019-02-14T22:33:46  <meshcollider> but im happy to merge as-is
5652019-02-14T22:34:15  <achow101> 14021 first is cleaner I think
5662019-02-14T22:34:42  <meshcollider> ok
5672019-02-14T22:34:54  <achow101> looking at the nits now
5682019-02-14T22:42:26  *** spinza has joined #bitcoin-core-dev
5692019-02-14T22:45:35  *** schmidty has quit IRC
5702019-02-14T22:45:49  <meshcollider> achow101: are you going to push any nit-fixes or shall I merge now
5712019-02-14T22:46:07  <achow101> meshcollider: i'll be pushing fixes in a few minutes
5722019-02-14T22:46:09  <meshcollider> ok
5732019-02-14T22:46:16  <achow101> also found a bug, forgot a few braches
5742019-02-14T22:46:19  <achow101> *braces
5752019-02-14T22:50:07  <achow101> meshcollider: pushed
5762019-02-14T22:50:44  <achow101> wait, something went wrong
5772019-02-14T22:55:09  *** promag has joined #bitcoin-core-dev
5782019-02-14T23:00:32  *** booyah has quit IRC
5792019-02-14T23:01:26  *** booyah has joined #bitcoin-core-dev
5802019-02-14T23:05:15  <achow101> meshcollider: ok, now it should be good to merge
5812019-02-14T23:08:14  <gmaxwell> phantomcircuit: check the logs, otherwise -- go instrument the code.
5822019-02-14T23:12:16  *** bitcoin-git has joined #bitcoin-core-dev
5832019-02-14T23:12:17  <bitcoin-git> [bitcoin] MeshCollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/33480c636658...8d0ec74801f7
5842019-02-14T23:12:17  <bitcoin-git> bitcoin/master c45415f Andrew Chow: Refactor keymetadata writing to a separate method
5852019-02-14T23:12:18  <bitcoin-git> bitcoin/master e7652d3 Andrew Chow: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
5862019-02-14T23:12:19  <bitcoin-git> bitcoin/master bac8c67 Andrew Chow: Add a method to CWallet to write just CKeyMetadata
5872019-02-14T23:12:20  *** bitcoin-git has left #bitcoin-core-dev
5882019-02-14T23:12:27  *** cluelessperson has quit IRC
5892019-02-14T23:12:38  *** bitcoin-git has joined #bitcoin-core-dev
5902019-02-14T23:12:38  <bitcoin-git> [bitcoin] MeshCollider merged pull request #14021: Import key origin data through descriptors in importmulti (master...import-multi-hd) https://github.com/bitcoin/bitcoin/pull/14021
5912019-02-14T23:12:51  *** bitcoin-git has left #bitcoin-core-dev
5922019-02-14T23:12:51  <meshcollider> ok achow101 please rebase #14075 :)
5932019-02-14T23:12:55  <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
5942019-02-14T23:12:58  <achow101> wohoo
5952019-02-14T23:13:05  *** rex4539 has quit IRC
5962019-02-14T23:17:11  *** cluelessperson has joined #bitcoin-core-dev
5972019-02-14T23:17:32  *** Aequitas_ has joined #bitcoin-core-dev
5982019-02-14T23:18:22  *** jarthur has quit IRC
5992019-02-14T23:19:28  <achow101> meshcollider: rebased. i'm gonna check it against hwi real quick to make sure I didn't screw up anything
6002019-02-14T23:20:05  <meshcollider> ok
6012019-02-14T23:20:22  <Aequitas_> Hello, is there a valid bitcoin core binary release signing key?  It looks like the key with fingerprint 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964 expired today.
6022019-02-14T23:21:48  <meshcollider> Aequitas_: yes, wumpus bumped the key expiry a few days ago
6032019-02-14T23:22:18  *** schmidty has joined #bitcoin-core-dev
6042019-02-14T23:27:36  *** booyah has quit IRC
6052019-02-14T23:27:57  *** mistergold has joined #bitcoin-core-dev
6062019-02-14T23:28:29  *** booyah has joined #bitcoin-core-dev
6072019-02-14T23:30:24  *** Guyver2 has quit IRC
6082019-02-14T23:31:56  *** mistergo1d has quit IRC
6092019-02-14T23:34:43  *** justanotheruser has joined #bitcoin-core-dev
6102019-02-14T23:37:04  <achow101> meshcollider: it's good to go now
6112019-02-14T23:42:37  <Aequitas_> meshcollider: Thanks, is there a published location I can aquire the new key?  https://bitcoincore.org/keys/laanwj-releases.asc is still importing as expired
6122019-02-14T23:44:16  <meshcollider> Aequitas_: just use --refresh-keys
6132019-02-14T23:44:21  <meshcollider> its the same key, just a different date
6142019-02-14T23:44:31  <achow101> Aequitas_: you can get it from any key server
6152019-02-14T23:45:21  *** promag has joined #bitcoin-core-dev
6162019-02-14T23:47:12  *** mistergo1d has joined #bitcoin-core-dev
6172019-02-14T23:47:20  *** mistergold has quit IRC
6182019-02-14T23:49:23  *** promag has quit IRC
6192019-02-14T23:52:41  *** bitcoin-git has joined #bitcoin-core-dev
6202019-02-14T23:52:43  <bitcoin-git> [bitcoin] MeshCollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8d0ec74801f7...c576979b78b5
6212019-02-14T23:52:43  <bitcoin-git> bitcoin/master 99cccb9 Andrew Chow: Add a method to add a pubkey to the keypool
6222019-02-14T23:52:44  <bitcoin-git> bitcoin/master 9b81fd1 Andrew Chow: Fetch keys from keypool when private keys are disabled
6232019-02-14T23:52:45  <bitcoin-git> bitcoin/master 513719c Andrew Chow: Add option to importmulti add an imported pubkey to the keypool
6242019-02-14T23:52:47  *** bitcoin-git has left #bitcoin-core-dev
6252019-02-14T23:53:05  *** bitcoin-git has joined #bitcoin-core-dev
6262019-02-14T23:53:06  <bitcoin-git> [bitcoin] MeshCollider merged pull request #14075: Import watch only pubkeys to the keypool if private keys are disabled (master...watch-only-keypool) https://github.com/bitcoin/bitcoin/pull/14075
6272019-02-14T23:53:09  *** bitcoin-git has left #bitcoin-core-dev
6282019-02-14T23:54:23  <achow101> \o/
6292019-02-14T23:54:38  <meshcollider> \o/
6302019-02-14T23:54:48  <achow101> instagibbs: there's your keypool
6312019-02-14T23:54:50  <meshcollider> provoostenator, instagibbs ^
6322019-02-14T23:54:51  *** schmidty has quit IRC