1 2019-02-26T00:04:32  *** schmidty has quit IRC
  2 2019-02-26T00:08:50  *** EagleTM has quit IRC
  3 2019-02-26T00:35:55  *** promag_ has quit IRC
  4 2019-02-26T00:36:33  *** promag has joined #bitcoin-core-dev
  5 2019-02-26T00:40:34  *** leishman has quit IRC
  6 2019-02-26T00:40:52  *** promag has quit IRC
  7 2019-02-26T00:49:11  *** MrPaz has joined #bitcoin-core-dev
  8 2019-02-26T00:53:55  *** schmidty has joined #bitcoin-core-dev
  9 2019-02-26T00:57:31  *** schmidty_ has joined #bitcoin-core-dev
 10 2019-02-26T00:58:30  *** schmidty has quit IRC
 11 2019-02-26T01:02:08  *** schmidty_ has quit IRC
 12 2019-02-26T01:03:50  *** jarthur has quit IRC
 13 2019-02-26T01:04:40  *** jarthur has joined #bitcoin-core-dev
 14 2019-02-26T01:10:50  *** DeanGuss has joined #bitcoin-core-dev
 15 2019-02-26T01:16:22  *** captjakk has quit IRC
 16 2019-02-26T01:22:46  *** EagleTM has joined #bitcoin-core-dev
 17 2019-02-26T01:30:44  *** promag has joined #bitcoin-core-dev
 18 2019-02-26T01:31:25  *** IGHOR has quit IRC
 19 2019-02-26T01:35:13  *** tryphe has quit IRC
 20 2019-02-26T01:35:26  *** promag has quit IRC
 21 2019-02-26T01:35:37  *** IGHOR has joined #bitcoin-core-dev
 22 2019-02-26T01:35:42  *** tryphe has joined #bitcoin-core-dev
 23 2019-02-26T01:35:47  *** jarthur has quit IRC
 24 2019-02-26T01:36:24  *** jarthur has joined #bitcoin-core-dev
 25 2019-02-26T01:47:52  *** jarthur has quit IRC
 26 2019-02-26T01:48:50  *** jarthur has joined #bitcoin-core-dev
 27 2019-02-26T02:06:46  *** sipa has quit IRC
 28 2019-02-26T02:08:42  *** tryphe_ has joined #bitcoin-core-dev
 29 2019-02-26T02:11:57  *** tryphe has quit IRC
 30 2019-02-26T02:12:00  *** sipa has joined #bitcoin-core-dev
 31 2019-02-26T02:13:30  *** schmidty has joined #bitcoin-core-dev
 32 2019-02-26T02:18:17  *** schmidty has quit IRC
 33 2019-02-26T02:23:02  <luke-jr> BlueMatt: re #15482 can you add something to the BIP on a rationale for using the witness-stripped size for <65 byte limit?
 34 2019-02-26T02:23:03  <gribble> https://github.com/bitcoin/bitcoin/issues/15482 | Implement BIPXXXs new softfork rules (The Great Consensus Cleanup) by TheBlueMatt · Pull Request #15482 · bitcoin/bitcoin · GitHub
 35 2019-02-26T02:36:08  <sipa> luke-jr: the witness-stripped size is what matters for the merkle tree vulnerability
 36 2019-02-26T02:37:04  <luke-jr> sipa: only in one merkle tree, though?
 37 2019-02-26T02:39:19  <luke-jr> I guess <64 bytes isn't possible with any sensible output anyway, even if witness is stripped
 38 2019-02-26T02:44:12  <luke-jr> anyway, just a topic to cover in the rationale IMO
 39 2019-02-26T02:44:19  <kanzure> just fyi, bitcoin-dev mailing list is temporarily broken
 40 2019-02-26T02:44:32  <kanzure> i assume temporarily.
 41 2019-02-26T02:44:44  <sipa> luke-jr: agree
 42 2019-02-26T02:49:06  *** EagleTM has quit IRC
 43 2019-02-26T02:54:47  *** schmidty has joined #bitcoin-core-dev
 44 2019-02-26T02:59:38  *** schmidty has quit IRC
 45 2019-02-26T03:02:23  *** promag has joined #bitcoin-core-dev
 46 2019-02-26T03:06:42  *** promag has quit IRC
 47 2019-02-26T03:12:37  *** AaronvanW has quit IRC
 48 2019-02-26T03:32:09  *** droark has quit IRC
 49 2019-02-26T03:33:35  *** petertodd has quit IRC
 50 2019-02-26T03:37:59  *** schmidty has joined #bitcoin-core-dev
 51 2019-02-26T03:42:22  *** schmidty has quit IRC
 52 2019-02-26T03:43:28  *** AaronvanW has joined #bitcoin-core-dev
 53 2019-02-26T03:47:44  *** AaronvanW has quit IRC
 54 2019-02-26T04:13:34  *** owowo has quit IRC
 55 2019-02-26T04:31:32  *** fanquake has joined #bitcoin-core-dev
 56 2019-02-26T04:31:55  <fanquake> wumpus/sipa can you block 3ggerman29 from GH. They are spamming addresses/comments.
 57 2019-02-26T04:34:16  *** AaronvanW has joined #bitcoin-core-dev
 58 2019-02-26T04:40:45  <sipa> give me an irc command to run
 59 2019-02-26T04:54:13  <fanquake> sipa pretty sure you'll have to go to GitHub, don't think we've got a ban bot
 60 2019-02-26T04:54:50  <sipa> oh!
 61 2019-02-26T04:55:31  <sipa> sorry, i thought you meant someone spamming on irc
 62 2019-02-26T04:55:39  <sipa> can't do so right now
 63 2019-02-26T04:58:28  *** fanquake has quit IRC
 64 2019-02-26T04:59:16  *** fanquake has joined #bitcoin-core-dev
 65 2019-02-26T05:00:29  *** fanquake has quit IRC
 66 2019-02-26T05:00:48  *** fanquake has joined #bitcoin-core-dev
 67 2019-02-26T05:01:20  <luke-jr> lol
 68 2019-02-26T05:01:42  *** AaronvanW has quit IRC
 69 2019-02-26T05:03:12  *** schmidty has joined #bitcoin-core-dev
 70 2019-02-26T05:07:37  *** schmidty has quit IRC
 71 2019-02-26T05:08:02  *** ghost43 has quit IRC
 72 2019-02-26T05:08:16  *** ghost43 has joined #bitcoin-core-dev
 73 2019-02-26T05:08:28  <fanquake> sipa no worries
 74 2019-02-26T05:20:38  *** ovovo has joined #bitcoin-core-dev
 75 2019-02-26T05:32:55  *** schmidty has joined #bitcoin-core-dev
 76 2019-02-26T05:34:56  *** fanquake has quit IRC
 77 2019-02-26T05:37:32  *** schmidty has quit IRC
 78 2019-02-26T05:39:50  *** fanquake has joined #bitcoin-core-dev
 79 2019-02-26T05:40:30  *** bashco has quit IRC
 80 2019-02-26T05:40:30  *** bashco has joined #bitcoin-core-dev
 81 2019-02-26T05:41:58  <BlueMatt> luke-jr: wait, I'm confused, you want me to add rationale for why we care only about non-witness size and why we dont have similar concerns in wtxid merkle tree?
 82 2019-02-26T05:49:47  *** fanquake has quit IRC
 83 2019-02-26T05:50:05  *** fanquake has joined #bitcoin-core-dev
 84 2019-02-26T05:59:18  *** _flow_ has quit IRC
 85 2019-02-26T05:59:32  *** jarthur has quit IRC
 86 2019-02-26T06:08:07  <luke-jr> BlueMatt: no.. why we don't ONLY protect the witness tree, basically
 87 2019-02-26T06:08:28  <luke-jr> (and probably good to mention why it doesn't matter?)
 88 2019-02-26T06:38:11  *** fanquake has quit IRC
 89 2019-02-26T06:58:46  *** AaronvanW has joined #bitcoin-core-dev
 90 2019-02-26T07:08:06  *** AaronvanW has quit IRC
 91 2019-02-26T07:18:12  *** promag has joined #bitcoin-core-dev
 92 2019-02-26T07:18:39  *** promag has quit IRC
 93 2019-02-26T07:19:23  *** promag has joined #bitcoin-core-dev
 94 2019-02-26T07:23:54  *** promag has quit IRC
 95 2019-02-26T07:28:35  *** Muoi has joined #bitcoin-core-dev
 96 2019-02-26T07:31:07  <Muoi> I run a Bitcoin node, there is no IP inserted to tried table since December, is this a problem?
 97 2019-02-26T07:31:42  <gmaxwell> Muoi: thats interesting. it's supposed to generate feeler connections, are you using -connect?
 98 2019-02-26T07:32:08  <Muoi> No, I run a default node, with only some additional customized logging messages.
 99 2019-02-26T07:32:16  <gmaxwell> current version?
100 2019-02-26T07:32:23  <Muoi> There is no feeler connection was made since 18 Dec 2018
101 2019-02-26T07:32:25  <Muoi> 0.17.0
102 2019-02-26T07:32:46  <gmaxwell> Muoi: how many connections do you have up?
103 2019-02-26T07:33:21  <Muoi> Outgoing connections are always 8 or 9.
104 2019-02-26T07:33:37  <Muoi> "Potential stale tip detected, will try using extra outbound peer" was printed out frequently also
105 2019-02-26T07:33:47  *** schmidty has joined #bitcoin-core-dev
106 2019-02-26T07:33:48  <gmaxwell> that sounds like you're actually deadlocked.
107 2019-02-26T07:33:49  <Muoi> 6-12 times per day
108 2019-02-26T07:33:57  <gmaxwell> Muoi: what is your most recent block?
109 2019-02-26T07:34:12  <Muoi> ATM 564704
110 2019-02-26T07:34:39  <gmaxwell> Thats currentish.
111 2019-02-26T07:35:07  <Muoi> yes, stale tip happens, but not every time the node checks, I think.
112 2019-02-26T07:35:22  <Muoi> For example, on 25 Feb 2019:
113 2019-02-26T07:35:23  <Muoi> 2019-02-25T06:36:35Z Potential stale tip detected, will try using extra outbound peer (last tip update: 1849 seconds ago) 2019-02-25T09:03:36Z Potential stale tip detected, will try using extra outbound peer (last tip update: 2138 seconds ago) 2019-02-25T09:14:06Z Potential stale tip detected, will try using extra outbound peer (last tip update: 2768 seconds ago) 2019-02-25T11:20:08Z Potential stale tip detected, will try us
114 2019-02-26T07:35:46  <gmaxwell> well that will happen from time to time normally (when blocks are far apart) so it's not shocking but 12 times per day sounds like too much.
115 2019-02-26T07:36:25  <Muoi> Yep, I agree.
116 2019-02-26T07:36:36  <Muoi> But isn't that feeler connections should still happen?
117 2019-02-26T07:37:45  <gmaxwell> it should, indeed. it shoulds like a bug.
118 2019-02-26T07:38:29  *** schmidty has quit IRC
119 2019-02-26T07:38:52  <Muoi> It happens with my another node also. But after I reboot the node, it starts having feeler connections again.
120 2019-02-26T07:39:30  <Muoi> Seems like the SetTryNewOutboundPeer() is incorrectly set somewhere.
121 2019-02-26T07:40:56  <gmaxwell> My first guess would be to look for interactions with the stale tip logic.
122 2019-02-26T07:48:37  <luke-jr> has the node been restarted since this began happening?
123 2019-02-26T07:49:24  <Muoi> No, I have been running it non-stop. To clarify more, I run few nodes actually. Some of them have this problem.
124 2019-02-26T07:49:46  <Muoi> I restart only one node and problem is gone, so I wouldn't want to do it on other nodes.
125 2019-02-26T07:51:00  <Muoi> To trigger feeler connection, tip must not be stale and the number of outgoing connections must be >=8, right?
126 2019-02-26T07:51:31  <Muoi> But stale tip are detected few times per day, and number of outbound conn. is always 8. But no feeler connection.
127 2019-02-26T07:51:54  <Muoi> I have looked at the stale tip logic in the last 12 hours, couldn't figure it out so I brought the problem here.
128 2019-02-26T07:54:21  *** EagleTM has joined #bitcoin-core-dev
129 2019-02-26T07:57:25  *** ovovo is now known as owowo
130 2019-02-26T08:00:27  *** EagleTM has quit IRC
131 2019-02-26T08:03:41  *** Guyver2 has joined #bitcoin-core-dev
132 2019-02-26T08:07:28  *** timothy has joined #bitcoin-core-dev
133 2019-02-26T08:16:17  *** promag has joined #bitcoin-core-dev
134 2019-02-26T08:18:53  <Muoi> Btw, I would be very gladful if you guys can help to take a look at this problem. I can provide detailed debug.log, node specs, etc..
135 2019-02-26T08:21:47  <gmaxwell> Muoi: thanks someone will. If you can hang around (or leave an email). It would be helpful to open an issue too.
136 2019-02-26T08:22:04  <gmaxwell> (I'm not looking at it right now since it's late for me and I should be asleep)
137 2019-02-26T08:23:50  <Muoi> Okay sure, I will open an issue. FYI, my email is muoitran@comp.nus.edu.sg. Please feel free to drop an email so we can discuss more. Good night!.
138 2019-02-26T08:24:37  *** promag has quit IRC
139 2019-02-26T08:26:17  *** spinza has quit IRC
140 2019-02-26T08:39:25  *** jungly has joined #bitcoin-core-dev
141 2019-02-26T08:42:56  *** spinza has joined #bitcoin-core-dev
142 2019-02-26T09:05:39  *** AaronvanW has joined #bitcoin-core-dev
143 2019-02-26T09:12:19  *** droark has joined #bitcoin-core-dev
144 2019-02-26T09:14:50  *** siom has joined #bitcoin-core-dev
145 2019-02-26T09:15:16  *** AaronvanW has quit IRC
146 2019-02-26T09:18:58  *** Deinogalerix21 has joined #bitcoin-core-dev
147 2019-02-26T09:23:51  *** ctrlbreak_MAD has joined #bitcoin-core-dev
148 2019-02-26T09:24:16  *** murrayn has quit IRC
149 2019-02-26T09:24:29  *** siom_ has joined #bitcoin-core-dev
150 2019-02-26T09:25:27  *** siom has quit IRC
151 2019-02-26T09:27:37  *** rafalcpp_ has joined #bitcoin-core-dev
152 2019-02-26T09:28:39  *** murrayn has joined #bitcoin-core-dev
153 2019-02-26T09:28:39  *** murrayn has joined #bitcoin-core-dev
154 2019-02-26T09:29:04  *** Kvaciral_ has joined #bitcoin-core-dev
155 2019-02-26T09:30:05  *** ctrlbreak has quit IRC
156 2019-02-26T09:30:05  *** rafalcpp has quit IRC
157 2019-02-26T09:30:05  *** Kvaciral has quit IRC
158 2019-02-26T09:30:26  *** andytoshi has quit IRC
159 2019-02-26T09:30:32  *** gkrizek has quit IRC
160 2019-02-26T09:30:34  *** tryphe_ is now known as tryphe
161 2019-02-26T09:30:35  *** andytoshi has joined #bitcoin-core-dev
162 2019-02-26T09:30:35  *** andytoshi has joined #bitcoin-core-dev
163 2019-02-26T09:30:58  *** gkrizek has joined #bitcoin-core-dev
164 2019-02-26T09:33:58  *** gkrizek3 has joined #bitcoin-core-dev
165 2019-02-26T09:34:12  *** kabaum has joined #bitcoin-core-dev
166 2019-02-26T09:34:51  *** schmidty has joined #bitcoin-core-dev
167 2019-02-26T09:35:08  *** rockhouse has quit IRC
168 2019-02-26T09:35:08  *** gkrizek has quit IRC
169 2019-02-26T09:35:08  *** davec_ has quit IRC
170 2019-02-26T09:35:23  *** davec has joined #bitcoin-core-dev
171 2019-02-26T09:35:33  *** rockhouse has joined #bitcoin-core-dev
172 2019-02-26T09:39:38  *** schmidty has quit IRC
173 2019-02-26T09:49:25  *** promag has joined #bitcoin-core-dev
174 2019-02-26T10:06:53  *** setpill has joined #bitcoin-core-dev
175 2019-02-26T10:09:07  *** volkov has joined #bitcoin-core-dev
176 2019-02-26T10:17:33  *** AaronvanW has joined #bitcoin-core-dev
177 2019-02-26T10:21:46  *** AaronvanW has quit IRC
178 2019-02-26T10:29:02  *** Deinogalerix21 has quit IRC
179 2019-02-26T10:41:31  *** darosior has joined #bitcoin-core-dev
180 2019-02-26T10:48:44  *** spinza has quit IRC
181 2019-02-26T11:02:26  *** spinza has joined #bitcoin-core-dev
182 2019-02-26T11:03:18  *** AaronvanW has joined #bitcoin-core-dev
183 2019-02-26T11:07:50  *** AaronvanW has quit IRC
184 2019-02-26T11:20:41  *** bitcoin-git has joined #bitcoin-core-dev
185 2019-02-26T11:20:41  <bitcoin-git> [bitcoin] darosior opened pull request #15483: Adding a 'logpath' entry to getrpcinfo, as discussed in #15438 (master...getrpcinfo_logpath) https://github.com/bitcoin/bitcoin/pull/15483
186 2019-02-26T11:20:53  *** bitcoin-git has left #bitcoin-core-dev
187 2019-02-26T11:25:03  *** DeanGuss has quit IRC
188 2019-02-26T11:25:21  *** schmidty has joined #bitcoin-core-dev
189 2019-02-26T11:25:29  *** DeanGuss has joined #bitcoin-core-dev
190 2019-02-26T11:45:55  *** AaronvanW has joined #bitcoin-core-dev
191 2019-02-26T11:46:12  *** mmgen has joined #bitcoin-core-dev
192 2019-02-26T12:04:32  *** EagleTM has joined #bitcoin-core-dev
193 2019-02-26T12:05:03  *** volkov has quit IRC
194 2019-02-26T12:10:51  *** EagleTM has quit IRC
195 2019-02-26T12:20:40  *** junior_ has joined #bitcoin-core-dev
196 2019-02-26T12:21:03  *** darosior has quit IRC
197 2019-02-26T12:25:29  *** Paz has joined #bitcoin-core-dev
198 2019-02-26T12:25:43  *** tryphe_ has joined #bitcoin-core-dev
199 2019-02-26T12:25:53  *** Paz is now known as Guest7635
200 2019-02-26T12:26:03  *** booyah_ has joined #bitcoin-core-dev
201 2019-02-26T12:28:34  *** cryptapus_ has joined #bitcoin-core-dev
202 2019-02-26T12:28:35  *** cryptapus_ has quit IRC
203 2019-02-26T12:28:35  *** cryptapus_ has joined #bitcoin-core-dev
204 2019-02-26T12:30:00  *** commavir_ has joined #bitcoin-core-dev
205 2019-02-26T12:30:23  *** commavir has quit IRC
206 2019-02-26T12:30:24  *** Emcy has quit IRC
207 2019-02-26T12:30:24  *** spinza has quit IRC
208 2019-02-26T12:30:24  *** owowo has quit IRC
209 2019-02-26T12:30:24  *** tryphe has quit IRC
210 2019-02-26T12:30:24  *** instagibbs has quit IRC
211 2019-02-26T12:30:24  *** booyah has quit IRC
212 2019-02-26T12:30:25  *** sgeisler has quit IRC
213 2019-02-26T12:30:25  *** cryptapus has quit IRC
214 2019-02-26T12:30:25  *** sgeisler has joined #bitcoin-core-dev
215 2019-02-26T12:30:28  *** victorSN has quit IRC
216 2019-02-26T12:30:28  *** rh0nj has quit IRC
217 2019-02-26T12:30:29  *** so has quit IRC
218 2019-02-26T12:30:30  *** MrPaz has quit IRC
219 2019-02-26T12:30:47  *** so_ has joined #bitcoin-core-dev
220 2019-02-26T12:30:51  *** instagibbs has joined #bitcoin-core-dev
221 2019-02-26T12:30:59  *** Emcy has joined #bitcoin-core-dev
222 2019-02-26T12:31:08  *** rh0nj has joined #bitcoin-core-dev
223 2019-02-26T12:31:11  *** Emcy has quit IRC
224 2019-02-26T12:31:11  *** Emcy has joined #bitcoin-core-dev
225 2019-02-26T12:31:26  *** owowo has joined #bitcoin-core-dev
226 2019-02-26T12:31:38  *** victorSN has joined #bitcoin-core-dev
227 2019-02-26T12:32:08  *** schmidty has quit IRC
228 2019-02-26T12:35:29  *** Emcy has quit IRC
229 2019-02-26T12:35:49  *** Emcy has joined #bitcoin-core-dev
230 2019-02-26T12:37:19  *** Emcy has joined #bitcoin-core-dev
231 2019-02-26T12:37:37  *** schmidty has joined #bitcoin-core-dev
232 2019-02-26T12:37:37  *** schmidty has joined #bitcoin-core-dev
233 2019-02-26T12:40:04  *** commavir_ is now known as commavir
234 2019-02-26T12:42:07  *** schmidty has quit IRC
235 2019-02-26T12:45:35  *** spinza has joined #bitcoin-core-dev
236 2019-02-26T12:49:07  *** AaronvanW has quit IRC
237 2019-02-26T12:54:43  *** owowo has quit IRC
238 2019-02-26T12:59:01  *** owowo has joined #bitcoin-core-dev
239 2019-02-26T13:07:16  *** lio17 has quit IRC
240 2019-02-26T13:07:16  *** AaronvanW has joined #bitcoin-core-dev
241 2019-02-26T13:08:02  *** lio17 has joined #bitcoin-core-dev
242 2019-02-26T13:08:54  *** lio17 has quit IRC
243 2019-02-26T13:09:32  *** lio17 has joined #bitcoin-core-dev
244 2019-02-26T13:09:39  *** schmidty has joined #bitcoin-core-dev
245 2019-02-26T13:11:03  *** siom_ has quit IRC
246 2019-02-26T13:14:19  *** schmidty has quit IRC
247 2019-02-26T13:26:43  *** TheCharlatan has quit IRC
248 2019-02-26T13:27:37  *** muoitran has joined #bitcoin-core-dev
249 2019-02-26T13:27:54  *** TheCharlatan has joined #bitcoin-core-dev
250 2019-02-26T13:28:23  *** muoitran has quit IRC
251 2019-02-26T13:34:39  <sdaftuar> Muoi: hi, i'd like to investigate the p2p issue you're seeing (i wrote the code that seems to be involved).  can you post your debug.log somewhere? if there might be sensitive information in it (eg wallet related things, ip addresses, etc) i'm most interested in just a few lines that might appear:
252 2019-02-26T13:35:15  <sdaftuar> lines involving "UpdateTip", "Potential stale tip", "disconnecting extra outbound peer", "keeping outbound peer"
253 2019-02-26T13:35:55  <sdaftuar> also "setting try another outbound peer"
254 2019-02-26T13:39:27  *** Guyver2 has quit IRC
255 2019-02-26T13:41:20  *** schmidty has joined #bitcoin-core-dev
256 2019-02-26T13:46:07  *** schmidty has quit IRC
257 2019-02-26T13:46:59  *** promag has quit IRC
258 2019-02-26T13:50:48  *** Zenton has quit IRC
259 2019-02-26T13:51:00  *** Zenton has joined #bitcoin-core-dev
260 2019-02-26T14:08:43  *** promag has joined #bitcoin-core-dev
261 2019-02-26T14:12:58  *** promag has quit IRC
262 2019-02-26T14:21:47  *** bitcoin-git has joined #bitcoin-core-dev
263 2019-02-26T14:21:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f470ecc534d...d88f7f8764b1
264 2019-02-26T14:21:48  <bitcoin-git> bitcoin/master ef362f2 Wladimir J. van der Laan: rpc/gui: Remove 'Unknown block versions being mined' warning
265 2019-02-26T14:21:49  <bitcoin-git> bitcoin/master d88f7f8 MarcoFalke: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning...
266 2019-02-26T14:21:55  *** bitcoin-git has left #bitcoin-core-dev
267 2019-02-26T14:22:42  *** bitcoin-git has joined #bitcoin-core-dev
268 2019-02-26T14:22:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15471: rpc/gui: Remove 'Unknown block versions being mined' warning (master...2019_02_false_positives) https://github.com/bitcoin/bitcoin/pull/15471
269 2019-02-26T14:22:46  *** bitcoin-git has left #bitcoin-core-dev
270 2019-02-26T14:24:41  *** booyah_ has quit IRC
271 2019-02-26T14:25:21  *** booyah_ has joined #bitcoin-core-dev
272 2019-02-26T14:27:08  *** bitcoin-git has joined #bitcoin-core-dev
273 2019-02-26T14:27:08  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
274 2019-02-26T14:27:09  *** bitcoin-git has left #bitcoin-core-dev
275 2019-02-26T14:27:26  *** bitcoin-git has joined #bitcoin-core-dev
276 2019-02-26T14:27:26  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
277 2019-02-26T14:27:30  *** bitcoin-git has left #bitcoin-core-dev
278 2019-02-26T14:29:42  *** promag has joined #bitcoin-core-dev
279 2019-02-26T14:36:47  *** rafalcpp_ is now known as rafalcpp
280 2019-02-26T14:37:16  *** Guyver2 has joined #bitcoin-core-dev
281 2019-02-26T14:39:47  *** phwalkr has joined #bitcoin-core-dev
282 2019-02-26T14:45:07  *** schmidty has joined #bitcoin-core-dev
283 2019-02-26T14:45:39  <phantomcircuit> Muoi, possibly your system clock is broken
284 2019-02-26T14:52:11  *** promag has quit IRC
285 2019-02-26T14:53:35  *** promag_ has joined #bitcoin-core-dev
286 2019-02-26T15:24:50  *** captjakk has joined #bitcoin-core-dev
287 2019-02-26T15:27:38  *** darosior has joined #bitcoin-core-dev
288 2019-02-26T15:33:13  *** elichai2 has joined #bitcoin-core-dev
289 2019-02-26T15:41:31  *** Muoi_ has joined #bitcoin-core-dev
290 2019-02-26T15:56:09  *** dviola has joined #bitcoin-core-dev
291 2019-02-26T16:15:17  *** _flow_ has joined #bitcoin-core-dev
292 2019-02-26T16:17:07  *** _flow_ has quit IRC
293 2019-02-26T16:17:15  *** _flow_ has joined #bitcoin-core-dev
294 2019-02-26T16:17:26  *** setpill has quit IRC
295 2019-02-26T16:18:55  *** dqx_ has joined #bitcoin-core-dev
296 2019-02-26T16:24:09  *** darosior has quit IRC
297 2019-02-26T16:33:28  *** dviola has quit IRC
298 2019-02-26T16:54:03  *** tryphe_ is now known as tryphe
299 2019-02-26T16:55:54  <sdaftuar> phantomcircuit: it seems to be a bug in the addrman/net interaction, see #15484.  can someone tag that with the Bug label?  we should fix it...
300 2019-02-26T16:55:55  <gribble> https://github.com/bitcoin/bitcoin/issues/15484 | No feeler connection is made when our tip is stale · Issue #15484 · bitcoin/bitcoin · GitHub
301 2019-02-26T16:57:03  <achow101> Has anyone seen this issue with 0.17.1 on ubuntu 18.10 before: https://bitcoin.stackexchange.com/questions/84868/bitcoin-qt-testnet-0-17-1-send-and-receive-buttons-do-nothing?
302 2019-02-26T16:57:29  <achow101> the debug.log file indicates that various signals aren't being connected
303 2019-02-26T17:23:27  *** led_zgrl has joined #bitcoin-core-dev
304 2019-02-26T17:27:42  *** darosior has joined #bitcoin-core-dev
305 2019-02-26T17:28:04  *** promag has joined #bitcoin-core-dev
306 2019-02-26T17:28:59  *** jarthur has joined #bitcoin-core-dev
307 2019-02-26T17:34:15  *** schmidty has quit IRC
308 2019-02-26T17:34:56  *** schmidty has joined #bitcoin-core-dev
309 2019-02-26T17:34:56  *** schmidty has joined #bitcoin-core-dev
310 2019-02-26T17:39:31  *** led_zgrl has quit IRC
311 2019-02-26T17:39:33  *** hebasto has joined #bitcoin-core-dev
312 2019-02-26T17:39:40  *** schmidty has quit IRC
313 2019-02-26T17:57:47  *** Guyver2 has quit IRC
314 2019-02-26T18:00:58  *** schmidty has joined #bitcoin-core-dev
315 2019-02-26T18:01:05  *** schmidty has quit IRC
316 2019-02-26T18:01:05  *** schmidty has joined #bitcoin-core-dev
317 2019-02-26T18:05:50  *** hebasto has quit IRC
318 2019-02-26T18:07:36  *** fabianfabian has joined #bitcoin-core-dev
319 2019-02-26T18:08:53  *** Guyver2 has joined #bitcoin-core-dev
320 2019-02-26T18:09:56  *** jungly has quit IRC
321 2019-02-26T18:12:57  *** darosior has quit IRC
322 2019-02-26T18:15:25  *** promag has quit IRC
323 2019-02-26T18:26:43  *** Aaronvan_ has joined #bitcoin-core-dev
324 2019-02-26T18:30:00  *** AaronvanW has quit IRC
325 2019-02-26T18:41:28  *** Aaronvan_ is now known as AaronvanW
326 2019-02-26T18:52:48  *** _Sam-- has joined #bitcoin-core-dev
327 2019-02-26T19:03:01  <BlueMatt> is feature_assumevalid known to be failing on travis?
328 2019-02-26T19:03:49  <gmaxwell> BlueMatt: isn't failed on any other PRs than yours, AFAICT
329 2019-02-26T19:04:05  <BlueMatt> weird...given I havent touched it and it passes locally :(
330 2019-02-26T19:04:36  <sipa> have you tried turning it off and on again?
331 2019-02-26T19:04:41  <sipa> (restarting travis)
332 2019-02-26T19:04:47  <BlueMatt> I have...a few times :(
333 2019-02-26T19:04:52  <gmaxwell> https://github.com/bitcoin/bitcoin/commit/b6f0db69a9c9cdf101371720351935121590d3aa#diff-42a25137995f0f513f6ee7653bc2c63e
334 2019-02-26T19:05:00  <gmaxwell> apparently it's been flaking before.
335 2019-02-26T19:05:08  <BlueMatt> recently, too
336 2019-02-26T19:05:28  * gmaxwell grumbles about testing on cloud services.
337 2019-02-26T19:05:39  <BlueMatt> fails on the same line, too
338 2019-02-26T19:05:56  <gmaxwell> try again... :(
339 2019-02-26T19:06:53  <BlueMatt> yea, I bumped the time limit, lets see if it fixes it
340 2019-02-26T19:07:25  <gmaxwell> Unrelated, do we need to move off linuxfoundation lists?  AFAICT the mailing list has been dysfunctional for some time and now isn't working at all.
341 2019-02-26T19:07:28  <BlueMatt> I am curious why that generated a failure, though, given it also fails on the pre-fork-changes commit which I dont see how it could possibly have a performance effect aside from running a different set of tests in parallell at the time
342 2019-02-26T19:10:18  <jnewbery> what's the pre-fork-changes commit?
343 2019-02-26T19:10:53  <gmaxwell> performance of travis executors seems to be extremely inconsistent.
344 2019-02-26T19:11:10  <BlueMatt> jnewbery: the commit that only changed the getblocktemplate/miner.cpp behavior
345 2019-02-26T19:11:21  <BlueMatt> (and added a new test)
346 2019-02-26T19:11:32  <BlueMatt> ie #15481
347 2019-02-26T19:11:35  <gribble> https://github.com/bitcoin/bitcoin/issues/15481 | Restrict timestamp when mining a diff-adjustment block to prev-600 by TheBlueMatt · Pull Request #15481 · bitcoin/bitcoin · GitHub
348 2019-02-26T19:13:07  <gmaxwell> kanzure: do you know whats up with the mailing list?
349 2019-02-26T19:13:40  <sipa> admin interface is down, i heard
350 2019-02-26T19:14:45  <BlueMatt> last I heard he said he'd "escalated" it
351 2019-02-26T19:14:49  <BlueMatt> so....who knows
352 2019-02-26T19:18:25  *** promag has joined #bitcoin-core-dev
353 2019-02-26T19:20:39  *** Emcy has quit IRC
354 2019-02-26T19:20:39  *** so_ has quit IRC
355 2019-02-26T19:20:47  *** spinza has quit IRC
356 2019-02-26T19:20:48  *** rh0nj has quit IRC
357 2019-02-26T19:20:56  *** so has joined #bitcoin-core-dev
358 2019-02-26T19:21:02  *** promag_ has quit IRC
359 2019-02-26T19:21:08  *** Emcy has joined #bitcoin-core-dev
360 2019-02-26T19:21:46  <jnewbery> and it hasn't failed on master recently?
361 2019-02-26T19:22:34  <luke-jr> gmaxwell: PM
362 2019-02-26T19:25:17  *** phwalkr has quit IRC
363 2019-02-26T19:25:19  <BlueMatt> jnewbery: what hasnt?
364 2019-02-26T19:26:08  *** phwalkr has joined #bitcoin-core-dev
365 2019-02-26T19:26:11  <BlueMatt> also, processnewblock_signals_ordering is busted on windows, but if I restart it it works again
366 2019-02-26T19:26:14  <BlueMatt> soooo ummm...thats bad
367 2019-02-26T19:29:19  <kanzure> gmaxwell: no, i don't know what's going on. it's just "internal server error" all the time.
368 2019-02-26T19:29:19  *** spinza has joined #bitcoin-core-dev
369 2019-02-26T19:29:27  <kanzure> gmaxwell: i escalated to warren, who knows the linux foundation people
370 2019-02-26T19:31:50  *** phwalkr has quit IRC
371 2019-02-26T19:33:17  <jnewbery> the test that's failing - feature_assumevalid.py ?
372 2019-02-26T19:35:42  <jnewbery> ah, I think I see what's happening
373 2019-02-26T19:36:00  <jnewbery> feature_assumevalid.py always takes a long time on travis. usually around 150 seconds
374 2019-02-26T19:36:17  <jnewbery> for me locally, it runs in less than 10
375 2019-02-26T19:36:35  <jnewbery> it must be taking a long time here:
376 2019-02-26T19:36:35  <jnewbery>             p2p1.send_message(msg_block(self.blocks[i]))
377 2019-02-26T19:36:56  <jnewbery> sorry, here:
378 2019-02-26T19:36:57  <jnewbery>         for i in range(2202):
379 2019-02-26T19:36:57  <jnewbery>             p2p1.send_message(msg_block(self.blocks[i]))
380 2019-02-26T19:37:20  <jnewbery> which presumably is hitting storage in AcceptBlock()
381 2019-02-26T19:37:48  <jnewbery> any disk activity is super slow in Travis
382 2019-02-26T19:39:12  <jnewbery> I don't think there's any way to speed it up. The test is feeding a long chain of blocks to a node where one of the early blocks has an invalid signature, and checking that the chain is accepted when assumevalid is set
383 2019-02-26T19:40:18  *** EagleTM has joined #bitcoin-core-dev
384 2019-02-26T19:41:05  <jnewbery> I can't see any reason your change would make a difference there, unless it just happens to be running a different test that has disk i/o in parallel
385 2019-02-26T19:41:51  *** DeanGuss has quit IRC
386 2019-02-26T19:43:08  <jnewbery> Actually, I guess we don't need to feed it the full chain of blocks. As long as it accepts the invalid block (height 102), then it's testing the assumevalid behaviour
387 2019-02-26T19:43:54  *** bitcoin-git has joined #bitcoin-core-dev
388 2019-02-26T19:43:55  <bitcoin-git> [bitcoin] adamjonas opened pull request #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (master...test_rpc_misc) https://github.com/bitcoin/bitcoin/pull/15485
389 2019-02-26T19:44:00  *** bitcoin-git has left #bitcoin-core-dev
390 2019-02-26T19:49:17  *** elichai2 has quit IRC
391 2019-02-26T19:54:24  *** schmidty has quit IRC
392 2019-02-26T19:57:57  *** jarthur_ has joined #bitcoin-core-dev
393 2019-02-26T20:01:01  *** jarthur has quit IRC
394 2019-02-26T20:01:40  <BlueMatt> jnewyea, the new test *also* accepts like 2k blocks at once, so understandably it may interfere
395 2019-02-26T20:01:48  <BlueMatt> it appears to have been fixed by further increasing the timeout
396 2019-02-26T20:01:52  <BlueMatt> jnewbery:
397 2019-02-26T20:06:09  <jnewbery> Consider moving assumevalid.py and the new test to EXTENDED_SCRIPTS
398 2019-02-26T20:06:23  <jnewbery> that way they wouldn't get run on Travis
399 2019-02-26T20:06:36  <sipa> do the extended tests get run anywhere automatically?
400 2019-02-26T20:06:40  <jnewbery> no :(
401 2019-02-26T20:06:49  <sipa> could we enable then for travis master builds?
402 2019-02-26T20:06:51  <jnewbery> Travis is too slow for any tests that hit disk too much
403 2019-02-26T20:06:52  <sipa> (but not PRs?)
404 2019-02-26T20:07:40  <sipa> could MarcoFalke's Drahtbot run then at some regular interval? I don't know what hardware it runs on
405 2019-02-26T20:08:28  <jnewbery> Previously, a bunch more of the tests were EXTENDED, and they got moved to BASIC
406 2019-02-26T20:08:45  <jnewbery> the EXTENDED tests were run nightly on a travis cron job, with the exception of pruning and dbcrash
407 2019-02-26T20:08:59  <jnewbery> those were too slow to be run even nightly, because the travis job would time out
408 2019-02-26T20:10:13  <gmaxwell> how long until we ship a serious bug that the extended tests would have caught?
409 2019-02-26T20:10:28  <jnewbery> It would be nice to have a non-cloud CI
410 2019-02-26T20:10:43  <jnewbery> I think a long time. Only pruning and dbcrash are extended tests now
411 2019-02-26T20:11:09  <jnewbery> There are probably more critical paths that don't have any test coverage at all
412 2019-02-26T20:11:46  *** owowo has quit IRC
413 2019-02-26T20:15:02  *** ap4lmtree has quit IRC
414 2019-02-26T20:15:34  *** ap4lmtree has joined #bitcoin-core-dev
415 2019-02-26T20:25:58  *** ap4lmtree has quit IRC
416 2019-02-26T20:27:19  *** rafalcpp_ has joined #bitcoin-core-dev
417 2019-02-26T20:28:06  *** comboy_ has quit IRC
418 2019-02-26T20:28:06  *** rafalcpp has quit IRC
419 2019-02-26T20:28:31  *** comboy has joined #bitcoin-core-dev
420 2019-02-26T20:28:51  *** wolfspraul has quit IRC
421 2019-02-26T20:28:58  *** wolfspraul has joined #bitcoin-core-dev
422 2019-02-26T20:30:01  *** bitcoin-git has joined #bitcoin-core-dev
423 2019-02-26T20:30:01  <bitcoin-git> [bitcoin] sdaftuar opened pull request #15486: [net] Allow feeler connections to go to the same netgroup as existing outbound peers (master...2019-02-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15486
424 2019-02-26T20:30:06  *** bitcoin-git has left #bitcoin-core-dev
425 2019-02-26T20:30:16  *** schmidty has joined #bitcoin-core-dev
426 2019-02-26T20:31:08  <gmaxwell> sdaftuar: dud you see the report last night that feelers were stopping?
427 2019-02-26T20:31:10  <gmaxwell> did
428 2019-02-26T20:31:27  <gmaxwell> oh you are fixing it
429 2019-02-26T20:31:32  <sdaftuar> :)
430 2019-02-26T20:31:38  <gmaxwell> ohh nice
431 2019-02-26T20:31:41  <gmaxwell> thats subtle
432 2019-02-26T20:32:10  <BlueMatt> damn, sdaftuar is smart...
433 2019-02-26T20:32:23  <gmaxwell> sorry I haven't looked this morning, been dealing with meatspace stuff.  but I probably wouldn't have figured that out anyways.
434 2019-02-26T20:32:24  <sdaftuar> luckily the reporter's logging made this easier to find... our default logging doesn't provide the ip you're colliding with
435 2019-02-26T20:34:44  *** schmidty has quit IRC
436 2019-02-26T20:37:22  <gmaxwell> Your change seems reasonable but it also seems like a really indirect fix.
437 2019-02-26T20:37:44  <sdaftuar> yeah i agree. i haven't quite wrapped my head around the addrman well enough to propose a fix there
438 2019-02-26T20:38:49  *** schmidty has joined #bitcoin-core-dev
439 2019-02-26T20:38:50  <gmaxwell> I think the tried buffer should have a maximum size and random forgetting if it overfills.
440 2019-02-26T20:38:58  <gmaxwell> I don't think addrman's behavior needs to change.
441 2019-02-26T20:39:04  <sdaftuar> i think it does?  at least, from reading the original PR it seems to
442 2019-02-26T20:39:16  <sdaftuar> the issue is that you might not have any new collisions for a long time
443 2019-02-26T20:39:23  *** jarthur_ has quit IRC
444 2019-02-26T20:39:24  <sdaftuar> so you have just one tried entry, which you have to try each time
445 2019-02-26T20:39:29  <sdaftuar> one tried collision entry i mean
446 2019-02-26T20:39:36  <sdaftuar> but then we fail because it's in the same netgroup
447 2019-02-26T20:39:51  *** jarthur has joined #bitcoin-core-dev
448 2019-02-26T20:39:55  <sdaftuar> so we could bail out differently i guess and pull from regular Select
449 2019-02-26T20:40:23  <gmaxwell> making it unconditionally remove when it makes use of it would be sufficient
450 2019-02-26T20:41:21  <sdaftuar> well, that's trickier to write i think -- i believe we use it asynchronously, so if we drained it there we'd need to put it somewhere else so that we could resolve the collision later the right way
451 2019-02-26T20:42:19  <gmaxwell> I don't think it's critical that absolutely always retry an evicted try.
452 2019-02-26T20:43:01  <gmaxwell> just so long as an attacker can't cause us to never try.
453 2019-02-26T20:43:27  <sdaftuar> i actually don't recall why we do it this way in the first place... the concern is around an attacker getting us to remove things from the tried table that we shouldn't?
454 2019-02-26T20:43:37  *** schmidty has quit IRC
455 2019-02-26T20:43:54  <sdaftuar> don't we use some kind of salted hashing or something to make that hard to do?
456 2019-02-26T20:45:08  * sdaftuar hopes ethan will pop in and fix this in some simple way
457 2019-02-26T20:57:11  <gmaxwell> sdaftuar: kind of, basically it's just creating an anti-eviction bias. In simulation it helps a lot.
458 2019-02-26T20:57:26  <gmaxwell> we resist the attacker flooding our table, but can't block it completely.
459 2019-02-26T20:57:37  <gmaxwell> So we essentially give anything that was already in there a second chance.
460 2019-02-26T20:58:28  <sdaftuar> oh, so if we looked at collisions as "if we're not sure the existing entry is bad, keep it" that's probably fine?
461 2019-02-26T20:58:56  <gmaxwell> like: we want to evict old tried data in favor of new known to be working stuff... but only because the old tried data is old and may no longer be a working node. So the idea behind try before evict is to resolve that "we don't know".
462 2019-02-26T20:59:14  <gmaxwell> If we knew an entry in tried was working we'd prefer to never evict it in favor of something new.
463 2019-02-26T21:00:14  *** booyah_ is now known as booyah
464 2019-02-26T21:04:05  <sdaftuar> (from ethan, pasting from a slack channel at his request)
465 2019-02-26T21:04:06  <sdaftuar> Ethan Heilman [3:57 PM]
466 2019-02-26T21:04:08  <sdaftuar> We make the following assumption: The addresses in the tried table contain some non-malicious addresses because if they were all malicious controlled addresses the attack has already won and you would not learn about non-malicious addresses. Based on this assumption you don't want to evict an address from the tried table if that address is still up and connectable.
467 2019-02-26T21:04:26  <sdaftuar> Ethan Heilman [3:57 PM]
468 2019-02-26T21:04:26  <sdaftuar> So we never evict an address without trying it
469 2019-02-26T21:04:27  <sdaftuar> exactly
470 2019-02-26T21:04:37  <sdaftuar> Ethan Heilman [3:59 PM]
471 2019-02-26T21:04:37  <sdaftuar> I haven't read it closely but PR #15486 seems like a reasonable fix at face value.
472 2019-02-26T21:04:38  <gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
473 2019-02-26T21:04:40  <sdaftuar> The second role of feeler connections is testing addresses in new and adding them to tried
474 2019-02-26T21:04:43  <sdaftuar> both of these purposes don't need to care about the group the address is from
475 2019-02-26T21:05:58  *** ethan_ has joined #bitcoin-core-dev
476 2019-02-26T21:05:59  <gmaxwell> right but is the fix complete? I'm concerned that if there is a persistant issue with one of the addresses that we'll get stuck on it.
477 2019-02-26T21:06:21  <gmaxwell> like, do we correctly count it as unreachable under all possibility failure conditions... clearly not currently.
478 2019-02-26T21:06:56  <gmaxwell> An alternative to your fix would be counting the grouping failure as failed, that would be dumb because feelers shouldn't be obeying the network group rule regardless.. but it would also be a fix.
479 2019-02-26T21:07:38  <ethan_> We can enumerate the ways we believe it can fail and then cover all those cases or mark it with a number of attempts uint and if that number is greater than 3 remove it
480 2019-02-26T21:08:42  <gmaxwell> My thought was just anytime we attempt to try we should remove it from the list.  Maybe this means some spurrious removals will happen, but I don't think that matters.
481 2019-02-26T21:09:10  <gmaxwell> like if 1:50 try before evicts didn't really try but evicted anyways, ... so what?
482 2019-02-26T21:09:26  <gmaxwell> network connections fail by chance sometimes too.
483 2019-02-26T21:09:46  <sdaftuar> my thought was that if something has been in the m_tried_collisions for too long, we just remove it?
484 2019-02-26T21:10:11  *** ap4lmtree has joined #bitcoin-core-dev
485 2019-02-26T21:10:18  <sdaftuar> basically add one extra condition in ResolveCollisions() where after 20 minutes or something we give up on an eviction attempt.
486 2019-02-26T21:10:47  <ethan_> that seems reasonable
487 2019-02-26T21:10:47  <sdaftuar> or do the eviction anyway, not sure which way makes more sense
488 2019-02-26T21:10:50  *** promag_ has joined #bitcoin-core-dev
489 2019-02-26T21:11:55  *** promag__ has joined #bitcoin-core-dev
490 2019-02-26T21:13:45  <ethan_> you should evict if you are failing to connect or resolve the goodness of the to-be-evicted address
491 2019-02-26T21:14:40  <ethan_> if you can't test an IP and the reason isn't because of its group, then you aren't going to be able to connect to the IP anyway and it should be evicted
492 2019-02-26T21:14:50  <sdaftuar> that's a good point
493 2019-02-26T21:15:07  *** promag_ has quit IRC
494 2019-02-26T21:22:34  *** spinza has quit IRC
495 2019-02-26T21:28:48  *** mmgen has quit IRC
496 2019-02-26T21:34:09  *** bitcoin-git has joined #bitcoin-core-dev
497 2019-02-26T21:34:09  <bitcoin-git> [bitcoin] Sjors opened pull request #15487: [WIP] descriptor based wallet  (master...2019/02/descriptor-wallet) https://github.com/bitcoin/bitcoin/pull/15487
498 2019-02-26T21:34:11  *** bitcoin-git has left #bitcoin-core-dev
499 2019-02-26T21:34:13  *** jarthur has quit IRC
500 2019-02-26T21:36:48  <sdaftuar> ethan_: gmaxwell: i updated #15486 with a timeout in ResolveCollisions
501 2019-02-26T21:36:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [net] Allow feeler connections to go to the same netgroup as existing outbound peers by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
502 2019-02-26T21:37:14  *** spinza has joined #bitcoin-core-dev
503 2019-02-26T21:37:25  *** Guyver2 has quit IRC
504 2019-02-26T21:50:50  *** jarthur has joined #bitcoin-core-dev
505 2019-02-26T21:52:35  *** DeanGuss has joined #bitcoin-core-dev
506 2019-02-26T22:01:34  *** bitcoin-git has joined #bitcoin-core-dev
507 2019-02-26T22:01:34  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14775: net: 'break' should be 'continue' here? (master...patch-6) https://github.com/bitcoin/bitcoin/pull/14775
508 2019-02-26T22:01:35  *** bitcoin-git has left #bitcoin-core-dev
509 2019-02-26T22:05:42  *** jarthur has quit IRC
510 2019-02-26T22:06:58  *** cryptapus_ is now known as cryptapus
511 2019-02-26T22:11:53  *** spinza has quit IRC
512 2019-02-26T22:20:54  *** EagleTM has quit IRC
513 2019-02-26T22:21:39  <MarcoFalke> So it is not recommended to post to the mailing list right now, because non-approved people can not post to it?
514 2019-02-26T22:22:58  *** parmado has joined #bitcoin-core-dev
515 2019-02-26T22:24:38  <sipa> i think nobody is approved
516 2019-02-26T22:25:03  <parmado> i came in as a guest, which is an option
517 2019-02-26T22:26:27  <luke-jr> parmado: the channel is intentionally open to the public; however, if you have questions about Bitcoin, #bitcoin is usually a better place to ask
518 2019-02-26T22:26:58  <parmado> thanks. is spectating okay for the time being?
519 2019-02-26T22:27:03  <sipa> of course!
520 2019-02-26T22:27:11  <parmado> thanks.
521 2019-02-26T22:28:36  <parmado> is the consensus here that bitcoin will dominate amongst electronic assets, or is there substantial disagreement on that?
522 2019-02-26T22:28:50  <sipa> parmado: #bitcoin
523 2019-02-26T22:29:16  *** timothy has quit IRC
524 2019-02-26T22:30:01  <gwillen> hmm, I just rebased a feature branch, and now loading my testnet wallet is warning me: “Warning: Error reading ! All keys read correctly, but transaction data or address book entries might be missing or incorrect.”
525 2019-02-26T22:30:52  <gwillen> I added some debug prints, and I am seeing errors when loading an object of strType="keymeta", and I am seeing lots of them, and all of them are caught exceptions (meaning that strErr="" so nothing useful prints)
526 2019-02-26T22:31:17  <gwillen> achow101: I think you touched this recently? Should I be worried either that I did something wrong, or that you did?
527 2019-02-26T22:31:27  *** darosior has joined #bitcoin-core-dev
528 2019-02-26T22:32:31  <gmaxwell> ethan_: the only kind of case where I think it might make sense to not always remove a connection from that list is when we're offline.
529 2019-02-26T22:32:47  <gmaxwell> but we don't really know when we're offline in any case..
530 2019-02-26T22:44:03  <gmaxwell> sdaftuar: you should probably add a reported by credit to the feelerfix, it's esp to do when the report was good enough to make fixing it easier/possible.
531 2019-02-26T22:44:18  <sipa> credit?
532 2019-02-26T22:44:27  <sipa> oh!
533 2019-02-26T22:44:40  *** fanquake has joined #bitcoin-core-dev
534 2019-02-26T22:44:45  <sipa> a "reported by" credit, not a reported "by credit"
535 2019-02-26T22:44:52  <gmaxwell> indeed.
536 2019-02-26T22:45:18  *** promag__ has quit IRC
537 2019-02-26T22:47:25  *** spinza has joined #bitcoin-core-dev
538 2019-02-26T22:47:46  *** fabianfabian has quit IRC
539 2019-02-26T22:50:49  *** amiti has joined #bitcoin-core-dev
540 2019-02-26T22:52:25  *** amiti has quit IRC
541 2019-02-26T22:54:04  *** schmidty has joined #bitcoin-core-dev
542 2019-02-26T22:55:23  *** schmidty has quit IRC
543 2019-02-26T22:55:32  *** DeanGuss has quit IRC
544 2019-02-26T22:55:55  *** DeanGuss has joined #bitcoin-core-dev
545 2019-02-26T22:56:36  *** jarthur has joined #bitcoin-core-dev
546 2019-02-26T22:57:17  *** Guest60674 has joined #bitcoin-core-dev
547 2019-02-26T23:01:38  *** Guest60674 has quit IRC
548 2019-02-26T23:13:20  *** darosior has quit IRC
549 2019-02-26T23:16:07  *** parmado has quit IRC
550 2019-02-26T23:18:01  *** promag_ has joined #bitcoin-core-dev
551 2019-02-26T23:31:26  <promag_> sipa: with #15402 it's possible to have concurrent invalidateblock right?
552 2019-02-26T23:31:28  <gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub