1 2019-03-16T00:14:59  *** pinheadmz has quit IRC
  2 2019-03-16T00:15:45  <gmaxwell> Anyone see a issue with adding all the IPs that have been performing the electrum coin theft attakcks to my node blacklist?
  3 2019-03-16T00:20:53  *** mn9495887 has joined #bitcoin-core-dev
  4 2019-03-16T00:21:22  *** mn9495888 has joined #bitcoin-core-dev
  5 2019-03-16T00:23:01  *** promag has joined #bitcoin-core-dev
  6 2019-03-16T00:25:12  *** mn9495887 has quit IRC
  7 2019-03-16T00:25:27  *** mn9495888 has quit IRC
  8 2019-03-16T00:27:04  *** tripleslash has quit IRC
  9 2019-03-16T00:42:03  *** promag has quit IRC
 10 2019-03-16T00:42:05  *** mn9495889 has joined #bitcoin-core-dev
 11 2019-03-16T00:42:05  *** mn949588 has joined #bitcoin-core-dev
 12 2019-03-16T00:44:55  *** promag has joined #bitcoin-core-dev
 13 2019-03-16T00:46:09  *** DeanGuss has quit IRC
 14 2019-03-16T00:46:43  *** mn9495889 has quit IRC
 15 2019-03-16T00:46:43  *** mn949588 has quit IRC
 16 2019-03-16T00:47:33  *** promag has quit IRC
 17 2019-03-16T01:03:34  *** afk11 has joined #bitcoin-core-dev
 18 2019-03-16T01:05:38  *** afk11 has joined #bitcoin-core-dev
 19 2019-03-16T01:05:38  *** afk11 has joined #bitcoin-core-dev
 20 2019-03-16T01:08:40  *** timothy has quit IRC
 21 2019-03-16T01:27:00  <midnightmagic> gmaxwell: I think that's a splendid idea.
 22 2019-03-16T01:27:34  <midnightmagic> gmaxwell: May I request some explanatory text in a comment section maybe so the groups are identifiable if you choose to head there
 23 2019-03-16T01:28:40  *** d_t has quit IRC
 24 2019-03-16T01:31:20  *** IGHOR has quit IRC
 25 2019-03-16T01:33:04  *** IGHOR has joined #bitcoin-core-dev
 26 2019-03-16T01:36:58  *** mn9495889 has joined #bitcoin-core-dev
 27 2019-03-16T01:43:56  *** jimmysong has joined #bitcoin-core-dev
 28 2019-03-16T01:46:27  *** d_t has joined #bitcoin-core-dev
 29 2019-03-16T01:53:21  <fanquake> 3 signed sigs up for rc2 so far.
 30 2019-03-16T01:56:39  *** Aaronvan_ has joined #bitcoin-core-dev
 31 2019-03-16T01:59:21  *** AaronvanW has quit IRC
 32 2019-03-16T02:00:41  *** darosior has quit IRC
 33 2019-03-16T02:30:18  *** afk11 has quit IRC
 34 2019-03-16T02:30:53  *** mn94958812 has joined #bitcoin-core-dev
 35 2019-03-16T02:31:23  *** mn94958810 has joined #bitcoin-core-dev
 36 2019-03-16T02:37:35  <warren> I apologize for not participating in gitian for a while. debootstrap has not worked on Fedora for a few years now. I'm hoping people can help https://github.com/bitcoin/bitcoin/pull/15277 so we have a deterministic buildsystem to replace gitian.
 37 2019-03-16T02:43:03  *** Aaronvan_ is now known as AaronvanW
 38 2019-03-16T02:54:08  *** pinheadmz has joined #bitcoin-core-dev
 39 2019-03-16T02:56:13  <fanquake> warren I'm writing up notes for that/using guix on macOS. Have also been working on an alpine/guix docker setup for those builds.
 40 2019-03-16T02:56:34  <sipa> nice
 41 2019-03-16T03:03:10  *** d_t has quit IRC
 42 2019-03-16T03:03:38  <warren> fanquake: awesome!
 43 2019-03-16T03:04:33  <warren> fanquake: you mean you got the osx cross-compile from linux working?
 44 2019-03-16T03:08:00  <fanquake> warren no, just getting setup to build. I started building (in an alpine container) using carls scripts, but didn't get finished, so will probably retry today.
 45 2019-03-16T03:08:24  <fanquake> I haven't read the latest out of the PR yet, so probably need to catch up on anything newish.
 46 2019-03-16T03:18:10  *** mn949588 has joined #bitcoin-core-dev
 47 2019-03-16T03:29:41  *** pinheadmz has quit IRC
 48 2019-03-16T03:55:55  <fanquake> If someone could sanity check https://github.com/fanquake/core-review/blob/master/update-assumevalid.md that'd be handy.
 49 2019-03-16T04:07:33  *** Squidicuz has joined #bitcoin-core-dev
 50 2019-03-16T04:12:59  *** shesek has quit IRC
 51 2019-03-16T04:27:08  *** OneFive has quit IRC
 52 2019-03-16T04:44:15  *** shesek has joined #bitcoin-core-dev
 53 2019-03-16T04:44:15  *** shesek has joined #bitcoin-core-dev
 54 2019-03-16T04:53:04  *** Woodsy has quit IRC
 55 2019-03-16T05:10:51  *** AaronvanW has quit IRC
 56 2019-03-16T05:40:12  *** mn9495881 has joined #bitcoin-core-dev
 57 2019-03-16T05:43:48  *** mn949588 has quit IRC
 58 2019-03-16T05:59:23  *** d_t has joined #bitcoin-core-dev
 59 2019-03-16T06:01:12  *** bitcoin-git has joined #bitcoin-core-dev
 60 2019-03-16T06:01:13  <bitcoin-git> [bitcoin] hebasto opened pull request #15609: scripts and tools: Set 'distro' explicitly (master...20190314-set-distro) https://github.com/bitcoin/bitcoin/pull/15609
 61 2019-03-16T06:01:17  *** bitcoin-git has left #bitcoin-core-dev
 62 2019-03-16T06:10:56  *** d_t has quit IRC
 63 2019-03-16T06:18:01  <hebasto> @wumpus: Hi! Regarding #15541. When you faced LXC disk size issues the cache was enabled or disabled?
 64 2019-03-16T06:18:03  <gribble> https://github.com/bitcoin/bitcoin/issues/15541 | Reproducibility issue with 0.18.0rc1 · Issue #15541 · bitcoin/bitcoin · GitHub
 65 2019-03-16T06:23:38  *** d_t has joined #bitcoin-core-dev
 66 2019-03-16T06:38:43  *** d_t has quit IRC
 67 2019-03-16T07:23:20  *** rex4539 has joined #bitcoin-core-dev
 68 2019-03-16T07:33:07  *** d_t has joined #bitcoin-core-dev
 69 2019-03-16T07:38:58  *** ccdle12 has joined #bitcoin-core-dev
 70 2019-03-16T07:40:25  <provoostenator> The MVSC (debug) build bitcoind.exe has a weird habit of occasionally pausing. E.g. in the middle of IBD I have to hit space and then it continues.
 71 2019-03-16T07:40:40  <provoostenator> Maybe it's a PowerShell issue? I don't really feel like going down that rabbit hole though...
 72 2019-03-16T07:45:46  *** d_t has quit IRC
 73 2019-03-16T08:34:04  *** DeanGuss has joined #bitcoin-core-dev
 74 2019-03-16T08:38:02  *** d_t has joined #bitcoin-core-dev
 75 2019-03-16T09:00:30  *** mmgen has joined #bitcoin-core-dev
 76 2019-03-16T09:04:22  *** kexkey has quit IRC
 77 2019-03-16T10:14:07  *** schnerchi has joined #bitcoin-core-dev
 78 2019-03-16T10:17:21  *** ExtraCrispy has quit IRC
 79 2019-03-16T10:17:22  *** schnerchi has quit IRC
 80 2019-03-16T10:27:44  *** mn9495881 has quit IRC
 81 2019-03-16T10:28:02  *** mn949588 has joined #bitcoin-core-dev
 82 2019-03-16T10:51:41  *** ExtraCrispy has joined #bitcoin-core-dev
 83 2019-03-16T10:55:38  *** spinza has quit IRC
 84 2019-03-16T11:04:10  *** spinza has joined #bitcoin-core-dev
 85 2019-03-16T11:15:39  *** jonatack has joined #bitcoin-core-dev
 86 2019-03-16T11:24:23  *** zhangzf has quit IRC
 87 2019-03-16T11:24:38  *** zhangzf has joined #bitcoin-core-dev
 88 2019-03-16T11:25:10  *** zhangzf has quit IRC
 89 2019-03-16T11:25:26  *** zhangzf has joined #bitcoin-core-dev
 90 2019-03-16T11:26:12  *** zhangzf has joined #bitcoin-core-dev
 91 2019-03-16T11:27:00  *** zhangzf has joined #bitcoin-core-dev
 92 2019-03-16T11:27:49  *** zhangzf has joined #bitcoin-core-dev
 93 2019-03-16T11:38:27  *** jonatack has quit IRC
 94 2019-03-16T11:49:44  *** promag has joined #bitcoin-core-dev
 95 2019-03-16T12:00:27  <wumpus> hebasto: I didn't change anything with regard to cache settings from the default
 96 2019-03-16T12:01:02  <wumpus> provoostenator: I vaguely remember this, no idea why though
 97 2019-03-16T12:01:09  *** promag has quit IRC
 98 2019-03-16T12:01:34  <wumpus> I guess as MSVC has a pretty good debugger it should be possible to find out where it's hanging by breaking when it happens
 99 2019-03-16T12:20:02  <fanquake> evening wumpus
100 2019-03-16T12:20:24  <wumpus> hello fanquake
101 2019-03-16T12:21:21  <fanquake> If you're doing any merging, #15609 and #15604 could go in. Probably don't really have to get the gitian build on the first pr.
102 2019-03-16T12:21:22  <gribble> https://github.com/bitcoin/bitcoin/issues/15609 | scripts and tools: Set distro explicitly by hebasto · Pull Request #15609 · bitcoin/bitcoin · GitHub
103 2019-03-16T12:21:23  <gribble> https://github.com/bitcoin/bitcoin/issues/15604 | [docs] release note for disabling reject messages by default by jnewbery · Pull Request #15604 · bitcoin/bitcoin · GitHub
104 2019-03-16T12:22:08  <fanquake> given that we should have always been getting set to "ubuntu" anyways.
105 2019-03-16T12:22:18  *** JackH has quit IRC
106 2019-03-16T12:25:06  <wumpus> yes
107 2019-03-16T12:27:20  *** bitcoin-git has joined #bitcoin-core-dev
108 2019-03-16T12:27:20  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/118a5c8d94de...cede01b41668
109 2019-03-16T12:27:21  <bitcoin-git> bitcoin/master b8705a0 Hennadii Stepanov: Set 'distro' explicitly
110 2019-03-16T12:27:21  <bitcoin-git> bitcoin/master cede01b Wladimir J. van der Laan: Merge #15609: scripts and tools: Set 'distro' explicitly
111 2019-03-16T12:27:23  *** bitcoin-git has left #bitcoin-core-dev
112 2019-03-16T12:28:10  *** bitcoin-git has joined #bitcoin-core-dev
113 2019-03-16T12:28:10  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cede01b41668...165ea14efeda
114 2019-03-16T12:28:10  <bitcoin-git> bitcoin/master 92f3e80 John Newbery: [docs] release note for disabling reject messages by default
115 2019-03-16T12:28:11  <bitcoin-git> bitcoin/master 165ea14 Wladimir J. van der Laan: Merge #15604: [docs] release note for disabling reject messages by default...
116 2019-03-16T12:28:12  *** bitcoin-git has left #bitcoin-core-dev
117 2019-03-16T12:28:26  <fanquake> There is such a long lag between the bot reporting a PR merged and GH's UI actually updating to the merged state..
118 2019-03-16T12:28:30  *** bitcoin-git has joined #bitcoin-core-dev
119 2019-03-16T12:28:30  <bitcoin-git> [bitcoin] laanwj merged pull request #15604: [docs] release note for disabling reject messages by default (master...release_notes_bip61) https://github.com/bitcoin/bitcoin/pull/15604
120 2019-03-16T12:28:31  *** bitcoin-git has left #bitcoin-core-dev
121 2019-03-16T12:28:50  *** bitcoin-git has joined #bitcoin-core-dev
122 2019-03-16T12:28:50  <bitcoin-git> [bitcoin] laanwj merged pull request #15609: scripts and tools: Set 'distro' explicitly (master...20190314-set-distro) https://github.com/bitcoin/bitcoin/pull/15609
123 2019-03-16T12:28:52  *** bitcoin-git has left #bitcoin-core-dev
124 2019-03-16T12:37:44  *** jonatack has joined #bitcoin-core-dev
125 2019-03-16T12:57:58  *** shesek has quit IRC
126 2019-03-16T13:46:21  <Sentineo> gitian build PR created, hope it is ok. I found several stuff that I was not sure what to do, so I had to guess :P
127 2019-03-16T13:48:09  <fanquake> Sentineo the sigs look ok. What issues did you run into?
128 2019-03-16T13:52:15  *** AaronvanW has joined #bitcoin-core-dev
129 2019-03-16T13:53:19  <Sentineo> I used docker as someone suggested, but had no idea how to use it. so first had to consult help of the gitian build script. Then I had trouble cloning the gitian.sigs repo (as I have no ssh key uploaded to github, that might have been the issue, but cloned it from the github page). Then the signing part of the docs was confusing. As some parts were not defined at all (e.g. $VERSION) and some
130 2019-03-16T13:53:25  <Sentineo> were static and had to remove them. But not big issue, but I guess the goal is to make it perhaps very user friendly to run, so I can create a PR for a more detailed steps, e.g. for docker.
131 2019-03-16T13:53:42  <Sentineo> I used https://github.com/bitcoin-core/docs/blob/master/gitian-building.md
132 2019-03-16T13:54:40  <Sentineo> the question is who is the target. If a developer, then the docs are fine, if a more novice user it makes a lot of assumptions about prior knowledge.
133 2019-03-16T13:56:20  *** shesek has joined #bitcoin-core-dev
134 2019-03-16T13:58:16  <fanquake> Sentineo if you have suggestions on how to make the documentation more user friendly, PRs are definitely welcome
135 2019-03-16T13:58:52  <fanquake> There is a base level of knowledge assumed, i.e cloning repositories.
136 2019-03-16T13:59:10  <fanquake> If there inconsistencies with usage of $VERSION that should be fixed up.
137 2019-03-16T13:59:17  *** brianhoffman has quit IRC
138 2019-03-16T13:59:29  *** brianhoffman has joined #bitcoin-core-dev
139 2019-03-16T14:40:58  *** Guyver2 has joined #bitcoin-core-dev
140 2019-03-16T14:44:52  *** mn949588 has quit IRC
141 2019-03-16T14:47:08  *** rex4539 has quit IRC
142 2019-03-16T14:51:33  *** jonatack has quit IRC
143 2019-03-16T14:53:24  *** DougieBot5000_ has joined #bitcoin-core-dev
144 2019-03-16T14:54:14  *** EagleTM has joined #bitcoin-core-dev
145 2019-03-16T14:56:14  *** DougieBot5000 has quit IRC
146 2019-03-16T14:59:16  *** mmgen has quit IRC
147 2019-03-16T15:00:33  *** ovovo has quit IRC
148 2019-03-16T15:01:57  *** mmgen has joined #bitcoin-core-dev
149 2019-03-16T15:03:00  *** justanotheruser has quit IRC
150 2019-03-16T15:05:47  *** profmac has quit IRC
151 2019-03-16T15:07:34  *** justanotheruser has joined #bitcoin-core-dev
152 2019-03-16T15:09:06  *** spinza has quit IRC
153 2019-03-16T15:12:05  *** OneFive has joined #bitcoin-core-dev
154 2019-03-16T15:13:21  *** OneFive_ has joined #bitcoin-core-dev
155 2019-03-16T15:14:33  *** OneFive__ has joined #bitcoin-core-dev
156 2019-03-16T15:15:16  *** dviola has joined #bitcoin-core-dev
157 2019-03-16T15:15:19  *** OneFive_ has quit IRC
158 2019-03-16T15:16:43  *** OneFive has quit IRC
159 2019-03-16T15:17:35  *** spinza has joined #bitcoin-core-dev
160 2019-03-16T15:19:06  *** profmac has joined #bitcoin-core-dev
161 2019-03-16T15:24:21  *** EagleTM has quit IRC
162 2019-03-16T15:25:57  <fanquake> carldong warren Some initial Alpine / Guix Docker instructions up here https://github.com/fanquake/core-review/blob/master/guix/guix.md
163 2019-03-16T15:26:55  <fanquake> Seems to setup ok. depends currently fails building fontconfig. Looks like maybe a permissions issue not solved by --no-same-owner ? Need to investigate some more.
164 2019-03-16T15:27:43  <fanquake> I put more info into 15277 anyways.
165 2019-03-16T15:32:05  *** stepa[m] has quit IRC
166 2019-03-16T15:32:19  *** TheFuzzStone[m] has quit IRC
167 2019-03-16T15:32:23  *** ajtowns[m] has quit IRC
168 2019-03-16T15:32:26  *** kewde[m] has quit IRC
169 2019-03-16T15:33:11  *** promag has joined #bitcoin-core-dev
170 2019-03-16T15:35:33  *** rev_strangehope has quit IRC
171 2019-03-16T15:37:31  *** rev_strangehope has joined #bitcoin-core-dev
172 2019-03-16T15:41:33  *** Inaltoasinistra has joined #bitcoin-core-dev
173 2019-03-16T15:42:05  *** ajtowns[m] has joined #bitcoin-core-dev
174 2019-03-16T15:43:34  *** Inaltoasinistra has quit IRC
175 2019-03-16T15:46:24  *** promag has quit IRC
176 2019-03-16T16:04:28  *** rex4539 has joined #bitcoin-core-dev
177 2019-03-16T16:05:54  *** kewde[m] has joined #bitcoin-core-dev
178 2019-03-16T16:05:55  *** TheFuzzStone[m] has joined #bitcoin-core-dev
179 2019-03-16T16:05:56  *** stepa[m] has joined #bitcoin-core-dev
180 2019-03-16T16:12:43  *** bitcoin-git has joined #bitcoin-core-dev
181 2019-03-16T16:12:43  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/165ea14efeda...2f501fb5c68d
182 2019-03-16T16:12:44  <bitcoin-git> bitcoin/master c7ea8d3 practicalswift: Add sizeof(size_t) assumptions
183 2019-03-16T16:12:44  <bitcoin-git> bitcoin/master c7a7250 practicalswift: Document assumptions about C++ compiler
184 2019-03-16T16:12:45  <bitcoin-git> bitcoin/master 2f501fb Wladimir J. van der Laan: Merge #15522: Document sizeof(size_t) assumptions and compiler assumptions...
185 2019-03-16T16:12:46  *** bitcoin-git has left #bitcoin-core-dev
186 2019-03-16T16:13:29  *** bitcoin-git has joined #bitcoin-core-dev
187 2019-03-16T16:13:29  <bitcoin-git> [bitcoin] laanwj merged pull request #15522: Document sizeof(size_t) assumptions and compiler assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522
188 2019-03-16T16:13:30  *** bitcoin-git has left #bitcoin-core-dev
189 2019-03-16T16:26:39  *** dermoth has joined #bitcoin-core-dev
190 2019-03-16T16:38:12  *** pinheadmz has joined #bitcoin-core-dev
191 2019-03-16T17:00:44  *** pinheadmz has quit IRC
192 2019-03-16T17:18:26  *** pinheadmz has joined #bitcoin-core-dev
193 2019-03-16T17:24:31  *** luke-jr has quit IRC
194 2019-03-16T17:26:57  *** afk11 has joined #bitcoin-core-dev
195 2019-03-16T17:26:57  *** afk11 has joined #bitcoin-core-dev
196 2019-03-16T17:27:39  *** afk11 has joined #bitcoin-core-dev
197 2019-03-16T17:32:48  *** Bullitje has quit IRC
198 2019-03-16T17:36:27  *** Bullit has joined #bitcoin-core-dev
199 2019-03-16T17:40:53  *** DougieBot5000_ is now known as DougieBot5000
200 2019-03-16T17:42:59  <provoostenator> Fwiw I succesfully used fanquake's Gitian Docker instructions on my Mac. Ideally those instructions would be added to the gitian-builder script.
201 2019-03-16T17:44:17  <provoostenator> If that script also handles the signing and pushing signatures to Github, then it might be able to catch configuration mistakes like not having an SSH setup or missing dependencies. Generally those checks are added as people run into problems themselves :-)
202 2019-03-16T17:47:00  *** promag has joined #bitcoin-core-dev
203 2019-03-16T17:51:17  *** promag has quit IRC
204 2019-03-16T17:53:38  *** owowo has joined #bitcoin-core-dev
205 2019-03-16T17:55:40  *** Aaronvan_ has joined #bitcoin-core-dev
206 2019-03-16T17:58:21  *** AaronvanW has quit IRC
207 2019-03-16T18:13:22  *** kexkey has joined #bitcoin-core-dev
208 2019-03-16T18:44:56  *** justanotheruser has quit IRC
209 2019-03-16T18:47:43  *** dviola has quit IRC
210 2019-03-16T18:48:32  *** afk11 has quit IRC
211 2019-03-16T19:00:22  *** justanotheruser has joined #bitcoin-core-dev
212 2019-03-16T19:00:24  *** rex4539 has quit IRC
213 2019-03-16T19:01:45  *** justanotheruser has quit IRC
214 2019-03-16T19:03:12  *** jonatack has joined #bitcoin-core-dev
215 2019-03-16T19:05:00  *** rex4539 has joined #bitcoin-core-dev
216 2019-03-16T19:07:26  *** ccdle12 has quit IRC
217 2019-03-16T19:16:38  *** pinheadmz has quit IRC
218 2019-03-16T19:18:28  *** pinheadmz has joined #bitcoin-core-dev
219 2019-03-16T19:32:26  <dongcarl> fanquake: I think tar is trying to set the mtime of the extracted file, but doesn’t have permission? I’m afk but there’s probably a flag to disable that
220 2019-03-16T19:32:31  *** ccdle12 has joined #bitcoin-core-dev
221 2019-03-16T19:34:56  *** mn949588 has joined #bitcoin-core-dev
222 2019-03-16T19:42:10  *** Aaronvan_ has quit IRC
223 2019-03-16T19:44:52  *** pinheadmz has quit IRC
224 2019-03-16T19:46:35  *** ccdle12 has quit IRC
225 2019-03-16T19:59:57  *** shesek has quit IRC
226 2019-03-16T20:01:32  *** pinheadmz has joined #bitcoin-core-dev
227 2019-03-16T20:05:09  *** mn949588 has quit IRC
228 2019-03-16T20:05:25  *** mn949588 has joined #bitcoin-core-dev
229 2019-03-16T20:06:25  *** arubi has quit IRC
230 2019-03-16T20:06:51  *** arubi has joined #bitcoin-core-dev
231 2019-03-16T20:12:55  *** ExtraCrispy has quit IRC
232 2019-03-16T20:23:35  *** pinheadmz has quit IRC
233 2019-03-16T20:27:00  *** AaronvanW has joined #bitcoin-core-dev
234 2019-03-16T20:28:54  *** obsrver has joined #bitcoin-core-dev
235 2019-03-16T20:31:18  <gmaxwell> brought up a node on a new IP, within 5 minutes I has 12 inbound connections... all of them were mass connectors on my published banlists...
236 2019-03-16T20:31:32  <gmaxwell> so are mass connectors chewing up >10% of inbound port capacity?
237 2019-03-16T20:40:49  *** ccdle12 has joined #bitcoin-core-dev
238 2019-03-16T20:47:18  *** promag has joined #bitcoin-core-dev
239 2019-03-16T20:48:22  *** dviola has joined #bitcoin-core-dev
240 2019-03-16T20:51:55  *** promag has quit IRC
241 2019-03-16T20:53:09  *** DeanGuss has quit IRC
242 2019-03-16T20:59:40  *** Licoche has joined #bitcoin-core-dev
243 2019-03-16T21:13:13  *** luke-jr has joined #bitcoin-core-dev
244 2019-03-16T21:17:02  *** Licoche has quit IRC
245 2019-03-16T21:18:21  *** obsrver has quit IRC
246 2019-03-16T21:20:25  *** d_t has quit IRC
247 2019-03-16T21:28:15  *** ccdle12 has quit IRC
248 2019-03-16T21:28:23  *** Guyver2 has quit IRC
249 2019-03-16T21:36:04  *** DM21 has joined #bitcoin-core-dev
250 2019-03-16T21:36:24  *** hebasto has quit IRC
251 2019-03-16T21:36:31  *** DM21 has quit IRC
252 2019-03-16T21:38:56  *** ccdle12 has joined #bitcoin-core-dev
253 2019-03-16T21:44:46  *** AaronvanW has quit IRC
254 2019-03-16T21:46:55  *** dviola has quit IRC
255 2019-03-16T21:47:48  *** d_t has joined #bitcoin-core-dev
256 2019-03-16T21:48:36  *** AaronvanW has joined #bitcoin-core-dev
257 2019-03-16T21:54:40  <provoostenator> Feedback on the (de)serialization code in #15487 would be quite useful, if anyone has time in the next couple of days.
258 2019-03-16T21:54:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15487 | [WIP] descriptor based wallet serialization and import by Sjors · Pull Request #15487 · bitcoin/bitcoin · GitHub
259 2019-03-16T21:56:07  *** jonatack has quit IRC
260 2019-03-16T21:56:39  * provoostenator goes off to unfry brain...
261 2019-03-16T21:59:39  *** EagleTM has joined #bitcoin-core-dev
262 2019-03-16T22:04:40  *** mmgen has quit IRC
263 2019-03-16T22:07:18  *** AaronvanW has quit IRC
264 2019-03-16T22:07:39  *** copumpkin has joined #bitcoin-core-dev
265 2019-03-16T22:08:03  *** justanotheruser has joined #bitcoin-core-dev
266 2019-03-16T22:08:18  *** spinza has quit IRC
267 2019-03-16T22:14:55  <gmaxwell> Does "bitcoin core" sound like "bitcoin bark" in chinese or something? https://bitcoin.stackexchange.com/questions/84185/i-was-tasked-with-installing-a-bitcoin-kernel-on-ubuntu-and-i-had-questions
268 2019-03-16T22:15:15  *** spinza has joined #bitcoin-core-dev
269 2019-03-16T22:15:52  <sipa> lol
270 2019-03-16T22:19:24  <gmaxwell> Googling shows one or two other pages also saying "bitcoin bark" but it doesn't appear to be an altcoin.
271 2019-03-16T22:24:40  <gmaxwell> okay an estonian word for "bark" is "koor"  (and presumably other languages have a similar mapping)
272 2019-03-16T22:25:01  <gmaxwell> thats kinda confusing since bark and core have sort of opposite meanings (like tree bark vs tree core)
273 2019-03-16T22:28:31  <gmaxwell> (I guess finish would be a likely candidate)
274 2019-03-16T22:29:40  *** jonatack has joined #bitcoin-core-dev
275 2019-03-16T22:30:44  <gmaxwell> (and indeed google translate says that "tree bark" is "puun kuori" in finnish)
276 2019-03-16T22:31:25  *** DeanGuss has joined #bitcoin-core-dev
277 2019-03-16T22:31:49  <luke-jr> I know of Karna, but not bark :P
278 2019-03-16T22:48:07  *** promag has joined #bitcoin-core-dev
279 2019-03-16T23:06:12  <promag> any reason to not tag #15313 0.18?
280 2019-03-16T23:06:14  <gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
281 2019-03-16T23:07:06  <gmaxwell> it's incomplete. :(
282 2019-03-16T23:07:40  <gmaxwell> 0.18 tagging will force another RC and add weeks to the release, but won't fix the other cases where the same bug exists.
283 2019-03-16T23:08:56  <promag> fixes the reported bug
284 2019-03-16T23:09:33  <promag> but yeah, no need to delay 0.18
285 2019-03-16T23:09:36  <gmaxwell> read the rest of the bug, it points out that a bunch of other versions of the same thing exists
286 2019-03-16T23:09:57  <gmaxwell> I think for 0.18 it might be better to revert #14941 which I believe introduced the crash.
287 2019-03-16T23:09:59  <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
288 2019-03-16T23:10:33  <gmaxwell> Shipping with a known easily triggerable crash isn't ideal (in partiular because the crash can corrupt your blockchain state e.g. if you do it during IBD)
289 2019-03-16T23:11:12  <gmaxwell> or alternatively disable wallet unloading with the gui up in 0.18.0.
290 2019-03-16T23:11:35  <promag> QDialog blocking calls are not recommended
291 2019-03-16T23:11:43  <promag> you can always console->unloadwallet
292 2019-03-16T23:12:07  <gmaxwell> Sure. I'm not saying that that sort of thing is a good long term fix.
293 2019-03-16T23:12:42  <promag> for RPC clients 14941 is more important IMO
294 2019-03-16T23:13:01  <gmaxwell> But in general when we find new functionality causes crashes shortly before a release we should probably favor reverting-- or applying blunt workaround like disabling a non-criticial feature-- rather than making more changes which could introduce their own bugs.
295 2019-03-16T23:14:09  <promag> true, jonas fix "looks harmless" but indeed it's too late for that
296 2019-03-16T23:14:23  <promag> I'm afraid reverting that one can open other problems
297 2019-03-16T23:17:15  <promag> btw, I meant to ask this before, but is a "-experimental=foo" option reasonable?
298 2019-03-16T23:18:12  <gmaxwell> the idea behind a reverting preference is that /generally/ whatever problems existed with the old behavior aren't that fatal-- since we have thousands and thousands of users running with them already.  this is obviously not always the case, e.g. for changes that have been in the codebase for 7 months which interact with other features...
299 2019-03-16T23:19:34  <gmaxwell> promag: maybe? depends on the thing. We've pretty commonly added new functionality and defaulted it to disabled, then enabled it in a later release, and even in some cases later removed the configuration setting.. which is functionally equivilent.  'Nesting options' is probably not ideal.
300 2019-03-16T23:20:04  <promag> or just -experimental, where a bunch of "experimental" stuff is enabled
301 2019-03-16T23:20:30  <luke-jr> promag: IMO it sounds like you're thinking of "just merge it into Knots for now" ;)
302 2019-03-16T23:20:59  <gmaxwell> I'd rather see -experimental-foo=1 than -experimental=foo.  also, I don't think we should be shipping a "bunch" of expiremental stuff generally.
303 2019-03-16T23:21:47  <promag> luke-jr: is that officially supported here?
304 2019-03-16T23:22:32  <gmaxwell> usage by users of optional features is very low from what I've seen, and they carry risk.  I think the reason we end up with stuff default off in an initial release is often when functionality was intended to get turned on but didn't quite reach enough maturity (or even when it turned out to have shortcomings at the last minute)
305 2019-03-16T23:23:10  <gmaxwell> or when it has interop impact and we want people to test with it before defaulting it on...
306 2019-03-16T23:23:45  *** ccdle12 has quit IRC
307 2019-03-16T23:25:58  <luke-jr> promag: each person can decide what they will support as usual; complicating Core with a -experimental mode wouldn't reasonably increase support though
308 2019-03-16T23:26:56  <luke-jr> (as for "here": this isn't a support channel in the first place)
309 2019-03-16T23:29:46  *** justan0theruser has joined #bitcoin-core-dev
310 2019-03-16T23:30:24  *** justan0theruser has quit IRC
311 2019-03-16T23:30:43  *** justan0theruser has joined #bitcoin-core-dev
312 2019-03-16T23:31:40  *** AaronvanW has joined #bitcoin-core-dev
313 2019-03-16T23:31:40  *** justanotheruser has quit IRC
314 2019-03-16T23:34:44  *** bitcoin-git has joined #bitcoin-core-dev
315 2019-03-16T23:34:45  <bitcoin-git> [bitcoin] droark opened pull request #15611: Add Gitian key for droark (master...master-keys-update) https://github.com/bitcoin/bitcoin/pull/15611
316 2019-03-16T23:34:58  *** bitcoin-git has left #bitcoin-core-dev
317 2019-03-16T23:35:47  *** ccdle12 has joined #bitcoin-core-dev
318 2019-03-16T23:39:51  <promag> gmaxwell: reverting 14941 requires rc3?
319 2019-03-16T23:50:02  *** EagleTM has quit IRC
320 2019-03-16T23:52:25  <promag> gmaxwell: btw, 14941 fixes #14917
321 2019-03-16T23:52:26  <gribble> https://github.com/bitcoin/bitcoin/issues/14917 | wallet_multiwallet --usecli fails with "Duplicate -wallet filename specified" · Issue #14917 · bitcoin/bitcoin · GitHub
322 2019-03-16T23:57:35  *** promag has quit IRC
323 2019-03-16T23:58:12  *** promag has joined #bitcoin-core-dev