1 2019-03-20T00:01:00 *** DeanGuss has quit IRC
2 2019-03-20T01:09:16 *** captjakk has quit IRC
3 2019-03-20T01:21:50 *** fanquake has quit IRC
4 2019-03-20T01:30:32 *** promag has quit IRC
5 2019-03-20T01:43:47 *** fanquake has joined #bitcoin-core-dev
6 2019-03-20T02:06:34 *** captjakk has joined #bitcoin-core-dev
7 2019-03-20T02:06:40 *** KevinW has joined #bitcoin-core-dev
8 2019-03-20T02:07:21 <KevinW> help
9 2019-03-20T02:08:27 *** KevinW has quit IRC
10 2019-03-20T02:13:46 *** captjakk has quit IRC
11 2019-03-20T02:43:54 *** afk11 has joined #bitcoin-core-dev
12 2019-03-20T02:45:16 *** AaronvanW has quit IRC
13 2019-03-20T02:47:26 *** afk11 has quit IRC
14 2019-03-20T02:53:10 *** dviola has joined #bitcoin-core-dev
15 2019-03-20T03:12:02 *** dviola has quit IRC
16 2019-03-20T03:25:02 *** DeanGuss has joined #bitcoin-core-dev
17 2019-03-20T03:39:44 *** makey40 has quit IRC
18 2019-03-20T03:40:09 *** makey40 has joined #bitcoin-core-dev
19 2019-03-20T03:40:33 *** Victorsueca has quit IRC
20 2019-03-20T03:41:09 *** Victorsueca has joined #bitcoin-core-dev
21 2019-03-20T03:51:27 *** pinheadmz has quit IRC
22 2019-03-20T04:10:35 *** mr_burdell_ has quit IRC
23 2019-03-20T04:11:22 *** mr_burdell has joined #bitcoin-core-dev
24 2019-03-20T04:32:00 *** Krellan has quit IRC
25 2019-03-20T04:32:28 *** Krellan has joined #bitcoin-core-dev
26 2019-03-20T04:36:43 *** Krellan has quit IRC
27 2019-03-20T05:11:33 *** luke-jr has quit IRC
28 2019-03-20T05:16:28 *** pinheadmz has joined #bitcoin-core-dev
29 2019-03-20T05:27:18 *** Dean_Guss has joined #bitcoin-core-dev
30 2019-03-20T05:30:47 *** DeanGuss has quit IRC
31 2019-03-20T05:31:29 *** Krellan has joined #bitcoin-core-dev
32 2019-03-20T05:32:48 *** luke-jr has joined #bitcoin-core-dev
33 2019-03-20T05:35:49 *** Krellan has quit IRC
34 2019-03-20T05:45:29 *** dviola has joined #bitcoin-core-dev
35 2019-03-20T06:16:54 *** cryptapus has quit IRC
36 2019-03-20T06:26:50 *** pinheadmz has quit IRC
37 2019-03-20T06:30:33 *** spaced0ut has quit IRC
38 2019-03-20T07:26:59 *** ccdle12 has joined #bitcoin-core-dev
39 2019-03-20T07:27:00 *** dviola has quit IRC
40 2019-03-20T07:48:28 *** murrayn has quit IRC
41 2019-03-20T07:49:15 *** murrayn has joined #bitcoin-core-dev
42 2019-03-20T07:49:15 *** murrayn has joined #bitcoin-core-dev
43 2019-03-20T07:52:16 *** fanquake has quit IRC
44 2019-03-20T07:56:24 *** ccdle12 has quit IRC
45 2019-03-20T07:59:27 *** murrayn has quit IRC
46 2019-03-20T07:59:28 *** pinheadmz has joined #bitcoin-core-dev
47 2019-03-20T08:04:02 *** ccdle12 has joined #bitcoin-core-dev
48 2019-03-20T08:08:10 *** promag has joined #bitcoin-core-dev
49 2019-03-20T08:11:06 *** promag has quit IRC
50 2019-03-20T08:18:48 *** pinheadmz has quit IRC
51 2019-03-20T08:19:53 *** fanquake has joined #bitcoin-core-dev
52 2019-03-20T08:29:05 *** murrayn has joined #bitcoin-core-dev
53 2019-03-20T08:34:40 *** spinza has quit IRC
54 2019-03-20T08:39:08 *** jonatack has joined #bitcoin-core-dev
55 2019-03-20T08:42:19 *** ExtraCrispy has quit IRC
56 2019-03-20T08:57:47 *** Guyver2 has joined #bitcoin-core-dev
57 2019-03-20T09:01:44 *** spinza has joined #bitcoin-core-dev
58 2019-03-20T09:04:27 *** EagleTM has joined #bitcoin-core-dev
59 2019-03-20T09:16:50 *** JackH has joined #bitcoin-core-dev
60 2019-03-20T09:19:14 *** timothy has joined #bitcoin-core-dev
61 2019-03-20T09:40:04 *** Sentineo has quit IRC
62 2019-03-20T09:55:26 *** bitcoin-git has joined #bitcoin-core-dev
63 2019-03-20T09:55:26 <bitcoin-git> [bitcoin] practicalswift opened pull request #15625: refactor: Remove unused function (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/15625
64 2019-03-20T09:55:30 *** bitcoin-git has left #bitcoin-core-dev
65 2019-03-20T10:11:45 *** promag has joined #bitcoin-core-dev
66 2019-03-20T10:16:04 *** promag has quit IRC
67 2019-03-20T10:35:16 *** spinza has quit IRC
68 2019-03-20T10:35:17 *** setpill has joined #bitcoin-core-dev
69 2019-03-20T10:36:08 *** AaronvanW has joined #bitcoin-core-dev
70 2019-03-20T10:37:36 *** setpill has joined #bitcoin-core-dev
71 2019-03-20T10:39:25 *** bitcoin-git has joined #bitcoin-core-dev
72 2019-03-20T10:39:25 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45b7f20e651...81f732bcaa30
73 2019-03-20T10:39:26 <bitcoin-git> bitcoin/master 054d01d Pieter Wuille: Do not relay banned IP addresses
74 2019-03-20T10:39:26 <bitcoin-git> bitcoin/master 81f732b Wladimir J. van der Laan: Merge #15617: p2p: Do not relay banned IP addresses
75 2019-03-20T10:39:38 *** bitcoin-git has left #bitcoin-core-dev
76 2019-03-20T10:40:10 *** bitcoin-git has joined #bitcoin-core-dev
77 2019-03-20T10:40:10 <bitcoin-git> [bitcoin] laanwj merged pull request #15617: p2p: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
78 2019-03-20T10:40:11 *** bitcoin-git has left #bitcoin-core-dev
79 2019-03-20T10:41:11 *** bitcoin-git has joined #bitcoin-core-dev
80 2019-03-20T10:41:12 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/d3a038200709...238ef3369296
81 2019-03-20T10:41:12 <bitcoin-git> bitcoin/0.18 238ef33 Pieter Wuille: Do not relay banned IP addresses
82 2019-03-20T10:41:14 *** bitcoin-git has left #bitcoin-core-dev
83 2019-03-20T10:50:53 *** JackH has quit IRC
84 2019-03-20T10:51:20 *** JackH has joined #bitcoin-core-dev
85 2019-03-20T10:58:48 *** EagleTM has quit IRC
86 2019-03-20T10:59:48 *** spinza has joined #bitcoin-core-dev
87 2019-03-20T11:03:37 *** EagleTM has joined #bitcoin-core-dev
88 2019-03-20T11:04:40 *** rex4539 has quit IRC
89 2019-03-20T11:07:04 *** bitcoin-git has joined #bitcoin-core-dev
90 2019-03-20T11:07:04 <bitcoin-git> [bitcoin] jonatack opened pull request #15626: Docs: Update ACK description in CONTRIBUTING.md (master...update-ack-description-in-contributing-md) https://github.com/bitcoin/bitcoin/pull/15626
91 2019-03-20T11:07:16 *** bitcoin-git has left #bitcoin-core-dev
92 2019-03-20T11:08:03 <wumpus> i've added the list of PRs and authors to the preliminary release notes, if someone could double-check that'd be good, https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft
93 2019-03-20T11:09:30 <fanquake> wumpus can do
94 2019-03-20T11:10:28 <fanquake> #15607 probably mergable if you agree with the changes
95 2019-03-20T11:10:29 <gribble> https://github.com/bitcoin/bitcoin/issues/15607 | [Docs] Release process updates by jonatack · Pull Request #15607 · bitcoin/bitcoin · GitHub
96 2019-03-20T11:11:30 <wumpus> (e.g. I always clean up the list and have tried to remove "silly" PRs, small refactors, and self-referential documentation ones that refer to changing the release notes, and so on, but I might have removed too much or little)
97 2019-03-20T11:11:48 *** TheRec has quit IRC
98 2019-03-20T11:12:56 <fanquake> silly PRs :o
99 2019-03-20T11:14:24 <wumpus> yes, to not have a list with 1000 times "fix typo" :)
100 2019-03-20T11:15:30 <fanquake> sounds right, release notes are quite long as is
101 2019-03-20T11:16:42 <wumpus> also it's pretty easy to miscategorize things
102 2019-03-20T11:17:17 <fanquake> just throw everything into "misc"
103 2019-03-20T11:17:35 *** TheRec has joined #bitcoin-core-dev
104 2019-03-20T11:17:35 *** TheRec has joined #bitcoin-core-dev
105 2019-03-20T11:47:11 <meshcollider> lol
106 2019-03-20T11:49:23 *** jonatack has quit IRC
107 2019-03-20T11:49:25 <wumpus> hehe
108 2019-03-20T11:52:19 *** spinza has quit IRC
109 2019-03-20T11:52:44 *** zhangzf has quit IRC
110 2019-03-20T11:58:51 <wumpus> how postmodern
111 2019-03-20T12:04:04 <wumpus> there's also still a few PRs (such as #12493) that are marked "needs release note" https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=label%3A%22Needs+release+note%22+
112 2019-03-20T12:04:06 <gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
113 2019-03-20T12:04:59 <wumpus> (though before you begin writing please check if the PR is actually part of this release, or an earlier one and somehow still has the tag! looks like there's a few of those)
114 2019-03-20T12:05:45 <fanquake> Also looks like some that we closed un-merged and still have the tag
115 2019-03-20T12:06:20 <wumpus> :$
116 2019-03-20T12:06:39 <fanquake> "TODO for release notes 0.17.0" Still "Needs release note"
117 2019-03-20T12:06:51 *** spinza has joined #bitcoin-core-dev
118 2019-03-20T12:08:08 <wumpus> reminder: remove everything from that tag after -final
119 2019-03-20T12:08:47 <fanquake> Could be another addition in #15607
120 2019-03-20T12:08:50 <gribble> https://github.com/bitcoin/bitcoin/issues/15607 | [Docs] Release process updates by jonatack · Pull Request #15607 · bitcoin/bitcoin · GitHub
121 2019-03-20T12:09:47 <wumpus> yes!
122 2019-03-20T12:11:17 *** rex4539 has joined #bitcoin-core-dev
123 2019-03-20T12:21:20 *** Aaronvan_ has joined #bitcoin-core-dev
124 2019-03-20T12:21:25 <fanquake> Ok. No more issues tagged needing release notes, and < 10 PRs left.
125 2019-03-20T12:24:24 *** AaronvanW has quit IRC
126 2019-03-20T12:29:29 <fanquake> Only 3 actually. Descriptor checksums, Reopen CDBEnv after encryption instead of shutdown & Never bind INADDR_ANY by default.
127 2019-03-20T12:51:31 *** dviola has joined #bitcoin-core-dev
128 2019-03-20T12:55:52 *** bitcoin-git has joined #bitcoin-core-dev
129 2019-03-20T12:55:53 <bitcoin-git> [bitcoin] layer1gfx opened pull request #15627: Update bitcoin_de.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15627
130 2019-03-20T12:55:54 *** bitcoin-git has left #bitcoin-core-dev
131 2019-03-20T12:57:14 *** bitcoin-git has joined #bitcoin-core-dev
132 2019-03-20T12:57:14 <bitcoin-git> [bitcoin] fanquake closed pull request #15627: Update bitcoin_de.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15627
133 2019-03-20T12:57:18 *** bitcoin-git has left #bitcoin-core-dev
134 2019-03-20T13:11:07 *** captjakk has joined #bitcoin-core-dev
135 2019-03-20T13:15:16 *** captjakk has quit IRC
136 2019-03-20T13:51:31 *** lnostdal has joined #bitcoin-core-dev
137 2019-03-20T13:52:03 *** luke-jr has quit IRC
138 2019-03-20T13:52:48 *** luke-jr has joined #bitcoin-core-dev
139 2019-03-20T13:52:48 *** luke-jr has quit IRC
140 2019-03-20T13:57:01 *** spaced0ut has joined #bitcoin-core-dev
141 2019-03-20T13:57:49 *** luke-jr has joined #bitcoin-core-dev
142 2019-03-20T13:57:49 *** luke-jr has quit IRC
143 2019-03-20T13:59:56 *** luke-jr has joined #bitcoin-core-dev
144 2019-03-20T14:00:25 *** luke-jr has quit IRC
145 2019-03-20T14:01:12 *** Krellan has joined #bitcoin-core-dev
146 2019-03-20T14:01:24 *** luke-jr has joined #bitcoin-core-dev
147 2019-03-20T14:01:35 <wumpus> fanquake: thanks for sorting them out
148 2019-03-20T14:01:51 *** luke-jr has quit IRC
149 2019-03-20T14:02:35 *** luke-jr has joined #bitcoin-core-dev
150 2019-03-20T14:03:02 *** dviola has quit IRC
151 2019-03-20T14:03:29 <wumpus> fanquake: I think we have the INADDR_ANY one; see "The rpcallowip option can no longer be used to automatically listen " under configuration option changes
152 2019-03-20T14:03:43 *** luke-jr has quit IRC
153 2019-03-20T14:04:13 *** achow101 has quit IRC
154 2019-03-20T14:05:06 *** dviola has joined #bitcoin-core-dev
155 2019-03-20T14:05:37 <wumpus> updated
156 2019-03-20T14:05:54 *** luke-jr has joined #bitcoin-core-dev
157 2019-03-20T14:05:54 *** luke-jr has quit IRC
158 2019-03-20T14:05:54 *** Krellan has quit IRC
159 2019-03-20T14:06:26 <fanquake> wumpus yes good call
160 2019-03-20T14:13:08 *** achow101 has joined #bitcoin-core-dev
161 2019-03-20T14:13:11 *** luke-jr has joined #bitcoin-core-dev
162 2019-03-20T14:13:11 *** luke-jr has quit IRC
163 2019-03-20T14:13:51 *** luke-jr has joined #bitcoin-core-dev
164 2019-03-20T14:13:51 *** luke-jr has quit IRC
165 2019-03-20T14:14:04 *** luke-jr has joined #bitcoin-core-dev
166 2019-03-20T14:14:36 *** luke-jr has quit IRC
167 2019-03-20T14:15:24 *** luke-jr has joined #bitcoin-core-dev
168 2019-03-20T14:15:58 *** luke-jr has quit IRC
169 2019-03-20T14:17:23 *** luke-jr has joined #bitcoin-core-dev
170 2019-03-20T14:17:23 *** luke-jr has quit IRC
171 2019-03-20T14:18:25 *** dviola has quit IRC
172 2019-03-20T14:18:47 *** luke-jr has joined #bitcoin-core-dev
173 2019-03-20T14:18:48 *** luke-jr has quit IRC
174 2019-03-20T14:19:30 *** luke-jr has joined #bitcoin-core-dev
175 2019-03-20T14:19:30 *** luke-jr has quit IRC
176 2019-03-20T14:20:58 *** luke-jr has joined #bitcoin-core-dev
177 2019-03-20T14:20:58 *** luke-jr has quit IRC
178 2019-03-20T14:22:35 *** luke-jr has joined #bitcoin-core-dev
179 2019-03-20T14:23:05 *** luke-jr has quit IRC
180 2019-03-20T14:31:43 *** dviola has joined #bitcoin-core-dev
181 2019-03-20T14:41:36 *** nothingmuch has joined #bitcoin-core-dev
182 2019-03-20T14:43:09 <nothingmuch> what is the purpose of NET_INTERNAL address?
183 2019-03-20T14:43:15 *** luke-jr has joined #bitcoin-core-dev
184 2019-03-20T14:43:53 *** luke-jr has quit IRC
185 2019-03-20T14:44:36 *** luke-jr has joined #bitcoin-core-dev
186 2019-03-20T14:44:51 *** zhangzf has joined #bitcoin-core-dev
187 2019-03-20T14:46:46 *** luke-jr has quit IRC
188 2019-03-20T14:50:18 <nothingmuch> (i've looked at #10466 which introduces it, but i don't understand what problem it actually solved)
189 2019-03-20T14:50:19 <gribble> https://github.com/bitcoin/bitcoin/issues/10466 | Use localhost for bitcoin · Issue #10466 · bitcoin/bitcoin · GitHub
190 2019-03-20T14:50:22 *** Aaronvan_ is now known as AaronvanW
191 2019-03-20T14:50:24 *** luke-jr has joined #bitcoin-core-dev
192 2019-03-20T14:54:59 *** luke-jr has quit IRC
193 2019-03-20T14:58:26 *** Tralfaz has joined #bitcoin-core-dev
194 2019-03-20T14:59:59 *** luke-jr has joined #bitcoin-core-dev
195 2019-03-20T15:01:13 *** EagleTM has quit IRC
196 2019-03-20T15:04:06 <nothingmuch> oops, #11512
197 2019-03-20T15:04:09 <gribble> https://github.com/bitcoin/bitcoin/issues/11512 | Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding by TheBlueMatt · Pull Request #11512 · bitcoin/bitcoin · GitHub
198 2019-03-20T15:04:51 *** luke-jr has quit IRC
199 2019-03-20T15:06:04 <nothingmuch> wait, that's not it either... sorry for spamming, too many open tabs... 10446
200 2019-03-20T15:08:33 *** captjakk has joined #bitcoin-core-dev
201 2019-03-20T15:11:17 <dongcarl> fanquake: Hey let me know if there are things I didn't address yet for your help on Guix! Too many threads haha. But the tool I linked to in https://github.com/fanquake/core-review/issues/5 should make it much easier to just use capabilities
202 2019-03-20T15:14:50 <dongcarl> nothingmuch: hey!
203 2019-03-20T15:15:02 <dongcarl> It seems like it was introduced in this commit: https://github.com/bitcoin/bitcoin/pull/10446/commits/7f31762cb6261806542cc6d1188ca07db98a6950
204 2019-03-20T15:15:27 <wumpus> nothingmuch: NET_INTERNAL is used for IP ranges that are reserved for internal networks like 192.168.*
205 2019-03-20T15:15:55 <wumpus> nothingmuch: they're not supposed to be gossiped over addr messages
206 2019-03-20T15:18:37 *** zhangzf has quit IRC
207 2019-03-20T15:21:02 <nothingmuch> wumpus: that's what i guessed when i first found it in the code (i was trying to figure out proxy selection logic), but IsInternal seems to specifically match an ipv6 private sub-range
208 2019-03-20T15:22:00 <nothingmuch> dongcarl: OH HAI!
209 2019-03-20T15:22:33 *** promag has joined #bitcoin-core-dev
210 2019-03-20T15:23:44 <dongcarl> nothingmuch: Check out `SetInternal`
211 2019-03-20T15:24:24 <nothingmuch> that's the part that got me confused ^_^
212 2019-03-20T15:26:26 *** dviola has quit IRC
213 2019-03-20T15:29:47 *** jonatack has joined #bitcoin-core-dev
214 2019-03-20T15:32:41 <wumpus> nothingmuch: SetInternal is a scheme to generate fake internal addresses for the addrdb bucketing logic
215 2019-03-20T15:35:40 <wumpus> ah yes you already had #10446, there cfields kind of explains it
216 2019-03-20T15:35:42 <gribble> https://github.com/bitcoin/bitcoin/issues/10446 | net: avoid extra dns query per seed by theuni · Pull Request #10446 · bitcoin/bitcoin · GitHub
217 2019-03-20T15:39:14 *** dviola has joined #bitcoin-core-dev
218 2019-03-20T15:43:14 <dongcarl> nothingmuch: basically, instead of having an actual IP, you have (0xFD + sha256("bitcoin")[0:5] + sha256(hostname))[0:16], which is useful in cases where you don't actually care about the IP, but the hostname, e.g. for seeds
219 2019-03-20T15:43:21 * dongcarl might be wrong
220 2019-03-20T15:44:12 <nothingmuch> i read through that explanation, but didn't understand the problem statement ("resolve an extra host")
221 2019-03-20T15:44:40 <nothingmuch> dongcarl: i think that's right, and that the goal is to get LookupHost to return an entry which would not be connected to under any circumstances
222 2019-03-20T15:45:15 <nothingmuch> but i'm still confused as to why that would happen
223 2019-03-20T15:46:29 <dongcarl> the "not be connected to under any circumstance" part is not as important as "we can identify these seeds by their hostname rather than their IP in AddrMan"
224 2019-03-20T15:47:56 <dongcarl> nothingmuch: does that make sense?
225 2019-03-20T15:50:47 <nothingmuch> hasn't clicked yet, staring hard at the call sites of SetInternal in net.cpp...
226 2019-03-20T15:52:59 <dongcarl> Okay, I'd suggest reading the commit message again, and lmk where you're stuck
227 2019-03-20T15:53:04 *** Sentineo has joined #bitcoin-core-dev
228 2019-03-20T15:53:41 *** pinheadmz has joined #bitcoin-core-dev
229 2019-03-20T15:57:18 *** luke-jr has joined #bitcoin-core-dev
230 2019-03-20T16:05:57 *** dviola has quit IRC
231 2019-03-20T16:06:53 *** dviola has joined #bitcoin-core-dev
232 2019-03-20T16:12:28 *** ccdle12 has quit IRC
233 2019-03-20T16:12:53 *** jonatack has quit IRC
234 2019-03-20T16:14:48 <nothingmuch> dongcarl: sorry, IRL distractions + thundering herd of messages... i reread the subsequent commit and it makes sense now. thanks!
235 2019-03-20T16:15:28 <dongcarl> :+1:
236 2019-03-20T16:15:38 <wumpus> yay
237 2019-03-20T16:19:22 *** ccdle12 has joined #bitcoin-core-dev
238 2019-03-20T16:24:07 *** dviola has quit IRC
239 2019-03-20T16:30:32 *** bitcoin-git has joined #bitcoin-core-dev
240 2019-03-20T16:30:32 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/81f732bcaa30...93623eea71e7
241 2019-03-20T16:30:33 <bitcoin-git> bitcoin/master fa11c03 MarcoFalke: refactor: Expose UndoReadFromDisk in header
242 2019-03-20T16:30:33 <bitcoin-git> bitcoin/master 93623ee MarcoFalke: Merge #15623: refactor: Expose UndoReadFromDisk in header
243 2019-03-20T16:30:35 *** bitcoin-git has left #bitcoin-core-dev
244 2019-03-20T16:31:22 *** bitcoin-git has joined #bitcoin-core-dev
245 2019-03-20T16:31:22 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15623: refactor: Expose UndoReadFromDisk in header (master...1903-UndoReadFromDiskHeader) https://github.com/bitcoin/bitcoin/pull/15623
246 2019-03-20T16:31:25 *** bitcoin-git has left #bitcoin-core-dev
247 2019-03-20T16:37:13 *** jarthur has joined #bitcoin-core-dev
248 2019-03-20T16:46:40 *** RMHysMagus has joined #bitcoin-core-dev
249 2019-03-20T16:48:46 *** luke-jr has quit IRC
250 2019-03-20T16:48:52 *** lukedashjr has joined #bitcoin-core-dev
251 2019-03-20T16:49:04 *** captjakk has quit IRC
252 2019-03-20T16:53:22 *** lukedashjr is now known as luke-jr
253 2019-03-20T16:55:00 *** lukedashjr has joined #bitcoin-core-dev
254 2019-03-20T16:58:55 *** luke-jr has quit IRC
255 2019-03-20T16:59:29 *** ThomasLuong has joined #bitcoin-core-dev
256 2019-03-20T16:59:40 *** lukedashjr is now known as luke-jr
257 2019-03-20T17:01:25 *** captjakk has joined #bitcoin-core-dev
258 2019-03-20T17:02:10 *** captjakk has joined #bitcoin-core-dev
259 2019-03-20T17:08:48 *** luke-jr has quit IRC
260 2019-03-20T17:09:21 *** luke-jr has joined #bitcoin-core-dev
261 2019-03-20T17:11:00 *** setpill has quit IRC
262 2019-03-20T17:15:17 *** lukedashjr has joined #bitcoin-core-dev
263 2019-03-20T17:16:03 *** luke-jr has quit IRC
264 2019-03-20T17:21:13 *** lukedashjr has quit IRC
265 2019-03-20T17:24:31 *** luke-jr has joined #bitcoin-core-dev
266 2019-03-20T18:00:03 *** instagibbs has quit IRC
267 2019-03-20T18:06:06 *** RMHysMagus has quit IRC
268 2019-03-20T18:07:34 *** PowPos has joined #bitcoin-core-dev
269 2019-03-20T18:07:57 <PowPos> https://discord.gg/QWrUrv
270 2019-03-20T18:08:03 <PowPos> Guys there's a PoW vs PoS debate
271 2019-03-20T18:08:08 <PowPos> With Kyle Samani from Multicoin
272 2019-03-20T18:08:14 <PowPos> and Will Martino from Kadena
273 2019-03-20T18:08:17 <PowPos> Live at the moment
274 2019-03-20T18:08:22 <PowPos> Would love to have you guys come in
275 2019-03-20T18:08:33 <sipa> stop spamming
276 2019-03-20T18:09:03 <PowPos> Sorry about that
277 2019-03-20T18:09:04 *** instagibbs has joined #bitcoin-core-dev
278 2019-03-20T18:29:41 *** PowPos has quit IRC
279 2019-03-20T18:30:48 *** valwal has quit IRC
280 2019-03-20T18:31:32 *** hsmiths has quit IRC
281 2019-03-20T18:31:32 *** Isthmus has quit IRC
282 2019-03-20T18:31:48 *** Isthmus_ has joined #bitcoin-core-dev
283 2019-03-20T18:31:54 *** rodarmor has quit IRC
284 2019-03-20T18:32:16 *** jl2012 has quit IRC
285 2019-03-20T18:34:58 *** rodarmor has joined #bitcoin-core-dev
286 2019-03-20T18:40:41 *** hsmiths has joined #bitcoin-core-dev
287 2019-03-20T18:43:54 *** valwal has joined #bitcoin-core-dev
288 2019-03-20T18:45:40 *** jl2012 has joined #bitcoin-core-dev
289 2019-03-20T19:01:52 *** qrestlove has quit IRC
290 2019-03-20T19:02:39 <mischa010> hi, compact blocks seems to reduce orphan rates by ~75%, would there happen to be a source somewhere stating this?:p
291 2019-03-20T19:05:42 *** dqx_ has quit IRC
292 2019-03-20T19:08:53 <sipa> mischa010: does not compute
293 2019-03-20T19:09:14 <sipa> block propagation shouldn't affect tx relay i think
294 2019-03-20T19:09:30 *** dqx_ has joined #bitcoin-core-dev
295 2019-03-20T19:10:01 <sipa> oh, you mean orphan blocks
296 2019-03-20T19:12:31 *** bitcoin-git has joined #bitcoin-core-dev
297 2019-03-20T19:12:33 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/93623eea71e7...bbc436e09ef1
298 2019-03-20T19:12:33 <bitcoin-git> bitcoin/master 0d9d2b3 Jon Atack: Doc: update ACK description in CONTRIBUTING.md
299 2019-03-20T19:12:33 <bitcoin-git> bitcoin/master bbc436e Wladimir J. van der Laan: Merge #15626: Docs: Update ACK description in CONTRIBUTING.md
300 2019-03-20T19:12:36 *** bitcoin-git has left #bitcoin-core-dev
301 2019-03-20T19:13:12 *** dqx_ has quit IRC
302 2019-03-20T19:13:20 *** bitcoin-git has joined #bitcoin-core-dev
303 2019-03-20T19:13:20 <bitcoin-git> [bitcoin] laanwj merged pull request #15626: Docs: Update ACK description in CONTRIBUTING.md (master...update-ack-description-in-contributing-md) https://github.com/bitcoin/bitcoin/pull/15626
304 2019-03-20T19:13:21 *** bitcoin-git has left #bitcoin-core-dev
305 2019-03-20T19:34:19 *** captjakk has quit IRC
306 2019-03-20T19:35:20 *** captjakk has joined #bitcoin-core-dev
307 2019-03-20T19:35:50 *** captjakk has joined #bitcoin-core-dev
308 2019-03-20T19:36:56 *** bitcoin-git has joined #bitcoin-core-dev
309 2019-03-20T19:36:57 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbc436e09ef1...b3f82284ba90
310 2019-03-20T19:36:57 <bitcoin-git> bitcoin/master ef0019e Patrick Strateman: Generate log entry when blocks messages are received unexpectedly.
311 2019-03-20T19:36:57 <bitcoin-git> bitcoin/master b3f8228 Wladimir J. van der Laan: Merge #15597: net: Generate log entry when blocks messages are received un...
312 2019-03-20T19:37:07 *** bitcoin-git has left #bitcoin-core-dev
313 2019-03-20T19:37:43 *** bitcoin-git has joined #bitcoin-core-dev
314 2019-03-20T19:37:43 <bitcoin-git> [bitcoin] laanwj merged pull request #15597: net: Generate log entry when blocks messages are received unexpectedly (master...2019-03-12-net-unexpected-block) https://github.com/bitcoin/bitcoin/pull/15597
315 2019-03-20T19:37:44 *** bitcoin-git has left #bitcoin-core-dev
316 2019-03-20T19:39:24 *** bitcoin-git has joined #bitcoin-core-dev
317 2019-03-20T19:39:26 <bitcoin-git> [bitcoin] laanwj pushed 18 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/392d1382c1b1...6cf81b01b48e
318 2019-03-20T19:39:26 <bitcoin-git> bitcoin/0.17 f455979 Andrew Chow: Add function to close all Db's and reload the databae environment
319 2019-03-20T19:39:27 <bitcoin-git> bitcoin/0.17 048fda2 Andrew Chow: After encrypting the wallet, reload the database environment
320 2019-03-20T19:39:28 <bitcoin-git> bitcoin/0.17 435df68 Andrew Chow: Move BerkeleyEnvironment deletion from internal method to callsite
321 2019-03-20T19:39:36 *** bitcoin-git has left #bitcoin-core-dev
322 2019-03-20T19:39:37 *** dqx_ has joined #bitcoin-core-dev
323 2019-03-20T19:39:39 *** pinheadmz has quit IRC
324 2019-03-20T19:39:53 *** bitcoin-git has joined #bitcoin-core-dev
325 2019-03-20T19:39:53 <bitcoin-git> [bitcoin] laanwj merged pull request #15575: 0.17: Backport 15297 (0.17...2019-03-backport-15297-017) https://github.com/bitcoin/bitcoin/pull/15575
326 2019-03-20T19:39:55 *** bitcoin-git has left #bitcoin-core-dev
327 2019-03-20T19:40:58 *** pinheadmz has joined #bitcoin-core-dev
328 2019-03-20T19:41:45 <gmaxwell> 12:02:39 < mischa010> hi, compact blocks seems to reduce orphan rates by ~75%, would there happen to be a source somewhere stating this?:p
329 2019-03-20T19:42:07 <gmaxwell> 75% sounds like a really low figure, I believe the effect is greater than that.
330 2019-03-20T19:44:27 *** captjakk has quit IRC
331 2019-03-20T19:44:37 *** dqx_ has quit IRC
332 2019-03-20T19:48:17 *** dqx_ has joined #bitcoin-core-dev
333 2019-03-20T19:52:32 *** dqx_ has quit IRC
334 2019-03-20T19:53:51 *** captjakk has joined #bitcoin-core-dev
335 2019-03-20T19:57:59 *** ThomasLuong has quit IRC
336 2019-03-20T20:11:21 *** captjakk has quit IRC
337 2019-03-20T20:11:55 *** captjakk has joined #bitcoin-core-dev
338 2019-03-20T20:14:58 *** captjakk has quit IRC
339 2019-03-20T20:15:33 *** captjakk has joined #bitcoin-core-dev
340 2019-03-20T20:24:16 *** dqx_ has joined #bitcoin-core-dev
341 2019-03-20T20:28:20 *** qrestlove has joined #bitcoin-core-dev
342 2019-03-20T20:31:20 *** bitcoin-git has joined #bitcoin-core-dev
343 2019-03-20T20:31:20 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15629: init: Throw error when network specific config is ignored (master...1903-InitErrorConf) https://github.com/bitcoin/bitcoin/pull/15629
344 2019-03-20T20:31:25 *** bitcoin-git has left #bitcoin-core-dev
345 2019-03-20T20:32:50 *** promag has quit IRC
346 2019-03-20T20:47:32 *** schmidty_ has quit IRC
347 2019-03-20T20:56:44 *** ccdle12 has quit IRC
348 2019-03-20T21:02:07 *** hebasto has joined #bitcoin-core-dev
349 2019-03-20T21:02:23 *** ghost43 has quit IRC
350 2019-03-20T21:05:55 <dongcarl> Trying to understand qt: at a high level, the user-visible options are in `OptionsModel` whereas the non-user-visible ones are kept in `gArgs`, right?
351 2019-03-20T21:07:24 <dongcarl> (of course there's interactions between them but... just talking in general)
352 2019-03-20T21:09:59 <ryanofsky> most options will be in gArgs regardless, optionsmodel.cpp will set them there
353 2019-03-20T21:11:22 <ryanofsky> only settings that aren't in gargs are things that are gui specific like minimize to tray
354 2019-03-20T21:13:46 *** Tralfaz has quit IRC
355 2019-03-20T21:14:01 <dongcarl> ryanofsky: I see. When we have multiprocess bitcoin, will it be an interface violation for optionsmodel.cpp to include net.h?
356 2019-03-20T21:16:57 <ryanofsky> for now yeah. i was kind of overzealous in #10244 and changed qt to only access gArgs indirectly through the Node interface
357 2019-03-20T21:17:00 <gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
358 2019-03-20T21:17:41 <ryanofsky> i want to change that to get some simplifications, but for now it is the current state
359 2019-03-20T21:19:25 *** bitcoin-git has joined #bitcoin-core-dev
360 2019-03-20T21:19:25 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15631: qa: mininode: Clearer error message on invalid magic bytes (master...1903-qaMagicMininode) https://github.com/bitcoin/bitcoin/pull/15631
361 2019-03-20T21:19:26 *** bitcoin-git has left #bitcoin-core-dev
362 2019-03-20T21:19:42 *** schmidty has joined #bitcoin-core-dev
363 2019-03-20T21:20:22 <ryanofsky> if you know what problem you want to solve, i can point you in the right direction. last thing I heard about #14856, is that you wanted to have multiple connmans in a single gui, but that didn't quite make sense to me
364 2019-03-20T21:20:25 <gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl · Pull Request #14856 · bitcoin/bitcoin · GitHub
365 2019-03-20T21:24:36 *** schmidty has quit IRC
366 2019-03-20T21:34:57 *** hebasto has quit IRC
367 2019-03-20T21:44:25 *** ccdle12 has joined #bitcoin-core-dev
368 2019-03-20T22:00:54 *** spinza has quit IRC
369 2019-03-20T22:08:04 *** ap4lmtree has left #bitcoin-core-dev
370 2019-03-20T22:09:14 *** cryptapus has joined #bitcoin-core-dev
371 2019-03-20T22:09:14 *** cryptapus has quit IRC
372 2019-03-20T22:09:14 *** cryptapus has joined #bitcoin-core-dev
373 2019-03-20T22:10:11 *** Guyver2 has quit IRC
374 2019-03-20T22:17:16 *** bitcoin-git has joined #bitcoin-core-dev
375 2019-03-20T22:17:16 <bitcoin-git> [bitcoin] jnewbery opened pull request #15632: Remove ResendWalletTransactions from the Validation Interface (master...no_resend_wallet_txs) https://github.com/bitcoin/bitcoin/pull/15632
376 2019-03-20T22:17:19 *** bitcoin-git has left #bitcoin-core-dev
377 2019-03-20T22:21:28 *** spinza has joined #bitcoin-core-dev
378 2019-03-20T22:27:11 *** jarthur has quit IRC
379 2019-03-20T22:32:29 <mischa010> [20:42] <gmaxwell> 75% sounds like a really low figure, I believe the effect is greater than that.
380 2019-03-20T22:32:46 <mischa010> has anyone done measurements that i can look at?
381 2019-03-20T22:33:28 <sipa> it's kind of hard to test, as it depends on ecosystem adoption and not just what the test nodes do
382 2019-03-20T22:33:30 *** promag has joined #bitcoin-core-dev
383 2019-03-20T22:33:54 <sipa> and there are certainly historical measurements, but those are also influenced by other factors
384 2019-03-20T22:34:56 <mischa010> i did a linear regression on an orphan blocks per 2 days bar chart
385 2019-03-20T22:35:02 <mischa010> https://imgur.com/a/1KrkOQm
386 2019-03-20T22:35:10 <mischa010> please excuse the lack of binning, im still working on it
387 2019-03-20T22:35:29 <sipa> is this just your own node?
388 2019-03-20T22:35:58 <mischa010> no the data is from blockchain.info
389 2019-03-20T22:36:02 <mischa010> https://www.blockchain.com/charts/n-orphaned-blocks?timespan=all&daysAverageString=1&scale=0
390 2019-03-20T22:36:35 <mischa010> the fit seems to show an approximately 75% decrease since compact blocks were merged
391 2019-03-20T22:36:51 <mischa010> but as you said, lots of other factors influence it of course
392 2019-03-20T22:37:30 *** ghost43 has joined #bitcoin-core-dev
393 2019-03-20T22:37:43 *** promag has quit IRC
394 2019-03-20T22:37:44 <mischa010> adoption, verification speed, read/write speed
395 2019-03-20T22:37:50 <mischa010> correct?
396 2019-03-20T22:38:10 <sipa> miner topology
397 2019-03-20T22:38:15 <sipa> decentralization of hashpower
398 2019-03-20T22:38:24 <sipa> validationless mining
399 2019-03-20T22:38:29 <sipa> fibre deployment
400 2019-03-20T22:38:52 <mischa010> thanks
401 2019-03-20T22:40:01 <mischa010> btw measurements seem to go to zero somewhere in 2017, i wonder if they stopped collecting data or orphan rate actually went to zero :p
402 2019-03-20T22:42:11 *** dviola has joined #bitcoin-core-dev
403 2019-03-20T22:48:40 *** pinheadmz has quit IRC
404 2019-03-20T22:50:08 *** pinheadmz has joined #bitcoin-core-dev
405 2019-03-20T22:51:58 *** pinheadmz has joined #bitcoin-core-dev
406 2019-03-20T22:57:44 <gmaxwell> mischa010: it's not zero, I assume you're looking at blockchain.info which basically gives garbage data.
407 2019-03-20T22:57:49 <gmaxwell> they aren't even trying.
408 2019-03-20T22:58:50 <gmaxwell> orphaning is caused by latency at many different places in the stack, orphaning related to non-propagation causes doesn't propagate well, and so its difficult to observe.
409 2019-03-20T22:59:10 <gmaxwell> if you look from only one node/geography you'll only see a tiny fraction of it.
410 2019-03-20T22:59:31 <gmaxwell> for some reason bc.i doesn't even show that much, I'd guess their collection is just broken entirely.
411 2019-03-20T23:01:33 *** ccdle12 has quit IRC
412 2019-03-20T23:03:37 <mischa010> thanks, it's the best data i could find
413 2019-03-20T23:03:55 <mischa010> so nice to have a list of reasons to explain divergence of my results
414 2019-03-20T23:04:22 <mischa010> \difference from prediction
415 2019-03-20T23:06:03 *** hsmiths has quit IRC
416 2019-03-20T23:07:59 <mischa010> also blocks weren't full in 2014!
417 2019-03-20T23:09:39 <gmaxwell> This has much better data: https://twitter.com/tillneu/status/1076034211872677888
418 2019-03-20T23:12:52 <midnightmagic> holy moly.
419 2019-03-20T23:13:08 <midnightmagic> look at that.
420 2019-03-20T23:15:01 *** ccdle12 has joined #bitcoin-core-dev
421 2019-03-20T23:21:10 *** schmidty has joined #bitcoin-core-dev
422 2019-03-20T23:26:12 *** schmidty has quit IRC
423 2019-03-20T23:34:29 <mischa010> thanks gmaxwell
424 2019-03-20T23:37:56 *** ccdle12 has quit IRC