1 2019-03-24T00:22:22  *** Aaronvan_ has joined #bitcoin-core-dev
  2 2019-03-24T00:25:40  *** AaronvanW has quit IRC
  3 2019-03-24T00:27:00  <belcher> a slight nuance with electrum is it sends hashes of scriptpubkeys, so addresses which are never used stay hidden (of course thats not much better)
  4 2019-03-24T00:36:44  <luke-jr> it does? the protocol spec just has actual addresses though?
  5 2019-03-24T00:40:00  <gmaxwell> belcher: Keeping your irrelevant secrets safe!
  6 2019-03-24T00:41:46  <belcher> luke-jr even if the the protocol supports it, electrum only uses scripthash when requesting
  7 2019-03-24T00:41:53  <belcher> gmaxwell :D
  8 2019-03-24T00:42:08  *** spinza has quit IRC
  9 2019-03-24T00:45:05  <sipa> jonasschnelli: in the v2 p2p bip, 02 pubkeys are even and 03 ones are odd
 10 2019-03-24T00:52:06  *** spinza has joined #bitcoin-core-dev
 11 2019-03-24T00:56:44  *** zhangzf has joined #bitcoin-core-dev
 12 2019-03-24T01:11:46  *** farmerwampum_ has joined #bitcoin-core-dev
 13 2019-03-24T01:14:24  *** farmerwampum__ has quit IRC
 14 2019-03-24T01:19:44  <ghost43> to clarify, electrum used to send addresses to servers, but around the time bip173 was published, the protocol was changed to sha256(scriptPubKey), to abstract away addresses
 15 2019-03-24T01:38:41  <gmaxwell> I wasn't aware of that until belcher mentioned it above, but it doesn't have any privacy implication.. just allows the protocol to work independantly of address encodings.
 16 2019-03-24T01:40:28  *** pinheadmz has quit IRC
 17 2019-03-24T01:47:30  *** pinheadmz has joined #bitcoin-core-dev
 18 2019-03-24T01:48:03  <ghost43> privacy was not a motivation at all. and you are right. I could come up with contrived counterexamples though; like having an address in a forum signature that never receives a transaction, and subscribing to an electrum server; the server would not be able to tie the two identities together. :P
 19 2019-03-24T01:48:33  <ghost43> oh wait that does not work either, lol
 20 2019-03-24T01:49:13  *** zhangzf has quit IRC
 21 2019-03-24T01:58:30  *** DeanGuss has quit IRC
 22 2019-03-24T01:58:37  *** Aaronvan_ is now known as AaronvanW
 23 2019-03-24T01:58:56  *** DeanGuss has joined #bitcoin-core-dev
 24 2019-03-24T02:15:39  *** mn94958852 has joined #bitcoin-core-dev
 25 2019-03-24T02:15:39  *** mn949588 has joined #bitcoin-core-dev
 26 2019-03-24T02:19:24  *** mn94958848 has quit IRC
 27 2019-03-24T02:19:24  *** mn94958851 has quit IRC
 28 2019-03-24T02:26:49  *** zhangzf has joined #bitcoin-core-dev
 29 2019-03-24T02:31:58  *** zhangzf has quit IRC
 30 2019-03-24T02:32:44  *** zhangzf has joined #bitcoin-core-dev
 31 2019-03-24T02:34:54  *** mn94958853 has joined #bitcoin-core-dev
 32 2019-03-24T02:34:54  *** mn94958849 has joined #bitcoin-core-dev
 33 2019-03-24T02:38:22  <luke-jr> Lightsword: AIUI, Bitpay rejects payments if they see the transaction broadcast before they get it
 34 2019-03-24T02:38:46  *** mn94958852 has quit IRC
 35 2019-03-24T02:38:47  *** mn949588 has quit IRC
 36 2019-03-24T02:45:33  <gmaxwell> 09:03:15 < wumpus> gmaxwell: that said, not finding *one* working node in 20+ hours is unexpected I think
 37 2019-03-24T02:45:50  <gmaxwell> thats my thought.... if it was two hours I wouldn't have been surprised.
 38 2019-03-24T02:49:35  <promag> one line review: #15474
 39 2019-03-24T02:49:36  <gribble> https://github.com/bitcoin/bitcoin/issues/15474 | rest/rpc: Make mempoolinfo atomic by promag · Pull Request #15474 · bitcoin/bitcoin · GitHub
 40 2019-03-24T02:49:38  *** Emcy has quit IRC
 41 2019-03-24T02:50:24  <gmaxwell> really thats a hundred thousand line review... it changes locking. :P
 42 2019-03-24T02:51:06  <promag> x)
 43 2019-03-24T02:51:39  <promag> you might enjoy this one then #15463
 44 2019-03-24T02:51:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub
 45 2019-03-24T02:51:46  <gmaxwell> (I guess not really since presumably all the things it calls except DynamicMemoryUsage are trivial)
 46 2019-03-24T03:13:04  *** AaronvanW has quit IRC
 47 2019-03-24T03:16:39  *** DeanGuss has quit IRC
 48 2019-03-24T03:28:03  *** pinheadmz has quit IRC
 49 2019-03-24T03:47:45  *** Prad has joined #bitcoin-core-dev
 50 2019-03-24T04:23:07  *** Prad has quit IRC
 51 2019-03-24T04:32:58  *** EagleTM has quit IRC
 52 2019-03-24T04:34:18  *** Emcy has joined #bitcoin-core-dev
 53 2019-03-24T05:09:14  *** whiteface has joined #bitcoin-core-dev
 54 2019-03-24T05:10:36  *** Randolf has joined #bitcoin-core-dev
 55 2019-03-24T05:11:20  *** rex4539 has joined #bitcoin-core-dev
 56 2019-03-24T05:11:21  <whiteface> which wallet is the best?
 57 2019-03-24T05:12:06  <Randolf> whiteface: That question is better-suited for the #bitcoin channel.
 58 2019-03-24T05:12:51  <whiteface> thank you
 59 2019-03-24T05:13:29  <Randolf> You're welcome.
 60 2019-03-24T05:32:35  <fanquake_> Chris_Stewart_5 Could you take a look at #14853? I've dropped the Travis related commit.
 61 2019-03-24T05:32:37  <gribble> https://github.com/bitcoin/bitcoin/issues/14853 | depends: latest RapidCheck by fanquake · Pull Request #14853 · bitcoin/bitcoin · GitHub
 62 2019-03-24T06:15:02  *** murrayn has quit IRC
 63 2019-03-24T06:16:55  *** whiteface has quit IRC
 64 2019-03-24T06:18:24  *** murrayn has joined #bitcoin-core-dev
 65 2019-03-24T06:18:24  *** murrayn has joined #bitcoin-core-dev
 66 2019-03-24T06:30:01  *** zhangzf has quit IRC
 67 2019-03-24T06:36:05  *** rex4539 has quit IRC
 68 2019-03-24T06:37:38  *** rex4539 has joined #bitcoin-core-dev
 69 2019-03-24T06:37:59  *** zhangzf has joined #bitcoin-core-dev
 70 2019-03-24T06:48:30  *** zhangzf has quit IRC
 71 2019-03-24T06:48:35  *** zhangzf_ has joined #bitcoin-core-dev
 72 2019-03-24T06:50:03  *** harrymm has quit IRC
 73 2019-03-24T06:59:33  *** TheHoliestRoger has quit IRC
 74 2019-03-24T07:02:10  *** TheHoliestRoger has joined #bitcoin-core-dev
 75 2019-03-24T07:03:44  *** harrymm has joined #bitcoin-core-dev
 76 2019-03-24T07:04:20  *** pinheadmz has joined #bitcoin-core-dev
 77 2019-03-24T07:08:42  *** hebasto has joined #bitcoin-core-dev
 78 2019-03-24T07:21:26  *** wzhroho has joined #bitcoin-core-dev
 79 2019-03-24T07:24:27  *** zhangzf_ has quit IRC
 80 2019-03-24T07:25:04  *** zhangzf has joined #bitcoin-core-dev
 81 2019-03-24T07:28:56  *** rex4539 has quit IRC
 82 2019-03-24T07:29:40  *** zhangzf has quit IRC
 83 2019-03-24T07:30:42  *** wzhroho has quit IRC
 84 2019-03-24T07:47:22  *** DeanGuss has joined #bitcoin-core-dev
 85 2019-03-24T08:18:49  *** zhangzf has joined #bitcoin-core-dev
 86 2019-03-24T08:24:44  *** wzhroho has joined #bitcoin-core-dev
 87 2019-03-24T08:25:53  *** pinheadmz has quit IRC
 88 2019-03-24T08:46:25  *** wzhroho has quit IRC
 89 2019-03-24T08:46:29  *** rex4539 has joined #bitcoin-core-dev
 90 2019-03-24T08:48:38  *** harrymm has quit IRC
 91 2019-03-24T09:00:54  *** harrymm has joined #bitcoin-core-dev
 92 2019-03-24T09:22:18  *** mn949588 has joined #bitcoin-core-dev
 93 2019-03-24T09:22:30  *** mn94958850 has joined #bitcoin-core-dev
 94 2019-03-24T09:25:48  *** mn94958853 has quit IRC
 95 2019-03-24T09:26:14  *** mn94958849 has quit IRC
 96 2019-03-24T10:14:17  *** spinza has quit IRC
 97 2019-03-24T10:20:43  *** bitcoin-git has joined #bitcoin-core-dev
 98 2019-03-24T10:20:44  <bitcoin-git> [bitcoin] promag closed pull request #13189: Remove 2nd mapTx lookup in CTxMemPool::removeForBlock (master...2018-05-txmempool-removeforblock) https://github.com/bitcoin/bitcoin/pull/13189
 99 2019-03-24T10:20:47  *** bitcoin-git has left #bitcoin-core-dev
100 2019-03-24T10:23:38  *** obsrver has joined #bitcoin-core-dev
101 2019-03-24T10:42:51  *** spinza has joined #bitcoin-core-dev
102 2019-03-24T11:38:07  *** Ocsivit has joined #bitcoin-core-dev
103 2019-03-24T11:45:58  *** jonatack has joined #bitcoin-core-dev
104 2019-03-24T12:17:53  *** jonatack has quit IRC
105 2019-03-24T12:21:17  *** Ocsivit has quit IRC
106 2019-03-24T12:43:06  *** AaronvanW has joined #bitcoin-core-dev
107 2019-03-24T12:47:03  *** jonatack has joined #bitcoin-core-dev
108 2019-03-24T13:13:54  *** zhangzf has quit IRC
109 2019-03-24T13:17:38  *** zhangzf has joined #bitcoin-core-dev
110 2019-03-24T13:22:52  *** zhangzf has quit IRC
111 2019-03-24T13:24:49  *** zhangzf has joined #bitcoin-core-dev
112 2019-03-24T13:39:04  *** EagleTM has joined #bitcoin-core-dev
113 2019-03-24T13:47:06  <fanquake_> "Shutdown hangs a bit in IBD"
114 2019-03-24T13:47:18  <promag> yes?
115 2019-03-24T13:47:19  <fanquake_> very technical promag :p
116 2019-03-24T13:47:24  <promag> :D
117 2019-03-24T13:47:30  <promag> you tell me :p
118 2019-03-24T13:48:36  <promag> fanquake_: in the 1st log you see it hangs for 19 seconds
119 2019-03-24T13:49:27  <promag> something is blocking the shutdown
120 2019-03-24T13:49:49  <echeveria> isn't that expected, to flush the cache to disk?
121 2019-03-24T13:50:47  <promag> from a clean datadir, launch and wait for some connections, then ctrl-c
122 2019-03-24T13:51:45  <promag> echeveria: I don't think it could take 20 seconds, especially right on the begin
123 2019-03-24T13:52:01  <promag> echeveria: my system is also quite fast
124 2019-03-24T13:55:48  <harding> Took 8 seconds here from after initial connections established but before the first updatetip, on a fresh datadir with master.
125 2019-03-24T13:56:08  <promag> harding: thanks
126 2019-03-24T13:56:15  <echeveria> promag: I mean, I can get it to take like 4 seconds to shut down if I attempt a connection, SIGINT, and then it waits briefly for the timeout.
127 2019-03-24T13:57:04  <harding> Here's the big gap in my log: 2019-03-24T13:54:31Z msghand thread exit
128 2019-03-24T13:57:04  <harding> 2019-03-24T13:54:39Z opencon thread exit
129 2019-03-24T13:57:16  <promag> I don't see a reason to hold that long
130 2019-03-24T13:57:19  <echeveria> 2019-03-24T13:56:37.732765Z Shutdown: In progress...
131 2019-03-24T13:57:19  <echeveria> 2019-03-24T13:56:41.248476Z Shutdown: done
132 2019-03-24T13:58:34  <echeveria> sort of pales in comparison to most people's time to dump to disk. unless its holding up tests or hitting systemd timeouts I don't see it as an issue particularly.
133 2019-03-24T14:00:23  <promag> echeveria: if this happens in travis/appveyor then I think it could be improved
134 2019-03-24T14:01:13  <promag> there are at least 2 "interruptNet.sleep_for(std::chrono::seconds" in the code
135 2019-03-24T14:03:45  *** zhangzf_ has joined #bitcoin-core-dev
136 2019-03-24T14:03:48  *** zhangzf has quit IRC
137 2019-03-24T14:10:39  *** jonatack has quit IRC
138 2019-03-24T14:16:07  <gmaxwell> promag: travis storage is insanely slow, flushing takes forever.
139 2019-03-24T14:16:20  <gmaxwell> taking 19 seconds is expected.
140 2019-03-24T14:16:39  <promag> I'm seeing this locally
141 2019-03-24T14:17:10  <promag> but not always, I'm trying to figure out what is causing it
142 2019-03-24T14:17:21  <gmaxwell> turn debug=1 and see if you can see the cause from that?
143 2019-03-24T14:17:28  <promag> yap
144 2019-03-24T14:18:08  <promag> but sometimes in travis/appveyor there are random failures when stopping test nodes
145 2019-03-24T14:18:13  <gmaxwell> your statement about it doing to right away surprises me, but if you said you waited log enough for dbcache to fill I wouldn't be shocked if it took minutes.
146 2019-03-24T14:20:48  <promag> gmaxwell: first of all, I only observe this in mainnet
147 2019-03-24T14:21:06  <promag> clear datadir etc
148 2019-03-24T14:21:21  <promag> bitcoind -debug
149 2019-03-24T14:21:44  <gmaxwell> promag: thats consistent with it being actual flushing that makes it take time.
150 2019-03-24T14:21:56  <gmaxwell> (and the assc. fsyncs)
151 2019-03-24T14:22:50  *** zhangzf_ has quit IRC
152 2019-03-24T14:23:34  *** zhangzf has joined #bitcoin-core-dev
153 2019-03-24T14:24:05  <promag> gmaxwell: see https://github.com/bitcoin/bitcoin/issues/15657#issuecomment-475964106
154 2019-03-24T14:25:16  <gmaxwell> so it was waiting on the dnsseed lookups to finish.
155 2019-03-24T14:30:39  <promag> gmaxwell: oh, but is it LookupHost that takes so long?
156 2019-03-24T14:32:18  <gmaxwell> It certantly can, it waits on the network.
157 2019-03-24T14:43:26  *** EagleTM has quit IRC
158 2019-03-24T14:48:02  <gmaxwell> has anyone noticed the github web ui being a lot slower recently or is it just me?
159 2019-03-24T14:51:08  <gmaxwell> harding: re your question on the mailing list about the transport BIP:   it's hard to coordinate ID assignment.   The initial BIP obviously can just do so.
160 2019-03-24T14:51:46  <harding> gmaxwell: yeah, that's what I didn't understand, why the initial BIP doesn't just do it.
161 2019-03-24T14:52:10  <harding> (Especially since it is doing it for three of the messages.)
162 2019-03-24T14:52:12  <gmaxwell> harding: one alternative would be that any further assignments are negoiated at connect time, then variable length could be ignored... but expecting all future messages to get static one byte asignments wouldn't be realistic.
163 2019-03-24T14:58:50  <harding> I guess.  I know there's been some contention over things like getdata msg_type between different node implementations before, but 200+ free values seems like enough space that everyone could just get along (or at least specify what they expect via version messages).  Perhaps I'm being too optimistic though.
164 2019-03-24T15:02:00  <harding> Oh, I guess with encryption and, hopefully, subsequent authentication, we could be expecting to see private extensions to P2P, which could significantly increase the number of message types.  Maybe then it does make more sense to have negotiation.
165 2019-03-24T15:02:52  <echeveria> is there any actually used implementation of a bitcoin node other than btcd and bitcoin core?
166 2019-03-24T15:05:25  <gmaxwell> harding: it's just too hard process wise to allocate ids.
167 2019-03-24T15:05:34  <gmaxwell> like even just cordinating expiremental use...
168 2019-03-24T15:05:53  <harding> echeveria: not that I'm aware of at the moment.  I was thinking about 2015-17 contention between Bitcoin Core and some of the stuff Unlimited was doing.  Also XT had BIP64 support and a different protocol version.
169 2019-03-24T15:06:11  <gmaxwell> but negoiation is probably sufficient, I don't really see needing to have more than 256 message types, esp since a message type can be an extended-type-message
170 2019-03-24T15:06:13  <harding> gmaxwell: fair enough.  I've seen enough food fights about BIP numbers.
171 2019-03-24T15:07:52  <gmaxwell> But I can see an argument that the complexity of variable types would better be spent on negoiation, since thats eventually needed in any case... but like consider a message like "sendheaders" ... there is really no reason to give it a shortid.
172 2019-03-24T15:08:49  <gmaxwell> so even if there were no variable length types, I think there would need to be one or more "option messages" that could be used for things like send headers, and then thats just introducing a variable length type, but maybe at a different 'layer'
173 2019-03-24T15:09:10  <gmaxwell> (and maybe making it a different layer is a good idea)
174 2019-03-24T15:11:51  <echeveria> harding: the only other one I was thinking of was Parity Bitcoin, and they seemed to have only been funded to create that for a very short period.
175 2019-03-24T15:15:21  <gmaxwell> harding: aside, I kinda worry that too much debate about the shortids will just get them dropped from the protocol... because they're not that important.  But I think that would be a bit sad.
176 2019-03-24T15:15:37  <harding> gmaxwell: thanks for explaining.  It looked to me like unnecessary complexity, but as long as there's a reasonable use for it (eliminating developer time wasted coordinating allocation), I'm fine with it.
177 2019-03-24T15:16:02  <gmaxwell> harding: yeah, I think that serves a purpose.
178 2019-03-24T15:16:33  <gmaxwell> (you might want to follow up on the list, I'm not on it anymore)
179 2019-03-24T15:16:46  <harding> :-(  Ok.
180 2019-03-24T15:17:22  <gmaxwell> (ironically, one of the relatively few cases where I think replying would be useful happens shortly after I unsub :P )
181 2019-03-24T16:21:29  *** Guyver2 has joined #bitcoin-core-dev
182 2019-03-24T16:31:39  *** zhangzf has quit IRC
183 2019-03-24T16:43:54  *** pinheadmz has joined #bitcoin-core-dev
184 2019-03-24T16:52:33  *** jonatack has joined #bitcoin-core-dev
185 2019-03-24T17:39:23  *** Randolf has quit IRC
186 2019-03-24T17:40:22  *** wzhroho has joined #bitcoin-core-dev
187 2019-03-24T17:40:42  *** dario_ has joined #bitcoin-core-dev
188 2019-03-24T17:50:54  *** wzhroho has quit IRC
189 2019-03-24T17:59:15  *** hebasto has quit IRC
190 2019-03-24T18:13:39  *** harrymm has quit IRC
191 2019-03-24T18:34:14  *** harrymm has joined #bitcoin-core-dev
192 2019-03-24T19:20:48  *** promag has quit IRC
193 2019-03-24T19:36:37  *** obsrver has quit IRC
194 2019-03-24T19:44:02  *** bitcoin-git has joined #bitcoin-core-dev
195 2019-03-24T19:44:02  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14050: Add chacha20/poly1305 and chacha20poly1305_AEAD from openssh (master...2018/08/bip151_chachapoly1305) https://github.com/bitcoin/bitcoin/pull/14050
196 2019-03-24T19:44:04  *** bitcoin-git has left #bitcoin-core-dev
197 2019-03-24T19:57:35  *** hibye has joined #bitcoin-core-dev
198 2019-03-24T20:07:46  *** Randolf has joined #bitcoin-core-dev
199 2019-03-24T20:55:02  *** owowo has quit IRC
200 2019-03-24T21:00:02  *** owowo has joined #bitcoin-core-dev
201 2019-03-24T21:00:02  *** owowo has joined #bitcoin-core-dev
202 2019-03-24T21:14:31  *** hibye has quit IRC
203 2019-03-24T21:15:51  *** spinza has quit IRC
204 2019-03-24T21:17:46  *** Randolf has quit IRC
205 2019-03-24T21:19:38  *** z has joined #bitcoin-core-dev
206 2019-03-24T21:20:01  *** z is now known as Guest80974
207 2019-03-24T21:21:28  *** promag has joined #bitcoin-core-dev
208 2019-03-24T21:22:31  *** Guyver2 has quit IRC
209 2019-03-24T21:23:01  *** rh0nj has quit IRC
210 2019-03-24T21:24:07  *** rh0nj has joined #bitcoin-core-dev
211 2019-03-24T21:25:52  *** spinza has joined #bitcoin-core-dev
212 2019-03-24T21:25:52  *** promag has quit IRC
213 2019-03-24T21:28:24  *** wzhroho has joined #bitcoin-core-dev
214 2019-03-24T22:03:14  *** bitcoin-git has joined #bitcoin-core-dev
215 2019-03-24T22:03:14  <bitcoin-git> [bitcoin] r8921039 opened pull request #15659: [docs] fix findFork comment (master...fix_findFork_comment) https://github.com/bitcoin/bitcoin/pull/15659
216 2019-03-24T22:03:15  *** bitcoin-git has left #bitcoin-core-dev
217 2019-03-24T22:20:52  *** bitcoin-git has joined #bitcoin-core-dev
218 2019-03-24T22:20:52  <bitcoin-git> [bitcoin] sdaftuar opened pull request #15660: [qa] Overhaul p2p_compactblocks.py (master...2019-03-refactor-p2p-compactblocks-2) https://github.com/bitcoin/bitcoin/pull/15660
219 2019-03-24T22:20:54  *** bitcoin-git has left #bitcoin-core-dev
220 2019-03-24T22:22:43  *** dermoth has quit IRC
221 2019-03-24T22:23:16  *** dermoth has joined #bitcoin-core-dev
222 2019-03-24T22:23:40  <jonasschnelli> harding: I wrote a reply to your mailing list mail but it seem to not appear? any ideas?
223 2019-03-24T22:24:09  <sipa> jonasschnelli: it takes a while
224 2019-03-24T22:24:22  <sipa> all mails are manually approved
225 2019-03-24T22:25:55  <jonasschnelli> Ah. I just saw that the discussion he had with Greg was 8h ago.. okay. fine
226 2019-03-24T22:32:36  *** wzhroho has quit IRC
227 2019-03-24T22:37:44  *** spinza has quit IRC
228 2019-03-24T22:51:45  *** spinza has joined #bitcoin-core-dev
229 2019-03-24T22:58:22  *** justanotheruser has quit IRC
230 2019-03-24T23:34:26  *** dermoth has quit IRC
231 2019-03-24T23:35:13  *** dermoth has joined #bitcoin-core-dev
232 2019-03-24T23:42:03  *** AaronvanW has quit IRC
233 2019-03-24T23:53:38  <fanquake_> Who has access to bitcoincore.org, and could address #15658 ? cfields?
234 2019-03-24T23:53:39  <gribble> https://github.com/bitcoin/bitcoin/issues/15658 | depends: files missing from bitcoincore.org fallback · Issue #15658 · bitcoin/bitcoin · GitHub
235 2019-03-24T23:59:09  *** AaronvanW has joined #bitcoin-core-dev