12019-04-12T00:06:43  *** davterra has quit IRC
  22019-04-12T00:11:22  *** captjakk has quit IRC
  32019-04-12T00:15:45  *** jonatack has quit IRC
  42019-04-12T00:29:38  *** Emcy has quit IRC
  52019-04-12T00:38:22  *** DeanGuss has joined #bitcoin-core-dev
  62019-04-12T00:38:43  *** elichai2 has quit IRC
  72019-04-12T00:39:08  *** Emcy has joined #bitcoin-core-dev
  82019-04-12T00:53:15  *** Demian- has joined #bitcoin-core-dev
  92019-04-12T01:18:41  *** bitcoin-git has joined #bitcoin-core-dev
 102019-04-12T01:18:42  <bitcoin-git> [bitcoin] JimmyMow opened pull request #15802: doc: create application support bitcoin folder (master...fix/macos-docs) https://github.com/bitcoin/bitcoin/pull/15802
 112019-04-12T01:18:42  *** bitcoin-git has left #bitcoin-core-dev
 122019-04-12T01:19:25  *** Tralfaz has joined #bitcoin-core-dev
 132019-04-12T01:42:14  *** bitcoin-git has joined #bitcoin-core-dev
 142019-04-12T01:42:14  <bitcoin-git> [bitcoin] meshcollider opened pull request #15803: [0.18] Backport 15749: importmulti only imports origin info for PKH outputs (0.18...201904_backport_15749) https://github.com/bitcoin/bitcoin/pull/15803
 152019-04-12T01:42:16  *** bitcoin-git has left #bitcoin-core-dev
 162019-04-12T01:57:06  *** Emcy has quit IRC
 172019-04-12T02:01:56  *** Emcy has joined #bitcoin-core-dev
 182019-04-12T02:09:13  *** fanquake has joined #bitcoin-core-dev
 192019-04-12T02:13:26  *** EagleTM has joined #bitcoin-core-dev
 202019-04-12T02:17:43  *** EagleTM has quit IRC
 212019-04-12T02:27:41  *** AaronvanW has quit IRC
 222019-04-12T02:48:41  *** chriswang2019 has joined #bitcoin-core-dev
 232019-04-12T02:51:09  *** davterra has joined #bitcoin-core-dev
 242019-04-12T02:51:27  *** Tralfaz has quit IRC
 252019-04-12T02:53:00  *** Emcy has quit IRC
 262019-04-12T03:00:58  *** chriswang2019 has quit IRC
 272019-04-12T03:01:42  *** fanquake has quit IRC
 282019-04-12T03:07:46  *** Emcy has joined #bitcoin-core-dev
 292019-04-12T03:53:35  *** riperk has quit IRC
 302019-04-12T04:03:04  *** brianhoffman has quit IRC
 312019-04-12T04:04:22  *** brianhoffman has joined #bitcoin-core-dev
 322019-04-12T04:31:43  *** ranefer has quit IRC
 332019-04-12T04:46:51  *** Squidicc has joined #bitcoin-core-dev
 342019-04-12T04:46:51  *** Squidicuz has quit IRC
 352019-04-12T05:22:19  *** Demian- has quit IRC
 362019-04-12T05:35:17  *** ghost43 has quit IRC
 372019-04-12T05:36:08  *** chriswang2019 has joined #bitcoin-core-dev
 382019-04-12T05:39:53  *** ghost43 has joined #bitcoin-core-dev
 392019-04-12T05:42:51  *** captjakk has joined #bitcoin-core-dev
 402019-04-12T05:47:27  *** captjakk has quit IRC
 412019-04-12T06:04:15  *** chriswang2019 has quit IRC
 422019-04-12T07:06:20  *** gertjaap has quit IRC
 432019-04-12T07:06:31  *** nsh has quit IRC
 442019-04-12T07:06:31  *** bosma has quit IRC
 452019-04-12T07:06:31  *** Liliaceae has quit IRC
 462019-04-12T07:06:35  *** gertjaap has joined #bitcoin-core-dev
 472019-04-12T07:06:44  *** Liliaceae has joined #bitcoin-core-dev
 482019-04-12T07:06:44  *** bosma has joined #bitcoin-core-dev
 492019-04-12T07:07:02  *** Taek has quit IRC
 502019-04-12T07:07:08  *** Taek has joined #bitcoin-core-dev
 512019-04-12T07:24:01  *** nsh has joined #bitcoin-core-dev
 522019-04-12T08:00:28  *** berndj has quit IRC
 532019-04-12T08:00:42  *** berndj has joined #bitcoin-core-dev
 542019-04-12T08:01:36  *** promag has joined #bitcoin-core-dev
 552019-04-12T08:06:04  *** promag has quit IRC
 562019-04-12T08:10:44  *** lnostdal has quit IRC
 572019-04-12T08:23:33  *** bitcoin-git has joined #bitcoin-core-dev
 582019-04-12T08:23:33  <bitcoin-git> [bitcoin] practicalswift opened pull request #15805: log: Increase signal-to-noise in bitcoind standard output. Don't print debug output "Pre-allocating to position ..." and "Leaving block file ..." when running with -nodebug (default). (master...stdout-signal-to-noise) https://github.com/bitcoin/bitcoin/pull/15805
 592019-04-12T08:23:34  *** bitcoin-git has left #bitcoin-core-dev
 602019-04-12T08:46:46  *** Zenton has joined #bitcoin-core-dev
 612019-04-12T08:52:40  *** bitcoin-git has joined #bitcoin-core-dev
 622019-04-12T08:52:41  <bitcoin-git> [bitcoin] practicalswift opened pull request #15806: contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py (master...remove-SUSPICIOUS_HOSTS) https://github.com/bitcoin/bitcoin/pull/15806
 632019-04-12T08:52:43  *** bitcoin-git has left #bitcoin-core-dev
 642019-04-12T08:55:58  <gmaxwell> uh
 652019-04-12T08:58:32  *** mnl has joined #bitcoin-core-dev
 662019-04-12T08:59:26  *** promag has joined #bitcoin-core-dev
 672019-04-12T09:02:23  *** timothy has joined #bitcoin-core-dev
 682019-04-12T09:21:22  *** bitcoin-git has joined #bitcoin-core-dev
 692019-04-12T09:21:22  <bitcoin-git> [bitcoin] practicalswift closed pull request #15806: contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py (master...remove-SUSPICIOUS_HOSTS) https://github.com/bitcoin/bitcoin/pull/15806
 702019-04-12T09:21:23  *** bitcoin-git has left #bitcoin-core-dev
 712019-04-12T09:24:32  *** rex4539 has quit IRC
 722019-04-12T09:32:08  *** lnostdal has joined #bitcoin-core-dev
 732019-04-12T09:44:56  *** chriswang2019 has joined #bitcoin-core-dev
 742019-04-12T09:49:13  *** captjakk has joined #bitcoin-core-dev
 752019-04-12T09:53:46  *** captjakk has quit IRC
 762019-04-12T10:05:26  *** chriswang2019 has quit IRC
 772019-04-12T10:07:19  *** ghost43_ has joined #bitcoin-core-dev
 782019-04-12T10:07:51  *** ghost43 has quit IRC
 792019-04-12T10:11:39  *** promag has quit IRC
 802019-04-12T10:11:49  *** ghost43_ has quit IRC
 812019-04-12T10:12:35  *** promag has joined #bitcoin-core-dev
 822019-04-12T10:13:57  *** ghost43 has joined #bitcoin-core-dev
 832019-04-12T10:16:33  *** fanquake has joined #bitcoin-core-dev
 842019-04-12T10:17:13  <fanquake> Am looking forward to playing around with --enable-experimental-rust
 852019-04-12T10:21:53  *** promag has quit IRC
 862019-04-12T10:23:45  *** jonatack has joined #bitcoin-core-dev
 872019-04-12T10:25:25  *** ghost43 has quit IRC
 882019-04-12T10:31:54  *** ghost43 has joined #bitcoin-core-dev
 892019-04-12T10:33:54  *** rex4539 has joined #bitcoin-core-dev
 902019-04-12T10:48:16  *** spinza has quit IRC
 912019-04-12T10:58:52  *** spinza has joined #bitcoin-core-dev
 922019-04-12T11:03:31  *** setpill has joined #bitcoin-core-dev
 932019-04-12T11:30:34  *** laptop500 has joined #bitcoin-core-dev
 942019-04-12T11:54:01  *** shesek has joined #bitcoin-core-dev
 952019-04-12T11:54:01  *** shesek has quit IRC
 962019-04-12T11:54:01  *** shesek has joined #bitcoin-core-dev
 972019-04-12T12:01:15  *** jonatack has quit IRC
 982019-04-12T12:19:39  *** cryptapus has quit IRC
 992019-04-12T12:20:28  *** cryptapus has joined #bitcoin-core-dev
1002019-04-12T12:20:29  *** cryptapus has quit IRC
1012019-04-12T12:20:29  *** cryptapus has joined #bitcoin-core-dev
1022019-04-12T12:58:28  *** AaronvanW has joined #bitcoin-core-dev
1032019-04-12T13:01:35  *** qrestlove has quit IRC
1042019-04-12T13:06:33  *** bsm117532 has joined #bitcoin-core-dev
1052019-04-12T13:07:24  <bsm117532> BlueMatt: ported your BetterHash mining server code to 0.18: https://github.com/mcelrath/bitcoin/tree/betterhash_bob
1062019-04-12T13:07:27  <bsm117532> Anyone using this?
1072019-04-12T13:08:25  <bsm117532> Will be pointing miners at it in the next few days.
1082019-04-12T13:25:38  *** lio17 has quit IRC
1092019-04-12T13:26:07  *** lio17 has joined #bitcoin-core-dev
1102019-04-12T13:26:35  *** _Sam-- has quit IRC
1112019-04-12T13:40:59  *** mnl has quit IRC
1122019-04-12T13:41:42  *** chriswang2019 has joined #bitcoin-core-dev
1132019-04-12T13:46:51  *** Aaronvan_ has joined #bitcoin-core-dev
1142019-04-12T13:49:36  *** AaronvanW has quit IRC
1152019-04-12T13:49:52  *** chriswang2019 has quit IRC
1162019-04-12T13:56:49  *** rex4539 has quit IRC
1172019-04-12T14:00:38  *** rex4539 has joined #bitcoin-core-dev
1182019-04-12T14:02:14  *** Technoquake has joined #bitcoin-core-dev
1192019-04-12T14:02:43  *** rex4539 has quit IRC
1202019-04-12T14:03:10  *** rex4539 has joined #bitcoin-core-dev
1212019-04-12T14:09:54  *** laptop500 has quit IRC
1222019-04-12T14:15:02  *** ranefer has joined #bitcoin-core-dev
1232019-04-12T14:27:59  <BlueMatt> bsm117532: nice! I'll follow up over the weekend
1242019-04-12T14:29:34  *** pinheadmz has quit IRC
1252019-04-12T14:47:36  *** ranefer has quit IRC
1262019-04-12T14:47:55  *** ranefer has joined #bitcoin-core-dev
1272019-04-12T14:51:20  *** ranefer has left #bitcoin-core-dev
1282019-04-12T15:03:28  *** asoltys_ has left #bitcoin-core-dev
1292019-04-12T15:34:10  *** pinheadmz has joined #bitcoin-core-dev
1302019-04-12T15:40:18  *** setpill has quit IRC
1312019-04-12T15:44:34  *** Guyver2 has joined #bitcoin-core-dev
1322019-04-12T15:47:49  *** captjakk has joined #bitcoin-core-dev
1332019-04-12T16:28:50  *** millerti has joined #bitcoin-core-dev
1342019-04-12T16:32:37  *** ppisati has quit IRC
1352019-04-12T16:40:03  *** ppisati has joined #bitcoin-core-dev
1362019-04-12T16:45:47  *** owowo has joined #bitcoin-core-dev
1372019-04-12T16:51:18  *** captjakk has quit IRC
1382019-04-12T16:51:23  *** bitcoin-git has joined #bitcoin-core-dev
1392019-04-12T16:51:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e9cb2d24dbf...66ce95a43400
1402019-04-12T16:51:24  <bitcoin-git> bitcoin/master fa2dfbf MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
1412019-04-12T16:51:24  <bitcoin-git> bitcoin/master 66ce95a MarcoFalke: Merge #15797: travis: Bump second timeout to 33 minutes, Add rationale
1422019-04-12T16:51:26  *** bitcoin-git has left #bitcoin-core-dev
1432019-04-12T16:52:12  *** bitcoin-git has joined #bitcoin-core-dev
1442019-04-12T16:52:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15797: travis: Bump second timeout to 33 minutes, Add rationale (master...1904-travisTime) https://github.com/bitcoin/bitcoin/pull/15797
1452019-04-12T16:52:13  *** bitcoin-git has left #bitcoin-core-dev
1462019-04-12T16:54:09  *** dviola has joined #bitcoin-core-dev
1472019-04-12T17:01:07  *** Aaronvan_ has quit IRC
1482019-04-12T17:01:45  *** captjakk has joined #bitcoin-core-dev
1492019-04-12T17:04:06  *** captjakk_ has joined #bitcoin-core-dev
1502019-04-12T17:05:40  *** AaronvanW has joined #bitcoin-core-dev
1512019-04-12T17:08:39  *** captjakk has quit IRC
1522019-04-12T17:09:27  *** ghost43 has quit IRC
1532019-04-12T17:12:45  *** ghost43 has joined #bitcoin-core-dev
1542019-04-12T17:18:55  *** promag has joined #bitcoin-core-dev
1552019-04-12T17:26:28  <instagibbs> MarcoFalke, re #15797 is this the "no output seen" timeout?
1562019-04-12T17:26:30  <gribble> https://github.com/bitcoin/bitcoin/issues/15797 | travis: Bump second timeout to 33 minutes, Add rationale by MarcoFalke · Pull Request #15797 · bitcoin/bitcoin · GitHub
1572019-04-12T17:26:56  <MarcoFalke> nah, the 50 min timeout
1582019-04-12T17:27:14  *** captjakk_ has quit IRC
1592019-04-12T17:27:48  <MarcoFalke> All tests are busy printing at least every 10 minutes, so the "no output seen" should never be hit
1602019-04-12T17:29:13  *** captjakk has joined #bitcoin-core-dev
1612019-04-12T17:29:40  *** captjakk has joined #bitcoin-core-dev
1622019-04-12T17:31:14  *** hebasto has joined #bitcoin-core-dev
1632019-04-12T17:31:52  *** Technoquake has quit IRC
1642019-04-12T17:32:03  *** timothy has quit IRC
1652019-04-12T17:32:48  *** niska has quit IRC
1662019-04-12T17:34:07  *** captjakk has quit IRC
1672019-04-12T17:37:58  *** niska has joined #bitcoin-core-dev
1682019-04-12T17:41:21  *** Zenton has quit IRC
1692019-04-12T17:41:28  *** promag has quit IRC
1702019-04-12T17:47:38  <jnewbery> I think there's a wallet meeting in just over an hour today. If so, I have one #proposedmeetingtopic : Upgrade wallet (#15761). There's already been some discussion in the PR
1712019-04-12T17:47:40  <gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
1722019-04-12T17:51:43  *** pinheadmz has quit IRC
1732019-04-12T17:52:26  *** pinheadmz has joined #bitcoin-core-dev
1742019-04-12T17:54:20  *** schmidty_ has quit IRC
1752019-04-12T17:54:38  *** schmidty has joined #bitcoin-core-dev
1762019-04-12T17:59:55  *** jonatack has joined #bitcoin-core-dev
1772019-04-12T17:59:57  *** chriswang2019 has joined #bitcoin-core-dev
1782019-04-12T18:19:13  *** captjakk has joined #bitcoin-core-dev
1792019-04-12T18:20:47  *** captjakk has joined #bitcoin-core-dev
1802019-04-12T18:26:35  *** chriswang2019 has quit IRC
1812019-04-12T18:29:49  *** chriswang2019 has joined #bitcoin-core-dev
1822019-04-12T18:44:21  *** millerti has quit IRC
1832019-04-12T18:46:47  *** chriswang2019 has quit IRC
1842019-04-12T18:50:18  <achow101> #proposedmeetingtopic native descriptor wallets (#15761)
1852019-04-12T18:50:20  <gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
1862019-04-12T18:50:34  <achow101> ehh, #15764
1872019-04-12T18:50:36  <gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
1882019-04-12T19:00:04  <meshcollider> #startmeeting
1892019-04-12T19:00:04  <lightningbot> Meeting started Fri Apr 12 19:00:04 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
1902019-04-12T19:00:04  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
1912019-04-12T19:00:07  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
1922019-04-12T19:00:11  <jnewbery> hi
1932019-04-12T19:01:10  <achow101> hi
1942019-04-12T19:01:35  <meshcollider> #topic : Upgrade wallet (#15761) (jnewbery)
1952019-04-12T19:01:37  <gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
1962019-04-12T19:02:14  <kanzure> hi
1972019-04-12T19:02:26  <jnewbery> This PR is to replace the -upgradewallet startup option, which is great news
1982019-04-12T19:03:01  <jnewbery> achow is proposing to replace it with an RPC. There were a couple of other suggestions on what to replace it with in the PR and I wanted to poll for opinions
1992019-04-12T19:03:10  <achow101> I think the primary question is RPC, wallet-tool command, or both
2002019-04-12T19:03:30  <achow101> I prefer both
2012019-04-12T19:03:47  <jnewbery> I'm slightly concerned about having an RPC that can upgrade at any time. I just feel that it might introduce subtle corner cases if the wallet is doing something else at the time
2022019-04-12T19:04:16  <jnewbery> but I might be wrong. Perhaps it's fine
2032019-04-12T19:04:44  <achow101> the whole operation is locked, and any operations on the wallet are also locked, so I don't think that's really a problem
2042019-04-12T19:04:47  <jnewbery> (I'm definitely a big concept ACK on moving away from startup option)
2052019-04-12T19:05:28  <kanzure> does upgradewallet replace the wallet or does it create an upgraded wallet only?
2062019-04-12T19:05:40  <achow101> kanzure: it just upgrades the wallet file
2072019-04-12T19:05:52  <luke-jr> could be only allowed when loading
2082019-04-12T19:06:03  <meshcollider> I'm in favour of both too
2092019-04-12T19:06:50  <jnewbery> luke-jr: that's one suggestion in the PR. Another option would be to only allow it on wallets that aren't currently loaded.
2102019-04-12T19:07:11  <jnewbery> (ie separate upgrade from running entirely)
2112019-04-12T19:07:13  <achow101> jnewbery: what if upgradewallet unloads it, upgrades, then reloads it
2122019-04-12T19:07:29  <achow101> that would disconnect all of the signals and stuff that would cause issues
2132019-04-12T19:07:34  <kanzure> need lock during upgrade
2142019-04-12T19:07:38  <kanzure> so that they don't reopen
2152019-04-12T19:07:52  <kanzure> in achow101's flow.
2162019-04-12T19:08:16  <jnewbery> Should we encourage users to backup before they upgrade?
2172019-04-12T19:08:30  <meshcollider> kanzure: I think thats the current behavior anyway
2182019-04-12T19:08:53  <kanzure> meshcollider: ok, i thought the lock only applies to loaded wallets. nevermind.
2192019-04-12T19:09:29  <achow101> kanzure: meshcollider: in the idea I just proposed, you would have to lock something to prevent loading the wallet during upgarde
2202019-04-12T19:09:35  <luke-jr> jnewbery: at least after
2212019-04-12T19:09:58  <harding> Wallet files are generally small.  If you think a backup is important, it's probably better to just make one automatically and stuff it somewhere in ~/.bitcoin/
2222019-04-12T19:10:07  <achow101> jnewbery: probably. the help text for the RPC does say that backups after are required
2232019-04-12T19:10:15  <achow101> I can change it to also say before too
2242019-04-12T19:10:32  <meshcollider> backup before can be done automatically like harding suggests
2252019-04-12T19:10:41  <meshcollider> Make a wallet.old or something
2262019-04-12T19:10:47  <harding> (Backup after is a different thing, since that's talking about off-disk backups.)
2272019-04-12T19:11:14  <luke-jr> achow101: well, only after is *required*..
2282019-04-12T19:12:58  <achow101> right
2292019-04-12T19:14:17  <achow101> I think it's possible to make both an upgradewallet RPC and wallet-tool command work safely
2302019-04-12T19:15:58  <meshcollider> It doesn't seem like theres any real objection to that
2312019-04-12T19:16:56  <meshcollider> jnewbery: anything else to discuss on this topic?
2322019-04-12T19:17:12  <jnewbery> nothing from me
2332019-04-12T19:17:31  <meshcollider> #topic native descriptor wallets (achow101)
2342019-04-12T19:18:01  <achow101> So i finished up an implementation of native descriptor wallets last weekend: #15764
2352019-04-12T19:18:03  <gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
2362019-04-12T19:18:09  *** DeanGuss has quit IRC
2372019-04-12T19:18:26  <achow101> the only question I really have is what to do with the tests for the old wallet stuff
2382019-04-12T19:18:50  <jnewbery> I think it's pretty important to keep those tests
2392019-04-12T19:18:58  <achow101> currently I have a bunch of tests removed or changed because they don't work with descriptor wallets
2402019-04-12T19:19:17  <jnewbery> Most users will still be using non-descriptor wallets for some time. We can't just stop testing those and hope there are no regressions
2412019-04-12T19:19:19  *** DeanGuss has joined #bitcoin-core-dev
2422019-04-12T19:19:45  <ryanofsky> you can add descriptors as an optional feature, there's no need to remove old code or old tests
2432019-04-12T19:22:31  <achow101> ryanofsky: that's an option, but I feel like descriptors and its new definitions is such a departure from current wallet stuff that it should have better distinction than just a wallet flag
2442019-04-12T19:23:57  <ryanofsky> you are referring to the practical downside of having to keep more code around?
2452019-04-12T19:23:58  <achow101> e.g. it's possible for someone to write code which accidentally unsets the wallet flag. it's much harder to accidentally downgrade the version
2462019-04-12T19:24:01  <meshcollider> Does your PR remove the ability to generate new "old" wallets
2472019-04-12T19:24:15  <achow101> meshcollider: yes
2482019-04-12T19:24:22  <achow101> (it's a wallet version bump)
2492019-04-12T19:26:02  <sipa>  achow101: i think, even for just testing purposes, we'll need to retain the ability to create old wallets
2502019-04-12T19:26:15  <jnewbery> The main downside of it being a flag rather than a version is that it becomes combinatorially more difficult to test everything
2512019-04-12T19:26:24  <sipa> as this is a very invasive change, and i don't think we want to lose the ability to test old logic
2522019-04-12T19:26:51  <jnewbery> I think that the default should be that newly created wallets are old-style, and users need to explicitly upgrade
2532019-04-12T19:26:51  *** bitcoin-git has joined #bitcoin-core-dev
2542019-04-12T19:26:51  <bitcoin-git> [bitcoin] jamesob opened pull request #15809: gitignore: plist and dat (master...2019-04-gitignore) https://github.com/bitcoin/bitcoin/pull/15809
2552019-04-12T19:26:52  *** bitcoin-git has left #bitcoin-core-dev
2562019-04-12T19:27:09  <achow101> jnewbery: how come?
2572019-04-12T19:27:45  <achow101> I think an explicit upgrade is actually far more dangerous than creating a new descriptor wallet
2582019-04-12T19:27:45  <jnewbery> because like you say, it's a big departure from the current wallet design
2592019-04-12T19:28:10  <jnewbery> we need to support both for some time to come, so why not take the conservative approach for now
2602019-04-12T19:28:21  <meshcollider> I think thats sensible for now, old wallet generation can be "deprecated" later on
2612019-04-12T19:29:17  <ryanofsky> yeah, i just think you don't need to add descriptors as this big one time change
2622019-04-12T19:29:50  <jnewbery> > I think an explicit upgrade is actually far more dangerous...
2632019-04-12T19:29:51  <ryanofsky> you can add new functionality alongside existing functionality, you will get better review better testing
2642019-04-12T19:30:07  <jnewbery> We definitely shouldn't be releasing wallet code that we think is *in any way* dangerous
2652019-04-12T19:30:08  *** tripleslash has quit IRC
2662019-04-12T19:30:32  <achow101> ok
2672019-04-12T19:30:50  *** provoostenator has left #bitcoin-core-dev
2682019-04-12T19:30:51  *** provoostenator has joined #bitcoin-core-dev
2692019-04-12T19:31:03  <achow101> jnewbery: the upgrade stuff I think will be inherently dangerous. shoehorning the old ismine logic into the new ismine logic is not trivial and they are incompatible in many different ways
2702019-04-12T19:31:35  <ryanofsky> achow101, you don't even need to add upgrade in the initial pr
2712019-04-12T19:32:10  <ryanofsky> we can add support for just creating new descriptor wallets, or just importing descriptors first
2722019-04-12T19:32:28  <jnewbery> i don't agree that it's inherently dangerous. We just need to do lots of testing until we're satisfied that it's no longer dangerous
2732019-04-12T19:32:30  <meshcollider> provoostenator is having IRC issues and can't send messages here atm but would like to point out he also has a slightly different (and perhaps less complete) PR open: https://github.com/bitcoin/bitcoin/pull/15487
2742019-04-12T19:32:45  <jnewbery> and roll it out slowly, with warnings to backup, etc
2752019-04-12T19:32:49  <achow101> ryanofsky: right
2762019-04-12T19:33:36  <jnewbery> Everything ryanofsky is suggesting is still possible by using wallet versions and not flags
2772019-04-12T19:33:37  <achow101> ryanofsky: we shouldn't allow people to create mixed descriptor and non-descriptor wllets though. so no importing descriptors
2782019-04-12T19:34:05  <achow101> jnewbery: making it optional is not
2792019-04-12T19:34:19  <achow101> that should only be done with flags
2802019-04-12T19:34:29  <jnewbery> why not? Add a new parameter to createwallet
2812019-04-12T19:34:50  <ryanofsky> yeah, i'm not sure you actually need a version or a flag
2822019-04-12T19:34:55  *** EagleTM has joined #bitcoin-core-dev
2832019-04-12T19:35:05  <jnewbery> if descriptorwallet=false create an old-style wallet, if true create a descriptor wallet
2842019-04-12T19:35:17  <achow101> the last time we did optional version was hd wallet and that was a headache to reconcile with upgrades in the future. I would rather not go through that excercise again
2852019-04-12T19:35:18  <jnewbery> default to false
2862019-04-12T19:35:37  <jnewbery> we need to handle upgrades anyway. You already have code to do that
2872019-04-12T19:36:05  <provoostenator> hi?
2882019-04-12T19:36:09  <harding> provoostenator: hi
2892019-04-12T19:36:12  <provoostenator> YES!
2902019-04-12T19:36:18  <meshcollider> provoostenator: hi \o/
2912019-04-12T19:36:23  <jnewbery> hi sjors!
2922019-04-12T19:36:24  <provoostenator> That was weird, I've been talking into a void for a day or so :-)
2932019-04-12T19:37:03  <provoostenator> In my version of descriptor wallets it's a feature flag and opt-in. Obviously this sort of thing is easy to tweak.
2942019-04-12T19:37:16  <achow101> jnewbery: I think we should maintain the separation of wallet flags for optional, wallet version for mandatory
2952019-04-12T19:37:17  <provoostenator> I'll do a more thorough comparison later.
2962019-04-12T19:37:58  <jnewbery> wallet version is optional. Upgrading from an old version to new is optional
2972019-04-12T19:37:59  <meshcollider> achow101: but why not just allow the wallet to be created with either version number
2982019-04-12T19:38:06  <jnewbery> right
2992019-04-12T19:38:14  <ryanofsky> jnewbery, i think version numbers are just confusing and should never be used again
3002019-04-12T19:38:52  <jnewbery> They are confusing, but they at least cut down on the number of combinations of options
3012019-04-12T19:38:52  <ryanofsky> your concern about testing and flag combinations is easily addressed by just refusing to load / support wallets with whatever combinations of flags you want to rule out
3022019-04-12T19:39:26  <jnewbery> I think that's effectively the same thing, no?
3032019-04-12T19:39:33  <meshcollider> IIRC in lightning, when exchanging feature lists, there are some optional features and some mandatory features based on bit positions
3042019-04-12T19:39:36  <ryanofsky> yes, exactly
3052019-04-12T19:39:49  <achow101> meshcollider: jnewbery: the problem with optional wallet versions is that any future wallet version becomes optional as well. You can't e.g. skip descriptor wallets and go to the version after that which introduces something completely unrelated to descriptors
3062019-04-12T19:39:56  <ryanofsky> anything you want to do with version numbers is possible with flags, but flags are more readable and easier to think about
3072019-04-12T19:40:00  <achow101> reconciling the two becomes a pain, as it was for hd wallets
3082019-04-12T19:40:17  <jnewbery> achow101 that's always the case with version numbers
3092019-04-12T19:40:24  <meshcollider> We dont have to add any new features to old style wallets from now on
3102019-04-12T19:40:35  <meshcollider> Force a descriptor upgrade before any other upgrade
3112019-04-12T19:40:39  *** owowo has quit IRC
3122019-04-12T19:40:45  <ryanofsky> because you don't have to mentally load the whole project history to figure out what conditions are possible, it's just written explicitly in code
3132019-04-12T19:41:08  <provoostenator> I'd rather not force upgrades anytime soon. That most likely will lead to endless delays in shipping.
3142019-04-12T19:41:11  <jnewbery> even if you don't make the version 'optional', there are still users of old wallets who would have to upgrade through descriptor wallets if they wanted a later version
3152019-04-12T19:41:34  <jnewbery> provoostenator: definitely. No forced upgrades
3162019-04-12T19:42:09  *** promag has joined #bitcoin-core-dev
3172019-04-12T19:42:12  <achow101> i agree with ryanofsky
3182019-04-12T19:42:25  <achow101> anyways, this is bikeshedding
3192019-04-12T19:42:32  <jnewbery> ?
3202019-04-12T19:42:51  <meshcollider> I think this is important for the approach
3212019-04-12T19:43:20  <provoostenator> What's more important I think is to decide if we want to support a hybrid with descriptors and regular stuff (I prefer not).
3222019-04-12T19:43:34  <achow101> provoostenator: definitely no
3232019-04-12T19:43:38  <meshcollider> No, we shouldnt
3242019-04-12T19:44:54  <provoostenator> Ok, so that can be supported both with versioning and with feature flags I think. We can revisit that later?
3252019-04-12T19:45:17  <provoostenator> Or is there something where this choice does matter more urgently?
3262019-04-12T19:45:29  <achow101> meshcollider: jnewbery: consider the case where we introduce descriptor wallets as a new optional version. Sometime later down the road, we introduce a new wallet version because a new field is introduced in the wallet that is inherently not backwards compatible so it needs a version bump to prevent old software from loading, e.g. several more wallet flags
3272019-04-12T19:45:44  <meshcollider> I think it just affects how to deal with transitioning tests
3282019-04-12T19:46:24  <achow101> in order for users to upgrade to that version with more wallet flags, they first have to upgrade to descriptors, which they may not want to. that new version provides new functionality that does not require descriptors but is still applicable to old wallets. now this needs to be reconciled, and that's rather difficult
3292019-04-12T19:46:29  *** promag has quit IRC
3302019-04-12T19:46:33  *** owowo has joined #bitcoin-core-dev
3312019-04-12T19:46:37  <ryanofsky> yeah, i don't see why flags aren't just obviously better in every case. you can still prevent combinations of features, you are just forced to write down which combinations are possible
3322019-04-12T19:46:48  <jnewbery> achow101 are you arguing that this should be a flag?
3332019-04-12T19:47:04  <meshcollider> Flags alone dont prevent old nodes from trying to open though do they?
3342019-04-12T19:47:08  <achow101> jnewbery: yes. if it is going to be an optional feature, it should be a flag
3352019-04-12T19:47:23  <ryanofsky> meshcollider, mandatory flags do
3362019-04-12T19:47:49  <jnewbery> Of course it's an optional feature. We don't force people to upgrade!
3372019-04-12T19:48:02  <meshcollider> Ok yes I agree with making it a mandatory flag rather than version
3382019-04-12T19:48:28  <jnewbery> I'm fine with it being a flag. Like ryanofsky has said, you can do everything with flags that you can with versions (and more)
3392019-04-12T19:49:14  <jnewbery> As long as the valid combinations are all documented and enforced in one place
3402019-04-12T19:49:17  <provoostenator> A mandatory flag also means we can reduce complexity.
3412019-04-12T19:49:40  <provoostenator> Only supporting upgrades for basic cases.
3422019-04-12T19:49:51  <achow101> alright, i'll change the pr to use a flag, restore the tests, and drop the upgrading logic for now
3432019-04-12T19:50:02  <meshcollider> Just because its a flag doesn't mean we have to allow all possible combinations of flags
3442019-04-12T19:50:43  <meshcollider> achow101: +1
3452019-04-12T19:50:56  <meshcollider> Anything else for the last 10 minutes?
3462019-04-12T19:51:22  <meshcollider> Anything else for backport to 0.18.0rc4 or high priority requests?
3472019-04-12T19:51:50  <jnewbery> Wallet high priority PRs are #15006 #14447 #15741
3482019-04-12T19:51:54  <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
3492019-04-12T19:51:55  <gribble> https://github.com/bitcoin/bitcoin/issues/14447 | Armory 0.96.4 causies BitcoinCore 0.17 crash sometimes · Issue #14447 · bitcoin/bitcoin · GitHub
3502019-04-12T19:51:57  <gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
3512019-04-12T19:51:57  *** pinheadmz has quit IRC
3522019-04-12T19:52:02  <jnewbery> sorry #15557
3532019-04-12T19:52:06  <gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
3542019-04-12T19:52:33  <jnewbery> I think 15557 is almost ready for merge. It's a really nice feature and quite easy to review
3552019-04-12T19:53:06  <meshcollider> Maybe kallewoof would like to have that debit/credit caching one on there
3562019-04-12T19:53:17  <meshcollider> #15780
3572019-04-12T19:53:20  <gribble> https://github.com/bitcoin/bitcoin/issues/15780 | wallet: add cachable accounts for caching credit/debit values by kallewoof · Pull Request #15780 · bitcoin/bitcoin · GitHub
3582019-04-12T19:53:54  *** pinheadmz has joined #bitcoin-core-dev
3592019-04-12T19:54:04  <jnewbery> I think that can go on. It blocks his other PR
3602019-04-12T19:54:26  <jnewbery> (which has been open for 8 months)
3612019-04-12T19:55:12  <meshcollider> Yes, and he is very proactive with rebasing, he deserves some acceleration lol
3622019-04-12T19:55:30  <jnewbery> #action review more kallewoof PRs!
3632019-04-12T19:56:11  <meshcollider> Ok seems thats all for the meeting today then :)
3642019-04-12T19:56:16  <meshcollider> #endmeeting
3652019-04-12T19:56:16  <lightningbot> Meeting ended Fri Apr 12 19:56:16 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3662019-04-12T19:56:16  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-12-19.00.html
3672019-04-12T19:56:16  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-12-19.00.txt
3682019-04-12T19:56:16  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-12-19.00.log.html
3692019-04-12T19:57:18  <achow101> when can we switch to a bdb that's shipped by distros?
3702019-04-12T19:58:57  <gwillen> I'm a little late to the high priority party, but I'd really like to see #15024 make it in
3712019-04-12T19:58:58  <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
3722019-04-12T19:59:35  <warren> achow101: drawback of that is everyone's wallet.dat would be a different format, and you wouldn't be able to use the gitian binary
3732019-04-12T19:59:47  <gwillen> this is a stopgap for using private-key-bearing descriptors in pre-descriptorwallets, but I expect that it can land MUCH faster than descriptorwallets will
3742019-04-12T20:00:23  <gwillen> I expect that it is not eligible for backport, but it would be nice to see it in master
3752019-04-12T20:02:05  <jnewbery> I'm fine with adding it. It does make the high priority list a bit wallet-heavy
3762019-04-12T20:02:49  <meshcollider> The wallet is the only important thing anyway ;)
3772019-04-12T20:03:55  <gwillen> hah :D
3782019-04-12T20:24:08  <luke-jr> achow101: probably never?
3792019-04-12T20:25:01  <luke-jr> achow101: modern bdb is AGPL; so we'd need to modify our software to serve source code of whatever is running to peers
3802019-04-12T20:25:06  <luke-jr> which IMO is stupid
3812019-04-12T20:25:48  *** promag has joined #bitcoin-core-dev
3822019-04-12T20:27:16  *** promag has quit IRC
3832019-04-12T20:33:35  *** Zenton has joined #bitcoin-core-dev
3842019-04-12T20:45:50  *** promag has joined #bitcoin-core-dev
3852019-04-12T20:54:53  *** bitcoin-git has joined #bitcoin-core-dev
3862019-04-12T20:54:53  <bitcoin-git> [bitcoin] jnewbery opened pull request #15810: [WIP] Remove nAbsurdFee fee from AcceptToMemoryPool (master...2019-04-remove-absurd-fee) https://github.com/bitcoin/bitcoin/pull/15810
3872019-04-12T20:54:55  *** bitcoin-git has left #bitcoin-core-dev
3882019-04-12T20:55:08  *** hebasto has quit IRC
3892019-04-12T21:00:37  *** promag has quit IRC
3902019-04-12T21:14:23  *** andreacab has joined #bitcoin-core-dev
3912019-04-12T21:15:30  *** riperk has joined #bitcoin-core-dev
3922019-04-12T21:16:06  *** promag has joined #bitcoin-core-dev
3932019-04-12T21:18:57  *** chriswang2019 has joined #bitcoin-core-dev
3942019-04-12T21:19:31  *** rex4539 has quit IRC
3952019-04-12T21:21:36  *** chriswang2019 has quit IRC
3962019-04-12T21:22:49  <promag> gh down?
3972019-04-12T21:24:15  <instagibbs> not for me
3982019-04-12T21:26:20  *** Guyver2 has quit IRC
3992019-04-12T21:50:29  *** jimmysong has joined #bitcoin-core-dev
4002019-04-12T21:50:34  *** jimmysong_ has joined #bitcoin-core-dev
4012019-04-12T21:55:41  *** captjakk has quit IRC
4022019-04-12T21:56:15  *** captjakk has joined #bitcoin-core-dev
4032019-04-12T21:57:53  *** DeanGuss has quit IRC
4042019-04-12T21:57:54  *** ghost43 has quit IRC
4052019-04-12T22:01:33  *** ghost43 has joined #bitcoin-core-dev
4062019-04-12T22:05:14  *** captjakk has quit IRC
4072019-04-12T22:16:02  *** pinheadmz has quit IRC
4082019-04-12T22:17:11  *** pinheadmz has joined #bitcoin-core-dev
4092019-04-12T22:18:07  *** pinheadmz has quit IRC
4102019-04-12T22:18:18  *** dqx__ has quit IRC
4112019-04-12T22:21:01  *** pinheadmz has joined #bitcoin-core-dev
4122019-04-12T22:33:27  *** dqx_ has joined #bitcoin-core-dev
4132019-04-12T22:48:21  *** bitbee has quit IRC
4142019-04-12T22:50:10  *** dqx_ has quit IRC
4152019-04-12T22:51:46  *** bitbee has joined #bitcoin-core-dev
4162019-04-12T22:52:21  *** andreacab has quit IRC
4172019-04-12T22:55:39  *** spinza has quit IRC
4182019-04-12T22:56:46  *** dqx_ has joined #bitcoin-core-dev
4192019-04-12T23:00:01  *** dqx_ has quit IRC
4202019-04-12T23:01:18  *** promag_ has joined #bitcoin-core-dev
4212019-04-12T23:05:24  *** promag_ has quit IRC
4222019-04-12T23:11:41  *** spinza has joined #bitcoin-core-dev
4232019-04-12T23:29:22  *** Aaronvan_ has joined #bitcoin-core-dev
4242019-04-12T23:32:15  *** AaronvanW has quit IRC
4252019-04-12T23:41:01  *** Aaronvan_ has quit IRC