1 2019-06-21T00:00:01  *** chaosagent has quit IRC
  2 2019-06-21T00:01:19  *** bitcoin-git has joined #bitcoin-core-dev
  3 2019-06-21T00:01:19  <bitcoin-git> [bitcoin] Sjors opened pull request #16257: [wallet] abort when attempting to fund a transaction above -maxtxfee (master...2019/06/max_fee) https://github.com/bitcoin/bitcoin/pull/16257
  4 2019-06-21T00:01:20  *** bitcoin-git has left #bitcoin-core-dev
  5 2019-06-21T00:08:28  <promag> achow101: have you tested #16215?
  6 2019-06-21T00:08:29  <gribble> https://github.com/bitcoin/bitcoin/issues/16215 | gui: Refactor wallet controller activities by promag · Pull Request #16215 · bitcoin/bitcoin · GitHub
  7 2019-06-21T00:08:45  <promag> I can split, no problem
  8 2019-06-21T00:10:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  9 2019-06-21T00:14:35  *** hugohn has joined #bitcoin-core-dev
 10 2019-06-21T00:19:57  *** pwgn has joined #bitcoin-core-dev
 11 2019-06-21T00:21:59  <promag> achow101: actually if I split then I'd have to implement CreateWalletActivity, like current OpenWalletActivity, which is not that great compared to 16215.
 12 2019-06-21T00:24:18  <promag> ryanofsky suggestion makes sense because avoids refactor PRs, but if I split then we would have different refactor: refactor both activities to a better approach.
 13 2019-06-21T00:25:34  *** hugohn has quit IRC
 14 2019-06-21T00:26:31  <promag> what makes more sense to me is to first refactor OpenWalletActivity, then your PR could have my the remaining changes squashed in the correct commits.
 15 2019-06-21T00:26:38  <promag> let me know what you think
 16 2019-06-21T00:28:35  <promag> fanquake: mind testing #16231? ty
 17 2019-06-21T00:28:36  <gribble> https://github.com/bitcoin/bitcoin/issues/16231 | gui: Fix open wallet menu initialization order by promag · Pull Request #16231 · bitcoin/bitcoin · GitHub
 18 2019-06-21T00:28:41  *** dviola has quit IRC
 19 2019-06-21T00:31:06  <fanquake> promag ok
 20 2019-06-21T00:32:36  *** hugohn has joined #bitcoin-core-dev
 21 2019-06-21T00:34:09  *** EagleTM has quit IRC
 22 2019-06-21T00:51:45  *** ylbam has quit IRC
 23 2019-06-21T00:51:49  *** jonatack has quit IRC
 24 2019-06-21T00:59:03  *** promag has quit IRC
 25 2019-06-21T01:14:53  *** bralyclow01 has joined #bitcoin-core-dev
 26 2019-06-21T01:15:28  *** scoop has quit IRC
 27 2019-06-21T01:17:29  *** justanotheruser has quit IRC
 28 2019-06-21T01:17:31  *** AaronvanW has quit IRC
 29 2019-06-21T01:18:36  *** bralyclow has quit IRC
 30 2019-06-21T01:33:19  *** Chris_Stewart_5 has quit IRC
 31 2019-06-21T01:36:42  *** queip has quit IRC
 32 2019-06-21T01:36:49  *** rafalcpp has joined #bitcoin-core-dev
 33 2019-06-21T01:37:16  *** rafalcpp_ has quit IRC
 34 2019-06-21T01:43:21  *** queip has joined #bitcoin-core-dev
 35 2019-06-21T01:44:48  *** spinza has quit IRC
 36 2019-06-21T01:48:40  *** aseem has joined #bitcoin-core-dev
 37 2019-06-21T01:51:28  *** hugohn has quit IRC
 38 2019-06-21T01:52:16  *** d_t has quit IRC
 39 2019-06-21T01:59:31  *** AaronvanW has joined #bitcoin-core-dev
 40 2019-06-21T02:04:50  *** AaronvanW has quit IRC
 41 2019-06-21T02:07:52  *** spinza has joined #bitcoin-core-dev
 42 2019-06-21T02:12:52  *** AaronvanW has joined #bitcoin-core-dev
 43 2019-06-21T02:25:46  *** ccdle12 has joined #bitcoin-core-dev
 44 2019-06-21T02:27:08  *** ccdle12_ has joined #bitcoin-core-dev
 45 2019-06-21T02:27:08  *** ccdle12 has quit IRC
 46 2019-06-21T02:28:14  *** ccdle12_ has quit IRC
 47 2019-06-21T02:28:31  *** ccdle12 has joined #bitcoin-core-dev
 48 2019-06-21T02:31:57  *** dgenr8 has quit IRC
 49 2019-06-21T02:37:48  *** bralyclow has joined #bitcoin-core-dev
 50 2019-06-21T02:40:00  *** AaronvanW has quit IRC
 51 2019-06-21T02:41:18  *** bralyclow01 has quit IRC
 52 2019-06-21T02:43:44  *** scoop has joined #bitcoin-core-dev
 53 2019-06-21T02:47:59  *** scoop has quit IRC
 54 2019-06-21T02:50:29  *** scoop has joined #bitcoin-core-dev
 55 2019-06-21T02:59:11  *** elichai2 has quit IRC
 56 2019-06-21T02:59:40  *** promag has joined #bitcoin-core-dev
 57 2019-06-21T03:00:01  *** pwgn has quit IRC
 58 2019-06-21T03:02:56  *** DeanGuss has joined #bitcoin-core-dev
 59 2019-06-21T03:04:01  *** promag has quit IRC
 60 2019-06-21T03:04:28  *** gchaix1 has joined #bitcoin-core-dev
 61 2019-06-21T03:14:06  *** justanotheruser has joined #bitcoin-core-dev
 62 2019-06-21T03:15:26  *** ddustin has quit IRC
 63 2019-06-21T03:16:12  *** ddustin has joined #bitcoin-core-dev
 64 2019-06-21T03:16:54  *** ddustin has quit IRC
 65 2019-06-21T03:17:01  *** scoop has quit IRC
 66 2019-06-21T03:17:43  *** scoop has joined #bitcoin-core-dev
 67 2019-06-21T03:19:26  *** skyikot has quit IRC
 68 2019-06-21T03:27:04  *** scoop_ has joined #bitcoin-core-dev
 69 2019-06-21T03:27:04  *** scoop has quit IRC
 70 2019-06-21T03:29:15  *** aseem has quit IRC
 71 2019-06-21T03:29:15  *** scoop_ has quit IRC
 72 2019-06-21T03:29:36  *** scoop has joined #bitcoin-core-dev
 73 2019-06-21T03:31:37  *** scoop_ has joined #bitcoin-core-dev
 74 2019-06-21T03:31:37  *** scoop has quit IRC
 75 2019-06-21T03:33:01  *** hebasto has joined #bitcoin-core-dev
 76 2019-06-21T03:34:47  *** surja795 has joined #bitcoin-core-dev
 77 2019-06-21T03:37:05  *** scoop has joined #bitcoin-core-dev
 78 2019-06-21T03:37:14  *** scoop_ has quit IRC
 79 2019-06-21T03:37:17  *** scoop has quit IRC
 80 2019-06-21T03:39:11  *** scoop has joined #bitcoin-core-dev
 81 2019-06-21T03:42:59  *** bralyclow01 has joined #bitcoin-core-dev
 82 2019-06-21T03:43:08  *** scoop has quit IRC
 83 2019-06-21T03:43:35  *** bralyclo_ has joined #bitcoin-core-dev
 84 2019-06-21T03:44:01  *** scoop_ has joined #bitcoin-core-dev
 85 2019-06-21T03:45:04  *** bralyclow has quit IRC
 86 2019-06-21T03:45:11  *** bralycl__ has joined #bitcoin-core-dev
 87 2019-06-21T03:46:27  *** scoop has joined #bitcoin-core-dev
 88 2019-06-21T03:46:27  *** scoop_ has quit IRC
 89 2019-06-21T03:47:08  *** bralyclow01 has quit IRC
 90 2019-06-21T03:47:09  *** scoop has quit IRC
 91 2019-06-21T03:48:40  *** scoop_ has joined #bitcoin-core-dev
 92 2019-06-21T03:48:47  *** bralyclo_ has quit IRC
 93 2019-06-21T03:49:09  *** scoop_ has quit IRC
 94 2019-06-21T03:49:20  *** scoop_ has joined #bitcoin-core-dev
 95 2019-06-21T03:52:09  *** scoop_ has quit IRC
 96 2019-06-21T03:52:17  *** scoop has joined #bitcoin-core-dev
 97 2019-06-21T03:57:03  *** scoop has quit IRC
 98 2019-06-21T03:58:07  *** scoop has joined #bitcoin-core-dev
 99 2019-06-21T03:58:14  *** AaronvanW has joined #bitcoin-core-dev
100 2019-06-21T04:02:33  *** scoop has quit IRC
101 2019-06-21T04:04:29  *** hebasto has quit IRC
102 2019-06-21T04:06:58  *** scoop has joined #bitcoin-core-dev
103 2019-06-21T04:09:02  *** rh0nj has quit IRC
104 2019-06-21T04:11:11  *** scoop has quit IRC
105 2019-06-21T04:12:07  *** rh0nj has joined #bitcoin-core-dev
106 2019-06-21T04:23:22  *** surja795 has quit IRC
107 2019-06-21T04:25:39  *** ccdle12 has quit IRC
108 2019-06-21T04:31:42  *** AaronvanW has quit IRC
109 2019-06-21T04:42:12  *** ccdle12 has joined #bitcoin-core-dev
110 2019-06-21T04:53:12  *** midnightmagic has joined #bitcoin-core-dev
111 2019-06-21T04:54:28  *** surja795 has joined #bitcoin-core-dev
112 2019-06-21T04:59:01  *** ccdle12 has quit IRC
113 2019-06-21T04:59:12  *** surja795 has quit IRC
114 2019-06-21T05:02:17  *** bralycl__ has quit IRC
115 2019-06-21T05:02:58  *** bralyclow has joined #bitcoin-core-dev
116 2019-06-21T05:07:57  *** bralyclow has quit IRC
117 2019-06-21T05:15:13  *** hebasto has joined #bitcoin-core-dev
118 2019-06-21T05:17:28  *** ddustin has joined #bitcoin-core-dev
119 2019-06-21T05:18:45  *** scoop has joined #bitcoin-core-dev
120 2019-06-21T05:21:36  *** ddustin has quit IRC
121 2019-06-21T05:29:00  *** surja795 has joined #bitcoin-core-dev
122 2019-06-21T05:33:52  *** surja795 has quit IRC
123 2019-06-21T05:40:27  *** reallll has quit IRC
124 2019-06-21T05:46:07  *** reallll has joined #bitcoin-core-dev
125 2019-06-21T05:48:52  *** bralyclow has joined #bitcoin-core-dev
126 2019-06-21T05:53:50  *** scoop has quit IRC
127 2019-06-21T05:59:00  *** bralyclow has quit IRC
128 2019-06-21T05:59:16  *** bralyclow has joined #bitcoin-core-dev
129 2019-06-21T06:00:02  *** gchaix1 has quit IRC
130 2019-06-21T06:03:46  *** beng-nl1 has joined #bitcoin-core-dev
131 2019-06-21T06:07:37  *** kallewoof has quit IRC
132 2019-06-21T06:08:01  *** kallewoof has joined #bitcoin-core-dev
133 2019-06-21T06:28:47  *** AaronvanW has joined #bitcoin-core-dev
134 2019-06-21T06:31:39  *** rafalcpp_ has joined #bitcoin-core-dev
135 2019-06-21T06:32:32  *** queip has quit IRC
136 2019-06-21T06:32:40  *** rafalcpp has quit IRC
137 2019-06-21T06:34:10  *** tryphe_ is now known as tryphe
138 2019-06-21T06:38:58  *** queip has joined #bitcoin-core-dev
139 2019-06-21T06:45:32  *** reallll is now known as belcher
140 2019-06-21T06:54:27  <jonasschnelli> Is is somehow possible to emulate BE with Qemu? With reasonable performance? I remember doing it years ago but it was veeery slow?
141 2019-06-21T06:55:23  <jonasschnelli> Or is it possible to use an ARM SoC-board (Odroid) to run a BE OS on ARM64?
142 2019-06-21T06:57:35  <kallewoof> jonasschnelli: yes
143 2019-06-21T06:57:51  <jonasschnelli> kallewoof: can you be more specific. :)
144 2019-06-21T06:57:55  <kallewoof> I have a qemu instance for trying bitcoin compiling
145 2019-06-21T06:58:00  <kallewoof> big endian.
146 2019-06-21T06:58:20  <kallewoof> its not reasonable performance though, so... maybe "sorta" is more accurate than "yes".
147 2019-06-21T06:58:50  <jonasschnelli> kallewoof: okay. But the compilation finishes at "some point"? Can you run the unit tests?
148 2019-06-21T06:58:56  <kallewoof> yep!
149 2019-06-21T06:59:21  <jonasschnelli> Great. Do you use PPC? Do you use Debian (since I guess they sill support PPC images)?
150 2019-06-21T06:59:34  <kallewoof> its debian_wheezy_powerpc_standard.qcow2
151 2019-06-21T06:59:47  <kallewoof> unfortunately debian stopped supporting ppc after wheezy
152 2019-06-21T06:59:51  <jonasschnelli> Looks like everyone is using that
153 2019-06-21T07:00:03  <jonasschnelli> The question is, if BE is reasonable anymore...
154 2019-06-21T07:00:38  <kallewoof> i thought there was new hardware that was BE or could be BE
155 2019-06-21T07:01:14  *** dviola has joined #bitcoin-core-dev
156 2019-06-21T07:02:08  *** AaronvanW has quit IRC
157 2019-06-21T07:04:55  <jonasschnelli> BE is probably relevant fpr the Power9 family
158 2019-06-21T07:06:09  *** promag has joined #bitcoin-core-dev
159 2019-06-21T07:07:21  *** mildly_risky has joined #bitcoin-core-dev
160 2019-06-21T07:08:21  *** mildly_risky has quit IRC
161 2019-06-21T07:26:12  *** bitcoin-git has joined #bitcoin-core-dev
162 2019-06-21T07:26:12  <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
163 2019-06-21T07:26:15  *** bitcoin-git has left #bitcoin-core-dev
164 2019-06-21T07:37:13  <kallewoof> @sipa I am confused about a commit of yours from March 2016 (sorry..!), but someone else might be able to explain this: https://github.com/bitcoin/bitcoin/commit/8a253b342c5272496926ed391b078742bbe937ae -- the nInnerLoopCount restricts the nonce to 0..65535 (16 bits), but the nonce is 32 bits. Why? I realize if you make this 0xffffffff and try to Ctrl-C a bitcoind instance while trying to find a blokc, it will lock up and
165 2019-06-21T07:37:13  <kallewoof>  wait for the generate to finish. Is that why?
166 2019-06-21T07:44:43  *** bitcoin-git has joined #bitcoin-core-dev
167 2019-06-21T07:44:43  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23815ee74dfd...303ec103bacf
168 2019-06-21T07:44:43  <bitcoin-git> bitcoin/master a495034 Andrew Chow: Make and get the multisig redeemscript and destination in one function ins...
169 2019-06-21T07:44:44  <bitcoin-git> bitcoin/master 303ec10 MeshCollider: Merge #16026: Ensure that uncompressed public keys in a multisig always re...
170 2019-06-21T07:44:57  *** bitcoin-git has left #bitcoin-core-dev
171 2019-06-21T07:45:33  *** bitcoin-git has joined #bitcoin-core-dev
172 2019-06-21T07:45:33  <bitcoin-git> [bitcoin] meshcollider merged pull request #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address (master...dont-sw-ms-uncomp) https://github.com/bitcoin/bitcoin/pull/16026
173 2019-06-21T07:45:46  *** bitcoin-git has left #bitcoin-core-dev
174 2019-06-21T07:49:09  *** cncr04s has quit IRC
175 2019-06-21T07:49:51  *** emilengler has joined #bitcoin-core-dev
176 2019-06-21T07:54:36  *** astro has quit IRC
177 2019-06-21T07:54:55  *** kljasdfvv has joined #bitcoin-core-dev
178 2019-06-21T07:56:43  *** cncr04s has joined #bitcoin-core-dev
179 2019-06-21T07:58:14  *** dviola has quit IRC
180 2019-06-21T07:59:56  *** astro has joined #bitcoin-core-dev
181 2019-06-21T08:00:13  *** bitcoin-git has joined #bitcoin-core-dev
182 2019-06-21T08:00:14  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/303ec103bacf...fd333e15a545
183 2019-06-21T08:00:14  <bitcoin-git> bitcoin/master 7c611e2 Andrew Chow: Move ismine to wallet module
184 2019-06-21T08:00:15  <bitcoin-git> bitcoin/master e61de63 Andrew Chow: Change ismine to take a CWallet instead of CKeyStore
185 2019-06-21T08:00:15  <bitcoin-git> bitcoin/master fd333e1 MeshCollider: Merge #16226: Move ismine to the wallet module
186 2019-06-21T08:00:17  *** bitcoin-git has left #bitcoin-core-dev
187 2019-06-21T08:01:08  *** bitcoin-git has joined #bitcoin-core-dev
188 2019-06-21T08:01:08  <bitcoin-git> [bitcoin] meshcollider merged pull request #16226: Move ismine to the wallet module (master...mv-ismine-wallet) https://github.com/bitcoin/bitcoin/pull/16226
189 2019-06-21T08:01:13  *** bitcoin-git has left #bitcoin-core-dev
190 2019-06-21T08:13:19  *** rex4539 has quit IRC
191 2019-06-21T08:13:23  *** rafalcpp has joined #bitcoin-core-dev
192 2019-06-21T08:13:43  *** queip has quit IRC
193 2019-06-21T08:14:08  *** rafalcpp_ has quit IRC
194 2019-06-21T08:18:37  *** kristapsk has quit IRC
195 2019-06-21T08:20:11  *** queip has joined #bitcoin-core-dev
196 2019-06-21T08:22:33  *** surja795 has joined #bitcoin-core-dev
197 2019-06-21T08:23:57  *** DeanGuss has quit IRC
198 2019-06-21T08:27:07  *** surja795 has quit IRC
199 2019-06-21T08:36:00  *** Zenton has joined #bitcoin-core-dev
200 2019-06-21T08:36:14  *** mryandao_ has joined #bitcoin-core-dev
201 2019-06-21T08:36:22  *** mryandao has quit IRC
202 2019-06-21T08:39:24  *** promag_ has joined #bitcoin-core-dev
203 2019-06-21T08:40:00  *** sfhi has joined #bitcoin-core-dev
204 2019-06-21T08:51:40  *** darosior has joined #bitcoin-core-dev
205 2019-06-21T08:54:46  *** sfhi has quit IRC
206 2019-06-21T09:00:01  *** beng-nl1 has quit IRC
207 2019-06-21T09:00:25  *** AaronvanW has joined #bitcoin-core-dev
208 2019-06-21T09:05:11  *** Honkeymagoo has joined #bitcoin-core-dev
209 2019-06-21T09:12:31  *** timothy has joined #bitcoin-core-dev
210 2019-06-21T09:14:45  *** EagleTM has joined #bitcoin-core-dev
211 2019-06-21T09:26:10  *** rafalcpp_ has joined #bitcoin-core-dev
212 2019-06-21T09:26:18  *** queip has quit IRC
213 2019-06-21T09:27:11  *** rafalcpp has quit IRC
214 2019-06-21T09:34:10  *** queip has joined #bitcoin-core-dev
215 2019-06-21T09:48:48  *** EagleTM has quit IRC
216 2019-06-21T09:50:50  *** anonymous8587 has joined #bitcoin-core-dev
217 2019-06-21T09:53:08  *** anonymous8587 has quit IRC
218 2019-06-21T09:56:46  *** darosior has quit IRC
219 2019-06-21T10:04:10  *** AaronvanW has quit IRC
220 2019-06-21T10:16:33  *** michaelfolkson has joined #bitcoin-core-dev
221 2019-06-21T10:18:59  *** michaelfolkson has joined #bitcoin-core-dev
222 2019-06-21T10:22:07  *** AaronvanW has joined #bitcoin-core-dev
223 2019-06-21T10:33:10  *** michaelfolkson has quit IRC
224 2019-06-21T10:37:41  *** astro has quit IRC
225 2019-06-21T10:40:08  *** justanotheruser has quit IRC
226 2019-06-21T10:41:25  *** Honkeymagoo has quit IRC
227 2019-06-21T10:42:54  *** astro has joined #bitcoin-core-dev
228 2019-06-21T10:42:56  *** bitcoin-git has joined #bitcoin-core-dev
229 2019-06-21T10:42:57  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd333e15a545...32e94538185b
230 2019-06-21T10:42:57  <bitcoin-git> bitcoin/master 5a88ea7 Jon Atack: doc: remove orphaned header in developer notes
231 2019-06-21T10:42:58  <bitcoin-git> bitcoin/master 32e9453 fanquake: Merge #16256: doc: remove orphaned header in developer notes
232 2019-06-21T10:43:00  *** bitcoin-git has left #bitcoin-core-dev
233 2019-06-21T10:43:36  *** EagleTM has joined #bitcoin-core-dev
234 2019-06-21T10:43:51  *** bitcoin-git has joined #bitcoin-core-dev
235 2019-06-21T10:43:51  <bitcoin-git> [bitcoin] fanquake merged pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256
236 2019-06-21T10:43:52  *** bitcoin-git has left #bitcoin-core-dev
237 2019-06-21T10:44:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
238 2019-06-21T10:45:13  *** spinza has quit IRC
239 2019-06-21T10:48:12  *** chriswang2019 has joined #bitcoin-core-dev
240 2019-06-21T10:48:14  *** EagleTM has quit IRC
241 2019-06-21T10:55:10  *** spinza has joined #bitcoin-core-dev
242 2019-06-21T10:56:10  *** jonatack has joined #bitcoin-core-dev
243 2019-06-21T10:56:45  *** chriswang2019 has quit IRC
244 2019-06-21T10:59:03  *** lnostdal has quit IRC
245 2019-06-21T10:59:37  *** queip has quit IRC
246 2019-06-21T10:59:37  *** rafalcpp_ has quit IRC
247 2019-06-21T10:59:54  *** rafalcpp_ has joined #bitcoin-core-dev
248 2019-06-21T11:02:17  *** tlyu has joined #bitcoin-core-dev
249 2019-06-21T11:04:10  *** justanotheruser has joined #bitcoin-core-dev
250 2019-06-21T11:05:58  *** queip has joined #bitcoin-core-dev
251 2019-06-21T11:09:36  *** lnostdal has joined #bitcoin-core-dev
252 2019-06-21T11:21:40  *** rafalcpp has joined #bitcoin-core-dev
253 2019-06-21T11:22:07  *** queip has quit IRC
254 2019-06-21T11:22:08  *** rafalcpp_ has quit IRC
255 2019-06-21T11:24:55  *** astro has quit IRC
256 2019-06-21T11:28:26  *** queip has joined #bitcoin-core-dev
257 2019-06-21T11:30:24  *** astro has joined #bitcoin-core-dev
258 2019-06-21T11:32:09  *** bitcoin-git has joined #bitcoin-core-dev
259 2019-06-21T11:32:09  <bitcoin-git> [bitcoin] natangl opened pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
260 2019-06-21T11:32:10  *** bitcoin-git has left #bitcoin-core-dev
261 2019-06-21T11:33:15  *** bitcoin-git has joined #bitcoin-core-dev
262 2019-06-21T11:33:15  <bitcoin-git> [bitcoin] fanquake closed pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
263 2019-06-21T11:33:18  *** bitcoin-git has left #bitcoin-core-dev
264 2019-06-21T11:49:33  *** astro_ has joined #bitcoin-core-dev
265 2019-06-21T11:51:55  *** astro has quit IRC
266 2019-06-21T11:52:00  *** Chris_Stewart_5 has quit IRC
267 2019-06-21T11:56:00  *** surja795 has joined #bitcoin-core-dev
268 2019-06-21T11:56:24  *** promag_ has quit IRC
269 2019-06-21T11:59:35  *** aiprivateexchang has joined #bitcoin-core-dev
270 2019-06-21T12:00:02  *** tlyu has quit IRC
271 2019-06-21T12:00:06  *** promag_ has joined #bitcoin-core-dev
272 2019-06-21T12:00:07  *** aiprivateexchang has left #bitcoin-core-dev
273 2019-06-21T12:00:58  *** qwebirc303118 has joined #bitcoin-core-dev
274 2019-06-21T12:03:48  *** hds has joined #bitcoin-core-dev
275 2019-06-21T12:12:01  *** promag_ has quit IRC
276 2019-06-21T12:16:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
277 2019-06-21T12:18:05  *** darosior has joined #bitcoin-core-dev
278 2019-06-21T12:26:40  *** surja795 has quit IRC
279 2019-06-21T12:44:41  *** jonatack has quit IRC
280 2019-06-21T12:57:15  *** provoostenator has quit IRC
281 2019-06-21T13:06:33  *** shesek has quit IRC
282 2019-06-21T13:08:03  *** shesek has joined #bitcoin-core-dev
283 2019-06-21T13:09:32  *** scoop has joined #bitcoin-core-dev
284 2019-06-21T13:12:42  *** shesek has quit IRC
285 2019-06-21T13:13:04  *** Zenton has quit IRC
286 2019-06-21T13:13:39  *** Zenton has joined #bitcoin-core-dev
287 2019-06-21T13:14:43  *** shesek has joined #bitcoin-core-dev
288 2019-06-21T13:21:28  *** shesek has quit IRC
289 2019-06-21T13:31:25  *** provoostenator has joined #bitcoin-core-dev
290 2019-06-21T13:34:50  *** promag_ has joined #bitcoin-core-dev
291 2019-06-21T13:39:13  *** promag_ has quit IRC
292 2019-06-21T13:40:47  *** hebasto has quit IRC
293 2019-06-21T13:41:46  *** lightlike has joined #bitcoin-core-dev
294 2019-06-21T13:45:59  *** bralyclow01 has joined #bitcoin-core-dev
295 2019-06-21T13:46:39  *** elichai2 has joined #bitcoin-core-dev
296 2019-06-21T13:49:53  *** bralyclow has quit IRC
297 2019-06-21T13:50:21  *** d_t has joined #bitcoin-core-dev
298 2019-06-21T13:53:22  *** aseem has joined #bitcoin-core-dev
299 2019-06-21T13:55:19  <MarcoFalke> #proposedmeetingtopic  0.18.1: Backports #16035
300 2019-06-21T13:55:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
301 2019-06-21T14:03:04  *** dviola has joined #bitcoin-core-dev
302 2019-06-21T14:08:31  *** mryandao has joined #bitcoin-core-dev
303 2019-06-21T14:10:11  *** mryandao_ has quit IRC
304 2019-06-21T14:16:54  *** provoostenator has quit IRC
305 2019-06-21T14:17:26  *** Guyver2 has joined #bitcoin-core-dev
306 2019-06-21T14:21:11  *** provoostenator has joined #bitcoin-core-dev
307 2019-06-21T14:27:10  *** provoostenator has quit IRC
308 2019-06-21T14:28:03  *** provoostenator has joined #bitcoin-core-dev
309 2019-06-21T14:28:40  *** jonatack has joined #bitcoin-core-dev
310 2019-06-21T14:30:12  *** hebasto has joined #bitcoin-core-dev
311 2019-06-21T14:34:03  *** promag_ has joined #bitcoin-core-dev
312 2019-06-21T14:34:15  *** michaelsdunn1 has joined #bitcoin-core-dev
313 2019-06-21T14:37:39  *** PastaPasta has joined #bitcoin-core-dev
314 2019-06-21T14:38:36  *** promag_ has quit IRC
315 2019-06-21T14:40:50  *** captjakk has joined #bitcoin-core-dev
316 2019-06-21T14:40:50  *** AaronvanW has quit IRC
317 2019-06-21T14:46:26  *** pinheadmz has quit IRC
318 2019-06-21T14:50:20  *** d_t has quit IRC
319 2019-06-21T14:50:35  <phantomcircuit> kallewoof, there's a pr with comments https://github.com/bitcoin/bitcoin/pull/7663
320 2019-06-21T14:56:00  <kallewoof> @phantomcircuit thanks!
321 2019-06-21T14:58:42  *** shigeya has quit IRC
322 2019-06-21T14:59:16  <phantomcircuit> kallewoof, you can get to those from the commit btw
323 2019-06-21T14:59:27  <kallewoof> how?
324 2019-06-21T14:59:36  <kallewoof> OH.
325 2019-06-21T14:59:39  <kallewoof> doh. thanks.
326 2019-06-21T14:59:40  <phantomcircuit> it's right above the author
327 2019-06-21T14:59:48  <phantomcircuit> yeah i only noticed that recently
328 2019-06-21T15:00:01  *** hds has quit IRC
329 2019-06-21T15:01:18  *** bralyclow01 has quit IRC
330 2019-06-21T15:01:57  *** bitcoin-git has joined #bitcoin-core-dev
331 2019-06-21T15:01:58  <bitcoin-git> [bitcoin] promag opened pull request #16261: gui: Refactor OpenWalletActivity (master...2019-06-refactor-open-wallet) https://github.com/bitcoin/bitcoin/pull/16261
332 2019-06-21T15:01:58  *** bitcoin-git has left #bitcoin-core-dev
333 2019-06-21T15:02:00  *** bralyclow has joined #bitcoin-core-dev
334 2019-06-21T15:03:27  *** shigeya has joined #bitcoin-core-dev
335 2019-06-21T15:04:16  *** StopAndDecrypt has quit IRC
336 2019-06-21T15:04:33  *** StopAndDecrypt has joined #bitcoin-core-dev
337 2019-06-21T15:04:40  <kallewoof> phantomcircuit: unfortunately the PR doesnt give me any more clues as to why it only uses 16 out of 32 bits of the nonce...
338 2019-06-21T15:04:42  *** StopAndDecrypt has quit IRC
339 2019-06-21T15:04:42  *** StopAndDecrypt has joined #bitcoin-core-dev
340 2019-06-21T15:07:38  *** bralyclow has quit IRC
341 2019-06-21T15:07:59  <phantomcircuit> kallewoof, well it's just the inner loop
342 2019-06-21T15:08:27  *** AaronvanW has joined #bitcoin-core-dev
343 2019-06-21T15:08:32  <phantomcircuit> yeah actually not sure about that one
344 2019-06-21T15:10:47  <kallewoof> I think the idea was to make it run 65535 times and then loop back and then run another 65535 times and then if it ran out of the nonce it would inccrement the extra nonce, but thats not what its doing at all.
345 2019-06-21T15:16:00  *** aseem has quit IRC
346 2019-06-21T15:21:57  *** aseem has joined #bitcoin-core-dev
347 2019-06-21T15:23:59  *** rex4539 has joined #bitcoin-core-dev
348 2019-06-21T15:34:41  *** pinheadmz has joined #bitcoin-core-dev
349 2019-06-21T15:43:02  *** nyuszika7h1 has joined #bitcoin-core-dev
350 2019-06-21T16:03:12  *** Zenton has quit IRC
351 2019-06-21T16:06:17  *** bralyclow has joined #bitcoin-core-dev
352 2019-06-21T16:11:29  *** DeanGuss has joined #bitcoin-core-dev
353 2019-06-21T16:11:30  *** rafalcpp_ has joined #bitcoin-core-dev
354 2019-06-21T16:12:10  *** queip has quit IRC
355 2019-06-21T16:12:10  *** rafalcpp has quit IRC
356 2019-06-21T16:15:14  *** aseem has quit IRC
357 2019-06-21T16:16:20  *** bralyclow has quit IRC
358 2019-06-21T16:17:23  *** bralyclow has joined #bitcoin-core-dev
359 2019-06-21T16:17:31  *** d_t has joined #bitcoin-core-dev
360 2019-06-21T16:18:14  *** queip has joined #bitcoin-core-dev
361 2019-06-21T16:19:30  *** rex4539 has quit IRC
362 2019-06-21T16:20:16  *** rex4539 has joined #bitcoin-core-dev
363 2019-06-21T16:20:36  *** jarthur has joined #bitcoin-core-dev
364 2019-06-21T16:21:43  *** bralyclow has quit IRC
365 2019-06-21T16:22:27  *** kljasdfvv has quit IRC
366 2019-06-21T16:23:42  *** aseem has joined #bitcoin-core-dev
367 2019-06-21T16:24:04  *** rex4539 has quit IRC
368 2019-06-21T16:33:55  *** brianhoffman has joined #bitcoin-core-dev
369 2019-06-21T16:41:42  <phantomcircuit> kallewoof, i mean im sure it doesn't matter at least
370 2019-06-21T16:42:31  <kallewoof> why not?
371 2019-06-21T16:42:56  *** TheRec has quit IRC
372 2019-06-21T16:45:00  <phantomcircuit> kallewoof, the inner loop is doing all of the hashing for the block again anyways
373 2019-06-21T16:45:21  <phantomcircuit> so changing the extra nonce value even every loop wouldn't make it any slower
374 2019-06-21T16:46:00  <kallewoof> you lose 16 bits worth of nonce space though
375 2019-06-21T16:46:17  <phantomcircuit> so what
376 2019-06-21T16:47:50  <phantomcircuit> that's not even a vaguely efficient loop regardless
377 2019-06-21T16:47:52  <kallewoof> it doesnt matter for regtest, or other trivially mineable nets, no. i am having issues with signet though cause i have to actually re-create signatures every time you run out of nonces. having 32 bits intead of 16 would make things a lot less grumpifying.
378 2019-06-21T16:48:27  <sipa> kallewoof: the code for the generate RPC is designed for simplicity, not efficiency
379 2019-06-21T16:49:25  <kallewoof> sipa: yeah, just wondering if that 16 bit cap was for a reason or if it was just arbitrary
380 2019-06-21T16:51:41  *** scoop has quit IRC
381 2019-06-21T16:51:48  <phantomcircuit> sipa, wait wouldn't that be a hard stop at the inner loop limit instead of at the nmaxtries?
382 2019-06-21T16:52:28  <phantomcircuit> actually nvm im dumb
383 2019-06-21T16:53:55  <phantomcircuit> it should be a uint32_t though
384 2019-06-21T16:53:56  * phantomcircuit runs
385 2019-06-21T16:58:08  *** Emcy_ has quit IRC
386 2019-06-21T17:01:30  <phantomcircuit> kallewoof, i cant measure a performance difference between the loop stopping at 16 vs 32 bits searched
387 2019-06-21T17:01:55  <phantomcircuit> takes about 1 minute to generate 1000 blocks on a new regtest chain either way
388 2019-06-21T17:02:02  <phantomcircuit> (sorry 10000)
389 2019-06-21T17:02:21  <kallewoof> phantomcircuit: thats not the point. in signets case i have to actually ask every signer to resign whenever we run out of nonce space. i can use custom mining software but that seems overkill for a test network
390 2019-06-21T17:03:48  <kallewoof> 65535 combos vs 4294967296 makes a big difference when you have to generate signatures and stuff. esp if you are doing multi-sig with peers all over the place.
391 2019-06-21T17:04:25  <phantomcircuit> kallewoof, i don't see any reason not to make the  search space 32 bits
392 2019-06-21T17:04:48  <kallewoof> great! me neither. :)
393 2019-06-21T17:05:00  <achow101> meshcollider: do you think #15588 is mergable? It's a pretty simple change
394 2019-06-21T17:05:03  <gribble> https://github.com/bitcoin/bitcoin/issues/15588 | Log the actual wallet file version and no longer publicly expose the "version" record by achow101 · Pull Request #15588 · bitcoin/bitcoin · GitHub
395 2019-06-21T17:05:17  <phantomcircuit> actually i dont see any reason for the inner loop check at all
396 2019-06-21T17:07:35  <phantomcircuit> kallewoof, actually i see why, the ShutdownRequested() check in the loop
397 2019-06-21T17:07:45  <phantomcircuit> only gets called once per search of the nonce space
398 2019-06-21T17:07:48  <kallewoof> Yeah, that seems to be the only reason.
399 2019-06-21T17:08:29  <kallewoof> And thats  what I noticed when I upped it to 0xffffffff.. I couldnt actually ^C without waiting for the entire 32 bits to iterate through.
400 2019-06-21T17:09:50  <phantomcircuit> on x86 it should be cheap enough to check that every inner loop
401 2019-06-21T17:11:46  *** Chris_Stewart_5 has quit IRC
402 2019-06-21T17:13:59  <sipa> this was before we had atomic variables
403 2019-06-21T17:14:55  <phantomcircuit> sipa, yeah no criticism from me there
404 2019-06-21T17:15:03  <phantomcircuit> makes perfect sense this is how you did it
405 2019-06-21T17:15:24  *** timothy has quit IRC
406 2019-06-21T17:19:21  *** Emcy has joined #bitcoin-core-dev
407 2019-06-21T17:20:29  *** darosior has quit IRC
408 2019-06-21T17:21:09  *** bralyclow has joined #bitcoin-core-dev
409 2019-06-21T17:21:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
410 2019-06-21T17:26:15  *** DeanGuss has quit IRC
411 2019-06-21T17:28:18  *** bitcoin-git has joined #bitcoin-core-dev
412 2019-06-21T17:28:18  <bitcoin-git> [bitcoin] pstratem opened pull request #16262: Slightly simplify the mining loop. (master...2019-06-21-generateblocks) https://github.com/bitcoin/bitcoin/pull/16262
413 2019-06-21T17:28:31  *** bitcoin-git has left #bitcoin-core-dev
414 2019-06-21T17:29:02  *** PastaPasta has quit IRC
415 2019-06-21T17:29:16  <phantomcircuit> i help
416 2019-06-21T17:30:37  <kallewoof> i did something more complex. your solution is better.
417 2019-06-21T17:32:10  *** scoop has joined #bitcoin-core-dev
418 2019-06-21T17:32:20  *** scoop has quit IRC
419 2019-06-21T17:34:06  *** surja795 has joined #bitcoin-core-dev
420 2019-06-21T17:37:12  <promag> Can I have #16261 in HP?
421 2019-06-21T17:37:14  <gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
422 2019-06-21T17:37:51  <promag> achow101: FYI, if you rebase with that you'll have a couple of trivial conflicts
423 2019-06-21T17:42:37  *** bitcoin-git has joined #bitcoin-core-dev
424 2019-06-21T17:42:37  <bitcoin-git> [bitcoin] hebasto opened pull request #16263: qt: Use qInfo() if no error occurs (master...20190621-qInfo) https://github.com/bitcoin/bitcoin/pull/16263
425 2019-06-21T17:42:39  *** bitcoin-git has left #bitcoin-core-dev
426 2019-06-21T17:49:52  *** itsiku has quit IRC
427 2019-06-21T17:54:41  *** bralyclow has quit IRC
428 2019-06-21T17:54:53  *** TheRec has joined #bitcoin-core-dev
429 2019-06-21T17:56:18  *** scoop has joined #bitcoin-core-dev
430 2019-06-21T18:00:01  *** nyuszika7h1 has quit IRC
431 2019-06-21T18:00:29  *** scoop has quit IRC
432 2019-06-21T18:09:59  *** scoop has joined #bitcoin-core-dev
433 2019-06-21T18:10:03  *** pabelanger1 has joined #bitcoin-core-dev
434 2019-06-21T18:15:28  *** surja795 has quit IRC
435 2019-06-21T18:16:40  *** aseem has quit IRC
436 2019-06-21T18:17:21  *** aseem has joined #bitcoin-core-dev
437 2019-06-21T18:18:11  *** scoop has quit IRC
438 2019-06-21T18:20:26  *** scoop has joined #bitcoin-core-dev
439 2019-06-21T18:20:43  *** bralyclow has joined #bitcoin-core-dev
440 2019-06-21T18:20:59  *** rex4539 has joined #bitcoin-core-dev
441 2019-06-21T18:22:22  *** scoop has quit IRC
442 2019-06-21T18:22:38  *** scoop has joined #bitcoin-core-dev
443 2019-06-21T18:26:42  *** lightlike has quit IRC
444 2019-06-21T18:26:56  *** scoop has quit IRC
445 2019-06-21T18:27:16  *** scoop has joined #bitcoin-core-dev
446 2019-06-21T18:32:02  <sipa> if there is a wallet meeting today, i'll miss it (meeting with github)
447 2019-06-21T18:40:23  *** bitcoin-git has joined #bitcoin-core-dev
448 2019-06-21T18:40:23  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16264: policy: Add experimental -mempoolreplacement=full (off by default) (master...1906-policyFullRbf) https://github.com/bitcoin/bitcoin/pull/16264
449 2019-06-21T18:40:27  *** bitcoin-git has left #bitcoin-core-dev
450 2019-06-21T18:42:50  *** bralyclow has quit IRC
451 2019-06-21T18:47:43  *** bralyclow has joined #bitcoin-core-dev
452 2019-06-21T18:52:08  *** bralyclow has quit IRC
453 2019-06-21T18:55:04  *** scoop has quit IRC
454 2019-06-21T18:56:08  *** scoop has joined #bitcoin-core-dev
455 2019-06-21T18:56:45  *** scoop has quit IRC
456 2019-06-21T18:57:01  *** scoop has joined #bitcoin-core-dev
457 2019-06-21T19:00:14  <achow101> wallet meeting?
458 2019-06-21T19:00:21  <meshcollider> #startmeeting
459 2019-06-21T19:00:21  <lightningbot> Meeting started Fri Jun 21 19:00:21 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
460 2019-06-21T19:00:21  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
461 2019-06-21T19:00:38  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky
462 2019-06-21T19:01:01  <kanzure> hi
463 2019-06-21T19:01:05  <achow101> hi
464 2019-06-21T19:02:13  <achow101> something I mentioned yesterday that we could discuss here: "I've been working on implementing the scriptpubkeymanager  and I noticed a bunch of things related to key generation rely on the wallet version and wallet flags. Thoughts on how to handle those without introducing a circular dependency?"
465 2019-06-21T19:03:02  <achow101> sipa's suggestion was to have flags and version be part of the constructors for SPKmanagers, but these things get updated during key generation and imports
466 2019-06-21T19:03:40  <achow101> I tried having the spkmanager write out the updates to the wallet file, but then the parent cwallet instance wouldn't know about the flag changes. it also felt like a layer violation
467 2019-06-21T19:03:45  <achow101> any thoughts on that?
468 2019-06-21T19:04:23  <meshcollider> #topic scriptpubkeymanager wallet flags (achow101)
469 2019-06-21T19:05:50  <kanzure> managers are assigned a key, or managers make keys?
470 2019-06-21T19:06:01  <achow101> managers make keys
471 2019-06-21T19:06:38  <meshcollider> Can the wallet pass a pointer on construction instead?
472 2019-06-21T19:07:01  <achow101> yes, but locks..
473 2019-06-21T19:07:23  <achow101> IIRC cs_wallet needs to be locked to modify flags but spkmanagers won't have access to cs_wallet
474 2019-06-21T19:09:13  *** queip has quit IRC
475 2019-06-21T19:09:13  *** rafalcpp has joined #bitcoin-core-dev
476 2019-06-21T19:09:18  <achow101> FWIW all of the wallet flags are things that spkmanagers care about, not the wallet. so maybe it does make sense to just have the wallet's flag stuff call through to the spkmanager's?
477 2019-06-21T19:09:19  <meshcollider> Hmm, pass a callback function down from the wallet then?
478 2019-06-21T19:09:57  *** surja795 has joined #bitcoin-core-dev
479 2019-06-21T19:10:01  *** rafalcpp_ has quit IRC
480 2019-06-21T19:10:07  <instagibbs> which things/flags get updated on import, just to job my memory
481 2019-06-21T19:10:23  <meshcollider> Which SPKManager would provide the flags then
482 2019-06-21T19:11:14  <achow101> instagibbs: WALLET_FLAG_BLANK_WALLET changes on import and key generation. WALLET_FLAG_KEY_ORIGIN_METADATA can change on load. WALLET_FLAG_DISABLE_PRIVATE_KEYS is checked before keys are generated
483 2019-06-21T19:11:45  <achow101> meshcollider: I think they would all have the same flags, so it doesn't matter. but I guess there's an update problem with that too..
484 2019-06-21T19:12:08  <achow101> the only flag that SPKManagers won't use is WALLET_FLAG_AVOID_REUSE
485 2019-06-21T19:12:46  *** infernix has quit IRC
486 2019-06-21T19:13:12  <achow101> my initial thought was to have each spkmanager also store a pointer to it's parent cwallet, but that's circular
487 2019-06-21T19:14:14  <meshcollider> I guess BLANK_ and KEY_ORIGIN_ can be per-spkmanager and the wallet can itetate over them all with OR
488 2019-06-21T19:14:44  <meshcollider> Iterate*
489 2019-06-21T19:15:25  <meshcollider> Whereas DISABLE_PRIV doesn't change does it
490 2019-06-21T19:15:37  <achow101> it doesn't
491 2019-06-21T19:15:43  *** queip has joined #bitcoin-core-dev
492 2019-06-21T19:17:05  *** justan0theruser has joined #bitcoin-core-dev
493 2019-06-21T19:17:06  <meshcollider> Am I right in thinking these flags only ever get set, never reset
494 2019-06-21T19:17:15  <meshcollider> So you can just OR them all
495 2019-06-21T19:17:18  <achow101> yeah
496 2019-06-21T19:17:21  <meshcollider> bitwise
497 2019-06-21T19:17:31  <achow101> so should there be a new wallet record for spkmanager flags?
498 2019-06-21T19:19:13  <achow101> I don't think that approach will really work though since there won't necessarily be a way to uniquely identify spkmanagers
499 2019-06-21T19:19:29  <achow101> the whole loading part is kind of an issue
500 2019-06-21T19:19:48  *** justanotheruser has quit IRC
501 2019-06-21T19:19:52  *** justan0theruser is now known as justanotheruser
502 2019-06-21T19:21:29  <meshcollider> Just because one SPKManager changes a flag doesn't mean they all need to update their flags do they? It doesn't matter if they all get the same flags at reload?
503 2019-06-21T19:21:49  *** timothy has joined #bitcoin-core-dev
504 2019-06-21T19:21:51  <meshcollider> As long as whichever one updates can write it to the wallet file
505 2019-06-21T19:23:34  <achow101> I think so?
506 2019-06-21T19:27:25  *** bralyclow has joined #bitcoin-core-dev
507 2019-06-21T19:28:33  <achow101> so i guess the conclusion is that spkmanagers will handle the storage of BLANK, KEY_ORIGIN, an DISABLE_PRIV flags and CWallet handles the storage of AVOID_REUSE
508 2019-06-21T19:29:25  <meshcollider> seems sensible
509 2019-06-21T19:29:33  <achow101> i can foresee some concurrency issues with this
510 2019-06-21T19:30:43  <meshcollider> Hmm I don't really see why there needs to be concurrency issues if they're not being used to communicate with each other at runtime
511 2019-06-21T19:32:01  <meshcollider> Are there any other topics or is this the only one? Just so we aren't holding up the meeting if we continue discussing this
512 2019-06-21T19:32:43  <meshcollider> Doesn't seem like attendance is very high today so I assume this is it :)
513 2019-06-21T19:33:14  <achow101> the flags between cwallet and each spkmanager can be out of sync, so the update of flags on one object can undo an update from another one
514 2019-06-21T19:34:19  <meshcollider> But like I said earlier, isn't each flag only one-way
515 2019-06-21T19:34:39  <achow101> e.g. cwallet has BLANK set. spkmanager unsets BLANK because a seed is set so it writes that to the file. CWallet still has BLANK set. it updates the flags because AVOID_REUSE is changed so now the old BLANK is written back to the wallet
516 2019-06-21T19:35:26  <achow101> not so much concurrency than not updating objects i suppose
517 2019-06-21T19:36:17  <meshcollider> CWallet wouldn't store BLANK anyway
518 2019-06-21T19:36:30  <meshcollider> If it needs to know blank, it would ask the spkmanagers
519 2019-06-21T19:36:37  *** astro_ has quit IRC
520 2019-06-21T19:36:57  <achow101> yeah, but the wallet flags record is just a bitfield. it can't update it without updating the whole thing
521 2019-06-21T19:37:00  *** astro has joined #bitcoin-core-dev
522 2019-06-21T19:37:06  <achow101> so it needs to know all flags in effect
523 2019-06-21T19:39:12  *** Chris_Stewart_5 has quit IRC
524 2019-06-21T19:40:13  *** scoop has quit IRC
525 2019-06-21T19:40:56  *** scoop has joined #bitcoin-core-dev
526 2019-06-21T19:41:35  <achow101> maybe function callbacks are the best option
527 2019-06-21T19:41:51  *** rex4539 has quit IRC
528 2019-06-21T19:43:43  <meshcollider> It seems like it might be, or can you use the built in atomic stuff to avoid locks
529 2019-06-21T19:44:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
530 2019-06-21T19:44:58  *** scoop has quit IRC
531 2019-06-21T19:45:17  <achow101> i'll try it out
532 2019-06-21T19:45:44  <meshcollider> Alright
533 2019-06-21T19:45:57  <meshcollider> Yeah I don't see a particularly clean solution otherwise
534 2019-06-21T19:46:21  <meshcollider> Ok let's end the meeting there then, too many people away today
535 2019-06-21T19:46:24  <meshcollider> #endmeeting
536 2019-06-21T19:46:24  <lightningbot> Meeting ended Fri Jun 21 19:46:24 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
537 2019-06-21T19:46:24  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.html
538 2019-06-21T19:46:24  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.txt
539 2019-06-21T19:46:24  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.log.html
540 2019-06-21T19:46:45  <achow101> this refactor has turned out to be much harder than I thought it would be
541 2019-06-21T19:46:57  <achow101> good luck reviewing it
542 2019-06-21T19:49:22  *** aseem has quit IRC
543 2019-06-21T19:50:42  *** jarthur_ has joined #bitcoin-core-dev
544 2019-06-21T19:50:51  *** Zenton has joined #bitcoin-core-dev
545 2019-06-21T19:54:01  *** aseem has joined #bitcoin-core-dev
546 2019-06-21T19:54:20  *** jarthur has quit IRC
547 2019-06-21T19:57:26  *** elichai2 has quit IRC
548 2019-06-21T19:58:08  *** dviola has quit IRC
549 2019-06-21T20:00:30  *** bralyclow has quit IRC
550 2019-06-21T20:04:11  *** scoop has joined #bitcoin-core-dev
551 2019-06-21T20:09:24  *** Guyver2 has quit IRC
552 2019-06-21T20:13:03  *** bitcoin-git has joined #bitcoin-core-dev
553 2019-06-21T20:13:03  <bitcoin-git> [bitcoin] asood123 opened pull request #16265: Update check disk space in bitcoind (master...patch-15813) https://github.com/bitcoin/bitcoin/pull/16265
554 2019-06-21T20:13:07  *** bitcoin-git has left #bitcoin-core-dev
555 2019-06-21T20:15:27  *** laptop500 has quit IRC
556 2019-06-21T20:19:45  *** scoop has quit IRC
557 2019-06-21T20:21:43  *** paracyst_ has quit IRC
558 2019-06-21T20:22:57  *** dviola has joined #bitcoin-core-dev
559 2019-06-21T20:28:43  *** paracyst has joined #bitcoin-core-dev
560 2019-06-21T20:30:08  *** surja795 has quit IRC
561 2019-06-21T20:31:01  *** scoop has joined #bitcoin-core-dev
562 2019-06-21T20:34:26  *** paracyst has quit IRC
563 2019-06-21T20:35:12  *** scoop has quit IRC
564 2019-06-21T20:36:35  *** infernix has joined #bitcoin-core-dev
565 2019-06-21T20:56:24  *** paracyst has joined #bitcoin-core-dev
566 2019-06-21T20:56:51  *** jarthur_ has quit IRC
567 2019-06-21T20:57:02  *** spinza has quit IRC
568 2019-06-21T20:57:21  *** jarthur has joined #bitcoin-core-dev
569 2019-06-21T21:00:03  *** pabelanger1 has quit IRC
570 2019-06-21T21:00:58  *** surja795 has joined #bitcoin-core-dev
571 2019-06-21T21:01:04  *** rafalcpp_ has joined #bitcoin-core-dev
572 2019-06-21T21:02:11  *** DeanGuss has joined #bitcoin-core-dev
573 2019-06-21T21:02:18  *** queip has quit IRC
574 2019-06-21T21:02:18  *** rafalcpp has quit IRC
575 2019-06-21T21:06:35  *** spinza has joined #bitcoin-core-dev
576 2019-06-21T21:08:22  *** queip has joined #bitcoin-core-dev
577 2019-06-21T21:20:49  *** k0da has joined #bitcoin-core-dev
578 2019-06-21T21:21:44  *** emilengler has quit IRC
579 2019-06-21T21:23:55  *** emilengler has joined #bitcoin-core-dev
580 2019-06-21T21:26:56  *** Chris_Stewart_5 has quit IRC
581 2019-06-21T21:27:26  *** hebasto has quit IRC
582 2019-06-21T21:29:12  <gwillen> so I just ran into an issue (twice) where I broke one of the python tests in a confusing way with a typo
583 2019-06-21T21:29:22  <gwillen> and ended up accidentally reusing an intermediate from a testcase in a subsequent test case without noticing it
584 2019-06-21T21:29:50  <gwillen> my friend the python expert strongly recommends that the test cases should be separate functions as the best way to avoid this kind of issue, which doesn't seem crazy to me
585 2019-06-21T21:29:58  <gwillen> but of course, it seems like most or all the tests are written in this style
586 2019-06-21T21:30:01  <gwillen> so I'm curious what people think about that
587 2019-06-21T21:32:35  <gwillen> the failure mode where one accidentally reuses an intermediate from a previous test case is EXTREMELY mystifying and hard to diagnose
588 2019-06-21T21:32:37  *** aseem has quit IRC
589 2019-06-21T21:33:02  <gwillen> and it's easy to induce when adding/removing or commenting or uncommenting lines, given that each testcase uses most of the same names for intermediates
590 2019-06-21T21:33:28  <sipa> gwillen: my favorite *ahum* bug i ever had in python was when i had two classes with the same name, and the second just overwrote the first one, without warning
591 2019-06-21T21:33:41  <gwillen> oh geez
592 2019-06-21T21:33:58  <sipa> making me mystified why some obvioisly broken code in the first one wasn't causing problems
593 2019-06-21T21:34:04  <gwillen> yeah.
594 2019-06-21T21:34:18  <sipa> even google's internal linter at the time did not catch this
595 2019-06-21T21:34:33  <gwillen> when I suspect something like that my next move is always to break something VERY blatant in the code I'm not sure is running, like make it throw on the first line
596 2019-06-21T21:34:51  <sipa> yeah
597 2019-06-21T21:35:01  <sipa> anyway, your suggestions sounds very reasonable
598 2019-06-21T21:35:08  <sipa> but i'm not a python person myself
599 2019-06-21T21:36:07  <gwillen> my friend is one of the maintainers of mypy, and one of the Python People at dropbox
600 2019-06-21T21:36:20  <gwillen> so I take his suggestions on python style seriously :-)
601 2019-06-21T21:36:41  <sipa> ping MarcoFalke ^
602 2019-06-21T21:38:00  <gwillen> (he is also the author of "Peer-to-Peer Affine Commitment using Bitcoin", which describes the "Typecoin" system, and was almost named "Massively Multiplayer Online Linear Logic")
603 2019-06-21T21:46:32  <sipa> lol
604 2019-06-21T21:46:44  <sipa> mmoll
605 2019-06-21T21:52:01  *** surja795 has quit IRC
606 2019-06-21T21:54:44  *** surja795 has joined #bitcoin-core-dev
607 2019-06-21T21:57:25  *** bralyclow has joined #bitcoin-core-dev
608 2019-06-21T22:01:39  *** DeanGuss has quit IRC
609 2019-06-21T22:05:29  <luke-jr> sdaftuar: ping
610 2019-06-21T22:12:58  *** spinza has quit IRC
611 2019-06-21T22:15:51  *** ddustin has joined #bitcoin-core-dev
612 2019-06-21T22:16:46  *** ddustin has joined #bitcoin-core-dev
613 2019-06-21T22:17:31  *** ddustin has joined #bitcoin-core-dev
614 2019-06-21T22:21:42  *** shesek has joined #bitcoin-core-dev
615 2019-06-21T22:21:42  *** shesek has joined #bitcoin-core-dev
616 2019-06-21T22:23:49  *** rafalcpp has joined #bitcoin-core-dev
617 2019-06-21T22:24:38  *** rafalcpp_ has quit IRC
618 2019-06-21T22:24:46  *** scoop has joined #bitcoin-core-dev
619 2019-06-21T22:25:54  *** queip has quit IRC
620 2019-06-21T22:26:07  *** timothy has quit IRC
621 2019-06-21T22:26:55  *** spinza has joined #bitcoin-core-dev
622 2019-06-21T22:29:19  *** michaelsdunn1 has quit IRC
623 2019-06-21T22:30:36  *** queip has joined #bitcoin-core-dev
624 2019-06-21T22:30:52  *** bralyclow has quit IRC
625 2019-06-21T22:43:20  *** Wasyl has joined #bitcoin-core-dev
626 2019-06-21T22:47:11  *** Wasyl has quit IRC
627 2019-06-21T22:57:11  *** bralyclow has joined #bitcoin-core-dev
628 2019-06-21T23:04:01  *** surja795 has quit IRC
629 2019-06-21T23:07:42  *** captjakk has quit IRC
630 2019-06-21T23:09:20  *** jarthur has quit IRC
631 2019-06-21T23:18:58  *** jtimon has joined #bitcoin-core-dev
632 2019-06-21T23:19:36  *** emilengler has quit IRC
633 2019-06-21T23:20:33  *** owowo has quit IRC
634 2019-06-21T23:25:26  *** owowo has joined #bitcoin-core-dev
635 2019-06-21T23:30:41  *** bralyclow has quit IRC
636 2019-06-21T23:35:02  *** spinza has quit IRC
637 2019-06-21T23:35:13  *** bralyclow has joined #bitcoin-core-dev
638 2019-06-21T23:42:01  *** reallll has joined #bitcoin-core-dev
639 2019-06-21T23:42:02  <jtimon> In regtest, I'm sending coins from bitcoin core to lightningd's newaddr but it doesn't seem to be receiving anything, I'm generating more blocks  on the core node and calling dev_rescan_outputs on the lightning node, but still not seeing anything in listfunds and fundchannel says "Cannot afford transaction"
640 2019-06-21T23:42:14  <jtimon> what may I be doing wrong?
641 2019-06-21T23:43:27  <jtimon> sorry, wrong channel
642 2019-06-21T23:43:31  *** spinza has joined #bitcoin-core-dev
643 2019-06-21T23:43:43  *** jonatack has quit IRC
644 2019-06-21T23:45:35  *** belcher has quit IRC
645 2019-06-21T23:53:02  *** reallll is now known as belcher
646 2019-06-21T23:57:22  *** Skirmant has joined #bitcoin-core-dev