1 2019-07-19T00:00:02  *** nirik-fre has quit IRC
  2 2019-07-19T00:04:21  *** ButterflyOfFire has joined #bitcoin-core-dev
  3 2019-07-19T00:04:42  *** luc__ has joined #bitcoin-core-dev
  4 2019-07-19T00:07:43  *** scoop has quit IRC
  5 2019-07-19T00:09:28  *** luc__ has quit IRC
  6 2019-07-19T00:16:28  *** gribble has joined #bitcoin-core-dev
  7 2019-07-19T00:25:29  *** jarthur has quit IRC
  8 2019-07-19T00:25:37  *** Krellan has joined #bitcoin-core-dev
  9 2019-07-19T00:28:42  *** Scrat has joined #bitcoin-core-dev
 10 2019-07-19T00:30:12  *** Krellan has quit IRC
 11 2019-07-19T00:36:10  *** Scrat has quit IRC
 12 2019-07-19T00:39:27  *** ertewe has joined #bitcoin-core-dev
 13 2019-07-19T00:42:58  *** werrwer has quit IRC
 14 2019-07-19T00:44:35  *** ertewe has quit IRC
 15 2019-07-19T00:44:46  *** bitcoin-git has joined #bitcoin-core-dev
 16 2019-07-19T00:44:46  <bitcoin-git> [bitcoin] zenosage opened pull request #16422: test: remove redundant setup in addrman_tests (master...addrman_tests) https://github.com/bitcoin/bitcoin/pull/16422
 17 2019-07-19T00:44:59  *** bitcoin-git has left #bitcoin-core-dev
 18 2019-07-19T00:45:38  *** DeanWeen has joined #bitcoin-core-dev
 19 2019-07-19T00:54:38  *** jeremyrubin has quit IRC
 20 2019-07-19T00:57:32  *** Honthe has quit IRC
 21 2019-07-19T01:03:30  *** Krellan has joined #bitcoin-core-dev
 22 2019-07-19T01:05:31  *** Honthe has joined #bitcoin-core-dev
 23 2019-07-19T01:07:24  *** bitcoin-git has joined #bitcoin-core-dev
 24 2019-07-19T01:07:24  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5abb59a9a66...89d7229c9c18
 25 2019-07-19T01:07:25  <bitcoin-git> bitcoin/master 024ecd7 Jonas Schnelli: QA: Fix race condition in wallet_encryption test
 26 2019-07-19T01:07:25  <bitcoin-git> bitcoin/master 89d7229 fanquake: Merge #16420: QA: Fix race condition in wallet_encryption test
 27 2019-07-19T01:07:27  *** bitcoin-git has left #bitcoin-core-dev
 28 2019-07-19T01:08:29  *** bitcoin-git has joined #bitcoin-core-dev
 29 2019-07-19T01:08:29  <bitcoin-git> [bitcoin] fanquake merged pull request #16420: QA: Fix race condition in wallet_encryption test (master...2019/07/wallet_enc_test_fix) https://github.com/bitcoin/bitcoin/pull/16420
 30 2019-07-19T01:08:31  *** bitcoin-git has left #bitcoin-core-dev
 31 2019-07-19T01:13:39  *** nijak has quit IRC
 32 2019-07-19T01:13:41  *** nijak_ has joined #bitcoin-core-dev
 33 2019-07-19T01:13:58  <aj> yay!
 34 2019-07-19T01:17:42  *** nijak has joined #bitcoin-core-dev
 35 2019-07-19T01:19:19  *** nijak_ has quit IRC
 36 2019-07-19T01:21:57  *** scoop has joined #bitcoin-core-dev
 37 2019-07-19T01:22:11  *** DeanWeen has quit IRC
 38 2019-07-19T01:22:30  *** DeanWeen has joined #bitcoin-core-dev
 39 2019-07-19T01:37:56  *** Krellan has quit IRC
 40 2019-07-19T01:47:28  *** kljasdfvv has quit IRC
 41 2019-07-19T01:48:08  *** kljasdfvv has joined #bitcoin-core-dev
 42 2019-07-19T02:09:32  *** DeanWeen has quit IRC
 43 2019-07-19T02:11:41  *** spinza has quit IRC
 44 2019-07-19T02:11:45  *** Krellan has joined #bitcoin-core-dev
 45 2019-07-19T02:16:46  *** Krellan has quit IRC
 46 2019-07-19T02:25:38  *** queip has quit IRC
 47 2019-07-19T02:31:28  *** queip has joined #bitcoin-core-dev
 48 2019-07-19T02:34:27  *** spinza has joined #bitcoin-core-dev
 49 2019-07-19T02:45:51  *** kristapsk_ has joined #bitcoin-core-dev
 50 2019-07-19T02:46:28  *** Krellan has joined #bitcoin-core-dev
 51 2019-07-19T02:47:04  *** kristapsk has quit IRC
 52 2019-07-19T02:47:31  *** ghost43 has quit IRC
 53 2019-07-19T02:48:21  *** ghost43 has joined #bitcoin-core-dev
 54 2019-07-19T03:00:01  *** ButterflyOfFire has quit IRC
 55 2019-07-19T03:03:57  *** Kabaka has joined #bitcoin-core-dev
 56 2019-07-19T03:09:45  *** d_t has joined #bitcoin-core-dev
 57 2019-07-19T03:11:18  *** davterra has joined #bitcoin-core-dev
 58 2019-07-19T03:20:14  *** Krellan has quit IRC
 59 2019-07-19T03:21:02  *** schnerch_ has joined #bitcoin-core-dev
 60 2019-07-19T03:24:32  *** schnerchi has quit IRC
 61 2019-07-19T03:25:35  *** captjakk has joined #bitcoin-core-dev
 62 2019-07-19T03:57:09  *** captjakk has quit IRC
 63 2019-07-19T04:04:41  *** d_t has quit IRC
 64 2019-07-19T04:06:39  *** d_t has joined #bitcoin-core-dev
 65 2019-07-19T04:11:50  *** hebasto has joined #bitcoin-core-dev
 66 2019-07-19T04:13:16  *** hebasto has quit IRC
 67 2019-07-19T04:30:14  *** d_t has quit IRC
 68 2019-07-19T04:31:17  *** jtimon has quit IRC
 69 2019-07-19T04:31:54  *** Victor_sueca has joined #bitcoin-core-dev
 70 2019-07-19T04:34:37  *** Victorsueca has quit IRC
 71 2019-07-19T04:36:39  *** Krellan has joined #bitcoin-core-dev
 72 2019-07-19T05:13:45  *** Taborlin has joined #bitcoin-core-dev
 73 2019-07-19T05:16:03  *** Krellan has quit IRC
 74 2019-07-19T05:17:31  *** Krellan has joined #bitcoin-core-dev
 75 2019-07-19T05:19:41  *** Taborlin has quit IRC
 76 2019-07-19T05:22:10  *** Krellan has quit IRC
 77 2019-07-19T05:31:57  <meshcollider> achow101: There is a wallet meeting scheduled tomorrow
 78 2019-07-19T05:32:14  <meshcollider> But i will be on a bus so I won't be able to host it
 79 2019-07-19T05:32:17  *** Krellan has joined #bitcoin-core-dev
 80 2019-07-19T05:32:27  <meshcollider> Someone else want to volunteer?
 81 2019-07-19T05:33:00  *** lowentropy has quit IRC
 82 2019-07-19T05:38:10  *** d_t has joined #bitcoin-core-dev
 83 2019-07-19T05:46:50  *** Krellan_ has joined #bitcoin-core-dev
 84 2019-07-19T05:47:00  *** scoop_ has joined #bitcoin-core-dev
 85 2019-07-19T05:47:32  *** cornfeedhobo has quit IRC
 86 2019-07-19T05:47:32  *** shtirlic has quit IRC
 87 2019-07-19T05:47:57  *** chainhead has quit IRC
 88 2019-07-19T05:48:05  *** chainhead has joined #bitcoin-core-dev
 89 2019-07-19T05:48:22  *** votesmith has quit IRC
 90 2019-07-19T05:48:24  *** scoop has quit IRC
 91 2019-07-19T05:48:53  *** shtirlic has joined #bitcoin-core-dev
 92 2019-07-19T05:49:37  *** Krellan has quit IRC
 93 2019-07-19T05:49:37  *** rabidus has quit IRC
 94 2019-07-19T05:49:50  *** rabidus has joined #bitcoin-core-dev
 95 2019-07-19T05:51:40  *** votesmith has joined #bitcoin-core-dev
 96 2019-07-19T05:57:52  <kallewoof> Would it be horrible to remove the assume valid stuff from bitcoin core? It feels like signature validation is pretty fast these days.
 97 2019-07-19T06:00:02  *** Kabaka has quit IRC
 98 2019-07-19T06:07:05  *** cornfeedhobo has joined #bitcoin-core-dev
 99 2019-07-19T06:07:25  *** luc__ has joined #bitcoin-core-dev
100 2019-07-19T06:11:50  *** luc__ has quit IRC
101 2019-07-19T06:18:24  *** seaLne1 has joined #bitcoin-core-dev
102 2019-07-19T06:24:02  <mryandao> why not set the default to off instead?
103 2019-07-19T06:25:16  <sipa> kallewoof: really?
104 2019-07-19T06:26:36  <sipa> i think it's around a week of CPU time to verify all historical signatures
105 2019-07-19T06:26:49  <sipa> on a modern x86 cpu
106 2019-07-19T06:27:23  <sipa> if you have 32 cores that's perhaps acceptable
107 2019-07-19T06:32:10  *** elichai2 has quit IRC
108 2019-07-19T06:36:05  *** d_t has quit IRC
109 2019-07-19T06:39:09  *** Krellan_ has quit IRC
110 2019-07-19T06:39:42  <kallewoof> It's that big of a difference? I must have misheard numbers then.
111 2019-07-19T06:55:47  <sipa> it's 50 microseconds or so per signature check
112 2019-07-19T06:56:30  <sipa> assuming a billion sigcheck (rough guess) in the chain, that's 5 days of CPU time (divided by the number of threads to get real time)
113 2019-07-19T06:57:49  <mryandao> is there a plot that tracks number of sigcheck ops to date?
114 2019-07-19T06:57:54  <jonasschnelli> MarcoFalke: are you sure CCACHE_SIZE is the right directive: https://github.com/bitcoin/bitcoin/blob/master/.travis.yml#L49?
115 2019-07-19T06:58:11  <jonasschnelli> maybe it's travis special
116 2019-07-19T06:58:33  <jonasschnelli> But it looks like that the ccache env var would be CCACHE_MAXSIZE (instead of CCACHE_SIZE) https://ccache.dev/manual/3.4.html#_cache_size_management
117 2019-07-19T07:00:35  *** jonatack has quit IRC
118 2019-07-19T07:02:57  <fanquake> jonasschnelli: hard to tell. Looks like there are usages of either VAR in .travis.yml files on github. i.e https://github.com/search?l=yaml&q=CCACHE_MAXSIZE&type=Code
119 2019-07-19T07:03:20  <jonasschnelli> maybe set both *duck*
120 2019-07-19T07:04:37  <kallewoof> CCACHE_MAXSIZE is correct according to man ccache
121 2019-07-19T07:07:57  *** queip has quit IRC
122 2019-07-19T07:10:27  <kallewoof> Just me or is travis not creating new jobs when pushing to a PR branch..? (it creates local instances for my own repo but not for bitcoin).
123 2019-07-19T07:13:41  *** queip has joined #bitcoin-core-dev
124 2019-07-19T07:18:39  *** double_helix has quit IRC
125 2019-07-19T07:20:39  *** jungly has joined #bitcoin-core-dev
126 2019-07-19T07:29:27  *** pinheadmz has quit IRC
127 2019-07-19T07:41:20  *** Krellan has joined #bitcoin-core-dev
128 2019-07-19T07:49:15  *** EagleTM has joined #bitcoin-core-dev
129 2019-07-19T08:00:18  *** jonatack has joined #bitcoin-core-dev
130 2019-07-19T08:06:39  *** jonatack has quit IRC
131 2019-07-19T08:14:44  *** Krellan has quit IRC
132 2019-07-19T08:19:14  *** setpill has joined #bitcoin-core-dev
133 2019-07-19T08:22:38  *** jonatack has joined #bitcoin-core-dev
134 2019-07-19T08:26:05  *** AaronvanW has joined #bitcoin-core-dev
135 2019-07-19T08:28:28  *** timothy has joined #bitcoin-core-dev
136 2019-07-19T08:29:23  *** kljasdfvv has quit IRC
137 2019-07-19T08:29:45  *** kljasdfvv has joined #bitcoin-core-dev
138 2019-07-19T08:34:15  *** Zenton has joined #bitcoin-core-dev
139 2019-07-19T08:40:13  *** scoop_ has quit IRC
140 2019-07-19T08:42:42  *** EagleTM has quit IRC
141 2019-07-19T08:46:02  *** jonatack has quit IRC
142 2019-07-19T08:53:23  *** EagleTM has joined #bitcoin-core-dev
143 2019-07-19T09:00:02  *** seaLne1 has quit IRC
144 2019-07-19T09:00:02  *** jonatack has joined #bitcoin-core-dev
145 2019-07-19T09:04:02  *** delinka has joined #bitcoin-core-dev
146 2019-07-19T09:05:56  *** Logan63 has joined #bitcoin-core-dev
147 2019-07-19T09:06:10  *** Madars_ has quit IRC
148 2019-07-19T09:07:33  *** Skirmant has quit IRC
149 2019-07-19T09:07:40  *** Madars_ has joined #bitcoin-core-dev
150 2019-07-19T09:08:21  *** Logan63 has quit IRC
151 2019-07-19T09:26:16  *** Krellan has joined #bitcoin-core-dev
152 2019-07-19T09:34:30  *** bitcoin-git has joined #bitcoin-core-dev
153 2019-07-19T09:34:30  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/89d7229c9c18...59ce537a4994
154 2019-07-19T09:34:31  <bitcoin-git> bitcoin/master 5efcb77 Matt Corallo: Disable bloom filtering by default.
155 2019-07-19T09:34:32  <bitcoin-git> bitcoin/master f27309f Matt Corallo: Move DEFAULT_PEERBLOOMFILTERS from validation.h to net_processing.h
156 2019-07-19T09:34:33  <bitcoin-git> bitcoin/master bead32e Matt Corallo: Add release notes for DEFAULT_BLOOM change
157 2019-07-19T09:34:34  *** bitcoin-git has left #bitcoin-core-dev
158 2019-07-19T09:35:19  *** bitcoin-git has joined #bitcoin-core-dev
159 2019-07-19T09:35:19  <bitcoin-git> [bitcoin] fanquake merged pull request #16152: Disable bloom filtering by default. (master...2019-06-fix-dos) https://github.com/bitcoin/bitcoin/pull/16152
160 2019-07-19T09:35:22  *** bitcoin-git has left #bitcoin-core-dev
161 2019-07-19T09:36:18  *** queip has quit IRC
162 2019-07-19T09:41:24  *** queip has joined #bitcoin-core-dev
163 2019-07-19T10:00:08  *** Krellan has quit IRC
164 2019-07-19T10:04:44  *** Aaronvan_ has joined #bitcoin-core-dev
165 2019-07-19T10:07:58  *** AaronvanW has quit IRC
166 2019-07-19T10:19:46  *** queip has quit IRC
167 2019-07-19T10:25:27  *** queip has joined #bitcoin-core-dev
168 2019-07-19T10:41:51  *** jonatack has quit IRC
169 2019-07-19T10:51:35  *** Aaronvan_ is now known as AaronvanW
170 2019-07-19T11:03:44  *** Krellan has joined #bitcoin-core-dev
171 2019-07-19T11:14:52  *** morcos has quit IRC
172 2019-07-19T11:15:13  *** morcos has joined #bitcoin-core-dev
173 2019-07-19T11:15:22  <jonasschnelli> Would someone mind if I add a webhook to bitcoin/bitcoin (a "readonly" webhook) to drive the CI i have built in the last weeks?
174 2019-07-19T11:15:42  <jonasschnelli> It's non-invasive (as said, readonly)
175 2019-07-19T11:15:52  <jonasschnelli> ^ wumpus, MarcoFalke, fanquake
176 2019-07-19T11:16:09  <jonasschnelli> the CI is currently under heave development: https://bitcoinbuilds.org/
177 2019-07-19T11:16:28  <jonasschnelli> But I want to test it with some load and integrate building all PR pushes
178 2019-07-19T11:26:29  <fanquake> jonasschnelli: Interesting. Is the source for the site going to live here: https://github.com/jonasschnelli/bitcoin-core-ci?
179 2019-07-19T11:26:30  <fanquake> What hardware are you running the builds on atm?
180 2019-07-19T11:26:57  <jonasschnelli> Yes. The source code will end up at that repo (as soon as its ready)
181 2019-07-19T11:27:07  <jonasschnelli> Its running on a relatively powerful physical host
182 2019-07-19T11:27:14  <jonasschnelli> It's based on KVM
183 2019-07-19T11:27:23  <jonasschnelli> Full custom software though
184 2019-07-19T11:27:25  <fanquake> The site looks pretty nice. At least looking at large logs is more responsive than Travis 👍
185 2019-07-19T11:27:39  <fanquake> I assume you'll be adding macOS and other builds later on?
186 2019-07-19T11:27:41  <jonasschnelli> Yeah... travis logs are a nightmare.
187 2019-07-19T11:28:00  <jonasschnelli> fanquake: Yes. All possible. Just caping to three platforms right now then later expand
188 2019-07-19T11:28:56  <fanquake> Cool. I'm not opposed to a read-only hook if you want to stress / load test for a week or two. Probably worth bring up at a meeting after that.
189 2019-07-19T11:29:14  <jonasschnelli> Yes. We can discuss that next thursday
190 2019-07-19T11:32:44  *** jtimon has joined #bitcoin-core-dev
191 2019-07-19T11:33:39  *** jtimon has quit IRC
192 2019-07-19T11:36:49  *** Krellan has quit IRC
193 2019-07-19T11:45:20  *** StopAndDecrypt has joined #bitcoin-core-dev
194 2019-07-19T12:00:01  *** delinka has quit IRC
195 2019-07-19T12:04:38  *** quijote has quit IRC
196 2019-07-19T12:09:45  *** luc__ has joined #bitcoin-core-dev
197 2019-07-19T12:12:31  *** Greedi has joined #bitcoin-core-dev
198 2019-07-19T12:14:26  *** luc__ has quit IRC
199 2019-07-19T12:17:56  *** d_t has joined #bitcoin-core-dev
200 2019-07-19T12:25:56  *** goatpig has joined #bitcoin-core-dev
201 2019-07-19T12:34:15  <kallewoof> Weird. Github claims "all checks passed" for #16411 but in reality, the travis check never actually executed, only the appveyor one. :/
202 2019-07-19T12:34:18  <gribble> https://github.com/bitcoin/bitcoin/issues/16411 | Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
203 2019-07-19T12:34:59  *** as1nc_ has quit IRC
204 2019-07-19T12:35:19  *** as1nc_ has joined #bitcoin-core-dev
205 2019-07-19T12:36:17  *** scoop has joined #bitcoin-core-dev
206 2019-07-19T12:38:49  *** Krellan has joined #bitcoin-core-dev
207 2019-07-19T12:40:42  <fanquake> Travis has a habit of doing weird things like that. Sometimes it'll show Travis failing when in fact all tests have passed.
208 2019-07-19T12:46:28  *** d_t has quit IRC
209 2019-07-19T12:48:58  *** reallll has joined #bitcoin-core-dev
210 2019-07-19T12:52:38  *** belcher has quit IRC
211 2019-07-19T13:13:06  *** Krellan has quit IRC
212 2019-07-19T13:13:06  *** Cory has quit IRC
213 2019-07-19T13:17:26  *** Guyver2 has joined #bitcoin-core-dev
214 2019-07-19T13:23:30  *** jonatack has joined #bitcoin-core-dev
215 2019-07-19T13:23:46  *** davterra has quit IRC
216 2019-07-19T13:24:59  *** setpill has quit IRC
217 2019-07-19T13:30:42  *** setpill has joined #bitcoin-core-dev
218 2019-07-19T13:39:12  *** d_t has joined #bitcoin-core-dev
219 2019-07-19T13:42:28  *** Zenton has quit IRC
220 2019-07-19T13:42:51  *** Zenton has joined #bitcoin-core-dev
221 2019-07-19T13:44:57  *** d_t has quit IRC
222 2019-07-19T13:50:29  *** d_t has joined #bitcoin-core-dev
223 2019-07-19T13:54:58  *** d_t has quit IRC
224 2019-07-19T13:56:57  *** etwert has joined #bitcoin-core-dev
225 2019-07-19T14:08:52  *** pinheadmz has joined #bitcoin-core-dev
226 2019-07-19T14:09:32  *** jnewbery has quit IRC
227 2019-07-19T14:10:59  *** davterra has joined #bitcoin-core-dev
228 2019-07-19T14:13:23  *** jnewbery has joined #bitcoin-core-dev
229 2019-07-19T14:16:24  *** hexyul has quit IRC
230 2019-07-19T14:16:55  *** davterra has quit IRC
231 2019-07-19T14:17:24  *** davterra has joined #bitcoin-core-dev
232 2019-07-19T14:20:57  *** bitcoin-git has joined #bitcoin-core-dev
233 2019-07-19T14:20:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59ce537a4994...c7b7cf299a9e
234 2019-07-19T14:20:58  <bitcoin-git> bitcoin/master 5c3c24c zenosage: test: remove redundant setup in addrman_tests
235 2019-07-19T14:20:58  <bitcoin-git> bitcoin/master c7b7cf2 MarcoFalke: Merge #16422: test: remove redundant setup in addrman_tests
236 2019-07-19T14:21:11  *** bitcoin-git has left #bitcoin-core-dev
237 2019-07-19T14:21:35  *** pinheadmz has quit IRC
238 2019-07-19T14:21:55  *** hexyul has joined #bitcoin-core-dev
239 2019-07-19T14:22:02  *** bitcoin-git has joined #bitcoin-core-dev
240 2019-07-19T14:22:02  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16422: test: remove redundant setup in addrman_tests (master...addrman_tests) https://github.com/bitcoin/bitcoin/pull/16422
241 2019-07-19T14:22:03  *** jb55 has joined #bitcoin-core-dev
242 2019-07-19T14:22:03  *** bitcoin-git has left #bitcoin-core-dev
243 2019-07-19T14:22:41  *** jarthur has joined #bitcoin-core-dev
244 2019-07-19T14:25:38  *** Krellan has joined #bitcoin-core-dev
245 2019-07-19T14:29:25  *** davterra has quit IRC
246 2019-07-19T14:35:16  *** setpill has quit IRC
247 2019-07-19T14:39:56  *** lei15 has joined #bitcoin-core-dev
248 2019-07-19T14:42:33  *** pinheadmz has joined #bitcoin-core-dev
249 2019-07-19T14:44:08  *** davterra has joined #bitcoin-core-dev
250 2019-07-19T14:45:00  *** harrigan has joined #bitcoin-core-dev
251 2019-07-19T14:53:14  *** rockhouse has quit IRC
252 2019-07-19T14:53:15  *** victorSN has quit IRC
253 2019-07-19T14:58:12  *** pinheadmz_ has joined #bitcoin-core-dev
254 2019-07-19T14:58:46  *** justanotheruser has quit IRC
255 2019-07-19T14:59:24  *** rockhouse has joined #bitcoin-core-dev
256 2019-07-19T14:59:42  *** victorSN has joined #bitcoin-core-dev
257 2019-07-19T14:59:52  *** Krellan has quit IRC
258 2019-07-19T15:00:01  *** Greedi has quit IRC
259 2019-07-19T15:00:52  *** pinheadmz has quit IRC
260 2019-07-19T15:00:52  *** pinheadmz_ is now known as pinheadmz
261 2019-07-19T15:03:47  *** rockhouse has quit IRC
262 2019-07-19T15:04:28  *** victorSN has quit IRC
263 2019-07-19T15:05:31  *** elichai2 has joined #bitcoin-core-dev
264 2019-07-19T15:08:20  *** hebasto has joined #bitcoin-core-dev
265 2019-07-19T15:09:01  *** rockhouse has joined #bitcoin-core-dev
266 2019-07-19T15:09:15  *** victorSN has joined #bitcoin-core-dev
267 2019-07-19T15:11:42  *** Victor_sueca has quit IRC
268 2019-07-19T15:12:57  *** MM87 has joined #bitcoin-core-dev
269 2019-07-19T15:13:56  *** Leo_Verto1 has joined #bitcoin-core-dev
270 2019-07-19T15:14:31  *** emilengler has joined #bitcoin-core-dev
271 2019-07-19T15:14:50  *** davterra has quit IRC
272 2019-07-19T15:16:58  *** michaelsdunn1 has joined #bitcoin-core-dev
273 2019-07-19T15:20:52  *** justanotheruser has joined #bitcoin-core-dev
274 2019-07-19T15:20:54  *** bitcoin-git has joined #bitcoin-core-dev
275 2019-07-19T15:20:54  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7b7cf299a9e...f4b1fe7165c8
276 2019-07-19T15:20:55  <bitcoin-git> bitcoin/master a52818c tecnovert: net: Make poll in InterruptibleRecv only filter for POLLIN events.
277 2019-07-19T15:20:56  <bitcoin-git> bitcoin/master f4b1fe7 Wladimir J. van der Laan: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN e...
278 2019-07-19T15:20:57  *** bitcoin-git has left #bitcoin-core-dev
279 2019-07-19T15:21:54  *** bitcoin-git has joined #bitcoin-core-dev
280 2019-07-19T15:21:54  <bitcoin-git> [bitcoin] laanwj merged pull request #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. (master...bitcoin-poll) https://github.com/bitcoin/bitcoin/pull/16412
281 2019-07-19T15:21:57  *** bitcoin-git has left #bitcoin-core-dev
282 2019-07-19T15:27:40  *** kljasdfvv has quit IRC
283 2019-07-19T15:31:49  *** lei15 has quit IRC
284 2019-07-19T15:36:01  *** Krellan has joined #bitcoin-core-dev
285 2019-07-19T15:39:54  *** captjakk has joined #bitcoin-core-dev
286 2019-07-19T15:40:27  *** Krellan has quit IRC
287 2019-07-19T15:50:36  *** emilengler has quit IRC
288 2019-07-19T15:55:53  *** Zenton has quit IRC
289 2019-07-19T15:56:56  *** jarthur has quit IRC
290 2019-07-19T16:00:03  *** bitcoin-git has joined #bitcoin-core-dev
291 2019-07-19T16:00:04  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/3f76160087c0...063c8ce7a054
292 2019-07-19T16:00:04  <bitcoin-git> bitcoin/0.18 063c8ce tecnovert: net: Make poll in InterruptibleRecv only filter for POLLIN events.
293 2019-07-19T16:00:16  *** bitcoin-git has left #bitcoin-core-dev
294 2019-07-19T16:00:28  *** Victorsueca has joined #bitcoin-core-dev
295 2019-07-19T16:02:52  <MarcoFalke> 0.18.1 can go
296 2019-07-19T16:06:39  *** Krellan has joined #bitcoin-core-dev
297 2019-07-19T16:08:29  *** teardown has quit IRC
298 2019-07-19T16:14:28  <wumpus> MarcoFalke: what about #16414?
299 2019-07-19T16:14:30  <gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
300 2019-07-19T16:15:22  <wumpus> (I think that is the last one)
301 2019-07-19T16:16:20  <wumpus> going to do pre-rc1 translations update
302 2019-07-19T16:18:49  *** davterra has joined #bitcoin-core-dev
303 2019-07-19T16:29:22  *** etwert has quit IRC
304 2019-07-19T16:32:32  *** DeanWeen has joined #bitcoin-core-dev
305 2019-07-19T16:34:21  *** timothy has quit IRC
306 2019-07-19T16:43:19  *** spinza has quit IRC
307 2019-07-19T16:44:34  *** Victorsueca has quit IRC
308 2019-07-19T16:44:41  *** Victor_sueca has joined #bitcoin-core-dev
309 2019-07-19T16:45:20  *** Victor_sueca has quit IRC
310 2019-07-19T16:46:10  *** Victor_sueca has joined #bitcoin-core-dev
311 2019-07-19T16:47:01  *** spinza has joined #bitcoin-core-dev
312 2019-07-19T16:47:57  *** jnewbery has quit IRC
313 2019-07-19T16:48:44  *** sdaftuar has quit IRC
314 2019-07-19T16:50:28  *** Victor_sueca has quit IRC
315 2019-07-19T16:51:44  *** jungly has quit IRC
316 2019-07-19T17:04:40  *** hebasto has quit IRC
317 2019-07-19T17:05:01  *** hebasto has joined #bitcoin-core-dev
318 2019-07-19T17:06:42  *** sdaftuar has joined #bitcoin-core-dev
319 2019-07-19T17:10:55  *** jnewbery has joined #bitcoin-core-dev
320 2019-07-19T17:23:16  *** DeanWeen has quit IRC
321 2019-07-19T17:27:24  *** harrigan has quit IRC
322 2019-07-19T17:31:23  *** etwert has joined #bitcoin-core-dev
323 2019-07-19T17:33:58  *** Victor_sueca has joined #bitcoin-core-dev
324 2019-07-19T17:40:54  *** jarthur has joined #bitcoin-core-dev
325 2019-07-19T17:46:31  *** harrigan has joined #bitcoin-core-dev
326 2019-07-19T17:51:49  *** bitcoin-git has joined #bitcoin-core-dev
327 2019-07-19T17:51:51  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/063c8ce7a054...a6cba19831da
328 2019-07-19T17:51:51  <bitcoin-git> bitcoin/0.18 641b2ff Wladimir J. van der Laan: qt: pre-rc1 translations update
329 2019-07-19T17:51:52  <bitcoin-git> bitcoin/0.18 aa2d12a Wladimir J. van der Laan: build: Bump version to 0.18.1rc1
330 2019-07-19T17:51:53  <bitcoin-git> bitcoin/0.18 a6cba19 Wladimir J. van der Laan: doc: Update manpages for rc1
331 2019-07-19T17:51:55  *** bitcoin-git has left #bitcoin-core-dev
332 2019-07-19T17:53:29  <BlueMatt> wumpus: plz2merge #15681
333 2019-07-19T17:53:31  <gribble> https://github.com/bitcoin/bitcoin/issues/15681 | [mempool] Allow one extra single-ancestor transaction per package by TheBlueMatt · Pull Request #15681 · bitcoin/bitcoin · GitHub
334 2019-07-19T17:53:47  <elichai2> sipa: kallewoof that's not right
335 2019-07-19T17:53:51  <wumpus> looks like recent changes in master broke compatibility with c-lightning
336 2019-07-19T17:53:55  <wumpus> BlueMatt: looking
337 2019-07-19T17:54:18  <elichai2> I did it yesterday. did a full IBD with assumbalid=0 from scratch in ~6 hours
338 2019-07-19T17:54:28  <elichai2> *assumevalid
339 2019-07-19T17:54:52  <wumpus> user@medea:~ % ./launch-lightning.sh
340 2019-07-19T17:54:54  <wumpus> bitcoin-cli getblockchaininfo: invalid response
341 2019-07-19T17:54:57  <wumpus> not sure why yet
342 2019-07-19T17:56:11  <elichai2> (fair point that I do have 8 cores and 16 threads, NVMe and a ~600MiB internet connection and I set dbcache=4096)
343 2019-07-19T17:58:11  <achow101> Could someone help me figure out where the memory leak being reported here is: https://travis-ci.org/bitcoin/bitcoin/jobs/560780816 ?
344 2019-07-19T17:59:03  <achow101> It seems like it's something happening in std::map but I don't know why it happens here
345 2019-07-19T18:00:01  *** Leo_Verto1 has quit IRC
346 2019-07-19T18:00:45  *** bitcoin-git has joined #bitcoin-core-dev
347 2019-07-19T18:00:46  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b1fe7165c8...51a6e2c41929
348 2019-07-19T18:00:46  <bitcoin-git> bitcoin/master 50cede3 Matt Corallo: [mempool] Allow one extra single-ancestor transaction per package
349 2019-07-19T18:00:47  <bitcoin-git> bitcoin/master 51a6e2c Wladimir J. van der Laan: Merge #15681: [mempool] Allow one extra single-ancestor transaction per pa...
350 2019-07-19T18:00:48  *** bitcoin-git has left #bitcoin-core-dev
351 2019-07-19T18:00:56  <BlueMatt> woooo
352 2019-07-19T18:01:25  *** bitcoin-git has joined #bitcoin-core-dev
353 2019-07-19T18:01:26  <bitcoin-git> [bitcoin] laanwj merged pull request #15681: [mempool] Allow one extra single-ancestor transaction per package (master...2019-03-lightning-policy) https://github.com/bitcoin/bitcoin/pull/15681
354 2019-07-19T18:01:27  *** bitcoin-git has left #bitcoin-core-dev
355 2019-07-19T18:02:10  <sipa> elichai2: what kind of hardware?
356 2019-07-19T18:02:28  <sipa> ah, just saw the later message
357 2019-07-19T18:02:58  <sipa> elichai2: 16 * 6 hours = 4 days
358 2019-07-19T18:03:03  <sipa> i don't think i'm far off
359 2019-07-19T18:03:51  <elichai2> Most laptops these days have at least 4 threads. And I'm not even entirely sure what was the bottleneck because nothing maxed out
360 2019-07-19T18:04:03  <elichai2> Probably the peers internet connection
361 2019-07-19T18:04:17  <sipa> with 4 threads it would be a day...
362 2019-07-19T18:04:22  *** izaki1 has joined #bitcoin-core-dev
363 2019-07-19T18:04:59  <sipa> 6 hours is already pretty terrible on itself
364 2019-07-19T18:05:24  <sipa> though admittedly there is little we can do about the time to download the chain (except assumeutxo like security model changes)
365 2019-07-19T18:06:34  <sipa> most laptop cpus will also downclock when many cores are used at once, so it may not be fair to assume more threads linearly oncreases speed
366 2019-07-19T18:12:28  *** luc__ has joined #bitcoin-core-dev
367 2019-07-19T18:13:35  *** luc__ has quit IRC
368 2019-07-19T18:17:33  <elichai2> one thing I saw is that there's no logic that chooses prefers peers by their bandwidth
369 2019-07-19T18:18:07  *** scoop has quit IRC
370 2019-07-19T18:18:11  <elichai2> so when I manually when to https://bitnodes.earn.com and looked for closer peers that share the same ISP and added then via `addnode` I got faster download
371 2019-07-19T18:19:35  <elichai2> and if everyone had good cpus we could try and use compression algorithms before sending the blocks around to move some of the weight from the internet to the cpu
372 2019-07-19T18:21:02  <sipa> elichai2: not explicitly, though there is the "stall detection" logic which tends to kick out the slowest peers from time to time in many cases
373 2019-07-19T18:23:02  <sipa> elichai2: yeah, we have someone working on transaction compression (though primarily aimed at satellite links, where a large amount of CPU to gain some bandwidth is much more acceptable than on the general P2P network), still some of the results are likely useful for a P2P compression mechanism too
374 2019-07-19T18:24:22  <elichai2> cool. I was actually impressed by the 6 hours. really thought it will take me at least a day with the `assumevalid=0`
375 2019-07-19T18:31:19  *** scoop has joined #bitcoin-core-dev
376 2019-07-19T18:32:32  *** scoop has quit IRC
377 2019-07-19T18:32:39  *** scoop has joined #bitcoin-core-dev
378 2019-07-19T18:33:45  *** Victor_sueca has quit IRC
379 2019-07-19T18:36:25  <wumpus> so no-one else has had issues with c-lightning and recent bitcoind yet?
380 2019-07-19T18:36:37  <wumpus> trying to bisect it
381 2019-07-19T18:38:14  *** Victorsueca has joined #bitcoin-core-dev
382 2019-07-19T18:46:37  *** scoop has quit IRC
383 2019-07-19T18:49:07  *** scoop has joined #bitcoin-core-dev
384 2019-07-19T18:49:35  *** harrigan has quit IRC
385 2019-07-19T18:52:10  *** hebasto has quit IRC
386 2019-07-19T18:52:26  *** etwert has quit IRC
387 2019-07-19T18:52:30  *** hebasto has joined #bitcoin-core-dev
388 2019-07-19T18:53:22  *** scoop has quit IRC
389 2019-07-19T18:55:33  *** etwert has joined #bitcoin-core-dev
390 2019-07-19T18:58:37  *** hebasto has quit IRC
391 2019-07-19T19:01:33  *** Zenton has joined #bitcoin-core-dev
392 2019-07-19T19:03:43  *** pinheadmz has quit IRC
393 2019-07-19T19:16:52  *** teardown has joined #bitcoin-core-dev
394 2019-07-19T19:29:19  *** scoop has joined #bitcoin-core-dev
395 2019-07-19T19:29:48  *** harrigan has joined #bitcoin-core-dev
396 2019-07-19T19:29:51  *** scoop has quit IRC
397 2019-07-19T19:29:57  *** scoop has joined #bitcoin-core-dev
398 2019-07-19T19:31:23  *** teardown has left #bitcoin-core-dev
399 2019-07-19T19:43:09  <dongcarl> wumpus: Thinking about implementation of addrv2... I'm thinking: rework CAddress to be more enum-y and less weird-IPv6-y, and do the weird-IPV6-y tricks in the serialization code only if `s.GetVersion() < GOSSIP_ADDRV2_VERSION`
400 2019-07-19T19:43:14  <dongcarl> lmk if that makes sense
401 2019-07-19T19:43:37  *** bitcoin-git has joined #bitcoin-core-dev
402 2019-07-19T19:43:37  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16424: build: Treat -Wswitch as error when --enable-werror (master...1907-buildSwitchError) https://github.com/bitcoin/bitcoin/pull/16424
403 2019-07-19T19:43:49  *** bitcoin-git has left #bitcoin-core-dev
404 2019-07-19T19:52:32  *** pinheadmz has joined #bitcoin-core-dev
405 2019-07-19T20:03:52  *** bitcoin-git has joined #bitcoin-core-dev
406 2019-07-19T20:03:52  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16425: addrman: Add sleep to while(1) loops (master...1907-addrmanNomNomCpu) https://github.com/bitcoin/bitcoin/pull/16425
407 2019-07-19T20:03:53  *** bitcoin-git has left #bitcoin-core-dev
408 2019-07-19T20:05:13  *** harrigan has quit IRC
409 2019-07-19T20:13:27  <wumpus> dongcarl: rust enums would be really nice here
410 2019-07-19T20:13:42  <dongcarl> wumpus: Haha yeah... But, alas...
411 2019-07-19T20:13:49  <wumpus> dongcarl: but I don't think you need to change the internal representation for this
412 2019-07-19T20:14:06  <wumpus> oh wait, you do, ofc
413 2019-07-19T20:14:19  * dongcarl almost got gaslighted
414 2019-07-19T20:14:26  <wumpus> sorry
415 2019-07-19T20:14:37  <sipa> boost::variant?
416 2019-07-19T20:14:39  * sipa ducks
417 2019-07-19T20:14:51  <BlueMatt> lets just use rust?
418 2019-07-19T20:15:13  <wumpus> tfw no std::variant
419 2019-07-19T20:15:32  <BlueMatt> dont we already have rust build support? time to start using it :p
420 2019-07-19T20:16:09  <BlueMatt> (only like 90% joke, fwiw)
421 2019-07-19T20:17:35  * dongcarl is going to do it the stupid way first
422 2019-07-19T20:18:40  <sipa> just a uint256 and an enum?
423 2019-07-19T20:19:08  <sipa> how will you deal with serialization in addrman.dat?
424 2019-07-19T20:19:20  <sipa> peers.dat, i guess
425 2019-07-19T20:21:05  <dongcarl> yes just a uint256 and an enum (do we have uint256's?)
426 2019-07-19T20:21:17  * sipa points to uint256.h
427 2019-07-19T20:21:51  <dongcarl> oh cool!
428 2019-07-19T20:22:32  <sipa> we use 256-bit values here and there in bitcoin :)
429 2019-07-19T20:22:41  <dongcarl> lol
430 2019-07-19T20:22:48  <dongcarl> I haven't looked at peers.dat serialization...
431 2019-07-19T20:23:01  <dongcarl> What are potential problems?
432 2019-07-19T20:24:02  <dongcarl> Oh... we need to maintain back-compat I guess?
433 2019-07-19T20:25:42  <sipa> yes
434 2019-07-19T20:26:01  <sipa> well, not backward compatibility
435 2019-07-19T20:26:07  <sipa> that'll be impossible anyway
436 2019-07-19T20:26:14  <sipa> but you do need forward compatibility
437 2019-07-19T20:26:26  <sipa> (new code will need to be able to read an old peers.dat)
438 2019-07-19T20:27:31  <dongcarl> Right, sorry that's what I meant... What's usually done in this case? One-off migration of peers.dat?
439 2019-07-19T20:27:52  <sipa> up to you
440 2019-07-19T20:28:16  <dongcarl> Cool. Thanks for tips!
441 2019-07-19T20:28:20  <sipa> if there is a way to serialize a CADdress (haven't checked if there is) that would be compatible, that would be great
442 2019-07-19T20:29:06  <dongcarl> sipa: You mean serialize an addrv2 in a way that's back-compatible with addv1?
443 2019-07-19T20:29:18  <sipa> yes
444 2019-07-19T20:29:21  <sipa> oh, there is
445 2019-07-19T20:29:39  <sipa> SER_DISK mode for CAddress stores a version number
446 2019-07-19T20:29:58  *** bitcoin-git has joined #bitcoin-core-dev
447 2019-07-19T20:29:58  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16425: addrman: Add sleep to while(1) loops (master...1907-addrmanNomNomCpu) https://github.com/bitcoin/bitcoin/pull/16425
448 2019-07-19T20:30:01  *** bitcoin-git has left #bitcoin-core-dev
449 2019-07-19T20:30:06  <sipa> you can leverage that to just use old serializtion for things compatible with it
450 2019-07-19T20:30:12  <sipa> and new serialization otherwise
451 2019-07-19T20:30:31  <sipa> (which you can define i guess identical to how the addrv2 bip encodes addressrs)
452 2019-07-19T20:31:42  <sipa> that would be automatically forward compatible
453 2019-07-19T20:31:54  <sipa> and backward compatible as long as no new style addresses are stored
454 2019-07-19T20:34:32  <dongcarl> sipa: Ah... So if I understand you correctly, this way disk serialization of ipv4, v6, and torv2 will be in the older format... Which means if I generate a peers.dat in a newer client and feed it to an older one, the older client will pick up everything except torv3, i2p, and CJDNS?
455 2019-07-19T20:35:04  <sipa> it will just fail to deserialize entirely if it contains torv3/i2p/cjdns
456 2019-07-19T20:35:13  <sipa> as it has no idea about the length of the field it's trying to read
457 2019-07-19T20:35:29  <sipa> so i think there are two ways:
458 2019-07-19T20:35:47  * dongcarl listening
459 2019-07-19T20:36:07  *** emilengler has joined #bitcoin-core-dev
460 2019-07-19T20:36:47  <sipa> 1) have a global peers.dat-wide field (it has an nVersion for this) that says "this file uses new encoding", and then all addresses in it use new encoding; you'd have read support for the old format, but always write in the new format
461 2019-07-19T20:38:46  <sipa> 2) you use the per-address nVersion field to distinguish between old and new (right now the nVersion field there is just the client version number which is a terrible practice anyway; define some cutoff equivalent to say 0.99.0 which means "new format" and stick to 0.18.x for old format), but use old encoding when writing tor/ipv4/ipv6
462 2019-07-19T20:39:05  <sipa> the first idea is perhaps simpler and much more compact
463 2019-07-19T20:39:19  <sipa> as ipv4 is hugely wasteful in the old serialization
464 2019-07-19T20:39:41  <dongcarl> Yeah that makes sense
465 2019-07-19T20:39:49  <dongcarl> I'm gunna aim for #1 first
466 2019-07-19T20:39:51  <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
467 2019-07-19T20:40:05  *** Guyver2 has quit IRC
468 2019-07-19T20:40:26  <dongcarl> sipa: Thanks for helping think this thru!
469 2019-07-19T20:40:59  *** instagibbs_ has joined #bitcoin-core-dev
470 2019-07-19T20:42:07  <sipa> to switch between old and new encoding, i suggest not actually using nVersion directly (it's messy...), but instead ORing some field flag into like, like SERIALIZE_TRANSACTION_NO_WITNESS for transactions
471 2019-07-19T20:42:53  <sipa> then you can also use OverrideStream in the P2P code to select between old and new encoding based on what the peer supports
472 2019-07-19T20:45:39  <dongcarl> sipa: Hmmm I think the spec wants me to use nVersion? https://github.com/bitcoin/bips/blob/f5174192e2d5fb3dfa7232be62d1b9d586a7f8d6/bip-0155.mediawiki#compatibility
473 2019-07-19T20:46:07  <sipa> dongcarl: i mean, don't use the p2p protocol nVersion directly to select between features
474 2019-07-19T20:46:33  <sipa> that feels like an enormous layer violation, and makes things messy in addrman (where nVersion is the _client_ version, while on the wire it's the protocol version...)
475 2019-07-19T20:47:26  <sipa> even if at connection time nVersion is used to signal readiness for the new protocol, set a flag in CNode or so to remember what addr protocol is used, and then explicitly choose a flag to set when serializing addr messages based on that
476 2019-07-19T20:48:05  * dongcarl reading and trying to understand
477 2019-07-19T20:48:37  <sipa> dongcarl: basically my opinion is that it's a mistake that there is a single "stream version" number that influences serialization
478 2019-07-19T20:49:02  <dongcarl> sipa: You mean like our existing logic for CADDR_TIME_VERSION?
479 2019-07-19T20:49:05  <dongcarl> That's the mistake?
480 2019-07-19T20:49:06  <sipa> yes
481 2019-07-19T20:49:28  <sipa> well, that's historical, and dates from a time when client versions and protocol versions were the same thing
482 2019-07-19T20:49:49  <sipa> but right now those two are distinct things, and it's not the CAddress that should know exactly which protocols require which serializations
483 2019-07-19T20:50:10  <sipa> it should be the protocol implementations that decide that, and just tell CAddress whether to use v1 or v2 (which is something CAddress should know about)
484 2019-07-19T20:51:22  <dongcarl> Okay, I think I understand that. What's a good way of passing the v1 vs v2 info to CAddress so it knows how to serialize?
485 2019-07-19T20:52:01  <sipa> by essentially using the high bits of nVersion as a bit field, and using one bit in it to indicate which encoding to use
486 2019-07-19T20:52:24  <sipa> like SERIALIZE_TRANSACTION_NO_WITNESS (which is equal to 0x40000000)
487 2019-07-19T20:53:17  <dongcarl> Oh I see... Seems hacky but there's no way we're serializing a transaction while we're also serializing an address so that's okay, right?
488 2019-07-19T20:53:33  <sipa> right, they don't need to live in the same namespace
489 2019-07-19T20:53:35  <sipa> for segwit, based on whether segwit support was negotiated with the peer (and/or whether the witness flag in a CInv request is set), a wrapper makes the stream temporarily report that flag in its nVersion
490 2019-07-19T20:54:10  <dongcarl> Okay that makes sense!
491 2019-07-19T20:54:42  <dongcarl> sipa: Glad you pointed this out because I was about to copy the CADDR_TIME_VERSION logic
492 2019-07-19T20:55:06  <sipa> for example, see the line in net_processing:
493 2019-07-19T20:55:07  <sipa> connman->PushMessage(pfrom, msgMaker.Make(SERIALIZE_TRANSACTION_NO_WITNESS, NetMsgType::BLOCK, *pblock));
494 2019-07-19T20:55:34  <sipa> or
495 2019-07-19T20:55:39  <sipa> int nSendFlags = (inv.type == MSG_TX ? SERIALIZE_TRANSACTION_NO_WITNESS : 0);
496 2019-07-19T20:55:43  <sipa> connman->PushMessage(pfrom, msgMaker.Make(nSendFlags, NetMsgType::TX, *mi->second));
497 2019-07-19T20:57:11  <dongcarl> Ah! Very good examples... I should probably define a SERIALIZE_ADDR_AS_V2 or something
498 2019-07-19T20:57:16  <sipa> right
499 2019-07-19T20:58:01  <sipa> in the v2 stuff you can probably drop the nVersion/SER_DISK/... logic too
500 2019-07-19T20:58:21  <sipa> no need to encode a per-addr version number if that version is being communicated externally
501 2019-07-19T20:58:44  <dongcarl> sipa: True!
502 2019-07-19T20:58:59  * dongcarl is glad he understood
503 2019-07-19T20:59:32  <sipa> much of this is my personal opinion btw, i don't want to give a false impression that this approach is some commonly agreed upon way of doing things
504 2019-07-19T21:00:01  *** izaki1 has quit IRC
505 2019-07-19T21:00:53  <dongcarl> sipa: It's certainly given me a solid direction for implementation... Much better than me designing in the dark, and I'm happy to iterate once I have an MVP working. :-)
506 2019-07-19T21:04:37  *** greylica has joined #bitcoin-core-dev
507 2019-07-19T21:05:24  <sipa> great
508 2019-07-19T21:10:14  *** scoop has quit IRC
509 2019-07-19T21:23:29  *** instagibbs_ has quit IRC
510 2019-07-19T21:33:19  *** scoop has joined #bitcoin-core-dev
511 2019-07-19T21:41:34  *** reallll is now known as belcher
512 2019-07-19T21:43:54  *** scoop has quit IRC
513 2019-07-19T21:46:50  *** _major has joined #bitcoin-core-dev
514 2019-07-19T21:47:24  *** pinheadmz has quit IRC
515 2019-07-19T21:52:06  *** laftho has joined #bitcoin-core-dev
516 2019-07-19T22:02:28  *** michaelsdunn1 has quit IRC
517 2019-07-19T22:16:24  *** scoop has joined #bitcoin-core-dev
518 2019-07-19T22:27:14  *** scoop has quit IRC
519 2019-07-19T22:30:35  *** laftho has quit IRC
520 2019-07-19T22:41:19  *** _atos has joined #bitcoin-core-dev
521 2019-07-19T22:55:08  *** AaronvanW has quit IRC
522 2019-07-19T22:57:51  *** bitcoin-git has joined #bitcoin-core-dev
523 2019-07-19T22:57:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16409: Remove mempool expiry, treat txs as replaceable instead (master...1907-noExpiryButReplace) https://github.com/bitcoin/bitcoin/pull/16409
524 2019-07-19T22:57:52  *** bitcoin-git has left #bitcoin-core-dev
525 2019-07-19T23:12:57  *** jarthur has quit IRC
526 2019-07-19T23:13:34  *** EagleTM has quit IRC
527 2019-07-19T23:21:29  *** EagleTM has joined #bitcoin-core-dev
528 2019-07-19T23:30:33  *** pinheadmz has joined #bitcoin-core-dev
529 2019-07-19T23:55:16  *** scoop has joined #bitcoin-core-dev