1 2019-07-29T00:00:02  *** EricYuzo has quit IRC
  2 2019-07-29T00:11:01  *** rh0nj has quit IRC
  3 2019-07-29T00:12:07  *** rh0nj has joined #bitcoin-core-dev
  4 2019-07-29T00:19:32  *** Lauwenmark has joined #bitcoin-core-dev
  5 2019-07-29T00:32:39  *** luke-jr has joined #bitcoin-core-dev
  6 2019-07-29T01:00:25  *** JamesAU has joined #bitcoin-core-dev
  7 2019-07-29T01:01:59  *** JamesAU_ has joined #bitcoin-core-dev
  8 2019-07-29T01:05:39  *** JamesAU has quit IRC
  9 2019-07-29T01:07:50  *** emilengler has quit IRC
 10 2019-07-29T01:16:43  *** Xunie__ has joined #bitcoin-core-dev
 11 2019-07-29T01:20:34  *** Xunie_ has quit IRC
 12 2019-07-29T01:44:10  *** teardown has quit IRC
 13 2019-07-29T01:44:30  *** bitcoin-git has joined #bitcoin-core-dev
 14 2019-07-29T01:44:30  <bitcoin-git> [bitcoin] fanquake closed pull request #15052: Tests: Contract testing for the procedure AddTimeData and related fixes (master...timedata_contract_test2) https://github.com/bitcoin/bitcoin/pull/15052
 15 2019-07-29T01:44:31  *** bitcoin-git has left #bitcoin-core-dev
 16 2019-07-29T01:45:40  *** bitcoin-git has joined #bitcoin-core-dev
 17 2019-07-29T01:45:40  <bitcoin-git> [bitcoin] fanquake closed pull request #15104: Tests: Add unit testing for the CompressScript function (master...compress_contract_test3) https://github.com/bitcoin/bitcoin/pull/15104
 18 2019-07-29T01:45:41  *** bitcoin-git has left #bitcoin-core-dev
 19 2019-07-29T01:47:20  *** bitcoin-git has joined #bitcoin-core-dev
 20 2019-07-29T01:47:20  <bitcoin-git> [bitcoin] fanquake closed pull request #13357: Define SIGHASH_MASK in validation and determine the use of SIGHASH_SINGLE in signing (master...signsingle) https://github.com/bitcoin/bitcoin/pull/13357
 21 2019-07-29T01:47:23  *** bitcoin-git has left #bitcoin-core-dev
 22 2019-07-29T02:03:23  *** profmac has quit IRC
 23 2019-07-29T02:11:59  *** DeanGuss has joined #bitcoin-core-dev
 24 2019-07-29T02:13:19  *** rex4539 has quit IRC
 25 2019-07-29T02:16:37  *** profmac has joined #bitcoin-core-dev
 26 2019-07-29T02:31:25  *** andytoshi has joined #bitcoin-core-dev
 27 2019-07-29T02:33:13  *** darosior has quit IRC
 28 2019-07-29T02:55:41  *** dviola has quit IRC
 29 2019-07-29T03:00:02  *** Lauwenmark has quit IRC
 30 2019-07-29T03:04:10  *** Lauwenmark has joined #bitcoin-core-dev
 31 2019-07-29T03:12:11  *** davex_ has joined #bitcoin-core-dev
 32 2019-07-29T03:14:37  *** davex__ has quit IRC
 33 2019-07-29T03:22:38  *** liberiga has joined #bitcoin-core-dev
 34 2019-07-29T03:45:17  *** Eagle[TM] has joined #bitcoin-core-dev
 35 2019-07-29T03:47:36  *** pinheadmz has joined #bitcoin-core-dev
 36 2019-07-29T03:48:04  *** EagleTM has quit IRC
 37 2019-07-29T03:50:16  *** liberiga has quit IRC
 38 2019-07-29T03:53:33  *** schnerchi has joined #bitcoin-core-dev
 39 2019-07-29T03:56:37  *** schnerch_ has quit IRC
 40 2019-07-29T03:58:34  *** kcalvinalvin has joined #bitcoin-core-dev
 41 2019-07-29T04:05:57  *** Klox has quit IRC
 42 2019-07-29T04:07:24  *** sipa has quit IRC
 43 2019-07-29T04:12:40  *** sipa has joined #bitcoin-core-dev
 44 2019-07-29T04:13:23  *** dviola has joined #bitcoin-core-dev
 45 2019-07-29T04:44:50  <phantomcircuit> sipa, i added logging of the leveldb wrapper stuff and noticed that there's requests for seemingly everything until block height=227931 where the cache seems to absorb all the requests, does that make any sense or have i just missed something really obvious
 46 2019-07-29T04:49:29  <sipa> phantomcircuit: elaborate?
 47 2019-07-29T04:52:30  <phantomcircuit> sipa, i added some LogPrint statements in dbwrapper.h after pdb->Get in Read and Exists
 48 2019-07-29T04:53:05  <phantomcircuit> i wanted to do a graph of "io" relative to dbcache size during IBD
 49 2019-07-29T04:53:21  <phantomcircuit> but instead what im seeing in logs seems crazy
 50 2019-07-29T04:55:36  *** AaronvanW has quit IRC
 51 2019-07-29T05:00:05  <phantomcircuit> sipa, i changed the logging hang on i'll upload the debug.log...
 52 2019-07-29T05:00:07  <phantomcircuit> https://github.com/pstratem/bitcoin/commits/2019-07-28-leveldb-detail
 53 2019-07-29T05:07:39  <phantomcircuit> sipa, https://2083236893.com/debug.log
 54 2019-07-29T05:15:03  <phantomcircuit> sipa, i think that's the block where bip34 was activated
 55 2019-07-29T05:16:50  *** dviola has quit IRC
 56 2019-07-29T05:21:07  <harding> phantomcircuit: BIP90 agrees that 227931 was the BIP34 activationheight.
 57 2019-07-29T05:21:45  <sipa> phantomcircuit: will look tomorrow
 58 2019-07-29T05:23:08  <sipa> threre is some interaction between bip34 and the utxo logic
 59 2019-07-29T05:24:15  <phantomcircuit> oh i see bip30
 60 2019-07-29T05:26:29  <phantomcircuit> sipa, nvm i understand how, the bip30 logic guarantees at least one utxo db access for each transaction in the block until the bip34 activation block
 61 2019-07-29T05:26:51  <phantomcircuit> and since it's never going to be in the cache the read always goes to disk
 62 2019-07-29T05:27:15  <phantomcircuit> there's probably potential to optimize that when assumevalid is set
 63 2019-07-29T05:28:00  <phantomcircuit> it's 34 million leveldb Get calls
 64 2019-07-29T05:28:49  *** AaronvanW has joined #bitcoin-core-dev
 65 2019-07-29T05:34:00  *** AaronvanW has quit IRC
 66 2019-07-29T06:00:02  *** Lauwenmark has quit IRC
 67 2019-07-29T06:01:28  *** DeanGuss has quit IRC
 68 2019-07-29T06:01:45  *** DeanGuss has joined #bitcoin-core-dev
 69 2019-07-29T06:05:17  *** AaronvanW has joined #bitcoin-core-dev
 70 2019-07-29T06:13:22  *** DeanGuss has quit IRC
 71 2019-07-29T06:13:37  *** DeanGuss has joined #bitcoin-core-dev
 72 2019-07-29T06:14:38  *** rex4539 has joined #bitcoin-core-dev
 73 2019-07-29T06:15:00  *** davec has quit IRC
 74 2019-07-29T06:15:24  *** hebasto has joined #bitcoin-core-dev
 75 2019-07-29T06:17:21  *** DeanGuss has quit IRC
 76 2019-07-29T06:17:48  *** DeanGuss has joined #bitcoin-core-dev
 77 2019-07-29T06:22:18  *** davec has joined #bitcoin-core-dev
 78 2019-07-29T06:38:29  *** Pysis|work has joined #bitcoin-core-dev
 79 2019-07-29T06:38:39  *** AaronvanW has quit IRC
 80 2019-07-29T06:50:02  *** kcalvinalvin has quit IRC
 81 2019-07-29T06:55:26  *** rex4539 has quit IRC
 82 2019-07-29T07:18:43  *** hebasto has quit IRC
 83 2019-07-29T07:22:05  *** Guyver2 has joined #bitcoin-core-dev
 84 2019-07-29T07:37:58  *** Eagle[TM] has quit IRC
 85 2019-07-29T07:42:00  *** Keshawn1Walker has joined #bitcoin-core-dev
 86 2019-07-29T07:42:54  *** rex4539 has joined #bitcoin-core-dev
 87 2019-07-29T07:46:12  *** AaronvanW has joined #bitcoin-core-dev
 88 2019-07-29T07:55:15  *** Keshawn1Walker has quit IRC
 89 2019-07-29T08:04:16  *** zrc has joined #bitcoin-core-dev
 90 2019-07-29T08:05:05  *** JamesAU has joined #bitcoin-core-dev
 91 2019-07-29T08:07:45  *** JamesAU__ has joined #bitcoin-core-dev
 92 2019-07-29T08:08:35  *** JamesAU_ has quit IRC
 93 2019-07-29T08:10:16  *** JamesAU has quit IRC
 94 2019-07-29T08:20:33  *** bitcoin-git has joined #bitcoin-core-dev
 95 2019-07-29T08:20:33  <bitcoin-git> [bitcoin] sipsorcery opened pull request #16483: Updated python command in msvc readme (master...update_msvc_readme) https://github.com/bitcoin/bitcoin/pull/16483
 96 2019-07-29T08:20:34  *** bitcoin-git has left #bitcoin-core-dev
 97 2019-07-29T08:24:23  *** bitcoin-git has joined #bitcoin-core-dev
 98 2019-07-29T08:24:23  <bitcoin-git> [bitcoin] fanquake closed pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
 99 2019-07-29T08:24:25  *** bitcoin-git has left #bitcoin-core-dev
100 2019-07-29T08:28:06  *** kljasdfvv has joined #bitcoin-core-dev
101 2019-07-29T08:30:29  *** hebasto has joined #bitcoin-core-dev
102 2019-07-29T08:36:09  *** DeanGuss has quit IRC
103 2019-07-29T08:36:40  *** DeanGuss has joined #bitcoin-core-dev
104 2019-07-29T08:37:55  *** queip has quit IRC
105 2019-07-29T08:39:16  <jonasschnelli> hebasto: https://github.com/bitcoin/bitcoin/pull/16476,... 5 labels? :-)
106 2019-07-29T08:39:40  <jonasschnelli> Draht added them... I see
107 2019-07-29T08:40:39  <fanquake> jonasschnelli: sometimes the bot gets a bit out of control hah
108 2019-07-29T08:43:48  *** queip has joined #bitcoin-core-dev
109 2019-07-29T08:45:26  *** AaronvanW has quit IRC
110 2019-07-29T08:45:42  *** AaronvanW has joined #bitcoin-core-dev
111 2019-07-29T08:51:26  *** AaronvanW has quit IRC
112 2019-07-29T08:55:29  *** JamesAU has joined #bitcoin-core-dev
113 2019-07-29T08:58:34  *** JamesAU_ has joined #bitcoin-core-dev
114 2019-07-29T08:59:11  *** JamesAU__ has quit IRC
115 2019-07-29T09:00:01  *** Pysis|work has quit IRC
116 2019-07-29T09:02:26  *** JamesAU has quit IRC
117 2019-07-29T09:11:31  <jonasschnelli> sipa: the PR #16202 is a result of your NACK/comment in 14046. Appreciate your review. Thanks
118 2019-07-29T09:11:34  <gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
119 2019-07-29T09:13:10  *** mengu has joined #bitcoin-core-dev
120 2019-07-29T09:13:33  *** mengu is now known as Guest2233
121 2019-07-29T09:15:27  *** JamesAU has joined #bitcoin-core-dev
122 2019-07-29T09:18:17  *** timothy has joined #bitcoin-core-dev
123 2019-07-29T09:19:00  *** JamesAU_ has quit IRC
124 2019-07-29T09:22:04  *** TheFuzzStone[m] has quit IRC
125 2019-07-29T09:22:05  *** DavidMitchell[m] has quit IRC
126 2019-07-29T09:22:07  *** tuirektiujm[m] has quit IRC
127 2019-07-29T09:22:14  *** electric-sheep[m has quit IRC
128 2019-07-29T09:22:17  *** kewde[m] has quit IRC
129 2019-07-29T09:25:53  *** DeanGuss has quit IRC
130 2019-07-29T09:26:52  *** DeanGuss has joined #bitcoin-core-dev
131 2019-07-29T09:29:05  *** TheFuzzStone[m] has joined #bitcoin-core-dev
132 2019-07-29T09:36:15  *** kewde[m] has joined #bitcoin-core-dev
133 2019-07-29T09:36:15  *** tuirektiujm[m] has joined #bitcoin-core-dev
134 2019-07-29T09:36:22  *** electric-sheep[m has joined #bitcoin-core-dev
135 2019-07-29T09:36:23  *** DavidMitchell[m] has joined #bitcoin-core-dev
136 2019-07-29T09:38:06  *** JamesAU has quit IRC
137 2019-07-29T09:44:13  *** queip has quit IRC
138 2019-07-29T09:51:01  *** queip has joined #bitcoin-core-dev
139 2019-07-29T10:03:29  *** setpill has joined #bitcoin-core-dev
140 2019-07-29T10:09:01  *** JamesAU has joined #bitcoin-core-dev
141 2019-07-29T10:39:45  *** jonatack has quit IRC
142 2019-07-29T10:46:04  *** JamesAU has quit IRC
143 2019-07-29T10:55:14  *** shtirlic has quit IRC
144 2019-07-29T10:56:15  *** shtirlic has joined #bitcoin-core-dev
145 2019-07-29T11:03:43  *** dgfhdfg has joined #bitcoin-core-dev
146 2019-07-29T11:13:20  *** DeanGuss has quit IRC
147 2019-07-29T11:13:46  *** DeanGuss has joined #bitcoin-core-dev
148 2019-07-29T11:17:57  *** emilengler has joined #bitcoin-core-dev
149 2019-07-29T11:19:19  *** DeanGuss has quit IRC
150 2019-07-29T11:59:36  *** rex4539 has quit IRC
151 2019-07-29T12:00:02  *** Guest2233 has quit IRC
152 2019-07-29T12:04:48  *** j3parker1 has joined #bitcoin-core-dev
153 2019-07-29T12:16:48  *** bitcoin-git has joined #bitcoin-core-dev
154 2019-07-29T12:16:48  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
155 2019-07-29T12:16:56  *** bitcoin-git has left #bitcoin-core-dev
156 2019-07-29T12:17:07  *** _Sam-- has joined #bitcoin-core-dev
157 2019-07-29T12:18:13  *** bitcoin-git has joined #bitcoin-core-dev
158 2019-07-29T12:18:13  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
159 2019-07-29T12:18:14  *** bitcoin-git has left #bitcoin-core-dev
160 2019-07-29T12:22:28  *** bitcoin-git has joined #bitcoin-core-dev
161 2019-07-29T12:22:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c2885f9b2e3...502ec0227290
162 2019-07-29T12:22:29  <bitcoin-git> bitcoin/master fabfcb5 MarcoFalke: build: Treat -Wswitch as error when --enable-werror
163 2019-07-29T12:22:29  <bitcoin-git> bitcoin/master 502ec02 MarcoFalke: Merge #16424: build: Treat -Wswitch as error when --enable-werror
164 2019-07-29T12:22:31  *** bitcoin-git has left #bitcoin-core-dev
165 2019-07-29T12:23:28  *** bitcoin-git has joined #bitcoin-core-dev
166 2019-07-29T12:23:28  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16424: build: Treat -Wswitch as error when --enable-werror (master...1907-buildSwitchError) https://github.com/bitcoin/bitcoin/pull/16424
167 2019-07-29T12:23:30  *** bitcoin-git has left #bitcoin-core-dev
168 2019-07-29T12:27:59  *** setpill has quit IRC
169 2019-07-29T12:28:30  *** setpill has joined #bitcoin-core-dev
170 2019-07-29T12:28:45  *** goatpig has quit IRC
171 2019-07-29T12:33:30  *** bitcoin-git has joined #bitcoin-core-dev
172 2019-07-29T12:33:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16484: doc: Remove "trivial" label in CONTRIBUTING (master...1907-docNoTrivial) https://github.com/bitcoin/bitcoin/pull/16484
173 2019-07-29T12:33:31  *** bitcoin-git has left #bitcoin-core-dev
174 2019-07-29T12:44:28  *** esotericnonsense has quit IRC
175 2019-07-29T12:47:23  *** AaronvanW has joined #bitcoin-core-dev
176 2019-07-29T12:52:33  *** bitcoin-git has joined #bitcoin-core-dev
177 2019-07-29T12:52:34  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/502ec0227290...f735851be294
178 2019-07-29T12:52:34  <bitcoin-git> bitcoin/master 07e01d6 Jon Atack: rpc: sendrawtransaction unconditionality/privacy note
179 2019-07-29T12:52:35  <bitcoin-git> bitcoin/master f735851 Wladimir J. van der Laan: Merge #16467: rpc: sendrawtransaction help privacy note
180 2019-07-29T12:52:37  *** bitcoin-git has left #bitcoin-core-dev
181 2019-07-29T12:53:33  *** bitcoin-git has joined #bitcoin-core-dev
182 2019-07-29T12:53:33  <bitcoin-git> [bitcoin] laanwj merged pull request #16467: rpc: sendrawtransaction help privacy note (master...sendrawtransaction-privacy-note) https://github.com/bitcoin/bitcoin/pull/16467
183 2019-07-29T12:53:34  *** bitcoin-git has left #bitcoin-core-dev
184 2019-07-29T13:11:09  *** queip has quit IRC
185 2019-07-29T13:17:25  *** queip has joined #bitcoin-core-dev
186 2019-07-29T13:21:24  *** JamesAU has joined #bitcoin-core-dev
187 2019-07-29T13:23:10  *** Kvaciral has quit IRC
188 2019-07-29T13:26:31  *** promag has quit IRC
189 2019-07-29T13:28:13  *** promag has joined #bitcoin-core-dev
190 2019-07-29T13:33:44  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-07-29T13:33:44  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f735851be294...29220250c10e
192 2019-07-29T13:33:45  <bitcoin-git> bitcoin/master 98a64bd fanquake: build: disable libjpeg in qt
193 2019-07-29T13:33:45  <bitcoin-git> bitcoin/master 0aeb98a fanquake: build: remove jpeg lib check from bitcoin_qt.m4
194 2019-07-29T13:33:46  <bitcoin-git> bitcoin/master 1bb1661 fanquake: doc: fix typo in bitcoin_qt.m4 comment
195 2019-07-29T13:33:47  *** bitcoin-git has left #bitcoin-core-dev
196 2019-07-29T13:34:45  *** bitcoin-git has joined #bitcoin-core-dev
197 2019-07-29T13:34:45  <bitcoin-git> [bitcoin] laanwj merged pull request #16441: build: remove qt libjpeg check from bitcoin_qt.m4 (master...remove-qt-libjpeg-check) https://github.com/bitcoin/bitcoin/pull/16441
198 2019-07-29T13:34:46  *** bitcoin-git has left #bitcoin-core-dev
199 2019-07-29T13:38:00  *** bitcoin-git has joined #bitcoin-core-dev
200 2019-07-29T13:38:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/29220250c10e...74ea1f3b0f26
201 2019-07-29T13:38:01  <bitcoin-git> bitcoin/master 3199610 Fabian Jahr: Place out args at the end for CreateWallet
202 2019-07-29T13:38:01  <bitcoin-git> bitcoin/master d6649d1 Fabian Jahr: Use strong enum for WalletCreationStatus
203 2019-07-29T13:38:01  <bitcoin-git> bitcoin/master ba1f128 Fabian Jahr: Return error for ignored passphrase through disable private keys option
204 2019-07-29T13:38:13  *** bitcoin-git has left #bitcoin-core-dev
205 2019-07-29T13:39:00  *** bitcoin-git has joined #bitcoin-core-dev
206 2019-07-29T13:39:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16399: wallet: Improve wallet creation (master...followup-16244) https://github.com/bitcoin/bitcoin/pull/16399
207 2019-07-29T13:39:01  *** bitcoin-git has left #bitcoin-core-dev
208 2019-07-29T13:42:42  *** elichai2 has joined #bitcoin-core-dev
209 2019-07-29T13:44:16  *** queip has quit IRC
210 2019-07-29T13:50:19  *** queip has joined #bitcoin-core-dev
211 2019-07-29T13:50:30  *** d_t has joined #bitcoin-core-dev
212 2019-07-29T14:20:10  *** laptop500 has joined #bitcoin-core-dev
213 2019-07-29T14:33:50  *** nijak_ has joined #bitcoin-core-dev
214 2019-07-29T14:35:01  *** nijak has quit IRC
215 2019-07-29T14:41:51  *** mdunnio has joined #bitcoin-core-dev
216 2019-07-29T14:50:54  *** d_t has quit IRC
217 2019-07-29T14:52:18  *** bitcoin-git has joined #bitcoin-core-dev
218 2019-07-29T14:52:19  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/74ea1f3b0f26...b21acab82fe9
219 2019-07-29T14:52:19  <bitcoin-git> bitcoin/master 9f76e45 Hennadii Stepanov: Drop support of insecure miniUPnPc versions
220 2019-07-29T14:52:20  <bitcoin-git> bitcoin/master 91a1b85 Hennadii Stepanov: Use PACKAGE_NAME in UPnP description
221 2019-07-29T14:52:21  <bitcoin-git> bitcoin/master 02709e9 Hennadii Stepanov: Align formatting with clang-format
222 2019-07-29T14:52:22  *** bitcoin-git has left #bitcoin-core-dev
223 2019-07-29T14:53:02  *** bitcoin-git has joined #bitcoin-core-dev
224 2019-07-29T14:53:03  <bitcoin-git> [bitcoin] laanwj merged pull request #15993: net: Drop support of the insecure miniUPnPc versions (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993
225 2019-07-29T14:53:13  *** bitcoin-git has left #bitcoin-core-dev
226 2019-07-29T14:54:04  <sdaftuar> hi all, if anyone is interested in reviewing or even just testing #15759 i'd appreciate it, as i think it'd be best if p2p changes like this simmer in master with plenty of time before a new release in case of bugs or unintended side effects
227 2019-07-29T14:54:08  <gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
228 2019-07-29T14:54:33  *** mdunnio has quit IRC
229 2019-07-29T14:55:12  *** mdunnio has joined #bitcoin-core-dev
230 2019-07-29T14:58:11  *** profmac has quit IRC
231 2019-07-29T14:58:39  *** kristapsk_ has joined #bitcoin-core-dev
232 2019-07-29T14:59:58  *** mdunnio has quit IRC
233 2019-07-29T15:00:02  *** j3parker1 has quit IRC
234 2019-07-29T15:01:20  *** kristapsk has quit IRC
235 2019-07-29T15:02:02  *** mdunnio has joined #bitcoin-core-dev
236 2019-07-29T15:19:24  *** bitcoin-git has joined #bitcoin-core-dev
237 2019-07-29T15:19:25  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b21acab82fe9...2a7c3bc498b5
238 2019-07-29T15:19:25  <bitcoin-git> bitcoin/master 4057b7a Hennadii Stepanov: wallet: Recognize -disablewallet option early
239 2019-07-29T15:19:25  <bitcoin-git> bitcoin/master 2a7c3bc Wladimir J. van der Laan: Merge #16436: gui: Do not create payment server if -disablewallet option p...
240 2019-07-29T15:19:37  *** bitcoin-git has left #bitcoin-core-dev
241 2019-07-29T15:19:42  <wumpus> sdaftuar: agreed
242 2019-07-29T15:19:57  *** |Kin| has joined #bitcoin-core-dev
243 2019-07-29T15:20:24  *** bitcoin-git has joined #bitcoin-core-dev
244 2019-07-29T15:20:24  <bitcoin-git> [bitcoin] laanwj merged pull request #16436: gui: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
245 2019-07-29T15:20:37  *** bitcoin-git has left #bitcoin-core-dev
246 2019-07-29T15:24:16  *** profmac has joined #bitcoin-core-dev
247 2019-07-29T15:31:19  <sdaftuar> sipa: wumpus: any thoughts on the issue described in #16444? seems like an annoying problem to fix
248 2019-07-29T15:31:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16444 | Assertion `setBlockIndexCandidates.count(pindex) failed · Issue #16444 · bitcoin/bitcoin · GitHub
249 2019-07-29T15:32:54  <sdaftuar> i think if we want to maintain the invariants we've historically had and not change CheckBlockIndex() at all, then we could add some more code to InvalidateBlock() so that everything works as it used to.
250 2019-07-29T15:32:55  *** kljasdfvv has quit IRC
251 2019-07-29T15:33:31  <sdaftuar> it just seems a bit tedious and it's not totally clear to me that it's important to maintain our usual invariants in this one specific case
252 2019-07-29T15:39:29  *** anemous has joined #bitcoin-core-dev
253 2019-07-29T15:55:25  *** anemous has quit IRC
254 2019-07-29T16:00:18  *** mdunnio has quit IRC
255 2019-07-29T16:05:21  *** mdunnio has joined #bitcoin-core-dev
256 2019-07-29T16:11:38  *** dgfhdfg has quit IRC
257 2019-07-29T16:20:22  *** lightlike has joined #bitcoin-core-dev
258 2019-07-29T16:29:00  *** dgfhdfg has joined #bitcoin-core-dev
259 2019-07-29T16:34:04  *** sfhi has joined #bitcoin-core-dev
260 2019-07-29T16:37:00  *** mdunnio has quit IRC
261 2019-07-29T16:39:09  *** roconnor has joined #bitcoin-core-dev
262 2019-07-29T16:48:37  *** setpill has quit IRC
263 2019-07-29T16:52:32  *** mdunnio has joined #bitcoin-core-dev
264 2019-07-29T16:55:50  *** bitcoin-git has joined #bitcoin-core-dev
265 2019-07-29T16:55:50  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a7c3bc498b5...68da54987df4
266 2019-07-29T16:55:51  <bitcoin-git> bitcoin/master 42a5e91 John Newbery: [mempool] log correct messages when CPFP fails
267 2019-07-29T16:55:51  <bitcoin-git> bitcoin/master 68da549 Wladimir J. van der Laan: Merge #16471: [mempool] log correct messages when CPFP fails
268 2019-07-29T16:55:55  *** bitcoin-git has left #bitcoin-core-dev
269 2019-07-29T16:56:50  *** bitcoin-git has joined #bitcoin-core-dev
270 2019-07-29T16:56:50  <bitcoin-git> [bitcoin] laanwj merged pull request #16471: [mempool] log correct messages when CPFP fails (master...2019-07-fix-CalculateMempoolAncestors-logging) https://github.com/bitcoin/bitcoin/pull/16471
271 2019-07-29T16:56:52  *** bitcoin-git has left #bitcoin-core-dev
272 2019-07-29T16:57:28  *** mdunnio has quit IRC
273 2019-07-29T16:59:40  *** roconnor has quit IRC
274 2019-07-29T17:00:55  *** roconnor has joined #bitcoin-core-dev
275 2019-07-29T17:08:43  *** mdunnio has joined #bitcoin-core-dev
276 2019-07-29T17:13:03  *** sfhi2 has joined #bitcoin-core-dev
277 2019-07-29T17:13:07  *** mdunnio has quit IRC
278 2019-07-29T17:17:28  *** sfhi has quit IRC
279 2019-07-29T17:19:03  *** mdunnio has joined #bitcoin-core-dev
280 2019-07-29T17:21:09  *** pinheadmz has quit IRC
281 2019-07-29T17:21:15  *** pinheadmz_ has joined #bitcoin-core-dev
282 2019-07-29T17:24:46  *** ezegom has joined #bitcoin-core-dev
283 2019-07-29T17:28:32  *** sipa has quit IRC
284 2019-07-29T17:34:11  *** sipa has joined #bitcoin-core-dev
285 2019-07-29T17:34:52  *** fasdlkfjaslkfj has joined #bitcoin-core-dev
286 2019-07-29T17:35:29  *** jonatack has joined #bitcoin-core-dev
287 2019-07-29T17:36:10  *** fasdlkfjaslkfj has quit IRC
288 2019-07-29T17:39:59  *** bitcoin-git has joined #bitcoin-core-dev
289 2019-07-29T17:39:59  <bitcoin-git> [bitcoin] pstratem opened pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
290 2019-07-29T17:40:02  *** bitcoin-git has left #bitcoin-core-dev
291 2019-07-29T17:43:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
292 2019-07-29T17:57:38  *** ezegom has quit IRC
293 2019-07-29T17:58:00  *** ezegom has joined #bitcoin-core-dev
294 2019-07-29T18:00:00  *** bitcoin-git has joined #bitcoin-core-dev
295 2019-07-29T18:00:00  <bitcoin-git> [bitcoin] jamesob opened pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
296 2019-07-29T18:00:01  *** bitcoin-git has left #bitcoin-core-dev
297 2019-07-29T18:00:04  *** |Kin| has quit IRC
298 2019-07-29T18:04:10  *** josef641 has joined #bitcoin-core-dev
299 2019-07-29T18:04:48  *** mdunnio has quit IRC
300 2019-07-29T18:06:24  *** jarthur has joined #bitcoin-core-dev
301 2019-07-29T18:12:19  *** jarthur has quit IRC
302 2019-07-29T18:14:05  *** mdunnio has joined #bitcoin-core-dev
303 2019-07-29T18:15:48  *** dgfhdfg has quit IRC
304 2019-07-29T18:17:29  *** dgfhdfg has joined #bitcoin-core-dev
305 2019-07-29T18:17:39  *** ezegom has quit IRC
306 2019-07-29T18:18:14  *** ezegom has joined #bitcoin-core-dev
307 2019-07-29T18:18:40  *** belcher has joined #bitcoin-core-dev
308 2019-07-29T18:21:23  *** reallll has quit IRC
309 2019-07-29T18:22:33  *** ezegom has quit IRC
310 2019-07-29T18:24:13  *** ezegom has joined #bitcoin-core-dev
311 2019-07-29T18:47:41  *** JamesAU has quit IRC
312 2019-07-29T18:48:22  <phantomcircuit> also the TODO in the BIP30 logic while not exactly immediate should be looked into
313 2019-07-29T19:06:30  *** captjakk_ has quit IRC
314 2019-07-29T19:21:52  *** Victor_sueca has joined #bitcoin-core-dev
315 2019-07-29T19:21:58  *** Victorsueca has quit IRC
316 2019-07-29T19:30:36  *** bitcoin-git has joined #bitcoin-core-dev
317 2019-07-29T19:30:36  <bitcoin-git> [bitcoin] jonatack opened pull request #16489: log: update bitcoind daemon logging (master...daemon-logging-harmonisation) https://github.com/bitcoin/bitcoin/pull/16489
318 2019-07-29T19:30:49  *** bitcoin-git has left #bitcoin-core-dev
319 2019-07-29T19:38:27  *** ezegom has quit IRC
320 2019-07-29T19:39:01  *** ezegom has joined #bitcoin-core-dev
321 2019-07-29T19:40:40  *** ezegom has joined #bitcoin-core-dev
322 2019-07-29T19:42:44  *** captjakk has joined #bitcoin-core-dev
323 2019-07-29T19:45:45  *** captjakk has quit IRC
324 2019-07-29T19:46:18  *** captjakk has joined #bitcoin-core-dev
325 2019-07-29T19:50:37  *** captjakk has quit IRC
326 2019-07-29T19:51:44  *** captjakk has joined #bitcoin-core-dev
327 2019-07-29T19:53:02  *** davterra has joined #bitcoin-core-dev
328 2019-07-29T20:00:33  *** davterra has quit IRC
329 2019-07-29T20:06:31  *** sfhi2 has quit IRC
330 2019-07-29T20:06:37  *** EagleTM has joined #bitcoin-core-dev
331 2019-07-29T20:14:23  *** davterra has joined #bitcoin-core-dev
332 2019-07-29T20:18:44  *** timothy has quit IRC
333 2019-07-29T20:31:21  *** promag has quit IRC
334 2019-07-29T20:41:56  *** mdunnio has quit IRC
335 2019-07-29T20:44:26  *** sblinn has joined #bitcoin-core-dev
336 2019-07-29T20:49:40  *** mdunnio has joined #bitcoin-core-dev
337 2019-07-29T20:51:32  *** bitcoin-git has joined #bitcoin-core-dev
338 2019-07-29T20:51:32  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
339 2019-07-29T20:51:33  *** bitcoin-git has left #bitcoin-core-dev
340 2019-07-29T21:00:01  *** josef641 has quit IRC
341 2019-07-29T21:02:58  *** ezegom has quit IRC
342 2019-07-29T21:03:31  *** ezegom has joined #bitcoin-core-dev
343 2019-07-29T21:04:51  *** VitamineD has joined #bitcoin-core-dev
344 2019-07-29T21:04:53  *** ezegom has joined #bitcoin-core-dev
345 2019-07-29T21:08:40  *** Chris_Stewart_5 has quit IRC
346 2019-07-29T21:14:30  *** Guyver2 has quit IRC
347 2019-07-29T21:15:08  *** ezegom has quit IRC
348 2019-07-29T21:19:39  *** sblinn has quit IRC
349 2019-07-29T21:28:37  *** bitcoin-git has joined #bitcoin-core-dev
350 2019-07-29T21:28:37  <bitcoin-git> [bitcoin] jonatack opened pull request #16491: qa: fix deprecated log.warn in feature_dbcrash test (master...test-fix-feature_dbcrash-warn-deprecation) https://github.com/bitcoin/bitcoin/pull/16491
351 2019-07-29T21:28:45  *** bitcoin-git has left #bitcoin-core-dev
352 2019-07-29T21:31:01  *** michagogo has joined #bitcoin-core-dev
353 2019-07-29T21:46:27  <sipa> jonasschnelli, BlueMatt: about v2 transport and the question on how to encode the message types. given that 12 bytes is complete overkill anyway, i wonder if an alternative to shortcuts+variable length as proposed currently, it wouldn't be easier to just shrink the message type field; it turns out that first 2 characters + last 2 characters of every message name is unique currently
354 2019-07-29T21:46:57  <BlueMatt> why?
355 2019-07-29T21:47:07  <BlueMatt> just use the current one-byte proposal with a fallback to 12 bytes?
356 2019-07-29T21:47:18  <BlueMatt> or fallback to, I dunno, 8 bytes? whatever you want
357 2019-07-29T21:47:22  <sipa> that's also a possibility, but harder to extend
358 2019-07-29T21:47:32  <BlueMatt> is it?
359 2019-07-29T21:48:06  <sipa> as in: the shortening will only be available to a select number of messages, and probably need a lot of coordination to avoid collisions between them
360 2019-07-29T21:48:50  <BlueMatt> a lot of coordination? as in te bip process?
361 2019-07-29T21:48:54  <sipa> right
362 2019-07-29T21:49:02  <BlueMatt> that seems reasonable to me.
363 2019-07-29T21:49:18  <sipa> string messages are unlikely to collide, for 1-byte types you really need to assign sequentially
364 2019-07-29T21:49:53  <BlueMatt> how about 8 bytes and you must use the time of when you selected the message :p
365 2019-07-29T21:49:55  <sipa> while 4-byte messages for everything doesn't have this problem, is even simpler to implement, gets you most of the savings, and is backward compatible
366 2019-07-29T21:50:16  <BlueMatt> ok, or 4 byte message types and you must use the time of when you selected the message mod 2**32 :p
367 2019-07-29T21:50:45  <sipa> that could totally work
368 2019-07-29T21:51:03  <BlueMatt> I prefer that infinitely over a variable-length message type anyway
369 2019-07-29T21:51:26  <sipa> infinity is a lot
370 2019-07-29T21:52:31  *** ezegom has joined #bitcoin-core-dev
371 2019-07-29T21:53:57  <BlueMatt> YUGE
372 2019-07-29T21:55:01  <sipa> filterclear would become "feer".
373 2019-07-29T21:55:26  <BlueMatt> limiting to common-char-lower-case-ascii seems like a waste of 4 bytes, but, whatever
374 2019-07-29T21:55:41  <sipa> it is; for v2-only messages that restriction wouldn't be needed
375 2019-07-29T21:55:58  <sipa> actually it's need needed at all, agree
376 2019-07-29T21:58:02  <sipa> or we could use SHA256(message)[0:4] :p
377 2019-07-29T21:58:15  <sipa> oh no, double-SHA256(message)[0:4], satoshi style
378 2019-07-29T21:59:17  <BlueMatt> rot13(rot13(message))
379 2019-07-29T22:00:54  <sipa> i'm only half joking; using a hash function or CRC or so as mapping from string names to 4-byte message type ids has hardly any downsides i think
380 2019-07-29T22:01:01  <BlueMatt> true
381 2019-07-29T22:01:15  <sipa> an actual implementation wouldn't actually compute the hashes; they'd just be precomputed for every message type
382 2019-07-29T22:01:23  <BlueMatt> sure, of course
383 2019-07-29T22:01:58  <sipa> anyway, let's see what jonasschnelli thinks
384 2019-07-29T22:04:53  <hugohn> sipa: do you think it makes sense for descriptor.cpp->Parse() to return the output type of the descriptor string, along with the Signing Provider? I'm trying to infer the output type through other means without touching descriptor.h/.cpp. But Expand() doesn't work as intermediate redeem scripts are no longer saved to memory with native descriptor wallets (so you can’t peek into them). And string pattern matching
385 2019-07-29T22:04:53  <hugohn> (e.g. matching against `"sh(wsh"`) is ugly IMO.
386 2019-07-29T22:05:34  <sipa> hugohn: what is 'output type' ?
387 2019-07-29T22:06:35  <sipa> and i don't understand why Expand doesn't work
388 2019-07-29T22:06:59  *** booyah has quit IRC
389 2019-07-29T22:07:06  <sipa> oh, output type as in address type
390 2019-07-29T22:07:07  <sipa> hmm
391 2019-07-29T22:07:26  <sipa> what about raw multisig, or combo? those don't have a well-defined output type
392 2019-07-29T22:07:27  <hugohn> https://github.com/bitcoin/bitcoin/blob/master/src/outputtype.h#L16
393 2019-07-29T22:07:39  *** booyah has joined #bitcoin-core-dev
394 2019-07-29T22:07:44  *** mdunnio has quit IRC
395 2019-07-29T22:07:52  <hugohn> the "buckets" used in the refactored wallet
396 2019-07-29T22:10:54  <sipa> Expand() + ExtractDestination should work, i think
397 2019-07-29T22:11:26  <sipa> and you should always be able to call Expand on descriptors in the wallet, otherwise how would you participate in signing?
398 2019-07-29T22:11:56  <sipa> and you don't need the intermediate redeemscript; just ExtractDestination on the output scriptPubKey should be sufficient
399 2019-07-29T22:12:00  <sipa> i may be missing things :)
400 2019-07-29T22:13:02  <hugohn> yeah I can call Expand just fine :D my problem is distinguishing between a legacy P2SH & a P2SH-Segwit
401 2019-07-29T22:13:31  <sipa> there shouldn't be a need to distinguish between those
402 2019-07-29T22:13:51  <sipa> if the sender supports P2SH, he will support both
403 2019-07-29T22:13:56  <sipa> as he obviously can't distinguish
404 2019-07-29T22:14:38  <sipa> output types currently distinguish between them, as that what the mechanism to determine whether you wanted to use segwit in the wallet or not
405 2019-07-29T22:14:57  <sipa> but in a post-descriptor world, i think that distinction would simply be made by having a segwit descriptor or not
406 2019-07-29T22:16:20  <hugohn> right, it doesn't make a difference to the user, but I believe in achow101 's proposed new wallet architecture, we would have different scriptPubKeyManager(s) for each of the 3 output types: LEGACY, P2SH_SEGWIT (wrapped Segwit), and BECH32.
407 2019-07-29T22:16:51  <sipa> right, and you need a sanity check when creating a new descriptor?
408 2019-07-29T22:16:59  *** mdunnio has joined #bitcoin-core-dev
409 2019-07-29T22:17:04  <sipa> that the descriptor is compatible with that type
410 2019-07-29T22:17:06  <sipa> ?
411 2019-07-29T22:26:00  *** mdunnio has quit IRC
412 2019-07-29T22:26:06  <achow101> Yes
413 2019-07-29T22:26:46  *** mdunnio has joined #bitcoin-core-dev
414 2019-07-29T22:26:54  <sipa> arguably we should just get rid of the distinction between P2SH and P2SH-Segwit
415 2019-07-29T22:27:53  <achow101> I wrote a function that used the Solver + a SigningProvider in order to determine the address type, but apparently that doesn't work since the p2sh-segwit redeemScript is not put in the SigningProvider by Descriptor Expand or Parse
416 2019-07-29T22:27:53  <sipa> though perhaps that's not something to do simultaneously
417 2019-07-29T22:28:09  <sipa> hmm, really?
418 2019-07-29T22:28:20  <sipa> Expand should put it there
419 2019-07-29T22:28:49  <achow101> That's what I thought, but hugohn told me it isn't (haven't had the chance to check)
420 2019-07-29T22:29:10  <sipa> that sounds like a major issue if it isn't
421 2019-07-29T22:29:52  <sipa> https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp#L461
422 2019-07-29T22:29:55  <hugohn> https://www.irccloud.com/pastebin/NoBXcIt6/ExpandHelper
423 2019-07-29T22:30:15  *** ezegom has quit IRC
424 2019-07-29T22:31:44  <sipa> hugohn: yes?
425 2019-07-29T22:32:43  <hugohn> sorry ignore that snippet. I missed that line you posted above, looks like the redeem script is saved to the Signing Provider.
426 2019-07-29T22:33:25  <sipa> hugohn: in general no information should get lost through an Expand
427 2019-07-29T22:33:27  <hugohn> then I don't understand why when we look up for the redeemScript later, we don't find it, hmm...
428 2019-07-29T22:33:50  <sipa> otherwise InferDescriptor wouldn't be able to reconstruct things
429 2019-07-29T22:33:55  <sipa> which afaik has a test
430 2019-07-29T22:34:01  *** mdunnio has quit IRC
431 2019-07-29T22:37:29  <elichai2> hugohn: maybe it wasn't expanded yet?
432 2019-07-29T22:39:15  <hugohn> elichai2: no I made sure it was expanded
433 2019-07-29T22:43:07  <hugohn> code for more context: https://github.com/achow101/bitcoin/pull/4/files#diff-b2bb174788c7409b671c46ccc86034bdR4273
434 2019-07-29T22:43:17  <hugohn> I'm not getting the correct output type by peeking into an address generated by Expand() here^
435 2019-07-29T22:49:45  *** luke-jr has quit IRC
436 2019-07-29T22:51:51  *** luke-jr has joined #bitcoin-core-dev
437 2019-07-29T22:52:19  <hugohn> implementation for DetermineOutputType: https://github.com/achow101/bitcoin/blob/wallet-of-the-glorious-future/src/outputtype.cpp#L126
438 2019-07-29T22:52:48  <hugohn> `provider.GetCScript()` fails to look up the redeem script given the script ID
439 2019-07-29T22:56:56  *** ezegom has joined #bitcoin-core-dev
440 2019-07-29T22:57:56  <hugohn> nway, very likely I'm doing something wrong, will investigate further. thanks sipa!
441 2019-07-29T22:59:59  *** jonatack has quit IRC
442 2019-07-29T23:00:26  *** luke-jr has quit IRC
443 2019-07-29T23:00:53  *** dgfhdfg has quit IRC
444 2019-07-29T23:01:24  <sipa> hugohn: add some debug statements that print the contents of the SigningProvider before calling the code to determine output type
445 2019-07-29T23:01:34  *** luke-jr has joined #bitcoin-core-dev
446 2019-07-29T23:03:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
447 2019-07-29T23:04:01  *** ezegom has quit IRC
448 2019-07-29T23:06:06  <hugohn> sipa: yes I'm adding printf eveywhere lol. will try that next!
449 2019-07-29T23:10:35  *** rex4539 has joined #bitcoin-core-dev
450 2019-07-29T23:11:32  *** dviola has joined #bitcoin-core-dev
451 2019-07-29T23:20:03  *** Chris_Stewart_5 has quit IRC
452 2019-07-29T23:25:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
453 2019-07-29T23:36:13  *** mdunnio has joined #bitcoin-core-dev
454 2019-07-29T23:37:28  *** mdunnio has quit IRC
455 2019-07-29T23:38:13  *** lightlike has quit IRC
456 2019-07-29T23:39:26  *** mdunnio has joined #bitcoin-core-dev
457 2019-07-29T23:46:19  *** ezegom has joined #bitcoin-core-dev