1 2019-07-31T00:00:02  *** spake has quit IRC
  2 2019-07-31T00:01:39  *** laptop500 has quit IRC
  3 2019-07-31T00:04:05  *** ezegom has quit IRC
  4 2019-07-31T00:04:26  *** ezegom has joined #bitcoin-core-dev
  5 2019-07-31T00:04:52  *** gatox has joined #bitcoin-core-dev
  6 2019-07-31T00:12:40  *** mdunnio has joined #bitcoin-core-dev
  7 2019-07-31T00:12:43  *** captjakk has quit IRC
  8 2019-07-31T00:13:11  *** captjakk has joined #bitcoin-core-dev
  9 2019-07-31T00:14:23  *** mdunnio has quit IRC
 10 2019-07-31T00:14:59  *** mdunnio has joined #bitcoin-core-dev
 11 2019-07-31T00:15:45  *** mdunnio has joined #bitcoin-core-dev
 12 2019-07-31T00:16:00  *** mdunnio has quit IRC
 13 2019-07-31T00:16:49  *** AaronvanW has joined #bitcoin-core-dev
 14 2019-07-31T00:18:12  *** captjakk has quit IRC
 15 2019-07-31T00:18:16  *** Chris_Stewart_5 has quit IRC
 16 2019-07-31T00:18:46  *** mdunnio has joined #bitcoin-core-dev
 17 2019-07-31T00:22:00  *** AaronvanW has quit IRC
 18 2019-07-31T00:25:00  *** captjakk has joined #bitcoin-core-dev
 19 2019-07-31T00:28:17  *** bitcoin-git has joined #bitcoin-core-dev
 20 2019-07-31T00:28:17  <bitcoin-git> [bitcoin] promag opened pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
 21 2019-07-31T00:28:21  *** bitcoin-git has left #bitcoin-core-dev
 22 2019-07-31T00:34:50  *** mdunnio has quit IRC
 23 2019-07-31T00:35:26  *** mdunnio has joined #bitcoin-core-dev
 24 2019-07-31T00:37:03  *** mdunnio has joined #bitcoin-core-dev
 25 2019-07-31T00:37:12  *** mdunnio has quit IRC
 26 2019-07-31T00:49:18  *** AaronvanW has joined #bitcoin-core-dev
 27 2019-07-31T00:52:12  *** justanotheruser has joined #bitcoin-core-dev
 28 2019-07-31T00:53:17  *** lightlike has quit IRC
 29 2019-07-31T00:53:48  *** AaronvanW has quit IRC
 30 2019-07-31T01:01:36  *** morcos_ has joined #bitcoin-core-dev
 31 2019-07-31T01:03:46  *** morcos has quit IRC
 32 2019-07-31T01:03:47  *** morcos_ is now known as morcos
 33 2019-07-31T01:20:22  *** rex4539 has quit IRC
 34 2019-07-31T01:20:43  *** berndj has quit IRC
 35 2019-07-31T01:23:55  *** berndj has joined #bitcoin-core-dev
 36 2019-07-31T01:25:54  *** ezegom has quit IRC
 37 2019-07-31T01:28:57  *** AaronvanW has joined #bitcoin-core-dev
 38 2019-07-31T01:32:27  *** petezz4 has quit IRC
 39 2019-07-31T01:33:57  *** AaronvanW has quit IRC
 40 2019-07-31T01:35:45  *** ezegom has joined #bitcoin-core-dev
 41 2019-07-31T01:39:55  *** ezegom has quit IRC
 42 2019-07-31T01:43:42  *** davec has quit IRC
 43 2019-07-31T01:46:20  *** DeanGuss has joined #bitcoin-core-dev
 44 2019-07-31T01:50:12  *** Victor_sueca has quit IRC
 45 2019-07-31T01:51:11  *** Victor_sueca has joined #bitcoin-core-dev
 46 2019-07-31T01:55:16  *** justanotheruser has quit IRC
 47 2019-07-31T02:00:04  *** elichai2 has quit IRC
 48 2019-07-31T02:01:05  *** ezegom has joined #bitcoin-core-dev
 49 2019-07-31T02:02:21  *** davec has joined #bitcoin-core-dev
 50 2019-07-31T02:05:27  *** ezegom has quit IRC
 51 2019-07-31T02:08:07  *** AaronvanW has joined #bitcoin-core-dev
 52 2019-07-31T02:12:32  *** AaronvanW has quit IRC
 53 2019-07-31T02:24:02  *** tryphe_ is now known as tryphe
 54 2019-07-31T02:25:15  *** mdunnio has joined #bitcoin-core-dev
 55 2019-07-31T02:28:56  *** captjakk has quit IRC
 56 2019-07-31T02:29:23  *** captjakk has joined #bitcoin-core-dev
 57 2019-07-31T02:33:48  *** captjakk has quit IRC
 58 2019-07-31T02:40:22  *** emilengler has quit IRC
 59 2019-07-31T02:44:27  *** AaronvanW has joined #bitcoin-core-dev
 60 2019-07-31T02:49:07  *** AaronvanW has quit IRC
 61 2019-07-31T02:57:58  *** booyah has quit IRC
 62 2019-07-31T02:59:09  *** booyah has joined #bitcoin-core-dev
 63 2019-07-31T03:00:02  *** gatox has quit IRC
 64 2019-07-31T03:00:57  *** mdunnio has quit IRC
 65 2019-07-31T03:04:31  *** vostorga1 has joined #bitcoin-core-dev
 66 2019-07-31T03:07:18  *** skyikot has joined #bitcoin-core-dev
 67 2019-07-31T03:14:05  *** skyikot has quit IRC
 68 2019-07-31T03:14:16  *** skyikot has joined #bitcoin-core-dev
 69 2019-07-31T03:15:20  *** captjakk has joined #bitcoin-core-dev
 70 2019-07-31T03:15:41  *** justanotheruser has joined #bitcoin-core-dev
 71 2019-07-31T03:16:27  *** d_t has joined #bitcoin-core-dev
 72 2019-07-31T03:17:18  *** AaronvanW has joined #bitcoin-core-dev
 73 2019-07-31T03:17:37  *** skyikot has quit IRC
 74 2019-07-31T03:17:50  *** skyikot has joined #bitcoin-core-dev
 75 2019-07-31T03:18:49  *** skyikot has quit IRC
 76 2019-07-31T03:20:35  *** skyikot has joined #bitcoin-core-dev
 77 2019-07-31T03:21:40  *** AaronvanW has quit IRC
 78 2019-07-31T03:22:33  *** skyikot has quit IRC
 79 2019-07-31T03:27:04  *** skyikot has joined #bitcoin-core-dev
 80 2019-07-31T03:46:49  *** AaronvanW has joined #bitcoin-core-dev
 81 2019-07-31T03:51:09  *** AaronvanW has quit IRC
 82 2019-07-31T03:52:41  *** schnerchi has joined #bitcoin-core-dev
 83 2019-07-31T03:55:28  *** schnerch_ has quit IRC
 84 2019-07-31T04:01:28  *** captjakk has quit IRC
 85 2019-07-31T04:02:04  *** captjakk has joined #bitcoin-core-dev
 86 2019-07-31T04:06:34  *** captjakk has quit IRC
 87 2019-07-31T04:12:49  *** DeanGuss has quit IRC
 88 2019-07-31T04:13:33  *** DeanGuss has joined #bitcoin-core-dev
 89 2019-07-31T04:22:17  *** AaronvanW has joined #bitcoin-core-dev
 90 2019-07-31T04:26:43  *** AaronvanW has quit IRC
 91 2019-07-31T04:31:46  *** Victorsueca has joined #bitcoin-core-dev
 92 2019-07-31T04:34:11  *** Victor_sueca has quit IRC
 93 2019-07-31T04:44:55  *** DeanGuss has quit IRC
 94 2019-07-31T04:45:24  *** DeanGuss has joined #bitcoin-core-dev
 95 2019-07-31T04:56:01  *** AaronvanW has joined #bitcoin-core-dev
 96 2019-07-31T05:00:51  *** AaronvanW has quit IRC
 97 2019-07-31T05:06:50  *** d_t has quit IRC
 98 2019-07-31T05:06:56  *** DeanGuss has quit IRC
 99 2019-07-31T05:07:11  *** DeanGuss has joined #bitcoin-core-dev
100 2019-07-31T05:09:38  *** liberiga has joined #bitcoin-core-dev
101 2019-07-31T05:12:44  *** _Sam-- has quit IRC
102 2019-07-31T05:20:24  *** Lauda has quit IRC
103 2019-07-31T05:21:04  *** afk11 has quit IRC
104 2019-07-31T05:21:32  *** sipa has quit IRC
105 2019-07-31T05:22:11  *** Lauda has joined #bitcoin-core-dev
106 2019-07-31T05:22:11  *** Lauda has joined #bitcoin-core-dev
107 2019-07-31T05:23:20  *** afk11 has joined #bitcoin-core-dev
108 2019-07-31T05:28:06  *** sipa has joined #bitcoin-core-dev
109 2019-07-31T05:30:07  *** AaronvanW has joined #bitcoin-core-dev
110 2019-07-31T05:34:52  *** AaronvanW has quit IRC
111 2019-07-31T05:54:11  *** AaronvanW has joined #bitcoin-core-dev
112 2019-07-31T05:56:14  *** AaronvanW has quit IRC
113 2019-07-31T05:56:32  *** AaronvanW has joined #bitcoin-core-dev
114 2019-07-31T06:00:02  *** vostorga1 has quit IRC
115 2019-07-31T06:05:31  *** skyikot has quit IRC
116 2019-07-31T06:10:52  *** dlareg1 has joined #bitcoin-core-dev
117 2019-07-31T06:19:00  *** kcalvinalvin has joined #bitcoin-core-dev
118 2019-07-31T06:23:12  *** EagleTM has joined #bitcoin-core-dev
119 2019-07-31T06:29:40  *** liberiga has quit IRC
120 2019-07-31T06:56:38  *** anemous has quit IRC
121 2019-07-31T07:01:32  *** bitcoin-git has joined #bitcoin-core-dev
122 2019-07-31T07:01:34  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/39763b75556b...8241b5150431
123 2019-07-31T07:01:34  <bitcoin-git> bitcoin/master b3a9d17 John Newbery: [wallet] Move CMerkleTx functions into CWalletTx
124 2019-07-31T07:01:35  <bitcoin-git> bitcoin/master 783a76f John Newbery: [wallet] Flatten CWalletTx class hierarchy
125 2019-07-31T07:01:36  <bitcoin-git> bitcoin/master 05b56d1 John Newbery: [wallet] Remove CMerkleTx serialization logic
126 2019-07-31T07:01:38  *** bitcoin-git has left #bitcoin-core-dev
127 2019-07-31T07:02:32  *** bitcoin-git has joined #bitcoin-core-dev
128 2019-07-31T07:02:32  <bitcoin-git> [bitcoin] laanwj merged pull request #16451: Remove CMerkleTx (master...2019-07-remove-CMerkleTx) https://github.com/bitcoin/bitcoin/pull/16451
129 2019-07-31T07:02:36  *** bitcoin-git has left #bitcoin-core-dev
130 2019-07-31T07:09:31  *** EagleTM has quit IRC
131 2019-07-31T07:13:01  *** Raystonn has quit IRC
132 2019-07-31T07:18:37  *** petezz4 has joined #bitcoin-core-dev
133 2019-07-31T07:25:03  *** petezz4 has quit IRC
134 2019-07-31T07:25:15  *** petezz4 has joined #bitcoin-core-dev
135 2019-07-31T07:40:39  *** kljasdfvv has joined #bitcoin-core-dev
136 2019-07-31T07:46:01  *** promag has quit IRC
137 2019-07-31T08:03:23  *** bitcoin-git has joined #bitcoin-core-dev
138 2019-07-31T08:03:24  <bitcoin-git> [bitcoin] sipsorcery opened pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
139 2019-07-31T08:03:25  *** bitcoin-git has left #bitcoin-core-dev
140 2019-07-31T08:09:57  <fanquake> kallewoof: done 👍
141 2019-07-31T08:10:52  *** midnightmagic has quit IRC
142 2019-07-31T08:12:14  *** laptop500 has joined #bitcoin-core-dev
143 2019-07-31T08:12:15  <kallewoof> Thanks! :)
144 2019-07-31T08:12:18  *** Krellan_ has quit IRC
145 2019-07-31T08:12:47  *** Krellan has joined #bitcoin-core-dev
146 2019-07-31T08:17:01  *** jungly has joined #bitcoin-core-dev
147 2019-07-31T08:17:17  *** Krellan has quit IRC
148 2019-07-31T08:24:31  *** midnightmagic has joined #bitcoin-core-dev
149 2019-07-31T08:34:32  *** Zenton has joined #bitcoin-core-dev
150 2019-07-31T08:35:15  *** kcalvinalvin has quit IRC
151 2019-07-31T08:58:13  *** setpill has joined #bitcoin-core-dev
152 2019-07-31T09:00:01  *** dlareg1 has quit IRC
153 2019-07-31T09:06:00  *** jb55 has quit IRC
154 2019-07-31T09:13:49  *** timothy has joined #bitcoin-core-dev
155 2019-07-31T09:14:31  *** jb55 has joined #bitcoin-core-dev
156 2019-07-31T09:25:08  *** jb55 has quit IRC
157 2019-07-31T09:26:51  *** guest69 has quit IRC
158 2019-07-31T09:28:22  *** jb55 has joined #bitcoin-core-dev
159 2019-07-31T09:45:24  *** guilhermeblanco has joined #bitcoin-core-dev
160 2019-07-31T10:12:19  *** bitcoin-git has joined #bitcoin-core-dev
161 2019-07-31T10:12:19  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8241b5150431...00922b872027
162 2019-07-31T10:12:20  <bitcoin-git> bitcoin/master 80ba424 Amiti Uttarwar: extract min & max depth onto coin control
163 2019-07-31T10:12:20  <bitcoin-git> bitcoin/master 00922b8 Wladimir J. van der Laan: Merge #15906: [wallet] Move min_depth and max_depth to coin control
164 2019-07-31T10:12:22  *** bitcoin-git has left #bitcoin-core-dev
165 2019-07-31T10:13:04  *** bitcoin-git has joined #bitcoin-core-dev
166 2019-07-31T10:13:04  <bitcoin-git> [bitcoin] laanwj merged pull request #15906: [wallet] Move min_depth and max_depth to coin control (master...refactor_available_coins) https://github.com/bitcoin/bitcoin/pull/15906
167 2019-07-31T10:13:05  *** bitcoin-git has left #bitcoin-core-dev
168 2019-07-31T10:16:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
169 2019-07-31T10:37:56  *** jonatack has quit IRC
170 2019-07-31T10:59:53  *** spinza has quit IRC
171 2019-07-31T11:15:38  *** spinza has joined #bitcoin-core-dev
172 2019-07-31T11:17:53  *** ezegom has joined #bitcoin-core-dev
173 2019-07-31T11:17:55  *** sdupre has joined #bitcoin-core-dev
174 2019-07-31T11:18:38  *** luke-jr has quit IRC
175 2019-07-31T11:19:21  *** luke-jr has joined #bitcoin-core-dev
176 2019-07-31T11:21:50  *** luke-jr has quit IRC
177 2019-07-31T11:22:12  *** ezegom has quit IRC
178 2019-07-31T11:23:10  *** luke-jr has joined #bitcoin-core-dev
179 2019-07-31T11:25:43  *** bitcoin-git has joined #bitcoin-core-dev
180 2019-07-31T11:25:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00922b872027...f89113626e42
181 2019-07-31T11:25:43  <bitcoin-git> bitcoin/master 0646ca5 Aaron Clauson: Changes the verbosity of msbuild from quiet to normal in the appveyor scri...
182 2019-07-31T11:25:44  <bitcoin-git> bitcoin/master f891136 MarcoFalke: Merge #16505: Changes verbosity of msbuild from quiet to normal in the app...
183 2019-07-31T11:25:45  *** bitcoin-git has left #bitcoin-core-dev
184 2019-07-31T11:26:51  *** bitcoin-git has joined #bitcoin-core-dev
185 2019-07-31T11:26:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
186 2019-07-31T11:26:52  *** bitcoin-git has left #bitcoin-core-dev
187 2019-07-31T11:28:36  *** bitcoin-git has joined #bitcoin-core-dev
188 2019-07-31T11:28:36  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
189 2019-07-31T11:28:37  *** bitcoin-git has left #bitcoin-core-dev
190 2019-07-31T11:28:55  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-07-31T11:28:55  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
192 2019-07-31T11:28:59  *** bitcoin-git has left #bitcoin-core-dev
193 2019-07-31T11:29:00  *** sdupre has quit IRC
194 2019-07-31T11:37:56  *** bitcoin-git has joined #bitcoin-core-dev
195 2019-07-31T11:37:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f89113626e42...3f288a1c05eb
196 2019-07-31T11:37:56  <bitcoin-git> bitcoin/master 73b692b João Barbosa: doc: Add release note for the deprecated totalFee option of bumpfee
197 2019-07-31T11:37:57  <bitcoin-git> bitcoin/master 3f288a1 MarcoFalke: Merge #16504: doc: Add release note for the deprecated totalFee option of ...
198 2019-07-31T11:37:58  *** bitcoin-git has left #bitcoin-core-dev
199 2019-07-31T11:38:56  *** bitcoin-git has joined #bitcoin-core-dev
200 2019-07-31T11:38:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
201 2019-07-31T11:39:00  *** bitcoin-git has left #bitcoin-core-dev
202 2019-07-31T12:00:02  *** guilhermeblanco has quit IRC
203 2019-07-31T12:00:25  *** jonatack has joined #bitcoin-core-dev
204 2019-07-31T12:04:24  *** MarconM has joined #bitcoin-core-dev
205 2019-07-31T12:06:13  *** ezegom has joined #bitcoin-core-dev
206 2019-07-31T12:08:50  *** ezegom has quit IRC
207 2019-07-31T12:09:24  *** captjakk has joined #bitcoin-core-dev
208 2019-07-31T12:12:44  *** ezegom has joined #bitcoin-core-dev
209 2019-07-31T12:18:37  *** ezegom has quit IRC
210 2019-07-31T12:27:44  <sdaftuar> phantomcircuit: regarding the bip 30 optimization
211 2019-07-31T12:28:26  <sdaftuar> it’s important to enforce bip30 on potential “alternate” chains, because if there is a utxo “overwrite” from a duplicate transaction, then the utxo set will be potentially incorrect when reorging from that chain to some other chain (eg because you’ll have removed an entry from the utxo set that should still be there, if you’d never connected the block that overwrote the transaction in
212 2019-07-31T12:28:28  <sdaftuar> the first place).
213 2019-07-31T12:29:22  <sdaftuar> on the bitcoin main chain, this is not actually a problem (modulo the hypothetical future problem we can have after block 1.9M or whatever it is)
214 2019-07-31T12:29:37  <sdaftuar> Anyway this would be a simple fix to your PR — just ensure that you only skip the bip30 checks if assume valid is set and the assume valid block hash builds on the known bip34 activation block hash; that would ensure that we only skip the bip30 checks on blocks we know to be safe from this issue
215 2019-07-31T12:30:17  <sdaftuar> but as i mentioned on the pr, i don’t think it’s worth making any changes for a 22 second speedup during IBD.
216 2019-07-31T12:35:46  *** mzygar has joined #bitcoin-core-dev
217 2019-07-31T12:36:50  *** cubancorona has joined #bitcoin-core-dev
218 2019-07-31T12:44:13  *** spaced0ut has joined #bitcoin-core-dev
219 2019-07-31T12:56:06  *** davterra has quit IRC
220 2019-07-31T12:58:52  *** DeanGuss has quit IRC
221 2019-07-31T13:05:05  *** Guyver2 has joined #bitcoin-core-dev
222 2019-07-31T13:10:31  *** captjakk has quit IRC
223 2019-07-31T13:11:04  *** captjakk has joined #bitcoin-core-dev
224 2019-07-31T13:11:38  *** ezegom has joined #bitcoin-core-dev
225 2019-07-31T13:15:43  *** captjakk has quit IRC
226 2019-07-31T13:16:35  *** Jackielove4u has quit IRC
227 2019-07-31T13:16:47  *** Jackielove4u has joined #bitcoin-core-dev
228 2019-07-31T13:20:21  *** dgfhdfg has joined #bitcoin-core-dev
229 2019-07-31T13:32:33  *** lnostdal has quit IRC
230 2019-07-31T13:40:40  *** davterra has joined #bitcoin-core-dev
231 2019-07-31T13:50:36  *** d_t has joined #bitcoin-core-dev
232 2019-07-31T13:50:48  *** lightlike has joined #bitcoin-core-dev
233 2019-07-31T14:01:13  *** elichai2 has joined #bitcoin-core-dev
234 2019-07-31T14:07:29  *** mzygar_ has joined #bitcoin-core-dev
235 2019-07-31T14:09:29  *** captjakk has joined #bitcoin-core-dev
236 2019-07-31T14:10:27  *** mzygar has quit IRC
237 2019-07-31T14:12:16  *** captjakk has quit IRC
238 2019-07-31T14:15:52  *** _Sam-- has joined #bitcoin-core-dev
239 2019-07-31T14:20:43  *** dgfhdfg has quit IRC
240 2019-07-31T14:32:25  *** hebasto has joined #bitcoin-core-dev
241 2019-07-31T14:39:13  *** emilengler has joined #bitcoin-core-dev
242 2019-07-31T14:40:13  <jnewbery_> laanwj MarcoFalke: if you're in a merging mood, then I think #16452 is good to go
243 2019-07-31T14:40:17  <gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub
244 2019-07-31T14:45:16  <dongcarl> wumpus: How should addrv2 clients handle ::FFFF:0:0/96 IPv4-mapped addresses?
245 2019-07-31T14:46:38  *** mdunnio has joined #bitcoin-core-dev
246 2019-07-31T14:47:28  <dongcarl> More specifically, 1. Should they be accepted (I think yes) 2. Should they be internally parsed into IPv4 addresses, or stay internally as IPv6 addresses that still return true for `IsIPv4()`?
247 2019-07-31T14:48:24  <phantomcircuit> sdaftuar, ooooh yes i see
248 2019-07-31T14:50:24  *** d_t has quit IRC
249 2019-07-31T14:50:44  *** bitcoin-git has joined #bitcoin-core-dev
250 2019-07-31T14:50:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f288a1c05eb...7821821a23b6
251 2019-07-31T14:50:45  <bitcoin-git> bitcoin/master 9bc8b28 Antoine Riard: refactor : use RelayTransaction in BroadcastTransaction utility
252 2019-07-31T14:50:46  <bitcoin-git> bitcoin/master 7821821 MarcoFalke: Merge #16452: refactor: use RelayTransaction in BroadcastTransaction utili...
253 2019-07-31T14:50:47  *** bitcoin-git has left #bitcoin-core-dev
254 2019-07-31T14:51:49  *** bitcoin-git has joined #bitcoin-core-dev
255 2019-07-31T14:51:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
256 2019-07-31T14:51:54  *** bitcoin-git has left #bitcoin-core-dev
257 2019-07-31T14:55:11  <sdaftuar> phantomcircuit: really, assumevalid has nothing to do with the optimization -- it'd be enough to check to see if a block is an ancestor of the known-bip34-activation blockhash, and if so, skip the check. i think.  but this is all so complicated that i think it's best not to risk changes here...
258 2019-07-31T14:57:43  *** mdunnio has quit IRC
259 2019-07-31T14:58:44  <phantomcircuit> sdaftuar, my principle motivation was to make measuring leveldb calls vs dbcache size easier
260 2019-07-31T14:58:58  <phantomcircuit> i just thought it was a nice optimization as well
261 2019-07-31T14:59:02  *** mdunnio has joined #bitcoin-core-dev
262 2019-07-31T14:59:16  *** sdupre has joined #bitcoin-core-dev
263 2019-07-31T14:59:19  <phantomcircuit> but yeah i hadn't considered that it would erase a utxo entry that wouldn't be restored by the undo blocks
264 2019-07-31T15:00:02  *** MarconM has quit IRC
265 2019-07-31T15:00:26  <MarcoFalke> fanquake: If you leave the label for DrahtBot to remove, it will also remove all its comments and make the comment history shorter/easier to follow. https://github.com/bitcoin/bitcoin/pull/16400#event-2523391791
266 2019-07-31T15:04:29  *** paulk-collins has joined #bitcoin-core-dev
267 2019-07-31T15:06:41  *** schnerchi has quit IRC
268 2019-07-31T15:12:55  *** setpill has quit IRC
269 2019-07-31T15:19:16  *** dgfhdfg has joined #bitcoin-core-dev
270 2019-07-31T15:21:13  *** mdunnio has quit IRC
271 2019-07-31T15:21:29  *** mdunnio has joined #bitcoin-core-dev
272 2019-07-31T15:21:59  <elichai2> should I impose the lex ordering over the tapdescriptor? meaning. should I fail a desc because it wasn't ordered correctly? on one hand this means it's really hard to constructe desc by hand(if that's even a thing?) on the other if we don't have this than there's no longer 1-1 mapping (multiple desc ordered differently will result in the same scriptPubKey)
273 2019-07-31T15:23:56  <sipa> elichai2: good question
274 2019-07-31T15:26:28  <wumpus> dongcarl: that's a good point, i think it should reject (ignore) them, addrv2 has its own way of sending IPv4 addresses that should be used
275 2019-07-31T15:29:25  <wumpus> dongcarl: for Tor I do specify this explictly in the BIP"
276 2019-07-31T15:29:39  <wumpus> dongcarl: e.g. " Clients SHOULD ignore OnionCat (<code>fd87:d87e:eb43::/48</code>) addresses on receive if they come with the <code>IPV6</code> network ID."
277 2019-07-31T15:29:56  <wumpus> dongcarl: should probably add the same for IPv4 addresses encoded as IPv6
278 2019-07-31T15:30:10  <sipa> wumpus: that makes sense
279 2019-07-31T15:31:37  <dongcarl> that sounds good :-)
280 2019-07-31T15:33:29  *** bitcoin-git has joined #bitcoin-core-dev
281 2019-07-31T15:33:29  <bitcoin-git> [bitcoin] instagibbs closed pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
282 2019-07-31T15:33:32  *** bitcoin-git has left #bitcoin-core-dev
283 2019-07-31T15:37:44  <sipa> elichai2: it's kind of annoying for human construction if the branches need to be well-ordered (which is effectively random)
284 2019-07-31T15:38:10  <sipa> elichai2: on the other hand, inferring a descriptor from comtext information will only possibly find one order
285 2019-07-31T15:38:11  *** hhhhtfuzrtzrtzey has joined #bitcoin-core-dev
286 2019-07-31T15:38:17  <sipa> so... i don't know
287 2019-07-31T15:39:42  <elichai2> sipa: hmm generally the inferring isn't a fun problem. but it actually makes it a little bit simpler if you don't care about the order. you can compare paths to identify siblings
288 2019-07-31T15:41:10  <elichai2> (so siblings are gonna have the same script path except the last part(which will be the hash of each other), you can then combine them together to a new "script path" as a node, remove the last part of the path and find they're sibling. that way you reconstructe from the bottom up without verifying order)
289 2019-07-31T15:42:06  <sipa> sure, you can compare things in multiple ways
290 2019-07-31T15:42:40  *** kljasdfvv has quit IRC
291 2019-07-31T15:43:10  <sipa> i'm just wondering if the inconvenience of forcing an essentially random (and hard for humans to create) order weighs up against the added variance in descriptors (which will be wiped out by canonicalizing/infering)
292 2019-07-31T15:43:19  <sipa> i think we should permit both orders
293 2019-07-31T15:43:46  <sipa> there are already non-canonical things in descriptors
294 2019-07-31T15:44:56  *** captjakk has joined #bitcoin-core-dev
295 2019-07-31T15:45:48  <elichai2> sipa: are there any non-canonical things *withou* addr and raw?
296 2019-07-31T15:46:23  <sipa> elichai2: the h vs ' for hardened paths
297 2019-07-31T15:46:27  <elichai2> (altough parsing a raw descriptor and then infering back the scriptPubKey might end you up with a different desc then the one you started with)
298 2019-07-31T15:46:28  <elichai2> right
299 2019-07-31T15:49:05  *** ezegom has quit IRC
300 2019-07-31T15:49:15  <sipa> yeah
301 2019-07-31T15:49:39  *** ezegom has joined #bitcoin-core-dev
302 2019-07-31T15:50:04  *** ezegom has joined #bitcoin-core-dev
303 2019-07-31T15:50:36  *** hhhhtfuzrtzrtzey has quit IRC
304 2019-07-31T15:54:34  *** mzygar_ has quit IRC
305 2019-07-31T16:05:47  <emilengler> Hi, how can I detect in the qt debug window if the console tab is open? Is there a function which returns a bool for it or something similar?
306 2019-07-31T16:17:15  <wumpus> emilengler: ui->tabWidget->widget(index) == ui->tab_console
307 2019-07-31T16:17:34  <emilengler> wumpus: thank you
308 2019-07-31T16:17:40  <wumpus> emilengler: though usually you shouldn't need to worry what tab is open
309 2019-07-31T16:18:20  <emilengler> wumpus: Well how does bitcoin-qt then detects when Ctrl+L is pressed? It only works when the console tab is open
310 2019-07-31T16:18:58  <wumpus> I suppose it only works when the console's input widget is selected
311 2019-07-31T16:19:18  <wumpus> that's kind of the idea, to use qt's event propagation, it's very rare that you need to go outside that
312 2019-07-31T16:20:01  <emilengler> The console also clears wiht Ctrl+L if the textbox isn't selected if this is what you've meant
313 2019-07-31T16:24:24  <wumpus>            <property name="shortcut">
314 2019-07-31T16:24:25  <wumpus>             <string notr="true">Ctrl+L</string>
315 2019-07-31T16:24:27  <wumpus>            </property>
316 2019-07-31T16:24:32  <wumpus> looks like the clearButton has that as shortcut
317 2019-07-31T16:24:56  <wumpus> I *think* a button will only trigger if it is visible
318 2019-07-31T16:25:02  <wumpus> so that explains it
319 2019-07-31T16:25:07  <emilengler> Oh interesting this explains a lot... I searched exactly for this for so long haha
320 2019-07-31T16:27:15  *** owowo has quit IRC
321 2019-07-31T16:34:27  *** owowo has joined #bitcoin-core-dev
322 2019-07-31T16:34:48  *** achow101 has quit IRC
323 2019-07-31T16:38:37  *** mdunnio has quit IRC
324 2019-07-31T16:44:51  *** achow101 has joined #bitcoin-core-dev
325 2019-07-31T16:44:58  *** csknk has joined #bitcoin-core-dev
326 2019-07-31T16:45:59  *** harrigan has joined #bitcoin-core-dev
327 2019-07-31T16:50:26  *** davex__ has joined #bitcoin-core-dev
328 2019-07-31T16:53:10  *** michaelfolkson has joined #bitcoin-core-dev
329 2019-07-31T17:01:03  *** i2 has joined #bitcoin-core-dev
330 2019-07-31T17:03:36  *** timothy has quit IRC
331 2019-07-31T17:06:51  *** mdunnio has joined #bitcoin-core-dev
332 2019-07-31T17:11:54  *** ezegom has quit IRC
333 2019-07-31T17:12:31  *** ezegom has joined #bitcoin-core-dev
334 2019-07-31T17:12:51  *** ezegom has joined #bitcoin-core-dev
335 2019-07-31T17:23:53  *** davterra has quit IRC
336 2019-07-31T17:24:22  *** davterra has joined #bitcoin-core-dev
337 2019-07-31T17:24:47  *** bitcoin-git has joined #bitcoin-core-dev
338 2019-07-31T17:24:47  <bitcoin-git> [bitcoin] instagibbs opened pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
339 2019-07-31T17:24:49  *** Chris_Stewart_5 has quit IRC
340 2019-07-31T17:25:00  *** bitcoin-git has left #bitcoin-core-dev
341 2019-07-31T17:26:22  *** jungly has quit IRC
342 2019-07-31T17:29:39  *** davterra has quit IRC
343 2019-07-31T17:30:06  *** ezegom has quit IRC
344 2019-07-31T17:30:15  *** davterra has joined #bitcoin-core-dev
345 2019-07-31T17:30:43  *** ezegom has joined #bitcoin-core-dev
346 2019-07-31T17:31:03  *** ezegom has joined #bitcoin-core-dev
347 2019-07-31T17:36:02  *** Dannzor has joined #bitcoin-core-dev
348 2019-07-31T17:36:03  *** captjakk has quit IRC
349 2019-07-31T17:40:51  *** michaelfolkson has quit IRC
350 2019-07-31T17:41:58  *** Zenton has quit IRC
351 2019-07-31T17:44:34  *** bitcoin-git has joined #bitcoin-core-dev
352 2019-07-31T17:44:35  <bitcoin-git> [bitcoin] hebasto opened pull request #16508: Use ArgsManager::ALLOW_BOOL flag explicitly (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
353 2019-07-31T17:44:36  *** bitcoin-git has left #bitcoin-core-dev
354 2019-07-31T17:49:11  *** mzygar has joined #bitcoin-core-dev
355 2019-07-31T17:56:55  *** michaelsdunn1_ has quit IRC
356 2019-07-31T18:00:02  *** paulk-collins has quit IRC
357 2019-07-31T18:04:08  *** dougvann has joined #bitcoin-core-dev
358 2019-07-31T18:04:55  *** csknk has quit IRC
359 2019-07-31T18:10:15  <jonatack> emilengler: git grep Ctrl+L (git grep is your friend :)...)
360 2019-07-31T18:11:06  *** Dannzor has quit IRC
361 2019-07-31T18:11:40  <emilengler> jonatack: Well I tried the Unix grep but I searched for "Qt::CTRL" and "Qt::Key_L" I thought it was using a QShortcut or something similar
362 2019-07-31T18:17:52  *** reallll has joined #bitcoin-core-dev
363 2019-07-31T18:21:00  *** belcher has quit IRC
364 2019-07-31T18:24:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
365 2019-07-31T18:24:57  *** booyah has quit IRC
366 2019-07-31T18:26:05  *** booyah has joined #bitcoin-core-dev
367 2019-07-31T18:27:25  *** liberiga has joined #bitcoin-core-dev
368 2019-07-31T18:30:12  *** captjakk has joined #bitcoin-core-dev
369 2019-07-31T18:35:22  *** mdunnio has quit IRC
370 2019-07-31T18:40:18  *** kristapsk has quit IRC
371 2019-07-31T18:40:38  *** kristapsk has joined #bitcoin-core-dev
372 2019-07-31T18:45:33  *** mdunnio has joined #bitcoin-core-dev
373 2019-07-31T18:46:32  *** i2 has quit IRC
374 2019-07-31T18:53:02  *** queip has quit IRC
375 2019-07-31T18:55:20  *** harrigan has quit IRC
376 2019-07-31T19:01:14  *** queip has joined #bitcoin-core-dev
377 2019-07-31T19:04:52  *** captjakk has quit IRC
378 2019-07-31T19:05:27  *** captjakk has joined #bitcoin-core-dev
379 2019-07-31T19:06:02  *** jarthur has joined #bitcoin-core-dev
380 2019-07-31T19:06:32  *** mdunnio has quit IRC
381 2019-07-31T19:07:15  *** mdunnio has joined #bitcoin-core-dev
382 2019-07-31T19:10:05  *** captjakk has quit IRC
383 2019-07-31T19:13:16  *** sdupre has quit IRC
384 2019-07-31T19:13:29  *** sdupre has joined #bitcoin-core-dev
385 2019-07-31T19:15:15  *** jarthur has quit IRC
386 2019-07-31T19:15:16  *** sdupre has quit IRC
387 2019-07-31T19:20:19  *** davterra has quit IRC
388 2019-07-31T19:22:26  *** sdupre has joined #bitcoin-core-dev
389 2019-07-31T19:22:37  *** jonatack has quit IRC
390 2019-07-31T19:26:21  *** captjakk has joined #bitcoin-core-dev
391 2019-07-31T19:34:15  <phantomcircuit> sdaftuar, actually would that be right either? is it true we can't reorg backwards past an overwritten utxo entry?
392 2019-07-31T19:37:53  <sdaftuar> phantomcircuit: if you reorg past an overwritten utxo, then your utxo state is incorrect/different from if you never connected the block that did the overwrite
393 2019-07-31T19:39:44  *** davterra has joined #bitcoin-core-dev
394 2019-07-31T19:48:22  *** EagleTM has joined #bitcoin-core-dev
395 2019-07-31T19:51:51  *** luke-jr has quit IRC
396 2019-07-31T19:52:03  *** Chris_Stewart_5 has quit IRC
397 2019-07-31T19:52:35  *** luke-jr has joined #bitcoin-core-dev
398 2019-07-31T19:54:11  *** luke-jr has quit IRC
399 2019-07-31T19:55:25  *** luke-jr has joined #bitcoin-core-dev
400 2019-07-31T19:57:18  *** captjakk has quit IRC
401 2019-07-31T19:58:49  *** luke-jr has quit IRC
402 2019-07-31T20:00:56  *** luke-jr has joined #bitcoin-core-dev
403 2019-07-31T20:04:16  *** bitcoin-git has joined #bitcoin-core-dev
404 2019-07-31T20:04:16  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
405 2019-07-31T20:04:17  *** bitcoin-git has left #bitcoin-core-dev
406 2019-07-31T20:06:25  *** captjakk_ has joined #bitcoin-core-dev
407 2019-07-31T20:08:26  *** reallll is now known as belcher
408 2019-07-31T20:12:45  *** mdunnio has quit IRC
409 2019-07-31T20:12:53  *** luke-jr has quit IRC
410 2019-07-31T20:13:28  *** luke-jr has joined #bitcoin-core-dev
411 2019-07-31T20:17:11  *** luke-jr has quit IRC
412 2019-07-31T20:18:16  *** mdunnio has joined #bitcoin-core-dev
413 2019-07-31T20:18:36  *** luke-jr has joined #bitcoin-core-dev
414 2019-07-31T20:18:41  *** ezegom has quit IRC
415 2019-07-31T20:20:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
416 2019-07-31T20:21:51  *** luke-jr has quit IRC
417 2019-07-31T20:22:47  *** luke-jr has joined #bitcoin-core-dev
418 2019-07-31T20:30:07  *** luke-jr has quit IRC
419 2019-07-31T20:31:56  *** luke-jr has joined #bitcoin-core-dev
420 2019-07-31T20:36:35  *** luke-jr has quit IRC
421 2019-07-31T20:37:29  *** luke-jr has joined #bitcoin-core-dev
422 2019-07-31T20:46:50  *** davereikher has joined #bitcoin-core-dev
423 2019-07-31T20:51:37  *** belcher has quit IRC
424 2019-07-31T20:52:43  *** owowo has quit IRC
425 2019-07-31T20:55:17  *** ezegom has joined #bitcoin-core-dev
426 2019-07-31T20:56:05  *** hebasto has quit IRC
427 2019-07-31T20:57:54  *** owowo has joined #bitcoin-core-dev
428 2019-07-31T21:00:01  *** dougvann has quit IRC
429 2019-07-31T21:04:23  *** Waithamai1 has joined #bitcoin-core-dev
430 2019-07-31T21:07:47  *** davereikher has quit IRC
431 2019-07-31T21:10:54  *** AaronvanW has quit IRC
432 2019-07-31T21:11:50  *** AaronvanW has joined #bitcoin-core-dev
433 2019-07-31T21:15:56  <emilengler> When I call QTabWidget::widget where can I get the index in rpcconsole.cpp?
434 2019-07-31T21:18:40  *** liberiga has quit IRC
435 2019-07-31T21:21:22  *** Guyver2 has quit IRC
436 2019-07-31T21:25:52  *** Chris_Stewart_5 has quit IRC
437 2019-07-31T21:30:09  <phantomcircuit> hmm i was thinking we could drop the leveldb bloomfilter if the bip30 checks aren't running but actually that makes bogus transactions sent to us much more expensive to handle
438 2019-07-31T21:30:29  *** promag has joined #bitcoin-core-dev
439 2019-07-31T21:30:31  <phantomcircuit> currently mostly that's just cpu and bandwidth used, but without the bloomfilters it's potentially also disk access
440 2019-07-31T21:32:32  *** sdupre has quit IRC
441 2019-07-31T21:35:22  <phantomcircuit> and that type of transaction, missing utxo can't result in a peer being banned so it's an actual issue
442 2019-07-31T21:40:41  *** Raystonn has joined #bitcoin-core-dev
443 2019-07-31T21:42:01  <BlueMatt> #proposedmeetingtopic is transaction.nVersion signed or unsigned?
444 2019-07-31T21:43:09  <BlueMatt> dongcarl: ^ gets to handle that one :)
445 2019-07-31T21:50:36  <promag> emilengler: what are you trying to do?
446 2019-07-31T22:01:36  *** mzygar has quit IRC
447 2019-07-31T22:01:53  *** mdunnio has quit IRC
448 2019-07-31T22:03:28  *** ezegom has quit IRC
449 2019-07-31T22:04:05  *** ezegom has joined #bitcoin-core-dev
450 2019-07-31T22:05:26  *** bitcoin-git has joined #bitcoin-core-dev
451 2019-07-31T22:05:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7821821a23b6...5639d71a07db
452 2019-07-31T22:05:27  <bitcoin-git> bitcoin/master fa6fba3 MarcoFalke: test: Make local symbols in run_test members
453 2019-07-31T22:05:28  <bitcoin-git> bitcoin/master faf8318 MarcoFalke: test: Split fundrawtx test into subtests
454 2019-07-31T22:05:28  <bitcoin-git> bitcoin/master 5639d71 MarcoFalke: Merge #16293: test: Make test cases separate functions
455 2019-07-31T22:05:39  *** bitcoin-git has left #bitcoin-core-dev
456 2019-07-31T22:06:21  *** bitcoin-git has joined #bitcoin-core-dev
457 2019-07-31T22:06:22  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
458 2019-07-31T22:06:23  *** bitcoin-git has left #bitcoin-core-dev
459 2019-07-31T22:08:23  *** ezegom has quit IRC
460 2019-07-31T22:11:56  *** bitcoin-git has joined #bitcoin-core-dev
461 2019-07-31T22:11:56  <bitcoin-git> [bitcoin] achow101 opened pull request #16512: Shuffle inputs and outputs after joining psbts (master...joinpsbt-rand) https://github.com/bitcoin/bitcoin/pull/16512
462 2019-07-31T22:11:57  *** bitcoin-git has left #bitcoin-core-dev
463 2019-07-31T22:12:07  <emilengler> promag: I'm trying to check if the user is in a specific tab
464 2019-07-31T22:12:28  <promag> why?
465 2019-07-31T22:13:10  <emilengler> Because I want to add a shortcut which should only work in a specifc tab in the debug window
466 2019-07-31T22:13:17  <emilengler> In the console to be correct
467 2019-07-31T22:13:19  <emilengler> In bitcoin-qt
468 2019-07-31T22:13:37  <sipa> a shortcut to do what?
469 2019-07-31T22:14:05  <emilengler> I want to add a shortcut to close the debug window when the user is in the console
470 2019-07-31T22:14:13  <emilengler> Ctrl+D
471 2019-07-31T22:14:19  <emilengler> Like in any other terminal :P
472 2019-07-31T22:15:22  <promag> you mean close the dialog?
473 2019-07-31T22:15:32  <sipa> is there a close button?
474 2019-07-31T22:16:00  <promag> ESC closes (at least on mac)
475 2019-07-31T22:16:23  *** rex4539 has joined #bitcoin-core-dev
476 2019-07-31T22:16:43  <emilengler> Yes esc closes
477 2019-07-31T22:16:48  <sipa> emilengler: that seems confusing; to anyone not familiar with a unix console that wouldn't be natural, while every OS probably has its native keybinding already to close windows
478 2019-07-31T22:17:05  <emilengler> I'm thinking of adding a Ctrl+D beside the esc
479 2019-07-31T22:17:26  <emilengler> I always get confused for a second or so if I press Ctrl+D and nothing happens
480 2019-07-31T22:17:35  <emilengler> So I thought it would be a good addition
481 2019-07-31T22:17:43  <sipa> (feel free to ignore my comments, i never use the UI)
482 2019-07-31T22:17:47  <luke-jr> well, Ctrl-D is EOF, not "close window"
483 2019-07-31T22:17:54  * luke-jr wonders what happens if you Ctrl-D in a cmd.exe window
484 2019-07-31T22:18:28  <luke-jr> emilengler: if you do add it, it probably should only work if the text entry has focus specifically
485 2019-07-31T22:18:39  <sipa> i guess Ctrl-J and Ctrl-M should also newline then
486 2019-07-31T22:19:15  *** ezegom has joined #bitcoin-core-dev
487 2019-07-31T22:19:28  <emilengler> luke-jr: Does EOF stops a process?
488 2019-07-31T22:19:38  <emilengler> In common shells it does
489 2019-07-31T22:19:42  <sipa> emilengler: no, it sends EOF on stdin
490 2019-07-31T22:19:55  <sipa> which many programs use a signal to quit
491 2019-07-31T22:20:03  <emilengler> ok, thanks
492 2019-07-31T22:20:19  <sipa> Ctrl-J sends newline, Ctrl-A sends BELL, ...
493 2019-07-31T22:20:30  <sipa> there are a bunch of other control characters you can compose that way
494 2019-07-31T22:21:00  <emilengler> sipa: You might be right but Ctrl+L is also implemented
495 2019-07-31T22:21:07  <emilengler> Is this a control character as well?
496 2019-07-31T22:21:10  <sipa> yes
497 2019-07-31T22:21:27  <sipa> emilengler: http://www.asciitable.com/
498 2019-07-31T22:21:33  <promag> emilengler: even if your idea is accepted it won't have the same behavior
499 2019-07-31T22:21:47  <emilengler> But the most common control-chars are Ctrl+D and Ctrl+L (at least in my case)
500 2019-07-31T22:22:06  <emilengler> promag: Why because it won't use a key event or because it wont send an EOF?
501 2019-07-31T22:22:15  <emilengler> QKeyEvent
502 2019-07-31T22:22:32  <sipa> emilengler: L = 12th position in alphabet, Ctrl-L = ASCII 12 = form feed = clear page
503 2019-07-31T22:22:52  <sipa> emilengler: D = 4th position in alphabet, Ctrl-D = ASCII 4 = end of transmission
504 2019-07-31T22:23:05  <sipa> emilengler: J = 10th position in alphabet, Ctrl-D = ASCII 10 = new line
505 2019-07-31T22:23:13  <sipa> eh, Ctrl-J
506 2019-07-31T22:23:24  <emilengler> sipa: thank you this explains a lot of stuff but Ctrl+L does not transmit this singal IIRC
507 2019-07-31T22:23:33  <promag> emilengler: because you can't "terminate" the bitcoin-qt terminal
508 2019-07-31T22:23:41  <sipa> emilengler: i don't know what you mean
509 2019-07-31T22:23:54  <promag> emilengler: you would just hide/close the dialog
510 2019-07-31T22:24:21  <emilengler> promag: But you can close the window the idea was a "synonym" for the esc
511 2019-07-31T22:24:23  <promag> I'm sure you can find other stuff to improve on the gui
512 2019-07-31T22:25:05  <emilengler> You might be right :) but when we already have Ctrl+L why not Ctrl+D then
513 2019-07-31T22:27:08  <promag> feel free to submit the PR, I just think that on the gui ESC is more natural, people are used to close dialogs with ESC
514 2019-07-31T22:27:32  *** luke-jr has quit IRC
515 2019-07-31T22:28:00  <sipa> emilengler: can't you add a shortcut to a button in Qt? if so, that should be enough
516 2019-07-31T22:28:11  <sipa> without trying to infer what tab you're on
517 2019-07-31T22:28:11  *** luke-jr has joined #bitcoin-core-dev
518 2019-07-31T22:28:20  *** mdunnio has joined #bitcoin-core-dev
519 2019-07-31T22:28:40  *** mdunnio has quit IRC
520 2019-07-31T22:29:45  *** bitcoin-git has joined #bitcoin-core-dev
521 2019-07-31T22:29:46  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16513: Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513
522 2019-07-31T22:29:47  *** bitcoin-git has left #bitcoin-core-dev
523 2019-07-31T22:29:58  <emilengler> promag: Sure but for people who are there whole day in terminal emulators Ctrl+D is more natural I think
524 2019-07-31T22:30:16  <emilengler> sipa: Sure but there is no close button in the qt gui
525 2019-07-31T22:30:22  <emilengler> Only the window manager close button
526 2019-07-31T22:30:47  <sipa> yeah ok
527 2019-07-31T22:30:56  <sipa> and adding one would be redundant
528 2019-07-31T22:31:50  <promag> not sure if it would work but try adding a QAction with the respective shortcut to the tab
529 2019-07-31T22:33:23  <emilengler> promag: Already read that something like this is possible but tbh I'm a bloody beginner in Qt. I'm completely unable to design something that's why I always stick to cli programming
530 2019-07-31T22:33:54  <sipa> haha
531 2019-07-31T22:33:56  <sipa> sounds familiar
532 2019-07-31T22:34:25  *** luke-jr has quit IRC
533 2019-07-31T22:35:13  *** luke-jr has joined #bitcoin-core-dev
534 2019-07-31T22:35:56  *** bitcoin-git has joined #bitcoin-core-dev
535 2019-07-31T22:35:56  <bitcoin-git> [bitcoin] promag opened pull request #16514: gui: Remove unused RPCConsole::tabFocus (master...2019-07-remove-unused-tabfocus) https://github.com/bitcoin/bitcoin/pull/16514
536 2019-07-31T22:35:57  *** bitcoin-git has left #bitcoin-core-dev
537 2019-07-31T22:37:17  <tryphe> emilengler, i've been using Qt for 20 years and i still prefer cli :p
538 2019-07-31T22:40:49  <emilengler> tryphe: You may love or may hate gui design there is nothing inbetween
539 2019-07-31T22:44:24  *** Zenton has joined #bitcoin-core-dev
540 2019-07-31T22:44:48  <tryphe> emilengler, to me, a cli is somewhere between having a gui and no interface, where later on you'd just build the gui on the same interface the cli uses
541 2019-07-31T22:46:06  *** captjakk_ has quit IRC
542 2019-07-31T22:46:10  <emilengler> tryphe: It depends what do you mean by cli something like an interactive shell (like the openbsd installer), a curses(-like) application or just a program which you start with some args and prints log infos in the console
543 2019-07-31T22:46:34  <tryphe> emilengler, yes, all of those
544 2019-07-31T22:47:49  <emilengler> tryphe: Same in my definition a cli application is everything which displays text in a console
545 2019-07-31T22:55:03  *** AaronvanW has quit IRC
546 2019-07-31T22:56:37  *** jnewbery_ has quit IRC
547 2019-07-31T22:56:40  *** sdaftuar has quit IRC
548 2019-07-31T22:56:49  *** bitcoin-git has joined #bitcoin-core-dev
549 2019-07-31T22:56:50  <bitcoin-git> [bitcoin] promag opened pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515
550 2019-07-31T22:56:50  *** bitcoin-git has left #bitcoin-core-dev
551 2019-07-31T22:57:57  <promag> emilengler: I can add you as co author if you like, or if you prefer you can pick that commit, re-work it and submit another pr (I'll close mine in that case)
552 2019-07-31T22:58:02  *** jnewbery has joined #bitcoin-core-dev
553 2019-07-31T22:58:05  *** sdaftuar has joined #bitcoin-core-dev
554 2019-07-31T23:09:47  *** Bullitje_enable has joined #bitcoin-core-dev
555 2019-07-31T23:12:31  <promag> fanquake: https://github.com/bitcoin/bitcoin/pull/16502#event-2522283884 can be removed
556 2019-07-31T23:12:57  *** Bullitje has quit IRC
557 2019-07-31T23:15:02  *** emilengler has quit IRC
558 2019-07-31T23:19:23  *** emilengler has joined #bitcoin-core-dev
559 2019-07-31T23:20:16  <emilengler> promag: Sorry my internet connection died, what do you meant?
560 2019-07-31T23:20:25  <emilengler> Do you mean #16515
561 2019-07-31T23:20:29  <gribble> https://github.com/bitcoin/bitcoin/issues/16515 | gui: Close console with CTRL+D ala terminal by promag · Pull Request #16515 · bitcoin/bitcoin · GitHub
562 2019-07-31T23:20:41  <promag> y
563 2019-07-31T23:21:17  <emilengler> Ok, I will take a look at it
564 2019-07-31T23:21:26  <emilengler> But thank you a lot :)
565 2019-07-31T23:22:44  <fanquake> promag: yep
566 2019-07-31T23:23:30  <emilengler> Ok I'm compiling it right now, will write a comment then
567 2019-07-31T23:24:25  <emilengler> How good that I deleted my already compiled dir -.-
568 2019-07-31T23:25:55  *** ptiyoyip has joined #bitcoin-core-dev
569 2019-07-31T23:26:13  <promag> how do you build?
570 2019-07-31T23:27:31  <emilengler> The classic way, ./autogen.sh; ./configure; make
571 2019-07-31T23:29:13  *** dgfhdfg has quit IRC
572 2019-07-31T23:29:40  <promag> emilengler: make -j8 -C src/qt bitcoin-qt
573 2019-07-31T23:30:26  <emilengler> promag: Yeah I was more git oriented like cloning your branch it my local repo
574 2019-07-31T23:31:01  <emilengler> Maybe with git remote add promap https://github.com/promag/bitcoin.git; git fetch promag; git rebase promag/yourbranch yourbranch
575 2019-07-31T23:31:21  <emilengler> But now it is too late already
576 2019-07-31T23:34:20  <promag> emilengler: mayeb read https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#reference-prs-easily-with-refspecs
577 2019-07-31T23:39:03  <emilengler> thx
578 2019-07-31T23:55:10  *** bitcoin-git has joined #bitcoin-core-dev
579 2019-07-31T23:55:11  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5639d71a07db...25f0edd59fee
580 2019-07-31T23:55:11  <bitcoin-git> bitcoin/master fa2f991 Torkel Rogstad: doc: add note on precedence of options in bitcoin.conf
581 2019-07-31T23:55:12  <bitcoin-git> bitcoin/master 25f0edd fanquake: Merge #16448: doc: add note on precedence of options in bitcoin.conf
582 2019-07-31T23:55:23  *** bitcoin-git has left #bitcoin-core-dev
583 2019-07-31T23:56:11  *** bitcoin-git has joined #bitcoin-core-dev
584 2019-07-31T23:56:11  <bitcoin-git> [bitcoin] fanquake merged pull request #16448: doc: add note on precedence of options in bitcoin.conf (master...options_bitocin_conf) https://github.com/bitcoin/bitcoin/pull/16448
585 2019-07-31T23:56:24  *** bitcoin-git has left #bitcoin-core-dev
586 2019-07-31T23:58:53  *** michaelfolkson has joined #bitcoin-core-dev