12019-10-10T00:00:01  *** midnightmagic1 has quit IRC
  22019-10-10T00:05:24  *** laptop500 has quit IRC
  32019-10-10T00:06:50  *** captjakk has joined #bitcoin-core-dev
  42019-10-10T00:09:23  *** captjakk has quit IRC
  52019-10-10T00:09:36  *** captjakk has joined #bitcoin-core-dev
  62019-10-10T00:10:12  *** captjakk has quit IRC
  72019-10-10T00:10:23  *** captjakk has joined #bitcoin-core-dev
  82019-10-10T00:11:44  *** captjakk has joined #bitcoin-core-dev
  92019-10-10T00:13:39  *** jkczyz has quit IRC
 102019-10-10T00:15:38  *** captjakk has quit IRC
 112019-10-10T00:16:29  *** HaeB1 has joined #bitcoin-core-dev
 122019-10-10T00:19:49  *** nosss2 has quit IRC
 132019-10-10T00:22:59  *** jkczyz has joined #bitcoin-core-dev
 142019-10-10T00:23:19  *** arik_ has quit IRC
 152019-10-10T00:36:27  *** m1rror8955363887 has quit IRC
 162019-10-10T00:37:45  *** jkczyz has quit IRC
 172019-10-10T00:45:55  *** arik_ has joined #bitcoin-core-dev
 182019-10-10T00:57:23  *** jeremyrubin has joined #bitcoin-core-dev
 192019-10-10T01:05:40  *** arik_ has quit IRC
 202019-10-10T01:06:39  *** ddustin has quit IRC
 212019-10-10T01:07:27  *** ddustin has joined #bitcoin-core-dev
 222019-10-10T01:09:53  *** jkczyz has joined #bitcoin-core-dev
 232019-10-10T01:10:29  *** arik_ has joined #bitcoin-core-dev
 242019-10-10T01:11:37  *** ddustin has quit IRC
 252019-10-10T01:18:07  *** arik_ has quit IRC
 262019-10-10T01:20:24  *** michaelfolkson has joined #bitcoin-core-dev
 272019-10-10T01:24:07  *** michaelfolkson has quit IRC
 282019-10-10T01:32:05  *** arik_ has joined #bitcoin-core-dev
 292019-10-10T01:34:24  *** arik_ has quit IRC
 302019-10-10T01:46:32  *** jkczyz has quit IRC
 312019-10-10T01:51:39  *** jungly has quit IRC
 322019-10-10T01:52:55  *** jungly has joined #bitcoin-core-dev
 332019-10-10T01:56:29  *** Emcy has quit IRC
 342019-10-10T02:00:54  *** Emcy has joined #bitcoin-core-dev
 352019-10-10T02:08:13  *** emilengler_ has joined #bitcoin-core-dev
 362019-10-10T02:08:52  *** brianhoffman has joined #bitcoin-core-dev
 372019-10-10T02:09:58  *** emilengler has quit IRC
 382019-10-10T02:15:00  *** arik_ has joined #bitcoin-core-dev
 392019-10-10T02:42:39  *** Aaronvan_ has quit IRC
 402019-10-10T02:50:36  *** behradkhodayar has joined #bitcoin-core-dev
 412019-10-10T02:50:51  *** berndj has quit IRC
 422019-10-10T02:55:15  *** berndj has joined #bitcoin-core-dev
 432019-10-10T02:56:38  *** arik_ has quit IRC
 442019-10-10T02:57:45  *** Bullit has joined #bitcoin-core-dev
 452019-10-10T02:59:45  *** Bullit has joined #bitcoin-core-dev
 462019-10-10T03:00:02  *** HaeB1 has quit IRC
 472019-10-10T03:00:16  *** Bullit has quit IRC
 482019-10-10T03:00:52  *** Bullit has joined #bitcoin-core-dev
 492019-10-10T03:00:57  *** baldur has quit IRC
 502019-10-10T03:08:51  *** jtimon has quit IRC
 512019-10-10T03:13:31  *** baldur has joined #bitcoin-core-dev
 522019-10-10T03:18:01  *** voet has joined #bitcoin-core-dev
 532019-10-10T03:26:26  *** behradkhodayar has quit IRC
 542019-10-10T03:39:17  *** fox2p has quit IRC
 552019-10-10T03:39:57  *** justanotheruser has quit IRC
 562019-10-10T03:40:58  *** fox2p has joined #bitcoin-core-dev
 572019-10-10T03:45:00  *** justanotheruser has joined #bitcoin-core-dev
 582019-10-10T04:01:38  *** nosss2 has joined #bitcoin-core-dev
 592019-10-10T04:31:56  *** Victor_sueca has joined #bitcoin-core-dev
 602019-10-10T04:34:33  *** Victorsueca has quit IRC
 612019-10-10T05:01:50  *** nosss2 has quit IRC
 622019-10-10T05:07:10  *** Randolf has joined #bitcoin-core-dev
 632019-10-10T05:08:26  *** zenogais has quit IRC
 642019-10-10T05:35:51  *** shesek has quit IRC
 652019-10-10T05:36:15  *** shesek has joined #bitcoin-core-dev
 662019-10-10T05:41:44  *** Karyon has quit IRC
 672019-10-10T05:43:11  *** Karyon has joined #bitcoin-core-dev
 682019-10-10T05:45:11  *** Eagle[TM] has quit IRC
 692019-10-10T05:45:23  *** fox2p_ has joined #bitcoin-core-dev
 702019-10-10T05:46:57  *** fox2p has quit IRC
 712019-10-10T06:00:02  *** voet has quit IRC
 722019-10-10T06:06:37  <kallewoof> I really don't like maintainers closing PRs in author's faces. Specifically https://github.com/bitcoin/bitcoin/pull/16681#issuecomment-539694699 -- can we just not do this, ever? I'd rather have 1000 open PRs than this kind of power abuse.
 732019-10-10T06:08:02  <kallewoof> If the PR is clearly wrong, that is one thing of course, but closing a PR in the middle of a discussion sends the wrong message.
 742019-10-10T06:09:54  <luke-jr> no kidding
 752019-10-10T06:10:24  <luke-jr> otoh, the author did say to close it in that example :p
 762019-10-10T06:11:07  <luke-jr> also rather annoying stuff I'm actively maintaining gets closed because I'm not basing them on master anymore (because why bother when nobody reviews?)
 772019-10-10T06:11:11  <kallewoof> It was a question which, if it ended up being the overall conclusion, would result in him, himself, closing it, I think.
 782019-10-10T06:12:19  <kallewoof> luke-jr: I think that's bad too, but I also think we as PR authors need to kind of champion our PRs towards merging more (I myself suck at this)
 792019-10-10T06:12:59  <kallewoof> Maintainers closing a PR with no updates for years I can kind of get, but this was a relatively new PR with active discussion from multiple people.
 802019-10-10T06:14:00  <luke-jr> I update most of mine regularly - but often just on top of the most recent stable branch.
 812019-10-10T06:14:10  <luke-jr> (so always under a year stale)
 822019-10-10T06:15:36  <kallewoof> I for one consider a PR unreviewable if it is unmergable into master, but maybe I'm mistaken on that.
 832019-10-10T06:16:03  <Randolf> I've noticed this problem with PRs getting closed in the middle of discussions in other projects too.  It's horrible.
 842019-10-10T06:16:16  <kallewoof> There's also the fact that PR authors have to convince people to review their PRs. I honestly have no good solution for that one. And your code can be a bit like Matt's... scary and hard to review.
 852019-10-10T06:16:36  <Randolf> Perhaps it's a limitation of how GitHub works.
 862019-10-10T06:17:46  <kallewoof> Randolf: Why? Maintainers assume authors can't make the judgement call. That's all there is to it, IMO.
 872019-10-10T06:18:00  *** ericb2 has joined #bitcoin-core-dev
 882019-10-10T06:18:25  *** ericb2 is now known as Guest69975
 892019-10-10T06:18:32  *** ajonas has quit IRC
 902019-10-10T06:20:19  <Randolf> kallewoof: If a PR is actively being discussed though, then shouldn't it generally be kept open at least for a while?
 912019-10-10T06:21:03  <luke-jr> kallewoof: there's been a PR review club thing attempted for a few months. maybe more of us need to get invovled in it
 922019-10-10T06:21:15  <luke-jr> Randolf: I think we're all agreement on that
 932019-10-10T06:21:27  <kallewoof> ^ Yep
 942019-10-10T06:22:11  <kallewoof> luke-jr: Yeah, that is a separate problem (I guess), but definitely. My bitcoin dev time is currently on the low end for a bit, but once I get time back I'll make that effort for sure.
 952019-10-10T06:26:48  <cncr04s> whos in charge of what gets committed?
 962019-10-10T06:27:54  <cncr04s> or even the direction of what each release is trying to acomplish
 972019-10-10T06:28:55  <luke-jr> in theory, nobody; in practice, only stuff with interest from quite a few devs goes anywhere
 982019-10-10T06:30:46  <Randolf> That's like a popular vote ... like a democracy.
 992019-10-10T06:31:54  <luke-jr> not really
1002019-10-10T06:32:43  <Randolf> Without the voting part.
1012019-10-10T06:33:01  <luke-jr> and without the masses being involved
1022019-10-10T06:36:09  <Randolf> Yeah, a much smaller population in this case.
1032019-10-10T06:36:35  <Bullit> Oh is the problem that command structure is distributed buying options cause that aint a effect that we can measure
1042019-10-10T06:37:41  <warren> During tomorrow's IRC meeting I'm bringing up the topic of three possible migration paths for the dev lists.
1052019-10-10T06:37:57  <warren> 1) Google Groups - Eliminates the maintenance and DoS headache. But people had serious concerns about this option a few years ago due to it being a centralized service. An informal poll of developers early this year indicated most people prefer that it just work and they don't want to think about how. Perhaps people would care less about this now.
1062019-10-10T06:38:09  <warren> 2) mailman2 hosted by a non-profit known for hosting FOSS projects in the past decades. For sensitivity reasons can't talk details about this as it might blow up the proposal. The non-profit needs community donations generally to continue their good work.
1072019-10-10T06:39:21  <sipa> warren: i really don't think the bitcoin core project meeting is appropriate for thos
1082019-10-10T06:39:28  <warren> 3) self-hosted mailman2 - We have offers of donated dedicated servers but that is nowhere near the hard part. If you have tried to properly maintain a MTA you know it requires a fair bit of experience and ongoing effort. When you deliver mail to numerous providers it is far too easy to be induced by an attacker to forward spam and get your IP on blacklists. Other attacks include invalid subscriber flooding and other ways of causing bounce
1092019-10-10T06:39:28  <warren> floods and resource exhaustion. A properly maintained mail server can mitigate this but you always have to adjust strategies to counter the next abuse method. This option would require an ongoing cost to compensate a professional sysadmin who is intimately familiar with this.
1102019-10-10T06:39:44  <warren> sipa: how the hell else am I supposed to get people to pay attention?
1112019-10-10T06:40:15  <warren> We have somebody in mind with experience to do #3 but he acknowledges this is a headache enough that we should really try the #2 or #1 method. I think several of us would prefer that we just moved it to Google Groups where we could probably just forget about DoS and maintenance headaches for the indefinite future.
1122019-10-10T06:40:18  <gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
1132019-10-10T06:40:19  <Randolf> warren: With Google Groups, are you thinking NNTP or Google's proprietary Groups?  (I know that NNTP can support both moderated and unmoderated newsgroups.)
1142019-10-10T06:40:21  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
1152019-10-10T06:40:24  <warren> Note: Other list management platforms like groups.io were seen as unacceptable because of how they munge message-id. I *think* Google Groups doesn't do that but we it to be tested.
1162019-10-10T06:40:24  <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
1172019-10-10T06:40:34  <sipa> warren: well it's a discussion to be had on the ML, not here
1182019-10-10T06:40:44  <cncr04s> I use mailgun to send emails
1192019-10-10T06:41:11  <luke-jr> warren: Google has a history of sometimes blocking non-big-company mail servers
1202019-10-10T06:41:29  <warren> It's *hard* in part because I literally can't talk about some details in public as it may scare away the most ideal host.
1212019-10-10T06:41:54  <luke-jr> [06:39:44] <warren> sipa: how the hell else am I supposed to get people to pay attention? <-- if posting to the ML doesn't do it, maybe there's no point?
1222019-10-10T06:43:04  <luke-jr> to rephrase: ML hosting only matters if people are using the ML; in which case, posting to the ML is probably the best way to get the eyes needed
1232019-10-10T06:43:14  <sipa> exactly
1242019-10-10T06:43:43  <warren> The developers have made it clear after several opportunities where I've asked for 1) help 2) opinions that they simply just want something that works. But we don't do anything here with a tiny cabal who decides for everyone else. Also we're volunteers too doing a part that other people find necessary but are annoyed to hear about?
1252019-10-10T06:43:58  <Randolf> warren: I've been doing hosting since about the mid-1990s, running our own mail servers, web servers, etc.  I'd be willing to host mailman3 with PostgreSQL in the back-end.  (I'd need to find out more details from you on requirements, etc.)  (We have IPv4 and IPv6 support.)
1262019-10-10T06:44:11  <warren> Randolf: mailman3 is unacceptable
1272019-10-10T06:44:23  <warren> Randolf: we
1282019-10-10T06:44:25  <warren> we
1292019-10-10T06:44:29  <warren> grr...
1302019-10-10T06:44:32  <Randolf> warren: Okay.  I thought you mentioned mailman, but no problem.  I actually don't use mailman anywhere.
1312019-10-10T06:44:56  <luke-jr> Randolf: mailman2, not 3 ; apparently 3 has serious issues
1322019-10-10T06:44:58  <warren> you wouldn't know how problematic this stuff is if you haven't spent years trying to use it
1332019-10-10T06:45:02  <Randolf> Okay.
1342019-10-10T06:45:09  <Bullit> <gribble> rbitcoin: Visa processes 1,700 transactions per second. The lighting network is capable of processing millions to billions of transactions per second.  <<< Who´s the electrican in AE
1352019-10-10T06:45:40  <sipa> i know there is a bunch of overlap, but it really feels wrong to discuss or even determine the fate of the mailing list (which is supposed to be an indistry wide forum) in a bitcoin core specific place
1362019-10-10T06:46:10  <Randolf> warren: Well, I'm familiar with the anti-spam community as I've been involved in that for a very long time (I used to participate in NANAE, but mostly just lurk once in a while now).
1372019-10-10T06:46:11  <sipa> even if succesful, that's a bery bad outcome
1382019-10-10T06:46:17  <warren> the only lists that aren't dead are bitcoin-core-dev and lightning-dev
1392019-10-10T06:46:27  <sipa> what?
1402019-10-10T06:46:28  <luke-jr> bitcoin-dev you mean
1412019-10-10T06:46:37  <warren> oh oops ...
1422019-10-10T06:46:46  <sipa> bitcoin-core-dev has no traffic at all afaik
1432019-10-10T06:46:58  <luke-jr> well, it has rc announcements
1442019-10-10T06:46:59  <sipa> as we do everything on github
1452019-10-10T06:47:07  <sipa> right, that's it
1462019-10-10T06:47:20  <Bullit> Strange call on this turkish man
1472019-10-10T06:47:20  <Randolf> warren: If you find that you need hosting for mailman2 (or whatever you need), please know that I'm willing to volunteer.
1482019-10-10T06:47:41  <sipa> i don't think the question is so much who will maintain it
1492019-10-10T06:47:48  <sipa> rather what organization will control it
1502019-10-10T06:48:04  <Randolf> sipa: Having things decentralized is important.
1512019-10-10T06:48:13  <sipa> Randolf: yes, exactly
1522019-10-10T06:48:14  <luke-jr> sipa: I think it's actually both :/
1532019-10-10T06:48:36  <sipa> sure, but i'm sure funds can be found to pay a competent maintainer
1542019-10-10T06:48:43  <sipa> if necessary
1552019-10-10T06:48:59  <warren> Randolf: Open Source anti-spam sucking, needing constant hand tuning, and perpetually being poorly maintained in FOSS I have some authority on the matter. I tried and failed to keep spamassassin from being totally dead for a few years. It stressed me out and I gave up ~2012. Other people picked it up after me but this stuff is perpetually under-resourced, and thankless work. anti-spam is also only a small part of the problem.
1562019-10-10T06:49:42  <luke-jr> since it's moderated anyway, do we even need anti-spam?
1572019-10-10T06:49:46  <warren> sipa: hence LF agreeing to host it seemed perfect in 2015 because nobody questioned their neutrality.
1582019-10-10T06:50:00  <luke-jr> worst case something gets through the antispam to the mods who reject it
1592019-10-10T06:50:11  <sipa> but imho either we find a neutral third party to run it (like lf!), or we'll have to pick some big centralized company
1602019-10-10T06:50:14  <warren> luke-jr: not even the largest problem, when the rest of it is poorly maintained it goes haywire.
1612019-10-10T06:50:29  <Randolf> warren: Yeah, I'm familiar with that.  It's a bit of an art and a science to keep anti-spam stuff working well for clients, blocking the junk without flagging legitimate stuff.  Spammers suck.
1622019-10-10T06:50:35  <sipa> even the answer of "we run our self hsoted instance" runs into the question of firdt defining who "we" is
1632019-10-10T06:51:02  <warren> LF doesn't want to do list hosting at all anymore, they were willing to pay to outsource our lists to groups.io (which we found to be technically unacceptable, we're not the only dev lists who refused to move there)
1642019-10-10T06:51:20  <warren> The other orgs however are uncontroversial and do not attract DoS attacks
1652019-10-10T06:51:55  <warren> LF asked us to migrate 2 years ago, they will eventually kick us off
1662019-10-10T06:53:44  <warren> I've since learned from that sysadmin that mailman2 doesn't suck nearly as much as I've been lead to believe. fdo and a few others maintain modern versions and with a non-upstreamable CAPTCHA it stops one of the crippling attacks that knocked LF's mailman offline for weeks.
1672019-10-10T06:54:32  *** Karyon has quit IRC
1682019-10-10T06:55:12  <sipa> warren: well, i really think this discussion should move to the list
1692019-10-10T06:55:20  <sipa> i promise to respond with my thoughts
1702019-10-10T06:55:52  <warren> OK, I'm meeting kanzure tomorrow or Friday-ish to write all this down together. I'm taking time off "work" to focus on this.
1712019-10-10T06:56:39  <warren> sorry for expression my frustration here.
1722019-10-10T06:56:43  <sipa> warren: also, you should not feel bad aboit sending a "this is what i've tried, but i've been unable to find an acceptable solution, i want to work on other things" response
1732019-10-10T06:56:57  <luke-jr> looks like mailman2 had an upstream release a year ago
1742019-10-10T06:57:22  *** Victor_sueca has quit IRC
1752019-10-10T06:57:37  <Randolf> How much volume does the current setup of the mailing lists get?
1762019-10-10T06:58:42  <warren> Not much. It's mostly attacks that succeeded in knocking the servers offline with swap storms and the OOM killer mainly because they stopped trying to maintain their list server.
1772019-10-10T06:58:59  <warren> They "fixed" it early 2019 by blackholing all bounces.
1782019-10-10T06:59:47  <warren> That means the server is incapable of deliverying mail to several large providers who perma-banned the IP.
1792019-10-10T07:00:34  <warren> My information is likely incomplete because it's only bits and pieces they told me. They clearly don't want to deal with this anymore.
1802019-10-10T07:00:42  *** astro has quit IRC
1812019-10-10T07:00:56  *** Karyon has joined #bitcoin-core-dev
1822019-10-10T07:01:02  <Randolf> The old block-and-forget routine.  It can be worse than being listed in SPEWS (while it was still running).
1832019-10-10T07:02:16  <warren> I'm sleeping. I am again mentioning that there exists a temporary channel if people want to discuss, give opinions or help test stuff for the list migration. Ask me in PM for an invite if you are interested.
1842019-10-10T07:03:36  *** bitcoin-git has joined #bitcoin-core-dev
1852019-10-10T07:03:36  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc7e721d97dc...b265ffe32371
1862019-10-10T07:03:37  <bitcoin-git> bitcoin/master f33efa8 Luke Dashjr: GUI: Restore RPC Console to non-wallet tray icon menu
1872019-10-10T07:03:37  <bitcoin-git> bitcoin/master b265ffe Jonas Schnelli: Merge #15023: GUI: Restore RPC Console to non-wallet tray icon menu
1882019-10-10T07:03:39  *** bitcoin-git has left #bitcoin-core-dev
1892019-10-10T07:03:40  *** promag_ has quit IRC
1902019-10-10T07:04:11  *** bitcoin-git has joined #bitcoin-core-dev
1912019-10-10T07:04:11  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b265ffe32371...5cb1d938a1c9
1922019-10-10T07:04:12  <bitcoin-git> bitcoin/master 091747b João Barbosa: gui: Add shortcuts for tab tools
1932019-10-10T07:04:12  <bitcoin-git> bitcoin/master 5cb1d93 Jonas Schnelli: Merge #15756: gui: Add shortcuts for tab tools
1942019-10-10T07:04:14  *** bitcoin-git has left #bitcoin-core-dev
1952019-10-10T07:04:30  *** bitcoin-git has joined #bitcoin-core-dev
1962019-10-10T07:04:30  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15023: GUI: Restore RPC Console to non-wallet tray icon menu (master...gui_node_rpcconsole) https://github.com/bitcoin/bitcoin/pull/15023
1972019-10-10T07:04:32  *** bitcoin-git has left #bitcoin-core-dev
1982019-10-10T07:04:51  *** bitcoin-git has joined #bitcoin-core-dev
1992019-10-10T07:04:51  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15756: gui: Add shortcuts for tab tools (master...2019-04-tools-shortcuts) https://github.com/bitcoin/bitcoin/pull/15756
2002019-10-10T07:04:53  *** bitcoin-git has left #bitcoin-core-dev
2012019-10-10T07:16:01  *** astro has joined #bitcoin-core-dev
2022019-10-10T07:21:26  *** Victorsueca has joined #bitcoin-core-dev
2032019-10-10T07:21:32  *** Zero-1729 has joined #bitcoin-core-dev
2042019-10-10T07:22:53  *** Zero-1729 has quit IRC
2052019-10-10T07:38:25  *** b10c has joined #bitcoin-core-dev
2062019-10-10T07:38:55  *** bitcoin-git has joined #bitcoin-core-dev
2072019-10-10T07:38:55  <bitcoin-git> [bitcoin] practicalswift opened pull request #17093: tests: Add fuzzing harness for various CTx{In,Out} related functions (master...fuzzers-txin-txout) https://github.com/bitcoin/bitcoin/pull/17093
2082019-10-10T07:38:58  *** bitcoin-git has left #bitcoin-core-dev
2092019-10-10T07:43:04  *** marcoagner has joined #bitcoin-core-dev
2102019-10-10T07:51:12  *** SiAnDoG has joined #bitcoin-core-dev
2112019-10-10T07:55:57  <wumpus> if something isn't going to be merged, maintainers are completely in their right to close a PR, if anything keeping it open gives the author false hope
2122019-10-10T07:56:26  <wumpus> for better or worse it's the maintainers that need to make that kind of decisions sometimes
2132019-10-10T07:57:20  <wumpus> if you'd rather have 1000 PRs open, that's up to you in your own project but it's not how bitcoin core is run, we try to actively keep track of open PRs
2142019-10-10T07:58:25  <wumpus> that's not specifically about #16681, btw, you're free to disagree with a specific decision, but IMO we're not going to change our github way of working because of it
2152019-10-10T07:58:27  <gribble> https://github.com/bitcoin/bitcoin/issues/16681 | Tests: Use self.chain instead of regtest in all current tests by jtimon · Pull Request #16681 · bitcoin/bitcoin · GitHub
2162019-10-10T08:01:37  <wumpus> warren: for what it's worth, I still prefer a discourse forum to any kind of mailing list, tbh, and it can be self-hosted too
2172019-10-10T08:01:51  <wumpus> google groups is terrible
2182019-10-10T08:06:54  *** TheRec has quit IRC
2192019-10-10T08:06:56  <wumpus> bitcoin-core-dev is just an announcement list, we could do without it, there are plenty of other ways to announce RCs and versions (we used to have a "sendy" instance for announcements and that broke, too, mail is just awful nowadays)
2202019-10-10T08:13:11  <kallewoof> wumpus: I 100% agree with you. The only problem here is that the maintainer has no way of knowing whether something is or isn't going to get merged. Unless the maintainer decides, in which case the maintainer owns bitcoin core and we can all just go home now.
2212019-10-10T08:14:02  <wumpus> it's a lot more subtle than that, and I'd agree with you in case of consensus changes and such
2222019-10-10T08:14:25  <wumpus> but MarcoFalke is tests maintainer, for better or worse he has the last vote what goes into the test framework
2232019-10-10T08:15:33  *** promag has joined #bitcoin-core-dev
2242019-10-10T08:16:36  <kallewoof> wumpus: side question, but where is this information to be found? (who maintains what, I mean)
2252019-10-10T08:17:04  <wumpus> I think there needs to be some kind of direction in those things, to make progress, and that also means they can make mistakes, and you're free to disagree with them and start a discussion like this, but I don't like the way you do this now
2262019-10-10T08:17:22  <wumpus> like generalize immediately
2272019-10-10T08:18:18  <kallewoof> this has been on my mind for some time, but maybe you're right that I'm overgeneralizing. Apologies.
2282019-10-10T08:18:32  <wumpus> kallewoof: currently nowhere, would be useful to have a CODEOWNERS fiel https://github.blog/2017-07-06-introducing-code-owners/
2292019-10-10T08:19:11  <kallewoof> Ooo... didn't know that feature existed. Neat.
2302019-10-10T08:26:10  *** laptop500 has joined #bitcoin-core-dev
2312019-10-10T08:27:38  *** laptop500 has quit IRC
2322019-10-10T08:34:31  *** face has joined #bitcoin-core-dev
2332019-10-10T08:39:11  <wumpus> kallewoof: anyhow if #16681 matters to you and you want to see it merged, just pitch in there directly
2342019-10-10T08:39:12  <jonatack> kallewoof: IIRC the maintainer roles were mentioned in one of the core.dev transcripts from last June, though from observing interaction in the repository the roles seem fairly clear
2352019-10-10T08:39:13  <gribble> https://github.com/bitcoin/bitcoin/issues/16681 | Tests: Use self.chain instead of regtest in all current tests by jtimon · Pull Request #16681 · bitcoin/bitcoin · GitHub
2362019-10-10T08:40:32  <wumpus> people haven't done that, it seems everyone is a bit ~0 about it (or slightly against it), no one is super enthousiatic about the change yet, which might be enough to get it merged anyway
2372019-10-10T08:40:50  *** TheRec has joined #bitcoin-core-dev
2382019-10-10T08:40:50  *** TheRec has joined #bitcoin-core-dev
2392019-10-10T08:40:54  <wumpus> that's, constructive at least
2402019-10-10T08:43:56  *** setpill has joined #bitcoin-core-dev
2412019-10-10T08:49:09  *** jonatack has quit IRC
2422019-10-10T09:00:02  *** Guest69975 has quit IRC
2432019-10-10T09:00:25  <Bullit> My mailclient is Thunderbird
2442019-10-10T09:00:41  *** timothy has joined #bitcoin-core-dev
2452019-10-10T09:04:20  *** promag_ has joined #bitcoin-core-dev
2462019-10-10T09:05:32  *** bitcoin-git has joined #bitcoin-core-dev
2472019-10-10T09:05:32  <bitcoin-git> [bitcoin] laanwj opened pull request #17094: doc: Add CODEOWNERS file (master...2019_10_codeowners) https://github.com/bitcoin/bitcoin/pull/17094
2482019-10-10T09:05:43  *** AaronvanW has joined #bitcoin-core-dev
2492019-10-10T09:05:44  *** bitcoin-git has left #bitcoin-core-dev
2502019-10-10T09:08:17  *** promag_ has quit IRC
2512019-10-10T09:15:27  *** bitcoin-git has joined #bitcoin-core-dev
2522019-10-10T09:15:27  <bitcoin-git> [bitcoin] darosior closed pull request #15346: cli: encryptwallet password entered from stdin. fixes #15318 (master...cli_encryptwallet_stdin) https://github.com/bitcoin/bitcoin/pull/15346
2532019-10-10T09:15:39  *** bitcoin-git has left #bitcoin-core-dev
2542019-10-10T09:17:45  *** srimech1 has joined #bitcoin-core-dev
2552019-10-10T09:18:12  *** Guyver2 has joined #bitcoin-core-dev
2562019-10-10T09:22:37  *** jonatack has joined #bitcoin-core-dev
2572019-10-10T09:46:46  *** promag has quit IRC
2582019-10-10T09:48:37  *** jdmark has quit IRC
2592019-10-10T09:52:45  *** promag has joined #bitcoin-core-dev
2602019-10-10T10:01:40  *** promag has quit IRC
2612019-10-10T10:29:04  *** promag has joined #bitcoin-core-dev
2622019-10-10T10:36:23  *** Deinogalerix21 has joined #bitcoin-core-dev
2632019-10-10T10:41:48  *** jb55 has quit IRC
2642019-10-10T10:44:57  *** jdmark_ has joined #bitcoin-core-dev
2652019-10-10T10:47:29  *** lightlike has joined #bitcoin-core-dev
2662019-10-10T10:50:00  *** jdmark_ is now known as jdmark
2672019-10-10T10:50:47  *** jdmark has joined #bitcoin-core-dev
2682019-10-10T10:51:51  *** jb55 has joined #bitcoin-core-dev
2692019-10-10T10:52:59  *** Deinogalerix21 has quit IRC
2702019-10-10T10:54:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2712019-10-10T10:56:08  *** jdmark has quit IRC
2722019-10-10T10:58:50  *** ghost43_ has joined #bitcoin-core-dev
2732019-10-10T10:59:02  *** arubi has joined #bitcoin-core-dev
2742019-10-10T10:59:23  *** sipa_ has joined #bitcoin-core-dev
2752019-10-10T10:59:52  *** SiAnDoG_ has joined #bitcoin-core-dev
2762019-10-10T11:00:11  *** afk11 has quit IRC
2772019-10-10T11:00:31  *** ghost43 has quit IRC
2782019-10-10T11:00:52  *** EagleTM has joined #bitcoin-core-dev
2792019-10-10T11:01:07  *** sipa has quit IRC
2802019-10-10T11:01:22  *** mryandao_ has joined #bitcoin-core-dev
2812019-10-10T11:01:52  *** morcos has quit IRC
2822019-10-10T11:02:20  *** SiAnDoG has quit IRC
2832019-10-10T11:02:20  *** mryandao has quit IRC
2842019-10-10T11:02:48  *** arubi_ has quit IRC
2852019-10-10T11:04:43  *** afk11 has joined #bitcoin-core-dev
2862019-10-10T11:06:41  *** jdmark has joined #bitcoin-core-dev
2872019-10-10T11:06:43  *** morcos has joined #bitcoin-core-dev
2882019-10-10T11:09:08  *** spinza has quit IRC
2892019-10-10T11:10:28  *** bitcoin-git has joined #bitcoin-core-dev
2902019-10-10T11:10:29  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5cb1d938a1c9...b67ca4ee73d1
2912019-10-10T11:10:29  <bitcoin-git> bitcoin/master facb9a1 Wladimir J. van der Laan: init: Change fallback locale to C.UTF-8
2922019-10-10T11:10:30  <bitcoin-git> bitcoin/master b67ca4e Wladimir J. van der Laan: Merge #17085: init: Change fallback locale to C.UTF-8
2932019-10-10T11:10:32  *** bitcoin-git has left #bitcoin-core-dev
2942019-10-10T11:10:48  *** bitcoin-git has joined #bitcoin-core-dev
2952019-10-10T11:10:48  <bitcoin-git> [bitcoin] laanwj merged pull request #17085: init: Change fallback locale to C.UTF-8 (master...2019_10_utf8_fallback) https://github.com/bitcoin/bitcoin/pull/17085
2962019-10-10T11:10:49  *** bitcoin-git has left #bitcoin-core-dev
2972019-10-10T11:17:36  *** Eagle[TM] has joined #bitcoin-core-dev
2982019-10-10T11:17:39  *** jdmark has quit IRC
2992019-10-10T11:18:17  *** srimech1 has quit IRC
3002019-10-10T11:18:24  *** coinmonks has joined #bitcoin-core-dev
3012019-10-10T11:18:57  *** EagleTM has quit IRC
3022019-10-10T11:19:10  *** spinza has joined #bitcoin-core-dev
3032019-10-10T11:24:24  *** jdmark has joined #bitcoin-core-dev
3042019-10-10T11:27:11  *** bitcoin-git has joined #bitcoin-core-dev
3052019-10-10T11:27:11  <bitcoin-git> [bitcoin] laanwj opened pull request #17095: util: Filter control characters out of log messages (master...2019_10_log_control_chars) https://github.com/bitcoin/bitcoin/pull/17095
3062019-10-10T11:27:12  *** bitcoin-git has left #bitcoin-core-dev
3072019-10-10T11:41:36  <luke-jr> wumpus: is there a reason to not have spaces on both sides of the colon for a item for-loop
3082019-10-10T11:41:37  <luke-jr> ?
3092019-10-10T11:44:38  *** Kater1 has joined #bitcoin-core-dev
3102019-10-10T11:44:44  <wumpus> is there a reason to? I don't care, if people prefer that I'll do that
3112019-10-10T11:47:33  <luke-jr> dunno, just noticed the difference
3122019-10-10T11:50:21  *** braydonf has quit IRC
3132019-10-10T11:50:21  *** lowentropy has quit IRC
3142019-10-10T11:50:39  *** lowentropy has joined #bitcoin-core-dev
3152019-10-10T11:50:44  *** braydonf has joined #bitcoin-core-dev
3162019-10-10T11:51:19  *** promag has quit IRC
3172019-10-10T11:58:23  <kanzure> one argument in favor of keeping a maintained mailing list is that there's tens of thousands of subscribers and many of them rely on this for critical security announcements
3182019-10-10T11:58:38  <kanzure> anyway, meeting with warren in person soon to see why he wanted to meet
3192019-10-10T12:00:02  *** Kater1 has quit IRC
3202019-10-10T12:09:20  *** promag has joined #bitcoin-core-dev
3212019-10-10T12:10:15  *** Eagle[TM] has quit IRC
3222019-10-10T12:11:38  *** masterdonx2 has joined #bitcoin-core-dev
3232019-10-10T12:11:45  *** coinmonks has quit IRC
3242019-10-10T12:12:12  <wumpus> that needs an announcements list, not so much a mailing list
3252019-10-10T12:12:27  *** MasterdonX has quit IRC
3262019-10-10T12:12:39  <wumpus> (e.g. something like sendy or mailgun or whatever would work too)
3272019-10-10T12:12:48  *** goatpig has quit IRC
3282019-10-10T12:13:41  *** promag has quit IRC
3292019-10-10T12:15:47  *** ka6sox1 has joined #bitcoin-core-dev
3302019-10-10T12:45:09  *** goatpig has joined #bitcoin-core-dev
3312019-10-10T12:51:09  *** promag has joined #bitcoin-core-dev
3322019-10-10T12:56:30  *** sipa_ has quit IRC
3332019-10-10T12:56:53  *** sipa has joined #bitcoin-core-dev
3342019-10-10T13:01:38  *** Highway62 has joined #bitcoin-core-dev
3352019-10-10T13:02:37  *** Highway61 has quit IRC
3362019-10-10T13:02:37  *** Highway62 is now known as Highway61
3372019-10-10T13:20:35  *** bitcoin-git has joined #bitcoin-core-dev
3382019-10-10T13:20:36  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b67ca4ee73d1...2352aec9fc82
3392019-10-10T13:20:36  <bitcoin-git> bitcoin/master 0a57368 practicalswift: tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) an...
3402019-10-10T13:20:37  <bitcoin-git> bitcoin/master 5c29876 practicalswift: tests: Remove TRANSACTION_DESERIALIZE (replaced by transaction fuzzer)
3412019-10-10T13:20:37  <bitcoin-git> bitcoin/master 2352aec MarcoFalke: Merge #17076: tests: Add fuzzing harness for CheckTransaction(...), IsStan...
3422019-10-10T13:20:38  *** bitcoin-git has left #bitcoin-core-dev
3432019-10-10T13:20:40  *** rockhouse has quit IRC
3442019-10-10T13:20:40  *** victorSN has quit IRC
3452019-10-10T13:20:55  *** bitcoin-git has joined #bitcoin-core-dev
3462019-10-10T13:20:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17076: tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions (master...fuzzers-transaction) https://github.com/bitcoin/bitcoin/pull/17076
3472019-10-10T13:20:57  *** bitcoin-git has left #bitcoin-core-dev
3482019-10-10T13:21:40  *** rockhouse has joined #bitcoin-core-dev
3492019-10-10T13:28:03  *** EagleTM has joined #bitcoin-core-dev
3502019-10-10T13:29:02  *** victorSN has joined #bitcoin-core-dev
3512019-10-10T13:29:09  *** Eagle[TM] has joined #bitcoin-core-dev
3522019-10-10T13:32:04  *** Chris_Stewart_5 has quit IRC
3532019-10-10T13:32:27  *** EagleTM has quit IRC
3542019-10-10T13:33:08  *** bitcoin-git has joined #bitcoin-core-dev
3552019-10-10T13:33:09  <bitcoin-git> [bitcoin] Zero-1729 opened pull request #17096: gui: rename debug window (master...rename-debug-window) https://github.com/bitcoin/bitcoin/pull/17096
3562019-10-10T13:33:09  *** bitcoin-git has left #bitcoin-core-dev
3572019-10-10T13:37:40  *** TheRec has quit IRC
3582019-10-10T13:37:49  *** TheRec has joined #bitcoin-core-dev
3592019-10-10T13:37:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3602019-10-10T13:40:20  *** TheRec has quit IRC
3612019-10-10T13:40:39  *** TheRec has joined #bitcoin-core-dev
3622019-10-10T13:40:39  *** TheRec has joined #bitcoin-core-dev
3632019-10-10T13:42:19  *** TheRec has quit IRC
3642019-10-10T13:42:51  *** Eagle[TM] has quit IRC
3652019-10-10T13:43:22  *** TheRec has joined #bitcoin-core-dev
3662019-10-10T13:43:23  *** TheRec has joined #bitcoin-core-dev
3672019-10-10T13:43:26  *** ghost43_ is now known as ghost43
3682019-10-10T13:45:31  *** pinheadmz has quit IRC
3692019-10-10T13:46:09  *** pinheadmz has joined #bitcoin-core-dev
3702019-10-10T13:48:21  *** TheRec has quit IRC
3712019-10-10T13:48:44  *** TheRec has joined #bitcoin-core-dev
3722019-10-10T14:01:08  *** TheRec has joined #bitcoin-core-dev
3732019-10-10T14:01:08  *** TheRec has joined #bitcoin-core-dev
3742019-10-10T14:06:41  *** bitcoin-git has joined #bitcoin-core-dev
3752019-10-10T14:06:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2352aec9fc82...2a0164085b00
3762019-10-10T14:06:43  <bitcoin-git> bitcoin/master 3530108 Antoine Riard: MOVEONLY : move RPC wallets helpers to TransactionDescriptionString
3772019-10-10T14:06:43  <bitcoin-git> bitcoin/master f4c8953 Antoine Riard: Add missing fields in TransactionDescriptionString and others
3782019-10-10T14:06:44  <bitcoin-git> bitcoin/master 2a01640 MarcoFalke: Merge #16689: rpc: add missing fields to wallet rpc help output
3792019-10-10T14:06:54  *** bitcoin-git has left #bitcoin-core-dev
3802019-10-10T14:07:11  *** bitcoin-git has joined #bitcoin-core-dev
3812019-10-10T14:07:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16689: rpc: add missing fields to wallet rpc help output (master...2019-08-missing-fields-rpcs-help) https://github.com/bitcoin/bitcoin/pull/16689
3822019-10-10T14:07:12  *** bitcoin-git has left #bitcoin-core-dev
3832019-10-10T14:10:20  *** ajonas has joined #bitcoin-core-dev
3842019-10-10T14:19:26  *** bitcoin-git has joined #bitcoin-core-dev
3852019-10-10T14:19:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17089: ci: Add test env for riscv (master...1909-ciRiscV) https://github.com/bitcoin/bitcoin/pull/17089
3862019-10-10T14:19:28  *** bitcoin-git has left #bitcoin-core-dev
3872019-10-10T14:23:16  *** emilengler_ is now known as emilengler
3882019-10-10T14:25:07  *** nosss2 has joined #bitcoin-core-dev
3892019-10-10T14:25:10  *** emilengler has joined #bitcoin-core-dev
3902019-10-10T14:33:26  *** jonatack has quit IRC
3912019-10-10T14:34:07  *** michaelfolkson has joined #bitcoin-core-dev
3922019-10-10T14:38:10  *** mdunnio has joined #bitcoin-core-dev
3932019-10-10T14:39:54  *** michaelfolkson has quit IRC
3942019-10-10T14:43:49  *** mdunnio has quit IRC
3952019-10-10T14:47:45  *** mdunnio has joined #bitcoin-core-dev
3962019-10-10T14:49:36  *** promag has quit IRC
3972019-10-10T14:52:00  *** bitcoin-git has joined #bitcoin-core-dev
3982019-10-10T14:52:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17097: build: Add README.md to DIST target (master...1909-buildDocDist) https://github.com/bitcoin/bitcoin/pull/17097
3992019-10-10T14:52:01  *** bitcoin-git has left #bitcoin-core-dev
4002019-10-10T14:54:43  *** michaelfolkson has joined #bitcoin-core-dev
4012019-10-10T14:57:57  *** face has quit IRC
4022019-10-10T14:59:25  *** promag has joined #bitcoin-core-dev
4032019-10-10T15:00:02  *** ka6sox1 has quit IRC
4042019-10-10T15:00:10  *** face has joined #bitcoin-core-dev
4052019-10-10T15:04:10  *** mdunnio has quit IRC
4062019-10-10T15:05:15  *** mdunnio has joined #bitcoin-core-dev
4072019-10-10T15:11:32  *** promag has quit IRC
4082019-10-10T15:12:30  *** promag has joined #bitcoin-core-dev
4092019-10-10T15:16:12  *** michaelfolkson has quit IRC
4102019-10-10T15:17:24  *** michaelfolkson has joined #bitcoin-core-dev
4112019-10-10T15:18:02  *** rh0nj has quit IRC
4122019-10-10T15:18:11  *** DASPRiD1 has joined #bitcoin-core-dev
4132019-10-10T15:19:07  *** rh0nj has joined #bitcoin-core-dev
4142019-10-10T15:25:49  *** jtimon has joined #bitcoin-core-dev
4152019-10-10T15:31:00  *** Randolf has quit IRC
4162019-10-10T15:41:17  *** Highway62 has joined #bitcoin-core-dev
4172019-10-10T15:42:59  *** Highway61 has quit IRC
4182019-10-10T15:43:01  *** Highway62 is now known as Highway61
4192019-10-10T15:46:06  *** michaelfolkson has quit IRC
4202019-10-10T15:47:39  *** roconnor has joined #bitcoin-core-dev
4212019-10-10T15:50:44  *** sdaftuar has quit IRC
4222019-10-10T15:53:46  *** sdaftuar has joined #bitcoin-core-dev
4232019-10-10T15:57:22  *** newbieprogrammer has joined #bitcoin-core-dev
4242019-10-10T15:58:35  *** lightlike has quit IRC
4252019-10-10T16:03:16  *** newbieprogrammer has left #bitcoin-core-dev
4262019-10-10T16:05:50  *** promag has quit IRC
4272019-10-10T16:06:50  *** pinheadmz_ has joined #bitcoin-core-dev
4282019-10-10T16:08:25  *** michaelfolkson has joined #bitcoin-core-dev
4292019-10-10T16:09:06  *** morcos has quit IRC
4302019-10-10T16:09:19  *** morcos has joined #bitcoin-core-dev
4312019-10-10T16:09:25  *** pinheadmz has quit IRC
4322019-10-10T16:09:26  *** pinheadmz_ is now known as pinheadmz
4332019-10-10T16:11:39  *** justanotheruser has quit IRC
4342019-10-10T16:14:54  *** bitcoin-git has joined #bitcoin-core-dev
4352019-10-10T16:14:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a0164085b00...59f0687fea26
4362019-10-10T16:14:55  <bitcoin-git> bitcoin/master a57a1d4 Sebastian Falbesoner: test: add unit test for wallet watch-only methods involving PubKeys
4372019-10-10T16:14:56  <bitcoin-git> bitcoin/master 59f0687 MarcoFalke: Merge #16786: test: add unit test for wallet watch-only methods involving ...
4382019-10-10T16:15:05  *** bitcoin-git has left #bitcoin-core-dev
4392019-10-10T16:15:24  *** bitcoin-git has joined #bitcoin-core-dev
4402019-10-10T16:15:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16786: test: add unit test for wallet watch-only methods involving PubKeys (master...add_wallet_watchpubkey_unit_test) https://github.com/bitcoin/bitcoin/pull/16786
4412019-10-10T16:15:35  *** bitcoin-git has left #bitcoin-core-dev
4422019-10-10T16:16:58  *** mdunnio has quit IRC
4432019-10-10T16:18:35  *** mdunnio has joined #bitcoin-core-dev
4442019-10-10T16:21:40  <warren> wumpus: regarding discourse vs mailing list, I'm happy that anyone expressed an opinion at all!
4452019-10-10T16:23:57  *** setpill has quit IRC
4462019-10-10T16:23:59  *** michaelfolkson has quit IRC
4472019-10-10T16:24:36  *** roconnor_ has joined #bitcoin-core-dev
4482019-10-10T16:24:37  *** roconnor has quit IRC
4492019-10-10T16:29:07  *** justanotheruser has joined #bitcoin-core-dev
4502019-10-10T16:29:09  *** bitcoin-git has joined #bitcoin-core-dev
4512019-10-10T16:29:09  <bitcoin-git> [bitcoin] adamjonas opened pull request #17098: refactor: Feebumper EstimateFeeRate (master...16727-follow-up) https://github.com/bitcoin/bitcoin/pull/17098
4522019-10-10T16:29:19  *** bitcoin-git has left #bitcoin-core-dev
4532019-10-10T16:30:26  *** pyericz has quit IRC
4542019-10-10T16:30:29  *** bitcoin-git has joined #bitcoin-core-dev
4552019-10-10T16:30:29  <bitcoin-git> [bitcoin] dongcarl opened pull request #17099: depends: Eliminate hard dependency on Ubuntu-ABI specific clang (master...2019-09-no-clang-download) https://github.com/bitcoin/bitcoin/pull/17099
4562019-10-10T16:30:40  *** bitcoin-git has left #bitcoin-core-dev
4572019-10-10T16:35:06  *** bitcoin-git has joined #bitcoin-core-dev
4582019-10-10T16:35:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/59f0687fea26...befdef8aee89
4592019-10-10T16:35:07  <bitcoin-git> bitcoin/master 230d43f Pieter Wuille: Abstract out some of the descriptor Span-parsing helpers
4602019-10-10T16:35:08  <bitcoin-git> bitcoin/master 5e69aee Pieter Wuille: Add documenting comments to spanparsing.h
4612019-10-10T16:35:08  <bitcoin-git> bitcoin/master bb36372 Sebastian Falbesoner: test: add unit tests for Span-parsing helpers
4622019-10-10T16:35:10  *** bitcoin-git has left #bitcoin-core-dev
4632019-10-10T16:35:26  *** bitcoin-git has joined #bitcoin-core-dev
4642019-10-10T16:35:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16887: Abstract out some of the descriptor Span-parsing helpers (master...201909_spanparsing) https://github.com/bitcoin/bitcoin/pull/16887
4652019-10-10T16:35:28  *** bitcoin-git has left #bitcoin-core-dev
4662019-10-10T16:39:21  *** seeder has joined #bitcoin-core-dev
4672019-10-10T16:47:02  *** mdunnio has quit IRC
4682019-10-10T16:47:46  *** lightlike has joined #bitcoin-core-dev
4692019-10-10T16:50:54  *** bitcoin-git has joined #bitcoin-core-dev
4702019-10-10T16:50:54  <bitcoin-git> [bitcoin] praveenkumar141 opened pull request #17100: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/17100
4712019-10-10T16:51:05  *** bitcoin-git has left #bitcoin-core-dev
4722019-10-10T16:52:04  *** bitcoin-git has joined #bitcoin-core-dev
4732019-10-10T16:52:04  <bitcoin-git> [bitcoin] fanquake closed pull request #17100: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/17100
4742019-10-10T16:52:15  *** bitcoin-git has left #bitcoin-core-dev
4752019-10-10T16:52:20  <fanquake> wumpus / sipa can you ban praveenkumar141 from the repo.
4762019-10-10T16:53:57  <sipa> sure; what did he do?
4772019-10-10T16:54:07  <sipa> ah, i just get the email
4782019-10-10T16:55:05  <sipa> done
4792019-10-10T16:56:30  *** promag has joined #bitcoin-core-dev
4802019-10-10T17:00:30  *** captjakk has joined #bitcoin-core-dev
4812019-10-10T17:00:37  *** promag has quit IRC
4822019-10-10T17:03:57  *** roconnor_ has quit IRC
4832019-10-10T17:04:44  *** masterdonx2 has quit IRC
4842019-10-10T17:05:30  <fanquake> Thanks
4852019-10-10T17:05:34  *** MasterdonX has joined #bitcoin-core-dev
4862019-10-10T17:07:47  *** promag has joined #bitcoin-core-dev
4872019-10-10T17:07:58  *** face has quit IRC
4882019-10-10T17:17:30  *** jarthur has joined #bitcoin-core-dev
4892019-10-10T17:21:24  *** Chris_Stewart_5 has quit IRC
4902019-10-10T17:21:29  *** bitcoin-git has joined #bitcoin-core-dev
4912019-10-10T17:21:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/befdef8aee89...d5a770b70d55
4922019-10-10T17:21:30  <bitcoin-git> bitcoin/master d478a47 Martin Zumsande: test: Fix combine_logs.py for AppVeyor build
4932019-10-10T17:21:30  <bitcoin-git> bitcoin/master d5a770b MarcoFalke: Merge #16973: test: Fix combine_logs.py for AppVeyor build
4942019-10-10T17:21:30  *** jonatack has joined #bitcoin-core-dev
4952019-10-10T17:21:40  *** bitcoin-git has left #bitcoin-core-dev
4962019-10-10T17:21:59  *** bitcoin-git has joined #bitcoin-core-dev
4972019-10-10T17:21:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16973: test: Fix combine_logs.py for AppVeyor build (master...201909_test_pathsep) https://github.com/bitcoin/bitcoin/pull/16973
4982019-10-10T17:22:01  *** bitcoin-git has left #bitcoin-core-dev
4992019-10-10T17:24:30  *** mdunnio has joined #bitcoin-core-dev
5002019-10-10T17:26:03  *** Emcy has quit IRC
5012019-10-10T17:26:14  *** promag has quit IRC
5022019-10-10T17:26:17  *** justanotheruser has quit IRC
5032019-10-10T17:28:29  *** Emcy has joined #bitcoin-core-dev
5042019-10-10T17:32:21  *** advac has joined #bitcoin-core-dev
5052019-10-10T17:33:19  *** advac has quit IRC
5062019-10-10T17:33:56  *** mdunnio has quit IRC
5072019-10-10T17:34:08  *** mdunnio has joined #bitcoin-core-dev
5082019-10-10T17:41:33  *** profmac has quit IRC
5092019-10-10T17:43:51  *** timothy has quit IRC
5102019-10-10T17:44:14  *** profmac has joined #bitcoin-core-dev
5112019-10-10T17:47:27  *** justanotheruser has joined #bitcoin-core-dev
5122019-10-10T17:47:36  *** bitcoin-git has joined #bitcoin-core-dev
5132019-10-10T17:47:36  <bitcoin-git> [bitcoin] jnewbery opened pull request #17101: test PR (master...residency_test) https://github.com/bitcoin/bitcoin/pull/17101
5142019-10-10T17:47:38  *** bitcoin-git has left #bitcoin-core-dev
5152019-10-10T17:49:06  *** fox2p has joined #bitcoin-core-dev
5162019-10-10T17:50:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5172019-10-10T17:50:17  *** fox2p_ has quit IRC
5182019-10-10T17:53:32  *** votesmith has quit IRC
5192019-10-10T17:55:18  <MarcoFalke> kallewoof: Just saw your complaint that me closing https://github.com/bitcoin/bitcoin/pull/16681#issuecomment-539694699 was a "power move"
5202019-10-10T17:55:46  <MarcoFalke> I disagree. Usually I don't close pull requests unless they are obvioulsy never going to get merged
5212019-10-10T17:56:35  <MarcoFalke> If I think a pull request should be closed, I state my reasons for doing so and wait for the author to close it or agree it can be closed
5222019-10-10T17:56:55  <MarcoFalke> In this case jtimon's response was "In that case, I guess we should close this."
5232019-10-10T17:57:15  <MarcoFalke> Which I read as permission to close the pull request
5242019-10-10T17:57:36  <MarcoFalke> Let me know if there is anything I did wrong or should improve
5252019-10-10T17:57:36  *** bitcoin-git has joined #bitcoin-core-dev
5262019-10-10T17:57:36  <bitcoin-git> [bitcoin] jnewbery closed pull request #17101: test PR (master...residency_test) https://github.com/bitcoin/bitcoin/pull/17101
5272019-10-10T17:57:37  *** bitcoin-git has left #bitcoin-core-dev
5282019-10-10T17:57:41  *** roconnor_ has joined #bitcoin-core-dev
5292019-10-10T18:00:01  *** DASPRiD1 has quit IRC
5302019-10-10T18:02:20  *** sdaftuar has quit IRC
5312019-10-10T18:03:20  *** sdaftuar has joined #bitcoin-core-dev
5322019-10-10T18:07:38  *** votesmith has joined #bitcoin-core-dev
5332019-10-10T18:08:09  *** MasterdonX has quit IRC
5342019-10-10T18:09:54  *** MasterdonX has joined #bitcoin-core-dev
5352019-10-10T18:10:28  *** Alejoss has joined #bitcoin-core-dev
5362019-10-10T18:17:33  *** michaelfolkson has joined #bitcoin-core-dev
5372019-10-10T18:18:27  *** Ahmuck has joined #bitcoin-core-dev
5382019-10-10T18:18:37  *** mdunnio has quit IRC
5392019-10-10T18:20:10  *** mdunnio has joined #bitcoin-core-dev
5402019-10-10T18:21:02  *** pinheadmz_ has joined #bitcoin-core-dev
5412019-10-10T18:24:00  *** pinheadmz has quit IRC
5422019-10-10T18:24:00  *** pinheadmz_ is now known as pinheadmz
5432019-10-10T18:26:25  *** bitcoin-git has joined #bitcoin-core-dev
5442019-10-10T18:26:26  <bitcoin-git> [bitcoin] practicalswift reopened pull request #16136: Add an optional extra level of checking: DCHECK(...) - an opt-in side-effect safe assert(...) (master...check) https://github.com/bitcoin/bitcoin/pull/16136
5452019-10-10T18:26:27  *** bitcoin-git has left #bitcoin-core-dev
5462019-10-10T18:28:00  *** Skirmant has quit IRC
5472019-10-10T18:28:04  *** Alejoss has quit IRC
5482019-10-10T18:30:26  <jtimon> MarcoFalke: I think it was as misanderstanding. By "in that case" I meant "in case those reasons aren't good enough", which I thought it was obvious I disagreed with.
5492019-10-10T18:30:27  <jtimon> I don't think that is the case, I think those reasons are good enoug. What I mean if that those reasons don't convince other people, we can close it.
5502019-10-10T18:30:27  <jtimon> In any case, if more people agree with my reasons, the best place to say is probably the PR itself
5512019-10-10T18:32:44  *** bitcoin-git has joined #bitcoin-core-dev
5522019-10-10T18:32:44  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16681: Tests: Use self.chain instead of 'regtest' in all current tests (master...b19-testchains-tests) https://github.com/bitcoin/bitcoin/pull/16681
5532019-10-10T18:32:51  <MarcoFalke> Ok, reopened it
5542019-10-10T18:32:55  *** bitcoin-git has left #bitcoin-core-dev
5552019-10-10T18:33:52  <jtimon> thanks
5562019-10-10T18:45:03  <elichai2> wow :/
5572019-10-10T18:45:12  <elichai2> ops, sorry
5582019-10-10T18:47:07  *** Highway61 has quit IRC
5592019-10-10T18:48:45  *** Skirmant has joined #bitcoin-core-dev
5602019-10-10T18:50:22  *** arik_ has joined #bitcoin-core-dev
5612019-10-10T18:54:03  *** Aaronvan_ has joined #bitcoin-core-dev
5622019-10-10T18:55:27  *** arik_ has quit IRC
5632019-10-10T18:56:03  *** mmgen has joined #bitcoin-core-dev
5642019-10-10T18:57:07  *** AaronvanW has quit IRC
5652019-10-10T18:57:22  *** arik_ has joined #bitcoin-core-dev
5662019-10-10T18:59:55  *** promag has joined #bitcoin-core-dev
5672019-10-10T19:00:10  <sipa> meetung?
5682019-10-10T19:00:21  <achow101> meeting?
5692019-10-10T19:00:22  <wumpus> #startmeeting
5702019-10-10T19:00:22  <lightningbot> Meeting started Thu Oct 10 19:00:22 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
5712019-10-10T19:00:22  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
5722019-10-10T19:00:25  <kanzure> hi
5732019-10-10T19:00:37  *** roconnor_ has quit IRC
5742019-10-10T19:00:39  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
5752019-10-10T19:00:44  <promag> hello
5762019-10-10T19:00:47  <gleb> hi
5772019-10-10T19:00:48  <jonatack> hi
5782019-10-10T19:01:05  <fanquake> hi
5792019-10-10T19:01:09  <sipa> hi
5802019-10-10T19:01:12  <elichai2> hi
5812019-10-10T19:01:21  <provoostenator> hi
5822019-10-10T19:01:29  <meshcollider> hi
5832019-10-10T19:01:44  <wumpus> has anyone been testing 0.19.0rc1? any issues found?
5842019-10-10T19:02:01  <fanquake> Limited testing so far. Nothing obvious has cropped up.
5852019-10-10T19:02:04  *** sdaftuar has quit IRC
5862019-10-10T19:02:05  <MarcoFalke> hoy
5872019-10-10T19:02:08  <fanquake> Will do more over the weekend.
5882019-10-10T19:02:28  <jonasschnelli> hi
5892019-10-10T19:02:30  <wumpus> same, no problems here
5902019-10-10T19:02:34  <achow101> hi
5912019-10-10T19:02:52  <MarcoFalke> Would be surprised if this was the first major release without bugs xD
5922019-10-10T19:02:52  * jonasschnelli running 0.19.0rc1
5932019-10-10T19:03:08  <wumpus> we should definitely give it some more time :)
5942019-10-10T19:03:56  *** sdaftuar has joined #bitcoin-core-dev
5952019-10-10T19:04:03  <real_or_random> hi
5962019-10-10T19:04:07  <promag> spinning as usual
5972019-10-10T19:04:20  <wumpus> we have one proposed topic: #16834 (BlueMatt)
5982019-10-10T19:04:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16834 | Fetch Headers over DNS by TheBlueMatt · Pull Request #16834 · bitcoin/bitcoin · GitHub
5992019-10-10T19:04:27  <fanquake> A couple PRs to pull in at some point as well. https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+label%3A%22Needs+backport+%280.19%29%22
6002019-10-10T19:04:28  *** belcher has quit IRC
6012019-10-10T19:04:30  <BlueMatt> yea, I need to find some time to switch my seed nodes to 190rc1
6022019-10-10T19:04:41  <BlueMatt> will do this coming week
6032019-10-10T19:04:50  <wumpus> but we'll start with high priority for review again
6042019-10-10T19:04:55  *** jkczyz has joined #bitcoin-core-dev
6052019-10-10T19:04:57  <wumpus> #topic High priority for review
6062019-10-10T19:05:20  <wumpus> https://github.com/bitcoin/bitcoin/projects/8  only three blockers on the list right now
6072019-10-10T19:05:39  <fanquake> #16202 Had quite a few ACKs, however needs a rebase jonasschnelli
6082019-10-10T19:05:41  <wumpus> #16202 is close to merge?
6092019-10-10T19:05:41  <gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
6102019-10-10T19:05:44  <gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
6112019-10-10T19:05:58  <jonasschnelli> Oh. Let me rebase then
6122019-10-10T19:06:05  <MarcoFalke> I'd like to put up #16490
6132019-10-10T19:06:07  <gribble> https://github.com/bitcoin/bitcoin/issues/16490 | rpc: Report reason for replaceable txpool transactions by MarcoFalke · Pull Request #16490 · bitcoin/bitcoin · GitHub
6142019-10-10T19:06:32  <dongcarl> I think most of the comments in #16202 expand on the scope, and should be followups. They're all ACKs otherwise
6152019-10-10T19:06:34  <gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
6162019-10-10T19:07:03  <jnewbery> hi
6172019-10-10T19:07:07  <MarcoFalke> I removed the "Bugs in 0.19 are blockers" card in high prio
6182019-10-10T19:07:18  <wumpus> MarcoFalke: added
6192019-10-10T19:07:22  <MarcoFalke> thx
6202019-10-10T19:07:59  <provoostenator> I'd like to nominate #16944, pretty close anyway...
6212019-10-10T19:08:01  <gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors · Pull Request #16944 · bitcoin/bitcoin · GitHub
6222019-10-10T19:08:20  <wumpus> dongcarl: right, especially so early in the release window it's better to merge, then expanding the scope in follow-ups, it allows for better cooporation
6232019-10-10T19:09:20  <wumpus> provoostenator: ok added
6242019-10-10T19:09:43  <jonasschnelli> my only worry is, that with 16944 the GUI gets even more complicated
6252019-10-10T19:09:52  <fanquake> ^
6262019-10-10T19:09:57  <jonasschnelli> But maybe okay for watch-only expertish setups
6272019-10-10T19:10:08  <wumpus> #topic gui: create PSBT with watch-only wallet
6282019-10-10T19:10:19  <jonasschnelli> but I need to take a closer look at 16944 before I further complain
6292019-10-10T19:11:20  <provoostenator> jonasschnelli: it's going to get more complicated if we ever add full hardware support
6302019-10-10T19:11:31  <provoostenator> See also: #16966
6312019-10-10T19:11:33  <gribble> https://github.com/bitcoin/bitcoin/issues/16966 | ui: make send a wizard by Sjors · Pull Request #16966 · bitcoin/bitcoin · GitHub
6322019-10-10T19:12:08  <provoostenator> That wizard PR should make it easier to add more stuff, because we're not squeezing a million things in one dialog.
6332019-10-10T19:12:12  *** AaronvanW has joined #bitcoin-core-dev
6342019-10-10T19:13:02  <wumpus> yes
6352019-10-10T19:13:17  <promag> yup
6362019-10-10T19:13:37  <fanquake> provoostenator: how does what your doing aling/conflict with what the HWI project is doing GUI wise?
6372019-10-10T19:13:42  <fanquake> *align
6382019-10-10T19:13:56  <fanquake> I've seen discussions on their repo about adding some sort of GUI.
6392019-10-10T19:14:14  <provoostenator> It's the reverse approach, it can co-exist
6402019-10-10T19:14:47  <jonasschnelli> however, the function itself (PSBT creation in watch-only mode) is certainly a strong concept ack,... just need to watch out for the UX
6412019-10-10T19:14:50  <achow101> The idea is to have some gui for HWI where users can paste the psbt from 16944 instead of having to go to the command line
6422019-10-10T19:15:19  *** Aaronvan_ has quit IRC
6432019-10-10T19:16:02  <provoostenator> In the longer run I'd rather not force users to have 2 GUIs to deal with, but in the short run an HWI GUI is easier.
6442019-10-10T19:17:11  <jonasschnelli> I totally get the use case... just copy pasting from one UI to another is not a UX users appreciate in general. However, I'm not saying this is how it could be done initially
6452019-10-10T19:17:21  <fanquake> At a high level, not necessarily in regards to this PR, I'm hesitant to add more & more flows/functionality to Cores GUI. However I'll present my thoughts another time.
6462019-10-10T19:17:29  <provoostenator> I plan to build a hardware wallet GUI on top of the wizard above.
6472019-10-10T19:17:50  <provoostenator> As well as some options to the create wallet dialog.
6482019-10-10T19:18:15  <jonasschnelli> I think that would be great. Thanks provoostenator
6492019-10-10T19:18:47  <achow101> yeah, the two gui things is just a stop-gap measure, just like how the importmulti thing was a stop-gap
6502019-10-10T19:19:22  <fanquake> Should we move on? bluematt & DNS & Rust ?
6512019-10-10T19:19:40  <wumpus> right, got to have it working first, then think about streamlining it
6522019-10-10T19:19:40  <elichai2> :)
6532019-10-10T19:20:11  <fanquake> Has also been some good Rust related discussion in #17090 so far.
6542019-10-10T19:20:13  <gribble> https://github.com/bitcoin/bitcoin/issues/17090 | RFC: Rust code integration · Issue #17090 · bitcoin/bitcoin · GitHub
6552019-10-10T19:20:17  <wumpus> #topic Fetch Headers over DNS (BlueMatt)
6562019-10-10T19:20:19  <BlueMatt> so #17090 is where the high-level discussion has moved, and there's good comments there to read, but, at a high level, I want to move forward with (in 0.20, off by default, with a goal of on by default/in release bins in 0.21) work to enable parallel p2p and block/header download in rust.
6572019-10-10T19:20:21  <gribble> https://github.com/bitcoin/bitcoin/issues/17090 | RFC: Rust code integration · Issue #17090 · bitcoin/bitcoin · GitHub
6582019-10-10T19:20:22  <BlueMatt> the first step/merge-candidate is #16834 which just fetches headers over dns with 100 loc in rust or so. I want to change the format of the dns responses but otherwise (mod some review from elichai2 I need to respond to) I think its "ready to go"
6592019-10-10T19:20:23  <gribble> https://github.com/bitcoin/bitcoin/issues/16834 | Fetch Headers over DNS by TheBlueMatt · Pull Request #16834 · bitcoin/bitcoin · GitHub
6602019-10-10T19:20:30  <BlueMatt> (sorry, I had those pre-written :p)
6612019-10-10T19:21:23  <BlueMatt> in the medium-term, I'd like a) blocks-over-http(preferably s, but ssl is Hard), and b) a full parallel p2p network implementation in rust, likely with the same protocol and with an explicit goal of being Simple and Robust
6622019-10-10T19:21:27  <fanquake> Aside from the review comments, I've discussed with Cory and there is still some build related "cleanup" that can be done there as well.
6632019-10-10T19:21:40  <wumpus> as for the high level discussion about rust, concept ACK, don't really have anything to say besides already written in #17090
6642019-10-10T19:21:41  <gribble> https://github.com/bitcoin/bitcoin/issues/17090 | RFC: Rust code integration · Issue #17090 · bitcoin/bitcoin · GitHub
6652019-10-10T19:21:43  <BlueMatt> but it has generated a nice little framework for building ways to download the chain
6662019-10-10T19:21:54  <achow101> time to learn rust I guess
6672019-10-10T19:22:04  <wumpus> as for fetching headers over DNS ... interesting idea, doesn't it put a lot of strain on the DNS resolver to have a request per block?
6682019-10-10T19:22:07  <cfields> I think if we're going to discuss here, we should split this topic in two.
6692019-10-10T19:22:45  <BlueMatt> wumpus: probably, but its partially a demo, and partially a thing that you could theoretically use in conjunction with the Dns-over-https-over-cloudflare stuff people are looking at putting in systemd....
6702019-10-10T19:22:52  <cfields> (Or maybe the higher level discussions belong on 17090)
6712019-10-10T19:23:05  <wumpus> so it's good for the last-to-end bocks, but not for getting the entire chain, I guess
6722019-10-10T19:23:13  <BlueMatt> I think there's a few open questions here that we may want to discuss
6732019-10-10T19:23:20  <BlueMatt> biggest is just what rustc version do we target
6742019-10-10T19:23:45  <BlueMatt> wumpus: my model for eaders fetching is that it may be a good censorship *detection* thing, so even if it just gets a few more headers than you have blocks, thats ok
6752019-10-10T19:23:57  <wumpus> whatever is in bionic would be most convenient I guess
6762019-10-10T19:24:02  <elichai2> I agree with BlueMatt on the rustc version.
6772019-10-10T19:24:03  <BlueMatt> as long as it can generate a "you may be censored" warning, which p2p could take an turn on more aggressive options, as well as warn the user
6782019-10-10T19:24:26  <elichai2> wumpus: that means 1.36
6792019-10-10T19:24:29  <cfields> Right, we've discussed this a bit briefly. Because we don't yet have any rust code, and it won't be a build-time requirement, it makes sense imo to require the version that delivers whatever features we need. If that's bleeding-edge, so be it.
6802019-10-10T19:24:38  <BlueMatt> looks like bionic has a newer rustc than debian stable
6812019-10-10T19:24:42  *** Highway61 has joined #bitcoin-core-dev
6822019-10-10T19:24:46  <BlueMatt> (1.36 instead of 1.34)
6832019-10-10T19:24:48  *** promag_ has joined #bitcoin-core-dev
6842019-10-10T19:24:55  <MarcoFalke> we need bionic for gitian building
6852019-10-10T19:25:15  <BlueMatt> I dont think we're gonna ship rust code in release until dongcarl figures out guix stuff
6862019-10-10T19:25:30  <BlueMatt> but I *do* think we don't want to break debian stable (which is gonna be stable for like years)
6872019-10-10T19:26:04  <elichai2> that's weird
6882019-10-10T19:26:11  <MarcoFalke> That means the rust code is not shipped and disabled by default. What is the point then? Might as well not do it if it doesn't give any advantage
6892019-10-10T19:26:12  <wumpus> hm it seems pretty easy to integrate it into the existing gitian
6902019-10-10T19:26:31  <wumpus> I'm not sure why make it conditional on guix, but anyhow
6912019-10-10T19:26:42  <wumpus> MarcoFalke: that's the goal in the long term at least
6922019-10-10T19:26:47  <cfields> MarcoFalke: I mean that we don't *yet* have any rust code, so we're still free to set whatever requirements we want.
6932019-10-10T19:26:51  <fanquake> BlueMatt Is there anything not in 1.34 from later versions that would be "nice to have" ?
6942019-10-10T19:26:51  <provoostenator> The new feature can be tested by folks who build manually, that's been done before
6952019-10-10T19:26:52  <cfields> That changes as soon as we lock-in.
6962019-10-10T19:26:53  <BlueMatt> MarcoFalke: well I was kinda expecting we'd want to have a good story around bootstrapping the rust code before we ship in release binaries
6972019-10-10T19:26:57  <BlueMatt> (was hoping 0.21)
6982019-10-10T19:27:05  <wumpus> I don't think it makes sense to make so many different concerns conditional on each other
6992019-10-10T19:27:06  <BlueMatt> but if we're comfortable with it, that's cool too
7002019-10-10T19:27:16  *** promag has quit IRC
7012019-10-10T19:27:30  <elichai2> fanquake: i'm going over releases now to see if there's anything really interesting after 1.34
7022019-10-10T19:27:33  <wumpus> historically that was always a bad idea because we don't really know how long things are going to take
7032019-10-10T19:27:46  <MarcoFalke> for gitian you need to trust Ubuntu either way, so there is no downgrade in trusting the Bionic rustc
7042019-10-10T19:28:06  <jnewbery> I'm worried that in this medium-term world where we have a shiny new rust p2p implementation, we'll have even fewer people making and reviewing changes in the c++ p2p implementation
7052019-10-10T19:28:17  <BlueMatt> I suppose this is true....ubuntu did bootstrap rust themselves.....
7062019-10-10T19:28:44  <BlueMatt> jnewbery: my anticipation is that the "shiny new rust p2p implementation" was explicitly "thou may not relay transactions nor add anything 'complicated'"
7072019-10-10T19:28:46  <fanquake> jnewbery: atleast that should be somewhat offset by the major p2p reviewers not being Rust devs, as far as I'm aware.
7082019-10-10T19:28:50  <BlueMatt> so that would hopefully limit that somewhat
7092019-10-10T19:29:01  <fanquake> aside from bluematt that is.
7102019-10-10T19:29:39  <wumpus> jnewbery: I mean, you can never control wat people will review and contribute to
7112019-10-10T19:29:55  <elichai2> 1. better hashmap. 2.alloc crate. 3. #[must_use]. 4. `--offline` to cargo. 5. armv7-unknown-freebsd-gnueabihf, armv6-unknown-freebsd-gnueabihf, wasm32-unknown-wasi support.
7122019-10-10T19:30:05  <elichai2> i don't think any of them matter but  1.34.2 fixed a CVE
7132019-10-10T19:30:14  <jnewbery> wumpus: right, I agree with that. I certainly wouldn't want to tell anyone what they should work on
7142019-10-10T19:30:17  <BlueMatt> right, debian does have 1.34.2, not 1.34
7152019-10-10T19:30:17  <wumpus> jnewbery: it sounds a bit childish to not include rust code because you're afraid developers will look at that code more :)
7162019-10-10T19:30:19  <elichai2> that's the debian supported version
7172019-10-10T19:30:29  <cfields> elichai2: is 2. needed for overriding malloc?
7182019-10-10T19:30:43  *** promag has joined #bitcoin-core-dev
7192019-10-10T19:30:50  <elichai2> cfields: no. it's just a way to link against liballoc and not libstd
7202019-10-10T19:30:50  <ysangkok> wouldn't it make sense to drop support for debian once guix makes it really easier to build the same thing on all platforms?
7212019-10-10T19:30:50  <wumpus> also, it might also get new people interested, you never know
7222019-10-10T19:30:51  <BlueMatt> cfields: no, only 1.28 is required for GlobalAlloc
7232019-10-10T19:31:05  <cfields> Ok, thanks.
7242019-10-10T19:31:06  <elichai2> (making binaries smaller and further support for embedded)
7252019-10-10T19:31:28  <fanquake> wumpus: hopefully
7262019-10-10T19:31:35  <jnewbery> wumpus: I'm not sure it's childish. I think it's a valid concern thta when there aren't many developers looking at a component, then reimplementing it in a different language may make the situation worse
7272019-10-10T19:32:02  <MarcoFalke> ysangkok: That is the long-term goal, but won't happen before Bitcoin Core 0.21.0
7282019-10-10T19:32:12  <provoostenator> I would probably feel more embolded reviewing c++ p2p code if there was a fresh Rust version to compare with
7292019-10-10T19:32:18  <BlueMatt> elichai2: well luckily all but 3 there dont require changes to our code, so we can build with newer rustc and get those features, even if we "support" older ones
7302019-10-10T19:32:18  <wumpus> jnewbery: but only if you see the set of dvelopers looking at the code as a closed set, I hope that's not the case in the medium term
7312019-10-10T19:33:26  <elichai2> BlueMatt: yeah I shoud've dropped 1 because that's transparent to impl. but 2 isn't. altough I don't think we care about it that much (maybe for compiling to some exotic target that doesn't support libstd)
7322019-10-10T19:33:48  <BlueMatt> right, I dont think core is gonna support wasm so that may be ok :p
7332019-10-10T19:34:48  <elichai2> oh another thing in 1.35 is musl support. although again that doesn't bother implementors. only the users who compile (a user can compile the same code both to x86_64-gnu and x86_64-musl) https://github.com/rust-lang/rust/pull/58575
7342019-10-10T19:35:16  <elichai2> IMHO 1.34.2 it is
7352019-10-10T19:35:28  <midnightmagic> musl appears to be a popular target for supporting e.g. BE on POWER9
7362019-10-10T19:35:33  <BlueMatt> kool, unless there are other obections seems like at least that issue is fine
7372019-10-10T19:36:13  <wumpus> people that want to use musl can just use a newer rust, right?
7382019-10-10T19:36:28  <BlueMatt> midnightmagic: right, just means those users will need a newer rustc, even though we "support" older ones
7392019-10-10T19:36:29  <elichai2> yes
7402019-10-10T19:36:29  <wumpus> that it supports 1.35 doesn't mean you need to build with that...
7412019-10-10T19:36:30  <BlueMatt> yep
7422019-10-10T19:36:47  <elichai2> the target support should only conserned released binaries I think
7432019-10-10T19:37:17  <midnightmagic> sure, just making observation that it appears some (highly competent) people are liking the musl
7442019-10-10T19:37:26  <BlueMatt> right
7452019-10-10T19:37:30  <midnightmagic> \o
7462019-10-10T19:37:43  <elichai2> so as long as all released binaries are for x86 windows/gnu(glibc) then I don't think any of that other stuff matter. users can use 1.38 to compile to musl/armv7/riscv32i etc.
7472019-10-10T19:38:05  <cfields> *armv7-bsd
7482019-10-10T19:38:05  <wumpus> released binaries are glibc only
7492019-10-10T19:38:25  <wumpus> I'm sure that could change inthe future, but that's a wholly different concern
7502019-10-10T19:38:26  <BlueMatt> right, and you'll at least be able to turn it off at compile time for the forseeable future
7512019-10-10T19:38:53  <cfields> elichai2 and I have a longer-term plan for rust/libc world domination anyway.
7522019-10-10T19:39:05  <BlueMatt> another thing that may be worth mentioning here is that for the bitcoin core-required bits of stratumv2 (ie a getblocktemplate replacement) there has been some initial speculation/thinking that it would be in rust
7532019-10-10T19:40:16  <elichai2> cfields: don't know too much about armv7 but something changed even for the linux variants lately https://github.com/rust-lang/rust/pull/63107/
7542019-10-10T19:40:29  <MarcoFalke> so the windows,mac,and arm releases couldn't come with any rust code compiled in?
7552019-10-10T19:40:36  <MarcoFalke> only the x86 ones?
7562019-10-10T19:41:03  <BlueMatt> no they totally could
7572019-10-10T19:41:13  <BlueMatt> all of those platforms are "well supported"
7582019-10-10T19:41:36  <BlueMatt> power may be more of a question (as its "second tier" support or some shit like that), but I've never had issues with rust on power9 and thats my main dev machine
7592019-10-10T19:42:13  <wumpus> rust works very well on ARM 32 and 64, windows/mac is also well supported
7602019-10-10T19:42:20  <MarcoFalke> we don't have power yet: #14066
7612019-10-10T19:42:22  <cfields> yeah, I'm a bit confused about that PR. I think it's a bit more subtle than "armv7 wasn't supported but is now".
7622019-10-10T19:42:23  <wumpus> risc-v linux is still a problem right now
7632019-10-10T19:42:43  <elichai2> I really don't know a lot about arm and there are too many target triples for armv7 for me to know what's what lol
7642019-10-10T19:42:47  <wumpus> then again, that will be resolved soon, I'm sure it won't be in a year or so
7652019-10-10T19:42:48  <gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
7662019-10-10T19:42:58  <elichai2> wumpus: which target triple is "normal arm"?
7672019-10-10T19:43:05  <wumpus> arm-linux-gnueabi
7682019-10-10T19:43:10  <wumpus> hf
7692019-10-10T19:43:38  <elichai2> yeah. that's Tier 2 with cargo+rustc+libstd. good support :)
7702019-10-10T19:43:39  <BlueMatt> do we support hard forking? </badjoke>
7712019-10-10T19:43:54  <wumpus> arm64 is aarch64-linux-gnu
7722019-10-10T19:44:21  *** mdunnio has quit IRC
7732019-10-10T19:44:23  <wumpus> both can run the compiler as well as cross compile for
7742019-10-10T19:44:38  <fanquake> Getting a bit into the weeds here. Does anyone else have a meeting topic for the last 15 minutes? Otherwise I can we can continue Rust discussion/
7752019-10-10T19:44:40  <elichai2> yep same. the `gnueabi` and `musleabi` are the ones who changed
7762019-10-10T19:45:01  <wumpus> I don't think there's any other topics
7772019-10-10T19:45:41  <wumpus> #endmeeting
7782019-10-10T19:45:41  <lightningbot> Meeting ended Thu Oct 10 19:45:41 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
7792019-10-10T19:45:41  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-10-19.00.html
7802019-10-10T19:45:41  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-10-19.00.txt
7812019-10-10T19:45:41  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-10-19.00.log.html
7822019-10-10T19:45:43  <BlueMatt> I mean so it sounds like conclusions are: 1.36(at least, if not older) target for "supported"
7832019-10-10T19:45:57  <BlueMatt> and also review #16834
7842019-10-10T19:45:58  <gribble> https://github.com/bitcoin/bitcoin/issues/16834 | Fetch Headers over DNS by TheBlueMatt · Pull Request #16834 · bitcoin/bitcoin · GitHub
7852019-10-10T19:46:25  <jeremyrubin> Sorry -- was running late but just caught up
7862019-10-10T19:46:35  <fanquake> BlueMatt: could you summarize into #17090 ?
7872019-10-10T19:46:36  <gribble> https://github.com/bitcoin/bitcoin/issues/17090 | RFC: Rust code integration · Issue #17090 · bitcoin/bitcoin · GitHub
7882019-10-10T19:46:39  *** bitcoin-git has joined #bitcoin-core-dev
7892019-10-10T19:46:39  <bitcoin-git> [bitcoin] jnewbery closed pull request #10593: Relax punishment for peers relaying invalid blocks and headers (master...relax_invblk_punishment) https://github.com/bitcoin/bitcoin/pull/10593
7902019-10-10T19:46:49  *** bitcoin-git has left #bitcoin-core-dev
7912019-10-10T19:46:56  *** jtimon has quit IRC
7922019-10-10T19:46:59  <BlueMatt> fanquake: will do
7932019-10-10T19:47:07  <fanquake> BlueMatt: cheers
7942019-10-10T19:48:00  <jeremyrubin> My general feeling is we should keep the version flexible until we're looking to put it in a release, echoing cfields. If we want experimental features, so be it. One nice thing is that it's easily doable to link multiple rust versions if needed, afaict
7952019-10-10T19:48:15  *** mdunnio has joined #bitcoin-core-dev
7962019-10-10T19:49:02  *** seeder has quit IRC
7972019-10-10T19:49:08  <jeremyrubin> So if there's a set of non-experimental rust that is going to build against the stable, it'd be fine to have experimental extensions too which are nightly. Especially if we're looking at big modules (like a blocks over DNS thing)
7982019-10-10T19:51:43  *** Chris_Stewart_5 has quit IRC
7992019-10-10T19:52:11  <BlueMatt> jeremyrubin: I dunno about nightly rust, but I don't know that anyone would really disagree about "revisit rustc requirement in the future if we need something"
8002019-10-10T19:52:44  <BlueMatt> jeremyrubin: but, at least personally, I'd be really, really, really heasitant to do that unless we really need something, and eg super new features like async/await probably need at least a year or two before we'd even remotely consider them.
8012019-10-10T19:52:59  <BlueMatt> (and, short that, there isnt a ton of shiny newness we want, imo)
8022019-10-10T19:54:27  <jeremyrubin> That's roughly what I had in mind. personally I'm dreading async/await being more popular though, and don't think we'll necessarily want to use it at all.
8032019-10-10T19:54:59  <BlueMatt> same
8042019-10-10T19:55:44  <Bullit> Remember units such as ¨ton¨ are still strange
8052019-10-10T19:55:45  <elichai2> async/await is mostly sugar syntaxing. most of the usability is already there just looks ugly
8062019-10-10T19:56:28  <jeremyrubin> elichai2: I'm unexcited for people using it more ;)
8072019-10-10T19:59:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
8082019-10-10T20:00:35  *** bitcoin-git has joined #bitcoin-core-dev
8092019-10-10T20:00:36  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5a770b70d55...08ed87e8875d
8102019-10-10T20:00:36  <bitcoin-git> bitcoin/master 86b9f92 Hennadii Stepanov: doc: Add detailed info about Bitcoin Core files
8112019-10-10T20:00:37  <bitcoin-git> bitcoin/master 08ed87e MarcoFalke: Merge #16983: doc: Add detailed info about Bitcoin Core files
8122019-10-10T20:00:38  *** bitcoin-git has left #bitcoin-core-dev
8132019-10-10T20:00:55  *** bitcoin-git has joined #bitcoin-core-dev
8142019-10-10T20:00:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16983: doc: Add detailed info about Bitcoin Core files (master...20190929-files) https://github.com/bitcoin/bitcoin/pull/16983
8152019-10-10T20:00:56  *** bitcoin-git has left #bitcoin-core-dev
8162019-10-10T20:01:45  <instagibbs> jonasschnelli, 16944 fits a small usability niche that I appreciate. After that I don't think there's more "feature creep" until someone wants full fledged offline signer wizard, which is a much larger change
8172019-10-10T20:02:46  *** ariard_ has quit IRC
8182019-10-10T20:02:52  <jonasschnelli> Yeah. I kinda also appreciate. I guess its also pretty isolated to not scare non PSBT users
8192019-10-10T20:04:58  <instagibbs> yes, if it wasn't really small change set and hidden to normal users I'd be -1 on it
8202019-10-10T20:06:17  *** Highway61 has quit IRC
8212019-10-10T20:08:20  *** ariard has joined #bitcoin-core-dev
8222019-10-10T20:10:06  *** promag has quit IRC
8232019-10-10T20:10:25  *** bitcoin-git has joined #bitcoin-core-dev
8242019-10-10T20:10:26  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17102: doc: Add missing indexes/blockfilter/basic to doc/files.md (master...1909-docFilesBlockFilterIndex) https://github.com/bitcoin/bitcoin/pull/17102
8252019-10-10T20:10:27  *** bitcoin-git has left #bitcoin-core-dev
8262019-10-10T20:15:02  <ysangkok> jeremyrubin: what is your concern with await/async?
8272019-10-10T20:24:24  <jeremyrubin> Generally I think that willy-nilly await/async leads to deadlock/race conditions and non-deterministic execution.
8282019-10-10T20:25:02  <jeremyrubin> Even if Rust permits us to be more broad in the parallelism we use in Bitcoin, I think this generally points to still closely guarded/scoped parallelism.
8292019-10-10T20:26:19  *** Highway61 has joined #bitcoin-core-dev
8302019-10-10T20:27:17  <jeremyrubin> I don't like how infectuos await/async is either. Because soon lots of libraries will use/abuse await/async and those types will 'infect' your code to an extent.
8312019-10-10T20:27:45  <BlueMatt> add it to the long list of gripes over the rust ecosystem :/
8322019-10-10T20:28:07  <jeremyrubin> Luckily, for Bitcoin, if we aren't making much use of await/async we'll mostly be able to avoid it as we're not going to be relying on a huge number of crates
8332019-10-10T20:30:12  <jeremyrubin> I think overall it's a good thing; it's going to make rust much more suitable for general application development, which will draw more users, which means more review/investment etc etc. But I doubt the async/await features will be super useful for nitty-gritty systems engineering, which is the original focus for rust.
8342019-10-10T20:31:03  *** Highway62 has joined #bitcoin-core-dev
8352019-10-10T20:33:32  *** Highway61 has quit IRC
8362019-10-10T20:33:34  *** Highway62 is now known as Highway61
8372019-10-10T20:35:12  *** mdunnio has quit IRC
8382019-10-10T20:35:40  *** mdunnio has joined #bitcoin-core-dev
8392019-10-10T20:35:46  *** mdunnio has quit IRC
8402019-10-10T20:42:02  *** mmgen has quit IRC
8412019-10-10T20:43:22  *** arik_ has quit IRC
8422019-10-10T20:44:17  *** jkczyz has quit IRC
8432019-10-10T20:45:08  *** MasterdonX has quit IRC
8442019-10-10T20:47:00  *** MasterdonX has joined #bitcoin-core-dev
8452019-10-10T20:47:11  *** jtimon has joined #bitcoin-core-dev
8462019-10-10T20:49:55  *** michaelfolkson has quit IRC
8472019-10-10T20:51:41  *** Chris_Stewart_5 has quit IRC
8482019-10-10T20:57:41  *** shesek has quit IRC
8492019-10-10T20:58:04  *** shesek has joined #bitcoin-core-dev
8502019-10-10T20:58:04  *** shesek has joined #bitcoin-core-dev
8512019-10-10T20:59:12  *** shesek has quit IRC
8522019-10-10T20:59:40  *** shesek has joined #bitcoin-core-dev
8532019-10-10T21:00:01  *** Ahmuck has quit IRC
8542019-10-10T21:03:03  *** shesek has quit IRC
8552019-10-10T21:03:30  *** shesek has joined #bitcoin-core-dev
8562019-10-10T21:04:26  *** cryptapus has quit IRC
8572019-10-10T21:05:12  *** MasterdonX has quit IRC
8582019-10-10T21:06:05  *** MasterdonX has joined #bitcoin-core-dev
8592019-10-10T21:06:47  *** shesek has quit IRC
8602019-10-10T21:07:09  *** shesek has joined #bitcoin-core-dev
8612019-10-10T21:07:09  *** shesek has joined #bitcoin-core-dev
8622019-10-10T21:08:33  *** shesek has quit IRC
8632019-10-10T21:08:59  *** shesek has joined #bitcoin-core-dev
8642019-10-10T21:08:59  *** shesek has joined #bitcoin-core-dev
8652019-10-10T21:14:10  *** qapla_org has joined #bitcoin-core-dev
8662019-10-10T21:14:31  *** Guyver2 has quit IRC
8672019-10-10T21:25:34  <sipa> qt/rpcconsole.cpp:1287:1: warning: control reaches end of non-void function [-Wreturn-type]
8682019-10-10T21:35:56  *** promag_ is now known as promag
8692019-10-10T21:35:59  <promag> I was under the impression it wouldn't be a problem (as in it wouldn't complain) if there were a case X: for each enum value
8702019-10-10T21:36:54  *** ghost43_ has joined #bitcoin-core-dev
8712019-10-10T21:37:53  *** ghost43 has quit IRC
8722019-10-10T21:38:06  <promag> should add a default: on the last case?
8732019-10-10T21:38:29  <promag> default: assert(false) ?
8742019-10-10T21:40:56  *** arik_ has joined #bitcoin-core-dev
8752019-10-10T21:44:43  *** jkczyz has joined #bitcoin-core-dev
8762019-10-10T21:44:55  *** michaelfolkson has joined #bitcoin-core-dev
8772019-10-10T21:46:53  *** arik__ has joined #bitcoin-core-dev
8782019-10-10T21:49:19  *** arik___ has joined #bitcoin-core-dev
8792019-10-10T21:50:52  *** arik_ has quit IRC
8802019-10-10T21:52:15  *** shesek has quit IRC
8812019-10-10T21:52:37  *** arik__ has quit IRC
8822019-10-10T21:52:41  *** shesek has joined #bitcoin-core-dev
8832019-10-10T21:53:57  *** shesek has quit IRC
8842019-10-10T21:54:19  *** shesek has joined #bitcoin-core-dev
8852019-10-10T21:54:19  *** shesek has joined #bitcoin-core-dev
8862019-10-10T21:55:25  *** shesek has quit IRC
8872019-10-10T21:55:50  *** shesek has joined #bitcoin-core-dev
8882019-10-10T21:55:50  *** shesek has joined #bitcoin-core-dev
8892019-10-10T21:57:14  *** shesek has quit IRC
8902019-10-10T21:57:29  *** EagleTM has joined #bitcoin-core-dev
8912019-10-10T21:57:37  *** shesek has joined #bitcoin-core-dev
8922019-10-10T21:58:55  *** shesek has quit IRC
8932019-10-10T21:59:20  *** shesek has joined #bitcoin-core-dev
8942019-10-10T21:59:20  *** shesek has joined #bitcoin-core-dev
8952019-10-10T22:18:34  *** arik_ has joined #bitcoin-core-dev
8962019-10-10T22:21:15  *** arik___ has quit IRC
8972019-10-10T22:22:46  *** Sentineo has joined #bitcoin-core-dev
8982019-10-10T22:25:25  *** EagleTM has quit IRC
8992019-10-10T22:28:05  *** jeremyrubin has quit IRC
9002019-10-10T22:34:35  <luke-jr> sipa: promag: default:assert(false) just breaks the warning :/
9012019-10-10T22:35:07  <luke-jr> best to cover each case explicitly, so when/if the enum gets a value added, the warning comes back if it's not added here too
9022019-10-10T22:37:19  *** bitcoin-git has joined #bitcoin-core-dev
9032019-10-10T22:37:19  <bitcoin-git> [bitcoin] ch4ot1c opened pull request #17104: [WIP] build: `make dist` uses `git archive` (master...build/archive-dist) https://github.com/bitcoin/bitcoin/pull/17104
9042019-10-10T22:37:21  *** bitcoin-git has left #bitcoin-core-dev
9052019-10-10T22:40:06  <sipa> luke-jr: i have not checked the code, but i believe the problem is that the warning is emitted despite all enum values being covered in the switch
9062019-10-10T22:40:58  *** michaelfolkson has quit IRC
9072019-10-10T22:41:28  <luke-jr> oh, that's weird
9082019-10-10T22:41:47  <luke-jr> well, maybe not, different warning
9092019-10-10T22:41:52  <luke-jr> add assert(false) after the switch?
9102019-10-10T22:42:08  <luke-jr> that way the switch will still warn if it's missing a value
9112019-10-10T22:42:34  <Bullit> Which switch are you planing on using they all about bottom
9122019-10-10T22:43:19  *** marcoagner has quit IRC
9132019-10-10T22:55:21  *** michaelfolkson has joined #bitcoin-core-dev
9142019-10-10T23:00:29  *** michaelfolkson has quit IRC
9152019-10-10T23:04:20  *** bitcoin-git has joined #bitcoin-core-dev
9162019-10-10T23:04:21  <bitcoin-git> [bitcoin] promag opened pull request #17105: gui: Add missing return value in RPCConsole::tabShortcut (master...2019-10-fix-warning) https://github.com/bitcoin/bitcoin/pull/17105
9172019-10-10T23:04:22  *** bitcoin-git has left #bitcoin-core-dev
9182019-10-10T23:08:22  *** promag has quit IRC
9192019-10-10T23:14:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
9202019-10-10T23:19:43  *** jkczyz has quit IRC
9212019-10-10T23:20:50  *** jkczyz has joined #bitcoin-core-dev
9222019-10-10T23:24:37  *** Chris_Stewart_5 has quit IRC
9232019-10-10T23:25:04  *** arik__ has joined #bitcoin-core-dev
9242019-10-10T23:26:17  *** arik___ has joined #bitcoin-core-dev
9252019-10-10T23:28:27  *** arik_ has quit IRC
9262019-10-10T23:29:15  *** arik__ has quit IRC
9272019-10-10T23:31:15  *** MasterdonX has quit IRC
9282019-10-10T23:32:14  *** MasterdonX has joined #bitcoin-core-dev
9292019-10-10T23:36:00  *** jeremyrubin has joined #bitcoin-core-dev
9302019-10-10T23:41:02  *** Karyon has quit IRC
9312019-10-10T23:41:26  *** Karyon has joined #bitcoin-core-dev
9322019-10-10T23:44:57  *** arik___ has quit IRC
9332019-10-10T23:45:55  *** promag has joined #bitcoin-core-dev