1 2019-10-12T00:00:01 *** bpalmer1 has quit IRC
2 2019-10-12T00:00:38 *** marcoagner has quit IRC
3 2019-10-12T00:04:21 *** Jackielove4u has quit IRC
4 2019-10-12T00:05:19 *** lightlike has quit IRC
5 2019-10-12T00:06:14 *** goatpig has joined #bitcoin-core-dev
6 2019-10-12T00:12:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
7 2019-10-12T00:22:00 *** phantomcircuit_ is now known as phantomcircuit
8 2019-10-12T00:24:59 *** promag has quit IRC
9 2019-10-12T00:31:20 *** jkczyz has joined #bitcoin-core-dev
10 2019-10-12T00:33:52 *** AaronvanW has quit IRC
11 2019-10-12T00:33:57 *** promag has joined #bitcoin-core-dev
12 2019-10-12T00:35:39 *** jkczyz has quit IRC
13 2019-10-12T00:37:37 *** Highway61 has quit IRC
14 2019-10-12T00:41:24 *** arik_ has quit IRC
15 2019-10-12T00:46:13 *** |Kin| has joined #bitcoin-core-dev
16 2019-10-12T01:06:10 <emilengler> captjakk: I'm not sure but I don't think so
17 2019-10-12T01:06:38 <emilengler> For example when you prune on a regtest chain, block 1 will still be there I thinx
18 2019-10-12T01:07:29 <sipa> he's no longer here
19 2019-10-12T01:07:39 *** Chris_Stewart_5 has quit IRC
20 2019-10-12T01:11:39 *** millerti has quit IRC
21 2019-10-12T01:22:45 *** gwollon is now known as gwillen
22 2019-10-12T01:25:12 *** promag has quit IRC
23 2019-10-12T01:26:13 *** cubancorona has quit IRC
24 2019-10-12T01:31:25 *** laptop500 has quit IRC
25 2019-10-12T01:33:17 *** arik_ has joined #bitcoin-core-dev
26 2019-10-12T01:34:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
27 2019-10-12T01:34:59 *** achow101 has quit IRC
28 2019-10-12T01:38:08 *** arik_ has quit IRC
29 2019-10-12T01:38:50 *** cubancorona has joined #bitcoin-core-dev
30 2019-10-12T01:39:05 *** achow101 has joined #bitcoin-core-dev
31 2019-10-12T01:40:24 *** cubancorona2 has joined #bitcoin-core-dev
32 2019-10-12T01:43:17 *** cubancorona has quit IRC
33 2019-10-12T01:50:43 *** michaelfolkson has joined #bitcoin-core-dev
34 2019-10-12T01:51:51 *** emilengler has quit IRC
35 2019-10-12T02:02:03 *** michaelfolkson has quit IRC
36 2019-10-12T02:07:38 *** nosss2_ has joined #bitcoin-core-dev
37 2019-10-12T02:08:18 *** SiAnDoG has joined #bitcoin-core-dev
38 2019-10-12T02:09:45 *** emilengler has joined #bitcoin-core-dev
39 2019-10-12T02:11:17 *** nosss2 has quit IRC
40 2019-10-12T02:12:35 *** Chris_Stewart_5 has quit IRC
41 2019-10-12T02:14:32 *** felixfoertsch has quit IRC
42 2019-10-12T02:14:33 *** felixfoertsch23 has joined #bitcoin-core-dev
43 2019-10-12T02:25:54 *** promag has joined #bitcoin-core-dev
44 2019-10-12T02:30:02 *** promag has quit IRC
45 2019-10-12T02:32:09 *** jkczyz has joined #bitcoin-core-dev
46 2019-10-12T02:33:00 *** shesek has joined #bitcoin-core-dev
47 2019-10-12T02:33:00 *** shesek has joined #bitcoin-core-dev
48 2019-10-12T02:36:56 *** jkczyz has quit IRC
49 2019-10-12T02:40:01 *** rh0nj has quit IRC
50 2019-10-12T02:41:10 *** rh0nj has joined #bitcoin-core-dev
51 2019-10-12T02:43:36 *** arik_ has joined #bitcoin-core-dev
52 2019-10-12T02:44:57 *** achow101 has quit IRC
53 2019-10-12T02:57:28 *** arik_ has quit IRC
54 2019-10-12T02:58:07 *** achow101 has joined #bitcoin-core-dev
55 2019-10-12T03:00:02 *** |Kin| has quit IRC
56 2019-10-12T03:08:41 *** jarthur has joined #bitcoin-core-dev
57 2019-10-12T03:17:24 *** sankarshan1 has joined #bitcoin-core-dev
58 2019-10-12T03:55:17 *** ddustin has joined #bitcoin-core-dev
59 2019-10-12T03:56:20 *** BLackArch has joined #bitcoin-core-dev
60 2019-10-12T04:01:25 *** BLackArch has left #bitcoin-core-dev
61 2019-10-12T04:02:40 *** Hayro has joined #bitcoin-core-dev
62 2019-10-12T04:03:33 *** jkczyz has joined #bitcoin-core-dev
63 2019-10-12T04:07:57 *** jkczyz has quit IRC
64 2019-10-12T04:12:02 *** jkczyz has joined #bitcoin-core-dev
65 2019-10-12T04:23:40 *** felixfoertsch23 has quit IRC
66 2019-10-12T04:23:51 *** felixfoertsch has joined #bitcoin-core-dev
67 2019-10-12T04:33:39 *** justanotheruser has quit IRC
68 2019-10-12T04:39:52 *** ajonas has quit IRC
69 2019-10-12T04:49:45 *** BLackArch has joined #bitcoin-core-dev
70 2019-10-12T04:50:41 *** justanotheruser has joined #bitcoin-core-dev
71 2019-10-12T04:51:35 *** Hayro has quit IRC
72 2019-10-12T04:54:05 *** rex4539 has joined #bitcoin-core-dev
73 2019-10-12T04:54:57 *** BLackArch has left #bitcoin-core-dev
74 2019-10-12T05:11:31 *** rex4539 has quit IRC
75 2019-10-12T05:18:51 *** verno99999 has joined #bitcoin-core-dev
76 2019-10-12T05:28:26 *** verno99999 has quit IRC
77 2019-10-12T05:37:51 *** face has joined #bitcoin-core-dev
78 2019-10-12T05:51:24 *** arik_ has joined #bitcoin-core-dev
79 2019-10-12T05:58:32 *** rex4539 has joined #bitcoin-core-dev
80 2019-10-12T05:58:49 *** rex4539 has quit IRC
81 2019-10-12T06:00:01 *** sankarshan1 has quit IRC
82 2019-10-12T06:00:25 *** promag has joined #bitcoin-core-dev
83 2019-10-12T06:04:51 *** promag has quit IRC
84 2019-10-12T06:17:43 *** kottt has joined #bitcoin-core-dev
85 2019-10-12T06:31:13 *** face has quit IRC
86 2019-10-12T06:35:37 *** jkczyz has quit IRC
87 2019-10-12T07:04:05 *** jkczyz has joined #bitcoin-core-dev
88 2019-10-12T07:08:38 *** jkczyz has quit IRC
89 2019-10-12T07:12:04 *** rex4539 has joined #bitcoin-core-dev
90 2019-10-12T07:29:53 *** lnostdal has joined #bitcoin-core-dev
91 2019-10-12T07:37:31 *** nickler_ has quit IRC
92 2019-10-12T07:37:45 *** nickler has joined #bitcoin-core-dev
93 2019-10-12T07:43:13 *** jonatack has quit IRC
94 2019-10-12T08:04:24 *** Jackielove4u has joined #bitcoin-core-dev
95 2019-10-12T08:17:38 *** promag has joined #bitcoin-core-dev
96 2019-10-12T08:27:25 *** bitcoin-git has joined #bitcoin-core-dev
97 2019-10-12T08:27:25 <bitcoin-git> [bitcoin] practicalswift opened pull request #17113: tests: Add fuzzing harness for descriptor Span-parsing helpers (master...fuzzers-spanparsing) https://github.com/bitcoin/bitcoin/pull/17113
98 2019-10-12T08:27:27 *** bitcoin-git has left #bitcoin-core-dev
99 2019-10-12T08:38:32 *** jonatack has joined #bitcoin-core-dev
100 2019-10-12T08:40:07 *** PaulTroon has joined #bitcoin-core-dev
101 2019-10-12T08:40:31 *** arik_ has quit IRC
102 2019-10-12T08:42:58 <promag> could #16963 be in HP?
103 2019-10-12T08:43:00 <gribble> https://github.com/bitcoin/bitcoin/issues/16963 | wallet: Fix unique_ptr usage in boost::signals2 by promag · Pull Request #16963 · bitcoin/bitcoin · GitHub
104 2019-10-12T08:44:32 *** rex4539 has quit IRC
105 2019-10-12T08:44:46 *** rex4539 has joined #bitcoin-core-dev
106 2019-10-12T08:47:56 *** hebasto has joined #bitcoin-core-dev
107 2019-10-12T08:48:27 *** jonatack has quit IRC
108 2019-10-12T08:49:53 *** jonatack has joined #bitcoin-core-dev
109 2019-10-12T08:51:15 *** m1rror8955363887 has quit IRC
110 2019-10-12T08:53:09 *** jarthur has quit IRC
111 2019-10-12T08:58:06 *** marcoagner has joined #bitcoin-core-dev
112 2019-10-12T09:00:02 *** kottt has quit IRC
113 2019-10-12T09:04:59 *** jkczyz has joined #bitcoin-core-dev
114 2019-10-12T09:09:45 *** jkczyz has quit IRC
115 2019-10-12T09:12:57 *** AaronvanW has joined #bitcoin-core-dev
116 2019-10-12T09:13:53 *** subdriven1 has joined #bitcoin-core-dev
117 2019-10-12T09:15:13 *** morcos has quit IRC
118 2019-10-12T09:15:27 *** promag has quit IRC
119 2019-10-12T09:15:35 *** morcos has joined #bitcoin-core-dev
120 2019-10-12T09:21:55 *** promag has joined #bitcoin-core-dev
121 2019-10-12T09:33:57 *** jonatack has quit IRC
122 2019-10-12T09:34:08 *** promag has quit IRC
123 2019-10-12T09:34:49 *** promag has joined #bitcoin-core-dev
124 2019-10-12T09:39:10 *** m8tion has joined #bitcoin-core-dev
125 2019-10-12T09:40:35 *** promag has quit IRC
126 2019-10-12T09:49:10 *** kakobrekla has quit IRC
127 2019-10-12T09:50:31 *** kakobrekla has joined #bitcoin-core-dev
128 2019-10-12T09:58:09 *** jonatack has joined #bitcoin-core-dev
129 2019-10-12T10:15:07 *** Victor_sueca is now known as Victorsueca
130 2019-10-12T10:25:52 *** ddustin has quit IRC
131 2019-10-12T10:33:40 *** jkczyz has joined #bitcoin-core-dev
132 2019-10-12T10:38:17 *** jkczyz has quit IRC
133 2019-10-12T10:42:52 *** Soligor has quit IRC
134 2019-10-12T10:45:06 *** Evel-Knievel has quit IRC
135 2019-10-12T10:48:40 *** goatpig has quit IRC
136 2019-10-12T10:49:59 *** jb55 has quit IRC
137 2019-10-12T10:50:56 *** jb55 has joined #bitcoin-core-dev
138 2019-10-12T10:51:11 *** mmgen has joined #bitcoin-core-dev
139 2019-10-12T10:56:17 *** Soligor has joined #bitcoin-core-dev
140 2019-10-12T11:01:38 *** m8tion has quit IRC
141 2019-10-12T11:23:27 *** Ap4ch3 has joined #bitcoin-core-dev
142 2019-10-12T11:42:59 *** EagleTM has joined #bitcoin-core-dev
143 2019-10-12T12:00:01 *** subdriven1 has quit IRC
144 2019-10-12T12:05:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
145 2019-10-12T12:17:32 *** omega8cc has joined #bitcoin-core-dev
146 2019-10-12T12:18:48 *** Anduck_ is now known as Anduck
147 2019-10-12T12:34:36 *** jkczyz has joined #bitcoin-core-dev
148 2019-10-12T12:37:37 *** Highway61 has joined #bitcoin-core-dev
149 2019-10-12T12:39:11 *** jkczyz has quit IRC
150 2019-10-12T12:52:49 *** goatpig has joined #bitcoin-core-dev
151 2019-10-12T12:58:07 *** cubancorona2 has quit IRC
152 2019-10-12T13:00:02 *** jb55 has quit IRC
153 2019-10-12T13:00:30 *** jb55 has joined #bitcoin-core-dev
154 2019-10-12T13:01:02 *** promag has joined #bitcoin-core-dev
155 2019-10-12T13:27:16 *** nosss2_ has quit IRC
156 2019-10-12T13:27:39 *** promag has quit IRC
157 2019-10-12T13:39:57 *** jonatack has quit IRC
158 2019-10-12T13:44:15 *** ddustin has joined #bitcoin-core-dev
159 2019-10-12T13:47:32 *** PaulTroon has quit IRC
160 2019-10-12T13:49:16 *** ddustin has quit IRC
161 2019-10-12T13:56:27 *** goatpig has quit IRC
162 2019-10-12T14:01:25 *** promag has joined #bitcoin-core-dev
163 2019-10-12T14:06:05 *** promag has quit IRC
164 2019-10-12T14:08:37 *** bitcoin-git has joined #bitcoin-core-dev
165 2019-10-12T14:08:37 <bitcoin-git> [bitcoin] Sjors opened pull request #17118: [build] depends macOS: point --sysroot to SDK (master...2019/10/macos-sysroot) https://github.com/bitcoin/bitcoin/pull/17118
166 2019-10-12T14:08:38 *** bitcoin-git has left #bitcoin-core-dev
167 2019-10-12T14:13:36 <provoostenator> Any QT build system experts in the house who can demystify https://github.com/bitcoin/bitcoin/pull/16966#issuecomment-541310206 ?
168 2019-10-12T14:14:33 <provoostenator> Basically a --disable-wallet Travis build complaining that it can't find certain wallet related headers.
169 2019-10-12T14:15:18 <provoostenator> I'm not sure what I'm doing different in terms of including the new QT send screen file I created though.
170 2019-10-12T14:18:17 *** EagleTM has quit IRC
171 2019-10-12T14:19:56 *** promag has joined #bitcoin-core-dev
172 2019-10-12T14:21:12 *** aqquadro has joined #bitcoin-core-dev
173 2019-10-12T14:21:12 *** aqquadro has quit IRC
174 2019-10-12T14:21:12 *** aqquadro has joined #bitcoin-core-dev
175 2019-10-12T14:21:23 <gwillen> provoostenator: I don't think it's actually a QT issue
176 2019-10-12T14:21:37 <gwillen> you added an include of "wallet/coincontrol.h" to "qt/sendcompose.h"
177 2019-10-12T14:21:45 <gwillen> but I think the former is wallet and the latter is non-wallet
178 2019-10-12T14:22:05 <gwillen> (or rather, the latter is conditionally-wallet)
179 2019-10-12T14:22:35 <gwillen> (because all the QT stuff gets built no matter whether wallet is enabled or not, as long as qt is enabled, I think)
180 2019-10-12T14:23:03 <gwillen> not sure why it wouldn't reproduce locally though
181 2019-10-12T14:23:07 <provoostenator> gwillen: but doesn't the current SendCoinsDialog have the same include? https://github.com/bitcoin/bitcoin/blob/master/src/qt/sendcoinsdialog.cpp#L24
182 2019-10-12T14:23:09 <gwillen> so perhaps I'm wrong
183 2019-10-12T14:23:52 <provoostenator> I can't reproduce it locally either, though trying a few different things.
184 2019-10-12T14:23:53 <gwillen> but now it's in the h, where it was in the cpp before
185 2019-10-12T14:24:03 <gwillen> that is definitely a significant change
186 2019-10-12T14:24:09 <provoostenator> Yeah, I think I added it to the h in an attempt to get rid of that error.
187 2019-10-12T14:24:22 <provoostenator> But I'll strip it again
188 2019-10-12T14:24:38 <gwillen> ok, *nod*
189 2019-10-12T14:24:49 <provoostenator> But trial and error only gets you so far :-)
190 2019-10-12T14:25:00 <gwillen> the error you pasted in the PR thread definitely shows it being included in the h, and that would definitely tend to cause this problem I think
191 2019-10-12T14:29:57 *** Chris_Stewart_5 has quit IRC
192 2019-10-12T14:30:29 <provoostenator> Ah, for some reason sendcoinsdialog.h gets away with not having a "class CCoinControl" forward declaration.
193 2019-10-12T14:30:44 <provoostenator> But I can't get away with that in sendcompose.h
194 2019-10-12T14:30:56 <provoostenator> Indirect include mysteries ftw
195 2019-10-12T14:33:45 <provoostenator> Or maybe because I'm using it with Q_SIGNALS
196 2019-10-12T14:34:59 <provoostenator> I can see how that becomes a mess; the .ui and _moc wallet related files are not seperated.
197 2019-10-12T14:35:25 *** jkczyz has joined #bitcoin-core-dev
198 2019-10-12T14:35:26 <provoostenator> So I can either do something about that, or find a way to pass fewer things around (or both).
199 2019-10-12T14:36:22 <gwillen> the problem is the addition of gotoSign, which takes a CCCoinControl
200 2019-10-12T14:36:39 <provoostenator> Exactly.
201 2019-10-12T14:36:41 <gwillen> because it takes the object by value, callers need to know the size of a CCoinControl so they need the full definition,
202 2019-10-12T14:37:06 <gwillen> hmm
203 2019-10-12T14:37:39 <provoostenator> I probably want to keep CCoinControl (and the transaction) on SendDialog, instead of passing it around between the tabs.
204 2019-10-12T14:37:54 <provoostenator> Just need to make sure to do that without introducing circular references
205 2019-10-12T14:38:17 <gwillen> ok so you literally just stuff it into a shared_ptr when it gets there
206 2019-10-12T14:38:22 <gwillen> so you could pass it as a shared_ptr instead
207 2019-10-12T14:38:52 <gwillen> shared_ptr<CCoinControl> should not need the include
208 2019-10-12T14:39:16 <provoostenator> That's what I did before actually and it ended up not updating it between tabs.
209 2019-10-12T14:39:20 <gwillen> hmmmm
210 2019-10-12T14:39:39 *** jkczyz has quit IRC
211 2019-10-12T14:39:47 <provoostenator> So it probably copied it somewhere accidentally.
212 2019-10-12T14:40:04 <gwillen> *nod*, that makes sense
213 2019-10-12T14:40:10 <provoostenator> pointers are not my strong suite
214 2019-10-12T14:40:26 <gwillen> I mean right now you are deliberately just copying it, do you copy it back later, in order for it to update?
215 2019-10-12T14:40:39 <gwillen> I agree that refactoring it upwards so you don't have to do that makes the most sense
216 2019-10-12T14:40:46 <provoostenator> Well, the way it is right now is tjust the first thing I got working :-)
217 2019-10-12T14:41:16 <provoostenator> But the shared pointer approach probably makes more sense. I can try that again.
218 2019-10-12T14:41:46 <gwillen> I mean to be clear, I wasn't actually suggesting going back to sharing it rather than copying, I was just suggesting a hack
219 2019-10-12T14:42:00 <gwillen> which is, make the interface to gotoSign take a shared_ptr<CCoinControl>
220 2019-10-12T14:42:03 <gwillen> to fix the immediate build issue
221 2019-10-12T14:42:33 <provoostenator> Well, I don't like that the Compose tab passes a transaction to the SendDialog, which then passes it to the SignTab, which then passes it back, etc
222 2019-10-12T14:42:50 <gwillen> yeah, *nod*
223 2019-10-12T14:43:11 <gwillen> if the signtab has the senddialog as its parent, it should be easy not to have to do that
224 2019-10-12T14:43:16 <provoostenator> Hacks beget nacks.
225 2019-10-12T14:43:23 <gwillen> heh, yeah
226 2019-10-12T14:44:41 <provoostenator> The sign tab (sendsign.h) has a constructor with a *parent argument, currently QWidget.
227 2019-10-12T14:44:46 <provoostenator> The sign tab (sendsign.h) has a constructor with a *parent argument, currently QWidget.
228 2019-10-12T14:45:20 <provoostenator> Wouldn't I create a circular reference if I change that to a SendDialog?
229 2019-10-12T14:45:32 <gwillen> SendDialog is a type of QWidget
230 2019-10-12T14:46:03 <gwillen> you would just pass "this" as the second argument to the SendSign constructor when constructing it in senddialog.cpp
231 2019-10-12T14:46:14 <gwillen> right now you're not giving it a parent at all, it's just defaulting to null (it appears)
232 2019-10-12T14:46:28 <provoostenator> I know, but SendDialog.cpp includes signcompose.h
233 2019-10-12T14:46:50 <provoostenator> Circular includes I should say
234 2019-10-12T14:46:58 <gwillen> you don't need to change signcompose.h in order to do this
235 2019-10-12T14:47:06 <gwillen> so there's no circular include
236 2019-10-12T14:48:12 <gwillen> (I don't know for sure that setting the parent is the right QT thing to do here, but I feel like it probably is)
237 2019-10-12T14:48:23 <provoostenator> But QWidget won't have a coinControl property
238 2019-10-12T14:49:15 <gwillen> hmmmmmmm that's true. maybe that's not the right way to do this.
239 2019-10-12T14:49:28 <provoostenator> Maybe some abstract SignTab class?
240 2019-10-12T14:49:33 <gwillen> (it might still be the case that you should set the parent relationship, but it may not help with this issue)
241 2019-10-12T14:50:00 <gwillen> actually you could just give SignTab a pointer directly to SendDialog
242 2019-10-12T14:50:12 <gwillen> that _still_ will not create a circular include as long as it's a pointer (which it would have to be anyway) and not a copy
243 2019-10-12T14:50:12 <provoostenator> I'm probably thinking too much in ObjectiveC terms
244 2019-10-12T14:50:33 <gwillen> you can then get away with forward declaring "class SendDialog;" and not including anything
245 2019-10-12T14:51:11 <gwillen> er, reverse that
246 2019-10-12T14:51:18 <gwillen> give a SendDialog pointer to SignTab
247 2019-10-12T14:51:27 <provoostenator> I think I'll try passing a CCoinControl shared pointer to the tab constructor(s) again though, that seems more straight forward
248 2019-10-12T14:51:39 <gwillen> *nods*
249 2019-10-12T14:52:05 <gwillen> assuming that the SendDialog always outlives the SignTab, a bare pointer would also work
250 2019-10-12T14:52:20 <gwillen> I don't know if that's considered acceptable form
251 2019-10-12T14:53:01 <provoostenator> SendDialog creates the tabs when it's constructed, and they live until the end of the app.
252 2019-10-12T14:53:29 <provoostenator> But I hear shared pointers (or references?) are safer.
253 2019-10-12T14:53:39 <gwillen> shared pointers are definitely the safest option
254 2019-10-12T15:00:02 *** omega8cc has quit IRC
255 2019-10-12T15:02:17 *** lowentropy has quit IRC
256 2019-10-12T15:02:31 *** lowentropy has joined #bitcoin-core-dev
257 2019-10-12T15:05:28 *** Francisco_ has joined #bitcoin-core-dev
258 2019-10-12T15:09:15 *** tsujp has quit IRC
259 2019-10-12T15:09:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
260 2019-10-12T15:12:10 *** michaelfolkson has joined #bitcoin-core-dev
261 2019-10-12T15:15:46 *** XhmikosR1 has joined #bitcoin-core-dev
262 2019-10-12T15:16:32 *** tsujp has joined #bitcoin-core-dev
263 2019-10-12T15:23:09 <provoostenator> Maybe even a unique_ptr, since only 1 tab should be doing anything at any given moment.
264 2019-10-12T15:24:52 *** goatpig has joined #bitcoin-core-dev
265 2019-10-12T15:30:27 *** davterra has joined #bitcoin-core-dev
266 2019-10-12T15:33:17 *** promag has quit IRC
267 2019-10-12T15:35:57 *** tsujp has quit IRC
268 2019-10-12T15:36:25 *** tsujp_ has joined #bitcoin-core-dev
269 2019-10-12T15:38:01 *** Guyver2 has joined #bitcoin-core-dev
270 2019-10-12T15:56:09 *** goatpig has quit IRC
271 2019-10-12T16:03:55 *** alko has quit IRC
272 2019-10-12T16:05:11 *** davterra has quit IRC
273 2019-10-12T16:10:16 *** promag has joined #bitcoin-core-dev
274 2019-10-12T16:13:04 *** davterra has joined #bitcoin-core-dev
275 2019-10-12T16:15:31 *** Evel-Knievel has joined #bitcoin-core-dev
276 2019-10-12T16:23:26 *** promag has quit IRC
277 2019-10-12T16:30:34 *** alko89 has joined #bitcoin-core-dev
278 2019-10-12T16:36:28 *** jkczyz has joined #bitcoin-core-dev
279 2019-10-12T16:37:04 *** Deacyde has joined #bitcoin-core-dev
280 2019-10-12T16:40:51 *** jkczyz has quit IRC
281 2019-10-12T16:45:09 *** goatpig has joined #bitcoin-core-dev
282 2019-10-12T16:46:10 *** kristapsk has quit IRC
283 2019-10-12T16:52:02 *** promag has joined #bitcoin-core-dev
284 2019-10-12T16:54:35 *** nosss2 has joined #bitcoin-core-dev
285 2019-10-12T16:56:17 *** promag has quit IRC
286 2019-10-12T16:58:41 *** jkczyz has joined #bitcoin-core-dev
287 2019-10-12T17:05:17 *** kristapsk has joined #bitcoin-core-dev
288 2019-10-12T17:11:55 *** drbrule has quit IRC
289 2019-10-12T17:12:31 *** jb55 has quit IRC
290 2019-10-12T17:13:05 *** jb55 has joined #bitcoin-core-dev
291 2019-10-12T17:14:03 *** Chris_Stewart_5 has quit IRC
292 2019-10-12T17:34:23 *** davterra has quit IRC
293 2019-10-12T17:34:46 *** jonatack has joined #bitcoin-core-dev
294 2019-10-12T17:53:55 *** jarthur has joined #bitcoin-core-dev
295 2019-10-12T17:55:30 *** goatpig has quit IRC
296 2019-10-12T18:00:02 *** XhmikosR1 has quit IRC
297 2019-10-12T18:04:03 *** Deacyde has quit IRC
298 2019-10-12T18:10:01 *** davterra has joined #bitcoin-core-dev
299 2019-10-12T18:17:34 *** jdsharp has joined #bitcoin-core-dev
300 2019-10-12T18:32:55 *** promag has joined #bitcoin-core-dev
301 2019-10-12T18:35:28 *** lightlike has joined #bitcoin-core-dev
302 2019-10-12T18:37:42 *** promag has quit IRC
303 2019-10-12T18:38:34 *** nosss2 has quit IRC
304 2019-10-12T18:39:02 *** nosss2 has joined #bitcoin-core-dev
305 2019-10-12T18:51:17 *** Emcy has quit IRC
306 2019-10-12T18:55:15 *** goatpig has joined #bitcoin-core-dev
307 2019-10-12T19:04:49 *** nickler_ has joined #bitcoin-core-dev
308 2019-10-12T19:05:31 *** meshcollider has joined #bitcoin-core-dev
309 2019-10-12T19:05:41 *** nickler has quit IRC
310 2019-10-12T19:05:52 *** nickler has joined #bitcoin-core-dev
311 2019-10-12T19:06:56 *** Emcy has joined #bitcoin-core-dev
312 2019-10-12T19:12:17 *** jkczyz has quit IRC
313 2019-10-12T19:18:19 *** Skirmant has quit IRC
314 2019-10-12T19:23:27 <elichai2> Writing a simple tool to create bitcoin keys and to sign+verify messages. now i'm trying to decide if I should add support for `p2wpkh` and `p2shwpkh` for signing and verifying. because AFAIK core doesn't support it. should I? should I add support for core too? or just wait for BIP 322? @instagibbs
315 2019-10-12T19:29:01 <provoostenator> elichai2: how is that different from https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki ?
316 2019-10-12T19:29:32 <provoostenator> #16440
317 2019-10-12T19:29:34 <gribble> https://github.com/bitcoin/bitcoin/issues/16440 | BIP-322: Generic signed message format by kallewoof · Pull Request #16440 · bitcoin/bitcoin · GitHub
318 2019-10-12T19:29:49 <elichai2> All I do is assume it's a pay to pubkey hash in the end (meaning I just create a simple bech32 segwit p2wpkh and compare, then wrap it in p2sh and compare)
319 2019-10-12T19:29:56 <elichai2> I don't do anything fancy
320 2019-10-12T19:30:07 <elichai2> it's not "generic"
321 2019-10-12T19:30:30 <provoostenator> I think the initial idea of BIP 322 was not to be fancy :-)
322 2019-10-12T19:30:58 <sipa> elichai2: please don't further any message signing except bip322 :)
323 2019-10-12T19:31:47 <elichai2> sipa: ok :) it was just too easy in my tool lol. I'll either add a big warning that this isn't supported by core or just remove the whole thing except p2pkh
324 2019-10-12T19:32:09 <elichai2> (literally 2 more lines to support the rest lol)
325 2019-10-12T19:37:19 <provoostenator> elichai2: there's also this primitive method #16653, shared between Signet and BIP322. Could use some review love.
326 2019-10-12T19:37:20 <gribble> https://github.com/bitcoin/bitcoin/issues/16653 | script: add simple signature support (checker/creator) by kallewoof · Pull Request #16653 · bitcoin/bitcoin · GitHub
327 2019-10-12T19:39:58 <elichai2> i'll give it a look and if it's in my knwoledge i'll review :)
328 2019-10-12T19:40:10 *** Skirmant has joined #bitcoin-core-dev
329 2019-10-12T19:44:43 <Bullit> 11782 this piggy drove a would be car VWPOLOHARLEY but was -overdrive 01-08-2019 14:02
330 2019-10-12T19:52:40 *** ChanServ sets mode: +o sipa
331 2019-10-12T19:52:47 <sipa> Bullit: stop the nonsense
332 2019-10-12T19:56:36 *** goatpig has quit IRC
333 2019-10-12T20:00:41 *** Emcy_ has joined #bitcoin-core-dev
334 2019-10-12T20:02:57 *** Emcy has quit IRC
335 2019-10-12T20:04:30 *** jkczyz has joined #bitcoin-core-dev
336 2019-10-12T20:08:13 *** promag has joined #bitcoin-core-dev
337 2019-10-12T20:10:12 *** jkczyz has quit IRC
338 2019-10-12T20:11:40 *** promag has quit IRC
339 2019-10-12T20:11:55 *** promag has joined #bitcoin-core-dev
340 2019-10-12T20:32:02 *** davterra has quit IRC
341 2019-10-12T20:32:43 *** davterra has joined #bitcoin-core-dev
342 2019-10-12T20:34:46 *** davterra has joined #bitcoin-core-dev
343 2019-10-12T20:35:35 *** davterra has joined #bitcoin-core-dev
344 2019-10-12T20:38:13 *** mmgen has quit IRC
345 2019-10-12T20:44:10 *** goatpig has joined #bitcoin-core-dev
346 2019-10-12T20:46:37 *** davterra has quit IRC
347 2019-10-12T20:47:33 *** davterra has joined #bitcoin-core-dev
348 2019-10-12T20:56:08 *** bitcoin-git has joined #bitcoin-core-dev
349 2019-10-12T20:56:09 <bitcoin-git> [bitcoin] andrewtoth opened pull request #17119: [rpc] Fix broken bitcoin-cli examples (master...example-fixes) https://github.com/bitcoin/bitcoin/pull/17119
350 2019-10-12T20:56:10 *** bitcoin-git has left #bitcoin-core-dev
351 2019-10-12T21:00:01 *** jdsharp has quit IRC
352 2019-10-12T21:00:04 *** jkczyz has joined #bitcoin-core-dev
353 2019-10-12T21:05:08 *** jkczyz has quit IRC
354 2019-10-12T21:17:37 *** gnrp1 has joined #bitcoin-core-dev
355 2019-10-12T21:23:22 *** captjakk has joined #bitcoin-core-dev
356 2019-10-12T21:31:00 *** promag has quit IRC
357 2019-10-12T21:31:00 *** bitcoin-git has joined #bitcoin-core-dev
358 2019-10-12T21:31:00 <bitcoin-git> [bitcoin] promag opened pull request #17120: gui: Fix start timer from non QThread (master...2019-10-fix-timer) https://github.com/bitcoin/bitcoin/pull/17120
359 2019-10-12T21:31:04 *** bitcoin-git has left #bitcoin-core-dev
360 2019-10-12T21:59:58 *** kristapsk has quit IRC
361 2019-10-12T22:00:23 *** kristapsk has joined #bitcoin-core-dev
362 2019-10-12T22:03:00 *** jarthur has quit IRC
363 2019-10-12T22:19:21 *** Guyver2 has quit IRC
364 2019-10-12T22:20:02 *** captjakk has quit IRC
365 2019-10-12T22:22:47 *** meshcollider has quit IRC
366 2019-10-12T22:37:16 *** jarthur has joined #bitcoin-core-dev
367 2019-10-12T22:37:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
368 2019-10-12T22:39:29 *** meshcollider has joined #bitcoin-core-dev
369 2019-10-12T22:44:51 *** Highway61 has quit IRC
370 2019-10-12T22:44:51 *** meshcollider has quit IRC
371 2019-10-12T22:49:13 *** captjakk has joined #bitcoin-core-dev
372 2019-10-12T22:49:47 *** meshcollider has joined #bitcoin-core-dev
373 2019-10-12T22:50:20 *** captjakk has quit IRC
374 2019-10-12T22:50:56 *** shesek has quit IRC
375 2019-10-12T22:56:02 *** goatpig has quit IRC
376 2019-10-12T22:57:37 *** Chris_Stewart_5 has quit IRC
377 2019-10-12T23:00:28 *** Ox207fffff has quit IRC
378 2019-10-12T23:00:47 *** Ox207fffff has joined #bitcoin-core-dev
379 2019-10-12T23:00:56 *** jkczyz has joined #bitcoin-core-dev
380 2019-10-12T23:00:57 *** meshcollider has quit IRC
381 2019-10-12T23:00:57 *** meshcoll- has joined #bitcoin-core-dev
382 2019-10-12T23:01:17 *** meshcoll- has left #bitcoin-core-dev
383 2019-10-12T23:01:24 *** Ox207fffff has quit IRC
384 2019-10-12T23:02:27 *** Ox207fffff has joined #bitcoin-core-dev
385 2019-10-12T23:05:36 *** jkczyz has quit IRC
386 2019-10-12T23:11:22 *** jkczyz has joined #bitcoin-core-dev
387 2019-10-12T23:14:03 *** meshcollider has joined #bitcoin-core-dev
388 2019-10-12T23:14:59 *** meshcollider- has joined #bitcoin-core-dev
389 2019-10-12T23:15:03 *** meshcollider- has left #bitcoin-core-dev
390 2019-10-12T23:15:37 *** jkczyz has quit IRC
391 2019-10-12T23:16:36 *** davterra has quit IRC
392 2019-10-12T23:17:01 *** davterra has joined #bitcoin-core-dev
393 2019-10-12T23:31:36 *** promag has joined #bitcoin-core-dev
394 2019-10-12T23:36:20 *** promag has quit IRC
395 2019-10-12T23:41:08 *** astro has quit IRC
396 2019-10-12T23:44:03 *** astro has joined #bitcoin-core-dev
397 2019-10-12T23:44:47 *** goatpig has joined #bitcoin-core-dev
398 2019-10-12T23:58:27 *** marcoagner has quit IRC