12019-11-04T00:00:02  *** jhf has quit IRC
  22019-11-04T00:00:03  *** ddustin has quit IRC
  32019-11-04T00:00:10  *** michaelfolkson has joined #bitcoin-core-dev
  42019-11-04T00:02:27  *** EagleTM has quit IRC
  52019-11-04T00:08:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  62019-11-04T00:16:51  *** leonardo1 has joined #bitcoin-core-dev
  72019-11-04T00:20:57  *** dviola has quit IRC
  82019-11-04T00:21:41  *** dviola has joined #bitcoin-core-dev
  92019-11-04T00:22:13  *** dviola has joined #bitcoin-core-dev
 102019-11-04T00:34:01  *** TravelingThrough has joined #bitcoin-core-dev
 112019-11-04T00:35:09  *** promag has quit IRC
 122019-11-04T00:35:38  *** Highway61 has joined #bitcoin-core-dev
 132019-11-04T00:35:50  *** Chris_Stewart_5 has quit IRC
 142019-11-04T00:44:17  *** justanotheruser has quit IRC
 152019-11-04T00:45:36  *** cryptoIndio has joined #bitcoin-core-dev
 162019-11-04T00:57:06  *** jarthur has joined #bitcoin-core-dev
 172019-11-04T01:00:48  *** justanotheruser has joined #bitcoin-core-dev
 182019-11-04T01:27:02  *** dviola has quit IRC
 192019-11-04T01:28:04  *** promag has joined #bitcoin-core-dev
 202019-11-04T01:29:55  *** ddustin has joined #bitcoin-core-dev
 212019-11-04T01:34:03  *** ddustin has quit IRC
 222019-11-04T01:35:22  *** cryptoIndio has quit IRC
 232019-11-04T01:35:39  *** cryptoIndio has joined #bitcoin-core-dev
 242019-11-04T01:51:29  *** promag_ has joined #bitcoin-core-dev
 252019-11-04T01:55:57  *** promag_ has quit IRC
 262019-11-04T02:09:57  *** michaelfolkson has quit IRC
 272019-11-04T02:14:35  *** Karyon has quit IRC
 282019-11-04T02:14:59  *** Karyon has joined #bitcoin-core-dev
 292019-11-04T02:16:03  *** michaelfolkson has joined #bitcoin-core-dev
 302019-11-04T02:26:54  *** michaelfolkson has quit IRC
 312019-11-04T02:28:20  *** promag has quit IRC
 322019-11-04T02:40:27  *** Dean_Guss has quit IRC
 332019-11-04T02:47:54  *** tsujp has quit IRC
 342019-11-04T02:50:12  *** tsujp has joined #bitcoin-core-dev
 352019-11-04T02:58:53  *** nsh has quit IRC
 362019-11-04T03:00:01  *** leonardo1 has quit IRC
 372019-11-04T03:02:34  *** Giszmo has quit IRC
 382019-11-04T03:03:23  *** cryptoIndio has quit IRC
 392019-11-04T03:08:06  *** nsh has joined #bitcoin-core-dev
 402019-11-04T03:08:35  *** emilengler has quit IRC
 412019-11-04T03:14:17  *** emilengler has joined #bitcoin-core-dev
 422019-11-04T03:16:35  *** felixfoertsch23 has joined #bitcoin-core-dev
 432019-11-04T03:17:41  *** felixfoertsch has quit IRC
 442019-11-04T03:30:12  *** cryptoIndio has joined #bitcoin-core-dev
 452019-11-04T03:47:46  *** patryk1 has joined #bitcoin-core-dev
 462019-11-04T04:04:41  *** jarthur has quit IRC
 472019-11-04T04:05:11  *** jarthur has joined #bitcoin-core-dev
 482019-11-04T04:07:10  *** Highway61 has quit IRC
 492019-11-04T04:07:44  *** tsujp has quit IRC
 502019-11-04T04:14:47  *** tsujp has joined #bitcoin-core-dev
 512019-11-04T04:28:56  *** promag has joined #bitcoin-core-dev
 522019-11-04T04:33:39  *** promag has quit IRC
 532019-11-04T04:44:49  *** davterra has joined #bitcoin-core-dev
 542019-11-04T04:53:14  *** tsujp has quit IRC
 552019-11-04T04:54:32  *** jarthur has quit IRC
 562019-11-04T04:55:20  *** jarthur has joined #bitcoin-core-dev
 572019-11-04T05:00:12  *** tsujp has joined #bitcoin-core-dev
 582019-11-04T05:08:33  *** nosss2 has quit IRC
 592019-11-04T05:25:35  *** felixfoertsch23 has quit IRC
 602019-11-04T05:25:45  *** felixfoertsch has joined #bitcoin-core-dev
 612019-11-04T05:31:51  *** Victor_sueca has joined #bitcoin-core-dev
 622019-11-04T05:33:51  *** nosss2 has joined #bitcoin-core-dev
 632019-11-04T05:34:39  *** Victorsueca has quit IRC
 642019-11-04T05:38:13  *** nosss2 has quit IRC
 652019-11-04T05:40:34  *** Dean_Guss has joined #bitcoin-core-dev
 662019-11-04T05:43:13  *** nosss2 has joined #bitcoin-core-dev
 672019-11-04T05:44:56  *** jarthur has quit IRC
 682019-11-04T05:46:58  *** nosss2 has quit IRC
 692019-11-04T05:51:36  *** mryandao has quit IRC
 702019-11-04T05:54:02  *** cryptoIndio has quit IRC
 712019-11-04T05:59:25  *** treyzania_ is now known as treyzania
 722019-11-04T06:00:01  *** patryk1 has quit IRC
 732019-11-04T06:03:03  *** Dean_Guss has quit IRC
 742019-11-04T06:03:19  *** Dean_Guss has joined #bitcoin-core-dev
 752019-11-04T06:11:12  *** mryandao has joined #bitcoin-core-dev
 762019-11-04T06:12:43  *** mryandao has joined #bitcoin-core-dev
 772019-11-04T06:16:58  *** profmac has quit IRC
 782019-11-04T06:17:52  *** Suntop1 has joined #bitcoin-core-dev
 792019-11-04T06:29:08  *** cryptoIndio has joined #bitcoin-core-dev
 802019-11-04T06:29:25  *** profmac has joined #bitcoin-core-dev
 812019-11-04T06:48:17  *** jeremyrubin has quit IRC
 822019-11-04T06:59:12  *** Highway61 has joined #bitcoin-core-dev
 832019-11-04T06:59:55  *** timothy has joined #bitcoin-core-dev
 842019-11-04T07:00:12  *** mryandao has quit IRC
 852019-11-04T07:00:22  *** promag has joined #bitcoin-core-dev
 862019-11-04T07:03:14  *** Highway61 has quit IRC
 872019-11-04T07:08:50  *** promag has quit IRC
 882019-11-04T07:14:26  *** mryandao has joined #bitcoin-core-dev
 892019-11-04T07:15:34  *** cryptoIn_ has joined #bitcoin-core-dev
 902019-11-04T07:16:03  *** timothy has quit IRC
 912019-11-04T07:17:27  *** timothy has joined #bitcoin-core-dev
 922019-11-04T07:18:17  *** cryptoIndio has quit IRC
 932019-11-04T07:34:54  *** AaronvanW has joined #bitcoin-core-dev
 942019-11-04T07:36:33  *** jonatack has joined #bitcoin-core-dev
 952019-11-04T07:44:54  *** timothy has quit IRC
 962019-11-04T07:47:01  *** jungly has joined #bitcoin-core-dev
 972019-11-04T07:59:02  *** cryptoIn_ has quit IRC
 982019-11-04T07:59:35  *** cryptoIndio has joined #bitcoin-core-dev
 992019-11-04T08:17:56  *** timothy has joined #bitcoin-core-dev
1002019-11-04T08:20:58  *** jonatack has quit IRC
1012019-11-04T08:22:55  *** jonatack has joined #bitcoin-core-dev
1022019-11-04T08:25:48  *** AaronvanW has quit IRC
1032019-11-04T08:27:31  *** nijynot has joined #bitcoin-core-dev
1042019-11-04T08:36:03  *** timothy has quit IRC
1052019-11-04T08:42:23  *** timothy has joined #bitcoin-core-dev
1062019-11-04T08:44:53  *** luke-jr has quit IRC
1072019-11-04T08:48:24  *** luke-jr has joined #bitcoin-core-dev
1082019-11-04T08:50:46  *** marcoagner has joined #bitcoin-core-dev
1092019-11-04T08:52:14  *** kljasdfvv has joined #bitcoin-core-dev
1102019-11-04T08:52:27  *** kljasdfvv has quit IRC
1112019-11-04T08:54:45  *** TravelingThrough has quit IRC
1122019-11-04T08:59:31  *** Randolf has joined #bitcoin-core-dev
1132019-11-04T09:00:01  *** Suntop1 has quit IRC
1142019-11-04T09:00:31  *** kljasdfvv has joined #bitcoin-core-dev
1152019-11-04T09:07:57  *** drizztbsd has joined #bitcoin-core-dev
1162019-11-04T09:08:27  *** timothy has quit IRC
1172019-11-04T09:11:50  *** Giszmo has joined #bitcoin-core-dev
1182019-11-04T09:18:12  *** aclark has joined #bitcoin-core-dev
1192019-11-04T09:19:35  *** bitcoin-git has joined #bitcoin-core-dev
1202019-11-04T09:19:35  <bitcoin-git> [bitcoin] jonatack opened pull request #17362: test: speed up wallet_avoidreuse, add logging (master...wallet_avoidreuse-test-improvements) https://github.com/bitcoin/bitcoin/pull/17362
1212019-11-04T09:19:36  *** bitcoin-git has left #bitcoin-core-dev
1222019-11-04T09:31:44  *** cryptoIndio has quit IRC
1232019-11-04T09:35:18  *** drizztbsd has quit IRC
1242019-11-04T09:35:47  *** drizztbsd has joined #bitcoin-core-dev
1252019-11-04T09:40:29  *** jpe has joined #bitcoin-core-dev
1262019-11-04T09:42:54  *** cryptoIndio has joined #bitcoin-core-dev
1272019-11-04T09:53:48  *** nosss2 has joined #bitcoin-core-dev
1282019-11-04T09:59:02  *** nosss2 has quit IRC
1292019-11-04T10:10:22  *** nosss2 has joined #bitcoin-core-dev
1302019-11-04T10:14:01  *** drizztbsd has quit IRC
1312019-11-04T10:15:41  *** drizztbsd has joined #bitcoin-core-dev
1322019-11-04T10:18:02  *** nosss2 has quit IRC
1332019-11-04T10:23:35  *** nosss2 has joined #bitcoin-core-dev
1342019-11-04T10:28:37  *** nosss2 has quit IRC
1352019-11-04T10:32:15  *** nosss2 has joined #bitcoin-core-dev
1362019-11-04T10:38:02  *** mryandao has quit IRC
1372019-11-04T10:39:32  *** rockhouse5 is now known as rockhouse
1382019-11-04T10:39:41  *** nosss2 has quit IRC
1392019-11-04T10:40:04  *** mryandao has joined #bitcoin-core-dev
1402019-11-04T10:45:33  *** cryptoIndio has quit IRC
1412019-11-04T10:51:38  *** nosss2 has joined #bitcoin-core-dev
1422019-11-04T10:56:22  *** nosss2 has quit IRC
1432019-11-04T10:58:12  *** timothy has joined #bitcoin-core-dev
1442019-11-04T10:58:50  *** drizztbsd has quit IRC
1452019-11-04T11:06:00  *** nosss2 has joined #bitcoin-core-dev
1462019-11-04T11:06:17  *** IGHOR has quit IRC
1472019-11-04T11:08:51  *** IGHOR has joined #bitcoin-core-dev
1482019-11-04T11:11:03  *** nosss2 has quit IRC
1492019-11-04T11:11:07  *** IGHOR has quit IRC
1502019-11-04T11:14:06  *** IGHOR has joined #bitcoin-core-dev
1512019-11-04T11:17:38  *** cryptoIndio has joined #bitcoin-core-dev
1522019-11-04T11:17:53  *** IGHOR has quit IRC
1532019-11-04T11:19:16  *** nosss2 has joined #bitcoin-core-dev
1542019-11-04T11:23:27  *** cryptoIndio has quit IRC
1552019-11-04T11:24:00  *** promag has joined #bitcoin-core-dev
1562019-11-04T11:26:31  *** nosss2 has quit IRC
1572019-11-04T11:28:14  *** promag has quit IRC
1582019-11-04T11:30:09  *** IGHOR has joined #bitcoin-core-dev
1592019-11-04T11:30:19  *** michaelfolkson has joined #bitcoin-core-dev
1602019-11-04T11:31:49  *** nosss2 has joined #bitcoin-core-dev
1612019-11-04T11:32:18  *** michaelfolkson has quit IRC
1622019-11-04T11:34:10  *** nosss2 has quit IRC
1632019-11-04T11:35:12  *** IGHOR has quit IRC
1642019-11-04T11:38:00  *** IGHOR has joined #bitcoin-core-dev
1652019-11-04T11:39:29  *** nosss2 has joined #bitcoin-core-dev
1662019-11-04T11:41:38  *** IGHOR has quit IRC
1672019-11-04T11:44:28  *** nosss2 has quit IRC
1682019-11-04T11:46:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1692019-11-04T11:46:21  *** IGHOR has joined #bitcoin-core-dev
1702019-11-04T12:00:02  *** aclark has quit IRC
1712019-11-04T12:01:11  *** nosss2 has joined #bitcoin-core-dev
1722019-11-04T12:06:08  *** nosss2 has quit IRC
1732019-11-04T12:08:57  *** nijynot has quit IRC
1742019-11-04T12:11:57  *** nosss2 has joined #bitcoin-core-dev
1752019-11-04T12:16:26  *** nosss2 has quit IRC
1762019-11-04T12:17:33  *** nijynot has joined #bitcoin-core-dev
1772019-11-04T12:17:48  *** RISCi_ATOM1 has joined #bitcoin-core-dev
1782019-11-04T12:19:07  *** bitcoin-git has joined #bitcoin-core-dev
1792019-11-04T12:19:07  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/463eab5e1418...c4b8dd20600f
1802019-11-04T12:19:08  <bitcoin-git> bitcoin/master f44abe4 Hennadii Stepanov: refactor: Remove addrdb.h dependency from node.h
1812019-11-04T12:19:08  <bitcoin-git> bitcoin/master c4b8dd2 Wladimir J. van der Laan: Merge #17297: refactor: Remove addrdb.h dependency from node.h
1822019-11-04T12:19:10  *** bitcoin-git has left #bitcoin-core-dev
1832019-11-04T12:19:27  *** Randolf has quit IRC
1842019-11-04T12:19:27  *** bitcoin-git has joined #bitcoin-core-dev
1852019-11-04T12:19:27  <bitcoin-git> [bitcoin] laanwj merged pull request #17297:  refactor: Remove addrdb.h dependency from node.h  (master...20191029-refactor-addrdb) https://github.com/bitcoin/bitcoin/pull/17297
1862019-11-04T12:19:28  *** bitcoin-git has left #bitcoin-core-dev
1872019-11-04T12:24:47  *** michaelfolkson has joined #bitcoin-core-dev
1882019-11-04T12:29:18  *** Highway61 has joined #bitcoin-core-dev
1892019-11-04T12:29:34  *** nosss2 has joined #bitcoin-core-dev
1902019-11-04T12:33:25  *** bitcoin-git has joined #bitcoin-core-dev
1912019-11-04T12:33:26  <bitcoin-git> [bitcoin] Sjors closed pull request #17246: wallet: avoid knapsack when there's no change (master...2019/10/less-knapsack) https://github.com/bitcoin/bitcoin/pull/17246
1922019-11-04T12:33:29  *** lightlike has joined #bitcoin-core-dev
1932019-11-04T12:33:38  *** bitcoin-git has left #bitcoin-core-dev
1942019-11-04T12:34:15  *** nijynot has quit IRC
1952019-11-04T12:34:25  *** nosss2 has quit IRC
1962019-11-04T12:34:25  *** bitcoin-git has joined #bitcoin-core-dev
1972019-11-04T12:34:25  <bitcoin-git> [bitcoin] laanwj pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/c4b8dd20600f...91fbcf41b35c
1982019-11-04T12:34:26  <bitcoin-git> bitcoin/master 0b0cff3 Igor Cota: Add support for building Android dependencies
1992019-11-04T12:34:27  <bitcoin-git> bitcoin/master c2a749c Igor Cota: Add example Android host-platform-triplet and options
2002019-11-04T12:34:27  <bitcoin-git> bitcoin/master 9c4cb01 Igor Cota: Add ranlib to android.mk hosts file (fix OSX Android NDK build)
2012019-11-04T12:34:28  *** bitcoin-git has left #bitcoin-core-dev
2022019-11-04T12:35:00  *** bitcoin-git has joined #bitcoin-core-dev
2032019-11-04T12:35:01  <bitcoin-git> [bitcoin] laanwj merged pull request #16110: depends: Add Android NDK support (master...add-android-to-depends) https://github.com/bitcoin/bitcoin/pull/16110
2042019-11-04T12:35:01  *** bitcoin-git has left #bitcoin-core-dev
2052019-11-04T12:36:16  *** IGHOR has quit IRC
2062019-11-04T12:37:38  *** nosss2 has joined #bitcoin-core-dev
2072019-11-04T12:42:18  *** nosss2 has quit IRC
2082019-11-04T12:47:37  *** michaelfolkson has quit IRC
2092019-11-04T12:50:12  *** nijynot has joined #bitcoin-core-dev
2102019-11-04T12:52:31  *** IGHOR has joined #bitcoin-core-dev
2112019-11-04T12:53:03  *** michaelfolkson has joined #bitcoin-core-dev
2122019-11-04T12:53:53  *** michaelfolkson has quit IRC
2132019-11-04T12:54:35  *** nosss2 has joined #bitcoin-core-dev
2142019-11-04T12:55:08  *** cryptoIndio has joined #bitcoin-core-dev
2152019-11-04T12:56:37  *** Chris_Stewart_5 has quit IRC
2162019-11-04T12:57:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2172019-11-04T12:58:57  *** nosss2 has quit IRC
2182019-11-04T12:59:37  *** IGHOR has quit IRC
2192019-11-04T13:01:15  *** cryptoIndio has quit IRC
2202019-11-04T13:04:43  *** toti has joined #bitcoin-core-dev
2212019-11-04T13:04:44  *** drizztbsd has joined #bitcoin-core-dev
2222019-11-04T13:04:47  *** bitcoin-git has joined #bitcoin-core-dev
2232019-11-04T13:04:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91fbcf41b35c...73b26e38d7a1
2242019-11-04T13:04:48  <bitcoin-git> bitcoin/master ac83133 randymcmillan: doc: Fix some misspellings
2252019-11-04T13:04:48  <bitcoin-git> bitcoin/master 73b26e3 MarcoFalke: Merge #17351: doc: Fix some misspellings
2262019-11-04T13:04:50  *** bitcoin-git has left #bitcoin-core-dev
2272019-11-04T13:05:07  *** toti is now known as Guest80584
2282019-11-04T13:05:08  *** bitcoin-git has joined #bitcoin-core-dev
2292019-11-04T13:05:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17351: doc: Fix some misspellings (master...makeseeds-py) https://github.com/bitcoin/bitcoin/pull/17351
2302019-11-04T13:05:09  *** bitcoin-git has left #bitcoin-core-dev
2312019-11-04T13:07:03  *** timothy has quit IRC
2322019-11-04T13:07:04  *** nosss2 has joined #bitcoin-core-dev
2332019-11-04T13:09:17  *** tsujp has quit IRC
2342019-11-04T13:11:53  *** nosss2 has quit IRC
2352019-11-04T13:13:35  *** Guest80584 has left #bitcoin-core-dev
2362019-11-04T13:14:19  *** nosss2 has joined #bitcoin-core-dev
2372019-11-04T13:15:12  *** tsujp has joined #bitcoin-core-dev
2382019-11-04T13:17:53  *** bitcoin-git has joined #bitcoin-core-dev
2392019-11-04T13:17:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/73b26e38d7a1...5933c6d9245d
2402019-11-04T13:17:54  <bitcoin-git> bitcoin/master fa54b3e MarcoFalke: test: move-only ComputeFilter to src/test/lib/blockfilter
2412019-11-04T13:17:55  <bitcoin-git> bitcoin/master fa0a731 MarcoFalke: test: Add RegTestingSetup to setup_common
2422019-11-04T13:17:55  <bitcoin-git> bitcoin/master 5933c6d MarcoFalke: Merge #17228: test: Add RegTestingSetup to setup_common
2432019-11-04T13:17:57  *** bitcoin-git has left #bitcoin-core-dev
2442019-11-04T13:18:13  *** bitcoin-git has joined #bitcoin-core-dev
2452019-11-04T13:18:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17228: test: Add RegTestingSetup to setup_common (master...1910-RegTestingSetup) https://github.com/bitcoin/bitcoin/pull/17228
2462019-11-04T13:18:14  *** bitcoin-git has left #bitcoin-core-dev
2472019-11-04T13:19:15  *** nosss2 has quit IRC
2482019-11-04T13:19:59  *** nosss2 has joined #bitcoin-core-dev
2492019-11-04T13:22:08  *** IGHOR has joined #bitcoin-core-dev
2502019-11-04T13:23:24  *** timothy has joined #bitcoin-core-dev
2512019-11-04T13:23:55  *** drizztbsd has quit IRC
2522019-11-04T13:24:18  *** bitcoin-git has joined #bitcoin-core-dev
2532019-11-04T13:24:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5933c6d9245d...def69e5a8632
2542019-11-04T13:24:20  <bitcoin-git> bitcoin/master fafa064 MarcoFalke: ci: Remove ccache requirement on the host
2552019-11-04T13:24:21  <bitcoin-git> bitcoin/master facc0da MarcoFalke: travis: Run unit and functional tests on native arm
2562019-11-04T13:24:21  <bitcoin-git> bitcoin/master def69e5 MarcoFalke: Merge #17233: travis: Run unit and functional tests on native arm
2572019-11-04T13:24:23  *** bitcoin-git has left #bitcoin-core-dev
2582019-11-04T13:24:24  *** nosss2 has quit IRC
2592019-11-04T13:24:38  *** bitcoin-git has joined #bitcoin-core-dev
2602019-11-04T13:24:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17233: travis: Run unit and functional tests on native arm (master...1910-travisNativeArm) https://github.com/bitcoin/bitcoin/pull/17233
2612019-11-04T13:24:39  *** bitcoin-git has left #bitcoin-core-dev
2622019-11-04T13:24:57  *** nosss2 has joined #bitcoin-core-dev
2632019-11-04T13:24:59  *** jonatack has quit IRC
2642019-11-04T13:32:10  *** IGHOR has quit IRC
2652019-11-04T13:33:27  *** bitcoin-git has joined #bitcoin-core-dev
2662019-11-04T13:33:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/def69e5a8632...fba574c908bb
2672019-11-04T13:33:29  <bitcoin-git> bitcoin/master 29f8434 Hennadii Stepanov: refactor: Remove redundant PSBT copy constructor
2682019-11-04T13:33:30  <bitcoin-git> bitcoin/master fa89198 MarcoFalke: bench: Remove redundant copy constructor in mempool_stress
2692019-11-04T13:33:30  <bitcoin-git> bitcoin/master fba574c MarcoFalke: Merge #17349: Remove redundant copy constructors
2702019-11-04T13:33:32  *** bitcoin-git has left #bitcoin-core-dev
2712019-11-04T13:33:37  *** nosss2 has quit IRC
2722019-11-04T13:33:47  *** bitcoin-git has joined #bitcoin-core-dev
2732019-11-04T13:33:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17349: Remove redundant copy constructors (master...1911-copyConstructorWhy) https://github.com/bitcoin/bitcoin/pull/17349
2742019-11-04T13:33:48  *** bitcoin-git has left #bitcoin-core-dev
2752019-11-04T13:35:43  *** cryptoIndio has joined #bitcoin-core-dev
2762019-11-04T13:36:31  *** thoragh has joined #bitcoin-core-dev
2772019-11-04T13:40:17  *** cryptoIndio has quit IRC
2782019-11-04T13:45:15  *** captjakk has quit IRC
2792019-11-04T13:46:12  *** Chris_Stewart_5 has quit IRC
2802019-11-04T13:47:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2812019-11-04T13:49:45  *** diogosergio has joined #bitcoin-core-dev
2822019-11-04T13:50:18  *** IGHOR has joined #bitcoin-core-dev
2832019-11-04T13:58:16  *** michaelfolkson has joined #bitcoin-core-dev
2842019-11-04T14:02:48  *** thoragh has quit IRC
2852019-11-04T14:04:11  *** Jackielove4u has quit IRC
2862019-11-04T14:05:19  *** thoragh has joined #bitcoin-core-dev
2872019-11-04T14:11:09  *** bitcoin-git has joined #bitcoin-core-dev
2882019-11-04T14:11:10  <bitcoin-git> [bitcoin] theStack opened pull request #17363: test: add "diamond" unit test to MempoolAncestryTests (master...20191104-test-add_diamond_ancestors_unit_test) https://github.com/bitcoin/bitcoin/pull/17363
2892019-11-04T14:11:11  *** bitcoin-git has left #bitcoin-core-dev
2902019-11-04T14:21:24  *** oneark has joined #bitcoin-core-dev
2912019-11-04T14:22:04  *** bitcoin-git has joined #bitcoin-core-dev
2922019-11-04T14:22:05  <bitcoin-git> [bitcoin] stefanwouldgo closed pull request #17008: build: bump libevent to 2.1.11 in depends (master...master) https://github.com/bitcoin/bitcoin/pull/17008
2932019-11-04T14:22:05  *** bitcoin-git has left #bitcoin-core-dev
2942019-11-04T14:22:24  *** bitcoin-git has joined #bitcoin-core-dev
2952019-11-04T14:22:25  <bitcoin-git> [bitcoin] stefanwouldgo reopened pull request #17008: build: bump libevent to 2.1.11 in depends (master...master) https://github.com/bitcoin/bitcoin/pull/17008
2962019-11-04T14:22:25  *** bitcoin-git has left #bitcoin-core-dev
2972019-11-04T14:23:18  *** bitcoin-git has joined #bitcoin-core-dev
2982019-11-04T14:23:19  <bitcoin-git> [bitcoin] sipsorcery opened pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
2992019-11-04T14:23:20  *** bitcoin-git has left #bitcoin-core-dev
3002019-11-04T14:27:50  *** IGHOR has quit IRC
3012019-11-04T14:29:02  *** spaced0ut has quit IRC
3022019-11-04T14:30:41  *** spaced0ut has joined #bitcoin-core-dev
3032019-11-04T14:34:24  <instagibbs> #17304 looks mergeable
3042019-11-04T14:34:28  <gribble> https://github.com/bitcoin/bitcoin/issues/17304 | refactor: Move many functions into LegacyScriptPubKeyMan and further separate it from CWallet by achow101 · Pull Request #17304 · bitcoin/bitcoin · GitHub
3052019-11-04T14:34:30  <instagibbs> 4 fresh code review acks
3062019-11-04T14:38:12  *** bsm1175321 has joined #bitcoin-core-dev
3072019-11-04T14:39:43  <luke-jr> backport to 0.19? #17102
3082019-11-04T14:39:44  <gribble> https://github.com/bitcoin/bitcoin/issues/17102 | doc: Add missing indexes/blockfilter/basic to doc/files.md by MarcoFalke · Pull Request #17102 · bitcoin/bitcoin · GitHub
3092019-11-04T14:44:14  *** ajonas has joined #bitcoin-core-dev
3102019-11-04T14:55:30  *** Jackielove4u has joined #bitcoin-core-dev
3112019-11-04T14:55:42  *** davterra has quit IRC
3122019-11-04T14:56:12  *** davterra has joined #bitcoin-core-dev
3132019-11-04T15:00:02  *** RISCi_ATOM1 has quit IRC
3142019-11-04T15:02:12  *** bitcoin-git has joined #bitcoin-core-dev
3152019-11-04T15:02:14  <bitcoin-git> [bitcoin] laanwj pushed 19 commits to master: https://github.com/bitcoin/bitcoin/compare/fba574c908bb...bbc9e4133cc5
3162019-11-04T15:02:14  <bitcoin-git> bitcoin/master b4cb18b Andrew Chow: MOVEONLY: Reorder LegacyScriptPubKeyMan methods
3172019-11-04T15:02:15  <bitcoin-git> bitcoin/master 533d8b3 Andrew Chow: Refactor: Declare LegacyScriptPubKeyMan methods as virtual
3182019-11-04T15:02:16  <bitcoin-git> bitcoin/master acedc5b Andrew Chow: Refactor: Add new ScriptPubKeyMan virtual methods
3192019-11-04T15:02:18  *** bitcoin-git has left #bitcoin-core-dev
3202019-11-04T15:02:32  *** bitcoin-git has joined #bitcoin-core-dev
3212019-11-04T15:02:33  <bitcoin-git> [bitcoin] laanwj merged pull request #17304: refactor: Move many functions into LegacyScriptPubKeyMan and further separate it from CWallet (master...wallet-box-pr-3) https://github.com/bitcoin/bitcoin/pull/17304
3222019-11-04T15:02:34  *** bitcoin-git has left #bitcoin-core-dev
3232019-11-04T15:12:00  *** cubancorona has quit IRC
3242019-11-04T15:15:39  *** bitcoin-git has joined #bitcoin-core-dev
3252019-11-04T15:15:39  <bitcoin-git> [bitcoin] icota opened pull request #17365: depends: update README.md with working Android targets and API levels (master...update-android-depends-doc) https://github.com/bitcoin/bitcoin/pull/17365
3262019-11-04T15:15:42  *** bitcoin-git has left #bitcoin-core-dev
3272019-11-04T15:17:11  *** promag has joined #bitcoin-core-dev
3282019-11-04T15:18:07  *** jb55 has joined #bitcoin-core-dev
3292019-11-04T15:21:41  *** cryptoIndio has joined #bitcoin-core-dev
3302019-11-04T15:27:37  *** cryptoIndio has quit IRC
3312019-11-04T15:34:15  *** Highway61 has quit IRC
3322019-11-04T15:37:17  *** nosss2 has joined #bitcoin-core-dev
3332019-11-04T15:44:36  *** michaelfolkson has quit IRC
3342019-11-04T15:47:37  *** codestr0m has joined #bitcoin-core-dev
3352019-11-04T15:48:13  <achow101> \o/
3362019-11-04T15:48:54  <fanquake> achow101 18 out of how many commits left in the wallet refactor pipeline?
3372019-11-04T15:49:23  <achow101> 20?
3382019-11-04T15:49:23  <provoostenator> rebase time!
3392019-11-04T15:49:33  <achow101> we'll find out after rebase :)
3402019-11-04T16:01:34  *** michaelfolkson has joined #bitcoin-core-dev
3412019-11-04T16:07:29  *** bitcoin-git has joined #bitcoin-core-dev
3422019-11-04T16:07:29  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17366: test: Reset global args between test suites (master...1911-testResetGlobals) https://github.com/bitcoin/bitcoin/pull/17366
3432019-11-04T16:07:32  *** bitcoin-git has left #bitcoin-core-dev
3442019-11-04T16:08:22  *** nosss2 has quit IRC
3452019-11-04T16:14:27  *** Guyver2 has joined #bitcoin-core-dev
3462019-11-04T16:18:25  *** bitcoin-git has joined #bitcoin-core-dev
3472019-11-04T16:18:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bbc9e4133cc5...8f9df2ed88c4
3482019-11-04T16:18:26  <bitcoin-git> bitcoin/master 090b75c User: p2p: Avoid allocating memory for addrKnown where we don't need it
3492019-11-04T16:18:27  <bitcoin-git> bitcoin/master a552e84 User: added asserts to check m_addr_known when it's used
3502019-11-04T16:18:27  <bitcoin-git> bitcoin/master b6d2183 User: Minor refactoring to remove implied m_addr_relay_peer.
3512019-11-04T16:18:29  *** bitcoin-git has left #bitcoin-core-dev
3522019-11-04T16:18:45  *** bitcoin-git has joined #bitcoin-core-dev
3532019-11-04T16:18:45  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17164: p2p: Avoid allocating memory for addrKnown where we don't need it (master...addr_relay_optimization_4) https://github.com/bitcoin/bitcoin/pull/17164
3542019-11-04T16:18:46  *** bitcoin-git has left #bitcoin-core-dev
3552019-11-04T16:20:14  *** TravelingThrough has joined #bitcoin-core-dev
3562019-11-04T16:23:06  *** jonatack has joined #bitcoin-core-dev
3572019-11-04T16:28:55  *** bitcoin-git has joined #bitcoin-core-dev
3582019-11-04T16:28:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f9df2ed88c4...6cb10c14c600
3592019-11-04T16:28:56  <bitcoin-git> bitcoin/master 8d8e5a7 Sebastian Falbesoner: test: use default address type (bech32) for wallet_bumpfee tests
3602019-11-04T16:28:57  <bitcoin-git> bitcoin/master 6cb10c1 MarcoFalke: Merge #17199: test: use default address type (bech32) for wallet_bumpfee t...
3612019-11-04T16:28:58  *** bitcoin-git has left #bitcoin-core-dev
3622019-11-04T16:29:05  *** marcinja has quit IRC
3632019-11-04T16:29:15  *** bitcoin-git has joined #bitcoin-core-dev
3642019-11-04T16:29:15  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17199: test: use default address type (bech32) for wallet_bumpfee tests (master...20191020-test-wallet-bumpfee_adapt_constants_after_default_address_change) https://github.com/bitcoin/bitcoin/pull/17199
3652019-11-04T16:29:16  *** bitcoin-git has left #bitcoin-core-dev
3662019-11-04T16:31:06  *** ddustin has joined #bitcoin-core-dev
3672019-11-04T16:34:45  *** bitcoin-git has joined #bitcoin-core-dev
3682019-11-04T16:34:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6cb10c14c600...94a26b192f18
3692019-11-04T16:34:45  <bitcoin-git> bitcoin/master c98bd13 Adam Jonas: replace asserts in RPC code with CHECK_NONFATAL and add linter
3702019-11-04T16:34:46  <bitcoin-git> bitcoin/master 94a26b1 MarcoFalke: Merge #17318: replace asserts in RPC code with CHECK_NONFATAL and add lint...
3712019-11-04T16:34:47  *** bitcoin-git has left #bitcoin-core-dev
3722019-11-04T16:35:04  *** bitcoin-git has joined #bitcoin-core-dev
3732019-11-04T16:35:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17318: replace asserts in RPC code with CHECK_NONFATAL and add linter (master...replace-rpc-asserts-for-CHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17318
3742019-11-04T16:35:05  *** bitcoin-git has left #bitcoin-core-dev
3752019-11-04T16:36:03  *** ddustin has quit IRC
3762019-11-04T16:47:35  *** nijynot has quit IRC
3772019-11-04T16:51:15  *** diogosergio has quit IRC
3782019-11-04T16:53:40  *** DougieBot5000 has quit IRC
3792019-11-04T16:53:56  *** DougieBot5000 has joined #bitcoin-core-dev
3802019-11-04T16:55:41  *** alko89 has quit IRC
3812019-11-04T16:56:07  *** alko89 has joined #bitcoin-core-dev
3822019-11-04T16:59:45  *** timothy has quit IRC
3832019-11-04T17:03:08  *** diogosergio has joined #bitcoin-core-dev
3842019-11-04T17:06:27  *** Dean_Guss has quit IRC
3852019-11-04T17:06:44  *** michaelfolkson has quit IRC
3862019-11-04T17:07:16  *** Dean_Guss has joined #bitcoin-core-dev
3872019-11-04T17:09:27  *** jarthur has joined #bitcoin-core-dev
3882019-11-04T17:10:44  *** ghost43_ has joined #bitcoin-core-dev
3892019-11-04T17:10:50  *** ghost43 has quit IRC
3902019-11-04T17:12:50  *** diogosergio has quit IRC
3912019-11-04T17:15:27  *** Dean_Guss has quit IRC
3922019-11-04T17:15:59  *** Dean_Guss has joined #bitcoin-core-dev
3932019-11-04T17:20:16  *** TTT has joined #bitcoin-core-dev
3942019-11-04T17:23:37  *** TravelingThrough has quit IRC
3952019-11-04T17:28:07  *** marcinja has joined #bitcoin-core-dev
3962019-11-04T17:41:52  *** wsm has quit IRC
3972019-11-04T17:42:52  *** michaelfolkson has joined #bitcoin-core-dev
3982019-11-04T17:43:44  *** wsm has joined #bitcoin-core-dev
3992019-11-04T17:55:02  *** harrigan has quit IRC
4002019-11-04T17:55:41  *** harrigan has joined #bitcoin-core-dev
4012019-11-04T18:00:01  *** codestr0m has quit IRC
4022019-11-04T18:14:45  *** michaelfolkson has quit IRC
4032019-11-04T18:17:27  *** Guyver2 has quit IRC
4042019-11-04T18:17:46  *** ozbot has joined #bitcoin-core-dev
4052019-11-04T18:18:09  *** diogosergio has joined #bitcoin-core-dev
4062019-11-04T18:19:08  *** Chris_Stewart_5 has quit IRC
4072019-11-04T18:20:36  *** TravelingThrough has joined #bitcoin-core-dev
4082019-11-04T18:24:04  *** TTT has quit IRC
4092019-11-04T18:26:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4102019-11-04T18:29:41  *** michaelfolkson has joined #bitcoin-core-dev
4112019-11-04T18:36:12  *** thoragh has quit IRC
4122019-11-04T18:44:03  *** thoragh has joined #bitcoin-core-dev
4132019-11-04T18:44:37  *** r251d has joined #bitcoin-core-dev
4142019-11-04T18:57:43  *** oneark has quit IRC
4152019-11-04T18:58:08  *** reallll has joined #bitcoin-core-dev
4162019-11-04T19:00:38  *** ddustin has joined #bitcoin-core-dev
4172019-11-04T19:00:41  *** arik_ has joined #bitcoin-core-dev
4182019-11-04T19:01:14  *** belcher has quit IRC
4192019-11-04T19:02:15  *** arik_ has joined #bitcoin-core-dev
4202019-11-04T19:05:07  *** bitcoin-git has joined #bitcoin-core-dev
4212019-11-04T19:05:07  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17367: ci: Run non-cross-compile builds natively (master...1911-ciNative) https://github.com/bitcoin/bitcoin/pull/17367
4222019-11-04T19:05:08  *** bitcoin-git has left #bitcoin-core-dev
4232019-11-04T19:05:27  *** ddustin has quit IRC
4242019-11-04T19:06:28  *** ddustin has joined #bitcoin-core-dev
4252019-11-04T19:10:13  *** ddustin has quit IRC
4262019-11-04T19:10:33  *** ddustin has joined #bitcoin-core-dev
4272019-11-04T19:15:48  *** reallll is now known as belcher
4282019-11-04T19:20:32  *** TTT has joined #bitcoin-core-dev
4292019-11-04T19:21:38  *** ddustin has quit IRC
4302019-11-04T19:21:54  *** bitcoin-git has joined #bitcoin-core-dev
4312019-11-04T19:21:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94a26b192f18...33b155f28732
4322019-11-04T19:21:55  <bitcoin-git> bitcoin/master fa07b8b MarcoFalke: test: Reset global args between test suites
4332019-11-04T19:21:55  <bitcoin-git> bitcoin/master 33b155f MarcoFalke: Merge #17366: test: Reset global args between test suites
4342019-11-04T19:21:56  *** ddustin has joined #bitcoin-core-dev
4352019-11-04T19:21:57  *** bitcoin-git has left #bitcoin-core-dev
4362019-11-04T19:22:14  *** bitcoin-git has joined #bitcoin-core-dev
4372019-11-04T19:22:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17366: test: Reset global args between test suites (master...1911-testResetGlobals) https://github.com/bitcoin/bitcoin/pull/17366
4382019-11-04T19:22:15  *** bitcoin-git has left #bitcoin-core-dev
4392019-11-04T19:24:30  *** TravelingThrough has quit IRC
4402019-11-04T19:25:07  *** jeremyrubin has joined #bitcoin-core-dev
4412019-11-04T19:28:50  *** thoragh has quit IRC
4422019-11-04T19:31:37  *** ddustin_ has joined #bitcoin-core-dev
4432019-11-04T19:32:15  *** jarthur_ has joined #bitcoin-core-dev
4442019-11-04T19:34:37  *** jarthur has quit IRC
4452019-11-04T19:34:50  *** ddustin has quit IRC
4462019-11-04T19:35:07  *** fox2p has quit IRC
4472019-11-04T19:35:46  *** EagleTM has joined #bitcoin-core-dev
4482019-11-04T19:37:05  *** b10c has joined #bitcoin-core-dev
4492019-11-04T19:42:55  *** b10c_ has joined #bitcoin-core-dev
4502019-11-04T19:45:39  *** b10c has quit IRC
4512019-11-04T19:46:31  *** bitcoin-git has joined #bitcoin-core-dev
4522019-11-04T19:46:31  <bitcoin-git> [bitcoin] fanquake opened pull request #17368: cli: fix -getinfo output when compiled with no wallet (master...fix_getinfo_no_wallet) https://github.com/bitcoin/bitcoin/pull/17368
4532019-11-04T19:46:32  *** bitcoin-git has left #bitcoin-core-dev
4542019-11-04T19:50:29  *** b10c_ has joined #bitcoin-core-dev
4552019-11-04T19:50:52  *** thoragh has joined #bitcoin-core-dev
4562019-11-04T19:52:01  *** b10c has joined #bitcoin-core-dev
4572019-11-04T19:52:52  *** b10c has joined #bitcoin-core-dev
4582019-11-04T19:53:57  *** b10c_ has quit IRC
4592019-11-04T19:55:23  *** bitcoin-git has joined #bitcoin-core-dev
4602019-11-04T19:55:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/33b155f28732...bc38bb9a6036
4612019-11-04T19:55:26  <bitcoin-git> bitcoin/master ede8b76 JamesC: Remove network_event_loop instance in close()
4622019-11-04T19:55:26  <bitcoin-git> bitcoin/master 6b71241 JamesC: Refactor TestFramework main() into setup/shutdown
4632019-11-04T19:55:27  <bitcoin-git> bitcoin/master 6f40820 JamesC: Add closing and flushing of logging handlers
4642019-11-04T19:55:29  *** bitcoin-git has left #bitcoin-core-dev
4652019-11-04T19:55:44  *** bitcoin-git has joined #bitcoin-core-dev
4662019-11-04T19:55:45  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17288: Added TestShell class for interactive Python environments. (master...2019-10-testwrapper) https://github.com/bitcoin/bitcoin/pull/17288
4672019-11-04T19:55:45  *** bitcoin-git has left #bitcoin-core-dev
4682019-11-04T19:58:11  *** michaelfolkson has quit IRC
4692019-11-04T20:02:59  *** bitcoin-git has joined #bitcoin-core-dev
4702019-11-04T20:03:00  <bitcoin-git> [bitcoin] fanquake closed pull request #17128: gui: remove unnecessary shortcuts in bitcoingui files (master...clean-bitcoingui) https://github.com/bitcoin/bitcoin/pull/17128
4712019-11-04T20:03:01  *** bitcoin-git has left #bitcoin-core-dev
4722019-11-04T20:06:23  *** b10c has quit IRC
4732019-11-04T20:06:43  *** b10c has joined #bitcoin-core-dev
4742019-11-04T20:08:32  *** b10c has quit IRC
4752019-11-04T20:08:47  *** b10c has joined #bitcoin-core-dev
4762019-11-04T20:09:03  *** b10c has joined #bitcoin-core-dev
4772019-11-04T20:09:40  *** b10c has joined #bitcoin-core-dev
4782019-11-04T20:09:43  <jeremyrubin> Ok there *is* something very peculiar going on with trusty tahr
4792019-11-04T20:10:01  <jeremyrubin> It kinda seems like the default bucket count for a newly created map is 11
4802019-11-04T20:10:30  <sipa> unordered_map ?
4812019-11-04T20:10:36  <jeremyrubin> yeah
4822019-11-04T20:10:54  <sipa> is that unreasonable?
4832019-11-04T20:11:06  <jeremyrubin> Yeah
4842019-11-04T20:11:32  *** fox2p has joined #bitcoin-core-dev
4852019-11-04T20:11:47  <jeremyrubin> I think for most others the default is 1 or 0
4862019-11-04T20:13:35  *** sdaftuar has left #bitcoin-core-dev
4872019-11-04T20:20:36  *** T^3 has joined #bitcoin-core-dev
4882019-11-04T20:20:58  *** jarthur_ has quit IRC
4892019-11-04T20:21:27  *** braydonf has joined #bitcoin-core-dev
4902019-11-04T20:21:27  *** jarthur has joined #bitcoin-core-dev
4912019-11-04T20:22:55  *** Deacyde has joined #bitcoin-core-dev
4922019-11-04T20:23:56  *** TTT has quit IRC
4932019-11-04T20:27:21  *** Highway61 has joined #bitcoin-core-dev
4942019-11-04T20:38:37  *** b10c has quit IRC
4952019-11-04T20:38:52  *** b10c has joined #bitcoin-core-dev
4962019-11-04T20:48:37  *** IGHOR has joined #bitcoin-core-dev
4972019-11-04T20:50:33  *** millerti has joined #bitcoin-core-dev
4982019-11-04T21:00:02  *** ozbot has quit IRC
4992019-11-04T21:00:42  <phantomcircuit> jeremyrubin, that doesn't seem that unreasonable to me?
5002019-11-04T21:00:56  <jeremyrubin> It is
5012019-11-04T21:01:04  <jeremyrubin> Because it means you always allocate I think
5022019-11-04T21:01:04  <phantomcircuit> ok why
5032019-11-04T21:01:20  <jeremyrubin> so just creating a std::unordered_set on the stack makes an allocation
5042019-11-04T21:01:35  <jeremyrubin> the ones that default to 0 or 1 do so via an optimization for a single pointer case IIRC
5052019-11-04T21:01:46  <phantomcircuit> yes presumably virtually every user of std::vector ends up allocating at least 11 elements
5062019-11-04T21:01:56  <phantomcircuit> which would reduce malloc churn
5072019-11-04T21:02:15  <jeremyrubin> Well it sucks for things like computing the DynamicUsage
5082019-11-04T21:02:26  <jeremyrubin> Because you can't tell if the buckets are stack or heap
5092019-11-04T21:02:36  <jeremyrubin> and so there is no x-platform way to count that memory
5102019-11-04T21:02:45  <jeremyrubin> without double counting
5112019-11-04T21:03:04  <jeremyrubin> And no, I think a lot of vectors stay empty
5122019-11-04T21:03:17  <jeremyrubin> There's probably an interesting distribution....
5132019-11-04T21:04:46  *** dviola has joined #bitcoin-core-dev
5142019-11-04T21:09:35  *** bitcoin-git has joined #bitcoin-core-dev
5152019-11-04T21:09:35  <bitcoin-git> [bitcoin] achow101 opened pull request #17369: Refactor: Move encryption code between KeyMan and Wallet (master...wallet-box-pr-4) https://github.com/bitcoin/bitcoin/pull/17369
5162019-11-04T21:09:45  *** bitcoin-git has left #bitcoin-core-dev
5172019-11-04T21:10:18  *** dviola has quit IRC
5182019-11-04T21:11:13  *** arik__ has joined #bitcoin-core-dev
5192019-11-04T21:14:04  *** bitcoin-git has joined #bitcoin-core-dev
5202019-11-04T21:14:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17370: doc: Update doc/bips.md with recent changes in master (master...1911-docBips) https://github.com/bitcoin/bitcoin/pull/17370
5212019-11-04T21:14:06  *** bitcoin-git has left #bitcoin-core-dev
5222019-11-04T21:14:37  *** arik_ has quit IRC
5232019-11-04T21:14:57  *** arik_ has joined #bitcoin-core-dev
5242019-11-04T21:15:43  *** arik_ has joined #bitcoin-core-dev
5252019-11-04T21:15:52  <sipa> jeremyrubin: generally vectors only allocate when you add something to them
5262019-11-04T21:16:04  <sipa> and std::unordered_map needs an allocation per element anyway, afaik
5272019-11-04T21:16:10  <sipa> in addition to the allocation of the table
5282019-11-04T21:16:15  *** arik__ has quit IRC
5292019-11-04T21:16:28  <jeremyrubin> Yes, but usually you wouldn't allocate the table ahead of adding anything
5302019-11-04T21:16:39  <jeremyrubin> you would wait for an explicit reserve
5312019-11-04T21:16:44  <jeremyrubin> Or an insert
5322019-11-04T21:17:00  <jeremyrubin> It's weird to assume the user wants an allocation
5332019-11-04T21:17:44  *** Bille has joined #bitcoin-core-dev
5342019-11-04T21:18:01  <sipa> jeremyrubin: btw, i'm working on a PR to add a memory-accounting allocayot
5352019-11-04T21:18:05  <sipa> *allocator
5362019-11-04T21:18:21  <jeremyrubin> That should help solve this
5372019-11-04T21:18:43  <sipa> which will compute DynamicUsage exactly, regardless of what weird policy containers use
5382019-11-04T21:19:11  <jeremyrubin> The only "issue" with that is then you're talking an extra 8 bytes per thing that has a map
5392019-11-04T21:20:17  *** Highway61 has quit IRC
5402019-11-04T21:20:35  *** TTT has joined #bitcoin-core-dev
5412019-11-04T21:24:39  *** b10c has quit IRC
5422019-11-04T21:24:53  *** T^3 has quit IRC
5432019-11-04T21:25:37  *** cryptoIndio has joined #bitcoin-core-dev
5442019-11-04T21:27:09  *** jb55 has quit IRC
5452019-11-04T21:30:55  *** cryptoIndio has quit IRC
5462019-11-04T21:34:02  <jeremyrubin> And possibly, if you specify a "non static" (not sure right term) you might be paying for another extra pointer for the allocator
5472019-11-04T21:34:24  *** jb55 has joined #bitcoin-core-dev
5482019-11-04T21:34:50  <jeremyrubin> So might be good to figure out if there's a way that the templates can know which allocator they are using at compile time, and perhaps share it across multiple instances of the same inner class
5492019-11-04T21:35:18  *** bsm1175321 has quit IRC
5502019-11-04T21:35:31  <sipa> sure, that's possible, but i think it's overkill
5512019-11-04T21:36:15  <sipa> you have a pointer to a tracker size_t as template argument, for example
5522019-11-04T21:36:18  <sipa> *can
5532019-11-04T21:36:56  <jeremyrubin> only if it's on the stack right?
5542019-11-04T21:37:09  <sipa> hmm?
5552019-11-04T21:37:36  <sipa> it needs to be known at compile time, so it'd need to scoped similarly as the container definition
5562019-11-04T21:37:41  <jeremyrubin> I mean that it would be difficult to pass such maps around as the template args would differ
5572019-11-04T21:37:59  <jeremyrubin> yeah
5582019-11-04T21:38:00  <sipa> yes
5592019-11-04T21:38:14  <luke-jr> emilengler: BIP 179: next is wait for Travis ;)
5602019-11-04T21:38:15  <sipa> but it could be on the heap in case the container is on the heap too
5612019-11-04T21:38:26  <sipa> in any case, not worth it imho
5622019-11-04T21:50:01  *** rh0nj has quit IRC
5632019-11-04T21:51:07  *** rh0nj has joined #bitcoin-core-dev
5642019-11-04T22:04:00  *** bitcoin-git has joined #bitcoin-core-dev
5652019-11-04T22:04:00  <bitcoin-git> [bitcoin] achow101 opened pull request #17371: Refactor: Require scriptPubKey to get wallet SigningProvider (master...wallet-box-pr-5) https://github.com/bitcoin/bitcoin/pull/17371
5662019-11-04T22:04:02  *** TTT has quit IRC
5672019-11-04T22:04:11  *** bitcoin-git has left #bitcoin-core-dev
5682019-11-04T22:13:40  *** diogosergio has quit IRC
5692019-11-04T22:13:49  *** arik__ has joined #bitcoin-core-dev
5702019-11-04T22:17:47  *** arik_ has quit IRC
5712019-11-04T22:28:02  *** Chris_Stewart_5 has quit IRC
5722019-11-04T22:31:05  *** thoragh has quit IRC
5732019-11-04T22:40:37  *** arik_ has joined #bitcoin-core-dev
5742019-11-04T22:44:18  *** arik__ has quit IRC
5752019-11-04T22:54:11  *** justanotheruser has quit IRC
5762019-11-04T23:21:29  *** bitcoin-git has joined #bitcoin-core-dev
5772019-11-04T23:21:30  <bitcoin-git> [bitcoin] achow101 opened pull request #17373: wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet (master...wallet-box-pr-6) https://github.com/bitcoin/bitcoin/pull/17373
5782019-11-04T23:21:41  *** bitcoin-git has left #bitcoin-core-dev
5792019-11-04T23:23:32  *** bitcoin-git has joined #bitcoin-core-dev
5802019-11-04T23:23:32  <bitcoin-git> [bitcoin] achow101 opened pull request #17374: IsMine: Set state to WATCH_ONLY if we can get the pubkey (master...wallet-box-pr-7) https://github.com/bitcoin/bitcoin/pull/17374
5812019-11-04T23:23:33  *** bitcoin-git has left #bitcoin-core-dev
5822019-11-04T23:26:54  *** marcoagner has quit IRC
5832019-11-04T23:29:05  *** nosss2 has joined #bitcoin-core-dev
5842019-11-04T23:30:24  *** soju has joined #bitcoin-core-dev
5852019-11-04T23:39:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5862019-11-04T23:48:01  *** TTT has joined #bitcoin-core-dev
5872019-11-04T23:51:20  *** davterra has quit IRC
5882019-11-04T23:54:36  *** jarthur_ has joined #bitcoin-core-dev
5892019-11-04T23:57:33  *** jarthur has quit IRC
5902019-11-04T23:58:50  *** jarthur_ has quit IRC