1 2019-11-04T00:00:02 *** jhf has quit IRC
2 2019-11-04T00:00:03 *** ddustin has quit IRC
3 2019-11-04T00:00:10 *** michaelfolkson has joined #bitcoin-core-dev
4 2019-11-04T00:02:27 *** EagleTM has quit IRC
5 2019-11-04T00:08:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6 2019-11-04T00:16:51 *** leonardo1 has joined #bitcoin-core-dev
7 2019-11-04T00:20:57 *** dviola has quit IRC
8 2019-11-04T00:21:41 *** dviola has joined #bitcoin-core-dev
9 2019-11-04T00:22:13 *** dviola has joined #bitcoin-core-dev
10 2019-11-04T00:34:01 *** TravelingThrough has joined #bitcoin-core-dev
11 2019-11-04T00:35:09 *** promag has quit IRC
12 2019-11-04T00:35:38 *** Highway61 has joined #bitcoin-core-dev
13 2019-11-04T00:35:50 *** Chris_Stewart_5 has quit IRC
14 2019-11-04T00:44:17 *** justanotheruser has quit IRC
15 2019-11-04T00:45:36 *** cryptoIndio has joined #bitcoin-core-dev
16 2019-11-04T00:57:06 *** jarthur has joined #bitcoin-core-dev
17 2019-11-04T01:00:48 *** justanotheruser has joined #bitcoin-core-dev
18 2019-11-04T01:27:02 *** dviola has quit IRC
19 2019-11-04T01:28:04 *** promag has joined #bitcoin-core-dev
20 2019-11-04T01:29:55 *** ddustin has joined #bitcoin-core-dev
21 2019-11-04T01:34:03 *** ddustin has quit IRC
22 2019-11-04T01:35:22 *** cryptoIndio has quit IRC
23 2019-11-04T01:35:39 *** cryptoIndio has joined #bitcoin-core-dev
24 2019-11-04T01:51:29 *** promag_ has joined #bitcoin-core-dev
25 2019-11-04T01:55:57 *** promag_ has quit IRC
26 2019-11-04T02:09:57 *** michaelfolkson has quit IRC
27 2019-11-04T02:14:35 *** Karyon has quit IRC
28 2019-11-04T02:14:59 *** Karyon has joined #bitcoin-core-dev
29 2019-11-04T02:16:03 *** michaelfolkson has joined #bitcoin-core-dev
30 2019-11-04T02:26:54 *** michaelfolkson has quit IRC
31 2019-11-04T02:28:20 *** promag has quit IRC
32 2019-11-04T02:40:27 *** Dean_Guss has quit IRC
33 2019-11-04T02:47:54 *** tsujp has quit IRC
34 2019-11-04T02:50:12 *** tsujp has joined #bitcoin-core-dev
35 2019-11-04T02:58:53 *** nsh has quit IRC
36 2019-11-04T03:00:01 *** leonardo1 has quit IRC
37 2019-11-04T03:02:34 *** Giszmo has quit IRC
38 2019-11-04T03:03:23 *** cryptoIndio has quit IRC
39 2019-11-04T03:08:06 *** nsh has joined #bitcoin-core-dev
40 2019-11-04T03:08:35 *** emilengler has quit IRC
41 2019-11-04T03:14:17 *** emilengler has joined #bitcoin-core-dev
42 2019-11-04T03:16:35 *** felixfoertsch23 has joined #bitcoin-core-dev
43 2019-11-04T03:17:41 *** felixfoertsch has quit IRC
44 2019-11-04T03:30:12 *** cryptoIndio has joined #bitcoin-core-dev
45 2019-11-04T03:47:46 *** patryk1 has joined #bitcoin-core-dev
46 2019-11-04T04:04:41 *** jarthur has quit IRC
47 2019-11-04T04:05:11 *** jarthur has joined #bitcoin-core-dev
48 2019-11-04T04:07:10 *** Highway61 has quit IRC
49 2019-11-04T04:07:44 *** tsujp has quit IRC
50 2019-11-04T04:14:47 *** tsujp has joined #bitcoin-core-dev
51 2019-11-04T04:28:56 *** promag has joined #bitcoin-core-dev
52 2019-11-04T04:33:39 *** promag has quit IRC
53 2019-11-04T04:44:49 *** davterra has joined #bitcoin-core-dev
54 2019-11-04T04:53:14 *** tsujp has quit IRC
55 2019-11-04T04:54:32 *** jarthur has quit IRC
56 2019-11-04T04:55:20 *** jarthur has joined #bitcoin-core-dev
57 2019-11-04T05:00:12 *** tsujp has joined #bitcoin-core-dev
58 2019-11-04T05:08:33 *** nosss2 has quit IRC
59 2019-11-04T05:25:35 *** felixfoertsch23 has quit IRC
60 2019-11-04T05:25:45 *** felixfoertsch has joined #bitcoin-core-dev
61 2019-11-04T05:31:51 *** Victor_sueca has joined #bitcoin-core-dev
62 2019-11-04T05:33:51 *** nosss2 has joined #bitcoin-core-dev
63 2019-11-04T05:34:39 *** Victorsueca has quit IRC
64 2019-11-04T05:38:13 *** nosss2 has quit IRC
65 2019-11-04T05:40:34 *** Dean_Guss has joined #bitcoin-core-dev
66 2019-11-04T05:43:13 *** nosss2 has joined #bitcoin-core-dev
67 2019-11-04T05:44:56 *** jarthur has quit IRC
68 2019-11-04T05:46:58 *** nosss2 has quit IRC
69 2019-11-04T05:51:36 *** mryandao has quit IRC
70 2019-11-04T05:54:02 *** cryptoIndio has quit IRC
71 2019-11-04T05:59:25 *** treyzania_ is now known as treyzania
72 2019-11-04T06:00:01 *** patryk1 has quit IRC
73 2019-11-04T06:03:03 *** Dean_Guss has quit IRC
74 2019-11-04T06:03:19 *** Dean_Guss has joined #bitcoin-core-dev
75 2019-11-04T06:11:12 *** mryandao has joined #bitcoin-core-dev
76 2019-11-04T06:12:43 *** mryandao has joined #bitcoin-core-dev
77 2019-11-04T06:16:58 *** profmac has quit IRC
78 2019-11-04T06:17:52 *** Suntop1 has joined #bitcoin-core-dev
79 2019-11-04T06:29:08 *** cryptoIndio has joined #bitcoin-core-dev
80 2019-11-04T06:29:25 *** profmac has joined #bitcoin-core-dev
81 2019-11-04T06:48:17 *** jeremyrubin has quit IRC
82 2019-11-04T06:59:12 *** Highway61 has joined #bitcoin-core-dev
83 2019-11-04T06:59:55 *** timothy has joined #bitcoin-core-dev
84 2019-11-04T07:00:12 *** mryandao has quit IRC
85 2019-11-04T07:00:22 *** promag has joined #bitcoin-core-dev
86 2019-11-04T07:03:14 *** Highway61 has quit IRC
87 2019-11-04T07:08:50 *** promag has quit IRC
88 2019-11-04T07:14:26 *** mryandao has joined #bitcoin-core-dev
89 2019-11-04T07:15:34 *** cryptoIn_ has joined #bitcoin-core-dev
90 2019-11-04T07:16:03 *** timothy has quit IRC
91 2019-11-04T07:17:27 *** timothy has joined #bitcoin-core-dev
92 2019-11-04T07:18:17 *** cryptoIndio has quit IRC
93 2019-11-04T07:34:54 *** AaronvanW has joined #bitcoin-core-dev
94 2019-11-04T07:36:33 *** jonatack has joined #bitcoin-core-dev
95 2019-11-04T07:44:54 *** timothy has quit IRC
96 2019-11-04T07:47:01 *** jungly has joined #bitcoin-core-dev
97 2019-11-04T07:59:02 *** cryptoIn_ has quit IRC
98 2019-11-04T07:59:35 *** cryptoIndio has joined #bitcoin-core-dev
99 2019-11-04T08:17:56 *** timothy has joined #bitcoin-core-dev
100 2019-11-04T08:20:58 *** jonatack has quit IRC
101 2019-11-04T08:22:55 *** jonatack has joined #bitcoin-core-dev
102 2019-11-04T08:25:48 *** AaronvanW has quit IRC
103 2019-11-04T08:27:31 *** nijynot has joined #bitcoin-core-dev
104 2019-11-04T08:36:03 *** timothy has quit IRC
105 2019-11-04T08:42:23 *** timothy has joined #bitcoin-core-dev
106 2019-11-04T08:44:53 *** luke-jr has quit IRC
107 2019-11-04T08:48:24 *** luke-jr has joined #bitcoin-core-dev
108 2019-11-04T08:50:46 *** marcoagner has joined #bitcoin-core-dev
109 2019-11-04T08:52:14 *** kljasdfvv has joined #bitcoin-core-dev
110 2019-11-04T08:52:27 *** kljasdfvv has quit IRC
111 2019-11-04T08:54:45 *** TravelingThrough has quit IRC
112 2019-11-04T08:59:31 *** Randolf has joined #bitcoin-core-dev
113 2019-11-04T09:00:01 *** Suntop1 has quit IRC
114 2019-11-04T09:00:31 *** kljasdfvv has joined #bitcoin-core-dev
115 2019-11-04T09:07:57 *** drizztbsd has joined #bitcoin-core-dev
116 2019-11-04T09:08:27 *** timothy has quit IRC
117 2019-11-04T09:11:50 *** Giszmo has joined #bitcoin-core-dev
118 2019-11-04T09:18:12 *** aclark has joined #bitcoin-core-dev
119 2019-11-04T09:19:35 *** bitcoin-git has joined #bitcoin-core-dev
120 2019-11-04T09:19:35 <bitcoin-git> [bitcoin] jonatack opened pull request #17362: test: speed up wallet_avoidreuse, add logging (master...wallet_avoidreuse-test-improvements) https://github.com/bitcoin/bitcoin/pull/17362
121 2019-11-04T09:19:36 *** bitcoin-git has left #bitcoin-core-dev
122 2019-11-04T09:31:44 *** cryptoIndio has quit IRC
123 2019-11-04T09:35:18 *** drizztbsd has quit IRC
124 2019-11-04T09:35:47 *** drizztbsd has joined #bitcoin-core-dev
125 2019-11-04T09:40:29 *** jpe has joined #bitcoin-core-dev
126 2019-11-04T09:42:54 *** cryptoIndio has joined #bitcoin-core-dev
127 2019-11-04T09:53:48 *** nosss2 has joined #bitcoin-core-dev
128 2019-11-04T09:59:02 *** nosss2 has quit IRC
129 2019-11-04T10:10:22 *** nosss2 has joined #bitcoin-core-dev
130 2019-11-04T10:14:01 *** drizztbsd has quit IRC
131 2019-11-04T10:15:41 *** drizztbsd has joined #bitcoin-core-dev
132 2019-11-04T10:18:02 *** nosss2 has quit IRC
133 2019-11-04T10:23:35 *** nosss2 has joined #bitcoin-core-dev
134 2019-11-04T10:28:37 *** nosss2 has quit IRC
135 2019-11-04T10:32:15 *** nosss2 has joined #bitcoin-core-dev
136 2019-11-04T10:38:02 *** mryandao has quit IRC
137 2019-11-04T10:39:32 *** rockhouse5 is now known as rockhouse
138 2019-11-04T10:39:41 *** nosss2 has quit IRC
139 2019-11-04T10:40:04 *** mryandao has joined #bitcoin-core-dev
140 2019-11-04T10:45:33 *** cryptoIndio has quit IRC
141 2019-11-04T10:51:38 *** nosss2 has joined #bitcoin-core-dev
142 2019-11-04T10:56:22 *** nosss2 has quit IRC
143 2019-11-04T10:58:12 *** timothy has joined #bitcoin-core-dev
144 2019-11-04T10:58:50 *** drizztbsd has quit IRC
145 2019-11-04T11:06:00 *** nosss2 has joined #bitcoin-core-dev
146 2019-11-04T11:06:17 *** IGHOR has quit IRC
147 2019-11-04T11:08:51 *** IGHOR has joined #bitcoin-core-dev
148 2019-11-04T11:11:03 *** nosss2 has quit IRC
149 2019-11-04T11:11:07 *** IGHOR has quit IRC
150 2019-11-04T11:14:06 *** IGHOR has joined #bitcoin-core-dev
151 2019-11-04T11:17:38 *** cryptoIndio has joined #bitcoin-core-dev
152 2019-11-04T11:17:53 *** IGHOR has quit IRC
153 2019-11-04T11:19:16 *** nosss2 has joined #bitcoin-core-dev
154 2019-11-04T11:23:27 *** cryptoIndio has quit IRC
155 2019-11-04T11:24:00 *** promag has joined #bitcoin-core-dev
156 2019-11-04T11:26:31 *** nosss2 has quit IRC
157 2019-11-04T11:28:14 *** promag has quit IRC
158 2019-11-04T11:30:09 *** IGHOR has joined #bitcoin-core-dev
159 2019-11-04T11:30:19 *** michaelfolkson has joined #bitcoin-core-dev
160 2019-11-04T11:31:49 *** nosss2 has joined #bitcoin-core-dev
161 2019-11-04T11:32:18 *** michaelfolkson has quit IRC
162 2019-11-04T11:34:10 *** nosss2 has quit IRC
163 2019-11-04T11:35:12 *** IGHOR has quit IRC
164 2019-11-04T11:38:00 *** IGHOR has joined #bitcoin-core-dev
165 2019-11-04T11:39:29 *** nosss2 has joined #bitcoin-core-dev
166 2019-11-04T11:41:38 *** IGHOR has quit IRC
167 2019-11-04T11:44:28 *** nosss2 has quit IRC
168 2019-11-04T11:46:08 *** Chris_Stewart_5 has joined #bitcoin-core-dev
169 2019-11-04T11:46:21 *** IGHOR has joined #bitcoin-core-dev
170 2019-11-04T12:00:02 *** aclark has quit IRC
171 2019-11-04T12:01:11 *** nosss2 has joined #bitcoin-core-dev
172 2019-11-04T12:06:08 *** nosss2 has quit IRC
173 2019-11-04T12:08:57 *** nijynot has quit IRC
174 2019-11-04T12:11:57 *** nosss2 has joined #bitcoin-core-dev
175 2019-11-04T12:16:26 *** nosss2 has quit IRC
176 2019-11-04T12:17:33 *** nijynot has joined #bitcoin-core-dev
177 2019-11-04T12:17:48 *** RISCi_ATOM1 has joined #bitcoin-core-dev
178 2019-11-04T12:19:07 *** bitcoin-git has joined #bitcoin-core-dev
179 2019-11-04T12:19:07 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/463eab5e1418...c4b8dd20600f
180 2019-11-04T12:19:08 <bitcoin-git> bitcoin/master f44abe4 Hennadii Stepanov: refactor: Remove addrdb.h dependency from node.h
181 2019-11-04T12:19:08 <bitcoin-git> bitcoin/master c4b8dd2 Wladimir J. van der Laan: Merge #17297: refactor: Remove addrdb.h dependency from node.h
182 2019-11-04T12:19:10 *** bitcoin-git has left #bitcoin-core-dev
183 2019-11-04T12:19:27 *** Randolf has quit IRC
184 2019-11-04T12:19:27 *** bitcoin-git has joined #bitcoin-core-dev
185 2019-11-04T12:19:27 <bitcoin-git> [bitcoin] laanwj merged pull request #17297: refactor: Remove addrdb.h dependency from node.h (master...20191029-refactor-addrdb) https://github.com/bitcoin/bitcoin/pull/17297
186 2019-11-04T12:19:28 *** bitcoin-git has left #bitcoin-core-dev
187 2019-11-04T12:24:47 *** michaelfolkson has joined #bitcoin-core-dev
188 2019-11-04T12:29:18 *** Highway61 has joined #bitcoin-core-dev
189 2019-11-04T12:29:34 *** nosss2 has joined #bitcoin-core-dev
190 2019-11-04T12:33:25 *** bitcoin-git has joined #bitcoin-core-dev
191 2019-11-04T12:33:26 <bitcoin-git> [bitcoin] Sjors closed pull request #17246: wallet: avoid knapsack when there's no change (master...2019/10/less-knapsack) https://github.com/bitcoin/bitcoin/pull/17246
192 2019-11-04T12:33:29 *** lightlike has joined #bitcoin-core-dev
193 2019-11-04T12:33:38 *** bitcoin-git has left #bitcoin-core-dev
194 2019-11-04T12:34:15 *** nijynot has quit IRC
195 2019-11-04T12:34:25 *** nosss2 has quit IRC
196 2019-11-04T12:34:25 *** bitcoin-git has joined #bitcoin-core-dev
197 2019-11-04T12:34:25 <bitcoin-git> [bitcoin] laanwj pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/c4b8dd20600f...91fbcf41b35c
198 2019-11-04T12:34:26 <bitcoin-git> bitcoin/master 0b0cff3 Igor Cota: Add support for building Android dependencies
199 2019-11-04T12:34:27 <bitcoin-git> bitcoin/master c2a749c Igor Cota: Add example Android host-platform-triplet and options
200 2019-11-04T12:34:27 <bitcoin-git> bitcoin/master 9c4cb01 Igor Cota: Add ranlib to android.mk hosts file (fix OSX Android NDK build)
201 2019-11-04T12:34:28 *** bitcoin-git has left #bitcoin-core-dev
202 2019-11-04T12:35:00 *** bitcoin-git has joined #bitcoin-core-dev
203 2019-11-04T12:35:01 <bitcoin-git> [bitcoin] laanwj merged pull request #16110: depends: Add Android NDK support (master...add-android-to-depends) https://github.com/bitcoin/bitcoin/pull/16110
204 2019-11-04T12:35:01 *** bitcoin-git has left #bitcoin-core-dev
205 2019-11-04T12:36:16 *** IGHOR has quit IRC
206 2019-11-04T12:37:38 *** nosss2 has joined #bitcoin-core-dev
207 2019-11-04T12:42:18 *** nosss2 has quit IRC
208 2019-11-04T12:47:37 *** michaelfolkson has quit IRC
209 2019-11-04T12:50:12 *** nijynot has joined #bitcoin-core-dev
210 2019-11-04T12:52:31 *** IGHOR has joined #bitcoin-core-dev
211 2019-11-04T12:53:03 *** michaelfolkson has joined #bitcoin-core-dev
212 2019-11-04T12:53:53 *** michaelfolkson has quit IRC
213 2019-11-04T12:54:35 *** nosss2 has joined #bitcoin-core-dev
214 2019-11-04T12:55:08 *** cryptoIndio has joined #bitcoin-core-dev
215 2019-11-04T12:56:37 *** Chris_Stewart_5 has quit IRC
216 2019-11-04T12:57:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
217 2019-11-04T12:58:57 *** nosss2 has quit IRC
218 2019-11-04T12:59:37 *** IGHOR has quit IRC
219 2019-11-04T13:01:15 *** cryptoIndio has quit IRC
220 2019-11-04T13:04:43 *** toti has joined #bitcoin-core-dev
221 2019-11-04T13:04:44 *** drizztbsd has joined #bitcoin-core-dev
222 2019-11-04T13:04:47 *** bitcoin-git has joined #bitcoin-core-dev
223 2019-11-04T13:04:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91fbcf41b35c...73b26e38d7a1
224 2019-11-04T13:04:48 <bitcoin-git> bitcoin/master ac83133 randymcmillan: doc: Fix some misspellings
225 2019-11-04T13:04:48 <bitcoin-git> bitcoin/master 73b26e3 MarcoFalke: Merge #17351: doc: Fix some misspellings
226 2019-11-04T13:04:50 *** bitcoin-git has left #bitcoin-core-dev
227 2019-11-04T13:05:07 *** toti is now known as Guest80584
228 2019-11-04T13:05:08 *** bitcoin-git has joined #bitcoin-core-dev
229 2019-11-04T13:05:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17351: doc: Fix some misspellings (master...makeseeds-py) https://github.com/bitcoin/bitcoin/pull/17351
230 2019-11-04T13:05:09 *** bitcoin-git has left #bitcoin-core-dev
231 2019-11-04T13:07:03 *** timothy has quit IRC
232 2019-11-04T13:07:04 *** nosss2 has joined #bitcoin-core-dev
233 2019-11-04T13:09:17 *** tsujp has quit IRC
234 2019-11-04T13:11:53 *** nosss2 has quit IRC
235 2019-11-04T13:13:35 *** Guest80584 has left #bitcoin-core-dev
236 2019-11-04T13:14:19 *** nosss2 has joined #bitcoin-core-dev
237 2019-11-04T13:15:12 *** tsujp has joined #bitcoin-core-dev
238 2019-11-04T13:17:53 *** bitcoin-git has joined #bitcoin-core-dev
239 2019-11-04T13:17:54 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/73b26e38d7a1...5933c6d9245d
240 2019-11-04T13:17:54 <bitcoin-git> bitcoin/master fa54b3e MarcoFalke: test: move-only ComputeFilter to src/test/lib/blockfilter
241 2019-11-04T13:17:55 <bitcoin-git> bitcoin/master fa0a731 MarcoFalke: test: Add RegTestingSetup to setup_common
242 2019-11-04T13:17:55 <bitcoin-git> bitcoin/master 5933c6d MarcoFalke: Merge #17228: test: Add RegTestingSetup to setup_common
243 2019-11-04T13:17:57 *** bitcoin-git has left #bitcoin-core-dev
244 2019-11-04T13:18:13 *** bitcoin-git has joined #bitcoin-core-dev
245 2019-11-04T13:18:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17228: test: Add RegTestingSetup to setup_common (master...1910-RegTestingSetup) https://github.com/bitcoin/bitcoin/pull/17228
246 2019-11-04T13:18:14 *** bitcoin-git has left #bitcoin-core-dev
247 2019-11-04T13:19:15 *** nosss2 has quit IRC
248 2019-11-04T13:19:59 *** nosss2 has joined #bitcoin-core-dev
249 2019-11-04T13:22:08 *** IGHOR has joined #bitcoin-core-dev
250 2019-11-04T13:23:24 *** timothy has joined #bitcoin-core-dev
251 2019-11-04T13:23:55 *** drizztbsd has quit IRC
252 2019-11-04T13:24:18 *** bitcoin-git has joined #bitcoin-core-dev
253 2019-11-04T13:24:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5933c6d9245d...def69e5a8632
254 2019-11-04T13:24:20 <bitcoin-git> bitcoin/master fafa064 MarcoFalke: ci: Remove ccache requirement on the host
255 2019-11-04T13:24:21 <bitcoin-git> bitcoin/master facc0da MarcoFalke: travis: Run unit and functional tests on native arm
256 2019-11-04T13:24:21 <bitcoin-git> bitcoin/master def69e5 MarcoFalke: Merge #17233: travis: Run unit and functional tests on native arm
257 2019-11-04T13:24:23 *** bitcoin-git has left #bitcoin-core-dev
258 2019-11-04T13:24:24 *** nosss2 has quit IRC
259 2019-11-04T13:24:38 *** bitcoin-git has joined #bitcoin-core-dev
260 2019-11-04T13:24:38 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17233: travis: Run unit and functional tests on native arm (master...1910-travisNativeArm) https://github.com/bitcoin/bitcoin/pull/17233
261 2019-11-04T13:24:39 *** bitcoin-git has left #bitcoin-core-dev
262 2019-11-04T13:24:57 *** nosss2 has joined #bitcoin-core-dev
263 2019-11-04T13:24:59 *** jonatack has quit IRC
264 2019-11-04T13:32:10 *** IGHOR has quit IRC
265 2019-11-04T13:33:27 *** bitcoin-git has joined #bitcoin-core-dev
266 2019-11-04T13:33:28 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/def69e5a8632...fba574c908bb
267 2019-11-04T13:33:29 <bitcoin-git> bitcoin/master 29f8434 Hennadii Stepanov: refactor: Remove redundant PSBT copy constructor
268 2019-11-04T13:33:30 <bitcoin-git> bitcoin/master fa89198 MarcoFalke: bench: Remove redundant copy constructor in mempool_stress
269 2019-11-04T13:33:30 <bitcoin-git> bitcoin/master fba574c MarcoFalke: Merge #17349: Remove redundant copy constructors
270 2019-11-04T13:33:32 *** bitcoin-git has left #bitcoin-core-dev
271 2019-11-04T13:33:37 *** nosss2 has quit IRC
272 2019-11-04T13:33:47 *** bitcoin-git has joined #bitcoin-core-dev
273 2019-11-04T13:33:47 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17349: Remove redundant copy constructors (master...1911-copyConstructorWhy) https://github.com/bitcoin/bitcoin/pull/17349
274 2019-11-04T13:33:48 *** bitcoin-git has left #bitcoin-core-dev
275 2019-11-04T13:35:43 *** cryptoIndio has joined #bitcoin-core-dev
276 2019-11-04T13:36:31 *** thoragh has joined #bitcoin-core-dev
277 2019-11-04T13:40:17 *** cryptoIndio has quit IRC
278 2019-11-04T13:45:15 *** captjakk has quit IRC
279 2019-11-04T13:46:12 *** Chris_Stewart_5 has quit IRC
280 2019-11-04T13:47:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
281 2019-11-04T13:49:45 *** diogosergio has joined #bitcoin-core-dev
282 2019-11-04T13:50:18 *** IGHOR has joined #bitcoin-core-dev
283 2019-11-04T13:58:16 *** michaelfolkson has joined #bitcoin-core-dev
284 2019-11-04T14:02:48 *** thoragh has quit IRC
285 2019-11-04T14:04:11 *** Jackielove4u has quit IRC
286 2019-11-04T14:05:19 *** thoragh has joined #bitcoin-core-dev
287 2019-11-04T14:11:09 *** bitcoin-git has joined #bitcoin-core-dev
288 2019-11-04T14:11:10 <bitcoin-git> [bitcoin] theStack opened pull request #17363: test: add "diamond" unit test to MempoolAncestryTests (master...20191104-test-add_diamond_ancestors_unit_test) https://github.com/bitcoin/bitcoin/pull/17363
289 2019-11-04T14:11:11 *** bitcoin-git has left #bitcoin-core-dev
290 2019-11-04T14:21:24 *** oneark has joined #bitcoin-core-dev
291 2019-11-04T14:22:04 *** bitcoin-git has joined #bitcoin-core-dev
292 2019-11-04T14:22:05 <bitcoin-git> [bitcoin] stefanwouldgo closed pull request #17008: build: bump libevent to 2.1.11 in depends (master...master) https://github.com/bitcoin/bitcoin/pull/17008
293 2019-11-04T14:22:05 *** bitcoin-git has left #bitcoin-core-dev
294 2019-11-04T14:22:24 *** bitcoin-git has joined #bitcoin-core-dev
295 2019-11-04T14:22:25 <bitcoin-git> [bitcoin] stefanwouldgo reopened pull request #17008: build: bump libevent to 2.1.11 in depends (master...master) https://github.com/bitcoin/bitcoin/pull/17008
296 2019-11-04T14:22:25 *** bitcoin-git has left #bitcoin-core-dev
297 2019-11-04T14:23:18 *** bitcoin-git has joined #bitcoin-core-dev
298 2019-11-04T14:23:19 <bitcoin-git> [bitcoin] sipsorcery opened pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
299 2019-11-04T14:23:20 *** bitcoin-git has left #bitcoin-core-dev
300 2019-11-04T14:27:50 *** IGHOR has quit IRC
301 2019-11-04T14:29:02 *** spaced0ut has quit IRC
302 2019-11-04T14:30:41 *** spaced0ut has joined #bitcoin-core-dev
303 2019-11-04T14:34:24 <instagibbs> #17304 looks mergeable
304 2019-11-04T14:34:28 <gribble> https://github.com/bitcoin/bitcoin/issues/17304 | refactor: Move many functions into LegacyScriptPubKeyMan and further separate it from CWallet by achow101 · Pull Request #17304 · bitcoin/bitcoin · GitHub
305 2019-11-04T14:34:30 <instagibbs> 4 fresh code review acks
306 2019-11-04T14:38:12 *** bsm1175321 has joined #bitcoin-core-dev
307 2019-11-04T14:39:43 <luke-jr> backport to 0.19? #17102
308 2019-11-04T14:39:44 <gribble> https://github.com/bitcoin/bitcoin/issues/17102 | doc: Add missing indexes/blockfilter/basic to doc/files.md by MarcoFalke · Pull Request #17102 · bitcoin/bitcoin · GitHub
309 2019-11-04T14:44:14 *** ajonas has joined #bitcoin-core-dev
310 2019-11-04T14:55:30 *** Jackielove4u has joined #bitcoin-core-dev
311 2019-11-04T14:55:42 *** davterra has quit IRC
312 2019-11-04T14:56:12 *** davterra has joined #bitcoin-core-dev
313 2019-11-04T15:00:02 *** RISCi_ATOM1 has quit IRC
314 2019-11-04T15:02:12 *** bitcoin-git has joined #bitcoin-core-dev
315 2019-11-04T15:02:14 <bitcoin-git> [bitcoin] laanwj pushed 19 commits to master: https://github.com/bitcoin/bitcoin/compare/fba574c908bb...bbc9e4133cc5
316 2019-11-04T15:02:14 <bitcoin-git> bitcoin/master b4cb18b Andrew Chow: MOVEONLY: Reorder LegacyScriptPubKeyMan methods
317 2019-11-04T15:02:15 <bitcoin-git> bitcoin/master 533d8b3 Andrew Chow: Refactor: Declare LegacyScriptPubKeyMan methods as virtual
318 2019-11-04T15:02:16 <bitcoin-git> bitcoin/master acedc5b Andrew Chow: Refactor: Add new ScriptPubKeyMan virtual methods
319 2019-11-04T15:02:18 *** bitcoin-git has left #bitcoin-core-dev
320 2019-11-04T15:02:32 *** bitcoin-git has joined #bitcoin-core-dev
321 2019-11-04T15:02:33 <bitcoin-git> [bitcoin] laanwj merged pull request #17304: refactor: Move many functions into LegacyScriptPubKeyMan and further separate it from CWallet (master...wallet-box-pr-3) https://github.com/bitcoin/bitcoin/pull/17304
322 2019-11-04T15:02:34 *** bitcoin-git has left #bitcoin-core-dev
323 2019-11-04T15:12:00 *** cubancorona has quit IRC
324 2019-11-04T15:15:39 *** bitcoin-git has joined #bitcoin-core-dev
325 2019-11-04T15:15:39 <bitcoin-git> [bitcoin] icota opened pull request #17365: depends: update README.md with working Android targets and API levels (master...update-android-depends-doc) https://github.com/bitcoin/bitcoin/pull/17365
326 2019-11-04T15:15:42 *** bitcoin-git has left #bitcoin-core-dev
327 2019-11-04T15:17:11 *** promag has joined #bitcoin-core-dev
328 2019-11-04T15:18:07 *** jb55 has joined #bitcoin-core-dev
329 2019-11-04T15:21:41 *** cryptoIndio has joined #bitcoin-core-dev
330 2019-11-04T15:27:37 *** cryptoIndio has quit IRC
331 2019-11-04T15:34:15 *** Highway61 has quit IRC
332 2019-11-04T15:37:17 *** nosss2 has joined #bitcoin-core-dev
333 2019-11-04T15:44:36 *** michaelfolkson has quit IRC
334 2019-11-04T15:47:37 *** codestr0m has joined #bitcoin-core-dev
335 2019-11-04T15:48:13 <achow101> \o/
336 2019-11-04T15:48:54 <fanquake> achow101 18 out of how many commits left in the wallet refactor pipeline?
337 2019-11-04T15:49:23 <achow101> 20?
338 2019-11-04T15:49:23 <provoostenator> rebase time!
339 2019-11-04T15:49:33 <achow101> we'll find out after rebase :)
340 2019-11-04T16:01:34 *** michaelfolkson has joined #bitcoin-core-dev
341 2019-11-04T16:07:29 *** bitcoin-git has joined #bitcoin-core-dev
342 2019-11-04T16:07:29 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17366: test: Reset global args between test suites (master...1911-testResetGlobals) https://github.com/bitcoin/bitcoin/pull/17366
343 2019-11-04T16:07:32 *** bitcoin-git has left #bitcoin-core-dev
344 2019-11-04T16:08:22 *** nosss2 has quit IRC
345 2019-11-04T16:14:27 *** Guyver2 has joined #bitcoin-core-dev
346 2019-11-04T16:18:25 *** bitcoin-git has joined #bitcoin-core-dev
347 2019-11-04T16:18:26 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bbc9e4133cc5...8f9df2ed88c4
348 2019-11-04T16:18:26 <bitcoin-git> bitcoin/master 090b75c User: p2p: Avoid allocating memory for addrKnown where we don't need it
349 2019-11-04T16:18:27 <bitcoin-git> bitcoin/master a552e84 User: added asserts to check m_addr_known when it's used
350 2019-11-04T16:18:27 <bitcoin-git> bitcoin/master b6d2183 User: Minor refactoring to remove implied m_addr_relay_peer.
351 2019-11-04T16:18:29 *** bitcoin-git has left #bitcoin-core-dev
352 2019-11-04T16:18:45 *** bitcoin-git has joined #bitcoin-core-dev
353 2019-11-04T16:18:45 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17164: p2p: Avoid allocating memory for addrKnown where we don't need it (master...addr_relay_optimization_4) https://github.com/bitcoin/bitcoin/pull/17164
354 2019-11-04T16:18:46 *** bitcoin-git has left #bitcoin-core-dev
355 2019-11-04T16:20:14 *** TravelingThrough has joined #bitcoin-core-dev
356 2019-11-04T16:23:06 *** jonatack has joined #bitcoin-core-dev
357 2019-11-04T16:28:55 *** bitcoin-git has joined #bitcoin-core-dev
358 2019-11-04T16:28:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f9df2ed88c4...6cb10c14c600
359 2019-11-04T16:28:56 <bitcoin-git> bitcoin/master 8d8e5a7 Sebastian Falbesoner: test: use default address type (bech32) for wallet_bumpfee tests
360 2019-11-04T16:28:57 <bitcoin-git> bitcoin/master 6cb10c1 MarcoFalke: Merge #17199: test: use default address type (bech32) for wallet_bumpfee t...
361 2019-11-04T16:28:58 *** bitcoin-git has left #bitcoin-core-dev
362 2019-11-04T16:29:05 *** marcinja has quit IRC
363 2019-11-04T16:29:15 *** bitcoin-git has joined #bitcoin-core-dev
364 2019-11-04T16:29:15 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17199: test: use default address type (bech32) for wallet_bumpfee tests (master...20191020-test-wallet-bumpfee_adapt_constants_after_default_address_change) https://github.com/bitcoin/bitcoin/pull/17199
365 2019-11-04T16:29:16 *** bitcoin-git has left #bitcoin-core-dev
366 2019-11-04T16:31:06 *** ddustin has joined #bitcoin-core-dev
367 2019-11-04T16:34:45 *** bitcoin-git has joined #bitcoin-core-dev
368 2019-11-04T16:34:45 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6cb10c14c600...94a26b192f18
369 2019-11-04T16:34:45 <bitcoin-git> bitcoin/master c98bd13 Adam Jonas: replace asserts in RPC code with CHECK_NONFATAL and add linter
370 2019-11-04T16:34:46 <bitcoin-git> bitcoin/master 94a26b1 MarcoFalke: Merge #17318: replace asserts in RPC code with CHECK_NONFATAL and add lint...
371 2019-11-04T16:34:47 *** bitcoin-git has left #bitcoin-core-dev
372 2019-11-04T16:35:04 *** bitcoin-git has joined #bitcoin-core-dev
373 2019-11-04T16:35:04 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17318: replace asserts in RPC code with CHECK_NONFATAL and add linter (master...replace-rpc-asserts-for-CHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17318
374 2019-11-04T16:35:05 *** bitcoin-git has left #bitcoin-core-dev
375 2019-11-04T16:36:03 *** ddustin has quit IRC
376 2019-11-04T16:47:35 *** nijynot has quit IRC
377 2019-11-04T16:51:15 *** diogosergio has quit IRC
378 2019-11-04T16:53:40 *** DougieBot5000 has quit IRC
379 2019-11-04T16:53:56 *** DougieBot5000 has joined #bitcoin-core-dev
380 2019-11-04T16:55:41 *** alko89 has quit IRC
381 2019-11-04T16:56:07 *** alko89 has joined #bitcoin-core-dev
382 2019-11-04T16:59:45 *** timothy has quit IRC
383 2019-11-04T17:03:08 *** diogosergio has joined #bitcoin-core-dev
384 2019-11-04T17:06:27 *** Dean_Guss has quit IRC
385 2019-11-04T17:06:44 *** michaelfolkson has quit IRC
386 2019-11-04T17:07:16 *** Dean_Guss has joined #bitcoin-core-dev
387 2019-11-04T17:09:27 *** jarthur has joined #bitcoin-core-dev
388 2019-11-04T17:10:44 *** ghost43_ has joined #bitcoin-core-dev
389 2019-11-04T17:10:50 *** ghost43 has quit IRC
390 2019-11-04T17:12:50 *** diogosergio has quit IRC
391 2019-11-04T17:15:27 *** Dean_Guss has quit IRC
392 2019-11-04T17:15:59 *** Dean_Guss has joined #bitcoin-core-dev
393 2019-11-04T17:20:16 *** TTT has joined #bitcoin-core-dev
394 2019-11-04T17:23:37 *** TravelingThrough has quit IRC
395 2019-11-04T17:28:07 *** marcinja has joined #bitcoin-core-dev
396 2019-11-04T17:41:52 *** wsm has quit IRC
397 2019-11-04T17:42:52 *** michaelfolkson has joined #bitcoin-core-dev
398 2019-11-04T17:43:44 *** wsm has joined #bitcoin-core-dev
399 2019-11-04T17:55:02 *** harrigan has quit IRC
400 2019-11-04T17:55:41 *** harrigan has joined #bitcoin-core-dev
401 2019-11-04T18:00:01 *** codestr0m has quit IRC
402 2019-11-04T18:14:45 *** michaelfolkson has quit IRC
403 2019-11-04T18:17:27 *** Guyver2 has quit IRC
404 2019-11-04T18:17:46 *** ozbot has joined #bitcoin-core-dev
405 2019-11-04T18:18:09 *** diogosergio has joined #bitcoin-core-dev
406 2019-11-04T18:19:08 *** Chris_Stewart_5 has quit IRC
407 2019-11-04T18:20:36 *** TravelingThrough has joined #bitcoin-core-dev
408 2019-11-04T18:24:04 *** TTT has quit IRC
409 2019-11-04T18:26:00 *** Chris_Stewart_5 has joined #bitcoin-core-dev
410 2019-11-04T18:29:41 *** michaelfolkson has joined #bitcoin-core-dev
411 2019-11-04T18:36:12 *** thoragh has quit IRC
412 2019-11-04T18:44:03 *** thoragh has joined #bitcoin-core-dev
413 2019-11-04T18:44:37 *** r251d has joined #bitcoin-core-dev
414 2019-11-04T18:57:43 *** oneark has quit IRC
415 2019-11-04T18:58:08 *** reallll has joined #bitcoin-core-dev
416 2019-11-04T19:00:38 *** ddustin has joined #bitcoin-core-dev
417 2019-11-04T19:00:41 *** arik_ has joined #bitcoin-core-dev
418 2019-11-04T19:01:14 *** belcher has quit IRC
419 2019-11-04T19:02:15 *** arik_ has joined #bitcoin-core-dev
420 2019-11-04T19:05:07 *** bitcoin-git has joined #bitcoin-core-dev
421 2019-11-04T19:05:07 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17367: ci: Run non-cross-compile builds natively (master...1911-ciNative) https://github.com/bitcoin/bitcoin/pull/17367
422 2019-11-04T19:05:08 *** bitcoin-git has left #bitcoin-core-dev
423 2019-11-04T19:05:27 *** ddustin has quit IRC
424 2019-11-04T19:06:28 *** ddustin has joined #bitcoin-core-dev
425 2019-11-04T19:10:13 *** ddustin has quit IRC
426 2019-11-04T19:10:33 *** ddustin has joined #bitcoin-core-dev
427 2019-11-04T19:15:48 *** reallll is now known as belcher
428 2019-11-04T19:20:32 *** TTT has joined #bitcoin-core-dev
429 2019-11-04T19:21:38 *** ddustin has quit IRC
430 2019-11-04T19:21:54 *** bitcoin-git has joined #bitcoin-core-dev
431 2019-11-04T19:21:54 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94a26b192f18...33b155f28732
432 2019-11-04T19:21:55 <bitcoin-git> bitcoin/master fa07b8b MarcoFalke: test: Reset global args between test suites
433 2019-11-04T19:21:55 <bitcoin-git> bitcoin/master 33b155f MarcoFalke: Merge #17366: test: Reset global args between test suites
434 2019-11-04T19:21:56 *** ddustin has joined #bitcoin-core-dev
435 2019-11-04T19:21:57 *** bitcoin-git has left #bitcoin-core-dev
436 2019-11-04T19:22:14 *** bitcoin-git has joined #bitcoin-core-dev
437 2019-11-04T19:22:14 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17366: test: Reset global args between test suites (master...1911-testResetGlobals) https://github.com/bitcoin/bitcoin/pull/17366
438 2019-11-04T19:22:15 *** bitcoin-git has left #bitcoin-core-dev
439 2019-11-04T19:24:30 *** TravelingThrough has quit IRC
440 2019-11-04T19:25:07 *** jeremyrubin has joined #bitcoin-core-dev
441 2019-11-04T19:28:50 *** thoragh has quit IRC
442 2019-11-04T19:31:37 *** ddustin_ has joined #bitcoin-core-dev
443 2019-11-04T19:32:15 *** jarthur_ has joined #bitcoin-core-dev
444 2019-11-04T19:34:37 *** jarthur has quit IRC
445 2019-11-04T19:34:50 *** ddustin has quit IRC
446 2019-11-04T19:35:07 *** fox2p has quit IRC
447 2019-11-04T19:35:46 *** EagleTM has joined #bitcoin-core-dev
448 2019-11-04T19:37:05 *** b10c has joined #bitcoin-core-dev
449 2019-11-04T19:42:55 *** b10c_ has joined #bitcoin-core-dev
450 2019-11-04T19:45:39 *** b10c has quit IRC
451 2019-11-04T19:46:31 *** bitcoin-git has joined #bitcoin-core-dev
452 2019-11-04T19:46:31 <bitcoin-git> [bitcoin] fanquake opened pull request #17368: cli: fix -getinfo output when compiled with no wallet (master...fix_getinfo_no_wallet) https://github.com/bitcoin/bitcoin/pull/17368
453 2019-11-04T19:46:32 *** bitcoin-git has left #bitcoin-core-dev
454 2019-11-04T19:50:29 *** b10c_ has joined #bitcoin-core-dev
455 2019-11-04T19:50:52 *** thoragh has joined #bitcoin-core-dev
456 2019-11-04T19:52:01 *** b10c has joined #bitcoin-core-dev
457 2019-11-04T19:52:52 *** b10c has joined #bitcoin-core-dev
458 2019-11-04T19:53:57 *** b10c_ has quit IRC
459 2019-11-04T19:55:23 *** bitcoin-git has joined #bitcoin-core-dev
460 2019-11-04T19:55:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/33b155f28732...bc38bb9a6036
461 2019-11-04T19:55:26 <bitcoin-git> bitcoin/master ede8b76 JamesC: Remove network_event_loop instance in close()
462 2019-11-04T19:55:26 <bitcoin-git> bitcoin/master 6b71241 JamesC: Refactor TestFramework main() into setup/shutdown
463 2019-11-04T19:55:27 <bitcoin-git> bitcoin/master 6f40820 JamesC: Add closing and flushing of logging handlers
464 2019-11-04T19:55:29 *** bitcoin-git has left #bitcoin-core-dev
465 2019-11-04T19:55:44 *** bitcoin-git has joined #bitcoin-core-dev
466 2019-11-04T19:55:45 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17288: Added TestShell class for interactive Python environments. (master...2019-10-testwrapper) https://github.com/bitcoin/bitcoin/pull/17288
467 2019-11-04T19:55:45 *** bitcoin-git has left #bitcoin-core-dev
468 2019-11-04T19:58:11 *** michaelfolkson has quit IRC
469 2019-11-04T20:02:59 *** bitcoin-git has joined #bitcoin-core-dev
470 2019-11-04T20:03:00 <bitcoin-git> [bitcoin] fanquake closed pull request #17128: gui: remove unnecessary shortcuts in bitcoingui files (master...clean-bitcoingui) https://github.com/bitcoin/bitcoin/pull/17128
471 2019-11-04T20:03:01 *** bitcoin-git has left #bitcoin-core-dev
472 2019-11-04T20:06:23 *** b10c has quit IRC
473 2019-11-04T20:06:43 *** b10c has joined #bitcoin-core-dev
474 2019-11-04T20:08:32 *** b10c has quit IRC
475 2019-11-04T20:08:47 *** b10c has joined #bitcoin-core-dev
476 2019-11-04T20:09:03 *** b10c has joined #bitcoin-core-dev
477 2019-11-04T20:09:40 *** b10c has joined #bitcoin-core-dev
478 2019-11-04T20:09:43 <jeremyrubin> Ok there *is* something very peculiar going on with trusty tahr
479 2019-11-04T20:10:01 <jeremyrubin> It kinda seems like the default bucket count for a newly created map is 11
480 2019-11-04T20:10:30 <sipa> unordered_map ?
481 2019-11-04T20:10:36 <jeremyrubin> yeah
482 2019-11-04T20:10:54 <sipa> is that unreasonable?
483 2019-11-04T20:11:06 <jeremyrubin> Yeah
484 2019-11-04T20:11:32 *** fox2p has joined #bitcoin-core-dev
485 2019-11-04T20:11:47 <jeremyrubin> I think for most others the default is 1 or 0
486 2019-11-04T20:13:35 *** sdaftuar has left #bitcoin-core-dev
487 2019-11-04T20:20:36 *** T^3 has joined #bitcoin-core-dev
488 2019-11-04T20:20:58 *** jarthur_ has quit IRC
489 2019-11-04T20:21:27 *** braydonf has joined #bitcoin-core-dev
490 2019-11-04T20:21:27 *** jarthur has joined #bitcoin-core-dev
491 2019-11-04T20:22:55 *** Deacyde has joined #bitcoin-core-dev
492 2019-11-04T20:23:56 *** TTT has quit IRC
493 2019-11-04T20:27:21 *** Highway61 has joined #bitcoin-core-dev
494 2019-11-04T20:38:37 *** b10c has quit IRC
495 2019-11-04T20:38:52 *** b10c has joined #bitcoin-core-dev
496 2019-11-04T20:48:37 *** IGHOR has joined #bitcoin-core-dev
497 2019-11-04T20:50:33 *** millerti has joined #bitcoin-core-dev
498 2019-11-04T21:00:02 *** ozbot has quit IRC
499 2019-11-04T21:00:42 <phantomcircuit> jeremyrubin, that doesn't seem that unreasonable to me?
500 2019-11-04T21:00:56 <jeremyrubin> It is
501 2019-11-04T21:01:04 <jeremyrubin> Because it means you always allocate I think
502 2019-11-04T21:01:04 <phantomcircuit> ok why
503 2019-11-04T21:01:20 <jeremyrubin> so just creating a std::unordered_set on the stack makes an allocation
504 2019-11-04T21:01:35 <jeremyrubin> the ones that default to 0 or 1 do so via an optimization for a single pointer case IIRC
505 2019-11-04T21:01:46 <phantomcircuit> yes presumably virtually every user of std::vector ends up allocating at least 11 elements
506 2019-11-04T21:01:56 <phantomcircuit> which would reduce malloc churn
507 2019-11-04T21:02:15 <jeremyrubin> Well it sucks for things like computing the DynamicUsage
508 2019-11-04T21:02:26 <jeremyrubin> Because you can't tell if the buckets are stack or heap
509 2019-11-04T21:02:36 <jeremyrubin> and so there is no x-platform way to count that memory
510 2019-11-04T21:02:45 <jeremyrubin> without double counting
511 2019-11-04T21:03:04 <jeremyrubin> And no, I think a lot of vectors stay empty
512 2019-11-04T21:03:17 <jeremyrubin> There's probably an interesting distribution....
513 2019-11-04T21:04:46 *** dviola has joined #bitcoin-core-dev
514 2019-11-04T21:09:35 *** bitcoin-git has joined #bitcoin-core-dev
515 2019-11-04T21:09:35 <bitcoin-git> [bitcoin] achow101 opened pull request #17369: Refactor: Move encryption code between KeyMan and Wallet (master...wallet-box-pr-4) https://github.com/bitcoin/bitcoin/pull/17369
516 2019-11-04T21:09:45 *** bitcoin-git has left #bitcoin-core-dev
517 2019-11-04T21:10:18 *** dviola has quit IRC
518 2019-11-04T21:11:13 *** arik__ has joined #bitcoin-core-dev
519 2019-11-04T21:14:04 *** bitcoin-git has joined #bitcoin-core-dev
520 2019-11-04T21:14:04 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17370: doc: Update doc/bips.md with recent changes in master (master...1911-docBips) https://github.com/bitcoin/bitcoin/pull/17370
521 2019-11-04T21:14:06 *** bitcoin-git has left #bitcoin-core-dev
522 2019-11-04T21:14:37 *** arik_ has quit IRC
523 2019-11-04T21:14:57 *** arik_ has joined #bitcoin-core-dev
524 2019-11-04T21:15:43 *** arik_ has joined #bitcoin-core-dev
525 2019-11-04T21:15:52 <sipa> jeremyrubin: generally vectors only allocate when you add something to them
526 2019-11-04T21:16:04 <sipa> and std::unordered_map needs an allocation per element anyway, afaik
527 2019-11-04T21:16:10 <sipa> in addition to the allocation of the table
528 2019-11-04T21:16:15 *** arik__ has quit IRC
529 2019-11-04T21:16:28 <jeremyrubin> Yes, but usually you wouldn't allocate the table ahead of adding anything
530 2019-11-04T21:16:39 <jeremyrubin> you would wait for an explicit reserve
531 2019-11-04T21:16:44 <jeremyrubin> Or an insert
532 2019-11-04T21:17:00 <jeremyrubin> It's weird to assume the user wants an allocation
533 2019-11-04T21:17:44 *** Bille has joined #bitcoin-core-dev
534 2019-11-04T21:18:01 <sipa> jeremyrubin: btw, i'm working on a PR to add a memory-accounting allocayot
535 2019-11-04T21:18:05 <sipa> *allocator
536 2019-11-04T21:18:21 <jeremyrubin> That should help solve this
537 2019-11-04T21:18:43 <sipa> which will compute DynamicUsage exactly, regardless of what weird policy containers use
538 2019-11-04T21:19:11 <jeremyrubin> The only "issue" with that is then you're talking an extra 8 bytes per thing that has a map
539 2019-11-04T21:20:17 *** Highway61 has quit IRC
540 2019-11-04T21:20:35 *** TTT has joined #bitcoin-core-dev
541 2019-11-04T21:24:39 *** b10c has quit IRC
542 2019-11-04T21:24:53 *** T^3 has quit IRC
543 2019-11-04T21:25:37 *** cryptoIndio has joined #bitcoin-core-dev
544 2019-11-04T21:27:09 *** jb55 has quit IRC
545 2019-11-04T21:30:55 *** cryptoIndio has quit IRC
546 2019-11-04T21:34:02 <jeremyrubin> And possibly, if you specify a "non static" (not sure right term) you might be paying for another extra pointer for the allocator
547 2019-11-04T21:34:24 *** jb55 has joined #bitcoin-core-dev
548 2019-11-04T21:34:50 <jeremyrubin> So might be good to figure out if there's a way that the templates can know which allocator they are using at compile time, and perhaps share it across multiple instances of the same inner class
549 2019-11-04T21:35:18 *** bsm1175321 has quit IRC
550 2019-11-04T21:35:31 <sipa> sure, that's possible, but i think it's overkill
551 2019-11-04T21:36:15 <sipa> you have a pointer to a tracker size_t as template argument, for example
552 2019-11-04T21:36:18 <sipa> *can
553 2019-11-04T21:36:56 <jeremyrubin> only if it's on the stack right?
554 2019-11-04T21:37:09 <sipa> hmm?
555 2019-11-04T21:37:36 <sipa> it needs to be known at compile time, so it'd need to scoped similarly as the container definition
556 2019-11-04T21:37:41 <jeremyrubin> I mean that it would be difficult to pass such maps around as the template args would differ
557 2019-11-04T21:37:59 <jeremyrubin> yeah
558 2019-11-04T21:38:00 <sipa> yes
559 2019-11-04T21:38:14 <luke-jr> emilengler: BIP 179: next is wait for Travis ;)
560 2019-11-04T21:38:15 <sipa> but it could be on the heap in case the container is on the heap too
561 2019-11-04T21:38:26 <sipa> in any case, not worth it imho
562 2019-11-04T21:50:01 *** rh0nj has quit IRC
563 2019-11-04T21:51:07 *** rh0nj has joined #bitcoin-core-dev
564 2019-11-04T22:04:00 *** bitcoin-git has joined #bitcoin-core-dev
565 2019-11-04T22:04:00 <bitcoin-git> [bitcoin] achow101 opened pull request #17371: Refactor: Require scriptPubKey to get wallet SigningProvider (master...wallet-box-pr-5) https://github.com/bitcoin/bitcoin/pull/17371
566 2019-11-04T22:04:02 *** TTT has quit IRC
567 2019-11-04T22:04:11 *** bitcoin-git has left #bitcoin-core-dev
568 2019-11-04T22:13:40 *** diogosergio has quit IRC
569 2019-11-04T22:13:49 *** arik__ has joined #bitcoin-core-dev
570 2019-11-04T22:17:47 *** arik_ has quit IRC
571 2019-11-04T22:28:02 *** Chris_Stewart_5 has quit IRC
572 2019-11-04T22:31:05 *** thoragh has quit IRC
573 2019-11-04T22:40:37 *** arik_ has joined #bitcoin-core-dev
574 2019-11-04T22:44:18 *** arik__ has quit IRC
575 2019-11-04T22:54:11 *** justanotheruser has quit IRC
576 2019-11-04T23:21:29 *** bitcoin-git has joined #bitcoin-core-dev
577 2019-11-04T23:21:30 <bitcoin-git> [bitcoin] achow101 opened pull request #17373: wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet (master...wallet-box-pr-6) https://github.com/bitcoin/bitcoin/pull/17373
578 2019-11-04T23:21:41 *** bitcoin-git has left #bitcoin-core-dev
579 2019-11-04T23:23:32 *** bitcoin-git has joined #bitcoin-core-dev
580 2019-11-04T23:23:32 <bitcoin-git> [bitcoin] achow101 opened pull request #17374: IsMine: Set state to WATCH_ONLY if we can get the pubkey (master...wallet-box-pr-7) https://github.com/bitcoin/bitcoin/pull/17374
581 2019-11-04T23:23:33 *** bitcoin-git has left #bitcoin-core-dev
582 2019-11-04T23:26:54 *** marcoagner has quit IRC
583 2019-11-04T23:29:05 *** nosss2 has joined #bitcoin-core-dev
584 2019-11-04T23:30:24 *** soju has joined #bitcoin-core-dev
585 2019-11-04T23:39:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
586 2019-11-04T23:48:01 *** TTT has joined #bitcoin-core-dev
587 2019-11-04T23:51:20 *** davterra has quit IRC
588 2019-11-04T23:54:36 *** jarthur_ has joined #bitcoin-core-dev
589 2019-11-04T23:57:33 *** jarthur has quit IRC
590 2019-11-04T23:58:50 *** jarthur_ has quit IRC