12019-11-20T00:00:02  *** carldani1 has quit IRC
  22019-11-20T00:00:56  *** diogosergio has joined #bitcoin-core-dev
  32019-11-20T00:05:37  *** diogosergio has quit IRC
  42019-11-20T00:46:29  *** alxgnon1 has joined #bitcoin-core-dev
  52019-11-20T00:54:29  *** deadlysin has quit IRC
  62019-11-20T00:59:37  *** fox2p_ has quit IRC
  72019-11-20T01:01:48  *** baldur has joined #bitcoin-core-dev
  82019-11-20T01:02:04  *** SiAnDoG_ has quit IRC
  92019-11-20T01:02:05  *** andrewtoth has quit IRC
 102019-11-20T01:02:29  *** SiAnDoG_ has joined #bitcoin-core-dev
 112019-11-20T01:02:31  *** andrewtoth has joined #bitcoin-core-dev
 122019-11-20T01:02:34  *** fox2p has joined #bitcoin-core-dev
 132019-11-20T01:03:23  *** dawggo12 has joined #bitcoin-core-dev
 142019-11-20T01:22:06  *** nik-j has joined #bitcoin-core-dev
 152019-11-20T01:36:31  *** deadlysin has joined #bitcoin-core-dev
 162019-11-20T01:43:49  *** nik-j has quit IRC
 172019-11-20T01:44:25  *** nik-j has joined #bitcoin-core-dev
 182019-11-20T01:48:57  *** nik-j has quit IRC
 192019-11-20T02:16:02  *** nik-j has joined #bitcoin-core-dev
 202019-11-20T02:24:27  *** nik-j has quit IRC
 212019-11-20T02:50:18  *** Highway61 has quit IRC
 222019-11-20T02:51:51  *** nik-j has joined #bitcoin-core-dev
 232019-11-20T03:00:01  *** alxgnon1 has quit IRC
 242019-11-20T03:03:17  *** nik-j has quit IRC
 252019-11-20T03:10:39  *** felixfoertsch has quit IRC
 262019-11-20T03:11:12  *** felixfoertsch has joined #bitcoin-core-dev
 272019-11-20T03:17:28  *** dlareg1 has joined #bitcoin-core-dev
 282019-11-20T03:26:09  *** reallll has joined #bitcoin-core-dev
 292019-11-20T03:28:24  *** dawggo12_ has joined #bitcoin-core-dev
 302019-11-20T03:29:17  *** belcher has quit IRC
 312019-11-20T03:30:18  *** nik-j has joined #bitcoin-core-dev
 322019-11-20T03:30:56  *** dawggo12 has quit IRC
 332019-11-20T03:39:14  *** nik-j has quit IRC
 342019-11-20T03:48:38  *** dawggo12_ has quit IRC
 352019-11-20T03:50:16  *** dawggo12 has joined #bitcoin-core-dev
 362019-11-20T03:58:49  *** bitcoin-git has joined #bitcoin-core-dev
 372019-11-20T03:58:49  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17529: rpc: Faster getblock using PureBlock (master...1911-PureTx) https://github.com/bitcoin/bitcoin/pull/17529
 382019-11-20T03:58:52  *** bitcoin-git has left #bitcoin-core-dev
 392019-11-20T03:59:06  *** nik-j has joined #bitcoin-core-dev
 402019-11-20T04:03:44  *** nik-j has quit IRC
 412019-11-20T04:04:38  *** nik-j has joined #bitcoin-core-dev
 422019-11-20T04:06:41  *** provoostenator has quit IRC
 432019-11-20T04:08:50  *** nik-j has quit IRC
 442019-11-20T04:10:01  *** provoostenator has joined #bitcoin-core-dev
 452019-11-20T04:20:28  *** nosss2 has quit IRC
 462019-11-20T04:27:24  *** tryphe_ has joined #bitcoin-core-dev
 472019-11-20T04:29:25  *** tryphe has quit IRC
 482019-11-20T04:39:04  *** nosss2 has joined #bitcoin-core-dev
 492019-11-20T04:43:17  *** nosss2 has quit IRC
 502019-11-20T05:33:40  *** diogosergio has joined #bitcoin-core-dev
 512019-11-20T05:37:56  *** diogosergio has quit IRC
 522019-11-20T05:38:00  *** justan0theruser has quit IRC
 532019-11-20T05:41:17  *** justanotheruser has joined #bitcoin-core-dev
 542019-11-20T05:50:18  *** jtimon has quit IRC
 552019-11-20T06:00:01  *** dlareg1 has quit IRC
 562019-11-20T06:06:30  *** nik-j has joined #bitcoin-core-dev
 572019-11-20T06:14:18  *** nik-j has quit IRC
 582019-11-20T06:17:09  *** greynix has joined #bitcoin-core-dev
 592019-11-20T06:24:37  *** justanotheruser has quit IRC
 602019-11-20T06:44:43  *** kabaum has quit IRC
 612019-11-20T06:51:31  *** Karyon has quit IRC
 622019-11-20T06:53:04  *** justanotheruser has joined #bitcoin-core-dev
 632019-11-20T06:53:19  *** Karyon has joined #bitcoin-core-dev
 642019-11-20T06:58:38  <meshcollider> wumpus, achow101: the thing with #17290 is that it only has 2 people review it, but no one else seems to want to touch coin selection
 652019-11-20T06:58:40  <gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 · Pull Request #17290 · bitcoin/bitcoin · GitHub
 662019-11-20T06:59:04  <achow101> touch it then :)
 672019-11-20T06:59:15  <meshcollider> I'm happy to merge it if no one will complain about it not getting enough review, but I'm not confident enough with coin selection myself to review it properly
 682019-11-20T06:59:25  *** Highway61 has joined #bitcoin-core-dev
 692019-11-20T06:59:53  <meshcollider> instagibbs and provoostenator are both good reviewers though
 702019-11-20T07:06:33  *** nik-j has joined #bitcoin-core-dev
 712019-11-20T07:06:49  *** Emcy_ has joined #bitcoin-core-dev
 722019-11-20T07:08:57  *** Emcy has quit IRC
 732019-11-20T07:09:35  *** nosss2 has joined #bitcoin-core-dev
 742019-11-20T07:11:35  *** nik-j has quit IRC
 752019-11-20T07:17:26  *** nosss2 has quit IRC
 762019-11-20T07:24:14  *** nosss2 has joined #bitcoin-core-dev
 772019-11-20T07:26:25  *** nik-j has joined #bitcoin-core-dev
 782019-11-20T07:30:43  *** nik-j has quit IRC
 792019-11-20T07:32:50  *** goatpig has joined #bitcoin-core-dev
 802019-11-20T07:33:05  *** nosss2 has quit IRC
 812019-11-20T07:35:14  *** nosss2 has joined #bitcoin-core-dev
 822019-11-20T07:37:26  *** openoms has quit IRC
 832019-11-20T07:38:25  *** nik-j has joined #bitcoin-core-dev
 842019-11-20T07:39:38  *** nosss2 has quit IRC
 852019-11-20T07:41:10  *** nosss2 has joined #bitcoin-core-dev
 862019-11-20T07:43:14  *** nik-j has quit IRC
 872019-11-20T07:45:14  *** nosss2 has quit IRC
 882019-11-20T07:52:27  *** nosss2 has joined #bitcoin-core-dev
 892019-11-20T07:56:36  *** nosss2 has quit IRC
 902019-11-20T07:56:37  *** nik-j has joined #bitcoin-core-dev
 912019-11-20T08:00:57  *** nik-j has quit IRC
 922019-11-20T08:04:15  *** nosss2 has joined #bitcoin-core-dev
 932019-11-20T08:08:13  *** nik-j has joined #bitcoin-core-dev
 942019-11-20T08:08:38  *** nosss2 has quit IRC
 952019-11-20T08:12:26  *** nik-j has quit IRC
 962019-11-20T08:15:17  *** nosss2 has joined #bitcoin-core-dev
 972019-11-20T08:19:07  *** nik-j has joined #bitcoin-core-dev
 982019-11-20T08:19:28  *** nosss2 has quit IRC
 992019-11-20T08:23:35  *** nosss2 has joined #bitcoin-core-dev
1002019-11-20T08:28:11  *** nosss2 has quit IRC
1012019-11-20T08:35:59  *** nosss2 has joined #bitcoin-core-dev
1022019-11-20T08:38:57  <provoostenator> I spammed morcos's #12605 to get some more reviews.
1032019-11-20T08:38:58  <gribble> https://github.com/bitcoin/bitcoin/issues/12605 | High level road map for coin selection changes · Issue #12605 · bitcoin/bitcoin · GitHub
1042019-11-20T08:40:04  <meshcollider> provoostenator: thanks :D
1052019-11-20T08:40:21  *** nosss2 has quit IRC
1062019-11-20T08:40:45  *** davterra has quit IRC
1072019-11-20T08:41:56  *** davterra has joined #bitcoin-core-dev
1082019-11-20T08:43:00  *** nosss2 has joined #bitcoin-core-dev
1092019-11-20T08:44:22  *** reallll is now known as belcher
1102019-11-20T08:47:14  *** nosss2 has quit IRC
1112019-11-20T08:48:30  *** nosss2 has joined #bitcoin-core-dev
1122019-11-20T08:53:00  *** nosss2 has quit IRC
1132019-11-20T08:57:24  *** AaronvanW has joined #bitcoin-core-dev
1142019-11-20T09:00:01  *** greynix has quit IRC
1152019-11-20T09:01:21  *** nosss2 has joined #bitcoin-core-dev
1162019-11-20T09:05:53  *** nosss2 has quit IRC
1172019-11-20T09:08:50  *** BGL has quit IRC
1182019-11-20T09:08:55  *** nosss2 has joined #bitcoin-core-dev
1192019-11-20T09:17:00  *** nosss2 has quit IRC
1202019-11-20T09:17:30  *** Kmos has joined #bitcoin-core-dev
1212019-11-20T09:17:36  *** bitcoin-git has joined #bitcoin-core-dev
1222019-11-20T09:17:36  <bitcoin-git> [bitcoin] laanwj opened pull request #17530: Use natural alignment for prevector (master...2019_11_prevector) https://github.com/bitcoin/bitcoin/pull/17530
1232019-11-20T09:17:49  *** bitcoin-git has left #bitcoin-core-dev
1242019-11-20T09:18:08  <wumpus> achow101: ^^
1252019-11-20T09:19:31  <wumpus> oh, I'll remove the surprssion too
1262019-11-20T09:21:19  *** nik-j has quit IRC
1272019-11-20T09:21:55  *** nik-j has joined #bitcoin-core-dev
1282019-11-20T09:26:40  *** nik-j has quit IRC
1292019-11-20T09:28:03  *** nosss2 has joined #bitcoin-core-dev
1302019-11-20T09:33:17  *** nosss2 has quit IRC
1312019-11-20T09:35:09  *** kabaum has joined #bitcoin-core-dev
1322019-11-20T09:35:17  *** nosss2 has joined #bitcoin-core-dev
1332019-11-20T09:35:22  *** nik-j has joined #bitcoin-core-dev
1342019-11-20T09:39:37  *** nik-j has quit IRC
1352019-11-20T09:39:37  *** nosss2 has quit IRC
1362019-11-20T09:40:36  *** AaronvanW has quit IRC
1372019-11-20T09:41:34  *** nosss2 has joined #bitcoin-core-dev
1382019-11-20T09:45:59  *** timothy has joined #bitcoin-core-dev
1392019-11-20T09:46:00  *** nosss2 has quit IRC
1402019-11-20T09:50:29  *** nosss2 has joined #bitcoin-core-dev
1412019-11-20T09:51:28  *** nik-j has joined #bitcoin-core-dev
1422019-11-20T09:51:38  *** DougieBot5000 has quit IRC
1432019-11-20T09:54:54  *** nosss2 has quit IRC
1442019-11-20T09:55:38  *** nik-j has quit IRC
1452019-11-20T09:55:53  *** DougieBot5000 has joined #bitcoin-core-dev
1462019-11-20T09:58:36  *** nik-j has joined #bitcoin-core-dev
1472019-11-20T10:02:39  *** bitcoin-git has joined #bitcoin-core-dev
1482019-11-20T10:02:40  <bitcoin-git> [bitcoin] laanwj opened pull request #17531: Bump minimum libc version to 2.23 (master...2019_11_bump_libc) https://github.com/bitcoin/bitcoin/pull/17531
1492019-11-20T10:02:40  *** bitcoin-git has left #bitcoin-core-dev
1502019-11-20T10:03:50  *** kabaum has quit IRC
1512019-11-20T10:04:18  *** kabaum has joined #bitcoin-core-dev
1522019-11-20T10:06:20  *** nik-j has quit IRC
1532019-11-20T10:09:22  *** nijynot has joined #bitcoin-core-dev
1542019-11-20T10:09:29  *** bitcoin-git has joined #bitcoin-core-dev
1552019-11-20T10:09:30  <bitcoin-git> [bitcoin] theStack opened pull request #17532: test: add functional test for non-standard txs with too large scriptSig (master...20191120-test-check-for-too-large-scriptsig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17532
1562019-11-20T10:09:30  *** goatpig has quit IRC
1572019-11-20T10:09:31  *** bitcoin-git has left #bitcoin-core-dev
1582019-11-20T10:09:48  *** goatpig has joined #bitcoin-core-dev
1592019-11-20T10:14:40  *** ExtraCrispy has joined #bitcoin-core-dev
1602019-11-20T10:15:17  *** nosss2 has joined #bitcoin-core-dev
1612019-11-20T10:15:49  *** ExtraCrispy has quit IRC
1622019-11-20T10:17:57  *** ExtraCrispy has joined #bitcoin-core-dev
1632019-11-20T10:18:49  *** ExtraCrispy has quit IRC
1642019-11-20T10:19:10  *** ExtraCrispy has joined #bitcoin-core-dev
1652019-11-20T10:20:19  *** ExtraCrispy has quit IRC
1662019-11-20T10:20:40  *** ExtraCrispy has joined #bitcoin-core-dev
1672019-11-20T10:21:49  *** ExtraCrispy has quit IRC
1682019-11-20T10:22:09  *** ExtraCrispy has joined #bitcoin-core-dev
1692019-11-20T10:23:19  *** ExtraCrispy has quit IRC
1702019-11-20T10:23:40  *** ExtraCrispy has joined #bitcoin-core-dev
1712019-11-20T10:24:49  *** ExtraCrispy has quit IRC
1722019-11-20T10:26:43  *** diogosergio has joined #bitcoin-core-dev
1732019-11-20T10:28:02  *** nosss2 has quit IRC
1742019-11-20T10:29:55  *** nosss2 has joined #bitcoin-core-dev
1752019-11-20T10:33:53  *** nik-j has joined #bitcoin-core-dev
1762019-11-20T10:34:17  *** nosss2 has quit IRC
1772019-11-20T10:34:56  *** nosss2 has joined #bitcoin-core-dev
1782019-11-20T10:35:12  *** AaronvanW has joined #bitcoin-core-dev
1792019-11-20T10:38:02  *** nik-j has quit IRC
1802019-11-20T10:39:09  *** nosss2 has quit IRC
1812019-11-20T10:39:38  *** nosss2 has joined #bitcoin-core-dev
1822019-11-20T10:39:38  *** AaronvanW has quit IRC
1832019-11-20T10:41:42  *** nik-j has joined #bitcoin-core-dev
1842019-11-20T10:43:51  *** nosss2_ has joined #bitcoin-core-dev
1852019-11-20T10:43:56  *** nosss2 has quit IRC
1862019-11-20T10:46:05  *** nik-j has quit IRC
1872019-11-20T10:48:41  *** nosss2_ has quit IRC
1882019-11-20T10:50:54  *** nosss2 has joined #bitcoin-core-dev
1892019-11-20T10:51:03  *** EagleTM has joined #bitcoin-core-dev
1902019-11-20T10:51:06  *** nik-j has joined #bitcoin-core-dev
1912019-11-20T10:54:40  *** nosss2 has quit IRC
1922019-11-20T10:54:59  *** nosss2 has joined #bitcoin-core-dev
1932019-11-20T10:56:09  *** nik-j has quit IRC
1942019-11-20T11:02:26  *** nosss2 has quit IRC
1952019-11-20T11:03:24  *** nik-j has joined #bitcoin-core-dev
1962019-11-20T11:09:00  *** nosss2 has joined #bitcoin-core-dev
1972019-11-20T11:11:37  *** kabaum has quit IRC
1982019-11-20T11:13:17  *** nosss2 has quit IRC
1992019-11-20T11:14:41  *** nik-j has quit IRC
2002019-11-20T11:19:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2012019-11-20T11:20:51  *** nosss2 has joined #bitcoin-core-dev
2022019-11-20T11:25:10  *** nosss2 has quit IRC
2032019-11-20T11:27:49  *** bitcoin-git has joined #bitcoin-core-dev
2042019-11-20T11:27:50  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4a1da9ef8e4...6496bb87afc6
2052019-11-20T11:27:50  <bitcoin-git> bitcoin/master 02ac445 stefanwouldgo: bump libevent to 2.1.11 in depends
2062019-11-20T11:27:51  <bitcoin-git> bitcoin/master 6496bb8 Wladimir J. van der Laan: Merge #17008: build: bump libevent to 2.1.11 in depends
2072019-11-20T11:27:53  *** bitcoin-git has left #bitcoin-core-dev
2082019-11-20T11:28:14  *** bitcoin-git has joined #bitcoin-core-dev
2092019-11-20T11:28:14  <bitcoin-git> [bitcoin] laanwj merged pull request #17008: build: bump libevent to 2.1.11 in depends (master...master) https://github.com/bitcoin/bitcoin/pull/17008
2102019-11-20T11:28:15  *** bitcoin-git has left #bitcoin-core-dev
2112019-11-20T11:33:06  *** BGL has joined #bitcoin-core-dev
2122019-11-20T11:33:28  *** nosss2 has joined #bitcoin-core-dev
2132019-11-20T11:36:24  *** BGL has quit IRC
2142019-11-20T11:42:38  *** nosss2 has quit IRC
2152019-11-20T11:43:23  *** SiAnDoG_ has quit IRC
2162019-11-20T11:44:24  *** bitcoin-git has joined #bitcoin-core-dev
2172019-11-20T11:44:25  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6496bb87afc6...36191a8bb536
2182019-11-20T11:44:25  <bitcoin-git> bitcoin/master 47101bb Ben Woosley: scripted-diff: Rename CPubKey and CKey::*_KEY_SIZE and COMPRESSED_*_KEY_SI...
2192019-11-20T11:44:26  <bitcoin-git> bitcoin/master 0580f86 Ben Woosley: Fixup whitespace
2202019-11-20T11:44:26  <bitcoin-git> bitcoin/master 36191a8 Wladimir J. van der Laan: Merge #12461: scripted-diff: Rename key size consts to be relative to thei...
2212019-11-20T11:44:37  *** SiAnDoG_ has joined #bitcoin-core-dev
2222019-11-20T11:44:38  *** bitcoin-git has left #bitcoin-core-dev
2232019-11-20T11:45:49  *** bitcoin-git has joined #bitcoin-core-dev
2242019-11-20T11:45:50  <bitcoin-git> [bitcoin] laanwj merged pull request #12461: scripted-diff: Rename key size consts to be relative to their class (master...key-size-consts) https://github.com/bitcoin/bitcoin/pull/12461
2252019-11-20T11:46:02  *** bitcoin-git has left #bitcoin-core-dev
2262019-11-20T11:46:32  *** nosss2 has joined #bitcoin-core-dev
2272019-11-20T11:50:27  *** bitcoin-git has joined #bitcoin-core-dev
2282019-11-20T11:50:27  <bitcoin-git> [bitcoin] Sjors opened pull request #17533: build: undo Werror=unused-variable (master...2019/11/no-unused-variable-error) https://github.com/bitcoin/bitcoin/pull/17533
2292019-11-20T11:50:28  *** bitcoin-git has left #bitcoin-core-dev
2302019-11-20T11:50:50  *** nosss2 has quit IRC
2312019-11-20T11:50:53  *** bitcoin-git has joined #bitcoin-core-dev
2322019-11-20T11:50:53  <bitcoin-git> [bitcoin] laanwj closed pull request #16808: gui: fix language list (master...translation-list-fix) https://github.com/bitcoin/bitcoin/pull/16808
2332019-11-20T11:50:54  *** bitcoin-git has left #bitcoin-core-dev
2342019-11-20T11:53:33  *** bitcoin-git has joined #bitcoin-core-dev
2352019-11-20T11:53:33  <bitcoin-git> [bitcoin] Sjors closed pull request #17520: build: Mark depends headers as -isystem (master...2019/11/depends-isystem) https://github.com/bitcoin/bitcoin/pull/17520
2362019-11-20T11:53:34  *** bitcoin-git has left #bitcoin-core-dev
2372019-11-20T12:00:01  *** Kmos has quit IRC
2382019-11-20T12:01:26  *** nosss2 has joined #bitcoin-core-dev
2392019-11-20T12:04:45  *** EagleTM has quit IRC
2402019-11-20T12:05:43  *** nosss2 has quit IRC
2412019-11-20T12:11:39  *** kabaum has joined #bitcoin-core-dev
2422019-11-20T12:13:15  *** andytoshi has joined #bitcoin-core-dev
2432019-11-20T12:13:15  *** andytoshi has quit IRC
2442019-11-20T12:13:15  *** andytoshi has joined #bitcoin-core-dev
2452019-11-20T12:17:12  *** Stuk has joined #bitcoin-core-dev
2462019-11-20T12:19:37  *** tryphe_ has quit IRC
2472019-11-20T12:19:58  *** tryphe_ has joined #bitcoin-core-dev
2482019-11-20T12:20:14  *** thelounge246725 has quit IRC
2492019-11-20T12:20:49  *** thelounge246725 has joined #bitcoin-core-dev
2502019-11-20T12:24:10  *** nosss2 has joined #bitcoin-core-dev
2512019-11-20T12:26:02  *** nik-j has joined #bitcoin-core-dev
2522019-11-20T12:27:41  <wumpus> cfields: would you know which glibc_compat fallbacks are no longer needed when going from 2.11 to 2.19 minimum libc?
2532019-11-20T12:28:38  <wumpus> the memcpy/memmove aliasing mentions 2.14, so I suppose at least that one
2542019-11-20T12:30:25  *** nik-j has quit IRC
2552019-11-20T12:30:27  <wumpus> but wouldn't know about __wrap_log2f __wrap___divmoddi4 __udivmoddi4. I guess I could just try when the symbol checker start complaining.
2562019-11-20T12:30:40  *** nik-j has joined #bitcoin-core-dev
2572019-11-20T12:32:02  *** nosss2 has quit IRC
2582019-11-20T12:32:37  *** Chris_Stewart_5 has quit IRC
2592019-11-20T12:32:42  <fanquake> there’s also a librt getclocktime link in configure we come be able to drop it going to 2.19
2602019-11-20T12:33:03  <fanquake> *might
2612019-11-20T12:33:05  <wumpus> fanquake: nice
2622019-11-20T12:33:59  <wumpus> (though, I'm not sure that's a good idea to do in my PR)
2632019-11-20T12:34:30  <wumpus> changing the libc minimum of the release binaries is not strictly the same as changing the one it can be potentially built against
2642019-11-20T12:34:38  <wumpus> not that it matters in this case, I think
2652019-11-20T12:34:45  <wumpus> 2.19 is still super old
2662019-11-20T12:36:43  *** AaronvanW has joined #bitcoin-core-dev
2672019-11-20T12:36:58  <wumpus> but I'd like to avoid adding anything that makes it potentially controversial
2682019-11-20T12:37:02  <fanquake> Yea no need to do too much in that PR.
2692019-11-20T12:37:19  <wumpus> right
2702019-11-20T12:37:21  <fanquake> I’m sure it’s probably controversial enough already heh
2712019-11-20T12:37:33  <wumpus> it helps that it needs to be merged to get gitian working again
2722019-11-20T12:37:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2732019-11-20T12:43:00  *** BGL has joined #bitcoin-core-dev
2742019-11-20T12:43:02  <wumpus> getauxval implementation is pretty scary (dl_hwcap etc interfaces with the dynamic linker / crt code): https://code.woboq.org/userspace/glibc/misc/getauxval.c.html, I don't think implementing it as part of the compatibility wrapper is a realistic alternative
2752019-11-20T12:47:08  *** bitcoin-git has joined #bitcoin-core-dev
2762019-11-20T12:47:08  <bitcoin-git> [bitcoin] laanwj closed pull request #17531: Bump minimum libc to 2.19 for release binaries (master...2019_11_bump_libc) https://github.com/bitcoin/bitcoin/pull/17531
2772019-11-20T12:47:09  *** bitcoin-git has left #bitcoin-core-dev
2782019-11-20T12:47:33  *** nosss2 has joined #bitcoin-core-dev
2792019-11-20T12:47:49  <fanquake> Well. I guess we’ll revert those changes out of random then?
2802019-11-20T12:47:54  <wumpus> I'll leave it to someone else
2812019-11-20T12:48:23  <wumpus> leveldb needs it too on ARM
2822019-11-20T12:48:29  <wumpus> at least the new one
2832019-11-20T12:49:23  <wumpus> (e.g. to find out if crc32c acceleration is available)
2842019-11-20T12:49:36  <wumpus> there's no way around requiring it at some point
2852019-11-20T12:49:47  <fanquake> Right. So the 1.22 upgrade is blocked but the same problem right now?
2862019-11-20T12:49:58  <MarcoFalke> wumpus: Sorry for not providing context. I think 2.17 should be good
2872019-11-20T12:50:08  <wumpus> but I don't like this eternal race to the bottom of version support, I really don't have the energy for this
2882019-11-20T12:50:50  <wumpus> MarcoFalke: ok
2892019-11-20T12:50:52  <MarcoFalke> I think debian and red hat are the only lts versions
2902019-11-20T12:50:56  <MarcoFalke> *LTS
2912019-11-20T12:51:40  <fanquake> MarcoFalke: 2.17 doesn’t fix the issues right?
2922019-11-20T12:52:03  <MarcoFalke> fanquake: You said 2.16 was enough?
2932019-11-20T12:52:11  *** nosss2 has quit IRC
2942019-11-20T12:52:17  <MarcoFalke> https://github.com/bitcoin/bitcoin/issues/17525#issuecomment-555742355
2952019-11-20T12:52:44  <fanquake> Ah good. For some reason I thought it was 2.19
2962019-11-20T12:52:45  <wumpus> imagine me hoping debian oldstable would be a realistic aim
2972019-11-20T12:52:56  <wumpus> then there's oldoldstable and heck who knows what else
2982019-11-20T12:53:26  <fanquake> wumpus: I can take that PR over if you’d like
2992019-11-20T12:53:29  <wumpus> let's, just stop releasing linux binaries
3002019-11-20T12:53:41  <wumpus> or link against muslibc
3012019-11-20T12:53:51  <wumpus> (statically)
3022019-11-20T12:54:27  <wumpus> IIRC rust does that nowadays
3032019-11-20T12:55:05  <MarcoFalke> ACK
3042019-11-20T12:58:03  <MarcoFalke> We should probably have a ci build against musl
3052019-11-20T12:59:01  <hebasto> provoostenator: promag: mind (re)reviewing #16224 which is user-faced part of already merged #16362 ?
3062019-11-20T12:59:04  <gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub
3072019-11-20T12:59:06  <gribble> https://github.com/bitcoin/bitcoin/issues/16362 | Add bilingual_str type by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub
3082019-11-20T13:00:44  <wumpus> MarcoFalke: agree
3092019-11-20T13:01:37  *** dawggo12 has quit IRC
3102019-11-20T13:01:49  <wumpus> that would be a good first step
3112019-11-20T13:02:21  <wumpus> I suppose it's pretty much impossible to do that on ubuntu ,though
3122019-11-20T13:02:43  *** kabaum has quit IRC
3132019-11-20T13:03:07  <wumpus> oh it isn't with the "musl-gcc wrapper" I guess
3142019-11-20T13:06:06  *** dawggo12_ has joined #bitcoin-core-dev
3152019-11-20T13:09:14  *** nosss2 has joined #bitcoin-core-dev
3162019-11-20T13:11:02  *** AaronvanW has quit IRC
3172019-11-20T13:11:26  *** jtimon has joined #bitcoin-core-dev
3182019-11-20T13:12:52  *** JamesAU has quit IRC
3192019-11-20T13:13:51  *** nosss2 has quit IRC
3202019-11-20T13:26:19  *** bitcoin-git has joined #bitcoin-core-dev
3212019-11-20T13:26:20  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/36191a8bb536...26744ae189af
3222019-11-20T13:26:20  <bitcoin-git> bitcoin/master 8944c1d dannmat: Changed tooltips of receive form to highlight difference between Label and...
3232019-11-20T13:26:20  *** nosss2 has joined #bitcoin-core-dev
3242019-11-20T13:26:20  <bitcoin-git> bitcoin/master 26744ae Wladimir J. van der Laan: Merge #17446: gui: Changed tooltip for 'Label' & 'Message' text fields to ...
3252019-11-20T13:26:33  *** bitcoin-git has left #bitcoin-core-dev
3262019-11-20T13:26:53  *** bitcoin-git has joined #bitcoin-core-dev
3272019-11-20T13:26:54  <bitcoin-git> [bitcoin] laanwj merged pull request #17446: gui: Changed tooltip for 'Label' & 'Message' text fields to be more clear (master...Nov-19-Remove-Message-Input) https://github.com/bitcoin/bitcoin/pull/17446
3282019-11-20T13:26:54  *** bitcoin-git has left #bitcoin-core-dev
3292019-11-20T13:29:11  *** jonatack has joined #bitcoin-core-dev
3302019-11-20T13:31:06  *** deadlysin has quit IRC
3312019-11-20T13:31:11  *** nosss2 has quit IRC
3322019-11-20T13:37:38  *** nosss2 has joined #bitcoin-core-dev
3332019-11-20T13:37:52  *** JamesAU has joined #bitcoin-core-dev
3342019-11-20T13:38:16  *** rex4539 has quit IRC
3352019-11-20T13:40:26  *** Dean_Guss has quit IRC
3362019-11-20T13:40:26  *** dawggo12_ has quit IRC
3372019-11-20T13:40:55  *** Dean_Guss has joined #bitcoin-core-dev
3382019-11-20T13:42:07  *** dawggo12 has joined #bitcoin-core-dev
3392019-11-20T13:42:18  *** nosss2 has quit IRC
3402019-11-20T13:49:06  *** emilengler has joined #bitcoin-core-dev
3412019-11-20T13:51:47  *** nosss2 has joined #bitcoin-core-dev
3422019-11-20T13:55:51  *** nosss2_ has joined #bitcoin-core-dev
3432019-11-20T13:55:54  *** nosss2 has quit IRC
3442019-11-20T14:02:40  *** nosss2_ has quit IRC
3452019-11-20T14:02:56  *** nosss2 has joined #bitcoin-core-dev
3462019-11-20T14:05:43  *** deadlysin has joined #bitcoin-core-dev
3472019-11-20T14:07:29  *** nosss2 has quit IRC
3482019-11-20T14:11:11  *** rex4539 has joined #bitcoin-core-dev
3492019-11-20T14:17:59  *** rex4539 has quit IRC
3502019-11-20T14:24:07  *** shesek has quit IRC
3512019-11-20T14:24:31  *** shesek has joined #bitcoin-core-dev
3522019-11-20T14:31:14  *** diogosergio has quit IRC
3532019-11-20T14:39:27  *** daniel__ has quit IRC
3542019-11-20T14:41:54  *** kabaum has joined #bitcoin-core-dev
3552019-11-20T14:43:00  *** nosss2 has joined #bitcoin-core-dev
3562019-11-20T14:45:32  *** diogosergio has joined #bitcoin-core-dev
3572019-11-20T14:46:29  *** nosss2 has quit IRC
3582019-11-20T14:46:50  *** emil__ has joined #bitcoin-core-dev
3592019-11-20T14:48:12  *** emilengler has quit IRC
3602019-11-20T14:51:10  <kanzure> re: "unannounced server migration", there has been substantial warning for a while now, but linux foundation did not give us an exact date
3612019-11-20T14:51:12  *** rex4539 has joined #bitcoin-core-dev
3622019-11-20T14:51:25  <kanzure> and they just did it without notifying me. sorry i couldn't provide more timely information.
3632019-11-20T14:53:40  *** nosss2 has joined #bitcoin-core-dev
3642019-11-20T14:54:55  *** bitcoin-git has joined #bitcoin-core-dev
3652019-11-20T14:54:57  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/26744ae189af...76e777df83db
3662019-11-20T14:54:57  <bitcoin-git> bitcoin/master ad71548 Jeffrey Czyz: Fix compilation errors in support/lockedpool.cpp
3672019-11-20T14:54:58  <bitcoin-git> bitcoin/master 15c84f5 Jeffrey Czyz: Define ARENA_DEBUG in Travis test runs
3682019-11-20T14:54:59  <bitcoin-git> bitcoin/master 30fb598 Jeffrey Czyz: Fix segfault in allocator_tests/arena_tests
3692019-11-20T14:55:01  *** bitcoin-git has left #bitcoin-core-dev
3702019-11-20T14:55:39  *** bitcoin-git has joined #bitcoin-core-dev
3712019-11-20T14:55:39  <bitcoin-git> [bitcoin] fanquake merged pull request #16161: util: Fix compilation errors in support/lockedpool.cpp (master...2019-06-arena-walk) https://github.com/bitcoin/bitcoin/pull/16161
3722019-11-20T14:55:40  *** bitcoin-git has left #bitcoin-core-dev
3732019-11-20T14:56:44  *** rex4539 has quit IRC
3742019-11-20T14:58:17  *** nosss2 has quit IRC
3752019-11-20T14:59:46  *** AaronvanW has joined #bitcoin-core-dev
3762019-11-20T15:00:01  *** Stuk has quit IRC
3772019-11-20T15:07:13  *** andrewtoth_ has joined #bitcoin-core-dev
3782019-11-20T15:08:08  *** andrewtoth has quit IRC
3792019-11-20T15:10:10  *** andrewtoth_ has quit IRC
3802019-11-20T15:10:57  *** Chris_Stewart_5 has quit IRC
3812019-11-20T15:17:20  *** survivor has joined #bitcoin-core-dev
3822019-11-20T15:21:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3832019-11-20T15:21:16  *** nosss2 has joined #bitcoin-core-dev
3842019-11-20T15:25:32  *** andrewtoth has joined #bitcoin-core-dev
3852019-11-20T15:34:26  *** jonatack has quit IRC
3862019-11-20T15:36:10  *** mdunnio has joined #bitcoin-core-dev
3872019-11-20T15:37:43  <fanquake> wumpus looks like a very unrelated Travis failure in #17514: https://travis-ci.org/bitcoin/bitcoin/jobs/614551535#L1424
3882019-11-20T15:37:45  <gribble> https://github.com/bitcoin/bitcoin/issues/17514 | util: Make logging noexcept by laanwj · Pull Request #17514 · bitcoin/bitcoin · GitHub
3892019-11-20T15:37:55  <fanquake> corelib/tools/qvector.h:648:6: internal compiler error: Segmentation fault
3902019-11-20T15:38:37  <wumpus> oh wow - does travis overclock their machines?
3912019-11-20T15:38:56  *** ghost43 has quit IRC
3922019-11-20T15:38:56  *** mryandao has quit IRC
3932019-11-20T15:39:24  *** afk11 has quit IRC
3942019-11-20T15:39:44  <wumpus> or under-cool, I guess¸this being ARM64
3952019-11-20T15:39:52  *** Dean_Guss has quit IRC
3962019-11-20T15:39:52  *** lowentropy has quit IRC
3972019-11-20T15:39:52  *** sipa has quit IRC
3982019-11-20T15:39:52  *** sdaftuar has quit IRC
3992019-11-20T15:39:52  *** wsm has quit IRC
4002019-11-20T15:39:52  *** morcos has quit IRC
4012019-11-20T15:40:06  *** Chris_Stewart_5 has quit IRC
4022019-11-20T15:40:20  *** andrewtoth has quit IRC
4032019-11-20T15:40:20  *** SiAnDoG_ has quit IRC
4042019-11-20T15:40:20  *** kristapsk has quit IRC
4052019-11-20T15:40:58  <wumpus> bad heat management is really common for ARM boards
4062019-11-20T15:41:31  <wumpus> b-but why is it compiling Qt
4072019-11-20T15:43:08  *** afk11 has joined #bitcoin-core-dev
4082019-11-20T15:43:10  *** mryandao has joined #bitcoin-core-dev
4092019-11-20T15:43:15  *** sdaftuar has joined #bitcoin-core-dev
4102019-11-20T15:43:41  *** wsm has joined #bitcoin-core-dev
4112019-11-20T15:43:43  *** ghost43 has joined #bitcoin-core-dev
4122019-11-20T15:44:52  *** morcos has joined #bitcoin-core-dev
4132019-11-20T15:46:28  *** wsm___ has joined #bitcoin-core-dev
4142019-11-20T15:46:29  *** lowentropy has joined #bitcoin-core-dev
4152019-11-20T15:46:45  *** sipa has joined #bitcoin-core-dev
4162019-11-20T15:47:15  *** wsm___ has quit IRC
4172019-11-20T15:47:52  *** wsm has quit IRC
4182019-11-20T15:48:54  *** wsm has joined #bitcoin-core-dev
4192019-11-20T15:50:42  *** wsm has joined #bitcoin-core-dev
4202019-11-20T15:59:18  <MarcoFalke> https://travis-ci.community/t/segfaults-in-arm64-environment/5617/4
4212019-11-20T16:00:03  *** deadlysin has quit IRC
4222019-11-20T16:01:11  *** nullptr| has joined #bitcoin-core-dev
4232019-11-20T16:01:15  *** ajonas has quit IRC
4242019-11-20T16:01:33  *** nullptr_ has quit IRC
4252019-11-20T16:02:26  *** fox2p has quit IRC
4262019-11-20T16:03:58  *** nijynot has quit IRC
4272019-11-20T16:05:38  *** fox2p has joined #bitcoin-core-dev
4282019-11-20T16:06:01  *** jonatack has joined #bitcoin-core-dev
4292019-11-20T16:06:37  *** kabaum has quit IRC
4302019-11-20T16:07:49  *** JamesAU_ has joined #bitcoin-core-dev
4312019-11-20T16:08:36  *** diogosergio has quit IRC
4322019-11-20T16:08:43  *** JamesAU has quit IRC
4332019-11-20T16:10:37  *** deadlysin has joined #bitcoin-core-dev
4342019-11-20T16:11:52  <wumpus> I had the same problem with my Odroid C2 but managed to fix it by powering it from a power brick instead of USB, but that's a problem with that particular board not a generic one :shrug:
4352019-11-20T16:12:08  *** emil__ has quit IRC
4362019-11-20T16:12:21  *** emilengler has joined #bitcoin-core-dev
4372019-11-20T16:17:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4382019-11-20T16:22:23  *** andrewtoth has joined #bitcoin-core-dev
4392019-11-20T16:24:55  *** diogosergio has joined #bitcoin-core-dev
4402019-11-20T16:29:35  *** diogosergio has quit IRC
4412019-11-20T16:29:47  *** bitcoin-git has joined #bitcoin-core-dev
4422019-11-20T16:29:47  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76e777df83db...3671c5721d42
4432019-11-20T16:29:48  <bitcoin-git> bitcoin/master 8f2d773 Sebastian Falbesoner: test: add functional test for non-standard txs with too large scriptSig
4442019-11-20T16:29:49  <bitcoin-git> bitcoin/master 3671c57 fanquake: Merge #17532: test: add functional test for non-standard txs with too larg...
4452019-11-20T16:29:50  *** bitcoin-git has left #bitcoin-core-dev
4462019-11-20T16:30:07  *** bitcoin-git has joined #bitcoin-core-dev
4472019-11-20T16:30:07  <bitcoin-git> [bitcoin] fanquake merged pull request #17532: test: add functional test for non-standard txs with too large scriptSig (master...20191120-test-check-for-too-large-scriptsig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17532
4482019-11-20T16:30:08  *** bitcoin-git has left #bitcoin-core-dev
4492019-11-20T16:32:22  *** bitcoin-git has joined #bitcoin-core-dev
4502019-11-20T16:32:22  <bitcoin-git> [bitcoin] jonatack opened pull request #17535: test: add block height test to listsinceblock.py  (master...rpc-wallet-blockheight-followups) https://github.com/bitcoin/bitcoin/pull/17535
4512019-11-20T16:32:24  *** bitcoin-git has left #bitcoin-core-dev
4522019-11-20T16:36:26  *** bitcoin-git has joined #bitcoin-core-dev
4532019-11-20T16:36:26  <bitcoin-git> [bitcoin] emilengler opened pull request #17536: test: Add test for rpc_whitelist (master...2019-11-jeremyrubin-whitelistrpc-meta) https://github.com/bitcoin/bitcoin/pull/17536
4542019-11-20T16:36:37  *** bitcoin-git has left #bitcoin-core-dev
4552019-11-20T16:38:01  *** goatpig has quit IRC
4562019-11-20T16:44:44  *** nosss2 has quit IRC
4572019-11-20T16:45:33  *** diogosergio has joined #bitcoin-core-dev
4582019-11-20T16:50:02  *** diogosergio has quit IRC
4592019-11-20T16:52:52  *** rex4539 has joined #bitcoin-core-dev
4602019-11-20T16:57:42  *** rex4539 has quit IRC
4612019-11-20T17:01:19  *** michaelfolkson has joined #bitcoin-core-dev
4622019-11-20T17:01:33  *** meriadoc has joined #bitcoin-core-dev
4632019-11-20T17:01:41  *** Talkless has joined #bitcoin-core-dev
4642019-11-20T17:04:37  *** michaelfolkson has quit IRC
4652019-11-20T17:04:51  *** Talkless has quit IRC
4662019-11-20T17:05:40  *** Talkless has joined #bitcoin-core-dev
4672019-11-20T17:06:15  *** diogosergio has joined #bitcoin-core-dev
4682019-11-20T17:07:05  *** michaelfolkson has joined #bitcoin-core-dev
4692019-11-20T17:10:42  *** rex4539 has joined #bitcoin-core-dev
4702019-11-20T17:11:09  *** diogosergio has quit IRC
4712019-11-20T17:12:20  *** Talkless has quit IRC
4722019-11-20T17:12:59  *** Talkless has joined #bitcoin-core-dev
4732019-11-20T17:14:21  *** dawggo12 has quit IRC
4742019-11-20T17:15:52  *** dawggo12_ has joined #bitcoin-core-dev
4752019-11-20T17:41:17  *** Highway61 has quit IRC
4762019-11-20T17:41:54  *** mryandao has quit IRC
4772019-11-20T17:42:12  *** mryandao has joined #bitcoin-core-dev
4782019-11-20T17:42:34  *** nik-j has quit IRC
4792019-11-20T17:43:10  *** nik-j has joined #bitcoin-core-dev
4802019-11-20T17:47:17  *** nik-j has quit IRC
4812019-11-20T17:49:29  *** bitcoin-git has joined #bitcoin-core-dev
4822019-11-20T17:49:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3671c5721d42...a8d9f7dfa723
4832019-11-20T17:49:30  <bitcoin-git> bitcoin/master 9999a79 MarcoFalke: travis: Rework CACHE_ERR_MSG
4842019-11-20T17:49:31  <bitcoin-git> bitcoin/master a8d9f7d MarcoFalke: Merge #17420: travis: Rework CACHE_ERR_MSG
4852019-11-20T17:49:42  *** bitcoin-git has left #bitcoin-core-dev
4862019-11-20T17:49:59  *** bitcoin-git has joined #bitcoin-core-dev
4872019-11-20T17:50:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17420: travis: Rework CACHE_ERR_MSG (master...1911-docTravis) https://github.com/bitcoin/bitcoin/pull/17420
4882019-11-20T17:50:01  *** bitcoin-git has left #bitcoin-core-dev
4892019-11-20T17:55:26  *** bitcoin-git has joined #bitcoin-core-dev
4902019-11-20T17:55:26  <bitcoin-git> [bitcoin] achow101 opened pull request #17537: wallet: Cleanup and move opportunistic and superfluous TopUp()s (master...cleanup-topups) https://github.com/bitcoin/bitcoin/pull/17537
4912019-11-20T17:55:37  *** bitcoin-git has left #bitcoin-core-dev
4922019-11-20T17:59:57  *** sanoj has joined #bitcoin-core-dev
4932019-11-20T18:00:02  *** survivor has quit IRC
4942019-11-20T18:03:57  *** kristapsk has joined #bitcoin-core-dev
4952019-11-20T18:10:48  *** nik-j has joined #bitcoin-core-dev
4962019-11-20T18:14:50  *** nik-j has quit IRC
4972019-11-20T18:15:03  *** afk11 has quit IRC
4982019-11-20T18:15:29  *** afk11 has joined #bitcoin-core-dev
4992019-11-20T18:17:39  *** jmp-TOK has joined #bitcoin-core-dev
5002019-11-20T18:19:17  *** Eric3 has left #bitcoin-core-dev
5012019-11-20T18:19:50  *** ExEric3 has joined #bitcoin-core-dev
5022019-11-20T18:21:20  *** Hasu has joined #bitcoin-core-dev
5032019-11-20T18:21:56  *** ExtraCrispy has joined #bitcoin-core-dev
5042019-11-20T18:22:23  *** davterra has quit IRC
5052019-11-20T18:22:51  *** davterra has joined #bitcoin-core-dev
5062019-11-20T18:23:05  *** nik-j has joined #bitcoin-core-dev
5072019-11-20T18:25:51  *** bitcoin-git has joined #bitcoin-core-dev
5082019-11-20T18:25:51  <bitcoin-git> [bitcoin] achow101 closed pull request #17510: Add copy constructor and copy operator= to CScript to remove ubsan suppression (master...cscript-undef) https://github.com/bitcoin/bitcoin/pull/17510
5092019-11-20T18:25:52  *** bitcoin-git has left #bitcoin-core-dev
5102019-11-20T18:27:35  *** nik-j has quit IRC
5112019-11-20T18:29:26  *** rex4539_ has joined #bitcoin-core-dev
5122019-11-20T18:30:52  *** jasonzhouu has joined #bitcoin-core-dev
5132019-11-20T18:32:47  *** rex4539 has quit IRC
5142019-11-20T18:36:56  *** bitcoin-git has joined #bitcoin-core-dev
5152019-11-20T18:36:56  <bitcoin-git> [bitcoin] fanquake opened pull request #17538: build: Bump minimum libc to 2.17 for release binaries (master...bump_libc_217) https://github.com/bitcoin/bitcoin/pull/17538
5162019-11-20T18:36:58  *** bitcoin-git has left #bitcoin-core-dev
5172019-11-20T18:40:35  *** Chris_Stewart_5 has quit IRC
5182019-11-20T18:42:35  *** bitcoin-git has joined #bitcoin-core-dev
5192019-11-20T18:42:35  <bitcoin-git> [bitcoin] hebasto opened pull request #17539: doc: Update and improve Developer Notes (master...20191120-developer-notes) https://github.com/bitcoin/bitcoin/pull/17539
5202019-11-20T18:42:36  *** bitcoin-git has left #bitcoin-core-dev
5212019-11-20T18:42:39  *** rex4539_ has quit IRC
5222019-11-20T18:42:59  *** rex4539 has joined #bitcoin-core-dev
5232019-11-20T18:43:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5242019-11-20T18:56:15  *** nik-j has joined #bitcoin-core-dev
5252019-11-20T18:57:56  *** kabaum has joined #bitcoin-core-dev
5262019-11-20T19:01:50  *** nik-j has quit IRC
5272019-11-20T19:03:28  *** fox2p has quit IRC
5282019-11-20T19:07:53  *** deadlysin has quit IRC
5292019-11-20T19:08:10  *** fox2p has joined #bitcoin-core-dev
5302019-11-20T19:08:28  *** michaelfolkson has quit IRC
5312019-11-20T19:12:53  *** deadlysin has joined #bitcoin-core-dev
5322019-11-20T19:13:15  *** kayabaNerve has joined #bitcoin-core-dev
5332019-11-20T19:20:36  *** ExtraCrispy has quit IRC
5342019-11-20T19:26:01  *** rh0nj has quit IRC
5352019-11-20T19:26:44  *** jonatack has quit IRC
5362019-11-20T19:27:08  *** rh0nj has joined #bitcoin-core-dev
5372019-11-20T19:28:57  *** rex4539 has quit IRC
5382019-11-20T19:32:26  *** kayabaNerve has quit IRC
5392019-11-20T19:37:28  *** Highway61 has joined #bitcoin-core-dev
5402019-11-20T19:50:53  <emilengler> How can I run multiple tests in one file?
5412019-11-20T19:51:05  <emilengler> Like I have a test in one class and antoher test in another class
5422019-11-20T19:51:12  <emilengler> And I want to exectue both
5432019-11-20T19:51:40  <emilengler> Placing both in the "if __name__ == '__main__'" section only exectues the irst one
5442019-11-20T19:53:45  <MarcoFalke> emilengler: There might be a weird interaction when running two test frameworks in succession without shutting down the python process
5452019-11-20T19:53:49  <MarcoFalke> See also the TestShell
5462019-11-20T19:54:08  <MarcoFalke> Why do you need two test frameworks to begin with?
5472019-11-20T19:54:20  <emilengler> I need to medify the bitcoin.conf
5482019-11-20T19:54:38  <emilengler> See #17536
5492019-11-20T19:54:40  <gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler · Pull Request #17536 · bitcoin/bitcoin · GitHub
5502019-11-20T19:54:57  <MarcoFalke> have you seen ./test/functional/feature_config_args.py
5512019-11-20T19:55:13  <emilengler> I would like to run it first with "rpcwhitelistdefault=0" and then "rpcwhitelistdefault+1"
5522019-11-20T19:55:18  <emilengler> MarcoFalke: no not yet
5532019-11-20T19:55:26  <emilengler> But is it possibel to change it on the fly
5542019-11-20T19:55:58  <emilengler> possible*
5552019-11-20T19:56:15  <instagibbs_> reminder: I'm available for review. Can "trade" for easy review of #16795
5562019-11-20T19:56:17  <gribble> https://github.com/bitcoin/bitcoin/issues/16795 | rpc: have raw transaction decoding infer output descriptors by instagibbs · Pull Request #16795 · bitcoin/bitcoin · GitHub
5572019-11-20T19:56:31  <MarcoFalke> I am pretty sure the test framwork needs at least getblockcount permissions to check when the rpc thread is running
5582019-11-20T19:57:13  <MarcoFalke> rpcwhitelistdefault=1 disables all rpcs, right? So that wouldn't work.
5592019-11-20T19:57:21  <emilengler> MarcoFalke: user1 has the permisson to getblockcount
5602019-11-20T19:57:35  <emilengler> MarcoFalke: I'm actually not 100% sure let me try
5612019-11-20T19:58:49  <emilengler> Yes it restricts accesss to all RPC commands
5622019-11-20T19:58:54  <emilengler> It rutrns an 403 then
5632019-11-20T19:59:39  <MarcoFalke> I guess 403 is sufficient, as long as it is not a timeout or conenction error?
5642019-11-20T19:59:56  <emilengler> Yes
5652019-11-20T20:00:06  <emilengler> But still I need to change it after the test was already launceh
5662019-11-20T20:00:12  <emilengler> It would require a restart of bitcond
5672019-11-20T20:00:18  <emilengler> bitcoind*
5682019-11-20T20:03:01  <MarcoFalke> Yeah, just call `(re)start_node` and fixup `wait_for_rpc_connection` to return on 403
5692019-11-20T20:03:41  *** nik-j has joined #bitcoin-core-dev
5702019-11-20T20:04:04  <emilengler> I'm a bit confused, where should I call (re)start_node and how can I modify the cli args then?
5712019-11-20T20:04:09  <emilengler> After run_tests()?
5722019-11-20T20:04:16  <emilengler> run_test()*
5732019-11-20T20:06:26  *** rex4539 has joined #bitcoin-core-dev
5742019-11-20T20:08:06  *** Highway61 has quit IRC
5752019-11-20T20:08:07  *** nik-j has quit IRC
5762019-11-20T20:09:19  *** Talkless has quit IRC
5772019-11-20T20:13:03  <instagibbs_> can someone remind me/show an example of wallet endpoint selection for python framework
5782019-11-20T20:15:20  <MarcoFalke> emilengler: If you want to modify the conf file, you'd have to stop the node and then start it again
5792019-11-20T20:15:21  *** michaelfolkson has joined #bitcoin-core-dev
5802019-11-20T20:15:28  <MarcoFalke> Same for command line args
5812019-11-20T20:15:39  <MarcoFalke> instagibbs_: wallet_multiwallet
5822019-11-20T20:15:43  <MarcoFalke> .py
5832019-11-20T20:15:46  <instagibbs_> dank
5842019-11-20T20:16:10  <sipa> are release linux binaries build with zmq support included?
5852019-11-20T20:16:47  <instagibbs_> for players at home: "node.get_wallet_rpc(new_wallet_name)"
5862019-11-20T20:17:10  <MarcoFalke> sipa: yes
5872019-11-20T20:18:20  <sipa> MarcoFalke: statically linked?
5882019-11-20T20:20:30  <MarcoFalke> I would believe everything in the gitian binaries is statically linked
5892019-11-20T20:21:04  <emilengler> MarcoFalke: Which function restarts the node?
5902019-11-20T20:21:32  <MarcoFalke> the function in the test_framework `def restart_node(...`
5912019-11-20T20:21:43  <MarcoFalke> or `def stop_node` and `def start_node`
5922019-11-20T20:25:30  *** deadlysin has quit IRC
5932019-11-20T20:25:41  <instagibbs_> "CHECK_NONFATAL(condition) should be used instead of assert for RPC code." what. I don't see any instances of that string in the codebase....
5942019-11-20T20:25:59  <instagibbs_> (linter output)
5952019-11-20T20:26:39  <instagibbs_> or is that like... paraphrasing that it shouldn't blow up and rather return an error in json
5962019-11-20T20:29:09  *** michaelfolkson has quit IRC
5972019-11-20T20:29:45  <MarcoFalke> instagibbs_: Have you run `git grep CHECK_NONFATAL bitcoin/master`?
5982019-11-20T20:29:53  <MarcoFalke> There should be plenty
5992019-11-20T20:30:50  *** michaelfolkson has joined #bitcoin-core-dev
6002019-11-20T20:33:36  <instagibbs_> oh, guess i havent rebased in a long time, thanks
6012019-11-20T20:37:11  *** nik-j has joined #bitcoin-core-dev
6022019-11-20T20:47:20  *** nik-j has quit IRC
6032019-11-20T20:50:55  *** bitcoin-git has joined #bitcoin-core-dev
6042019-11-20T20:50:55  <bitcoin-git> [bitcoin] theStack opened pull request #17541: test: add functional test for non-standard bare multisig txs (master...20191120-test-for-bare-multisig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17541
6052019-11-20T20:50:56  *** bitcoin-git has left #bitcoin-core-dev
6062019-11-20T20:51:15  *** bitcoin-git has joined #bitcoin-core-dev
6072019-11-20T20:51:15  <bitcoin-git> [bitcoin] brakmic opened pull request #17542: build: Create test utility library from src/test/util/ (master...test-util-lib) https://github.com/bitcoin/bitcoin/pull/17542
6082019-11-20T20:51:16  *** bitcoin-git has left #bitcoin-core-dev
6092019-11-20T21:00:02  *** jmp-TOK has quit IRC
6102019-11-20T21:03:12  *** deadlysin has joined #bitcoin-core-dev
6112019-11-20T21:08:28  *** nik-j has joined #bitcoin-core-dev
6122019-11-20T21:13:38  *** nik-j has quit IRC
6132019-11-20T21:15:36  *** zivl has quit IRC
6142019-11-20T21:22:30  *** emilengler has quit IRC
6152019-11-20T21:23:17  <fanquake> sipa did you have a particular question in regards to zmq?
6162019-11-20T21:25:04  <sipa> fanquake: i was trying to figure out https://bitcoin.stackexchange.com/q/91802/208
6172019-11-20T21:27:11  <sipa> fanquake: still in the us?
6182019-11-20T21:31:10  *** bitcoin-git has joined #bitcoin-core-dev
6192019-11-20T21:31:10  <bitcoin-git> [bitcoin] ariard opened pull request #17543: Wallet: undo conflicts properly in case of blocks disconnection (master...2019-11-fix-wallet-unconflicts) https://github.com/bitcoin/bitcoin/pull/17543
6202019-11-20T21:31:12  *** bitcoin-git has left #bitcoin-core-dev
6212019-11-20T21:31:32  <fanquake> sipa yea I am. For a little while longer yet.
6222019-11-20T21:31:47  <fanquake> I’ll look ag the question shortly.
6232019-11-20T21:36:55  *** timothy has quit IRC
6242019-11-20T21:41:29  *** nik-j has joined #bitcoin-core-dev
6252019-11-20T21:43:54  *** bitcoin-git has joined #bitcoin-core-dev
6262019-11-20T21:43:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a8d9f7dfa723...41162c0ba0a1
6272019-11-20T21:43:55  <bitcoin-git> bitcoin/master fa00393 MarcoFalke: ci: Make all filesystem operations inside docker
6282019-11-20T21:43:56  <bitcoin-git> bitcoin/master fab1333 MarcoFalke: ci: Remove git from required packages on host
6292019-11-20T21:43:56  <bitcoin-git> bitcoin/master fa493ef MarcoFalke: ci: Make ci system read-only on the git work tree
6302019-11-20T21:44:02  *** baldur has quit IRC
6312019-11-20T21:44:07  *** bitcoin-git has left #bitcoin-core-dev
6322019-11-20T21:44:25  *** bitcoin-git has joined #bitcoin-core-dev
6332019-11-20T21:44:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17423: ci: Make ci system read-only on the git work tree (master...1911-ciRo) https://github.com/bitcoin/bitcoin/pull/17423
6342019-11-20T21:44:37  *** bitcoin-git has left #bitcoin-core-dev
6352019-11-20T21:48:07  *** santa_1 has joined #bitcoin-core-dev
6362019-11-20T21:50:37  *** nik-j has quit IRC
6372019-11-20T21:52:20  *** bitcoin-git has joined #bitcoin-core-dev
6382019-11-20T21:52:20  <bitcoin-git> [bitcoin] fanquake opened pull request #17545: build: remove libanl.so.1 from ALLOWED_LIBRARIES (master...remove_libanl_from_allowed_symbols) https://github.com/bitcoin/bitcoin/pull/17545
6392019-11-20T21:52:21  *** bitcoin-git has left #bitcoin-core-dev
6402019-11-20T21:55:25  *** bitcoin-git has joined #bitcoin-core-dev
6412019-11-20T21:55:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/41162c0ba0a1...b7bc9b833009
6422019-11-20T21:55:26  <bitcoin-git> bitcoin/master faffa7f MarcoFalke: wallet: Avoid showing GUI popups on RPC errors (take 2)
6432019-11-20T21:55:26  <bitcoin-git> bitcoin/master b7bc9b8 MarcoFalke: Merge #17444: wallet: Avoid showing GUI popups on RPC errors (take 2)
6442019-11-20T21:55:28  *** bitcoin-git has left #bitcoin-core-dev
6452019-11-20T21:55:45  *** bitcoin-git has joined #bitcoin-core-dev
6462019-11-20T21:55:45  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17444: wallet: Avoid showing GUI popups on RPC errors (take 2) (master...1911-walletGuiPopupRpc) https://github.com/bitcoin/bitcoin/pull/17444
6472019-11-20T21:55:46  *** bitcoin-git has left #bitcoin-core-dev
6482019-11-20T21:56:25  *** nik-j has joined #bitcoin-core-dev
6492019-11-20T21:57:17  *** baldur has joined #bitcoin-core-dev
6502019-11-20T22:00:47  *** nik-j has quit IRC
6512019-11-20T22:02:42  *** jonatack has joined #bitcoin-core-dev
6522019-11-20T22:05:39  *** afk11 has quit IRC
6532019-11-20T22:05:39  *** mryandao has quit IRC
6542019-11-20T22:05:48  *** andrewtoth has quit IRC
6552019-11-20T22:06:27  *** afk11 has joined #bitcoin-core-dev
6562019-11-20T22:06:55  *** mryandao has joined #bitcoin-core-dev
6572019-11-20T22:10:54  *** michaelfolkson has quit IRC
6582019-11-20T22:12:42  *** jtimon has quit IRC
6592019-11-20T22:13:51  *** Highway61 has joined #bitcoin-core-dev
6602019-11-20T22:19:50  *** nosss2 has joined #bitcoin-core-dev
6612019-11-20T22:20:57  *** diogosergio has joined #bitcoin-core-dev
6622019-11-20T22:22:22  *** justan0theruser has joined #bitcoin-core-dev
6632019-11-20T22:23:13  *** justanotheruser has quit IRC
6642019-11-20T22:25:38  *** Chris_Stewart_5 has quit IRC
6652019-11-20T22:26:23  *** EagleTM has joined #bitcoin-core-dev
6662019-11-20T22:27:11  *** mdunnio_ has joined #bitcoin-core-dev
6672019-11-20T22:28:06  *** sipsorcery has quit IRC
6682019-11-20T22:28:28  *** mdunnio has quit IRC
6692019-11-20T22:31:12  *** nik-j has joined #bitcoin-core-dev
6702019-11-20T22:35:53  *** nik-j has quit IRC
6712019-11-20T22:36:01  *** mdunnio has joined #bitcoin-core-dev
6722019-11-20T22:36:30  *** mdunnio_ has quit IRC
6732019-11-20T22:39:41  *** nik-j has joined #bitcoin-core-dev
6742019-11-20T22:41:08  *** pinheadmz has quit IRC
6752019-11-20T22:43:39  *** deadlysin has quit IRC
6762019-11-20T22:44:54  *** nik-j has quit IRC
6772019-11-20T22:46:56  *** diogosergio has quit IRC
6782019-11-20T22:57:09  *** mdunnio has quit IRC
6792019-11-20T22:57:10  *** diogosergio has joined #bitcoin-core-dev
6802019-11-20T23:01:34  *** diogosergio has quit IRC
6812019-11-20T23:06:00  *** deadlysin has joined #bitcoin-core-dev
6822019-11-20T23:22:54  *** deadlysin has quit IRC
6832019-11-20T23:44:43  *** nik-j has joined #bitcoin-core-dev
6842019-11-20T23:54:16  *** nik-j has quit IRC
6852019-11-20T23:57:09  *** pinheadmz has joined #bitcoin-core-dev
6862019-11-20T23:58:24  *** marcoagner has quit IRC