1 2019-12-10T00:00:02  *** mreider has quit IRC
  2 2019-12-10T00:10:46  *** Evel-Knievel has quit IRC
  3 2019-12-10T00:11:18  *** SiAnDoG_ has joined #bitcoin-core-dev
  4 2019-12-10T00:12:48  *** Evel-Knievel has joined #bitcoin-core-dev
  5 2019-12-10T00:16:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  6 2019-12-10T00:30:52  *** sipsorcery has quit IRC
  7 2019-12-10T00:33:44  *** promag has quit IRC
  8 2019-12-10T00:38:57  *** sipsorcery has joined #bitcoin-core-dev
  9 2019-12-10T00:43:13  *** luke-jr has quit IRC
 10 2019-12-10T00:44:17  *** luke-jr has joined #bitcoin-core-dev
 11 2019-12-10T00:44:41  *** sipsorcery has quit IRC
 12 2019-12-10T00:44:56  *** sipsorcery has joined #bitcoin-core-dev
 13 2019-12-10T00:46:03  *** AaronvanW has quit IRC
 14 2019-12-10T00:48:28  *** Highway61 has joined #bitcoin-core-dev
 15 2019-12-10T00:50:52  *** ddustin has quit IRC
 16 2019-12-10T00:56:14  *** calvz14 has joined #bitcoin-core-dev
 17 2019-12-10T00:59:31  *** SiAnDoG__ has joined #bitcoin-core-dev
 18 2019-12-10T01:00:08  *** SiAnDoG_ has quit IRC
 19 2019-12-10T01:03:21  *** Highway61 has quit IRC
 20 2019-12-10T01:09:57  *** promag has joined #bitcoin-core-dev
 21 2019-12-10T01:12:17  *** shaunsun has quit IRC
 22 2019-12-10T01:12:59  *** shaunsun_ has quit IRC
 23 2019-12-10T01:14:56  *** promag has quit IRC
 24 2019-12-10T01:16:02  *** SukhE1 has joined #bitcoin-core-dev
 25 2019-12-10T01:20:29  *** sipsorcery has quit IRC
 26 2019-12-10T01:23:17  *** Chris_Stewart_5 has quit IRC
 27 2019-12-10T01:34:40  *** Dean_Guss has quit IRC
 28 2019-12-10T01:34:40  *** kristapsk has quit IRC
 29 2019-12-10T01:34:40  *** SiAnDoG__ has quit IRC
 30 2019-12-10T01:34:42  *** _andrewtoth_ has quit IRC
 31 2019-12-10T01:34:59  *** SiAnDoG__ has joined #bitcoin-core-dev
 32 2019-12-10T01:34:59  *** kristapsk has joined #bitcoin-core-dev
 33 2019-12-10T01:35:00  *** _andrewtoth_ has joined #bitcoin-core-dev
 34 2019-12-10T01:42:39  *** dviola has joined #bitcoin-core-dev
 35 2019-12-10T01:43:47  *** calvz14 has quit IRC
 36 2019-12-10T01:51:40  *** gouhobandgraw has left #bitcoin-core-dev
 37 2019-12-10T02:11:12  *** Dean_Guss has joined #bitcoin-core-dev
 38 2019-12-10T02:37:40  *** jeremyrubin has quit IRC
 39 2019-12-10T02:38:19  *** promag has joined #bitcoin-core-dev
 40 2019-12-10T02:42:37  *** promag has quit IRC
 41 2019-12-10T02:44:17  *** millerti has quit IRC
 42 2019-12-10T02:44:47  *** wullon has quit IRC
 43 2019-12-10T02:46:10  *** abacus has quit IRC
 44 2019-12-10T02:46:20  *** abacus has joined #bitcoin-core-dev
 45 2019-12-10T02:47:38  *** wullon has joined #bitcoin-core-dev
 46 2019-12-10T02:47:39  <wumpus> the path length is not actually an issue, it's just a general warning that it always throws
 47 2019-12-10T02:49:05  <wumpus> it's kind of annoying but only in the way that it's overly apparent in the log so it's always a false lead when something goes wrong in appveyor
 48 2019-12-10T02:49:34  <fanquake> wumpus ah ok. Having trouble keeping up with Appveyor changes.
 49 2019-12-10T02:54:50  *** dviola has quit IRC
 50 2019-12-10T02:55:46  <wumpus> the build is based on some package system (vcproj) which has its own breaking changes all the time, I don't know if it offers something like version pinning (it would avoid things randomly breaking on one hand, on the other it'd be one more set of dependency versions to keep up to date...)
 51 2019-12-10T02:56:58  *** davterra has joined #bitcoin-core-dev
 52 2019-12-10T02:56:59  *** dviola has joined #bitcoin-core-dev
 53 2019-12-10T02:57:09  <luke-jr> why can't Appveyor just use autotools?
 54 2019-12-10T02:57:26  <wumpus> anyhow I don't know if the new error is caused by that or some change of our own this time: "C:\projects\bitcoin\src\sync.h(139,23): error C2220: the following warning is treated as an error [C:\projects\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]"
 55 2019-12-10T02:57:42  <wumpus> because eeeeveryone likes to do things their own way
 56 2019-12-10T03:00:01  *** SukhE1 has quit IRC
 57 2019-12-10T03:00:19  <wumpus> the last change in sync.h was in september
 58 2019-12-10T03:02:12  <wumpus> "Tries to lock the mutex. Returns immediately. On successful lock acquisition returns true, otherwise returns false. "
 59 2019-12-10T03:03:04  <wumpus> I wonder why we're ignoring that return value and using Base::owns_lock instead
 60 2019-12-10T03:15:47  *** bitcoin-git has joined #bitcoin-core-dev
 61 2019-12-10T03:15:47  <bitcoin-git> [bitcoin] laanwj opened pull request #17707: util: Use try_lock return value in UniqueLock::TryEnter (master...2019_12_try_lock_returnval) https://github.com/bitcoin/bitcoin/pull/17707
 62 2019-12-10T03:15:59  *** bitcoin-git has left #bitcoin-core-dev
 63 2019-12-10T03:31:38  <wumpus> ^^ the other option would be to disable the warning, but I think avoiding unnecessary calls to owns_lock is better
 64 2019-12-10T03:33:30  <wumpus> cfields_: BlueMatt: we should make sure https://bitcoincore.org/depends-sources is up to date
 65 2019-12-10T03:47:32  *** cmn1 has joined #bitcoin-core-dev
 66 2019-12-10T03:49:09  <wumpus> looks like more things broke in appveyor, fixed one warning and a new batch appears
 67 2019-12-10T03:52:55  *** felixfoertsch23 has joined #bitcoin-core-dev
 68 2019-12-10T03:55:29  *** felixfoertsch has quit IRC
 69 2019-12-10T04:07:15  <wumpus> is #17530 serious UB or should I just close it?
 70 2019-12-10T04:07:17  <gribble> https://github.com/bitcoin/bitcoin/issues/17530 | Use natural alignment for prevector by laanwj · Pull Request #17530 · bitcoin/bitcoin · GitHub
 71 2019-12-10T04:09:02  <wumpus> I have very little interest in language lawyering but AFAIK misaligned integers/pointers can sometimes lead to real issues
 72 2019-12-10T04:16:54  *** justanotheruser has quit IRC
 73 2019-12-10T04:22:41  <sipa> wumpus: i suspect little impact right now in production
 74 2019-12-10T04:23:29  <sipa> becaus epretty much all modern platforms don't care about alignment (at worst it's a performance issue), and for cases where alignment is actually necessary, it'd be an immediate trap rather than misbehavior
 75 2019-12-10T04:23:53  <sipa> but i think there is a concern that compilers may misoptimize in the futurr
 76 2019-12-10T04:25:14  <sipa> and of course it interferes with sanitizers that correctly detect misaligned access...
 77 2019-12-10T04:26:04  *** justanotheruser has joined #bitcoin-core-dev
 78 2019-12-10T04:28:17  <wumpus> ok but an immediate trap is also bad
 79 2019-12-10T04:28:25  <wumpus> we don't want the software to crash right?
 80 2019-12-10T04:30:55  <wumpus> do we, in general, try to avoid unalgned accesses in the code?
 81 2019-12-10T04:32:59  <wumpus> (this is the only use of pragma(pack) FWIW)
 82 2019-12-10T04:35:40  <wumpus> I think it's safer to remove it
 83 2019-12-10T04:39:11  <sipa> i'm very surprised that pragma pack actually makes the compiler generate code it considers itself incorrect
 84 2019-12-10T04:39:34  <wumpus> FWIW it's the same in rust, pragma(pack) is a cesspool of UB
 85 2019-12-10T04:40:43  <sipa> looking at the actual chabge
 86 2019-12-10T04:40:44  <sipa> change
 87 2019-12-10T04:41:13  <wumpus> it's for when a data structure needs to be tightly packed in memory, but those are really exceptional, generally mis-informed protocol parsing and such
 88 2019-12-10T04:42:28  <wumpus> I don't think that's the case here, none of that code relies on the struct's binary layout
 89 2019-12-10T04:43:36  <sipa> yeah, my only question is if this significantly changes the size of CScript
 90 2019-12-10T04:43:46  <sipa> as doing so may affect the performance of CCoinsCache
 91 2019-12-10T04:44:04  <sipa> if it doesn't affect it significantly we should just remove the pragma
 92 2019-12-10T04:44:29  <wumpus> but using UB to get a speedup is a bit questionable
 93 2019-12-10T04:44:47  <sipa> oh absolutely!
 94 2019-12-10T04:44:50  <wumpus> I think that's over the line that is reasonable for a probject like this
 95 2019-12-10T04:44:59  <sipa> we need to get rid of the pack regardless, if it causes invalid code
 96 2019-12-10T04:45:42  <sipa> but if just removing it causes a cache impact, we should perhaps look for another solution to get better memory usage
 97 2019-12-10T04:46:42  <wumpus> sure, that's always a good thing
 98 2019-12-10T05:01:09  *** diogosergio has joined #bitcoin-core-dev
 99 2019-12-10T05:06:59  *** brakmic has joined #bitcoin-core-dev
100 2019-12-10T05:08:53  <aj> CScriptBase goes from 32 to 40 bytes for me on clang, after dropping the pragma :(
101 2019-12-10T05:08:57  *** diogosergio has quit IRC
102 2019-12-10T05:11:47  <wumpus> same in gcc
103 2019-12-10T05:12:36  <wumpus> I do not really understand why, though
104 2019-12-10T05:15:55  *** dandelionLyy has joined #bitcoin-core-dev
105 2019-12-10T05:18:28  <wumpus> let's try shuffling the fields inside prevector
106 2019-12-10T05:19:22  <aj> i think having the pointer in the union is forcing it to be aligned and/or padded, but shuffling isn't fixing it for me (yet at least)
107 2019-12-10T05:21:13  <wumpus> I've moved the char* pointer first, then the capacity, then the size
108 2019-12-10T05:21:23  <wumpus> (but it has to recompile almost everything...)
109 2019-12-10T05:22:00  <aj> wumpus: yeah, me too. i'm getting the union as 32 bytes despite the array being 28 bytes and the struct having 8+4 bytes
110 2019-12-10T05:22:42  <wumpus> oh
111 2019-12-10T05:22:46  <aj> or is sizeof automatically a multiple of alignof? yeah that's it isn't it?
112 2019-12-10T05:24:24  <wumpus> yes, I think so
113 2019-12-10T05:26:19  <wumpus> I wonder if there's a way to express not wanting to waste unnecessary bytes in/after the union but still putting everything at the required alignment
114 2019-12-10T05:29:24  <wumpus> the final word only needs 4-byte alignment not 8-byte
115 2019-12-10T05:31:47  *** Victor_sueca has joined #bitcoin-core-dev
116 2019-12-10T05:32:27  *** dandelionLyy has quit IRC
117 2019-12-10T05:32:28  <wumpus> (... putting the size *inside* the union might solve it, but would be even scarier because it'd rely on the two union members overlapping in a certain way)
118 2019-12-10T05:34:36  <aj> wumpus: could move the pragma to only be around the union declaration, i think that works and would fix the observed bugs, but wouldn't quite guarantee that it was aligned at 8 bytes
119 2019-12-10T05:34:56  *** Victorsueca has quit IRC
120 2019-12-10T05:35:57  <wumpus> it wouldn't fully solve the problem either
121 2019-12-10T05:36:36  <wumpus> exactly, the outer structure would then get an alignment of 4 instead of 8, I suppose
122 2019-12-10T05:37:47  *** pinheadmz has joined #bitcoin-core-dev
123 2019-12-10T05:39:54  <aj> putting size inside the union looks like it'd just invoke other sets of undefined behaviour
124 2019-12-10T05:40:13  <wumpus> yes
125 2019-12-10T05:40:27  <wumpus> it's aliasing
126 2019-12-10T05:40:29  <sipa> hmm, maybe the better question is the sizeof of CCoin
127 2019-12-10T05:40:47  <sipa> there is a lot more in there than just a CScript
128 2019-12-10T05:45:29  <sipa> #17060 contains a commit that changes the prevector layout as well, and iirc also removes the pragma pack
129 2019-12-10T05:45:32  <gribble> https://github.com/bitcoin/bitcoin/issues/17060 | Cache 26% more coins: Reduce CCoinsMap::value_type from 96 to 76 bytes by martinus · Pull Request #17060 · bitcoin/bitcoin · GitHub
130 2019-12-10T05:46:41  <wumpus> it doesn't seem to remove the pragma pack
131 2019-12-10T05:47:05  <sipa> oh, then i misremember
132 2019-12-10T05:47:19  <wumpus> it does put a size inside the union, in addition to the size outside it (which is a smaller type)
133 2019-12-10T05:48:13  <wumpus> it was worth checking :)
134 2019-12-10T05:53:20  <aj> oh, there's an alignos specifier in c++11? maybe combine that with pragma pack on just the union? https://en.cppreference.com/w/cpp/language/alignas
135 2019-12-10T05:54:17  <aj> #pragma pack union d_o_i { }; #pragma pack(pop) alignas(alignof(char*)) d_o_i _union = {}; size_type _size = 0;   with char*indirect before size_type capacity; seems to work
136 2019-12-10T05:55:17  <sipa> will that not generate unaligned access toi?
137 2019-12-10T05:55:19  <sipa> too?
138 2019-12-10T05:56:14  <wumpus> if you can reliably control the alignment of the outer structure, you can pack the fields so that no unaligned access happens
139 2019-12-10T05:56:42  <wumpus> (I think that's already OK with current prevector, if it happens to end up on a 8-aligned address)
140 2019-12-10T05:57:19  <aj> sipa: if you used direct_or_indirect elsewhere you could, but alignas() forces _union to be aligned right, and that forces CScritBase to also require 8 byte alignment everywhere it's used, which should fix things i think
141 2019-12-10T05:57:56  <wumpus> yes, forcing prevctor at align(sizeof(char*)) should do it
142 2019-12-10T05:58:21  <sipa> ah
143 2019-12-10T05:59:16  <wumpus> e.g. the current inside of a prevector is, in the indirect case: uint32_t uint32_t char*   ... which is ok, at least for architetectures with 32 and 64 bit pointers, to be even more sure move the char* to the beginning and the size to the end
144 2019-12-10T06:00:01  *** cmn1 has quit IRC
145 2019-12-10T06:04:39  <aj> wumpus: posted a diff in the PR that seems like it works right for me
146 2019-12-10T06:06:39  <wumpus> that's quite a bigger change than I expected
147 2019-12-10T06:07:08  <aj> it's mostly comments and static_asserts
148 2019-12-10T06:07:15  <wumpus> shouldn't you alignas the *outer* structure?
149 2019-12-10T06:08:33  <wumpus> I'm giving up here, I admit I don't know enough about C++ compilers to do this safely
150 2019-12-10T06:08:35  <aj> i think you could `class alignas(alignof(char*)) prevector { .. }`
151 2019-12-10T06:08:53  *** DougieBot5000 has quit IRC
152 2019-12-10T06:09:43  <aj> could probably *just* do that and not change the pack pragma or reorder anything even
153 2019-12-10T06:11:23  <sipa> aj: but what is the resulting impact on CCoinCacheEntry or whatever it is called?
154 2019-12-10T06:11:39  <sipa> maybe that still grows?
155 2019-12-10T06:12:38  *** spinza has quit IRC
156 2019-12-10T06:15:44  <wumpus> I doubt it
157 2019-12-10T06:16:58  *** bitcoin-git has joined #bitcoin-core-dev
158 2019-12-10T06:16:59  <bitcoin-git> [bitcoin] laanwj closed pull request #17530: Use natural alignment for prevector (master...2019_11_prevector) https://github.com/bitcoin/bitcoin/pull/17530
159 2019-12-10T06:17:00  *** bitcoin-git has left #bitcoin-core-dev
160 2019-12-10T06:17:07  *** smibarber has joined #bitcoin-core-dev
161 2019-12-10T06:23:23  *** pinheadmz has quit IRC
162 2019-12-10T06:24:02  <wumpus> aj: ok, looking at your diff more I think putting the #pragma pack(push,1)  inside the structure is a good idea, it makes sure that the size_type size is still aligned correctly no matter what sizeof(T)*N is
163 2019-12-10T06:25:56  <wumpus> aj: can't find anything wrong with it, I think it would even work out for 128 bit pointers
164 2019-12-10T06:27:04  <wumpus> e.g. the beginning of _union is aligned to alignas(alignof(char*)), which is where the pointer is
165 2019-12-10T06:27:34  <wumpus> alignas(char*) seems to work too
166 2019-12-10T06:28:45  <aj> so it does!
167 2019-12-10T06:28:57  *** smibarber has quit IRC
168 2019-12-10T06:30:57  <aj> before:  Coin: 48,8 CCoinsCacheEntry: 56,8, CScript: 32,1    after:  48,8 56,8 32,8
169 2019-12-10T06:31:43  <wumpus> that's sizeof(X),alignof(X)?
170 2019-12-10T06:31:45  <aj> (that's `class alignas(char*) prevector { .. }`, so it seems to work right)
171 2019-12-10T06:31:51  <aj> yeah, sizeof,alignof
172 2019-12-10T06:32:22  <wumpus> LGTM then, that should solve the alignment issue without increasing the size of any of the structures
173 2019-12-10T06:33:51  <sipa> nice!
174 2019-12-10T06:36:02  *** promag has joined #bitcoin-core-dev
175 2019-12-10T06:40:35  *** promag has quit IRC
176 2019-12-10T06:50:48  *** madwoota1 has joined #bitcoin-core-dev
177 2019-12-10T07:08:19  *** kabaum has quit IRC
178 2019-12-10T07:12:32  *** Kiminuo has joined #bitcoin-core-dev
179 2019-12-10T07:20:32  *** mol has joined #bitcoin-core-dev
180 2019-12-10T07:36:18  *** jungly has joined #bitcoin-core-dev
181 2019-12-10T07:36:50  *** EvaristeGalois has joined #bitcoin-core-dev
182 2019-12-10T07:46:57  *** promag has joined #bitcoin-core-dev
183 2019-12-10T07:48:07  *** vasild_ is now known as vasild
184 2019-12-10T07:49:21  *** vasild has quit IRC
185 2019-12-10T07:50:43  *** vasild has joined #bitcoin-core-dev
186 2019-12-10T07:53:31  *** promag has quit IRC
187 2019-12-10T08:04:52  *** promag has joined #bitcoin-core-dev
188 2019-12-10T08:08:31  *** sipsorcery has joined #bitcoin-core-dev
189 2019-12-10T08:09:20  *** promag has quit IRC
190 2019-12-10T08:17:31  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-12-10T08:17:31  <bitcoin-git> [bitcoin] ajtowns opened pull request #17708: prevector: avoid misaligned member accesses (master...201912-prevec-pack) https://github.com/bitcoin/bitcoin/pull/17708
192 2019-12-10T08:17:32  *** bitcoin-git has left #bitcoin-core-dev
193 2019-12-10T08:20:12  *** marcoagner has joined #bitcoin-core-dev
194 2019-12-10T08:24:36  *** spinza has joined #bitcoin-core-dev
195 2019-12-10T08:27:39  <vasild> Ah, I am late to the alignment party, but let me throw my $0.02: the program would indeed crash on nonaligned access at least on some platforms (Solaris/sparc64). E.g. if you have a uint64_t pointer that points to a location that is not aligned on a 8 byte boundary. x86 is more forgiving - no crash, but however the read or write is split in two words so it is not atomic anymore which could cause
196 2019-12-10T08:27:45  <vasild> difficult to debug bugs if some code assumes that read/writes to 64 integers are atomic on 64 bit CPUs (which they are if aligned, and yes, better use std::atomic).
197 2019-12-10T08:28:49  *** luke-jr has quit IRC
198 2019-12-10T08:29:20  *** luke-jr has joined #bitcoin-core-dev
199 2019-12-10T08:29:50  *** Guyver2 has joined #bitcoin-core-dev
200 2019-12-10T08:30:58  *** ddustin has joined #bitcoin-core-dev
201 2019-12-10T08:35:25  *** ddustin has quit IRC
202 2019-12-10T08:41:39  *** Scrat has joined #bitcoin-core-dev
203 2019-12-10T08:42:49  *** luke-jr has quit IRC
204 2019-12-10T08:44:17  *** luke-jr has joined #bitcoin-core-dev
205 2019-12-10T08:49:53  *** Scrat has quit IRC
206 2019-12-10T08:51:00  *** marcoagner has quit IRC
207 2019-12-10T09:00:02  *** madwoota1 has quit IRC
208 2019-12-10T09:12:55  *** promag has joined #bitcoin-core-dev
209 2019-12-10T09:13:45  <wumpus> we definitely don't assume writes to CScript are atomic :)
210 2019-12-10T09:14:16  *** DougieBot5000 has joined #bitcoin-core-dev
211 2019-12-10T09:14:46  *** promag_ has joined #bitcoin-core-dev
212 2019-12-10T09:15:02  *** timothy has joined #bitcoin-core-dev
213 2019-12-10T09:16:11  *** AaronvanW has joined #bitcoin-core-dev
214 2019-12-10T09:16:58  *** promag has quit IRC
215 2019-12-10T09:17:27  *** lunaphyte_ has joined #bitcoin-core-dev
216 2019-12-10T09:29:36  <sipsorcery> re. the latest appveyor job failures I'm not seeing any problem with local msvc builds.
217 2019-12-10T09:29:57  <sipsorcery> suspect it could be related to appveyor updating their VS2019 image https://www.appveyor.com/updates/
218 2019-12-10T09:30:55  <sipsorcery> I'll do some checks by switching one of my appveyor jobs to the previous VS2019 image.
219 2019-12-10T09:31:21  *** b10c has joined #bitcoin-core-dev
220 2019-12-10T09:38:10  *** Zenton has joined #bitcoin-core-dev
221 2019-12-10T09:40:52  *** vasild has quit IRC
222 2019-12-10T09:48:14  *** sipsorcery has quit IRC
223 2019-12-10T09:48:25  *** nijynot has joined #bitcoin-core-dev
224 2019-12-10T09:50:05  <wumpus> they should really stop changing those kind of things behind our back
225 2019-12-10T09:54:59  *** sipsorcery has joined #bitcoin-core-dev
226 2019-12-10T10:06:10  *** vasild has joined #bitcoin-core-dev
227 2019-12-10T10:10:59  *** kabaum has joined #bitcoin-core-dev
228 2019-12-10T10:18:27  *** n00by_d00by has joined #bitcoin-core-dev
229 2019-12-10T10:21:36  *** n00by_d00by has quit IRC
230 2019-12-10T10:22:18  *** jonatack has quit IRC
231 2019-12-10T10:24:39  *** goatpig_ has quit IRC
232 2019-12-10T10:24:49  *** shaunsun_ has joined #bitcoin-core-dev
233 2019-12-10T10:24:49  *** shaunsun has joined #bitcoin-core-dev
234 2019-12-10T10:24:49  *** goatpig has joined #bitcoin-core-dev
235 2019-12-10T10:28:48  *** bitcoin-git has joined #bitcoin-core-dev
236 2019-12-10T10:28:48  <bitcoin-git> [bitcoin] sipsorcery opened pull request #17709: msvc: Add an ignore for warning C4834 related to nodiscard attribute. (master...msvc_ignore_c4834) https://github.com/bitcoin/bitcoin/pull/17709
237 2019-12-10T10:29:01  *** bitcoin-git has left #bitcoin-core-dev
238 2019-12-10T10:29:45  *** shaunsun__ has joined #bitcoin-core-dev
239 2019-12-10T10:30:33  *** bitcoin-git has joined #bitcoin-core-dev
240 2019-12-10T10:30:33  <bitcoin-git> [bitcoin] laanwj closed pull request #17707: util: Use try_lock return value in UniqueLock::TryEnter (master...2019_12_try_lock_returnval) https://github.com/bitcoin/bitcoin/pull/17707
241 2019-12-10T10:30:35  *** bitcoin-git has left #bitcoin-core-dev
242 2019-12-10T10:32:24  *** shaunsun_ has quit IRC
243 2019-12-10T10:32:24  *** shaunsun has quit IRC
244 2019-12-10T10:33:36  *** shaunsun has joined #bitcoin-core-dev
245 2019-12-10T10:37:24  *** midnight has quit IRC
246 2019-12-10T10:38:55  *** promag_ has quit IRC
247 2019-12-10T10:42:53  *** promag has joined #bitcoin-core-dev
248 2019-12-10T10:44:35  *** midnightmagic has joined #bitcoin-core-dev
249 2019-12-10T10:50:15  *** midnightmagic is now known as midnight
250 2019-12-10T10:58:22  *** promag has quit IRC
251 2019-12-10T10:58:31  *** jonatack has joined #bitcoin-core-dev
252 2019-12-10T11:09:41  *** Highway61 has joined #bitcoin-core-dev
253 2019-12-10T11:11:17  *** jonatack has quit IRC
254 2019-12-10T11:15:38  *** promag has joined #bitcoin-core-dev
255 2019-12-10T11:16:08  *** belcher has quit IRC
256 2019-12-10T11:16:23  *** bitcoin-git has joined #bitcoin-core-dev
257 2019-12-10T11:16:24  <bitcoin-git> [bitcoin] sipsorcery opened pull request #17710: msvc: Change appveyor build image to previous visual studio 2019. (master...appveyor_prev2019) https://github.com/bitcoin/bitcoin/pull/17710
258 2019-12-10T11:16:24  *** bitcoin-git has left #bitcoin-core-dev
259 2019-12-10T11:17:15  *** promag has quit IRC
260 2019-12-10T11:19:46  *** jonatack has joined #bitcoin-core-dev
261 2019-12-10T11:22:51  *** belcher has joined #bitcoin-core-dev
262 2019-12-10T11:33:54  *** Laisha25Beier has joined #bitcoin-core-dev
263 2019-12-10T11:34:49  <aj> hmm, with taproot, should we consider bumping CScript from 28 bytes (which fits p2pkh(25B), p2sh(23B) and p2wpkh(22B)) to 36 bytes (which would also fit p2wsh(34B) and p2tr(34B))?
264 2019-12-10T11:36:03  *** promag has joined #bitcoin-core-dev
265 2019-12-10T11:37:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
266 2019-12-10T11:39:00  *** Laisha25Beier has quit IRC
267 2019-12-10T11:56:55  *** shaunsun has quit IRC
268 2019-12-10T11:56:55  *** shaunsun__ has quit IRC
269 2019-12-10T12:00:02  *** lunaphyte_ has quit IRC
270 2019-12-10T12:03:05  *** dviola has quit IRC
271 2019-12-10T12:06:14  *** thelounge2467250 has quit IRC
272 2019-12-10T12:07:00  *** thelounge2467250 has joined #bitcoin-core-dev
273 2019-12-10T12:17:13  *** andrea has joined #bitcoin-core-dev
274 2019-12-10T12:17:23  *** andrea is now known as Guest35230
275 2019-12-10T12:25:49  *** diogosergio has joined #bitcoin-core-dev
276 2019-12-10T12:27:14  *** Guyver2 has quit IRC
277 2019-12-10T12:36:00  *** promag has quit IRC
278 2019-12-10T12:39:36  *** tsujp has quit IRC
279 2019-12-10T12:41:48  *** promag has joined #bitcoin-core-dev
280 2019-12-10T12:57:18  *** promag has quit IRC
281 2019-12-10T13:17:44  *** promag has joined #bitcoin-core-dev
282 2019-12-10T13:18:20  *** mryandao has quit IRC
283 2019-12-10T13:21:57  *** promag has quit IRC
284 2019-12-10T13:44:19  *** mryandao has joined #bitcoin-core-dev
285 2019-12-10T13:59:07  *** bsm1175321 has joined #bitcoin-core-dev
286 2019-12-10T14:13:25  *** spinza has quit IRC
287 2019-12-10T14:18:06  *** jonatack has quit IRC
288 2019-12-10T14:20:07  *** andytoshi has joined #bitcoin-core-dev
289 2019-12-10T14:24:22  *** dr-orlovsky has quit IRC
290 2019-12-10T14:25:20  *** bitcoin-git has joined #bitcoin-core-dev
291 2019-12-10T14:25:20  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17704: depends: Set default depends fallback url to drahtbot.space (master...1912-dependsDrahtBot) https://github.com/bitcoin/bitcoin/pull/17704
292 2019-12-10T14:25:21  *** bitcoin-git has left #bitcoin-core-dev
293 2019-12-10T14:34:39  *** kabaum has quit IRC
294 2019-12-10T14:34:39  *** Kiminuo has quit IRC
295 2019-12-10T14:46:48  *** pinheadmz has joined #bitcoin-core-dev
296 2019-12-10T14:55:59  *** molly has joined #bitcoin-core-dev
297 2019-12-10T14:57:43  *** Guyver2 has joined #bitcoin-core-dev
298 2019-12-10T14:58:55  *** mol has quit IRC
299 2019-12-10T15:00:01  *** Guest35230 has quit IRC
300 2019-12-10T15:06:42  *** promag has joined #bitcoin-core-dev
301 2019-12-10T15:17:19  *** DuncanT1 has joined #bitcoin-core-dev
302 2019-12-10T15:19:17  *** justanotheruser has quit IRC
303 2019-12-10T15:31:29  *** nijynot has quit IRC
304 2019-12-10T15:33:54  *** instagibbs has quit IRC
305 2019-12-10T15:35:35  *** justanotheruser has joined #bitcoin-core-dev
306 2019-12-10T15:39:40  *** instagibbs has joined #bitcoin-core-dev
307 2019-12-10T15:43:17  *** justanotheruser has quit IRC
308 2019-12-10T16:01:42  *** mdunnio has joined #bitcoin-core-dev
309 2019-12-10T16:03:49  *** justanotheruser has joined #bitcoin-core-dev
310 2019-12-10T16:09:39  *** andrewtoth_ has joined #bitcoin-core-dev
311 2019-12-10T16:11:00  *** _andrewtoth_ has quit IRC
312 2019-12-10T16:16:45  *** jonatack has joined #bitcoin-core-dev
313 2019-12-10T16:17:04  *** andrewtoth_ has quit IRC
314 2019-12-10T16:19:40  *** promag has quit IRC
315 2019-12-10T16:34:58  *** nijynot has joined #bitcoin-core-dev
316 2019-12-10T16:49:36  *** vasild has quit IRC
317 2019-12-10T16:54:02  *** Talkless has joined #bitcoin-core-dev
318 2019-12-10T16:54:12  *** andrewtoth_ has joined #bitcoin-core-dev
319 2019-12-10T16:54:50  *** vasild has joined #bitcoin-core-dev
320 2019-12-10T16:58:46  *** ExtraCrispy has joined #bitcoin-core-dev
321 2019-12-10T17:00:04  *** Highway61 has quit IRC
322 2019-12-10T17:00:25  *** spinza has joined #bitcoin-core-dev
323 2019-12-10T17:03:35  *** Highway61 has joined #bitcoin-core-dev
324 2019-12-10T17:11:57  *** nijynot has quit IRC
325 2019-12-10T17:12:24  *** bitcoin-git has joined #bitcoin-core-dev
326 2019-12-10T17:12:24  <bitcoin-git> [bitcoin] instagibbs opened pull request #17712: sendmany/bumpfee: Avoid address reuse and partial spends as per walle… (master...avoid_reuse_sm_bf) https://github.com/bitcoin/bitcoin/pull/17712
327 2019-12-10T17:12:35  *** bitcoin-git has left #bitcoin-core-dev
328 2019-12-10T17:13:29  *** bitcoin-git has joined #bitcoin-core-dev
329 2019-12-10T17:13:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1189b6acab11...fae94785d99e
330 2019-12-10T17:13:31  <bitcoin-git> bitcoin/master 638e40c Andrew Chow: Have a PSBTAnalysis state that indicates invalid PSBT
331 2019-12-10T17:13:32  <bitcoin-git> bitcoin/master 773d457 Andrew Chow: Mark PSBTs spending unspendable outputs as invalid in analysis
332 2019-12-10T17:13:32  <bitcoin-git> bitcoin/master fae9478 MarcoFalke: Merge #17524: psbt: handle unspendable psbts
333 2019-12-10T17:13:38  *** bitcoin-git has left #bitcoin-core-dev
334 2019-12-10T17:14:00  *** bitcoin-git has joined #bitcoin-core-dev
335 2019-12-10T17:14:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17524: psbt: handle unspendable psbts (master...analyzepsbt-invalid) https://github.com/bitcoin/bitcoin/pull/17524
336 2019-12-10T17:14:10  *** bitcoin-git has left #bitcoin-core-dev
337 2019-12-10T17:23:39  *** promag has joined #bitcoin-core-dev
338 2019-12-10T17:26:54  *** promag has quit IRC
339 2019-12-10T17:34:44  *** diogosergio has quit IRC
340 2019-12-10T17:49:28  *** mryandao has quit IRC
341 2019-12-10T17:49:52  *** mryandao has joined #bitcoin-core-dev
342 2019-12-10T17:52:20  *** bitcoin-git has joined #bitcoin-core-dev
343 2019-12-10T17:52:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fae94785d99e...ea756bc48cd5
344 2019-12-10T17:52:21  <bitcoin-git> bitcoin/master 1bb5d51 Sebastian Falbesoner: test: add unit test for non-standard bare multisig txs
345 2019-12-10T17:52:22  <bitcoin-git> bitcoin/master ea756bc MarcoFalke: Merge #17502: test: add unit test for non-standard bare multisig txs
346 2019-12-10T17:52:24  *** bitcoin-git has left #bitcoin-core-dev
347 2019-12-10T17:52:40  *** bitcoin-git has joined #bitcoin-core-dev
348 2019-12-10T17:52:40  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17502: test: add unit test for non-standard bare multisig txs (master...20191118-test_check-for-non-standard-txs-bare-multisig) https://github.com/bitcoin/bitcoin/pull/17502
349 2019-12-10T17:52:41  *** bitcoin-git has left #bitcoin-core-dev
350 2019-12-10T17:59:11  *** Chris_Stewart_5 has quit IRC
351 2019-12-10T17:59:39  *** marcoagner has joined #bitcoin-core-dev
352 2019-12-10T18:00:01  *** DuncanT1 has quit IRC
353 2019-12-10T18:00:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
354 2019-12-10T18:01:48  *** b10c has quit IRC
355 2019-12-10T18:03:59  *** bitcoin-git has joined #bitcoin-core-dev
356 2019-12-10T18:03:59  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17713: doc: Add release notes for 17447 (master...1912-docRelNotes) https://github.com/bitcoin/bitcoin/pull/17713
357 2019-12-10T18:04:00  *** bitcoin-git has left #bitcoin-core-dev
358 2019-12-10T18:07:41  *** promag has joined #bitcoin-core-dev
359 2019-12-10T18:08:38  *** owowo has quit IRC
360 2019-12-10T18:10:14  *** bitcoin-git has joined #bitcoin-core-dev
361 2019-12-10T18:10:15  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea756bc48cd5...2126d6ce6977
362 2019-12-10T18:10:15  <bitcoin-git> bitcoin/master 5ad4dd1 Marius Kjærstad: doc: Changed MiniUPnPc link to https in dependencies.md
363 2019-12-10T18:10:16  <bitcoin-git> bitcoin/master 2126d6c MarcoFalke: Merge #17561: doc: Changed MiniUPnPc link to https in dependencies.md
364 2019-12-10T18:10:18  *** bitcoin-git has left #bitcoin-core-dev
365 2019-12-10T18:10:34  *** bitcoin-git has joined #bitcoin-core-dev
366 2019-12-10T18:10:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17561: doc: Changed MiniUPnPc link to https in dependencies.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17561
367 2019-12-10T18:10:45  *** bitcoin-git has left #bitcoin-core-dev
368 2019-12-10T18:12:11  *** promag has quit IRC
369 2019-12-10T18:13:44  *** owowo has joined #bitcoin-core-dev
370 2019-12-10T18:17:03  *** Pysis|work has joined #bitcoin-core-dev
371 2019-12-10T18:17:30  *** bitcoin-git has joined #bitcoin-core-dev
372 2019-12-10T18:17:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2126d6ce6977...d5674c5f0f7e
373 2019-12-10T18:17:31  <bitcoin-git> bitcoin/master 8ddcbb4 fanquake: build: Remove backticks from configure.ac
374 2019-12-10T18:17:32  <bitcoin-git> bitcoin/master 3ab1824 fanquake: build: Use dnl for all comments in configure.ac, rather than #
375 2019-12-10T18:17:32  <bitcoin-git> bitcoin/master d5674c5 MarcoFalke: Merge #17703: build: Improve configure.ac formatting
376 2019-12-10T18:17:34  *** bitcoin-git has left #bitcoin-core-dev
377 2019-12-10T18:17:50  *** bitcoin-git has joined #bitcoin-core-dev
378 2019-12-10T18:17:50  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17703: build: Improve configure.ac formatting (master...configure_ac_formatting) https://github.com/bitcoin/bitcoin/pull/17703
379 2019-12-10T18:17:52  *** bitcoin-git has left #bitcoin-core-dev
380 2019-12-10T18:22:59  *** Kiminuo has joined #bitcoin-core-dev
381 2019-12-10T18:27:25  *** promag has joined #bitcoin-core-dev
382 2019-12-10T18:31:50  *** bitcoin-git has joined #bitcoin-core-dev
383 2019-12-10T18:31:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5674c5f0f7e...3d6752779f05
384 2019-12-10T18:31:50  <bitcoin-git> bitcoin/master 5db506b practicalswift: tests: Add option --valgrind to run nodes under valgrind in the functional...
385 2019-12-10T18:31:51  <bitcoin-git> bitcoin/master 3d67527 MarcoFalke: Merge #17633: tests: Add option --valgrind to run the functional tests und...
386 2019-12-10T18:31:52  *** bitcoin-git has left #bitcoin-core-dev
387 2019-12-10T18:32:10  *** bitcoin-git has joined #bitcoin-core-dev
388 2019-12-10T18:32:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17633: tests: Add option --valgrind to run the functional tests under Valgrind (master...functional-valgrind) https://github.com/bitcoin/bitcoin/pull/17633
389 2019-12-10T18:32:11  *** bitcoin-git has left #bitcoin-core-dev
390 2019-12-10T18:40:42  *** Highway61 has quit IRC
391 2019-12-10T18:41:26  *** Zenton has quit IRC
392 2019-12-10T18:44:17  *** Chris_Stewart_5 has quit IRC
393 2019-12-10T18:46:21  *** jarthur has joined #bitcoin-core-dev
394 2019-12-10T18:47:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
395 2019-12-10T18:50:55  *** bitcoin-git has joined #bitcoin-core-dev
396 2019-12-10T18:50:55  <bitcoin-git> [bitcoin] jonatack opened pull request #17714: rpc: add missing newline in analyzepsbt RPCResult (master...pr-17524-follow-up) https://github.com/bitcoin/bitcoin/pull/17714
397 2019-12-10T18:50:56  *** bitcoin-git has left #bitcoin-core-dev
398 2019-12-10T18:58:42  *** millerti has joined #bitcoin-core-dev
399 2019-12-10T19:02:54  *** jarthur has quit IRC
400 2019-12-10T19:06:42  *** justanotheruser has quit IRC
401 2019-12-10T19:07:52  *** promag has quit IRC
402 2019-12-10T19:14:12  *** sanoj has quit IRC
403 2019-12-10T19:14:27  *** sanoj has joined #bitcoin-core-dev
404 2019-12-10T19:27:56  *** ExtraCrispy has quit IRC
405 2019-12-10T19:32:52  *** ppartyix has joined #bitcoin-core-dev
406 2019-12-10T19:33:12  *** ppartyix has quit IRC
407 2019-12-10T19:33:57  *** ppartyix has joined #bitcoin-core-dev
408 2019-12-10T19:34:17  *** soju has joined #bitcoin-core-dev
409 2019-12-10T19:35:57  *** Kiminuo has quit IRC
410 2019-12-10T19:37:54  *** justanotheruser has joined #bitcoin-core-dev
411 2019-12-10T19:43:09  *** AaronvanW has quit IRC
412 2019-12-10T19:58:16  *** vasild has quit IRC
413 2019-12-10T20:00:05  *** vasild has joined #bitcoin-core-dev
414 2019-12-10T20:00:43  *** promag has joined #bitcoin-core-dev
415 2019-12-10T20:06:41  *** Highway61 has joined #bitcoin-core-dev
416 2019-12-10T20:08:24  *** Talkless has quit IRC
417 2019-12-10T20:19:43  *** ppartyix has quit IRC
418 2019-12-10T20:20:03  *** Kiminuo has joined #bitcoin-core-dev
419 2019-12-10T20:25:39  *** sanket1729 has quit IRC
420 2019-12-10T20:26:21  *** AaronvanW has joined #bitcoin-core-dev
421 2019-12-10T20:29:58  *** sanket1729 has joined #bitcoin-core-dev
422 2019-12-10T20:30:37  *** AaronvanW has quit IRC
423 2019-12-10T20:32:13  *** EagleTM has joined #bitcoin-core-dev
424 2019-12-10T21:00:02  *** Pysis|work has quit IRC
425 2019-12-10T21:09:08  *** kabaum has joined #bitcoin-core-dev
426 2019-12-10T21:10:21  *** Zenton has joined #bitcoin-core-dev
427 2019-12-10T21:13:41  *** andytoshi has quit IRC
428 2019-12-10T21:17:19  *** BrunoNapoleao has joined #bitcoin-core-dev
429 2019-12-10T21:26:00  *** ddustin has joined #bitcoin-core-dev
430 2019-12-10T21:30:04  *** lowentropy has quit IRC
431 2019-12-10T21:30:18  *** lowentropy has joined #bitcoin-core-dev
432 2019-12-10T21:34:59  *** kabaum has quit IRC
433 2019-12-10T21:40:11  *** b10c has joined #bitcoin-core-dev
434 2019-12-10T21:40:57  *** ddustin has quit IRC
435 2019-12-10T21:41:24  *** vasild has quit IRC
436 2019-12-10T21:41:36  *** ddustin has joined #bitcoin-core-dev
437 2019-12-10T21:45:37  *** ddustin has quit IRC
438 2019-12-10T21:47:17  *** vasild has joined #bitcoin-core-dev
439 2019-12-10T21:56:39  *** Chris_Stewart_5 has quit IRC
440 2019-12-10T21:58:39  *** ddustin has joined #bitcoin-core-dev
441 2019-12-10T22:10:42  *** _andrewtoth_ has joined #bitcoin-core-dev
442 2019-12-10T22:12:12  *** andrewtoth_ has quit IRC
443 2019-12-10T22:13:49  *** soju has quit IRC
444 2019-12-10T22:22:09  *** Guyver2 has quit IRC
445 2019-12-10T22:27:10  *** dannmat has joined #bitcoin-core-dev
446 2019-12-10T22:27:57  *** AaronvanW has joined #bitcoin-core-dev
447 2019-12-10T22:29:33  *** timothy has quit IRC
448 2019-12-10T22:32:26  *** molz_ has joined #bitcoin-core-dev
449 2019-12-10T22:36:05  *** molly has quit IRC
450 2019-12-10T22:39:34  *** jeremyrubin has joined #bitcoin-core-dev
451 2019-12-10T22:40:38  *** dannmat has quit IRC
452 2019-12-10T22:40:40  *** morcos has quit IRC
453 2019-12-10T22:41:39  *** morcos has joined #bitcoin-core-dev
454 2019-12-10T22:46:37  *** brakmic has quit IRC
455 2019-12-10T22:47:58  *** luke-jr has quit IRC
456 2019-12-10T22:48:18  *** luke-jr has joined #bitcoin-core-dev
457 2019-12-10T22:49:32  *** Kiminuo has quit IRC
458 2019-12-10T23:01:40  *** AaronvanW has quit IRC
459 2019-12-10T23:03:30  *** luke-jr has quit IRC
460 2019-12-10T23:12:08  *** marcoagner has quit IRC
461 2019-12-10T23:13:45  *** ddustin has quit IRC
462 2019-12-10T23:14:23  *** ddustin has joined #bitcoin-core-dev
463 2019-12-10T23:14:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
464 2019-12-10T23:17:17  *** b10c has quit IRC
465 2019-12-10T23:18:38  *** ddustin has quit IRC
466 2019-12-10T23:23:51  *** EvaristeGalois has quit IRC
467 2019-12-10T23:44:06  *** luke-jr has joined #bitcoin-core-dev
468 2019-12-10T23:48:10  *** AaronvanW has joined #bitcoin-core-dev