12019-12-24T00:00:01 *** hali has quit IRC
22019-12-24T00:02:03 *** shesek has joined #bitcoin-core-dev
32019-12-24T00:02:03 *** shesek has quit IRC
42019-12-24T00:02:03 *** shesek has joined #bitcoin-core-dev
52019-12-24T00:14:09 *** ddustin has quit IRC
62019-12-24T00:15:15 *** kees1 has joined #bitcoin-core-dev
72019-12-24T00:16:17 *** ddustin has joined #bitcoin-core-dev
82019-12-24T00:37:25 *** AaronvanW has quit IRC
92019-12-24T00:55:36 *** bitcoin-git has joined #bitcoin-core-dev
102019-12-24T00:55:36 <bitcoin-git> [bitcoin] thomcari81 opened pull request #17798: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/17798
112019-12-24T00:55:37 *** bitcoin-git has left #bitcoin-core-dev
122019-12-24T01:01:34 *** bitcoin-git has joined #bitcoin-core-dev
132019-12-24T01:01:34 <bitcoin-git> [bitcoin] fanquake closed pull request #17798: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/17798
142019-12-24T01:01:48 *** bitcoin-git has left #bitcoin-core-dev
152019-12-24T01:09:57 *** AaronvanW has joined #bitcoin-core-dev
162019-12-24T01:14:26 *** AaronvanW has quit IRC
172019-12-24T01:15:17 *** captjakk has quit IRC
182019-12-24T01:52:58 *** ddustin has quit IRC
192019-12-24T01:57:32 *** zavan has quit IRC
202019-12-24T02:03:09 *** promag has joined #bitcoin-core-dev
212019-12-24T02:03:24 *** aqua42 has joined #bitcoin-core-dev
222019-12-24T02:06:08 *** marcoagner has quit IRC
232019-12-24T02:07:29 *** promag has quit IRC
242019-12-24T02:15:39 *** da2ce7_ has quit IRC
252019-12-24T02:18:02 *** da2ce7 has joined #bitcoin-core-dev
262019-12-24T02:32:02 *** da2ce7 has quit IRC
272019-12-24T02:33:10 *** andytoshi has quit IRC
282019-12-24T02:33:21 *** da2ce7 has joined #bitcoin-core-dev
292019-12-24T02:48:12 *** tsujp has joined #bitcoin-core-dev
302019-12-24T02:49:06 *** da2ce7 has quit IRC
312019-12-24T02:49:47 *** andytoshi has joined #bitcoin-core-dev
322019-12-24T02:51:29 *** da2ce7 has joined #bitcoin-core-dev
332019-12-24T02:57:45 *** bitcoin-git has joined #bitcoin-core-dev
342019-12-24T02:57:45 <bitcoin-git> [bitcoin] thomcari81 opened pull request #17799: Create 1 (master...master) https://github.com/bitcoin/bitcoin/pull/17799
352019-12-24T02:57:47 *** bitcoin-git has left #bitcoin-core-dev
362019-12-24T02:58:45 *** bitcoin-git has joined #bitcoin-core-dev
372019-12-24T02:58:45 <bitcoin-git> [bitcoin] fanquake closed pull request #17799: Create 1 (master...master) https://github.com/bitcoin/bitcoin/pull/17799
382019-12-24T02:58:47 *** bitcoin-git has left #bitcoin-core-dev
392019-12-24T03:00:02 *** kees1 has quit IRC
402019-12-24T03:06:45 *** justanotheruser has joined #bitcoin-core-dev
412019-12-24T03:11:54 *** AaronvanW has joined #bitcoin-core-dev
422019-12-24T03:12:45 *** blardo has joined #bitcoin-core-dev
432019-12-24T03:39:24 *** justanotheruser has quit IRC
442019-12-24T03:44:26 *** AaronvanW has quit IRC
452019-12-24T03:47:29 *** bitcoin-git has joined #bitcoin-core-dev
462019-12-24T03:47:29 <bitcoin-git> [bitcoin] fanquake opened pull request #17800: random: don't special case clock usage on macOS (master...random_macos_clocks) https://github.com/bitcoin/bitcoin/pull/17800
472019-12-24T03:47:30 *** bitcoin-git has left #bitcoin-core-dev
482019-12-24T03:51:05 *** felixfoertsch23 has joined #bitcoin-core-dev
492019-12-24T03:52:50 *** felixfoertsch has quit IRC
502019-12-24T04:19:58 *** justanotheruser has joined #bitcoin-core-dev
512019-12-24T04:30:39 *** ddustin has joined #bitcoin-core-dev
522019-12-24T04:41:27 *** AaronvanW has joined #bitcoin-core-dev
532019-12-24T04:43:06 *** turbo_choo has joined #bitcoin-core-dev
542019-12-24T04:43:12 *** Relis has quit IRC
552019-12-24T04:43:49 *** Relis has joined #bitcoin-core-dev
562019-12-24T04:48:29 *** turbo_choo has quit IRC
572019-12-24T04:52:48 *** turbo_choo has joined #bitcoin-core-dev
582019-12-24T05:14:56 *** AaronvanW has quit IRC
592019-12-24T06:00:02 *** blardo has quit IRC
602019-12-24T06:08:48 *** ddustin has quit IRC
612019-12-24T06:09:26 *** ddustin has joined #bitcoin-core-dev
622019-12-24T06:13:56 *** ddustin has quit IRC
632019-12-24T06:15:13 *** Jarsto1 has joined #bitcoin-core-dev
642019-12-24T06:31:43 *** sdaftuar_ has quit IRC
652019-12-24T06:33:35 *** sdaftuar_ has joined #bitcoin-core-dev
662019-12-24T06:38:49 *** paracyst_ has quit IRC
672019-12-24T06:39:11 *** paracyst has joined #bitcoin-core-dev
682019-12-24T06:48:48 *** ddustin has joined #bitcoin-core-dev
692019-12-24T06:55:38 *** turbo_choo has quit IRC
702019-12-24T07:11:49 *** ddustin has quit IRC
712019-12-24T07:12:17 *** AaronvanW has joined #bitcoin-core-dev
722019-12-24T07:12:26 *** ddustin has joined #bitcoin-core-dev
732019-12-24T07:22:02 *** ddustin has quit IRC
742019-12-24T07:27:21 *** Relis has quit IRC
752019-12-24T07:45:06 *** AaronvanW has quit IRC
762019-12-24T07:55:13 *** kristapsk has quit IRC
772019-12-24T07:55:21 *** ddustin has joined #bitcoin-core-dev
782019-12-24T08:28:34 *** Guyver2 has joined #bitcoin-core-dev
792019-12-24T08:50:20 *** SiAnDoG_ has quit IRC
802019-12-24T08:50:24 *** SiAnDoG__ has joined #bitcoin-core-dev
812019-12-24T08:57:37 *** kristapsk has joined #bitcoin-core-dev
822019-12-24T09:00:02 *** Jarsto1 has quit IRC
832019-12-24T09:13:08 *** andytoshi has quit IRC
842019-12-24T09:16:30 *** smtx has joined #bitcoin-core-dev
852019-12-24T09:19:50 *** emilengler has joined #bitcoin-core-dev
862019-12-24T09:20:18 *** tsujp has quit IRC
872019-12-24T09:42:06 *** AaronvanW has joined #bitcoin-core-dev
882019-12-24T09:49:15 *** kristapsk has quit IRC
892019-12-24T10:15:01 *** AaronvanW has quit IRC
902019-12-24T10:25:34 *** nobody12_ has joined #bitcoin-core-dev
912019-12-24T10:31:36 *** marcoagner has joined #bitcoin-core-dev
922019-12-24T10:32:54 *** promag has joined #bitcoin-core-dev
932019-12-24T10:50:01 *** emilengler_ has joined #bitcoin-core-dev
942019-12-24T10:50:36 *** emilengler has quit IRC
952019-12-24T10:53:05 *** AaronvanW has joined #bitcoin-core-dev
962019-12-24T10:55:00 *** jonatack has quit IRC
972019-12-24T10:59:49 *** promag has quit IRC
982019-12-24T11:05:16 *** EagleTM has joined #bitcoin-core-dev
992019-12-24T11:51:12 *** Relis has joined #bitcoin-core-dev
1002019-12-24T11:56:36 *** Relis has quit IRC
1012019-12-24T12:00:03 *** smtx has quit IRC
1022019-12-24T12:02:26 *** Vodyanoy has joined #bitcoin-core-dev
1032019-12-24T12:07:12 *** Relis has joined #bitcoin-core-dev
1042019-12-24T12:13:44 *** mYk1 has joined #bitcoin-core-dev
1052019-12-24T12:21:19 *** jonatack has joined #bitcoin-core-dev
1062019-12-24T12:35:31 *** zavan has joined #bitcoin-core-dev
1072019-12-24T12:42:48 *** Vodyanoy has quit IRC
1082019-12-24T13:00:27 *** promag has joined #bitcoin-core-dev
1092019-12-24T13:04:43 *** promag has quit IRC
1102019-12-24T13:05:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1112019-12-24T13:13:39 *** Highway61 has joined #bitcoin-core-dev
1122019-12-24T13:18:53 *** ossifrage has quit IRC
1132019-12-24T13:31:31 *** ossifrage has joined #bitcoin-core-dev
1142019-12-24T13:34:25 *** jonatack has quit IRC
1152019-12-24T13:37:30 *** jonatack has joined #bitcoin-core-dev
1162019-12-24T13:40:48 *** Relis has quit IRC
1172019-12-24T13:41:08 *** brakmic has joined #bitcoin-core-dev
1182019-12-24T13:45:32 *** molz_ has quit IRC
1192019-12-24T13:48:34 *** jonatack has quit IRC
1202019-12-24T13:50:28 *** mol has joined #bitcoin-core-dev
1212019-12-24T13:53:58 *** Skirmant has quit IRC
1222019-12-24T13:55:53 *** nobody12_ has quit IRC
1232019-12-24T14:01:25 *** Skirmant has joined #bitcoin-core-dev
1242019-12-24T14:08:30 *** Relis has joined #bitcoin-core-dev
1252019-12-24T14:27:30 *** jonatack has joined #bitcoin-core-dev
1262019-12-24T14:33:00 *** jnewbery_ is now known as jnewbery
1272019-12-24T14:40:52 *** molly has joined #bitcoin-core-dev
1282019-12-24T14:41:54 *** bitcoin-git has joined #bitcoin-core-dev
1292019-12-24T14:41:54 <bitcoin-git> [bitcoin] fanquake closed pull request #17055: [0.19] Backport of #15706 (0.19...check-qt-version-0.19) https://github.com/bitcoin/bitcoin/pull/17055
1302019-12-24T14:41:55 *** bitcoin-git has left #bitcoin-core-dev
1312019-12-24T14:42:35 *** mol has quit IRC
1322019-12-24T14:47:57 *** DeanWeen has joined #bitcoin-core-dev
1332019-12-24T14:48:04 *** Dean_Guss has quit IRC
1342019-12-24T14:48:59 *** molly has quit IRC
1352019-12-24T14:54:32 *** Chris_Stewart_5 has quit IRC
1362019-12-24T15:00:02 *** mYk1 has quit IRC
1372019-12-24T15:11:15 *** emilengler_ has quit IRC
1382019-12-24T15:11:27 *** emilengler has joined #bitcoin-core-dev
1392019-12-24T15:13:28 *** emilengler has quit IRC
1402019-12-24T15:14:22 *** emilengler has joined #bitcoin-core-dev
1412019-12-24T15:17:11 *** Clouclou has joined #bitcoin-core-dev
1422019-12-24T15:28:29 *** Jackielove4u has quit IRC
1432019-12-24T15:28:36 *** justanotheruser has quit IRC
1442019-12-24T15:38:04 *** Skirmant has quit IRC
1452019-12-24T15:39:38 *** Skirmant has joined #bitcoin-core-dev
1462019-12-24T15:39:47 *** ddustin has quit IRC
1472019-12-24T15:40:05 *** ddustin has joined #bitcoin-core-dev
1482019-12-24T15:50:53 *** Relis has quit IRC
1492019-12-24T15:58:23 *** justanotheruser has joined #bitcoin-core-dev
1502019-12-24T16:00:40 *** promag has joined #bitcoin-core-dev
1512019-12-24T16:01:55 *** brakmic_ has joined #bitcoin-core-dev
1522019-12-24T16:01:58 *** brakmic has quit IRC
1532019-12-24T16:05:21 *** promag has quit IRC
1542019-12-24T16:05:29 *** brakmic has joined #bitcoin-core-dev
1552019-12-24T16:08:28 *** brakmic_ has quit IRC
1562019-12-24T16:09:02 *** Relis has joined #bitcoin-core-dev
1572019-12-24T16:10:39 *** luke-jr has quit IRC
1582019-12-24T16:13:56 *** luke-jr has joined #bitcoin-core-dev
1592019-12-24T16:20:13 *** andytoshi has joined #bitcoin-core-dev
1602019-12-24T16:20:13 *** andytoshi has quit IRC
1612019-12-24T16:20:13 *** andytoshi has joined #bitcoin-core-dev
1622019-12-24T16:39:23 *** alko89 has joined #bitcoin-core-dev
1632019-12-24T16:51:53 *** sdaftuar_ has quit IRC
1642019-12-24T17:03:28 *** shesek has quit IRC
1652019-12-24T17:19:52 *** Jackielove4u has joined #bitcoin-core-dev
1662019-12-24T17:22:16 *** Alexys68Hagenes has joined #bitcoin-core-dev
1672019-12-24T17:49:23 *** brakmic has quit IRC
1682019-12-24T17:49:26 *** dviola has joined #bitcoin-core-dev
1692019-12-24T17:49:51 *** brakmic has joined #bitcoin-core-dev
1702019-12-24T17:50:58 *** captjakk has joined #bitcoin-core-dev
1712019-12-24T17:52:29 <gleb> Is there a way to trick functional tests to think that nodes are not connected locally? Like, so that addr is not 127.0.0.1
1722019-12-24T17:52:35 *** brakmic_ has joined #bitcoin-core-dev
1732019-12-24T17:55:40 *** brakmic has quit IRC
1742019-12-24T17:56:31 *** Alexys68Hagenes has quit IRC
1752019-12-24T17:57:12 <gwillen> gleb: I don't know if they're checking for 127.0.0.1 specifically, but you can use anything in 127.* and it will work as localhost
1762019-12-24T17:57:25 <gwillen> if that doesn't work, you can also use your own external IP, and see if it is able to catch that
1772019-12-24T17:58:48 <gleb> No, it's like *I need* the node to think that a connection between 2 regtest nodes is not local. So that they see each other as something from the internet
1782019-12-24T17:59:22 <gwillen> right, that's what I'm saying -- try giving it 127.0.0.2 to connect to, and see if it believes that's not local
1792019-12-24T17:59:37 <gwillen> or if your LAN IP is 192.168.1.99, try giving it that
1802019-12-24T17:59:57 <gwillen> it will still connect locally but the IP will be different
1812019-12-24T18:00:01 *** Clouclou has quit IRC
1822019-12-24T18:00:09 <gwillen> (but if it's connecting to itself automatically and you don't supply the IP, then I'm not sure)
1832019-12-24T18:16:55 *** ddustin has quit IRC
1842019-12-24T18:17:34 *** ddustin has joined #bitcoin-core-dev
1852019-12-24T18:22:28 *** ddustin has quit IRC
1862019-12-24T18:32:46 <gleb> gwillen: Thanks. I gave up and tested manually. If you have a bit more time, perhaps looking at the last comment in 16702 would let you know what I want to achieve better, cuz it's hard to explain without context. If not â no worries, at this point I feel like there is no good answer anyway =\
1872019-12-24T18:35:14 *** Relis has quit IRC
1882019-12-24T18:36:59 *** Relis has joined #bitcoin-core-dev
1892019-12-24T18:37:17 *** pinheadmz_ has joined #bitcoin-core-dev
1902019-12-24T18:40:41 *** pinheadmz has quit IRC
1912019-12-24T18:40:41 *** pinheadmz_ is now known as pinheadmz
1922019-12-24T18:44:17 *** jajm1 has joined #bitcoin-core-dev
1932019-12-24T18:49:08 *** brakmic_ has quit IRC
1942019-12-24T19:02:46 *** pinheadmz has quit IRC
1952019-12-24T19:05:31 *** DeanWeen has quit IRC
1962019-12-24T19:06:38 *** ddustin_ has joined #bitcoin-core-dev
1972019-12-24T19:07:21 *** pinheadmz has joined #bitcoin-core-dev
1982019-12-24T19:12:22 *** brakmic has joined #bitcoin-core-dev
1992019-12-24T19:15:03 *** brakmic_ has joined #bitcoin-core-dev
2002019-12-24T19:18:39 *** brakmic has quit IRC
2012019-12-24T19:26:06 <gwillen> gleb: I do see what you mean (and it turns out that none of my suggestions would work anyway, since all of the addresses I suggested will identify as "local")
2022019-12-24T19:26:26 <gwillen> or rather as !routable
2032019-12-24T19:30:28 <gwillen> I'm having a little trouble tracing the code you're describing because I can't find what the thing is that you're calling an asmap
2042019-12-24T19:30:42 <gwillen> I assume that's "AS map" but I couldn't turn anything up searching
2052019-12-24T19:31:38 <sipa> https://github.com/sipa/asmap ?
2062019-12-24T19:32:11 <gwillen> where is the codepath in core that deals in those?
2072019-12-24T19:32:15 <gwillen> (also thanks)
2082019-12-24T19:38:59 *** ossifrage has quit IRC
2092019-12-24T19:40:55 *** EagleTM has quit IRC
2102019-12-24T19:41:54 *** kristapsk has joined #bitcoin-core-dev
2112019-12-24T19:43:10 <sipa> gwillen: #16702
2122019-12-24T19:43:13 <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
2132019-12-24T19:51:33 *** lmpk has joined #bitcoin-core-dev
2142019-12-24T19:52:58 *** lmpk has quit IRC
2152019-12-24T19:57:11 *** dviola has quit IRC
2162019-12-24T20:01:22 *** promag has joined #bitcoin-core-dev
2172019-12-24T20:05:53 *** promag has quit IRC
2182019-12-24T21:00:01 *** jajm1 has quit IRC
2192019-12-24T21:04:26 *** captjakk has quit IRC
2202019-12-24T21:04:58 *** captjakk has joined #bitcoin-core-dev
2212019-12-24T21:09:55 *** captjakk has quit IRC
2222019-12-24T21:17:14 *** doomas has joined #bitcoin-core-dev
2232019-12-24T21:31:35 *** Relis has quit IRC
2242019-12-24T21:50:03 *** kristapsk has quit IRC
2252019-12-24T21:55:53 *** emilengler has quit IRC
2262019-12-24T21:57:18 *** alko89 has quit IRC
2272019-12-24T21:57:30 *** alko89 has joined #bitcoin-core-dev
2282019-12-24T21:59:25 *** Relis has joined #bitcoin-core-dev
2292019-12-24T22:00:53 *** captjakk has joined #bitcoin-core-dev
2302019-12-24T22:14:50 *** captjakk has quit IRC
2312019-12-24T22:39:20 *** captjakk has joined #bitcoin-core-dev
2322019-12-24T22:52:22 *** Guyver2 has quit IRC
2332019-12-24T22:53:07 <gwillen> oh, it was new in the PR, that's why I couldn't find it. XD thanks.
2342019-12-24T23:01:25 *** promag has joined #bitcoin-core-dev
2352019-12-24T23:05:38 *** promag has quit IRC
2362019-12-24T23:11:15 *** kinlo has quit IRC
2372019-12-24T23:12:59 *** brakmic has joined #bitcoin-core-dev
2382019-12-24T23:13:38 *** brakmic_ has quit IRC
2392019-12-24T23:13:52 *** brakmic_ has joined #bitcoin-core-dev
2402019-12-24T23:17:48 *** brakmic has quit IRC
2412019-12-24T23:21:53 *** Highway61 has quit IRC
2422019-12-24T23:38:41 <pinheadmz> gleb: is there any sense in "allowing" local connections in regtest mode only? you'd still have to shim in a ASN number for 127.0.0.1 ...
2432019-12-24T23:41:40 <gleb> pinheadmz: I'm not sure what you're asking. But it seems like you agree that testing this behaviour is too complicated that we probably can omit it.
2442019-12-24T23:44:52 <gwillen> pinheadmz: it seems like you'd have to shim multiple ones, to test meaningfully
2452019-12-24T23:45:02 <gwillen> but I guess you could do that with a fake asmap data file
2462019-12-24T23:45:26 <gwillen> in the code, you would just need to disable the check for local addresses for testing
2472019-12-24T23:45:51 <gwillen> and it does make _some_ sense to just remove all the nonroutable checks in regtest, potentially
2482019-12-24T23:55:11 <pinheadmz> yeah agreed, and the rpc output isnt the point of the PR anyway :-)