12020-01-02T00:00:02 *** SteveMcIntyre1 has quit IRC
22020-01-02T00:03:37 *** morcos has quit IRC
32020-01-02T00:03:55 *** morcos has joined #bitcoin-core-dev
42020-01-02T00:05:37 *** turbo_choo has quit IRC
52020-01-02T00:09:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
62020-01-02T00:17:30 *** fredcooke1 has joined #bitcoin-core-dev
72020-01-02T00:34:50 *** marcoagner has quit IRC
82020-01-02T00:40:02 *** Chris_Stewart_5 has quit IRC
92020-01-02T00:42:15 *** apex944 has joined #bitcoin-core-dev
102020-01-02T00:42:46 *** rh0nj has quit IRC
112020-01-02T00:43:08 *** rh0nj has joined #bitcoin-core-dev
122020-01-02T00:47:07 *** apex944 has quit IRC
132020-01-02T00:50:34 *** bitcoin-git has joined #bitcoin-core-dev
142020-01-02T00:50:34 <bitcoin-git> [bitcoin] fjahr opened pull request #17843: wallet: Reset reused transactions cache (master...getbalances) https://github.com/bitcoin/bitcoin/pull/17843
152020-01-02T00:50:35 *** bitcoin-git has left #bitcoin-core-dev
162020-01-02T01:13:01 *** AaronvanW has quit IRC
172020-01-02T01:14:55 *** Krellan_ has joined #bitcoin-core-dev
182020-01-02T01:16:26 *** turbo_choo has joined #bitcoin-core-dev
192020-01-02T01:53:32 *** turbo_choo has quit IRC
202020-01-02T01:53:54 *** turbo_choo has joined #bitcoin-core-dev
212020-01-02T02:00:48 *** Highway61 has quit IRC
222020-01-02T02:02:47 *** turbo_choo has quit IRC
232020-01-02T02:09:54 *** turbo_choo has joined #bitcoin-core-dev
242020-01-02T02:15:58 *** turbo_choo has quit IRC
252020-01-02T02:24:28 *** turbo_choo has joined #bitcoin-core-dev
262020-01-02T02:29:48 *** AaronvanW has joined #bitcoin-core-dev
272020-01-02T02:30:33 *** turbo_choo has quit IRC
282020-01-02T02:36:31 *** turbo_choo has joined #bitcoin-core-dev
292020-01-02T02:37:03 *** morcos has quit IRC
302020-01-02T02:41:37 *** morcos has joined #bitcoin-core-dev
312020-01-02T03:00:02 *** fredcooke1 has quit IRC
322020-01-02T03:00:45 *** abrissbirne has joined #bitcoin-core-dev
332020-01-02T03:04:12 *** abrissbi1ne has quit IRC
342020-01-02T03:04:20 *** AaronvanW has quit IRC
352020-01-02T03:17:23 *** phoenixlzx1 has joined #bitcoin-core-dev
362020-01-02T03:20:28 *** Yihen has joined #bitcoin-core-dev
372020-01-02T03:33:55 *** apex944 has joined #bitcoin-core-dev
382020-01-02T03:38:42 *** apex944 has quit IRC
392020-01-02T03:42:58 *** felixfoertsch23 has joined #bitcoin-core-dev
402020-01-02T03:43:14 *** Relis has quit IRC
412020-01-02T03:43:48 *** felixfoertsch has quit IRC
422020-01-02T03:53:16 *** promag has joined #bitcoin-core-dev
432020-01-02T03:57:37 *** promag has quit IRC
442020-01-02T04:05:51 *** Relis has joined #bitcoin-core-dev
452020-01-02T04:12:37 *** geeker has joined #bitcoin-core-dev
462020-01-02T04:12:52 *** justanotheruser has quit IRC
472020-01-02T04:14:42 *** zivl has quit IRC
482020-01-02T04:19:00 *** EagleTM has joined #bitcoin-core-dev
492020-01-02T04:19:25 *** Yihen has quit IRC
502020-01-02T04:21:23 *** Eagle[TM] has quit IRC
512020-01-02T04:31:31 *** AaronvanW has joined #bitcoin-core-dev
522020-01-02T05:01:52 *** Relis has quit IRC
532020-01-02T05:31:44 *** geeker has quit IRC
542020-01-02T05:32:26 *** geeker has joined #bitcoin-core-dev
552020-01-02T05:34:18 *** AaronvanW has quit IRC
562020-01-02T05:34:44 *** apex944 has joined #bitcoin-core-dev
572020-01-02T05:35:31 *** geeker has quit IRC
582020-01-02T05:37:08 *** geeker has joined #bitcoin-core-dev
592020-01-02T05:39:51 *** apex944 has quit IRC
602020-01-02T05:48:41 *** harrigan has quit IRC
612020-01-02T05:49:31 *** harrigan has joined #bitcoin-core-dev
622020-01-02T05:51:41 *** felixfoertsch23 has quit IRC
632020-01-02T05:51:53 *** felixfoertsch has joined #bitcoin-core-dev
642020-01-02T06:00:01 *** phoenixlzx1 has quit IRC
652020-01-02T06:17:10 *** davidfischer has joined #bitcoin-core-dev
662020-01-02T06:17:15 *** davidfischer is now known as Guest76156
672020-01-02T06:20:18 *** mol has joined #bitcoin-core-dev
682020-01-02T06:34:24 *** MrPaz has quit IRC
692020-01-02T06:50:49 *** cartshitaf has joined #bitcoin-core-dev
702020-01-02T07:11:43 *** apex944 has joined #bitcoin-core-dev
712020-01-02T07:13:25 *** geeker has quit IRC
722020-01-02T07:14:12 *** Kiminuo has joined #bitcoin-core-dev
732020-01-02T07:14:41 *** geeker has joined #bitcoin-core-dev
742020-01-02T07:16:40 *** apex944 has quit IRC
752020-01-02T07:31:16 *** AaronvanW has joined #bitcoin-core-dev
762020-01-02T07:31:28 *** geeker has quit IRC
772020-01-02T07:34:32 *** geeker has joined #bitcoin-core-dev
782020-01-02T07:46:38 *** Victor_sueca has quit IRC
792020-01-02T08:04:46 *** AaronvanW has quit IRC
802020-01-02T08:11:36 *** aqquadro has joined #bitcoin-core-dev
812020-01-02T08:11:47 *** aqquadro has joined #bitcoin-core-dev
822020-01-02T08:12:15 *** Victorsueca has joined #bitcoin-core-dev
832020-01-02T08:18:17 *** EagleTM has quit IRC
842020-01-02T08:20:52 *** Guyver2 has joined #bitcoin-core-dev
852020-01-02T08:37:19 *** mably has joined #bitcoin-core-dev
862020-01-02T09:00:02 *** Guest76156 has quit IRC
872020-01-02T09:03:31 *** aqquadro has quit IRC
882020-01-02T09:04:09 *** felixfoertsch has quit IRC
892020-01-02T09:04:26 *** felixfoertsch has joined #bitcoin-core-dev
902020-01-02T09:05:35 *** felixfoertsch has quit IRC
912020-01-02T09:07:37 *** felixfoertsch has joined #bitcoin-core-dev
922020-01-02T09:17:08 *** chrippa has joined #bitcoin-core-dev
932020-01-02T09:17:16 *** Guyver2 has quit IRC
942020-01-02T09:17:32 *** promag has joined #bitcoin-core-dev
952020-01-02T09:37:35 *** vasild has joined #bitcoin-core-dev
962020-01-02T09:38:23 *** PaulTroo_ has joined #bitcoin-core-dev
972020-01-02T09:39:05 *** PaulTroo_ is now known as PaulTroon_
982020-01-02T09:40:43 *** vasild_ has quit IRC
992020-01-02T09:42:09 *** promag has joined #bitcoin-core-dev
1002020-01-02T09:45:11 *** promag has quit IRC
1012020-01-02T09:48:09 *** marcoagner has joined #bitcoin-core-dev
1022020-01-02T09:48:22 *** chrippa has quit IRC
1032020-01-02T09:48:33 *** alec has joined #bitcoin-core-dev
1042020-01-02T09:49:40 *** geeker has quit IRC
1052020-01-02T09:51:01 *** Guest83 has joined #bitcoin-core-dev
1062020-01-02T09:51:32 *** apex944 has joined #bitcoin-core-dev
1072020-01-02T09:56:02 *** apex944 has quit IRC
1082020-01-02T09:58:04 *** felixfoertsch has quit IRC
1092020-01-02T10:03:23 *** felixfoertsch has joined #bitcoin-core-dev
1102020-01-02T10:13:39 *** justanotheruser has joined #bitcoin-core-dev
1112020-01-02T10:14:37 *** aowi has joined #bitcoin-core-dev
1122020-01-02T10:30:02 *** felixfoertsch has quit IRC
1132020-01-02T10:30:32 *** felixfoertsch has joined #bitcoin-core-dev
1142020-01-02T10:31:42 *** aqquadro has joined #bitcoin-core-dev
1152020-01-02T10:34:23 *** AaronvanW has joined #bitcoin-core-dev
1162020-01-02T10:38:43 *** alec has quit IRC
1172020-01-02T10:39:36 *** takinbo has quit IRC
1182020-01-02T10:40:43 *** AaronvanW has quit IRC
1192020-01-02T10:40:54 *** jonasschnelli has quit IRC
1202020-01-02T10:41:00 *** AaronvanW has joined #bitcoin-core-dev
1212020-01-02T10:41:43 *** morcos has quit IRC
1222020-01-02T10:41:43 *** lowentropy has quit IRC
1232020-01-02T10:41:43 *** sipa has quit IRC
1242020-01-02T10:42:04 *** afk11 has quit IRC
1252020-01-02T10:42:04 *** ghost43 has quit IRC
1262020-01-02T10:42:21 *** takinbo has joined #bitcoin-core-dev
1272020-01-02T10:42:21 *** takinbo has quit IRC
1282020-01-02T10:42:21 *** takinbo has joined #bitcoin-core-dev
1292020-01-02T10:42:43 *** vasild has quit IRC
1302020-01-02T10:44:11 *** jonasschnelli has joined #bitcoin-core-dev
1312020-01-02T10:45:33 *** jb55 has quit IRC
1322020-01-02T10:47:03 *** morcos has joined #bitcoin-core-dev
1332020-01-02T10:47:17 *** ghost43 has joined #bitcoin-core-dev
1342020-01-02T10:47:35 *** jb55 has joined #bitcoin-core-dev
1352020-01-02T10:48:31 *** mol has quit IRC
1362020-01-02T10:48:55 *** vasild has joined #bitcoin-core-dev
1372020-01-02T10:48:56 *** afk11 has joined #bitcoin-core-dev
1382020-01-02T10:48:56 *** lowentropy has joined #bitcoin-core-dev
1392020-01-02T10:48:57 *** sipa has joined #bitcoin-core-dev
1402020-01-02T10:49:02 *** mol has joined #bitcoin-core-dev
1412020-01-02T10:51:12 *** felixfoertsch has quit IRC
1422020-01-02T10:53:20 *** felixfoertsch has joined #bitcoin-core-dev
1432020-01-02T10:53:23 *** aqquadro has quit IRC
1442020-01-02T10:55:13 *** Guest83 has quit IRC
1452020-01-02T11:03:26 <wumpus> heh thanks CubicEarth
1462020-01-02T11:03:57 *** Hertha46Legros has joined #bitcoin-core-dev
1472020-01-02T11:05:47 *** mol has quit IRC
1482020-01-02T11:06:31 <wumpus> happy 2020 everyone
1492020-01-02T11:09:37 *** marcoagn1 has joined #bitcoin-core-dev
1502020-01-02T11:11:14 *** marcoagner has quit IRC
1512020-01-02T11:12:15 <fanquake> wumpus ð
1522020-01-02T11:12:28 <wumpus> lets do my first 'git pull' of the repository this decade
1532020-01-02T11:13:14 *** Hertha46Legros has quit IRC
1542020-01-02T11:15:07 <fanquake> Watch out for all the copyright headers ð
1552020-01-02T11:16:46 <wumpus> that causes make / ccache to forget everything resulting in a clean build for the new year!
1562020-01-02T11:20:24 <fanquake> heh. Looking forward to another decade of bitcoind!
1572020-01-02T11:20:45 *** SiAnDoG__ has joined #bitcoin-core-dev
1582020-01-02T11:21:33 <wumpus> yes!
1592020-01-02T11:21:59 *** trotski2000_ has joined #bitcoin-core-dev
1602020-01-02T11:22:20 <wumpus> what would be cool to merge as first PR?
1612020-01-02T11:23:41 <wumpus> #10785 would be nice
1622020-01-02T11:23:45 <gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
1632020-01-02T11:24:24 <fanquake> Right now I can probably only tell you what would not be cool to merge
1642020-01-02T11:24:39 <wumpus> very futuristic to have improved serialization for the new decade
1652020-01-02T11:24:47 <wumpus> hehe yes
1662020-01-02T11:25:23 *** felixfoertsch has quit IRC
1672020-01-02T11:26:35 <sipa> agree! ;)
1682020-01-02T11:27:45 <fanquake> I'll be very biased, an suggest that #17787 is just a tiny bit "cool"
1692020-01-02T11:27:47 <gribble> https://github.com/bitcoin/bitcoin/issues/17787 | scripts: add MACHO PIE check to security-check.py by fanquake · Pull Request #17787 · bitcoin/bitcoin · GitHub
1702020-01-02T11:28:23 <sipa> MACHO does sound very cool
1712020-01-02T11:28:36 *** aqquadro has joined #bitcoin-core-dev
1722020-01-02T11:29:22 *** felixfoertsch has joined #bitcoin-core-dev
1732020-01-02T11:30:01 <fanquake> Got some pie as well. Sounds like a good deal all round
1742020-01-02T11:31:17 <wumpus> MACHO PIE
1752020-01-02T11:32:14 <wumpus> it's good branding for security features
1762020-01-02T11:35:10 <fanquake> macOS has all the cool flags heh
1772020-01-02T11:35:12 <fanquake> NOUNDEFS DYLDLINK TWOLEVEL WEAK_DEFINES BINDS_TO_WEAK PIE
1782020-01-02T11:35:41 <wumpus> switching to macos this year because of the cool flags
1792020-01-02T11:36:27 *** Talkless has joined #bitcoin-core-dev
1802020-01-02T11:36:54 <wumpus> fanquake: any idea about the travis error in that PR? "import configparser" fails in the python tests, seems unrelated
1812020-01-02T11:37:03 <wumpus> but it is on macos
1822020-01-02T11:37:10 <fanquake> Just watch out, you might run out of harddrive space if you do that #17827
1832020-01-02T11:37:11 <gribble> https://github.com/bitcoin/bitcoin/issues/17827 | Blocks directory on macOS uses more disk space than expected · Issue #17827 · bitcoin/bitcoin · GitHub
1842020-01-02T11:37:56 <fanquake> wumpus From what I could see, brew tries to upgrade Python, but fails during the linking step, so I assumed it was related to that. I can have a proper look into it tonight given it's affecting everything.
1852020-01-02T11:41:34 <wumpus> oh I seee now it fails everywhere
1862020-01-02T11:44:00 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1872020-01-02T11:45:51 *** promag has joined #bitcoin-core-dev
1882020-01-02T11:49:26 *** Highway61 has joined #bitcoin-core-dev
1892020-01-02T11:49:42 *** bitcoin-git has joined #bitcoin-core-dev
1902020-01-02T11:49:43 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/35fff5be60e8...0655c7a94cc9
1912020-01-02T11:49:43 <bitcoin-git> bitcoin/master 4ca92dc fanquake: scripts: add MACHO PIE check to security-check.py
1922020-01-02T11:49:44 <bitcoin-git> bitcoin/master 7c9e821 fanquake: scripts: add MACHO NOUNDEFS check to security-check.py
1932020-01-02T11:49:44 <bitcoin-git> bitcoin/master 0655c7a Wladimir J. van der Laan: Merge #17787: scripts: add MACHO PIE check to security-check.py
1942020-01-02T11:49:46 *** bitcoin-git has left #bitcoin-core-dev
1952020-01-02T11:50:02 *** bitcoin-git has joined #bitcoin-core-dev
1962020-01-02T11:50:02 <bitcoin-git> [bitcoin] laanwj merged pull request #17787: scripts: add MACHO PIE check to security-check.py (master...add_macOS_to_security_check) https://github.com/bitcoin/bitcoin/pull/17787
1972020-01-02T11:50:03 *** bitcoin-git has left #bitcoin-core-dev
1982020-01-02T11:50:16 *** promag has quit IRC
1992020-01-02T11:50:18 *** Evel-Knievel has quit IRC
2002020-01-02T12:00:01 *** aowi has quit IRC
2012020-01-02T12:03:23 *** promag has joined #bitcoin-core-dev
2022020-01-02T12:04:58 *** promag has quit IRC
2032020-01-02T12:17:51 *** kir has joined #bitcoin-core-dev
2042020-01-02T12:18:49 *** felixfoertsch has quit IRC
2052020-01-02T12:20:48 *** bitcoin-git has joined #bitcoin-core-dev
2062020-01-02T12:20:48 <bitcoin-git> [bitcoin] emilengler closed pull request #17842: util: Check for curl in Posix PATH (master...2020-01-check-curl-path) https://github.com/bitcoin/bitcoin/pull/17842
2072020-01-02T12:20:49 *** bitcoin-git has left #bitcoin-core-dev
2082020-01-02T12:22:06 *** promag has joined #bitcoin-core-dev
2092020-01-02T12:22:38 *** felixfoertsch has joined #bitcoin-core-dev
2102020-01-02T12:22:57 *** Chris_Stewart_5 has quit IRC
2112020-01-02T12:25:18 *** zivl has joined #bitcoin-core-dev
2122020-01-02T12:28:34 *** SiAnDoG__ has quit IRC
2132020-01-02T12:28:57 *** SiAnDoG__ has joined #bitcoin-core-dev
2142020-01-02T12:30:27 *** apex944 has joined #bitcoin-core-dev
2152020-01-02T12:39:57 *** alec has joined #bitcoin-core-dev
2162020-01-02T12:40:50 *** turbo_choo has quit IRC
2172020-01-02T12:52:11 *** PaulTroon_ has quit IRC
2182020-01-02T12:52:50 *** PaulTroo_ has joined #bitcoin-core-dev
2192020-01-02T12:53:06 *** PaulTroo_ is now known as PaulTroon_
2202020-01-02T12:54:16 *** PaulTroon_ has quit IRC
2212020-01-02T12:54:54 *** PaulTroo_ has joined #bitcoin-core-dev
2222020-01-02T12:56:20 <elichai2> how do people feel about some re-organizing includes such that we "include only what we use"? (hopefully it will make compilation faster and make it more obvious what parts are still highly connected)
2232020-01-02T12:56:43 *** PaulTroo_ has joined #bitcoin-core-dev
2242020-01-02T12:57:39 *** promag has joined #bitcoin-core-dev
2252020-01-02T12:57:43 *** PaulTroo_ is now known as PaulTroon_
2262020-01-02T12:58:22 *** PaulTroon_ is now known as paultroon_
2272020-01-02T12:59:11 *** paultroon_ is now known as PaulTroon_
2282020-01-02T12:59:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2292020-01-02T13:00:10 <fanquake> Related #15442
2302020-01-02T13:00:11 <gribble> https://github.com/bitcoin/bitcoin/issues/15442 | Running iwyu on Bitcoin Core · Issue #15442 · bitcoin/bitcoin · GitHub
2312020-01-02T13:01:18 <elichai2> ha thanks :) well IWYU itself has a problem with boost. boost isn't built with the IWYU idea in mind
2322020-01-02T13:03:37 *** PaulTroon_ is now known as paultroon_
2332020-01-02T13:05:13 *** Talkless has quit IRC
2342020-01-02T13:05:27 *** paultroon_ is now known as paultroon
2352020-01-02T13:08:05 *** promag has quit IRC
2362020-01-02T13:10:33 *** Talkless has joined #bitcoin-core-dev
2372020-01-02T13:14:56 *** SiAnDoG__ has quit IRC
2382020-01-02T13:16:05 *** vincenzopalazzo has joined #bitcoin-core-dev
2392020-01-02T13:18:13 *** felixfoertsch has quit IRC
2402020-01-02T13:18:25 <elichai2> I assume we still want the `fs.h` separation even though it can increase compile time? (a lot of units only need the path.hpp and not the whole fs)
2412020-01-02T13:20:35 *** felixfoertsch has joined #bitcoin-core-dev
2422020-01-02T13:22:24 *** MrPaz has joined #bitcoin-core-dev
2432020-01-02T13:22:58 *** turbo_choo has joined #bitcoin-core-dev
2442020-01-02T13:33:48 *** vincentpalazzo has joined #bitcoin-core-dev
2452020-01-02T13:34:15 *** apex944 has quit IRC
2462020-01-02T13:36:32 *** vincenzopalazzo has quit IRC
2472020-01-02T13:38:01 *** Evel-Knievel has joined #bitcoin-core-dev
2482020-01-02T13:51:03 *** promag has joined #bitcoin-core-dev
2492020-01-02T14:02:09 *** Relis has joined #bitcoin-core-dev
2502020-01-02T14:02:49 *** molly has joined #bitcoin-core-dev
2512020-01-02T14:07:17 *** Relis has quit IRC
2522020-01-02T14:07:33 *** apex944 has joined #bitcoin-core-dev
2532020-01-02T14:09:49 *** ddustin has joined #bitcoin-core-dev
2542020-01-02T14:10:24 *** alec has quit IRC
2552020-01-02T14:10:37 *** alec has joined #bitcoin-core-dev
2562020-01-02T14:12:18 *** apex944 has quit IRC
2572020-01-02T14:13:09 *** Relis has joined #bitcoin-core-dev
2582020-01-02T14:14:18 *** Guest83 has joined #bitcoin-core-dev
2592020-01-02T14:33:14 *** brianhoffman has quit IRC
2602020-01-02T14:35:32 *** brianhoffman has joined #bitcoin-core-dev
2612020-01-02T14:36:24 *** setpill has joined #bitcoin-core-dev
2622020-01-02T14:39:28 *** goatpig has joined #bitcoin-core-dev
2632020-01-02T14:39:57 *** Relis has quit IRC
2642020-01-02T14:44:43 *** MrPaz has quit IRC
2652020-01-02T14:45:34 *** MrPaz has joined #bitcoin-core-dev
2662020-01-02T14:45:37 *** Guest83 has quit IRC
2672020-01-02T14:46:50 *** molly has quit IRC
2682020-01-02T14:48:18 *** Guest83 has joined #bitcoin-core-dev
2692020-01-02T14:50:20 *** mol has joined #bitcoin-core-dev
2702020-01-02T14:50:22 *** emilengler has quit IRC
2712020-01-02T15:00:01 *** kir has quit IRC
2722020-01-02T15:00:12 *** aqquadro has quit IRC
2732020-01-02T15:06:02 <Chris_Stewart_5> Is there a document anywhere on bitcoin core's key handling and storage procedures? Or is this a "read the code" situation?
2742020-01-02T15:06:59 <sipa> i don't think it's documented anywhere
2752020-01-02T15:09:32 *** aqquadro has joined #bitcoin-core-dev
2762020-01-02T15:09:32 *** aqquadro has joined #bitcoin-core-dev
2772020-01-02T15:11:59 <MarcoFalke> Is there a meeting today?
2782020-01-02T15:13:54 *** Relis has joined #bitcoin-core-dev
2792020-01-02T15:17:35 *** gorthx has joined #bitcoin-core-dev
2802020-01-02T15:20:22 *** goatpig_ has joined #bitcoin-core-dev
2812020-01-02T15:20:53 *** AaronvanW has quit IRC
2822020-01-02T15:22:16 *** setpill has quit IRC
2832020-01-02T15:22:44 *** goatpig has quit IRC
2842020-01-02T15:31:04 *** setpill has joined #bitcoin-core-dev
2852020-01-02T15:34:31 *** aqquadro has quit IRC
2862020-01-02T15:45:08 *** AaronvanW has joined #bitcoin-core-dev
2872020-01-02T15:48:56 *** apex944 has joined #bitcoin-core-dev
2882020-01-02T15:50:54 *** paultroon has quit IRC
2892020-01-02T15:52:20 *** jonatack has joined #bitcoin-core-dev
2902020-01-02T15:53:14 *** apex944 has quit IRC
2912020-01-02T15:54:36 *** mdunnio has joined #bitcoin-core-dev
2922020-01-02T16:04:33 *** enasigurd has joined #bitcoin-core-dev
2932020-01-02T16:10:57 *** bitcoin-git has joined #bitcoin-core-dev
2942020-01-02T16:10:58 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0655c7a94cc9...3f8dbcd65547
2952020-01-02T16:10:59 <bitcoin-git> bitcoin/master 6f6465c John Newbery: scripted-diff: [validation] Rename CheckInputs to CheckInputScripts
2962020-01-02T16:11:00 <bitcoin-git> bitcoin/master 3bd8db8 John Newbery: [validation] fix comments in CheckInputScripts()
2972020-01-02T16:11:00 <bitcoin-git> bitcoin/master 3f8dbcd MarcoFalke: Merge #16658: validation: Rename CheckInputs to CheckInputScripts
2982020-01-02T16:11:02 *** bitcoin-git has left #bitcoin-core-dev
2992020-01-02T16:11:40 *** bitcoin-git has joined #bitcoin-core-dev
3002020-01-02T16:11:40 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16658: validation: Rename CheckInputs to CheckInputScripts (master...2019-08-rename-CheckInputs) https://github.com/bitcoin/bitcoin/pull/16658
3012020-01-02T16:11:41 *** bitcoin-git has left #bitcoin-core-dev
3022020-01-02T16:11:48 *** paultroon has joined #bitcoin-core-dev
3032020-01-02T16:12:24 <wumpus> elichai2: yes, please keep fs.h
3042020-01-02T16:13:13 <wumpus> after filesystem lands in c++ itself and we can use that, we can discuss splitting it up (depending on how the standard library does it), but before that this is supposed to abstract out that particular boost usage
3052020-01-02T16:14:02 <elichai2> makes sense
3062020-01-02T16:15:31 <wumpus> (also, having the fs functions in one header is useful for sandboxing platforms that don't have direct file access)
3072020-01-02T16:15:47 <wumpus> MarcoFalke: I'm okay with doing a meeting today
3082020-01-02T16:16:34 *** paultroon has quit IRC
3092020-01-02T16:16:45 <elichai2> MarcoFalke: how do you feel about the `for XXXX` comments IWYU leaves?
3102020-01-02T16:17:17 <MarcoFalke> elichai2: spammy unless a header is used for 3 things or less
3112020-01-02T16:17:39 <elichai2> and easily gets out of date
3122020-01-02T16:17:58 <MarcoFalke> Jup
3132020-01-02T16:18:04 *** aqquadro has joined #bitcoin-core-dev
3142020-01-02T16:18:04 *** aqquadro has joined #bitcoin-core-dev
3152020-01-02T16:18:21 <MarcoFalke> I guess most useful would be documentation on how to run it on a single file (e.g. a freshly created file)
3162020-01-02T16:19:30 <elichai2> that's the easiest actually. but still requires fixing the problems it makes
3172020-01-02T16:19:57 <elichai2> I want to make a PR showing how the changes look, altough this is something that isn't reviewable easily
3182020-01-02T16:21:44 <elichai2> where should I document how to use this?
3192020-01-02T16:33:09 *** morcos has quit IRC
3202020-01-02T16:33:28 *** morcos has joined #bitcoin-core-dev
3212020-01-02T16:36:08 *** setpill has quit IRC
3222020-01-02T16:42:57 <MarcoFalke> Maybe in my issue or in our developer docs
3232020-01-02T16:46:51 <MarcoFalke> #proposedmeetingtopic Vanilla debian Bitcoin Core package, #17343
3242020-01-02T16:46:53 <gribble> https://github.com/bitcoin/bitcoin/issues/17343 | Meta: Packaging Bitcoin Core as vanilla system package · Issue #17343 · bitcoin/bitcoin · GitHub
3252020-01-02T16:49:34 *** Highway62 has joined #bitcoin-core-dev
3262020-01-02T16:50:23 *** Highway61 has quit IRC
3272020-01-02T16:50:24 *** Highway62 is now known as Highway61
3282020-01-02T16:53:37 *** Highway61 has quit IRC
3292020-01-02T16:56:05 *** Relis has quit IRC
3302020-01-02T17:00:52 *** Highway61 has joined #bitcoin-core-dev
3312020-01-02T17:01:03 *** AaronvanW has quit IRC
3322020-01-02T17:01:45 *** Talkless has quit IRC
3332020-01-02T17:05:15 *** Relis has joined #bitcoin-core-dev
3342020-01-02T17:05:33 <sipsorcery> wumpus: In case you didn't already spot it the GitHub Action job is being triggered on every repo action (issue comments etc).
3352020-01-02T17:06:19 <elichai2> since when github actions working in core? :O
3362020-01-02T17:06:26 *** sturles has quit IRC
3372020-01-02T17:07:59 <sipsorcery> elichai2: https://github.com/bitcoin/bitcoin/issues/17803
3382020-01-02T17:09:28 *** sturles has joined #bitcoin-core-dev
3392020-01-02T17:09:28 *** sturles has joined #bitcoin-core-dev
3402020-01-02T17:11:24 <sipsorcery> not sure why issue comments are triggering the job... the "on: push:" should restrict triggering to commits
3412020-01-02T17:11:30 <sipsorcery> will try and replicate
3422020-01-02T17:13:30 <promag> #16963 review/merge ?
3432020-01-02T17:13:32 <gribble> https://github.com/bitcoin/bitcoin/issues/16963 | wallet: Fix unique_ptr usage in boost::signals2 by promag · Pull Request #16963 · bitcoin/bitcoin · GitHub
3442020-01-02T17:22:36 *** promag has quit IRC
3452020-01-02T17:36:25 *** Chris_Stewart_5 has quit IRC
3462020-01-02T17:39:34 *** bitcoin-git has joined #bitcoin-core-dev
3472020-01-02T17:39:35 <bitcoin-git> [bitcoin] hebasto opened pull request #17849: ci: Fix brew python link (master...20200102-travis-brew-python) https://github.com/bitcoin/bitcoin/pull/17849
3482020-01-02T17:39:47 *** bitcoin-git has left #bitcoin-core-dev
3492020-01-02T17:41:20 *** ddustin has quit IRC
3502020-01-02T17:41:58 *** ddustin has joined #bitcoin-core-dev
3512020-01-02T17:42:29 *** AaronvanW has joined #bitcoin-core-dev
3522020-01-02T17:43:31 *** Guest83 has quit IRC
3532020-01-02T17:45:17 *** DougieBot5000_ has joined #bitcoin-core-dev
3542020-01-02T17:45:33 *** DougieBot5000 has quit IRC
3552020-01-02T17:46:28 *** ddustin has quit IRC
3562020-01-02T17:49:49 *** apex944 has joined #bitcoin-core-dev
3572020-01-02T17:54:20 *** DougieBot5000_ is now known as DougieBot5000
3582020-01-02T17:54:55 *** apex944 has quit IRC
3592020-01-02T17:57:29 *** dviola has joined #bitcoin-core-dev
3602020-01-02T18:00:01 *** gorthx has quit IRC
3612020-01-02T18:04:13 *** cryptapus has quit IRC
3622020-01-02T18:04:23 *** paultroon has joined #bitcoin-core-dev
3632020-01-02T18:13:15 *** gnusha has quit IRC
3642020-01-02T18:13:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3652020-01-02T18:17:14 *** drewx2 has joined #bitcoin-core-dev
3662020-01-02T18:22:55 <hebasto> it seems travis is happy with #17849
3672020-01-02T18:22:56 <gribble> https://github.com/bitcoin/bitcoin/issues/17849 | ci: Fix brew python link by hebasto · Pull Request #17849 · bitcoin/bitcoin · GitHub
3682020-01-02T18:25:52 *** aqquadro has quit IRC
3692020-01-02T18:28:57 *** mably has quit IRC
3702020-01-02T18:28:58 <wumpus> sipsorcery: should I disable it again?
3712020-01-02T18:35:39 *** Talkless has joined #bitcoin-core-dev
3722020-01-02T18:45:54 *** davterra has joined #bitcoin-core-dev
3732020-01-02T18:50:14 <sipsorcery> wumpus: yes, it's going to fail on every run at the moment, reason at end of #17803.
3742020-01-02T18:50:15 <gribble> https://github.com/bitcoin/bitcoin/issues/17803 | ci: Migration from AppVeyor to GitHub Actions · Issue #17803 · bitcoin/bitcoin · GitHub
3752020-01-02T18:51:31 *** aqquadro has joined #bitcoin-core-dev
3762020-01-02T18:51:45 <jonatack> sipsorcery: wumpus: yes, every review comment seems to be firing off a GH Actions email with a title like "[bitcoin/bitcoin] Run failed:"
3772020-01-02T18:53:19 *** bitcoin-git has joined #bitcoin-core-dev
3782020-01-02T18:53:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f8dbcd65547...52900a764c42
3792020-01-02T18:53:20 <bitcoin-git> bitcoin/master 87744b1 Hennadii Stepanov: ci: Fix brew python link
3802020-01-02T18:53:21 <bitcoin-git> bitcoin/master 52900a7 MarcoFalke: Merge #17849: ci: Fix brew python link
3812020-01-02T18:53:32 *** bitcoin-git has left #bitcoin-core-dev
3822020-01-02T18:53:49 *** bitcoin-git has joined #bitcoin-core-dev
3832020-01-02T18:53:50 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17849: ci: Fix brew python link (master...20200102-travis-brew-python) https://github.com/bitcoin/bitcoin/pull/17849
3842020-01-02T18:53:50 *** bitcoin-git has left #bitcoin-core-dev
3852020-01-02T18:55:42 <sipa> wumpus: what's the status on #17398 ?
3862020-01-02T18:55:44 <gribble> https://github.com/bitcoin/bitcoin/issues/17398 | build: Update leveldb to 1.22+ by laanwj · Pull Request #17398 · bitcoin/bitcoin · GitHub
3872020-01-02T18:57:02 *** Highway61 has quit IRC
3882020-01-02T18:57:55 *** bitcoin-git has joined #bitcoin-core-dev
3892020-01-02T18:57:55 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
3902020-01-02T18:57:56 *** bitcoin-git has left #bitcoin-core-dev
3912020-01-02T18:58:10 *** bitcoin-git has joined #bitcoin-core-dev
3922020-01-02T18:58:10 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
3932020-01-02T18:58:12 *** bitcoin-git has left #bitcoin-core-dev
3942020-01-02T18:59:51 <wumpus> actions have been disabled again for now
3952020-01-02T19:00:26 <wumpus> sipa: I think it's ready just needs review/testing
3962020-01-02T19:00:39 <wumpus> #startmeeting
3972020-01-02T19:00:39 <lightningbot> Meeting started Thu Jan 2 19:00:39 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3982020-01-02T19:00:39 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3992020-01-02T19:00:51 *** gnusha has joined #bitcoin-core-dev
4002020-01-02T19:01:01 <hebasto> hi
4012020-01-02T19:01:04 <sipsorcery> hi
4022020-01-02T19:01:08 <jonatack> hi
4032020-01-02T19:01:15 <achow101> HI
4042020-01-02T19:01:24 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
4052020-01-02T19:01:26 <wumpus> jeremyrubin lightlike emilengler jonatack
4062020-01-02T19:01:33 <amiti> hi
4072020-01-02T19:01:36 <MarcoFalke> hi
4082020-01-02T19:01:39 <kanzure> hi
4092020-01-02T19:01:41 <moneyball> happy new year everyone
4102020-01-02T19:02:09 *** promag has joined #bitcoin-core-dev
4112020-01-02T19:02:16 <promag> hi
4122020-01-02T19:02:20 <MarcoFalke> travis macOS is fixed thanks to hebasto. I just reset all travis runs. Let me know if I missed one
4132020-01-02T19:02:22 <wumpus> yes, happy new year everyone
4142020-01-02T19:02:38 <wumpus> thanks hebasto
4152020-01-02T19:02:49 <hebasto> nm
4162020-01-02T19:03:35 <sipa> hi
4172020-01-02T19:03:38 <wumpus> one proposed topic this week by MarcoFalke : Vanilla debian Bitcoin Core package, #17343
4182020-01-02T19:03:40 <gribble> https://github.com/bitcoin/bitcoin/issues/17343 | Meta: Packaging Bitcoin Core as vanilla system package · Issue #17343 · bitcoin/bitcoin · GitHub
4192020-01-02T19:03:59 <wumpus> anything else to discuss?
4202020-01-02T19:04:15 <luke-jr> HNY
4212020-01-02T19:04:47 <wumpus> #topic High priroity for review
4222020-01-02T19:04:48 *** bitcoin-git has joined #bitcoin-core-dev
4232020-01-02T19:04:48 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
4242020-01-02T19:04:49 *** bitcoin-git has left #bitcoin-core-dev
4252020-01-02T19:04:49 <sipa> From Wikipedia, the free encyclopedia. HNY may refer to: Happy New Year (2014 film) Hengyang Nanyue Airport, IATA code HNY.
4262020-01-02T19:05:04 <gleb> Hi
4272020-01-02T19:05:08 *** bitcoin-git has joined #bitcoin-core-dev
4282020-01-02T19:05:08 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17669: tests: have coins simulation test also use CCoinsViewDB (master...2019-12-coins-tests) https://github.com/bitcoin/bitcoin/pull/17669
4292020-01-02T19:05:09 *** bitcoin-git has left #bitcoin-core-dev
4302020-01-02T19:05:13 <wumpus> 10 blockers (!), 7 chasing concept ACK https://github.com/bitcoin/bitcoin/projects/8
4312020-01-02T19:05:15 <luke-jr> sipa: it has to be a film? O.o
4322020-01-02T19:05:20 <wumpus> better get to reviewing :)
4332020-01-02T19:05:56 <sipa> new year's resolution: review more PRs (and also, 1080p)
4342020-01-02T19:06:36 <wumpus> would be nice to get #10785 in soon, it's about time, it's from 2017
4352020-01-02T19:06:39 <gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub
4362020-01-02T19:06:58 <wumpus> I definitely wouldn't have the patience to keep rebasing a PR for that long
4372020-01-02T19:07:00 <MarcoFalke> sipa, review in 1080 pixel instead of 360 pixel?
4382020-01-02T19:07:11 <sipa> wumpus: making a minimal initial PR with just 2 commits
4392020-01-02T19:07:31 <jonatack> i think kallewoof wanted to move #16411 from chasing concept acks over to high-priority
4402020-01-02T19:07:33 <gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
4412020-01-02T19:07:36 <wumpus> sipa: oh, it grew over time
4422020-01-02T19:07:40 *** Chris_Stewart_5 has quit IRC
4432020-01-02T19:07:48 <wumpus> jonatack: ok
4442020-01-02T19:08:08 <sipa> wumpus: not really, and the recent protobuf purging simplified it a bit, actually
4452020-01-02T19:08:19 <sipa> but still, it seems there is little appetite to review the whole thing at once
4462020-01-02T19:08:55 <sipa> in any case, concept ack on moving #16411 from chasing concept ack to blocker
4472020-01-02T19:08:58 <gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
4482020-01-02T19:09:02 <wumpus> well tons of people reviewed it
4492020-01-02T19:09:23 <wumpus> looking at number of comments at least
4502020-01-02T19:09:42 <sipa> many ryanofsky reviews mostly, iirc :)
4512020-01-02T19:10:03 <wumpus> ah couldn't really see due to github comment hiding gymnastics
4522020-01-02T19:10:34 <luke-jr> XD
4532020-01-02T19:10:57 <wumpus> #topic Vanilla debian Bitcoin Core package (MarcoFalke)
4542020-01-02T19:10:58 <sipa> must be heavy on their poor Ruby infrastructure
4552020-01-02T19:12:08 <sipa> MarcoFalke: ^
4562020-01-02T19:12:08 <MarcoFalke> So packaging is still an unsolved problem for Linux distros. We stopped maintaining the Ubuntu PPA due to numerous problems and provided flatpak and snapcraft packages.
4572020-01-02T19:12:27 <wumpus> oh, the ppa is no longer maintained?
4582020-01-02T19:12:28 <MarcoFalke> Though, that uncovered other issues
4592020-01-02T19:12:28 <luke-jr> MarcoFalke: Matt stopped maintaining the PPA. I didn't.
4602020-01-02T19:12:39 <luke-jr> wumpus: the bitcoin/bitcoin one Matt used to have is unmaintained now
4612020-01-02T19:13:00 <MarcoFalke> luke-jr: There are still issues with the ppa, even if maintained.
4622020-01-02T19:13:01 *** spaced0ut has quit IRC
4632020-01-02T19:13:26 <wumpus> yes, if it was just a matter of maintenance we could try to find someone else to do it
4642020-01-02T19:13:26 <achow101> what are the issues?
4652020-01-02T19:13:36 <luke-jr> IMO flatpak/snapcraft aren't comparable, but go on
4662020-01-02T19:13:49 <luke-jr> (FWIW, my PPA is at https://launchpad.net/~luke-jr/+archive/ubuntu/bitcoincore )
4672020-01-02T19:14:38 <wumpus> yes, what are ths issues?
4682020-01-02T19:14:39 <MarcoFalke> achow101: On the top of my head: * not reproducible builds, no way to verify what happened on the build servers. * People installing the ubuntu ppa on non-ubuntu distros (https://wiki.debian.org/DontBreakDebian )
4692020-01-02T19:14:42 <wumpus> except non-determinism
4702020-01-02T19:14:46 *** promag has quit IRC
4712020-01-02T19:14:53 <wumpus> yes I mean non-reproducible
4722020-01-02T19:15:05 <jamesob> hi
4732020-01-02T19:15:07 *** bitcoin-git has joined #bitcoin-core-dev
4742020-01-02T19:15:07 <bitcoin-git> [bitcoin] sipa opened pull request #17850: Serialization improvements (minimal initial commits) (master...202001_noncastserial) https://github.com/bitcoin/bitcoin/pull/17850
4752020-01-02T19:15:09 <luke-jr> ok, so no real issues? :P
4762020-01-02T19:15:09 *** bitcoin-git has left #bitcoin-core-dev
4772020-01-02T19:15:09 *** promag has joined #bitcoin-core-dev
4782020-01-02T19:15:22 <luke-jr> (non-determinism isn't an issue IMO since it's built by the distro co)
4792020-01-02T19:15:25 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4802020-01-02T19:15:27 <wumpus> is there a ppa-like system for debian?
4812020-01-02T19:15:39 <luke-jr> wumpus: you can manually add repos, but nothing as easy as PPA AFAIK :/
4822020-01-02T19:15:49 <MarcoFalke> * The ppa is also updated only after the OS has been released, so upgrading the Ubuntu might lead to issues
4832020-01-02T19:15:51 <luke-jr> QuickBuild.io provides PPAs for Debian, but in my experience they don't work :/
4842020-01-02T19:16:05 <luke-jr> MarcoFalke: I don'
4852020-01-02T19:16:09 <luke-jr> MarcoFalke: I don't understand what you mean there
4862020-01-02T19:16:16 <MarcoFalke> * The ppa only supports one version of Bitcoin Core, so (not) updating Bitcoin Core might lead to issues
4872020-01-02T19:16:51 <wumpus> I'm interested in that problem, yes, auto-update kind of sucks for bitcoin
4882020-01-02T19:17:11 <wumpus> it should be a user decision to upgrade
4892020-01-02T19:17:11 <luke-jr> auto-update is the entire point of PPAs, though
4902020-01-02T19:17:13 <MarcoFalke> luke-jr: The ppa was only compiled for (let's say Ubuntu 18.04 after it has been released. I.e. Apr 18) So it is harder to install it for the Ubuntu Beta?
4912020-01-02T19:17:22 <wumpus> could we do better?
4922020-01-02T19:17:34 <luke-jr> MarcoFalke: not if we update the PPA timely
4932020-01-02T19:17:39 <wumpus> (apart from having a new package for every new release0
4942020-01-02T19:17:40 <jamesob> Wouldn't it be better just to provide a shell script that people can curl that builds from source than trying to cater to bad distro build infra?
4952020-01-02T19:18:00 <luke-jr> jamesob: eww, no
4962020-01-02T19:18:15 <achow101> MarcoFalke: is your suggestion that we also build debs and upload them to bitcoincore.org?
4972020-01-02T19:18:16 <wumpus> I mean ,we already have binary builds for linux
4982020-01-02T19:18:22 <wumpus> they should work on most distros
4992020-01-02T19:18:28 <wumpus> definitely debian and fedora
5002020-01-02T19:18:35 <luke-jr> I've been keeping an archive of PPA-generated .debs locally FWIW
5012020-01-02T19:18:52 <jamesob> Yeah, so what's wrong with saying "ppa build infra isn't up to our standards, so go to these other places"
5022020-01-02T19:18:54 <luke-jr> wumpus: they only work on Ubuntu in my experience; at least not on Gentoo
5032020-01-02T19:18:56 <wumpus> the only exception really is non-glibc
5042020-01-02T19:19:01 <MarcoFalke> luke-jr: Are you volunteering to update the PPA timely for the full matrix of distros/version of Bitcoin Core?
5052020-01-02T19:19:08 <luke-jr> jamesob: I see no problem w/ the build infra
5062020-01-02T19:19:28 <jamesob> didn't someone say the buids aren't reproducible?
5072020-01-02T19:19:31 <luke-jr> MarcoFalke: I can only update the PPA for Launchpad-supported distros, but yes, I have been and intend to continue updating it
5082020-01-02T19:19:37 <luke-jr> jamesob: neither is the rest of the OS
5092020-01-02T19:19:57 <luke-jr> jamesob: PPAs are Canonical built for Canonical distros
5102020-01-02T19:20:17 <wumpus> so anyway: what is the proposal here?
5112020-01-02T19:20:28 <MarcoFalke> And also, PPAs are not friendly for new users (novice linux users). E.g. I avoid them because it is easy to break the whole system with them.
5122020-01-02T19:20:39 <MarcoFalke> wumpus: My proposal is to have vanilla packages
5132020-01-02T19:20:46 <wumpus> how would you do that?
5142020-01-02T19:20:47 <MarcoFalke> in the vanilla package manager of the distro
5152020-01-02T19:21:00 <luke-jr> MarcoFalke: we explicitly advise distros NOT to do that..
5162020-01-02T19:21:04 <wumpus> that's up to the distros, right?
5172020-01-02T19:21:09 <luke-jr> also, that has the same problems as the PPA?
5182020-01-02T19:21:12 <MarcoFalke> luke-jr: Why?
5192020-01-02T19:21:38 <luke-jr> MarcoFalke: 1) their LevelDB packages don't meet consensus-safety standards, and they will not use embedded copies
5202020-01-02T19:22:01 <luke-jr> MarcoFalke: 2) they won't deploy even minor fixes to stable versions
5212020-01-02T19:22:04 <fanquake> Hi
5222020-01-02T19:22:25 * luke-jr looks up our advisement to see if there's anything else
5232020-01-02T19:22:49 <MarcoFalke> 1) We release versions of Bitcoin Core with different versions of leveldb. So the versioning shouldnt' be an issue. If the packaging is an issue, it can be changed, maybe
5242020-01-02T19:23:18 <wumpus> bleh, not using the embedded leveldb would really be inadvisable
5252020-01-02T19:23:27 <luke-jr> for reference, here was our 2013 advisement: http://luke.dashjr.org/tmp/code/20130723-linux-distribution-packaging-and-bitcoin.md.asc
5262020-01-02T19:23:53 <MarcoFalke> 2) Releasing new versions can be done with "backports", like it is done with clang-8 on Bionic Ubuntu and security fixes are alwasy deployed
5272020-01-02T19:24:07 <luke-jr> MarcoFalke: backports are no less trouble than PPAs
5282020-01-02T19:24:18 <luke-jr> PPAs are better because users already have them
5292020-01-02T19:24:25 <luke-jr> (for the initial install)
5302020-01-02T19:24:49 <luke-jr> also, the existence of bad PPAs doesn't mean *our* PPAs need to be bad; and not using a PPA ourselves doesn't make the bad ones go away
5312020-01-02T19:25:26 *** promag has quit IRC
5322020-01-02T19:25:34 <MarcoFalke> PPAs are bad pratice in general
5332020-01-02T19:25:55 <luke-jr> they aren't
5342020-01-02T19:26:32 <wumpus> I don't think PPAs are bad practice in general, not on ubuntu at least, installing them to other distros like debian is obviously bad
5352020-01-02T19:26:43 <MarcoFalke> And the bitcoin Core PPA is being used against best practices, so providing one is like encouraging those bad practices
5362020-01-02T19:27:15 <sipa> MarcoFalke: what do you mean by that (just curious, i know very little about them)
5372020-01-02T19:27:16 <luke-jr> yes, PPAs target a specific distro/release and shouldn't be used on others
5382020-01-02T19:27:16 <wumpus> in any case, I think we need to be really careful to reconsider the advisement
5392020-01-02T19:27:20 *** promag has joined #bitcoin-core-dev
5402020-01-02T19:28:06 <wumpus> we don't want zillions of nodes running years-old software by accident, not because they want to but just because there's no upgrade path
5412020-01-02T19:28:20 <MarcoFalke> sipa: PPAs are usually compiled for a specific OS version and might break things if installed on a different OS version. E.g. install an Bionic ppa on Ubuntu 19.10 or even Debian
5422020-01-02T19:28:22 <sipa> agreed
5432020-01-02T19:28:25 <luke-jr> distro packages are likely to end up with *new* users installing obsolete versions
5442020-01-02T19:29:16 <sipa> luke-jr: perhaps - but is that really the alternative? given things like snap/flatpak?
5452020-01-02T19:29:21 <wumpus> MarcoFalke: at least the ppa-add script avoids that, it will only add the ppa for the release that a user has
5462020-01-02T19:29:42 <MarcoFalke> Ok, so if the preference is to stick with PPAs, we should maintain them
5472020-01-02T19:29:47 <luke-jr> sipa: that's the topic ;)
5482020-01-02T19:30:14 <sipa> luke-jr: i think a reasonable conclusion could be that for our use case both distro packages and PPAs are bad
5492020-01-02T19:30:24 <luke-jr> sipa: PPAs aren't bad though.. :/
5502020-01-02T19:30:37 <luke-jr> yes, they're targetted, but that's kinda the point
5512020-01-02T19:30:38 <sipa> luke-jr: i said for our use case
5522020-01-02T19:30:40 <wumpus> I'm not convinced PPAs are really bad
5532020-01-02T19:30:52 <sipa> if they result in people running old unupgradable versions
5542020-01-02T19:31:00 <luke-jr> sipa: they don't
5552020-01-02T19:31:03 <wumpus> though I prefer people to use the deterministic binaries from bitcoincore.org
5562020-01-02T19:31:07 <luke-jr> PPAs can be updated for every release
5572020-01-02T19:31:20 <wumpus> but distro packages wouldn't improve that
5582020-01-02T19:31:27 <luke-jr> every Core release*
5592020-01-02T19:31:29 *** davterra has quit IRC
5602020-01-02T19:31:49 <MarcoFalke> Well, some people use curl $latest_release, so they end up with no upgrade path through $package_manager update
5612020-01-02T19:31:57 <luke-jr> sipa: for example, my PPA currently has 0.19.0.1 for every supported Ubuntu version; when 0.19.1 is out, it will get that for all versions too
5622020-01-02T19:31:58 <wumpus> no, PPAs (at least used to) be updated with every release of core
5632020-01-02T19:32:10 <sipa> ok
5642020-01-02T19:32:19 <MarcoFalke> So I don't really like the bitcoincore.org/bin/* either
5652020-01-02T19:32:32 <wumpus> the bitcoin/bitcoin ones are unmaintained at the moment but that's not a fault in PPA
5662020-01-02T19:32:52 <wumpus> well, nothing is ideal
5672020-01-02T19:32:56 <luke-jr> I suppose I could update bitcoin/bitcoin if Matt wants to give me access - I just figured it made more sense to retire it
5682020-01-02T19:33:03 <MarcoFalke> wumpus: True :)
5692020-01-02T19:33:17 <luke-jr> perhaps it should be updated with a .txt package saying to switch to another source
5702020-01-02T19:33:32 <wumpus> packaging bitcoin is a difficult issue
5712020-01-02T19:33:41 <MarcoFalke> luke-jr: It should be maintained in https://github.com/bitcoin-core/packaging
5722020-01-02T19:33:58 <luke-jr> (although it might be rude to effectively delete from users' PCs on an update)
5732020-01-02T19:34:06 <MarcoFalke> There is a debian subfolder, but no one has touched it in years: https://github.com/bitcoin-core/packaging/tree/master/debian
5742020-01-02T19:34:06 <achow101> I'm pretty sure lots of instructions point to the bitcoin/bitcoin ppa
5752020-01-02T19:34:07 <luke-jr> MarcoFalke: that's the source code, not the PPA
5762020-01-02T19:34:18 <achow101> and it would screw with people's existing installs from it
5772020-01-02T19:34:20 <luke-jr> MarcoFalke: I *think* I'm using it as-is still\
5782020-01-02T19:34:38 <wumpus> I think it would be better if someone took over maintenance of the current one instead of retire it
5792020-01-02T19:34:50 <luke-jr> maybe deleting the bitcoin/bitcoin PPA will work best - it won't uninstall anything, and will give the user an error when they update repos
5802020-01-02T19:35:09 <MarcoFalke> At least two people should have access (bus factor) or at least a way to reset the credentials
5812020-01-02T19:35:11 <wumpus> that's also not very friendly
5822020-01-02T19:35:23 <wumpus> yes
5832020-01-02T19:35:27 <MarcoFalke> And we should have documentation how to maintain it
5842020-01-02T19:35:36 <luke-jr> well, Matt isn't here, so we need to defer that discussion I think
5852020-01-02T19:35:56 <luke-jr> MarcoFalke: I have a gitian yml that updates it for me; I suppose I should add that to the packaging repo
5862020-01-02T19:36:05 <luke-jr> (it doesn't generate any files, just uploads)
5872020-01-02T19:36:41 <wumpus> yes, would be good to have the instructions public
5882020-01-02T19:37:48 <wumpus> any other topics?
5892020-01-02T19:38:37 <wumpus> #endmeeting
5902020-01-02T19:38:37 <lightningbot> Meeting ended Thu Jan 2 19:38:37 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5912020-01-02T19:38:37 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-02-19.00.html
5922020-01-02T19:38:37 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-02-19.00.txt
5932020-01-02T19:38:37 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-02-19.00.log.html
5942020-01-02T19:39:17 *** Highway61 has joined #bitcoin-core-dev
5952020-01-02T19:42:51 *** Guyver2 has joined #bitcoin-core-dev
5962020-01-02T19:45:22 *** molly has joined #bitcoin-core-dev
5972020-01-02T19:47:57 *** promag has quit IRC
5982020-01-02T19:48:45 *** mol has quit IRC
5992020-01-02T19:50:39 *** apex944 has joined #bitcoin-core-dev
6002020-01-02T19:55:11 *** apex944 has quit IRC
6012020-01-02T19:55:40 *** trotski2000_ has quit IRC
6022020-01-02T19:55:43 *** aqquadro has quit IRC
6032020-01-02T19:57:13 *** promag has joined #bitcoin-core-dev
6042020-01-02T20:01:57 *** promag has quit IRC
6052020-01-02T20:03:03 *** promag has joined #bitcoin-core-dev
6062020-01-02T20:04:40 *** promag has quit IRC
6072020-01-02T20:04:51 *** promag has joined #bitcoin-core-dev
6082020-01-02T20:23:03 *** promag has quit IRC
6092020-01-02T20:31:33 *** Highway61 has quit IRC
6102020-01-02T20:39:32 *** bitcoin-git has joined #bitcoin-core-dev
6112020-01-02T20:39:34 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/52900a764c42...190a4051fde7
6122020-01-02T20:39:34 <bitcoin-git> bitcoin/master 4d88c3d Wladimir J. van der Laan: net: Log to net category for exceptions in ProcessMessages
6132020-01-02T20:39:35 <bitcoin-git> bitcoin/master 4bdd68f Wladimir J. van der Laan: Add missing typeinfo includes
6142020-01-02T20:39:36 <bitcoin-git> bitcoin/master 190a405 Wladimir J. van der Laan: Merge #17762: net: Log to net category for exceptions in ProcessMessages
6152020-01-02T20:39:38 *** bitcoin-git has left #bitcoin-core-dev
6162020-01-02T20:39:52 *** bitcoin-git has joined #bitcoin-core-dev
6172020-01-02T20:39:52 <bitcoin-git> [bitcoin] laanwj merged pull request #17762: net: Log to net category for exceptions in ProcessMessages (master...2019_12_network_exceptions) https://github.com/bitcoin/bitcoin/pull/17762
6182020-01-02T20:39:54 *** bitcoin-git has left #bitcoin-core-dev
6192020-01-02T20:40:42 *** promag has joined #bitcoin-core-dev
6202020-01-02T20:42:36 *** justanotheruser has quit IRC
6212020-01-02T20:45:46 *** promag has quit IRC
6222020-01-02T20:58:54 *** guest534543 has joined #bitcoin-core-dev
6232020-01-02T21:00:01 *** drewx2 has quit IRC
6242020-01-02T21:01:38 *** bitcoin-git has joined #bitcoin-core-dev
6252020-01-02T21:01:38 <bitcoin-git> [bitcoin] practicalswift opened pull request #17851: tests: Add std::to_string to list of locale dependent functions (master...locale-dependence-of-to_string) https://github.com/bitcoin/bitcoin/pull/17851
6262020-01-02T21:01:39 *** bitcoin-git has left #bitcoin-core-dev
6272020-01-02T21:01:44 *** Kiminuo has quit IRC
6282020-01-02T21:04:04 *** justanotheruser has joined #bitcoin-core-dev
6292020-01-02T21:08:06 *** dviola has quit IRC
6302020-01-02T21:09:38 *** vincentpalazzo has quit IRC
6312020-01-02T21:11:23 *** Talkless has quit IRC
6322020-01-02T21:15:25 *** Highway61 has joined #bitcoin-core-dev
6332020-01-02T21:17:57 *** paulk1 has joined #bitcoin-core-dev
6342020-01-02T21:21:38 *** cryptapus has joined #bitcoin-core-dev
6352020-01-02T21:21:38 *** cryptapus has quit IRC
6362020-01-02T21:21:38 *** cryptapus has joined #bitcoin-core-dev
6372020-01-02T21:27:53 *** promag has joined #bitcoin-core-dev
6382020-01-02T21:31:53 *** promag has quit IRC
6392020-01-02T21:33:53 *** justanotheruser has quit IRC
6402020-01-02T21:40:43 *** vasild has quit IRC
6412020-01-02T21:42:33 *** vasild has joined #bitcoin-core-dev
6422020-01-02T21:45:43 *** Guyver2 has quit IRC
6432020-01-02T21:49:38 *** guest534543 has quit IRC
6442020-01-02T21:54:26 *** justanotheruser has joined #bitcoin-core-dev
6452020-01-02T22:05:26 *** apex944 has joined #bitcoin-core-dev
6462020-01-02T22:06:02 *** promag has joined #bitcoin-core-dev
6472020-01-02T22:13:03 *** promag has quit IRC
6482020-01-02T22:18:14 *** Chris_Stewart_5 has quit IRC
6492020-01-02T22:28:34 *** promag has joined #bitcoin-core-dev
6502020-01-02T22:29:07 *** paultroon has quit IRC
6512020-01-02T22:36:28 *** apex944 has quit IRC
6522020-01-02T22:48:17 *** luke-jr has quit IRC
6532020-01-02T22:49:48 *** paultroon has joined #bitcoin-core-dev
6542020-01-02T22:51:51 *** luke-jr has joined #bitcoin-core-dev
6552020-01-02T22:52:53 *** bitcoin-git has joined #bitcoin-core-dev
6562020-01-02T22:52:54 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/190a4051fde7...17e14ac92fce
6572020-01-02T22:52:55 <bitcoin-git> bitcoin/master 6666ef1 MarcoFalke: test: Properly document blockinfo size in miner_tests
6582020-01-02T22:52:56 <bitcoin-git> bitcoin/master faa92a2 MarcoFalke: rpc: Remove mempool global from miner
6592020-01-02T22:52:56 <bitcoin-git> bitcoin/master 17e14ac MarcoFalke: Merge #17781: rpc: Remove mempool global from miner
6602020-01-02T22:52:58 *** bitcoin-git has left #bitcoin-core-dev
6612020-01-02T22:53:13 *** bitcoin-git has joined #bitcoin-core-dev
6622020-01-02T22:53:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17781: rpc: Remove mempool global from miner (master...1912-mempoolMiner) https://github.com/bitcoin/bitcoin/pull/17781
6632020-01-02T22:53:14 *** bitcoin-git has left #bitcoin-core-dev
6642020-01-02T22:54:23 *** paultroon has quit IRC
6652020-01-02T23:04:26 *** apex944 has joined #bitcoin-core-dev
6662020-01-02T23:09:20 *** apex944 has quit IRC
6672020-01-02T23:13:38 *** turbo_choo has quit IRC
6682020-01-02T23:41:21 *** justanotheruser has quit IRC
6692020-01-02T23:42:07 *** mdunnio has quit IRC
6702020-01-02T23:48:13 *** marcoagn1 has quit IRC
6712020-01-02T23:55:17 *** Chris_Stewart_5 has joined #bitcoin-core-dev